1 2007-06-25 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (libmodest_dbus_client_search),
5 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
6 instead of 1 second, because the search gets folders and messages from
7 the server, which can take a long time. When it times out,
8 osso-global-search will report no results.
10 We need to specify whether we should search only cached information
11 (maybe with a user preference), and the osso-email-search-plugin
12 API should really be improved to allow that option, and to allow results
13 to be delivered asynchronously in batches.
15 2007-06-25 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
18 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
19 GTK_ICON_SIZE_DIALOG is probably the wrong size.
21 2007-06-25 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
24 that is an empty string. D-Bus seems to give us these instead of NULL.
26 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
28 * src/dbus_api/modest-dbus-callbacks.c:
29 * src/maemo/easysetup/modest-easysetup-wizard.h:
30 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
31 * src/maemo/modest-connection-specific-smtp-edit-window.c:
32 (modest_connection_specific_smtp_edit_window_init):
33 * src/maemo/modest-maemo-global-settings-dialog.c:
35 * src/maemo/modest-maemo-utils.c:
36 (modest_maemo_utils_setup_images_filechooser):
37 * src/maemo/modest-main-window.c: (create_details_widget):
38 * src/maemo/modest-msg-edit-window.c:
39 (modest_msg_edit_window_attach_file_noninteractive),
40 (modest_msg_edit_window_color_button_change),
41 (modest_msg_edit_window_set_zoom):
42 * src/modest-mail-operation.c: (update_account_thread):
43 * src/modest-tny-account-store.c:
44 * src/modest-tny-account.c:
45 * src/widgets/modest-global-settings-dialog.c:
46 * src/widgets/modest-window.h:
50 2007-06-25 Murray Cumming <murrayc@murrayc.com>
52 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
53 * src/modest-search.c: (modest_search_folder),
54 (modest_search_all_accounts): Actually search only in the specified folder,
55 doing a simple match on the folder ID.
56 * src/modest-search.h: Added a folder field to the ModestSearch struct,
57 and added some documentation.
59 2007-06-22 Armin Burgmeier <armin@openismus.com>
61 * src/maemo/modest-maemo-utils.h:
62 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
63 modest_maemo_utils_get_supported_secure_authentication_methods.
65 * src/maemo/easysetup/modest-easysetup-wizard.c:
66 * src/maemo/modest-account-settings-dialog.c: Show correct error if
67 one occured, not just "Server does not support secure authentication".
69 2007-06-22 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-tny-account-store.c: (get_password):
72 Restored the call to tny_account_set_user() because Philip seems to have
73 stopped this from crashing (by not using the freed string). It still does
74 not work, but now we can test it.
76 2007-06-22 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-msg-edit-window.c: (init_window):
79 Comment out use of an uninitialzed GtkScrolledWindow variable,
80 to fix the build and stop a crash. Yet again.
82 2007-06-22 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-tny-account-store.c: (get_password):
85 Remove the call to tny_account_set_user() because this actually crashes.
86 As mentioned in the last commit, it is known to not work anyway.
88 2007-06-22 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-tny-account-store.c: (get_password):
91 Use tny_account_set_username() to tell tinymail that the username might
92 have changed too. But tinymail ignores this: see projects.maemo.org
94 * src/modest-ui-actions.c:
95 (modest_ui_actions_on_password_requested): Remove the useless attempt to
96 reset the connection when changing the username, and improve the comments.
97 Save the changed username to gconf at least, so it is used when Modest is
100 2007-06-21 Murray Cumming <murrayc@murrayc.com>
102 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
103 Do not use a query, so that we get all folders, including for POP and
104 local-folders. They work as search criteria too.
105 This fixes projects.maemo.org bug NB#57740.
107 2007-06-21 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
110 Comment out the use of hildon_notification_set_sound() because it is
111 not declared, to fix the build. Warnings are serious, people.
113 2007-06-21 Armin Burgmeier <armin@openismus.com>
115 * src/maemo/modest-maemo-utils.h:
116 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
117 modest_maemo_utils_get_supported_secure_authentication_methods()
118 to query authentication methods for a specific user. This should fix
119 projects.maemo.org bug NB#61369.
121 * src/maemo/easysetup/modest-easysetup-wizard.c:
122 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
125 2007-06-21 Murray Cumming <murrayc@murrayc.com>
127 * libmodest-dbus-client/libmodest-dbus-client.h:
128 * libmodest-dbus-client/libmodest-dbus-client.c:
129 (modest_dbus_message_iter_get_search_hit),
130 (libmodest_dbus_client_search):
131 Reorganised and commented this.
132 Removed modest_search_hit_free() from the public API because it
135 Added libmodest_dbus_client_get_folders() and
136 modest_folder_result_list_free().
138 * src/dbus_api/modest-dbus-api.h:
139 * src/dbus_api/modest-dbus-callbacks.c:
140 (modest_dbus_req_filter): Commented. Moved most code to
141 on_dbus_method_search() and added on_dbus_method_get_folders().
143 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
144 of the extra D-Bus handler.
146 * tests/dbus_api/Makefile.am:
147 * tests/dbus_api/test_get_folders.c: New test for
148 libmodest_dbus_client_get_folders(). This seems to return an empty list
149 at the moment. That could be the same error that causes the message list
150 to be empty sometimes.
151 This should help with projects.maemo.org bug NB#57740.
153 2007-06-21 Armin Burgmeier <armin@openismus.com>
155 * src/modest-mail-operation.c: Do not call
156 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
157 notify the operation's end after having set the status to CANCELED for
158 the operation queue to listen on. This fixes a deadlock when there
159 were mail operations in the queue during its finalization.
161 * src/modest-singletons.c: Reordered uninitialization of the account
162 manager to happen after the mail operation queue was uninitialized
163 because the mail operation's in the queue might still try to access
164 the account manager (see modest_mail_operation_notify_end()). This
165 fixes a potential crash when terminating the application.
167 2007-06-21 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-search.c:
170 (search_mime_part_and_child_parts): Moved some code here so we
171 can search recursively in child folders.
172 (modest_search_folder): Search in the message as a mime part, instead
173 of just its child mime parts.
174 (read_chunk), (search_mime_part_ogs):
175 Check how many bytes were read, to prevent an endless loop.
176 Searching in message bodies now works. This finishes the fix for
177 projects.maemo.org bug NB#61007.
179 2007-06-20 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
182 Add a g_warning when the item is not a folder.
184 * src/modest-ui-dimming-rules.c:
185 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
186 when selected item is not a folder (for instance, an account), because
187 the UI spec only talks about folders.
188 I am not sure what the UI spec wants, so this might not totally fix
189 projects.maemo.org bug NB#60794.
191 2007-06-20 Murray Cumming <murrayc@murrayc.com>
193 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
194 (load_from_file): Sort the list. The unsorted list would be more noticeable
195 in non-English locales.
197 * src/maemo/modest-msg-edit-window.c:
198 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
199 warning and fix the build.
201 * src/maemo/modest-progress-bar-widget.c:
202 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
203 avoid a g_warning, and probably to avoid a crash.
205 2007-06-20 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-search.c: (modest_search_folder): Check for a GError
208 when calling tny_folder_get_headers(), to show that this is not the cause
211 2007-06-20 Murray Cumming <murrayc@murrayc.com>
213 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
214 Actually set the body query instead of the subject query.
216 * src/modest-search.c: (search_mime_part_ogs),
217 (search_mime_part_strcmp): Remove extra space from the text/* regex,
218 which would probably cause it to fail if we got this far.
220 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
221 to simplify the code.
222 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
223 be causing search-in-body to fail.
225 2007-06-20 Murray Cumming <murrayc@murrayc.com>
227 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
229 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
230 Better debug message when the folder cannot be found.
231 This should help with fixing projects.maemo.org bug #61287.
232 * src/modest-search.c: (add_hit): Do not leak the furl string.
234 2007-06-20 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-ui-actions.c:
237 (modest_ui_actions_on_folder_selection_changed):
238 Do not special-case TNY_MERGE_FOLDER here, because
239 modest_tny_folder_get_account() already does that. This fixes
240 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
241 shown when the Outbox was selected).
243 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
245 * libmodest-dbus-client/libmodest-dbus-client.c:
246 (_dbus_iter_get_string_or_null): Initialize the string variable in
247 case this helps with Dirk's crash.
249 2007-06-19 Murray Cumming <murrayc@murrayc.com>
251 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
252 though it is not implemented yet (this function is maybe not even used),
253 to avoid breaking ABI in future.
254 * libmodest-dbus-client/libmodest-dbus-client.c:
255 (get_attachments_string): Moved some code into this generic function.
256 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
257 sends email. It is maybe not used.
258 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
259 (on_send_mail): Use attachments.
261 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
262 * src/maemo/modest-msg-edit-window.c:
263 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
264 a filename before using it, to fix projects.maemo.org bug NB#58233.
266 2007-06-19 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
269 Initialize the continue_download variable to fix the build, and probably
270 to fix randome behaviour.
272 2007-06-18 Armin Burgmeier <armin@openismus.com>
274 * src/modest-tny-send-queue.h:
275 * src/modest-tny-send-queue.c: Keep track of the status of messages in
276 the queue so we can later show it in the UI. Replaced
277 modest_tny_send_queue_msg_is_being_sent() by
278 modest_tny_send_queue_get_msg_status().
280 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
282 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
283 gpointer. This probably was not harmful, but just to be sure.
285 2007-06-18 Murray Cumming <murrayc@murrayc.com>
287 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
288 Fix the build, but leave the function broken on Bora, because
289 hildon_uri_action_get_service() does not exist.
290 osso_uri_action_get_service() does not exist either, it seems.
292 2007-06-18 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-tny-account.c:
295 (modest_tny_account_new_from_server_account):
296 Uncommented the url debug output again, because it is useful for
297 debugging, as I said in the comment.
299 2007-06-18 Murray Cumming <murrayc@murrayc.com>
301 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
303 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
304 for Mameo Bora, to fix the build.
306 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
309 Fixed build with hildon < 0.99
311 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
312 Check if the selected account is busy instead of checking all accounts
314 * src/modest-account-mgr-priv.h:
315 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
316 (modest_account_mgr_init), (compare_account_name),
317 (modest_account_mgr_set_account_busy),
318 (modest_account_mgr_account_is_busy):
319 * src/modest-account-mgr.h:
320 Added busy information to the account manager. It possible to
321 set an account to busy or not busy now.
323 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
324 (modest_mail_operation_update_account),
325 (modest_mail_operation_notify_end):
326 Set the account to busy/not busy depending on the operation state.
328 * src/widgets/modest-account-view.c:
329 (modest_account_view_finalize), (get_last_updated_string),
330 (update_account_view), (on_account_busy_changed), (init_view):
331 Show string "Refreshing..." if the account is currently busy.
333 All this fixes projects.maemo.org bug NB#59711
335 2007-06-14 Armin Burgmeier <armin@openismus.com>
337 * src/widgets/modest-attachments-view.h:
338 * src/widgets/modest-attachments-view.c: Added
339 modest_attachments_view_has_attachments() and fixed coordinate
340 transformation in get_att_view_at_coords(). This fixes attachment
343 * src/widgets/modest-msg-view.c: Make use of
344 modest_attachments_view_has_attachments() to decide whether to show
345 attachments in the header.
347 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
350 (on_change), (on_combo_security_changed),
351 (modest_connection_specific_smtp_edit_window_init),
352 (modest_connection_specific_smtp_edit_window_set_connection),
353 (modest_connection_specific_smtp_edit_window_is_dirty):
354 * src/maemo/modest-connection-specific-smtp-edit-window.h:
355 * src/maemo/modest-connection-specific-smtp-window.c:
358 Show an comfirmation dialog for the smpt-edit-window if there are
359 unsaved changes and the user hits cancel.
360 (projects.maemo.org bug NB#60479)
362 2007-06-14 Armin Burgmeier <armin@openismus.com>
364 * src/maemo/easysetup/modest-easysetup-wizard.c:
365 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
366 address" info in banner instead of node, and select all the text as
367 per UI spec. This fixes projects.maemo.org bug NB#60550.
369 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
371 reviewed by: <delete if not using a buddy>
373 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
374 * src/modest-ui-actions.c: (folder_refreshed_cb):
376 2007-06-14 Murray Cumming <murrayc@murrayc.com>
378 * src/widgets/modest-folder-view.c: (filter_row):
379 Explictly filter out the per-account outbox accounts. I don't know why
380 these only sometimes show up, but now they should never show up in the UI.
381 This should fix projects.maemo.org bug NB#60160.
383 2007-06-14 Murray Cumming <murrayc@murrayc.com>
385 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
386 when the toolbar does not exist yet.
387 * src/modest-widget-memory.c: (save_settings_header_view):
388 Added g_warnings() to help us to discover when we are trying to set
389 an empty columns list in gconf.
391 2007-06-14 Murray Cumming <murrayc@murrayc.com>
395 Added modest_init_get_default_header_view_column_ids().
397 * src/modest-widget-memory.c: (restore_settings_header_view):
398 Use the new function to get defaults, if the gconf key is empty,
399 instead of not creating any columns. This seems to fix the
400 empty right-hand pane problems.
402 * src/widgets/modest-header-view.h: Improved documentation.
404 2007-06-13 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
407 Revert the use of the display name as the account name, because this
408 is generally wrong and would break the code that follows.
410 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
412 * src/maemo/easysetup/modest-easysetup-wizard.c:
413 (check_for_supported_auth_methods), (on_before_next),
416 More correct fix for projects.maemo.org bug NB# 58991
417 Do not longer accept AUTH_PASSWORD as secure method and choose
418 correct method when creating the account.
420 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
422 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
423 Fixed projects.maemo.org bug NB# 58991
425 2007-06-13 Murray Cumming <murrayc@murrayc.com>
427 * src/modest-init.c: (modest_init_init_core),
428 (modest_init_local_folders): Fixed compilation errors.
430 2007-06-13 Murray Cumming <murrayc@murrayc.com>
432 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
433 Remove unnecessary lib/include, though it is good in principle when needed.
435 * src/modest-init.c: (modest_init_one_local_folder),
436 (modest_init_local_folders):
437 * src/modest-init.h: Initialize the .modest library for memory cards,
438 instead of just doing nothing for them. This should allow us to create
439 folders there, fixing projects.maemo.org bug NB#59297.
441 2007-06-13 Murray Cumming <murrayc@murrayc.com>
443 * libmodest-dbus-client/libmodest-dbus-client.c:
444 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
445 (libmodest_dbus_client_compose_mail),
446 (libmodest_dbus_client_open_message),
447 (libmodest_dbus_client_send_and_receive),
448 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
450 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
451 (on_idle_open_message), (modest_dbus_req_handler),
452 (search_result_to_message), (modest_dbus_req_filter):
453 * src/modest-search.c: (add_hit), (modest_search_folder),
454 (modest_search_all_accounts): Improved debug messages.
456 * tests/dbus_api/test_open_message.c: (main): Improved comments.
458 * src/modest-tny-account-store.c:
459 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
462 2007-06-13 Murray Cumming <murrayc@murrayc.com>
465 2007-06-12 Murray Cumming <murrayc@murrayc.com>
467 * src/modest-tny-account-store.c: (get_server_accounts):
468 Call modest_tny_local_folders_account_add_merged_outbox_folders()
469 even when there are no accounts, so that the Outbox folder is always
470 visible. This fixes projects.maemo.org bug NB#60158.
472 2007-06-12 Murray Cumming <murrayc@murrayc.com>
474 * src/maemo/modest-main-window.c: (create_details_widget):
475 Use the mcen_va_never logical ID.
477 2007-06-12 Murray Cumming <murrayc@murrayc.com>
479 * src/dbus_api/modest-dbus-api.h:
480 * src/dbus_api/modest-dbus-callbacks.c:
481 (on_idle_open_default_inbox), (on_open_default_inbox),
482 (modest_dbus_req_handler):
483 Added a new OpenDefaultInbox method.
485 * libmodest-dbus-client/libmodest-dbus-client.h:
486 * libmodest-dbus-client/libmodest-dbus-client.c:
487 Added libmodest_dbus_client_open_default_inbox() to call the new
488 dbus method. This should be useful to projects.maemo.org bug NB#57214,
489 though it should maybe be used by a new osso-email-interface function.
491 * tests/dbus_api/Makefile.am:
492 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
495 2007-06-12 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
498 NULL, so that the signals get all the keys. This should not actually
499 change any behaviour because we currently update everything when anything
502 2007-06-12 Murray Cumming <murrayc@murrayc.com>
504 * src/widgets/modest-folder-view.c: (text_cell_data),
505 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
506 (find_inbox_iter): If tinymail tells us that the folder is
507 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
508 This causes the inbox to be selected at startup, fixing part of
509 projects.maemo.org bug NB#56305.
511 * src/modest-ui-dimming-rules.c:
512 (modest_ui_dimming_rules_on_tools_smtp_servers):
513 * src/modest-ui-dimming-rules.h: Added a callback function to dim
514 the SMTP servers menu item.
515 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
516 that the SMTP Servers menu item is dimmed when there are no accounts,
517 as a future version of the UI spec will require. This fixes
518 projects.maemo.org bug NB#56305.
520 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
522 * src/maemo/modest-maemo-utils.c:
523 (modest_maemo_utils_get_supported_secure_authentication_methods):
524 Added label to dialog instead of unreadable title
526 * src/maemo/modest-main-window.c: (sync_accounts_cb),
527 (modest_main_window_new):
528 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
531 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
532 * src/modest-account-mgr.h:
533 Added method to avoid code duplication
535 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
536 (modest_ui_actions_on_send_receive):
537 Use modest_account_mgr_has_accounts
539 2007-06-11 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/easysetup/modest-presets.c:
542 (modest_presets_get_info_server_security): Do not report secure auth
544 * src/modest-protocol-info.c: Use the defines for the gconf key names
545 for secure authentication. This was not working because we were writing
546 Password and reading password, and the check was case sensitive.
547 With this, gmail now works for receiving and sending when created via
550 2007-06-11 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/easysetup/modest-presets.c:
553 (modest_presets_get_info_server_security): Correct the key name for
554 SecureSmtp, because it seems to be case-sensitive.
555 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
556 Do not try to get the 0th notebook page if there are 0 pages, to
559 2007-06-11 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
562 Prevent use of the new notification feature for now, because it currently
563 shows one dialog for each new email, which is annoying.
565 2007-06-11 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
568 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
569 when no country was selected, so that we show the global ones.
570 * src/maemo/easysetup/modest-presets.c:
571 (modest_presets_get_providers): Return only the global providers, not
572 all providers when mmc=0 was requested.
574 2007-06-11 Murray Cumming <murrayc@murrayc.com>
576 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
577 (easysetup_provider_combo_box_fill): Remove debug code that showed the
578 provider ID in the combo.
580 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
581 Do not show the page numbers, because it would be confusing when we add
582 the 2 extra pages for the custom setup, when the user chooses the "Other"
583 provider. This fixes projects.maemo.org bug NB#59028
585 * src/modest-init.c: (modest_init_init_core),
586 (modest_init_local_folders):
588 * src/modest-tny-account.c:
589 (modest_tny_account_new_for_local_folders): Do not create default folders
590 for the memory card. This should fix projects.maemo.org bug NB#59328.
592 2007-06-11 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
595 Free the changed_conf_keys string items. They are already freed in the
596 idle handler if that runs first.
598 2007-06-11 Murray Cumming <murrayc@murrayc.com>
600 * src/modest-ui-actions.c:
601 (modest_ui_actions_on_password_requested): Check that the server name
602 is not NULL, because I just saw a password dialog with (null) as the
605 * src/modest-tny-folder.[h|c]: Added
606 modest_tny_folder_is_memory_card_folder().
607 * src/modest-ui-dimming-rules.c:
608 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
609 menu item for memory cards, as per the UI spec (section 7.4). This should
610 fix projects.maemo.org bug NB#59297.
612 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
614 * src/maemo/modest-main-window.c: (sync_accounts_cb):
615 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
616 is another problem with the code, see Murray's comment at line 772)
618 2007-06-08 Murray Cumming <murrayc@murrayc.com>
620 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
621 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
622 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
623 (load_from_file), (easysetup_country_combo_box_init),
624 (easysetup_country_combo_box_get_active_country_ids),
625 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
626 instead of just one ID, to avoid duplicate country names in the UI.
628 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
629 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
630 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
631 a single ID, avoiding duplicate providers.
632 * src/maemo/easysetup/modest-easysetup-wizard.c:
633 (on_combo_account_country): Adapt to use a list.
635 2007-06-08 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
638 keys changed in the last X seconds.
640 * src/modest-account-mgr.h:
641 * src/modest-account-mgr.c: (on_timeout_notify_changes),
642 (on_key_change), (modest_account_mgr_class_init),
643 (modest_account_mgr_init), (modest_account_mgr_finalize):
644 As the keys are changed, save them in a GSList* and signal that GSList*
645 further every X seconds, to batch changes, to allow us to do just one
646 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
647 bug NB#56941 and other (UI-blocking) delays when changing account settings.
649 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
650 changed signal signature.
652 * src/modest-conf.c: (modest_conf_set_list),
653 (modest_conf_on_change): Reenable notification.
655 (modest_conf_maemo_fake_on_change): Comment out the hack that
656 notified immediately instead of asynchronously.
658 * src/widgets/modest-account-view.h:
659 * src/widgets/modest-account-view.c:
660 (update_account_view): Select the previously-selected account ID,
661 if possible. This fixes projects.maemo.org bug NB#56933.
663 (on_account_changed), (on_account_removed),
664 (modest_account_view_select_account):
666 Remove the block/unblock functions
667 because they were not useful.
669 * src/maemo/modest-account-view-window.c:
670 (on_delete_button_clicked), (on_edit_button_clicked),
671 (on_new_button_clicked): Remove the use of the non-working block/unblock.
673 2007-06-08 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
676 Improve the error dialog to show Incorrect Account Settings, which seems
677 clearer, and say that the internal error message (to be removed from the
678 dialog later) is often misleading.
679 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
681 * src/modest-tny-account.c:
682 (modest_tny_account_new_from_server_account): Uncomment the printf of the
683 URL because this is so useful for debugging on the device.
685 * src/widgets/modest-serversecurity-combo-box.c:
686 (modest_serversecurity_combo_box_fill): Correct a logical ID.
688 2007-06-08 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-mail-operation.c:
691 (modest_mail_operation_send_new_mail):
692 Added a comment about a nasty but apparently harmless message. Details
693 added to the wiki g_warnings() page.
695 2007-06-08 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
698 (modest_tny_send_queue_class_init):
699 Do not use the priv struct because it is empty, to avoid g_warnings
700 about a non-existant priv struct.
702 * src/modest-tny-account-store.c:
703 (modest_tny_account_store_get_server_account),
704 (modest_tny_account_store_get_transport_account_for_open_connection
705 ): Do not try to get transport server accounts for local folders,
706 because they don't have any. This avoids a g_warning().
708 * src/maemo/modest-main-window.c:
709 (modest_main_window_notify_send_receive_initied),
710 (on_configuration_key_changed):
711 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
713 * src/modest-mail-operation.c:
714 (modest_mail_operation_update_account):
715 * src/modest-tny-account-store.h:
716 * src/modest-tny-account.c:
717 (modest_tny_account_get_special_folder),
718 (modest_tny_account_new_for_local_folders),
719 (modest_tny_account_new_for_per_account_local_outbox_folder):
720 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
721 * src/modest-tny-local-folders-account.c:
722 (add_account_folders_to_merged_folder):
723 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
724 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
725 (modest_ui_actions_on_send):
726 * src/widgets/modest-folder-view.c: (update_model):
727 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
728 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
729 modest_tny_account_store_get_tny_account_by_account() to
730 modest_tny_account_store_get_server_account() to make the code clearer.
732 2007-06-07 Marcus Bauer <marcusb@openismus.com>
734 * src/dbus_api/modest-dbus-api.h:
735 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
736 * src/maemo/modest-msg-edit-window.c:
737 (modest_msg_edit_window_attach_file_noninteractive):
738 added g_warning in case the file to be attached does not exist
739 * tests/dbus_api/test_compose_mail.c: (main):
740 removed obsolete comment, added generic files as test case
742 2007-06-07 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-tny-account-store.c: (get_server_accounts):
745 Create the local folders account only once, not once for each outbox, and
746 not only when there are some outboxes.
748 2007-06-07 Murray Cumming <murrayc@murrayc.com>
750 * src/widgets/modest-folder-view.c: (update_model): Comment out some
751 code that is causing a crash at startup. Sergio says that he is fixing this.
753 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
755 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
756 * src/maemo/modest-account-settings-dialog.c:
757 (create_page_outgoing),
758 (modest_account_settings_dialog_set_account_name),
759 (save_configuration):
760 - Fixed handling of the "Use secure authentication" toggle to comply with
761 the ui specification. See also projects.maemo.org bug NB#58400
763 - Restore the Secure connection setting combo correctly when loading
766 * src/maemo/modest-maemo-utils.c:
767 (on_camel_account_get_supported_secure_authentication),
768 (modest_maemo_utils_get_supported_secure_authentication_methods):
769 Fixed a crasher if operation is canceled
771 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
772 (modest_protocol_info_auth_is_secure):
773 * src/modest-protocol-info.h:
775 Added two new methods to determine if a protocol/auth method is secure/encrypted in
776 the sense of the "Use secure authentication" toggle.
778 2007-06-07 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-account-store.h:
781 * src/modest-tny-account-store.c:
782 Added modest_tny_account_store_get_local_folders_account().
784 * src/modest-tny-folder.h:
785 * src/modest-tny-folder.c:
786 (modest_tny_folder_get_account):
787 Added this replacement for tny_folder_get_account() which returns
788 the local-folders account for TnyMergeFolders, to avoid the
789 warning about the unimplemented get_account_func() vfunc().
791 (modest_tny_folder_get_rules),
792 * src/modest-ui-actions.c:
793 (modest_ui_actions_on_folder_selection_changed):
794 * src/modest-mail-operation.c:
795 (modest_mail_operation_remove_folder),
796 (modest_mail_operation_xfer_folder),
797 (modest_mail_operation_rename_folder),
798 (modest_mail_operation_get_msg),
799 (modest_mail_operation_get_msgs_full),
800 (modest_mail_operation_remove_msg),
801 (modest_mail_operation_xfer_msgs),
802 (modest_mail_operation_refresh_folder):
803 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
805 2007-06-07 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
808 (modest_server_account_set_security):
809 * src/modest-defs.h: Add comments explaining that our
810 UI spec means TLS when it says Normal, so these do not look like errors.
812 * src/modest-tny-account.c:
813 (modest_tny_account_new_from_server_account): Use the new tinymail
814 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
815 for TLS. This should fix projects.maemo.org bug NB#58460.
817 2007-06-06 Murray Cumming <murrayc@murrayc.com>
819 * src/maemo/easysetup/modest-easysetup-wizard.c:
820 (create_account): Correct the position of the gconf sanity check warning.
821 (on_button_edit_advanced_settings): Show the dialog immediately, instead
822 of using the g_idle_add() hack, because this does not seem to be necessary
823 on osso 1.1. It might even work on Maemo Bora if the problems were actually
824 caused by something other than maemo's gconf.
825 This fixes projects.maemo.org bug #59022.
827 2007-06-06 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-account-mgr-helpers.c:
830 (modest_account_mgr_get_default_account): Do not check that the account
831 exists if there is no default account (NULL), to fix a runtime warning.
833 2007-06-06 Murray Cumming <murrayc@murrayc.com>
835 * src/widgets/modest-folder-view.c: (update_model):
836 Do not unref the treemodel before we have finished with it.
837 This prevents a valgrind warning and an occasional crash at startup.
839 2007-06-06 Marcus Bauer <marcusb@openismus.com>
841 * libmodest-dbus-client/libmodest-dbus-client.h:
842 added libmodest_dbus_client_compose_mail()
843 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
845 added functions needed for SendAsMail() functionality
846 * src/maemo/modest-msg-edit-window.c:
847 (modest_msg_edit_window_attach_file_noninteractive):
848 non interactively attaching files to message edit window
849 * src/widgets/modest-msg-edit-window.h:
850 * tests/dbus_api/Makefile.am:
851 added test_compose_mail.c
852 * tests/dbus_api/test_compose_mail.c: (main):
854 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
856 * src/modest-account-view.c:
857 Fixed bug projects.maemo.org bug NB#59307
859 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
861 * src/maemo/easysetup/modest-easysetup-wizard.c:
862 (get_serverport_incoming), (on_before_next), (create_account):
863 * src/maemo/modest-account-settings-dialog.c:
864 (modest_account_settings_dialog_set_account_name):
865 * src/maemo/modest-maemo-utils.c:
866 (on_camel_account_get_supported_secure_authentication_status),
867 (on_camel_account_get_supported_secure_authentication),
868 (on_secure_auth_cancel),
869 (modest_maemo_utils_get_supported_secure_authentication_methods):
871 Implemented security authentication for settings and easysetup.
873 2007-06-05 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/modest-main-window.c: (create_details_widget):
876 Show the total size for memory card accounts too, instead of showing
877 the name again. Fixes bug projects.maemo.org bug NB#59307.
879 2007-06-05 Murray Cumming <murrayc@murrayc.com>
882 * src/modest-tny-simple-folder-store.c:
883 * src/modest-tny-simple-folder-store.h: Removed.
885 * src/modest-tny-local-folders-account.h
886 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
887 for the local-folders maildir, with an extra TnyMergedFolder containing
888 the folders of the per-account outbox store accounts.
889 * src/modest-tny-account-store.c: (get_server_accounts):
890 Add the outboxes to the special local folders account after creating it.
892 * src/modest-tny-account.c:
893 (modest_tny_account_new_for_local_folders): Create the derived
894 account when creating the main local-folders account.
896 * src/maemo/modest-main-window.c: (create_details_widget),
897 (modest_main_window_set_contents_style):
898 Adapted to the use of the derived account instead of the folder store.
900 * src/modest-ui-actions.c:
901 (modest_ui_actions_on_folder_selection_changed):
902 * src/modest-ui-dimming-rules.c:
903 (modest_ui_dimming_rules_on_new_folder):
904 * src/widgets/modest-folder-view.c: (text_cell_data),
905 (icon_cell_data), (filter_row), (update_model),
906 (get_cmp_rows_type_pos):
909 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
910 Do not get the priv struct, because no priv struct has been set,
911 to avoid a runtime warning.
913 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
914 #ifelse with #else, to fix a warning, to fix the build.
917 2007-06-05 Christian Kellner <ckellner@openismus.com>
919 * libmodest-dbus-client/libmodest-dbus-client.c:
920 Fix small typo in doc (why do you always see them
921 AFTER committing stuff?)
924 2007-06-05 Christian Kellner <ckellner@openismus.com>
926 * libmodest-dbus-client/libmodest-dbus-client.c:
927 (libmodest_dbus_client_search):
928 Initialize hit list with NULL. Also set folder list
929 to "" if NULL was supplied.
932 2007-06-03 Christian Kellner <ckellner@openismus.com>
934 * libmodest-dbus-client/libmodest-dbus-client.c:
935 (modest_search_hit_list_free):
936 Make it save to call it with NULL.
938 * src/dbus_api/modest-dbus-callbacks.c:
939 * src/modest-search.c:
940 Return full ModestSearchHits as the search result list not TnyHeader
941 since can't be around withouth the correspoding TnyFolder.
943 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
945 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
946 Added currently commented code to check for secure auth
948 * src/maemo/modest-account-settings-dialog.c: (on_response),
949 (save_configuration), (show_ok):
950 Fixed projects.maemo.org bugs NB #59248 and #59251
952 * src/maemo/modest-maemo-utils.c:
953 (on_camel_account_get_supported_secure_authentication_status),
954 (on_camel_account_get_supported_secure_authentication),
955 (modest_maemo_utils_get_supported_secure_authentication_methods):
956 * src/maemo/modest-maemo-utils.h:
957 Moved get_supported_secure_authentication() method here to be able
958 to use it from easysetup wizard.
960 * src/modest-pair.c: (on_pair_compare_as_string):
961 Should compare string with first part of pair and not
962 strcmp pairs which will crash.
964 * src/modest-protocol-info.c:
965 (modest_protocol_info_protocol_is_store):
966 * src/modest-protocol-info.h:
967 Added modest_protocol_info_get_auth_protocol_name()
969 2007-06-03 Armin Burgmeier <armin@openismus.com>
971 * src/modest-mail-operation.c:
972 (modest_mail_operation_get_msgs_full): Set priv->account also when
973 only retrieving a single message. This avoids a crash when canceling
976 (modest_mail_operation_notify_end): Do not explicitely remove the
977 operation from the queue but only emit the progress_changed signal.
978 The queue itself listens to that signal to remove the operation when
979 it is finished. This reduces coupling and removes a potential deadlock
980 when modest_mail_operation_notify_end() is called from the queue
981 itself. If that is a problem performance-wise, I would suggest to
982 implement a status-changed signal or something.
984 * src/modest-mail-operation-queue.c: Make sure to never call a
985 function from another file while the queue is locked. This (hopefully)
986 fixes another deadlock when exiting the application while retrieving
989 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
991 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
992 Fixed build if libogs is not available
994 2007-06-03 Christian Kellner <ckellner@openismus.com>
996 * libmodest-dbus-client/libmodest-dbus-client.h:
997 * libmodest-dbus-client/libmodest-dbus-client.c:
998 (libmodest_dbus_client_delete_message):
999 Implement deletion of messages (Client side).
1001 (modest_search_hit_free),
1002 (modest_search_hit_list_free):
1003 Utility functions to free the result hits.
1005 * src/dbus_api/modest-dbus-api.h:
1006 * src/dbus_api/modest-dbus-callbacks.c:
1007 (on_delete_message),
1008 (modest_dbus_req_handler):
1009 Implement deletion of messages (Server side).
1011 * tests/dbus_api/test_search.c: (main):
1014 * tests/dbus_api/Makefile.am:
1015 * tests/dbus_api/test_delete_message:
1016 Add little test for the message deletion logic
1018 2007-06-03 Armin Burgmeier <armin@openismus.com>
1020 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1021 when the operation queue was not empty. projects.maemo.org bug
1024 2007-06-03 Armin Burgmeier <armin@openismus.com>
1026 * src/widgets/modest-account-view.c
1027 (on_account_default_toggled): Toggle default account column
1028 explicitely instead of waiting for gconf notification (which is
1029 currently ignored). This should fix projects.maemo.org bug NB#56910
1030 for now. It should probably be removed when gconf notifications are
1033 2007-06-03 Christian Kellner <ckellner@openismus.com>
1035 * libmodest-dbus-client/libmodest-dbus-client.c:
1036 Removed debugging spew.
1038 * src/dbus_api/modest-dbus-callbacks.c:
1039 Added debugging info.
1041 * src/modest-search.c:
1042 (modest_search_all_accounts):
1043 Use tny_account_store_get_accounts () on the account store
1044 to get all accounts which is the way to get all accounts.
1046 * tests/dbus_api/test_search.c: (main):
1047 Make it possible to supply the search term on the command line.
1049 2007-06-03 Christian Kellner <ckellner@openismus.com>
1051 * libmodest-dbus-client/libmodest-dbus-client.c:
1052 * libmodest-dbus-client/libmodest-dbus-client.h:
1053 Implement searching for mesages over raw dbus. (Client side)
1055 * src/dbus_api/Makefile.am:
1056 * src/dbus_api/modest-dbus-api.h:
1057 * src/dbus_api/modest-dbus-callbacks.c:
1058 * src/dbus_api/modest-dbus-callbacks.h:
1059 Search framework (Server side). Also implement on_idle_open_message().
1061 * src/maemo/modest-platform.c: (modest_platform_init):
1062 Prepare for raw dbus/osso rpc interaction.
1064 * src/modest-search.h:
1065 Changed minsize from unspecific guint to guint32.
1067 * src/modest-search.c:
1069 Added strange hack which magically made tnymail work.
1071 (modest_search_folder),
1072 (modest_search_account),
1073 (modest_search_all_accounts):
1074 Implement helper functions to search all accounts, specific account
1077 * tests/dbus_api/Makefile.am:
1078 * tests/dbus_api/test_open_message.c:
1079 Read url to open from commandline.
1081 * tests/dbus_api/test_search.c:
1082 Implement small test for dbus search stuff
1084 2007-06-02 Armin Burgmeier <armin@openismus.com>
1086 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1087 include account type and account title. This fixes projects.maemo.org
1090 * src/maemo/modest-account-view-window.c: Set a title for the window.
1092 2007-06-02 Armin Burgmeier <armin@openismus.com>
1094 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1095 incoming and outgoing server name based on email address and server
1096 types as long as the names have not been edited manually. This fixes
1097 projects.maemo.org bug NB#58671.
1099 2007-06-02 Armin Burgmeier <armin@openismus.com>
1101 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1102 server type cannot be changed in future to the incoming details page
1103 when creating an account. This fixes projects.maemo.org bug NB#59029.
1105 2007-06-02 Armin Burgmeier <armin@openismus.com>
1107 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1108 and assigned max width chars so that they wrap instead of being
1109 truncated. Fixes projects.maemo.org bug NB#56126.
1111 2007-06-02 Armin Burgmeier <armin@openismus.com>
1113 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1114 introductory note to the connection specific smtp servers dialog, as
1115 section 8.12 of the email UI specification requires. This fixes
1116 projects.maemo.org bug NB#59212.
1118 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1120 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1121 Check for running mail operations, and offer to cancel them, as per the UI
1122 spec. This fixes projects.maemo.org bug NB#59041 .
1123 However, I suspect that tinymail may still use the network connection
1124 in ways that we cannot detect or cancel. But it should at least adapt to
1125 changes fairly well.
1127 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1129 * src/modest-tny-account-store.c: (recreate_all_accounts),
1130 (get_cached_accounts), (get_server_accounts): Do more sensible
1131 ref-counting of the temporarily-cached outbox accounts list. This seems
1132 to fix a crash when entering the password when the password was wrong.
1134 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1136 * src/gnome/modest-main-window.c: (connect_signals):
1137 * src/modest-tny-account-store.c: (get_password),
1138 (modest_tny_account_store_alert): Added comments and clues and
1139 commented-out code about how we currently fail to deal with connection
1140 errors and wrong passwords, and how we should.
1142 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1144 * src/widgets/modest-retrieve-combo-box.c:
1145 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1146 This fixes projects.maemo.org bug NB#58472 .
1148 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/easysetup/modest-easysetup-wizard.c:
1151 (create_page_complete_easysetup):
1152 (create_page_complete_custom): Correct the last commit,
1153 putting the correct sentences in the correct pages.
1155 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/easysetup/modest-easysetup-wizard.c:
1158 (create_page_complete_custom): Show the second sentence of text
1159 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1162 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1165 Set the leave-on-server conf key by default. This fixes
1166 projects.maemo.org bug NB#59258 .
1168 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1170 * src/maemo/modest-account-view-window.c:
1171 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1172 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1175 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1177 * src/maemo/easysetup/modest-easysetup-wizard.c:
1178 (create_caption_new_with_asterisk):
1179 * src/maemo/modest-account-settings-dialog.c:
1180 (create_caption_new_with_asterisk):
1181 Uncomment the code to add the asterisk, because they are no longer in the
1182 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1183 (update_incoming_server_title): Add an asterisk here too.
1185 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/modest-maemo-global-settings-dialog.c:
1188 (current_connection): Check that we are even connected before trying to
1189 get the current connection name, to prevent a warning.
1191 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1192 Change the comments because tny_maemo_conic_device_connect() is now meant to
1194 * src/modest-mail-operation.c:
1195 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1196 make sure we have a connection and fail if we can't connect.
1198 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-main-window.c:
1201 (on_account_store_connecting_finished): Do not try to get the
1202 connection ID if we are not really connected. I am surprised that
1203 this signal handler is called when we are not connected.
1205 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-error.h:
1208 * src/modest-ui-actions.c:
1209 (modest_ui_actions_get_msgs_full_error_handler):
1210 Renamed an enum, added comments, added an enum
1211 for retrieve-limit errors.
1213 * src/modest-mail-operation.c: (foreach_add_item),
1214 (internal_folder_observer_update), (update_account_thread),
1215 (modest_mail_operation_get_msgs_full):
1216 (modest_mail_operation_update_account),
1217 Added comments about how this works, and some code that should
1218 (but does not) check the retrieve-limit. See the TODO comment.
1220 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1223 Initialize help_id to fix the build. Warnings are good.
1225 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1227 * src/widgets/modest-hbox-cell-renderer.c:
1228 (modest_hbox_cell_renderer_append):
1229 * src/widgets/modest-vbox-cell-renderer.c:
1230 (modest_vbox_cell_renderer_append):
1231 Fix the last commit by doing an extra ref.
1233 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1235 * src/widgets/modest-hbox-cell-renderer.c:
1236 (modest_hbox_cell_renderer_append):
1237 * src/widgets/modest-vbox-cell-renderer.c:
1238 (modest_vbox_cell_renderer_append):
1239 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1240 to fix the build with Maemo Bora.
1241 However, there seems to be a remaining crash, probably due to reference
1244 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-tny-account.c:
1247 (modest_tny_account_new_for_local_folders):
1248 Use hildon_file_system_info_async_new() to get a better name for
1249 the memory card account, setting it as the account name.
1250 The timing seems to work, but this is probably
1251 not the best place to do this. See the TODO comment.
1252 * src/maemo/modest-main-window.c: (create_details_widget):
1253 * src/widgets/modest-folder-view.c: (text_cell_data):
1254 Use the tny account name instead of hardcoding a name.
1256 2007-05-30 Christian Kellner <ckellner@openismus.com>
1258 * src/modest-search.c: (modest_search):
1259 Correctly set part_search_func even if we have already parsed
1260 the query and thus a valid OgsTextSearcher object.
1262 2007-05-30 Christian Kellner <ckellner@openismus.com>
1265 Search and check for libogs.
1268 Incooparte the ogs build env.
1270 * src/modest-mime-part-search-stream.c:
1271 * src/modest-mime-part-search-stream.h:
1272 Removed since we do the real searching now in modest-search.c.
1274 * src/modest-search.c:
1275 * src/modest-search.h:
1276 Implement support for ogs. We use that if available and requested
1277 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1278 should now handle the corner case when the search term is spread
1279 across multiple reads.
1280 Also the logic in modest_search () was corrected to search all
1281 requested fields until one is found.
1283 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1287 * src/modest-init.h:
1288 * src/modest-init.c: Made modest_init_local_folders() take a
1289 path and be public so we can iniitialize maildir folders on
1292 * src/modest-local-folder-info.h:
1293 * src/modest-local-folder-info.c:
1294 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1296 * src/modest-tny-account.c:
1297 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1298 still means the standard local-folders path on the local volume.
1300 * src/modest-tny-account-store.c:
1301 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1302 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1303 all accounts when that happens.
1304 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1305 this too, so it shows up in the treeview.
1307 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1309 * src/maemo/modest-maemo-global-settings-dialog.c:
1310 (current_connection):
1311 * src/widgets/modest-global-settings-dialog.c:
1312 (current_connection_default):
1313 Use the enum values instead of 0, 1 and -1,
1314 to make the code clearer.
1316 * src/modest-account-mgr-helpers.c:
1317 (modest_account_mgr_get_connection_specific_smtp): Make this code
1320 * src/modest-runtime.h:
1321 * src/modest-runtime.c:
1322 Added modest_runtime_remove_all_send_queues().
1323 * src/maemo/modest-main-window.c:
1324 (on_account_store_connecting_finished): Recreate the send queues,
1325 using the appropriate transport accounts for this new connection.
1326 Some futher adapting might be needed if the old send queues are not
1327 automatically stopped at this point.
1329 * src/modest-tny-account-store.c: (get_server_accounts):
1330 Create the connection-specific transport accounts, so that they can
1331 be found later by their ID.
1333 * src/modest-tny-account.h:
1334 * src/modest-tny-account.c:
1335 Added modest_tny_account_new_from_server_account_name().
1336 modest_tny_account_new_from_server_account(): Do not create the
1337 send queues here, because they will be
1338 recreated anyway when the connection changes for the first time.
1340 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-local-folder-info.h:
1343 * src/modest-local-folder-info.c:
1344 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1345 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1346 tbox_folder): Take a modest account name instead of a server TnyAccount,
1347 so we can have per-modest-account rather than per-transport-account
1349 We must make sure that we change or recreate the exisitng send queues
1350 when the connection changes for connection-specific transport accounts.
1352 * src/modest-tny-account-store.c:
1353 (create_per_account_local_outbox_folders): Create outboxed per modest
1354 account, not per transport account.
1356 * src/modest-tny-account.h:
1357 * src/modest-tny-account.c:
1358 (modest_tny_account_get_special_folder): For outboxes, get the
1359 parent modest account name. The account is ignored for other folders.
1360 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1361 modest account name rather than a server TnyAccount.
1363 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1365 * src/modest-tny-account.c:
1366 (modest_tny_account_new_from_server_account):
1367 Call modest_runtime_get_send_queue() immediately after creating transport
1368 accounts, so that they start trying to send email from the outbox as soon
1369 as possible at startup. This is probably what we want.
1371 * src/modest-mail-operation.c: (update_account_thread):
1372 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1373 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1374 * src/modest-tny-send-queue.h:
1375 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1376 (modest_ui_actions_on_send):
1377 Added comments about how sending works, though it needs some more work.
1379 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1381 * src/modest-tny-account.c:
1382 (modest_tny_account_get_special_folder): Add TODO because this fails when
1383 the network is busy.
1384 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1385 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1386 Do not try to show this window when there is no active account. The UI
1387 specs does not tell us what to do in this case.
1389 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/Makefile.am:
1394 * src/widgets/Makefile.am: Some dist fixes.
1396 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/modest-connection-specific-smtp-window.c:
1399 (on_button_edit): Make the code clearer, to prevent a double free.
1401 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/modest-account-settings-dialog.c:
1404 (modest_account_settings_dialog_set_account_name),
1405 Check the connection-specific smtp servers checkbox if there are any.
1407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1408 (modest_connection_specific_smtp_edit_window_init):
1409 Start with a suitable port number.
1411 * src/modest-account-mgr-helpers.h:
1412 * src/modest-account-mgr-helpers.c: Added
1413 modest_account_mgr_get_has_connection_specific_smtp().
1415 (modest_account_mgr_set_connection_specific_smtp),
1416 (modest_account_mgr_remove_connection_specific_smtp),
1417 (modest_account_mgr_get_has_connection_specific_smtp),
1418 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1419 connection-specific smtp server accounts in the account, rather than
1420 the server account conf dir.
1422 This fixes bug projects.maemo.org bug NB#58263 .
1424 * src/modest-tny-account-store.c:
1425 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1426 if there are no server accounts yet, to prevent an infinite loop when there
1427 are no accounts. Document that one must be called before the other.
1429 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-account-mgr-helpers.c:
1432 (modest_account_mgr_get_default_account): Make sure that at least
1433 one account is always the default, if there are any enabled accounts.
1434 This is just a sanity check that shouldn't be necessary.
1436 * src/modest-account-mgr-priv.c:
1437 (_modest_account_mgr_account_from_key): Unescape the conf key to
1438 get the real account name. For instance, this is an issue if a space
1439 was in the account name, which can happen because the account name
1440 is generated from the display name.
1441 (_modest_account_mgr_get_account_keyname): Always escape the
1443 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1444 Unescape the conf keys to get the real account names.
1446 For instance, previously the is-default radio button in the accounts
1447 list was not checked for any accounts at first. This fixes that,
1448 and might fix several similar bugs.
1450 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1452 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1453 Removed some debug printfs.
1455 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1457 Modest on-disk outbox directories are now here, for instance:
1458 $HOME/.modest/outboxes/<account-id-1>/outbox
1459 $HOME/.modest/outboxes/<account-id-2>/outbox
1461 $HOME/.modest/local-folders/outbox
1462 so we can have a separate outbox for each account.
1463 But they are shown as one outbox in the GtkTreeView, by using a
1464 TnyMergeFolder in a ModestTnySimpleFolderStore.
1467 * src/modest-tny-simple-folder-store.c:
1468 * src/modest-tny-simple-folder-store.h:
1469 Added ModestTnySimpleFolderStore, used to contain folders from
1470 other folder stores, such as other accounts.
1472 * src/modest-tny-outbox-account.h:
1473 * src/modest-tny-outbox-account.c:
1474 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1475 used for the per-account local outbox folders.
1477 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1478 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1479 only use this (internally) now for the non-outbox local folders.
1481 * src/modest-init.h:
1482 * src/modest-init.c: Added modest_init_one_local_folder(), for
1483 setting up the directory structure for each local folder.
1485 * src/modest-local-folder-info.c:
1486 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1487 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1489 * src/modest-local-folder-info.h:
1490 * src/modest-tny-account-store.c: (on_account_removed),
1491 (on_account_changed), (create_per_account_local_outbox_folders),
1492 (get_server_accounts), (modest_tny_account_store_get_accounts),
1493 (modest_tny_account_store_get_tny_account_by_account),
1494 (modest_tny_folder_store_is_virtual_local_folders):
1496 * src/modest-tny-account.h:
1497 * src/modest-tny-account.c:
1498 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1499 to create an on-disk per-account local outbox folder for each
1501 (create_per_account_local_outbox_folders): Create a local outbox folder
1502 for each transport account.
1503 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1504 for all local folders.
1506 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1507 instead of using g_object_get/set() directly. It is clearer.
1509 (modest_tny_folder_store_get_message_count),
1510 (modest_tny_folder_store_get_local_size
1511 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1512 because we now use these with non-acount folder stores.
1514 (modest_tny_account_get_special_folder),
1515 (modest_tny_account_new_from_server_account),
1516 (modest_tny_account_new_from_account):
1517 (recurse_folders): Adjust to the new outbox system.
1519 * src/modest-tny-folder.h:
1520 * src/modest-tny-folder.c:
1521 (modest_tny_folder_is_local_folder),
1522 (modest_tny_folder_get_local_folder_type),
1523 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1525 * src/widgets/modest-main-window.h:
1526 * src/maemo/modest-main-window.c: (create_details_widget),
1527 (modest_main_window_set_contents_style): Show details for any folder store,
1530 (modest_tny_folder_get_rules):
1531 Remove the const. C does not support constness enough for this.
1533 * src/modest-ui-actions.c:
1534 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1535 make all outboxes appear as one, in the usual local-folders tree node.
1537 (set_active_account_from_tny_account),
1538 (modest_ui_actions_on_folder_selection_changed):
1539 * src/widgets/modest-folder-view.c: (text_cell_data),
1540 (icon_cell_data), (filter_row),
1541 (add_account_folders_to_merged_folder),
1542 (add_account_folders_to_simple_folder_store), (),
1543 (get_cmp_rows_type_pos), (cmp_rows),
1544 (modest_folder_view_set_account_id_of_visible_server_account):
1545 Adjust to the new outbox system, using generic folder stores and folders
1546 in the GtkTreeModel.
1548 2007-05-23 Christian Kellner <ckellner@openismus.com>
1550 * src/modest-mail-operation.c:
1551 (modest_mail_operation_update_account):
1552 Use info->max_size instead of unintialized local var [small
1553 build fix]. (Added TODO to review that change since I don't
1556 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1558 * libmodest-dbus-client/libmodest-dbus-client.c:
1559 (libmodest_dbus_client_compose_mail): function added
1560 * src/dbus_api/modest-dbus-api.h:
1561 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1562 (on_compose_mail): Implementation of the SendAsMail functionality
1564 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1566 * src/modest-account-mgr.c:
1567 (modest_account_mgr_add_server_account): Set the secure-connection
1568 conf key for transport accounts as well as store accounts. I don't know
1569 why the if was there. For instance, this makes sure that we use SSL
1570 for the gmail preset from the easysetup wizard.
1572 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1574 * src/gnome/modest-main-window.c:
1575 (on_account_store_connecting_finished), (connect_signals):
1576 * src/maemo/modest-main-window.c:
1577 (on_account_store_connecting_finished), (connect_signals),
1578 (modest_main_window_new):
1579 Handle TnyAccountStore::connecting-finished instead of
1580 TnyDevice::connection-changed, because we cannot actually perform
1581 operations on accounts until TnyAccountStore has itself responded to
1582 the TnyDevice::connection-changed signal. This prevents a GError from
1584 Do not try to update at startup, because we (at least on scratchbox)
1585 already do an update at startup when the device goes online.
1586 This prevents a GError from tinymail.
1587 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1588 Added TODO about stopping simultaneous operations.
1590 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1593 * src/modest-mail-operation-queue.c:
1594 (modest_mail_operation_queue_remove):
1595 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1596 about where they happened.
1598 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-ui-actions.c:
1601 (modest_ui_actions_on_password_requested): Make sure that the remember
1602 output parameter is always TRUE.
1604 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1607 Show a OK/Cancel dialog if the error is a question, though we still do not
1608 know anything more about what we are asking the user.
1609 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1610 Fix an uninitialized variable (helper). This is a logic error, however.
1612 2007-05-21 Christian Kellner <ckellner@openismus.com>
1614 * src/modest-search.h:
1615 Correct bit shifting in the ModestSearchFlags enum.
1617 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-tny-account.c:
1620 (modest_tny_account_new_from_server_account): Do not use the lsub and
1621 check-all hard-coded IMAP options when using POP.
1623 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-tny-account.c:
1626 (modest_tny_account_new_from_server_account):
1627 Use NULL for the secure-auth method for POP when Password auth has been
1628 specified by the user, as we already do for IMAP. "auth=Login" causes
1629 an error from camel or the server.
1631 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1633 * src/maemo/modest-account-settings-dialog.c:
1634 (create_page_account_details),
1635 (modest_account_settings_dialog_set_account_name):
1636 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1637 for the leave-on-server checkbox, rathr than just the checkbox, when
1638 the protocol is not POP.
1640 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1642 * src/widgets/modest-account-view.c:
1643 * src/widgets/modest-account-view.h:
1644 Added modest_account_view_select_account() which will be useful later
1645 to asynchronously re-select the edited account.
1647 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1649 * src/maemo/modest-account-settings-dialog.c:
1650 (modest_account_settings_dialog_set_account_name):
1651 Automatically choose the port numbers based on the secure authentication
1652 methods, if they have not been chosen before.
1653 This fixes projects.maemo.org bug NB#56273 .
1655 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1657 * src/maemo/modest-main-window-ui.h:
1658 * src/modest-ui-actions.c:
1659 * src/modest-ui-actions.h:
1660 Connect the Tools/SMTP Servers menu item to
1661 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1662 SMTP servers dialog, as in the UI specification and saves changes when it
1663 is closed. This fixed projects.maemo.org bug NB#56305 .
1665 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1667 * src/maemo/modest-connection-specific-smtp-window.c:
1668 (modest_connection_specific_smtp_window_init):
1669 Use gtk_window_set_default_size() to make this window big enough, so
1670 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1672 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1675 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1676 (modest_connection_specific_smtp_edit_window_init),
1677 Do not try to connect to a combobox signal before the combobox exists.
1678 This fixes the cras in projects.maemo.org bug NB#56288 .
1679 (modest_connection_specific_smtp_edit_window_get_settings):
1680 Remove the server_account_name parameter which was being checked for NULL
1681 though it was not used.
1683 * src/maemo/modest-connection-specific-smtp-window.c:
1684 (modest_connection_specific_smtp_window_fill_with_connections),
1685 (on_button_edit), (modest_connection_specific_smtp_window_init):
1686 Correct the number of treemodel columns to prevent a warning.
1687 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1688 libconic does not work.
1690 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-tny-account.c:
1693 (modest_tny_account_new_from_server_account):
1694 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1695 SMTP when "None" was chosen by the user. However, with my SMTP server that
1696 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1699 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1701 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1702 to explain the memory management issue with the ID in the ModestPair.
1704 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1705 (add_sending_page), (modest_account_assistant_finalize):
1706 * src/gnome/modest-gnome-global-settings-dialog.c:
1707 (create_updating_page), (create_composing_page):
1708 * src/gnome/modest-msg-edit-window.c: (get_transports),
1709 (init_window), (modest_msg_edit_window_finalize),
1710 (modest_msg_edit_window_get_msg_data):
1711 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1712 * src/gnome/modest-transport-widget.c:
1713 (modest_transport_widget_finalize), (smtp_configuration):
1714 * src/maemo/modest-maemo-global-settings-dialog.c:
1715 (create_updating_page), (create_composing_page):
1716 * src/maemo/modest-msg-edit-window.c: (get_transports),
1717 (init_window), (modest_msg_edit_window_finalize),
1718 (modest_msg_edit_window_get_msg_data),
1719 (modest_msg_edit_window_free_msg_data):
1720 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1721 (modest_store_widget_finalize):
1722 * src/maemo/modest-transport-widget.c:
1723 (modest_transport_widget_finalize), (smtp_configuration):
1724 * src/modest-main.c: (send_mail):
1725 * src/widgets/modest-combo-box.h:
1726 * src/widgets/modest-global-settings-dialog-priv.h:
1727 * src/widgets/modest-global-settings-dialog.c:
1728 (modest_global_settings_dialog_finalize):
1729 * src/widgets/modest-msg-edit-window.h:
1730 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1731 as long as the combo box, to prevent use of freed memory for the ID.
1733 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1736 get_accounts(), to make this clearer. Do not check for the enabled gconf
1737 key, because we do not use this for server accounts (at least, not yet).
1738 This allows us to send email again.
1740 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1742 * src/maemo/modest-platform.c:
1743 (on_modest_conf_update_interval_changed), (modest_platform_init):
1744 Only respond to this particular key change. All these strcmp()s cannot be
1747 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/modest-maemo-global-settings-dialog.c:
1750 (current_connection): Prevent a crash in scratchbox when
1751 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1752 * src/maemo/modest-platform.c:
1753 (on_modest_conf_update_interval_changed), (modest_platform_init):
1754 Get the update interval from gconf and reset it when the gconf key changes.
1756 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1758 * src/modest-protocol-info.c:
1759 * src/modest-protocol-info.h: Adde enum-specific get functions,
1760 instead of using a ModestProtocolType enum parameter.
1762 * src/gnome/modest-account-assistant.c:
1763 * src/gnome/modest-store-widget.c:
1764 * src/gnome/modest-store-widget.h:
1765 * src/gnome/modest-transport-widget.c:
1766 * src/gnome/modest-transport-widget.h:
1767 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1768 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1769 * src/maemo/easysetup/modest-easysetup-wizard.c:
1770 * src/maemo/modest-account-settings-dialog.c:
1771 * src/maemo/modest-account-settings-dialog.h:
1772 * src/maemo/modest-store-widget.c:
1773 * src/maemo/modest-store-widget.h:
1774 * src/maemo/modest-transport-widget.c:
1775 * src/maemo/modest-transport-widget.h:
1776 * src/modest-account-mgr-helpers.c:
1777 * src/modest-account-mgr-helpers.h:
1778 * src/modest-account-mgr.c:
1779 * src/modest-account-mgr.h:
1780 * src/modest-tny-account.c:
1781 * src/modest-tny-folder.c:
1782 * src/widgets/modest-account-view.c:
1783 * src/widgets/modest-retrieve-combo-box.c:
1784 * src/widgets/modest-retrieve-combo-box.h:
1785 * src/widgets/modest-secureauth-combo-box.c:
1786 * src/widgets/modest-serversecurity-combo-box.c:
1787 * src/widgets/modest-serversecurity-combo-box.h:
1788 * tests/check_account-mgr.c:
1789 Use the specific functions, and use the re-renamed enum values for GNOME too.
1791 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-pair.h:
1794 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1795 so we can get the second based on the first.
1797 * src/maemo/modest-account-settings-dialog.h:
1798 * src/maemo/modest-account-settings-dialog.c:
1799 Added get_supported_secure_authentication_methods(), though it is mostly
1800 commented-out for now until the necessary API is committed to tinymail.
1801 (modest_account_settings_dialog_set_account_name),
1802 (save_configuration): Request the supported authentication methods from the
1803 server, so we can choose a working method.
1805 * src/modest-tny-account-store.h:
1806 * src/modest-tny-account-store.c:
1807 (modest_tny_account_store_get_session): Rename from
1808 tny_account_store_get_session().
1810 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1812 * src/modest-protocol-info.h: Split the ModestProtocol enum
1813 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1814 There was no need to have these unrelated values in one enum.
1816 * src/: many files: Adapted to changed enum. This makes the code a bit
1817 clearer, and the compiler could catch some errors.
1819 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1821 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1822 Show the detailed internal camel error message when an error happens
1823 during the configuration, so that our testers can give us more clues.
1824 For instance, in projects.maemo.org bug NB#56910 .
1826 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1828 * src/modest-tny-account.c:
1829 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1830 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1832 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1835 * src/maemo/modest-account-settings-dialog.c:
1836 (modest_account_settings_dialog_set_account_name),
1837 (save_configuration): For the incoming secure authentication checkbox,
1838 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1839 the UI specification. PLAIN does not seem to be supported for most IMAP
1840 servers anyway, and I am not sure what it would mean.
1841 However, we probably need to discover which of the secure-authentication
1842 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1843 * src/modest-account-mgr-helpers.c:
1844 (modest_account_mgr_get_server_account_data):
1846 * src/modest-tny-account.c:
1847 (modest_tny_account_new_from_server_account):
1848 Use tny_account_set_mech() to set secure-authentication methods,
1849 with some special-casing for IMAP, based on my observations of how
1852 * src/modest-account-mgr-helpers.h:
1853 * src/modest-account-mgr.c:
1854 * src/modest-defs.h: Comment that the URI is only used for local folders.
1856 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1859 parameter const, just to be neat.
1860 * src/modest-text-utils.c: (modest_text_utils_inline):
1861 End g_strconcat() with NULL, as its documentation says. This is almost
1862 certainly the cause of my crash at startup on the device. Interestingly,
1863 valgrind doesn't tell us about these errors.
1865 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1867 * scripts/build-packages: Added more precise comments about how to use
1868 this script, though I still get this error:
1869 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1870 error building tinymail
1872 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/modest-main-window.c: (on_account_update):
1875 Very slight cleanup, hoping to make it simpler to discover what causes
1876 a crash here sometimes.
1878 * src/modest-tny-account.c:
1879 (modest_tny_account_new_from_server_account): Set the port. Added
1880 comments about the options and a TODO comment because I need to find out
1881 how to specify the secure authentication method.
1883 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1885 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1886 changed CFlags paths form modest to libmodest
1888 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-account-mgr-helpers.c:
1891 (modest_account_mgr_get_server_account_data),
1892 (modest_account_mgr_free_server_account_data):
1893 * src/modest-account-mgr-helpers.h:
1894 * src/modest-account-mgr.c:
1895 (modest_account_mgr_add_server_account):
1896 * src/modest-defs.h:
1897 * src/modest-tny-account.c:
1898 (modest_tny_account_new_from_server_account):
1899 Determine the options for tny_camel_account_add_option() here,
1900 based on the settings, rather than storing them directly in gconf.
1902 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1905 Show a more friendly error dialog now that we expect (from the tinymail
1906 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1908 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1910 * src/maemo/modest-main-window.c: (on_account_update): Check that
1911 account_name is not NULL, to prevent a crash at startup that I am
1912 seeing on the N800. I do wonder why it is NULL.
1914 * src/maemo/easysetup/modest-easysetup-wizard.c:
1915 (create_page_user_details):
1916 * src/maemo/modest-account-settings-dialog.c:
1917 (create_page_user_details), (create_page_outgoing):
1918 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1919 (modest_connection_specific_smtp_edit_window_init):
1920 * src/modest-ui-actions.c:
1921 (modest_ui_actions_on_password_requested):
1922 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1923 might do something useful with the on-screen keyboard.
1925 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/modest-main-window.c: (on_account_update):
1928 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1929 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1931 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1933 * src/modest-tny-account-store.c: (on_account_changed):
1934 Correct the signature of this signal handler.
1936 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1938 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1939 Show a HildonNote instead of a GtkDialog for Maemo.
1941 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1943 * src/widgets/modest-account-view.h:
1944 * src/widgets/modest-account-view.c: (on_account_changed),
1945 (on_account_removed). Added a boolean flag, set/unset by
1946 modest_account_view_block_conf_updates(),
1947 modest_account_view_unblock_conf_updates() to prevent unnecessary
1948 updates, but this is not very useful because the gconf notifications are
1949 so delays (maybe only on Maemo Bora).
1950 So auto-updating is turned off, and these functions do an explicit
1951 update when necessary.
1952 However, something else is still doing too much work when adding/removing
1953 accounts, probably in another part of the application.
1955 * src/maemo/modest-account-view-window.c:
1956 (on_delete_button_clicked), (on_edit_button_clicked),
1957 (on_new_button_clicked): Use the new functions.
1959 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1961 * src/modest-account-mgr-helpers.c:
1962 (modest_account_mgr_set_first_account_as_default):
1963 Sort the list of names alphabetically-by-title, so we choose the first one
1965 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1966 alphabetically by the title.
1968 This fixes projects.maemo.org bug NB#56418 .
1970 * src/modest-account-mgr-priv.c:
1971 (_modest_account_mgr_account_from_key):
1972 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1973 avoid a valgrind error, and possible random behaviour.
1975 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1977 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1978 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1979 tinymail documentation to say that this can be expected.
1980 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1981 pretty, and should not happen, but I would prefer to know when it does.
1983 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1985 * configure.ac: When using the older hildon version, probably on Bora,
1986 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1988 * src/widgets/modest-attachment-view.c:
1989 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1992 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1994 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1995 Implemented the prototype. Can be tested with
1996 tests/dbus_api/test_open_message:
1998 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2000 * src/modest-tny-account-store.c:
2001 (modest_tny_account_store_instance_init), (get_password):
2002 * src/modest-ui-actions.c:
2003 (modest_ui_actions_on_password_requested):
2004 Do not store the password in gconf, because this function is called
2005 for non-remembered passwords. Actually use the cached (in the hash map)
2006 password instead of releasing it.
2007 The password will now not be remembered if it is asked via the protected
2008 password dialog, as per the UI spec.
2010 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-defs.h:
2013 * src/modest-account-mgr-helpers.h:
2014 * src/modest-account-mgr-helpers.c:
2015 Added modest_server_account_get_username_has_succeeded(),
2016 modest_server_account_set_username_has_succeeded().
2017 (modest_server_account_set_username),
2018 Reset the has-succeeded flag if the username changes.
2020 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2021 * src/maemo/modest-connection-specific-smtp-window.c:
2022 (modest_connection_specific_smtp_window_save_server_accounts):
2023 Use modest_server_account_set_username() instead of using
2024 modest_conf_set_string() directly, so that the has-succeeded flag is always
2027 * src/modest-ui-actions.c:
2028 (modest_ui_actions_on_password_requested): Dim the username entry if
2029 the username has ever worked, as per the UI spec.
2031 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2033 * src/modest-tny-account-store.c: (get_password):
2034 * src/modest-ui-actions.c:
2035 (modest_ui_actions_on_password_requested):
2036 Allow the username to be changed too, though there is more work to
2037 be done on exactly how this behaves.
2039 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-account-mgr-helpers.h:
2042 * src/modest-account-mgr-helpers.c:
2043 Added modest_account_mgr_get_display_name(),
2044 modest_server_account_get_username(),
2045 modest_server_account_set_username(),
2046 modest_server_account_set_password(),
2047 modest_server_account_get_hostname() functions so we do not need to
2048 use the conf API directly.
2050 * src/maemo/modest-main-window.c: (connect_signals):
2051 Actually connect ot the ModestAccountStore::request-password signal,
2052 so that we show the dialog when the password is requested by Tinymail,
2053 for isntance if it is empty.
2055 * src/modest-marshal.list:
2056 * src/modest-tny-account-store.c:
2057 (modest_tny_account_store_class_init), (get_password),
2058 (modest_tny_account_store_alert):
2059 * src/modest-tny-account-store.h:
2060 * src/modest-ui-actions.h:
2061 * src/modest-ui-actions.c:
2062 (modest_ui_actions_on_password_requested):
2063 Change the signal parameters, so it is obvious that we are providing
2064 the non human-readable server name, and receiving both the username
2065 and password, though changing of the username is not yet implemented.
2066 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2067 for the GNOME version.
2069 This should fix the projects.maemo.org bug NB#56209, though it does not
2070 work on Bora, because the gconf_client_get() for the password fails
2071 immediately after we save it with gconf_client_set().
2073 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2076 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2077 caused an undefined symbol error:
2078 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2080 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-tny-account-store.c:
2083 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2084 using a GError instead of a string message, so we can translate it in
2087 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2089 * src/maemo/modest-address-book.c:
2090 (modest_address_book_check_names):
2091 * src/maemo/modest-msg-view-window.c:
2092 (modest_msg_view_window_clipboard_owner_change):
2093 * src/modest-init.c: (modest_init_init_ui):
2094 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2095 (update_folders_cb), (modest_mail_operation_update_account):
2096 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2097 (modest_ui_actions_on_msg_attachment_clicked),
2098 (modest_ui_actions_on_msg_recpt_activated):
2099 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2100 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2101 (modest_msg_view_search_next):
2102 * src/widgets/modest-recpt-editor.c:
2103 (modest_recpt_editor_on_button_release_event),
2104 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2105 g_message(). At this point we should only be seeing interesting errors on
2106 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2108 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2110 (modest_wizard_dialog_force_title_update):
2111 * src/maemo/easysetup/modest-wizard-dialog.h:
2112 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2113 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2114 can update the title when appropriate. Otherwise the title is wrong if the
2115 pages are added after adding the notebook to the dialog.
2116 This must be a problem in HildonWizardDialog too.
2117 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2119 * src/maemo/easysetup/modest-easysetup-wizard.c:
2120 (create_subsequent_customsetup_pages),
2121 (create_subsequent_easysetup_pages):
2122 Call modest_wizard_dialog_force_title_update() so that the title is
2123 correct even with GTK+ < 2.10.
2124 This fixes projects.maemo.org bug NB#56145 .
2126 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/modest-platform.c:
2129 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2130 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2133 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2135 * src/widgets/modest-window.h:
2136 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2137 and modest_window_save_state(), which invokes it.
2139 * src/widgets/modest-window-mgr.h:
2140 * src/widgets/modest-window-mgr.c:
2141 Added modest_window_mgr_save_state_for_all_windows(), which calls
2142 the save_state vfunc on all registered windows, if implemented.
2144 * src/gnome/modest-msg-edit-window.c:
2145 * src/gnome/modest-msg-view-window.c:
2146 * src/maemo/modest-msg-edit-window.c:
2147 * src/maemo/modest-msg-view-window.c:
2148 * src/maemo/modest-main-window.c:
2149 Specify the existing save_settings functions as implementations of
2150 ModestWindow::save_state_func().
2152 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2153 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2154 enabling hibernation, for instance.
2156 We may need to do the same thing for restoring settings.
2159 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2161 * src/widgets/modest-window-mgr.c:
2162 * src/widgets/modest-window-mgr.h:
2163 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2164 modest_window_mgr_get_hibernation_is_prevented().
2166 * src/maemo/modest-main-window.c:
2167 (on_hildon_program_is_topmost_notify): Prevent hibernation
2168 (possible when the application goes to the background in the WM),
2169 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2171 * src/maemo/easysetup/modest-easysetup-wizard.c:
2172 (modest_easysetup_wizard_dialog_init):
2173 * src/maemo/modest-account-settings-dialog.c:
2174 (modest_account_settings_dialog_init):
2175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2176 (modest_connection_specific_smtp_edit_window_init):
2177 * src/maemo/modest-connection-specific-smtp-window.c:
2178 (modest_connection_specific_smtp_window_init):
2179 * src/maemo/modest-signature-editor-dialog.c:
2180 (modest_signature_editor_dialog_init):
2181 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2182 prevent hibernation while any of these account settings dialogs are open.
2184 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/Makefile.am:
2187 * src/maemo/modest-osso-state-saving.c:
2188 * src/maemo/modest-osso-state-saving.h: Added
2189 modest_osso_load_state() and modest_osso_save_state() though they do
2190 nothing now. They should iterate through all the open windows and load/save
2192 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2193 save state when closing.
2195 * src/maemo/modest-main-window.c:
2196 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2197 Add a notification handler for the HildonProgram::is-topmost property,
2198 so we can allow hibernation when the application goes into the background.
2199 But we still need to detect when the accounts setup windows are open so
2200 we can stop hibernation when they are open.
2201 To do this, I also added the main window the HildonProgram. This might have
2202 other side-effects/benefits, and should maybe be done for other windows.
2204 * src/maemo/modest-osso-autosave-callbacks.h:
2205 * src/maemo/modest-osso-autosave-callbacks.c:
2206 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2207 though it does not do anything yet, and we might never need this to do
2208 anything. For instance, we already save drafts.
2210 * src/maemo/modest-platform.c: (modest_platform_init):
2211 Specify the libosso auto-save callback.
2213 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/modest-platform.c:
2216 (modest_platform_set_update_interval):
2217 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2218 aparently stays valid between application instances, so we can use this
2219 to remove and reset it later. According to a maemo-developers email from
2222 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2224 * configure.ac: Depend on libalarm for Maemo.
2226 * src/dbus_api/modest-dbus-api.h:
2227 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2228 (on_send_receive), (modest_dbus_req_handler):
2229 Handle a SEND_RECEIVE D-Bus method.
2231 * libmodest-dbus-client/libmodest-dbus-client.c:
2232 (libmodest_dbus_client_send_and_receive):
2233 * libmodest-dbus-client/libmodest-dbus-client.h:
2234 Add C convenience functions for calling the new D-Bus method.
2236 * src/modest-platform.h:
2237 * src/gnome/modest-platform.c:
2238 * src/maemo/modest-platform.c:
2239 Added modest_platform_set_update_interval(), which uses the
2240 alarmd API on Maemo.
2241 (modest_platform_init),
2242 Call modest_platform_set_update_interval(), using a hard-coded
2243 interval for now (until the global settings dialog is implemented),
2244 though I am not sure that this makes sense yet.
2246 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2248 * src/dbus_api/modest-dbus-callbacks.c:
2249 (modest_osso_cb_hw_state_handler):
2250 * src/dbus_api/modest-dbus-callbacks.h:
2251 * src/maemo/modest-platform.c: (modest_platform_init):
2252 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2253 in case this has some effect on the ability for Maemo to ping the
2256 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2258 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2259 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2260 warning. It is probably a logic error, but I need to fix the build.
2262 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2264 * src/modest-account-mgr.h:
2265 * src/modest-account-mgr.c:
2266 (modest_account_mgr_account_names): Add a gboolean enabled_only
2267 parameter, so we can get lists of onlt the enabled accounts.
2269 (modest_account_mgr_add_account),,
2270 (modest_account_mgr_account_with_display_name_exists):
2271 * src/maemo/modest-msg-edit-window.c: (get_transports):
2272 * src/modest-account-mgr-helpers.c:
2273 (modest_account_mgr_set_first_account_as_default):
2274 * src/modest-init.c: (init_default_account_maybe):
2275 * src/modest-tny-account-store.c: (get_accounts):
2276 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2277 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2278 * tests/check_account-mgr.c: (START_TEST):
2279 Provide the extra parameter, as appropriate.
2281 * src/widgets/modest-account-view.c: (update_account_view):
2282 Do not show disabled accounts (meaning that there is no way to
2283 enable/disable accounts in the UI (the feature is not in our UI
2284 specification), so we can use this internally only to mark unfinished
2285 or temporary account data.
2287 * src/maemo/easysetup/modest-easysetup-wizard.c:
2288 (create_account): Add boolean enable parameter, so we can specify FALSE
2289 to create the temporary account.
2290 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2291 (on_before_next): When finishing, when there is a temporary account, just
2293 Also, use a timeout to delay the showing of the dialog until gconf is likely
2294 to return correct information, due to a maemo gconf bug that is fixed in
2295 osso 1.1, but not yet in Bora.
2296 However, the dialog stays on screen after it is destroyed.
2298 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2299 for invalid data when cancelling. Use a hildon note instead of a dialog
2300 to complain about invalid data. Do not show the account-saved note if the
2301 account is disabled (a temporary account that will not really be saved for use
2304 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2306 * src/modest-account-mgr-helpers.h:
2307 * src/modest-account-mgr-helpers.c:
2308 Added modest_account_mgr_unset_default_account(),
2309 Added modest_account_mgr_set_first_account_as_default().
2311 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2312 If it was the default account, unset the default account name.
2314 * src/maemo/modest-account-view-window.c:
2315 (on_delete_button_clicked): If it was the default account,
2316 set the first remaining account as the default instead.
2318 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2319 a NULL account or a NULL default account, to prevent a crash. This should
2320 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2323 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2325 * src/widgets/modest-recpt-editor.c:
2326 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2327 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2328 TODO comment for this. This fixes the build.
2330 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2331 be the best place for it. This will in future update all auto-update accounts,
2332 rather than just the current/default account, when that gconf key exists.
2333 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2334 if there are no accounts, before calling do_send_receive().
2335 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2337 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2338 * src/maemo/modest-main-window-ui.h:
2339 * src/maemo/modest-main-window.c: (on_connection_changed),
2340 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2341 directly, becaue the signal handler does more.
2343 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-account-mgr-helpers.c:
2346 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2347 for the case that the account does not exist.
2349 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2350 (equivalent to the modest account name) rather than the tinymail account name
2351 (equivalent to the modest account title - human readable) to get the account data.
2352 Check for null account data to prevent the crash, and add a TODO comment saying that
2353 this needs fixing because it is using the server account name instead of the account name.
2355 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2357 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2358 * src/maemo/modest-account-settings-dialog.c: (show_error),
2360 Use hildon_note_new_information() for informative and error messages,
2361 which seems to be expected for Maemo applications (no documentation that I know of
2362 says this). I am surprised that there is no distinction between info and error
2365 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2367 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2368 it is easy to find where this is used.
2370 * src/maemo/easysetup/modest-easysetup-wizard.c:
2371 (create_page_welcome), (create_page_account_details),
2372 (create_page_user_details), (create_page_complete_easysetup),
2373 (create_page_custom_incoming), (create_page_custom_outgoing),
2374 (create_page_complete_custom):
2375 * src/maemo/modest-account-settings-dialog.c:
2376 (create_page_account_details), (create_page_user_details),
2377 (create_page_incoming), (create_page_outgoing):
2378 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2379 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2380 (modest_connection_specific_smtp_edit_window_init):
2381 * src/maemo/modest-connection-specific-smtp-window.c:
2382 (modest_connection_specific_smtp_window_init):
2383 * src/maemo/modest-signature-editor-dialog.c:
2384 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2385 and scrolling policy as per the Email Application Layout Guide, if I have
2388 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2390 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2391 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2392 which were empty, because these vfuncs have been removed from TnyAccountStore.
2393 This fixes the build.
2395 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2397 * src/maemo/modest-main-window.c:
2398 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2399 showing/hiding it. Added TODO because it probably should not be NULL.
2400 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2401 because unnecessary g_warnings() make degugging difficult.
2403 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2405 * src/maemo/modest-msg-edit-window.c:
2406 (modest_msg_edit_window_select_color),
2407 (modest_msg_edit_window_select_background_color): 2 const corrections and
2408 moving 2 #endifs before closing brackets, to fix the build.
2410 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2412 * src/maemo/easysetup/modest-easysetup-wizard.h:
2413 * src/maemo/easysetup/modest-easysetup-wizard.c:
2414 (modest_easysetup_wizard_dialog_finalize),
2415 (on_button_edit_advanced_settings), (create_page_complete_custom),
2416 (on_response), (create_account):
2417 Implement the Advanced Settings edit button, by saving the account information,
2418 for the Advanded Settings dialog to use directly from gconf, and removing it
2419 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2420 Bug #5533 in the projects.maemo.org bugzilla.
2422 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/modest-msg-view-window.c:
2425 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2426 when opening a message window.
2428 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2430 * src/maemo/easysetup/modest-easysetup-wizard.c:
2431 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2434 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2435 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2436 gconf settings. I probably added more checks than necessary, but that is safer.
2438 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2439 variable to fix the build, but this seems to be used when it is still NULL.
2441 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2443 * src/modest-platform.h:
2444 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2445 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2446 * src/modest-main.c: Implement this function so we can avoid using
2447 maemo-specific API from cross-platform code.
2449 * src/modest-tny-account-store.c:
2450 (get_smtp_specific_transport_account_for_open_connection):
2451 * src/modest-ui-actions.c: (check_for_connection),
2452 (modest_ui_actions_on_item_not_found):
2453 Use modest_platform_connect_and_wait() and put #idefs around other
2454 maemo-specific code, because only maemo currently has a way to
2455 identify connection names.
2457 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-tny-account-store.h:
2460 * src/modest-tny-account-store.c:
2461 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2462 the connection-specific SMTP server settings in the configuration.
2464 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2466 * src/maemo/modest-main-window.c: (on_connection_changed),
2468 * src/modest-main.c: (main), (start_ui), (send_mail):
2469 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2470 that is what is intended.
2472 * src/modest-ui-actions.c: (action_send), (action_receive),
2473 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2474 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2475 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2476 SMTP server is used when it is specified.
2478 (modest_ui_actions_on_send_receive):
2479 Check that a connection is open before proceeding.
2480 Receive and then send, instead of vice-versa, as per the specification.
2482 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-mail-operation.c:
2485 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2486 though I guess it should be something other than NULL.
2488 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/easysetup/modest-easysetup-wizard.c:
2491 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2492 combo twice, to avoid an g_warning and to make it visible again.
2493 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2494 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2495 (already intended) dereference when detaching, because we then recreate the menu.
2496 But I am not sure why the warning was happening, and it is possible that this is a memory
2499 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2501 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2502 and uri_parse_mailto() utility functions.
2503 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2505 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2507 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2509 * src/dbus_api/modest-dbus-api.h:
2510 * src/dbus_api/modest-dbus-callbacks.c:
2511 Use an idle callback to execute the modest code in the application's own thread.
2512 Remove the helloworld example method.
2513 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2514 parsed, and the open-message method is not implemented because this is not yet implemented in
2516 * libmodest-dbus-client/libmodest-dbus-client.c:
2517 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2518 (libmodest_dbus_client_open_message):
2519 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2521 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2522 body without crashing.
2524 * tests/dbus_api/Makefile.am:
2525 * tests/dbus_api/test_mail_to.c:
2526 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2528 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2530 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2531 Added file to fix the build. Sorry.
2533 * src/dbus_api/Makefile.am:
2534 * src/dbus_api/modest-dbus-api.h:
2535 * src/dbus_api/modest-dbus-callbacks.h:
2536 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2537 (modest_dbus_req_handler):
2538 Put constants in a separate header so it can be reused by the
2539 client library, without duplication
2541 * libmodest-dbus-client/Makefile.am:
2542 * libmodest-dbus-client/libmodest-dbus-client.c:
2543 (libmodest_dbus_client_call_helloworld),
2544 (libmodfest_dbus_client_send_mail),
2545 (libmodfest_dbus_client_mailto),
2546 (libmodfest_dbus_client_open_message):
2547 * libmodest-dbus-client/libmodest-dbus-client.h:
2548 (Partly) Implement a send_mail D-Bus method.
2550 * tests/dbus_api/Makefile.am:
2551 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2552 the send_email D-Bus method.
2554 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2558 * libmodest-dbus-client/Makefile.am:
2559 * libmodest-dbus-client/libmodest-dbus-client.c:
2560 * libmodest-dbus-client/libmodest-dbus-client.h:
2561 * tests/dbus_api/Makefile.am:
2562 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2563 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2565 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/easysetup/modest-easysetup-wizard.c:
2568 (create_page_account_details):
2569 * src/maemo/modest-account-settings-dialog.c:
2570 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2571 widgets, because this might not be the default in future versions of the Maemo GTK+.
2572 However, I can not not get capitalization to work even in a simple test case.
2574 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2576 * src/maemo/easysetup/modest-easysetup-wizard.c:
2577 (create_page_custom_incoming), (create_page_custom_outgoing):
2578 * src/maemo/modest-account-settings-dialog.c:
2579 (create_page_account_details), (create_page_incoming),
2580 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2581 instead of using gtk_check_button_with_label(), so they are aligned like the other
2582 widgets, as per the UI spec.
2584 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/easysetup/modest-easysetup-wizard.c:
2587 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2588 * src/widgets/modest-validating-entry.c:
2589 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2590 Modest prefix instead of an EasySetup prefix.
2592 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2594 * src/widgets/modest-validating-entry.h:
2595 * src/widgets/modest-validating-entry.c: (on_insert_text),
2596 Added easysetup_validating_entry_set_max_func(), used to set a callback
2597 to call when the max number of characters is reached. GtkEntry has a max-length
2598 already but is silent about it.
2600 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2601 (create_page_account_details), (create_page_user_details),
2603 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2604 (create_page_account_details), (create_page_user_details),
2605 (create_page_outgoing):
2606 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2607 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2608 the UI spec, when the user tries to enter more than the max number of characters.
2610 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/easysetup/modest-easysetup-wizard.c:
2613 (create_page_user_details), (create_page_custom_incoming),
2614 (create_page_custom_outgoing):
2615 * src/maemo/modest-account-settings-dialog.c:
2616 (create_page_user_details), (create_page_incoming),
2617 (create_page_outgoing):
2618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2619 (modest_connection_specific_smtp_edit_window_init):
2620 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2621 not appropriate. Bad Maemo-specific defaults!.
2623 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2625 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2626 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2627 (modest_signature_editor_dialog_set_settings):
2628 Disable the label and textview when the checkbox is disabled, and use the
2629 specified (UI spec) default signature text.
2631 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2634 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2636 * src/modest-defs.h:
2637 * src/modest-account-mgr-helpers.h:
2638 * src/modest-account-mgr-helpers.c:
2639 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2641 * src/maemo/Makefile.am:
2642 * src/maemo/modest-signature-editor-dialog.c:
2643 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2646 * src/maemo/modest-account-settings-dialog.h:
2647 * src/maemo/modest-account-settings-dialog.c:
2648 (modest_account_settings_dialog_finalize), (on_button_signature),
2649 (save_configuration): Use the new dialog when the Edit button is pressed, and
2650 save the changes if necessary, as per the UI spec.
2652 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2654 * src/maemo/Makefile.am:
2655 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2656 based on maemo-develoers email from Dirk.
2658 * src/maemo/easysetup/modest-easysetup-wizard.c:
2659 (create_page_welcome), (create_page_account_details),
2660 (create_page_user_details), (create_page_complete_easysetup),
2661 (create_page_custom_incoming), (create_page_custom_outgoing),
2662 (create_page_complete_custom),
2663 (modest_easysetup_wizard_dialog_init):
2664 * src/maemo/modest-account-settings-dialog.c:
2665 (create_page_account_details), (create_page_user_details),
2666 (create_page_incoming), (create_page_outgoing),
2667 (modest_account_settings_dialog_init):
2668 * src/maemo/modest-connection-specific-smtp-window.c:
2669 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2671 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/easysetup/modest-easysetup-wizard.c:
2674 (create_page_account_details), (create_page_custom_outgoing),
2675 (create_page_complete_custom):
2676 * src/maemo/modest-account-settings-dialog.c:
2677 (create_page_user_details), (create_page_incoming),
2678 (create_page_outgoing):
2679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2680 (modest_connection_specific_smtp_edit_window_init):
2681 Use the correct (UI spec) port min/max, and use horizontal separators,
2684 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2686 * src/maemo/easysetup/modest-easysetup-wizard.c:
2687 (set_default_custom_servernames):
2688 * src/maemo/modest-account-settings-dialog.c:
2689 (create_page_incoming), (on_combo_outgoing_security_changed),
2690 (on_combo_incoming_security_changed), (create_page_outgoing),
2691 (modest_account_settings_dialog_set_account_name),
2692 (save_configuration):
2693 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2694 (on_combo_security_changed),
2695 (modest_connection_specific_smtp_edit_window_init),
2696 (modest_connection_specific_smtp_edit_window_set_connection),
2697 (modest_connection_specific_smtp_edit_window_get_settings):
2698 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2701 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2704 * src/maemo/easysetup/modest-easysetup-wizard.c:
2705 (create_page_custom_outgoing), (create_page_complete_custom):
2706 * src/maemo/modest-account-settings-dialog.c:
2707 (create_page_user_details), (create_page_outgoing):
2708 * src/maemo/modest-account-view-window.c: (button_box_new):
2709 Use changed logical IDs as per the most recent UI spec:
2710 mcen_bd_emailsetup_edit -> mcen_bd_edit
2711 mcen_bd_emailsetup_delete -> mcen_bd_delete
2712 mcen_bd_emailsetup_close -> mcen_bd_close
2714 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2718 * src/dbus_api/Makefile.am:
2719 * src/dbus_api/modest-dbus-callbacks.c:
2720 * src/dbus_api/modest-dbus-callbacks.h:
2721 * src/maemo/modest-platform.c: (modest_platform_init):
2722 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2724 * tests/Makefile.am:
2725 * tests/dbus_api/Makefile.am:
2726 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2728 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2730 * src/maemo/modest-account-settings-dialog.c:
2731 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2732 Removed unnecessary includes.
2734 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/easysetup/modest-easysetup-wizard.c:
2737 * src/maemo/modest-account-settings-dialog.c:
2738 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2739 * src/widgets/Makefile.am:
2740 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2741 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2742 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2743 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2744 * src/widgets/modest-secureauth-combo-box.c:
2745 * src/widgets/modest-secureauth-combo-box.h:
2746 * src/widgets/modest-serversecurity-combo-box.c:
2747 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2748 made the GObject names more consistent with the rest of the Modest code.
2750 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/easysetup/Makefile.am:
2753 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2754 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2755 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2756 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2757 * src/maemo/easysetup/modest-easysetup-wizard.c:
2758 * src/maemo/easysetup/modest-validating-entry.c:
2759 * src/maemo/easysetup/modest-validating-entry.h:
2760 * src/maemo/modest-account-settings-dialog.c:
2761 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2762 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2763 widgets/ because they are used outside of easysetup too. After checking in,
2764 svn will allow me to rename them too.
2766 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2768 * src/gnome/modest-msg-edit-window.c:
2769 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2770 linker error, to fix the build on the GNOME platform.
2771 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2772 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2773 ifdefed out to avoid a warning.
2775 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2777 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2778 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2779 some alternative for GTK+ 2.6.
2781 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2783 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2785 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2786 specified for EmailAccountsDialog in UI spec.
2788 * src/maemo/easysetup/modest-easysetup-wizard.c:
2789 * src/maemo/easysetup/modest-easysetup-wizard.h:
2790 * src/maemo/modest-account-settings-dialog.c:
2791 * src/maemo/modest-account-settings-dialog.h:
2792 Reuse a member window widget for the connection-specific SMTP server accounts,
2793 so we can tell it to create/save the accounts only if we actually save changes.
2795 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2797 (modest_connection_specific_smtp_edit_window_get_settings):
2798 Return a struct instance for temporarily remembering the entered data.
2800 * src/maemo/modest-connection-specific-smtp-window.h:
2801 * src/maemo/modest-connection-specific-smtp-window.c:
2802 (modest_connection_specific_smtp_window_finalize),
2803 (modest_connection_specific_smtp_window_fill_with_connections),
2805 (modest_connection_specific_smtp_window_save_server_accounts),
2806 (update_model_server_names): Do not actually save data until asked,
2807 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2809 (on_selection_changed),
2810 (modest_connection_specific_smtp_window_init): Disable the edit
2811 button when nothing is selected.
2813 * src/modest-account-mgr-helpers.c:
2814 * src/modest-account-mgr-helpers.h:
2815 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2818 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2820 * src/modest-account-mgr-helpers.h:
2821 * src/modest-account-mgr-helpers.c:
2822 (modest_account_mgr_get_unused_account_name),
2823 (modest_account_mgr_get_unused_account_display_name): Added these
2824 utility functions, to avoid code duplication.
2826 * src/maemo/easysetup/modest-easysetup-wizard.c:
2827 (create_page_account_details), (create_account):
2828 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2829 (on_combo_security_changed),
2830 (modest_connection_specific_smtp_edit_window_init),
2831 (modest_connection_specific_smtp_edit_window_save_settings):
2832 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2833 * src/maemo/modest-connection-specific-smtp-window.c:
2834 (modest_connection_specific_smtp_window_finalize),
2835 (modest_connection_specific_smtp_window_fill_with_connections),
2836 (on_button_edit), (modest_connection_specific_smtp_window_init):
2837 * src/maemo/modest-connection-specific-smtp-window.h:
2838 Implementing saving of connection-specific server accounts.
2840 But I need to refactor this so we can save the data for each
2841 possible connection-specific account and only actually create the server accounts
2842 when the easysetup finished, or the OK button is pressed on the account settings
2845 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2848 (on_combo_security_changed):
2849 (modest_connection_specific_smtp_edit_window_init):
2850 Auto-fill the port number as in the account settings.
2852 (modest_connection_specific_smtp_edit_window_set_connection):
2853 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2854 * src/maemo/modest-connection-specific-smtp-window.c:
2855 (fill_with_connections), (on_button_edit),
2856 (modest_connection_specific_smtp_window_init):
2857 Turn the edit window into a dialog to simplify the code, and
2858 set a WM hint as in a GtkDialog, because only a popup can be on top of
2859 another window in Maemo, and popups usually have no WM decoration.
2861 * src/modest-defs.h:
2862 * src/modest-account-mgr-helpers.c:
2863 (modest_account_mgr_set_connection_specific_smtp),
2864 (modest_account_mgr_remove_connection_specific_smtp),
2865 (modest_account_mgr_get_connection_specific_smtp):
2866 * src/modest-account-mgr-helpers.h: Some functions to write the
2867 connection-specific SMTP server information. Not yet used.
2870 * src/widgets/modest-folder-view.c: (text_cell_data):
2871 Fix a warning about an uninitialized variable.
2872 (on_configuration_key_changed): Put an #ifdef around the use
2873 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2875 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/modest-account-settings-dialog.h:
2878 * src/maemo/modest-account-settings-dialog.c:
2879 Added connect_for_modified() utility function to mark the new modified boolean.
2881 (create_page_account_details), (create_page_user_details),
2882 (create_page_incoming), (create_page_outgoing), (on_response),
2883 (modest_account_settings_dialog_init),
2884 (modest_account_settings_dialog_set_account_name):
2885 Only warn about unsaved changes when there are actually unsaved changes.
2887 * src/modest-account-mgr-helpers.c:
2888 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2889 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2890 to get the data from there in future.
2892 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2894 * src/modest-defs.h:
2896 * src/modest-account-mgr-helpers.h:
2897 * src/modest-account-mgr-helpers.c:
2898 Store the security account setting in a single conf key instead of using
2899 the options list, so that the list is left for just the to-be-removed camel hack,
2900 and because gconf_client_set_list() is failing for some reason.
2902 * src/modest-account-mgr.c:
2903 (modest_account_mgr_add_server_account):
2904 * src/maemo/modest-account-settings-dialog.c:
2905 (modest_account_settings_dialog_set_account_name),
2906 (save_configuration): Use the renamed functions.
2909 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2911 * src/widgets/Makefile.am:
2912 * src/widgets/modest-limit-retrieve-combo-box.c:
2913 * src/widgets/modest-limit-retrieve-combo-box.h:
2914 * src/widgets/modest-retrieve-combo-box.c:
2915 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2916 the account settings dialog.
2918 * src/modest-defs.h:
2919 * src/modest-account-mgr-helpers.h:
2920 * src/modest-account-mgr-helpers.c:
2921 (modest_server_account_get_option_secure_auth),
2922 (modest_server_account_set_option_secure_auth):
2923 * src/modest-account-mgr.c:
2924 (modest_account_mgr_add_server_account):
2925 Use the existing AUTH_MECH conf key for the secure-auth setting,
2926 instead of putting it in the list options, because this was actually used already.
2928 * src/maemo/modest-account-settings-dialog.c:
2929 (create_page_account_details),
2930 (modest_account_settings_dialog_set_account_name),
2931 (save_configuration):
2932 * src/maemo/modest-account-settings-dialog.h:
2933 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2934 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2936 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2938 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2939 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2940 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2942 * src/modest-defs.h:
2943 * src/maemo/modest-account-settings-dialog.c:
2944 (create_page_incoming), (on_combo_outgoing_security_changed),
2945 (on_combo_incoming_security_changed), (create_page_outgoing),
2946 (modest_account_settings_dialog_set_account_name),
2947 (save_configuration): Load/Save the port number, and change it when the
2948 security combo changes, to suitable defaults.
2950 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2952 * src/modest-account-mgr.c:
2953 (modest_account_mgr_add_server_account): Set the security and secure-auth
2954 options, and add a comment saying that the other camel-specific options should be
2957 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2959 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2961 * src/modest-tny-account-store.c: (account_list_free),
2962 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2963 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2966 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2968 * src/modest-protocol-info.c:
2969 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2970 is required by our UI spec. Maybe something in our implementation will use this eventually.
2971 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2972 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2973 instead of the previous 0 placeholder.
2975 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2976 secure-auth settings.
2977 * src/modest-account-mgr-helpers.h:
2978 * src/modest-account-mgr-helpers.c:
2979 (modest_server_account_data_get_option_secure_auth),
2980 (modest_server_account_set_option_secure_auth),
2981 (modest_server_account_data_get_option_security),
2982 (modest_server_account_set_option_security): Added this API for getting and setting the security
2983 and secure-auth settings.
2985 * src/maemo/modest-account-settings-dialog.h:
2986 * src/maemo/modest-account-settings-dialog.c:
2987 (modest_account_settings_dialog_finalize), (check_data),
2988 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2989 about changing titles.
2990 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2991 (save_configuration): Save the security and secure-auth settings.
2993 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2994 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2996 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-defs.h:
2999 * src/modest-account-mgr.c:
3000 (modest_account_mgr_add_server_account):
3001 Added and used defines for the options key and value pair strings,
3002 that are used so far, though they do not seem to correspond to anything in our
3003 UI specs or ModestProtocol enum.
3005 * src/modest-account-mgr-helpers.h:
3006 * src/modest-account-mgr-helpers.c:
3007 (compare_option_strings_for_name),
3008 (modest_server_account_data_get_option_value),
3009 (modest_server_account_data_get_option_bool),
3010 (modest_account_mgr_get_server_account_option):
3011 Added helper functions for parsing the options GSList.
3013 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3015 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3016 display name is based on the supplied account name.
3017 * src/modest-account-mgr.c:
3018 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3019 with an inefficient, but good-enough, implementation.
3021 * src/maemo/easysetup/modest-easysetup-wizard.c:
3022 (create_page_account_details), (on_before_next), (create_account):
3023 Check for existing display names rather than (non-user-visible) account names, and just
3024 create and set a unique account name at the end.
3026 * src/maemo/modest-account-settings-dialog.c:
3027 (modest_account_settings_dialog_init),
3028 (modest_account_settings_dialog_set_account_name),
3029 (create_page_incoming): Show the display name, instead of the account name.
3030 (on_response): Do some (not all) extra checks, as in the UI spec.
3031 (save_configuration): Save the display name if it was changed.
3033 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3035 * po/en_GB.po: Added needed logical ID and translation.
3036 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3037 (init_view): Made the is-default column clicking work.
3039 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3042 * src/maemo/easysetup/Makefile.am:
3043 * src/maemo/easysetup/modest-easysetup-wizard.c:
3044 (modest_easysetup_wizard_dialog_init):
3045 * src/maemo/easysetup/provider-data-test.keyfile:
3046 * src/maemo/easysetup/provider-data.keyfile:
3047 Moved the provider data file to the new modest-providers-data package and used it from there.
3049 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-local-folder-info.c:
3052 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3053 N_() was already used on the static strings, but this just marks it for translation without
3054 using the translation.
3056 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3058 * src/maemo/modest-account-settings-dialog.c:
3059 (create_page_incoming),
3060 (modest_account_settings_dialog_set_account_name):
3061 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3062 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3063 I will do this if nobody else gets there first.
3065 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3068 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3069 save the security stuff.
3071 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3074 Set the email address and user fullname, which I now see must be
3077 * src/maemo/modest-account-settings-dialog.h:
3078 * src/maemo/modest-account-settings-dialog.c:
3080 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3081 leave-on-server and authentication.
3082 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3085 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3088 * src/maemo/modest-account-settings-dialog.c:
3089 * src/maemo/modest-account-settings-dialog.h:
3090 Most (but not all) of the widgets are now present as specified by the UI spec.
3091 No changes are yet saved, and some details are not properly shown yet.
3093 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3095 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3097 * src/maemo/Makefile.am:
3098 * src/maemo/modest-account-settings-dialog.c:
3099 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3100 an existing account. Doesn't do much yet.
3102 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3103 Open the accounts settings dialog when Edit is clicked.
3105 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/easysetup/Makefile.am:
3108 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3110 * src/maemo/easysetup/modest-easysetup-wizard.c:
3111 (modest_easysetup_wizard_dialog_init):
3112 Try to get the source directory from the build system,
3113 instead of hard-coding "./" into the source code, when opening our local
3114 copies of the configuration files.
3115 But this still fails when opening the wizard from the Accounts window,
3116 maybe because the working directory seems to change at runtime.
3117 So the wizard will fail the second time unless you copy the files into their
3118 proper locations - see the stdout warnings for the paths.
3120 (create_page_account_details),(on_before_next):
3121 Check for existing non-server accounts instead of server accounts,
3122 so the default account name is useful again, and to prevent trying to
3125 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3126 Show the wizard when New is clicked.
3128 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3129 (init_view): Show the column headers, and show the columns that are
3130 specified in the UI specs. However, something in Maemo's GTK+ prevents
3131 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3132 change the default account. This is despite unsetting the special properties.
3134 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3136 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3137 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3138 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3139 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3140 to make that clearer.
3141 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3143 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3145 * src/maemo/modest-account-view-window.c:
3146 (modest_account_view_window_init),
3147 (modest_account_view_window_new):
3148 Use the same buttons as specified in the
3149 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3150 the existing widgets, which never had a chance of working.
3151 Put the ModestAccountView treeview in a scrolled window.
3152 Do not repeat the initialization in both _init() and _new().
3154 * src/widgets/modest-account-view.c: (update_account_view):
3155 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3156 this widget and window shows no accounts.
3158 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3160 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3162 * src/maemo/easysetup/modest-easysetup-wizard.c:
3163 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3164 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3165 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3168 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3169 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3170 accounts exist yet, as in the UI spec.
3172 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3174 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3176 * src/maemo/Makefile.am:
3177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3178 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3179 New window for editing connection-specific smtp details.
3180 Not fully implemented.
3182 * src/maemo/modest-connection-specific-smtp-window.c:
3183 (modest_connection_specific_smtp_window_finalize) :
3184 unref the tree model.
3185 (on_button_edit): Show the edit window.
3187 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3189 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3192 * src/maemo/Makefile.am:
3193 * src/maemo/modest-connection-specific-smtp-window.c:
3194 * src/maemo/modest-connection-specific-smtp-window.h:
3195 New window for showing the list of connections, for connection-specific
3196 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3197 * src/maemo/easysetup/modest-easysetup-wizard.c:
3198 (create_page_custom_outgoing): Show the new window when the button is clicked.
3200 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3202 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3203 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3204 * src/maemo/modest-msg-edit-window.c:
3205 (modest_msg_edit_window_insert_image):
3206 * src/modest-conf.c: (modest_conf_key_escape):
3207 * src/modest-mail-operation.c:
3208 (modest_mail_operation_send_new_mail):
3209 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3210 (modest_ui_actions_on_new_account):
3211 * src/widgets/modest-attachment-view.c: (update_filename_request):
3212 * src/widgets/modest-mail-header-view.c:
3213 Corrected warnings that were breaking the build, by commenting out unused variables,
3214 and a function, and by including a header.
3216 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3218 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3219 so we can #ifdef around platform-specific code when necessary.
3220 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3221 to allow this to build for the GNOME platform too.
3223 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/easysetup/modest-easysetup-wizard.c:
3226 Added util_increment_name() and used it in create_page_account_details()
3227 to make sure that the default account name is always a new name.
3229 (modest_easysetup_wizard_dialog_init),
3230 (set_default_custom_servernames): Some minor memory management fixes.
3232 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3236 * src/modest-runtime.c: (init_i18n): Restored the translation
3237 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3238 are defined in config.h, and the translations are installed.
3240 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3241 is defined for translation.
3243 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3245 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3247 * src/maemo/easysetup/modest-easysetup-wizard.c:
3248 (modest_easysetup_wizard_dialog_init):
3249 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3250 Use realistic paths (though they should use $prefix generically) to the
3251 mcc_mapping and provider-data.keyfile files which might work when they
3252 are installed by the future version of the operator-wizard package,
3253 and then fallback to paths in our source code, with an explanatory
3256 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3260 * src/maemo/Makefile.am:
3261 * src/maemo/easysetup/: Added files from the previously-exernal
3262 osso-modest-easysetup.
3263 * src/maemo/modest-main-window-ui.h:
3264 * src/modest-ui-actions.c:
3265 * src/modest-ui-actions.h:
3266 Added modest_ui_actions_on_new_account() as a signal handler for the
3267 New Account menu item. It shows the easysetup wizard.
3268 * po/en_GB.po: Added additional needed logical IDs and translations.