git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-account-mgr.h:
   4         * src/modest-account-mgr.c:
   5         (modest_account_mgr_account_names): Add a gboolean enabled_only
   6         parameter, so we can get lists of onlt the enabled accounts.
   7
   8         (modest_account_mgr_add_account),,
   9         (modest_account_mgr_account_with_display_name_exists):
  10         * src/maemo/modest-msg-edit-window.c: (get_transports):
  11         * src/modest-account-mgr-helpers.c:
  12         (modest_account_mgr_set_first_account_as_default):
  13         * src/modest-init.c: (init_default_account_maybe):
  14         * src/modest-tny-account-store.c: (get_accounts):
  15         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
  16         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
  17         * tests/check_account-mgr.c: (START_TEST):
  18         Provide the extra parameter, as appropriate.
  19
  20         * src/widgets/modest-account-view.c: (update_account_view):
  21         Do not show disabled accounts (meaning that there is no way to
  22         enable/disable accounts in the UI (the feature is not in our UI
  23         specification), so we can use this internally only to mark unfinished
  24         or temporary account data.
  25
  26         * src/maemo/easysetup/modest-easysetup-wizard.c:
  27         (create_account): Add boolean enable parameter, so we can specify FALSE
  28         to create the temporary account.
  29         (on_button_edit_advanced_settings): Create the temporary account as disabled.
  30         (on_before_next): When finishing, when there is a temporary account, just
  31         set it as enabled.
  32         Also, use a timeout to delay the showing of the dialog until gconf is likely
  33         to return correct information, due to a maemo gconf bug that is fixed in
  34         osso 1.1, but not yet in Bora.
  35         However, the dialog stays on screen after it is destroyed.
  36
  37         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
  38         for invalid data when cancelling. Use a hildon note instead of a dialog
  39         to complain about invalid data. Do not show the account-saved note if the
  40         account is disabled (a temporary account that will not really be saved for use
  41         until later.)
  42
  43 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  44
  45         * src/modest-account-mgr-helpers.h:
  46         * src/modest-account-mgr-helpers.c:
  47         Added modest_account_mgr_unset_default_account(),
  48         Added modest_account_mgr_set_first_account_as_default().
  49
  50         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
  51         If it was the default account, unset the default account name.
  52
  53         * src/maemo/modest-account-view-window.c:
  54         (on_delete_button_clicked): If it was the default account,
  55         set the first remaining account as the default instead.
  56
  57         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
  58         a NULL account or a NULL default account, to prevent a crash. This should
  59         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
  60
  61
  62 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  63
  64         * src/widgets/modest-recpt-editor.c:
  65         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
  66         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
  67         TODO comment for this. This fixes the build.
  68
  69         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
  70         be the best place for it. This will in future update all auto-update accounts,
  71         rather than just the current/default account, when that gconf key exists.
  72         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
  73         if there are no accounts, before calling do_send_receive().
  74         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
  75
  76         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
  77         * src/maemo/modest-main-window-ui.h:
  78         * src/maemo/modest-main-window.c: (on_connection_changed),
  79         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
  80         directly, becaue the signal handler does more.
  81
  82 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  83
  84         * src/modest-account-mgr-helpers.c:
  85         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
  86         for the case that the account does not exist.
  87
  88         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
  89         (equivalent to the modest account name) rather than the tinymail account name
  90         (equivalent to the modest account title - human readable) to get the account data.
  91         Check for null account data to prevent the crash, and add a TODO comment saying that
  92         this needs fixing because it is using the server account name instead of the account name.
  93
  94 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
  95
  96         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
  97         * src/maemo/modest-account-settings-dialog.c: (show_error),
  98         (show_ok):
  99         Use hildon_note_new_information() for informative and error messages,
 100         which seems to be expected for Maemo applications (no documentation that I know of
 101         says this). I am surprised that there is no distinction between info and error
 102         dialogs.
 103
 104 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 105
 106         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 107         it is easy to find where this is used.
 108
 109         * src/maemo/easysetup/modest-easysetup-wizard.c:
 110         (create_page_welcome), (create_page_account_details),
 111         (create_page_user_details), (create_page_complete_easysetup),
 112         (create_page_custom_incoming), (create_page_custom_outgoing),
 113         (create_page_complete_custom):
 114         * src/maemo/modest-account-settings-dialog.c:
 115         (create_page_account_details), (create_page_user_details),
 116         (create_page_incoming), (create_page_outgoing):
 117         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 118         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 119         (modest_connection_specific_smtp_edit_window_init):
 120         * src/maemo/modest-connection-specific-smtp-window.c:
 121         (modest_connection_specific_smtp_window_init):
 122         * src/maemo/modest-signature-editor-dialog.c:
 123         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 124         and scrolling policy as per the Email Application Layout Guide, if I have
 125         understood it.
 126
 127 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 128
 129         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 130         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 131         which were empty, because these vfuncs have been removed from TnyAccountStore.
 132         This fixes the build.
 133
 134 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 135
 136         * src/maemo/modest-main-window.c:
 137         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 138         showing/hiding it. Added TODO because it probably should not be NULL.
 139         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 140         because unnecessary g_warnings() make degugging difficult.
 141
 142 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 143
 144         * src/maemo/modest-msg-edit-window.c:
 145         (modest_msg_edit_window_select_color),
 146         (modest_msg_edit_window_select_background_color): 2 const corrections and
 147         moving 2 #endifs before closing brackets, to fix the build.
 148
 149 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 150
 151         * src/maemo/easysetup/modest-easysetup-wizard.h:
 152         * src/maemo/easysetup/modest-easysetup-wizard.c:
 153         (modest_easysetup_wizard_dialog_finalize),
 154         (on_button_edit_advanced_settings), (create_page_complete_custom),
 155         (on_response), (create_account):
 156         Implement the Advanced Settings edit button, by saving the account information,
 157         for the Advanded Settings dialog to use directly from gconf, and removing it
 158         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 159         Bug #5533 in the projects.maemo.org bugzilla.
 160
 161 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 162
 163         * src/maemo/modest-msg-view-window.c:
 164         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 165         when opening a message window.
 166
 167 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * src/maemo/easysetup/modest-easysetup-wizard.c:
 170         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 171         match the UI spec.
 172
 173         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 174         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 175         gconf settings. I probably added more checks than necessary, but that is safer.
 176
 177         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 178         variable to fix the build, but this seems to be used when it is still NULL.
 179
 180 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 181
 182         * src/modest-platform.h:
 183         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 184         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 185         * src/modest-main.c: Implement this function so we can avoid using
 186         maemo-specific API from cross-platform code.
 187         (main):
 188         * src/modest-tny-account-store.c:
 189         (get_smtp_specific_transport_account_for_open_connection):
 190         * src/modest-ui-actions.c: (check_for_connection),
 191         (modest_ui_actions_on_item_not_found):
 192         Use modest_platform_connect_and_wait() and put #idefs around other
 193         maemo-specific code, because only maemo currently has a way to
 194         identify connection names.
 195
 196 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 197
 198         * src/modest-tny-account-store.h:
 199         * src/modest-tny-account-store.c:
 200         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 201         the connection-specific SMTP server settings in the configuration.
 202
 203         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 204         (on_idle_mail_to):
 205         * src/maemo/modest-main-window.c: (on_connection_changed),
 206         (connect_signals):
 207         * src/modest-main.c: (main), (start_ui), (send_mail):
 208         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 209         that is what is intended.
 210
 211         * src/modest-ui-actions.c: (action_send), (action_receive),
 212         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 213         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 214         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 215         SMTP server is used when it is specified.
 216
 217         (modest_ui_actions_on_send_receive):
 218         Check that a connection is open before proceeding.
 219         Receive and then send, instead of vice-versa, as per the specification.
 220
 221 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 222
 223         * src/modest-mail-operation.c:
 224         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 225         though I guess it should be something other than NULL.
 226
 227 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 228
 229         * src/maemo/easysetup/modest-easysetup-wizard.c:
 230         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 231         combo twice, to avoid an g_warning and to make it visible again.
 232         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 233         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 234         (already intended) dereference when detaching, because we then recreate the menu.
 235         But I am not sure why the warning was happening, and it is possible that this is a memory
 236         leak.
 237
 238 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 239
 240         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 241         and uri_parse_mailto() utility functions.
 242         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 243         the mailto URI.
 244         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 245
 246 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 247
 248         * src/dbus_api/modest-dbus-api.h:
 249         * src/dbus_api/modest-dbus-callbacks.c:
 250         Use an idle callback to execute the modest code in the application's own thread.
 251         Remove the helloworld example method.
 252         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 253         parsed, and the open-message method is not implemented because this is not yet implemented in
 254         modest itself.
 255         * libmodest-dbus-client/libmodest-dbus-client.c:
 256         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 257         (libmodest_dbus_client_open_message):
 258         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 259
 260         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 261         body without crashing.
 262
 263         * tests/dbus_api/Makefile.am:
 264         * tests/dbus_api/test_mail_to.c:
 265         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 266
 267 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 268
 269         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 270         Added file to fix the build. Sorry.
 271
 272         * src/dbus_api/Makefile.am:
 273         * src/dbus_api/modest-dbus-api.h:
 274         * src/dbus_api/modest-dbus-callbacks.h:
 275         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 276         (modest_dbus_req_handler):
 277         Put constants in a separate header so it can be reused by the
 278         client library, without duplication
 279
 280         * libmodest-dbus-client/Makefile.am:
 281         * libmodest-dbus-client/libmodest-dbus-client.c:
 282         (libmodest_dbus_client_call_helloworld),
 283         (libmodfest_dbus_client_send_mail),
 284         (libmodfest_dbus_client_mailto),
 285         (libmodfest_dbus_client_open_message):
 286         * libmodest-dbus-client/libmodest-dbus-client.h:
 287         (Partly) Implement a send_mail D-Bus method.
 288
 289         * tests/dbus_api/Makefile.am:
 290         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 291         the send_email D-Bus method.
 292
 293 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 294
 295         * Makefile.am:
 296         * configure.ac:
 297         * libmodest-dbus-client/Makefile.am:
 298         * libmodest-dbus-client/libmodest-dbus-client.c:
 299         * libmodest-dbus-client/libmodest-dbus-client.h:
 300         * tests/dbus_api/Makefile.am:
 301         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 302         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 303
 304 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 305
 306         * src/maemo/easysetup/modest-easysetup-wizard.c:
 307         (create_page_account_details):
 308         * src/maemo/modest-account-settings-dialog.c:
 309         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 310         widgets, because this might not be the default in future versions of the Maemo GTK+.
 311         However, I can not not get capitalization to work even in a simple test case.
 312
 313 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 314
 315         * src/maemo/easysetup/modest-easysetup-wizard.c:
 316         (create_page_custom_incoming), (create_page_custom_outgoing):
 317         * src/maemo/modest-account-settings-dialog.c:
 318         (create_page_account_details), (create_page_incoming),
 319         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 320         instead of using gtk_check_button_with_label(), so they are aligned like the other
 321         widgets, as per the UI spec.
 322
 323 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 324
 325         * src/maemo/easysetup/modest-easysetup-wizard.c:
 326         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 327         * src/widgets/modest-validating-entry.c:
 328         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 329         Modest prefix instead of an EasySetup prefix.
 330
 331 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 332
 333         * src/widgets/modest-validating-entry.h:
 334         * src/widgets/modest-validating-entry.c: (on_insert_text),
 335         Added easysetup_validating_entry_set_max_func(), used to set a callback
 336         to call when the max number of characters is reached. GtkEntry has a max-length
 337         already but is silent about it.
 338
 339         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 340         (create_page_account_details), (create_page_user_details),
 341         (create_account):
 342         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 343         (create_page_account_details), (create_page_user_details),
 344         (create_page_outgoing):
 345         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 346         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 347         the UI spec, when the user tries to enter more than the max number of characters.
 348
 349 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 350
 351         * src/maemo/easysetup/modest-easysetup-wizard.c:
 352         (create_page_user_details), (create_page_custom_incoming),
 353         (create_page_custom_outgoing):
 354         * src/maemo/modest-account-settings-dialog.c:
 355         (create_page_user_details), (create_page_incoming),
 356         (create_page_outgoing):
 357         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 358         (modest_connection_specific_smtp_edit_window_init):
 359         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 360         not appropriate. Bad Maemo-specific defaults!.
 361
 362 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 363
 364         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 365         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 366         (modest_signature_editor_dialog_set_settings):
 367         Disable the label and textview when the checkbox is disabled, and use the
 368         specified (UI spec) default signature text.
 369
 370 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 371
 372         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 373         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 374
 375         * src/modest-defs.h:
 376         * src/modest-account-mgr-helpers.h:
 377         * src/modest-account-mgr-helpers.c:
 378         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 379
 380         * src/maemo/Makefile.am:
 381         * src/maemo/modest-signature-editor-dialog.c:
 382         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 383         as per the UI spec.
 384
 385         * src/maemo/modest-account-settings-dialog.h:
 386         * src/maemo/modest-account-settings-dialog.c:
 387         (modest_account_settings_dialog_finalize), (on_button_signature),
 388         (save_configuration): Use the new dialog when the Edit button is pressed, and
 389         save the changes if necessary, as per the UI spec.
 390
 391 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 392
 393         * src/maemo/Makefile.am:
 394         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 395         based on maemo-develoers email from Dirk.
 396
 397         * src/maemo/easysetup/modest-easysetup-wizard.c:
 398         (create_page_welcome), (create_page_account_details),
 399         (create_page_user_details), (create_page_complete_easysetup),
 400         (create_page_custom_incoming), (create_page_custom_outgoing),
 401         (create_page_complete_custom),
 402         (modest_easysetup_wizard_dialog_init):
 403         * src/maemo/modest-account-settings-dialog.c:
 404         (create_page_account_details), (create_page_user_details),
 405         (create_page_incoming), (create_page_outgoing),
 406         (modest_account_settings_dialog_init):
 407         * src/maemo/modest-connection-specific-smtp-window.c:
 408         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 409
 410 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 411
 412         * src/maemo/easysetup/modest-easysetup-wizard.c:
 413         (create_page_account_details), (create_page_custom_outgoing),
 414         (create_page_complete_custom):
 415         * src/maemo/modest-account-settings-dialog.c:
 416         (create_page_user_details), (create_page_incoming),
 417         (create_page_outgoing):
 418         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 419         (modest_connection_specific_smtp_edit_window_init):
 420         Use the correct (UI spec) port min/max, and use horizontal separators,
 421         as per the UI spec.
 422
 423 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 424
 425         * src/maemo/easysetup/modest-easysetup-wizard.c:
 426         (set_default_custom_servernames):
 427         * src/maemo/modest-account-settings-dialog.c:
 428         (create_page_incoming), (on_combo_outgoing_security_changed),
 429         (on_combo_incoming_security_changed), (create_page_outgoing),
 430         (modest_account_settings_dialog_set_account_name),
 431         (save_configuration):
 432         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 433         (on_combo_security_changed),
 434         (modest_connection_specific_smtp_edit_window_init),
 435         (modest_connection_specific_smtp_edit_window_set_connection),
 436         (modest_connection_specific_smtp_edit_window_get_settings):
 437         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 438         as per the UI spec.
 439
 440 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 441
 442         * po/en_GB.po:
 443         * src/maemo/easysetup/modest-easysetup-wizard.c:
 444         (create_page_custom_outgoing), (create_page_complete_custom):
 445         * src/maemo/modest-account-settings-dialog.c:
 446         (create_page_user_details), (create_page_outgoing):
 447         * src/maemo/modest-account-view-window.c: (button_box_new):
 448         Use changed logical IDs as per the most recent UI spec:
 449         mcen_bd_emailsetup_edit -> mcen_bd_edit
 450         mcen_bd_emailsetup_delete -> mcen_bd_delete
 451         mcen_bd_emailsetup_close -> mcen_bd_close
 452
 453 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 454
 455         * configure.ac:
 456         * src/Makefile.am:
 457         * src/dbus_api/Makefile.am:
 458         * src/dbus_api/modest-dbus-callbacks.c:
 459         * src/dbus_api/modest-dbus-callbacks.h:
 460         * src/maemo/modest-platform.c: (modest_platform_init):
 461         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 462         method.
 463         * tests/Makefile.am:
 464         * tests/dbus_api/Makefile.am:
 465         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 466
 467 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 468
 469         * src/maemo/modest-account-settings-dialog.c:
 470         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 471         Removed unnecessary includes.
 472
 473 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 474
 475         * src/maemo/easysetup/modest-easysetup-wizard.c:
 476         * src/maemo/modest-account-settings-dialog.c:
 477         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 478         * src/widgets/Makefile.am:
 479         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 480         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 481         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 482         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 483         * src/widgets/modest-secureauth-combo-box.c:
 484         * src/widgets/modest-secureauth-combo-box.h:
 485         * src/widgets/modest-serversecurity-combo-box.c:
 486         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 487         made the GObject names more consistent with the rest of the Modest code.
 488
 489 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 490
 491         * src/maemo/easysetup/Makefile.am:
 492         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 493         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 494         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 495         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 496         * src/maemo/easysetup/modest-easysetup-wizard.c:
 497         * src/maemo/easysetup/modest-validating-entry.c:
 498         * src/maemo/easysetup/modest-validating-entry.h:
 499         * src/maemo/modest-account-settings-dialog.c:
 500         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 501         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 502         widgets/ because they are used outside of easysetup too. After checking in,
 503         svn will allow me to rename them too.
 504
 505 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 506
 507         * src/gnome/modest-msg-edit-window.c:
 508         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 509         linker error, to fix the build on the GNOME platform.
 510         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 511         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 512         ifdefed out to avoid a warning.
 513
 514 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 515
 516         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 517         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 518         some alternative for GTK+ 2.6.
 519
 520 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 521
 522         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 523
 524         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 525         specified for EmailAccountsDialog in UI spec.
 526
 527         * src/maemo/easysetup/modest-easysetup-wizard.c:
 528         * src/maemo/easysetup/modest-easysetup-wizard.h:
 529         * src/maemo/modest-account-settings-dialog.c:
 530         * src/maemo/modest-account-settings-dialog.h:
 531         Reuse a member window widget for the connection-specific SMTP server accounts,
 532         so we can tell it to create/save the accounts only if we actually save changes.
 533
 534         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 535         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 536         (modest_connection_specific_smtp_edit_window_get_settings):
 537         Return a struct instance for temporarily remembering the entered data.
 538
 539         * src/maemo/modest-connection-specific-smtp-window.h:
 540         * src/maemo/modest-connection-specific-smtp-window.c:
 541         (modest_connection_specific_smtp_window_finalize),
 542         (modest_connection_specific_smtp_window_fill_with_connections),
 543         (on_button_edit),
 544         (modest_connection_specific_smtp_window_save_server_accounts),
 545         (update_model_server_names): Do not actually save data until asked,
 546         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 547
 548         (on_selection_changed),
 549         (modest_connection_specific_smtp_window_init): Disable the edit
 550         button when nothing is selected.
 551
 552         * src/modest-account-mgr-helpers.c:
 553         * src/modest-account-mgr-helpers.h:
 554         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 555         elsewhere.
 556
 557 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 558
 559         * src/modest-account-mgr-helpers.h:
 560         * src/modest-account-mgr-helpers.c:
 561         (modest_account_mgr_get_unused_account_name),
 562         (modest_account_mgr_get_unused_account_display_name): Added these
 563         utility functions, to avoid code duplication.
 564
 565         * src/maemo/easysetup/modest-easysetup-wizard.c:
 566         (create_page_account_details), (create_account):
 567         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 568         (on_combo_security_changed),
 569         (modest_connection_specific_smtp_edit_window_init),
 570         (modest_connection_specific_smtp_edit_window_save_settings):
 571         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 572         * src/maemo/modest-connection-specific-smtp-window.c:
 573         (modest_connection_specific_smtp_window_finalize),
 574         (modest_connection_specific_smtp_window_fill_with_connections),
 575         (on_button_edit), (modest_connection_specific_smtp_window_init):
 576         * src/maemo/modest-connection-specific-smtp-window.h:
 577         Implementing saving of connection-specific server accounts.
 578
 579         But I need to refactor this so we can save the data for each
 580         possible connection-specific account and only actually create the server accounts
 581         when the easysetup finished, or the OK button is pressed on the account settings
 582         dialog.
 583
 584 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 585
 586         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 587         (on_combo_security_changed):
 588         (modest_connection_specific_smtp_edit_window_init):
 589         Auto-fill the port number as in the account settings.
 590
 591         (modest_connection_specific_smtp_edit_window_set_connection):
 592         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 593         * src/maemo/modest-connection-specific-smtp-window.c:
 594         (fill_with_connections), (on_button_edit),
 595         (modest_connection_specific_smtp_window_init):
 596         Turn the edit window into a dialog to simplify the code, and
 597         set a WM hint as in a GtkDialog, because only a popup can be on top of
 598         another window in Maemo, and popups usually have no WM decoration.
 599
 600         * src/modest-defs.h:
 601         * src/modest-account-mgr-helpers.c:
 602         (modest_account_mgr_set_connection_specific_smtp),
 603         (modest_account_mgr_remove_connection_specific_smtp),
 604         (modest_account_mgr_get_connection_specific_smtp):
 605         * src/modest-account-mgr-helpers.h: Some functions to write the
 606         connection-specific SMTP server information. Not yet used.
 607
 608
 609         * src/widgets/modest-folder-view.c: (text_cell_data):
 610         Fix a warning about an uninitialized variable.
 611         (on_configuration_key_changed): Put an #ifdef around the use
 612         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 613
 614 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 615
 616         * src/maemo/modest-account-settings-dialog.h:
 617         * src/maemo/modest-account-settings-dialog.c:
 618         Added connect_for_modified() utility function to mark the new modified boolean.
 619
 620         (create_page_account_details), (create_page_user_details),
 621         (create_page_incoming), (create_page_outgoing), (on_response),
 622         (modest_account_settings_dialog_init),
 623         (modest_account_settings_dialog_set_account_name):
 624         Only warn about unsaved changes when there are actually unsaved changes.
 625
 626         * src/modest-account-mgr-helpers.c:
 627         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 628         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 629         to get the data from there in future.
 630
 631 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 632
 633         * src/modest-defs.h:
 634
 635         * src/modest-account-mgr-helpers.h:
 636         * src/modest-account-mgr-helpers.c:
 637         Store the security account setting in a single conf key instead of using
 638         the options list, so that the list is left for just the to-be-removed camel hack,
 639         and because gconf_client_set_list() is failing for some reason.
 640
 641         * src/modest-account-mgr.c:
 642         (modest_account_mgr_add_server_account):
 643         * src/maemo/modest-account-settings-dialog.c:
 644         (modest_account_settings_dialog_set_account_name),
 645         (save_configuration): Use the renamed functions.
 646
 647
 648 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 649
 650         * src/widgets/Makefile.am:
 651         * src/widgets/modest-limit-retrieve-combo-box.c:
 652         * src/widgets/modest-limit-retrieve-combo-box.h:
 653         * src/widgets/modest-retrieve-combo-box.c:
 654         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 655         the account settings dialog.
 656
 657         * src/modest-defs.h:
 658         * src/modest-account-mgr-helpers.h:
 659         * src/modest-account-mgr-helpers.c:
 660         (modest_server_account_get_option_secure_auth),
 661         (modest_server_account_set_option_secure_auth):
 662         * src/modest-account-mgr.c:
 663         (modest_account_mgr_add_server_account):
 664         Use the existing AUTH_MECH conf key for the secure-auth setting,
 665         instead of putting it in the list options, because this was actually used already.
 666
 667         * src/maemo/modest-account-settings-dialog.c:
 668         (create_page_account_details),
 669         (modest_account_settings_dialog_set_account_name),
 670         (save_configuration):
 671         * src/maemo/modest-account-settings-dialog.h:
 672         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 673         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 674
 675 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 676
 677         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 678         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 679         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 680
 681         * src/modest-defs.h:
 682         * src/maemo/modest-account-settings-dialog.c:
 683         (create_page_incoming), (on_combo_outgoing_security_changed),
 684         (on_combo_incoming_security_changed), (create_page_outgoing),
 685         (modest_account_settings_dialog_set_account_name),
 686         (save_configuration): Load/Save the port number, and change it when the
 687         security combo changes, to suitable defaults.
 688
 689 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 690
 691         * src/modest-account-mgr.c:
 692         (modest_account_mgr_add_server_account): Set the security and secure-auth
 693         options, and add a comment saying that the other camel-specific options should be
 694         removed in future.
 695
 696 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 697
 698         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 699         found by valgrind.
 700         * src/modest-tny-account-store.c: (account_list_free),
 701         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 702         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 703         easy to fix.
 704
 705 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 706
 707         * src/modest-protocol-info.c:
 708         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 709         is required by our UI spec. Maybe something in our implementation will use this eventually.
 710         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 711         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 712         instead of the previous 0 placeholder.
 713
 714         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 715         secure-auth settings.
 716         * src/modest-account-mgr-helpers.h:
 717         * src/modest-account-mgr-helpers.c:
 718         (modest_server_account_data_get_option_secure_auth),
 719         (modest_server_account_set_option_secure_auth),
 720         (modest_server_account_data_get_option_security),
 721         (modest_server_account_set_option_security): Added this API for getting and setting the security
 722         and secure-auth settings.
 723
 724         * src/maemo/modest-account-settings-dialog.h:
 725         * src/maemo/modest-account-settings-dialog.c:
 726         (modest_account_settings_dialog_finalize), (check_data),
 727         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 728         about changing titles.
 729         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 730         (save_configuration): Save the security and secure-auth settings.
 731
 732         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 733         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 734
 735 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 736
 737         * src/modest-defs.h:
 738         * src/modest-account-mgr.c:
 739         (modest_account_mgr_add_server_account):
 740         Added and used defines for the options key and value pair strings,
 741         that are used so far, though they do not seem to correspond to anything in our
 742         UI specs or ModestProtocol enum.
 743
 744         * src/modest-account-mgr-helpers.h:
 745         * src/modest-account-mgr-helpers.c:
 746         (compare_option_strings_for_name),
 747         (modest_server_account_data_get_option_value),
 748         (modest_server_account_data_get_option_bool),
 749         (modest_account_mgr_get_server_account_option):
 750         Added helper functions for parsing the options GSList.
 751
 752 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 753
 754         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 755         display name is based on the supplied account name.
 756         * src/modest-account-mgr.c:
 757         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 758         with an inefficient, but good-enough, implementation.
 759
 760         * src/maemo/easysetup/modest-easysetup-wizard.c:
 761         (create_page_account_details), (on_before_next), (create_account):
 762         Check for existing display names rather than (non-user-visible) account names, and just
 763         create and set a unique account name at the end.
 764
 765         * src/maemo/modest-account-settings-dialog.c:
 766         (modest_account_settings_dialog_init),
 767         (modest_account_settings_dialog_set_account_name),
 768         (create_page_incoming): Show the display name, instead of the account name.
 769         (on_response): Do some (not all) extra checks, as in the UI spec.
 770         (save_configuration): Save the display name if it was changed.
 771
 772 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 773
 774         * po/en_GB.po: Added needed logical ID and translation.
 775         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 776         (init_view): Made the is-default column clicking work.
 777
 778 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 779
 780         * configure.ac:
 781         * src/maemo/easysetup/Makefile.am:
 782         * src/maemo/easysetup/modest-easysetup-wizard.c:
 783         (modest_easysetup_wizard_dialog_init):
 784         * src/maemo/easysetup/provider-data-test.keyfile:
 785         * src/maemo/easysetup/provider-data.keyfile:
 786         Moved the provider data file to the new modest-providers-data package and used it from there.
 787
 788 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 789
 790         * src/modest-local-folder-info.c:
 791         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 792         N_() was already used on the static strings, but this just marks it for translation without
 793         using the translation.
 794
 795 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 796
 797         * src/maemo/modest-account-settings-dialog.c:
 798         (create_page_incoming),
 799         (modest_account_settings_dialog_set_account_name):
 800         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 801         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 802         I will do this if nobody else gets there first.
 803
 804 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 805
 806         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 807         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 808         save the security stuff.
 809
 810 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 811
 812         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 813         Set the email address and user fullname, which I now see must be
 814         done separately.
 815
 816         * src/maemo/modest-account-settings-dialog.h:
 817         * src/maemo/modest-account-settings-dialog.c:
 818          (on_response),
 819         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 820         leave-on-server and authentication.
 821         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 822         how to do the rest.
 823
 824 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 825
 826
 827         * src/maemo/modest-account-settings-dialog.c:
 828         * src/maemo/modest-account-settings-dialog.h:
 829         Most (but not all) of the widgets are now present as specified by the UI spec.
 830         No changes are yet saved, and some details are not properly shown yet.
 831
 832         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 833
 834 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 835
 836         * src/maemo/Makefile.am:
 837         * src/maemo/modest-account-settings-dialog.c:
 838         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 839         an existing account. Doesn't do much yet.
 840
 841         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 842         Open the accounts settings dialog when Edit is clicked.
 843
 844 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 845
 846         * src/maemo/easysetup/Makefile.am:
 847         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 848         (load_from_file):
 849         * src/maemo/easysetup/modest-easysetup-wizard.c:
 850         (modest_easysetup_wizard_dialog_init):
 851         Try to get the source directory from the build system,
 852         instead of hard-coding "./" into the source code, when opening our local
 853         copies of the configuration files.
 854         But this still fails when opening the wizard from the Accounts window,
 855         maybe because the working directory seems to change at runtime.
 856         So the wizard will fail the second time unless you copy the files into their
 857         proper locations - see the stdout warnings for the paths.
 858
 859         (create_page_account_details),(on_before_next):
 860         Check for existing non-server accounts instead of server accounts,
 861         so the default account name is useful again, and to prevent trying to
 862         recreate accounts.
 863
 864         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 865         Show the wizard when New is clicked.
 866
 867         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 868         (init_view): Show the column headers, and show the columns that are
 869         specified in the UI specs. However, something in Maemo's GTK+ prevents
 870         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 871         change the default account. This is despite unsetting the special properties.
 872
 873 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 874
 875         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 876         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 877         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 878         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 879         to make that clearer.
 880         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 881
 882 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 883
 884         * src/maemo/modest-account-view-window.c:
 885         (modest_account_view_window_init),
 886         (modest_account_view_window_new):
 887         Use the same buttons as specified in the
 888         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 889         the existing widgets, which never had a chance of working.
 890         Put the ModestAccountView treeview in a scrolled window.
 891         Do not repeat the initialization in both _init() and _new().
 892
 893         * src/widgets/modest-account-view.c: (update_account_view):
 894         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 895         this widget and window shows no accounts.
 896
 897         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 898
 899 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 900
 901         * src/maemo/easysetup/modest-easysetup-wizard.c:
 902         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 903         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 904         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 905         which seems wrong.
 906
 907         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 908         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 909         accounts exist yet, as in the UI spec.
 910
 911         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 912
 913 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 914
 915         * src/maemo/Makefile.am:
 916         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 917         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 918         New window for editing connection-specific smtp details.
 919         Not fully implemented.
 920
 921         * src/maemo/modest-connection-specific-smtp-window.c:
 922         (modest_connection_specific_smtp_window_finalize) :
 923         unref the tree model.
 924         (on_button_edit): Show the edit window.
 925
 926 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 927
 928         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 929         error for me.
 930
 931         * src/maemo/Makefile.am:
 932         * src/maemo/modest-connection-specific-smtp-window.c:
 933         * src/maemo/modest-connection-specific-smtp-window.h:
 934         New window for showing the list of connections, for connection-specific
 935         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 936         * src/maemo/easysetup/modest-easysetup-wizard.c:
 937         (create_page_custom_outgoing): Show the new window when the button is clicked.
 938
 939 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 940
 941         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 942         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 943         * src/maemo/modest-msg-edit-window.c:
 944         (modest_msg_edit_window_insert_image):
 945         * src/modest-conf.c: (modest_conf_key_escape):
 946         * src/modest-mail-operation.c:
 947         (modest_mail_operation_send_new_mail):
 948         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 949         (modest_ui_actions_on_new_account):
 950         * src/widgets/modest-attachment-view.c: (update_filename_request):
 951         * src/widgets/modest-mail-header-view.c:
 952         Corrected warnings that were breaking the build, by commenting out unused variables,
 953         and a function, and by including a header.
 954
 955 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 956
 957         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 958         so we can #ifdef around platform-specific code when necessary.
 959         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 960         to allow this to build for the GNOME platform too.
 961
 962 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 963
 964         * src/maemo/easysetup/modest-easysetup-wizard.c:
 965         Added util_increment_name() and used it in create_page_account_details()
 966         to make sure that the default account name is always a new name.
 967
 968         (modest_easysetup_wizard_dialog_init),
 969         (set_default_custom_servernames): Some minor memory management fixes.
 970
 971 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 972
 973         * Makefile.am:
 974         * configure.ac:
 975         * src/modest-runtime.c: (init_i18n): Restored the translation
 976         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 977         are defined in config.h, and the translations are installed.
 978
 979         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 980         is defined for translation.
 981
 982 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 983
 984         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 985         (load_from_file):
 986         * src/maemo/easysetup/modest-easysetup-wizard.c:
 987         (modest_easysetup_wizard_dialog_init):
 988         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 989         Use realistic paths (though they should use $prefix generically) to the
 990         mcc_mapping and provider-data.keyfile files which might work when they
 991         are installed by the future version of the operator-wizard package,
 992         and then fallback to paths in our source code, with an explanatory
 993         warning.
 994
 995 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 996
 997         * configure.ac:
 998         * src/Makefile.am:
 999         * src/maemo/Makefile.am:
1000         * src/maemo/easysetup/: Added files from the previously-exernal
1001         osso-modest-easysetup.
1002         * src/maemo/modest-main-window-ui.h:
1003         * src/modest-ui-actions.c:
1004         * src/modest-ui-actions.h:
1005         Added modest_ui_actions_on_new_account() as a signal handler for the
1006         New Account menu item. It shows the easysetup wizard.
1007         * po/en_GB.po: Added additional needed logical IDs and translations.
1008
1009 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1010 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1011