1 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/modest-msg-edit-window.c: (init_window):
6 2007-07-10 Murray Cumming <murrayc@murrayc.com>
8 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
9 Take a parent widget instead of a parent window, and
10 implement this with hildon_banner_show_information() instead.
11 Non-Maemo builds can just ifdef that there.
12 This fixed projects.maemo.org bug NB#62766.
14 (on_entry_invalid_character): Use show_error() again instead
15 of using hildon directly, and use the _CS() macro to use the correct
17 (create_account), (check_for_supported_auth_methods), (on_entry_max):
18 Pass a widget instead od a window to show_error().
20 2007-07-10 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
23 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
24 This allows us to show the server name in the error message, fixing
25 projects.maemo.org bug NB#62904.
26 Also, use the appropriate logical ID message for the account protocol.
28 2007-07-10 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-tny-account-store.c: (on_idle_wrong_password):
31 A compilation fix, though the build wasn't broken for me.
33 2007-07-09 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
36 Do not try to unref a NULL folder store, to avoid a runtime warning.
37 This seems to happen sometimes when changing accounts settings.
39 2007-07-09 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-tny-account-store.c:
42 (modest_tny_account_store_instance_init),
43 (modest_tny_account_store_finalize),
44 (on_account_settings_hide), (on_idle_wrong_password):
45 Use a GHashTable to ensure that we only show one account settings
46 dialog per modest account. This avoids us having a dialog open for
47 both the store and transport accounts, or due to repeated get_password()
48 calls that shouldn't happen anyway.
50 2007-07-09 Murray Cumming <murrayc@murrayc.com>
52 * src/maemo/modest-maemo-utils.c: (on_hide),
53 (modest_maemo_show_dialog_and_forget): Handle the response, because
54 the window is not even hidden by default.
56 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
57 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
58 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
59 which seems to prevent some modality problems.
61 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
62 Ignore user cancellation errors.
64 * src/modest-account-mgr-helpers.h:
65 * src/modest-account-mgr-helpers.c:
66 Added modest_server_account_get_password() and
67 modest_server_account_get_has_password() to avoid direct use of
70 * src/maemo/modest-account-settings-dialog.h:
71 * src/maemo/modest-account-settings-dialog.c:
72 (modest_account_settings_dialog_init): Store the notebook so we can
74 Added modest_account_settings_dialog_switch_to_user_info().
76 * src/modest-tny-account-store.c:
77 (get_password): When the password in the account settings is wrong (we think),
78 show the relevant page of the account settings dialog, in the mainloop.
79 However, we currently get many of these at once because cancel does not
81 (forget_password): Do not forget the password
82 from the account settings, because this causes side-effects when
83 tinymail seems to call it at strange time, maybe because of how we
84 are cancelling get_password().
85 (modest_tny_account_store_alert): Ignore user cancellations.
87 2007-07-09 Murray Cumming <murrayc@murrayc.com>
89 * src/maemo/modest-maemo-utils.h:
90 * src/maemo/modest-maemo-utils.c:
91 Added modest_maemo_show_information_note_and_forget() for use instead of
92 gtk_dialog_run() when the response is not needed, to avoid an extra
93 mainloop which could cause a hang.
95 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
96 Use the logical IDs for the error message, though they are not
97 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
98 because gtk_dialog_run() caused a hang here (the window did not close).
99 This fixes projects.maemo.org bug NB#62646.
101 2007-07-09 Murray Cumming <murrayc@murrayc.com>
103 * src/modest-account-mgr-helpers.h:
104 * src/modest-account-mgr-helpers.c:
105 Added modest_account_mgr_get_store_protocol().
107 * src/maemo/modest-account-view-window.c:
108 (on_delete_button_clicked): Show different warning text depending on
109 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
110 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
113 2007-07-09 Murray Cumming <murrayc@murrayc.com>
115 * src/maemo/modest-msg-edit-window.c:
116 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
117 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
119 2007-07-07 Armin Burgmeier <armin@openismus.com>
121 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
122 ckdg_ib_maximum_characters_reached from correct package.
124 * src/modest-ui-actions.c: Show an error message when a folder could
125 not be created. Tinymail does not give us specific error codes about
126 what has gone wrong, so we assume that a folder with that name
127 already exists, though there might be other reasons.
129 2007-07-06 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
132 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
133 give a more exact error message that can be partly translated.
135 2007-07-05 Murray Cumming <murrayc@murrayc.com>
137 * src/maemo/modest-address-book.c:
138 (select_email_addrs_for_contact): Specify a default window size for the
139 select-email-address dialog, so that it is probably big enough for the
140 title. This should fix projects.maemo.org bug NB#62277.
142 2007-07-05 Murray Cumming <murrayc@murrayc.com>
144 * src/maemo/easysetup/modest-easysetup-wizard.c:
145 (create_page_complete_easysetup): Use
146 gtk_widget_set_size() request to ensure that the text wraps
149 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
151 * src/maemo/easysetup/modest-easysetup-wizard.c:
152 (on_entry_invalid_character), (create_page_account_details),
153 (create_page_user_details):
154 Use new API of ModestValidatingEntry. But for some reason the banner is
155 not shown. I will have to investigate that further.
157 * src/widgets/modest-validating-entry.c: (on_insert_text),
158 (modest_validating_entry_set_func):
159 * src/widgets/modest-validating-entry.h:
160 Added a new callback function to be able to react to prevented
161 characters whitespaces to e.g show a banner.
163 2007-07-05 Armin Burgmeier <armin@openismus.com>
165 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
166 notification of HildonNumberEditor instead of remembering the port
167 number. Thanks to Johannes for pointing this out.
169 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
171 * src/maemo/easysetup/modest-easysetup-wizard.c:
172 Check if there are any user changes before showing a confirmation
173 dialog (projects.maemo.org NB#60946)
175 2007-07-05 Armin Burgmeier <armin@openismus.com>
177 * src/maemo/modest-account-settings-dialog.c: Remember custom port
178 number at the beginning of the dialog and set the modified flag at the
179 end if the port number has changed. This is necessary because
180 HildonNumberEditor does not support notification when the value has
183 2007-07-05 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-ui-actions.c:
186 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
187 a connection before asking anything else. Correct the check for the destination
188 folder so that it succeeds when online.
189 This fixed projects.maemo.org bug NB#61645.
191 2007-07-05 Murray Cumming <murrayc@murrayc.com>
193 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
194 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
195 to fix projects.maemo.org bug NB#62439.
197 2007-07-05 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-tny-account.c: (on_connection_status_changed):
200 Really do not use tny_device_force_offline() here. See the previous comment.
202 2007-07-04 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-tny-account.c: (on_connection_status_changed):
205 Do not use tny_device_force_offline() when tinymail says that something
206 went wrong with the connection. It seems to report this unnecessarily.
208 2007-07-04 Murray Cumming <murrayc@murrayc.com>
210 * src/maemo/modest-connection-specific-smtp-window.c:
211 (modest_connection_specific_smtp_window_init):
212 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
213 does not seem to have any effect in osso 1.1 (though it works in
214 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
216 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
218 * src/maemo/modest-connection-specific-smtp-window.c:
219 Fix UI specification problems with projects.meamo.org NB#60479
221 2007-07-04 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
224 clue when this has failed, because the error dialog is not always shown
225 (at least in earlier version).
227 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
228 GError message, because the generic error dialog is not helpful.
230 'This message is not currently available (can't let a new connection go online)'
231 when trying to open an IMAP message.
233 (_modest_ui_actions_open): Offer a connection when some messages would
234 have to be downloaded and we are offline.
236 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
238 * src/widgets/modest-folder-view.c:
239 Don't check for MERGE type anymore as we use the correct type
241 NOTE: For the last two changes you need to update your tinymail copy
242 because of API changes!
244 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
246 * src/modest-tny-local-folders-account.c:
247 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
248 (see projects.maemo.org NB#61580)
250 2007-07-04 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-tny-account.c: (on_connection_status_changed):
253 Commented out the call to modest_platform_connect_and_wait() because this
254 seems to always hang, and I would like to know if this is the only thing
255 that causes a hang when showing the connection dialog.
256 It is not very useful anyway.
258 2007-07-04 Murray Cumming <murrayc@murrayc.com>
260 * src/maemo/modest-msg-view-window.c:
261 (modest_msg_view_window_select_next_message):
263 * src/modest-platform.h:
264 * src/maemo/modest-platform.c:
265 Added modest_platform_connect_and_wait(), which calls
266 tny_maemo_conic_device_connect() always in the main thread, by calling it
267 in an idle handler and waiting for the idle handler to run. It should be
268 in the main thread because it uses GTK+ UI code. It just returns TRUE
269 if the device is already online.
271 There is some nasty code to ensure that subsequent calls to
272 modest_platform_connect_and_wait() just wait for the first one to finish,
273 by checking repeatedly in another idle handler. This is necessary,
274 because other threads (or even the main thread, via another idle handler)
275 can call modest_platform_connect_and_wait() while
276 modest_platform_connect_and_wait() is running.
278 (modest_platform_connect_and_wait_if_network_account),
279 (modest_platform_connect_and_wait_if_network_folderstore):
280 Convenience functions that calls modest_platform_connect_and_wait() if
281 the account or folder might want network access.
283 * src/modest-mail-operation.c:
284 (modest_mail_operation_update_account):
285 * src/modest-ui-actions.c: (download_uncached_messages),
286 (modest_ui_actions_on_rename_folder), (delete_folder),
287 (modest_ui_actions_on_main_window_move_to),
288 (modest_ui_actions_on_msg_view_window_move_to):
289 * src/widgets/modest-folder-view.c:
290 (drag_and_drop_from_folder_view):
291 Offer a connection if we are offline.
293 * src/modest-tny-account.c: (on_connection_status_changed):
294 Document this as only handling errors during network operations in progress,
295 and replace the idle code with a simple call to
296 modest_platform_connect_and_wait(), which does this instead.
298 2007-07-03 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-tny-account.c:
301 (modest_tny_account_get_special_folder): (util_on_idle),
302 Handle the GError so we can see when tny_folder_store_get_folders()
303 fails, as it currently does while something else is connecting.
305 Added util_run_in_main_thread_and_wait()
306 which uses an idlen handler and mainloop to ensure that the function
307 is called in the main thread.
308 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
309 to make sure that we call attempt the connection in the mainloop only,
310 which might solve some hangs.
312 2007-07-03 Murray Cumming <murrayc@murrayc.com>
314 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
315 be found by their display name. This is never useful.
316 * src/modest-tny-account-store.c: (on_account_removed): Find the account
317 by its ID, instead of trying to use its ID as its display name.
319 * src/modest-tny-account-store.h:
320 * src/modest-tny-account.c:
321 (modest_tny_account_get_special_folder): Add a g_warning() when
322 tny_folder_store_get_folders() returns an empty list for the maildir.
324 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
325 Add a g_warning() when this returns NULL, because that it not allowed
328 2007-07-02 Armin Burgmeier <armin@openismus.com>
330 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
331 note when trying to cancel the wizard. This fixes projects.maemo.org
334 2007-07-02 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-tny-account.h:
337 * src/modest-tny-account.c:
338 (modest_tny_account_new_from_server_account),
339 (modest_tny_account_new_from_server_account_name),
340 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
341 because this must now be set before setting the proto. This is usd in
342 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
343 warning in camel_session_get_service() caused by
344 tny_camel_transport_account_prepare().
346 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
349 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
351 * src/maemo/modest-connection-specific-smtp-edit-window.c:
353 (modest_connection_specific_smtp_edit_window_init):
355 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
358 2007-06-29 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-tny-account.c:
361 (modest_tny_account_new_from_server_account):
362 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
363 now uses to request a connection when it needs one, and which it uses
364 to tell us that something is wrong with the connection, so we can force
365 the accounts offline to prevent further problems.
368 * src/modest-init.c: (init_default_settings):
369 * src/modest-mail-operation.c:
370 (modest_mail_operation_update_account):
371 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
372 This should not be necessary anymore. Do not set the conf key that
373 determined this (it was always TRUE and not set anywhere else).
375 * src/modest-ui-actions.h: Remove unused and unimplemented
376 modest_ui_actions_on_online_toggle_toggled().
378 2007-06-29 Murray Cumming <murrayc@murrayc.com
380 * src/maemo/modest-main-window.c: (connect_signals):
381 Don't connect to delete_event twice. Maybe this was harmless.
383 2007-06-29 Murray Cumming <murrayc@murrayc.com
385 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
386 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
387 Debug output to give some more clue when a folder move is not allowed.
389 2007-06-28 Murray Cumming <murrayc@murrayc.com
391 * src/modest-tny-account.c: (on_modest_file_system_info),
392 (modest_tny_account_get_mmc_account_name):
393 Always call the callback, without checking whether the name has changed.
394 * src/widgets/modest-folder-view.c: (strings_are_equal),
395 (on_model_foreach_set_name), (on_get_mmc_account_name),
396 (text_cell_data): Compare the name here, and use the name from
397 the account rather than from the
398 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
399 if the name was changed after the account was added to the model.
400 That's a tinymail bug but not one that I want to fix now.
402 This finally fixes projects.maemo.org bug NB#59301.
404 2007-06-27 Armin Burgmeier <armin@openismus.com>
406 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
409 2007-06-27 Murray Cumming <murrayc@murrayc.com
411 * src/modest-tny-account.h:
412 * src/modest-tny-account.c:
413 Added modest_tny_account_get_mmc_account_name(), to set the memory
414 card name asynchronously for the given account and then notify.
415 (modest_tny_account_new_for_local_folders): Use this new function instead
416 of using hildon_file_system_info_async_new() directly.
418 * src/widgets/modest-folder-view.c: (text_cell_data):
419 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
420 gtk_tree_model_row_changed() when it is available.
422 This should fix projects.maemo.org bug NB#59301.
424 2007-06-27 Murray Cumming <murrayc@murrayc.com
426 * src/modest-mail-operation.c: (update_account_thread),
427 (get_msgs_full_thread): Fix typo failures in the revert
430 2007-06-27 Murray Cumming <murrayc@murrayc.com
432 * src/maemo/modest-maemo-global-settings-dialog.c:
433 (idle_select_default_focus):
434 * src/modest-mail-operation.c: (idle_notify_progress),
435 (idle_notify_progress_once), (set_last_updated_idle),
436 (update_account_thread), (get_msgs_full_thread):
437 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
438 * src/widgets/modest-header-view.c:
439 (idle_notify_headers_count_changed_destroy),
440 (idle_notify_headers_count_changed):
441 Reverted the additions of gdk_threads_enter/leave(), in case this
442 helps with a startup hang on the device.
444 2007-06-26 Armin Burgmeier <armin@openismus.com>
446 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
447 for supported secure authentication methods from server by
448 gtk_dialog_run(), saving CPU time and a potential race condition.
450 2007-06-26 Armin Burgmeier <armin@openismus.com>
452 * src/maemo/modest-maemo-utils.h:
453 * src/maemo/modest-maemo-utils.c: Added a
454 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
455 only error code to tell the calling code when the user canceled the
458 * src/maemo/modest-account-settings-dialog.h:
459 * src/maemo/modest-account-settings-dialog.c:
460 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
461 message if the retrieval of secure authentication methods was canceled
462 by the user. Perform the check before saving anything to configuration
463 to not end up with half-committed configuration changes, do not show
464 a "Saving to configuration failed" note when authentication methods
465 could not be retrieved.
467 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
470 2007-06-26 Murray Cumming <murrayc@murrayc.com>
472 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
473 Only return the first level of folders under accounts, because the
474 osso-global-search UI spec doesn't want the rest.
475 This fixed projects.maemo.org bug NB#61811.
477 2007-06-26 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account-store.c:
480 * src/modest-tny-account-store.h:
481 Added modest_tny_account_is_memory_card_account().
482 * src/maemo/modest-main-window.c: (create_details_widget):
483 Show the same information items for the memory card as we show for the
484 local-folders, to fix projects.maemo.org bug NB#59307.
486 2007-06-26 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-tny-account-store.c: (get_password):
489 Added some checks for NULL to maybe prevent crashes, though I think
490 it was Philip's last commit that actually prevented the crash here
491 when creating a first new account.
492 But the new account is still not usable (no messages are shown)
493 until a restart of the application.
495 2007-06-26 Murray Cumming <murrayc@murrayc.com>
497 * src/maemo/modest-maemo-global-settings-dialog.c:
498 (idle_select_default_focus):
499 * src/modest-mail-operation.c: (idle_notify_progress),
500 (idle_notify_progress_once), (idle_notify_update_account_queue),
501 (set_last_updated_idle), (update_account_thread),
502 (notify_get_msgs_full), (get_msgs_full_destroyer),
503 (get_msgs_full_thread):
504 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
505 * src/widgets/modest-header-view.c:
506 (idle_notify_headers_count_changed_destroy),
507 (idle_notify_headers_count_changed):
508 Use gdk_threads_enter() and gdk_threads_enter_leave() in
509 all idle handlers, because some other thread could be blocking
510 the GDK lock, so that it can do GUI stuff.
512 2007-06-26 Murray Cumming <murrayc@murrayc.com>
514 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
515 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
516 (on_idle_send_receive), (on_idle_open_default_inbox):
517 * src/maemo/modest-msg-edit-window.c:
518 (modest_msg_edit_window_attach_file_noninteractive):
519 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
520 to prevent a hang. I don't quite understand why these are necessary,
521 beause we should already be in the main loop. I guess something outside
522 of the main loop is taking the lock.
524 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
525 we are really using URIs, and use files that are more likely to exist.
527 2007-06-26 Murray Cumming <murrayc@murrayc.com>
529 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
530 necessary because configure.ac now defines different variables.
532 2007-06-26 Murray Cumming <murrayc@murrayc.com>
534 * libmodest-dbus-client/libmodest-dbus-client.c:
535 * libmodest-dbus-client/libmodest-dbus-client.h:
536 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
537 libmodest_dbus_client_compose_mail() is what things actually use.
539 * src/dbus_api/modest-dbus-api.h:
540 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
541 * tests/dbus_api/Makefile.am:
542 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
545 2007-06-26 Murray Cumming <murrayc@murrayc.com>
547 * src/modest-init.c: (modest_init_local_folders):
548 For memory-card (or other non local-folders) maildir accounts,
549 always create an Archive folder, so that there is somewhere to put
550 messages. This should be less confusing, because the user does not need
551 to guess that the need to create a folder.
553 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
555 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
556 Fixed icon size by using (50, 50) which is the same as defined by
559 2007-06-25 Armin Burgmeier <armin@openismus.com>
561 * src/widgets/modest-window-mgr.c:
563 * configure.ac: Correctly recognize hildon-notify presence and fixed
564 the build without it being installed.
566 2007-06-25 Murray Cumming <murrayc@murrayc.com>
568 * libmodest-dbus-client/libmodest-dbus-client.c:
569 (libmodest_dbus_client_search): Fix the build. Sorry.
570 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
571 (reply_forward_cb): Initialize variables to fix the build.
573 * src/modest-tny-account-store.c:
574 (modest_tny_account_store_get_tny_account_by): Fix the account URI
575 comparison (a silly typo) so that email search results can be opened
576 when there are more than one account.
578 2007-06-25 Murray Cumming <murrayc@murrayc.com>
580 * libmodest-dbus-client/libmodest-dbus-client.c:
581 (libmodest_dbus_client_search),
582 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
583 instead of 1 second, because the search gets folders and messages from
584 the server, which can take a long time. When it times out,
585 osso-global-search will report no results.
587 We need to specify whether we should search only cached information
588 (maybe with a user preference), and the osso-email-search-plugin
589 API should really be improved to allow that option, and to allow results
590 to be delivered asynchronously in batches.
592 2007-06-25 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
595 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
596 GTK_ICON_SIZE_DIALOG is probably the wrong size.
598 2007-06-25 Murray Cumming <murrayc@murrayc.com>
600 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
601 that is an empty string. D-Bus seems to give us these instead of NULL.
603 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
605 * src/dbus_api/modest-dbus-callbacks.c:
606 * src/maemo/easysetup/modest-easysetup-wizard.h:
607 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
608 * src/maemo/modest-connection-specific-smtp-edit-window.c:
609 (modest_connection_specific_smtp_edit_window_init):
610 * src/maemo/modest-maemo-global-settings-dialog.c:
612 * src/maemo/modest-maemo-utils.c:
613 (modest_maemo_utils_setup_images_filechooser):
614 * src/maemo/modest-main-window.c: (create_details_widget):
615 * src/maemo/modest-msg-edit-window.c:
616 (modest_msg_edit_window_attach_file_noninteractive),
617 (modest_msg_edit_window_color_button_change),
618 (modest_msg_edit_window_set_zoom):
619 * src/modest-mail-operation.c: (update_account_thread):
620 * src/modest-tny-account-store.c:
621 * src/modest-tny-account.c:
622 * src/widgets/modest-global-settings-dialog.c:
623 * src/widgets/modest-window.h:
627 2007-06-25 Murray Cumming <murrayc@murrayc.com>
629 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
630 * src/modest-search.c: (modest_search_folder),
631 (modest_search_all_accounts): Actually search only in the specified folder,
632 doing a simple match on the folder ID.
633 * src/modest-search.h: Added a folder field to the ModestSearch struct,
634 and added some documentation.
636 2007-06-22 Armin Burgmeier <armin@openismus.com>
638 * src/maemo/modest-maemo-utils.h:
639 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
640 modest_maemo_utils_get_supported_secure_authentication_methods.
642 * src/maemo/easysetup/modest-easysetup-wizard.c:
643 * src/maemo/modest-account-settings-dialog.c: Show correct error if
644 one occured, not just "Server does not support secure authentication".
646 2007-06-22 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-tny-account-store.c: (get_password):
649 Restored the call to tny_account_set_user() because Philip seems to have
650 stopped this from crashing (by not using the freed string). It still does
651 not work, but now we can test it.
653 2007-06-22 Murray Cumming <murrayc@murrayc.com>
655 * src/maemo/modest-msg-edit-window.c: (init_window):
656 Comment out use of an uninitialzed GtkScrolledWindow variable,
657 to fix the build and stop a crash. Yet again.
659 2007-06-22 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-tny-account-store.c: (get_password):
662 Remove the call to tny_account_set_user() because this actually crashes.
663 As mentioned in the last commit, it is known to not work anyway.
665 2007-06-22 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account-store.c: (get_password):
668 Use tny_account_set_username() to tell tinymail that the username might
669 have changed too. But tinymail ignores this: see projects.maemo.org
671 * src/modest-ui-actions.c:
672 (modest_ui_actions_on_password_requested): Remove the useless attempt to
673 reset the connection when changing the username, and improve the comments.
674 Save the changed username to gconf at least, so it is used when Modest is
677 2007-06-21 Murray Cumming <murrayc@murrayc.com>
679 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
680 Do not use a query, so that we get all folders, including for POP and
681 local-folders. They work as search criteria too.
682 This fixes projects.maemo.org bug NB#57740.
684 2007-06-21 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
687 Comment out the use of hildon_notification_set_sound() because it is
688 not declared, to fix the build. Warnings are serious, people.
690 2007-06-21 Armin Burgmeier <armin@openismus.com>
692 * src/maemo/modest-maemo-utils.h:
693 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
694 modest_maemo_utils_get_supported_secure_authentication_methods()
695 to query authentication methods for a specific user. This should fix
696 projects.maemo.org bug NB#61369.
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
702 2007-06-21 Murray Cumming <murrayc@murrayc.com>
704 * libmodest-dbus-client/libmodest-dbus-client.h:
705 * libmodest-dbus-client/libmodest-dbus-client.c:
706 (modest_dbus_message_iter_get_search_hit),
707 (libmodest_dbus_client_search):
708 Reorganised and commented this.
709 Removed modest_search_hit_free() from the public API because it
712 Added libmodest_dbus_client_get_folders() and
713 modest_folder_result_list_free().
715 * src/dbus_api/modest-dbus-api.h:
716 * src/dbus_api/modest-dbus-callbacks.c:
717 (modest_dbus_req_filter): Commented. Moved most code to
718 on_dbus_method_search() and added on_dbus_method_get_folders().
720 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
721 of the extra D-Bus handler.
723 * tests/dbus_api/Makefile.am:
724 * tests/dbus_api/test_get_folders.c: New test for
725 libmodest_dbus_client_get_folders(). This seems to return an empty list
726 at the moment. That could be the same error that causes the message list
727 to be empty sometimes.
728 This should help with projects.maemo.org bug NB#57740.
730 2007-06-21 Armin Burgmeier <armin@openismus.com>
732 * src/modest-mail-operation.c: Do not call
733 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
734 notify the operation's end after having set the status to CANCELED for
735 the operation queue to listen on. This fixes a deadlock when there
736 were mail operations in the queue during its finalization.
738 * src/modest-singletons.c: Reordered uninitialization of the account
739 manager to happen after the mail operation queue was uninitialized
740 because the mail operation's in the queue might still try to access
741 the account manager (see modest_mail_operation_notify_end()). This
742 fixes a potential crash when terminating the application.
744 2007-06-21 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-search.c:
747 (search_mime_part_and_child_parts): Moved some code here so we
748 can search recursively in child folders.
749 (modest_search_folder): Search in the message as a mime part, instead
750 of just its child mime parts.
751 (read_chunk), (search_mime_part_ogs):
752 Check how many bytes were read, to prevent an endless loop.
753 Searching in message bodies now works. This finishes the fix for
754 projects.maemo.org bug NB#61007.
756 2007-06-20 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
759 Add a g_warning when the item is not a folder.
761 * src/modest-ui-dimming-rules.c:
762 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
763 when selected item is not a folder (for instance, an account), because
764 the UI spec only talks about folders.
765 I am not sure what the UI spec wants, so this might not totally fix
766 projects.maemo.org bug NB#60794.
768 2007-06-20 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
771 (load_from_file): Sort the list. The unsorted list would be more noticeable
772 in non-English locales.
774 * src/maemo/modest-msg-edit-window.c:
775 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
776 warning and fix the build.
778 * src/maemo/modest-progress-bar-widget.c:
779 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
780 avoid a g_warning, and probably to avoid a crash.
782 2007-06-20 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-search.c: (modest_search_folder): Check for a GError
785 when calling tny_folder_get_headers(), to show that this is not the cause
788 2007-06-20 Murray Cumming <murrayc@murrayc.com>
790 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
791 Actually set the body query instead of the subject query.
793 * src/modest-search.c: (search_mime_part_ogs),
794 (search_mime_part_strcmp): Remove extra space from the text/* regex,
795 which would probably cause it to fail if we got this far.
797 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
798 to simplify the code.
799 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
800 be causing search-in-body to fail.
802 2007-06-20 Murray Cumming <murrayc@murrayc.com>
804 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
806 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
807 Better debug message when the folder cannot be found.
808 This should help with fixing projects.maemo.org bug #61287.
809 * src/modest-search.c: (add_hit): Do not leak the furl string.
811 2007-06-20 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-ui-actions.c:
814 (modest_ui_actions_on_folder_selection_changed):
815 Do not special-case TNY_MERGE_FOLDER here, because
816 modest_tny_folder_get_account() already does that. This fixes
817 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
818 shown when the Outbox was selected).
820 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
822 * libmodest-dbus-client/libmodest-dbus-client.c:
823 (_dbus_iter_get_string_or_null): Initialize the string variable in
824 case this helps with Dirk's crash.
826 2007-06-19 Murray Cumming <murrayc@murrayc.com>
828 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
829 though it is not implemented yet (this function is maybe not even used),
830 to avoid breaking ABI in future.
831 * libmodest-dbus-client/libmodest-dbus-client.c:
832 (get_attachments_string): Moved some code into this generic function.
833 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
834 sends email. It is maybe not used.
835 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
836 (on_send_mail): Use attachments.
838 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
839 * src/maemo/modest-msg-edit-window.c:
840 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
841 a filename before using it, to fix projects.maemo.org bug NB#58233.
843 2007-06-19 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
846 Initialize the continue_download variable to fix the build, and probably
847 to fix randome behaviour.
849 2007-06-18 Armin Burgmeier <armin@openismus.com>
851 * src/modest-tny-send-queue.h:
852 * src/modest-tny-send-queue.c: Keep track of the status of messages in
853 the queue so we can later show it in the UI. Replaced
854 modest_tny_send_queue_msg_is_being_sent() by
855 modest_tny_send_queue_get_msg_status().
857 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
859 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
860 gpointer. This probably was not harmful, but just to be sure.
862 2007-06-18 Murray Cumming <murrayc@murrayc.com>
864 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
865 Fix the build, but leave the function broken on Bora, because
866 hildon_uri_action_get_service() does not exist.
867 osso_uri_action_get_service() does not exist either, it seems.
869 2007-06-18 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-tny-account.c:
872 (modest_tny_account_new_from_server_account):
873 Uncommented the url debug output again, because it is useful for
874 debugging, as I said in the comment.
876 2007-06-18 Murray Cumming <murrayc@murrayc.com>
878 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
880 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
881 for Mameo Bora, to fix the build.
883 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
886 Fixed build with hildon < 0.99
888 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
889 Check if the selected account is busy instead of checking all accounts
891 * src/modest-account-mgr-priv.h:
892 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
893 (modest_account_mgr_init), (compare_account_name),
894 (modest_account_mgr_set_account_busy),
895 (modest_account_mgr_account_is_busy):
896 * src/modest-account-mgr.h:
897 Added busy information to the account manager. It possible to
898 set an account to busy or not busy now.
900 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
901 (modest_mail_operation_update_account),
902 (modest_mail_operation_notify_end):
903 Set the account to busy/not busy depending on the operation state.
905 * src/widgets/modest-account-view.c:
906 (modest_account_view_finalize), (get_last_updated_string),
907 (update_account_view), (on_account_busy_changed), (init_view):
908 Show string "Refreshing..." if the account is currently busy.
910 All this fixes projects.maemo.org bug NB#59711
912 2007-06-14 Armin Burgmeier <armin@openismus.com>
914 * src/widgets/modest-attachments-view.h:
915 * src/widgets/modest-attachments-view.c: Added
916 modest_attachments_view_has_attachments() and fixed coordinate
917 transformation in get_att_view_at_coords(). This fixes attachment
920 * src/widgets/modest-msg-view.c: Make use of
921 modest_attachments_view_has_attachments() to decide whether to show
922 attachments in the header.
924 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
926 * src/maemo/modest-connection-specific-smtp-edit-window.c:
927 (on_change), (on_combo_security_changed),
928 (modest_connection_specific_smtp_edit_window_init),
929 (modest_connection_specific_smtp_edit_window_set_connection),
930 (modest_connection_specific_smtp_edit_window_is_dirty):
931 * src/maemo/modest-connection-specific-smtp-edit-window.h:
932 * src/maemo/modest-connection-specific-smtp-window.c:
935 Show an comfirmation dialog for the smpt-edit-window if there are
936 unsaved changes and the user hits cancel.
937 (projects.maemo.org bug NB#60479)
939 2007-06-14 Armin Burgmeier <armin@openismus.com>
941 * src/maemo/easysetup/modest-easysetup-wizard.c:
942 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
943 address" info in banner instead of node, and select all the text as
944 per UI spec. This fixes projects.maemo.org bug NB#60550.
946 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
948 reviewed by: <delete if not using a buddy>
950 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
951 * src/modest-ui-actions.c: (folder_refreshed_cb):
953 2007-06-14 Murray Cumming <murrayc@murrayc.com>
955 * src/widgets/modest-folder-view.c: (filter_row):
956 Explictly filter out the per-account outbox accounts. I don't know why
957 these only sometimes show up, but now they should never show up in the UI.
958 This should fix projects.maemo.org bug NB#60160.
960 2007-06-14 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
963 when the toolbar does not exist yet.
964 * src/modest-widget-memory.c: (save_settings_header_view):
965 Added g_warnings() to help us to discover when we are trying to set
966 an empty columns list in gconf.
968 2007-06-14 Murray Cumming <murrayc@murrayc.com>
972 Added modest_init_get_default_header_view_column_ids().
974 * src/modest-widget-memory.c: (restore_settings_header_view):
975 Use the new function to get defaults, if the gconf key is empty,
976 instead of not creating any columns. This seems to fix the
977 empty right-hand pane problems.
979 * src/widgets/modest-header-view.h: Improved documentation.
981 2007-06-13 Murray Cumming <murrayc@murrayc.com>
983 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
984 Revert the use of the display name as the account name, because this
985 is generally wrong and would break the code that follows.
987 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
989 * src/maemo/easysetup/modest-easysetup-wizard.c:
990 (check_for_supported_auth_methods), (on_before_next),
993 More correct fix for projects.maemo.org bug NB# 58991
994 Do not longer accept AUTH_PASSWORD as secure method and choose
995 correct method when creating the account.
997 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
999 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1000 Fixed projects.maemo.org bug NB# 58991
1002 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1004 * src/modest-init.c: (modest_init_init_core),
1005 (modest_init_local_folders): Fixed compilation errors.
1007 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1009 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1010 Remove unnecessary lib/include, though it is good in principle when needed.
1012 * src/modest-init.c: (modest_init_one_local_folder),
1013 (modest_init_local_folders):
1014 * src/modest-init.h: Initialize the .modest library for memory cards,
1015 instead of just doing nothing for them. This should allow us to create
1016 folders there, fixing projects.maemo.org bug NB#59297.
1018 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1020 * libmodest-dbus-client/libmodest-dbus-client.c:
1021 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1022 (libmodest_dbus_client_compose_mail),
1023 (libmodest_dbus_client_open_message),
1024 (libmodest_dbus_client_send_and_receive),
1025 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1027 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1028 (on_idle_open_message), (modest_dbus_req_handler),
1029 (search_result_to_message), (modest_dbus_req_filter):
1030 * src/modest-search.c: (add_hit), (modest_search_folder),
1031 (modest_search_all_accounts): Improved debug messages.
1033 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1035 * src/modest-tny-account-store.c:
1036 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1039 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1042 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-tny-account-store.c: (get_server_accounts):
1045 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1046 even when there are no accounts, so that the Outbox folder is always
1047 visible. This fixes projects.maemo.org bug NB#60158.
1049 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/modest-main-window.c: (create_details_widget):
1052 Use the mcen_va_never logical ID.
1054 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1056 * src/dbus_api/modest-dbus-api.h:
1057 * src/dbus_api/modest-dbus-callbacks.c:
1058 (on_idle_open_default_inbox), (on_open_default_inbox),
1059 (modest_dbus_req_handler):
1060 Added a new OpenDefaultInbox method.
1062 * libmodest-dbus-client/libmodest-dbus-client.h:
1063 * libmodest-dbus-client/libmodest-dbus-client.c:
1064 Added libmodest_dbus_client_open_default_inbox() to call the new
1065 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1066 though it should maybe be used by a new osso-email-interface function.
1068 * tests/dbus_api/Makefile.am:
1069 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1072 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1075 NULL, so that the signals get all the keys. This should not actually
1076 change any behaviour because we currently update everything when anything
1079 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1081 * src/widgets/modest-folder-view.c: (text_cell_data),
1082 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1083 (find_inbox_iter): If tinymail tells us that the folder is
1084 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1085 This causes the inbox to be selected at startup, fixing part of
1086 projects.maemo.org bug NB#56305.
1088 * src/modest-ui-dimming-rules.c:
1089 (modest_ui_dimming_rules_on_tools_smtp_servers):
1090 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1091 the SMTP servers menu item.
1092 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1093 that the SMTP Servers menu item is dimmed when there are no accounts,
1094 as a future version of the UI spec will require. This fixes
1095 projects.maemo.org bug NB#56305.
1097 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1099 * src/maemo/modest-maemo-utils.c:
1100 (modest_maemo_utils_get_supported_secure_authentication_methods):
1101 Added label to dialog instead of unreadable title
1103 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1104 (modest_main_window_new):
1105 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1108 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1109 * src/modest-account-mgr.h:
1110 Added method to avoid code duplication
1112 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1113 (modest_ui_actions_on_send_receive):
1114 Use modest_account_mgr_has_accounts
1116 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/easysetup/modest-presets.c:
1119 (modest_presets_get_info_server_security): Do not report secure auth
1121 * src/modest-protocol-info.c: Use the defines for the gconf key names
1122 for secure authentication. This was not working because we were writing
1123 Password and reading password, and the check was case sensitive.
1124 With this, gmail now works for receiving and sending when created via
1127 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1129 * src/maemo/easysetup/modest-presets.c:
1130 (modest_presets_get_info_server_security): Correct the key name for
1131 SecureSmtp, because it seems to be case-sensitive.
1132 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1133 Do not try to get the 0th notebook page if there are 0 pages, to
1134 avoid a g_warning().
1136 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1139 Prevent use of the new notification feature for now, because it currently
1140 shows one dialog for each new email, which is annoying.
1142 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1144 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1145 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1146 when no country was selected, so that we show the global ones.
1147 * src/maemo/easysetup/modest-presets.c:
1148 (modest_presets_get_providers): Return only the global providers, not
1149 all providers when mmc=0 was requested.
1151 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1154 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1155 provider ID in the combo.
1157 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1158 Do not show the page numbers, because it would be confusing when we add
1159 the 2 extra pages for the custom setup, when the user chooses the "Other"
1160 provider. This fixes projects.maemo.org bug NB#59028
1162 * src/modest-init.c: (modest_init_init_core),
1163 (modest_init_local_folders):
1164 * src/modest-init.h:
1165 * src/modest-tny-account.c:
1166 (modest_tny_account_new_for_local_folders): Do not create default folders
1167 for the memory card. This should fix projects.maemo.org bug NB#59328.
1169 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1172 Free the changed_conf_keys string items. They are already freed in the
1173 idle handler if that runs first.
1175 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-ui-actions.c:
1178 (modest_ui_actions_on_password_requested): Check that the server name
1179 is not NULL, because I just saw a password dialog with (null) as the
1182 * src/modest-tny-folder.[h|c]: Added
1183 modest_tny_folder_is_memory_card_folder().
1184 * src/modest-ui-dimming-rules.c:
1185 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1186 menu item for memory cards, as per the UI spec (section 7.4). This should
1187 fix projects.maemo.org bug NB#59297.
1189 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1191 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1192 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1193 is another problem with the code, see Murray's comment at line 772)
1195 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1197 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1198 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1199 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1200 (load_from_file), (easysetup_country_combo_box_init),
1201 (easysetup_country_combo_box_get_active_country_ids),
1202 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1203 instead of just one ID, to avoid duplicate country names in the UI.
1205 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1206 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1207 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1208 a single ID, avoiding duplicate providers.
1209 * src/maemo/easysetup/modest-easysetup-wizard.c:
1210 (on_combo_account_country): Adapt to use a list.
1212 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1214 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1215 keys changed in the last X seconds.
1217 * src/modest-account-mgr.h:
1218 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1219 (on_key_change), (modest_account_mgr_class_init),
1220 (modest_account_mgr_init), (modest_account_mgr_finalize):
1221 As the keys are changed, save them in a GSList* and signal that GSList*
1222 further every X seconds, to batch changes, to allow us to do just one
1223 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1224 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1226 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1227 changed signal signature.
1229 * src/modest-conf.c: (modest_conf_set_list),
1230 (modest_conf_on_change): Reenable notification.
1232 (modest_conf_maemo_fake_on_change): Comment out the hack that
1233 notified immediately instead of asynchronously.
1235 * src/widgets/modest-account-view.h:
1236 * src/widgets/modest-account-view.c:
1237 (update_account_view): Select the previously-selected account ID,
1238 if possible. This fixes projects.maemo.org bug NB#56933.
1240 (on_account_changed), (on_account_removed),
1241 (modest_account_view_select_account):
1243 Remove the block/unblock functions
1244 because they were not useful.
1246 * src/maemo/modest-account-view-window.c:
1247 (on_delete_button_clicked), (on_edit_button_clicked),
1248 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1250 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1253 Improve the error dialog to show Incorrect Account Settings, which seems
1254 clearer, and say that the internal error message (to be removed from the
1255 dialog later) is often misleading.
1256 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1258 * src/modest-tny-account.c:
1259 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1260 URL because this is so useful for debugging on the device.
1262 * src/widgets/modest-serversecurity-combo-box.c:
1263 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1265 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1267 * src/modest-mail-operation.c:
1268 (modest_mail_operation_send_new_mail):
1269 Added a comment about a nasty but apparently harmless message. Details
1270 added to the wiki g_warnings() page.
1272 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1275 (modest_tny_send_queue_class_init):
1276 Do not use the priv struct because it is empty, to avoid g_warnings
1277 about a non-existant priv struct.
1279 * src/modest-tny-account-store.c:
1280 (modest_tny_account_store_get_server_account),
1281 (modest_tny_account_store_get_transport_account_for_open_connection
1282 ): Do not try to get transport server accounts for local folders,
1283 because they don't have any. This avoids a g_warning().
1285 * src/maemo/modest-main-window.c:
1286 (modest_main_window_notify_send_receive_initied),
1287 (on_configuration_key_changed):
1288 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1289 * src/modest-defs.h:
1290 * src/modest-mail-operation.c:
1291 (modest_mail_operation_update_account):
1292 * src/modest-tny-account-store.h:
1293 * src/modest-tny-account.c:
1294 (modest_tny_account_get_special_folder),
1295 (modest_tny_account_new_for_local_folders),
1296 (modest_tny_account_new_for_per_account_local_outbox_folder):
1297 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1298 * src/modest-tny-local-folders-account.c:
1299 (add_account_folders_to_merged_folder):
1300 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1301 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1302 (modest_ui_actions_on_send):
1303 * src/widgets/modest-folder-view.c: (update_model):
1304 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1305 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1306 modest_tny_account_store_get_tny_account_by_account() to
1307 modest_tny_account_store_get_server_account() to make the code clearer.
1309 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1311 * src/dbus_api/modest-dbus-api.h:
1312 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1313 * src/maemo/modest-msg-edit-window.c:
1314 (modest_msg_edit_window_attach_file_noninteractive):
1315 added g_warning in case the file to be attached does not exist
1316 * tests/dbus_api/test_compose_mail.c: (main):
1317 removed obsolete comment, added generic files as test case
1319 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-tny-account-store.c: (get_server_accounts):
1322 Create the local folders account only once, not once for each outbox, and
1323 not only when there are some outboxes.
1325 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1327 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1328 code that is causing a crash at startup. Sergio says that he is fixing this.
1330 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1332 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1333 * src/maemo/modest-account-settings-dialog.c:
1334 (create_page_outgoing),
1335 (modest_account_settings_dialog_set_account_name),
1336 (save_configuration):
1337 - Fixed handling of the "Use secure authentication" toggle to comply with
1338 the ui specification. See also projects.maemo.org bug NB#58400
1340 - Restore the Secure connection setting combo correctly when loading
1343 * src/maemo/modest-maemo-utils.c:
1344 (on_camel_account_get_supported_secure_authentication),
1345 (modest_maemo_utils_get_supported_secure_authentication_methods):
1346 Fixed a crasher if operation is canceled
1348 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1349 (modest_protocol_info_auth_is_secure):
1350 * src/modest-protocol-info.h:
1352 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1353 the sense of the "Use secure authentication" toggle.
1355 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-tny-account-store.h:
1358 * src/modest-tny-account-store.c:
1359 Added modest_tny_account_store_get_local_folders_account().
1361 * src/modest-tny-folder.h:
1362 * src/modest-tny-folder.c:
1363 (modest_tny_folder_get_account):
1364 Added this replacement for tny_folder_get_account() which returns
1365 the local-folders account for TnyMergeFolders, to avoid the
1366 warning about the unimplemented get_account_func() vfunc().
1368 (modest_tny_folder_get_rules),
1369 * src/modest-ui-actions.c:
1370 (modest_ui_actions_on_folder_selection_changed):
1371 * src/modest-mail-operation.c:
1372 (modest_mail_operation_remove_folder),
1373 (modest_mail_operation_xfer_folder),
1374 (modest_mail_operation_rename_folder),
1375 (modest_mail_operation_get_msg),
1376 (modest_mail_operation_get_msgs_full),
1377 (modest_mail_operation_remove_msg),
1378 (modest_mail_operation_xfer_msgs),
1379 (modest_mail_operation_refresh_folder):
1380 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1382 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1385 (modest_server_account_set_security):
1386 * src/modest-defs.h: Add comments explaining that our
1387 UI spec means TLS when it says Normal, so these do not look like errors.
1389 * src/modest-tny-account.c:
1390 (modest_tny_account_new_from_server_account): Use the new tinymail
1391 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1392 for TLS. This should fix projects.maemo.org bug NB#58460.
1394 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1396 * src/maemo/easysetup/modest-easysetup-wizard.c:
1397 (create_account): Correct the position of the gconf sanity check warning.
1398 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1399 of using the g_idle_add() hack, because this does not seem to be necessary
1400 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1401 caused by something other than maemo's gconf.
1402 This fixes projects.maemo.org bug #59022.
1404 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-account-mgr-helpers.c:
1407 (modest_account_mgr_get_default_account): Do not check that the account
1408 exists if there is no default account (NULL), to fix a runtime warning.
1410 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1412 * src/widgets/modest-folder-view.c: (update_model):
1413 Do not unref the treemodel before we have finished with it.
1414 This prevents a valgrind warning and an occasional crash at startup.
1416 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1418 * libmodest-dbus-client/libmodest-dbus-client.h:
1419 added libmodest_dbus_client_compose_mail()
1420 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1422 added functions needed for SendAsMail() functionality
1423 * src/maemo/modest-msg-edit-window.c:
1424 (modest_msg_edit_window_attach_file_noninteractive):
1425 non interactively attaching files to message edit window
1426 * src/widgets/modest-msg-edit-window.h:
1427 * tests/dbus_api/Makefile.am:
1428 added test_compose_mail.c
1429 * tests/dbus_api/test_compose_mail.c: (main):
1431 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1433 * src/modest-account-view.c:
1434 Fixed bug projects.maemo.org bug NB#59307
1436 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1438 * src/maemo/easysetup/modest-easysetup-wizard.c:
1439 (get_serverport_incoming), (on_before_next), (create_account):
1440 * src/maemo/modest-account-settings-dialog.c:
1441 (modest_account_settings_dialog_set_account_name):
1442 * src/maemo/modest-maemo-utils.c:
1443 (on_camel_account_get_supported_secure_authentication_status),
1444 (on_camel_account_get_supported_secure_authentication),
1445 (on_secure_auth_cancel),
1446 (modest_maemo_utils_get_supported_secure_authentication_methods):
1448 Implemented security authentication for settings and easysetup.
1450 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1452 * src/maemo/modest-main-window.c: (create_details_widget):
1453 Show the total size for memory card accounts too, instead of showing
1454 the name again. Fixes bug projects.maemo.org bug NB#59307.
1456 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-tny-simple-folder-store.c:
1460 * src/modest-tny-simple-folder-store.h: Removed.
1462 * src/modest-tny-local-folders-account.h
1463 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1464 for the local-folders maildir, with an extra TnyMergedFolder containing
1465 the folders of the per-account outbox store accounts.
1466 * src/modest-tny-account-store.c: (get_server_accounts):
1467 Add the outboxes to the special local folders account after creating it.
1469 * src/modest-tny-account.c:
1470 (modest_tny_account_new_for_local_folders): Create the derived
1471 account when creating the main local-folders account.
1473 * src/maemo/modest-main-window.c: (create_details_widget),
1474 (modest_main_window_set_contents_style):
1475 Adapted to the use of the derived account instead of the folder store.
1477 * src/modest-ui-actions.c:
1478 (modest_ui_actions_on_folder_selection_changed):
1479 * src/modest-ui-dimming-rules.c:
1480 (modest_ui_dimming_rules_on_new_folder):
1481 * src/widgets/modest-folder-view.c: (text_cell_data),
1482 (icon_cell_data), (filter_row), (update_model),
1483 (get_cmp_rows_type_pos):
1486 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1487 Do not get the priv struct, because no priv struct has been set,
1488 to avoid a runtime warning.
1490 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1491 #ifelse with #else, to fix a warning, to fix the build.
1494 2007-06-05 Christian Kellner <ckellner@openismus.com>
1496 * libmodest-dbus-client/libmodest-dbus-client.c:
1497 Fix small typo in doc (why do you always see them
1498 AFTER committing stuff?)
1501 2007-06-05 Christian Kellner <ckellner@openismus.com>
1503 * libmodest-dbus-client/libmodest-dbus-client.c:
1504 (libmodest_dbus_client_search):
1505 Initialize hit list with NULL. Also set folder list
1506 to "" if NULL was supplied.
1509 2007-06-03 Christian Kellner <ckellner@openismus.com>
1511 * libmodest-dbus-client/libmodest-dbus-client.c:
1512 (modest_search_hit_list_free):
1513 Make it save to call it with NULL.
1515 * src/dbus_api/modest-dbus-callbacks.c:
1516 * src/modest-search.c:
1517 Return full ModestSearchHits as the search result list not TnyHeader
1518 since can't be around withouth the correspoding TnyFolder.
1520 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1522 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1523 Added currently commented code to check for secure auth
1525 * src/maemo/modest-account-settings-dialog.c: (on_response),
1526 (save_configuration), (show_ok):
1527 Fixed projects.maemo.org bugs NB #59248 and #59251
1529 * src/maemo/modest-maemo-utils.c:
1530 (on_camel_account_get_supported_secure_authentication_status),
1531 (on_camel_account_get_supported_secure_authentication),
1532 (modest_maemo_utils_get_supported_secure_authentication_methods):
1533 * src/maemo/modest-maemo-utils.h:
1534 Moved get_supported_secure_authentication() method here to be able
1535 to use it from easysetup wizard.
1537 * src/modest-pair.c: (on_pair_compare_as_string):
1538 Should compare string with first part of pair and not
1539 strcmp pairs which will crash.
1541 * src/modest-protocol-info.c:
1542 (modest_protocol_info_protocol_is_store):
1543 * src/modest-protocol-info.h:
1544 Added modest_protocol_info_get_auth_protocol_name()
1546 2007-06-03 Armin Burgmeier <armin@openismus.com>
1548 * src/modest-mail-operation.c:
1549 (modest_mail_operation_get_msgs_full): Set priv->account also when
1550 only retrieving a single message. This avoids a crash when canceling
1553 (modest_mail_operation_notify_end): Do not explicitely remove the
1554 operation from the queue but only emit the progress_changed signal.
1555 The queue itself listens to that signal to remove the operation when
1556 it is finished. This reduces coupling and removes a potential deadlock
1557 when modest_mail_operation_notify_end() is called from the queue
1558 itself. If that is a problem performance-wise, I would suggest to
1559 implement a status-changed signal or something.
1561 * src/modest-mail-operation-queue.c: Make sure to never call a
1562 function from another file while the queue is locked. This (hopefully)
1563 fixes another deadlock when exiting the application while retrieving
1566 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1568 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1569 Fixed build if libogs is not available
1571 2007-06-03 Christian Kellner <ckellner@openismus.com>
1573 * libmodest-dbus-client/libmodest-dbus-client.h:
1574 * libmodest-dbus-client/libmodest-dbus-client.c:
1575 (libmodest_dbus_client_delete_message):
1576 Implement deletion of messages (Client side).
1578 (modest_search_hit_free),
1579 (modest_search_hit_list_free):
1580 Utility functions to free the result hits.
1582 * src/dbus_api/modest-dbus-api.h:
1583 * src/dbus_api/modest-dbus-callbacks.c:
1584 (on_delete_message),
1585 (modest_dbus_req_handler):
1586 Implement deletion of messages (Server side).
1588 * tests/dbus_api/test_search.c: (main):
1591 * tests/dbus_api/Makefile.am:
1592 * tests/dbus_api/test_delete_message:
1593 Add little test for the message deletion logic
1595 2007-06-03 Armin Burgmeier <armin@openismus.com>
1597 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1598 when the operation queue was not empty. projects.maemo.org bug
1601 2007-06-03 Armin Burgmeier <armin@openismus.com>
1603 * src/widgets/modest-account-view.c
1604 (on_account_default_toggled): Toggle default account column
1605 explicitely instead of waiting for gconf notification (which is
1606 currently ignored). This should fix projects.maemo.org bug NB#56910
1607 for now. It should probably be removed when gconf notifications are
1610 2007-06-03 Christian Kellner <ckellner@openismus.com>
1612 * libmodest-dbus-client/libmodest-dbus-client.c:
1613 Removed debugging spew.
1615 * src/dbus_api/modest-dbus-callbacks.c:
1616 Added debugging info.
1618 * src/modest-search.c:
1619 (modest_search_all_accounts):
1620 Use tny_account_store_get_accounts () on the account store
1621 to get all accounts which is the way to get all accounts.
1623 * tests/dbus_api/test_search.c: (main):
1624 Make it possible to supply the search term on the command line.
1626 2007-06-03 Christian Kellner <ckellner@openismus.com>
1628 * libmodest-dbus-client/libmodest-dbus-client.c:
1629 * libmodest-dbus-client/libmodest-dbus-client.h:
1630 Implement searching for mesages over raw dbus. (Client side)
1632 * src/dbus_api/Makefile.am:
1633 * src/dbus_api/modest-dbus-api.h:
1634 * src/dbus_api/modest-dbus-callbacks.c:
1635 * src/dbus_api/modest-dbus-callbacks.h:
1636 Search framework (Server side). Also implement on_idle_open_message().
1638 * src/maemo/modest-platform.c: (modest_platform_init):
1639 Prepare for raw dbus/osso rpc interaction.
1641 * src/modest-search.h:
1642 Changed minsize from unspecific guint to guint32.
1644 * src/modest-search.c:
1646 Added strange hack which magically made tnymail work.
1648 (modest_search_folder),
1649 (modest_search_account),
1650 (modest_search_all_accounts):
1651 Implement helper functions to search all accounts, specific account
1654 * tests/dbus_api/Makefile.am:
1655 * tests/dbus_api/test_open_message.c:
1656 Read url to open from commandline.
1658 * tests/dbus_api/test_search.c:
1659 Implement small test for dbus search stuff
1661 2007-06-02 Armin Burgmeier <armin@openismus.com>
1663 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1664 include account type and account title. This fixes projects.maemo.org
1667 * src/maemo/modest-account-view-window.c: Set a title for the window.
1669 2007-06-02 Armin Burgmeier <armin@openismus.com>
1671 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1672 incoming and outgoing server name based on email address and server
1673 types as long as the names have not been edited manually. This fixes
1674 projects.maemo.org bug NB#58671.
1676 2007-06-02 Armin Burgmeier <armin@openismus.com>
1678 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1679 server type cannot be changed in future to the incoming details page
1680 when creating an account. This fixes projects.maemo.org bug NB#59029.
1682 2007-06-02 Armin Burgmeier <armin@openismus.com>
1684 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1685 and assigned max width chars so that they wrap instead of being
1686 truncated. Fixes projects.maemo.org bug NB#56126.
1688 2007-06-02 Armin Burgmeier <armin@openismus.com>
1690 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1691 introductory note to the connection specific smtp servers dialog, as
1692 section 8.12 of the email UI specification requires. This fixes
1693 projects.maemo.org bug NB#59212.
1695 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1697 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1698 Check for running mail operations, and offer to cancel them, as per the UI
1699 spec. This fixes projects.maemo.org bug NB#59041 .
1700 However, I suspect that tinymail may still use the network connection
1701 in ways that we cannot detect or cancel. But it should at least adapt to
1702 changes fairly well.
1704 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1706 * src/modest-tny-account-store.c: (recreate_all_accounts),
1707 (get_cached_accounts), (get_server_accounts): Do more sensible
1708 ref-counting of the temporarily-cached outbox accounts list. This seems
1709 to fix a crash when entering the password when the password was wrong.
1711 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1713 * src/gnome/modest-main-window.c: (connect_signals):
1714 * src/modest-tny-account-store.c: (get_password),
1715 (modest_tny_account_store_alert): Added comments and clues and
1716 commented-out code about how we currently fail to deal with connection
1717 errors and wrong passwords, and how we should.
1719 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1721 * src/widgets/modest-retrieve-combo-box.c:
1722 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1723 This fixes projects.maemo.org bug NB#58472 .
1725 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1727 * src/maemo/easysetup/modest-easysetup-wizard.c:
1728 (create_page_complete_easysetup):
1729 (create_page_complete_custom): Correct the last commit,
1730 putting the correct sentences in the correct pages.
1732 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1734 * src/maemo/easysetup/modest-easysetup-wizard.c:
1735 (create_page_complete_custom): Show the second sentence of text
1736 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1739 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1741 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1742 Set the leave-on-server conf key by default. This fixes
1743 projects.maemo.org bug NB#59258 .
1745 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1747 * src/maemo/modest-account-view-window.c:
1748 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1749 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1754 * src/maemo/easysetup/modest-easysetup-wizard.c:
1755 (create_caption_new_with_asterisk):
1756 * src/maemo/modest-account-settings-dialog.c:
1757 (create_caption_new_with_asterisk):
1758 Uncomment the code to add the asterisk, because they are no longer in the
1759 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1760 (update_incoming_server_title): Add an asterisk here too.
1762 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1764 * src/maemo/modest-maemo-global-settings-dialog.c:
1765 (current_connection): Check that we are even connected before trying to
1766 get the current connection name, to prevent a warning.
1768 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1769 Change the comments because tny_maemo_conic_device_connect() is now meant to
1771 * src/modest-mail-operation.c:
1772 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1773 make sure we have a connection and fail if we can't connect.
1775 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/modest-main-window.c:
1778 (on_account_store_connecting_finished): Do not try to get the
1779 connection ID if we are not really connected. I am surprised that
1780 this signal handler is called when we are not connected.
1782 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-error.h:
1785 * src/modest-ui-actions.c:
1786 (modest_ui_actions_get_msgs_full_error_handler):
1787 Renamed an enum, added comments, added an enum
1788 for retrieve-limit errors.
1790 * src/modest-mail-operation.c: (foreach_add_item),
1791 (internal_folder_observer_update), (update_account_thread),
1792 (modest_mail_operation_get_msgs_full):
1793 (modest_mail_operation_update_account),
1794 Added comments about how this works, and some code that should
1795 (but does not) check the retrieve-limit. See the TODO comment.
1797 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1800 Initialize help_id to fix the build. Warnings are good.
1802 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1804 * src/widgets/modest-hbox-cell-renderer.c:
1805 (modest_hbox_cell_renderer_append):
1806 * src/widgets/modest-vbox-cell-renderer.c:
1807 (modest_vbox_cell_renderer_append):
1808 Fix the last commit by doing an extra ref.
1810 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1812 * src/widgets/modest-hbox-cell-renderer.c:
1813 (modest_hbox_cell_renderer_append):
1814 * src/widgets/modest-vbox-cell-renderer.c:
1815 (modest_vbox_cell_renderer_append):
1816 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1817 to fix the build with Maemo Bora.
1818 However, there seems to be a remaining crash, probably due to reference
1821 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1823 * src/modest-tny-account.c:
1824 (modest_tny_account_new_for_local_folders):
1825 Use hildon_file_system_info_async_new() to get a better name for
1826 the memory card account, setting it as the account name.
1827 The timing seems to work, but this is probably
1828 not the best place to do this. See the TODO comment.
1829 * src/maemo/modest-main-window.c: (create_details_widget):
1830 * src/widgets/modest-folder-view.c: (text_cell_data):
1831 Use the tny account name instead of hardcoding a name.
1833 2007-05-30 Christian Kellner <ckellner@openismus.com>
1835 * src/modest-search.c: (modest_search):
1836 Correctly set part_search_func even if we have already parsed
1837 the query and thus a valid OgsTextSearcher object.
1839 2007-05-30 Christian Kellner <ckellner@openismus.com>
1842 Search and check for libogs.
1845 Incooparte the ogs build env.
1847 * src/modest-mime-part-search-stream.c:
1848 * src/modest-mime-part-search-stream.h:
1849 Removed since we do the real searching now in modest-search.c.
1851 * src/modest-search.c:
1852 * src/modest-search.h:
1853 Implement support for ogs. We use that if available and requested
1854 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1855 should now handle the corner case when the search term is spread
1856 across multiple reads.
1857 Also the logic in modest_search () was corrected to search all
1858 requested fields until one is found.
1860 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1862 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1864 * src/modest-init.h:
1865 * src/modest-init.c: Made modest_init_local_folders() take a
1866 path and be public so we can iniitialize maildir folders on
1869 * src/modest-local-folder-info.h:
1870 * src/modest-local-folder-info.c:
1871 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1873 * src/modest-tny-account.c:
1874 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1875 still means the standard local-folders path on the local volume.
1877 * src/modest-tny-account-store.c:
1878 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1879 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1880 all accounts when that happens.
1881 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1882 this too, so it shows up in the treeview.
1884 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-maemo-global-settings-dialog.c:
1887 (current_connection):
1888 * src/widgets/modest-global-settings-dialog.c:
1889 (current_connection_default):
1890 Use the enum values instead of 0, 1 and -1,
1891 to make the code clearer.
1893 * src/modest-account-mgr-helpers.c:
1894 (modest_account_mgr_get_connection_specific_smtp): Make this code
1897 * src/modest-runtime.h:
1898 * src/modest-runtime.c:
1899 Added modest_runtime_remove_all_send_queues().
1900 * src/maemo/modest-main-window.c:
1901 (on_account_store_connecting_finished): Recreate the send queues,
1902 using the appropriate transport accounts for this new connection.
1903 Some futher adapting might be needed if the old send queues are not
1904 automatically stopped at this point.
1906 * src/modest-tny-account-store.c: (get_server_accounts):
1907 Create the connection-specific transport accounts, so that they can
1908 be found later by their ID.
1910 * src/modest-tny-account.h:
1911 * src/modest-tny-account.c:
1912 Added modest_tny_account_new_from_server_account_name().
1913 modest_tny_account_new_from_server_account(): Do not create the
1914 send queues here, because they will be
1915 recreated anyway when the connection changes for the first time.
1917 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1919 * src/modest-local-folder-info.h:
1920 * src/modest-local-folder-info.c:
1921 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1922 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1923 tbox_folder): Take a modest account name instead of a server TnyAccount,
1924 so we can have per-modest-account rather than per-transport-account
1926 We must make sure that we change or recreate the exisitng send queues
1927 when the connection changes for connection-specific transport accounts.
1929 * src/modest-tny-account-store.c:
1930 (create_per_account_local_outbox_folders): Create outboxed per modest
1931 account, not per transport account.
1933 * src/modest-tny-account.h:
1934 * src/modest-tny-account.c:
1935 (modest_tny_account_get_special_folder): For outboxes, get the
1936 parent modest account name. The account is ignored for other folders.
1937 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1938 modest account name rather than a server TnyAccount.
1940 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-tny-account.c:
1943 (modest_tny_account_new_from_server_account):
1944 Call modest_runtime_get_send_queue() immediately after creating transport
1945 accounts, so that they start trying to send email from the outbox as soon
1946 as possible at startup. This is probably what we want.
1948 * src/modest-mail-operation.c: (update_account_thread):
1949 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1950 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1951 * src/modest-tny-send-queue.h:
1952 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1953 (modest_ui_actions_on_send):
1954 Added comments about how sending works, though it needs some more work.
1956 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1958 * src/modest-tny-account.c:
1959 (modest_tny_account_get_special_folder): Add TODO because this fails when
1960 the network is busy.
1961 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1962 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1963 Do not try to show this window when there is no active account. The UI
1964 specs does not tell us what to do in this case.
1966 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1970 * src/maemo/Makefile.am:
1971 * src/widgets/Makefile.am: Some dist fixes.
1973 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/modest-connection-specific-smtp-window.c:
1976 (on_button_edit): Make the code clearer, to prevent a double free.
1978 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1980 * src/maemo/modest-account-settings-dialog.c:
1981 (modest_account_settings_dialog_set_account_name),
1982 Check the connection-specific smtp servers checkbox if there are any.
1984 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1985 (modest_connection_specific_smtp_edit_window_init):
1986 Start with a suitable port number.
1988 * src/modest-account-mgr-helpers.h:
1989 * src/modest-account-mgr-helpers.c: Added
1990 modest_account_mgr_get_has_connection_specific_smtp().
1992 (modest_account_mgr_set_connection_specific_smtp),
1993 (modest_account_mgr_remove_connection_specific_smtp),
1994 (modest_account_mgr_get_has_connection_specific_smtp),
1995 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1996 connection-specific smtp server accounts in the account, rather than
1997 the server account conf dir.
1999 This fixes bug projects.maemo.org bug NB#58263 .
2001 * src/modest-tny-account-store.c:
2002 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2003 if there are no server accounts yet, to prevent an infinite loop when there
2004 are no accounts. Document that one must be called before the other.
2006 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-account-mgr-helpers.c:
2009 (modest_account_mgr_get_default_account): Make sure that at least
2010 one account is always the default, if there are any enabled accounts.
2011 This is just a sanity check that shouldn't be necessary.
2013 * src/modest-account-mgr-priv.c:
2014 (_modest_account_mgr_account_from_key): Unescape the conf key to
2015 get the real account name. For instance, this is an issue if a space
2016 was in the account name, which can happen because the account name
2017 is generated from the display name.
2018 (_modest_account_mgr_get_account_keyname): Always escape the
2020 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2021 Unescape the conf keys to get the real account names.
2023 For instance, previously the is-default radio button in the accounts
2024 list was not checked for any accounts at first. This fixes that,
2025 and might fix several similar bugs.
2027 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2030 Removed some debug printfs.
2032 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2034 Modest on-disk outbox directories are now here, for instance:
2035 $HOME/.modest/outboxes/<account-id-1>/outbox
2036 $HOME/.modest/outboxes/<account-id-2>/outbox
2038 $HOME/.modest/local-folders/outbox
2039 so we can have a separate outbox for each account.
2040 But they are shown as one outbox in the GtkTreeView, by using a
2041 TnyMergeFolder in a ModestTnySimpleFolderStore.
2044 * src/modest-tny-simple-folder-store.c:
2045 * src/modest-tny-simple-folder-store.h:
2046 Added ModestTnySimpleFolderStore, used to contain folders from
2047 other folder stores, such as other accounts.
2049 * src/modest-tny-outbox-account.h:
2050 * src/modest-tny-outbox-account.c:
2051 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2052 used for the per-account local outbox folders.
2054 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2055 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2056 only use this (internally) now for the non-outbox local folders.
2058 * src/modest-init.h:
2059 * src/modest-init.c: Added modest_init_one_local_folder(), for
2060 setting up the directory structure for each local folder.
2062 * src/modest-local-folder-info.c:
2063 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2064 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2066 * src/modest-local-folder-info.h:
2067 * src/modest-tny-account-store.c: (on_account_removed),
2068 (on_account_changed), (create_per_account_local_outbox_folders),
2069 (get_server_accounts), (modest_tny_account_store_get_accounts),
2070 (modest_tny_account_store_get_tny_account_by_account),
2071 (modest_tny_folder_store_is_virtual_local_folders):
2073 * src/modest-tny-account.h:
2074 * src/modest-tny-account.c:
2075 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2076 to create an on-disk per-account local outbox folder for each
2078 (create_per_account_local_outbox_folders): Create a local outbox folder
2079 for each transport account.
2080 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2081 for all local folders.
2083 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2084 instead of using g_object_get/set() directly. It is clearer.
2086 (modest_tny_folder_store_get_message_count),
2087 (modest_tny_folder_store_get_local_size
2088 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2089 because we now use these with non-acount folder stores.
2091 (modest_tny_account_get_special_folder),
2092 (modest_tny_account_new_from_server_account),
2093 (modest_tny_account_new_from_account):
2094 (recurse_folders): Adjust to the new outbox system.
2096 * src/modest-tny-folder.h:
2097 * src/modest-tny-folder.c:
2098 (modest_tny_folder_is_local_folder),
2099 (modest_tny_folder_get_local_folder_type),
2100 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2102 * src/widgets/modest-main-window.h:
2103 * src/maemo/modest-main-window.c: (create_details_widget),
2104 (modest_main_window_set_contents_style): Show details for any folder store,
2107 (modest_tny_folder_get_rules):
2108 Remove the const. C does not support constness enough for this.
2110 * src/modest-ui-actions.c:
2111 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2112 make all outboxes appear as one, in the usual local-folders tree node.
2114 (set_active_account_from_tny_account),
2115 (modest_ui_actions_on_folder_selection_changed):
2116 * src/widgets/modest-folder-view.c: (text_cell_data),
2117 (icon_cell_data), (filter_row),
2118 (add_account_folders_to_merged_folder),
2119 (add_account_folders_to_simple_folder_store), (),
2120 (get_cmp_rows_type_pos), (cmp_rows),
2121 (modest_folder_view_set_account_id_of_visible_server_account):
2122 Adjust to the new outbox system, using generic folder stores and folders
2123 in the GtkTreeModel.
2125 2007-05-23 Christian Kellner <ckellner@openismus.com>
2127 * src/modest-mail-operation.c:
2128 (modest_mail_operation_update_account):
2129 Use info->max_size instead of unintialized local var [small
2130 build fix]. (Added TODO to review that change since I don't
2133 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2135 * libmodest-dbus-client/libmodest-dbus-client.c:
2136 (libmodest_dbus_client_compose_mail): function added
2137 * src/dbus_api/modest-dbus-api.h:
2138 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2139 (on_compose_mail): Implementation of the SendAsMail functionality
2141 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2143 * src/modest-account-mgr.c:
2144 (modest_account_mgr_add_server_account): Set the secure-connection
2145 conf key for transport accounts as well as store accounts. I don't know
2146 why the if was there. For instance, this makes sure that we use SSL
2147 for the gmail preset from the easysetup wizard.
2149 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2151 * src/gnome/modest-main-window.c:
2152 (on_account_store_connecting_finished), (connect_signals):
2153 * src/maemo/modest-main-window.c:
2154 (on_account_store_connecting_finished), (connect_signals),
2155 (modest_main_window_new):
2156 Handle TnyAccountStore::connecting-finished instead of
2157 TnyDevice::connection-changed, because we cannot actually perform
2158 operations on accounts until TnyAccountStore has itself responded to
2159 the TnyDevice::connection-changed signal. This prevents a GError from
2161 Do not try to update at startup, because we (at least on scratchbox)
2162 already do an update at startup when the device goes online.
2163 This prevents a GError from tinymail.
2164 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2165 Added TODO about stopping simultaneous operations.
2167 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2170 * src/modest-mail-operation-queue.c:
2171 (modest_mail_operation_queue_remove):
2172 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2173 about where they happened.
2175 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-ui-actions.c:
2178 (modest_ui_actions_on_password_requested): Make sure that the remember
2179 output parameter is always TRUE.
2181 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2184 Show a OK/Cancel dialog if the error is a question, though we still do not
2185 know anything more about what we are asking the user.
2186 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2187 Fix an uninitialized variable (helper). This is a logic error, however.
2189 2007-05-21 Christian Kellner <ckellner@openismus.com>
2191 * src/modest-search.h:
2192 Correct bit shifting in the ModestSearchFlags enum.
2194 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2196 * src/modest-tny-account.c:
2197 (modest_tny_account_new_from_server_account): Do not use the lsub and
2198 check-all hard-coded IMAP options when using POP.
2200 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2202 * src/modest-tny-account.c:
2203 (modest_tny_account_new_from_server_account):
2204 Use NULL for the secure-auth method for POP when Password auth has been
2205 specified by the user, as we already do for IMAP. "auth=Login" causes
2206 an error from camel or the server.
2208 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/modest-account-settings-dialog.c:
2211 (create_page_account_details),
2212 (modest_account_settings_dialog_set_account_name):
2213 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2214 for the leave-on-server checkbox, rathr than just the checkbox, when
2215 the protocol is not POP.
2217 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2219 * src/widgets/modest-account-view.c:
2220 * src/widgets/modest-account-view.h:
2221 Added modest_account_view_select_account() which will be useful later
2222 to asynchronously re-select the edited account.
2224 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2226 * src/maemo/modest-account-settings-dialog.c:
2227 (modest_account_settings_dialog_set_account_name):
2228 Automatically choose the port numbers based on the secure authentication
2229 methods, if they have not been chosen before.
2230 This fixes projects.maemo.org bug NB#56273 .
2232 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/modest-main-window-ui.h:
2235 * src/modest-ui-actions.c:
2236 * src/modest-ui-actions.h:
2237 Connect the Tools/SMTP Servers menu item to
2238 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2239 SMTP servers dialog, as in the UI specification and saves changes when it
2240 is closed. This fixed projects.maemo.org bug NB#56305 .
2242 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/modest-connection-specific-smtp-window.c:
2245 (modest_connection_specific_smtp_window_init):
2246 Use gtk_window_set_default_size() to make this window big enough, so
2247 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2249 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2252 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2253 (modest_connection_specific_smtp_edit_window_init),
2254 Do not try to connect to a combobox signal before the combobox exists.
2255 This fixes the cras in projects.maemo.org bug NB#56288 .
2256 (modest_connection_specific_smtp_edit_window_get_settings):
2257 Remove the server_account_name parameter which was being checked for NULL
2258 though it was not used.
2260 * src/maemo/modest-connection-specific-smtp-window.c:
2261 (modest_connection_specific_smtp_window_fill_with_connections),
2262 (on_button_edit), (modest_connection_specific_smtp_window_init):
2263 Correct the number of treemodel columns to prevent a warning.
2264 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2265 libconic does not work.
2267 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2269 * src/modest-tny-account.c:
2270 (modest_tny_account_new_from_server_account):
2271 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2272 SMTP when "None" was chosen by the user. However, with my SMTP server that
2273 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2276 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2278 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2279 to explain the memory management issue with the ID in the ModestPair.
2281 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2282 (add_sending_page), (modest_account_assistant_finalize):
2283 * src/gnome/modest-gnome-global-settings-dialog.c:
2284 (create_updating_page), (create_composing_page):
2285 * src/gnome/modest-msg-edit-window.c: (get_transports),
2286 (init_window), (modest_msg_edit_window_finalize),
2287 (modest_msg_edit_window_get_msg_data):
2288 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2289 * src/gnome/modest-transport-widget.c:
2290 (modest_transport_widget_finalize), (smtp_configuration):
2291 * src/maemo/modest-maemo-global-settings-dialog.c:
2292 (create_updating_page), (create_composing_page):
2293 * src/maemo/modest-msg-edit-window.c: (get_transports),
2294 (init_window), (modest_msg_edit_window_finalize),
2295 (modest_msg_edit_window_get_msg_data),
2296 (modest_msg_edit_window_free_msg_data):
2297 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2298 (modest_store_widget_finalize):
2299 * src/maemo/modest-transport-widget.c:
2300 (modest_transport_widget_finalize), (smtp_configuration):
2301 * src/modest-main.c: (send_mail):
2302 * src/widgets/modest-combo-box.h:
2303 * src/widgets/modest-global-settings-dialog-priv.h:
2304 * src/widgets/modest-global-settings-dialog.c:
2305 (modest_global_settings_dialog_finalize):
2306 * src/widgets/modest-msg-edit-window.h:
2307 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2308 as long as the combo box, to prevent use of freed memory for the ID.
2310 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2312 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2313 get_accounts(), to make this clearer. Do not check for the enabled gconf
2314 key, because we do not use this for server accounts (at least, not yet).
2315 This allows us to send email again.
2317 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2319 * src/maemo/modest-platform.c:
2320 (on_modest_conf_update_interval_changed), (modest_platform_init):
2321 Only respond to this particular key change. All these strcmp()s cannot be
2324 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2326 * src/maemo/modest-maemo-global-settings-dialog.c:
2327 (current_connection): Prevent a crash in scratchbox when
2328 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2329 * src/maemo/modest-platform.c:
2330 (on_modest_conf_update_interval_changed), (modest_platform_init):
2331 Get the update interval from gconf and reset it when the gconf key changes.
2333 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2335 * src/modest-protocol-info.c:
2336 * src/modest-protocol-info.h: Adde enum-specific get functions,
2337 instead of using a ModestProtocolType enum parameter.
2339 * src/gnome/modest-account-assistant.c:
2340 * src/gnome/modest-store-widget.c:
2341 * src/gnome/modest-store-widget.h:
2342 * src/gnome/modest-transport-widget.c:
2343 * src/gnome/modest-transport-widget.h:
2344 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2345 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2346 * src/maemo/easysetup/modest-easysetup-wizard.c:
2347 * src/maemo/modest-account-settings-dialog.c:
2348 * src/maemo/modest-account-settings-dialog.h:
2349 * src/maemo/modest-store-widget.c:
2350 * src/maemo/modest-store-widget.h:
2351 * src/maemo/modest-transport-widget.c:
2352 * src/maemo/modest-transport-widget.h:
2353 * src/modest-account-mgr-helpers.c:
2354 * src/modest-account-mgr-helpers.h:
2355 * src/modest-account-mgr.c:
2356 * src/modest-account-mgr.h:
2357 * src/modest-tny-account.c:
2358 * src/modest-tny-folder.c:
2359 * src/widgets/modest-account-view.c:
2360 * src/widgets/modest-retrieve-combo-box.c:
2361 * src/widgets/modest-retrieve-combo-box.h:
2362 * src/widgets/modest-secureauth-combo-box.c:
2363 * src/widgets/modest-serversecurity-combo-box.c:
2364 * src/widgets/modest-serversecurity-combo-box.h:
2365 * tests/check_account-mgr.c:
2366 Use the specific functions, and use the re-renamed enum values for GNOME too.
2368 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-pair.h:
2371 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2372 so we can get the second based on the first.
2374 * src/maemo/modest-account-settings-dialog.h:
2375 * src/maemo/modest-account-settings-dialog.c:
2376 Added get_supported_secure_authentication_methods(), though it is mostly
2377 commented-out for now until the necessary API is committed to tinymail.
2378 (modest_account_settings_dialog_set_account_name),
2379 (save_configuration): Request the supported authentication methods from the
2380 server, so we can choose a working method.
2382 * src/modest-tny-account-store.h:
2383 * src/modest-tny-account-store.c:
2384 (modest_tny_account_store_get_session): Rename from
2385 tny_account_store_get_session().
2387 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2389 * src/modest-protocol-info.h: Split the ModestProtocol enum
2390 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2391 There was no need to have these unrelated values in one enum.
2393 * src/: many files: Adapted to changed enum. This makes the code a bit
2394 clearer, and the compiler could catch some errors.
2396 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2399 Show the detailed internal camel error message when an error happens
2400 during the configuration, so that our testers can give us more clues.
2401 For instance, in projects.maemo.org bug NB#56910 .
2403 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2405 * src/modest-tny-account.c:
2406 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2407 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2409 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2411 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2412 * src/maemo/modest-account-settings-dialog.c:
2413 (modest_account_settings_dialog_set_account_name),
2414 (save_configuration): For the incoming secure authentication checkbox,
2415 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2416 the UI specification. PLAIN does not seem to be supported for most IMAP
2417 servers anyway, and I am not sure what it would mean.
2418 However, we probably need to discover which of the secure-authentication
2419 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2420 * src/modest-account-mgr-helpers.c:
2421 (modest_account_mgr_get_server_account_data):
2423 * src/modest-tny-account.c:
2424 (modest_tny_account_new_from_server_account):
2425 Use tny_account_set_mech() to set secure-authentication methods,
2426 with some special-casing for IMAP, based on my observations of how
2429 * src/modest-account-mgr-helpers.h:
2430 * src/modest-account-mgr.c:
2431 * src/modest-defs.h: Comment that the URI is only used for local folders.
2433 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2435 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2436 parameter const, just to be neat.
2437 * src/modest-text-utils.c: (modest_text_utils_inline):
2438 End g_strconcat() with NULL, as its documentation says. This is almost
2439 certainly the cause of my crash at startup on the device. Interestingly,
2440 valgrind doesn't tell us about these errors.
2442 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2444 * scripts/build-packages: Added more precise comments about how to use
2445 this script, though I still get this error:
2446 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2447 error building tinymail
2449 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2451 * src/maemo/modest-main-window.c: (on_account_update):
2452 Very slight cleanup, hoping to make it simpler to discover what causes
2453 a crash here sometimes.
2455 * src/modest-tny-account.c:
2456 (modest_tny_account_new_from_server_account): Set the port. Added
2457 comments about the options and a TODO comment because I need to find out
2458 how to specify the secure authentication method.
2460 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2462 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2463 changed CFlags paths form modest to libmodest
2465 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-account-mgr-helpers.c:
2468 (modest_account_mgr_get_server_account_data),
2469 (modest_account_mgr_free_server_account_data):
2470 * src/modest-account-mgr-helpers.h:
2471 * src/modest-account-mgr.c:
2472 (modest_account_mgr_add_server_account):
2473 * src/modest-defs.h:
2474 * src/modest-tny-account.c:
2475 (modest_tny_account_new_from_server_account):
2476 Determine the options for tny_camel_account_add_option() here,
2477 based on the settings, rather than storing them directly in gconf.
2479 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2481 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2482 Show a more friendly error dialog now that we expect (from the tinymail
2483 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2485 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2487 * src/maemo/modest-main-window.c: (on_account_update): Check that
2488 account_name is not NULL, to prevent a crash at startup that I am
2489 seeing on the N800. I do wonder why it is NULL.
2491 * src/maemo/easysetup/modest-easysetup-wizard.c:
2492 (create_page_user_details):
2493 * src/maemo/modest-account-settings-dialog.c:
2494 (create_page_user_details), (create_page_outgoing):
2495 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2496 (modest_connection_specific_smtp_edit_window_init):
2497 * src/modest-ui-actions.c:
2498 (modest_ui_actions_on_password_requested):
2499 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2500 might do something useful with the on-screen keyboard.
2502 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/modest-main-window.c: (on_account_update):
2505 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2506 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2508 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2510 * src/modest-tny-account-store.c: (on_account_changed):
2511 Correct the signature of this signal handler.
2513 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2515 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2516 Show a HildonNote instead of a GtkDialog for Maemo.
2518 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2520 * src/widgets/modest-account-view.h:
2521 * src/widgets/modest-account-view.c: (on_account_changed),
2522 (on_account_removed). Added a boolean flag, set/unset by
2523 modest_account_view_block_conf_updates(),
2524 modest_account_view_unblock_conf_updates() to prevent unnecessary
2525 updates, but this is not very useful because the gconf notifications are
2526 so delays (maybe only on Maemo Bora).
2527 So auto-updating is turned off, and these functions do an explicit
2528 update when necessary.
2529 However, something else is still doing too much work when adding/removing
2530 accounts, probably in another part of the application.
2532 * src/maemo/modest-account-view-window.c:
2533 (on_delete_button_clicked), (on_edit_button_clicked),
2534 (on_new_button_clicked): Use the new functions.
2536 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-account-mgr-helpers.c:
2539 (modest_account_mgr_set_first_account_as_default):
2540 Sort the list of names alphabetically-by-title, so we choose the first one
2542 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2543 alphabetically by the title.
2545 This fixes projects.maemo.org bug NB#56418 .
2547 * src/modest-account-mgr-priv.c:
2548 (_modest_account_mgr_account_from_key):
2549 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2550 avoid a valgrind error, and possible random behaviour.
2552 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2554 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2555 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2556 tinymail documentation to say that this can be expected.
2557 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2558 pretty, and should not happen, but I would prefer to know when it does.
2560 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2562 * configure.ac: When using the older hildon version, probably on Bora,
2563 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2565 * src/widgets/modest-attachment-view.c:
2566 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2569 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2571 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2572 Implemented the prototype. Can be tested with
2573 tests/dbus_api/test_open_message:
2575 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2577 * src/modest-tny-account-store.c:
2578 (modest_tny_account_store_instance_init), (get_password):
2579 * src/modest-ui-actions.c:
2580 (modest_ui_actions_on_password_requested):
2581 Do not store the password in gconf, because this function is called
2582 for non-remembered passwords. Actually use the cached (in the hash map)
2583 password instead of releasing it.
2584 The password will now not be remembered if it is asked via the protected
2585 password dialog, as per the UI spec.
2587 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2589 * src/modest-defs.h:
2590 * src/modest-account-mgr-helpers.h:
2591 * src/modest-account-mgr-helpers.c:
2592 Added modest_server_account_get_username_has_succeeded(),
2593 modest_server_account_set_username_has_succeeded().
2594 (modest_server_account_set_username),
2595 Reset the has-succeeded flag if the username changes.
2597 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2598 * src/maemo/modest-connection-specific-smtp-window.c:
2599 (modest_connection_specific_smtp_window_save_server_accounts):
2600 Use modest_server_account_set_username() instead of using
2601 modest_conf_set_string() directly, so that the has-succeeded flag is always
2604 * src/modest-ui-actions.c:
2605 (modest_ui_actions_on_password_requested): Dim the username entry if
2606 the username has ever worked, as per the UI spec.
2608 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2610 * src/modest-tny-account-store.c: (get_password):
2611 * src/modest-ui-actions.c:
2612 (modest_ui_actions_on_password_requested):
2613 Allow the username to be changed too, though there is more work to
2614 be done on exactly how this behaves.
2616 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2618 * src/modest-account-mgr-helpers.h:
2619 * src/modest-account-mgr-helpers.c:
2620 Added modest_account_mgr_get_display_name(),
2621 modest_server_account_get_username(),
2622 modest_server_account_set_username(),
2623 modest_server_account_set_password(),
2624 modest_server_account_get_hostname() functions so we do not need to
2625 use the conf API directly.
2627 * src/maemo/modest-main-window.c: (connect_signals):
2628 Actually connect ot the ModestAccountStore::request-password signal,
2629 so that we show the dialog when the password is requested by Tinymail,
2630 for isntance if it is empty.
2632 * src/modest-marshal.list:
2633 * src/modest-tny-account-store.c:
2634 (modest_tny_account_store_class_init), (get_password),
2635 (modest_tny_account_store_alert):
2636 * src/modest-tny-account-store.h:
2637 * src/modest-ui-actions.h:
2638 * src/modest-ui-actions.c:
2639 (modest_ui_actions_on_password_requested):
2640 Change the signal parameters, so it is obvious that we are providing
2641 the non human-readable server name, and receiving both the username
2642 and password, though changing of the username is not yet implemented.
2643 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2644 for the GNOME version.
2646 This should fix the projects.maemo.org bug NB#56209, though it does not
2647 work on Bora, because the gconf_client_get() for the password fails
2648 immediately after we save it with gconf_client_set().
2650 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2653 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2654 caused an undefined symbol error:
2655 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2657 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-tny-account-store.c:
2660 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2661 using a GError instead of a string message, so we can translate it in
2664 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/modest-address-book.c:
2667 (modest_address_book_check_names):
2668 * src/maemo/modest-msg-view-window.c:
2669 (modest_msg_view_window_clipboard_owner_change):
2670 * src/modest-init.c: (modest_init_init_ui):
2671 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2672 (update_folders_cb), (modest_mail_operation_update_account):
2673 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2674 (modest_ui_actions_on_msg_attachment_clicked),
2675 (modest_ui_actions_on_msg_recpt_activated):
2676 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2677 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2678 (modest_msg_view_search_next):
2679 * src/widgets/modest-recpt-editor.c:
2680 (modest_recpt_editor_on_button_release_event),
2681 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2682 g_message(). At this point we should only be seeing interesting errors on
2683 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2685 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2687 (modest_wizard_dialog_force_title_update):
2688 * src/maemo/easysetup/modest-wizard-dialog.h:
2689 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2690 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2691 can update the title when appropriate. Otherwise the title is wrong if the
2692 pages are added after adding the notebook to the dialog.
2693 This must be a problem in HildonWizardDialog too.
2694 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2696 * src/maemo/easysetup/modest-easysetup-wizard.c:
2697 (create_subsequent_customsetup_pages),
2698 (create_subsequent_easysetup_pages):
2699 Call modest_wizard_dialog_force_title_update() so that the title is
2700 correct even with GTK+ < 2.10.
2701 This fixes projects.maemo.org bug NB#56145 .
2703 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/modest-platform.c:
2706 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2707 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2710 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2712 * src/widgets/modest-window.h:
2713 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2714 and modest_window_save_state(), which invokes it.
2716 * src/widgets/modest-window-mgr.h:
2717 * src/widgets/modest-window-mgr.c:
2718 Added modest_window_mgr_save_state_for_all_windows(), which calls
2719 the save_state vfunc on all registered windows, if implemented.
2721 * src/gnome/modest-msg-edit-window.c:
2722 * src/gnome/modest-msg-view-window.c:
2723 * src/maemo/modest-msg-edit-window.c:
2724 * src/maemo/modest-msg-view-window.c:
2725 * src/maemo/modest-main-window.c:
2726 Specify the existing save_settings functions as implementations of
2727 ModestWindow::save_state_func().
2729 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2730 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2731 enabling hibernation, for instance.
2733 We may need to do the same thing for restoring settings.
2736 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2738 * src/widgets/modest-window-mgr.c:
2739 * src/widgets/modest-window-mgr.h:
2740 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2741 modest_window_mgr_get_hibernation_is_prevented().
2743 * src/maemo/modest-main-window.c:
2744 (on_hildon_program_is_topmost_notify): Prevent hibernation
2745 (possible when the application goes to the background in the WM),
2746 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2748 * src/maemo/easysetup/modest-easysetup-wizard.c:
2749 (modest_easysetup_wizard_dialog_init):
2750 * src/maemo/modest-account-settings-dialog.c:
2751 (modest_account_settings_dialog_init):
2752 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2753 (modest_connection_specific_smtp_edit_window_init):
2754 * src/maemo/modest-connection-specific-smtp-window.c:
2755 (modest_connection_specific_smtp_window_init):
2756 * src/maemo/modest-signature-editor-dialog.c:
2757 (modest_signature_editor_dialog_init):
2758 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2759 prevent hibernation while any of these account settings dialogs are open.
2761 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2763 * src/maemo/Makefile.am:
2764 * src/maemo/modest-osso-state-saving.c:
2765 * src/maemo/modest-osso-state-saving.h: Added
2766 modest_osso_load_state() and modest_osso_save_state() though they do
2767 nothing now. They should iterate through all the open windows and load/save
2769 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2770 save state when closing.
2772 * src/maemo/modest-main-window.c:
2773 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2774 Add a notification handler for the HildonProgram::is-topmost property,
2775 so we can allow hibernation when the application goes into the background.
2776 But we still need to detect when the accounts setup windows are open so
2777 we can stop hibernation when they are open.
2778 To do this, I also added the main window the HildonProgram. This might have
2779 other side-effects/benefits, and should maybe be done for other windows.
2781 * src/maemo/modest-osso-autosave-callbacks.h:
2782 * src/maemo/modest-osso-autosave-callbacks.c:
2783 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2784 though it does not do anything yet, and we might never need this to do
2785 anything. For instance, we already save drafts.
2787 * src/maemo/modest-platform.c: (modest_platform_init):
2788 Specify the libosso auto-save callback.
2790 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/modest-platform.c:
2793 (modest_platform_set_update_interval):
2794 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2795 aparently stays valid between application instances, so we can use this
2796 to remove and reset it later. According to a maemo-developers email from
2799 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2801 * configure.ac: Depend on libalarm for Maemo.
2803 * src/dbus_api/modest-dbus-api.h:
2804 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2805 (on_send_receive), (modest_dbus_req_handler):
2806 Handle a SEND_RECEIVE D-Bus method.
2808 * libmodest-dbus-client/libmodest-dbus-client.c:
2809 (libmodest_dbus_client_send_and_receive):
2810 * libmodest-dbus-client/libmodest-dbus-client.h:
2811 Add C convenience functions for calling the new D-Bus method.
2813 * src/modest-platform.h:
2814 * src/gnome/modest-platform.c:
2815 * src/maemo/modest-platform.c:
2816 Added modest_platform_set_update_interval(), which uses the
2817 alarmd API on Maemo.
2818 (modest_platform_init),
2819 Call modest_platform_set_update_interval(), using a hard-coded
2820 interval for now (until the global settings dialog is implemented),
2821 though I am not sure that this makes sense yet.
2823 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2825 * src/dbus_api/modest-dbus-callbacks.c:
2826 (modest_osso_cb_hw_state_handler):
2827 * src/dbus_api/modest-dbus-callbacks.h:
2828 * src/maemo/modest-platform.c: (modest_platform_init):
2829 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2830 in case this has some effect on the ability for Maemo to ping the
2833 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2835 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2836 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2837 warning. It is probably a logic error, but I need to fix the build.
2839 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2841 * src/modest-account-mgr.h:
2842 * src/modest-account-mgr.c:
2843 (modest_account_mgr_account_names): Add a gboolean enabled_only
2844 parameter, so we can get lists of onlt the enabled accounts.
2846 (modest_account_mgr_add_account),,
2847 (modest_account_mgr_account_with_display_name_exists):
2848 * src/maemo/modest-msg-edit-window.c: (get_transports):
2849 * src/modest-account-mgr-helpers.c:
2850 (modest_account_mgr_set_first_account_as_default):
2851 * src/modest-init.c: (init_default_account_maybe):
2852 * src/modest-tny-account-store.c: (get_accounts):
2853 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2854 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2855 * tests/check_account-mgr.c: (START_TEST):
2856 Provide the extra parameter, as appropriate.
2858 * src/widgets/modest-account-view.c: (update_account_view):
2859 Do not show disabled accounts (meaning that there is no way to
2860 enable/disable accounts in the UI (the feature is not in our UI
2861 specification), so we can use this internally only to mark unfinished
2862 or temporary account data.
2864 * src/maemo/easysetup/modest-easysetup-wizard.c:
2865 (create_account): Add boolean enable parameter, so we can specify FALSE
2866 to create the temporary account.
2867 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2868 (on_before_next): When finishing, when there is a temporary account, just
2870 Also, use a timeout to delay the showing of the dialog until gconf is likely
2871 to return correct information, due to a maemo gconf bug that is fixed in
2872 osso 1.1, but not yet in Bora.
2873 However, the dialog stays on screen after it is destroyed.
2875 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2876 for invalid data when cancelling. Use a hildon note instead of a dialog
2877 to complain about invalid data. Do not show the account-saved note if the
2878 account is disabled (a temporary account that will not really be saved for use
2881 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-account-mgr-helpers.h:
2884 * src/modest-account-mgr-helpers.c:
2885 Added modest_account_mgr_unset_default_account(),
2886 Added modest_account_mgr_set_first_account_as_default().
2888 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2889 If it was the default account, unset the default account name.
2891 * src/maemo/modest-account-view-window.c:
2892 (on_delete_button_clicked): If it was the default account,
2893 set the first remaining account as the default instead.
2895 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2896 a NULL account or a NULL default account, to prevent a crash. This should
2897 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2900 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2902 * src/widgets/modest-recpt-editor.c:
2903 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2904 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2905 TODO comment for this. This fixes the build.
2907 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2908 be the best place for it. This will in future update all auto-update accounts,
2909 rather than just the current/default account, when that gconf key exists.
2910 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2911 if there are no accounts, before calling do_send_receive().
2912 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2914 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2915 * src/maemo/modest-main-window-ui.h:
2916 * src/maemo/modest-main-window.c: (on_connection_changed),
2917 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2918 directly, becaue the signal handler does more.
2920 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2922 * src/modest-account-mgr-helpers.c:
2923 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2924 for the case that the account does not exist.
2926 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2927 (equivalent to the modest account name) rather than the tinymail account name
2928 (equivalent to the modest account title - human readable) to get the account data.
2929 Check for null account data to prevent the crash, and add a TODO comment saying that
2930 this needs fixing because it is using the server account name instead of the account name.
2932 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2935 * src/maemo/modest-account-settings-dialog.c: (show_error),
2937 Use hildon_note_new_information() for informative and error messages,
2938 which seems to be expected for Maemo applications (no documentation that I know of
2939 says this). I am surprised that there is no distinction between info and error
2942 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2944 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2945 it is easy to find where this is used.
2947 * src/maemo/easysetup/modest-easysetup-wizard.c:
2948 (create_page_welcome), (create_page_account_details),
2949 (create_page_user_details), (create_page_complete_easysetup),
2950 (create_page_custom_incoming), (create_page_custom_outgoing),
2951 (create_page_complete_custom):
2952 * src/maemo/modest-account-settings-dialog.c:
2953 (create_page_account_details), (create_page_user_details),
2954 (create_page_incoming), (create_page_outgoing):
2955 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2956 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2957 (modest_connection_specific_smtp_edit_window_init):
2958 * src/maemo/modest-connection-specific-smtp-window.c:
2959 (modest_connection_specific_smtp_window_init):
2960 * src/maemo/modest-signature-editor-dialog.c:
2961 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2962 and scrolling policy as per the Email Application Layout Guide, if I have
2965 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2967 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2968 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2969 which were empty, because these vfuncs have been removed from TnyAccountStore.
2970 This fixes the build.
2972 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/modest-main-window.c:
2975 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2976 showing/hiding it. Added TODO because it probably should not be NULL.
2977 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2978 because unnecessary g_warnings() make degugging difficult.
2980 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-msg-edit-window.c:
2983 (modest_msg_edit_window_select_color),
2984 (modest_msg_edit_window_select_background_color): 2 const corrections and
2985 moving 2 #endifs before closing brackets, to fix the build.
2987 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/easysetup/modest-easysetup-wizard.h:
2990 * src/maemo/easysetup/modest-easysetup-wizard.c:
2991 (modest_easysetup_wizard_dialog_finalize),
2992 (on_button_edit_advanced_settings), (create_page_complete_custom),
2993 (on_response), (create_account):
2994 Implement the Advanced Settings edit button, by saving the account information,
2995 for the Advanded Settings dialog to use directly from gconf, and removing it
2996 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2997 Bug #5533 in the projects.maemo.org bugzilla.
2999 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/modest-msg-view-window.c:
3002 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3003 when opening a message window.
3005 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3011 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3012 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3013 gconf settings. I probably added more checks than necessary, but that is safer.
3015 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3016 variable to fix the build, but this seems to be used when it is still NULL.
3018 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3020 * src/modest-platform.h:
3021 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3022 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3023 * src/modest-main.c: Implement this function so we can avoid using
3024 maemo-specific API from cross-platform code.
3026 * src/modest-tny-account-store.c:
3027 (get_smtp_specific_transport_account_for_open_connection):
3028 * src/modest-ui-actions.c: (check_for_connection),
3029 (modest_ui_actions_on_item_not_found):
3030 Use modest_platform_connect_and_wait() and put #idefs around other
3031 maemo-specific code, because only maemo currently has a way to
3032 identify connection names.
3034 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3036 * src/modest-tny-account-store.h:
3037 * src/modest-tny-account-store.c:
3038 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3039 the connection-specific SMTP server settings in the configuration.
3041 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3043 * src/maemo/modest-main-window.c: (on_connection_changed),
3045 * src/modest-main.c: (main), (start_ui), (send_mail):
3046 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3047 that is what is intended.
3049 * src/modest-ui-actions.c: (action_send), (action_receive),
3050 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3051 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3052 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3053 SMTP server is used when it is specified.
3055 (modest_ui_actions_on_send_receive):
3056 Check that a connection is open before proceeding.
3057 Receive and then send, instead of vice-versa, as per the specification.
3059 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3061 * src/modest-mail-operation.c:
3062 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3063 though I guess it should be something other than NULL.
3065 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/easysetup/modest-easysetup-wizard.c:
3068 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3069 combo twice, to avoid an g_warning and to make it visible again.
3070 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3071 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3072 (already intended) dereference when detaching, because we then recreate the menu.
3073 But I am not sure why the warning was happening, and it is possible that this is a memory
3076 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3078 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3079 and uri_parse_mailto() utility functions.
3080 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3082 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3084 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3086 * src/dbus_api/modest-dbus-api.h:
3087 * src/dbus_api/modest-dbus-callbacks.c:
3088 Use an idle callback to execute the modest code in the application's own thread.
3089 Remove the helloworld example method.
3090 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3091 parsed, and the open-message method is not implemented because this is not yet implemented in
3093 * libmodest-dbus-client/libmodest-dbus-client.c:
3094 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3095 (libmodest_dbus_client_open_message):
3096 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3098 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3099 body without crashing.
3101 * tests/dbus_api/Makefile.am:
3102 * tests/dbus_api/test_mail_to.c:
3103 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3105 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3107 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3108 Added file to fix the build. Sorry.
3110 * src/dbus_api/Makefile.am:
3111 * src/dbus_api/modest-dbus-api.h:
3112 * src/dbus_api/modest-dbus-callbacks.h:
3113 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3114 (modest_dbus_req_handler):
3115 Put constants in a separate header so it can be reused by the
3116 client library, without duplication
3118 * libmodest-dbus-client/Makefile.am:
3119 * libmodest-dbus-client/libmodest-dbus-client.c:
3120 (libmodest_dbus_client_call_helloworld),
3121 (libmodfest_dbus_client_send_mail),
3122 (libmodfest_dbus_client_mailto),
3123 (libmodfest_dbus_client_open_message):
3124 * libmodest-dbus-client/libmodest-dbus-client.h:
3125 (Partly) Implement a send_mail D-Bus method.
3127 * tests/dbus_api/Makefile.am:
3128 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3129 the send_email D-Bus method.
3131 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3135 * libmodest-dbus-client/Makefile.am:
3136 * libmodest-dbus-client/libmodest-dbus-client.c:
3137 * libmodest-dbus-client/libmodest-dbus-client.h:
3138 * tests/dbus_api/Makefile.am:
3139 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3140 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3142 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3144 * src/maemo/easysetup/modest-easysetup-wizard.c:
3145 (create_page_account_details):
3146 * src/maemo/modest-account-settings-dialog.c:
3147 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3148 widgets, because this might not be the default in future versions of the Maemo GTK+.
3149 However, I can not not get capitalization to work even in a simple test case.
3151 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/easysetup/modest-easysetup-wizard.c:
3154 (create_page_custom_incoming), (create_page_custom_outgoing):
3155 * src/maemo/modest-account-settings-dialog.c:
3156 (create_page_account_details), (create_page_incoming),
3157 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3158 instead of using gtk_check_button_with_label(), so they are aligned like the other
3159 widgets, as per the UI spec.
3161 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/easysetup/modest-easysetup-wizard.c:
3164 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3165 * src/widgets/modest-validating-entry.c:
3166 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3167 Modest prefix instead of an EasySetup prefix.
3169 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3171 * src/widgets/modest-validating-entry.h:
3172 * src/widgets/modest-validating-entry.c: (on_insert_text),
3173 Added easysetup_validating_entry_set_max_func(), used to set a callback
3174 to call when the max number of characters is reached. GtkEntry has a max-length
3175 already but is silent about it.
3177 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3178 (create_page_account_details), (create_page_user_details),
3180 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3181 (create_page_account_details), (create_page_user_details),
3182 (create_page_outgoing):
3183 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3184 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3185 the UI spec, when the user tries to enter more than the max number of characters.
3187 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/easysetup/modest-easysetup-wizard.c:
3190 (create_page_user_details), (create_page_custom_incoming),
3191 (create_page_custom_outgoing):
3192 * src/maemo/modest-account-settings-dialog.c:
3193 (create_page_user_details), (create_page_incoming),
3194 (create_page_outgoing):
3195 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3196 (modest_connection_specific_smtp_edit_window_init):
3197 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3198 not appropriate. Bad Maemo-specific defaults!.
3200 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3202 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3203 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3204 (modest_signature_editor_dialog_set_settings):
3205 Disable the label and textview when the checkbox is disabled, and use the
3206 specified (UI spec) default signature text.
3208 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3210 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3211 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3213 * src/modest-defs.h:
3214 * src/modest-account-mgr-helpers.h:
3215 * src/modest-account-mgr-helpers.c:
3216 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3218 * src/maemo/Makefile.am:
3219 * src/maemo/modest-signature-editor-dialog.c:
3220 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3223 * src/maemo/modest-account-settings-dialog.h:
3224 * src/maemo/modest-account-settings-dialog.c:
3225 (modest_account_settings_dialog_finalize), (on_button_signature),
3226 (save_configuration): Use the new dialog when the Edit button is pressed, and
3227 save the changes if necessary, as per the UI spec.
3229 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/Makefile.am:
3232 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3233 based on maemo-develoers email from Dirk.
3235 * src/maemo/easysetup/modest-easysetup-wizard.c:
3236 (create_page_welcome), (create_page_account_details),
3237 (create_page_user_details), (create_page_complete_easysetup),
3238 (create_page_custom_incoming), (create_page_custom_outgoing),
3239 (create_page_complete_custom),
3240 (modest_easysetup_wizard_dialog_init):
3241 * src/maemo/modest-account-settings-dialog.c:
3242 (create_page_account_details), (create_page_user_details),
3243 (create_page_incoming), (create_page_outgoing),
3244 (modest_account_settings_dialog_init):
3245 * src/maemo/modest-connection-specific-smtp-window.c:
3246 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3248 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/easysetup/modest-easysetup-wizard.c:
3251 (create_page_account_details), (create_page_custom_outgoing),
3252 (create_page_complete_custom):
3253 * src/maemo/modest-account-settings-dialog.c:
3254 (create_page_user_details), (create_page_incoming),
3255 (create_page_outgoing):
3256 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3257 (modest_connection_specific_smtp_edit_window_init):
3258 Use the correct (UI spec) port min/max, and use horizontal separators,
3261 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3263 * src/maemo/easysetup/modest-easysetup-wizard.c:
3264 (set_default_custom_servernames):
3265 * src/maemo/modest-account-settings-dialog.c:
3266 (create_page_incoming), (on_combo_outgoing_security_changed),
3267 (on_combo_incoming_security_changed), (create_page_outgoing),
3268 (modest_account_settings_dialog_set_account_name),
3269 (save_configuration):
3270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3271 (on_combo_security_changed),
3272 (modest_connection_specific_smtp_edit_window_init),
3273 (modest_connection_specific_smtp_edit_window_set_connection),
3274 (modest_connection_specific_smtp_edit_window_get_settings):
3275 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3278 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/easysetup/modest-easysetup-wizard.c:
3282 (create_page_custom_outgoing), (create_page_complete_custom):
3283 * src/maemo/modest-account-settings-dialog.c:
3284 (create_page_user_details), (create_page_outgoing):
3285 * src/maemo/modest-account-view-window.c: (button_box_new):
3286 Use changed logical IDs as per the most recent UI spec:
3287 mcen_bd_emailsetup_edit -> mcen_bd_edit
3288 mcen_bd_emailsetup_delete -> mcen_bd_delete
3289 mcen_bd_emailsetup_close -> mcen_bd_close
3291 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3295 * src/dbus_api/Makefile.am:
3296 * src/dbus_api/modest-dbus-callbacks.c:
3297 * src/dbus_api/modest-dbus-callbacks.h:
3298 * src/maemo/modest-platform.c: (modest_platform_init):
3299 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3301 * tests/Makefile.am:
3302 * tests/dbus_api/Makefile.am:
3303 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3305 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/modest-account-settings-dialog.c:
3308 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3309 Removed unnecessary includes.
3311 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3313 * src/maemo/easysetup/modest-easysetup-wizard.c:
3314 * src/maemo/modest-account-settings-dialog.c:
3315 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3316 * src/widgets/Makefile.am:
3317 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3318 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3319 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3320 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3321 * src/widgets/modest-secureauth-combo-box.c:
3322 * src/widgets/modest-secureauth-combo-box.h:
3323 * src/widgets/modest-serversecurity-combo-box.c:
3324 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3325 made the GObject names more consistent with the rest of the Modest code.
3327 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3329 * src/maemo/easysetup/Makefile.am:
3330 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3331 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3332 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3333 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3334 * src/maemo/easysetup/modest-easysetup-wizard.c:
3335 * src/maemo/easysetup/modest-validating-entry.c:
3336 * src/maemo/easysetup/modest-validating-entry.h:
3337 * src/maemo/modest-account-settings-dialog.c:
3338 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3339 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3340 widgets/ because they are used outside of easysetup too. After checking in,
3341 svn will allow me to rename them too.
3343 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3345 * src/gnome/modest-msg-edit-window.c:
3346 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3347 linker error, to fix the build on the GNOME platform.
3348 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3349 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3350 ifdefed out to avoid a warning.
3352 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3354 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3355 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3356 some alternative for GTK+ 2.6.
3358 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3362 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3363 specified for EmailAccountsDialog in UI spec.
3365 * src/maemo/easysetup/modest-easysetup-wizard.c:
3366 * src/maemo/easysetup/modest-easysetup-wizard.h:
3367 * src/maemo/modest-account-settings-dialog.c:
3368 * src/maemo/modest-account-settings-dialog.h:
3369 Reuse a member window widget for the connection-specific SMTP server accounts,
3370 so we can tell it to create/save the accounts only if we actually save changes.
3372 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3374 (modest_connection_specific_smtp_edit_window_get_settings):
3375 Return a struct instance for temporarily remembering the entered data.
3377 * src/maemo/modest-connection-specific-smtp-window.h:
3378 * src/maemo/modest-connection-specific-smtp-window.c:
3379 (modest_connection_specific_smtp_window_finalize),
3380 (modest_connection_specific_smtp_window_fill_with_connections),
3382 (modest_connection_specific_smtp_window_save_server_accounts),
3383 (update_model_server_names): Do not actually save data until asked,
3384 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3386 (on_selection_changed),
3387 (modest_connection_specific_smtp_window_init): Disable the edit
3388 button when nothing is selected.
3390 * src/modest-account-mgr-helpers.c:
3391 * src/modest-account-mgr-helpers.h:
3392 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3395 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3397 * src/modest-account-mgr-helpers.h:
3398 * src/modest-account-mgr-helpers.c:
3399 (modest_account_mgr_get_unused_account_name),
3400 (modest_account_mgr_get_unused_account_display_name): Added these
3401 utility functions, to avoid code duplication.
3403 * src/maemo/easysetup/modest-easysetup-wizard.c:
3404 (create_page_account_details), (create_account):
3405 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3406 (on_combo_security_changed),
3407 (modest_connection_specific_smtp_edit_window_init),
3408 (modest_connection_specific_smtp_edit_window_save_settings):
3409 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3410 * src/maemo/modest-connection-specific-smtp-window.c:
3411 (modest_connection_specific_smtp_window_finalize),
3412 (modest_connection_specific_smtp_window_fill_with_connections),
3413 (on_button_edit), (modest_connection_specific_smtp_window_init):
3414 * src/maemo/modest-connection-specific-smtp-window.h:
3415 Implementing saving of connection-specific server accounts.
3417 But I need to refactor this so we can save the data for each
3418 possible connection-specific account and only actually create the server accounts
3419 when the easysetup finished, or the OK button is pressed on the account settings
3422 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3425 (on_combo_security_changed):
3426 (modest_connection_specific_smtp_edit_window_init):
3427 Auto-fill the port number as in the account settings.
3429 (modest_connection_specific_smtp_edit_window_set_connection):
3430 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3431 * src/maemo/modest-connection-specific-smtp-window.c:
3432 (fill_with_connections), (on_button_edit),
3433 (modest_connection_specific_smtp_window_init):
3434 Turn the edit window into a dialog to simplify the code, and
3435 set a WM hint as in a GtkDialog, because only a popup can be on top of
3436 another window in Maemo, and popups usually have no WM decoration.
3438 * src/modest-defs.h:
3439 * src/modest-account-mgr-helpers.c:
3440 (modest_account_mgr_set_connection_specific_smtp),
3441 (modest_account_mgr_remove_connection_specific_smtp),
3442 (modest_account_mgr_get_connection_specific_smtp):
3443 * src/modest-account-mgr-helpers.h: Some functions to write the
3444 connection-specific SMTP server information. Not yet used.
3447 * src/widgets/modest-folder-view.c: (text_cell_data):
3448 Fix a warning about an uninitialized variable.
3449 (on_configuration_key_changed): Put an #ifdef around the use
3450 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3452 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/modest-account-settings-dialog.h:
3455 * src/maemo/modest-account-settings-dialog.c:
3456 Added connect_for_modified() utility function to mark the new modified boolean.
3458 (create_page_account_details), (create_page_user_details),
3459 (create_page_incoming), (create_page_outgoing), (on_response),
3460 (modest_account_settings_dialog_init),
3461 (modest_account_settings_dialog_set_account_name):
3462 Only warn about unsaved changes when there are actually unsaved changes.
3464 * src/modest-account-mgr-helpers.c:
3465 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3466 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3467 to get the data from there in future.
3469 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3471 * src/modest-defs.h:
3473 * src/modest-account-mgr-helpers.h:
3474 * src/modest-account-mgr-helpers.c:
3475 Store the security account setting in a single conf key instead of using
3476 the options list, so that the list is left for just the to-be-removed camel hack,
3477 and because gconf_client_set_list() is failing for some reason.
3479 * src/modest-account-mgr.c:
3480 (modest_account_mgr_add_server_account):
3481 * src/maemo/modest-account-settings-dialog.c:
3482 (modest_account_settings_dialog_set_account_name),
3483 (save_configuration): Use the renamed functions.
3486 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3488 * src/widgets/Makefile.am:
3489 * src/widgets/modest-limit-retrieve-combo-box.c:
3490 * src/widgets/modest-limit-retrieve-combo-box.h:
3491 * src/widgets/modest-retrieve-combo-box.c:
3492 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3493 the account settings dialog.
3495 * src/modest-defs.h:
3496 * src/modest-account-mgr-helpers.h:
3497 * src/modest-account-mgr-helpers.c:
3498 (modest_server_account_get_option_secure_auth),
3499 (modest_server_account_set_option_secure_auth):
3500 * src/modest-account-mgr.c:
3501 (modest_account_mgr_add_server_account):
3502 Use the existing AUTH_MECH conf key for the secure-auth setting,
3503 instead of putting it in the list options, because this was actually used already.
3505 * src/maemo/modest-account-settings-dialog.c:
3506 (create_page_account_details),
3507 (modest_account_settings_dialog_set_account_name),
3508 (save_configuration):
3509 * src/maemo/modest-account-settings-dialog.h:
3510 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3511 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3513 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3515 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3516 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3517 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3519 * src/modest-defs.h:
3520 * src/maemo/modest-account-settings-dialog.c:
3521 (create_page_incoming), (on_combo_outgoing_security_changed),
3522 (on_combo_incoming_security_changed), (create_page_outgoing),
3523 (modest_account_settings_dialog_set_account_name),
3524 (save_configuration): Load/Save the port number, and change it when the
3525 security combo changes, to suitable defaults.
3527 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3529 * src/modest-account-mgr.c:
3530 (modest_account_mgr_add_server_account): Set the security and secure-auth
3531 options, and add a comment saying that the other camel-specific options should be
3534 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3536 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3538 * src/modest-tny-account-store.c: (account_list_free),
3539 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3540 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3543 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3545 * src/modest-protocol-info.c:
3546 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3547 is required by our UI spec. Maybe something in our implementation will use this eventually.
3548 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3549 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3550 instead of the previous 0 placeholder.
3552 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3553 secure-auth settings.
3554 * src/modest-account-mgr-helpers.h:
3555 * src/modest-account-mgr-helpers.c:
3556 (modest_server_account_data_get_option_secure_auth),
3557 (modest_server_account_set_option_secure_auth),
3558 (modest_server_account_data_get_option_security),
3559 (modest_server_account_set_option_security): Added this API for getting and setting the security
3560 and secure-auth settings.
3562 * src/maemo/modest-account-settings-dialog.h:
3563 * src/maemo/modest-account-settings-dialog.c:
3564 (modest_account_settings_dialog_finalize), (check_data),
3565 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3566 about changing titles.
3567 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3568 (save_configuration): Save the security and secure-auth settings.
3570 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3571 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3573 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3575 * src/modest-defs.h:
3576 * src/modest-account-mgr.c:
3577 (modest_account_mgr_add_server_account):
3578 Added and used defines for the options key and value pair strings,
3579 that are used so far, though they do not seem to correspond to anything in our
3580 UI specs or ModestProtocol enum.
3582 * src/modest-account-mgr-helpers.h:
3583 * src/modest-account-mgr-helpers.c:
3584 (compare_option_strings_for_name),
3585 (modest_server_account_data_get_option_value),
3586 (modest_server_account_data_get_option_bool),
3587 (modest_account_mgr_get_server_account_option):
3588 Added helper functions for parsing the options GSList.
3590 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3592 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3593 display name is based on the supplied account name.
3594 * src/modest-account-mgr.c:
3595 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3596 with an inefficient, but good-enough, implementation.
3598 * src/maemo/easysetup/modest-easysetup-wizard.c:
3599 (create_page_account_details), (on_before_next), (create_account):
3600 Check for existing display names rather than (non-user-visible) account names, and just
3601 create and set a unique account name at the end.
3603 * src/maemo/modest-account-settings-dialog.c:
3604 (modest_account_settings_dialog_init),
3605 (modest_account_settings_dialog_set_account_name),
3606 (create_page_incoming): Show the display name, instead of the account name.
3607 (on_response): Do some (not all) extra checks, as in the UI spec.
3608 (save_configuration): Save the display name if it was changed.
3610 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3612 * po/en_GB.po: Added needed logical ID and translation.
3613 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3614 (init_view): Made the is-default column clicking work.
3616 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3619 * src/maemo/easysetup/Makefile.am:
3620 * src/maemo/easysetup/modest-easysetup-wizard.c:
3621 (modest_easysetup_wizard_dialog_init):
3622 * src/maemo/easysetup/provider-data-test.keyfile:
3623 * src/maemo/easysetup/provider-data.keyfile:
3624 Moved the provider data file to the new modest-providers-data package and used it from there.
3626 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3628 * src/modest-local-folder-info.c:
3629 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3630 N_() was already used on the static strings, but this just marks it for translation without
3631 using the translation.
3633 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/modest-account-settings-dialog.c:
3636 (create_page_incoming),
3637 (modest_account_settings_dialog_set_account_name):
3638 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3639 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3640 I will do this if nobody else gets there first.
3642 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3644 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3645 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3646 save the security stuff.
3648 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3650 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3651 Set the email address and user fullname, which I now see must be
3654 * src/maemo/modest-account-settings-dialog.h:
3655 * src/maemo/modest-account-settings-dialog.c:
3657 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3658 leave-on-server and authentication.
3659 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3662 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3665 * src/maemo/modest-account-settings-dialog.c:
3666 * src/maemo/modest-account-settings-dialog.h:
3667 Most (but not all) of the widgets are now present as specified by the UI spec.
3668 No changes are yet saved, and some details are not properly shown yet.
3670 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3672 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3674 * src/maemo/Makefile.am:
3675 * src/maemo/modest-account-settings-dialog.c:
3676 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3677 an existing account. Doesn't do much yet.
3679 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3680 Open the accounts settings dialog when Edit is clicked.
3682 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3684 * src/maemo/easysetup/Makefile.am:
3685 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3687 * src/maemo/easysetup/modest-easysetup-wizard.c:
3688 (modest_easysetup_wizard_dialog_init):
3689 Try to get the source directory from the build system,
3690 instead of hard-coding "./" into the source code, when opening our local
3691 copies of the configuration files.
3692 But this still fails when opening the wizard from the Accounts window,
3693 maybe because the working directory seems to change at runtime.
3694 So the wizard will fail the second time unless you copy the files into their
3695 proper locations - see the stdout warnings for the paths.
3697 (create_page_account_details),(on_before_next):
3698 Check for existing non-server accounts instead of server accounts,
3699 so the default account name is useful again, and to prevent trying to
3702 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3703 Show the wizard when New is clicked.
3705 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3706 (init_view): Show the column headers, and show the columns that are
3707 specified in the UI specs. However, something in Maemo's GTK+ prevents
3708 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3709 change the default account. This is despite unsetting the special properties.
3711 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3713 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3714 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3715 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3716 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3717 to make that clearer.
3718 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3720 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3722 * src/maemo/modest-account-view-window.c:
3723 (modest_account_view_window_init),
3724 (modest_account_view_window_new):
3725 Use the same buttons as specified in the
3726 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3727 the existing widgets, which never had a chance of working.
3728 Put the ModestAccountView treeview in a scrolled window.
3729 Do not repeat the initialization in both _init() and _new().
3731 * src/widgets/modest-account-view.c: (update_account_view):
3732 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3733 this widget and window shows no accounts.
3735 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3737 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3739 * src/maemo/easysetup/modest-easysetup-wizard.c:
3740 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3741 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3742 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3745 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3746 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3747 accounts exist yet, as in the UI spec.
3749 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3751 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3753 * src/maemo/Makefile.am:
3754 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3755 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3756 New window for editing connection-specific smtp details.
3757 Not fully implemented.
3759 * src/maemo/modest-connection-specific-smtp-window.c:
3760 (modest_connection_specific_smtp_window_finalize) :
3761 unref the tree model.
3762 (on_button_edit): Show the edit window.
3764 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3766 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3769 * src/maemo/Makefile.am:
3770 * src/maemo/modest-connection-specific-smtp-window.c:
3771 * src/maemo/modest-connection-specific-smtp-window.h:
3772 New window for showing the list of connections, for connection-specific
3773 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3774 * src/maemo/easysetup/modest-easysetup-wizard.c:
3775 (create_page_custom_outgoing): Show the new window when the button is clicked.
3777 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3779 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3780 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3781 * src/maemo/modest-msg-edit-window.c:
3782 (modest_msg_edit_window_insert_image):
3783 * src/modest-conf.c: (modest_conf_key_escape):
3784 * src/modest-mail-operation.c:
3785 (modest_mail_operation_send_new_mail):
3786 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3787 (modest_ui_actions_on_new_account):
3788 * src/widgets/modest-attachment-view.c: (update_filename_request):
3789 * src/widgets/modest-mail-header-view.c:
3790 Corrected warnings that were breaking the build, by commenting out unused variables,
3791 and a function, and by including a header.
3793 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3795 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3796 so we can #ifdef around platform-specific code when necessary.
3797 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3798 to allow this to build for the GNOME platform too.
3800 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3802 * src/maemo/easysetup/modest-easysetup-wizard.c:
3803 Added util_increment_name() and used it in create_page_account_details()
3804 to make sure that the default account name is always a new name.
3806 (modest_easysetup_wizard_dialog_init),
3807 (set_default_custom_servernames): Some minor memory management fixes.
3809 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3813 * src/modest-runtime.c: (init_i18n): Restored the translation
3814 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3815 are defined in config.h, and the translations are installed.
3817 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3818 is defined for translation.
3820 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3822 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3824 * src/maemo/easysetup/modest-easysetup-wizard.c:
3825 (modest_easysetup_wizard_dialog_init):
3826 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3827 Use realistic paths (though they should use $prefix generically) to the
3828 mcc_mapping and provider-data.keyfile files which might work when they
3829 are installed by the future version of the operator-wizard package,
3830 and then fallback to paths in our source code, with an explanatory
3833 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3837 * src/maemo/Makefile.am:
3838 * src/maemo/easysetup/: Added files from the previously-exernal
3839 osso-modest-easysetup.
3840 * src/maemo/modest-main-window-ui.h:
3841 * src/modest-ui-actions.c:
3842 * src/modest-ui-actions.h:
3843 Added modest_ui_actions_on_new_account() as a signal handler for the
3844 New Account menu item. It shows the easysetup wizard.
3845 * po/en_GB.po: Added additional needed logical IDs and translations.