1 2007-07-12 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
4 Avoided a harmless g_warning().
6 2007-07-12 Murray Cumming <murrayc@murrayc.com>
8 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
9 Pass the modest account name, not the TnyAccount display name to
10 modest_msg_view_window_new() so that the reply feature works,
11 fixing projects.maemo.org bug NB#62892.
13 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
14 (modest_msg_view_window_new_with_header_model):
15 * src/maemo/modest-msg-view-window.c:
16 (modest_msg_view_window_new_with_header_model),
17 (modest_msg_view_window_new):
18 * src/modest-ui-actions.c: (reply_forward):
19 * src/widgets/modest-msg-view-window.h:
20 * src/widgets/modest-window.c: (modest_window_set_active_account):
21 Rename an account parameter to modest_account_name to make this clearer.
23 2007-07-11 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-ui-actions.h:
26 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
27 modest_do_message_delete().
28 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
29 Call modest_do_message_delete(), hoping that this would cause messages
30 to be really deleted from search instead of just marked with strike through.
31 Does not seem to help.
33 2007-07-11 Armin Burgmeier <armin@openismus.com>
35 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
36 priv->reselect to FALSE prior to calling
37 modest_folder_view_select_first_inbox_or_local() to prevent endless
38 recursion and thus a crash on startup.
40 2007-07-11 Armin Burgmeier <armin@openismus.com>
42 * src/maemo/modest-account-settings-dialog.h: Include
43 <gtk/gtknotebook.h> to fix the build (at least for me).
45 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
46 Use "New FolderN" as default suggested name if "New folder" already
47 exists, with N being the first free number, though never exceed "New
48 folder99" in which case we just fall back to "New Folder" even though
49 it already exists. This fixes projects.maemo.org bug NB#58663.
51 2007-07-11 Murray Cumming <murrayc@murrayc.com>
53 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
54 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
55 projects.maemo.org bug NB#62778.
57 2007-07-11 Murray Cumming <murrayc@murrayc.com>
59 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
60 Ignore the wrong (for now) secure-smtp setting in the presets -
61 just default to requiring secure authentication for SMTP, because
64 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
66 * src/widgets/modest-folder-view.c: (filter_row)
67 Do not show drafts folder (see UI specs)
69 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
71 * src/modest-ui-actions.c:
72 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
73 place and also not necessary.
75 * src/widgets/modest-folder-view.c: (filter_row)
76 Guess folder type and hide Sent & Outbox if necessary.
77 Fixed project.maemo.org NB#57328
79 2007-07-11 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-ui-actions.h:
82 * src/modest-ui-actions.c:
83 (modest_ui_actions_on_delete_message):
84 Move some code into a new
85 modest_ui_actions_refresh_message_window_after_delete()
86 function so we can use it from elsewhere.
88 * src/dbus_api/modest-dbus-callbacks.c:
89 (on_idle_delete_message), (on_delete_message): Used an idle
90 handler, as we do for the other D-Bus method handlers.
91 Call modest_ui_actions_refresh_message_window_after_delete()
92 if the deleted message was open in a window. This fixed
93 projects.maemo.org bug NB#62862.
95 2007-07-11 Murray Cumming <murrayc@murrayc.com>
97 * src/modest-main.c: (main): Only show the UI at the start if
98 the showui command line option was given. For instance,
99 run-standalone src/modest showui
100 Otherwise, we wait for the top_application D-Bus method to
101 be sent by hildon-desktop when the application is selected
103 This allows us to run without a UI when osso-global-search
104 uses our D-Bus methods.
106 2007-07-11 Murray Cumming <murrayc@murrayc.com>
108 * src/dbus_api/modest-dbus-api.h: Added a define for a
109 top-application D-Bus method.
110 * src/dbus_api/modest-dbus-callbacks.c:
111 (on_top_application),
112 (modest_dbus_req_handler): Handle the top-application D-Bus
113 method, which might be an undocumented D-Bus signal sent by
114 hildon-desktop when it starts the application from the menu.
115 But I am not sure and I need to test it on the device, because
116 my scratchbox does not have the application in the menu now.
117 This method shows the main window, so that it can be invisible
118 when started, for instance, just for email searching from
121 * src/maemo/modest-main-window.c: (restore_settings),
122 (modest_main_window_new): Do not show the window immediately
123 upon creation. We show it later.
124 * src/modest-widget-memory.c: (save_settings_paned):
125 Try (unsuccessfully) to avoid saving the paned position when
126 it is not even visible.
127 (restore_settings_paned): Do not allow a silly paned position.
128 This seems necessary when not showing the window at first.
130 * tests/dbus_api/Makefile.am:
131 * tests/dbus_api/test_top_application.c: (main): Test for the
134 2007-07-10 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-ui-dimming-rules.c:
137 (modest_ui_dimming_rules_on_new_msg),
138 (modest_ui_dimming_rules_on_reply_msg),
139 (modest_ui_dimming_rules_on_delete_msg),
140 (modest_ui_dimming_rules_on_details),
141 (modest_ui_dimming_rules_on_view_window_move_to),
142 (modest_ui_dimming_rules_on_view_previous),
143 (modest_ui_dimming_rules_on_view_next),
144 (_invalid_folder_for_purge): Added checks before
145 casting the window. This looks like an actual
146 logic error in _invalid_folder_for_purge(), because it
147 tries to use a ModestMainWindow as a message window.
149 2007-07-10 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/modest-account-settings-dialog.c:
152 (show_error): Use the same implementation as in
153 modest-easysetup-wizard.c:
154 (on_entry_invalid_character): The logical ID contains a %s.
155 Guessed what it should be.
156 (on_entry_max), (check_data), (on_response): Adapt to
157 changed show_error().
158 (create_page_account_details): Really call
159 modest_validating_entry_set_func() on the correct widgets.
160 * src/maemo/easysetup/modest-easysetup-wizard.c:
161 (on_entry_invalid_character): Fix the logical ID here too.
162 (create_page_account_details),
163 (create_page_user_details):
165 modest_validating_entry_set_func() on the correct widgets.
167 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
168 Do not try to use the account if it is NULL.
170 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
172 * src/modest-ui-actions.c: (create_move_to_dialog),
173 (modest_ui_actions_on_main_window_move_to),
174 (modest_ui_actions_on_msg_view_window_move_to):
175 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
176 (filter_row), (modest_folder_view_show_non_move_folders):
177 * src/widgets/modest-folder-view.h:
179 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
180 the Sent folder yet as it does not report the correct folder type.
182 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
184 * src/maemo/modest-msg-edit-window.c: (init_window):
187 2007-07-10 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
190 Take a parent widget instead of a parent window, and
191 implement this with hildon_banner_show_information() instead.
192 Non-Maemo builds can just ifdef that there.
193 This fixed projects.maemo.org bug NB#62766.
195 (on_entry_invalid_character): Use show_error() again instead
196 of using hildon directly, and use the _CS() macro to use the correct
198 (create_account), (check_for_supported_auth_methods), (on_entry_max):
199 Pass a widget instead od a window to show_error().
201 2007-07-10 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
204 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
205 This allows us to show the server name in the error message, fixing
206 projects.maemo.org bug NB#62904.
207 Also, use the appropriate logical ID message for the account protocol.
209 2007-07-10 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-tny-account-store.c: (on_idle_wrong_password):
212 A compilation fix, though the build wasn't broken for me.
214 2007-07-09 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
217 Do not try to unref a NULL folder store, to avoid a runtime warning.
218 This seems to happen sometimes when changing accounts settings.
220 2007-07-09 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-tny-account-store.c:
223 (modest_tny_account_store_instance_init),
224 (modest_tny_account_store_finalize),
225 (on_account_settings_hide), (on_idle_wrong_password):
226 Use a GHashTable to ensure that we only show one account settings
227 dialog per modest account. This avoids us having a dialog open for
228 both the store and transport accounts, or due to repeated get_password()
229 calls that shouldn't happen anyway.
231 2007-07-09 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/modest-maemo-utils.c: (on_hide),
234 (modest_maemo_show_dialog_and_forget): Handle the response, because
235 the window is not even hidden by default.
237 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
238 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
239 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
240 which seems to prevent some modality problems.
242 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
243 Ignore user cancellation errors.
245 * src/modest-account-mgr-helpers.h:
246 * src/modest-account-mgr-helpers.c:
247 Added modest_server_account_get_password() and
248 modest_server_account_get_has_password() to avoid direct use of
251 * src/maemo/modest-account-settings-dialog.h:
252 * src/maemo/modest-account-settings-dialog.c:
253 (modest_account_settings_dialog_init): Store the notebook so we can
255 Added modest_account_settings_dialog_switch_to_user_info().
257 * src/modest-tny-account-store.c:
258 (get_password): When the password in the account settings is wrong (we think),
259 show the relevant page of the account settings dialog, in the mainloop.
260 However, we currently get many of these at once because cancel does not
262 (forget_password): Do not forget the password
263 from the account settings, because this causes side-effects when
264 tinymail seems to call it at strange time, maybe because of how we
265 are cancelling get_password().
266 (modest_tny_account_store_alert): Ignore user cancellations.
268 2007-07-09 Murray Cumming <murrayc@murrayc.com>
270 * src/maemo/modest-maemo-utils.h:
271 * src/maemo/modest-maemo-utils.c:
272 Added modest_maemo_show_information_note_and_forget() for use instead of
273 gtk_dialog_run() when the response is not needed, to avoid an extra
274 mainloop which could cause a hang.
276 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
277 Use the logical IDs for the error message, though they are not
278 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
279 because gtk_dialog_run() caused a hang here (the window did not close).
280 This fixes projects.maemo.org bug NB#62646.
282 2007-07-09 Murray Cumming <murrayc@murrayc.com>
284 * src/modest-account-mgr-helpers.h:
285 * src/modest-account-mgr-helpers.c:
286 Added modest_account_mgr_get_store_protocol().
288 * src/maemo/modest-account-view-window.c:
289 (on_delete_button_clicked): Show different warning text depending on
290 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
291 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
294 2007-07-09 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/modest-msg-edit-window.c:
297 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
298 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
300 2007-07-07 Armin Burgmeier <armin@openismus.com>
302 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
303 ckdg_ib_maximum_characters_reached from correct package.
305 * src/modest-ui-actions.c: Show an error message when a folder could
306 not be created. Tinymail does not give us specific error codes about
307 what has gone wrong, so we assume that a folder with that name
308 already exists, though there might be other reasons.
310 2007-07-06 Murray Cumming <murrayc@murrayc.com>
312 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
313 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
314 give a more exact error message that can be partly translated.
316 2007-07-05 Murray Cumming <murrayc@murrayc.com>
318 * src/maemo/modest-address-book.c:
319 (select_email_addrs_for_contact): Specify a default window size for the
320 select-email-address dialog, so that it is probably big enough for the
321 title. This should fix projects.maemo.org bug NB#62277.
323 2007-07-05 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/easysetup/modest-easysetup-wizard.c:
326 (create_page_complete_easysetup): Use
327 gtk_widget_set_size() request to ensure that the text wraps
330 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
332 * src/maemo/easysetup/modest-easysetup-wizard.c:
333 (on_entry_invalid_character), (create_page_account_details),
334 (create_page_user_details):
335 Use new API of ModestValidatingEntry. But for some reason the banner is
336 not shown. I will have to investigate that further.
338 * src/widgets/modest-validating-entry.c: (on_insert_text),
339 (modest_validating_entry_set_func):
340 * src/widgets/modest-validating-entry.h:
341 Added a new callback function to be able to react to prevented
342 characters whitespaces to e.g show a banner.
344 2007-07-05 Armin Burgmeier <armin@openismus.com>
346 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
347 notification of HildonNumberEditor instead of remembering the port
348 number. Thanks to Johannes for pointing this out.
350 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
352 * src/maemo/easysetup/modest-easysetup-wizard.c:
353 Check if there are any user changes before showing a confirmation
354 dialog (projects.maemo.org NB#60946)
356 2007-07-05 Armin Burgmeier <armin@openismus.com>
358 * src/maemo/modest-account-settings-dialog.c: Remember custom port
359 number at the beginning of the dialog and set the modified flag at the
360 end if the port number has changed. This is necessary because
361 HildonNumberEditor does not support notification when the value has
364 2007-07-05 Murray Cumming <murrayc@murrayc.com>
366 * src/modest-ui-actions.c:
367 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
368 a connection before asking anything else. Correct the check for the destination
369 folder so that it succeeds when online.
370 This fixed projects.maemo.org bug NB#61645.
372 2007-07-05 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
375 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
376 to fix projects.maemo.org bug NB#62439.
378 2007-07-05 Murray Cumming <murrayc@murrayc.com>
380 * src/modest-tny-account.c: (on_connection_status_changed):
381 Really do not use tny_device_force_offline() here. See the previous comment.
383 2007-07-04 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-tny-account.c: (on_connection_status_changed):
386 Do not use tny_device_force_offline() when tinymail says that something
387 went wrong with the connection. It seems to report this unnecessarily.
389 2007-07-04 Murray Cumming <murrayc@murrayc.com>
391 * src/maemo/modest-connection-specific-smtp-window.c:
392 (modest_connection_specific_smtp_window_init):
393 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
394 does not seem to have any effect in osso 1.1 (though it works in
395 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
397 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
399 * src/maemo/modest-connection-specific-smtp-window.c:
400 Fix UI specification problems with projects.meamo.org NB#60479
402 2007-07-04 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
405 clue when this has failed, because the error dialog is not always shown
406 (at least in earlier version).
408 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
409 GError message, because the generic error dialog is not helpful.
411 'This message is not currently available (can't let a new connection go online)'
412 when trying to open an IMAP message.
414 (_modest_ui_actions_open): Offer a connection when some messages would
415 have to be downloaded and we are offline.
417 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
419 * src/widgets/modest-folder-view.c:
420 Don't check for MERGE type anymore as we use the correct type
422 NOTE: For the last two changes you need to update your tinymail copy
423 because of API changes!
425 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
427 * src/modest-tny-local-folders-account.c:
428 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
429 (see projects.maemo.org NB#61580)
431 2007-07-04 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-tny-account.c: (on_connection_status_changed):
434 Commented out the call to modest_platform_connect_and_wait() because this
435 seems to always hang, and I would like to know if this is the only thing
436 that causes a hang when showing the connection dialog.
437 It is not very useful anyway.
439 2007-07-04 Murray Cumming <murrayc@murrayc.com>
441 * src/maemo/modest-msg-view-window.c:
442 (modest_msg_view_window_select_next_message):
444 * src/modest-platform.h:
445 * src/maemo/modest-platform.c:
446 Added modest_platform_connect_and_wait(), which calls
447 tny_maemo_conic_device_connect() always in the main thread, by calling it
448 in an idle handler and waiting for the idle handler to run. It should be
449 in the main thread because it uses GTK+ UI code. It just returns TRUE
450 if the device is already online.
452 There is some nasty code to ensure that subsequent calls to
453 modest_platform_connect_and_wait() just wait for the first one to finish,
454 by checking repeatedly in another idle handler. This is necessary,
455 because other threads (or even the main thread, via another idle handler)
456 can call modest_platform_connect_and_wait() while
457 modest_platform_connect_and_wait() is running.
459 (modest_platform_connect_and_wait_if_network_account),
460 (modest_platform_connect_and_wait_if_network_folderstore):
461 Convenience functions that calls modest_platform_connect_and_wait() if
462 the account or folder might want network access.
464 * src/modest-mail-operation.c:
465 (modest_mail_operation_update_account):
466 * src/modest-ui-actions.c: (download_uncached_messages),
467 (modest_ui_actions_on_rename_folder), (delete_folder),
468 (modest_ui_actions_on_main_window_move_to),
469 (modest_ui_actions_on_msg_view_window_move_to):
470 * src/widgets/modest-folder-view.c:
471 (drag_and_drop_from_folder_view):
472 Offer a connection if we are offline.
474 * src/modest-tny-account.c: (on_connection_status_changed):
475 Document this as only handling errors during network operations in progress,
476 and replace the idle code with a simple call to
477 modest_platform_connect_and_wait(), which does this instead.
479 2007-07-03 Murray Cumming <murrayc@murrayc.com>
481 * src/modest-tny-account.c:
482 (modest_tny_account_get_special_folder): (util_on_idle),
483 Handle the GError so we can see when tny_folder_store_get_folders()
484 fails, as it currently does while something else is connecting.
486 Added util_run_in_main_thread_and_wait()
487 which uses an idlen handler and mainloop to ensure that the function
488 is called in the main thread.
489 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
490 to make sure that we call attempt the connection in the mainloop only,
491 which might solve some hangs.
493 2007-07-03 Murray Cumming <murrayc@murrayc.com>
495 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
496 be found by their display name. This is never useful.
497 * src/modest-tny-account-store.c: (on_account_removed): Find the account
498 by its ID, instead of trying to use its ID as its display name.
500 * src/modest-tny-account-store.h:
501 * src/modest-tny-account.c:
502 (modest_tny_account_get_special_folder): Add a g_warning() when
503 tny_folder_store_get_folders() returns an empty list for the maildir.
505 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
506 Add a g_warning() when this returns NULL, because that it not allowed
509 2007-07-02 Armin Burgmeier <armin@openismus.com>
511 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
512 note when trying to cancel the wizard. This fixes projects.maemo.org
515 2007-07-02 Murray Cumming <murrayc@murrayc.com>
517 * src/modest-tny-account.h:
518 * src/modest-tny-account.c:
519 (modest_tny_account_new_from_server_account),
520 (modest_tny_account_new_from_server_account_name),
521 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
522 because this must now be set before setting the proto. This is usd in
523 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
524 warning in camel_session_get_service() caused by
525 tny_camel_transport_account_prepare().
527 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
530 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
532 * src/maemo/modest-connection-specific-smtp-edit-window.c:
534 (modest_connection_specific_smtp_edit_window_init):
536 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
539 2007-06-29 Murray Cumming <murrayc@murrayc.com>
541 * src/modest-tny-account.c:
542 (modest_tny_account_new_from_server_account):
543 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
544 now uses to request a connection when it needs one, and which it uses
545 to tell us that something is wrong with the connection, so we can force
546 the accounts offline to prevent further problems.
549 * src/modest-init.c: (init_default_settings):
550 * src/modest-mail-operation.c:
551 (modest_mail_operation_update_account):
552 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
553 This should not be necessary anymore. Do not set the conf key that
554 determined this (it was always TRUE and not set anywhere else).
556 * src/modest-ui-actions.h: Remove unused and unimplemented
557 modest_ui_actions_on_online_toggle_toggled().
559 2007-06-29 Murray Cumming <murrayc@murrayc.com
561 * src/maemo/modest-main-window.c: (connect_signals):
562 Don't connect to delete_event twice. Maybe this was harmless.
564 2007-06-29 Murray Cumming <murrayc@murrayc.com
566 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
567 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
568 Debug output to give some more clue when a folder move is not allowed.
570 2007-06-28 Murray Cumming <murrayc@murrayc.com
572 * src/modest-tny-account.c: (on_modest_file_system_info),
573 (modest_tny_account_get_mmc_account_name):
574 Always call the callback, without checking whether the name has changed.
575 * src/widgets/modest-folder-view.c: (strings_are_equal),
576 (on_model_foreach_set_name), (on_get_mmc_account_name),
577 (text_cell_data): Compare the name here, and use the name from
578 the account rather than from the
579 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
580 if the name was changed after the account was added to the model.
581 That's a tinymail bug but not one that I want to fix now.
583 This finally fixes projects.maemo.org bug NB#59301.
585 2007-06-27 Armin Burgmeier <armin@openismus.com>
587 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
590 2007-06-27 Murray Cumming <murrayc@murrayc.com
592 * src/modest-tny-account.h:
593 * src/modest-tny-account.c:
594 Added modest_tny_account_get_mmc_account_name(), to set the memory
595 card name asynchronously for the given account and then notify.
596 (modest_tny_account_new_for_local_folders): Use this new function instead
597 of using hildon_file_system_info_async_new() directly.
599 * src/widgets/modest-folder-view.c: (text_cell_data):
600 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
601 gtk_tree_model_row_changed() when it is available.
603 This should fix projects.maemo.org bug NB#59301.
605 2007-06-27 Murray Cumming <murrayc@murrayc.com
607 * src/modest-mail-operation.c: (update_account_thread),
608 (get_msgs_full_thread): Fix typo failures in the revert
611 2007-06-27 Murray Cumming <murrayc@murrayc.com
613 * src/maemo/modest-maemo-global-settings-dialog.c:
614 (idle_select_default_focus):
615 * src/modest-mail-operation.c: (idle_notify_progress),
616 (idle_notify_progress_once), (set_last_updated_idle),
617 (update_account_thread), (get_msgs_full_thread):
618 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
619 * src/widgets/modest-header-view.c:
620 (idle_notify_headers_count_changed_destroy),
621 (idle_notify_headers_count_changed):
622 Reverted the additions of gdk_threads_enter/leave(), in case this
623 helps with a startup hang on the device.
625 2007-06-26 Armin Burgmeier <armin@openismus.com>
627 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
628 for supported secure authentication methods from server by
629 gtk_dialog_run(), saving CPU time and a potential race condition.
631 2007-06-26 Armin Burgmeier <armin@openismus.com>
633 * src/maemo/modest-maemo-utils.h:
634 * src/maemo/modest-maemo-utils.c: Added a
635 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
636 only error code to tell the calling code when the user canceled the
639 * src/maemo/modest-account-settings-dialog.h:
640 * src/maemo/modest-account-settings-dialog.c:
641 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
642 message if the retrieval of secure authentication methods was canceled
643 by the user. Perform the check before saving anything to configuration
644 to not end up with half-committed configuration changes, do not show
645 a "Saving to configuration failed" note when authentication methods
646 could not be retrieved.
648 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
651 2007-06-26 Murray Cumming <murrayc@murrayc.com>
653 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
654 Only return the first level of folders under accounts, because the
655 osso-global-search UI spec doesn't want the rest.
656 This fixed projects.maemo.org bug NB#61811.
658 2007-06-26 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-tny-account-store.c:
661 * src/modest-tny-account-store.h:
662 Added modest_tny_account_is_memory_card_account().
663 * src/maemo/modest-main-window.c: (create_details_widget):
664 Show the same information items for the memory card as we show for the
665 local-folders, to fix projects.maemo.org bug NB#59307.
667 2007-06-26 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-tny-account-store.c: (get_password):
670 Added some checks for NULL to maybe prevent crashes, though I think
671 it was Philip's last commit that actually prevented the crash here
672 when creating a first new account.
673 But the new account is still not usable (no messages are shown)
674 until a restart of the application.
676 2007-06-26 Murray Cumming <murrayc@murrayc.com>
678 * src/maemo/modest-maemo-global-settings-dialog.c:
679 (idle_select_default_focus):
680 * src/modest-mail-operation.c: (idle_notify_progress),
681 (idle_notify_progress_once), (idle_notify_update_account_queue),
682 (set_last_updated_idle), (update_account_thread),
683 (notify_get_msgs_full), (get_msgs_full_destroyer),
684 (get_msgs_full_thread):
685 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
686 * src/widgets/modest-header-view.c:
687 (idle_notify_headers_count_changed_destroy),
688 (idle_notify_headers_count_changed):
689 Use gdk_threads_enter() and gdk_threads_enter_leave() in
690 all idle handlers, because some other thread could be blocking
691 the GDK lock, so that it can do GUI stuff.
693 2007-06-26 Murray Cumming <murrayc@murrayc.com>
695 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
696 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
697 (on_idle_send_receive), (on_idle_open_default_inbox):
698 * src/maemo/modest-msg-edit-window.c:
699 (modest_msg_edit_window_attach_file_noninteractive):
700 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
701 to prevent a hang. I don't quite understand why these are necessary,
702 beause we should already be in the main loop. I guess something outside
703 of the main loop is taking the lock.
705 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
706 we are really using URIs, and use files that are more likely to exist.
708 2007-06-26 Murray Cumming <murrayc@murrayc.com>
710 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
711 necessary because configure.ac now defines different variables.
713 2007-06-26 Murray Cumming <murrayc@murrayc.com>
715 * libmodest-dbus-client/libmodest-dbus-client.c:
716 * libmodest-dbus-client/libmodest-dbus-client.h:
717 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
718 libmodest_dbus_client_compose_mail() is what things actually use.
720 * src/dbus_api/modest-dbus-api.h:
721 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
722 * tests/dbus_api/Makefile.am:
723 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
726 2007-06-26 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-init.c: (modest_init_local_folders):
729 For memory-card (or other non local-folders) maildir accounts,
730 always create an Archive folder, so that there is somewhere to put
731 messages. This should be less confusing, because the user does not need
732 to guess that the need to create a folder.
734 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
736 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
737 Fixed icon size by using (50, 50) which is the same as defined by
740 2007-06-25 Armin Burgmeier <armin@openismus.com>
742 * src/widgets/modest-window-mgr.c:
744 * configure.ac: Correctly recognize hildon-notify presence and fixed
745 the build without it being installed.
747 2007-06-25 Murray Cumming <murrayc@murrayc.com>
749 * libmodest-dbus-client/libmodest-dbus-client.c:
750 (libmodest_dbus_client_search): Fix the build. Sorry.
751 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
752 (reply_forward_cb): Initialize variables to fix the build.
754 * src/modest-tny-account-store.c:
755 (modest_tny_account_store_get_tny_account_by): Fix the account URI
756 comparison (a silly typo) so that email search results can be opened
757 when there are more than one account.
759 2007-06-25 Murray Cumming <murrayc@murrayc.com>
761 * libmodest-dbus-client/libmodest-dbus-client.c:
762 (libmodest_dbus_client_search),
763 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
764 instead of 1 second, because the search gets folders and messages from
765 the server, which can take a long time. When it times out,
766 osso-global-search will report no results.
768 We need to specify whether we should search only cached information
769 (maybe with a user preference), and the osso-email-search-plugin
770 API should really be improved to allow that option, and to allow results
771 to be delivered asynchronously in batches.
773 2007-06-25 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
776 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
777 GTK_ICON_SIZE_DIALOG is probably the wrong size.
779 2007-06-25 Murray Cumming <murrayc@murrayc.com>
781 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
782 that is an empty string. D-Bus seems to give us these instead of NULL.
784 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
786 * src/dbus_api/modest-dbus-callbacks.c:
787 * src/maemo/easysetup/modest-easysetup-wizard.h:
788 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
789 * src/maemo/modest-connection-specific-smtp-edit-window.c:
790 (modest_connection_specific_smtp_edit_window_init):
791 * src/maemo/modest-maemo-global-settings-dialog.c:
793 * src/maemo/modest-maemo-utils.c:
794 (modest_maemo_utils_setup_images_filechooser):
795 * src/maemo/modest-main-window.c: (create_details_widget):
796 * src/maemo/modest-msg-edit-window.c:
797 (modest_msg_edit_window_attach_file_noninteractive),
798 (modest_msg_edit_window_color_button_change),
799 (modest_msg_edit_window_set_zoom):
800 * src/modest-mail-operation.c: (update_account_thread):
801 * src/modest-tny-account-store.c:
802 * src/modest-tny-account.c:
803 * src/widgets/modest-global-settings-dialog.c:
804 * src/widgets/modest-window.h:
808 2007-06-25 Murray Cumming <murrayc@murrayc.com>
810 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
811 * src/modest-search.c: (modest_search_folder),
812 (modest_search_all_accounts): Actually search only in the specified folder,
813 doing a simple match on the folder ID.
814 * src/modest-search.h: Added a folder field to the ModestSearch struct,
815 and added some documentation.
817 2007-06-22 Armin Burgmeier <armin@openismus.com>
819 * src/maemo/modest-maemo-utils.h:
820 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
821 modest_maemo_utils_get_supported_secure_authentication_methods.
823 * src/maemo/easysetup/modest-easysetup-wizard.c:
824 * src/maemo/modest-account-settings-dialog.c: Show correct error if
825 one occured, not just "Server does not support secure authentication".
827 2007-06-22 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.c: (get_password):
830 Restored the call to tny_account_set_user() because Philip seems to have
831 stopped this from crashing (by not using the freed string). It still does
832 not work, but now we can test it.
834 2007-06-22 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/modest-msg-edit-window.c: (init_window):
837 Comment out use of an uninitialzed GtkScrolledWindow variable,
838 to fix the build and stop a crash. Yet again.
840 2007-06-22 Murray Cumming <murrayc@murrayc.com>
842 * src/modest-tny-account-store.c: (get_password):
843 Remove the call to tny_account_set_user() because this actually crashes.
844 As mentioned in the last commit, it is known to not work anyway.
846 2007-06-22 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-tny-account-store.c: (get_password):
849 Use tny_account_set_username() to tell tinymail that the username might
850 have changed too. But tinymail ignores this: see projects.maemo.org
852 * src/modest-ui-actions.c:
853 (modest_ui_actions_on_password_requested): Remove the useless attempt to
854 reset the connection when changing the username, and improve the comments.
855 Save the changed username to gconf at least, so it is used when Modest is
858 2007-06-21 Murray Cumming <murrayc@murrayc.com>
860 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
861 Do not use a query, so that we get all folders, including for POP and
862 local-folders. They work as search criteria too.
863 This fixes projects.maemo.org bug NB#57740.
865 2007-06-21 Murray Cumming <murrayc@murrayc.com>
867 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
868 Comment out the use of hildon_notification_set_sound() because it is
869 not declared, to fix the build. Warnings are serious, people.
871 2007-06-21 Armin Burgmeier <armin@openismus.com>
873 * src/maemo/modest-maemo-utils.h:
874 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
875 modest_maemo_utils_get_supported_secure_authentication_methods()
876 to query authentication methods for a specific user. This should fix
877 projects.maemo.org bug NB#61369.
879 * src/maemo/easysetup/modest-easysetup-wizard.c:
880 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
883 2007-06-21 Murray Cumming <murrayc@murrayc.com>
885 * libmodest-dbus-client/libmodest-dbus-client.h:
886 * libmodest-dbus-client/libmodest-dbus-client.c:
887 (modest_dbus_message_iter_get_search_hit),
888 (libmodest_dbus_client_search):
889 Reorganised and commented this.
890 Removed modest_search_hit_free() from the public API because it
893 Added libmodest_dbus_client_get_folders() and
894 modest_folder_result_list_free().
896 * src/dbus_api/modest-dbus-api.h:
897 * src/dbus_api/modest-dbus-callbacks.c:
898 (modest_dbus_req_filter): Commented. Moved most code to
899 on_dbus_method_search() and added on_dbus_method_get_folders().
901 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
902 of the extra D-Bus handler.
904 * tests/dbus_api/Makefile.am:
905 * tests/dbus_api/test_get_folders.c: New test for
906 libmodest_dbus_client_get_folders(). This seems to return an empty list
907 at the moment. That could be the same error that causes the message list
908 to be empty sometimes.
909 This should help with projects.maemo.org bug NB#57740.
911 2007-06-21 Armin Burgmeier <armin@openismus.com>
913 * src/modest-mail-operation.c: Do not call
914 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
915 notify the operation's end after having set the status to CANCELED for
916 the operation queue to listen on. This fixes a deadlock when there
917 were mail operations in the queue during its finalization.
919 * src/modest-singletons.c: Reordered uninitialization of the account
920 manager to happen after the mail operation queue was uninitialized
921 because the mail operation's in the queue might still try to access
922 the account manager (see modest_mail_operation_notify_end()). This
923 fixes a potential crash when terminating the application.
925 2007-06-21 Murray Cumming <murrayc@murrayc.com>
927 * src/modest-search.c:
928 (search_mime_part_and_child_parts): Moved some code here so we
929 can search recursively in child folders.
930 (modest_search_folder): Search in the message as a mime part, instead
931 of just its child mime parts.
932 (read_chunk), (search_mime_part_ogs):
933 Check how many bytes were read, to prevent an endless loop.
934 Searching in message bodies now works. This finishes the fix for
935 projects.maemo.org bug NB#61007.
937 2007-06-20 Murray Cumming <murrayc@murrayc.com>
939 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
940 Add a g_warning when the item is not a folder.
942 * src/modest-ui-dimming-rules.c:
943 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
944 when selected item is not a folder (for instance, an account), because
945 the UI spec only talks about folders.
946 I am not sure what the UI spec wants, so this might not totally fix
947 projects.maemo.org bug NB#60794.
949 2007-06-20 Murray Cumming <murrayc@murrayc.com>
951 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
952 (load_from_file): Sort the list. The unsorted list would be more noticeable
953 in non-English locales.
955 * src/maemo/modest-msg-edit-window.c:
956 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
957 warning and fix the build.
959 * src/maemo/modest-progress-bar-widget.c:
960 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
961 avoid a g_warning, and probably to avoid a crash.
963 2007-06-20 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-search.c: (modest_search_folder): Check for a GError
966 when calling tny_folder_get_headers(), to show that this is not the cause
969 2007-06-20 Murray Cumming <murrayc@murrayc.com>
971 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
972 Actually set the body query instead of the subject query.
974 * src/modest-search.c: (search_mime_part_ogs),
975 (search_mime_part_strcmp): Remove extra space from the text/* regex,
976 which would probably cause it to fail if we got this far.
978 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
979 to simplify the code.
980 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
981 be causing search-in-body to fail.
983 2007-06-20 Murray Cumming <murrayc@murrayc.com>
985 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
987 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
988 Better debug message when the folder cannot be found.
989 This should help with fixing projects.maemo.org bug #61287.
990 * src/modest-search.c: (add_hit): Do not leak the furl string.
992 2007-06-20 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-ui-actions.c:
995 (modest_ui_actions_on_folder_selection_changed):
996 Do not special-case TNY_MERGE_FOLDER here, because
997 modest_tny_folder_get_account() already does that. This fixes
998 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
999 shown when the Outbox was selected).
1001 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1003 * libmodest-dbus-client/libmodest-dbus-client.c:
1004 (_dbus_iter_get_string_or_null): Initialize the string variable in
1005 case this helps with Dirk's crash.
1007 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1009 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1010 though it is not implemented yet (this function is maybe not even used),
1011 to avoid breaking ABI in future.
1012 * libmodest-dbus-client/libmodest-dbus-client.c:
1013 (get_attachments_string): Moved some code into this generic function.
1014 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1015 sends email. It is maybe not used.
1016 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1017 (on_send_mail): Use attachments.
1019 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1020 * src/maemo/modest-msg-edit-window.c:
1021 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1022 a filename before using it, to fix projects.maemo.org bug NB#58233.
1024 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1027 Initialize the continue_download variable to fix the build, and probably
1028 to fix randome behaviour.
1030 2007-06-18 Armin Burgmeier <armin@openismus.com>
1032 * src/modest-tny-send-queue.h:
1033 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1034 the queue so we can later show it in the UI. Replaced
1035 modest_tny_send_queue_msg_is_being_sent() by
1036 modest_tny_send_queue_get_msg_status().
1038 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1040 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1041 gpointer. This probably was not harmful, but just to be sure.
1043 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1045 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1046 Fix the build, but leave the function broken on Bora, because
1047 hildon_uri_action_get_service() does not exist.
1048 osso_uri_action_get_service() does not exist either, it seems.
1050 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1052 * src/modest-tny-account.c:
1053 (modest_tny_account_new_from_server_account):
1054 Uncommented the url debug output again, because it is useful for
1055 debugging, as I said in the comment.
1057 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1059 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1061 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1062 for Mameo Bora, to fix the build.
1064 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1067 Fixed build with hildon < 0.99
1069 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1070 Check if the selected account is busy instead of checking all accounts
1072 * src/modest-account-mgr-priv.h:
1073 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1074 (modest_account_mgr_init), (compare_account_name),
1075 (modest_account_mgr_set_account_busy),
1076 (modest_account_mgr_account_is_busy):
1077 * src/modest-account-mgr.h:
1078 Added busy information to the account manager. It possible to
1079 set an account to busy or not busy now.
1081 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1082 (modest_mail_operation_update_account),
1083 (modest_mail_operation_notify_end):
1084 Set the account to busy/not busy depending on the operation state.
1086 * src/widgets/modest-account-view.c:
1087 (modest_account_view_finalize), (get_last_updated_string),
1088 (update_account_view), (on_account_busy_changed), (init_view):
1089 Show string "Refreshing..." if the account is currently busy.
1091 All this fixes projects.maemo.org bug NB#59711
1093 2007-06-14 Armin Burgmeier <armin@openismus.com>
1095 * src/widgets/modest-attachments-view.h:
1096 * src/widgets/modest-attachments-view.c: Added
1097 modest_attachments_view_has_attachments() and fixed coordinate
1098 transformation in get_att_view_at_coords(). This fixes attachment
1101 * src/widgets/modest-msg-view.c: Make use of
1102 modest_attachments_view_has_attachments() to decide whether to show
1103 attachments in the header.
1105 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1108 (on_change), (on_combo_security_changed),
1109 (modest_connection_specific_smtp_edit_window_init),
1110 (modest_connection_specific_smtp_edit_window_set_connection),
1111 (modest_connection_specific_smtp_edit_window_is_dirty):
1112 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1113 * src/maemo/modest-connection-specific-smtp-window.c:
1116 Show an comfirmation dialog for the smpt-edit-window if there are
1117 unsaved changes and the user hits cancel.
1118 (projects.maemo.org bug NB#60479)
1120 2007-06-14 Armin Burgmeier <armin@openismus.com>
1122 * src/maemo/easysetup/modest-easysetup-wizard.c:
1123 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1124 address" info in banner instead of node, and select all the text as
1125 per UI spec. This fixes projects.maemo.org bug NB#60550.
1127 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1129 reviewed by: <delete if not using a buddy>
1131 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1132 * src/modest-ui-actions.c: (folder_refreshed_cb):
1134 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1136 * src/widgets/modest-folder-view.c: (filter_row):
1137 Explictly filter out the per-account outbox accounts. I don't know why
1138 these only sometimes show up, but now they should never show up in the UI.
1139 This should fix projects.maemo.org bug NB#60160.
1141 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1144 when the toolbar does not exist yet.
1145 * src/modest-widget-memory.c: (save_settings_header_view):
1146 Added g_warnings() to help us to discover when we are trying to set
1147 an empty columns list in gconf.
1149 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-init.h:
1152 * src/modest-init.c:
1153 Added modest_init_get_default_header_view_column_ids().
1155 * src/modest-widget-memory.c: (restore_settings_header_view):
1156 Use the new function to get defaults, if the gconf key is empty,
1157 instead of not creating any columns. This seems to fix the
1158 empty right-hand pane problems.
1160 * src/widgets/modest-header-view.h: Improved documentation.
1162 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1164 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1165 Revert the use of the display name as the account name, because this
1166 is generally wrong and would break the code that follows.
1168 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1170 * src/maemo/easysetup/modest-easysetup-wizard.c:
1171 (check_for_supported_auth_methods), (on_before_next),
1174 More correct fix for projects.maemo.org bug NB# 58991
1175 Do not longer accept AUTH_PASSWORD as secure method and choose
1176 correct method when creating the account.
1178 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1180 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1181 Fixed projects.maemo.org bug NB# 58991
1183 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1185 * src/modest-init.c: (modest_init_init_core),
1186 (modest_init_local_folders): Fixed compilation errors.
1188 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1190 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1191 Remove unnecessary lib/include, though it is good in principle when needed.
1193 * src/modest-init.c: (modest_init_one_local_folder),
1194 (modest_init_local_folders):
1195 * src/modest-init.h: Initialize the .modest library for memory cards,
1196 instead of just doing nothing for them. This should allow us to create
1197 folders there, fixing projects.maemo.org bug NB#59297.
1199 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1201 * libmodest-dbus-client/libmodest-dbus-client.c:
1202 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1203 (libmodest_dbus_client_compose_mail),
1204 (libmodest_dbus_client_open_message),
1205 (libmodest_dbus_client_send_and_receive),
1206 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1208 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1209 (on_idle_open_message), (modest_dbus_req_handler),
1210 (search_result_to_message), (modest_dbus_req_filter):
1211 * src/modest-search.c: (add_hit), (modest_search_folder),
1212 (modest_search_all_accounts): Improved debug messages.
1214 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1216 * src/modest-tny-account-store.c:
1217 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1220 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1223 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-tny-account-store.c: (get_server_accounts):
1226 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1227 even when there are no accounts, so that the Outbox folder is always
1228 visible. This fixes projects.maemo.org bug NB#60158.
1230 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1232 * src/maemo/modest-main-window.c: (create_details_widget):
1233 Use the mcen_va_never logical ID.
1235 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1237 * src/dbus_api/modest-dbus-api.h:
1238 * src/dbus_api/modest-dbus-callbacks.c:
1239 (on_idle_open_default_inbox), (on_open_default_inbox),
1240 (modest_dbus_req_handler):
1241 Added a new OpenDefaultInbox method.
1243 * libmodest-dbus-client/libmodest-dbus-client.h:
1244 * libmodest-dbus-client/libmodest-dbus-client.c:
1245 Added libmodest_dbus_client_open_default_inbox() to call the new
1246 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1247 though it should maybe be used by a new osso-email-interface function.
1249 * tests/dbus_api/Makefile.am:
1250 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1253 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1256 NULL, so that the signals get all the keys. This should not actually
1257 change any behaviour because we currently update everything when anything
1260 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1262 * src/widgets/modest-folder-view.c: (text_cell_data),
1263 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1264 (find_inbox_iter): If tinymail tells us that the folder is
1265 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1266 This causes the inbox to be selected at startup, fixing part of
1267 projects.maemo.org bug NB#56305.
1269 * src/modest-ui-dimming-rules.c:
1270 (modest_ui_dimming_rules_on_tools_smtp_servers):
1271 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1272 the SMTP servers menu item.
1273 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1274 that the SMTP Servers menu item is dimmed when there are no accounts,
1275 as a future version of the UI spec will require. This fixes
1276 projects.maemo.org bug NB#56305.
1278 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1280 * src/maemo/modest-maemo-utils.c:
1281 (modest_maemo_utils_get_supported_secure_authentication_methods):
1282 Added label to dialog instead of unreadable title
1284 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1285 (modest_main_window_new):
1286 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1289 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1290 * src/modest-account-mgr.h:
1291 Added method to avoid code duplication
1293 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1294 (modest_ui_actions_on_send_receive):
1295 Use modest_account_mgr_has_accounts
1297 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/easysetup/modest-presets.c:
1300 (modest_presets_get_info_server_security): Do not report secure auth
1302 * src/modest-protocol-info.c: Use the defines for the gconf key names
1303 for secure authentication. This was not working because we were writing
1304 Password and reading password, and the check was case sensitive.
1305 With this, gmail now works for receiving and sending when created via
1308 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/easysetup/modest-presets.c:
1311 (modest_presets_get_info_server_security): Correct the key name for
1312 SecureSmtp, because it seems to be case-sensitive.
1313 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1314 Do not try to get the 0th notebook page if there are 0 pages, to
1315 avoid a g_warning().
1317 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1319 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1320 Prevent use of the new notification feature for now, because it currently
1321 shows one dialog for each new email, which is annoying.
1323 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1326 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1327 when no country was selected, so that we show the global ones.
1328 * src/maemo/easysetup/modest-presets.c:
1329 (modest_presets_get_providers): Return only the global providers, not
1330 all providers when mmc=0 was requested.
1332 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1335 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1336 provider ID in the combo.
1338 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1339 Do not show the page numbers, because it would be confusing when we add
1340 the 2 extra pages for the custom setup, when the user chooses the "Other"
1341 provider. This fixes projects.maemo.org bug NB#59028
1343 * src/modest-init.c: (modest_init_init_core),
1344 (modest_init_local_folders):
1345 * src/modest-init.h:
1346 * src/modest-tny-account.c:
1347 (modest_tny_account_new_for_local_folders): Do not create default folders
1348 for the memory card. This should fix projects.maemo.org bug NB#59328.
1350 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1353 Free the changed_conf_keys string items. They are already freed in the
1354 idle handler if that runs first.
1356 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-ui-actions.c:
1359 (modest_ui_actions_on_password_requested): Check that the server name
1360 is not NULL, because I just saw a password dialog with (null) as the
1363 * src/modest-tny-folder.[h|c]: Added
1364 modest_tny_folder_is_memory_card_folder().
1365 * src/modest-ui-dimming-rules.c:
1366 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1367 menu item for memory cards, as per the UI spec (section 7.4). This should
1368 fix projects.maemo.org bug NB#59297.
1370 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1372 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1373 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1374 is another problem with the code, see Murray's comment at line 772)
1376 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1379 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1380 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1381 (load_from_file), (easysetup_country_combo_box_init),
1382 (easysetup_country_combo_box_get_active_country_ids),
1383 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1384 instead of just one ID, to avoid duplicate country names in the UI.
1386 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1387 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1388 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1389 a single ID, avoiding duplicate providers.
1390 * src/maemo/easysetup/modest-easysetup-wizard.c:
1391 (on_combo_account_country): Adapt to use a list.
1393 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1396 keys changed in the last X seconds.
1398 * src/modest-account-mgr.h:
1399 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1400 (on_key_change), (modest_account_mgr_class_init),
1401 (modest_account_mgr_init), (modest_account_mgr_finalize):
1402 As the keys are changed, save them in a GSList* and signal that GSList*
1403 further every X seconds, to batch changes, to allow us to do just one
1404 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1405 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1407 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1408 changed signal signature.
1410 * src/modest-conf.c: (modest_conf_set_list),
1411 (modest_conf_on_change): Reenable notification.
1413 (modest_conf_maemo_fake_on_change): Comment out the hack that
1414 notified immediately instead of asynchronously.
1416 * src/widgets/modest-account-view.h:
1417 * src/widgets/modest-account-view.c:
1418 (update_account_view): Select the previously-selected account ID,
1419 if possible. This fixes projects.maemo.org bug NB#56933.
1421 (on_account_changed), (on_account_removed),
1422 (modest_account_view_select_account):
1424 Remove the block/unblock functions
1425 because they were not useful.
1427 * src/maemo/modest-account-view-window.c:
1428 (on_delete_button_clicked), (on_edit_button_clicked),
1429 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1431 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1434 Improve the error dialog to show Incorrect Account Settings, which seems
1435 clearer, and say that the internal error message (to be removed from the
1436 dialog later) is often misleading.
1437 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1439 * src/modest-tny-account.c:
1440 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1441 URL because this is so useful for debugging on the device.
1443 * src/widgets/modest-serversecurity-combo-box.c:
1444 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1446 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-mail-operation.c:
1449 (modest_mail_operation_send_new_mail):
1450 Added a comment about a nasty but apparently harmless message. Details
1451 added to the wiki g_warnings() page.
1453 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1455 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1456 (modest_tny_send_queue_class_init):
1457 Do not use the priv struct because it is empty, to avoid g_warnings
1458 about a non-existant priv struct.
1460 * src/modest-tny-account-store.c:
1461 (modest_tny_account_store_get_server_account),
1462 (modest_tny_account_store_get_transport_account_for_open_connection
1463 ): Do not try to get transport server accounts for local folders,
1464 because they don't have any. This avoids a g_warning().
1466 * src/maemo/modest-main-window.c:
1467 (modest_main_window_notify_send_receive_initied),
1468 (on_configuration_key_changed):
1469 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1470 * src/modest-defs.h:
1471 * src/modest-mail-operation.c:
1472 (modest_mail_operation_update_account):
1473 * src/modest-tny-account-store.h:
1474 * src/modest-tny-account.c:
1475 (modest_tny_account_get_special_folder),
1476 (modest_tny_account_new_for_local_folders),
1477 (modest_tny_account_new_for_per_account_local_outbox_folder):
1478 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1479 * src/modest-tny-local-folders-account.c:
1480 (add_account_folders_to_merged_folder):
1481 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1482 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1483 (modest_ui_actions_on_send):
1484 * src/widgets/modest-folder-view.c: (update_model):
1485 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1486 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1487 modest_tny_account_store_get_tny_account_by_account() to
1488 modest_tny_account_store_get_server_account() to make the code clearer.
1490 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1492 * src/dbus_api/modest-dbus-api.h:
1493 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1494 * src/maemo/modest-msg-edit-window.c:
1495 (modest_msg_edit_window_attach_file_noninteractive):
1496 added g_warning in case the file to be attached does not exist
1497 * tests/dbus_api/test_compose_mail.c: (main):
1498 removed obsolete comment, added generic files as test case
1500 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-tny-account-store.c: (get_server_accounts):
1503 Create the local folders account only once, not once for each outbox, and
1504 not only when there are some outboxes.
1506 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1508 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1509 code that is causing a crash at startup. Sergio says that he is fixing this.
1511 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1513 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1514 * src/maemo/modest-account-settings-dialog.c:
1515 (create_page_outgoing),
1516 (modest_account_settings_dialog_set_account_name),
1517 (save_configuration):
1518 - Fixed handling of the "Use secure authentication" toggle to comply with
1519 the ui specification. See also projects.maemo.org bug NB#58400
1521 - Restore the Secure connection setting combo correctly when loading
1524 * src/maemo/modest-maemo-utils.c:
1525 (on_camel_account_get_supported_secure_authentication),
1526 (modest_maemo_utils_get_supported_secure_authentication_methods):
1527 Fixed a crasher if operation is canceled
1529 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1530 (modest_protocol_info_auth_is_secure):
1531 * src/modest-protocol-info.h:
1533 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1534 the sense of the "Use secure authentication" toggle.
1536 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-tny-account-store.h:
1539 * src/modest-tny-account-store.c:
1540 Added modest_tny_account_store_get_local_folders_account().
1542 * src/modest-tny-folder.h:
1543 * src/modest-tny-folder.c:
1544 (modest_tny_folder_get_account):
1545 Added this replacement for tny_folder_get_account() which returns
1546 the local-folders account for TnyMergeFolders, to avoid the
1547 warning about the unimplemented get_account_func() vfunc().
1549 (modest_tny_folder_get_rules),
1550 * src/modest-ui-actions.c:
1551 (modest_ui_actions_on_folder_selection_changed):
1552 * src/modest-mail-operation.c:
1553 (modest_mail_operation_remove_folder),
1554 (modest_mail_operation_xfer_folder),
1555 (modest_mail_operation_rename_folder),
1556 (modest_mail_operation_get_msg),
1557 (modest_mail_operation_get_msgs_full),
1558 (modest_mail_operation_remove_msg),
1559 (modest_mail_operation_xfer_msgs),
1560 (modest_mail_operation_refresh_folder):
1561 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1563 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1566 (modest_server_account_set_security):
1567 * src/modest-defs.h: Add comments explaining that our
1568 UI spec means TLS when it says Normal, so these do not look like errors.
1570 * src/modest-tny-account.c:
1571 (modest_tny_account_new_from_server_account): Use the new tinymail
1572 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1573 for TLS. This should fix projects.maemo.org bug NB#58460.
1575 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/easysetup/modest-easysetup-wizard.c:
1578 (create_account): Correct the position of the gconf sanity check warning.
1579 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1580 of using the g_idle_add() hack, because this does not seem to be necessary
1581 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1582 caused by something other than maemo's gconf.
1583 This fixes projects.maemo.org bug #59022.
1585 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-account-mgr-helpers.c:
1588 (modest_account_mgr_get_default_account): Do not check that the account
1589 exists if there is no default account (NULL), to fix a runtime warning.
1591 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1593 * src/widgets/modest-folder-view.c: (update_model):
1594 Do not unref the treemodel before we have finished with it.
1595 This prevents a valgrind warning and an occasional crash at startup.
1597 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1599 * libmodest-dbus-client/libmodest-dbus-client.h:
1600 added libmodest_dbus_client_compose_mail()
1601 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1603 added functions needed for SendAsMail() functionality
1604 * src/maemo/modest-msg-edit-window.c:
1605 (modest_msg_edit_window_attach_file_noninteractive):
1606 non interactively attaching files to message edit window
1607 * src/widgets/modest-msg-edit-window.h:
1608 * tests/dbus_api/Makefile.am:
1609 added test_compose_mail.c
1610 * tests/dbus_api/test_compose_mail.c: (main):
1612 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1614 * src/modest-account-view.c:
1615 Fixed bug projects.maemo.org bug NB#59307
1617 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1619 * src/maemo/easysetup/modest-easysetup-wizard.c:
1620 (get_serverport_incoming), (on_before_next), (create_account):
1621 * src/maemo/modest-account-settings-dialog.c:
1622 (modest_account_settings_dialog_set_account_name):
1623 * src/maemo/modest-maemo-utils.c:
1624 (on_camel_account_get_supported_secure_authentication_status),
1625 (on_camel_account_get_supported_secure_authentication),
1626 (on_secure_auth_cancel),
1627 (modest_maemo_utils_get_supported_secure_authentication_methods):
1629 Implemented security authentication for settings and easysetup.
1631 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1633 * src/maemo/modest-main-window.c: (create_details_widget):
1634 Show the total size for memory card accounts too, instead of showing
1635 the name again. Fixes bug projects.maemo.org bug NB#59307.
1637 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1640 * src/modest-tny-simple-folder-store.c:
1641 * src/modest-tny-simple-folder-store.h: Removed.
1643 * src/modest-tny-local-folders-account.h
1644 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1645 for the local-folders maildir, with an extra TnyMergedFolder containing
1646 the folders of the per-account outbox store accounts.
1647 * src/modest-tny-account-store.c: (get_server_accounts):
1648 Add the outboxes to the special local folders account after creating it.
1650 * src/modest-tny-account.c:
1651 (modest_tny_account_new_for_local_folders): Create the derived
1652 account when creating the main local-folders account.
1654 * src/maemo/modest-main-window.c: (create_details_widget),
1655 (modest_main_window_set_contents_style):
1656 Adapted to the use of the derived account instead of the folder store.
1658 * src/modest-ui-actions.c:
1659 (modest_ui_actions_on_folder_selection_changed):
1660 * src/modest-ui-dimming-rules.c:
1661 (modest_ui_dimming_rules_on_new_folder):
1662 * src/widgets/modest-folder-view.c: (text_cell_data),
1663 (icon_cell_data), (filter_row), (update_model),
1664 (get_cmp_rows_type_pos):
1667 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1668 Do not get the priv struct, because no priv struct has been set,
1669 to avoid a runtime warning.
1671 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1672 #ifelse with #else, to fix a warning, to fix the build.
1675 2007-06-05 Christian Kellner <ckellner@openismus.com>
1677 * libmodest-dbus-client/libmodest-dbus-client.c:
1678 Fix small typo in doc (why do you always see them
1679 AFTER committing stuff?)
1682 2007-06-05 Christian Kellner <ckellner@openismus.com>
1684 * libmodest-dbus-client/libmodest-dbus-client.c:
1685 (libmodest_dbus_client_search):
1686 Initialize hit list with NULL. Also set folder list
1687 to "" if NULL was supplied.
1690 2007-06-03 Christian Kellner <ckellner@openismus.com>
1692 * libmodest-dbus-client/libmodest-dbus-client.c:
1693 (modest_search_hit_list_free):
1694 Make it save to call it with NULL.
1696 * src/dbus_api/modest-dbus-callbacks.c:
1697 * src/modest-search.c:
1698 Return full ModestSearchHits as the search result list not TnyHeader
1699 since can't be around withouth the correspoding TnyFolder.
1701 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1703 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1704 Added currently commented code to check for secure auth
1706 * src/maemo/modest-account-settings-dialog.c: (on_response),
1707 (save_configuration), (show_ok):
1708 Fixed projects.maemo.org bugs NB #59248 and #59251
1710 * src/maemo/modest-maemo-utils.c:
1711 (on_camel_account_get_supported_secure_authentication_status),
1712 (on_camel_account_get_supported_secure_authentication),
1713 (modest_maemo_utils_get_supported_secure_authentication_methods):
1714 * src/maemo/modest-maemo-utils.h:
1715 Moved get_supported_secure_authentication() method here to be able
1716 to use it from easysetup wizard.
1718 * src/modest-pair.c: (on_pair_compare_as_string):
1719 Should compare string with first part of pair and not
1720 strcmp pairs which will crash.
1722 * src/modest-protocol-info.c:
1723 (modest_protocol_info_protocol_is_store):
1724 * src/modest-protocol-info.h:
1725 Added modest_protocol_info_get_auth_protocol_name()
1727 2007-06-03 Armin Burgmeier <armin@openismus.com>
1729 * src/modest-mail-operation.c:
1730 (modest_mail_operation_get_msgs_full): Set priv->account also when
1731 only retrieving a single message. This avoids a crash when canceling
1734 (modest_mail_operation_notify_end): Do not explicitely remove the
1735 operation from the queue but only emit the progress_changed signal.
1736 The queue itself listens to that signal to remove the operation when
1737 it is finished. This reduces coupling and removes a potential deadlock
1738 when modest_mail_operation_notify_end() is called from the queue
1739 itself. If that is a problem performance-wise, I would suggest to
1740 implement a status-changed signal or something.
1742 * src/modest-mail-operation-queue.c: Make sure to never call a
1743 function from another file while the queue is locked. This (hopefully)
1744 fixes another deadlock when exiting the application while retrieving
1747 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1749 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1750 Fixed build if libogs is not available
1752 2007-06-03 Christian Kellner <ckellner@openismus.com>
1754 * libmodest-dbus-client/libmodest-dbus-client.h:
1755 * libmodest-dbus-client/libmodest-dbus-client.c:
1756 (libmodest_dbus_client_delete_message):
1757 Implement deletion of messages (Client side).
1759 (modest_search_hit_free),
1760 (modest_search_hit_list_free):
1761 Utility functions to free the result hits.
1763 * src/dbus_api/modest-dbus-api.h:
1764 * src/dbus_api/modest-dbus-callbacks.c:
1765 (on_delete_message),
1766 (modest_dbus_req_handler):
1767 Implement deletion of messages (Server side).
1769 * tests/dbus_api/test_search.c: (main):
1772 * tests/dbus_api/Makefile.am:
1773 * tests/dbus_api/test_delete_message:
1774 Add little test for the message deletion logic
1776 2007-06-03 Armin Burgmeier <armin@openismus.com>
1778 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1779 when the operation queue was not empty. projects.maemo.org bug
1782 2007-06-03 Armin Burgmeier <armin@openismus.com>
1784 * src/widgets/modest-account-view.c
1785 (on_account_default_toggled): Toggle default account column
1786 explicitely instead of waiting for gconf notification (which is
1787 currently ignored). This should fix projects.maemo.org bug NB#56910
1788 for now. It should probably be removed when gconf notifications are
1791 2007-06-03 Christian Kellner <ckellner@openismus.com>
1793 * libmodest-dbus-client/libmodest-dbus-client.c:
1794 Removed debugging spew.
1796 * src/dbus_api/modest-dbus-callbacks.c:
1797 Added debugging info.
1799 * src/modest-search.c:
1800 (modest_search_all_accounts):
1801 Use tny_account_store_get_accounts () on the account store
1802 to get all accounts which is the way to get all accounts.
1804 * tests/dbus_api/test_search.c: (main):
1805 Make it possible to supply the search term on the command line.
1807 2007-06-03 Christian Kellner <ckellner@openismus.com>
1809 * libmodest-dbus-client/libmodest-dbus-client.c:
1810 * libmodest-dbus-client/libmodest-dbus-client.h:
1811 Implement searching for mesages over raw dbus. (Client side)
1813 * src/dbus_api/Makefile.am:
1814 * src/dbus_api/modest-dbus-api.h:
1815 * src/dbus_api/modest-dbus-callbacks.c:
1816 * src/dbus_api/modest-dbus-callbacks.h:
1817 Search framework (Server side). Also implement on_idle_open_message().
1819 * src/maemo/modest-platform.c: (modest_platform_init):
1820 Prepare for raw dbus/osso rpc interaction.
1822 * src/modest-search.h:
1823 Changed minsize from unspecific guint to guint32.
1825 * src/modest-search.c:
1827 Added strange hack which magically made tnymail work.
1829 (modest_search_folder),
1830 (modest_search_account),
1831 (modest_search_all_accounts):
1832 Implement helper functions to search all accounts, specific account
1835 * tests/dbus_api/Makefile.am:
1836 * tests/dbus_api/test_open_message.c:
1837 Read url to open from commandline.
1839 * tests/dbus_api/test_search.c:
1840 Implement small test for dbus search stuff
1842 2007-06-02 Armin Burgmeier <armin@openismus.com>
1844 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1845 include account type and account title. This fixes projects.maemo.org
1848 * src/maemo/modest-account-view-window.c: Set a title for the window.
1850 2007-06-02 Armin Burgmeier <armin@openismus.com>
1852 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1853 incoming and outgoing server name based on email address and server
1854 types as long as the names have not been edited manually. This fixes
1855 projects.maemo.org bug NB#58671.
1857 2007-06-02 Armin Burgmeier <armin@openismus.com>
1859 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1860 server type cannot be changed in future to the incoming details page
1861 when creating an account. This fixes projects.maemo.org bug NB#59029.
1863 2007-06-02 Armin Burgmeier <armin@openismus.com>
1865 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1866 and assigned max width chars so that they wrap instead of being
1867 truncated. Fixes projects.maemo.org bug NB#56126.
1869 2007-06-02 Armin Burgmeier <armin@openismus.com>
1871 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1872 introductory note to the connection specific smtp servers dialog, as
1873 section 8.12 of the email UI specification requires. This fixes
1874 projects.maemo.org bug NB#59212.
1876 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1879 Check for running mail operations, and offer to cancel them, as per the UI
1880 spec. This fixes projects.maemo.org bug NB#59041 .
1881 However, I suspect that tinymail may still use the network connection
1882 in ways that we cannot detect or cancel. But it should at least adapt to
1883 changes fairly well.
1885 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-tny-account-store.c: (recreate_all_accounts),
1888 (get_cached_accounts), (get_server_accounts): Do more sensible
1889 ref-counting of the temporarily-cached outbox accounts list. This seems
1890 to fix a crash when entering the password when the password was wrong.
1892 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1894 * src/gnome/modest-main-window.c: (connect_signals):
1895 * src/modest-tny-account-store.c: (get_password),
1896 (modest_tny_account_store_alert): Added comments and clues and
1897 commented-out code about how we currently fail to deal with connection
1898 errors and wrong passwords, and how we should.
1900 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1902 * src/widgets/modest-retrieve-combo-box.c:
1903 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1904 This fixes projects.maemo.org bug NB#58472 .
1906 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1908 * src/maemo/easysetup/modest-easysetup-wizard.c:
1909 (create_page_complete_easysetup):
1910 (create_page_complete_custom): Correct the last commit,
1911 putting the correct sentences in the correct pages.
1913 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/easysetup/modest-easysetup-wizard.c:
1916 (create_page_complete_custom): Show the second sentence of text
1917 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1920 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1923 Set the leave-on-server conf key by default. This fixes
1924 projects.maemo.org bug NB#59258 .
1926 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1928 * src/maemo/modest-account-view-window.c:
1929 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1930 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1933 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/easysetup/modest-easysetup-wizard.c:
1936 (create_caption_new_with_asterisk):
1937 * src/maemo/modest-account-settings-dialog.c:
1938 (create_caption_new_with_asterisk):
1939 Uncomment the code to add the asterisk, because they are no longer in the
1940 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1941 (update_incoming_server_title): Add an asterisk here too.
1943 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1945 * src/maemo/modest-maemo-global-settings-dialog.c:
1946 (current_connection): Check that we are even connected before trying to
1947 get the current connection name, to prevent a warning.
1949 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1950 Change the comments because tny_maemo_conic_device_connect() is now meant to
1952 * src/modest-mail-operation.c:
1953 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1954 make sure we have a connection and fail if we can't connect.
1956 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1958 * src/maemo/modest-main-window.c:
1959 (on_account_store_connecting_finished): Do not try to get the
1960 connection ID if we are not really connected. I am surprised that
1961 this signal handler is called when we are not connected.
1963 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1965 * src/modest-error.h:
1966 * src/modest-ui-actions.c:
1967 (modest_ui_actions_get_msgs_full_error_handler):
1968 Renamed an enum, added comments, added an enum
1969 for retrieve-limit errors.
1971 * src/modest-mail-operation.c: (foreach_add_item),
1972 (internal_folder_observer_update), (update_account_thread),
1973 (modest_mail_operation_get_msgs_full):
1974 (modest_mail_operation_update_account),
1975 Added comments about how this works, and some code that should
1976 (but does not) check the retrieve-limit. See the TODO comment.
1978 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1981 Initialize help_id to fix the build. Warnings are good.
1983 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1985 * src/widgets/modest-hbox-cell-renderer.c:
1986 (modest_hbox_cell_renderer_append):
1987 * src/widgets/modest-vbox-cell-renderer.c:
1988 (modest_vbox_cell_renderer_append):
1989 Fix the last commit by doing an extra ref.
1991 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1993 * src/widgets/modest-hbox-cell-renderer.c:
1994 (modest_hbox_cell_renderer_append):
1995 * src/widgets/modest-vbox-cell-renderer.c:
1996 (modest_vbox_cell_renderer_append):
1997 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1998 to fix the build with Maemo Bora.
1999 However, there seems to be a remaining crash, probably due to reference
2002 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2004 * src/modest-tny-account.c:
2005 (modest_tny_account_new_for_local_folders):
2006 Use hildon_file_system_info_async_new() to get a better name for
2007 the memory card account, setting it as the account name.
2008 The timing seems to work, but this is probably
2009 not the best place to do this. See the TODO comment.
2010 * src/maemo/modest-main-window.c: (create_details_widget):
2011 * src/widgets/modest-folder-view.c: (text_cell_data):
2012 Use the tny account name instead of hardcoding a name.
2014 2007-05-30 Christian Kellner <ckellner@openismus.com>
2016 * src/modest-search.c: (modest_search):
2017 Correctly set part_search_func even if we have already parsed
2018 the query and thus a valid OgsTextSearcher object.
2020 2007-05-30 Christian Kellner <ckellner@openismus.com>
2023 Search and check for libogs.
2026 Incooparte the ogs build env.
2028 * src/modest-mime-part-search-stream.c:
2029 * src/modest-mime-part-search-stream.h:
2030 Removed since we do the real searching now in modest-search.c.
2032 * src/modest-search.c:
2033 * src/modest-search.h:
2034 Implement support for ogs. We use that if available and requested
2035 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2036 should now handle the corner case when the search term is spread
2037 across multiple reads.
2038 Also the logic in modest_search () was corrected to search all
2039 requested fields until one is found.
2041 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2045 * src/modest-init.h:
2046 * src/modest-init.c: Made modest_init_local_folders() take a
2047 path and be public so we can iniitialize maildir folders on
2050 * src/modest-local-folder-info.h:
2051 * src/modest-local-folder-info.c:
2052 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2054 * src/modest-tny-account.c:
2055 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2056 still means the standard local-folders path on the local volume.
2058 * src/modest-tny-account-store.c:
2059 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2060 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2061 all accounts when that happens.
2062 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2063 this too, so it shows up in the treeview.
2065 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/modest-maemo-global-settings-dialog.c:
2068 (current_connection):
2069 * src/widgets/modest-global-settings-dialog.c:
2070 (current_connection_default):
2071 Use the enum values instead of 0, 1 and -1,
2072 to make the code clearer.
2074 * src/modest-account-mgr-helpers.c:
2075 (modest_account_mgr_get_connection_specific_smtp): Make this code
2078 * src/modest-runtime.h:
2079 * src/modest-runtime.c:
2080 Added modest_runtime_remove_all_send_queues().
2081 * src/maemo/modest-main-window.c:
2082 (on_account_store_connecting_finished): Recreate the send queues,
2083 using the appropriate transport accounts for this new connection.
2084 Some futher adapting might be needed if the old send queues are not
2085 automatically stopped at this point.
2087 * src/modest-tny-account-store.c: (get_server_accounts):
2088 Create the connection-specific transport accounts, so that they can
2089 be found later by their ID.
2091 * src/modest-tny-account.h:
2092 * src/modest-tny-account.c:
2093 Added modest_tny_account_new_from_server_account_name().
2094 modest_tny_account_new_from_server_account(): Do not create the
2095 send queues here, because they will be
2096 recreated anyway when the connection changes for the first time.
2098 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2100 * src/modest-local-folder-info.h:
2101 * src/modest-local-folder-info.c:
2102 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2103 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2104 tbox_folder): Take a modest account name instead of a server TnyAccount,
2105 so we can have per-modest-account rather than per-transport-account
2107 We must make sure that we change or recreate the exisitng send queues
2108 when the connection changes for connection-specific transport accounts.
2110 * src/modest-tny-account-store.c:
2111 (create_per_account_local_outbox_folders): Create outboxed per modest
2112 account, not per transport account.
2114 * src/modest-tny-account.h:
2115 * src/modest-tny-account.c:
2116 (modest_tny_account_get_special_folder): For outboxes, get the
2117 parent modest account name. The account is ignored for other folders.
2118 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2119 modest account name rather than a server TnyAccount.
2121 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2123 * src/modest-tny-account.c:
2124 (modest_tny_account_new_from_server_account):
2125 Call modest_runtime_get_send_queue() immediately after creating transport
2126 accounts, so that they start trying to send email from the outbox as soon
2127 as possible at startup. This is probably what we want.
2129 * src/modest-mail-operation.c: (update_account_thread):
2130 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2131 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2132 * src/modest-tny-send-queue.h:
2133 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2134 (modest_ui_actions_on_send):
2135 Added comments about how sending works, though it needs some more work.
2137 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-tny-account.c:
2140 (modest_tny_account_get_special_folder): Add TODO because this fails when
2141 the network is busy.
2142 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2143 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2144 Do not try to show this window when there is no active account. The UI
2145 specs does not tell us what to do in this case.
2147 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/Makefile.am:
2152 * src/widgets/Makefile.am: Some dist fixes.
2154 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2156 * src/maemo/modest-connection-specific-smtp-window.c:
2157 (on_button_edit): Make the code clearer, to prevent a double free.
2159 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/modest-account-settings-dialog.c:
2162 (modest_account_settings_dialog_set_account_name),
2163 Check the connection-specific smtp servers checkbox if there are any.
2165 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2166 (modest_connection_specific_smtp_edit_window_init):
2167 Start with a suitable port number.
2169 * src/modest-account-mgr-helpers.h:
2170 * src/modest-account-mgr-helpers.c: Added
2171 modest_account_mgr_get_has_connection_specific_smtp().
2173 (modest_account_mgr_set_connection_specific_smtp),
2174 (modest_account_mgr_remove_connection_specific_smtp),
2175 (modest_account_mgr_get_has_connection_specific_smtp),
2176 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2177 connection-specific smtp server accounts in the account, rather than
2178 the server account conf dir.
2180 This fixes bug projects.maemo.org bug NB#58263 .
2182 * src/modest-tny-account-store.c:
2183 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2184 if there are no server accounts yet, to prevent an infinite loop when there
2185 are no accounts. Document that one must be called before the other.
2187 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-account-mgr-helpers.c:
2190 (modest_account_mgr_get_default_account): Make sure that at least
2191 one account is always the default, if there are any enabled accounts.
2192 This is just a sanity check that shouldn't be necessary.
2194 * src/modest-account-mgr-priv.c:
2195 (_modest_account_mgr_account_from_key): Unescape the conf key to
2196 get the real account name. For instance, this is an issue if a space
2197 was in the account name, which can happen because the account name
2198 is generated from the display name.
2199 (_modest_account_mgr_get_account_keyname): Always escape the
2201 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2202 Unescape the conf keys to get the real account names.
2204 For instance, previously the is-default radio button in the accounts
2205 list was not checked for any accounts at first. This fixes that,
2206 and might fix several similar bugs.
2208 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2210 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2211 Removed some debug printfs.
2213 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2215 Modest on-disk outbox directories are now here, for instance:
2216 $HOME/.modest/outboxes/<account-id-1>/outbox
2217 $HOME/.modest/outboxes/<account-id-2>/outbox
2219 $HOME/.modest/local-folders/outbox
2220 so we can have a separate outbox for each account.
2221 But they are shown as one outbox in the GtkTreeView, by using a
2222 TnyMergeFolder in a ModestTnySimpleFolderStore.
2225 * src/modest-tny-simple-folder-store.c:
2226 * src/modest-tny-simple-folder-store.h:
2227 Added ModestTnySimpleFolderStore, used to contain folders from
2228 other folder stores, such as other accounts.
2230 * src/modest-tny-outbox-account.h:
2231 * src/modest-tny-outbox-account.c:
2232 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2233 used for the per-account local outbox folders.
2235 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2236 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2237 only use this (internally) now for the non-outbox local folders.
2239 * src/modest-init.h:
2240 * src/modest-init.c: Added modest_init_one_local_folder(), for
2241 setting up the directory structure for each local folder.
2243 * src/modest-local-folder-info.c:
2244 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2245 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2247 * src/modest-local-folder-info.h:
2248 * src/modest-tny-account-store.c: (on_account_removed),
2249 (on_account_changed), (create_per_account_local_outbox_folders),
2250 (get_server_accounts), (modest_tny_account_store_get_accounts),
2251 (modest_tny_account_store_get_tny_account_by_account),
2252 (modest_tny_folder_store_is_virtual_local_folders):
2254 * src/modest-tny-account.h:
2255 * src/modest-tny-account.c:
2256 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2257 to create an on-disk per-account local outbox folder for each
2259 (create_per_account_local_outbox_folders): Create a local outbox folder
2260 for each transport account.
2261 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2262 for all local folders.
2264 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2265 instead of using g_object_get/set() directly. It is clearer.
2267 (modest_tny_folder_store_get_message_count),
2268 (modest_tny_folder_store_get_local_size
2269 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2270 because we now use these with non-acount folder stores.
2272 (modest_tny_account_get_special_folder),
2273 (modest_tny_account_new_from_server_account),
2274 (modest_tny_account_new_from_account):
2275 (recurse_folders): Adjust to the new outbox system.
2277 * src/modest-tny-folder.h:
2278 * src/modest-tny-folder.c:
2279 (modest_tny_folder_is_local_folder),
2280 (modest_tny_folder_get_local_folder_type),
2281 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2283 * src/widgets/modest-main-window.h:
2284 * src/maemo/modest-main-window.c: (create_details_widget),
2285 (modest_main_window_set_contents_style): Show details for any folder store,
2288 (modest_tny_folder_get_rules):
2289 Remove the const. C does not support constness enough for this.
2291 * src/modest-ui-actions.c:
2292 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2293 make all outboxes appear as one, in the usual local-folders tree node.
2295 (set_active_account_from_tny_account),
2296 (modest_ui_actions_on_folder_selection_changed):
2297 * src/widgets/modest-folder-view.c: (text_cell_data),
2298 (icon_cell_data), (filter_row),
2299 (add_account_folders_to_merged_folder),
2300 (add_account_folders_to_simple_folder_store), (),
2301 (get_cmp_rows_type_pos), (cmp_rows),
2302 (modest_folder_view_set_account_id_of_visible_server_account):
2303 Adjust to the new outbox system, using generic folder stores and folders
2304 in the GtkTreeModel.
2306 2007-05-23 Christian Kellner <ckellner@openismus.com>
2308 * src/modest-mail-operation.c:
2309 (modest_mail_operation_update_account):
2310 Use info->max_size instead of unintialized local var [small
2311 build fix]. (Added TODO to review that change since I don't
2314 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2316 * libmodest-dbus-client/libmodest-dbus-client.c:
2317 (libmodest_dbus_client_compose_mail): function added
2318 * src/dbus_api/modest-dbus-api.h:
2319 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2320 (on_compose_mail): Implementation of the SendAsMail functionality
2322 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2324 * src/modest-account-mgr.c:
2325 (modest_account_mgr_add_server_account): Set the secure-connection
2326 conf key for transport accounts as well as store accounts. I don't know
2327 why the if was there. For instance, this makes sure that we use SSL
2328 for the gmail preset from the easysetup wizard.
2330 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2332 * src/gnome/modest-main-window.c:
2333 (on_account_store_connecting_finished), (connect_signals):
2334 * src/maemo/modest-main-window.c:
2335 (on_account_store_connecting_finished), (connect_signals),
2336 (modest_main_window_new):
2337 Handle TnyAccountStore::connecting-finished instead of
2338 TnyDevice::connection-changed, because we cannot actually perform
2339 operations on accounts until TnyAccountStore has itself responded to
2340 the TnyDevice::connection-changed signal. This prevents a GError from
2342 Do not try to update at startup, because we (at least on scratchbox)
2343 already do an update at startup when the device goes online.
2344 This prevents a GError from tinymail.
2345 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2346 Added TODO about stopping simultaneous operations.
2348 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2350 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2351 * src/modest-mail-operation-queue.c:
2352 (modest_mail_operation_queue_remove):
2353 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2354 about where they happened.
2356 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2358 * src/modest-ui-actions.c:
2359 (modest_ui_actions_on_password_requested): Make sure that the remember
2360 output parameter is always TRUE.
2362 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2365 Show a OK/Cancel dialog if the error is a question, though we still do not
2366 know anything more about what we are asking the user.
2367 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2368 Fix an uninitialized variable (helper). This is a logic error, however.
2370 2007-05-21 Christian Kellner <ckellner@openismus.com>
2372 * src/modest-search.h:
2373 Correct bit shifting in the ModestSearchFlags enum.
2375 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2377 * src/modest-tny-account.c:
2378 (modest_tny_account_new_from_server_account): Do not use the lsub and
2379 check-all hard-coded IMAP options when using POP.
2381 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-tny-account.c:
2384 (modest_tny_account_new_from_server_account):
2385 Use NULL for the secure-auth method for POP when Password auth has been
2386 specified by the user, as we already do for IMAP. "auth=Login" causes
2387 an error from camel or the server.
2389 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2391 * src/maemo/modest-account-settings-dialog.c:
2392 (create_page_account_details),
2393 (modest_account_settings_dialog_set_account_name):
2394 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2395 for the leave-on-server checkbox, rathr than just the checkbox, when
2396 the protocol is not POP.
2398 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2400 * src/widgets/modest-account-view.c:
2401 * src/widgets/modest-account-view.h:
2402 Added modest_account_view_select_account() which will be useful later
2403 to asynchronously re-select the edited account.
2405 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2407 * src/maemo/modest-account-settings-dialog.c:
2408 (modest_account_settings_dialog_set_account_name):
2409 Automatically choose the port numbers based on the secure authentication
2410 methods, if they have not been chosen before.
2411 This fixes projects.maemo.org bug NB#56273 .
2413 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/modest-main-window-ui.h:
2416 * src/modest-ui-actions.c:
2417 * src/modest-ui-actions.h:
2418 Connect the Tools/SMTP Servers menu item to
2419 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2420 SMTP servers dialog, as in the UI specification and saves changes when it
2421 is closed. This fixed projects.maemo.org bug NB#56305 .
2423 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2425 * src/maemo/modest-connection-specific-smtp-window.c:
2426 (modest_connection_specific_smtp_window_init):
2427 Use gtk_window_set_default_size() to make this window big enough, so
2428 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2430 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2434 (modest_connection_specific_smtp_edit_window_init),
2435 Do not try to connect to a combobox signal before the combobox exists.
2436 This fixes the cras in projects.maemo.org bug NB#56288 .
2437 (modest_connection_specific_smtp_edit_window_get_settings):
2438 Remove the server_account_name parameter which was being checked for NULL
2439 though it was not used.
2441 * src/maemo/modest-connection-specific-smtp-window.c:
2442 (modest_connection_specific_smtp_window_fill_with_connections),
2443 (on_button_edit), (modest_connection_specific_smtp_window_init):
2444 Correct the number of treemodel columns to prevent a warning.
2445 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2446 libconic does not work.
2448 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2450 * src/modest-tny-account.c:
2451 (modest_tny_account_new_from_server_account):
2452 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2453 SMTP when "None" was chosen by the user. However, with my SMTP server that
2454 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2457 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2460 to explain the memory management issue with the ID in the ModestPair.
2462 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2463 (add_sending_page), (modest_account_assistant_finalize):
2464 * src/gnome/modest-gnome-global-settings-dialog.c:
2465 (create_updating_page), (create_composing_page):
2466 * src/gnome/modest-msg-edit-window.c: (get_transports),
2467 (init_window), (modest_msg_edit_window_finalize),
2468 (modest_msg_edit_window_get_msg_data):
2469 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2470 * src/gnome/modest-transport-widget.c:
2471 (modest_transport_widget_finalize), (smtp_configuration):
2472 * src/maemo/modest-maemo-global-settings-dialog.c:
2473 (create_updating_page), (create_composing_page):
2474 * src/maemo/modest-msg-edit-window.c: (get_transports),
2475 (init_window), (modest_msg_edit_window_finalize),
2476 (modest_msg_edit_window_get_msg_data),
2477 (modest_msg_edit_window_free_msg_data):
2478 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2479 (modest_store_widget_finalize):
2480 * src/maemo/modest-transport-widget.c:
2481 (modest_transport_widget_finalize), (smtp_configuration):
2482 * src/modest-main.c: (send_mail):
2483 * src/widgets/modest-combo-box.h:
2484 * src/widgets/modest-global-settings-dialog-priv.h:
2485 * src/widgets/modest-global-settings-dialog.c:
2486 (modest_global_settings_dialog_finalize):
2487 * src/widgets/modest-msg-edit-window.h:
2488 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2489 as long as the combo box, to prevent use of freed memory for the ID.
2491 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2494 get_accounts(), to make this clearer. Do not check for the enabled gconf
2495 key, because we do not use this for server accounts (at least, not yet).
2496 This allows us to send email again.
2498 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/modest-platform.c:
2501 (on_modest_conf_update_interval_changed), (modest_platform_init):
2502 Only respond to this particular key change. All these strcmp()s cannot be
2505 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2507 * src/maemo/modest-maemo-global-settings-dialog.c:
2508 (current_connection): Prevent a crash in scratchbox when
2509 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2510 * src/maemo/modest-platform.c:
2511 (on_modest_conf_update_interval_changed), (modest_platform_init):
2512 Get the update interval from gconf and reset it when the gconf key changes.
2514 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2516 * src/modest-protocol-info.c:
2517 * src/modest-protocol-info.h: Adde enum-specific get functions,
2518 instead of using a ModestProtocolType enum parameter.
2520 * src/gnome/modest-account-assistant.c:
2521 * src/gnome/modest-store-widget.c:
2522 * src/gnome/modest-store-widget.h:
2523 * src/gnome/modest-transport-widget.c:
2524 * src/gnome/modest-transport-widget.h:
2525 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2526 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2527 * src/maemo/easysetup/modest-easysetup-wizard.c:
2528 * src/maemo/modest-account-settings-dialog.c:
2529 * src/maemo/modest-account-settings-dialog.h:
2530 * src/maemo/modest-store-widget.c:
2531 * src/maemo/modest-store-widget.h:
2532 * src/maemo/modest-transport-widget.c:
2533 * src/maemo/modest-transport-widget.h:
2534 * src/modest-account-mgr-helpers.c:
2535 * src/modest-account-mgr-helpers.h:
2536 * src/modest-account-mgr.c:
2537 * src/modest-account-mgr.h:
2538 * src/modest-tny-account.c:
2539 * src/modest-tny-folder.c:
2540 * src/widgets/modest-account-view.c:
2541 * src/widgets/modest-retrieve-combo-box.c:
2542 * src/widgets/modest-retrieve-combo-box.h:
2543 * src/widgets/modest-secureauth-combo-box.c:
2544 * src/widgets/modest-serversecurity-combo-box.c:
2545 * src/widgets/modest-serversecurity-combo-box.h:
2546 * tests/check_account-mgr.c:
2547 Use the specific functions, and use the re-renamed enum values for GNOME too.
2549 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2551 * src/modest-pair.h:
2552 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2553 so we can get the second based on the first.
2555 * src/maemo/modest-account-settings-dialog.h:
2556 * src/maemo/modest-account-settings-dialog.c:
2557 Added get_supported_secure_authentication_methods(), though it is mostly
2558 commented-out for now until the necessary API is committed to tinymail.
2559 (modest_account_settings_dialog_set_account_name),
2560 (save_configuration): Request the supported authentication methods from the
2561 server, so we can choose a working method.
2563 * src/modest-tny-account-store.h:
2564 * src/modest-tny-account-store.c:
2565 (modest_tny_account_store_get_session): Rename from
2566 tny_account_store_get_session().
2568 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2570 * src/modest-protocol-info.h: Split the ModestProtocol enum
2571 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2572 There was no need to have these unrelated values in one enum.
2574 * src/: many files: Adapted to changed enum. This makes the code a bit
2575 clearer, and the compiler could catch some errors.
2577 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2579 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2580 Show the detailed internal camel error message when an error happens
2581 during the configuration, so that our testers can give us more clues.
2582 For instance, in projects.maemo.org bug NB#56910 .
2584 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-tny-account.c:
2587 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2588 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2590 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2593 * src/maemo/modest-account-settings-dialog.c:
2594 (modest_account_settings_dialog_set_account_name),
2595 (save_configuration): For the incoming secure authentication checkbox,
2596 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2597 the UI specification. PLAIN does not seem to be supported for most IMAP
2598 servers anyway, and I am not sure what it would mean.
2599 However, we probably need to discover which of the secure-authentication
2600 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2601 * src/modest-account-mgr-helpers.c:
2602 (modest_account_mgr_get_server_account_data):
2604 * src/modest-tny-account.c:
2605 (modest_tny_account_new_from_server_account):
2606 Use tny_account_set_mech() to set secure-authentication methods,
2607 with some special-casing for IMAP, based on my observations of how
2610 * src/modest-account-mgr-helpers.h:
2611 * src/modest-account-mgr.c:
2612 * src/modest-defs.h: Comment that the URI is only used for local folders.
2614 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2616 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2617 parameter const, just to be neat.
2618 * src/modest-text-utils.c: (modest_text_utils_inline):
2619 End g_strconcat() with NULL, as its documentation says. This is almost
2620 certainly the cause of my crash at startup on the device. Interestingly,
2621 valgrind doesn't tell us about these errors.
2623 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2625 * scripts/build-packages: Added more precise comments about how to use
2626 this script, though I still get this error:
2627 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2628 error building tinymail
2630 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2632 * src/maemo/modest-main-window.c: (on_account_update):
2633 Very slight cleanup, hoping to make it simpler to discover what causes
2634 a crash here sometimes.
2636 * src/modest-tny-account.c:
2637 (modest_tny_account_new_from_server_account): Set the port. Added
2638 comments about the options and a TODO comment because I need to find out
2639 how to specify the secure authentication method.
2641 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2643 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2644 changed CFlags paths form modest to libmodest
2646 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2648 * src/modest-account-mgr-helpers.c:
2649 (modest_account_mgr_get_server_account_data),
2650 (modest_account_mgr_free_server_account_data):
2651 * src/modest-account-mgr-helpers.h:
2652 * src/modest-account-mgr.c:
2653 (modest_account_mgr_add_server_account):
2654 * src/modest-defs.h:
2655 * src/modest-tny-account.c:
2656 (modest_tny_account_new_from_server_account):
2657 Determine the options for tny_camel_account_add_option() here,
2658 based on the settings, rather than storing them directly in gconf.
2660 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2662 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2663 Show a more friendly error dialog now that we expect (from the tinymail
2664 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2666 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-main-window.c: (on_account_update): Check that
2669 account_name is not NULL, to prevent a crash at startup that I am
2670 seeing on the N800. I do wonder why it is NULL.
2672 * src/maemo/easysetup/modest-easysetup-wizard.c:
2673 (create_page_user_details):
2674 * src/maemo/modest-account-settings-dialog.c:
2675 (create_page_user_details), (create_page_outgoing):
2676 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2677 (modest_connection_specific_smtp_edit_window_init):
2678 * src/modest-ui-actions.c:
2679 (modest_ui_actions_on_password_requested):
2680 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2681 might do something useful with the on-screen keyboard.
2683 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/modest-main-window.c: (on_account_update):
2686 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2687 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2689 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2691 * src/modest-tny-account-store.c: (on_account_changed):
2692 Correct the signature of this signal handler.
2694 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2696 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2697 Show a HildonNote instead of a GtkDialog for Maemo.
2699 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2701 * src/widgets/modest-account-view.h:
2702 * src/widgets/modest-account-view.c: (on_account_changed),
2703 (on_account_removed). Added a boolean flag, set/unset by
2704 modest_account_view_block_conf_updates(),
2705 modest_account_view_unblock_conf_updates() to prevent unnecessary
2706 updates, but this is not very useful because the gconf notifications are
2707 so delays (maybe only on Maemo Bora).
2708 So auto-updating is turned off, and these functions do an explicit
2709 update when necessary.
2710 However, something else is still doing too much work when adding/removing
2711 accounts, probably in another part of the application.
2713 * src/maemo/modest-account-view-window.c:
2714 (on_delete_button_clicked), (on_edit_button_clicked),
2715 (on_new_button_clicked): Use the new functions.
2717 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2719 * src/modest-account-mgr-helpers.c:
2720 (modest_account_mgr_set_first_account_as_default):
2721 Sort the list of names alphabetically-by-title, so we choose the first one
2723 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2724 alphabetically by the title.
2726 This fixes projects.maemo.org bug NB#56418 .
2728 * src/modest-account-mgr-priv.c:
2729 (_modest_account_mgr_account_from_key):
2730 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2731 avoid a valgrind error, and possible random behaviour.
2733 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2735 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2736 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2737 tinymail documentation to say that this can be expected.
2738 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2739 pretty, and should not happen, but I would prefer to know when it does.
2741 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2743 * configure.ac: When using the older hildon version, probably on Bora,
2744 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2746 * src/widgets/modest-attachment-view.c:
2747 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2750 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2752 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2753 Implemented the prototype. Can be tested with
2754 tests/dbus_api/test_open_message:
2756 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2758 * src/modest-tny-account-store.c:
2759 (modest_tny_account_store_instance_init), (get_password):
2760 * src/modest-ui-actions.c:
2761 (modest_ui_actions_on_password_requested):
2762 Do not store the password in gconf, because this function is called
2763 for non-remembered passwords. Actually use the cached (in the hash map)
2764 password instead of releasing it.
2765 The password will now not be remembered if it is asked via the protected
2766 password dialog, as per the UI spec.
2768 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2770 * src/modest-defs.h:
2771 * src/modest-account-mgr-helpers.h:
2772 * src/modest-account-mgr-helpers.c:
2773 Added modest_server_account_get_username_has_succeeded(),
2774 modest_server_account_set_username_has_succeeded().
2775 (modest_server_account_set_username),
2776 Reset the has-succeeded flag if the username changes.
2778 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2779 * src/maemo/modest-connection-specific-smtp-window.c:
2780 (modest_connection_specific_smtp_window_save_server_accounts):
2781 Use modest_server_account_set_username() instead of using
2782 modest_conf_set_string() directly, so that the has-succeeded flag is always
2785 * src/modest-ui-actions.c:
2786 (modest_ui_actions_on_password_requested): Dim the username entry if
2787 the username has ever worked, as per the UI spec.
2789 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2791 * src/modest-tny-account-store.c: (get_password):
2792 * src/modest-ui-actions.c:
2793 (modest_ui_actions_on_password_requested):
2794 Allow the username to be changed too, though there is more work to
2795 be done on exactly how this behaves.
2797 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2799 * src/modest-account-mgr-helpers.h:
2800 * src/modest-account-mgr-helpers.c:
2801 Added modest_account_mgr_get_display_name(),
2802 modest_server_account_get_username(),
2803 modest_server_account_set_username(),
2804 modest_server_account_set_password(),
2805 modest_server_account_get_hostname() functions so we do not need to
2806 use the conf API directly.
2808 * src/maemo/modest-main-window.c: (connect_signals):
2809 Actually connect ot the ModestAccountStore::request-password signal,
2810 so that we show the dialog when the password is requested by Tinymail,
2811 for isntance if it is empty.
2813 * src/modest-marshal.list:
2814 * src/modest-tny-account-store.c:
2815 (modest_tny_account_store_class_init), (get_password),
2816 (modest_tny_account_store_alert):
2817 * src/modest-tny-account-store.h:
2818 * src/modest-ui-actions.h:
2819 * src/modest-ui-actions.c:
2820 (modest_ui_actions_on_password_requested):
2821 Change the signal parameters, so it is obvious that we are providing
2822 the non human-readable server name, and receiving both the username
2823 and password, though changing of the username is not yet implemented.
2824 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2825 for the GNOME version.
2827 This should fix the projects.maemo.org bug NB#56209, though it does not
2828 work on Bora, because the gconf_client_get() for the password fails
2829 immediately after we save it with gconf_client_set().
2831 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2834 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2835 caused an undefined symbol error:
2836 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2838 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2840 * src/modest-tny-account-store.c:
2841 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2842 using a GError instead of a string message, so we can translate it in
2845 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/modest-address-book.c:
2848 (modest_address_book_check_names):
2849 * src/maemo/modest-msg-view-window.c:
2850 (modest_msg_view_window_clipboard_owner_change):
2851 * src/modest-init.c: (modest_init_init_ui):
2852 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2853 (update_folders_cb), (modest_mail_operation_update_account):
2854 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2855 (modest_ui_actions_on_msg_attachment_clicked),
2856 (modest_ui_actions_on_msg_recpt_activated):
2857 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2858 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2859 (modest_msg_view_search_next):
2860 * src/widgets/modest-recpt-editor.c:
2861 (modest_recpt_editor_on_button_release_event),
2862 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2863 g_message(). At this point we should only be seeing interesting errors on
2864 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2866 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2868 (modest_wizard_dialog_force_title_update):
2869 * src/maemo/easysetup/modest-wizard-dialog.h:
2870 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2871 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2872 can update the title when appropriate. Otherwise the title is wrong if the
2873 pages are added after adding the notebook to the dialog.
2874 This must be a problem in HildonWizardDialog too.
2875 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2877 * src/maemo/easysetup/modest-easysetup-wizard.c:
2878 (create_subsequent_customsetup_pages),
2879 (create_subsequent_easysetup_pages):
2880 Call modest_wizard_dialog_force_title_update() so that the title is
2881 correct even with GTK+ < 2.10.
2882 This fixes projects.maemo.org bug NB#56145 .
2884 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2886 * src/maemo/modest-platform.c:
2887 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2888 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2891 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2893 * src/widgets/modest-window.h:
2894 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2895 and modest_window_save_state(), which invokes it.
2897 * src/widgets/modest-window-mgr.h:
2898 * src/widgets/modest-window-mgr.c:
2899 Added modest_window_mgr_save_state_for_all_windows(), which calls
2900 the save_state vfunc on all registered windows, if implemented.
2902 * src/gnome/modest-msg-edit-window.c:
2903 * src/gnome/modest-msg-view-window.c:
2904 * src/maemo/modest-msg-edit-window.c:
2905 * src/maemo/modest-msg-view-window.c:
2906 * src/maemo/modest-main-window.c:
2907 Specify the existing save_settings functions as implementations of
2908 ModestWindow::save_state_func().
2910 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2911 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2912 enabling hibernation, for instance.
2914 We may need to do the same thing for restoring settings.
2917 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2919 * src/widgets/modest-window-mgr.c:
2920 * src/widgets/modest-window-mgr.h:
2921 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2922 modest_window_mgr_get_hibernation_is_prevented().
2924 * src/maemo/modest-main-window.c:
2925 (on_hildon_program_is_topmost_notify): Prevent hibernation
2926 (possible when the application goes to the background in the WM),
2927 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2929 * src/maemo/easysetup/modest-easysetup-wizard.c:
2930 (modest_easysetup_wizard_dialog_init):
2931 * src/maemo/modest-account-settings-dialog.c:
2932 (modest_account_settings_dialog_init):
2933 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2934 (modest_connection_specific_smtp_edit_window_init):
2935 * src/maemo/modest-connection-specific-smtp-window.c:
2936 (modest_connection_specific_smtp_window_init):
2937 * src/maemo/modest-signature-editor-dialog.c:
2938 (modest_signature_editor_dialog_init):
2939 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2940 prevent hibernation while any of these account settings dialogs are open.
2942 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2944 * src/maemo/Makefile.am:
2945 * src/maemo/modest-osso-state-saving.c:
2946 * src/maemo/modest-osso-state-saving.h: Added
2947 modest_osso_load_state() and modest_osso_save_state() though they do
2948 nothing now. They should iterate through all the open windows and load/save
2950 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2951 save state when closing.
2953 * src/maemo/modest-main-window.c:
2954 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2955 Add a notification handler for the HildonProgram::is-topmost property,
2956 so we can allow hibernation when the application goes into the background.
2957 But we still need to detect when the accounts setup windows are open so
2958 we can stop hibernation when they are open.
2959 To do this, I also added the main window the HildonProgram. This might have
2960 other side-effects/benefits, and should maybe be done for other windows.
2962 * src/maemo/modest-osso-autosave-callbacks.h:
2963 * src/maemo/modest-osso-autosave-callbacks.c:
2964 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2965 though it does not do anything yet, and we might never need this to do
2966 anything. For instance, we already save drafts.
2968 * src/maemo/modest-platform.c: (modest_platform_init):
2969 Specify the libosso auto-save callback.
2971 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2973 * src/maemo/modest-platform.c:
2974 (modest_platform_set_update_interval):
2975 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2976 aparently stays valid between application instances, so we can use this
2977 to remove and reset it later. According to a maemo-developers email from
2980 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2982 * configure.ac: Depend on libalarm for Maemo.
2984 * src/dbus_api/modest-dbus-api.h:
2985 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2986 (on_send_receive), (modest_dbus_req_handler):
2987 Handle a SEND_RECEIVE D-Bus method.
2989 * libmodest-dbus-client/libmodest-dbus-client.c:
2990 (libmodest_dbus_client_send_and_receive):
2991 * libmodest-dbus-client/libmodest-dbus-client.h:
2992 Add C convenience functions for calling the new D-Bus method.
2994 * src/modest-platform.h:
2995 * src/gnome/modest-platform.c:
2996 * src/maemo/modest-platform.c:
2997 Added modest_platform_set_update_interval(), which uses the
2998 alarmd API on Maemo.
2999 (modest_platform_init),
3000 Call modest_platform_set_update_interval(), using a hard-coded
3001 interval for now (until the global settings dialog is implemented),
3002 though I am not sure that this makes sense yet.
3004 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3006 * src/dbus_api/modest-dbus-callbacks.c:
3007 (modest_osso_cb_hw_state_handler):
3008 * src/dbus_api/modest-dbus-callbacks.h:
3009 * src/maemo/modest-platform.c: (modest_platform_init):
3010 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3011 in case this has some effect on the ability for Maemo to ping the
3014 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3016 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3017 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3018 warning. It is probably a logic error, but I need to fix the build.
3020 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3022 * src/modest-account-mgr.h:
3023 * src/modest-account-mgr.c:
3024 (modest_account_mgr_account_names): Add a gboolean enabled_only
3025 parameter, so we can get lists of onlt the enabled accounts.
3027 (modest_account_mgr_add_account),,
3028 (modest_account_mgr_account_with_display_name_exists):
3029 * src/maemo/modest-msg-edit-window.c: (get_transports):
3030 * src/modest-account-mgr-helpers.c:
3031 (modest_account_mgr_set_first_account_as_default):
3032 * src/modest-init.c: (init_default_account_maybe):
3033 * src/modest-tny-account-store.c: (get_accounts):
3034 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3035 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3036 * tests/check_account-mgr.c: (START_TEST):
3037 Provide the extra parameter, as appropriate.
3039 * src/widgets/modest-account-view.c: (update_account_view):
3040 Do not show disabled accounts (meaning that there is no way to
3041 enable/disable accounts in the UI (the feature is not in our UI
3042 specification), so we can use this internally only to mark unfinished
3043 or temporary account data.
3045 * src/maemo/easysetup/modest-easysetup-wizard.c:
3046 (create_account): Add boolean enable parameter, so we can specify FALSE
3047 to create the temporary account.
3048 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3049 (on_before_next): When finishing, when there is a temporary account, just
3051 Also, use a timeout to delay the showing of the dialog until gconf is likely
3052 to return correct information, due to a maemo gconf bug that is fixed in
3053 osso 1.1, but not yet in Bora.
3054 However, the dialog stays on screen after it is destroyed.
3056 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3057 for invalid data when cancelling. Use a hildon note instead of a dialog
3058 to complain about invalid data. Do not show the account-saved note if the
3059 account is disabled (a temporary account that will not really be saved for use
3062 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3064 * src/modest-account-mgr-helpers.h:
3065 * src/modest-account-mgr-helpers.c:
3066 Added modest_account_mgr_unset_default_account(),
3067 Added modest_account_mgr_set_first_account_as_default().
3069 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3070 If it was the default account, unset the default account name.
3072 * src/maemo/modest-account-view-window.c:
3073 (on_delete_button_clicked): If it was the default account,
3074 set the first remaining account as the default instead.
3076 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3077 a NULL account or a NULL default account, to prevent a crash. This should
3078 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3081 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3083 * src/widgets/modest-recpt-editor.c:
3084 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3085 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3086 TODO comment for this. This fixes the build.
3088 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3089 be the best place for it. This will in future update all auto-update accounts,
3090 rather than just the current/default account, when that gconf key exists.
3091 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3092 if there are no accounts, before calling do_send_receive().
3093 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3095 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3096 * src/maemo/modest-main-window-ui.h:
3097 * src/maemo/modest-main-window.c: (on_connection_changed),
3098 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3099 directly, becaue the signal handler does more.
3101 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3103 * src/modest-account-mgr-helpers.c:
3104 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3105 for the case that the account does not exist.
3107 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3108 (equivalent to the modest account name) rather than the tinymail account name
3109 (equivalent to the modest account title - human readable) to get the account data.
3110 Check for null account data to prevent the crash, and add a TODO comment saying that
3111 this needs fixing because it is using the server account name instead of the account name.
3113 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3115 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3116 * src/maemo/modest-account-settings-dialog.c: (show_error),
3118 Use hildon_note_new_information() for informative and error messages,
3119 which seems to be expected for Maemo applications (no documentation that I know of
3120 says this). I am surprised that there is no distinction between info and error
3123 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3126 it is easy to find where this is used.
3128 * src/maemo/easysetup/modest-easysetup-wizard.c:
3129 (create_page_welcome), (create_page_account_details),
3130 (create_page_user_details), (create_page_complete_easysetup),
3131 (create_page_custom_incoming), (create_page_custom_outgoing),
3132 (create_page_complete_custom):
3133 * src/maemo/modest-account-settings-dialog.c:
3134 (create_page_account_details), (create_page_user_details),
3135 (create_page_incoming), (create_page_outgoing):
3136 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3137 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3138 (modest_connection_specific_smtp_edit_window_init):
3139 * src/maemo/modest-connection-specific-smtp-window.c:
3140 (modest_connection_specific_smtp_window_init):
3141 * src/maemo/modest-signature-editor-dialog.c:
3142 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3143 and scrolling policy as per the Email Application Layout Guide, if I have
3146 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3149 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3150 which were empty, because these vfuncs have been removed from TnyAccountStore.
3151 This fixes the build.
3153 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3155 * src/maemo/modest-main-window.c:
3156 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3157 showing/hiding it. Added TODO because it probably should not be NULL.
3158 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3159 because unnecessary g_warnings() make degugging difficult.
3161 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/modest-msg-edit-window.c:
3164 (modest_msg_edit_window_select_color),
3165 (modest_msg_edit_window_select_background_color): 2 const corrections and
3166 moving 2 #endifs before closing brackets, to fix the build.
3168 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/easysetup/modest-easysetup-wizard.h:
3171 * src/maemo/easysetup/modest-easysetup-wizard.c:
3172 (modest_easysetup_wizard_dialog_finalize),
3173 (on_button_edit_advanced_settings), (create_page_complete_custom),
3174 (on_response), (create_account):
3175 Implement the Advanced Settings edit button, by saving the account information,
3176 for the Advanded Settings dialog to use directly from gconf, and removing it
3177 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3178 Bug #5533 in the projects.maemo.org bugzilla.
3180 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3182 * src/maemo/modest-msg-view-window.c:
3183 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3184 when opening a message window.
3186 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/easysetup/modest-easysetup-wizard.c:
3189 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3192 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3193 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3194 gconf settings. I probably added more checks than necessary, but that is safer.
3196 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3197 variable to fix the build, but this seems to be used when it is still NULL.
3199 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-platform.h:
3202 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3203 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3204 * src/modest-main.c: Implement this function so we can avoid using
3205 maemo-specific API from cross-platform code.
3207 * src/modest-tny-account-store.c:
3208 (get_smtp_specific_transport_account_for_open_connection):
3209 * src/modest-ui-actions.c: (check_for_connection),
3210 (modest_ui_actions_on_item_not_found):
3211 Use modest_platform_connect_and_wait() and put #idefs around other
3212 maemo-specific code, because only maemo currently has a way to
3213 identify connection names.
3215 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3217 * src/modest-tny-account-store.h:
3218 * src/modest-tny-account-store.c:
3219 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3220 the connection-specific SMTP server settings in the configuration.
3222 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3224 * src/maemo/modest-main-window.c: (on_connection_changed),
3226 * src/modest-main.c: (main), (start_ui), (send_mail):
3227 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3228 that is what is intended.
3230 * src/modest-ui-actions.c: (action_send), (action_receive),
3231 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3232 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3233 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3234 SMTP server is used when it is specified.
3236 (modest_ui_actions_on_send_receive):
3237 Check that a connection is open before proceeding.
3238 Receive and then send, instead of vice-versa, as per the specification.
3240 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3242 * src/modest-mail-operation.c:
3243 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3244 though I guess it should be something other than NULL.
3246 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3248 * src/maemo/easysetup/modest-easysetup-wizard.c:
3249 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3250 combo twice, to avoid an g_warning and to make it visible again.
3251 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3252 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3253 (already intended) dereference when detaching, because we then recreate the menu.
3254 But I am not sure why the warning was happening, and it is possible that this is a memory
3257 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3259 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3260 and uri_parse_mailto() utility functions.
3261 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3263 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3265 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3267 * src/dbus_api/modest-dbus-api.h:
3268 * src/dbus_api/modest-dbus-callbacks.c:
3269 Use an idle callback to execute the modest code in the application's own thread.
3270 Remove the helloworld example method.
3271 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3272 parsed, and the open-message method is not implemented because this is not yet implemented in
3274 * libmodest-dbus-client/libmodest-dbus-client.c:
3275 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3276 (libmodest_dbus_client_open_message):
3277 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3279 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3280 body without crashing.
3282 * tests/dbus_api/Makefile.am:
3283 * tests/dbus_api/test_mail_to.c:
3284 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3286 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3288 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3289 Added file to fix the build. Sorry.
3291 * src/dbus_api/Makefile.am:
3292 * src/dbus_api/modest-dbus-api.h:
3293 * src/dbus_api/modest-dbus-callbacks.h:
3294 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3295 (modest_dbus_req_handler):
3296 Put constants in a separate header so it can be reused by the
3297 client library, without duplication
3299 * libmodest-dbus-client/Makefile.am:
3300 * libmodest-dbus-client/libmodest-dbus-client.c:
3301 (libmodest_dbus_client_call_helloworld),
3302 (libmodfest_dbus_client_send_mail),
3303 (libmodfest_dbus_client_mailto),
3304 (libmodfest_dbus_client_open_message):
3305 * libmodest-dbus-client/libmodest-dbus-client.h:
3306 (Partly) Implement a send_mail D-Bus method.
3308 * tests/dbus_api/Makefile.am:
3309 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3310 the send_email D-Bus method.
3312 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3316 * libmodest-dbus-client/Makefile.am:
3317 * libmodest-dbus-client/libmodest-dbus-client.c:
3318 * libmodest-dbus-client/libmodest-dbus-client.h:
3319 * tests/dbus_api/Makefile.am:
3320 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3321 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3323 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/easysetup/modest-easysetup-wizard.c:
3326 (create_page_account_details):
3327 * src/maemo/modest-account-settings-dialog.c:
3328 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3329 widgets, because this might not be the default in future versions of the Maemo GTK+.
3330 However, I can not not get capitalization to work even in a simple test case.
3332 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3334 * src/maemo/easysetup/modest-easysetup-wizard.c:
3335 (create_page_custom_incoming), (create_page_custom_outgoing):
3336 * src/maemo/modest-account-settings-dialog.c:
3337 (create_page_account_details), (create_page_incoming),
3338 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3339 instead of using gtk_check_button_with_label(), so they are aligned like the other
3340 widgets, as per the UI spec.
3342 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3344 * src/maemo/easysetup/modest-easysetup-wizard.c:
3345 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3346 * src/widgets/modest-validating-entry.c:
3347 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3348 Modest prefix instead of an EasySetup prefix.
3350 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3352 * src/widgets/modest-validating-entry.h:
3353 * src/widgets/modest-validating-entry.c: (on_insert_text),
3354 Added easysetup_validating_entry_set_max_func(), used to set a callback
3355 to call when the max number of characters is reached. GtkEntry has a max-length
3356 already but is silent about it.
3358 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3359 (create_page_account_details), (create_page_user_details),
3361 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3362 (create_page_account_details), (create_page_user_details),
3363 (create_page_outgoing):
3364 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3365 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3366 the UI spec, when the user tries to enter more than the max number of characters.
3368 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3370 * src/maemo/easysetup/modest-easysetup-wizard.c:
3371 (create_page_user_details), (create_page_custom_incoming),
3372 (create_page_custom_outgoing):
3373 * src/maemo/modest-account-settings-dialog.c:
3374 (create_page_user_details), (create_page_incoming),
3375 (create_page_outgoing):
3376 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3377 (modest_connection_specific_smtp_edit_window_init):
3378 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3379 not appropriate. Bad Maemo-specific defaults!.
3381 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3383 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3384 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3385 (modest_signature_editor_dialog_set_settings):
3386 Disable the label and textview when the checkbox is disabled, and use the
3387 specified (UI spec) default signature text.
3389 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3392 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3394 * src/modest-defs.h:
3395 * src/modest-account-mgr-helpers.h:
3396 * src/modest-account-mgr-helpers.c:
3397 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3399 * src/maemo/Makefile.am:
3400 * src/maemo/modest-signature-editor-dialog.c:
3401 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3404 * src/maemo/modest-account-settings-dialog.h:
3405 * src/maemo/modest-account-settings-dialog.c:
3406 (modest_account_settings_dialog_finalize), (on_button_signature),
3407 (save_configuration): Use the new dialog when the Edit button is pressed, and
3408 save the changes if necessary, as per the UI spec.
3410 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/Makefile.am:
3413 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3414 based on maemo-develoers email from Dirk.
3416 * src/maemo/easysetup/modest-easysetup-wizard.c:
3417 (create_page_welcome), (create_page_account_details),
3418 (create_page_user_details), (create_page_complete_easysetup),
3419 (create_page_custom_incoming), (create_page_custom_outgoing),
3420 (create_page_complete_custom),
3421 (modest_easysetup_wizard_dialog_init):
3422 * src/maemo/modest-account-settings-dialog.c:
3423 (create_page_account_details), (create_page_user_details),
3424 (create_page_incoming), (create_page_outgoing),
3425 (modest_account_settings_dialog_init):
3426 * src/maemo/modest-connection-specific-smtp-window.c:
3427 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3429 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/easysetup/modest-easysetup-wizard.c:
3432 (create_page_account_details), (create_page_custom_outgoing),
3433 (create_page_complete_custom):
3434 * src/maemo/modest-account-settings-dialog.c:
3435 (create_page_user_details), (create_page_incoming),
3436 (create_page_outgoing):
3437 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3438 (modest_connection_specific_smtp_edit_window_init):
3439 Use the correct (UI spec) port min/max, and use horizontal separators,
3442 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3444 * src/maemo/easysetup/modest-easysetup-wizard.c:
3445 (set_default_custom_servernames):
3446 * src/maemo/modest-account-settings-dialog.c:
3447 (create_page_incoming), (on_combo_outgoing_security_changed),
3448 (on_combo_incoming_security_changed), (create_page_outgoing),
3449 (modest_account_settings_dialog_set_account_name),
3450 (save_configuration):
3451 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3452 (on_combo_security_changed),
3453 (modest_connection_specific_smtp_edit_window_init),
3454 (modest_connection_specific_smtp_edit_window_set_connection),
3455 (modest_connection_specific_smtp_edit_window_get_settings):
3456 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3459 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/easysetup/modest-easysetup-wizard.c:
3463 (create_page_custom_outgoing), (create_page_complete_custom):
3464 * src/maemo/modest-account-settings-dialog.c:
3465 (create_page_user_details), (create_page_outgoing):
3466 * src/maemo/modest-account-view-window.c: (button_box_new):
3467 Use changed logical IDs as per the most recent UI spec:
3468 mcen_bd_emailsetup_edit -> mcen_bd_edit
3469 mcen_bd_emailsetup_delete -> mcen_bd_delete
3470 mcen_bd_emailsetup_close -> mcen_bd_close
3472 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3476 * src/dbus_api/Makefile.am:
3477 * src/dbus_api/modest-dbus-callbacks.c:
3478 * src/dbus_api/modest-dbus-callbacks.h:
3479 * src/maemo/modest-platform.c: (modest_platform_init):
3480 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3482 * tests/Makefile.am:
3483 * tests/dbus_api/Makefile.am:
3484 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3486 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3488 * src/maemo/modest-account-settings-dialog.c:
3489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3490 Removed unnecessary includes.
3492 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3494 * src/maemo/easysetup/modest-easysetup-wizard.c:
3495 * src/maemo/modest-account-settings-dialog.c:
3496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3497 * src/widgets/Makefile.am:
3498 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3499 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3500 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3501 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3502 * src/widgets/modest-secureauth-combo-box.c:
3503 * src/widgets/modest-secureauth-combo-box.h:
3504 * src/widgets/modest-serversecurity-combo-box.c:
3505 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3506 made the GObject names more consistent with the rest of the Modest code.
3508 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/easysetup/Makefile.am:
3511 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3512 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3513 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3514 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3515 * src/maemo/easysetup/modest-easysetup-wizard.c:
3516 * src/maemo/easysetup/modest-validating-entry.c:
3517 * src/maemo/easysetup/modest-validating-entry.h:
3518 * src/maemo/modest-account-settings-dialog.c:
3519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3520 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3521 widgets/ because they are used outside of easysetup too. After checking in,
3522 svn will allow me to rename them too.
3524 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3526 * src/gnome/modest-msg-edit-window.c:
3527 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3528 linker error, to fix the build on the GNOME platform.
3529 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3530 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3531 ifdefed out to avoid a warning.
3533 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3535 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3536 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3537 some alternative for GTK+ 2.6.
3539 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3541 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3543 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3544 specified for EmailAccountsDialog in UI spec.
3546 * src/maemo/easysetup/modest-easysetup-wizard.c:
3547 * src/maemo/easysetup/modest-easysetup-wizard.h:
3548 * src/maemo/modest-account-settings-dialog.c:
3549 * src/maemo/modest-account-settings-dialog.h:
3550 Reuse a member window widget for the connection-specific SMTP server accounts,
3551 so we can tell it to create/save the accounts only if we actually save changes.
3553 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3554 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3555 (modest_connection_specific_smtp_edit_window_get_settings):
3556 Return a struct instance for temporarily remembering the entered data.
3558 * src/maemo/modest-connection-specific-smtp-window.h:
3559 * src/maemo/modest-connection-specific-smtp-window.c:
3560 (modest_connection_specific_smtp_window_finalize),
3561 (modest_connection_specific_smtp_window_fill_with_connections),
3563 (modest_connection_specific_smtp_window_save_server_accounts),
3564 (update_model_server_names): Do not actually save data until asked,
3565 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3567 (on_selection_changed),
3568 (modest_connection_specific_smtp_window_init): Disable the edit
3569 button when nothing is selected.
3571 * src/modest-account-mgr-helpers.c:
3572 * src/modest-account-mgr-helpers.h:
3573 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3576 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3578 * src/modest-account-mgr-helpers.h:
3579 * src/modest-account-mgr-helpers.c:
3580 (modest_account_mgr_get_unused_account_name),
3581 (modest_account_mgr_get_unused_account_display_name): Added these
3582 utility functions, to avoid code duplication.
3584 * src/maemo/easysetup/modest-easysetup-wizard.c:
3585 (create_page_account_details), (create_account):
3586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3587 (on_combo_security_changed),
3588 (modest_connection_specific_smtp_edit_window_init),
3589 (modest_connection_specific_smtp_edit_window_save_settings):
3590 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3591 * src/maemo/modest-connection-specific-smtp-window.c:
3592 (modest_connection_specific_smtp_window_finalize),
3593 (modest_connection_specific_smtp_window_fill_with_connections),
3594 (on_button_edit), (modest_connection_specific_smtp_window_init):
3595 * src/maemo/modest-connection-specific-smtp-window.h:
3596 Implementing saving of connection-specific server accounts.
3598 But I need to refactor this so we can save the data for each
3599 possible connection-specific account and only actually create the server accounts
3600 when the easysetup finished, or the OK button is pressed on the account settings
3603 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3606 (on_combo_security_changed):
3607 (modest_connection_specific_smtp_edit_window_init):
3608 Auto-fill the port number as in the account settings.
3610 (modest_connection_specific_smtp_edit_window_set_connection):
3611 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3612 * src/maemo/modest-connection-specific-smtp-window.c:
3613 (fill_with_connections), (on_button_edit),
3614 (modest_connection_specific_smtp_window_init):
3615 Turn the edit window into a dialog to simplify the code, and
3616 set a WM hint as in a GtkDialog, because only a popup can be on top of
3617 another window in Maemo, and popups usually have no WM decoration.
3619 * src/modest-defs.h:
3620 * src/modest-account-mgr-helpers.c:
3621 (modest_account_mgr_set_connection_specific_smtp),
3622 (modest_account_mgr_remove_connection_specific_smtp),
3623 (modest_account_mgr_get_connection_specific_smtp):
3624 * src/modest-account-mgr-helpers.h: Some functions to write the
3625 connection-specific SMTP server information. Not yet used.
3628 * src/widgets/modest-folder-view.c: (text_cell_data):
3629 Fix a warning about an uninitialized variable.
3630 (on_configuration_key_changed): Put an #ifdef around the use
3631 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3633 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/modest-account-settings-dialog.h:
3636 * src/maemo/modest-account-settings-dialog.c:
3637 Added connect_for_modified() utility function to mark the new modified boolean.
3639 (create_page_account_details), (create_page_user_details),
3640 (create_page_incoming), (create_page_outgoing), (on_response),
3641 (modest_account_settings_dialog_init),
3642 (modest_account_settings_dialog_set_account_name):
3643 Only warn about unsaved changes when there are actually unsaved changes.
3645 * src/modest-account-mgr-helpers.c:
3646 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3647 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3648 to get the data from there in future.
3650 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3652 * src/modest-defs.h:
3654 * src/modest-account-mgr-helpers.h:
3655 * src/modest-account-mgr-helpers.c:
3656 Store the security account setting in a single conf key instead of using
3657 the options list, so that the list is left for just the to-be-removed camel hack,
3658 and because gconf_client_set_list() is failing for some reason.
3660 * src/modest-account-mgr.c:
3661 (modest_account_mgr_add_server_account):
3662 * src/maemo/modest-account-settings-dialog.c:
3663 (modest_account_settings_dialog_set_account_name),
3664 (save_configuration): Use the renamed functions.
3667 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3669 * src/widgets/Makefile.am:
3670 * src/widgets/modest-limit-retrieve-combo-box.c:
3671 * src/widgets/modest-limit-retrieve-combo-box.h:
3672 * src/widgets/modest-retrieve-combo-box.c:
3673 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3674 the account settings dialog.
3676 * src/modest-defs.h:
3677 * src/modest-account-mgr-helpers.h:
3678 * src/modest-account-mgr-helpers.c:
3679 (modest_server_account_get_option_secure_auth),
3680 (modest_server_account_set_option_secure_auth):
3681 * src/modest-account-mgr.c:
3682 (modest_account_mgr_add_server_account):
3683 Use the existing AUTH_MECH conf key for the secure-auth setting,
3684 instead of putting it in the list options, because this was actually used already.
3686 * src/maemo/modest-account-settings-dialog.c:
3687 (create_page_account_details),
3688 (modest_account_settings_dialog_set_account_name),
3689 (save_configuration):
3690 * src/maemo/modest-account-settings-dialog.h:
3691 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3692 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3694 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3696 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3697 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3698 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3700 * src/modest-defs.h:
3701 * src/maemo/modest-account-settings-dialog.c:
3702 (create_page_incoming), (on_combo_outgoing_security_changed),
3703 (on_combo_incoming_security_changed), (create_page_outgoing),
3704 (modest_account_settings_dialog_set_account_name),
3705 (save_configuration): Load/Save the port number, and change it when the
3706 security combo changes, to suitable defaults.
3708 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3710 * src/modest-account-mgr.c:
3711 (modest_account_mgr_add_server_account): Set the security and secure-auth
3712 options, and add a comment saying that the other camel-specific options should be
3715 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3717 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3719 * src/modest-tny-account-store.c: (account_list_free),
3720 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3721 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3724 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3726 * src/modest-protocol-info.c:
3727 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3728 is required by our UI spec. Maybe something in our implementation will use this eventually.
3729 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3730 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3731 instead of the previous 0 placeholder.
3733 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3734 secure-auth settings.
3735 * src/modest-account-mgr-helpers.h:
3736 * src/modest-account-mgr-helpers.c:
3737 (modest_server_account_data_get_option_secure_auth),
3738 (modest_server_account_set_option_secure_auth),
3739 (modest_server_account_data_get_option_security),
3740 (modest_server_account_set_option_security): Added this API for getting and setting the security
3741 and secure-auth settings.
3743 * src/maemo/modest-account-settings-dialog.h:
3744 * src/maemo/modest-account-settings-dialog.c:
3745 (modest_account_settings_dialog_finalize), (check_data),
3746 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3747 about changing titles.
3748 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3749 (save_configuration): Save the security and secure-auth settings.
3751 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3752 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3754 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3756 * src/modest-defs.h:
3757 * src/modest-account-mgr.c:
3758 (modest_account_mgr_add_server_account):
3759 Added and used defines for the options key and value pair strings,
3760 that are used so far, though they do not seem to correspond to anything in our
3761 UI specs or ModestProtocol enum.
3763 * src/modest-account-mgr-helpers.h:
3764 * src/modest-account-mgr-helpers.c:
3765 (compare_option_strings_for_name),
3766 (modest_server_account_data_get_option_value),
3767 (modest_server_account_data_get_option_bool),
3768 (modest_account_mgr_get_server_account_option):
3769 Added helper functions for parsing the options GSList.
3771 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3773 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3774 display name is based on the supplied account name.
3775 * src/modest-account-mgr.c:
3776 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3777 with an inefficient, but good-enough, implementation.
3779 * src/maemo/easysetup/modest-easysetup-wizard.c:
3780 (create_page_account_details), (on_before_next), (create_account):
3781 Check for existing display names rather than (non-user-visible) account names, and just
3782 create and set a unique account name at the end.
3784 * src/maemo/modest-account-settings-dialog.c:
3785 (modest_account_settings_dialog_init),
3786 (modest_account_settings_dialog_set_account_name),
3787 (create_page_incoming): Show the display name, instead of the account name.
3788 (on_response): Do some (not all) extra checks, as in the UI spec.
3789 (save_configuration): Save the display name if it was changed.
3791 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3793 * po/en_GB.po: Added needed logical ID and translation.
3794 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3795 (init_view): Made the is-default column clicking work.
3797 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3800 * src/maemo/easysetup/Makefile.am:
3801 * src/maemo/easysetup/modest-easysetup-wizard.c:
3802 (modest_easysetup_wizard_dialog_init):
3803 * src/maemo/easysetup/provider-data-test.keyfile:
3804 * src/maemo/easysetup/provider-data.keyfile:
3805 Moved the provider data file to the new modest-providers-data package and used it from there.
3807 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3809 * src/modest-local-folder-info.c:
3810 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3811 N_() was already used on the static strings, but this just marks it for translation without
3812 using the translation.
3814 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/modest-account-settings-dialog.c:
3817 (create_page_incoming),
3818 (modest_account_settings_dialog_set_account_name):
3819 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3820 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3821 I will do this if nobody else gets there first.
3823 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3825 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3826 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3827 save the security stuff.
3829 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3831 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3832 Set the email address and user fullname, which I now see must be
3835 * src/maemo/modest-account-settings-dialog.h:
3836 * src/maemo/modest-account-settings-dialog.c:
3838 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3839 leave-on-server and authentication.
3840 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3843 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3846 * src/maemo/modest-account-settings-dialog.c:
3847 * src/maemo/modest-account-settings-dialog.h:
3848 Most (but not all) of the widgets are now present as specified by the UI spec.
3849 No changes are yet saved, and some details are not properly shown yet.
3851 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3853 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3855 * src/maemo/Makefile.am:
3856 * src/maemo/modest-account-settings-dialog.c:
3857 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3858 an existing account. Doesn't do much yet.
3860 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3861 Open the accounts settings dialog when Edit is clicked.
3863 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3865 * src/maemo/easysetup/Makefile.am:
3866 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3868 * src/maemo/easysetup/modest-easysetup-wizard.c:
3869 (modest_easysetup_wizard_dialog_init):
3870 Try to get the source directory from the build system,
3871 instead of hard-coding "./" into the source code, when opening our local
3872 copies of the configuration files.
3873 But this still fails when opening the wizard from the Accounts window,
3874 maybe because the working directory seems to change at runtime.
3875 So the wizard will fail the second time unless you copy the files into their
3876 proper locations - see the stdout warnings for the paths.
3878 (create_page_account_details),(on_before_next):
3879 Check for existing non-server accounts instead of server accounts,
3880 so the default account name is useful again, and to prevent trying to
3883 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3884 Show the wizard when New is clicked.
3886 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3887 (init_view): Show the column headers, and show the columns that are
3888 specified in the UI specs. However, something in Maemo's GTK+ prevents
3889 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3890 change the default account. This is despite unsetting the special properties.
3892 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3894 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3896 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3897 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3898 to make that clearer.
3899 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3901 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3903 * src/maemo/modest-account-view-window.c:
3904 (modest_account_view_window_init),
3905 (modest_account_view_window_new):
3906 Use the same buttons as specified in the
3907 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3908 the existing widgets, which never had a chance of working.
3909 Put the ModestAccountView treeview in a scrolled window.
3910 Do not repeat the initialization in both _init() and _new().
3912 * src/widgets/modest-account-view.c: (update_account_view):
3913 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3914 this widget and window shows no accounts.
3916 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3918 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3920 * src/maemo/easysetup/modest-easysetup-wizard.c:
3921 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3922 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3923 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3926 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3927 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3928 accounts exist yet, as in the UI spec.
3930 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3932 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3934 * src/maemo/Makefile.am:
3935 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3936 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3937 New window for editing connection-specific smtp details.
3938 Not fully implemented.
3940 * src/maemo/modest-connection-specific-smtp-window.c:
3941 (modest_connection_specific_smtp_window_finalize) :
3942 unref the tree model.
3943 (on_button_edit): Show the edit window.
3945 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3947 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3950 * src/maemo/Makefile.am:
3951 * src/maemo/modest-connection-specific-smtp-window.c:
3952 * src/maemo/modest-connection-specific-smtp-window.h:
3953 New window for showing the list of connections, for connection-specific
3954 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3955 * src/maemo/easysetup/modest-easysetup-wizard.c:
3956 (create_page_custom_outgoing): Show the new window when the button is clicked.
3958 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3960 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3961 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3962 * src/maemo/modest-msg-edit-window.c:
3963 (modest_msg_edit_window_insert_image):
3964 * src/modest-conf.c: (modest_conf_key_escape):
3965 * src/modest-mail-operation.c:
3966 (modest_mail_operation_send_new_mail):
3967 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3968 (modest_ui_actions_on_new_account):
3969 * src/widgets/modest-attachment-view.c: (update_filename_request):
3970 * src/widgets/modest-mail-header-view.c:
3971 Corrected warnings that were breaking the build, by commenting out unused variables,
3972 and a function, and by including a header.
3974 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3976 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3977 so we can #ifdef around platform-specific code when necessary.
3978 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3979 to allow this to build for the GNOME platform too.
3981 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3983 * src/maemo/easysetup/modest-easysetup-wizard.c:
3984 Added util_increment_name() and used it in create_page_account_details()
3985 to make sure that the default account name is always a new name.
3987 (modest_easysetup_wizard_dialog_init),
3988 (set_default_custom_servernames): Some minor memory management fixes.
3990 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3994 * src/modest-runtime.c: (init_i18n): Restored the translation
3995 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3996 are defined in config.h, and the translations are installed.
3998 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3999 is defined for translation.
4001 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4003 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4005 * src/maemo/easysetup/modest-easysetup-wizard.c:
4006 (modest_easysetup_wizard_dialog_init):
4007 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4008 Use realistic paths (though they should use $prefix generically) to the
4009 mcc_mapping and provider-data.keyfile files which might work when they
4010 are installed by the future version of the operator-wizard package,
4011 and then fallback to paths in our source code, with an explanatory
4014 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4018 * src/maemo/Makefile.am:
4019 * src/maemo/easysetup/: Added files from the previously-exernal
4020 osso-modest-easysetup.
4021 * src/maemo/modest-main-window-ui.h:
4022 * src/modest-ui-actions.c:
4023 * src/modest-ui-actions.h:
4024 Added modest_ui_actions_on_new_account() as a signal handler for the
4025 New Account menu item. It shows the easysetup wizard.
4026 * po/en_GB.po: Added additional needed logical IDs and translations.