git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/dbus_api/modest-dbus-callbacks.c:
   4         (modest_osso_cb_hw_state_handler):
   5         * src/dbus_api/modest-dbus-callbacks.h:
   6         * src/maemo/modest-platform.c: (modest_platform_init):
   7         Registered (empty) callbacks for the osso hardware state D-Bus signals,
   8         in case this has some effect on the ability for Maemo to ping the
   9         application.
  10
  11 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
  12
  13         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
  14         Comment out an if() that checks a gchar for < 0, causing a build-breaking
  15         warning. It is probably a logic error, but I need to fix the build.
  16
  17 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
  18
  19         * src/modest-account-mgr.h:
  20         * src/modest-account-mgr.c:
  21         (modest_account_mgr_account_names): Add a gboolean enabled_only
  22         parameter, so we can get lists of onlt the enabled accounts.
  23
  24         (modest_account_mgr_add_account),,
  25         (modest_account_mgr_account_with_display_name_exists):
  26         * src/maemo/modest-msg-edit-window.c: (get_transports):
  27         * src/modest-account-mgr-helpers.c:
  28         (modest_account_mgr_set_first_account_as_default):
  29         * src/modest-init.c: (init_default_account_maybe):
  30         * src/modest-tny-account-store.c: (get_accounts):
  31         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
  32         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
  33         * tests/check_account-mgr.c: (START_TEST):
  34         Provide the extra parameter, as appropriate.
  35
  36         * src/widgets/modest-account-view.c: (update_account_view):
  37         Do not show disabled accounts (meaning that there is no way to
  38         enable/disable accounts in the UI (the feature is not in our UI
  39         specification), so we can use this internally only to mark unfinished
  40         or temporary account data.
  41
  42         * src/maemo/easysetup/modest-easysetup-wizard.c:
  43         (create_account): Add boolean enable parameter, so we can specify FALSE
  44         to create the temporary account.
  45         (on_button_edit_advanced_settings): Create the temporary account as disabled.
  46         (on_before_next): When finishing, when there is a temporary account, just
  47         set it as enabled.
  48         Also, use a timeout to delay the showing of the dialog until gconf is likely
  49         to return correct information, due to a maemo gconf bug that is fixed in
  50         osso 1.1, but not yet in Bora.
  51         However, the dialog stays on screen after it is destroyed.
  52
  53         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
  54         for invalid data when cancelling. Use a hildon note instead of a dialog
  55         to complain about invalid data. Do not show the account-saved note if the
  56         account is disabled (a temporary account that will not really be saved for use
  57         until later.)
  58
  59 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  60
  61         * src/modest-account-mgr-helpers.h:
  62         * src/modest-account-mgr-helpers.c:
  63         Added modest_account_mgr_unset_default_account(),
  64         Added modest_account_mgr_set_first_account_as_default().
  65
  66         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
  67         If it was the default account, unset the default account name.
  68
  69         * src/maemo/modest-account-view-window.c:
  70         (on_delete_button_clicked): If it was the default account,
  71         set the first remaining account as the default instead.
  72
  73         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
  74         a NULL account or a NULL default account, to prevent a crash. This should
  75         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
  76
  77
  78 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  79
  80         * src/widgets/modest-recpt-editor.c:
  81         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
  82         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
  83         TODO comment for this. This fixes the build.
  84
  85         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
  86         be the best place for it. This will in future update all auto-update accounts,
  87         rather than just the current/default account, when that gconf key exists.
  88         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
  89         if there are no accounts, before calling do_send_receive().
  90         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
  91
  92         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
  93         * src/maemo/modest-main-window-ui.h:
  94         * src/maemo/modest-main-window.c: (on_connection_changed),
  95         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
  96         directly, becaue the signal handler does more.
  97
  98 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  99
 100         * src/modest-account-mgr-helpers.c:
 101         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 102         for the case that the account does not exist.
 103
 104         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 105         (equivalent to the modest account name) rather than the tinymail account name
 106         (equivalent to the modest account title - human readable) to get the account data.
 107         Check for null account data to prevent the crash, and add a TODO comment saying that
 108         this needs fixing because it is using the server account name instead of the account name.
 109
 110 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 111
 112         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 113         * src/maemo/modest-account-settings-dialog.c: (show_error),
 114         (show_ok):
 115         Use hildon_note_new_information() for informative and error messages,
 116         which seems to be expected for Maemo applications (no documentation that I know of
 117         says this). I am surprised that there is no distinction between info and error
 118         dialogs.
 119
 120 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 121
 122         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 123         it is easy to find where this is used.
 124
 125         * src/maemo/easysetup/modest-easysetup-wizard.c:
 126         (create_page_welcome), (create_page_account_details),
 127         (create_page_user_details), (create_page_complete_easysetup),
 128         (create_page_custom_incoming), (create_page_custom_outgoing),
 129         (create_page_complete_custom):
 130         * src/maemo/modest-account-settings-dialog.c:
 131         (create_page_account_details), (create_page_user_details),
 132         (create_page_incoming), (create_page_outgoing):
 133         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 134         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 135         (modest_connection_specific_smtp_edit_window_init):
 136         * src/maemo/modest-connection-specific-smtp-window.c:
 137         (modest_connection_specific_smtp_window_init):
 138         * src/maemo/modest-signature-editor-dialog.c:
 139         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 140         and scrolling policy as per the Email Application Layout Guide, if I have
 141         understood it.
 142
 143 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 144
 145         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 146         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 147         which were empty, because these vfuncs have been removed from TnyAccountStore.
 148         This fixes the build.
 149
 150 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 151
 152         * src/maemo/modest-main-window.c:
 153         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 154         showing/hiding it. Added TODO because it probably should not be NULL.
 155         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 156         because unnecessary g_warnings() make degugging difficult.
 157
 158 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 159
 160         * src/maemo/modest-msg-edit-window.c:
 161         (modest_msg_edit_window_select_color),
 162         (modest_msg_edit_window_select_background_color): 2 const corrections and
 163         moving 2 #endifs before closing brackets, to fix the build.
 164
 165 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 166
 167         * src/maemo/easysetup/modest-easysetup-wizard.h:
 168         * src/maemo/easysetup/modest-easysetup-wizard.c:
 169         (modest_easysetup_wizard_dialog_finalize),
 170         (on_button_edit_advanced_settings), (create_page_complete_custom),
 171         (on_response), (create_account):
 172         Implement the Advanced Settings edit button, by saving the account information,
 173         for the Advanded Settings dialog to use directly from gconf, and removing it
 174         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 175         Bug #5533 in the projects.maemo.org bugzilla.
 176
 177 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 178
 179         * src/maemo/modest-msg-view-window.c:
 180         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 181         when opening a message window.
 182
 183 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/maemo/easysetup/modest-easysetup-wizard.c:
 186         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 187         match the UI spec.
 188
 189         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 190         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 191         gconf settings. I probably added more checks than necessary, but that is safer.
 192
 193         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 194         variable to fix the build, but this seems to be used when it is still NULL.
 195
 196 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 197
 198         * src/modest-platform.h:
 199         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 200         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 201         * src/modest-main.c: Implement this function so we can avoid using
 202         maemo-specific API from cross-platform code.
 203         (main):
 204         * src/modest-tny-account-store.c:
 205         (get_smtp_specific_transport_account_for_open_connection):
 206         * src/modest-ui-actions.c: (check_for_connection),
 207         (modest_ui_actions_on_item_not_found):
 208         Use modest_platform_connect_and_wait() and put #idefs around other
 209         maemo-specific code, because only maemo currently has a way to
 210         identify connection names.
 211
 212 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 213
 214         * src/modest-tny-account-store.h:
 215         * src/modest-tny-account-store.c:
 216         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 217         the connection-specific SMTP server settings in the configuration.
 218
 219         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 220         (on_idle_mail_to):
 221         * src/maemo/modest-main-window.c: (on_connection_changed),
 222         (connect_signals):
 223         * src/modest-main.c: (main), (start_ui), (send_mail):
 224         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 225         that is what is intended.
 226
 227         * src/modest-ui-actions.c: (action_send), (action_receive),
 228         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 229         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 230         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 231         SMTP server is used when it is specified.
 232
 233         (modest_ui_actions_on_send_receive):
 234         Check that a connection is open before proceeding.
 235         Receive and then send, instead of vice-versa, as per the specification.
 236
 237 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 238
 239         * src/modest-mail-operation.c:
 240         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 241         though I guess it should be something other than NULL.
 242
 243 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 244
 245         * src/maemo/easysetup/modest-easysetup-wizard.c:
 246         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 247         combo twice, to avoid an g_warning and to make it visible again.
 248         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 249         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 250         (already intended) dereference when detaching, because we then recreate the menu.
 251         But I am not sure why the warning was happening, and it is possible that this is a memory
 252         leak.
 253
 254 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 255
 256         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 257         and uri_parse_mailto() utility functions.
 258         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 259         the mailto URI.
 260         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 261
 262 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/dbus_api/modest-dbus-api.h:
 265         * src/dbus_api/modest-dbus-callbacks.c:
 266         Use an idle callback to execute the modest code in the application's own thread.
 267         Remove the helloworld example method.
 268         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 269         parsed, and the open-message method is not implemented because this is not yet implemented in
 270         modest itself.
 271         * libmodest-dbus-client/libmodest-dbus-client.c:
 272         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 273         (libmodest_dbus_client_open_message):
 274         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 275
 276         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 277         body without crashing.
 278
 279         * tests/dbus_api/Makefile.am:
 280         * tests/dbus_api/test_mail_to.c:
 281         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 282
 283 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 284
 285         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 286         Added file to fix the build. Sorry.
 287
 288         * src/dbus_api/Makefile.am:
 289         * src/dbus_api/modest-dbus-api.h:
 290         * src/dbus_api/modest-dbus-callbacks.h:
 291         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 292         (modest_dbus_req_handler):
 293         Put constants in a separate header so it can be reused by the
 294         client library, without duplication
 295
 296         * libmodest-dbus-client/Makefile.am:
 297         * libmodest-dbus-client/libmodest-dbus-client.c:
 298         (libmodest_dbus_client_call_helloworld),
 299         (libmodfest_dbus_client_send_mail),
 300         (libmodfest_dbus_client_mailto),
 301         (libmodfest_dbus_client_open_message):
 302         * libmodest-dbus-client/libmodest-dbus-client.h:
 303         (Partly) Implement a send_mail D-Bus method.
 304
 305         * tests/dbus_api/Makefile.am:
 306         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 307         the send_email D-Bus method.
 308
 309 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 310
 311         * Makefile.am:
 312         * configure.ac:
 313         * libmodest-dbus-client/Makefile.am:
 314         * libmodest-dbus-client/libmodest-dbus-client.c:
 315         * libmodest-dbus-client/libmodest-dbus-client.h:
 316         * tests/dbus_api/Makefile.am:
 317         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 318         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 319
 320 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 321
 322         * src/maemo/easysetup/modest-easysetup-wizard.c:
 323         (create_page_account_details):
 324         * src/maemo/modest-account-settings-dialog.c:
 325         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 326         widgets, because this might not be the default in future versions of the Maemo GTK+.
 327         However, I can not not get capitalization to work even in a simple test case.
 328
 329 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 330
 331         * src/maemo/easysetup/modest-easysetup-wizard.c:
 332         (create_page_custom_incoming), (create_page_custom_outgoing):
 333         * src/maemo/modest-account-settings-dialog.c:
 334         (create_page_account_details), (create_page_incoming),
 335         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 336         instead of using gtk_check_button_with_label(), so they are aligned like the other
 337         widgets, as per the UI spec.
 338
 339 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 340
 341         * src/maemo/easysetup/modest-easysetup-wizard.c:
 342         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 343         * src/widgets/modest-validating-entry.c:
 344         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 345         Modest prefix instead of an EasySetup prefix.
 346
 347 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 348
 349         * src/widgets/modest-validating-entry.h:
 350         * src/widgets/modest-validating-entry.c: (on_insert_text),
 351         Added easysetup_validating_entry_set_max_func(), used to set a callback
 352         to call when the max number of characters is reached. GtkEntry has a max-length
 353         already but is silent about it.
 354
 355         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 356         (create_page_account_details), (create_page_user_details),
 357         (create_account):
 358         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 359         (create_page_account_details), (create_page_user_details),
 360         (create_page_outgoing):
 361         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 362         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 363         the UI spec, when the user tries to enter more than the max number of characters.
 364
 365 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 366
 367         * src/maemo/easysetup/modest-easysetup-wizard.c:
 368         (create_page_user_details), (create_page_custom_incoming),
 369         (create_page_custom_outgoing):
 370         * src/maemo/modest-account-settings-dialog.c:
 371         (create_page_user_details), (create_page_incoming),
 372         (create_page_outgoing):
 373         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 374         (modest_connection_specific_smtp_edit_window_init):
 375         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 376         not appropriate. Bad Maemo-specific defaults!.
 377
 378 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 379
 380         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 381         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 382         (modest_signature_editor_dialog_set_settings):
 383         Disable the label and textview when the checkbox is disabled, and use the
 384         specified (UI spec) default signature text.
 385
 386 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 387
 388         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 389         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 390
 391         * src/modest-defs.h:
 392         * src/modest-account-mgr-helpers.h:
 393         * src/modest-account-mgr-helpers.c:
 394         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 395
 396         * src/maemo/Makefile.am:
 397         * src/maemo/modest-signature-editor-dialog.c:
 398         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 399         as per the UI spec.
 400
 401         * src/maemo/modest-account-settings-dialog.h:
 402         * src/maemo/modest-account-settings-dialog.c:
 403         (modest_account_settings_dialog_finalize), (on_button_signature),
 404         (save_configuration): Use the new dialog when the Edit button is pressed, and
 405         save the changes if necessary, as per the UI spec.
 406
 407 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 408
 409         * src/maemo/Makefile.am:
 410         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 411         based on maemo-develoers email from Dirk.
 412
 413         * src/maemo/easysetup/modest-easysetup-wizard.c:
 414         (create_page_welcome), (create_page_account_details),
 415         (create_page_user_details), (create_page_complete_easysetup),
 416         (create_page_custom_incoming), (create_page_custom_outgoing),
 417         (create_page_complete_custom),
 418         (modest_easysetup_wizard_dialog_init):
 419         * src/maemo/modest-account-settings-dialog.c:
 420         (create_page_account_details), (create_page_user_details),
 421         (create_page_incoming), (create_page_outgoing),
 422         (modest_account_settings_dialog_init):
 423         * src/maemo/modest-connection-specific-smtp-window.c:
 424         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 425
 426 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 427
 428         * src/maemo/easysetup/modest-easysetup-wizard.c:
 429         (create_page_account_details), (create_page_custom_outgoing),
 430         (create_page_complete_custom):
 431         * src/maemo/modest-account-settings-dialog.c:
 432         (create_page_user_details), (create_page_incoming),
 433         (create_page_outgoing):
 434         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 435         (modest_connection_specific_smtp_edit_window_init):
 436         Use the correct (UI spec) port min/max, and use horizontal separators,
 437         as per the UI spec.
 438
 439 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 440
 441         * src/maemo/easysetup/modest-easysetup-wizard.c:
 442         (set_default_custom_servernames):
 443         * src/maemo/modest-account-settings-dialog.c:
 444         (create_page_incoming), (on_combo_outgoing_security_changed),
 445         (on_combo_incoming_security_changed), (create_page_outgoing),
 446         (modest_account_settings_dialog_set_account_name),
 447         (save_configuration):
 448         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 449         (on_combo_security_changed),
 450         (modest_connection_specific_smtp_edit_window_init),
 451         (modest_connection_specific_smtp_edit_window_set_connection),
 452         (modest_connection_specific_smtp_edit_window_get_settings):
 453         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 454         as per the UI spec.
 455
 456 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 457
 458         * po/en_GB.po:
 459         * src/maemo/easysetup/modest-easysetup-wizard.c:
 460         (create_page_custom_outgoing), (create_page_complete_custom):
 461         * src/maemo/modest-account-settings-dialog.c:
 462         (create_page_user_details), (create_page_outgoing):
 463         * src/maemo/modest-account-view-window.c: (button_box_new):
 464         Use changed logical IDs as per the most recent UI spec:
 465         mcen_bd_emailsetup_edit -> mcen_bd_edit
 466         mcen_bd_emailsetup_delete -> mcen_bd_delete
 467         mcen_bd_emailsetup_close -> mcen_bd_close
 468
 469 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 470
 471         * configure.ac:
 472         * src/Makefile.am:
 473         * src/dbus_api/Makefile.am:
 474         * src/dbus_api/modest-dbus-callbacks.c:
 475         * src/dbus_api/modest-dbus-callbacks.h:
 476         * src/maemo/modest-platform.c: (modest_platform_init):
 477         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 478         method.
 479         * tests/Makefile.am:
 480         * tests/dbus_api/Makefile.am:
 481         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 482
 483 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 484
 485         * src/maemo/modest-account-settings-dialog.c:
 486         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 487         Removed unnecessary includes.
 488
 489 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 490
 491         * src/maemo/easysetup/modest-easysetup-wizard.c:
 492         * src/maemo/modest-account-settings-dialog.c:
 493         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 494         * src/widgets/Makefile.am:
 495         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 496         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 497         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 498         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 499         * src/widgets/modest-secureauth-combo-box.c:
 500         * src/widgets/modest-secureauth-combo-box.h:
 501         * src/widgets/modest-serversecurity-combo-box.c:
 502         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 503         made the GObject names more consistent with the rest of the Modest code.
 504
 505 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 506
 507         * src/maemo/easysetup/Makefile.am:
 508         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 509         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 510         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 511         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 512         * src/maemo/easysetup/modest-easysetup-wizard.c:
 513         * src/maemo/easysetup/modest-validating-entry.c:
 514         * src/maemo/easysetup/modest-validating-entry.h:
 515         * src/maemo/modest-account-settings-dialog.c:
 516         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 517         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 518         widgets/ because they are used outside of easysetup too. After checking in,
 519         svn will allow me to rename them too.
 520
 521 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 522
 523         * src/gnome/modest-msg-edit-window.c:
 524         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 525         linker error, to fix the build on the GNOME platform.
 526         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 527         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 528         ifdefed out to avoid a warning.
 529
 530 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 531
 532         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 533         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 534         some alternative for GTK+ 2.6.
 535
 536 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 537
 538         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 539
 540         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 541         specified for EmailAccountsDialog in UI spec.
 542
 543         * src/maemo/easysetup/modest-easysetup-wizard.c:
 544         * src/maemo/easysetup/modest-easysetup-wizard.h:
 545         * src/maemo/modest-account-settings-dialog.c:
 546         * src/maemo/modest-account-settings-dialog.h:
 547         Reuse a member window widget for the connection-specific SMTP server accounts,
 548         so we can tell it to create/save the accounts only if we actually save changes.
 549
 550         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 551         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 552         (modest_connection_specific_smtp_edit_window_get_settings):
 553         Return a struct instance for temporarily remembering the entered data.
 554
 555         * src/maemo/modest-connection-specific-smtp-window.h:
 556         * src/maemo/modest-connection-specific-smtp-window.c:
 557         (modest_connection_specific_smtp_window_finalize),
 558         (modest_connection_specific_smtp_window_fill_with_connections),
 559         (on_button_edit),
 560         (modest_connection_specific_smtp_window_save_server_accounts),
 561         (update_model_server_names): Do not actually save data until asked,
 562         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 563
 564         (on_selection_changed),
 565         (modest_connection_specific_smtp_window_init): Disable the edit
 566         button when nothing is selected.
 567
 568         * src/modest-account-mgr-helpers.c:
 569         * src/modest-account-mgr-helpers.h:
 570         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 571         elsewhere.
 572
 573 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 574
 575         * src/modest-account-mgr-helpers.h:
 576         * src/modest-account-mgr-helpers.c:
 577         (modest_account_mgr_get_unused_account_name),
 578         (modest_account_mgr_get_unused_account_display_name): Added these
 579         utility functions, to avoid code duplication.
 580
 581         * src/maemo/easysetup/modest-easysetup-wizard.c:
 582         (create_page_account_details), (create_account):
 583         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 584         (on_combo_security_changed),
 585         (modest_connection_specific_smtp_edit_window_init),
 586         (modest_connection_specific_smtp_edit_window_save_settings):
 587         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 588         * src/maemo/modest-connection-specific-smtp-window.c:
 589         (modest_connection_specific_smtp_window_finalize),
 590         (modest_connection_specific_smtp_window_fill_with_connections),
 591         (on_button_edit), (modest_connection_specific_smtp_window_init):
 592         * src/maemo/modest-connection-specific-smtp-window.h:
 593         Implementing saving of connection-specific server accounts.
 594
 595         But I need to refactor this so we can save the data for each
 596         possible connection-specific account and only actually create the server accounts
 597         when the easysetup finished, or the OK button is pressed on the account settings
 598         dialog.
 599
 600 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 601
 602         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 603         (on_combo_security_changed):
 604         (modest_connection_specific_smtp_edit_window_init):
 605         Auto-fill the port number as in the account settings.
 606
 607         (modest_connection_specific_smtp_edit_window_set_connection):
 608         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 609         * src/maemo/modest-connection-specific-smtp-window.c:
 610         (fill_with_connections), (on_button_edit),
 611         (modest_connection_specific_smtp_window_init):
 612         Turn the edit window into a dialog to simplify the code, and
 613         set a WM hint as in a GtkDialog, because only a popup can be on top of
 614         another window in Maemo, and popups usually have no WM decoration.
 615
 616         * src/modest-defs.h:
 617         * src/modest-account-mgr-helpers.c:
 618         (modest_account_mgr_set_connection_specific_smtp),
 619         (modest_account_mgr_remove_connection_specific_smtp),
 620         (modest_account_mgr_get_connection_specific_smtp):
 621         * src/modest-account-mgr-helpers.h: Some functions to write the
 622         connection-specific SMTP server information. Not yet used.
 623
 624
 625         * src/widgets/modest-folder-view.c: (text_cell_data):
 626         Fix a warning about an uninitialized variable.
 627         (on_configuration_key_changed): Put an #ifdef around the use
 628         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 629
 630 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 631
 632         * src/maemo/modest-account-settings-dialog.h:
 633         * src/maemo/modest-account-settings-dialog.c:
 634         Added connect_for_modified() utility function to mark the new modified boolean.
 635
 636         (create_page_account_details), (create_page_user_details),
 637         (create_page_incoming), (create_page_outgoing), (on_response),
 638         (modest_account_settings_dialog_init),
 639         (modest_account_settings_dialog_set_account_name):
 640         Only warn about unsaved changes when there are actually unsaved changes.
 641
 642         * src/modest-account-mgr-helpers.c:
 643         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 644         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 645         to get the data from there in future.
 646
 647 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * src/modest-defs.h:
 650
 651         * src/modest-account-mgr-helpers.h:
 652         * src/modest-account-mgr-helpers.c:
 653         Store the security account setting in a single conf key instead of using
 654         the options list, so that the list is left for just the to-be-removed camel hack,
 655         and because gconf_client_set_list() is failing for some reason.
 656
 657         * src/modest-account-mgr.c:
 658         (modest_account_mgr_add_server_account):
 659         * src/maemo/modest-account-settings-dialog.c:
 660         (modest_account_settings_dialog_set_account_name),
 661         (save_configuration): Use the renamed functions.
 662
 663
 664 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 665
 666         * src/widgets/Makefile.am:
 667         * src/widgets/modest-limit-retrieve-combo-box.c:
 668         * src/widgets/modest-limit-retrieve-combo-box.h:
 669         * src/widgets/modest-retrieve-combo-box.c:
 670         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 671         the account settings dialog.
 672
 673         * src/modest-defs.h:
 674         * src/modest-account-mgr-helpers.h:
 675         * src/modest-account-mgr-helpers.c:
 676         (modest_server_account_get_option_secure_auth),
 677         (modest_server_account_set_option_secure_auth):
 678         * src/modest-account-mgr.c:
 679         (modest_account_mgr_add_server_account):
 680         Use the existing AUTH_MECH conf key for the secure-auth setting,
 681         instead of putting it in the list options, because this was actually used already.
 682
 683         * src/maemo/modest-account-settings-dialog.c:
 684         (create_page_account_details),
 685         (modest_account_settings_dialog_set_account_name),
 686         (save_configuration):
 687         * src/maemo/modest-account-settings-dialog.h:
 688         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 689         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 690
 691 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 692
 693         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 694         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 695         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 696
 697         * src/modest-defs.h:
 698         * src/maemo/modest-account-settings-dialog.c:
 699         (create_page_incoming), (on_combo_outgoing_security_changed),
 700         (on_combo_incoming_security_changed), (create_page_outgoing),
 701         (modest_account_settings_dialog_set_account_name),
 702         (save_configuration): Load/Save the port number, and change it when the
 703         security combo changes, to suitable defaults.
 704
 705 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 706
 707         * src/modest-account-mgr.c:
 708         (modest_account_mgr_add_server_account): Set the security and secure-auth
 709         options, and add a comment saying that the other camel-specific options should be
 710         removed in future.
 711
 712 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 713
 714         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 715         found by valgrind.
 716         * src/modest-tny-account-store.c: (account_list_free),
 717         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 718         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 719         easy to fix.
 720
 721 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 722
 723         * src/modest-protocol-info.c:
 724         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 725         is required by our UI spec. Maybe something in our implementation will use this eventually.
 726         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 727         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 728         instead of the previous 0 placeholder.
 729
 730         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 731         secure-auth settings.
 732         * src/modest-account-mgr-helpers.h:
 733         * src/modest-account-mgr-helpers.c:
 734         (modest_server_account_data_get_option_secure_auth),
 735         (modest_server_account_set_option_secure_auth),
 736         (modest_server_account_data_get_option_security),
 737         (modest_server_account_set_option_security): Added this API for getting and setting the security
 738         and secure-auth settings.
 739
 740         * src/maemo/modest-account-settings-dialog.h:
 741         * src/maemo/modest-account-settings-dialog.c:
 742         (modest_account_settings_dialog_finalize), (check_data),
 743         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 744         about changing titles.
 745         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 746         (save_configuration): Save the security and secure-auth settings.
 747
 748         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 749         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 750
 751 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 752
 753         * src/modest-defs.h:
 754         * src/modest-account-mgr.c:
 755         (modest_account_mgr_add_server_account):
 756         Added and used defines for the options key and value pair strings,
 757         that are used so far, though they do not seem to correspond to anything in our
 758         UI specs or ModestProtocol enum.
 759
 760         * src/modest-account-mgr-helpers.h:
 761         * src/modest-account-mgr-helpers.c:
 762         (compare_option_strings_for_name),
 763         (modest_server_account_data_get_option_value),
 764         (modest_server_account_data_get_option_bool),
 765         (modest_account_mgr_get_server_account_option):
 766         Added helper functions for parsing the options GSList.
 767
 768 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 769
 770         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 771         display name is based on the supplied account name.
 772         * src/modest-account-mgr.c:
 773         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 774         with an inefficient, but good-enough, implementation.
 775
 776         * src/maemo/easysetup/modest-easysetup-wizard.c:
 777         (create_page_account_details), (on_before_next), (create_account):
 778         Check for existing display names rather than (non-user-visible) account names, and just
 779         create and set a unique account name at the end.
 780
 781         * src/maemo/modest-account-settings-dialog.c:
 782         (modest_account_settings_dialog_init),
 783         (modest_account_settings_dialog_set_account_name),
 784         (create_page_incoming): Show the display name, instead of the account name.
 785         (on_response): Do some (not all) extra checks, as in the UI spec.
 786         (save_configuration): Save the display name if it was changed.
 787
 788 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 789
 790         * po/en_GB.po: Added needed logical ID and translation.
 791         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 792         (init_view): Made the is-default column clicking work.
 793
 794 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 795
 796         * configure.ac:
 797         * src/maemo/easysetup/Makefile.am:
 798         * src/maemo/easysetup/modest-easysetup-wizard.c:
 799         (modest_easysetup_wizard_dialog_init):
 800         * src/maemo/easysetup/provider-data-test.keyfile:
 801         * src/maemo/easysetup/provider-data.keyfile:
 802         Moved the provider data file to the new modest-providers-data package and used it from there.
 803
 804 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 805
 806         * src/modest-local-folder-info.c:
 807         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 808         N_() was already used on the static strings, but this just marks it for translation without
 809         using the translation.
 810
 811 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 812
 813         * src/maemo/modest-account-settings-dialog.c:
 814         (create_page_incoming),
 815         (modest_account_settings_dialog_set_account_name):
 816         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 817         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 818         I will do this if nobody else gets there first.
 819
 820 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 821
 822         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 823         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 824         save the security stuff.
 825
 826 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 827
 828         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 829         Set the email address and user fullname, which I now see must be
 830         done separately.
 831
 832         * src/maemo/modest-account-settings-dialog.h:
 833         * src/maemo/modest-account-settings-dialog.c:
 834          (on_response),
 835         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 836         leave-on-server and authentication.
 837         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 838         how to do the rest.
 839
 840 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 841
 842
 843         * src/maemo/modest-account-settings-dialog.c:
 844         * src/maemo/modest-account-settings-dialog.h:
 845         Most (but not all) of the widgets are now present as specified by the UI spec.
 846         No changes are yet saved, and some details are not properly shown yet.
 847
 848         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 849
 850 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 851
 852         * src/maemo/Makefile.am:
 853         * src/maemo/modest-account-settings-dialog.c:
 854         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 855         an existing account. Doesn't do much yet.
 856
 857         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 858         Open the accounts settings dialog when Edit is clicked.
 859
 860 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 861
 862         * src/maemo/easysetup/Makefile.am:
 863         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 864         (load_from_file):
 865         * src/maemo/easysetup/modest-easysetup-wizard.c:
 866         (modest_easysetup_wizard_dialog_init):
 867         Try to get the source directory from the build system,
 868         instead of hard-coding "./" into the source code, when opening our local
 869         copies of the configuration files.
 870         But this still fails when opening the wizard from the Accounts window,
 871         maybe because the working directory seems to change at runtime.
 872         So the wizard will fail the second time unless you copy the files into their
 873         proper locations - see the stdout warnings for the paths.
 874
 875         (create_page_account_details),(on_before_next):
 876         Check for existing non-server accounts instead of server accounts,
 877         so the default account name is useful again, and to prevent trying to
 878         recreate accounts.
 879
 880         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 881         Show the wizard when New is clicked.
 882
 883         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 884         (init_view): Show the column headers, and show the columns that are
 885         specified in the UI specs. However, something in Maemo's GTK+ prevents
 886         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 887         change the default account. This is despite unsetting the special properties.
 888
 889 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 890
 891         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 892         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 893         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 894         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 895         to make that clearer.
 896         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 897
 898 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 899
 900         * src/maemo/modest-account-view-window.c:
 901         (modest_account_view_window_init),
 902         (modest_account_view_window_new):
 903         Use the same buttons as specified in the
 904         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 905         the existing widgets, which never had a chance of working.
 906         Put the ModestAccountView treeview in a scrolled window.
 907         Do not repeat the initialization in both _init() and _new().
 908
 909         * src/widgets/modest-account-view.c: (update_account_view):
 910         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 911         this widget and window shows no accounts.
 912
 913         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 914
 915 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 916
 917         * src/maemo/easysetup/modest-easysetup-wizard.c:
 918         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 919         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 920         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 921         which seems wrong.
 922
 923         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 924         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 925         accounts exist yet, as in the UI spec.
 926
 927         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 928
 929 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 930
 931         * src/maemo/Makefile.am:
 932         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 933         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 934         New window for editing connection-specific smtp details.
 935         Not fully implemented.
 936
 937         * src/maemo/modest-connection-specific-smtp-window.c:
 938         (modest_connection_specific_smtp_window_finalize) :
 939         unref the tree model.
 940         (on_button_edit): Show the edit window.
 941
 942 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 943
 944         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 945         error for me.
 946
 947         * src/maemo/Makefile.am:
 948         * src/maemo/modest-connection-specific-smtp-window.c:
 949         * src/maemo/modest-connection-specific-smtp-window.h:
 950         New window for showing the list of connections, for connection-specific
 951         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 952         * src/maemo/easysetup/modest-easysetup-wizard.c:
 953         (create_page_custom_outgoing): Show the new window when the button is clicked.
 954
 955 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 956
 957         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 958         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 959         * src/maemo/modest-msg-edit-window.c:
 960         (modest_msg_edit_window_insert_image):
 961         * src/modest-conf.c: (modest_conf_key_escape):
 962         * src/modest-mail-operation.c:
 963         (modest_mail_operation_send_new_mail):
 964         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 965         (modest_ui_actions_on_new_account):
 966         * src/widgets/modest-attachment-view.c: (update_filename_request):
 967         * src/widgets/modest-mail-header-view.c:
 968         Corrected warnings that were breaking the build, by commenting out unused variables,
 969         and a function, and by including a header.
 970
 971 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 972
 973         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 974         so we can #ifdef around platform-specific code when necessary.
 975         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 976         to allow this to build for the GNOME platform too.
 977
 978 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 979
 980         * src/maemo/easysetup/modest-easysetup-wizard.c:
 981         Added util_increment_name() and used it in create_page_account_details()
 982         to make sure that the default account name is always a new name.
 983
 984         (modest_easysetup_wizard_dialog_init),
 985         (set_default_custom_servernames): Some minor memory management fixes.
 986
 987 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 988
 989         * Makefile.am:
 990         * configure.ac:
 991         * src/modest-runtime.c: (init_i18n): Restored the translation
 992         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 993         are defined in config.h, and the translations are installed.
 994
 995         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 996         is defined for translation.
 997
 998 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 999
1000         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1001         (load_from_file):
1002         * src/maemo/easysetup/modest-easysetup-wizard.c:
1003         (modest_easysetup_wizard_dialog_init):
1004         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1005         Use realistic paths (though they should use $prefix generically) to the
1006         mcc_mapping and provider-data.keyfile files which might work when they
1007         are installed by the future version of the operator-wizard package,
1008         and then fallback to paths in our source code, with an explanatory
1009         warning.
1010
1011 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1012
1013         * configure.ac:
1014         * src/Makefile.am:
1015         * src/maemo/Makefile.am:
1016         * src/maemo/easysetup/: Added files from the previously-exernal
1017         osso-modest-easysetup.
1018         * src/maemo/modest-main-window-ui.h:
1019         * src/modest-ui-actions.c:
1020         * src/modest-ui-actions.h:
1021         Added modest_ui_actions_on_new_account() as a signal handler for the
1022         New Account menu item. It shows the easysetup wizard.
1023         * po/en_GB.po: Added additional needed logical IDs and translations.
1024
1025 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1026 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1027