1 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.h:
4 * src/maemo/modest-account-settings-dialog.c:
5 Added connect_for_modified() utility function to mark the new modified boolean.
7 (create_page_account_details), (create_page_user_details),
8 (create_page_incoming), (create_page_outgoing), (on_response),
9 (modest_account_settings_dialog_init),
10 (modest_account_settings_dialog_set_account_name):
11 Only warn about unsaved changes when there are actually unsaved changes.
13 * src/modest-account-mgr-helpers.c:
14 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
15 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
16 to get the data from there in future.
18 2007-04-18 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-account-mgr-helpers.h:
23 * src/modest-account-mgr-helpers.c:
24 Store the security account setting in a single conf key instead of using
25 the options list, so that the list is left for just the to-be-removed camel hack,
26 and because gconf_client_set_list() is failing for some reason.
28 * src/modest-account-mgr.c:
29 (modest_account_mgr_add_server_account):
30 * src/maemo/modest-account-settings-dialog.c:
31 (modest_account_settings_dialog_set_account_name),
32 (save_configuration): Use the renamed functions.
35 2007-04-18 Murray Cumming <murrayc@murrayc.com>
37 * src/widgets/Makefile.am:
38 * src/widgets/modest-limit-retrieve-combo-box.c:
39 * src/widgets/modest-limit-retrieve-combo-box.h:
40 * src/widgets/modest-retrieve-combo-box.c:
41 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
42 the account settings dialog.
45 * src/modest-account-mgr-helpers.h:
46 * src/modest-account-mgr-helpers.c:
47 (modest_server_account_get_option_secure_auth),
48 (modest_server_account_set_option_secure_auth):
49 * src/modest-account-mgr.c:
50 (modest_account_mgr_add_server_account):
51 Use the existing AUTH_MECH conf key for the secure-auth setting,
52 instead of putting it in the list options, because this was actually used already.
54 * src/maemo/modest-account-settings-dialog.c:
55 (create_page_account_details),
56 (modest_account_settings_dialog_set_account_name),
58 * src/maemo/modest-account-settings-dialog.h:
59 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
60 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
62 2007-04-18 Murray Cumming <murrayc@murrayc.com>
64 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
65 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
66 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
69 * src/maemo/modest-account-settings-dialog.c:
70 (create_page_incoming), (on_combo_outgoing_security_changed),
71 (on_combo_incoming_security_changed), (create_page_outgoing),
72 (modest_account_settings_dialog_set_account_name),
73 (save_configuration): Load/Save the port number, and change it when the
74 security combo changes, to suitable defaults.
76 2007-04-17 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-account-mgr.c:
79 (modest_account_mgr_add_server_account): Set the security and secure-auth
80 options, and add a comment saying that the other camel-specific options should be
83 2007-04-17 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
87 * src/modest-tny-account-store.c: (account_list_free),
88 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
89 cursor->data after unreffing it. But there is some strange stuff there so it might not be
92 2007-04-17 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-protocol-info.c:
95 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
96 is required by our UI spec. Maybe something in our implementation will use this eventually.
97 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
98 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
99 instead of the previous 0 placeholder.
101 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
102 secure-auth settings.
103 * src/modest-account-mgr-helpers.h:
104 * src/modest-account-mgr-helpers.c:
105 (modest_server_account_data_get_option_secure_auth),
106 (modest_server_account_set_option_secure_auth),
107 (modest_server_account_data_get_option_security),
108 (modest_server_account_set_option_security): Added this API for getting and setting the security
109 and secure-auth settings.
111 * src/maemo/modest-account-settings-dialog.h:
112 * src/maemo/modest-account-settings-dialog.c:
113 (modest_account_settings_dialog_finalize), (check_data),
114 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
115 about changing titles.
116 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
117 (save_configuration): Save the security and secure-auth settings.
119 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
120 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
122 2007-04-17 Murray Cumming <murrayc@murrayc.com>
125 * src/modest-account-mgr.c:
126 (modest_account_mgr_add_server_account):
127 Added and used defines for the options key and value pair strings,
128 that are used so far, though they do not seem to correspond to anything in our
129 UI specs or ModestProtocol enum.
131 * src/modest-account-mgr-helpers.h:
132 * src/modest-account-mgr-helpers.c:
133 (compare_option_strings_for_name),
134 (modest_server_account_data_get_option_value),
135 (modest_server_account_data_get_option_bool),
136 (modest_account_mgr_get_server_account_option):
137 Added helper functions for parsing the options GSList.
139 2007-04-16 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
142 display name is based on the supplied account name.
143 * src/modest-account-mgr.c:
144 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
145 with an inefficient, but good-enough, implementation.
147 * src/maemo/easysetup/modest-easysetup-wizard.c:
148 (create_page_account_details), (on_before_next), (create_account):
149 Check for existing display names rather than (non-user-visible) account names, and just
150 create and set a unique account name at the end.
152 * src/maemo/modest-account-settings-dialog.c:
153 (modest_account_settings_dialog_init),
154 (modest_account_settings_dialog_set_account_name),
155 (create_page_incoming): Show the display name, instead of the account name.
156 (on_response): Do some (not all) extra checks, as in the UI spec.
157 (save_configuration): Save the display name if it was changed.
159 2007-04-16 Murray Cumming <murrayc@murrayc.com>
161 * po/en_GB.po: Added needed logical ID and translation.
162 * src/widgets/modest-account-view.c: (on_account_default_toggled),
163 (init_view): Made the is-default column clicking work.
165 2007-04-16 Murray Cumming <murrayc@murrayc.com>
168 * src/maemo/easysetup/Makefile.am:
169 * src/maemo/easysetup/modest-easysetup-wizard.c:
170 (modest_easysetup_wizard_dialog_init):
171 * src/maemo/easysetup/provider-data-test.keyfile:
172 * src/maemo/easysetup/provider-data.keyfile:
173 Moved the provider data file to the new modest-providers-data package and used it from there.
175 2007-04-16 Murray Cumming <murrayc@murrayc.com>
177 * src/modest-local-folder-info.c:
178 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
179 N_() was already used on the static strings, but this just marks it for translation without
180 using the translation.
182 2007-04-06 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/modest-account-settings-dialog.c:
185 (create_page_incoming),
186 (modest_account_settings_dialog_set_account_name):
187 Added comments about the need for new API in ModestAccountMgr to handle the authentication
188 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
189 I will do this if nobody else gets there first.
191 2007-04-06 Murray Cumming <murrayc@murrayc.com>
193 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
194 Saved much of the incoming and outgoing data too, though I cannot yet see how to
195 save the security stuff.
197 2007-04-06 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
200 Set the email address and user fullname, which I now see must be
203 * src/maemo/modest-account-settings-dialog.h:
204 * src/maemo/modest-account-settings-dialog.c:
206 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
207 leave-on-server and authentication.
208 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
211 2007-04-06 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/modest-account-settings-dialog.c:
215 * src/maemo/modest-account-settings-dialog.h:
216 Most (but not all) of the widgets are now present as specified by the UI spec.
217 No changes are yet saved, and some details are not properly shown yet.
219 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
221 2007-04-06 Murray Cumming <murrayc@murrayc.com>
223 * src/maemo/Makefile.am:
224 * src/maemo/modest-account-settings-dialog.c:
225 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
226 an existing account. Doesn't do much yet.
228 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
229 Open the accounts settings dialog when Edit is clicked.
231 2007-04-05 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/easysetup/Makefile.am:
234 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
236 * src/maemo/easysetup/modest-easysetup-wizard.c:
237 (modest_easysetup_wizard_dialog_init):
238 Try to get the source directory from the build system,
239 instead of hard-coding "./" into the source code, when opening our local
240 copies of the configuration files.
241 But this still fails when opening the wizard from the Accounts window,
242 maybe because the working directory seems to change at runtime.
243 So the wizard will fail the second time unless you copy the files into their
244 proper locations - see the stdout warnings for the paths.
246 (create_page_account_details),(on_before_next):
247 Check for existing non-server accounts instead of server accounts,
248 so the default account name is useful again, and to prevent trying to
251 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
252 Show the wizard when New is clicked.
254 * src/widgets/modest-account-view.c: (on_account_default_toggled),
255 (init_view): Show the column headers, and show the columns that are
256 specified in the UI specs. However, something in Maemo's GTK+ prevents
257 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
258 change the default account. This is despite unsetting the special properties.
260 2007-04-05 Murray Cumming <murrayc@murrayc.com>
262 * docs/reference/modest-design.sgml: Corrected spelling mistake.
263 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
264 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
265 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
266 to make that clearer.
267 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
269 2007-04-05 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-account-view-window.c:
272 (modest_account_view_window_init),
273 (modest_account_view_window_new):
274 Use the same buttons as specified in the
275 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
276 the existing widgets, which never had a chance of working.
277 Put the ModestAccountView treeview in a scrolled window.
278 Do not repeat the initialization in both _init() and _new().
280 * src/widgets/modest-account-view.c: (update_account_view):
281 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
282 this widget and window shows no accounts.
284 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
286 2007-04-05 Murray Cumming <murrayc@murrayc.com>
288 * src/maemo/easysetup/modest-easysetup-wizard.c:
289 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
290 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
291 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
294 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
295 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
296 accounts exist yet, as in the UI spec.
298 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
300 2007-04-05 Murray Cumming <murrayc@murrayc.com>
302 * src/maemo/Makefile.am:
303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
304 * src/maemo/modest-connection-specific-smtp-edit-window.h:
305 New window for editing connection-specific smtp details.
306 Not fully implemented.
308 * src/maemo/modest-connection-specific-smtp-window.c:
309 (modest_connection_specific_smtp_window_finalize) :
310 unref the tree model.
311 (on_button_edit): Show the edit window.
313 2007-04-05 Murray Cumming <murrayc@murrayc.com>
315 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
318 * src/maemo/Makefile.am:
319 * src/maemo/modest-connection-specific-smtp-window.c:
320 * src/maemo/modest-connection-specific-smtp-window.h:
321 New window for showing the list of connections, for connection-specific
322 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
323 * src/maemo/easysetup/modest-easysetup-wizard.c:
324 (create_page_custom_outgoing): Show the new window when the button is clicked.
326 2007-04-04 Murray Cumming <murrayc@murrayc.com>
328 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
329 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
330 * src/maemo/modest-msg-edit-window.c:
331 (modest_msg_edit_window_insert_image):
332 * src/modest-conf.c: (modest_conf_key_escape):
333 * src/modest-mail-operation.c:
334 (modest_mail_operation_send_new_mail):
335 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
336 (modest_ui_actions_on_new_account):
337 * src/widgets/modest-attachment-view.c: (update_filename_request):
338 * src/widgets/modest-mail-header-view.c:
339 Corrected warnings that were breaking the build, by commenting out unused variables,
340 and a function, and by including a header.
342 2007-04-04 Murray Cumming <murrayc@murrayc.com>
344 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
345 so we can #ifdef around platform-specific code when necessary.
346 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
347 to allow this to build for the GNOME platform too.
349 2007-04-04 Murray Cumming <murrayc@murrayc.com>
351 * src/maemo/easysetup/modest-easysetup-wizard.c:
352 Added util_increment_name() and used it in create_page_account_details()
353 to make sure that the default account name is always a new name.
355 (modest_easysetup_wizard_dialog_init),
356 (set_default_custom_servernames): Some minor memory management fixes.
358 2007-04-04 Murray Cumming <murrayc@murrayc.com>
362 * src/modest-runtime.c: (init_i18n): Restored the translation
363 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
364 are defined in config.h, and the translations are installed.
366 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
367 is defined for translation.
369 2007-04-03 Murray Cumming <murrayc@murrayc.com>
371 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
373 * src/maemo/easysetup/modest-easysetup-wizard.c:
374 (modest_easysetup_wizard_dialog_init):
375 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
376 Use realistic paths (though they should use $prefix generically) to the
377 mcc_mapping and provider-data.keyfile files which might work when they
378 are installed by the future version of the operator-wizard package,
379 and then fallback to paths in our source code, with an explanatory
382 2007-04-03 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/Makefile.am:
387 * src/maemo/easysetup/: Added files from the previously-exernal
388 osso-modest-easysetup.
389 * src/maemo/modest-main-window-ui.h:
390 * src/modest-ui-actions.c:
391 * src/modest-ui-actions.h:
392 Added modest_ui_actions_on_new_account() as a signal handler for the
393 New Account menu item. It shows the easysetup wizard.
394 * po/en_GB.po: Added additional needed logical IDs and translations.
396 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
397 Apparently ChangeLog is not used for some vague Nokia legal reasons.