1 2007-08-13 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-platform.c:
4 (modest_platform_set_update_interval): Handle the new
5 alarmd error to warn when alarmd is not running, as is the case in
6 scratchbox for me now because
7 "Module /usr/lib/alarmd/libretu.so initialization failed"
9 2007-08-13 Murray Cumming <murrayc@murrayc.com>
11 * src/widgets/modest-header-view-render.c:
12 (_modest_header_view_compact_header_cell_data):
13 NULL some strings after freeing them, trying to deal with
14 the double deletion found in projects.maemo.org bug 64183,
15 probably having no effect.
17 2007-08-13 Murray Cumming <murrayc@murrayc.com>
19 * src/maemo/modest-account-settings-dialog.c:
20 (create_page_incoming), (create_page_outgoing): Use a define
21 for the min and max port numbers.
23 (check_hildon_number_editor_and_warn_value_not_in_range),
24 (check_data): Do an extra check for an invalid port number, as needed
25 in projects.maemo.org bug #64275, when the number is cleared, but this
26 does not work due to bugs.maemo.org bug #1806.
28 2007-08-13 Murray Cumming <murrayc@murrayc.com>
30 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
31 Comment out the debug warning about the unexpected D-Bus methods.
32 They are just annoying now.
33 * src/maemo/modest-platform.c:
34 (modest_platform_set_update_interval): Correct the D-Bus path, instead
35 of using a file path, though it did not seem to break things before.
36 It might be needed now:
37 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
38 modest is not already running. This is the behaviour of the old client, and
39 Mox says it is what we should do for modest.
40 This closes projects.maemo.org bug NB#64327.
42 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
44 * src/modest-text-utils.c:
45 Fixed invalid jump due to incorrect string/pointer
47 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
50 2007-08-01 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-account-mgr-helpers.h:
53 * src/modest-account-mgr-helpers.c:
54 Added modest_account_mgr_get_first_account_name(),
55 using code from modest_account_mgr_set_first_account_as_default().
57 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
58 (account_number_changed): Call set_at_least_one_account_visible() so that
59 the first account is visible when first added, without the user having to
61 I do wonder how this worked before.
63 2007-08-01 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-tny-account-store.c: (show_password_warning_only),
66 (show_wrong_password), (request_password_and_wait), (get_password),
67 (modest_tny_account_store_alert): Remove the (incomplete anyway)
68 attempts to show UI only in the main context, which used g_idle_add()
69 and mainloops, because tinymail now guarantees that it only calls these
70 callbacks in the mainloop with the gdk lock. This makes everything much
73 2007-08-01 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
76 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
77 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
78 error dialog, instead of ignoring it.
80 2007-08-01 Murray Cumming <murrayc@murrayc.com>
82 * src/maemo/modest-msg-view-window.c:
83 (modest_msg_view_window_get_header),
84 (modest_msg_view_window_last_message_selected):
85 Added comments to explain the use of priv->header_model.
86 * src/modest-ui-dimming-rules.c:
87 (modest_ui_dimming_rules_on_open_msg),
88 (modest_ui_dimming_rules_on_mark_as_read_msg),
89 (modest_ui_dimming_rules_on_mark_as_unread_msg),
90 (modest_ui_dimming_rules_on_remove_attachments),
91 (_invalid_attach_selected), (_selected_msg_marked_as):
92 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
93 and changed the parameter to a ModestMainWindow to make it clearer that
94 it never uses any other kind of window.
95 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
96 instead of the selected message.
97 I notice that much of the dimming code and the ModestMsgViewWindow code
98 hard-codes the assumption that the viewed message is always selected in
99 the header view. This does not seem wise or simple.
101 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
102 examine the actual message instead of whatever might be selected
103 in the header view. This stops the delete toolbar button and menu item
104 from being dimmed when opening a message view the search UI,
105 partially fixing projects.maemo.org bug NB#63811.
107 However, when actually deleting, I now get this warning:
108 "tny_header_set_flags: This is a header instance for a new message.
109 Only priority and attachment flags are supported"
111 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
113 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
115 Show account wizard if no accounts are defined while sending
116 (automatic sending after the account wizard finished does not
117 work because it takes some time until the account manager
118 synchronizes everything. (projects.maemo.org NB#62792)
120 2007-07-30 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-tny-account-store.c: (on_account_removed),
123 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
124 account is removed from the View menu. We have TnyAccountStore
125 and ModestTnyAccountStore signals that seem very similar, but this
126 seems to work for now.
128 * src/maemo/modest-main-window.c:
129 (on_show_account_action_activated): Prevent dereference
130 of a NULL if the accoutn does not really exist, though that
131 should not happen anymore.
133 This fixes projects.maemo.org bug NB#64606.
135 2007-07-30 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-ui-actions.c: (run_account_setup_wizard),
138 (modest_ui_actions_on_accounts): Revert a change that set these
139 to modal dialogs, freezing the UI when they show secondary dialogs.
140 This fixed projects.maemo.org bug NB#64519.
142 2007-07-27 Murray Cumming <murrayc@murrayc.com>
144 * src/widgets/modest-header-view-render.c:
145 (_modest_header_view_compact_header_cell_data):
146 Some checks and initialization to try to deal with a crash,
147 probably ineffective.
149 2007-07-27 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/modest-maemo-utils.c:
152 (modest_maemo_utils_get_supported_secure_authentication_methods):
153 Make sure that we have a connection, asking the user for one
155 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
156 Check for a connection before showing the wizard, because
157 the wizard needs a connection to check for server capabilities.
159 2007-07-27 Murray Cumming <murrayc@murrayc.com>
161 * src/maemo/modest-account-view-window.c:
162 (on_new_button_clicked): Remember the wizard dialog instance,
163 so we can just present it again if necessary. This prevents
164 multiple windows from appearing if you click again quickly on the
165 New button before the dialog appears, fixing projects.maemo.org
168 2007-07-27 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
171 Offer a connection dialog if there is no connection when
172 starting modest. This should fix projects.maemo.org bug NB#61134.
174 2007-07-27 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
177 Reverted my last commit. I was able to fix the build by doing
178 apt-get install wpeditor0 (replacing other wpeditor packages) and
179 an explicit apt-get install wpeditor-dev to upgrade the -dev
182 2007-07-27 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
185 Commented out the use of wp_text_buffer_replace_image()
186 because it does not exist, to break the build. Added a TODO for it.
188 2007-07-26 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-tny-account-store.c: (recreate_all_accounts):
191 Recreate them even if they were NULL before. I guess something
192 else was already creating them before, or this would never
194 (modest_tny_account_store_get_server_account): Make sure that
195 the tny accounts have been created before trying to find one.
196 This allows libmodest_dbus_client_compose_mail() to work
197 when the UI is not yet visible.
198 This is probably useful in other cases too.
200 (get_password): When the password is wrong after it is entered
201 in the protected password dialog, show an info banner (in an
202 idle handler) before showing the protected password dialog
205 2007-07-26 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-ui-actions.h:
208 * src/modest-ui-actions.c: Added
209 modest_do_refresh_current_folder() containing some code from
210 modest_ui_actions_on_send_receive().
211 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
212 Call modest_do_refresh_current_folder() before refreshing the
213 requested account, as in modest_ui_actions_on_send_receive().
214 This is strange, but seems to be necessary to show new mails.
215 Now new emails are finally visible in the UI when downloaded
216 via the automatic update interval, fixing bug NB#57458.
217 This also works because bug NB#57458 has been fixed somehow.
219 2007-07-26 Murray Cumming <murrayc@murrayc.com>
221 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
222 printf more details when we get unhandled D-Bus methods, because
225 * src/modest-mail-operation.c: (update_account_thread):
226 Comment out the tny_camel_pop_store_account_reconnect(), because this
227 is apparently no longer needed, and it did not work before anyway.
228 See the comment in the code.
230 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
231 by checking the header flags. This fixes projects.maemo.org bug
234 2007-07-25 Murray Cumming <murrayc@murrayc.com>
236 * src/maemo/modest-maemo-utils.h:
237 * src/maemo/modest-maemo-utils.c: Added
238 modest_maemo_show_information_note_in_main_context_and_forget().
239 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
240 Use the new function to show simple error dialogs in the main
241 context, though question dialogs are still in the current context,
242 which is unfortunately usually not the main context. This should
245 2007-07-25 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-tny-account-store.c: (get_password):
248 Never save the entered username and password in gconf,
249 because the UI spec says we should not. This helps
250 slightly with projects.maemo.org bug NB#63671.
252 2007-07-25 Murray Cumming <murrayc@murrayc.com>
254 * src/widgets/modest-msg-edit-window.h:
255 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
256 Moved some code here to make it simpler.
257 (modest_msg_edit_window_attach_file_one): Renamed from
258 modest_msg_edit_window_attach_file_interactive().
259 (modest_msg_edit_window_offer_attach_file): Renamed from
260 modest_msg_edit_window_attach_file() and used
261 modest_msg_edit_window_attach_file_one() instead of
262 copy/pasting the code. The old code for one was not using
263 GnomeVFS. This allows use of smb:// URLs when using send-as
264 from external applications, fixing bug NB#63741.
266 (modest_msg_edit_window_insert_image),
267 (modest_msg_edit_window_add_attachment_clicked):
268 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
269 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
270 Adapted to the new function names.
272 2007-07-25 Murray Cumming <murrayc@murrayc.com>
274 (modest_platform_set_update_interval): Set the alarm recurrence
275 fields so that auto-update does not just happen the first time.
276 This should have fixed projects.maemo.org bug NB#63938.
278 When this happens you can see a printf when the D-Bus method is
280 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
282 However, I do not actually seem to get new POP messages even when
283 clicking the refresh button manually. A restart gets them.
284 This might be a problem in today's tinymail only.
286 2007-07-24 Murray Cumming <murrayc@murrayc.com>
288 * src/maemo/modest-maemo-global-settings-dialog.c:
289 (current_connection):
290 Avoid a crash (probably only in scratchbox) when strcmp()ing a
291 NULL when closing the dialog.
293 2007-07-24 Murray Cumming <murrayc@murrayc.com>
295 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
296 Remove the hacky send/receive that didn't work, and instead
297 refilter the treemodel to make the deleted email really vanish from
298 the UI (though the delete-from-menu code does has commented out
299 the code that does that). This fixes projects.maemo.org bug
302 2007-07-24 Murray Cumming <murrayc@murrayc.com>
304 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
305 Try a couple of tricks to force the treeview to update (
306 poke the folder, and do a send/receive refresh), but the deleted
307 email still appears with a strike-through instead of really being
310 2007-07-23 Murray Cumming <murrayc@murrayc.com>
312 * src/dbus_api/modest-dbus-callbacks.c:
313 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
314 because their ID is not human-readable (see the comment about
315 improvements needed to the osso-email-interface API) and
316 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
318 2007-07-23 Murray Cumming <murrayc@murrayc.com>
320 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
321 (add_folders_to_list), (on_dbus_method_get_folders),
322 (modest_dbus_req_filter):
323 * src/maemo/modest-maemo-utils.c:
324 (on_camel_account_get_supported_secure_authentication):
325 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
326 (on_header_view_focus_in):
327 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
328 * src/modest-formatter.c: (modest_formatter_create_body_part):
329 * src/modest-mail-operation.c: (recurse_folders),
330 (update_account_thread), (get_msgs_full_thread),
331 (modest_mail_operation_get_msgs_full),
332 (modest_mail_operation_xfer_msgs):
333 * src/modest-search.c: (search_mime_part_and_child_parts),
334 (modest_search_account), (modest_search_all_accounts):
335 * src/modest-tny-account.c:
336 (modest_tny_account_get_special_folder), (recurse_folders):
337 * src/modest-tny-local-folders-account.c:
338 (modest_tny_local_folders_account_query_passes):
339 * src/modest-tny-msg.c: (copy_mime_part),
340 (modest_tny_msg_find_body_part_from_mime_part):
341 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
342 (modest_tny_send_queue_try_to_send):
343 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
344 (_modest_ui_actions_open), (download_uncached_messages),
345 (reply_forward), (modest_ui_actions_on_copy),
346 (modest_ui_actions_on_details), (has_retrieved_msgs),
347 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
349 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
350 (_selected_msg_marked_as), (_msg_download_completed),
351 (_selected_msg_sent_in_progress):
352 * src/widgets/modest-attachments-view.c:
353 (modest_attachments_view_set_message):
354 * src/widgets/modest-msg-view.c: (find_cid_image):
355 * tests/check_folder-transfer.c: (find_folders):
356 * tests/check_update-account.c: (func):
357 * tests/dbus_api/test_get_folders.c: (main):
358 Checked all uses of tny_iterator_get_current(), making sure
359 that the object is unreferenced (3 or 4 places did not),
360 and adding checks for NULL.
362 2007-07-23 Murray Cumming <murrayc@murrayc.com>
364 * src/dbus_api/modest-dbus-callbacks.c:
365 (on_idle_open_default_inbox): Make sure that the application UI is
367 * src/maemo/easysetup/modest-easysetup-wizard.c:
368 (on_entry_invalid_character): Show the word whitespace instead
369 of (null) in the banner when whitespace was entered.
370 (show_error): Add a comment that this does not work in
371 Maemo Bora, though we do not know why.
373 2007-07-23 Murray Cumming <murrayc@murrayc.com>
375 * src/modest-tny-account.c:
376 (modest_tny_account_get_special_folder): Use an if instead of
377 an assert for when the parent account name is NULL, because this
378 might be causing a crash in projects.maemo.org bug 63192.
379 * src/modest-mail-operation.c:
380 (modest_mail_operation_send_new_mail_cb),
381 (modest_mail_operation_remove_folder): unref the folder that is
382 returned from modest_tny_account_get_special_folder().
384 2007-07-23 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-ui-actions.c:
387 (modest_ui_actions_on_password_requested):
388 Show mail_ib_login_cancelled info banner when the user cancels
389 the protected password dialog, to fix projects.maemo.org
392 2007-07-23 Murray Cumming <murrayc@murrayc.com>
394 * src/maemo/modest-account-settings-dialog.c:
395 (create_page_outgoing): Put this page in a GtkScrolledWindow,
396 matching the UI mock-up in the UI spec, and allowing access
397 to all widgets even when the on-screen keyboard is active.
399 2007-07-23 Murray Cumming <murrayc@murrayc.com>
401 Reverted this previous commit from Johannes,
402 because the scrollbars are always visible and because
403 I think we only need it on onepage of the account
404 settings, not the account wizard.
405 (I wrote the wrong instructions in the bug.)
407 * src/maemo/easysetup/modest-easysetup-wizard.c:
408 Added scrollbars to account wizard dialog.
409 Fixed projects.maemo.org NB #62744
411 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
413 * src/maemo/easysetup/modest-easysetup-wizard.c:
414 (create_page_user_details):
415 Use auto-cap for name (projects.maemo.org NB#63716)
416 * src/widgets/modest-account-view.c: (on_account_busy_changed):
418 2007-07-22 Armin Burgmeier <armin@openismus.com>
420 * src/maemo/modest-ui-actions.c: Use current account instead of
421 default account for creating viewer windows, so that the viewer
422 window knows to which account the viewed message belongs.
424 * src/maemo/modest-msg-view-window.c: Destroy the window when the
425 corresponding account is deleted. This fixes projects.maemo.org bug
428 2007-07-18 Armin Burgmeier <armin@openismus.com>
430 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
431 the dialog close after entering an invalid port number and clicking
432 OK. This fixes projects.maemo.org bug NB#63602.
434 2007-07-18 Armin Burgmeier <armin@openismus.com>
436 * src/modest-tny-account-store.c:
437 (get_server_accounts): Set parent modest account name for each
438 connection-specific transport account so that special folders of such
439 an account can be looked up. This fixes a crash when changing account
440 settings. This might also be related to projects.maemo.org bug
443 2007-07-16 Armin Burgmeier <armin@openismus.com>
445 * src/modest-ui-actions.c: Added a button to create a folder to the
446 move-to dialog. This fixes projects.maemo.org bug NB#.
448 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
450 * src/maemo/easysetup/modest-easysetup-wizard.c:
451 Added scrollbars to account wizard dialog.
452 Fixed projects.maemo.org NB #62744
454 2007-07-16 Murray Cumming <murrayc@murrayc.com>
456 * src/widgets/modest-msg-view.h:
457 * src/widgets/modest-msg-view.c:
458 Added modest_msg_view_get_message_is_empty() but this needs
460 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
461 Check if there is any text in the message yet.
462 But this needs to be implemented properly.
463 (modest_msg_edit_window_toggle_find_toolbar):
464 * src/maemo/modest-msg-view-window.c:
465 (modest_msg_view_window_toggle_find_toolbar):
466 Show a banner warning if there is no text to search, when
467 trying to start a search. This partially fixes
468 projects.maemo.org bug NB#62350.
470 2007-07-13 Murray Cumming <murrayc@murrayc.com>
472 * src/modest-mail-operation.c: (update_account_thread):
473 Initialized num_new_headers to fix the build.
475 2007-07-13 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
478 Ignore modest accounts whose server accounts don't exist in gconf.
479 This prevents us trying to create TnyAccount instances for those
480 server accounts when the server account has been removed from gconf,
481 but the parent modest account has not yet been removed from modest.
482 I don't know why this is only noticeable now. It was probably just
483 a harmeless g_warning() anyway.
485 2007-07-13 Murray Cumming <murrayc@murrayc.com>
487 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
488 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
490 2007-07-12 Armin Burgmeier <armin@openismus.com>
492 * src/maemo/modest-main-window.c: Make default account appear bold
493 in view, tools/send & receive and toolbar/send & receive SCM menus.
494 This fixes projects.maemo.org bug NB#59010.
496 2007-07-12 Murray Cumming <murrayc@murrayc.com>
498 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
499 Add a short-cut, by checking if the folder store is an account.
500 This ensures that the Sort menu item and toolbar is dimmed for
501 the local-folders account root item, fixing
502 projects.maemo.org bug NB#62545.
504 2007-07-12 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-tny-account-store.c: (get_password):
507 Show the password dialog (via the signal) only in the mainloop, via
508 an idle handler that we wait for. This could theoretically prevent
509 hangs, though I worry that it could introduce some too.
511 2007-07-12 Murray Cumming <murrayc@murrayc.com>
513 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
514 * src/maemo/modest-platform.c:
515 (modest_platform_connect_and_wait):
516 Take a TnyAccount* parameter and try to set it to online
517 (a TnyCamel-only API), because tinymail sets accounts to offline
518 when the user cancels a password dialog, and doesn't ask again until
519 it has been set to online.
520 However, this is commented out because it causes a hang now.
522 (modest_platform_connect_and_wait_if_network_account):
523 * src/modest-mail-operation.c:
524 (modest_mail_operation_update_account):
525 * src/modest-platform.h:
526 * src/modest-ui-actions.c: (_modest_ui_actions_open),
527 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
529 2007-07-12 Armin Burgmeier <armin@openismus.com>
531 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
533 * src/modest-mail-operation.c:
534 * src/modest-ui-actions.c: Check for already existing folder before
535 querying the server, show error message from camel if the request
536 still fails. This fixes projects.maemo.org bug NB#58701.
538 2007-07-12 Murray Cumming <murrayc@murrayc.com>
540 * src/modest-tny-account-store.h:
541 * src/modest-tny-account-store.c:
542 Added modest_tny_account_store_forget_password_in_memory(),
543 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
544 when creating a new account, so that new passwords will be used, instead of
545 us thinking that it's a second request as a result of a failed password again.
547 2007-07-12 Murray Cumming <murrayc@murrayc.com>
549 * src/dbus_api/modest-dbus-callbacks.c:
550 (on_idle_open_message): If the message is in drafts then open it
551 in an edit window instead of a view window. This fixes
552 projects.maemo.org bug NB#63005.
554 2007-07-12 Murray Cumming <murrayc@murrayc.com>
556 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
557 Avoided a harmless g_warning().
559 2007-07-12 Murray Cumming <murrayc@murrayc.com>
561 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
562 Pass the modest account name, not the TnyAccount display name to
563 modest_msg_view_window_new() so that the reply feature works,
564 fixing projects.maemo.org bug NB#62892.
566 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
567 (modest_msg_view_window_new_with_header_model):
568 * src/maemo/modest-msg-view-window.c:
569 (modest_msg_view_window_new_with_header_model),
570 (modest_msg_view_window_new):
571 * src/modest-ui-actions.c: (reply_forward):
572 * src/widgets/modest-msg-view-window.h:
573 * src/widgets/modest-window.c: (modest_window_set_active_account):
574 Rename an account parameter to modest_account_name to make this clearer.
576 2007-07-11 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-ui-actions.h:
579 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
580 modest_do_message_delete().
581 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
582 Call modest_do_message_delete(), hoping that this would cause messages
583 to be really deleted from search instead of just marked with strike through.
584 Does not seem to help.
586 2007-07-11 Armin Burgmeier <armin@openismus.com>
588 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
589 priv->reselect to FALSE prior to calling
590 modest_folder_view_select_first_inbox_or_local() to prevent endless
591 recursion and thus a crash on startup.
593 2007-07-11 Armin Burgmeier <armin@openismus.com>
595 * src/maemo/modest-account-settings-dialog.h: Include
596 <gtk/gtknotebook.h> to fix the build (at least for me).
598 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
599 Use "New FolderN" as default suggested name if "New folder" already
600 exists, with N being the first free number, though never exceed "New
601 folder99" in which case we just fall back to "New Folder" even though
602 it already exists. This fixes projects.maemo.org bug NB#58663.
604 2007-07-11 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
607 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
608 projects.maemo.org bug NB#62778.
610 2007-07-11 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
613 Ignore the wrong (for now) secure-smtp setting in the presets -
614 just default to requiring secure authentication for SMTP, because
617 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
619 * src/widgets/modest-folder-view.c: (filter_row)
620 Do not show drafts folder (see UI specs)
622 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
624 * src/modest-ui-actions.c:
625 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
626 place and also not necessary.
628 * src/widgets/modest-folder-view.c: (filter_row)
629 Guess folder type and hide Sent & Outbox if necessary.
630 Fixed project.maemo.org NB#57328
632 2007-07-11 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-ui-actions.h:
635 * src/modest-ui-actions.c:
636 (modest_ui_actions_on_delete_message):
637 Move some code into a new
638 modest_ui_actions_refresh_message_window_after_delete()
639 function so we can use it from elsewhere.
641 * src/dbus_api/modest-dbus-callbacks.c:
642 (on_idle_delete_message), (on_delete_message): Used an idle
643 handler, as we do for the other D-Bus method handlers.
644 Call modest_ui_actions_refresh_message_window_after_delete()
645 if the deleted message was open in a window. This fixed
646 projects.maemo.org bug NB#62862.
648 2007-07-11 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-main.c: (main): Only show the UI at the start if
651 the showui command line option was given. For instance,
652 run-standalone src/modest showui
653 Otherwise, we wait for the top_application D-Bus method to
654 be sent by hildon-desktop when the application is selected
656 This allows us to run without a UI when osso-global-search
657 uses our D-Bus methods.
659 2007-07-11 Murray Cumming <murrayc@murrayc.com>
661 * src/dbus_api/modest-dbus-api.h: Added a define for a
662 top-application D-Bus method.
663 * src/dbus_api/modest-dbus-callbacks.c:
664 (on_top_application),
665 (modest_dbus_req_handler): Handle the top-application D-Bus
666 method, which might be an undocumented D-Bus signal sent by
667 hildon-desktop when it starts the application from the menu.
668 But I am not sure and I need to test it on the device, because
669 my scratchbox does not have the application in the menu now.
670 This method shows the main window, so that it can be invisible
671 when started, for instance, just for email searching from
674 * src/maemo/modest-main-window.c: (restore_settings),
675 (modest_main_window_new): Do not show the window immediately
676 upon creation. We show it later.
677 * src/modest-widget-memory.c: (save_settings_paned):
678 Try (unsuccessfully) to avoid saving the paned position when
679 it is not even visible.
680 (restore_settings_paned): Do not allow a silly paned position.
681 This seems necessary when not showing the window at first.
683 * tests/dbus_api/Makefile.am:
684 * tests/dbus_api/test_top_application.c: (main): Test for the
687 2007-07-10 Murray Cumming <murrayc@murrayc.com>
689 * src/modest-ui-dimming-rules.c:
690 (modest_ui_dimming_rules_on_new_msg),
691 (modest_ui_dimming_rules_on_reply_msg),
692 (modest_ui_dimming_rules_on_delete_msg),
693 (modest_ui_dimming_rules_on_details),
694 (modest_ui_dimming_rules_on_view_window_move_to),
695 (modest_ui_dimming_rules_on_view_previous),
696 (modest_ui_dimming_rules_on_view_next),
697 (_invalid_folder_for_purge): Added checks before
698 casting the window. This looks like an actual
699 logic error in _invalid_folder_for_purge(), because it
700 tries to use a ModestMainWindow as a message window.
702 2007-07-10 Murray Cumming <murrayc@murrayc.com>
704 * src/maemo/modest-account-settings-dialog.c:
705 (show_error): Use the same implementation as in
706 modest-easysetup-wizard.c:
707 (on_entry_invalid_character): The logical ID contains a %s.
708 Guessed what it should be.
709 (on_entry_max), (check_data), (on_response): Adapt to
710 changed show_error().
711 (create_page_account_details): Really call
712 modest_validating_entry_set_func() on the correct widgets.
713 * src/maemo/easysetup/modest-easysetup-wizard.c:
714 (on_entry_invalid_character): Fix the logical ID here too.
715 (create_page_account_details),
716 (create_page_user_details):
718 modest_validating_entry_set_func() on the correct widgets.
720 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
721 Do not try to use the account if it is NULL.
723 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
725 * src/modest-ui-actions.c: (create_move_to_dialog),
726 (modest_ui_actions_on_main_window_move_to),
727 (modest_ui_actions_on_msg_view_window_move_to):
728 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
729 (filter_row), (modest_folder_view_show_non_move_folders):
730 * src/widgets/modest-folder-view.h:
732 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
733 the Sent folder yet as it does not report the correct folder type.
735 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
737 * src/maemo/modest-msg-edit-window.c: (init_window):
740 2007-07-10 Murray Cumming <murrayc@murrayc.com>
742 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
743 Take a parent widget instead of a parent window, and
744 implement this with hildon_banner_show_information() instead.
745 Non-Maemo builds can just ifdef that there.
746 This fixed projects.maemo.org bug NB#62766.
748 (on_entry_invalid_character): Use show_error() again instead
749 of using hildon directly, and use the _CS() macro to use the correct
751 (create_account), (check_for_supported_auth_methods), (on_entry_max):
752 Pass a widget instead od a window to show_error().
754 2007-07-10 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
757 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
758 This allows us to show the server name in the error message, fixing
759 projects.maemo.org bug NB#62904.
760 Also, use the appropriate logical ID message for the account protocol.
762 2007-07-10 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-tny-account-store.c: (on_idle_wrong_password):
765 A compilation fix, though the build wasn't broken for me.
767 2007-07-09 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
770 Do not try to unref a NULL folder store, to avoid a runtime warning.
771 This seems to happen sometimes when changing accounts settings.
773 2007-07-09 Murray Cumming <murrayc@murrayc.com>
775 * src/modest-tny-account-store.c:
776 (modest_tny_account_store_instance_init),
777 (modest_tny_account_store_finalize),
778 (on_account_settings_hide), (on_idle_wrong_password):
779 Use a GHashTable to ensure that we only show one account settings
780 dialog per modest account. This avoids us having a dialog open for
781 both the store and transport accounts, or due to repeated get_password()
782 calls that shouldn't happen anyway.
784 2007-07-09 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-maemo-utils.c: (on_hide),
787 (modest_maemo_show_dialog_and_forget): Handle the response, because
788 the window is not even hidden by default.
790 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
791 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
792 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
793 which seems to prevent some modality problems.
795 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
796 Ignore user cancellation errors.
798 * src/modest-account-mgr-helpers.h:
799 * src/modest-account-mgr-helpers.c:
800 Added modest_server_account_get_password() and
801 modest_server_account_get_has_password() to avoid direct use of
804 * src/maemo/modest-account-settings-dialog.h:
805 * src/maemo/modest-account-settings-dialog.c:
806 (modest_account_settings_dialog_init): Store the notebook so we can
808 Added modest_account_settings_dialog_switch_to_user_info().
810 * src/modest-tny-account-store.c:
811 (get_password): When the password in the account settings is wrong (we think),
812 show the relevant page of the account settings dialog, in the mainloop.
813 However, we currently get many of these at once because cancel does not
815 (forget_password): Do not forget the password
816 from the account settings, because this causes side-effects when
817 tinymail seems to call it at strange time, maybe because of how we
818 are cancelling get_password().
819 (modest_tny_account_store_alert): Ignore user cancellations.
821 2007-07-09 Murray Cumming <murrayc@murrayc.com>
823 * src/maemo/modest-maemo-utils.h:
824 * src/maemo/modest-maemo-utils.c:
825 Added modest_maemo_show_information_note_and_forget() for use instead of
826 gtk_dialog_run() when the response is not needed, to avoid an extra
827 mainloop which could cause a hang.
829 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
830 Use the logical IDs for the error message, though they are not
831 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
832 because gtk_dialog_run() caused a hang here (the window did not close).
833 This fixes projects.maemo.org bug NB#62646.
835 2007-07-09 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-account-mgr-helpers.h:
838 * src/modest-account-mgr-helpers.c:
839 Added modest_account_mgr_get_store_protocol().
841 * src/maemo/modest-account-view-window.c:
842 (on_delete_button_clicked): Show different warning text depending on
843 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
844 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
847 2007-07-09 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/modest-msg-edit-window.c:
850 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
851 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
853 2007-07-07 Armin Burgmeier <armin@openismus.com>
855 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
856 ckdg_ib_maximum_characters_reached from correct package.
858 * src/modest-ui-actions.c: Show an error message when a folder could
859 not be created. Tinymail does not give us specific error codes about
860 what has gone wrong, so we assume that a folder with that name
861 already exists, though there might be other reasons.
863 2007-07-06 Murray Cumming <murrayc@murrayc.com>
865 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
866 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
867 give a more exact error message that can be partly translated.
869 2007-07-05 Murray Cumming <murrayc@murrayc.com>
871 * src/maemo/modest-address-book.c:
872 (select_email_addrs_for_contact): Specify a default window size for the
873 select-email-address dialog, so that it is probably big enough for the
874 title. This should fix projects.maemo.org bug NB#62277.
876 2007-07-05 Murray Cumming <murrayc@murrayc.com>
878 * src/maemo/easysetup/modest-easysetup-wizard.c:
879 (create_page_complete_easysetup): Use
880 gtk_widget_set_size() request to ensure that the text wraps
883 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
885 * src/maemo/easysetup/modest-easysetup-wizard.c:
886 (on_entry_invalid_character), (create_page_account_details),
887 (create_page_user_details):
888 Use new API of ModestValidatingEntry. But for some reason the banner is
889 not shown. I will have to investigate that further.
891 * src/widgets/modest-validating-entry.c: (on_insert_text),
892 (modest_validating_entry_set_func):
893 * src/widgets/modest-validating-entry.h:
894 Added a new callback function to be able to react to prevented
895 characters whitespaces to e.g show a banner.
897 2007-07-05 Armin Burgmeier <armin@openismus.com>
899 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
900 notification of HildonNumberEditor instead of remembering the port
901 number. Thanks to Johannes for pointing this out.
903 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
905 * src/maemo/easysetup/modest-easysetup-wizard.c:
906 Check if there are any user changes before showing a confirmation
907 dialog (projects.maemo.org NB#60946)
909 2007-07-05 Armin Burgmeier <armin@openismus.com>
911 * src/maemo/modest-account-settings-dialog.c: Remember custom port
912 number at the beginning of the dialog and set the modified flag at the
913 end if the port number has changed. This is necessary because
914 HildonNumberEditor does not support notification when the value has
917 2007-07-05 Murray Cumming <murrayc@murrayc.com>
919 * src/modest-ui-actions.c:
920 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
921 a connection before asking anything else. Correct the check for the destination
922 folder so that it succeeds when online.
923 This fixed projects.maemo.org bug NB#61645.
925 2007-07-05 Murray Cumming <murrayc@murrayc.com>
927 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
928 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
929 to fix projects.maemo.org bug NB#62439.
931 2007-07-05 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-tny-account.c: (on_connection_status_changed):
934 Really do not use tny_device_force_offline() here. See the previous comment.
936 2007-07-04 Murray Cumming <murrayc@murrayc.com>
938 * src/modest-tny-account.c: (on_connection_status_changed):
939 Do not use tny_device_force_offline() when tinymail says that something
940 went wrong with the connection. It seems to report this unnecessarily.
942 2007-07-04 Murray Cumming <murrayc@murrayc.com>
944 * src/maemo/modest-connection-specific-smtp-window.c:
945 (modest_connection_specific_smtp_window_init):
946 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
947 does not seem to have any effect in osso 1.1 (though it works in
948 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
950 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
952 * src/maemo/modest-connection-specific-smtp-window.c:
953 Fix UI specification problems with projects.meamo.org NB#60479
955 2007-07-04 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
958 clue when this has failed, because the error dialog is not always shown
959 (at least in earlier version).
961 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
962 GError message, because the generic error dialog is not helpful.
964 'This message is not currently available (can't let a new connection go online)'
965 when trying to open an IMAP message.
967 (_modest_ui_actions_open): Offer a connection when some messages would
968 have to be downloaded and we are offline.
970 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
972 * src/widgets/modest-folder-view.c:
973 Don't check for MERGE type anymore as we use the correct type
975 NOTE: For the last two changes you need to update your tinymail copy
976 because of API changes!
978 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
980 * src/modest-tny-local-folders-account.c:
981 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
982 (see projects.maemo.org NB#61580)
984 2007-07-04 Murray Cumming <murrayc@murrayc.com>
986 * src/modest-tny-account.c: (on_connection_status_changed):
987 Commented out the call to modest_platform_connect_and_wait() because this
988 seems to always hang, and I would like to know if this is the only thing
989 that causes a hang when showing the connection dialog.
990 It is not very useful anyway.
992 2007-07-04 Murray Cumming <murrayc@murrayc.com>
994 * src/maemo/modest-msg-view-window.c:
995 (modest_msg_view_window_select_next_message):
997 * src/modest-platform.h:
998 * src/maemo/modest-platform.c:
999 Added modest_platform_connect_and_wait(), which calls
1000 tny_maemo_conic_device_connect() always in the main thread, by calling it
1001 in an idle handler and waiting for the idle handler to run. It should be
1002 in the main thread because it uses GTK+ UI code. It just returns TRUE
1003 if the device is already online.
1005 There is some nasty code to ensure that subsequent calls to
1006 modest_platform_connect_and_wait() just wait for the first one to finish,
1007 by checking repeatedly in another idle handler. This is necessary,
1008 because other threads (or even the main thread, via another idle handler)
1009 can call modest_platform_connect_and_wait() while
1010 modest_platform_connect_and_wait() is running.
1012 (modest_platform_connect_and_wait_if_network_account),
1013 (modest_platform_connect_and_wait_if_network_folderstore):
1014 Convenience functions that calls modest_platform_connect_and_wait() if
1015 the account or folder might want network access.
1017 * src/modest-mail-operation.c:
1018 (modest_mail_operation_update_account):
1019 * src/modest-ui-actions.c: (download_uncached_messages),
1020 (modest_ui_actions_on_rename_folder), (delete_folder),
1021 (modest_ui_actions_on_main_window_move_to),
1022 (modest_ui_actions_on_msg_view_window_move_to):
1023 * src/widgets/modest-folder-view.c:
1024 (drag_and_drop_from_folder_view):
1025 Offer a connection if we are offline.
1027 * src/modest-tny-account.c: (on_connection_status_changed):
1028 Document this as only handling errors during network operations in progress,
1029 and replace the idle code with a simple call to
1030 modest_platform_connect_and_wait(), which does this instead.
1032 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-tny-account.c:
1035 (modest_tny_account_get_special_folder): (util_on_idle),
1036 Handle the GError so we can see when tny_folder_store_get_folders()
1037 fails, as it currently does while something else is connecting.
1039 Added util_run_in_main_thread_and_wait()
1040 which uses an idlen handler and mainloop to ensure that the function
1041 is called in the main thread.
1042 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1043 to make sure that we call attempt the connection in the mainloop only,
1044 which might solve some hangs.
1046 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1048 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1049 be found by their display name. This is never useful.
1050 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1051 by its ID, instead of trying to use its ID as its display name.
1053 * src/modest-tny-account-store.h:
1054 * src/modest-tny-account.c:
1055 (modest_tny_account_get_special_folder): Add a g_warning() when
1056 tny_folder_store_get_folders() returns an empty list for the maildir.
1058 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1059 Add a g_warning() when this returns NULL, because that it not allowed
1062 2007-07-02 Armin Burgmeier <armin@openismus.com>
1064 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1065 note when trying to cancel the wizard. This fixes projects.maemo.org
1068 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-tny-account.h:
1071 * src/modest-tny-account.c:
1072 (modest_tny_account_new_from_server_account),
1073 (modest_tny_account_new_from_server_account_name),
1074 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1075 because this must now be set before setting the proto. This is usd in
1076 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1077 warning in camel_session_get_service() caused by
1078 tny_camel_transport_account_prepare().
1080 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1083 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1085 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1087 (modest_connection_specific_smtp_edit_window_init):
1089 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1090 of "changed" for now
1092 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-tny-account.c:
1095 (modest_tny_account_new_from_server_account):
1096 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1097 now uses to request a connection when it needs one, and which it uses
1098 to tell us that something is wrong with the connection, so we can force
1099 the accounts offline to prevent further problems.
1101 * src/modest-defs.h:
1102 * src/modest-init.c: (init_default_settings):
1103 * src/modest-mail-operation.c:
1104 (modest_mail_operation_update_account):
1105 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1106 This should not be necessary anymore. Do not set the conf key that
1107 determined this (it was always TRUE and not set anywhere else).
1109 * src/modest-ui-actions.h: Remove unused and unimplemented
1110 modest_ui_actions_on_online_toggle_toggled().
1112 2007-06-29 Murray Cumming <murrayc@murrayc.com
1114 * src/maemo/modest-main-window.c: (connect_signals):
1115 Don't connect to delete_event twice. Maybe this was harmless.
1117 2007-06-29 Murray Cumming <murrayc@murrayc.com
1119 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1120 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1121 Debug output to give some more clue when a folder move is not allowed.
1123 2007-06-28 Murray Cumming <murrayc@murrayc.com
1125 * src/modest-tny-account.c: (on_modest_file_system_info),
1126 (modest_tny_account_get_mmc_account_name):
1127 Always call the callback, without checking whether the name has changed.
1128 * src/widgets/modest-folder-view.c: (strings_are_equal),
1129 (on_model_foreach_set_name), (on_get_mmc_account_name),
1130 (text_cell_data): Compare the name here, and use the name from
1131 the account rather than from the
1132 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1133 if the name was changed after the account was added to the model.
1134 That's a tinymail bug but not one that I want to fix now.
1136 This finally fixes projects.maemo.org bug NB#59301.
1138 2007-06-27 Armin Burgmeier <armin@openismus.com>
1140 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1143 2007-06-27 Murray Cumming <murrayc@murrayc.com
1145 * src/modest-tny-account.h:
1146 * src/modest-tny-account.c:
1147 Added modest_tny_account_get_mmc_account_name(), to set the memory
1148 card name asynchronously for the given account and then notify.
1149 (modest_tny_account_new_for_local_folders): Use this new function instead
1150 of using hildon_file_system_info_async_new() directly.
1152 * src/widgets/modest-folder-view.c: (text_cell_data):
1153 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1154 gtk_tree_model_row_changed() when it is available.
1156 This should fix projects.maemo.org bug NB#59301.
1158 2007-06-27 Murray Cumming <murrayc@murrayc.com
1160 * src/modest-mail-operation.c: (update_account_thread),
1161 (get_msgs_full_thread): Fix typo failures in the revert
1164 2007-06-27 Murray Cumming <murrayc@murrayc.com
1166 * src/maemo/modest-maemo-global-settings-dialog.c:
1167 (idle_select_default_focus):
1168 * src/modest-mail-operation.c: (idle_notify_progress),
1169 (idle_notify_progress_once), (set_last_updated_idle),
1170 (update_account_thread), (get_msgs_full_thread):
1171 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1172 * src/widgets/modest-header-view.c:
1173 (idle_notify_headers_count_changed_destroy),
1174 (idle_notify_headers_count_changed):
1175 Reverted the additions of gdk_threads_enter/leave(), in case this
1176 helps with a startup hang on the device.
1178 2007-06-26 Armin Burgmeier <armin@openismus.com>
1180 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1181 for supported secure authentication methods from server by
1182 gtk_dialog_run(), saving CPU time and a potential race condition.
1184 2007-06-26 Armin Burgmeier <armin@openismus.com>
1186 * src/maemo/modest-maemo-utils.h:
1187 * src/maemo/modest-maemo-utils.c: Added a
1188 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1189 only error code to tell the calling code when the user canceled the
1192 * src/maemo/modest-account-settings-dialog.h:
1193 * src/maemo/modest-account-settings-dialog.c:
1194 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1195 message if the retrieval of secure authentication methods was canceled
1196 by the user. Perform the check before saving anything to configuration
1197 to not end up with half-committed configuration changes, do not show
1198 a "Saving to configuration failed" note when authentication methods
1199 could not be retrieved.
1201 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1204 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1206 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1207 Only return the first level of folders under accounts, because the
1208 osso-global-search UI spec doesn't want the rest.
1209 This fixed projects.maemo.org bug NB#61811.
1211 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1213 * src/modest-tny-account-store.c:
1214 * src/modest-tny-account-store.h:
1215 Added modest_tny_account_is_memory_card_account().
1216 * src/maemo/modest-main-window.c: (create_details_widget):
1217 Show the same information items for the memory card as we show for the
1218 local-folders, to fix projects.maemo.org bug NB#59307.
1220 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-tny-account-store.c: (get_password):
1223 Added some checks for NULL to maybe prevent crashes, though I think
1224 it was Philip's last commit that actually prevented the crash here
1225 when creating a first new account.
1226 But the new account is still not usable (no messages are shown)
1227 until a restart of the application.
1229 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/modest-maemo-global-settings-dialog.c:
1232 (idle_select_default_focus):
1233 * src/modest-mail-operation.c: (idle_notify_progress),
1234 (idle_notify_progress_once), (idle_notify_update_account_queue),
1235 (set_last_updated_idle), (update_account_thread),
1236 (notify_get_msgs_full), (get_msgs_full_destroyer),
1237 (get_msgs_full_thread):
1238 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1239 * src/widgets/modest-header-view.c:
1240 (idle_notify_headers_count_changed_destroy),
1241 (idle_notify_headers_count_changed):
1242 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1243 all idle handlers, because some other thread could be blocking
1244 the GDK lock, so that it can do GUI stuff.
1246 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1248 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1249 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1250 (on_idle_send_receive), (on_idle_open_default_inbox):
1251 * src/maemo/modest-msg-edit-window.c:
1252 (modest_msg_edit_window_attach_file_noninteractive):
1253 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1254 to prevent a hang. I don't quite understand why these are necessary,
1255 beause we should already be in the main loop. I guess something outside
1256 of the main loop is taking the lock.
1258 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1259 we are really using URIs, and use files that are more likely to exist.
1261 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1263 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1264 necessary because configure.ac now defines different variables.
1266 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1268 * libmodest-dbus-client/libmodest-dbus-client.c:
1269 * libmodest-dbus-client/libmodest-dbus-client.h:
1270 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1271 libmodest_dbus_client_compose_mail() is what things actually use.
1273 * src/dbus_api/modest-dbus-api.h:
1274 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1275 * tests/dbus_api/Makefile.am:
1276 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1279 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1281 * src/modest-init.c: (modest_init_local_folders):
1282 For memory-card (or other non local-folders) maildir accounts,
1283 always create an Archive folder, so that there is somewhere to put
1284 messages. This should be less confusing, because the user does not need
1285 to guess that the need to create a folder.
1287 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1289 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1290 Fixed icon size by using (50, 50) which is the same as defined by
1293 2007-06-25 Armin Burgmeier <armin@openismus.com>
1295 * src/widgets/modest-window-mgr.c:
1296 * src/modest-init.c:
1297 * configure.ac: Correctly recognize hildon-notify presence and fixed
1298 the build without it being installed.
1300 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1302 * libmodest-dbus-client/libmodest-dbus-client.c:
1303 (libmodest_dbus_client_search): Fix the build. Sorry.
1304 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1305 (reply_forward_cb): Initialize variables to fix the build.
1307 * src/modest-tny-account-store.c:
1308 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1309 comparison (a silly typo) so that email search results can be opened
1310 when there are more than one account.
1312 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1314 * libmodest-dbus-client/libmodest-dbus-client.c:
1315 (libmodest_dbus_client_search),
1316 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1317 instead of 1 second, because the search gets folders and messages from
1318 the server, which can take a long time. When it times out,
1319 osso-global-search will report no results.
1321 We need to specify whether we should search only cached information
1322 (maybe with a user preference), and the osso-email-search-plugin
1323 API should really be improved to allow that option, and to allow results
1324 to be delivered asynchronously in batches.
1326 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1329 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1330 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1332 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1335 that is an empty string. D-Bus seems to give us these instead of NULL.
1337 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1339 * src/dbus_api/modest-dbus-callbacks.c:
1340 * src/maemo/easysetup/modest-easysetup-wizard.h:
1341 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1342 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1343 (modest_connection_specific_smtp_edit_window_init):
1344 * src/maemo/modest-maemo-global-settings-dialog.c:
1346 * src/maemo/modest-maemo-utils.c:
1347 (modest_maemo_utils_setup_images_filechooser):
1348 * src/maemo/modest-main-window.c: (create_details_widget):
1349 * src/maemo/modest-msg-edit-window.c:
1350 (modest_msg_edit_window_attach_file_noninteractive),
1351 (modest_msg_edit_window_color_button_change),
1352 (modest_msg_edit_window_set_zoom):
1353 * src/modest-mail-operation.c: (update_account_thread):
1354 * src/modest-tny-account-store.c:
1355 * src/modest-tny-account.c:
1356 * src/widgets/modest-global-settings-dialog.c:
1357 * src/widgets/modest-window.h:
1359 Fixed build on bora!
1361 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1363 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1364 * src/modest-search.c: (modest_search_folder),
1365 (modest_search_all_accounts): Actually search only in the specified folder,
1366 doing a simple match on the folder ID.
1367 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1368 and added some documentation.
1370 2007-06-22 Armin Burgmeier <armin@openismus.com>
1372 * src/maemo/modest-maemo-utils.h:
1373 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1374 modest_maemo_utils_get_supported_secure_authentication_methods.
1376 * src/maemo/easysetup/modest-easysetup-wizard.c:
1377 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1378 one occured, not just "Server does not support secure authentication".
1380 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1382 * src/modest-tny-account-store.c: (get_password):
1383 Restored the call to tny_account_set_user() because Philip seems to have
1384 stopped this from crashing (by not using the freed string). It still does
1385 not work, but now we can test it.
1387 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/modest-msg-edit-window.c: (init_window):
1390 Comment out use of an uninitialzed GtkScrolledWindow variable,
1391 to fix the build and stop a crash. Yet again.
1393 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account-store.c: (get_password):
1396 Remove the call to tny_account_set_user() because this actually crashes.
1397 As mentioned in the last commit, it is known to not work anyway.
1399 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account-store.c: (get_password):
1402 Use tny_account_set_username() to tell tinymail that the username might
1403 have changed too. But tinymail ignores this: see projects.maemo.org
1405 * src/modest-ui-actions.c:
1406 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1407 reset the connection when changing the username, and improve the comments.
1408 Save the changed username to gconf at least, so it is used when Modest is
1411 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1413 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1414 Do not use a query, so that we get all folders, including for POP and
1415 local-folders. They work as search criteria too.
1416 This fixes projects.maemo.org bug NB#57740.
1418 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1420 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1421 Comment out the use of hildon_notification_set_sound() because it is
1422 not declared, to fix the build. Warnings are serious, people.
1424 2007-06-21 Armin Burgmeier <armin@openismus.com>
1426 * src/maemo/modest-maemo-utils.h:
1427 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1428 modest_maemo_utils_get_supported_secure_authentication_methods()
1429 to query authentication methods for a specific user. This should fix
1430 projects.maemo.org bug NB#61369.
1432 * src/maemo/easysetup/modest-easysetup-wizard.c:
1433 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1436 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1438 * libmodest-dbus-client/libmodest-dbus-client.h:
1439 * libmodest-dbus-client/libmodest-dbus-client.c:
1440 (modest_dbus_message_iter_get_search_hit),
1441 (libmodest_dbus_client_search):
1442 Reorganised and commented this.
1443 Removed modest_search_hit_free() from the public API because it
1446 Added libmodest_dbus_client_get_folders() and
1447 modest_folder_result_list_free().
1449 * src/dbus_api/modest-dbus-api.h:
1450 * src/dbus_api/modest-dbus-callbacks.c:
1451 (modest_dbus_req_filter): Commented. Moved most code to
1452 on_dbus_method_search() and added on_dbus_method_get_folders().
1454 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1455 of the extra D-Bus handler.
1457 * tests/dbus_api/Makefile.am:
1458 * tests/dbus_api/test_get_folders.c: New test for
1459 libmodest_dbus_client_get_folders(). This seems to return an empty list
1460 at the moment. That could be the same error that causes the message list
1461 to be empty sometimes.
1462 This should help with projects.maemo.org bug NB#57740.
1464 2007-06-21 Armin Burgmeier <armin@openismus.com>
1466 * src/modest-mail-operation.c: Do not call
1467 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1468 notify the operation's end after having set the status to CANCELED for
1469 the operation queue to listen on. This fixes a deadlock when there
1470 were mail operations in the queue during its finalization.
1472 * src/modest-singletons.c: Reordered uninitialization of the account
1473 manager to happen after the mail operation queue was uninitialized
1474 because the mail operation's in the queue might still try to access
1475 the account manager (see modest_mail_operation_notify_end()). This
1476 fixes a potential crash when terminating the application.
1478 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1480 * src/modest-search.c:
1481 (search_mime_part_and_child_parts): Moved some code here so we
1482 can search recursively in child folders.
1483 (modest_search_folder): Search in the message as a mime part, instead
1484 of just its child mime parts.
1485 (read_chunk), (search_mime_part_ogs):
1486 Check how many bytes were read, to prevent an endless loop.
1487 Searching in message bodies now works. This finishes the fix for
1488 projects.maemo.org bug NB#61007.
1490 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1493 Add a g_warning when the item is not a folder.
1495 * src/modest-ui-dimming-rules.c:
1496 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1497 when selected item is not a folder (for instance, an account), because
1498 the UI spec only talks about folders.
1499 I am not sure what the UI spec wants, so this might not totally fix
1500 projects.maemo.org bug NB#60794.
1502 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1505 (load_from_file): Sort the list. The unsorted list would be more noticeable
1506 in non-English locales.
1508 * src/maemo/modest-msg-edit-window.c:
1509 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1510 warning and fix the build.
1512 * src/maemo/modest-progress-bar-widget.c:
1513 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1514 avoid a g_warning, and probably to avoid a crash.
1516 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1518 * src/modest-search.c: (modest_search_folder): Check for a GError
1519 when calling tny_folder_get_headers(), to show that this is not the cause
1522 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1524 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1525 Actually set the body query instead of the subject query.
1527 * src/modest-search.c: (search_mime_part_ogs),
1528 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1529 which would probably cause it to fail if we got this far.
1531 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1532 to simplify the code.
1533 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1534 be causing search-in-body to fail.
1536 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1538 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1540 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1541 Better debug message when the folder cannot be found.
1542 This should help with fixing projects.maemo.org bug #61287.
1543 * src/modest-search.c: (add_hit): Do not leak the furl string.
1545 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1547 * src/modest-ui-actions.c:
1548 (modest_ui_actions_on_folder_selection_changed):
1549 Do not special-case TNY_MERGE_FOLDER here, because
1550 modest_tny_folder_get_account() already does that. This fixes
1551 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1552 shown when the Outbox was selected).
1554 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1556 * libmodest-dbus-client/libmodest-dbus-client.c:
1557 (_dbus_iter_get_string_or_null): Initialize the string variable in
1558 case this helps with Dirk's crash.
1560 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1562 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1563 though it is not implemented yet (this function is maybe not even used),
1564 to avoid breaking ABI in future.
1565 * libmodest-dbus-client/libmodest-dbus-client.c:
1566 (get_attachments_string): Moved some code into this generic function.
1567 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1568 sends email. It is maybe not used.
1569 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1570 (on_send_mail): Use attachments.
1572 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1573 * src/maemo/modest-msg-edit-window.c:
1574 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1575 a filename before using it, to fix projects.maemo.org bug NB#58233.
1577 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1580 Initialize the continue_download variable to fix the build, and probably
1581 to fix randome behaviour.
1583 2007-06-18 Armin Burgmeier <armin@openismus.com>
1585 * src/modest-tny-send-queue.h:
1586 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1587 the queue so we can later show it in the UI. Replaced
1588 modest_tny_send_queue_msg_is_being_sent() by
1589 modest_tny_send_queue_get_msg_status().
1591 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1593 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1594 gpointer. This probably was not harmful, but just to be sure.
1596 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1599 Fix the build, but leave the function broken on Bora, because
1600 hildon_uri_action_get_service() does not exist.
1601 osso_uri_action_get_service() does not exist either, it seems.
1603 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-tny-account.c:
1606 (modest_tny_account_new_from_server_account):
1607 Uncommented the url debug output again, because it is useful for
1608 debugging, as I said in the comment.
1610 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1612 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1614 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1615 for Mameo Bora, to fix the build.
1617 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1620 Fixed build with hildon < 0.99
1622 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1623 Check if the selected account is busy instead of checking all accounts
1625 * src/modest-account-mgr-priv.h:
1626 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1627 (modest_account_mgr_init), (compare_account_name),
1628 (modest_account_mgr_set_account_busy),
1629 (modest_account_mgr_account_is_busy):
1630 * src/modest-account-mgr.h:
1631 Added busy information to the account manager. It possible to
1632 set an account to busy or not busy now.
1634 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1635 (modest_mail_operation_update_account),
1636 (modest_mail_operation_notify_end):
1637 Set the account to busy/not busy depending on the operation state.
1639 * src/widgets/modest-account-view.c:
1640 (modest_account_view_finalize), (get_last_updated_string),
1641 (update_account_view), (on_account_busy_changed), (init_view):
1642 Show string "Refreshing..." if the account is currently busy.
1644 All this fixes projects.maemo.org bug NB#59711
1646 2007-06-14 Armin Burgmeier <armin@openismus.com>
1648 * src/widgets/modest-attachments-view.h:
1649 * src/widgets/modest-attachments-view.c: Added
1650 modest_attachments_view_has_attachments() and fixed coordinate
1651 transformation in get_att_view_at_coords(). This fixes attachment
1654 * src/widgets/modest-msg-view.c: Make use of
1655 modest_attachments_view_has_attachments() to decide whether to show
1656 attachments in the header.
1658 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1660 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1661 (on_change), (on_combo_security_changed),
1662 (modest_connection_specific_smtp_edit_window_init),
1663 (modest_connection_specific_smtp_edit_window_set_connection),
1664 (modest_connection_specific_smtp_edit_window_is_dirty):
1665 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1666 * src/maemo/modest-connection-specific-smtp-window.c:
1669 Show an comfirmation dialog for the smpt-edit-window if there are
1670 unsaved changes and the user hits cancel.
1671 (projects.maemo.org bug NB#60479)
1673 2007-06-14 Armin Burgmeier <armin@openismus.com>
1675 * src/maemo/easysetup/modest-easysetup-wizard.c:
1676 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1677 address" info in banner instead of node, and select all the text as
1678 per UI spec. This fixes projects.maemo.org bug NB#60550.
1680 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1682 reviewed by: <delete if not using a buddy>
1684 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1685 * src/modest-ui-actions.c: (folder_refreshed_cb):
1687 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1689 * src/widgets/modest-folder-view.c: (filter_row):
1690 Explictly filter out the per-account outbox accounts. I don't know why
1691 these only sometimes show up, but now they should never show up in the UI.
1692 This should fix projects.maemo.org bug NB#60160.
1694 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1697 when the toolbar does not exist yet.
1698 * src/modest-widget-memory.c: (save_settings_header_view):
1699 Added g_warnings() to help us to discover when we are trying to set
1700 an empty columns list in gconf.
1702 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-init.h:
1705 * src/modest-init.c:
1706 Added modest_init_get_default_header_view_column_ids().
1708 * src/modest-widget-memory.c: (restore_settings_header_view):
1709 Use the new function to get defaults, if the gconf key is empty,
1710 instead of not creating any columns. This seems to fix the
1711 empty right-hand pane problems.
1713 * src/widgets/modest-header-view.h: Improved documentation.
1715 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1717 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1718 Revert the use of the display name as the account name, because this
1719 is generally wrong and would break the code that follows.
1721 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1723 * src/maemo/easysetup/modest-easysetup-wizard.c:
1724 (check_for_supported_auth_methods), (on_before_next),
1727 More correct fix for projects.maemo.org bug NB# 58991
1728 Do not longer accept AUTH_PASSWORD as secure method and choose
1729 correct method when creating the account.
1731 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1733 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1734 Fixed projects.maemo.org bug NB# 58991
1736 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-init.c: (modest_init_init_core),
1739 (modest_init_local_folders): Fixed compilation errors.
1741 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1743 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1744 Remove unnecessary lib/include, though it is good in principle when needed.
1746 * src/modest-init.c: (modest_init_one_local_folder),
1747 (modest_init_local_folders):
1748 * src/modest-init.h: Initialize the .modest library for memory cards,
1749 instead of just doing nothing for them. This should allow us to create
1750 folders there, fixing projects.maemo.org bug NB#59297.
1752 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1754 * libmodest-dbus-client/libmodest-dbus-client.c:
1755 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1756 (libmodest_dbus_client_compose_mail),
1757 (libmodest_dbus_client_open_message),
1758 (libmodest_dbus_client_send_and_receive),
1759 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1761 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1762 (on_idle_open_message), (modest_dbus_req_handler),
1763 (search_result_to_message), (modest_dbus_req_filter):
1764 * src/modest-search.c: (add_hit), (modest_search_folder),
1765 (modest_search_all_accounts): Improved debug messages.
1767 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1769 * src/modest-tny-account-store.c:
1770 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1773 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1776 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1778 * src/modest-tny-account-store.c: (get_server_accounts):
1779 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1780 even when there are no accounts, so that the Outbox folder is always
1781 visible. This fixes projects.maemo.org bug NB#60158.
1783 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1785 * src/maemo/modest-main-window.c: (create_details_widget):
1786 Use the mcen_va_never logical ID.
1788 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1790 * src/dbus_api/modest-dbus-api.h:
1791 * src/dbus_api/modest-dbus-callbacks.c:
1792 (on_idle_open_default_inbox), (on_open_default_inbox),
1793 (modest_dbus_req_handler):
1794 Added a new OpenDefaultInbox method.
1796 * libmodest-dbus-client/libmodest-dbus-client.h:
1797 * libmodest-dbus-client/libmodest-dbus-client.c:
1798 Added libmodest_dbus_client_open_default_inbox() to call the new
1799 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1800 though it should maybe be used by a new osso-email-interface function.
1802 * tests/dbus_api/Makefile.am:
1803 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1806 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1809 NULL, so that the signals get all the keys. This should not actually
1810 change any behaviour because we currently update everything when anything
1813 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1815 * src/widgets/modest-folder-view.c: (text_cell_data),
1816 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1817 (find_inbox_iter): If tinymail tells us that the folder is
1818 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1819 This causes the inbox to be selected at startup, fixing part of
1820 projects.maemo.org bug NB#56305.
1822 * src/modest-ui-dimming-rules.c:
1823 (modest_ui_dimming_rules_on_tools_smtp_servers):
1824 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1825 the SMTP servers menu item.
1826 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1827 that the SMTP Servers menu item is dimmed when there are no accounts,
1828 as a future version of the UI spec will require. This fixes
1829 projects.maemo.org bug NB#56305.
1831 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1833 * src/maemo/modest-maemo-utils.c:
1834 (modest_maemo_utils_get_supported_secure_authentication_methods):
1835 Added label to dialog instead of unreadable title
1837 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1838 (modest_main_window_new):
1839 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1842 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1843 * src/modest-account-mgr.h:
1844 Added method to avoid code duplication
1846 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1847 (modest_ui_actions_on_send_receive):
1848 Use modest_account_mgr_has_accounts
1850 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/easysetup/modest-presets.c:
1853 (modest_presets_get_info_server_security): Do not report secure auth
1855 * src/modest-protocol-info.c: Use the defines for the gconf key names
1856 for secure authentication. This was not working because we were writing
1857 Password and reading password, and the check was case sensitive.
1858 With this, gmail now works for receiving and sending when created via
1861 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/easysetup/modest-presets.c:
1864 (modest_presets_get_info_server_security): Correct the key name for
1865 SecureSmtp, because it seems to be case-sensitive.
1866 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1867 Do not try to get the 0th notebook page if there are 0 pages, to
1868 avoid a g_warning().
1870 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1873 Prevent use of the new notification feature for now, because it currently
1874 shows one dialog for each new email, which is annoying.
1876 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1879 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1880 when no country was selected, so that we show the global ones.
1881 * src/maemo/easysetup/modest-presets.c:
1882 (modest_presets_get_providers): Return only the global providers, not
1883 all providers when mmc=0 was requested.
1885 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1887 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1888 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1889 provider ID in the combo.
1891 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1892 Do not show the page numbers, because it would be confusing when we add
1893 the 2 extra pages for the custom setup, when the user chooses the "Other"
1894 provider. This fixes projects.maemo.org bug NB#59028
1896 * src/modest-init.c: (modest_init_init_core),
1897 (modest_init_local_folders):
1898 * src/modest-init.h:
1899 * src/modest-tny-account.c:
1900 (modest_tny_account_new_for_local_folders): Do not create default folders
1901 for the memory card. This should fix projects.maemo.org bug NB#59328.
1903 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1906 Free the changed_conf_keys string items. They are already freed in the
1907 idle handler if that runs first.
1909 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1911 * src/modest-ui-actions.c:
1912 (modest_ui_actions_on_password_requested): Check that the server name
1913 is not NULL, because I just saw a password dialog with (null) as the
1916 * src/modest-tny-folder.[h|c]: Added
1917 modest_tny_folder_is_memory_card_folder().
1918 * src/modest-ui-dimming-rules.c:
1919 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1920 menu item for memory cards, as per the UI spec (section 7.4). This should
1921 fix projects.maemo.org bug NB#59297.
1923 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1925 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1926 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1927 is another problem with the code, see Murray's comment at line 772)
1929 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1931 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1932 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1933 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1934 (load_from_file), (easysetup_country_combo_box_init),
1935 (easysetup_country_combo_box_get_active_country_ids),
1936 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1937 instead of just one ID, to avoid duplicate country names in the UI.
1939 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1940 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1941 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1942 a single ID, avoiding duplicate providers.
1943 * src/maemo/easysetup/modest-easysetup-wizard.c:
1944 (on_combo_account_country): Adapt to use a list.
1946 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1948 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1949 keys changed in the last X seconds.
1951 * src/modest-account-mgr.h:
1952 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1953 (on_key_change), (modest_account_mgr_class_init),
1954 (modest_account_mgr_init), (modest_account_mgr_finalize):
1955 As the keys are changed, save them in a GSList* and signal that GSList*
1956 further every X seconds, to batch changes, to allow us to do just one
1957 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1958 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1960 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1961 changed signal signature.
1963 * src/modest-conf.c: (modest_conf_set_list),
1964 (modest_conf_on_change): Reenable notification.
1966 (modest_conf_maemo_fake_on_change): Comment out the hack that
1967 notified immediately instead of asynchronously.
1969 * src/widgets/modest-account-view.h:
1970 * src/widgets/modest-account-view.c:
1971 (update_account_view): Select the previously-selected account ID,
1972 if possible. This fixes projects.maemo.org bug NB#56933.
1974 (on_account_changed), (on_account_removed),
1975 (modest_account_view_select_account):
1977 Remove the block/unblock functions
1978 because they were not useful.
1980 * src/maemo/modest-account-view-window.c:
1981 (on_delete_button_clicked), (on_edit_button_clicked),
1982 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1984 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1987 Improve the error dialog to show Incorrect Account Settings, which seems
1988 clearer, and say that the internal error message (to be removed from the
1989 dialog later) is often misleading.
1990 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1992 * src/modest-tny-account.c:
1993 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1994 URL because this is so useful for debugging on the device.
1996 * src/widgets/modest-serversecurity-combo-box.c:
1997 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1999 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-mail-operation.c:
2002 (modest_mail_operation_send_new_mail):
2003 Added a comment about a nasty but apparently harmless message. Details
2004 added to the wiki g_warnings() page.
2006 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2009 (modest_tny_send_queue_class_init):
2010 Do not use the priv struct because it is empty, to avoid g_warnings
2011 about a non-existant priv struct.
2013 * src/modest-tny-account-store.c:
2014 (modest_tny_account_store_get_server_account),
2015 (modest_tny_account_store_get_transport_account_for_open_connection
2016 ): Do not try to get transport server accounts for local folders,
2017 because they don't have any. This avoids a g_warning().
2019 * src/maemo/modest-main-window.c:
2020 (modest_main_window_notify_send_receive_initied),
2021 (on_configuration_key_changed):
2022 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2023 * src/modest-defs.h:
2024 * src/modest-mail-operation.c:
2025 (modest_mail_operation_update_account):
2026 * src/modest-tny-account-store.h:
2027 * src/modest-tny-account.c:
2028 (modest_tny_account_get_special_folder),
2029 (modest_tny_account_new_for_local_folders),
2030 (modest_tny_account_new_for_per_account_local_outbox_folder):
2031 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2032 * src/modest-tny-local-folders-account.c:
2033 (add_account_folders_to_merged_folder):
2034 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2035 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2036 (modest_ui_actions_on_send):
2037 * src/widgets/modest-folder-view.c: (update_model):
2038 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2039 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2040 modest_tny_account_store_get_tny_account_by_account() to
2041 modest_tny_account_store_get_server_account() to make the code clearer.
2043 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2045 * src/dbus_api/modest-dbus-api.h:
2046 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2047 * src/maemo/modest-msg-edit-window.c:
2048 (modest_msg_edit_window_attach_file_noninteractive):
2049 added g_warning in case the file to be attached does not exist
2050 * tests/dbus_api/test_compose_mail.c: (main):
2051 removed obsolete comment, added generic files as test case
2053 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-tny-account-store.c: (get_server_accounts):
2056 Create the local folders account only once, not once for each outbox, and
2057 not only when there are some outboxes.
2059 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2061 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2062 code that is causing a crash at startup. Sergio says that he is fixing this.
2064 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2066 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2067 * src/maemo/modest-account-settings-dialog.c:
2068 (create_page_outgoing),
2069 (modest_account_settings_dialog_set_account_name),
2070 (save_configuration):
2071 - Fixed handling of the "Use secure authentication" toggle to comply with
2072 the ui specification. See also projects.maemo.org bug NB#58400
2074 - Restore the Secure connection setting combo correctly when loading
2077 * src/maemo/modest-maemo-utils.c:
2078 (on_camel_account_get_supported_secure_authentication),
2079 (modest_maemo_utils_get_supported_secure_authentication_methods):
2080 Fixed a crasher if operation is canceled
2082 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2083 (modest_protocol_info_auth_is_secure):
2084 * src/modest-protocol-info.h:
2086 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2087 the sense of the "Use secure authentication" toggle.
2089 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-tny-account-store.h:
2092 * src/modest-tny-account-store.c:
2093 Added modest_tny_account_store_get_local_folders_account().
2095 * src/modest-tny-folder.h:
2096 * src/modest-tny-folder.c:
2097 (modest_tny_folder_get_account):
2098 Added this replacement for tny_folder_get_account() which returns
2099 the local-folders account for TnyMergeFolders, to avoid the
2100 warning about the unimplemented get_account_func() vfunc().
2102 (modest_tny_folder_get_rules),
2103 * src/modest-ui-actions.c:
2104 (modest_ui_actions_on_folder_selection_changed):
2105 * src/modest-mail-operation.c:
2106 (modest_mail_operation_remove_folder),
2107 (modest_mail_operation_xfer_folder),
2108 (modest_mail_operation_rename_folder),
2109 (modest_mail_operation_get_msg),
2110 (modest_mail_operation_get_msgs_full),
2111 (modest_mail_operation_remove_msg),
2112 (modest_mail_operation_xfer_msgs),
2113 (modest_mail_operation_refresh_folder):
2114 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2116 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2118 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2119 (modest_server_account_set_security):
2120 * src/modest-defs.h: Add comments explaining that our
2121 UI spec means TLS when it says Normal, so these do not look like errors.
2123 * src/modest-tny-account.c:
2124 (modest_tny_account_new_from_server_account): Use the new tinymail
2125 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2126 for TLS. This should fix projects.maemo.org bug NB#58460.
2128 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2130 * src/maemo/easysetup/modest-easysetup-wizard.c:
2131 (create_account): Correct the position of the gconf sanity check warning.
2132 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2133 of using the g_idle_add() hack, because this does not seem to be necessary
2134 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2135 caused by something other than maemo's gconf.
2136 This fixes projects.maemo.org bug #59022.
2138 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-account-mgr-helpers.c:
2141 (modest_account_mgr_get_default_account): Do not check that the account
2142 exists if there is no default account (NULL), to fix a runtime warning.
2144 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2146 * src/widgets/modest-folder-view.c: (update_model):
2147 Do not unref the treemodel before we have finished with it.
2148 This prevents a valgrind warning and an occasional crash at startup.
2150 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2152 * libmodest-dbus-client/libmodest-dbus-client.h:
2153 added libmodest_dbus_client_compose_mail()
2154 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2156 added functions needed for SendAsMail() functionality
2157 * src/maemo/modest-msg-edit-window.c:
2158 (modest_msg_edit_window_attach_file_noninteractive):
2159 non interactively attaching files to message edit window
2160 * src/widgets/modest-msg-edit-window.h:
2161 * tests/dbus_api/Makefile.am:
2162 added test_compose_mail.c
2163 * tests/dbus_api/test_compose_mail.c: (main):
2165 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2167 * src/modest-account-view.c:
2168 Fixed bug projects.maemo.org bug NB#59307
2170 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2172 * src/maemo/easysetup/modest-easysetup-wizard.c:
2173 (get_serverport_incoming), (on_before_next), (create_account):
2174 * src/maemo/modest-account-settings-dialog.c:
2175 (modest_account_settings_dialog_set_account_name):
2176 * src/maemo/modest-maemo-utils.c:
2177 (on_camel_account_get_supported_secure_authentication_status),
2178 (on_camel_account_get_supported_secure_authentication),
2179 (on_secure_auth_cancel),
2180 (modest_maemo_utils_get_supported_secure_authentication_methods):
2182 Implemented security authentication for settings and easysetup.
2184 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/modest-main-window.c: (create_details_widget):
2187 Show the total size for memory card accounts too, instead of showing
2188 the name again. Fixes bug projects.maemo.org bug NB#59307.
2190 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2193 * src/modest-tny-simple-folder-store.c:
2194 * src/modest-tny-simple-folder-store.h: Removed.
2196 * src/modest-tny-local-folders-account.h
2197 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2198 for the local-folders maildir, with an extra TnyMergedFolder containing
2199 the folders of the per-account outbox store accounts.
2200 * src/modest-tny-account-store.c: (get_server_accounts):
2201 Add the outboxes to the special local folders account after creating it.
2203 * src/modest-tny-account.c:
2204 (modest_tny_account_new_for_local_folders): Create the derived
2205 account when creating the main local-folders account.
2207 * src/maemo/modest-main-window.c: (create_details_widget),
2208 (modest_main_window_set_contents_style):
2209 Adapted to the use of the derived account instead of the folder store.
2211 * src/modest-ui-actions.c:
2212 (modest_ui_actions_on_folder_selection_changed):
2213 * src/modest-ui-dimming-rules.c:
2214 (modest_ui_dimming_rules_on_new_folder):
2215 * src/widgets/modest-folder-view.c: (text_cell_data),
2216 (icon_cell_data), (filter_row), (update_model),
2217 (get_cmp_rows_type_pos):
2220 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2221 Do not get the priv struct, because no priv struct has been set,
2222 to avoid a runtime warning.
2224 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2225 #ifelse with #else, to fix a warning, to fix the build.
2228 2007-06-05 Christian Kellner <ckellner@openismus.com>
2230 * libmodest-dbus-client/libmodest-dbus-client.c:
2231 Fix small typo in doc (why do you always see them
2232 AFTER committing stuff?)
2235 2007-06-05 Christian Kellner <ckellner@openismus.com>
2237 * libmodest-dbus-client/libmodest-dbus-client.c:
2238 (libmodest_dbus_client_search):
2239 Initialize hit list with NULL. Also set folder list
2240 to "" if NULL was supplied.
2243 2007-06-03 Christian Kellner <ckellner@openismus.com>
2245 * libmodest-dbus-client/libmodest-dbus-client.c:
2246 (modest_search_hit_list_free):
2247 Make it save to call it with NULL.
2249 * src/dbus_api/modest-dbus-callbacks.c:
2250 * src/modest-search.c:
2251 Return full ModestSearchHits as the search result list not TnyHeader
2252 since can't be around withouth the correspoding TnyFolder.
2254 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2256 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2257 Added currently commented code to check for secure auth
2259 * src/maemo/modest-account-settings-dialog.c: (on_response),
2260 (save_configuration), (show_ok):
2261 Fixed projects.maemo.org bugs NB #59248 and #59251
2263 * src/maemo/modest-maemo-utils.c:
2264 (on_camel_account_get_supported_secure_authentication_status),
2265 (on_camel_account_get_supported_secure_authentication),
2266 (modest_maemo_utils_get_supported_secure_authentication_methods):
2267 * src/maemo/modest-maemo-utils.h:
2268 Moved get_supported_secure_authentication() method here to be able
2269 to use it from easysetup wizard.
2271 * src/modest-pair.c: (on_pair_compare_as_string):
2272 Should compare string with first part of pair and not
2273 strcmp pairs which will crash.
2275 * src/modest-protocol-info.c:
2276 (modest_protocol_info_protocol_is_store):
2277 * src/modest-protocol-info.h:
2278 Added modest_protocol_info_get_auth_protocol_name()
2280 2007-06-03 Armin Burgmeier <armin@openismus.com>
2282 * src/modest-mail-operation.c:
2283 (modest_mail_operation_get_msgs_full): Set priv->account also when
2284 only retrieving a single message. This avoids a crash when canceling
2287 (modest_mail_operation_notify_end): Do not explicitely remove the
2288 operation from the queue but only emit the progress_changed signal.
2289 The queue itself listens to that signal to remove the operation when
2290 it is finished. This reduces coupling and removes a potential deadlock
2291 when modest_mail_operation_notify_end() is called from the queue
2292 itself. If that is a problem performance-wise, I would suggest to
2293 implement a status-changed signal or something.
2295 * src/modest-mail-operation-queue.c: Make sure to never call a
2296 function from another file while the queue is locked. This (hopefully)
2297 fixes another deadlock when exiting the application while retrieving
2300 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2302 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2303 Fixed build if libogs is not available
2305 2007-06-03 Christian Kellner <ckellner@openismus.com>
2307 * libmodest-dbus-client/libmodest-dbus-client.h:
2308 * libmodest-dbus-client/libmodest-dbus-client.c:
2309 (libmodest_dbus_client_delete_message):
2310 Implement deletion of messages (Client side).
2312 (modest_search_hit_free),
2313 (modest_search_hit_list_free):
2314 Utility functions to free the result hits.
2316 * src/dbus_api/modest-dbus-api.h:
2317 * src/dbus_api/modest-dbus-callbacks.c:
2318 (on_delete_message),
2319 (modest_dbus_req_handler):
2320 Implement deletion of messages (Server side).
2322 * tests/dbus_api/test_search.c: (main):
2325 * tests/dbus_api/Makefile.am:
2326 * tests/dbus_api/test_delete_message:
2327 Add little test for the message deletion logic
2329 2007-06-03 Armin Burgmeier <armin@openismus.com>
2331 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2332 when the operation queue was not empty. projects.maemo.org bug
2335 2007-06-03 Armin Burgmeier <armin@openismus.com>
2337 * src/widgets/modest-account-view.c
2338 (on_account_default_toggled): Toggle default account column
2339 explicitely instead of waiting for gconf notification (which is
2340 currently ignored). This should fix projects.maemo.org bug NB#56910
2341 for now. It should probably be removed when gconf notifications are
2344 2007-06-03 Christian Kellner <ckellner@openismus.com>
2346 * libmodest-dbus-client/libmodest-dbus-client.c:
2347 Removed debugging spew.
2349 * src/dbus_api/modest-dbus-callbacks.c:
2350 Added debugging info.
2352 * src/modest-search.c:
2353 (modest_search_all_accounts):
2354 Use tny_account_store_get_accounts () on the account store
2355 to get all accounts which is the way to get all accounts.
2357 * tests/dbus_api/test_search.c: (main):
2358 Make it possible to supply the search term on the command line.
2360 2007-06-03 Christian Kellner <ckellner@openismus.com>
2362 * libmodest-dbus-client/libmodest-dbus-client.c:
2363 * libmodest-dbus-client/libmodest-dbus-client.h:
2364 Implement searching for mesages over raw dbus. (Client side)
2366 * src/dbus_api/Makefile.am:
2367 * src/dbus_api/modest-dbus-api.h:
2368 * src/dbus_api/modest-dbus-callbacks.c:
2369 * src/dbus_api/modest-dbus-callbacks.h:
2370 Search framework (Server side). Also implement on_idle_open_message().
2372 * src/maemo/modest-platform.c: (modest_platform_init):
2373 Prepare for raw dbus/osso rpc interaction.
2375 * src/modest-search.h:
2376 Changed minsize from unspecific guint to guint32.
2378 * src/modest-search.c:
2380 Added strange hack which magically made tnymail work.
2382 (modest_search_folder),
2383 (modest_search_account),
2384 (modest_search_all_accounts):
2385 Implement helper functions to search all accounts, specific account
2388 * tests/dbus_api/Makefile.am:
2389 * tests/dbus_api/test_open_message.c:
2390 Read url to open from commandline.
2392 * tests/dbus_api/test_search.c:
2393 Implement small test for dbus search stuff
2395 2007-06-02 Armin Burgmeier <armin@openismus.com>
2397 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2398 include account type and account title. This fixes projects.maemo.org
2401 * src/maemo/modest-account-view-window.c: Set a title for the window.
2403 2007-06-02 Armin Burgmeier <armin@openismus.com>
2405 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2406 incoming and outgoing server name based on email address and server
2407 types as long as the names have not been edited manually. This fixes
2408 projects.maemo.org bug NB#58671.
2410 2007-06-02 Armin Burgmeier <armin@openismus.com>
2412 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2413 server type cannot be changed in future to the incoming details page
2414 when creating an account. This fixes projects.maemo.org bug NB#59029.
2416 2007-06-02 Armin Burgmeier <armin@openismus.com>
2418 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2419 and assigned max width chars so that they wrap instead of being
2420 truncated. Fixes projects.maemo.org bug NB#56126.
2422 2007-06-02 Armin Burgmeier <armin@openismus.com>
2424 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2425 introductory note to the connection specific smtp servers dialog, as
2426 section 8.12 of the email UI specification requires. This fixes
2427 projects.maemo.org bug NB#59212.
2429 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2432 Check for running mail operations, and offer to cancel them, as per the UI
2433 spec. This fixes projects.maemo.org bug NB#59041 .
2434 However, I suspect that tinymail may still use the network connection
2435 in ways that we cannot detect or cancel. But it should at least adapt to
2436 changes fairly well.
2438 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2440 * src/modest-tny-account-store.c: (recreate_all_accounts),
2441 (get_cached_accounts), (get_server_accounts): Do more sensible
2442 ref-counting of the temporarily-cached outbox accounts list. This seems
2443 to fix a crash when entering the password when the password was wrong.
2445 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2447 * src/gnome/modest-main-window.c: (connect_signals):
2448 * src/modest-tny-account-store.c: (get_password),
2449 (modest_tny_account_store_alert): Added comments and clues and
2450 commented-out code about how we currently fail to deal with connection
2451 errors and wrong passwords, and how we should.
2453 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2455 * src/widgets/modest-retrieve-combo-box.c:
2456 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2457 This fixes projects.maemo.org bug NB#58472 .
2459 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/easysetup/modest-easysetup-wizard.c:
2462 (create_page_complete_easysetup):
2463 (create_page_complete_custom): Correct the last commit,
2464 putting the correct sentences in the correct pages.
2466 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/easysetup/modest-easysetup-wizard.c:
2469 (create_page_complete_custom): Show the second sentence of text
2470 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2473 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2475 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2476 Set the leave-on-server conf key by default. This fixes
2477 projects.maemo.org bug NB#59258 .
2479 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2481 * src/maemo/modest-account-view-window.c:
2482 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2483 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2486 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2488 * src/maemo/easysetup/modest-easysetup-wizard.c:
2489 (create_caption_new_with_asterisk):
2490 * src/maemo/modest-account-settings-dialog.c:
2491 (create_caption_new_with_asterisk):
2492 Uncomment the code to add the asterisk, because they are no longer in the
2493 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2494 (update_incoming_server_title): Add an asterisk here too.
2496 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2498 * src/maemo/modest-maemo-global-settings-dialog.c:
2499 (current_connection): Check that we are even connected before trying to
2500 get the current connection name, to prevent a warning.
2502 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2503 Change the comments because tny_maemo_conic_device_connect() is now meant to
2505 * src/modest-mail-operation.c:
2506 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2507 make sure we have a connection and fail if we can't connect.
2509 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/modest-main-window.c:
2512 (on_account_store_connecting_finished): Do not try to get the
2513 connection ID if we are not really connected. I am surprised that
2514 this signal handler is called when we are not connected.
2516 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2518 * src/modest-error.h:
2519 * src/modest-ui-actions.c:
2520 (modest_ui_actions_get_msgs_full_error_handler):
2521 Renamed an enum, added comments, added an enum
2522 for retrieve-limit errors.
2524 * src/modest-mail-operation.c: (foreach_add_item),
2525 (internal_folder_observer_update), (update_account_thread),
2526 (modest_mail_operation_get_msgs_full):
2527 (modest_mail_operation_update_account),
2528 Added comments about how this works, and some code that should
2529 (but does not) check the retrieve-limit. See the TODO comment.
2531 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2533 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2534 Initialize help_id to fix the build. Warnings are good.
2536 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2538 * src/widgets/modest-hbox-cell-renderer.c:
2539 (modest_hbox_cell_renderer_append):
2540 * src/widgets/modest-vbox-cell-renderer.c:
2541 (modest_vbox_cell_renderer_append):
2542 Fix the last commit by doing an extra ref.
2544 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2546 * src/widgets/modest-hbox-cell-renderer.c:
2547 (modest_hbox_cell_renderer_append):
2548 * src/widgets/modest-vbox-cell-renderer.c:
2549 (modest_vbox_cell_renderer_append):
2550 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2551 to fix the build with Maemo Bora.
2552 However, there seems to be a remaining crash, probably due to reference
2555 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2557 * src/modest-tny-account.c:
2558 (modest_tny_account_new_for_local_folders):
2559 Use hildon_file_system_info_async_new() to get a better name for
2560 the memory card account, setting it as the account name.
2561 The timing seems to work, but this is probably
2562 not the best place to do this. See the TODO comment.
2563 * src/maemo/modest-main-window.c: (create_details_widget):
2564 * src/widgets/modest-folder-view.c: (text_cell_data):
2565 Use the tny account name instead of hardcoding a name.
2567 2007-05-30 Christian Kellner <ckellner@openismus.com>
2569 * src/modest-search.c: (modest_search):
2570 Correctly set part_search_func even if we have already parsed
2571 the query and thus a valid OgsTextSearcher object.
2573 2007-05-30 Christian Kellner <ckellner@openismus.com>
2576 Search and check for libogs.
2579 Incooparte the ogs build env.
2581 * src/modest-mime-part-search-stream.c:
2582 * src/modest-mime-part-search-stream.h:
2583 Removed since we do the real searching now in modest-search.c.
2585 * src/modest-search.c:
2586 * src/modest-search.h:
2587 Implement support for ogs. We use that if available and requested
2588 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2589 should now handle the corner case when the search term is spread
2590 across multiple reads.
2591 Also the logic in modest_search () was corrected to search all
2592 requested fields until one is found.
2594 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2596 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2598 * src/modest-init.h:
2599 * src/modest-init.c: Made modest_init_local_folders() take a
2600 path and be public so we can iniitialize maildir folders on
2603 * src/modest-local-folder-info.h:
2604 * src/modest-local-folder-info.c:
2605 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2607 * src/modest-tny-account.c:
2608 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2609 still means the standard local-folders path on the local volume.
2611 * src/modest-tny-account-store.c:
2612 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2613 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2614 all accounts when that happens.
2615 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2616 this too, so it shows up in the treeview.
2618 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2620 * src/maemo/modest-maemo-global-settings-dialog.c:
2621 (current_connection):
2622 * src/widgets/modest-global-settings-dialog.c:
2623 (current_connection_default):
2624 Use the enum values instead of 0, 1 and -1,
2625 to make the code clearer.
2627 * src/modest-account-mgr-helpers.c:
2628 (modest_account_mgr_get_connection_specific_smtp): Make this code
2631 * src/modest-runtime.h:
2632 * src/modest-runtime.c:
2633 Added modest_runtime_remove_all_send_queues().
2634 * src/maemo/modest-main-window.c:
2635 (on_account_store_connecting_finished): Recreate the send queues,
2636 using the appropriate transport accounts for this new connection.
2637 Some futher adapting might be needed if the old send queues are not
2638 automatically stopped at this point.
2640 * src/modest-tny-account-store.c: (get_server_accounts):
2641 Create the connection-specific transport accounts, so that they can
2642 be found later by their ID.
2644 * src/modest-tny-account.h:
2645 * src/modest-tny-account.c:
2646 Added modest_tny_account_new_from_server_account_name().
2647 modest_tny_account_new_from_server_account(): Do not create the
2648 send queues here, because they will be
2649 recreated anyway when the connection changes for the first time.
2651 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-local-folder-info.h:
2654 * src/modest-local-folder-info.c:
2655 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2656 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2657 tbox_folder): Take a modest account name instead of a server TnyAccount,
2658 so we can have per-modest-account rather than per-transport-account
2660 We must make sure that we change or recreate the exisitng send queues
2661 when the connection changes for connection-specific transport accounts.
2663 * src/modest-tny-account-store.c:
2664 (create_per_account_local_outbox_folders): Create outboxed per modest
2665 account, not per transport account.
2667 * src/modest-tny-account.h:
2668 * src/modest-tny-account.c:
2669 (modest_tny_account_get_special_folder): For outboxes, get the
2670 parent modest account name. The account is ignored for other folders.
2671 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2672 modest account name rather than a server TnyAccount.
2674 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2676 * src/modest-tny-account.c:
2677 (modest_tny_account_new_from_server_account):
2678 Call modest_runtime_get_send_queue() immediately after creating transport
2679 accounts, so that they start trying to send email from the outbox as soon
2680 as possible at startup. This is probably what we want.
2682 * src/modest-mail-operation.c: (update_account_thread):
2683 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2684 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2685 * src/modest-tny-send-queue.h:
2686 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2687 (modest_ui_actions_on_send):
2688 Added comments about how sending works, though it needs some more work.
2690 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2692 * src/modest-tny-account.c:
2693 (modest_tny_account_get_special_folder): Add TODO because this fails when
2694 the network is busy.
2695 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2696 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2697 Do not try to show this window when there is no active account. The UI
2698 specs does not tell us what to do in this case.
2700 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2704 * src/maemo/Makefile.am:
2705 * src/widgets/Makefile.am: Some dist fixes.
2707 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2709 * src/maemo/modest-connection-specific-smtp-window.c:
2710 (on_button_edit): Make the code clearer, to prevent a double free.
2712 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/modest-account-settings-dialog.c:
2715 (modest_account_settings_dialog_set_account_name),
2716 Check the connection-specific smtp servers checkbox if there are any.
2718 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2719 (modest_connection_specific_smtp_edit_window_init):
2720 Start with a suitable port number.
2722 * src/modest-account-mgr-helpers.h:
2723 * src/modest-account-mgr-helpers.c: Added
2724 modest_account_mgr_get_has_connection_specific_smtp().
2726 (modest_account_mgr_set_connection_specific_smtp),
2727 (modest_account_mgr_remove_connection_specific_smtp),
2728 (modest_account_mgr_get_has_connection_specific_smtp),
2729 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2730 connection-specific smtp server accounts in the account, rather than
2731 the server account conf dir.
2733 This fixes bug projects.maemo.org bug NB#58263 .
2735 * src/modest-tny-account-store.c:
2736 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2737 if there are no server accounts yet, to prevent an infinite loop when there
2738 are no accounts. Document that one must be called before the other.
2740 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2742 * src/modest-account-mgr-helpers.c:
2743 (modest_account_mgr_get_default_account): Make sure that at least
2744 one account is always the default, if there are any enabled accounts.
2745 This is just a sanity check that shouldn't be necessary.
2747 * src/modest-account-mgr-priv.c:
2748 (_modest_account_mgr_account_from_key): Unescape the conf key to
2749 get the real account name. For instance, this is an issue if a space
2750 was in the account name, which can happen because the account name
2751 is generated from the display name.
2752 (_modest_account_mgr_get_account_keyname): Always escape the
2754 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2755 Unescape the conf keys to get the real account names.
2757 For instance, previously the is-default radio button in the accounts
2758 list was not checked for any accounts at first. This fixes that,
2759 and might fix several similar bugs.
2761 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2764 Removed some debug printfs.
2766 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2768 Modest on-disk outbox directories are now here, for instance:
2769 $HOME/.modest/outboxes/<account-id-1>/outbox
2770 $HOME/.modest/outboxes/<account-id-2>/outbox
2772 $HOME/.modest/local-folders/outbox
2773 so we can have a separate outbox for each account.
2774 But they are shown as one outbox in the GtkTreeView, by using a
2775 TnyMergeFolder in a ModestTnySimpleFolderStore.
2778 * src/modest-tny-simple-folder-store.c:
2779 * src/modest-tny-simple-folder-store.h:
2780 Added ModestTnySimpleFolderStore, used to contain folders from
2781 other folder stores, such as other accounts.
2783 * src/modest-tny-outbox-account.h:
2784 * src/modest-tny-outbox-account.c:
2785 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2786 used for the per-account local outbox folders.
2788 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2789 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2790 only use this (internally) now for the non-outbox local folders.
2792 * src/modest-init.h:
2793 * src/modest-init.c: Added modest_init_one_local_folder(), for
2794 setting up the directory structure for each local folder.
2796 * src/modest-local-folder-info.c:
2797 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2798 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2800 * src/modest-local-folder-info.h:
2801 * src/modest-tny-account-store.c: (on_account_removed),
2802 (on_account_changed), (create_per_account_local_outbox_folders),
2803 (get_server_accounts), (modest_tny_account_store_get_accounts),
2804 (modest_tny_account_store_get_tny_account_by_account),
2805 (modest_tny_folder_store_is_virtual_local_folders):
2807 * src/modest-tny-account.h:
2808 * src/modest-tny-account.c:
2809 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2810 to create an on-disk per-account local outbox folder for each
2812 (create_per_account_local_outbox_folders): Create a local outbox folder
2813 for each transport account.
2814 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2815 for all local folders.
2817 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2818 instead of using g_object_get/set() directly. It is clearer.
2820 (modest_tny_folder_store_get_message_count),
2821 (modest_tny_folder_store_get_local_size
2822 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2823 because we now use these with non-acount folder stores.
2825 (modest_tny_account_get_special_folder),
2826 (modest_tny_account_new_from_server_account),
2827 (modest_tny_account_new_from_account):
2828 (recurse_folders): Adjust to the new outbox system.
2830 * src/modest-tny-folder.h:
2831 * src/modest-tny-folder.c:
2832 (modest_tny_folder_is_local_folder),
2833 (modest_tny_folder_get_local_folder_type),
2834 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2836 * src/widgets/modest-main-window.h:
2837 * src/maemo/modest-main-window.c: (create_details_widget),
2838 (modest_main_window_set_contents_style): Show details for any folder store,
2841 (modest_tny_folder_get_rules):
2842 Remove the const. C does not support constness enough for this.
2844 * src/modest-ui-actions.c:
2845 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2846 make all outboxes appear as one, in the usual local-folders tree node.
2848 (set_active_account_from_tny_account),
2849 (modest_ui_actions_on_folder_selection_changed):
2850 * src/widgets/modest-folder-view.c: (text_cell_data),
2851 (icon_cell_data), (filter_row),
2852 (add_account_folders_to_merged_folder),
2853 (add_account_folders_to_simple_folder_store), (),
2854 (get_cmp_rows_type_pos), (cmp_rows),
2855 (modest_folder_view_set_account_id_of_visible_server_account):
2856 Adjust to the new outbox system, using generic folder stores and folders
2857 in the GtkTreeModel.
2859 2007-05-23 Christian Kellner <ckellner@openismus.com>
2861 * src/modest-mail-operation.c:
2862 (modest_mail_operation_update_account):
2863 Use info->max_size instead of unintialized local var [small
2864 build fix]. (Added TODO to review that change since I don't
2867 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2869 * libmodest-dbus-client/libmodest-dbus-client.c:
2870 (libmodest_dbus_client_compose_mail): function added
2871 * src/dbus_api/modest-dbus-api.h:
2872 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2873 (on_compose_mail): Implementation of the SendAsMail functionality
2875 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2877 * src/modest-account-mgr.c:
2878 (modest_account_mgr_add_server_account): Set the secure-connection
2879 conf key for transport accounts as well as store accounts. I don't know
2880 why the if was there. For instance, this makes sure that we use SSL
2881 for the gmail preset from the easysetup wizard.
2883 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2885 * src/gnome/modest-main-window.c:
2886 (on_account_store_connecting_finished), (connect_signals):
2887 * src/maemo/modest-main-window.c:
2888 (on_account_store_connecting_finished), (connect_signals),
2889 (modest_main_window_new):
2890 Handle TnyAccountStore::connecting-finished instead of
2891 TnyDevice::connection-changed, because we cannot actually perform
2892 operations on accounts until TnyAccountStore has itself responded to
2893 the TnyDevice::connection-changed signal. This prevents a GError from
2895 Do not try to update at startup, because we (at least on scratchbox)
2896 already do an update at startup when the device goes online.
2897 This prevents a GError from tinymail.
2898 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2899 Added TODO about stopping simultaneous operations.
2901 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2903 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2904 * src/modest-mail-operation-queue.c:
2905 (modest_mail_operation_queue_remove):
2906 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2907 about where they happened.
2909 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-ui-actions.c:
2912 (modest_ui_actions_on_password_requested): Make sure that the remember
2913 output parameter is always TRUE.
2915 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2917 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2918 Show a OK/Cancel dialog if the error is a question, though we still do not
2919 know anything more about what we are asking the user.
2920 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2921 Fix an uninitialized variable (helper). This is a logic error, however.
2923 2007-05-21 Christian Kellner <ckellner@openismus.com>
2925 * src/modest-search.h:
2926 Correct bit shifting in the ModestSearchFlags enum.
2928 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2930 * src/modest-tny-account.c:
2931 (modest_tny_account_new_from_server_account): Do not use the lsub and
2932 check-all hard-coded IMAP options when using POP.
2934 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2936 * src/modest-tny-account.c:
2937 (modest_tny_account_new_from_server_account):
2938 Use NULL for the secure-auth method for POP when Password auth has been
2939 specified by the user, as we already do for IMAP. "auth=Login" causes
2940 an error from camel or the server.
2942 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2944 * src/maemo/modest-account-settings-dialog.c:
2945 (create_page_account_details),
2946 (modest_account_settings_dialog_set_account_name):
2947 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2948 for the leave-on-server checkbox, rathr than just the checkbox, when
2949 the protocol is not POP.
2951 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2953 * src/widgets/modest-account-view.c:
2954 * src/widgets/modest-account-view.h:
2955 Added modest_account_view_select_account() which will be useful later
2956 to asynchronously re-select the edited account.
2958 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2960 * src/maemo/modest-account-settings-dialog.c:
2961 (modest_account_settings_dialog_set_account_name):
2962 Automatically choose the port numbers based on the secure authentication
2963 methods, if they have not been chosen before.
2964 This fixes projects.maemo.org bug NB#56273 .
2966 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2968 * src/maemo/modest-main-window-ui.h:
2969 * src/modest-ui-actions.c:
2970 * src/modest-ui-actions.h:
2971 Connect the Tools/SMTP Servers menu item to
2972 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2973 SMTP servers dialog, as in the UI specification and saves changes when it
2974 is closed. This fixed projects.maemo.org bug NB#56305 .
2976 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2978 * src/maemo/modest-connection-specific-smtp-window.c:
2979 (modest_connection_specific_smtp_window_init):
2980 Use gtk_window_set_default_size() to make this window big enough, so
2981 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2983 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2985 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2986 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2987 (modest_connection_specific_smtp_edit_window_init),
2988 Do not try to connect to a combobox signal before the combobox exists.
2989 This fixes the cras in projects.maemo.org bug NB#56288 .
2990 (modest_connection_specific_smtp_edit_window_get_settings):
2991 Remove the server_account_name parameter which was being checked for NULL
2992 though it was not used.
2994 * src/maemo/modest-connection-specific-smtp-window.c:
2995 (modest_connection_specific_smtp_window_fill_with_connections),
2996 (on_button_edit), (modest_connection_specific_smtp_window_init):
2997 Correct the number of treemodel columns to prevent a warning.
2998 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2999 libconic does not work.
3001 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3003 * src/modest-tny-account.c:
3004 (modest_tny_account_new_from_server_account):
3005 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3006 SMTP when "None" was chosen by the user. However, with my SMTP server that
3007 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3010 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3012 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3013 to explain the memory management issue with the ID in the ModestPair.
3015 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3016 (add_sending_page), (modest_account_assistant_finalize):
3017 * src/gnome/modest-gnome-global-settings-dialog.c:
3018 (create_updating_page), (create_composing_page):
3019 * src/gnome/modest-msg-edit-window.c: (get_transports),
3020 (init_window), (modest_msg_edit_window_finalize),
3021 (modest_msg_edit_window_get_msg_data):
3022 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3023 * src/gnome/modest-transport-widget.c:
3024 (modest_transport_widget_finalize), (smtp_configuration):
3025 * src/maemo/modest-maemo-global-settings-dialog.c:
3026 (create_updating_page), (create_composing_page):
3027 * src/maemo/modest-msg-edit-window.c: (get_transports),
3028 (init_window), (modest_msg_edit_window_finalize),
3029 (modest_msg_edit_window_get_msg_data),
3030 (modest_msg_edit_window_free_msg_data):
3031 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3032 (modest_store_widget_finalize):
3033 * src/maemo/modest-transport-widget.c:
3034 (modest_transport_widget_finalize), (smtp_configuration):
3035 * src/modest-main.c: (send_mail):
3036 * src/widgets/modest-combo-box.h:
3037 * src/widgets/modest-global-settings-dialog-priv.h:
3038 * src/widgets/modest-global-settings-dialog.c:
3039 (modest_global_settings_dialog_finalize):
3040 * src/widgets/modest-msg-edit-window.h:
3041 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3042 as long as the combo box, to prevent use of freed memory for the ID.
3044 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3046 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3047 get_accounts(), to make this clearer. Do not check for the enabled gconf
3048 key, because we do not use this for server accounts (at least, not yet).
3049 This allows us to send email again.
3051 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3053 * src/maemo/modest-platform.c:
3054 (on_modest_conf_update_interval_changed), (modest_platform_init):
3055 Only respond to this particular key change. All these strcmp()s cannot be
3058 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3060 * src/maemo/modest-maemo-global-settings-dialog.c:
3061 (current_connection): Prevent a crash in scratchbox when
3062 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3063 * src/maemo/modest-platform.c:
3064 (on_modest_conf_update_interval_changed), (modest_platform_init):
3065 Get the update interval from gconf and reset it when the gconf key changes.
3067 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3069 * src/modest-protocol-info.c:
3070 * src/modest-protocol-info.h: Adde enum-specific get functions,
3071 instead of using a ModestProtocolType enum parameter.
3073 * src/gnome/modest-account-assistant.c:
3074 * src/gnome/modest-store-widget.c:
3075 * src/gnome/modest-store-widget.h:
3076 * src/gnome/modest-transport-widget.c:
3077 * src/gnome/modest-transport-widget.h:
3078 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3079 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3080 * src/maemo/easysetup/modest-easysetup-wizard.c:
3081 * src/maemo/modest-account-settings-dialog.c:
3082 * src/maemo/modest-account-settings-dialog.h:
3083 * src/maemo/modest-store-widget.c:
3084 * src/maemo/modest-store-widget.h:
3085 * src/maemo/modest-transport-widget.c:
3086 * src/maemo/modest-transport-widget.h:
3087 * src/modest-account-mgr-helpers.c:
3088 * src/modest-account-mgr-helpers.h:
3089 * src/modest-account-mgr.c:
3090 * src/modest-account-mgr.h:
3091 * src/modest-tny-account.c:
3092 * src/modest-tny-folder.c:
3093 * src/widgets/modest-account-view.c:
3094 * src/widgets/modest-retrieve-combo-box.c:
3095 * src/widgets/modest-retrieve-combo-box.h:
3096 * src/widgets/modest-secureauth-combo-box.c:
3097 * src/widgets/modest-serversecurity-combo-box.c:
3098 * src/widgets/modest-serversecurity-combo-box.h:
3099 * tests/check_account-mgr.c:
3100 Use the specific functions, and use the re-renamed enum values for GNOME too.
3102 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3104 * src/modest-pair.h:
3105 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3106 so we can get the second based on the first.
3108 * src/maemo/modest-account-settings-dialog.h:
3109 * src/maemo/modest-account-settings-dialog.c:
3110 Added get_supported_secure_authentication_methods(), though it is mostly
3111 commented-out for now until the necessary API is committed to tinymail.
3112 (modest_account_settings_dialog_set_account_name),
3113 (save_configuration): Request the supported authentication methods from the
3114 server, so we can choose a working method.
3116 * src/modest-tny-account-store.h:
3117 * src/modest-tny-account-store.c:
3118 (modest_tny_account_store_get_session): Rename from
3119 tny_account_store_get_session().
3121 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3123 * src/modest-protocol-info.h: Split the ModestProtocol enum
3124 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3125 There was no need to have these unrelated values in one enum.
3127 * src/: many files: Adapted to changed enum. This makes the code a bit
3128 clearer, and the compiler could catch some errors.
3130 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3132 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3133 Show the detailed internal camel error message when an error happens
3134 during the configuration, so that our testers can give us more clues.
3135 For instance, in projects.maemo.org bug NB#56910 .
3137 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3139 * src/modest-tny-account.c:
3140 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3141 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3143 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3145 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3146 * src/maemo/modest-account-settings-dialog.c:
3147 (modest_account_settings_dialog_set_account_name),
3148 (save_configuration): For the incoming secure authentication checkbox,
3149 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3150 the UI specification. PLAIN does not seem to be supported for most IMAP
3151 servers anyway, and I am not sure what it would mean.
3152 However, we probably need to discover which of the secure-authentication
3153 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3154 * src/modest-account-mgr-helpers.c:
3155 (modest_account_mgr_get_server_account_data):
3157 * src/modest-tny-account.c:
3158 (modest_tny_account_new_from_server_account):
3159 Use tny_account_set_mech() to set secure-authentication methods,
3160 with some special-casing for IMAP, based on my observations of how
3163 * src/modest-account-mgr-helpers.h:
3164 * src/modest-account-mgr.c:
3165 * src/modest-defs.h: Comment that the URI is only used for local folders.
3167 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3169 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3170 parameter const, just to be neat.
3171 * src/modest-text-utils.c: (modest_text_utils_inline):
3172 End g_strconcat() with NULL, as its documentation says. This is almost
3173 certainly the cause of my crash at startup on the device. Interestingly,
3174 valgrind doesn't tell us about these errors.
3176 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3178 * scripts/build-packages: Added more precise comments about how to use
3179 this script, though I still get this error:
3180 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3181 error building tinymail
3183 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3185 * src/maemo/modest-main-window.c: (on_account_update):
3186 Very slight cleanup, hoping to make it simpler to discover what causes
3187 a crash here sometimes.
3189 * src/modest-tny-account.c:
3190 (modest_tny_account_new_from_server_account): Set the port. Added
3191 comments about the options and a TODO comment because I need to find out
3192 how to specify the secure authentication method.
3194 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3196 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3197 changed CFlags paths form modest to libmodest
3199 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-account-mgr-helpers.c:
3202 (modest_account_mgr_get_server_account_data),
3203 (modest_account_mgr_free_server_account_data):
3204 * src/modest-account-mgr-helpers.h:
3205 * src/modest-account-mgr.c:
3206 (modest_account_mgr_add_server_account):
3207 * src/modest-defs.h:
3208 * src/modest-tny-account.c:
3209 (modest_tny_account_new_from_server_account):
3210 Determine the options for tny_camel_account_add_option() here,
3211 based on the settings, rather than storing them directly in gconf.
3213 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3215 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3216 Show a more friendly error dialog now that we expect (from the tinymail
3217 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3219 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/modest-main-window.c: (on_account_update): Check that
3222 account_name is not NULL, to prevent a crash at startup that I am
3223 seeing on the N800. I do wonder why it is NULL.
3225 * src/maemo/easysetup/modest-easysetup-wizard.c:
3226 (create_page_user_details):
3227 * src/maemo/modest-account-settings-dialog.c:
3228 (create_page_user_details), (create_page_outgoing):
3229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3230 (modest_connection_specific_smtp_edit_window_init):
3231 * src/modest-ui-actions.c:
3232 (modest_ui_actions_on_password_requested):
3233 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3234 might do something useful with the on-screen keyboard.
3236 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3238 * src/maemo/modest-main-window.c: (on_account_update):
3239 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3240 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3242 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3244 * src/modest-tny-account-store.c: (on_account_changed):
3245 Correct the signature of this signal handler.
3247 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3249 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3250 Show a HildonNote instead of a GtkDialog for Maemo.
3252 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3254 * src/widgets/modest-account-view.h:
3255 * src/widgets/modest-account-view.c: (on_account_changed),
3256 (on_account_removed). Added a boolean flag, set/unset by
3257 modest_account_view_block_conf_updates(),
3258 modest_account_view_unblock_conf_updates() to prevent unnecessary
3259 updates, but this is not very useful because the gconf notifications are
3260 so delays (maybe only on Maemo Bora).
3261 So auto-updating is turned off, and these functions do an explicit
3262 update when necessary.
3263 However, something else is still doing too much work when adding/removing
3264 accounts, probably in another part of the application.
3266 * src/maemo/modest-account-view-window.c:
3267 (on_delete_button_clicked), (on_edit_button_clicked),
3268 (on_new_button_clicked): Use the new functions.
3270 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3272 * src/modest-account-mgr-helpers.c:
3273 (modest_account_mgr_set_first_account_as_default):
3274 Sort the list of names alphabetically-by-title, so we choose the first one
3276 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3277 alphabetically by the title.
3279 This fixes projects.maemo.org bug NB#56418 .
3281 * src/modest-account-mgr-priv.c:
3282 (_modest_account_mgr_account_from_key):
3283 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3284 avoid a valgrind error, and possible random behaviour.
3286 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3288 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3289 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3290 tinymail documentation to say that this can be expected.
3291 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3292 pretty, and should not happen, but I would prefer to know when it does.
3294 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3296 * configure.ac: When using the older hildon version, probably on Bora,
3297 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3299 * src/widgets/modest-attachment-view.c:
3300 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3303 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3305 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3306 Implemented the prototype. Can be tested with
3307 tests/dbus_api/test_open_message:
3309 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3311 * src/modest-tny-account-store.c:
3312 (modest_tny_account_store_instance_init), (get_password):
3313 * src/modest-ui-actions.c:
3314 (modest_ui_actions_on_password_requested):
3315 Do not store the password in gconf, because this function is called
3316 for non-remembered passwords. Actually use the cached (in the hash map)
3317 password instead of releasing it.
3318 The password will now not be remembered if it is asked via the protected
3319 password dialog, as per the UI spec.
3321 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3323 * src/modest-defs.h:
3324 * src/modest-account-mgr-helpers.h:
3325 * src/modest-account-mgr-helpers.c:
3326 Added modest_server_account_get_username_has_succeeded(),
3327 modest_server_account_set_username_has_succeeded().
3328 (modest_server_account_set_username),
3329 Reset the has-succeeded flag if the username changes.
3331 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3332 * src/maemo/modest-connection-specific-smtp-window.c:
3333 (modest_connection_specific_smtp_window_save_server_accounts):
3334 Use modest_server_account_set_username() instead of using
3335 modest_conf_set_string() directly, so that the has-succeeded flag is always
3338 * src/modest-ui-actions.c:
3339 (modest_ui_actions_on_password_requested): Dim the username entry if
3340 the username has ever worked, as per the UI spec.
3342 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3344 * src/modest-tny-account-store.c: (get_password):
3345 * src/modest-ui-actions.c:
3346 (modest_ui_actions_on_password_requested):
3347 Allow the username to be changed too, though there is more work to
3348 be done on exactly how this behaves.
3350 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3352 * src/modest-account-mgr-helpers.h:
3353 * src/modest-account-mgr-helpers.c:
3354 Added modest_account_mgr_get_display_name(),
3355 modest_server_account_get_username(),
3356 modest_server_account_set_username(),
3357 modest_server_account_set_password(),
3358 modest_server_account_get_hostname() functions so we do not need to
3359 use the conf API directly.
3361 * src/maemo/modest-main-window.c: (connect_signals):
3362 Actually connect ot the ModestAccountStore::request-password signal,
3363 so that we show the dialog when the password is requested by Tinymail,
3364 for isntance if it is empty.
3366 * src/modest-marshal.list:
3367 * src/modest-tny-account-store.c:
3368 (modest_tny_account_store_class_init), (get_password),
3369 (modest_tny_account_store_alert):
3370 * src/modest-tny-account-store.h:
3371 * src/modest-ui-actions.h:
3372 * src/modest-ui-actions.c:
3373 (modest_ui_actions_on_password_requested):
3374 Change the signal parameters, so it is obvious that we are providing
3375 the non human-readable server name, and receiving both the username
3376 and password, though changing of the username is not yet implemented.
3377 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3378 for the GNOME version.
3380 This should fix the projects.maemo.org bug NB#56209, though it does not
3381 work on Bora, because the gconf_client_get() for the password fails
3382 immediately after we save it with gconf_client_set().
3384 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3387 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3388 caused an undefined symbol error:
3389 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3391 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3393 * src/modest-tny-account-store.c:
3394 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3395 using a GError instead of a string message, so we can translate it in
3398 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3400 * src/maemo/modest-address-book.c:
3401 (modest_address_book_check_names):
3402 * src/maemo/modest-msg-view-window.c:
3403 (modest_msg_view_window_clipboard_owner_change):
3404 * src/modest-init.c: (modest_init_init_ui):
3405 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3406 (update_folders_cb), (modest_mail_operation_update_account):
3407 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3408 (modest_ui_actions_on_msg_attachment_clicked),
3409 (modest_ui_actions_on_msg_recpt_activated):
3410 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3411 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3412 (modest_msg_view_search_next):
3413 * src/widgets/modest-recpt-editor.c:
3414 (modest_recpt_editor_on_button_release_event),
3415 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3416 g_message(). At this point we should only be seeing interesting errors on
3417 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3419 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3421 (modest_wizard_dialog_force_title_update):
3422 * src/maemo/easysetup/modest-wizard-dialog.h:
3423 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3424 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3425 can update the title when appropriate. Otherwise the title is wrong if the
3426 pages are added after adding the notebook to the dialog.
3427 This must be a problem in HildonWizardDialog too.
3428 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3430 * src/maemo/easysetup/modest-easysetup-wizard.c:
3431 (create_subsequent_customsetup_pages),
3432 (create_subsequent_easysetup_pages):
3433 Call modest_wizard_dialog_force_title_update() so that the title is
3434 correct even with GTK+ < 2.10.
3435 This fixes projects.maemo.org bug NB#56145 .
3437 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3439 * src/maemo/modest-platform.c:
3440 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3441 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3444 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3446 * src/widgets/modest-window.h:
3447 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3448 and modest_window_save_state(), which invokes it.
3450 * src/widgets/modest-window-mgr.h:
3451 * src/widgets/modest-window-mgr.c:
3452 Added modest_window_mgr_save_state_for_all_windows(), which calls
3453 the save_state vfunc on all registered windows, if implemented.
3455 * src/gnome/modest-msg-edit-window.c:
3456 * src/gnome/modest-msg-view-window.c:
3457 * src/maemo/modest-msg-edit-window.c:
3458 * src/maemo/modest-msg-view-window.c:
3459 * src/maemo/modest-main-window.c:
3460 Specify the existing save_settings functions as implementations of
3461 ModestWindow::save_state_func().
3463 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3464 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3465 enabling hibernation, for instance.
3467 We may need to do the same thing for restoring settings.
3470 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3472 * src/widgets/modest-window-mgr.c:
3473 * src/widgets/modest-window-mgr.h:
3474 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3475 modest_window_mgr_get_hibernation_is_prevented().
3477 * src/maemo/modest-main-window.c:
3478 (on_hildon_program_is_topmost_notify): Prevent hibernation
3479 (possible when the application goes to the background in the WM),
3480 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3482 * src/maemo/easysetup/modest-easysetup-wizard.c:
3483 (modest_easysetup_wizard_dialog_init):
3484 * src/maemo/modest-account-settings-dialog.c:
3485 (modest_account_settings_dialog_init):
3486 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3487 (modest_connection_specific_smtp_edit_window_init):
3488 * src/maemo/modest-connection-specific-smtp-window.c:
3489 (modest_connection_specific_smtp_window_init):
3490 * src/maemo/modest-signature-editor-dialog.c:
3491 (modest_signature_editor_dialog_init):
3492 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3493 prevent hibernation while any of these account settings dialogs are open.
3495 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3497 * src/maemo/Makefile.am:
3498 * src/maemo/modest-osso-state-saving.c:
3499 * src/maemo/modest-osso-state-saving.h: Added
3500 modest_osso_load_state() and modest_osso_save_state() though they do
3501 nothing now. They should iterate through all the open windows and load/save
3503 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3504 save state when closing.
3506 * src/maemo/modest-main-window.c:
3507 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3508 Add a notification handler for the HildonProgram::is-topmost property,
3509 so we can allow hibernation when the application goes into the background.
3510 But we still need to detect when the accounts setup windows are open so
3511 we can stop hibernation when they are open.
3512 To do this, I also added the main window the HildonProgram. This might have
3513 other side-effects/benefits, and should maybe be done for other windows.
3515 * src/maemo/modest-osso-autosave-callbacks.h:
3516 * src/maemo/modest-osso-autosave-callbacks.c:
3517 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3518 though it does not do anything yet, and we might never need this to do
3519 anything. For instance, we already save drafts.
3521 * src/maemo/modest-platform.c: (modest_platform_init):
3522 Specify the libosso auto-save callback.
3524 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/modest-platform.c:
3527 (modest_platform_set_update_interval):
3528 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3529 aparently stays valid between application instances, so we can use this
3530 to remove and reset it later. According to a maemo-developers email from
3533 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3535 * configure.ac: Depend on libalarm for Maemo.
3537 * src/dbus_api/modest-dbus-api.h:
3538 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3539 (on_send_receive), (modest_dbus_req_handler):
3540 Handle a SEND_RECEIVE D-Bus method.
3542 * libmodest-dbus-client/libmodest-dbus-client.c:
3543 (libmodest_dbus_client_send_and_receive):
3544 * libmodest-dbus-client/libmodest-dbus-client.h:
3545 Add C convenience functions for calling the new D-Bus method.
3547 * src/modest-platform.h:
3548 * src/gnome/modest-platform.c:
3549 * src/maemo/modest-platform.c:
3550 Added modest_platform_set_update_interval(), which uses the
3551 alarmd API on Maemo.
3552 (modest_platform_init),
3553 Call modest_platform_set_update_interval(), using a hard-coded
3554 interval for now (until the global settings dialog is implemented),
3555 though I am not sure that this makes sense yet.
3557 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3559 * src/dbus_api/modest-dbus-callbacks.c:
3560 (modest_osso_cb_hw_state_handler):
3561 * src/dbus_api/modest-dbus-callbacks.h:
3562 * src/maemo/modest-platform.c: (modest_platform_init):
3563 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3564 in case this has some effect on the ability for Maemo to ping the
3567 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3569 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3570 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3571 warning. It is probably a logic error, but I need to fix the build.
3573 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3575 * src/modest-account-mgr.h:
3576 * src/modest-account-mgr.c:
3577 (modest_account_mgr_account_names): Add a gboolean enabled_only
3578 parameter, so we can get lists of onlt the enabled accounts.
3580 (modest_account_mgr_add_account),,
3581 (modest_account_mgr_account_with_display_name_exists):
3582 * src/maemo/modest-msg-edit-window.c: (get_transports):
3583 * src/modest-account-mgr-helpers.c:
3584 (modest_account_mgr_set_first_account_as_default):
3585 * src/modest-init.c: (init_default_account_maybe):
3586 * src/modest-tny-account-store.c: (get_accounts):
3587 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3588 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3589 * tests/check_account-mgr.c: (START_TEST):
3590 Provide the extra parameter, as appropriate.
3592 * src/widgets/modest-account-view.c: (update_account_view):
3593 Do not show disabled accounts (meaning that there is no way to
3594 enable/disable accounts in the UI (the feature is not in our UI
3595 specification), so we can use this internally only to mark unfinished
3596 or temporary account data.
3598 * src/maemo/easysetup/modest-easysetup-wizard.c:
3599 (create_account): Add boolean enable parameter, so we can specify FALSE
3600 to create the temporary account.
3601 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3602 (on_before_next): When finishing, when there is a temporary account, just
3604 Also, use a timeout to delay the showing of the dialog until gconf is likely
3605 to return correct information, due to a maemo gconf bug that is fixed in
3606 osso 1.1, but not yet in Bora.
3607 However, the dialog stays on screen after it is destroyed.
3609 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3610 for invalid data when cancelling. Use a hildon note instead of a dialog
3611 to complain about invalid data. Do not show the account-saved note if the
3612 account is disabled (a temporary account that will not really be saved for use
3615 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3617 * src/modest-account-mgr-helpers.h:
3618 * src/modest-account-mgr-helpers.c:
3619 Added modest_account_mgr_unset_default_account(),
3620 Added modest_account_mgr_set_first_account_as_default().
3622 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3623 If it was the default account, unset the default account name.
3625 * src/maemo/modest-account-view-window.c:
3626 (on_delete_button_clicked): If it was the default account,
3627 set the first remaining account as the default instead.
3629 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3630 a NULL account or a NULL default account, to prevent a crash. This should
3631 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3634 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3636 * src/widgets/modest-recpt-editor.c:
3637 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3638 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3639 TODO comment for this. This fixes the build.
3641 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3642 be the best place for it. This will in future update all auto-update accounts,
3643 rather than just the current/default account, when that gconf key exists.
3644 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3645 if there are no accounts, before calling do_send_receive().
3646 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3648 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3649 * src/maemo/modest-main-window-ui.h:
3650 * src/maemo/modest-main-window.c: (on_connection_changed),
3651 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3652 directly, becaue the signal handler does more.
3654 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3656 * src/modest-account-mgr-helpers.c:
3657 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3658 for the case that the account does not exist.
3660 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3661 (equivalent to the modest account name) rather than the tinymail account name
3662 (equivalent to the modest account title - human readable) to get the account data.
3663 Check for null account data to prevent the crash, and add a TODO comment saying that
3664 this needs fixing because it is using the server account name instead of the account name.
3666 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3668 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3669 * src/maemo/modest-account-settings-dialog.c: (show_error),
3671 Use hildon_note_new_information() for informative and error messages,
3672 which seems to be expected for Maemo applications (no documentation that I know of
3673 says this). I am surprised that there is no distinction between info and error
3676 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3678 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3679 it is easy to find where this is used.
3681 * src/maemo/easysetup/modest-easysetup-wizard.c:
3682 (create_page_welcome), (create_page_account_details),
3683 (create_page_user_details), (create_page_complete_easysetup),
3684 (create_page_custom_incoming), (create_page_custom_outgoing),
3685 (create_page_complete_custom):
3686 * src/maemo/modest-account-settings-dialog.c:
3687 (create_page_account_details), (create_page_user_details),
3688 (create_page_incoming), (create_page_outgoing):
3689 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3690 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3691 (modest_connection_specific_smtp_edit_window_init):
3692 * src/maemo/modest-connection-specific-smtp-window.c:
3693 (modest_connection_specific_smtp_window_init):
3694 * src/maemo/modest-signature-editor-dialog.c:
3695 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3696 and scrolling policy as per the Email Application Layout Guide, if I have
3699 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3701 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3702 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3703 which were empty, because these vfuncs have been removed from TnyAccountStore.
3704 This fixes the build.
3706 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3708 * src/maemo/modest-main-window.c:
3709 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3710 showing/hiding it. Added TODO because it probably should not be NULL.
3711 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3712 because unnecessary g_warnings() make degugging difficult.
3714 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/modest-msg-edit-window.c:
3717 (modest_msg_edit_window_select_color),
3718 (modest_msg_edit_window_select_background_color): 2 const corrections and
3719 moving 2 #endifs before closing brackets, to fix the build.
3721 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3723 * src/maemo/easysetup/modest-easysetup-wizard.h:
3724 * src/maemo/easysetup/modest-easysetup-wizard.c:
3725 (modest_easysetup_wizard_dialog_finalize),
3726 (on_button_edit_advanced_settings), (create_page_complete_custom),
3727 (on_response), (create_account):
3728 Implement the Advanced Settings edit button, by saving the account information,
3729 for the Advanded Settings dialog to use directly from gconf, and removing it
3730 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3731 Bug #5533 in the projects.maemo.org bugzilla.
3733 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3735 * src/maemo/modest-msg-view-window.c:
3736 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3737 when opening a message window.
3739 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3741 * src/maemo/easysetup/modest-easysetup-wizard.c:
3742 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3745 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3746 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3747 gconf settings. I probably added more checks than necessary, but that is safer.
3749 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3750 variable to fix the build, but this seems to be used when it is still NULL.
3752 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3754 * src/modest-platform.h:
3755 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3756 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3757 * src/modest-main.c: Implement this function so we can avoid using
3758 maemo-specific API from cross-platform code.
3760 * src/modest-tny-account-store.c:
3761 (get_smtp_specific_transport_account_for_open_connection):
3762 * src/modest-ui-actions.c: (check_for_connection),
3763 (modest_ui_actions_on_item_not_found):
3764 Use modest_platform_connect_and_wait() and put #idefs around other
3765 maemo-specific code, because only maemo currently has a way to
3766 identify connection names.
3768 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3770 * src/modest-tny-account-store.h:
3771 * src/modest-tny-account-store.c:
3772 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3773 the connection-specific SMTP server settings in the configuration.
3775 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3777 * src/maemo/modest-main-window.c: (on_connection_changed),
3779 * src/modest-main.c: (main), (start_ui), (send_mail):
3780 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3781 that is what is intended.
3783 * src/modest-ui-actions.c: (action_send), (action_receive),
3784 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3785 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3786 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3787 SMTP server is used when it is specified.
3789 (modest_ui_actions_on_send_receive):
3790 Check that a connection is open before proceeding.
3791 Receive and then send, instead of vice-versa, as per the specification.
3793 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3795 * src/modest-mail-operation.c:
3796 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3797 though I guess it should be something other than NULL.
3799 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3801 * src/maemo/easysetup/modest-easysetup-wizard.c:
3802 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3803 combo twice, to avoid an g_warning and to make it visible again.
3804 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3805 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3806 (already intended) dereference when detaching, because we then recreate the menu.
3807 But I am not sure why the warning was happening, and it is possible that this is a memory
3810 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3812 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3813 and uri_parse_mailto() utility functions.
3814 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3816 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3818 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3820 * src/dbus_api/modest-dbus-api.h:
3821 * src/dbus_api/modest-dbus-callbacks.c:
3822 Use an idle callback to execute the modest code in the application's own thread.
3823 Remove the helloworld example method.
3824 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3825 parsed, and the open-message method is not implemented because this is not yet implemented in
3827 * libmodest-dbus-client/libmodest-dbus-client.c:
3828 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3829 (libmodest_dbus_client_open_message):
3830 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3832 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3833 body without crashing.
3835 * tests/dbus_api/Makefile.am:
3836 * tests/dbus_api/test_mail_to.c:
3837 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3839 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3841 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3842 Added file to fix the build. Sorry.
3844 * src/dbus_api/Makefile.am:
3845 * src/dbus_api/modest-dbus-api.h:
3846 * src/dbus_api/modest-dbus-callbacks.h:
3847 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3848 (modest_dbus_req_handler):
3849 Put constants in a separate header so it can be reused by the
3850 client library, without duplication
3852 * libmodest-dbus-client/Makefile.am:
3853 * libmodest-dbus-client/libmodest-dbus-client.c:
3854 (libmodest_dbus_client_call_helloworld),
3855 (libmodfest_dbus_client_send_mail),
3856 (libmodfest_dbus_client_mailto),
3857 (libmodfest_dbus_client_open_message):
3858 * libmodest-dbus-client/libmodest-dbus-client.h:
3859 (Partly) Implement a send_mail D-Bus method.
3861 * tests/dbus_api/Makefile.am:
3862 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3863 the send_email D-Bus method.
3865 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3869 * libmodest-dbus-client/Makefile.am:
3870 * libmodest-dbus-client/libmodest-dbus-client.c:
3871 * libmodest-dbus-client/libmodest-dbus-client.h:
3872 * tests/dbus_api/Makefile.am:
3873 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3874 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3876 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3878 * src/maemo/easysetup/modest-easysetup-wizard.c:
3879 (create_page_account_details):
3880 * src/maemo/modest-account-settings-dialog.c:
3881 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3882 widgets, because this might not be the default in future versions of the Maemo GTK+.
3883 However, I can not not get capitalization to work even in a simple test case.
3885 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/easysetup/modest-easysetup-wizard.c:
3888 (create_page_custom_incoming), (create_page_custom_outgoing):
3889 * src/maemo/modest-account-settings-dialog.c:
3890 (create_page_account_details), (create_page_incoming),
3891 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3892 instead of using gtk_check_button_with_label(), so they are aligned like the other
3893 widgets, as per the UI spec.
3895 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3897 * src/maemo/easysetup/modest-easysetup-wizard.c:
3898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3899 * src/widgets/modest-validating-entry.c:
3900 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3901 Modest prefix instead of an EasySetup prefix.
3903 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3905 * src/widgets/modest-validating-entry.h:
3906 * src/widgets/modest-validating-entry.c: (on_insert_text),
3907 Added easysetup_validating_entry_set_max_func(), used to set a callback
3908 to call when the max number of characters is reached. GtkEntry has a max-length
3909 already but is silent about it.
3911 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3912 (create_page_account_details), (create_page_user_details),
3914 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3915 (create_page_account_details), (create_page_user_details),
3916 (create_page_outgoing):
3917 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3918 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3919 the UI spec, when the user tries to enter more than the max number of characters.
3921 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3923 * src/maemo/easysetup/modest-easysetup-wizard.c:
3924 (create_page_user_details), (create_page_custom_incoming),
3925 (create_page_custom_outgoing):
3926 * src/maemo/modest-account-settings-dialog.c:
3927 (create_page_user_details), (create_page_incoming),
3928 (create_page_outgoing):
3929 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3930 (modest_connection_specific_smtp_edit_window_init):
3931 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3932 not appropriate. Bad Maemo-specific defaults!.
3934 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3937 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3938 (modest_signature_editor_dialog_set_settings):
3939 Disable the label and textview when the checkbox is disabled, and use the
3940 specified (UI spec) default signature text.
3942 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3945 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3947 * src/modest-defs.h:
3948 * src/modest-account-mgr-helpers.h:
3949 * src/modest-account-mgr-helpers.c:
3950 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3952 * src/maemo/Makefile.am:
3953 * src/maemo/modest-signature-editor-dialog.c:
3954 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3957 * src/maemo/modest-account-settings-dialog.h:
3958 * src/maemo/modest-account-settings-dialog.c:
3959 (modest_account_settings_dialog_finalize), (on_button_signature),
3960 (save_configuration): Use the new dialog when the Edit button is pressed, and
3961 save the changes if necessary, as per the UI spec.
3963 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3965 * src/maemo/Makefile.am:
3966 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3967 based on maemo-develoers email from Dirk.
3969 * src/maemo/easysetup/modest-easysetup-wizard.c:
3970 (create_page_welcome), (create_page_account_details),
3971 (create_page_user_details), (create_page_complete_easysetup),
3972 (create_page_custom_incoming), (create_page_custom_outgoing),
3973 (create_page_complete_custom),
3974 (modest_easysetup_wizard_dialog_init):
3975 * src/maemo/modest-account-settings-dialog.c:
3976 (create_page_account_details), (create_page_user_details),
3977 (create_page_incoming), (create_page_outgoing),
3978 (modest_account_settings_dialog_init):
3979 * src/maemo/modest-connection-specific-smtp-window.c:
3980 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3982 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/easysetup/modest-easysetup-wizard.c:
3985 (create_page_account_details), (create_page_custom_outgoing),
3986 (create_page_complete_custom):
3987 * src/maemo/modest-account-settings-dialog.c:
3988 (create_page_user_details), (create_page_incoming),
3989 (create_page_outgoing):
3990 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3991 (modest_connection_specific_smtp_edit_window_init):
3992 Use the correct (UI spec) port min/max, and use horizontal separators,
3995 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3997 * src/maemo/easysetup/modest-easysetup-wizard.c:
3998 (set_default_custom_servernames):
3999 * src/maemo/modest-account-settings-dialog.c:
4000 (create_page_incoming), (on_combo_outgoing_security_changed),
4001 (on_combo_incoming_security_changed), (create_page_outgoing),
4002 (modest_account_settings_dialog_set_account_name),
4003 (save_configuration):
4004 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4005 (on_combo_security_changed),
4006 (modest_connection_specific_smtp_edit_window_init),
4007 (modest_connection_specific_smtp_edit_window_set_connection),
4008 (modest_connection_specific_smtp_edit_window_get_settings):
4009 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4012 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4015 * src/maemo/easysetup/modest-easysetup-wizard.c:
4016 (create_page_custom_outgoing), (create_page_complete_custom):
4017 * src/maemo/modest-account-settings-dialog.c:
4018 (create_page_user_details), (create_page_outgoing):
4019 * src/maemo/modest-account-view-window.c: (button_box_new):
4020 Use changed logical IDs as per the most recent UI spec:
4021 mcen_bd_emailsetup_edit -> mcen_bd_edit
4022 mcen_bd_emailsetup_delete -> mcen_bd_delete
4023 mcen_bd_emailsetup_close -> mcen_bd_close
4025 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4029 * src/dbus_api/Makefile.am:
4030 * src/dbus_api/modest-dbus-callbacks.c:
4031 * src/dbus_api/modest-dbus-callbacks.h:
4032 * src/maemo/modest-platform.c: (modest_platform_init):
4033 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4035 * tests/Makefile.am:
4036 * tests/dbus_api/Makefile.am:
4037 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4039 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4041 * src/maemo/modest-account-settings-dialog.c:
4042 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4043 Removed unnecessary includes.
4045 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4047 * src/maemo/easysetup/modest-easysetup-wizard.c:
4048 * src/maemo/modest-account-settings-dialog.c:
4049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4050 * src/widgets/Makefile.am:
4051 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4052 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4053 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4054 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4055 * src/widgets/modest-secureauth-combo-box.c:
4056 * src/widgets/modest-secureauth-combo-box.h:
4057 * src/widgets/modest-serversecurity-combo-box.c:
4058 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4059 made the GObject names more consistent with the rest of the Modest code.
4061 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4063 * src/maemo/easysetup/Makefile.am:
4064 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4065 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4066 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4067 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4068 * src/maemo/easysetup/modest-easysetup-wizard.c:
4069 * src/maemo/easysetup/modest-validating-entry.c:
4070 * src/maemo/easysetup/modest-validating-entry.h:
4071 * src/maemo/modest-account-settings-dialog.c:
4072 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4073 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4074 widgets/ because they are used outside of easysetup too. After checking in,
4075 svn will allow me to rename them too.
4077 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4079 * src/gnome/modest-msg-edit-window.c:
4080 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4081 linker error, to fix the build on the GNOME platform.
4082 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4083 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4084 ifdefed out to avoid a warning.
4086 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4088 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4089 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4090 some alternative for GTK+ 2.6.
4092 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4094 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4096 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4097 specified for EmailAccountsDialog in UI spec.
4099 * src/maemo/easysetup/modest-easysetup-wizard.c:
4100 * src/maemo/easysetup/modest-easysetup-wizard.h:
4101 * src/maemo/modest-account-settings-dialog.c:
4102 * src/maemo/modest-account-settings-dialog.h:
4103 Reuse a member window widget for the connection-specific SMTP server accounts,
4104 so we can tell it to create/save the accounts only if we actually save changes.
4106 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4108 (modest_connection_specific_smtp_edit_window_get_settings):
4109 Return a struct instance for temporarily remembering the entered data.
4111 * src/maemo/modest-connection-specific-smtp-window.h:
4112 * src/maemo/modest-connection-specific-smtp-window.c:
4113 (modest_connection_specific_smtp_window_finalize),
4114 (modest_connection_specific_smtp_window_fill_with_connections),
4116 (modest_connection_specific_smtp_window_save_server_accounts),
4117 (update_model_server_names): Do not actually save data until asked,
4118 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4120 (on_selection_changed),
4121 (modest_connection_specific_smtp_window_init): Disable the edit
4122 button when nothing is selected.
4124 * src/modest-account-mgr-helpers.c:
4125 * src/modest-account-mgr-helpers.h:
4126 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4129 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4131 * src/modest-account-mgr-helpers.h:
4132 * src/modest-account-mgr-helpers.c:
4133 (modest_account_mgr_get_unused_account_name),
4134 (modest_account_mgr_get_unused_account_display_name): Added these
4135 utility functions, to avoid code duplication.
4137 * src/maemo/easysetup/modest-easysetup-wizard.c:
4138 (create_page_account_details), (create_account):
4139 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4140 (on_combo_security_changed),
4141 (modest_connection_specific_smtp_edit_window_init),
4142 (modest_connection_specific_smtp_edit_window_save_settings):
4143 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4144 * src/maemo/modest-connection-specific-smtp-window.c:
4145 (modest_connection_specific_smtp_window_finalize),
4146 (modest_connection_specific_smtp_window_fill_with_connections),
4147 (on_button_edit), (modest_connection_specific_smtp_window_init):
4148 * src/maemo/modest-connection-specific-smtp-window.h:
4149 Implementing saving of connection-specific server accounts.
4151 But I need to refactor this so we can save the data for each
4152 possible connection-specific account and only actually create the server accounts
4153 when the easysetup finished, or the OK button is pressed on the account settings
4156 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4159 (on_combo_security_changed):
4160 (modest_connection_specific_smtp_edit_window_init):
4161 Auto-fill the port number as in the account settings.
4163 (modest_connection_specific_smtp_edit_window_set_connection):
4164 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4165 * src/maemo/modest-connection-specific-smtp-window.c:
4166 (fill_with_connections), (on_button_edit),
4167 (modest_connection_specific_smtp_window_init):
4168 Turn the edit window into a dialog to simplify the code, and
4169 set a WM hint as in a GtkDialog, because only a popup can be on top of
4170 another window in Maemo, and popups usually have no WM decoration.
4172 * src/modest-defs.h:
4173 * src/modest-account-mgr-helpers.c:
4174 (modest_account_mgr_set_connection_specific_smtp),
4175 (modest_account_mgr_remove_connection_specific_smtp),
4176 (modest_account_mgr_get_connection_specific_smtp):
4177 * src/modest-account-mgr-helpers.h: Some functions to write the
4178 connection-specific SMTP server information. Not yet used.
4181 * src/widgets/modest-folder-view.c: (text_cell_data):
4182 Fix a warning about an uninitialized variable.
4183 (on_configuration_key_changed): Put an #ifdef around the use
4184 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4186 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/modest-account-settings-dialog.h:
4189 * src/maemo/modest-account-settings-dialog.c:
4190 Added connect_for_modified() utility function to mark the new modified boolean.
4192 (create_page_account_details), (create_page_user_details),
4193 (create_page_incoming), (create_page_outgoing), (on_response),
4194 (modest_account_settings_dialog_init),
4195 (modest_account_settings_dialog_set_account_name):
4196 Only warn about unsaved changes when there are actually unsaved changes.
4198 * src/modest-account-mgr-helpers.c:
4199 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4200 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4201 to get the data from there in future.
4203 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4205 * src/modest-defs.h:
4207 * src/modest-account-mgr-helpers.h:
4208 * src/modest-account-mgr-helpers.c:
4209 Store the security account setting in a single conf key instead of using
4210 the options list, so that the list is left for just the to-be-removed camel hack,
4211 and because gconf_client_set_list() is failing for some reason.
4213 * src/modest-account-mgr.c:
4214 (modest_account_mgr_add_server_account):
4215 * src/maemo/modest-account-settings-dialog.c:
4216 (modest_account_settings_dialog_set_account_name),
4217 (save_configuration): Use the renamed functions.
4220 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4222 * src/widgets/Makefile.am:
4223 * src/widgets/modest-limit-retrieve-combo-box.c:
4224 * src/widgets/modest-limit-retrieve-combo-box.h:
4225 * src/widgets/modest-retrieve-combo-box.c:
4226 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4227 the account settings dialog.
4229 * src/modest-defs.h:
4230 * src/modest-account-mgr-helpers.h:
4231 * src/modest-account-mgr-helpers.c:
4232 (modest_server_account_get_option_secure_auth),
4233 (modest_server_account_set_option_secure_auth):
4234 * src/modest-account-mgr.c:
4235 (modest_account_mgr_add_server_account):
4236 Use the existing AUTH_MECH conf key for the secure-auth setting,
4237 instead of putting it in the list options, because this was actually used already.
4239 * src/maemo/modest-account-settings-dialog.c:
4240 (create_page_account_details),
4241 (modest_account_settings_dialog_set_account_name),
4242 (save_configuration):
4243 * src/maemo/modest-account-settings-dialog.h:
4244 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4245 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4247 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4249 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4250 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4251 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4253 * src/modest-defs.h:
4254 * src/maemo/modest-account-settings-dialog.c:
4255 (create_page_incoming), (on_combo_outgoing_security_changed),
4256 (on_combo_incoming_security_changed), (create_page_outgoing),
4257 (modest_account_settings_dialog_set_account_name),
4258 (save_configuration): Load/Save the port number, and change it when the
4259 security combo changes, to suitable defaults.
4261 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4263 * src/modest-account-mgr.c:
4264 (modest_account_mgr_add_server_account): Set the security and secure-auth
4265 options, and add a comment saying that the other camel-specific options should be
4268 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4270 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4272 * src/modest-tny-account-store.c: (account_list_free),
4273 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4274 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4277 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4279 * src/modest-protocol-info.c:
4280 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4281 is required by our UI spec. Maybe something in our implementation will use this eventually.
4282 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4283 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4284 instead of the previous 0 placeholder.
4286 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4287 secure-auth settings.
4288 * src/modest-account-mgr-helpers.h:
4289 * src/modest-account-mgr-helpers.c:
4290 (modest_server_account_data_get_option_secure_auth),
4291 (modest_server_account_set_option_secure_auth),
4292 (modest_server_account_data_get_option_security),
4293 (modest_server_account_set_option_security): Added this API for getting and setting the security
4294 and secure-auth settings.
4296 * src/maemo/modest-account-settings-dialog.h:
4297 * src/maemo/modest-account-settings-dialog.c:
4298 (modest_account_settings_dialog_finalize), (check_data),
4299 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4300 about changing titles.
4301 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4302 (save_configuration): Save the security and secure-auth settings.
4304 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4305 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4307 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4309 * src/modest-defs.h:
4310 * src/modest-account-mgr.c:
4311 (modest_account_mgr_add_server_account):
4312 Added and used defines for the options key and value pair strings,
4313 that are used so far, though they do not seem to correspond to anything in our
4314 UI specs or ModestProtocol enum.
4316 * src/modest-account-mgr-helpers.h:
4317 * src/modest-account-mgr-helpers.c:
4318 (compare_option_strings_for_name),
4319 (modest_server_account_data_get_option_value),
4320 (modest_server_account_data_get_option_bool),
4321 (modest_account_mgr_get_server_account_option):
4322 Added helper functions for parsing the options GSList.
4324 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4326 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4327 display name is based on the supplied account name.
4328 * src/modest-account-mgr.c:
4329 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4330 with an inefficient, but good-enough, implementation.
4332 * src/maemo/easysetup/modest-easysetup-wizard.c:
4333 (create_page_account_details), (on_before_next), (create_account):
4334 Check for existing display names rather than (non-user-visible) account names, and just
4335 create and set a unique account name at the end.
4337 * src/maemo/modest-account-settings-dialog.c:
4338 (modest_account_settings_dialog_init),
4339 (modest_account_settings_dialog_set_account_name),
4340 (create_page_incoming): Show the display name, instead of the account name.
4341 (on_response): Do some (not all) extra checks, as in the UI spec.
4342 (save_configuration): Save the display name if it was changed.
4344 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4346 * po/en_GB.po: Added needed logical ID and translation.
4347 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4348 (init_view): Made the is-default column clicking work.
4350 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4353 * src/maemo/easysetup/Makefile.am:
4354 * src/maemo/easysetup/modest-easysetup-wizard.c:
4355 (modest_easysetup_wizard_dialog_init):
4356 * src/maemo/easysetup/provider-data-test.keyfile:
4357 * src/maemo/easysetup/provider-data.keyfile:
4358 Moved the provider data file to the new modest-providers-data package and used it from there.
4360 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4362 * src/modest-local-folder-info.c:
4363 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4364 N_() was already used on the static strings, but this just marks it for translation without
4365 using the translation.
4367 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4369 * src/maemo/modest-account-settings-dialog.c:
4370 (create_page_incoming),
4371 (modest_account_settings_dialog_set_account_name):
4372 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4373 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4374 I will do this if nobody else gets there first.
4376 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4378 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4379 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4380 save the security stuff.
4382 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4384 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4385 Set the email address and user fullname, which I now see must be
4388 * src/maemo/modest-account-settings-dialog.h:
4389 * src/maemo/modest-account-settings-dialog.c:
4391 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4392 leave-on-server and authentication.
4393 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4396 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4399 * src/maemo/modest-account-settings-dialog.c:
4400 * src/maemo/modest-account-settings-dialog.h:
4401 Most (but not all) of the widgets are now present as specified by the UI spec.
4402 No changes are yet saved, and some details are not properly shown yet.
4404 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4406 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4408 * src/maemo/Makefile.am:
4409 * src/maemo/modest-account-settings-dialog.c:
4410 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4411 an existing account. Doesn't do much yet.
4413 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4414 Open the accounts settings dialog when Edit is clicked.
4416 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4418 * src/maemo/easysetup/Makefile.am:
4419 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4421 * src/maemo/easysetup/modest-easysetup-wizard.c:
4422 (modest_easysetup_wizard_dialog_init):
4423 Try to get the source directory from the build system,
4424 instead of hard-coding "./" into the source code, when opening our local
4425 copies of the configuration files.
4426 But this still fails when opening the wizard from the Accounts window,
4427 maybe because the working directory seems to change at runtime.
4428 So the wizard will fail the second time unless you copy the files into their
4429 proper locations - see the stdout warnings for the paths.
4431 (create_page_account_details),(on_before_next):
4432 Check for existing non-server accounts instead of server accounts,
4433 so the default account name is useful again, and to prevent trying to
4436 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4437 Show the wizard when New is clicked.
4439 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4440 (init_view): Show the column headers, and show the columns that are
4441 specified in the UI specs. However, something in Maemo's GTK+ prevents
4442 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4443 change the default account. This is despite unsetting the special properties.
4445 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4447 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4448 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4449 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4450 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4451 to make that clearer.
4452 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4454 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4456 * src/maemo/modest-account-view-window.c:
4457 (modest_account_view_window_init),
4458 (modest_account_view_window_new):
4459 Use the same buttons as specified in the
4460 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4461 the existing widgets, which never had a chance of working.
4462 Put the ModestAccountView treeview in a scrolled window.
4463 Do not repeat the initialization in both _init() and _new().
4465 * src/widgets/modest-account-view.c: (update_account_view):
4466 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4467 this widget and window shows no accounts.
4469 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4471 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4473 * src/maemo/easysetup/modest-easysetup-wizard.c:
4474 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4475 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4476 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4479 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4480 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4481 accounts exist yet, as in the UI spec.
4483 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4485 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4487 * src/maemo/Makefile.am:
4488 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4489 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4490 New window for editing connection-specific smtp details.
4491 Not fully implemented.
4493 * src/maemo/modest-connection-specific-smtp-window.c:
4494 (modest_connection_specific_smtp_window_finalize) :
4495 unref the tree model.
4496 (on_button_edit): Show the edit window.
4498 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4500 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4503 * src/maemo/Makefile.am:
4504 * src/maemo/modest-connection-specific-smtp-window.c:
4505 * src/maemo/modest-connection-specific-smtp-window.h:
4506 New window for showing the list of connections, for connection-specific
4507 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4508 * src/maemo/easysetup/modest-easysetup-wizard.c:
4509 (create_page_custom_outgoing): Show the new window when the button is clicked.
4511 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4513 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4514 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4515 * src/maemo/modest-msg-edit-window.c:
4516 (modest_msg_edit_window_insert_image):
4517 * src/modest-conf.c: (modest_conf_key_escape):
4518 * src/modest-mail-operation.c:
4519 (modest_mail_operation_send_new_mail):
4520 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4521 (modest_ui_actions_on_new_account):
4522 * src/widgets/modest-attachment-view.c: (update_filename_request):
4523 * src/widgets/modest-mail-header-view.c:
4524 Corrected warnings that were breaking the build, by commenting out unused variables,
4525 and a function, and by including a header.
4527 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4529 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4530 so we can #ifdef around platform-specific code when necessary.
4531 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4532 to allow this to build for the GNOME platform too.
4534 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4536 * src/maemo/easysetup/modest-easysetup-wizard.c:
4537 Added util_increment_name() and used it in create_page_account_details()
4538 to make sure that the default account name is always a new name.
4540 (modest_easysetup_wizard_dialog_init),
4541 (set_default_custom_servernames): Some minor memory management fixes.
4543 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4547 * src/modest-runtime.c: (init_i18n): Restored the translation
4548 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4549 are defined in config.h, and the translations are installed.
4551 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4552 is defined for translation.
4554 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4556 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4558 * src/maemo/easysetup/modest-easysetup-wizard.c:
4559 (modest_easysetup_wizard_dialog_init):
4560 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4561 Use realistic paths (though they should use $prefix generically) to the
4562 mcc_mapping and provider-data.keyfile files which might work when they
4563 are installed by the future version of the operator-wizard package,
4564 and then fallback to paths in our source code, with an explanatory
4567 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4571 * src/maemo/Makefile.am:
4572 * src/maemo/easysetup/: Added files from the previously-exernal
4573 osso-modest-easysetup.
4574 * src/maemo/modest-main-window-ui.h:
4575 * src/modest-ui-actions.c:
4576 * src/modest-ui-actions.h:
4577 Added modest_ui_actions_on_new_account() as a signal handler for the
4578 New Account menu item. It shows the easysetup wizard.
4579 * po/en_GB.po: Added additional needed logical IDs and translations.