1 2007-07-23 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c:
4 (modest_ui_actions_on_password_requested):
5 Show mail_ib_login_cancelled info banner when the user cancels
6 the protected password dialog, to fix projects.maemo.org
9 2007-07-23 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-account-settings-dialog.c:
12 (create_page_outgoing): Put this page in a GtkScrolledWindow,
13 matching the UI mock-up in the UI spec, and allowing access
14 to all widgets even when the on-screen keyboard is active.
16 2007-07-23 Murray Cumming <murrayc@murrayc.com>
18 Reverted this previous commit from Johannes,
19 because the scrollbars are always visible and because
20 I think we only need it on onepage of the account
21 settings, not the account wizard.
22 (I wrote the wrong instructions in the bug.)
24 * src/maemo/easysetup/modest-easysetup-wizard.c:
25 Added scrollbars to account wizard dialog.
26 Fixed projects.maemo.org NB #62744
28 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
30 * src/maemo/easysetup/modest-easysetup-wizard.c:
31 (create_page_user_details):
32 Use auto-cap for name (projects.maemo.org NB#63716)
33 * src/widgets/modest-account-view.c: (on_account_busy_changed):
35 2007-07-22 Armin Burgmeier <armin@openismus.com>
37 * src/maemo/modest-ui-actions.c: Use current account instead of
38 default account for creating viewer windows, so that the viewer
39 window knows to which account the viewed message belongs.
41 * src/maemo/modest-msg-view-window.c: Destroy the window when the
42 corresponding account is deleted. This fixes projects.maemo.org bug
45 2007-07-18 Armin Burgmeier <armin@openismus.com>
47 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
48 the dialog close after entering an invalid port number and clicking
49 OK. This fixes projects.maemo.org bug NB#63602.
51 2007-07-18 Armin Burgmeier <armin@openismus.com>
53 * src/modest-tny-account-store.c:
54 (get_server_accounts): Set parent modest account name for each
55 connection-specific transport account so that special folders of such
56 an account can be looked up. This fixes a crash when changing account
57 settings. This might also be related to projects.maemo.org bug
60 2007-07-16 Armin Burgmeier <armin@openismus.com>
62 * src/modest-ui-actions.c: Added a button to create a folder to the
63 move-to dialog. This fixes projects.maemo.org bug NB#.
65 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
67 * src/maemo/easysetup/modest-easysetup-wizard.c:
68 Added scrollbars to account wizard dialog.
69 Fixed projects.maemo.org NB #62744
71 2007-07-16 Murray Cumming <murrayc@murrayc.com>
73 * src/widgets/modest-msg-view.h:
74 * src/widgets/modest-msg-view.c:
75 Added modest_msg_view_get_message_is_empty() but this needs
77 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
78 Check if there is any text in the message yet.
79 But this needs to be implemented properly.
80 (modest_msg_edit_window_toggle_find_toolbar):
81 * src/maemo/modest-msg-view-window.c:
82 (modest_msg_view_window_toggle_find_toolbar):
83 Show a banner warning if there is no text to search, when
84 trying to start a search. This partially fixes
85 projects.maemo.org bug NB#62350.
87 2007-07-13 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-mail-operation.c: (update_account_thread):
90 Initialized num_new_headers to fix the build.
92 2007-07-13 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
95 Ignore modest accounts whose server accounts don't exist in gconf.
96 This prevents us trying to create TnyAccount instances for those
97 server accounts when the server account has been removed from gconf,
98 but the parent modest account has not yet been removed from modest.
99 I don't know why this is only noticeable now. It was probably just
100 a harmeless g_warning() anyway.
102 2007-07-13 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
105 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
107 2007-07-12 Armin Burgmeier <armin@openismus.com>
109 * src/maemo/modest-main-window.c: Make default account appear bold
110 in view, tools/send & receive and toolbar/send & receive SCM menus.
111 This fixes projects.maemo.org bug NB#59010.
113 2007-07-12 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
116 Add a short-cut, by checking if the folder store is an account.
117 This ensures that the Sort menu item and toolbar is dimmed for
118 the local-folders account root item, fixing
119 projects.maemo.org bug NB#62545.
121 2007-07-12 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-tny-account-store.c: (get_password):
124 Show the password dialog (via the signal) only in the mainloop, via
125 an idle handler that we wait for. This could theoretically prevent
126 hangs, though I worry that it could introduce some too.
128 2007-07-12 Murray Cumming <murrayc@murrayc.com>
130 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
131 * src/maemo/modest-platform.c:
132 (modest_platform_connect_and_wait):
133 Take a TnyAccount* parameter and try to set it to online
134 (a TnyCamel-only API), because tinymail sets accounts to offline
135 when the user cancels a password dialog, and doesn't ask again until
136 it has been set to online.
137 However, this is commented out because it causes a hang now.
139 (modest_platform_connect_and_wait_if_network_account):
140 * src/modest-mail-operation.c:
141 (modest_mail_operation_update_account):
142 * src/modest-platform.h:
143 * src/modest-ui-actions.c: (_modest_ui_actions_open),
144 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
146 2007-07-12 Armin Burgmeier <armin@openismus.com>
148 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
150 * src/modest-mail-operation.c:
151 * src/modest-ui-actions.c: Check for already existing folder before
152 querying the server, show error message from camel if the request
153 still fails. This fixes projects.maemo.org bug NB#58701.
155 2007-07-12 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-tny-account-store.h:
158 * src/modest-tny-account-store.c:
159 Added modest_tny_account_store_forget_password_in_memory(),
160 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
161 when creating a new account, so that new passwords will be used, instead of
162 us thinking that it's a second request as a result of a failed password again.
164 2007-07-12 Murray Cumming <murrayc@murrayc.com>
166 * src/dbus_api/modest-dbus-callbacks.c:
167 (on_idle_open_message): If the message is in drafts then open it
168 in an edit window instead of a view window. This fixes
169 projects.maemo.org bug NB#63005.
171 2007-07-12 Murray Cumming <murrayc@murrayc.com>
173 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
174 Avoided a harmless g_warning().
176 2007-07-12 Murray Cumming <murrayc@murrayc.com>
178 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
179 Pass the modest account name, not the TnyAccount display name to
180 modest_msg_view_window_new() so that the reply feature works,
181 fixing projects.maemo.org bug NB#62892.
183 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
184 (modest_msg_view_window_new_with_header_model):
185 * src/maemo/modest-msg-view-window.c:
186 (modest_msg_view_window_new_with_header_model),
187 (modest_msg_view_window_new):
188 * src/modest-ui-actions.c: (reply_forward):
189 * src/widgets/modest-msg-view-window.h:
190 * src/widgets/modest-window.c: (modest_window_set_active_account):
191 Rename an account parameter to modest_account_name to make this clearer.
193 2007-07-11 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-ui-actions.h:
196 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
197 modest_do_message_delete().
198 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
199 Call modest_do_message_delete(), hoping that this would cause messages
200 to be really deleted from search instead of just marked with strike through.
201 Does not seem to help.
203 2007-07-11 Armin Burgmeier <armin@openismus.com>
205 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
206 priv->reselect to FALSE prior to calling
207 modest_folder_view_select_first_inbox_or_local() to prevent endless
208 recursion and thus a crash on startup.
210 2007-07-11 Armin Burgmeier <armin@openismus.com>
212 * src/maemo/modest-account-settings-dialog.h: Include
213 <gtk/gtknotebook.h> to fix the build (at least for me).
215 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
216 Use "New FolderN" as default suggested name if "New folder" already
217 exists, with N being the first free number, though never exceed "New
218 folder99" in which case we just fall back to "New Folder" even though
219 it already exists. This fixes projects.maemo.org bug NB#58663.
221 2007-07-11 Murray Cumming <murrayc@murrayc.com>
223 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
224 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
225 projects.maemo.org bug NB#62778.
227 2007-07-11 Murray Cumming <murrayc@murrayc.com>
229 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
230 Ignore the wrong (for now) secure-smtp setting in the presets -
231 just default to requiring secure authentication for SMTP, because
234 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
236 * src/widgets/modest-folder-view.c: (filter_row)
237 Do not show drafts folder (see UI specs)
239 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
241 * src/modest-ui-actions.c:
242 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
243 place and also not necessary.
245 * src/widgets/modest-folder-view.c: (filter_row)
246 Guess folder type and hide Sent & Outbox if necessary.
247 Fixed project.maemo.org NB#57328
249 2007-07-11 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-ui-actions.h:
252 * src/modest-ui-actions.c:
253 (modest_ui_actions_on_delete_message):
254 Move some code into a new
255 modest_ui_actions_refresh_message_window_after_delete()
256 function so we can use it from elsewhere.
258 * src/dbus_api/modest-dbus-callbacks.c:
259 (on_idle_delete_message), (on_delete_message): Used an idle
260 handler, as we do for the other D-Bus method handlers.
261 Call modest_ui_actions_refresh_message_window_after_delete()
262 if the deleted message was open in a window. This fixed
263 projects.maemo.org bug NB#62862.
265 2007-07-11 Murray Cumming <murrayc@murrayc.com>
267 * src/modest-main.c: (main): Only show the UI at the start if
268 the showui command line option was given. For instance,
269 run-standalone src/modest showui
270 Otherwise, we wait for the top_application D-Bus method to
271 be sent by hildon-desktop when the application is selected
273 This allows us to run without a UI when osso-global-search
274 uses our D-Bus methods.
276 2007-07-11 Murray Cumming <murrayc@murrayc.com>
278 * src/dbus_api/modest-dbus-api.h: Added a define for a
279 top-application D-Bus method.
280 * src/dbus_api/modest-dbus-callbacks.c:
281 (on_top_application),
282 (modest_dbus_req_handler): Handle the top-application D-Bus
283 method, which might be an undocumented D-Bus signal sent by
284 hildon-desktop when it starts the application from the menu.
285 But I am not sure and I need to test it on the device, because
286 my scratchbox does not have the application in the menu now.
287 This method shows the main window, so that it can be invisible
288 when started, for instance, just for email searching from
291 * src/maemo/modest-main-window.c: (restore_settings),
292 (modest_main_window_new): Do not show the window immediately
293 upon creation. We show it later.
294 * src/modest-widget-memory.c: (save_settings_paned):
295 Try (unsuccessfully) to avoid saving the paned position when
296 it is not even visible.
297 (restore_settings_paned): Do not allow a silly paned position.
298 This seems necessary when not showing the window at first.
300 * tests/dbus_api/Makefile.am:
301 * tests/dbus_api/test_top_application.c: (main): Test for the
304 2007-07-10 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-ui-dimming-rules.c:
307 (modest_ui_dimming_rules_on_new_msg),
308 (modest_ui_dimming_rules_on_reply_msg),
309 (modest_ui_dimming_rules_on_delete_msg),
310 (modest_ui_dimming_rules_on_details),
311 (modest_ui_dimming_rules_on_view_window_move_to),
312 (modest_ui_dimming_rules_on_view_previous),
313 (modest_ui_dimming_rules_on_view_next),
314 (_invalid_folder_for_purge): Added checks before
315 casting the window. This looks like an actual
316 logic error in _invalid_folder_for_purge(), because it
317 tries to use a ModestMainWindow as a message window.
319 2007-07-10 Murray Cumming <murrayc@murrayc.com>
321 * src/maemo/modest-account-settings-dialog.c:
322 (show_error): Use the same implementation as in
323 modest-easysetup-wizard.c:
324 (on_entry_invalid_character): The logical ID contains a %s.
325 Guessed what it should be.
326 (on_entry_max), (check_data), (on_response): Adapt to
327 changed show_error().
328 (create_page_account_details): Really call
329 modest_validating_entry_set_func() on the correct widgets.
330 * src/maemo/easysetup/modest-easysetup-wizard.c:
331 (on_entry_invalid_character): Fix the logical ID here too.
332 (create_page_account_details),
333 (create_page_user_details):
335 modest_validating_entry_set_func() on the correct widgets.
337 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
338 Do not try to use the account if it is NULL.
340 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
342 * src/modest-ui-actions.c: (create_move_to_dialog),
343 (modest_ui_actions_on_main_window_move_to),
344 (modest_ui_actions_on_msg_view_window_move_to):
345 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
346 (filter_row), (modest_folder_view_show_non_move_folders):
347 * src/widgets/modest-folder-view.h:
349 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
350 the Sent folder yet as it does not report the correct folder type.
352 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
354 * src/maemo/modest-msg-edit-window.c: (init_window):
357 2007-07-10 Murray Cumming <murrayc@murrayc.com>
359 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
360 Take a parent widget instead of a parent window, and
361 implement this with hildon_banner_show_information() instead.
362 Non-Maemo builds can just ifdef that there.
363 This fixed projects.maemo.org bug NB#62766.
365 (on_entry_invalid_character): Use show_error() again instead
366 of using hildon directly, and use the _CS() macro to use the correct
368 (create_account), (check_for_supported_auth_methods), (on_entry_max):
369 Pass a widget instead od a window to show_error().
371 2007-07-10 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
374 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
375 This allows us to show the server name in the error message, fixing
376 projects.maemo.org bug NB#62904.
377 Also, use the appropriate logical ID message for the account protocol.
379 2007-07-10 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-tny-account-store.c: (on_idle_wrong_password):
382 A compilation fix, though the build wasn't broken for me.
384 2007-07-09 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
387 Do not try to unref a NULL folder store, to avoid a runtime warning.
388 This seems to happen sometimes when changing accounts settings.
390 2007-07-09 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account-store.c:
393 (modest_tny_account_store_instance_init),
394 (modest_tny_account_store_finalize),
395 (on_account_settings_hide), (on_idle_wrong_password):
396 Use a GHashTable to ensure that we only show one account settings
397 dialog per modest account. This avoids us having a dialog open for
398 both the store and transport accounts, or due to repeated get_password()
399 calls that shouldn't happen anyway.
401 2007-07-09 Murray Cumming <murrayc@murrayc.com>
403 * src/maemo/modest-maemo-utils.c: (on_hide),
404 (modest_maemo_show_dialog_and_forget): Handle the response, because
405 the window is not even hidden by default.
407 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
408 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
409 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
410 which seems to prevent some modality problems.
412 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
413 Ignore user cancellation errors.
415 * src/modest-account-mgr-helpers.h:
416 * src/modest-account-mgr-helpers.c:
417 Added modest_server_account_get_password() and
418 modest_server_account_get_has_password() to avoid direct use of
421 * src/maemo/modest-account-settings-dialog.h:
422 * src/maemo/modest-account-settings-dialog.c:
423 (modest_account_settings_dialog_init): Store the notebook so we can
425 Added modest_account_settings_dialog_switch_to_user_info().
427 * src/modest-tny-account-store.c:
428 (get_password): When the password in the account settings is wrong (we think),
429 show the relevant page of the account settings dialog, in the mainloop.
430 However, we currently get many of these at once because cancel does not
432 (forget_password): Do not forget the password
433 from the account settings, because this causes side-effects when
434 tinymail seems to call it at strange time, maybe because of how we
435 are cancelling get_password().
436 (modest_tny_account_store_alert): Ignore user cancellations.
438 2007-07-09 Murray Cumming <murrayc@murrayc.com>
440 * src/maemo/modest-maemo-utils.h:
441 * src/maemo/modest-maemo-utils.c:
442 Added modest_maemo_show_information_note_and_forget() for use instead of
443 gtk_dialog_run() when the response is not needed, to avoid an extra
444 mainloop which could cause a hang.
446 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
447 Use the logical IDs for the error message, though they are not
448 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
449 because gtk_dialog_run() caused a hang here (the window did not close).
450 This fixes projects.maemo.org bug NB#62646.
452 2007-07-09 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-account-mgr-helpers.h:
455 * src/modest-account-mgr-helpers.c:
456 Added modest_account_mgr_get_store_protocol().
458 * src/maemo/modest-account-view-window.c:
459 (on_delete_button_clicked): Show different warning text depending on
460 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
461 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
464 2007-07-09 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/modest-msg-edit-window.c:
467 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
468 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
470 2007-07-07 Armin Burgmeier <armin@openismus.com>
472 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
473 ckdg_ib_maximum_characters_reached from correct package.
475 * src/modest-ui-actions.c: Show an error message when a folder could
476 not be created. Tinymail does not give us specific error codes about
477 what has gone wrong, so we assume that a folder with that name
478 already exists, though there might be other reasons.
480 2007-07-06 Murray Cumming <murrayc@murrayc.com>
482 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
483 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
484 give a more exact error message that can be partly translated.
486 2007-07-05 Murray Cumming <murrayc@murrayc.com>
488 * src/maemo/modest-address-book.c:
489 (select_email_addrs_for_contact): Specify a default window size for the
490 select-email-address dialog, so that it is probably big enough for the
491 title. This should fix projects.maemo.org bug NB#62277.
493 2007-07-05 Murray Cumming <murrayc@murrayc.com>
495 * src/maemo/easysetup/modest-easysetup-wizard.c:
496 (create_page_complete_easysetup): Use
497 gtk_widget_set_size() request to ensure that the text wraps
500 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
502 * src/maemo/easysetup/modest-easysetup-wizard.c:
503 (on_entry_invalid_character), (create_page_account_details),
504 (create_page_user_details):
505 Use new API of ModestValidatingEntry. But for some reason the banner is
506 not shown. I will have to investigate that further.
508 * src/widgets/modest-validating-entry.c: (on_insert_text),
509 (modest_validating_entry_set_func):
510 * src/widgets/modest-validating-entry.h:
511 Added a new callback function to be able to react to prevented
512 characters whitespaces to e.g show a banner.
514 2007-07-05 Armin Burgmeier <armin@openismus.com>
516 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
517 notification of HildonNumberEditor instead of remembering the port
518 number. Thanks to Johannes for pointing this out.
520 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
522 * src/maemo/easysetup/modest-easysetup-wizard.c:
523 Check if there are any user changes before showing a confirmation
524 dialog (projects.maemo.org NB#60946)
526 2007-07-05 Armin Burgmeier <armin@openismus.com>
528 * src/maemo/modest-account-settings-dialog.c: Remember custom port
529 number at the beginning of the dialog and set the modified flag at the
530 end if the port number has changed. This is necessary because
531 HildonNumberEditor does not support notification when the value has
534 2007-07-05 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-ui-actions.c:
537 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
538 a connection before asking anything else. Correct the check for the destination
539 folder so that it succeeds when online.
540 This fixed projects.maemo.org bug NB#61645.
542 2007-07-05 Murray Cumming <murrayc@murrayc.com>
544 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
545 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
546 to fix projects.maemo.org bug NB#62439.
548 2007-07-05 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-tny-account.c: (on_connection_status_changed):
551 Really do not use tny_device_force_offline() here. See the previous comment.
553 2007-07-04 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-tny-account.c: (on_connection_status_changed):
556 Do not use tny_device_force_offline() when tinymail says that something
557 went wrong with the connection. It seems to report this unnecessarily.
559 2007-07-04 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/modest-connection-specific-smtp-window.c:
562 (modest_connection_specific_smtp_window_init):
563 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
564 does not seem to have any effect in osso 1.1 (though it works in
565 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
567 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
569 * src/maemo/modest-connection-specific-smtp-window.c:
570 Fix UI specification problems with projects.meamo.org NB#60479
572 2007-07-04 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
575 clue when this has failed, because the error dialog is not always shown
576 (at least in earlier version).
578 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
579 GError message, because the generic error dialog is not helpful.
581 'This message is not currently available (can't let a new connection go online)'
582 when trying to open an IMAP message.
584 (_modest_ui_actions_open): Offer a connection when some messages would
585 have to be downloaded and we are offline.
587 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
589 * src/widgets/modest-folder-view.c:
590 Don't check for MERGE type anymore as we use the correct type
592 NOTE: For the last two changes you need to update your tinymail copy
593 because of API changes!
595 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
597 * src/modest-tny-local-folders-account.c:
598 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
599 (see projects.maemo.org NB#61580)
601 2007-07-04 Murray Cumming <murrayc@murrayc.com>
603 * src/modest-tny-account.c: (on_connection_status_changed):
604 Commented out the call to modest_platform_connect_and_wait() because this
605 seems to always hang, and I would like to know if this is the only thing
606 that causes a hang when showing the connection dialog.
607 It is not very useful anyway.
609 2007-07-04 Murray Cumming <murrayc@murrayc.com>
611 * src/maemo/modest-msg-view-window.c:
612 (modest_msg_view_window_select_next_message):
614 * src/modest-platform.h:
615 * src/maemo/modest-platform.c:
616 Added modest_platform_connect_and_wait(), which calls
617 tny_maemo_conic_device_connect() always in the main thread, by calling it
618 in an idle handler and waiting for the idle handler to run. It should be
619 in the main thread because it uses GTK+ UI code. It just returns TRUE
620 if the device is already online.
622 There is some nasty code to ensure that subsequent calls to
623 modest_platform_connect_and_wait() just wait for the first one to finish,
624 by checking repeatedly in another idle handler. This is necessary,
625 because other threads (or even the main thread, via another idle handler)
626 can call modest_platform_connect_and_wait() while
627 modest_platform_connect_and_wait() is running.
629 (modest_platform_connect_and_wait_if_network_account),
630 (modest_platform_connect_and_wait_if_network_folderstore):
631 Convenience functions that calls modest_platform_connect_and_wait() if
632 the account or folder might want network access.
634 * src/modest-mail-operation.c:
635 (modest_mail_operation_update_account):
636 * src/modest-ui-actions.c: (download_uncached_messages),
637 (modest_ui_actions_on_rename_folder), (delete_folder),
638 (modest_ui_actions_on_main_window_move_to),
639 (modest_ui_actions_on_msg_view_window_move_to):
640 * src/widgets/modest-folder-view.c:
641 (drag_and_drop_from_folder_view):
642 Offer a connection if we are offline.
644 * src/modest-tny-account.c: (on_connection_status_changed):
645 Document this as only handling errors during network operations in progress,
646 and replace the idle code with a simple call to
647 modest_platform_connect_and_wait(), which does this instead.
649 2007-07-03 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-tny-account.c:
652 (modest_tny_account_get_special_folder): (util_on_idle),
653 Handle the GError so we can see when tny_folder_store_get_folders()
654 fails, as it currently does while something else is connecting.
656 Added util_run_in_main_thread_and_wait()
657 which uses an idlen handler and mainloop to ensure that the function
658 is called in the main thread.
659 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
660 to make sure that we call attempt the connection in the mainloop only,
661 which might solve some hangs.
663 2007-07-03 Murray Cumming <murrayc@murrayc.com>
665 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
666 be found by their display name. This is never useful.
667 * src/modest-tny-account-store.c: (on_account_removed): Find the account
668 by its ID, instead of trying to use its ID as its display name.
670 * src/modest-tny-account-store.h:
671 * src/modest-tny-account.c:
672 (modest_tny_account_get_special_folder): Add a g_warning() when
673 tny_folder_store_get_folders() returns an empty list for the maildir.
675 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
676 Add a g_warning() when this returns NULL, because that it not allowed
679 2007-07-02 Armin Burgmeier <armin@openismus.com>
681 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
682 note when trying to cancel the wizard. This fixes projects.maemo.org
685 2007-07-02 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-tny-account.h:
688 * src/modest-tny-account.c:
689 (modest_tny_account_new_from_server_account),
690 (modest_tny_account_new_from_server_account_name),
691 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
692 because this must now be set before setting the proto. This is usd in
693 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
694 warning in camel_session_get_service() caused by
695 tny_camel_transport_account_prepare().
697 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
700 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
702 * src/maemo/modest-connection-specific-smtp-edit-window.c:
704 (modest_connection_specific_smtp_edit_window_init):
706 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
709 2007-06-29 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-tny-account.c:
712 (modest_tny_account_new_from_server_account):
713 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
714 now uses to request a connection when it needs one, and which it uses
715 to tell us that something is wrong with the connection, so we can force
716 the accounts offline to prevent further problems.
719 * src/modest-init.c: (init_default_settings):
720 * src/modest-mail-operation.c:
721 (modest_mail_operation_update_account):
722 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
723 This should not be necessary anymore. Do not set the conf key that
724 determined this (it was always TRUE and not set anywhere else).
726 * src/modest-ui-actions.h: Remove unused and unimplemented
727 modest_ui_actions_on_online_toggle_toggled().
729 2007-06-29 Murray Cumming <murrayc@murrayc.com
731 * src/maemo/modest-main-window.c: (connect_signals):
732 Don't connect to delete_event twice. Maybe this was harmless.
734 2007-06-29 Murray Cumming <murrayc@murrayc.com
736 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
737 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
738 Debug output to give some more clue when a folder move is not allowed.
740 2007-06-28 Murray Cumming <murrayc@murrayc.com
742 * src/modest-tny-account.c: (on_modest_file_system_info),
743 (modest_tny_account_get_mmc_account_name):
744 Always call the callback, without checking whether the name has changed.
745 * src/widgets/modest-folder-view.c: (strings_are_equal),
746 (on_model_foreach_set_name), (on_get_mmc_account_name),
747 (text_cell_data): Compare the name here, and use the name from
748 the account rather than from the
749 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
750 if the name was changed after the account was added to the model.
751 That's a tinymail bug but not one that I want to fix now.
753 This finally fixes projects.maemo.org bug NB#59301.
755 2007-06-27 Armin Burgmeier <armin@openismus.com>
757 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
760 2007-06-27 Murray Cumming <murrayc@murrayc.com
762 * src/modest-tny-account.h:
763 * src/modest-tny-account.c:
764 Added modest_tny_account_get_mmc_account_name(), to set the memory
765 card name asynchronously for the given account and then notify.
766 (modest_tny_account_new_for_local_folders): Use this new function instead
767 of using hildon_file_system_info_async_new() directly.
769 * src/widgets/modest-folder-view.c: (text_cell_data):
770 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
771 gtk_tree_model_row_changed() when it is available.
773 This should fix projects.maemo.org bug NB#59301.
775 2007-06-27 Murray Cumming <murrayc@murrayc.com
777 * src/modest-mail-operation.c: (update_account_thread),
778 (get_msgs_full_thread): Fix typo failures in the revert
781 2007-06-27 Murray Cumming <murrayc@murrayc.com
783 * src/maemo/modest-maemo-global-settings-dialog.c:
784 (idle_select_default_focus):
785 * src/modest-mail-operation.c: (idle_notify_progress),
786 (idle_notify_progress_once), (set_last_updated_idle),
787 (update_account_thread), (get_msgs_full_thread):
788 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
789 * src/widgets/modest-header-view.c:
790 (idle_notify_headers_count_changed_destroy),
791 (idle_notify_headers_count_changed):
792 Reverted the additions of gdk_threads_enter/leave(), in case this
793 helps with a startup hang on the device.
795 2007-06-26 Armin Burgmeier <armin@openismus.com>
797 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
798 for supported secure authentication methods from server by
799 gtk_dialog_run(), saving CPU time and a potential race condition.
801 2007-06-26 Armin Burgmeier <armin@openismus.com>
803 * src/maemo/modest-maemo-utils.h:
804 * src/maemo/modest-maemo-utils.c: Added a
805 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
806 only error code to tell the calling code when the user canceled the
809 * src/maemo/modest-account-settings-dialog.h:
810 * src/maemo/modest-account-settings-dialog.c:
811 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
812 message if the retrieval of secure authentication methods was canceled
813 by the user. Perform the check before saving anything to configuration
814 to not end up with half-committed configuration changes, do not show
815 a "Saving to configuration failed" note when authentication methods
816 could not be retrieved.
818 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
821 2007-06-26 Murray Cumming <murrayc@murrayc.com>
823 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
824 Only return the first level of folders under accounts, because the
825 osso-global-search UI spec doesn't want the rest.
826 This fixed projects.maemo.org bug NB#61811.
828 2007-06-26 Murray Cumming <murrayc@murrayc.com>
830 * src/modest-tny-account-store.c:
831 * src/modest-tny-account-store.h:
832 Added modest_tny_account_is_memory_card_account().
833 * src/maemo/modest-main-window.c: (create_details_widget):
834 Show the same information items for the memory card as we show for the
835 local-folders, to fix projects.maemo.org bug NB#59307.
837 2007-06-26 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-tny-account-store.c: (get_password):
840 Added some checks for NULL to maybe prevent crashes, though I think
841 it was Philip's last commit that actually prevented the crash here
842 when creating a first new account.
843 But the new account is still not usable (no messages are shown)
844 until a restart of the application.
846 2007-06-26 Murray Cumming <murrayc@murrayc.com>
848 * src/maemo/modest-maemo-global-settings-dialog.c:
849 (idle_select_default_focus):
850 * src/modest-mail-operation.c: (idle_notify_progress),
851 (idle_notify_progress_once), (idle_notify_update_account_queue),
852 (set_last_updated_idle), (update_account_thread),
853 (notify_get_msgs_full), (get_msgs_full_destroyer),
854 (get_msgs_full_thread):
855 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
856 * src/widgets/modest-header-view.c:
857 (idle_notify_headers_count_changed_destroy),
858 (idle_notify_headers_count_changed):
859 Use gdk_threads_enter() and gdk_threads_enter_leave() in
860 all idle handlers, because some other thread could be blocking
861 the GDK lock, so that it can do GUI stuff.
863 2007-06-26 Murray Cumming <murrayc@murrayc.com>
865 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
866 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
867 (on_idle_send_receive), (on_idle_open_default_inbox):
868 * src/maemo/modest-msg-edit-window.c:
869 (modest_msg_edit_window_attach_file_noninteractive):
870 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
871 to prevent a hang. I don't quite understand why these are necessary,
872 beause we should already be in the main loop. I guess something outside
873 of the main loop is taking the lock.
875 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
876 we are really using URIs, and use files that are more likely to exist.
878 2007-06-26 Murray Cumming <murrayc@murrayc.com>
880 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
881 necessary because configure.ac now defines different variables.
883 2007-06-26 Murray Cumming <murrayc@murrayc.com>
885 * libmodest-dbus-client/libmodest-dbus-client.c:
886 * libmodest-dbus-client/libmodest-dbus-client.h:
887 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
888 libmodest_dbus_client_compose_mail() is what things actually use.
890 * src/dbus_api/modest-dbus-api.h:
891 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
892 * tests/dbus_api/Makefile.am:
893 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
896 2007-06-26 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-init.c: (modest_init_local_folders):
899 For memory-card (or other non local-folders) maildir accounts,
900 always create an Archive folder, so that there is somewhere to put
901 messages. This should be less confusing, because the user does not need
902 to guess that the need to create a folder.
904 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
906 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
907 Fixed icon size by using (50, 50) which is the same as defined by
910 2007-06-25 Armin Burgmeier <armin@openismus.com>
912 * src/widgets/modest-window-mgr.c:
914 * configure.ac: Correctly recognize hildon-notify presence and fixed
915 the build without it being installed.
917 2007-06-25 Murray Cumming <murrayc@murrayc.com>
919 * libmodest-dbus-client/libmodest-dbus-client.c:
920 (libmodest_dbus_client_search): Fix the build. Sorry.
921 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
922 (reply_forward_cb): Initialize variables to fix the build.
924 * src/modest-tny-account-store.c:
925 (modest_tny_account_store_get_tny_account_by): Fix the account URI
926 comparison (a silly typo) so that email search results can be opened
927 when there are more than one account.
929 2007-06-25 Murray Cumming <murrayc@murrayc.com>
931 * libmodest-dbus-client/libmodest-dbus-client.c:
932 (libmodest_dbus_client_search),
933 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
934 instead of 1 second, because the search gets folders and messages from
935 the server, which can take a long time. When it times out,
936 osso-global-search will report no results.
938 We need to specify whether we should search only cached information
939 (maybe with a user preference), and the osso-email-search-plugin
940 API should really be improved to allow that option, and to allow results
941 to be delivered asynchronously in batches.
943 2007-06-25 Murray Cumming <murrayc@murrayc.com>
945 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
946 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
947 GTK_ICON_SIZE_DIALOG is probably the wrong size.
949 2007-06-25 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
952 that is an empty string. D-Bus seems to give us these instead of NULL.
954 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
956 * src/dbus_api/modest-dbus-callbacks.c:
957 * src/maemo/easysetup/modest-easysetup-wizard.h:
958 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
960 (modest_connection_specific_smtp_edit_window_init):
961 * src/maemo/modest-maemo-global-settings-dialog.c:
963 * src/maemo/modest-maemo-utils.c:
964 (modest_maemo_utils_setup_images_filechooser):
965 * src/maemo/modest-main-window.c: (create_details_widget):
966 * src/maemo/modest-msg-edit-window.c:
967 (modest_msg_edit_window_attach_file_noninteractive),
968 (modest_msg_edit_window_color_button_change),
969 (modest_msg_edit_window_set_zoom):
970 * src/modest-mail-operation.c: (update_account_thread):
971 * src/modest-tny-account-store.c:
972 * src/modest-tny-account.c:
973 * src/widgets/modest-global-settings-dialog.c:
974 * src/widgets/modest-window.h:
978 2007-06-25 Murray Cumming <murrayc@murrayc.com>
980 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
981 * src/modest-search.c: (modest_search_folder),
982 (modest_search_all_accounts): Actually search only in the specified folder,
983 doing a simple match on the folder ID.
984 * src/modest-search.h: Added a folder field to the ModestSearch struct,
985 and added some documentation.
987 2007-06-22 Armin Burgmeier <armin@openismus.com>
989 * src/maemo/modest-maemo-utils.h:
990 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
991 modest_maemo_utils_get_supported_secure_authentication_methods.
993 * src/maemo/easysetup/modest-easysetup-wizard.c:
994 * src/maemo/modest-account-settings-dialog.c: Show correct error if
995 one occured, not just "Server does not support secure authentication".
997 2007-06-22 Murray Cumming <murrayc@murrayc.com>
999 * src/modest-tny-account-store.c: (get_password):
1000 Restored the call to tny_account_set_user() because Philip seems to have
1001 stopped this from crashing (by not using the freed string). It still does
1002 not work, but now we can test it.
1004 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1006 * src/maemo/modest-msg-edit-window.c: (init_window):
1007 Comment out use of an uninitialzed GtkScrolledWindow variable,
1008 to fix the build and stop a crash. Yet again.
1010 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-tny-account-store.c: (get_password):
1013 Remove the call to tny_account_set_user() because this actually crashes.
1014 As mentioned in the last commit, it is known to not work anyway.
1016 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-tny-account-store.c: (get_password):
1019 Use tny_account_set_username() to tell tinymail that the username might
1020 have changed too. But tinymail ignores this: see projects.maemo.org
1022 * src/modest-ui-actions.c:
1023 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1024 reset the connection when changing the username, and improve the comments.
1025 Save the changed username to gconf at least, so it is used when Modest is
1028 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1030 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1031 Do not use a query, so that we get all folders, including for POP and
1032 local-folders. They work as search criteria too.
1033 This fixes projects.maemo.org bug NB#57740.
1035 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1037 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1038 Comment out the use of hildon_notification_set_sound() because it is
1039 not declared, to fix the build. Warnings are serious, people.
1041 2007-06-21 Armin Burgmeier <armin@openismus.com>
1043 * src/maemo/modest-maemo-utils.h:
1044 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1045 modest_maemo_utils_get_supported_secure_authentication_methods()
1046 to query authentication methods for a specific user. This should fix
1047 projects.maemo.org bug NB#61369.
1049 * src/maemo/easysetup/modest-easysetup-wizard.c:
1050 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1053 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1055 * libmodest-dbus-client/libmodest-dbus-client.h:
1056 * libmodest-dbus-client/libmodest-dbus-client.c:
1057 (modest_dbus_message_iter_get_search_hit),
1058 (libmodest_dbus_client_search):
1059 Reorganised and commented this.
1060 Removed modest_search_hit_free() from the public API because it
1063 Added libmodest_dbus_client_get_folders() and
1064 modest_folder_result_list_free().
1066 * src/dbus_api/modest-dbus-api.h:
1067 * src/dbus_api/modest-dbus-callbacks.c:
1068 (modest_dbus_req_filter): Commented. Moved most code to
1069 on_dbus_method_search() and added on_dbus_method_get_folders().
1071 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1072 of the extra D-Bus handler.
1074 * tests/dbus_api/Makefile.am:
1075 * tests/dbus_api/test_get_folders.c: New test for
1076 libmodest_dbus_client_get_folders(). This seems to return an empty list
1077 at the moment. That could be the same error that causes the message list
1078 to be empty sometimes.
1079 This should help with projects.maemo.org bug NB#57740.
1081 2007-06-21 Armin Burgmeier <armin@openismus.com>
1083 * src/modest-mail-operation.c: Do not call
1084 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1085 notify the operation's end after having set the status to CANCELED for
1086 the operation queue to listen on. This fixes a deadlock when there
1087 were mail operations in the queue during its finalization.
1089 * src/modest-singletons.c: Reordered uninitialization of the account
1090 manager to happen after the mail operation queue was uninitialized
1091 because the mail operation's in the queue might still try to access
1092 the account manager (see modest_mail_operation_notify_end()). This
1093 fixes a potential crash when terminating the application.
1095 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-search.c:
1098 (search_mime_part_and_child_parts): Moved some code here so we
1099 can search recursively in child folders.
1100 (modest_search_folder): Search in the message as a mime part, instead
1101 of just its child mime parts.
1102 (read_chunk), (search_mime_part_ogs):
1103 Check how many bytes were read, to prevent an endless loop.
1104 Searching in message bodies now works. This finishes the fix for
1105 projects.maemo.org bug NB#61007.
1107 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1109 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1110 Add a g_warning when the item is not a folder.
1112 * src/modest-ui-dimming-rules.c:
1113 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1114 when selected item is not a folder (for instance, an account), because
1115 the UI spec only talks about folders.
1116 I am not sure what the UI spec wants, so this might not totally fix
1117 projects.maemo.org bug NB#60794.
1119 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1121 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1122 (load_from_file): Sort the list. The unsorted list would be more noticeable
1123 in non-English locales.
1125 * src/maemo/modest-msg-edit-window.c:
1126 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1127 warning and fix the build.
1129 * src/maemo/modest-progress-bar-widget.c:
1130 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1131 avoid a g_warning, and probably to avoid a crash.
1133 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-search.c: (modest_search_folder): Check for a GError
1136 when calling tny_folder_get_headers(), to show that this is not the cause
1139 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1141 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1142 Actually set the body query instead of the subject query.
1144 * src/modest-search.c: (search_mime_part_ogs),
1145 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1146 which would probably cause it to fail if we got this far.
1148 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1149 to simplify the code.
1150 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1151 be causing search-in-body to fail.
1153 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1155 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1157 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1158 Better debug message when the folder cannot be found.
1159 This should help with fixing projects.maemo.org bug #61287.
1160 * src/modest-search.c: (add_hit): Do not leak the furl string.
1162 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-ui-actions.c:
1165 (modest_ui_actions_on_folder_selection_changed):
1166 Do not special-case TNY_MERGE_FOLDER here, because
1167 modest_tny_folder_get_account() already does that. This fixes
1168 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1169 shown when the Outbox was selected).
1171 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1173 * libmodest-dbus-client/libmodest-dbus-client.c:
1174 (_dbus_iter_get_string_or_null): Initialize the string variable in
1175 case this helps with Dirk's crash.
1177 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1179 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1180 though it is not implemented yet (this function is maybe not even used),
1181 to avoid breaking ABI in future.
1182 * libmodest-dbus-client/libmodest-dbus-client.c:
1183 (get_attachments_string): Moved some code into this generic function.
1184 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1185 sends email. It is maybe not used.
1186 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1187 (on_send_mail): Use attachments.
1189 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1190 * src/maemo/modest-msg-edit-window.c:
1191 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1192 a filename before using it, to fix projects.maemo.org bug NB#58233.
1194 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1197 Initialize the continue_download variable to fix the build, and probably
1198 to fix randome behaviour.
1200 2007-06-18 Armin Burgmeier <armin@openismus.com>
1202 * src/modest-tny-send-queue.h:
1203 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1204 the queue so we can later show it in the UI. Replaced
1205 modest_tny_send_queue_msg_is_being_sent() by
1206 modest_tny_send_queue_get_msg_status().
1208 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1210 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1211 gpointer. This probably was not harmful, but just to be sure.
1213 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1215 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1216 Fix the build, but leave the function broken on Bora, because
1217 hildon_uri_action_get_service() does not exist.
1218 osso_uri_action_get_service() does not exist either, it seems.
1220 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-tny-account.c:
1223 (modest_tny_account_new_from_server_account):
1224 Uncommented the url debug output again, because it is useful for
1225 debugging, as I said in the comment.
1227 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1229 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1231 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1232 for Mameo Bora, to fix the build.
1234 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1237 Fixed build with hildon < 0.99
1239 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1240 Check if the selected account is busy instead of checking all accounts
1242 * src/modest-account-mgr-priv.h:
1243 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1244 (modest_account_mgr_init), (compare_account_name),
1245 (modest_account_mgr_set_account_busy),
1246 (modest_account_mgr_account_is_busy):
1247 * src/modest-account-mgr.h:
1248 Added busy information to the account manager. It possible to
1249 set an account to busy or not busy now.
1251 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1252 (modest_mail_operation_update_account),
1253 (modest_mail_operation_notify_end):
1254 Set the account to busy/not busy depending on the operation state.
1256 * src/widgets/modest-account-view.c:
1257 (modest_account_view_finalize), (get_last_updated_string),
1258 (update_account_view), (on_account_busy_changed), (init_view):
1259 Show string "Refreshing..." if the account is currently busy.
1261 All this fixes projects.maemo.org bug NB#59711
1263 2007-06-14 Armin Burgmeier <armin@openismus.com>
1265 * src/widgets/modest-attachments-view.h:
1266 * src/widgets/modest-attachments-view.c: Added
1267 modest_attachments_view_has_attachments() and fixed coordinate
1268 transformation in get_att_view_at_coords(). This fixes attachment
1271 * src/widgets/modest-msg-view.c: Make use of
1272 modest_attachments_view_has_attachments() to decide whether to show
1273 attachments in the header.
1275 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1277 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1278 (on_change), (on_combo_security_changed),
1279 (modest_connection_specific_smtp_edit_window_init),
1280 (modest_connection_specific_smtp_edit_window_set_connection),
1281 (modest_connection_specific_smtp_edit_window_is_dirty):
1282 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1283 * src/maemo/modest-connection-specific-smtp-window.c:
1286 Show an comfirmation dialog for the smpt-edit-window if there are
1287 unsaved changes and the user hits cancel.
1288 (projects.maemo.org bug NB#60479)
1290 2007-06-14 Armin Burgmeier <armin@openismus.com>
1292 * src/maemo/easysetup/modest-easysetup-wizard.c:
1293 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1294 address" info in banner instead of node, and select all the text as
1295 per UI spec. This fixes projects.maemo.org bug NB#60550.
1297 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1299 reviewed by: <delete if not using a buddy>
1301 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1302 * src/modest-ui-actions.c: (folder_refreshed_cb):
1304 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1306 * src/widgets/modest-folder-view.c: (filter_row):
1307 Explictly filter out the per-account outbox accounts. I don't know why
1308 these only sometimes show up, but now they should never show up in the UI.
1309 This should fix projects.maemo.org bug NB#60160.
1311 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1314 when the toolbar does not exist yet.
1315 * src/modest-widget-memory.c: (save_settings_header_view):
1316 Added g_warnings() to help us to discover when we are trying to set
1317 an empty columns list in gconf.
1319 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-init.h:
1322 * src/modest-init.c:
1323 Added modest_init_get_default_header_view_column_ids().
1325 * src/modest-widget-memory.c: (restore_settings_header_view):
1326 Use the new function to get defaults, if the gconf key is empty,
1327 instead of not creating any columns. This seems to fix the
1328 empty right-hand pane problems.
1330 * src/widgets/modest-header-view.h: Improved documentation.
1332 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1335 Revert the use of the display name as the account name, because this
1336 is generally wrong and would break the code that follows.
1338 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1340 * src/maemo/easysetup/modest-easysetup-wizard.c:
1341 (check_for_supported_auth_methods), (on_before_next),
1344 More correct fix for projects.maemo.org bug NB# 58991
1345 Do not longer accept AUTH_PASSWORD as secure method and choose
1346 correct method when creating the account.
1348 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1350 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1351 Fixed projects.maemo.org bug NB# 58991
1353 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-init.c: (modest_init_init_core),
1356 (modest_init_local_folders): Fixed compilation errors.
1358 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1360 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1361 Remove unnecessary lib/include, though it is good in principle when needed.
1363 * src/modest-init.c: (modest_init_one_local_folder),
1364 (modest_init_local_folders):
1365 * src/modest-init.h: Initialize the .modest library for memory cards,
1366 instead of just doing nothing for them. This should allow us to create
1367 folders there, fixing projects.maemo.org bug NB#59297.
1369 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1371 * libmodest-dbus-client/libmodest-dbus-client.c:
1372 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1373 (libmodest_dbus_client_compose_mail),
1374 (libmodest_dbus_client_open_message),
1375 (libmodest_dbus_client_send_and_receive),
1376 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1378 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1379 (on_idle_open_message), (modest_dbus_req_handler),
1380 (search_result_to_message), (modest_dbus_req_filter):
1381 * src/modest-search.c: (add_hit), (modest_search_folder),
1382 (modest_search_all_accounts): Improved debug messages.
1384 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1386 * src/modest-tny-account-store.c:
1387 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1390 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1393 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account-store.c: (get_server_accounts):
1396 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1397 even when there are no accounts, so that the Outbox folder is always
1398 visible. This fixes projects.maemo.org bug NB#60158.
1400 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1402 * src/maemo/modest-main-window.c: (create_details_widget):
1403 Use the mcen_va_never logical ID.
1405 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1407 * src/dbus_api/modest-dbus-api.h:
1408 * src/dbus_api/modest-dbus-callbacks.c:
1409 (on_idle_open_default_inbox), (on_open_default_inbox),
1410 (modest_dbus_req_handler):
1411 Added a new OpenDefaultInbox method.
1413 * libmodest-dbus-client/libmodest-dbus-client.h:
1414 * libmodest-dbus-client/libmodest-dbus-client.c:
1415 Added libmodest_dbus_client_open_default_inbox() to call the new
1416 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1417 though it should maybe be used by a new osso-email-interface function.
1419 * tests/dbus_api/Makefile.am:
1420 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1423 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1425 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1426 NULL, so that the signals get all the keys. This should not actually
1427 change any behaviour because we currently update everything when anything
1430 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1432 * src/widgets/modest-folder-view.c: (text_cell_data),
1433 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1434 (find_inbox_iter): If tinymail tells us that the folder is
1435 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1436 This causes the inbox to be selected at startup, fixing part of
1437 projects.maemo.org bug NB#56305.
1439 * src/modest-ui-dimming-rules.c:
1440 (modest_ui_dimming_rules_on_tools_smtp_servers):
1441 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1442 the SMTP servers menu item.
1443 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1444 that the SMTP Servers menu item is dimmed when there are no accounts,
1445 as a future version of the UI spec will require. This fixes
1446 projects.maemo.org bug NB#56305.
1448 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1450 * src/maemo/modest-maemo-utils.c:
1451 (modest_maemo_utils_get_supported_secure_authentication_methods):
1452 Added label to dialog instead of unreadable title
1454 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1455 (modest_main_window_new):
1456 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1459 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1460 * src/modest-account-mgr.h:
1461 Added method to avoid code duplication
1463 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1464 (modest_ui_actions_on_send_receive):
1465 Use modest_account_mgr_has_accounts
1467 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/easysetup/modest-presets.c:
1470 (modest_presets_get_info_server_security): Do not report secure auth
1472 * src/modest-protocol-info.c: Use the defines for the gconf key names
1473 for secure authentication. This was not working because we were writing
1474 Password and reading password, and the check was case sensitive.
1475 With this, gmail now works for receiving and sending when created via
1478 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1480 * src/maemo/easysetup/modest-presets.c:
1481 (modest_presets_get_info_server_security): Correct the key name for
1482 SecureSmtp, because it seems to be case-sensitive.
1483 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1484 Do not try to get the 0th notebook page if there are 0 pages, to
1485 avoid a g_warning().
1487 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1490 Prevent use of the new notification feature for now, because it currently
1491 shows one dialog for each new email, which is annoying.
1493 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1496 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1497 when no country was selected, so that we show the global ones.
1498 * src/maemo/easysetup/modest-presets.c:
1499 (modest_presets_get_providers): Return only the global providers, not
1500 all providers when mmc=0 was requested.
1502 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1505 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1506 provider ID in the combo.
1508 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1509 Do not show the page numbers, because it would be confusing when we add
1510 the 2 extra pages for the custom setup, when the user chooses the "Other"
1511 provider. This fixes projects.maemo.org bug NB#59028
1513 * src/modest-init.c: (modest_init_init_core),
1514 (modest_init_local_folders):
1515 * src/modest-init.h:
1516 * src/modest-tny-account.c:
1517 (modest_tny_account_new_for_local_folders): Do not create default folders
1518 for the memory card. This should fix projects.maemo.org bug NB#59328.
1520 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1522 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1523 Free the changed_conf_keys string items. They are already freed in the
1524 idle handler if that runs first.
1526 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1528 * src/modest-ui-actions.c:
1529 (modest_ui_actions_on_password_requested): Check that the server name
1530 is not NULL, because I just saw a password dialog with (null) as the
1533 * src/modest-tny-folder.[h|c]: Added
1534 modest_tny_folder_is_memory_card_folder().
1535 * src/modest-ui-dimming-rules.c:
1536 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1537 menu item for memory cards, as per the UI spec (section 7.4). This should
1538 fix projects.maemo.org bug NB#59297.
1540 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1542 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1543 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1544 is another problem with the code, see Murray's comment at line 772)
1546 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1548 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1549 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1550 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1551 (load_from_file), (easysetup_country_combo_box_init),
1552 (easysetup_country_combo_box_get_active_country_ids),
1553 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1554 instead of just one ID, to avoid duplicate country names in the UI.
1556 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1557 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1558 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1559 a single ID, avoiding duplicate providers.
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 (on_combo_account_country): Adapt to use a list.
1563 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1566 keys changed in the last X seconds.
1568 * src/modest-account-mgr.h:
1569 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1570 (on_key_change), (modest_account_mgr_class_init),
1571 (modest_account_mgr_init), (modest_account_mgr_finalize):
1572 As the keys are changed, save them in a GSList* and signal that GSList*
1573 further every X seconds, to batch changes, to allow us to do just one
1574 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1575 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1577 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1578 changed signal signature.
1580 * src/modest-conf.c: (modest_conf_set_list),
1581 (modest_conf_on_change): Reenable notification.
1583 (modest_conf_maemo_fake_on_change): Comment out the hack that
1584 notified immediately instead of asynchronously.
1586 * src/widgets/modest-account-view.h:
1587 * src/widgets/modest-account-view.c:
1588 (update_account_view): Select the previously-selected account ID,
1589 if possible. This fixes projects.maemo.org bug NB#56933.
1591 (on_account_changed), (on_account_removed),
1592 (modest_account_view_select_account):
1594 Remove the block/unblock functions
1595 because they were not useful.
1597 * src/maemo/modest-account-view-window.c:
1598 (on_delete_button_clicked), (on_edit_button_clicked),
1599 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1601 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1604 Improve the error dialog to show Incorrect Account Settings, which seems
1605 clearer, and say that the internal error message (to be removed from the
1606 dialog later) is often misleading.
1607 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1609 * src/modest-tny-account.c:
1610 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1611 URL because this is so useful for debugging on the device.
1613 * src/widgets/modest-serversecurity-combo-box.c:
1614 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1616 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1618 * src/modest-mail-operation.c:
1619 (modest_mail_operation_send_new_mail):
1620 Added a comment about a nasty but apparently harmless message. Details
1621 added to the wiki g_warnings() page.
1623 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1626 (modest_tny_send_queue_class_init):
1627 Do not use the priv struct because it is empty, to avoid g_warnings
1628 about a non-existant priv struct.
1630 * src/modest-tny-account-store.c:
1631 (modest_tny_account_store_get_server_account),
1632 (modest_tny_account_store_get_transport_account_for_open_connection
1633 ): Do not try to get transport server accounts for local folders,
1634 because they don't have any. This avoids a g_warning().
1636 * src/maemo/modest-main-window.c:
1637 (modest_main_window_notify_send_receive_initied),
1638 (on_configuration_key_changed):
1639 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1640 * src/modest-defs.h:
1641 * src/modest-mail-operation.c:
1642 (modest_mail_operation_update_account):
1643 * src/modest-tny-account-store.h:
1644 * src/modest-tny-account.c:
1645 (modest_tny_account_get_special_folder),
1646 (modest_tny_account_new_for_local_folders),
1647 (modest_tny_account_new_for_per_account_local_outbox_folder):
1648 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1649 * src/modest-tny-local-folders-account.c:
1650 (add_account_folders_to_merged_folder):
1651 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1652 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1653 (modest_ui_actions_on_send):
1654 * src/widgets/modest-folder-view.c: (update_model):
1655 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1656 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1657 modest_tny_account_store_get_tny_account_by_account() to
1658 modest_tny_account_store_get_server_account() to make the code clearer.
1660 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1662 * src/dbus_api/modest-dbus-api.h:
1663 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1664 * src/maemo/modest-msg-edit-window.c:
1665 (modest_msg_edit_window_attach_file_noninteractive):
1666 added g_warning in case the file to be attached does not exist
1667 * tests/dbus_api/test_compose_mail.c: (main):
1668 removed obsolete comment, added generic files as test case
1670 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-tny-account-store.c: (get_server_accounts):
1673 Create the local folders account only once, not once for each outbox, and
1674 not only when there are some outboxes.
1676 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1678 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1679 code that is causing a crash at startup. Sergio says that he is fixing this.
1681 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1683 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1684 * src/maemo/modest-account-settings-dialog.c:
1685 (create_page_outgoing),
1686 (modest_account_settings_dialog_set_account_name),
1687 (save_configuration):
1688 - Fixed handling of the "Use secure authentication" toggle to comply with
1689 the ui specification. See also projects.maemo.org bug NB#58400
1691 - Restore the Secure connection setting combo correctly when loading
1694 * src/maemo/modest-maemo-utils.c:
1695 (on_camel_account_get_supported_secure_authentication),
1696 (modest_maemo_utils_get_supported_secure_authentication_methods):
1697 Fixed a crasher if operation is canceled
1699 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1700 (modest_protocol_info_auth_is_secure):
1701 * src/modest-protocol-info.h:
1703 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1704 the sense of the "Use secure authentication" toggle.
1706 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1708 * src/modest-tny-account-store.h:
1709 * src/modest-tny-account-store.c:
1710 Added modest_tny_account_store_get_local_folders_account().
1712 * src/modest-tny-folder.h:
1713 * src/modest-tny-folder.c:
1714 (modest_tny_folder_get_account):
1715 Added this replacement for tny_folder_get_account() which returns
1716 the local-folders account for TnyMergeFolders, to avoid the
1717 warning about the unimplemented get_account_func() vfunc().
1719 (modest_tny_folder_get_rules),
1720 * src/modest-ui-actions.c:
1721 (modest_ui_actions_on_folder_selection_changed):
1722 * src/modest-mail-operation.c:
1723 (modest_mail_operation_remove_folder),
1724 (modest_mail_operation_xfer_folder),
1725 (modest_mail_operation_rename_folder),
1726 (modest_mail_operation_get_msg),
1727 (modest_mail_operation_get_msgs_full),
1728 (modest_mail_operation_remove_msg),
1729 (modest_mail_operation_xfer_msgs),
1730 (modest_mail_operation_refresh_folder):
1731 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1733 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1736 (modest_server_account_set_security):
1737 * src/modest-defs.h: Add comments explaining that our
1738 UI spec means TLS when it says Normal, so these do not look like errors.
1740 * src/modest-tny-account.c:
1741 (modest_tny_account_new_from_server_account): Use the new tinymail
1742 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1743 for TLS. This should fix projects.maemo.org bug NB#58460.
1745 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1747 * src/maemo/easysetup/modest-easysetup-wizard.c:
1748 (create_account): Correct the position of the gconf sanity check warning.
1749 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1750 of using the g_idle_add() hack, because this does not seem to be necessary
1751 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1752 caused by something other than maemo's gconf.
1753 This fixes projects.maemo.org bug #59022.
1755 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-account-mgr-helpers.c:
1758 (modest_account_mgr_get_default_account): Do not check that the account
1759 exists if there is no default account (NULL), to fix a runtime warning.
1761 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1763 * src/widgets/modest-folder-view.c: (update_model):
1764 Do not unref the treemodel before we have finished with it.
1765 This prevents a valgrind warning and an occasional crash at startup.
1767 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1769 * libmodest-dbus-client/libmodest-dbus-client.h:
1770 added libmodest_dbus_client_compose_mail()
1771 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1773 added functions needed for SendAsMail() functionality
1774 * src/maemo/modest-msg-edit-window.c:
1775 (modest_msg_edit_window_attach_file_noninteractive):
1776 non interactively attaching files to message edit window
1777 * src/widgets/modest-msg-edit-window.h:
1778 * tests/dbus_api/Makefile.am:
1779 added test_compose_mail.c
1780 * tests/dbus_api/test_compose_mail.c: (main):
1782 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1784 * src/modest-account-view.c:
1785 Fixed bug projects.maemo.org bug NB#59307
1787 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1789 * src/maemo/easysetup/modest-easysetup-wizard.c:
1790 (get_serverport_incoming), (on_before_next), (create_account):
1791 * src/maemo/modest-account-settings-dialog.c:
1792 (modest_account_settings_dialog_set_account_name):
1793 * src/maemo/modest-maemo-utils.c:
1794 (on_camel_account_get_supported_secure_authentication_status),
1795 (on_camel_account_get_supported_secure_authentication),
1796 (on_secure_auth_cancel),
1797 (modest_maemo_utils_get_supported_secure_authentication_methods):
1799 Implemented security authentication for settings and easysetup.
1801 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1803 * src/maemo/modest-main-window.c: (create_details_widget):
1804 Show the total size for memory card accounts too, instead of showing
1805 the name again. Fixes bug projects.maemo.org bug NB#59307.
1807 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1810 * src/modest-tny-simple-folder-store.c:
1811 * src/modest-tny-simple-folder-store.h: Removed.
1813 * src/modest-tny-local-folders-account.h
1814 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1815 for the local-folders maildir, with an extra TnyMergedFolder containing
1816 the folders of the per-account outbox store accounts.
1817 * src/modest-tny-account-store.c: (get_server_accounts):
1818 Add the outboxes to the special local folders account after creating it.
1820 * src/modest-tny-account.c:
1821 (modest_tny_account_new_for_local_folders): Create the derived
1822 account when creating the main local-folders account.
1824 * src/maemo/modest-main-window.c: (create_details_widget),
1825 (modest_main_window_set_contents_style):
1826 Adapted to the use of the derived account instead of the folder store.
1828 * src/modest-ui-actions.c:
1829 (modest_ui_actions_on_folder_selection_changed):
1830 * src/modest-ui-dimming-rules.c:
1831 (modest_ui_dimming_rules_on_new_folder):
1832 * src/widgets/modest-folder-view.c: (text_cell_data),
1833 (icon_cell_data), (filter_row), (update_model),
1834 (get_cmp_rows_type_pos):
1837 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1838 Do not get the priv struct, because no priv struct has been set,
1839 to avoid a runtime warning.
1841 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1842 #ifelse with #else, to fix a warning, to fix the build.
1845 2007-06-05 Christian Kellner <ckellner@openismus.com>
1847 * libmodest-dbus-client/libmodest-dbus-client.c:
1848 Fix small typo in doc (why do you always see them
1849 AFTER committing stuff?)
1852 2007-06-05 Christian Kellner <ckellner@openismus.com>
1854 * libmodest-dbus-client/libmodest-dbus-client.c:
1855 (libmodest_dbus_client_search):
1856 Initialize hit list with NULL. Also set folder list
1857 to "" if NULL was supplied.
1860 2007-06-03 Christian Kellner <ckellner@openismus.com>
1862 * libmodest-dbus-client/libmodest-dbus-client.c:
1863 (modest_search_hit_list_free):
1864 Make it save to call it with NULL.
1866 * src/dbus_api/modest-dbus-callbacks.c:
1867 * src/modest-search.c:
1868 Return full ModestSearchHits as the search result list not TnyHeader
1869 since can't be around withouth the correspoding TnyFolder.
1871 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1873 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1874 Added currently commented code to check for secure auth
1876 * src/maemo/modest-account-settings-dialog.c: (on_response),
1877 (save_configuration), (show_ok):
1878 Fixed projects.maemo.org bugs NB #59248 and #59251
1880 * src/maemo/modest-maemo-utils.c:
1881 (on_camel_account_get_supported_secure_authentication_status),
1882 (on_camel_account_get_supported_secure_authentication),
1883 (modest_maemo_utils_get_supported_secure_authentication_methods):
1884 * src/maemo/modest-maemo-utils.h:
1885 Moved get_supported_secure_authentication() method here to be able
1886 to use it from easysetup wizard.
1888 * src/modest-pair.c: (on_pair_compare_as_string):
1889 Should compare string with first part of pair and not
1890 strcmp pairs which will crash.
1892 * src/modest-protocol-info.c:
1893 (modest_protocol_info_protocol_is_store):
1894 * src/modest-protocol-info.h:
1895 Added modest_protocol_info_get_auth_protocol_name()
1897 2007-06-03 Armin Burgmeier <armin@openismus.com>
1899 * src/modest-mail-operation.c:
1900 (modest_mail_operation_get_msgs_full): Set priv->account also when
1901 only retrieving a single message. This avoids a crash when canceling
1904 (modest_mail_operation_notify_end): Do not explicitely remove the
1905 operation from the queue but only emit the progress_changed signal.
1906 The queue itself listens to that signal to remove the operation when
1907 it is finished. This reduces coupling and removes a potential deadlock
1908 when modest_mail_operation_notify_end() is called from the queue
1909 itself. If that is a problem performance-wise, I would suggest to
1910 implement a status-changed signal or something.
1912 * src/modest-mail-operation-queue.c: Make sure to never call a
1913 function from another file while the queue is locked. This (hopefully)
1914 fixes another deadlock when exiting the application while retrieving
1917 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1919 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1920 Fixed build if libogs is not available
1922 2007-06-03 Christian Kellner <ckellner@openismus.com>
1924 * libmodest-dbus-client/libmodest-dbus-client.h:
1925 * libmodest-dbus-client/libmodest-dbus-client.c:
1926 (libmodest_dbus_client_delete_message):
1927 Implement deletion of messages (Client side).
1929 (modest_search_hit_free),
1930 (modest_search_hit_list_free):
1931 Utility functions to free the result hits.
1933 * src/dbus_api/modest-dbus-api.h:
1934 * src/dbus_api/modest-dbus-callbacks.c:
1935 (on_delete_message),
1936 (modest_dbus_req_handler):
1937 Implement deletion of messages (Server side).
1939 * tests/dbus_api/test_search.c: (main):
1942 * tests/dbus_api/Makefile.am:
1943 * tests/dbus_api/test_delete_message:
1944 Add little test for the message deletion logic
1946 2007-06-03 Armin Burgmeier <armin@openismus.com>
1948 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1949 when the operation queue was not empty. projects.maemo.org bug
1952 2007-06-03 Armin Burgmeier <armin@openismus.com>
1954 * src/widgets/modest-account-view.c
1955 (on_account_default_toggled): Toggle default account column
1956 explicitely instead of waiting for gconf notification (which is
1957 currently ignored). This should fix projects.maemo.org bug NB#56910
1958 for now. It should probably be removed when gconf notifications are
1961 2007-06-03 Christian Kellner <ckellner@openismus.com>
1963 * libmodest-dbus-client/libmodest-dbus-client.c:
1964 Removed debugging spew.
1966 * src/dbus_api/modest-dbus-callbacks.c:
1967 Added debugging info.
1969 * src/modest-search.c:
1970 (modest_search_all_accounts):
1971 Use tny_account_store_get_accounts () on the account store
1972 to get all accounts which is the way to get all accounts.
1974 * tests/dbus_api/test_search.c: (main):
1975 Make it possible to supply the search term on the command line.
1977 2007-06-03 Christian Kellner <ckellner@openismus.com>
1979 * libmodest-dbus-client/libmodest-dbus-client.c:
1980 * libmodest-dbus-client/libmodest-dbus-client.h:
1981 Implement searching for mesages over raw dbus. (Client side)
1983 * src/dbus_api/Makefile.am:
1984 * src/dbus_api/modest-dbus-api.h:
1985 * src/dbus_api/modest-dbus-callbacks.c:
1986 * src/dbus_api/modest-dbus-callbacks.h:
1987 Search framework (Server side). Also implement on_idle_open_message().
1989 * src/maemo/modest-platform.c: (modest_platform_init):
1990 Prepare for raw dbus/osso rpc interaction.
1992 * src/modest-search.h:
1993 Changed minsize from unspecific guint to guint32.
1995 * src/modest-search.c:
1997 Added strange hack which magically made tnymail work.
1999 (modest_search_folder),
2000 (modest_search_account),
2001 (modest_search_all_accounts):
2002 Implement helper functions to search all accounts, specific account
2005 * tests/dbus_api/Makefile.am:
2006 * tests/dbus_api/test_open_message.c:
2007 Read url to open from commandline.
2009 * tests/dbus_api/test_search.c:
2010 Implement small test for dbus search stuff
2012 2007-06-02 Armin Burgmeier <armin@openismus.com>
2014 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2015 include account type and account title. This fixes projects.maemo.org
2018 * src/maemo/modest-account-view-window.c: Set a title for the window.
2020 2007-06-02 Armin Burgmeier <armin@openismus.com>
2022 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2023 incoming and outgoing server name based on email address and server
2024 types as long as the names have not been edited manually. This fixes
2025 projects.maemo.org bug NB#58671.
2027 2007-06-02 Armin Burgmeier <armin@openismus.com>
2029 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2030 server type cannot be changed in future to the incoming details page
2031 when creating an account. This fixes projects.maemo.org bug NB#59029.
2033 2007-06-02 Armin Burgmeier <armin@openismus.com>
2035 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2036 and assigned max width chars so that they wrap instead of being
2037 truncated. Fixes projects.maemo.org bug NB#56126.
2039 2007-06-02 Armin Burgmeier <armin@openismus.com>
2041 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2042 introductory note to the connection specific smtp servers dialog, as
2043 section 8.12 of the email UI specification requires. This fixes
2044 projects.maemo.org bug NB#59212.
2046 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2049 Check for running mail operations, and offer to cancel them, as per the UI
2050 spec. This fixes projects.maemo.org bug NB#59041 .
2051 However, I suspect that tinymail may still use the network connection
2052 in ways that we cannot detect or cancel. But it should at least adapt to
2053 changes fairly well.
2055 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-tny-account-store.c: (recreate_all_accounts),
2058 (get_cached_accounts), (get_server_accounts): Do more sensible
2059 ref-counting of the temporarily-cached outbox accounts list. This seems
2060 to fix a crash when entering the password when the password was wrong.
2062 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2064 * src/gnome/modest-main-window.c: (connect_signals):
2065 * src/modest-tny-account-store.c: (get_password),
2066 (modest_tny_account_store_alert): Added comments and clues and
2067 commented-out code about how we currently fail to deal with connection
2068 errors and wrong passwords, and how we should.
2070 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2072 * src/widgets/modest-retrieve-combo-box.c:
2073 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2074 This fixes projects.maemo.org bug NB#58472 .
2076 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/easysetup/modest-easysetup-wizard.c:
2079 (create_page_complete_easysetup):
2080 (create_page_complete_custom): Correct the last commit,
2081 putting the correct sentences in the correct pages.
2083 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/easysetup/modest-easysetup-wizard.c:
2086 (create_page_complete_custom): Show the second sentence of text
2087 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2090 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2093 Set the leave-on-server conf key by default. This fixes
2094 projects.maemo.org bug NB#59258 .
2096 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2098 * src/maemo/modest-account-view-window.c:
2099 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2100 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2103 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (create_caption_new_with_asterisk):
2107 * src/maemo/modest-account-settings-dialog.c:
2108 (create_caption_new_with_asterisk):
2109 Uncomment the code to add the asterisk, because they are no longer in the
2110 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2111 (update_incoming_server_title): Add an asterisk here too.
2113 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/modest-maemo-global-settings-dialog.c:
2116 (current_connection): Check that we are even connected before trying to
2117 get the current connection name, to prevent a warning.
2119 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2120 Change the comments because tny_maemo_conic_device_connect() is now meant to
2122 * src/modest-mail-operation.c:
2123 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2124 make sure we have a connection and fail if we can't connect.
2126 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/modest-main-window.c:
2129 (on_account_store_connecting_finished): Do not try to get the
2130 connection ID if we are not really connected. I am surprised that
2131 this signal handler is called when we are not connected.
2133 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2135 * src/modest-error.h:
2136 * src/modest-ui-actions.c:
2137 (modest_ui_actions_get_msgs_full_error_handler):
2138 Renamed an enum, added comments, added an enum
2139 for retrieve-limit errors.
2141 * src/modest-mail-operation.c: (foreach_add_item),
2142 (internal_folder_observer_update), (update_account_thread),
2143 (modest_mail_operation_get_msgs_full):
2144 (modest_mail_operation_update_account),
2145 Added comments about how this works, and some code that should
2146 (but does not) check the retrieve-limit. See the TODO comment.
2148 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2151 Initialize help_id to fix the build. Warnings are good.
2153 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2155 * src/widgets/modest-hbox-cell-renderer.c:
2156 (modest_hbox_cell_renderer_append):
2157 * src/widgets/modest-vbox-cell-renderer.c:
2158 (modest_vbox_cell_renderer_append):
2159 Fix the last commit by doing an extra ref.
2161 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2163 * src/widgets/modest-hbox-cell-renderer.c:
2164 (modest_hbox_cell_renderer_append):
2165 * src/widgets/modest-vbox-cell-renderer.c:
2166 (modest_vbox_cell_renderer_append):
2167 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2168 to fix the build with Maemo Bora.
2169 However, there seems to be a remaining crash, probably due to reference
2172 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-tny-account.c:
2175 (modest_tny_account_new_for_local_folders):
2176 Use hildon_file_system_info_async_new() to get a better name for
2177 the memory card account, setting it as the account name.
2178 The timing seems to work, but this is probably
2179 not the best place to do this. See the TODO comment.
2180 * src/maemo/modest-main-window.c: (create_details_widget):
2181 * src/widgets/modest-folder-view.c: (text_cell_data):
2182 Use the tny account name instead of hardcoding a name.
2184 2007-05-30 Christian Kellner <ckellner@openismus.com>
2186 * src/modest-search.c: (modest_search):
2187 Correctly set part_search_func even if we have already parsed
2188 the query and thus a valid OgsTextSearcher object.
2190 2007-05-30 Christian Kellner <ckellner@openismus.com>
2193 Search and check for libogs.
2196 Incooparte the ogs build env.
2198 * src/modest-mime-part-search-stream.c:
2199 * src/modest-mime-part-search-stream.h:
2200 Removed since we do the real searching now in modest-search.c.
2202 * src/modest-search.c:
2203 * src/modest-search.h:
2204 Implement support for ogs. We use that if available and requested
2205 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2206 should now handle the corner case when the search term is spread
2207 across multiple reads.
2208 Also the logic in modest_search () was corrected to search all
2209 requested fields until one is found.
2211 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2213 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2215 * src/modest-init.h:
2216 * src/modest-init.c: Made modest_init_local_folders() take a
2217 path and be public so we can iniitialize maildir folders on
2220 * src/modest-local-folder-info.h:
2221 * src/modest-local-folder-info.c:
2222 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2224 * src/modest-tny-account.c:
2225 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2226 still means the standard local-folders path on the local volume.
2228 * src/modest-tny-account-store.c:
2229 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2230 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2231 all accounts when that happens.
2232 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2233 this too, so it shows up in the treeview.
2235 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/modest-maemo-global-settings-dialog.c:
2238 (current_connection):
2239 * src/widgets/modest-global-settings-dialog.c:
2240 (current_connection_default):
2241 Use the enum values instead of 0, 1 and -1,
2242 to make the code clearer.
2244 * src/modest-account-mgr-helpers.c:
2245 (modest_account_mgr_get_connection_specific_smtp): Make this code
2248 * src/modest-runtime.h:
2249 * src/modest-runtime.c:
2250 Added modest_runtime_remove_all_send_queues().
2251 * src/maemo/modest-main-window.c:
2252 (on_account_store_connecting_finished): Recreate the send queues,
2253 using the appropriate transport accounts for this new connection.
2254 Some futher adapting might be needed if the old send queues are not
2255 automatically stopped at this point.
2257 * src/modest-tny-account-store.c: (get_server_accounts):
2258 Create the connection-specific transport accounts, so that they can
2259 be found later by their ID.
2261 * src/modest-tny-account.h:
2262 * src/modest-tny-account.c:
2263 Added modest_tny_account_new_from_server_account_name().
2264 modest_tny_account_new_from_server_account(): Do not create the
2265 send queues here, because they will be
2266 recreated anyway when the connection changes for the first time.
2268 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-local-folder-info.h:
2271 * src/modest-local-folder-info.c:
2272 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2273 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2274 tbox_folder): Take a modest account name instead of a server TnyAccount,
2275 so we can have per-modest-account rather than per-transport-account
2277 We must make sure that we change or recreate the exisitng send queues
2278 when the connection changes for connection-specific transport accounts.
2280 * src/modest-tny-account-store.c:
2281 (create_per_account_local_outbox_folders): Create outboxed per modest
2282 account, not per transport account.
2284 * src/modest-tny-account.h:
2285 * src/modest-tny-account.c:
2286 (modest_tny_account_get_special_folder): For outboxes, get the
2287 parent modest account name. The account is ignored for other folders.
2288 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2289 modest account name rather than a server TnyAccount.
2291 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2293 * src/modest-tny-account.c:
2294 (modest_tny_account_new_from_server_account):
2295 Call modest_runtime_get_send_queue() immediately after creating transport
2296 accounts, so that they start trying to send email from the outbox as soon
2297 as possible at startup. This is probably what we want.
2299 * src/modest-mail-operation.c: (update_account_thread):
2300 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2301 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2302 * src/modest-tny-send-queue.h:
2303 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2304 (modest_ui_actions_on_send):
2305 Added comments about how sending works, though it needs some more work.
2307 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-tny-account.c:
2310 (modest_tny_account_get_special_folder): Add TODO because this fails when
2311 the network is busy.
2312 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2313 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2314 Do not try to show this window when there is no active account. The UI
2315 specs does not tell us what to do in this case.
2317 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/Makefile.am:
2322 * src/widgets/Makefile.am: Some dist fixes.
2324 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2326 * src/maemo/modest-connection-specific-smtp-window.c:
2327 (on_button_edit): Make the code clearer, to prevent a double free.
2329 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/modest-account-settings-dialog.c:
2332 (modest_account_settings_dialog_set_account_name),
2333 Check the connection-specific smtp servers checkbox if there are any.
2335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2336 (modest_connection_specific_smtp_edit_window_init):
2337 Start with a suitable port number.
2339 * src/modest-account-mgr-helpers.h:
2340 * src/modest-account-mgr-helpers.c: Added
2341 modest_account_mgr_get_has_connection_specific_smtp().
2343 (modest_account_mgr_set_connection_specific_smtp),
2344 (modest_account_mgr_remove_connection_specific_smtp),
2345 (modest_account_mgr_get_has_connection_specific_smtp),
2346 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2347 connection-specific smtp server accounts in the account, rather than
2348 the server account conf dir.
2350 This fixes bug projects.maemo.org bug NB#58263 .
2352 * src/modest-tny-account-store.c:
2353 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2354 if there are no server accounts yet, to prevent an infinite loop when there
2355 are no accounts. Document that one must be called before the other.
2357 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2359 * src/modest-account-mgr-helpers.c:
2360 (modest_account_mgr_get_default_account): Make sure that at least
2361 one account is always the default, if there are any enabled accounts.
2362 This is just a sanity check that shouldn't be necessary.
2364 * src/modest-account-mgr-priv.c:
2365 (_modest_account_mgr_account_from_key): Unescape the conf key to
2366 get the real account name. For instance, this is an issue if a space
2367 was in the account name, which can happen because the account name
2368 is generated from the display name.
2369 (_modest_account_mgr_get_account_keyname): Always escape the
2371 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2372 Unescape the conf keys to get the real account names.
2374 For instance, previously the is-default radio button in the accounts
2375 list was not checked for any accounts at first. This fixes that,
2376 and might fix several similar bugs.
2378 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2380 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2381 Removed some debug printfs.
2383 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2385 Modest on-disk outbox directories are now here, for instance:
2386 $HOME/.modest/outboxes/<account-id-1>/outbox
2387 $HOME/.modest/outboxes/<account-id-2>/outbox
2389 $HOME/.modest/local-folders/outbox
2390 so we can have a separate outbox for each account.
2391 But they are shown as one outbox in the GtkTreeView, by using a
2392 TnyMergeFolder in a ModestTnySimpleFolderStore.
2395 * src/modest-tny-simple-folder-store.c:
2396 * src/modest-tny-simple-folder-store.h:
2397 Added ModestTnySimpleFolderStore, used to contain folders from
2398 other folder stores, such as other accounts.
2400 * src/modest-tny-outbox-account.h:
2401 * src/modest-tny-outbox-account.c:
2402 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2403 used for the per-account local outbox folders.
2405 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2406 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2407 only use this (internally) now for the non-outbox local folders.
2409 * src/modest-init.h:
2410 * src/modest-init.c: Added modest_init_one_local_folder(), for
2411 setting up the directory structure for each local folder.
2413 * src/modest-local-folder-info.c:
2414 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2415 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2417 * src/modest-local-folder-info.h:
2418 * src/modest-tny-account-store.c: (on_account_removed),
2419 (on_account_changed), (create_per_account_local_outbox_folders),
2420 (get_server_accounts), (modest_tny_account_store_get_accounts),
2421 (modest_tny_account_store_get_tny_account_by_account),
2422 (modest_tny_folder_store_is_virtual_local_folders):
2424 * src/modest-tny-account.h:
2425 * src/modest-tny-account.c:
2426 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2427 to create an on-disk per-account local outbox folder for each
2429 (create_per_account_local_outbox_folders): Create a local outbox folder
2430 for each transport account.
2431 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2432 for all local folders.
2434 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2435 instead of using g_object_get/set() directly. It is clearer.
2437 (modest_tny_folder_store_get_message_count),
2438 (modest_tny_folder_store_get_local_size
2439 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2440 because we now use these with non-acount folder stores.
2442 (modest_tny_account_get_special_folder),
2443 (modest_tny_account_new_from_server_account),
2444 (modest_tny_account_new_from_account):
2445 (recurse_folders): Adjust to the new outbox system.
2447 * src/modest-tny-folder.h:
2448 * src/modest-tny-folder.c:
2449 (modest_tny_folder_is_local_folder),
2450 (modest_tny_folder_get_local_folder_type),
2451 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2453 * src/widgets/modest-main-window.h:
2454 * src/maemo/modest-main-window.c: (create_details_widget),
2455 (modest_main_window_set_contents_style): Show details for any folder store,
2458 (modest_tny_folder_get_rules):
2459 Remove the const. C does not support constness enough for this.
2461 * src/modest-ui-actions.c:
2462 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2463 make all outboxes appear as one, in the usual local-folders tree node.
2465 (set_active_account_from_tny_account),
2466 (modest_ui_actions_on_folder_selection_changed):
2467 * src/widgets/modest-folder-view.c: (text_cell_data),
2468 (icon_cell_data), (filter_row),
2469 (add_account_folders_to_merged_folder),
2470 (add_account_folders_to_simple_folder_store), (),
2471 (get_cmp_rows_type_pos), (cmp_rows),
2472 (modest_folder_view_set_account_id_of_visible_server_account):
2473 Adjust to the new outbox system, using generic folder stores and folders
2474 in the GtkTreeModel.
2476 2007-05-23 Christian Kellner <ckellner@openismus.com>
2478 * src/modest-mail-operation.c:
2479 (modest_mail_operation_update_account):
2480 Use info->max_size instead of unintialized local var [small
2481 build fix]. (Added TODO to review that change since I don't
2484 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2486 * libmodest-dbus-client/libmodest-dbus-client.c:
2487 (libmodest_dbus_client_compose_mail): function added
2488 * src/dbus_api/modest-dbus-api.h:
2489 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2490 (on_compose_mail): Implementation of the SendAsMail functionality
2492 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2494 * src/modest-account-mgr.c:
2495 (modest_account_mgr_add_server_account): Set the secure-connection
2496 conf key for transport accounts as well as store accounts. I don't know
2497 why the if was there. For instance, this makes sure that we use SSL
2498 for the gmail preset from the easysetup wizard.
2500 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2502 * src/gnome/modest-main-window.c:
2503 (on_account_store_connecting_finished), (connect_signals):
2504 * src/maemo/modest-main-window.c:
2505 (on_account_store_connecting_finished), (connect_signals),
2506 (modest_main_window_new):
2507 Handle TnyAccountStore::connecting-finished instead of
2508 TnyDevice::connection-changed, because we cannot actually perform
2509 operations on accounts until TnyAccountStore has itself responded to
2510 the TnyDevice::connection-changed signal. This prevents a GError from
2512 Do not try to update at startup, because we (at least on scratchbox)
2513 already do an update at startup when the device goes online.
2514 This prevents a GError from tinymail.
2515 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2516 Added TODO about stopping simultaneous operations.
2518 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2520 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2521 * src/modest-mail-operation-queue.c:
2522 (modest_mail_operation_queue_remove):
2523 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2524 about where they happened.
2526 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2528 * src/modest-ui-actions.c:
2529 (modest_ui_actions_on_password_requested): Make sure that the remember
2530 output parameter is always TRUE.
2532 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2534 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2535 Show a OK/Cancel dialog if the error is a question, though we still do not
2536 know anything more about what we are asking the user.
2537 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2538 Fix an uninitialized variable (helper). This is a logic error, however.
2540 2007-05-21 Christian Kellner <ckellner@openismus.com>
2542 * src/modest-search.h:
2543 Correct bit shifting in the ModestSearchFlags enum.
2545 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2547 * src/modest-tny-account.c:
2548 (modest_tny_account_new_from_server_account): Do not use the lsub and
2549 check-all hard-coded IMAP options when using POP.
2551 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2553 * src/modest-tny-account.c:
2554 (modest_tny_account_new_from_server_account):
2555 Use NULL for the secure-auth method for POP when Password auth has been
2556 specified by the user, as we already do for IMAP. "auth=Login" causes
2557 an error from camel or the server.
2559 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2561 * src/maemo/modest-account-settings-dialog.c:
2562 (create_page_account_details),
2563 (modest_account_settings_dialog_set_account_name):
2564 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2565 for the leave-on-server checkbox, rathr than just the checkbox, when
2566 the protocol is not POP.
2568 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2570 * src/widgets/modest-account-view.c:
2571 * src/widgets/modest-account-view.h:
2572 Added modest_account_view_select_account() which will be useful later
2573 to asynchronously re-select the edited account.
2575 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2577 * src/maemo/modest-account-settings-dialog.c:
2578 (modest_account_settings_dialog_set_account_name):
2579 Automatically choose the port numbers based on the secure authentication
2580 methods, if they have not been chosen before.
2581 This fixes projects.maemo.org bug NB#56273 .
2583 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/modest-main-window-ui.h:
2586 * src/modest-ui-actions.c:
2587 * src/modest-ui-actions.h:
2588 Connect the Tools/SMTP Servers menu item to
2589 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2590 SMTP servers dialog, as in the UI specification and saves changes when it
2591 is closed. This fixed projects.maemo.org bug NB#56305 .
2593 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2595 * src/maemo/modest-connection-specific-smtp-window.c:
2596 (modest_connection_specific_smtp_window_init):
2597 Use gtk_window_set_default_size() to make this window big enough, so
2598 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2600 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2602 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2603 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2604 (modest_connection_specific_smtp_edit_window_init),
2605 Do not try to connect to a combobox signal before the combobox exists.
2606 This fixes the cras in projects.maemo.org bug NB#56288 .
2607 (modest_connection_specific_smtp_edit_window_get_settings):
2608 Remove the server_account_name parameter which was being checked for NULL
2609 though it was not used.
2611 * src/maemo/modest-connection-specific-smtp-window.c:
2612 (modest_connection_specific_smtp_window_fill_with_connections),
2613 (on_button_edit), (modest_connection_specific_smtp_window_init):
2614 Correct the number of treemodel columns to prevent a warning.
2615 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2616 libconic does not work.
2618 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2620 * src/modest-tny-account.c:
2621 (modest_tny_account_new_from_server_account):
2622 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2623 SMTP when "None" was chosen by the user. However, with my SMTP server that
2624 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2627 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2630 to explain the memory management issue with the ID in the ModestPair.
2632 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2633 (add_sending_page), (modest_account_assistant_finalize):
2634 * src/gnome/modest-gnome-global-settings-dialog.c:
2635 (create_updating_page), (create_composing_page):
2636 * src/gnome/modest-msg-edit-window.c: (get_transports),
2637 (init_window), (modest_msg_edit_window_finalize),
2638 (modest_msg_edit_window_get_msg_data):
2639 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2640 * src/gnome/modest-transport-widget.c:
2641 (modest_transport_widget_finalize), (smtp_configuration):
2642 * src/maemo/modest-maemo-global-settings-dialog.c:
2643 (create_updating_page), (create_composing_page):
2644 * src/maemo/modest-msg-edit-window.c: (get_transports),
2645 (init_window), (modest_msg_edit_window_finalize),
2646 (modest_msg_edit_window_get_msg_data),
2647 (modest_msg_edit_window_free_msg_data):
2648 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2649 (modest_store_widget_finalize):
2650 * src/maemo/modest-transport-widget.c:
2651 (modest_transport_widget_finalize), (smtp_configuration):
2652 * src/modest-main.c: (send_mail):
2653 * src/widgets/modest-combo-box.h:
2654 * src/widgets/modest-global-settings-dialog-priv.h:
2655 * src/widgets/modest-global-settings-dialog.c:
2656 (modest_global_settings_dialog_finalize):
2657 * src/widgets/modest-msg-edit-window.h:
2658 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2659 as long as the combo box, to prevent use of freed memory for the ID.
2661 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2664 get_accounts(), to make this clearer. Do not check for the enabled gconf
2665 key, because we do not use this for server accounts (at least, not yet).
2666 This allows us to send email again.
2668 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2670 * src/maemo/modest-platform.c:
2671 (on_modest_conf_update_interval_changed), (modest_platform_init):
2672 Only respond to this particular key change. All these strcmp()s cannot be
2675 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/modest-maemo-global-settings-dialog.c:
2678 (current_connection): Prevent a crash in scratchbox when
2679 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2680 * src/maemo/modest-platform.c:
2681 (on_modest_conf_update_interval_changed), (modest_platform_init):
2682 Get the update interval from gconf and reset it when the gconf key changes.
2684 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2686 * src/modest-protocol-info.c:
2687 * src/modest-protocol-info.h: Adde enum-specific get functions,
2688 instead of using a ModestProtocolType enum parameter.
2690 * src/gnome/modest-account-assistant.c:
2691 * src/gnome/modest-store-widget.c:
2692 * src/gnome/modest-store-widget.h:
2693 * src/gnome/modest-transport-widget.c:
2694 * src/gnome/modest-transport-widget.h:
2695 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2696 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2697 * src/maemo/easysetup/modest-easysetup-wizard.c:
2698 * src/maemo/modest-account-settings-dialog.c:
2699 * src/maemo/modest-account-settings-dialog.h:
2700 * src/maemo/modest-store-widget.c:
2701 * src/maemo/modest-store-widget.h:
2702 * src/maemo/modest-transport-widget.c:
2703 * src/maemo/modest-transport-widget.h:
2704 * src/modest-account-mgr-helpers.c:
2705 * src/modest-account-mgr-helpers.h:
2706 * src/modest-account-mgr.c:
2707 * src/modest-account-mgr.h:
2708 * src/modest-tny-account.c:
2709 * src/modest-tny-folder.c:
2710 * src/widgets/modest-account-view.c:
2711 * src/widgets/modest-retrieve-combo-box.c:
2712 * src/widgets/modest-retrieve-combo-box.h:
2713 * src/widgets/modest-secureauth-combo-box.c:
2714 * src/widgets/modest-serversecurity-combo-box.c:
2715 * src/widgets/modest-serversecurity-combo-box.h:
2716 * tests/check_account-mgr.c:
2717 Use the specific functions, and use the re-renamed enum values for GNOME too.
2719 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2721 * src/modest-pair.h:
2722 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2723 so we can get the second based on the first.
2725 * src/maemo/modest-account-settings-dialog.h:
2726 * src/maemo/modest-account-settings-dialog.c:
2727 Added get_supported_secure_authentication_methods(), though it is mostly
2728 commented-out for now until the necessary API is committed to tinymail.
2729 (modest_account_settings_dialog_set_account_name),
2730 (save_configuration): Request the supported authentication methods from the
2731 server, so we can choose a working method.
2733 * src/modest-tny-account-store.h:
2734 * src/modest-tny-account-store.c:
2735 (modest_tny_account_store_get_session): Rename from
2736 tny_account_store_get_session().
2738 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2740 * src/modest-protocol-info.h: Split the ModestProtocol enum
2741 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2742 There was no need to have these unrelated values in one enum.
2744 * src/: many files: Adapted to changed enum. This makes the code a bit
2745 clearer, and the compiler could catch some errors.
2747 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2750 Show the detailed internal camel error message when an error happens
2751 during the configuration, so that our testers can give us more clues.
2752 For instance, in projects.maemo.org bug NB#56910 .
2754 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2756 * src/modest-tny-account.c:
2757 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2758 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2760 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2763 * src/maemo/modest-account-settings-dialog.c:
2764 (modest_account_settings_dialog_set_account_name),
2765 (save_configuration): For the incoming secure authentication checkbox,
2766 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2767 the UI specification. PLAIN does not seem to be supported for most IMAP
2768 servers anyway, and I am not sure what it would mean.
2769 However, we probably need to discover which of the secure-authentication
2770 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2771 * src/modest-account-mgr-helpers.c:
2772 (modest_account_mgr_get_server_account_data):
2774 * src/modest-tny-account.c:
2775 (modest_tny_account_new_from_server_account):
2776 Use tny_account_set_mech() to set secure-authentication methods,
2777 with some special-casing for IMAP, based on my observations of how
2780 * src/modest-account-mgr-helpers.h:
2781 * src/modest-account-mgr.c:
2782 * src/modest-defs.h: Comment that the URI is only used for local folders.
2784 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2787 parameter const, just to be neat.
2788 * src/modest-text-utils.c: (modest_text_utils_inline):
2789 End g_strconcat() with NULL, as its documentation says. This is almost
2790 certainly the cause of my crash at startup on the device. Interestingly,
2791 valgrind doesn't tell us about these errors.
2793 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2795 * scripts/build-packages: Added more precise comments about how to use
2796 this script, though I still get this error:
2797 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2798 error building tinymail
2800 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-main-window.c: (on_account_update):
2803 Very slight cleanup, hoping to make it simpler to discover what causes
2804 a crash here sometimes.
2806 * src/modest-tny-account.c:
2807 (modest_tny_account_new_from_server_account): Set the port. Added
2808 comments about the options and a TODO comment because I need to find out
2809 how to specify the secure authentication method.
2811 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2813 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2814 changed CFlags paths form modest to libmodest
2816 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2818 * src/modest-account-mgr-helpers.c:
2819 (modest_account_mgr_get_server_account_data),
2820 (modest_account_mgr_free_server_account_data):
2821 * src/modest-account-mgr-helpers.h:
2822 * src/modest-account-mgr.c:
2823 (modest_account_mgr_add_server_account):
2824 * src/modest-defs.h:
2825 * src/modest-tny-account.c:
2826 (modest_tny_account_new_from_server_account):
2827 Determine the options for tny_camel_account_add_option() here,
2828 based on the settings, rather than storing them directly in gconf.
2830 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2832 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2833 Show a more friendly error dialog now that we expect (from the tinymail
2834 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2836 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2838 * src/maemo/modest-main-window.c: (on_account_update): Check that
2839 account_name is not NULL, to prevent a crash at startup that I am
2840 seeing on the N800. I do wonder why it is NULL.
2842 * src/maemo/easysetup/modest-easysetup-wizard.c:
2843 (create_page_user_details):
2844 * src/maemo/modest-account-settings-dialog.c:
2845 (create_page_user_details), (create_page_outgoing):
2846 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2847 (modest_connection_specific_smtp_edit_window_init):
2848 * src/modest-ui-actions.c:
2849 (modest_ui_actions_on_password_requested):
2850 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2851 might do something useful with the on-screen keyboard.
2853 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2855 * src/maemo/modest-main-window.c: (on_account_update):
2856 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2857 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2859 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2861 * src/modest-tny-account-store.c: (on_account_changed):
2862 Correct the signature of this signal handler.
2864 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2866 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2867 Show a HildonNote instead of a GtkDialog for Maemo.
2869 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2871 * src/widgets/modest-account-view.h:
2872 * src/widgets/modest-account-view.c: (on_account_changed),
2873 (on_account_removed). Added a boolean flag, set/unset by
2874 modest_account_view_block_conf_updates(),
2875 modest_account_view_unblock_conf_updates() to prevent unnecessary
2876 updates, but this is not very useful because the gconf notifications are
2877 so delays (maybe only on Maemo Bora).
2878 So auto-updating is turned off, and these functions do an explicit
2879 update when necessary.
2880 However, something else is still doing too much work when adding/removing
2881 accounts, probably in another part of the application.
2883 * src/maemo/modest-account-view-window.c:
2884 (on_delete_button_clicked), (on_edit_button_clicked),
2885 (on_new_button_clicked): Use the new functions.
2887 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2889 * src/modest-account-mgr-helpers.c:
2890 (modest_account_mgr_set_first_account_as_default):
2891 Sort the list of names alphabetically-by-title, so we choose the first one
2893 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2894 alphabetically by the title.
2896 This fixes projects.maemo.org bug NB#56418 .
2898 * src/modest-account-mgr-priv.c:
2899 (_modest_account_mgr_account_from_key):
2900 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2901 avoid a valgrind error, and possible random behaviour.
2903 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2905 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2906 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2907 tinymail documentation to say that this can be expected.
2908 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2909 pretty, and should not happen, but I would prefer to know when it does.
2911 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2913 * configure.ac: When using the older hildon version, probably on Bora,
2914 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2916 * src/widgets/modest-attachment-view.c:
2917 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2920 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2922 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2923 Implemented the prototype. Can be tested with
2924 tests/dbus_api/test_open_message:
2926 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-tny-account-store.c:
2929 (modest_tny_account_store_instance_init), (get_password):
2930 * src/modest-ui-actions.c:
2931 (modest_ui_actions_on_password_requested):
2932 Do not store the password in gconf, because this function is called
2933 for non-remembered passwords. Actually use the cached (in the hash map)
2934 password instead of releasing it.
2935 The password will now not be remembered if it is asked via the protected
2936 password dialog, as per the UI spec.
2938 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-defs.h:
2941 * src/modest-account-mgr-helpers.h:
2942 * src/modest-account-mgr-helpers.c:
2943 Added modest_server_account_get_username_has_succeeded(),
2944 modest_server_account_set_username_has_succeeded().
2945 (modest_server_account_set_username),
2946 Reset the has-succeeded flag if the username changes.
2948 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2949 * src/maemo/modest-connection-specific-smtp-window.c:
2950 (modest_connection_specific_smtp_window_save_server_accounts):
2951 Use modest_server_account_set_username() instead of using
2952 modest_conf_set_string() directly, so that the has-succeeded flag is always
2955 * src/modest-ui-actions.c:
2956 (modest_ui_actions_on_password_requested): Dim the username entry if
2957 the username has ever worked, as per the UI spec.
2959 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2961 * src/modest-tny-account-store.c: (get_password):
2962 * src/modest-ui-actions.c:
2963 (modest_ui_actions_on_password_requested):
2964 Allow the username to be changed too, though there is more work to
2965 be done on exactly how this behaves.
2967 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2969 * src/modest-account-mgr-helpers.h:
2970 * src/modest-account-mgr-helpers.c:
2971 Added modest_account_mgr_get_display_name(),
2972 modest_server_account_get_username(),
2973 modest_server_account_set_username(),
2974 modest_server_account_set_password(),
2975 modest_server_account_get_hostname() functions so we do not need to
2976 use the conf API directly.
2978 * src/maemo/modest-main-window.c: (connect_signals):
2979 Actually connect ot the ModestAccountStore::request-password signal,
2980 so that we show the dialog when the password is requested by Tinymail,
2981 for isntance if it is empty.
2983 * src/modest-marshal.list:
2984 * src/modest-tny-account-store.c:
2985 (modest_tny_account_store_class_init), (get_password),
2986 (modest_tny_account_store_alert):
2987 * src/modest-tny-account-store.h:
2988 * src/modest-ui-actions.h:
2989 * src/modest-ui-actions.c:
2990 (modest_ui_actions_on_password_requested):
2991 Change the signal parameters, so it is obvious that we are providing
2992 the non human-readable server name, and receiving both the username
2993 and password, though changing of the username is not yet implemented.
2994 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2995 for the GNOME version.
2997 This should fix the projects.maemo.org bug NB#56209, though it does not
2998 work on Bora, because the gconf_client_get() for the password fails
2999 immediately after we save it with gconf_client_set().
3001 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3004 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3005 caused an undefined symbol error:
3006 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3008 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3010 * src/modest-tny-account-store.c:
3011 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3012 using a GError instead of a string message, so we can translate it in
3015 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3017 * src/maemo/modest-address-book.c:
3018 (modest_address_book_check_names):
3019 * src/maemo/modest-msg-view-window.c:
3020 (modest_msg_view_window_clipboard_owner_change):
3021 * src/modest-init.c: (modest_init_init_ui):
3022 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3023 (update_folders_cb), (modest_mail_operation_update_account):
3024 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3025 (modest_ui_actions_on_msg_attachment_clicked),
3026 (modest_ui_actions_on_msg_recpt_activated):
3027 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3028 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3029 (modest_msg_view_search_next):
3030 * src/widgets/modest-recpt-editor.c:
3031 (modest_recpt_editor_on_button_release_event),
3032 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3033 g_message(). At this point we should only be seeing interesting errors on
3034 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3036 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3038 (modest_wizard_dialog_force_title_update):
3039 * src/maemo/easysetup/modest-wizard-dialog.h:
3040 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3041 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3042 can update the title when appropriate. Otherwise the title is wrong if the
3043 pages are added after adding the notebook to the dialog.
3044 This must be a problem in HildonWizardDialog too.
3045 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3047 * src/maemo/easysetup/modest-easysetup-wizard.c:
3048 (create_subsequent_customsetup_pages),
3049 (create_subsequent_easysetup_pages):
3050 Call modest_wizard_dialog_force_title_update() so that the title is
3051 correct even with GTK+ < 2.10.
3052 This fixes projects.maemo.org bug NB#56145 .
3054 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3056 * src/maemo/modest-platform.c:
3057 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3058 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3061 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3063 * src/widgets/modest-window.h:
3064 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3065 and modest_window_save_state(), which invokes it.
3067 * src/widgets/modest-window-mgr.h:
3068 * src/widgets/modest-window-mgr.c:
3069 Added modest_window_mgr_save_state_for_all_windows(), which calls
3070 the save_state vfunc on all registered windows, if implemented.
3072 * src/gnome/modest-msg-edit-window.c:
3073 * src/gnome/modest-msg-view-window.c:
3074 * src/maemo/modest-msg-edit-window.c:
3075 * src/maemo/modest-msg-view-window.c:
3076 * src/maemo/modest-main-window.c:
3077 Specify the existing save_settings functions as implementations of
3078 ModestWindow::save_state_func().
3080 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3081 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3082 enabling hibernation, for instance.
3084 We may need to do the same thing for restoring settings.
3087 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3089 * src/widgets/modest-window-mgr.c:
3090 * src/widgets/modest-window-mgr.h:
3091 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3092 modest_window_mgr_get_hibernation_is_prevented().
3094 * src/maemo/modest-main-window.c:
3095 (on_hildon_program_is_topmost_notify): Prevent hibernation
3096 (possible when the application goes to the background in the WM),
3097 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3099 * src/maemo/easysetup/modest-easysetup-wizard.c:
3100 (modest_easysetup_wizard_dialog_init):
3101 * src/maemo/modest-account-settings-dialog.c:
3102 (modest_account_settings_dialog_init):
3103 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3104 (modest_connection_specific_smtp_edit_window_init):
3105 * src/maemo/modest-connection-specific-smtp-window.c:
3106 (modest_connection_specific_smtp_window_init):
3107 * src/maemo/modest-signature-editor-dialog.c:
3108 (modest_signature_editor_dialog_init):
3109 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3110 prevent hibernation while any of these account settings dialogs are open.
3112 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3114 * src/maemo/Makefile.am:
3115 * src/maemo/modest-osso-state-saving.c:
3116 * src/maemo/modest-osso-state-saving.h: Added
3117 modest_osso_load_state() and modest_osso_save_state() though they do
3118 nothing now. They should iterate through all the open windows and load/save
3120 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3121 save state when closing.
3123 * src/maemo/modest-main-window.c:
3124 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3125 Add a notification handler for the HildonProgram::is-topmost property,
3126 so we can allow hibernation when the application goes into the background.
3127 But we still need to detect when the accounts setup windows are open so
3128 we can stop hibernation when they are open.
3129 To do this, I also added the main window the HildonProgram. This might have
3130 other side-effects/benefits, and should maybe be done for other windows.
3132 * src/maemo/modest-osso-autosave-callbacks.h:
3133 * src/maemo/modest-osso-autosave-callbacks.c:
3134 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3135 though it does not do anything yet, and we might never need this to do
3136 anything. For instance, we already save drafts.
3138 * src/maemo/modest-platform.c: (modest_platform_init):
3139 Specify the libosso auto-save callback.
3141 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3143 * src/maemo/modest-platform.c:
3144 (modest_platform_set_update_interval):
3145 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3146 aparently stays valid between application instances, so we can use this
3147 to remove and reset it later. According to a maemo-developers email from
3150 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3152 * configure.ac: Depend on libalarm for Maemo.
3154 * src/dbus_api/modest-dbus-api.h:
3155 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3156 (on_send_receive), (modest_dbus_req_handler):
3157 Handle a SEND_RECEIVE D-Bus method.
3159 * libmodest-dbus-client/libmodest-dbus-client.c:
3160 (libmodest_dbus_client_send_and_receive):
3161 * libmodest-dbus-client/libmodest-dbus-client.h:
3162 Add C convenience functions for calling the new D-Bus method.
3164 * src/modest-platform.h:
3165 * src/gnome/modest-platform.c:
3166 * src/maemo/modest-platform.c:
3167 Added modest_platform_set_update_interval(), which uses the
3168 alarmd API on Maemo.
3169 (modest_platform_init),
3170 Call modest_platform_set_update_interval(), using a hard-coded
3171 interval for now (until the global settings dialog is implemented),
3172 though I am not sure that this makes sense yet.
3174 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3176 * src/dbus_api/modest-dbus-callbacks.c:
3177 (modest_osso_cb_hw_state_handler):
3178 * src/dbus_api/modest-dbus-callbacks.h:
3179 * src/maemo/modest-platform.c: (modest_platform_init):
3180 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3181 in case this has some effect on the ability for Maemo to ping the
3184 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3186 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3187 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3188 warning. It is probably a logic error, but I need to fix the build.
3190 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3192 * src/modest-account-mgr.h:
3193 * src/modest-account-mgr.c:
3194 (modest_account_mgr_account_names): Add a gboolean enabled_only
3195 parameter, so we can get lists of onlt the enabled accounts.
3197 (modest_account_mgr_add_account),,
3198 (modest_account_mgr_account_with_display_name_exists):
3199 * src/maemo/modest-msg-edit-window.c: (get_transports):
3200 * src/modest-account-mgr-helpers.c:
3201 (modest_account_mgr_set_first_account_as_default):
3202 * src/modest-init.c: (init_default_account_maybe):
3203 * src/modest-tny-account-store.c: (get_accounts):
3204 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3205 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3206 * tests/check_account-mgr.c: (START_TEST):
3207 Provide the extra parameter, as appropriate.
3209 * src/widgets/modest-account-view.c: (update_account_view):
3210 Do not show disabled accounts (meaning that there is no way to
3211 enable/disable accounts in the UI (the feature is not in our UI
3212 specification), so we can use this internally only to mark unfinished
3213 or temporary account data.
3215 * src/maemo/easysetup/modest-easysetup-wizard.c:
3216 (create_account): Add boolean enable parameter, so we can specify FALSE
3217 to create the temporary account.
3218 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3219 (on_before_next): When finishing, when there is a temporary account, just
3221 Also, use a timeout to delay the showing of the dialog until gconf is likely
3222 to return correct information, due to a maemo gconf bug that is fixed in
3223 osso 1.1, but not yet in Bora.
3224 However, the dialog stays on screen after it is destroyed.
3226 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3227 for invalid data when cancelling. Use a hildon note instead of a dialog
3228 to complain about invalid data. Do not show the account-saved note if the
3229 account is disabled (a temporary account that will not really be saved for use
3232 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3234 * src/modest-account-mgr-helpers.h:
3235 * src/modest-account-mgr-helpers.c:
3236 Added modest_account_mgr_unset_default_account(),
3237 Added modest_account_mgr_set_first_account_as_default().
3239 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3240 If it was the default account, unset the default account name.
3242 * src/maemo/modest-account-view-window.c:
3243 (on_delete_button_clicked): If it was the default account,
3244 set the first remaining account as the default instead.
3246 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3247 a NULL account or a NULL default account, to prevent a crash. This should
3248 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3251 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3253 * src/widgets/modest-recpt-editor.c:
3254 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3255 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3256 TODO comment for this. This fixes the build.
3258 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3259 be the best place for it. This will in future update all auto-update accounts,
3260 rather than just the current/default account, when that gconf key exists.
3261 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3262 if there are no accounts, before calling do_send_receive().
3263 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3265 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3266 * src/maemo/modest-main-window-ui.h:
3267 * src/maemo/modest-main-window.c: (on_connection_changed),
3268 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3269 directly, becaue the signal handler does more.
3271 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3273 * src/modest-account-mgr-helpers.c:
3274 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3275 for the case that the account does not exist.
3277 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3278 (equivalent to the modest account name) rather than the tinymail account name
3279 (equivalent to the modest account title - human readable) to get the account data.
3280 Check for null account data to prevent the crash, and add a TODO comment saying that
3281 this needs fixing because it is using the server account name instead of the account name.
3283 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3285 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3286 * src/maemo/modest-account-settings-dialog.c: (show_error),
3288 Use hildon_note_new_information() for informative and error messages,
3289 which seems to be expected for Maemo applications (no documentation that I know of
3290 says this). I am surprised that there is no distinction between info and error
3293 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3295 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3296 it is easy to find where this is used.
3298 * src/maemo/easysetup/modest-easysetup-wizard.c:
3299 (create_page_welcome), (create_page_account_details),
3300 (create_page_user_details), (create_page_complete_easysetup),
3301 (create_page_custom_incoming), (create_page_custom_outgoing),
3302 (create_page_complete_custom):
3303 * src/maemo/modest-account-settings-dialog.c:
3304 (create_page_account_details), (create_page_user_details),
3305 (create_page_incoming), (create_page_outgoing):
3306 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3308 (modest_connection_specific_smtp_edit_window_init):
3309 * src/maemo/modest-connection-specific-smtp-window.c:
3310 (modest_connection_specific_smtp_window_init):
3311 * src/maemo/modest-signature-editor-dialog.c:
3312 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3313 and scrolling policy as per the Email Application Layout Guide, if I have
3316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3318 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3319 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3320 which were empty, because these vfuncs have been removed from TnyAccountStore.
3321 This fixes the build.
3323 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/modest-main-window.c:
3326 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3327 showing/hiding it. Added TODO because it probably should not be NULL.
3328 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3329 because unnecessary g_warnings() make degugging difficult.
3331 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/modest-msg-edit-window.c:
3334 (modest_msg_edit_window_select_color),
3335 (modest_msg_edit_window_select_background_color): 2 const corrections and
3336 moving 2 #endifs before closing brackets, to fix the build.
3338 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3340 * src/maemo/easysetup/modest-easysetup-wizard.h:
3341 * src/maemo/easysetup/modest-easysetup-wizard.c:
3342 (modest_easysetup_wizard_dialog_finalize),
3343 (on_button_edit_advanced_settings), (create_page_complete_custom),
3344 (on_response), (create_account):
3345 Implement the Advanced Settings edit button, by saving the account information,
3346 for the Advanded Settings dialog to use directly from gconf, and removing it
3347 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3348 Bug #5533 in the projects.maemo.org bugzilla.
3350 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3352 * src/maemo/modest-msg-view-window.c:
3353 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3354 when opening a message window.
3356 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3358 * src/maemo/easysetup/modest-easysetup-wizard.c:
3359 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3362 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3363 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3364 gconf settings. I probably added more checks than necessary, but that is safer.
3366 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3367 variable to fix the build, but this seems to be used when it is still NULL.
3369 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-platform.h:
3372 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3373 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3374 * src/modest-main.c: Implement this function so we can avoid using
3375 maemo-specific API from cross-platform code.
3377 * src/modest-tny-account-store.c:
3378 (get_smtp_specific_transport_account_for_open_connection):
3379 * src/modest-ui-actions.c: (check_for_connection),
3380 (modest_ui_actions_on_item_not_found):
3381 Use modest_platform_connect_and_wait() and put #idefs around other
3382 maemo-specific code, because only maemo currently has a way to
3383 identify connection names.
3385 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3387 * src/modest-tny-account-store.h:
3388 * src/modest-tny-account-store.c:
3389 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3390 the connection-specific SMTP server settings in the configuration.
3392 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3394 * src/maemo/modest-main-window.c: (on_connection_changed),
3396 * src/modest-main.c: (main), (start_ui), (send_mail):
3397 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3398 that is what is intended.
3400 * src/modest-ui-actions.c: (action_send), (action_receive),
3401 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3402 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3403 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3404 SMTP server is used when it is specified.
3406 (modest_ui_actions_on_send_receive):
3407 Check that a connection is open before proceeding.
3408 Receive and then send, instead of vice-versa, as per the specification.
3410 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3412 * src/modest-mail-operation.c:
3413 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3414 though I guess it should be something other than NULL.
3416 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3418 * src/maemo/easysetup/modest-easysetup-wizard.c:
3419 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3420 combo twice, to avoid an g_warning and to make it visible again.
3421 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3422 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3423 (already intended) dereference when detaching, because we then recreate the menu.
3424 But I am not sure why the warning was happening, and it is possible that this is a memory
3427 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3429 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3430 and uri_parse_mailto() utility functions.
3431 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3433 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3435 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3437 * src/dbus_api/modest-dbus-api.h:
3438 * src/dbus_api/modest-dbus-callbacks.c:
3439 Use an idle callback to execute the modest code in the application's own thread.
3440 Remove the helloworld example method.
3441 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3442 parsed, and the open-message method is not implemented because this is not yet implemented in
3444 * libmodest-dbus-client/libmodest-dbus-client.c:
3445 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3446 (libmodest_dbus_client_open_message):
3447 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3449 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3450 body without crashing.
3452 * tests/dbus_api/Makefile.am:
3453 * tests/dbus_api/test_mail_to.c:
3454 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3456 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3458 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3459 Added file to fix the build. Sorry.
3461 * src/dbus_api/Makefile.am:
3462 * src/dbus_api/modest-dbus-api.h:
3463 * src/dbus_api/modest-dbus-callbacks.h:
3464 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3465 (modest_dbus_req_handler):
3466 Put constants in a separate header so it can be reused by the
3467 client library, without duplication
3469 * libmodest-dbus-client/Makefile.am:
3470 * libmodest-dbus-client/libmodest-dbus-client.c:
3471 (libmodest_dbus_client_call_helloworld),
3472 (libmodfest_dbus_client_send_mail),
3473 (libmodfest_dbus_client_mailto),
3474 (libmodfest_dbus_client_open_message):
3475 * libmodest-dbus-client/libmodest-dbus-client.h:
3476 (Partly) Implement a send_mail D-Bus method.
3478 * tests/dbus_api/Makefile.am:
3479 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3480 the send_email D-Bus method.
3482 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3486 * libmodest-dbus-client/Makefile.am:
3487 * libmodest-dbus-client/libmodest-dbus-client.c:
3488 * libmodest-dbus-client/libmodest-dbus-client.h:
3489 * tests/dbus_api/Makefile.am:
3490 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3491 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3493 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3495 * src/maemo/easysetup/modest-easysetup-wizard.c:
3496 (create_page_account_details):
3497 * src/maemo/modest-account-settings-dialog.c:
3498 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3499 widgets, because this might not be the default in future versions of the Maemo GTK+.
3500 However, I can not not get capitalization to work even in a simple test case.
3502 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/easysetup/modest-easysetup-wizard.c:
3505 (create_page_custom_incoming), (create_page_custom_outgoing):
3506 * src/maemo/modest-account-settings-dialog.c:
3507 (create_page_account_details), (create_page_incoming),
3508 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3509 instead of using gtk_check_button_with_label(), so they are aligned like the other
3510 widgets, as per the UI spec.
3512 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3514 * src/maemo/easysetup/modest-easysetup-wizard.c:
3515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3516 * src/widgets/modest-validating-entry.c:
3517 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3518 Modest prefix instead of an EasySetup prefix.
3520 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3522 * src/widgets/modest-validating-entry.h:
3523 * src/widgets/modest-validating-entry.c: (on_insert_text),
3524 Added easysetup_validating_entry_set_max_func(), used to set a callback
3525 to call when the max number of characters is reached. GtkEntry has a max-length
3526 already but is silent about it.
3528 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3529 (create_page_account_details), (create_page_user_details),
3531 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3532 (create_page_account_details), (create_page_user_details),
3533 (create_page_outgoing):
3534 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3535 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3536 the UI spec, when the user tries to enter more than the max number of characters.
3538 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3540 * src/maemo/easysetup/modest-easysetup-wizard.c:
3541 (create_page_user_details), (create_page_custom_incoming),
3542 (create_page_custom_outgoing):
3543 * src/maemo/modest-account-settings-dialog.c:
3544 (create_page_user_details), (create_page_incoming),
3545 (create_page_outgoing):
3546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3547 (modest_connection_specific_smtp_edit_window_init):
3548 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3549 not appropriate. Bad Maemo-specific defaults!.
3551 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3553 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3554 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3555 (modest_signature_editor_dialog_set_settings):
3556 Disable the label and textview when the checkbox is disabled, and use the
3557 specified (UI spec) default signature text.
3559 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3561 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3562 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3564 * src/modest-defs.h:
3565 * src/modest-account-mgr-helpers.h:
3566 * src/modest-account-mgr-helpers.c:
3567 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3569 * src/maemo/Makefile.am:
3570 * src/maemo/modest-signature-editor-dialog.c:
3571 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3574 * src/maemo/modest-account-settings-dialog.h:
3575 * src/maemo/modest-account-settings-dialog.c:
3576 (modest_account_settings_dialog_finalize), (on_button_signature),
3577 (save_configuration): Use the new dialog when the Edit button is pressed, and
3578 save the changes if necessary, as per the UI spec.
3580 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3582 * src/maemo/Makefile.am:
3583 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3584 based on maemo-develoers email from Dirk.
3586 * src/maemo/easysetup/modest-easysetup-wizard.c:
3587 (create_page_welcome), (create_page_account_details),
3588 (create_page_user_details), (create_page_complete_easysetup),
3589 (create_page_custom_incoming), (create_page_custom_outgoing),
3590 (create_page_complete_custom),
3591 (modest_easysetup_wizard_dialog_init):
3592 * src/maemo/modest-account-settings-dialog.c:
3593 (create_page_account_details), (create_page_user_details),
3594 (create_page_incoming), (create_page_outgoing),
3595 (modest_account_settings_dialog_init):
3596 * src/maemo/modest-connection-specific-smtp-window.c:
3597 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3599 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3601 * src/maemo/easysetup/modest-easysetup-wizard.c:
3602 (create_page_account_details), (create_page_custom_outgoing),
3603 (create_page_complete_custom):
3604 * src/maemo/modest-account-settings-dialog.c:
3605 (create_page_user_details), (create_page_incoming),
3606 (create_page_outgoing):
3607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3608 (modest_connection_specific_smtp_edit_window_init):
3609 Use the correct (UI spec) port min/max, and use horizontal separators,
3612 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3614 * src/maemo/easysetup/modest-easysetup-wizard.c:
3615 (set_default_custom_servernames):
3616 * src/maemo/modest-account-settings-dialog.c:
3617 (create_page_incoming), (on_combo_outgoing_security_changed),
3618 (on_combo_incoming_security_changed), (create_page_outgoing),
3619 (modest_account_settings_dialog_set_account_name),
3620 (save_configuration):
3621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3622 (on_combo_security_changed),
3623 (modest_connection_specific_smtp_edit_window_init),
3624 (modest_connection_specific_smtp_edit_window_set_connection),
3625 (modest_connection_specific_smtp_edit_window_get_settings):
3626 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3629 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3632 * src/maemo/easysetup/modest-easysetup-wizard.c:
3633 (create_page_custom_outgoing), (create_page_complete_custom):
3634 * src/maemo/modest-account-settings-dialog.c:
3635 (create_page_user_details), (create_page_outgoing):
3636 * src/maemo/modest-account-view-window.c: (button_box_new):
3637 Use changed logical IDs as per the most recent UI spec:
3638 mcen_bd_emailsetup_edit -> mcen_bd_edit
3639 mcen_bd_emailsetup_delete -> mcen_bd_delete
3640 mcen_bd_emailsetup_close -> mcen_bd_close
3642 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3646 * src/dbus_api/Makefile.am:
3647 * src/dbus_api/modest-dbus-callbacks.c:
3648 * src/dbus_api/modest-dbus-callbacks.h:
3649 * src/maemo/modest-platform.c: (modest_platform_init):
3650 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3652 * tests/Makefile.am:
3653 * tests/dbus_api/Makefile.am:
3654 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3656 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3658 * src/maemo/modest-account-settings-dialog.c:
3659 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3660 Removed unnecessary includes.
3662 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3664 * src/maemo/easysetup/modest-easysetup-wizard.c:
3665 * src/maemo/modest-account-settings-dialog.c:
3666 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3667 * src/widgets/Makefile.am:
3668 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3669 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3670 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3671 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3672 * src/widgets/modest-secureauth-combo-box.c:
3673 * src/widgets/modest-secureauth-combo-box.h:
3674 * src/widgets/modest-serversecurity-combo-box.c:
3675 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3676 made the GObject names more consistent with the rest of the Modest code.
3678 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3680 * src/maemo/easysetup/Makefile.am:
3681 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3682 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3683 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3684 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3685 * src/maemo/easysetup/modest-easysetup-wizard.c:
3686 * src/maemo/easysetup/modest-validating-entry.c:
3687 * src/maemo/easysetup/modest-validating-entry.h:
3688 * src/maemo/modest-account-settings-dialog.c:
3689 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3690 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3691 widgets/ because they are used outside of easysetup too. After checking in,
3692 svn will allow me to rename them too.
3694 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3696 * src/gnome/modest-msg-edit-window.c:
3697 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3698 linker error, to fix the build on the GNOME platform.
3699 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3700 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3701 ifdefed out to avoid a warning.
3703 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3705 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3706 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3707 some alternative for GTK+ 2.6.
3709 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3711 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3713 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3714 specified for EmailAccountsDialog in UI spec.
3716 * src/maemo/easysetup/modest-easysetup-wizard.c:
3717 * src/maemo/easysetup/modest-easysetup-wizard.h:
3718 * src/maemo/modest-account-settings-dialog.c:
3719 * src/maemo/modest-account-settings-dialog.h:
3720 Reuse a member window widget for the connection-specific SMTP server accounts,
3721 so we can tell it to create/save the accounts only if we actually save changes.
3723 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3724 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3725 (modest_connection_specific_smtp_edit_window_get_settings):
3726 Return a struct instance for temporarily remembering the entered data.
3728 * src/maemo/modest-connection-specific-smtp-window.h:
3729 * src/maemo/modest-connection-specific-smtp-window.c:
3730 (modest_connection_specific_smtp_window_finalize),
3731 (modest_connection_specific_smtp_window_fill_with_connections),
3733 (modest_connection_specific_smtp_window_save_server_accounts),
3734 (update_model_server_names): Do not actually save data until asked,
3735 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3737 (on_selection_changed),
3738 (modest_connection_specific_smtp_window_init): Disable the edit
3739 button when nothing is selected.
3741 * src/modest-account-mgr-helpers.c:
3742 * src/modest-account-mgr-helpers.h:
3743 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3746 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3748 * src/modest-account-mgr-helpers.h:
3749 * src/modest-account-mgr-helpers.c:
3750 (modest_account_mgr_get_unused_account_name),
3751 (modest_account_mgr_get_unused_account_display_name): Added these
3752 utility functions, to avoid code duplication.
3754 * src/maemo/easysetup/modest-easysetup-wizard.c:
3755 (create_page_account_details), (create_account):
3756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3757 (on_combo_security_changed),
3758 (modest_connection_specific_smtp_edit_window_init),
3759 (modest_connection_specific_smtp_edit_window_save_settings):
3760 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3761 * src/maemo/modest-connection-specific-smtp-window.c:
3762 (modest_connection_specific_smtp_window_finalize),
3763 (modest_connection_specific_smtp_window_fill_with_connections),
3764 (on_button_edit), (modest_connection_specific_smtp_window_init):
3765 * src/maemo/modest-connection-specific-smtp-window.h:
3766 Implementing saving of connection-specific server accounts.
3768 But I need to refactor this so we can save the data for each
3769 possible connection-specific account and only actually create the server accounts
3770 when the easysetup finished, or the OK button is pressed on the account settings
3773 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3776 (on_combo_security_changed):
3777 (modest_connection_specific_smtp_edit_window_init):
3778 Auto-fill the port number as in the account settings.
3780 (modest_connection_specific_smtp_edit_window_set_connection):
3781 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3782 * src/maemo/modest-connection-specific-smtp-window.c:
3783 (fill_with_connections), (on_button_edit),
3784 (modest_connection_specific_smtp_window_init):
3785 Turn the edit window into a dialog to simplify the code, and
3786 set a WM hint as in a GtkDialog, because only a popup can be on top of
3787 another window in Maemo, and popups usually have no WM decoration.
3789 * src/modest-defs.h:
3790 * src/modest-account-mgr-helpers.c:
3791 (modest_account_mgr_set_connection_specific_smtp),
3792 (modest_account_mgr_remove_connection_specific_smtp),
3793 (modest_account_mgr_get_connection_specific_smtp):
3794 * src/modest-account-mgr-helpers.h: Some functions to write the
3795 connection-specific SMTP server information. Not yet used.
3798 * src/widgets/modest-folder-view.c: (text_cell_data):
3799 Fix a warning about an uninitialized variable.
3800 (on_configuration_key_changed): Put an #ifdef around the use
3801 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3803 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3805 * src/maemo/modest-account-settings-dialog.h:
3806 * src/maemo/modest-account-settings-dialog.c:
3807 Added connect_for_modified() utility function to mark the new modified boolean.
3809 (create_page_account_details), (create_page_user_details),
3810 (create_page_incoming), (create_page_outgoing), (on_response),
3811 (modest_account_settings_dialog_init),
3812 (modest_account_settings_dialog_set_account_name):
3813 Only warn about unsaved changes when there are actually unsaved changes.
3815 * src/modest-account-mgr-helpers.c:
3816 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3817 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3818 to get the data from there in future.
3820 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3822 * src/modest-defs.h:
3824 * src/modest-account-mgr-helpers.h:
3825 * src/modest-account-mgr-helpers.c:
3826 Store the security account setting in a single conf key instead of using
3827 the options list, so that the list is left for just the to-be-removed camel hack,
3828 and because gconf_client_set_list() is failing for some reason.
3830 * src/modest-account-mgr.c:
3831 (modest_account_mgr_add_server_account):
3832 * src/maemo/modest-account-settings-dialog.c:
3833 (modest_account_settings_dialog_set_account_name),
3834 (save_configuration): Use the renamed functions.
3837 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3839 * src/widgets/Makefile.am:
3840 * src/widgets/modest-limit-retrieve-combo-box.c:
3841 * src/widgets/modest-limit-retrieve-combo-box.h:
3842 * src/widgets/modest-retrieve-combo-box.c:
3843 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3844 the account settings dialog.
3846 * src/modest-defs.h:
3847 * src/modest-account-mgr-helpers.h:
3848 * src/modest-account-mgr-helpers.c:
3849 (modest_server_account_get_option_secure_auth),
3850 (modest_server_account_set_option_secure_auth):
3851 * src/modest-account-mgr.c:
3852 (modest_account_mgr_add_server_account):
3853 Use the existing AUTH_MECH conf key for the secure-auth setting,
3854 instead of putting it in the list options, because this was actually used already.
3856 * src/maemo/modest-account-settings-dialog.c:
3857 (create_page_account_details),
3858 (modest_account_settings_dialog_set_account_name),
3859 (save_configuration):
3860 * src/maemo/modest-account-settings-dialog.h:
3861 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3862 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3864 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3866 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3867 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3868 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3870 * src/modest-defs.h:
3871 * src/maemo/modest-account-settings-dialog.c:
3872 (create_page_incoming), (on_combo_outgoing_security_changed),
3873 (on_combo_incoming_security_changed), (create_page_outgoing),
3874 (modest_account_settings_dialog_set_account_name),
3875 (save_configuration): Load/Save the port number, and change it when the
3876 security combo changes, to suitable defaults.
3878 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3880 * src/modest-account-mgr.c:
3881 (modest_account_mgr_add_server_account): Set the security and secure-auth
3882 options, and add a comment saying that the other camel-specific options should be
3885 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3889 * src/modest-tny-account-store.c: (account_list_free),
3890 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3891 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3894 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3896 * src/modest-protocol-info.c:
3897 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3898 is required by our UI spec. Maybe something in our implementation will use this eventually.
3899 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3900 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3901 instead of the previous 0 placeholder.
3903 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3904 secure-auth settings.
3905 * src/modest-account-mgr-helpers.h:
3906 * src/modest-account-mgr-helpers.c:
3907 (modest_server_account_data_get_option_secure_auth),
3908 (modest_server_account_set_option_secure_auth),
3909 (modest_server_account_data_get_option_security),
3910 (modest_server_account_set_option_security): Added this API for getting and setting the security
3911 and secure-auth settings.
3913 * src/maemo/modest-account-settings-dialog.h:
3914 * src/maemo/modest-account-settings-dialog.c:
3915 (modest_account_settings_dialog_finalize), (check_data),
3916 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3917 about changing titles.
3918 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3919 (save_configuration): Save the security and secure-auth settings.
3921 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3922 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3924 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3926 * src/modest-defs.h:
3927 * src/modest-account-mgr.c:
3928 (modest_account_mgr_add_server_account):
3929 Added and used defines for the options key and value pair strings,
3930 that are used so far, though they do not seem to correspond to anything in our
3931 UI specs or ModestProtocol enum.
3933 * src/modest-account-mgr-helpers.h:
3934 * src/modest-account-mgr-helpers.c:
3935 (compare_option_strings_for_name),
3936 (modest_server_account_data_get_option_value),
3937 (modest_server_account_data_get_option_bool),
3938 (modest_account_mgr_get_server_account_option):
3939 Added helper functions for parsing the options GSList.
3941 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3943 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3944 display name is based on the supplied account name.
3945 * src/modest-account-mgr.c:
3946 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3947 with an inefficient, but good-enough, implementation.
3949 * src/maemo/easysetup/modest-easysetup-wizard.c:
3950 (create_page_account_details), (on_before_next), (create_account):
3951 Check for existing display names rather than (non-user-visible) account names, and just
3952 create and set a unique account name at the end.
3954 * src/maemo/modest-account-settings-dialog.c:
3955 (modest_account_settings_dialog_init),
3956 (modest_account_settings_dialog_set_account_name),
3957 (create_page_incoming): Show the display name, instead of the account name.
3958 (on_response): Do some (not all) extra checks, as in the UI spec.
3959 (save_configuration): Save the display name if it was changed.
3961 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3963 * po/en_GB.po: Added needed logical ID and translation.
3964 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3965 (init_view): Made the is-default column clicking work.
3967 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3970 * src/maemo/easysetup/Makefile.am:
3971 * src/maemo/easysetup/modest-easysetup-wizard.c:
3972 (modest_easysetup_wizard_dialog_init):
3973 * src/maemo/easysetup/provider-data-test.keyfile:
3974 * src/maemo/easysetup/provider-data.keyfile:
3975 Moved the provider data file to the new modest-providers-data package and used it from there.
3977 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3979 * src/modest-local-folder-info.c:
3980 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3981 N_() was already used on the static strings, but this just marks it for translation without
3982 using the translation.
3984 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3986 * src/maemo/modest-account-settings-dialog.c:
3987 (create_page_incoming),
3988 (modest_account_settings_dialog_set_account_name):
3989 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3990 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3991 I will do this if nobody else gets there first.
3993 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3995 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3996 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3997 save the security stuff.
3999 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4001 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4002 Set the email address and user fullname, which I now see must be
4005 * src/maemo/modest-account-settings-dialog.h:
4006 * src/maemo/modest-account-settings-dialog.c:
4008 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4009 leave-on-server and authentication.
4010 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4013 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4016 * src/maemo/modest-account-settings-dialog.c:
4017 * src/maemo/modest-account-settings-dialog.h:
4018 Most (but not all) of the widgets are now present as specified by the UI spec.
4019 No changes are yet saved, and some details are not properly shown yet.
4021 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4023 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4025 * src/maemo/Makefile.am:
4026 * src/maemo/modest-account-settings-dialog.c:
4027 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4028 an existing account. Doesn't do much yet.
4030 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4031 Open the accounts settings dialog when Edit is clicked.
4033 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4035 * src/maemo/easysetup/Makefile.am:
4036 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4038 * src/maemo/easysetup/modest-easysetup-wizard.c:
4039 (modest_easysetup_wizard_dialog_init):
4040 Try to get the source directory from the build system,
4041 instead of hard-coding "./" into the source code, when opening our local
4042 copies of the configuration files.
4043 But this still fails when opening the wizard from the Accounts window,
4044 maybe because the working directory seems to change at runtime.
4045 So the wizard will fail the second time unless you copy the files into their
4046 proper locations - see the stdout warnings for the paths.
4048 (create_page_account_details),(on_before_next):
4049 Check for existing non-server accounts instead of server accounts,
4050 so the default account name is useful again, and to prevent trying to
4053 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4054 Show the wizard when New is clicked.
4056 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4057 (init_view): Show the column headers, and show the columns that are
4058 specified in the UI specs. However, something in Maemo's GTK+ prevents
4059 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4060 change the default account. This is despite unsetting the special properties.
4062 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4064 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4065 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4066 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4067 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4068 to make that clearer.
4069 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4071 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4073 * src/maemo/modest-account-view-window.c:
4074 (modest_account_view_window_init),
4075 (modest_account_view_window_new):
4076 Use the same buttons as specified in the
4077 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4078 the existing widgets, which never had a chance of working.
4079 Put the ModestAccountView treeview in a scrolled window.
4080 Do not repeat the initialization in both _init() and _new().
4082 * src/widgets/modest-account-view.c: (update_account_view):
4083 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4084 this widget and window shows no accounts.
4086 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4088 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4090 * src/maemo/easysetup/modest-easysetup-wizard.c:
4091 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4092 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4093 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4096 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4097 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4098 accounts exist yet, as in the UI spec.
4100 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4102 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4104 * src/maemo/Makefile.am:
4105 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4106 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4107 New window for editing connection-specific smtp details.
4108 Not fully implemented.
4110 * src/maemo/modest-connection-specific-smtp-window.c:
4111 (modest_connection_specific_smtp_window_finalize) :
4112 unref the tree model.
4113 (on_button_edit): Show the edit window.
4115 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4117 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4120 * src/maemo/Makefile.am:
4121 * src/maemo/modest-connection-specific-smtp-window.c:
4122 * src/maemo/modest-connection-specific-smtp-window.h:
4123 New window for showing the list of connections, for connection-specific
4124 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4125 * src/maemo/easysetup/modest-easysetup-wizard.c:
4126 (create_page_custom_outgoing): Show the new window when the button is clicked.
4128 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4130 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4131 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4132 * src/maemo/modest-msg-edit-window.c:
4133 (modest_msg_edit_window_insert_image):
4134 * src/modest-conf.c: (modest_conf_key_escape):
4135 * src/modest-mail-operation.c:
4136 (modest_mail_operation_send_new_mail):
4137 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4138 (modest_ui_actions_on_new_account):
4139 * src/widgets/modest-attachment-view.c: (update_filename_request):
4140 * src/widgets/modest-mail-header-view.c:
4141 Corrected warnings that were breaking the build, by commenting out unused variables,
4142 and a function, and by including a header.
4144 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4146 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4147 so we can #ifdef around platform-specific code when necessary.
4148 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4149 to allow this to build for the GNOME platform too.
4151 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4153 * src/maemo/easysetup/modest-easysetup-wizard.c:
4154 Added util_increment_name() and used it in create_page_account_details()
4155 to make sure that the default account name is always a new name.
4157 (modest_easysetup_wizard_dialog_init),
4158 (set_default_custom_servernames): Some minor memory management fixes.
4160 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4164 * src/modest-runtime.c: (init_i18n): Restored the translation
4165 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4166 are defined in config.h, and the translations are installed.
4168 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4169 is defined for translation.
4171 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4173 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4175 * src/maemo/easysetup/modest-easysetup-wizard.c:
4176 (modest_easysetup_wizard_dialog_init):
4177 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4178 Use realistic paths (though they should use $prefix generically) to the
4179 mcc_mapping and provider-data.keyfile files which might work when they
4180 are installed by the future version of the operator-wizard package,
4181 and then fallback to paths in our source code, with an explanatory
4184 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/Makefile.am:
4189 * src/maemo/easysetup/: Added files from the previously-exernal
4190 osso-modest-easysetup.
4191 * src/maemo/modest-main-window-ui.h:
4192 * src/modest-ui-actions.c:
4193 * src/modest-ui-actions.h:
4194 Added modest_ui_actions_on_new_account() as a signal handler for the
4195 New Account menu item. It shows the easysetup wizard.
4196 * po/en_GB.po: Added additional needed logical IDs and translations.