1 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
4 * src/maemo/modest-account-settings-dialog.c:
5 (create_page_outgoing),
6 (modest_account_settings_dialog_set_account_name),
8 - Fixed handling of the "Use secure authentication" toggle to comply with
9 the ui specification. See also projects.maemo.org bug NB#58400
11 - Restore the Secure connection setting combo correctly when loading
14 * src/maemo/modest-maemo-utils.c:
15 (on_camel_account_get_supported_secure_authentication),
16 (modest_maemo_utils_get_supported_secure_authentication_methods):
17 Fixed a crasher if operation is canceled
19 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
20 (modest_protocol_info_auth_is_secure):
21 * src/modest-protocol-info.h:
23 Added two new methods to determine if a protocol/auth method is secure/encrypted in
24 the sense of the "Use secure authentication" toggle.
26 2007-06-07 Murray Cumming <murrayc@murrayc.com>
28 * src/modest-tny-account-store.h:
29 * src/modest-tny-account-store.c:
30 Added modest_tny_account_store_get_local_folders_account().
32 * src/modest-tny-folder.h:
33 * src/modest-tny-folder.c:
34 (modest_tny_folder_get_account):
35 Added this replacement for tny_folder_get_account() which returns
36 the local-folders account for TnyMergeFolders, to avoid the
37 warning about the unimplemented get_account_func() vfunc().
39 (modest_tny_folder_get_rules),
40 * src/modest-ui-actions.c:
41 (modest_ui_actions_on_folder_selection_changed):
42 * src/modest-mail-operation.c:
43 (modest_mail_operation_remove_folder),
44 (modest_mail_operation_xfer_folder),
45 (modest_mail_operation_rename_folder),
46 (modest_mail_operation_get_msg),
47 (modest_mail_operation_get_msgs_full),
48 (modest_mail_operation_remove_msg),
49 (modest_mail_operation_xfer_msgs),
50 (modest_mail_operation_refresh_folder):
51 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
53 2007-06-07 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
56 (modest_server_account_set_security):
57 * src/modest-defs.h: Add comments explaining that our
58 UI spec means TLS when it says Normal, so these do not look like errors.
60 * src/modest-tny-account.c:
61 (modest_tny_account_new_from_server_account): Use the new tinymail
62 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
63 for TLS. This should fix projects.maemo.org bug NB#58460.
65 2007-06-06 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/easysetup/modest-easysetup-wizard.c:
68 (create_account): Correct the position of the gconf sanity check warning.
69 (on_button_edit_advanced_settings): Show the dialog immediately, instead
70 of using the g_idle_add() hack, because this does not seem to be necessary
71 on osso 1.1. It might even work on Maemo Bora if the problems were actually
72 caused by something other than maemo's gconf.
73 This fixes projects.maemo.org bug #59022.
75 2007-06-06 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-account-mgr-helpers.c:
78 (modest_account_mgr_get_default_account): Do not check that the account
79 exists if there is no default account (NULL), to fix a runtime warning.
81 2007-06-06 Murray Cumming <murrayc@murrayc.com>
83 * src/widgets/modest-folder-view.c: (update_model):
84 Do not unref the treemodel before we have finished with it.
85 This prevents a valgrind warning and an occasional crash at startup.
87 2007-06-06 Marcus Bauer <marcusb@openismus.com>
89 * libmodest-dbus-client/libmodest-dbus-client.h:
90 added libmodest_dbus_client_compose_mail()
91 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
93 added functions needed for SendAsMail() functionality
94 * src/maemo/modest-msg-edit-window.c:
95 (modest_msg_edit_window_attach_file_noninteractive):
96 non interactively attaching files to message edit window
97 * src/widgets/modest-msg-edit-window.h:
98 * tests/dbus_api/Makefile.am:
99 added test_compose_mail.c
100 * tests/dbus_api/test_compose_mail.c: (main):
102 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
104 * src/modest-account-view.c:
105 Fixed bug projects.maemo.org bug NB#59307
107 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
109 * src/maemo/easysetup/modest-easysetup-wizard.c:
110 (get_serverport_incoming), (on_before_next), (create_account):
111 * src/maemo/modest-account-settings-dialog.c:
112 (modest_account_settings_dialog_set_account_name):
113 * src/maemo/modest-maemo-utils.c:
114 (on_camel_account_get_supported_secure_authentication_status),
115 (on_camel_account_get_supported_secure_authentication),
116 (on_secure_auth_cancel),
117 (modest_maemo_utils_get_supported_secure_authentication_methods):
119 Implemented security authentication for settings and easysetup.
121 2007-06-05 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/modest-main-window.c: (create_details_widget):
124 Show the total size for memory card accounts too, instead of showing
125 the name again. Fixes bug projects.maemo.org bug NB#59307.
127 2007-06-05 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-tny-simple-folder-store.c:
131 * src/modest-tny-simple-folder-store.h: Removed.
133 * src/modest-tny-local-folders-account.h
134 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
135 for the local-folders maildir, with an extra TnyMergedFolder containing
136 the folders of the per-account outbox store accounts.
137 * src/modest-tny-account-store.c: (get_server_accounts):
138 Add the outboxes to the special local folders account after creating it.
140 * src/modest-tny-account.c:
141 (modest_tny_account_new_for_local_folders): Create the derived
142 account when creating the main local-folders account.
144 * src/maemo/modest-main-window.c: (create_details_widget),
145 (modest_main_window_set_contents_style):
146 Adapted to the use of the derived account instead of the folder store.
148 * src/modest-ui-actions.c:
149 (modest_ui_actions_on_folder_selection_changed):
150 * src/modest-ui-dimming-rules.c:
151 (modest_ui_dimming_rules_on_new_folder):
152 * src/widgets/modest-folder-view.c: (text_cell_data),
153 (icon_cell_data), (filter_row), (update_model),
154 (get_cmp_rows_type_pos):
157 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
158 Do not get the priv struct, because no priv struct has been set,
159 to avoid a runtime warning.
161 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
162 #ifelse with #else, to fix a warning, to fix the build.
165 2007-06-05 Christian Kellner <ckellner@openismus.com>
167 * libmodest-dbus-client/libmodest-dbus-client.c:
168 Fix small typo in doc (why do you always see them
169 AFTER committing stuff?)
172 2007-06-05 Christian Kellner <ckellner@openismus.com>
174 * libmodest-dbus-client/libmodest-dbus-client.c:
175 (libmodest_dbus_client_search):
176 Initialize hit list with NULL. Also set folder list
177 to "" if NULL was supplied.
180 2007-06-03 Christian Kellner <ckellner@openismus.com>
182 * libmodest-dbus-client/libmodest-dbus-client.c:
183 (modest_search_hit_list_free):
184 Make it save to call it with NULL.
186 * src/dbus_api/modest-dbus-callbacks.c:
187 * src/modest-search.c:
188 Return full ModestSearchHits as the search result list not TnyHeader
189 since can't be around withouth the correspoding TnyFolder.
191 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
193 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
194 Added currently commented code to check for secure auth
196 * src/maemo/modest-account-settings-dialog.c: (on_response),
197 (save_configuration), (show_ok):
198 Fixed projects.maemo.org bugs NB #59248 and #59251
200 * src/maemo/modest-maemo-utils.c:
201 (on_camel_account_get_supported_secure_authentication_status),
202 (on_camel_account_get_supported_secure_authentication),
203 (modest_maemo_utils_get_supported_secure_authentication_methods):
204 * src/maemo/modest-maemo-utils.h:
205 Moved get_supported_secure_authentication() method here to be able
206 to use it from easysetup wizard.
208 * src/modest-pair.c: (on_pair_compare_as_string):
209 Should compare string with first part of pair and not
210 strcmp pairs which will crash.
212 * src/modest-protocol-info.c:
213 (modest_protocol_info_protocol_is_store):
214 * src/modest-protocol-info.h:
215 Added modest_protocol_info_get_auth_protocol_name()
217 2007-06-03 Armin Burgmeier <armin@openismus.com>
219 * src/modest-mail-operation.c:
220 (modest_mail_operation_get_msgs_full): Set priv->account also when
221 only retrieving a single message. This avoids a crash when canceling
224 (modest_mail_operation_notify_end): Do not explicitely remove the
225 operation from the queue but only emit the progress_changed signal.
226 The queue itself listens to that signal to remove the operation when
227 it is finished. This reduces coupling and removes a potential deadlock
228 when modest_mail_operation_notify_end() is called from the queue
229 itself. If that is a problem performance-wise, I would suggest to
230 implement a status-changed signal or something.
232 * src/modest-mail-operation-queue.c: Make sure to never call a
233 function from another file while the queue is locked. This (hopefully)
234 fixes another deadlock when exiting the application while retrieving
237 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
239 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
240 Fixed build if libogs is not available
242 2007-06-03 Christian Kellner <ckellner@openismus.com>
244 * libmodest-dbus-client/libmodest-dbus-client.h:
245 * libmodest-dbus-client/libmodest-dbus-client.c:
246 (libmodest_dbus_client_delete_message):
247 Implement deletion of messages (Client side).
249 (modest_search_hit_free),
250 (modest_search_hit_list_free):
251 Utility functions to free the result hits.
253 * src/dbus_api/modest-dbus-api.h:
254 * src/dbus_api/modest-dbus-callbacks.c:
256 (modest_dbus_req_handler):
257 Implement deletion of messages (Server side).
259 * tests/dbus_api/test_search.c: (main):
262 * tests/dbus_api/Makefile.am:
263 * tests/dbus_api/test_delete_message:
264 Add little test for the message deletion logic
266 2007-06-03 Armin Burgmeier <armin@openismus.com>
268 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
269 when the operation queue was not empty. projects.maemo.org bug
272 2007-06-03 Armin Burgmeier <armin@openismus.com>
274 * src/widgets/modest-account-view.c
275 (on_account_default_toggled): Toggle default account column
276 explicitely instead of waiting for gconf notification (which is
277 currently ignored). This should fix projects.maemo.org bug NB#56910
278 for now. It should probably be removed when gconf notifications are
281 2007-06-03 Christian Kellner <ckellner@openismus.com>
283 * libmodest-dbus-client/libmodest-dbus-client.c:
284 Removed debugging spew.
286 * src/dbus_api/modest-dbus-callbacks.c:
287 Added debugging info.
289 * src/modest-search.c:
290 (modest_search_all_accounts):
291 Use tny_account_store_get_accounts () on the account store
292 to get all accounts which is the way to get all accounts.
294 * tests/dbus_api/test_search.c: (main):
295 Make it possible to supply the search term on the command line.
297 2007-06-03 Christian Kellner <ckellner@openismus.com>
299 * libmodest-dbus-client/libmodest-dbus-client.c:
300 * libmodest-dbus-client/libmodest-dbus-client.h:
301 Implement searching for mesages over raw dbus. (Client side)
303 * src/dbus_api/Makefile.am:
304 * src/dbus_api/modest-dbus-api.h:
305 * src/dbus_api/modest-dbus-callbacks.c:
306 * src/dbus_api/modest-dbus-callbacks.h:
307 Search framework (Server side). Also implement on_idle_open_message().
309 * src/maemo/modest-platform.c: (modest_platform_init):
310 Prepare for raw dbus/osso rpc interaction.
312 * src/modest-search.h:
313 Changed minsize from unspecific guint to guint32.
315 * src/modest-search.c:
317 Added strange hack which magically made tnymail work.
319 (modest_search_folder),
320 (modest_search_account),
321 (modest_search_all_accounts):
322 Implement helper functions to search all accounts, specific account
325 * tests/dbus_api/Makefile.am:
326 * tests/dbus_api/test_open_message.c:
327 Read url to open from commandline.
329 * tests/dbus_api/test_search.c:
330 Implement small test for dbus search stuff
332 2007-06-02 Armin Burgmeier <armin@openismus.com>
334 * src/maemo/modest-account-settings-dialog.c: Changed window title to
335 include account type and account title. This fixes projects.maemo.org
338 * src/maemo/modest-account-view-window.c: Set a title for the window.
340 2007-06-02 Armin Burgmeier <armin@openismus.com>
342 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
343 incoming and outgoing server name based on email address and server
344 types as long as the names have not been edited manually. This fixes
345 projects.maemo.org bug NB#58671.
347 2007-06-02 Armin Burgmeier <armin@openismus.com>
349 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
350 server type cannot be changed in future to the incoming details page
351 when creating an account. This fixes projects.maemo.org bug NB#59029.
353 2007-06-02 Armin Burgmeier <armin@openismus.com>
355 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
356 and assigned max width chars so that they wrap instead of being
357 truncated. Fixes projects.maemo.org bug NB#56126.
359 2007-06-02 Armin Burgmeier <armin@openismus.com>
361 * src/maemo/modest-connection-specific-smtp-window.c: Add an
362 introductory note to the connection specific smtp servers dialog, as
363 section 8.12 of the email UI specification requires. This fixes
364 projects.maemo.org bug NB#59212.
366 2007-06-01 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
369 Check for running mail operations, and offer to cancel them, as per the UI
370 spec. This fixes projects.maemo.org bug NB#59041 .
371 However, I suspect that tinymail may still use the network connection
372 in ways that we cannot detect or cancel. But it should at least adapt to
375 2007-06-01 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account-store.c: (recreate_all_accounts),
378 (get_cached_accounts), (get_server_accounts): Do more sensible
379 ref-counting of the temporarily-cached outbox accounts list. This seems
380 to fix a crash when entering the password when the password was wrong.
382 2007-06-01 Murray Cumming <murrayc@murrayc.com>
384 * src/gnome/modest-main-window.c: (connect_signals):
385 * src/modest-tny-account-store.c: (get_password),
386 (modest_tny_account_store_alert): Added comments and clues and
387 commented-out code about how we currently fail to deal with connection
388 errors and wrong passwords, and how we should.
390 2007-06-01 Murray Cumming <murrayc@murrayc.com>
392 * src/widgets/modest-retrieve-combo-box.c:
393 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
394 This fixes projects.maemo.org bug NB#58472 .
396 2007-06-01 Murray Cumming <murrayc@murrayc.com>
398 * src/maemo/easysetup/modest-easysetup-wizard.c:
399 (create_page_complete_easysetup):
400 (create_page_complete_custom): Correct the last commit,
401 putting the correct sentences in the correct pages.
403 2007-06-01 Murray Cumming <murrayc@murrayc.com>
405 * src/maemo/easysetup/modest-easysetup-wizard.c:
406 (create_page_complete_custom): Show the second sentence of text
407 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
410 2007-06-01 Murray Cumming <murrayc@murrayc.com>
412 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
413 Set the leave-on-server conf key by default. This fixes
414 projects.maemo.org bug NB#59258 .
416 2007-06-01 Murray Cumming <murrayc@murrayc.com>
418 * src/maemo/modest-account-view-window.c:
419 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
420 logical ID for the confirmation messages. Fixed projects.maemo.org bug
423 2007-06-01 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/easysetup/modest-easysetup-wizard.c:
426 (create_caption_new_with_asterisk):
427 * src/maemo/modest-account-settings-dialog.c:
428 (create_caption_new_with_asterisk):
429 Uncomment the code to add the asterisk, because they are no longer in the
430 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
431 (update_incoming_server_title): Add an asterisk here too.
433 2007-06-01 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/modest-maemo-global-settings-dialog.c:
436 (current_connection): Check that we are even connected before trying to
437 get the current connection name, to prevent a warning.
439 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
440 Change the comments because tny_maemo_conic_device_connect() is now meant to
442 * src/modest-mail-operation.c:
443 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
444 make sure we have a connection and fail if we can't connect.
446 2007-05-31 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-main-window.c:
449 (on_account_store_connecting_finished): Do not try to get the
450 connection ID if we are not really connected. I am surprised that
451 this signal handler is called when we are not connected.
453 2007-05-31 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-error.h:
456 * src/modest-ui-actions.c:
457 (modest_ui_actions_get_msgs_full_error_handler):
458 Renamed an enum, added comments, added an enum
459 for retrieve-limit errors.
461 * src/modest-mail-operation.c: (foreach_add_item),
462 (internal_folder_observer_update), (update_account_thread),
463 (modest_mail_operation_get_msgs_full):
464 (modest_mail_operation_update_account),
465 Added comments about how this works, and some code that should
466 (but does not) check the retrieve-limit. See the TODO comment.
468 2007-05-31 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
471 Initialize help_id to fix the build. Warnings are good.
473 2007-05-31 Murray Cumming <murrayc@murrayc.com>
475 * src/widgets/modest-hbox-cell-renderer.c:
476 (modest_hbox_cell_renderer_append):
477 * src/widgets/modest-vbox-cell-renderer.c:
478 (modest_vbox_cell_renderer_append):
479 Fix the last commit by doing an extra ref.
481 2007-05-31 Murray Cumming <murrayc@murrayc.com>
483 * src/widgets/modest-hbox-cell-renderer.c:
484 (modest_hbox_cell_renderer_append):
485 * src/widgets/modest-vbox-cell-renderer.c:
486 (modest_vbox_cell_renderer_append):
487 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
488 to fix the build with Maemo Bora.
489 However, there seems to be a remaining crash, probably due to reference
492 2007-05-30 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-tny-account.c:
495 (modest_tny_account_new_for_local_folders):
496 Use hildon_file_system_info_async_new() to get a better name for
497 the memory card account, setting it as the account name.
498 The timing seems to work, but this is probably
499 not the best place to do this. See the TODO comment.
500 * src/maemo/modest-main-window.c: (create_details_widget):
501 * src/widgets/modest-folder-view.c: (text_cell_data):
502 Use the tny account name instead of hardcoding a name.
504 2007-05-30 Christian Kellner <ckellner@openismus.com>
506 * src/modest-search.c: (modest_search):
507 Correctly set part_search_func even if we have already parsed
508 the query and thus a valid OgsTextSearcher object.
510 2007-05-30 Christian Kellner <ckellner@openismus.com>
513 Search and check for libogs.
516 Incooparte the ogs build env.
518 * src/modest-mime-part-search-stream.c:
519 * src/modest-mime-part-search-stream.h:
520 Removed since we do the real searching now in modest-search.c.
522 * src/modest-search.c:
523 * src/modest-search.h:
524 Implement support for ogs. We use that if available and requested
525 and fall back to modest_text_utils_utf8_strcmp (). The search logic
526 should now handle the corner case when the search term is spread
527 across multiple reads.
528 Also the logic in modest_search () was corrected to search all
529 requested fields until one is found.
531 2007-05-30 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
536 * src/modest-init.c: Made modest_init_local_folders() take a
537 path and be public so we can iniitialize maildir folders on
540 * src/modest-local-folder-info.h:
541 * src/modest-local-folder-info.c:
542 (modest_local_folder_info_get_maildir_path): Add a path parameter.
544 * src/modest-tny-account.c:
545 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
546 still means the standard local-folders path on the local volume.
548 * src/modest-tny-account-store.c:
549 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
550 signal so we can detect mount/unmount of the MMC1 card, and do an update of
551 all accounts when that happens.
552 (get_server_accounts): If the MMC1 card is mounted, create a store account for
553 this too, so it shows up in the treeview.
555 2007-05-28 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-maemo-global-settings-dialog.c:
558 (current_connection):
559 * src/widgets/modest-global-settings-dialog.c:
560 (current_connection_default):
561 Use the enum values instead of 0, 1 and -1,
562 to make the code clearer.
564 * src/modest-account-mgr-helpers.c:
565 (modest_account_mgr_get_connection_specific_smtp): Make this code
568 * src/modest-runtime.h:
569 * src/modest-runtime.c:
570 Added modest_runtime_remove_all_send_queues().
571 * src/maemo/modest-main-window.c:
572 (on_account_store_connecting_finished): Recreate the send queues,
573 using the appropriate transport accounts for this new connection.
574 Some futher adapting might be needed if the old send queues are not
575 automatically stopped at this point.
577 * src/modest-tny-account-store.c: (get_server_accounts):
578 Create the connection-specific transport accounts, so that they can
579 be found later by their ID.
581 * src/modest-tny-account.h:
582 * src/modest-tny-account.c:
583 Added modest_tny_account_new_from_server_account_name().
584 modest_tny_account_new_from_server_account(): Do not create the
585 send queues here, because they will be
586 recreated anyway when the connection changes for the first time.
588 2007-05-28 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-local-folder-info.h:
591 * src/modest-local-folder-info.c:
592 (modest_per_account_local_outbox_folder_info_get_maildir_path),
593 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
594 tbox_folder): Take a modest account name instead of a server TnyAccount,
595 so we can have per-modest-account rather than per-transport-account
597 We must make sure that we change or recreate the exisitng send queues
598 when the connection changes for connection-specific transport accounts.
600 * src/modest-tny-account-store.c:
601 (create_per_account_local_outbox_folders): Create outboxed per modest
602 account, not per transport account.
604 * src/modest-tny-account.h:
605 * src/modest-tny-account.c:
606 (modest_tny_account_get_special_folder): For outboxes, get the
607 parent modest account name. The account is ignored for other folders.
608 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
609 modest account name rather than a server TnyAccount.
611 2007-05-25 Murray Cumming <murrayc@murrayc.com>
613 * src/modest-tny-account.c:
614 (modest_tny_account_new_from_server_account):
615 Call modest_runtime_get_send_queue() immediately after creating transport
616 accounts, so that they start trying to send email from the outbox as soon
617 as possible at startup. This is probably what we want.
619 * src/modest-mail-operation.c: (update_account_thread):
620 * src/modest-runtime.c: (modest_runtime_get_send_queue):
621 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
622 * src/modest-tny-send-queue.h:
623 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
624 (modest_ui_actions_on_send):
625 Added comments about how sending works, though it needs some more work.
627 2007-05-25 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account.c:
630 (modest_tny_account_get_special_folder): Add TODO because this fails when
632 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
633 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
634 Do not try to show this window when there is no active account. The UI
635 specs does not tell us what to do in this case.
637 2007-05-24 Murray Cumming <murrayc@murrayc.com>
641 * src/maemo/Makefile.am:
642 * src/widgets/Makefile.am: Some dist fixes.
644 2007-05-24 Murray Cumming <murrayc@murrayc.com>
646 * src/maemo/modest-connection-specific-smtp-window.c:
647 (on_button_edit): Make the code clearer, to prevent a double free.
649 2007-05-24 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-account-settings-dialog.c:
652 (modest_account_settings_dialog_set_account_name),
653 Check the connection-specific smtp servers checkbox if there are any.
655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
656 (modest_connection_specific_smtp_edit_window_init):
657 Start with a suitable port number.
659 * src/modest-account-mgr-helpers.h:
660 * src/modest-account-mgr-helpers.c: Added
661 modest_account_mgr_get_has_connection_specific_smtp().
663 (modest_account_mgr_set_connection_specific_smtp),
664 (modest_account_mgr_remove_connection_specific_smtp),
665 (modest_account_mgr_get_has_connection_specific_smtp),
666 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
667 connection-specific smtp server accounts in the account, rather than
668 the server account conf dir.
670 This fixes bug projects.maemo.org bug NB#58263 .
672 * src/modest-tny-account-store.c:
673 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
674 if there are no server accounts yet, to prevent an infinite loop when there
675 are no accounts. Document that one must be called before the other.
677 2007-05-24 Murray Cumming <murrayc@murrayc.com>
679 * src/modest-account-mgr-helpers.c:
680 (modest_account_mgr_get_default_account): Make sure that at least
681 one account is always the default, if there are any enabled accounts.
682 This is just a sanity check that shouldn't be necessary.
684 * src/modest-account-mgr-priv.c:
685 (_modest_account_mgr_account_from_key): Unescape the conf key to
686 get the real account name. For instance, this is an issue if a space
687 was in the account name, which can happen because the account name
688 is generated from the display name.
689 (_modest_account_mgr_get_account_keyname): Always escape the
691 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
692 Unescape the conf keys to get the real account names.
694 For instance, previously the is-default radio button in the accounts
695 list was not checked for any accounts at first. This fixes that,
696 and might fix several similar bugs.
698 2007-05-23 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
701 Removed some debug printfs.
703 2007-05-23 Murray Cumming <murrayc@murrayc.com>
705 Modest on-disk outbox directories are now here, for instance:
706 $HOME/.modest/outboxes/<account-id-1>/outbox
707 $HOME/.modest/outboxes/<account-id-2>/outbox
709 $HOME/.modest/local-folders/outbox
710 so we can have a separate outbox for each account.
711 But they are shown as one outbox in the GtkTreeView, by using a
712 TnyMergeFolder in a ModestTnySimpleFolderStore.
715 * src/modest-tny-simple-folder-store.c:
716 * src/modest-tny-simple-folder-store.h:
717 Added ModestTnySimpleFolderStore, used to contain folders from
718 other folder stores, such as other accounts.
720 * src/modest-tny-outbox-account.h:
721 * src/modest-tny-outbox-account.c:
722 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
723 used for the per-account local outbox folders.
725 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
726 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
727 only use this (internally) now for the non-outbox local folders.
730 * src/modest-init.c: Added modest_init_one_local_folder(), for
731 setting up the directory structure for each local folder.
733 * src/modest-local-folder-info.c:
734 (modest_per_account_local_outbox_folder_info_get_maildir_path),
735 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
737 * src/modest-local-folder-info.h:
738 * src/modest-tny-account-store.c: (on_account_removed),
739 (on_account_changed), (create_per_account_local_outbox_folders),
740 (get_server_accounts), (modest_tny_account_store_get_accounts),
741 (modest_tny_account_store_get_tny_account_by_account),
742 (modest_tny_folder_store_is_virtual_local_folders):
744 * src/modest-tny-account.h:
745 * src/modest-tny-account.c:
746 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
747 to create an on-disk per-account local outbox folder for each
749 (create_per_account_local_outbox_folders): Create a local outbox folder
750 for each transport account.
751 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
752 for all local folders.
754 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
755 instead of using g_object_get/set() directly. It is clearer.
757 (modest_tny_folder_store_get_message_count),
758 (modest_tny_folder_store_get_local_size
759 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
760 because we now use these with non-acount folder stores.
762 (modest_tny_account_get_special_folder),
763 (modest_tny_account_new_from_server_account),
764 (modest_tny_account_new_from_account):
765 (recurse_folders): Adjust to the new outbox system.
767 * src/modest-tny-folder.h:
768 * src/modest-tny-folder.c:
769 (modest_tny_folder_is_local_folder),
770 (modest_tny_folder_get_local_folder_type),
771 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
773 * src/widgets/modest-main-window.h:
774 * src/maemo/modest-main-window.c: (create_details_widget),
775 (modest_main_window_set_contents_style): Show details for any folder store,
778 (modest_tny_folder_get_rules):
779 Remove the const. C does not support constness enough for this.
781 * src/modest-ui-actions.c:
782 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
783 make all outboxes appear as one, in the usual local-folders tree node.
785 (set_active_account_from_tny_account),
786 (modest_ui_actions_on_folder_selection_changed):
787 * src/widgets/modest-folder-view.c: (text_cell_data),
788 (icon_cell_data), (filter_row),
789 (add_account_folders_to_merged_folder),
790 (add_account_folders_to_simple_folder_store), (),
791 (get_cmp_rows_type_pos), (cmp_rows),
792 (modest_folder_view_set_account_id_of_visible_server_account):
793 Adjust to the new outbox system, using generic folder stores and folders
796 2007-05-23 Christian Kellner <ckellner@openismus.com>
798 * src/modest-mail-operation.c:
799 (modest_mail_operation_update_account):
800 Use info->max_size instead of unintialized local var [small
801 build fix]. (Added TODO to review that change since I don't
804 2007-05-23 Marcus Bauer <marcusb@openismus.com>
806 * libmodest-dbus-client/libmodest-dbus-client.c:
807 (libmodest_dbus_client_compose_mail): function added
808 * src/dbus_api/modest-dbus-api.h:
809 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
810 (on_compose_mail): Implementation of the SendAsMail functionality
812 2007-05-22 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-account-mgr.c:
815 (modest_account_mgr_add_server_account): Set the secure-connection
816 conf key for transport accounts as well as store accounts. I don't know
817 why the if was there. For instance, this makes sure that we use SSL
818 for the gmail preset from the easysetup wizard.
820 2007-05-22 Murray Cumming <murrayc@murrayc.com>
822 * src/gnome/modest-main-window.c:
823 (on_account_store_connecting_finished), (connect_signals):
824 * src/maemo/modest-main-window.c:
825 (on_account_store_connecting_finished), (connect_signals),
826 (modest_main_window_new):
827 Handle TnyAccountStore::connecting-finished instead of
828 TnyDevice::connection-changed, because we cannot actually perform
829 operations on accounts until TnyAccountStore has itself responded to
830 the TnyDevice::connection-changed signal. This prevents a GError from
832 Do not try to update at startup, because we (at least on scratchbox)
833 already do an update at startup when the device goes online.
834 This prevents a GError from tinymail.
835 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
836 Added TODO about stopping simultaneous operations.
838 2007-05-21 Murray Cumming <murrayc@murrayc.com>
840 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
841 * src/modest-mail-operation-queue.c:
842 (modest_mail_operation_queue_remove):
843 * src/modest-tny-account-store.c: When GErrors happen, give more clues
844 about where they happened.
846 2007-05-21 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-ui-actions.c:
849 (modest_ui_actions_on_password_requested): Make sure that the remember
850 output parameter is always TRUE.
852 2007-05-21 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
855 Show a OK/Cancel dialog if the error is a question, though we still do not
856 know anything more about what we are asking the user.
857 * src/widgets/modest-folder-view.c: (on_drag_data_received):
858 Fix an uninitialized variable (helper). This is a logic error, however.
860 2007-05-21 Christian Kellner <ckellner@openismus.com>
862 * src/modest-search.h:
863 Correct bit shifting in the ModestSearchFlags enum.
865 2007-05-21 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-tny-account.c:
868 (modest_tny_account_new_from_server_account): Do not use the lsub and
869 check-all hard-coded IMAP options when using POP.
871 2007-05-21 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-tny-account.c:
874 (modest_tny_account_new_from_server_account):
875 Use NULL for the secure-auth method for POP when Password auth has been
876 specified by the user, as we already do for IMAP. "auth=Login" causes
877 an error from camel or the server.
879 2007-05-17 Murray Cumming <murrayc@murrayc.com>
881 * src/maemo/modest-account-settings-dialog.c:
882 (create_page_account_details),
883 (modest_account_settings_dialog_set_account_name):
884 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
885 for the leave-on-server checkbox, rathr than just the checkbox, when
886 the protocol is not POP.
888 2007-05-17 Murray Cumming <murrayc@murrayc.com>
890 * src/widgets/modest-account-view.c:
891 * src/widgets/modest-account-view.h:
892 Added modest_account_view_select_account() which will be useful later
893 to asynchronously re-select the edited account.
895 2007-05-17 Murray Cumming <murrayc@murrayc.com>
897 * src/maemo/modest-account-settings-dialog.c:
898 (modest_account_settings_dialog_set_account_name):
899 Automatically choose the port numbers based on the secure authentication
900 methods, if they have not been chosen before.
901 This fixes projects.maemo.org bug NB#56273 .
903 2007-05-17 Murray Cumming <murrayc@murrayc.com>
905 * src/maemo/modest-main-window-ui.h:
906 * src/modest-ui-actions.c:
907 * src/modest-ui-actions.h:
908 Connect the Tools/SMTP Servers menu item to
909 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
910 SMTP servers dialog, as in the UI specification and saves changes when it
911 is closed. This fixed projects.maemo.org bug NB#56305 .
913 2007-05-17 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/modest-connection-specific-smtp-window.c:
916 (modest_connection_specific_smtp_window_init):
917 Use gtk_window_set_default_size() to make this window big enough, so
918 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
920 2007-05-17 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-connection-specific-smtp-edit-window.h:
923 * src/maemo/modest-connection-specific-smtp-edit-window.c:
924 (modest_connection_specific_smtp_edit_window_init),
925 Do not try to connect to a combobox signal before the combobox exists.
926 This fixes the cras in projects.maemo.org bug NB#56288 .
927 (modest_connection_specific_smtp_edit_window_get_settings):
928 Remove the server_account_name parameter which was being checked for NULL
929 though it was not used.
931 * src/maemo/modest-connection-specific-smtp-window.c:
932 (modest_connection_specific_smtp_window_fill_with_connections),
933 (on_button_edit), (modest_connection_specific_smtp_window_init):
934 Correct the number of treemodel columns to prevent a warning.
935 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
936 libconic does not work.
938 2007-05-16 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-tny-account.c:
941 (modest_tny_account_new_from_server_account):
942 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
943 SMTP when "None" was chosen by the user. However, with my SMTP server that
944 does not support ANONYMOUS, the emails do not leave the Outbox and I see
947 2007-05-16 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
950 to explain the memory management issue with the ID in the ModestPair.
952 * src/gnome/modest-account-assistant.c: (add_receiving_page),
953 (add_sending_page), (modest_account_assistant_finalize):
954 * src/gnome/modest-gnome-global-settings-dialog.c:
955 (create_updating_page), (create_composing_page):
956 * src/gnome/modest-msg-edit-window.c: (get_transports),
957 (init_window), (modest_msg_edit_window_finalize),
958 (modest_msg_edit_window_get_msg_data):
959 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
960 * src/gnome/modest-transport-widget.c:
961 (modest_transport_widget_finalize), (smtp_configuration):
962 * src/maemo/modest-maemo-global-settings-dialog.c:
963 (create_updating_page), (create_composing_page):
964 * src/maemo/modest-msg-edit-window.c: (get_transports),
965 (init_window), (modest_msg_edit_window_finalize),
966 (modest_msg_edit_window_get_msg_data),
967 (modest_msg_edit_window_free_msg_data):
968 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
969 (modest_store_widget_finalize):
970 * src/maemo/modest-transport-widget.c:
971 (modest_transport_widget_finalize), (smtp_configuration):
972 * src/modest-main.c: (send_mail):
973 * src/widgets/modest-combo-box.h:
974 * src/widgets/modest-global-settings-dialog-priv.h:
975 * src/widgets/modest-global-settings-dialog.c:
976 (modest_global_settings_dialog_finalize):
977 * src/widgets/modest-msg-edit-window.h:
978 Whenever using modest_combo_box_new(), keep the ModestPairList alive
979 as long as the combo box, to prevent use of freed memory for the ID.
981 2007-05-15 Murray Cumming <murrayc@murrayc.com>
983 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
984 get_accounts(), to make this clearer. Do not check for the enabled gconf
985 key, because we do not use this for server accounts (at least, not yet).
986 This allows us to send email again.
988 2007-05-15 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/modest-platform.c:
991 (on_modest_conf_update_interval_changed), (modest_platform_init):
992 Only respond to this particular key change. All these strcmp()s cannot be
995 2007-05-15 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/modest-maemo-global-settings-dialog.c:
998 (current_connection): Prevent a crash in scratchbox when
999 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1000 * src/maemo/modest-platform.c:
1001 (on_modest_conf_update_interval_changed), (modest_platform_init):
1002 Get the update interval from gconf and reset it when the gconf key changes.
1004 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-protocol-info.c:
1007 * src/modest-protocol-info.h: Adde enum-specific get functions,
1008 instead of using a ModestProtocolType enum parameter.
1010 * src/gnome/modest-account-assistant.c:
1011 * src/gnome/modest-store-widget.c:
1012 * src/gnome/modest-store-widget.h:
1013 * src/gnome/modest-transport-widget.c:
1014 * src/gnome/modest-transport-widget.h:
1015 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1016 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1017 * src/maemo/easysetup/modest-easysetup-wizard.c:
1018 * src/maemo/modest-account-settings-dialog.c:
1019 * src/maemo/modest-account-settings-dialog.h:
1020 * src/maemo/modest-store-widget.c:
1021 * src/maemo/modest-store-widget.h:
1022 * src/maemo/modest-transport-widget.c:
1023 * src/maemo/modest-transport-widget.h:
1024 * src/modest-account-mgr-helpers.c:
1025 * src/modest-account-mgr-helpers.h:
1026 * src/modest-account-mgr.c:
1027 * src/modest-account-mgr.h:
1028 * src/modest-tny-account.c:
1029 * src/modest-tny-folder.c:
1030 * src/widgets/modest-account-view.c:
1031 * src/widgets/modest-retrieve-combo-box.c:
1032 * src/widgets/modest-retrieve-combo-box.h:
1033 * src/widgets/modest-secureauth-combo-box.c:
1034 * src/widgets/modest-serversecurity-combo-box.c:
1035 * src/widgets/modest-serversecurity-combo-box.h:
1036 * tests/check_account-mgr.c:
1037 Use the specific functions, and use the re-renamed enum values for GNOME too.
1039 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1041 * src/modest-pair.h:
1042 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1043 so we can get the second based on the first.
1045 * src/maemo/modest-account-settings-dialog.h:
1046 * src/maemo/modest-account-settings-dialog.c:
1047 Added get_supported_secure_authentication_methods(), though it is mostly
1048 commented-out for now until the necessary API is committed to tinymail.
1049 (modest_account_settings_dialog_set_account_name),
1050 (save_configuration): Request the supported authentication methods from the
1051 server, so we can choose a working method.
1053 * src/modest-tny-account-store.h:
1054 * src/modest-tny-account-store.c:
1055 (modest_tny_account_store_get_session): Rename from
1056 tny_account_store_get_session().
1058 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-protocol-info.h: Split the ModestProtocol enum
1061 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1062 There was no need to have these unrelated values in one enum.
1064 * src/: many files: Adapted to changed enum. This makes the code a bit
1065 clearer, and the compiler could catch some errors.
1067 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1069 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1070 Show the detailed internal camel error message when an error happens
1071 during the configuration, so that our testers can give us more clues.
1072 For instance, in projects.maemo.org bug NB#56910 .
1074 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-tny-account.c:
1077 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1078 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1080 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1082 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1083 * src/maemo/modest-account-settings-dialog.c:
1084 (modest_account_settings_dialog_set_account_name),
1085 (save_configuration): For the incoming secure authentication checkbox,
1086 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1087 the UI specification. PLAIN does not seem to be supported for most IMAP
1088 servers anyway, and I am not sure what it would mean.
1089 However, we probably need to discover which of the secure-authentication
1090 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1091 * src/modest-account-mgr-helpers.c:
1092 (modest_account_mgr_get_server_account_data):
1094 * src/modest-tny-account.c:
1095 (modest_tny_account_new_from_server_account):
1096 Use tny_account_set_mech() to set secure-authentication methods,
1097 with some special-casing for IMAP, based on my observations of how
1100 * src/modest-account-mgr-helpers.h:
1101 * src/modest-account-mgr.c:
1102 * src/modest-defs.h: Comment that the URI is only used for local folders.
1104 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1107 parameter const, just to be neat.
1108 * src/modest-text-utils.c: (modest_text_utils_inline):
1109 End g_strconcat() with NULL, as its documentation says. This is almost
1110 certainly the cause of my crash at startup on the device. Interestingly,
1111 valgrind doesn't tell us about these errors.
1113 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1115 * scripts/build-packages: Added more precise comments about how to use
1116 this script, though I still get this error:
1117 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1118 error building tinymail
1120 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1122 * src/maemo/modest-main-window.c: (on_account_update):
1123 Very slight cleanup, hoping to make it simpler to discover what causes
1124 a crash here sometimes.
1126 * src/modest-tny-account.c:
1127 (modest_tny_account_new_from_server_account): Set the port. Added
1128 comments about the options and a TODO comment because I need to find out
1129 how to specify the secure authentication method.
1131 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1133 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1134 changed CFlags paths form modest to libmodest
1136 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-account-mgr-helpers.c:
1139 (modest_account_mgr_get_server_account_data),
1140 (modest_account_mgr_free_server_account_data):
1141 * src/modest-account-mgr-helpers.h:
1142 * src/modest-account-mgr.c:
1143 (modest_account_mgr_add_server_account):
1144 * src/modest-defs.h:
1145 * src/modest-tny-account.c:
1146 (modest_tny_account_new_from_server_account):
1147 Determine the options for tny_camel_account_add_option() here,
1148 based on the settings, rather than storing them directly in gconf.
1150 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1153 Show a more friendly error dialog now that we expect (from the tinymail
1154 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1156 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1158 * src/maemo/modest-main-window.c: (on_account_update): Check that
1159 account_name is not NULL, to prevent a crash at startup that I am
1160 seeing on the N800. I do wonder why it is NULL.
1162 * src/maemo/easysetup/modest-easysetup-wizard.c:
1163 (create_page_user_details):
1164 * src/maemo/modest-account-settings-dialog.c:
1165 (create_page_user_details), (create_page_outgoing):
1166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1167 (modest_connection_specific_smtp_edit_window_init):
1168 * src/modest-ui-actions.c:
1169 (modest_ui_actions_on_password_requested):
1170 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1171 might do something useful with the on-screen keyboard.
1173 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1175 * src/maemo/modest-main-window.c: (on_account_update):
1176 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1177 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1179 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-tny-account-store.c: (on_account_changed):
1182 Correct the signature of this signal handler.
1184 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1187 Show a HildonNote instead of a GtkDialog for Maemo.
1189 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1191 * src/widgets/modest-account-view.h:
1192 * src/widgets/modest-account-view.c: (on_account_changed),
1193 (on_account_removed). Added a boolean flag, set/unset by
1194 modest_account_view_block_conf_updates(),
1195 modest_account_view_unblock_conf_updates() to prevent unnecessary
1196 updates, but this is not very useful because the gconf notifications are
1197 so delays (maybe only on Maemo Bora).
1198 So auto-updating is turned off, and these functions do an explicit
1199 update when necessary.
1200 However, something else is still doing too much work when adding/removing
1201 accounts, probably in another part of the application.
1203 * src/maemo/modest-account-view-window.c:
1204 (on_delete_button_clicked), (on_edit_button_clicked),
1205 (on_new_button_clicked): Use the new functions.
1207 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-account-mgr-helpers.c:
1210 (modest_account_mgr_set_first_account_as_default):
1211 Sort the list of names alphabetically-by-title, so we choose the first one
1213 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1214 alphabetically by the title.
1216 This fixes projects.maemo.org bug NB#56418 .
1218 * src/modest-account-mgr-priv.c:
1219 (_modest_account_mgr_account_from_key):
1220 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1221 avoid a valgrind error, and possible random behaviour.
1223 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1226 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1227 tinymail documentation to say that this can be expected.
1228 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1229 pretty, and should not happen, but I would prefer to know when it does.
1231 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1233 * configure.ac: When using the older hildon version, probably on Bora,
1234 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1236 * src/widgets/modest-attachment-view.c:
1237 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1240 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1242 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1243 Implemented the prototype. Can be tested with
1244 tests/dbus_api/test_open_message:
1246 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-tny-account-store.c:
1249 (modest_tny_account_store_instance_init), (get_password):
1250 * src/modest-ui-actions.c:
1251 (modest_ui_actions_on_password_requested):
1252 Do not store the password in gconf, because this function is called
1253 for non-remembered passwords. Actually use the cached (in the hash map)
1254 password instead of releasing it.
1255 The password will now not be remembered if it is asked via the protected
1256 password dialog, as per the UI spec.
1258 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1260 * src/modest-defs.h:
1261 * src/modest-account-mgr-helpers.h:
1262 * src/modest-account-mgr-helpers.c:
1263 Added modest_server_account_get_username_has_succeeded(),
1264 modest_server_account_set_username_has_succeeded().
1265 (modest_server_account_set_username),
1266 Reset the has-succeeded flag if the username changes.
1268 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1269 * src/maemo/modest-connection-specific-smtp-window.c:
1270 (modest_connection_specific_smtp_window_save_server_accounts):
1271 Use modest_server_account_set_username() instead of using
1272 modest_conf_set_string() directly, so that the has-succeeded flag is always
1275 * src/modest-ui-actions.c:
1276 (modest_ui_actions_on_password_requested): Dim the username entry if
1277 the username has ever worked, as per the UI spec.
1279 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1281 * src/modest-tny-account-store.c: (get_password):
1282 * src/modest-ui-actions.c:
1283 (modest_ui_actions_on_password_requested):
1284 Allow the username to be changed too, though there is more work to
1285 be done on exactly how this behaves.
1287 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-account-mgr-helpers.h:
1290 * src/modest-account-mgr-helpers.c:
1291 Added modest_account_mgr_get_display_name(),
1292 modest_server_account_get_username(),
1293 modest_server_account_set_username(),
1294 modest_server_account_set_password(),
1295 modest_server_account_get_hostname() functions so we do not need to
1296 use the conf API directly.
1298 * src/maemo/modest-main-window.c: (connect_signals):
1299 Actually connect ot the ModestAccountStore::request-password signal,
1300 so that we show the dialog when the password is requested by Tinymail,
1301 for isntance if it is empty.
1303 * src/modest-marshal.list:
1304 * src/modest-tny-account-store.c:
1305 (modest_tny_account_store_class_init), (get_password),
1306 (modest_tny_account_store_alert):
1307 * src/modest-tny-account-store.h:
1308 * src/modest-ui-actions.h:
1309 * src/modest-ui-actions.c:
1310 (modest_ui_actions_on_password_requested):
1311 Change the signal parameters, so it is obvious that we are providing
1312 the non human-readable server name, and receiving both the username
1313 and password, though changing of the username is not yet implemented.
1314 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1315 for the GNOME version.
1317 This should fix the projects.maemo.org bug NB#56209, though it does not
1318 work on Bora, because the gconf_client_get() for the password fails
1319 immediately after we save it with gconf_client_set().
1321 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1324 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1325 caused an undefined symbol error:
1326 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1328 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1330 * src/modest-tny-account-store.c:
1331 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1332 using a GError instead of a string message, so we can translate it in
1335 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1337 * src/maemo/modest-address-book.c:
1338 (modest_address_book_check_names):
1339 * src/maemo/modest-msg-view-window.c:
1340 (modest_msg_view_window_clipboard_owner_change):
1341 * src/modest-init.c: (modest_init_init_ui):
1342 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1343 (update_folders_cb), (modest_mail_operation_update_account):
1344 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1345 (modest_ui_actions_on_msg_attachment_clicked),
1346 (modest_ui_actions_on_msg_recpt_activated):
1347 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1348 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1349 (modest_msg_view_search_next):
1350 * src/widgets/modest-recpt-editor.c:
1351 (modest_recpt_editor_on_button_release_event),
1352 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1353 g_message(). At this point we should only be seeing interesting errors on
1354 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1356 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1358 (modest_wizard_dialog_force_title_update):
1359 * src/maemo/easysetup/modest-wizard-dialog.h:
1360 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1361 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1362 can update the title when appropriate. Otherwise the title is wrong if the
1363 pages are added after adding the notebook to the dialog.
1364 This must be a problem in HildonWizardDialog too.
1365 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1367 * src/maemo/easysetup/modest-easysetup-wizard.c:
1368 (create_subsequent_customsetup_pages),
1369 (create_subsequent_easysetup_pages):
1370 Call modest_wizard_dialog_force_title_update() so that the title is
1371 correct even with GTK+ < 2.10.
1372 This fixes projects.maemo.org bug NB#56145 .
1374 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/modest-platform.c:
1377 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1378 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1381 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1383 * src/widgets/modest-window.h:
1384 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1385 and modest_window_save_state(), which invokes it.
1387 * src/widgets/modest-window-mgr.h:
1388 * src/widgets/modest-window-mgr.c:
1389 Added modest_window_mgr_save_state_for_all_windows(), which calls
1390 the save_state vfunc on all registered windows, if implemented.
1392 * src/gnome/modest-msg-edit-window.c:
1393 * src/gnome/modest-msg-view-window.c:
1394 * src/maemo/modest-msg-edit-window.c:
1395 * src/maemo/modest-msg-view-window.c:
1396 * src/maemo/modest-main-window.c:
1397 Specify the existing save_settings functions as implementations of
1398 ModestWindow::save_state_func().
1400 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1401 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1402 enabling hibernation, for instance.
1404 We may need to do the same thing for restoring settings.
1407 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1409 * src/widgets/modest-window-mgr.c:
1410 * src/widgets/modest-window-mgr.h:
1411 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1412 modest_window_mgr_get_hibernation_is_prevented().
1414 * src/maemo/modest-main-window.c:
1415 (on_hildon_program_is_topmost_notify): Prevent hibernation
1416 (possible when the application goes to the background in the WM),
1417 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1419 * src/maemo/easysetup/modest-easysetup-wizard.c:
1420 (modest_easysetup_wizard_dialog_init):
1421 * src/maemo/modest-account-settings-dialog.c:
1422 (modest_account_settings_dialog_init):
1423 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1424 (modest_connection_specific_smtp_edit_window_init):
1425 * src/maemo/modest-connection-specific-smtp-window.c:
1426 (modest_connection_specific_smtp_window_init):
1427 * src/maemo/modest-signature-editor-dialog.c:
1428 (modest_signature_editor_dialog_init):
1429 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1430 prevent hibernation while any of these account settings dialogs are open.
1432 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/Makefile.am:
1435 * src/maemo/modest-osso-state-saving.c:
1436 * src/maemo/modest-osso-state-saving.h: Added
1437 modest_osso_load_state() and modest_osso_save_state() though they do
1438 nothing now. They should iterate through all the open windows and load/save
1440 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1441 save state when closing.
1443 * src/maemo/modest-main-window.c:
1444 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1445 Add a notification handler for the HildonProgram::is-topmost property,
1446 so we can allow hibernation when the application goes into the background.
1447 But we still need to detect when the accounts setup windows are open so
1448 we can stop hibernation when they are open.
1449 To do this, I also added the main window the HildonProgram. This might have
1450 other side-effects/benefits, and should maybe be done for other windows.
1452 * src/maemo/modest-osso-autosave-callbacks.h:
1453 * src/maemo/modest-osso-autosave-callbacks.c:
1454 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1455 though it does not do anything yet, and we might never need this to do
1456 anything. For instance, we already save drafts.
1458 * src/maemo/modest-platform.c: (modest_platform_init):
1459 Specify the libosso auto-save callback.
1461 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/modest-platform.c:
1464 (modest_platform_set_update_interval):
1465 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1466 aparently stays valid between application instances, so we can use this
1467 to remove and reset it later. According to a maemo-developers email from
1470 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1472 * configure.ac: Depend on libalarm for Maemo.
1474 * src/dbus_api/modest-dbus-api.h:
1475 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1476 (on_send_receive), (modest_dbus_req_handler):
1477 Handle a SEND_RECEIVE D-Bus method.
1479 * libmodest-dbus-client/libmodest-dbus-client.c:
1480 (libmodest_dbus_client_send_and_receive):
1481 * libmodest-dbus-client/libmodest-dbus-client.h:
1482 Add C convenience functions for calling the new D-Bus method.
1484 * src/modest-platform.h:
1485 * src/gnome/modest-platform.c:
1486 * src/maemo/modest-platform.c:
1487 Added modest_platform_set_update_interval(), which uses the
1488 alarmd API on Maemo.
1489 (modest_platform_init),
1490 Call modest_platform_set_update_interval(), using a hard-coded
1491 interval for now (until the global settings dialog is implemented),
1492 though I am not sure that this makes sense yet.
1494 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1496 * src/dbus_api/modest-dbus-callbacks.c:
1497 (modest_osso_cb_hw_state_handler):
1498 * src/dbus_api/modest-dbus-callbacks.h:
1499 * src/maemo/modest-platform.c: (modest_platform_init):
1500 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1501 in case this has some effect on the ability for Maemo to ping the
1504 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1507 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1508 warning. It is probably a logic error, but I need to fix the build.
1510 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-account-mgr.h:
1513 * src/modest-account-mgr.c:
1514 (modest_account_mgr_account_names): Add a gboolean enabled_only
1515 parameter, so we can get lists of onlt the enabled accounts.
1517 (modest_account_mgr_add_account),,
1518 (modest_account_mgr_account_with_display_name_exists):
1519 * src/maemo/modest-msg-edit-window.c: (get_transports):
1520 * src/modest-account-mgr-helpers.c:
1521 (modest_account_mgr_set_first_account_as_default):
1522 * src/modest-init.c: (init_default_account_maybe):
1523 * src/modest-tny-account-store.c: (get_accounts):
1524 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1525 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1526 * tests/check_account-mgr.c: (START_TEST):
1527 Provide the extra parameter, as appropriate.
1529 * src/widgets/modest-account-view.c: (update_account_view):
1530 Do not show disabled accounts (meaning that there is no way to
1531 enable/disable accounts in the UI (the feature is not in our UI
1532 specification), so we can use this internally only to mark unfinished
1533 or temporary account data.
1535 * src/maemo/easysetup/modest-easysetup-wizard.c:
1536 (create_account): Add boolean enable parameter, so we can specify FALSE
1537 to create the temporary account.
1538 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1539 (on_before_next): When finishing, when there is a temporary account, just
1541 Also, use a timeout to delay the showing of the dialog until gconf is likely
1542 to return correct information, due to a maemo gconf bug that is fixed in
1543 osso 1.1, but not yet in Bora.
1544 However, the dialog stays on screen after it is destroyed.
1546 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1547 for invalid data when cancelling. Use a hildon note instead of a dialog
1548 to complain about invalid data. Do not show the account-saved note if the
1549 account is disabled (a temporary account that will not really be saved for use
1552 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1554 * src/modest-account-mgr-helpers.h:
1555 * src/modest-account-mgr-helpers.c:
1556 Added modest_account_mgr_unset_default_account(),
1557 Added modest_account_mgr_set_first_account_as_default().
1559 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1560 If it was the default account, unset the default account name.
1562 * src/maemo/modest-account-view-window.c:
1563 (on_delete_button_clicked): If it was the default account,
1564 set the first remaining account as the default instead.
1566 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1567 a NULL account or a NULL default account, to prevent a crash. This should
1568 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1571 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1573 * src/widgets/modest-recpt-editor.c:
1574 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1575 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1576 TODO comment for this. This fixes the build.
1578 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1579 be the best place for it. This will in future update all auto-update accounts,
1580 rather than just the current/default account, when that gconf key exists.
1581 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1582 if there are no accounts, before calling do_send_receive().
1583 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1585 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1586 * src/maemo/modest-main-window-ui.h:
1587 * src/maemo/modest-main-window.c: (on_connection_changed),
1588 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1589 directly, becaue the signal handler does more.
1591 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1593 * src/modest-account-mgr-helpers.c:
1594 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1595 for the case that the account does not exist.
1597 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1598 (equivalent to the modest account name) rather than the tinymail account name
1599 (equivalent to the modest account title - human readable) to get the account data.
1600 Check for null account data to prevent the crash, and add a TODO comment saying that
1601 this needs fixing because it is using the server account name instead of the account name.
1603 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1605 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1606 * src/maemo/modest-account-settings-dialog.c: (show_error),
1608 Use hildon_note_new_information() for informative and error messages,
1609 which seems to be expected for Maemo applications (no documentation that I know of
1610 says this). I am surprised that there is no distinction between info and error
1613 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1615 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1616 it is easy to find where this is used.
1618 * src/maemo/easysetup/modest-easysetup-wizard.c:
1619 (create_page_welcome), (create_page_account_details),
1620 (create_page_user_details), (create_page_complete_easysetup),
1621 (create_page_custom_incoming), (create_page_custom_outgoing),
1622 (create_page_complete_custom):
1623 * src/maemo/modest-account-settings-dialog.c:
1624 (create_page_account_details), (create_page_user_details),
1625 (create_page_incoming), (create_page_outgoing):
1626 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1628 (modest_connection_specific_smtp_edit_window_init):
1629 * src/maemo/modest-connection-specific-smtp-window.c:
1630 (modest_connection_specific_smtp_window_init):
1631 * src/maemo/modest-signature-editor-dialog.c:
1632 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1633 and scrolling policy as per the Email Application Layout Guide, if I have
1636 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1639 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1640 which were empty, because these vfuncs have been removed from TnyAccountStore.
1641 This fixes the build.
1643 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/modest-main-window.c:
1646 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1647 showing/hiding it. Added TODO because it probably should not be NULL.
1648 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1649 because unnecessary g_warnings() make degugging difficult.
1651 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/modest-msg-edit-window.c:
1654 (modest_msg_edit_window_select_color),
1655 (modest_msg_edit_window_select_background_color): 2 const corrections and
1656 moving 2 #endifs before closing brackets, to fix the build.
1658 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/easysetup/modest-easysetup-wizard.h:
1661 * src/maemo/easysetup/modest-easysetup-wizard.c:
1662 (modest_easysetup_wizard_dialog_finalize),
1663 (on_button_edit_advanced_settings), (create_page_complete_custom),
1664 (on_response), (create_account):
1665 Implement the Advanced Settings edit button, by saving the account information,
1666 for the Advanded Settings dialog to use directly from gconf, and removing it
1667 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1668 Bug #5533 in the projects.maemo.org bugzilla.
1670 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1672 * src/maemo/modest-msg-view-window.c:
1673 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1674 when opening a message window.
1676 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1678 * src/maemo/easysetup/modest-easysetup-wizard.c:
1679 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1682 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1683 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1684 gconf settings. I probably added more checks than necessary, but that is safer.
1686 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1687 variable to fix the build, but this seems to be used when it is still NULL.
1689 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-platform.h:
1692 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1693 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1694 * src/modest-main.c: Implement this function so we can avoid using
1695 maemo-specific API from cross-platform code.
1697 * src/modest-tny-account-store.c:
1698 (get_smtp_specific_transport_account_for_open_connection):
1699 * src/modest-ui-actions.c: (check_for_connection),
1700 (modest_ui_actions_on_item_not_found):
1701 Use modest_platform_connect_and_wait() and put #idefs around other
1702 maemo-specific code, because only maemo currently has a way to
1703 identify connection names.
1705 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-tny-account-store.h:
1708 * src/modest-tny-account-store.c:
1709 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1710 the connection-specific SMTP server settings in the configuration.
1712 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1714 * src/maemo/modest-main-window.c: (on_connection_changed),
1716 * src/modest-main.c: (main), (start_ui), (send_mail):
1717 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1718 that is what is intended.
1720 * src/modest-ui-actions.c: (action_send), (action_receive),
1721 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1722 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1723 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1724 SMTP server is used when it is specified.
1726 (modest_ui_actions_on_send_receive):
1727 Check that a connection is open before proceeding.
1728 Receive and then send, instead of vice-versa, as per the specification.
1730 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1732 * src/modest-mail-operation.c:
1733 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1734 though I guess it should be something other than NULL.
1736 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1738 * src/maemo/easysetup/modest-easysetup-wizard.c:
1739 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1740 combo twice, to avoid an g_warning and to make it visible again.
1741 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1742 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1743 (already intended) dereference when detaching, because we then recreate the menu.
1744 But I am not sure why the warning was happening, and it is possible that this is a memory
1747 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1749 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1750 and uri_parse_mailto() utility functions.
1751 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1753 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1755 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1757 * src/dbus_api/modest-dbus-api.h:
1758 * src/dbus_api/modest-dbus-callbacks.c:
1759 Use an idle callback to execute the modest code in the application's own thread.
1760 Remove the helloworld example method.
1761 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1762 parsed, and the open-message method is not implemented because this is not yet implemented in
1764 * libmodest-dbus-client/libmodest-dbus-client.c:
1765 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1766 (libmodest_dbus_client_open_message):
1767 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1769 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1770 body without crashing.
1772 * tests/dbus_api/Makefile.am:
1773 * tests/dbus_api/test_mail_to.c:
1774 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1776 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1778 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1779 Added file to fix the build. Sorry.
1781 * src/dbus_api/Makefile.am:
1782 * src/dbus_api/modest-dbus-api.h:
1783 * src/dbus_api/modest-dbus-callbacks.h:
1784 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1785 (modest_dbus_req_handler):
1786 Put constants in a separate header so it can be reused by the
1787 client library, without duplication
1789 * libmodest-dbus-client/Makefile.am:
1790 * libmodest-dbus-client/libmodest-dbus-client.c:
1791 (libmodest_dbus_client_call_helloworld),
1792 (libmodfest_dbus_client_send_mail),
1793 (libmodfest_dbus_client_mailto),
1794 (libmodfest_dbus_client_open_message):
1795 * libmodest-dbus-client/libmodest-dbus-client.h:
1796 (Partly) Implement a send_mail D-Bus method.
1798 * tests/dbus_api/Makefile.am:
1799 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1800 the send_email D-Bus method.
1802 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1806 * libmodest-dbus-client/Makefile.am:
1807 * libmodest-dbus-client/libmodest-dbus-client.c:
1808 * libmodest-dbus-client/libmodest-dbus-client.h:
1809 * tests/dbus_api/Makefile.am:
1810 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1811 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1813 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/easysetup/modest-easysetup-wizard.c:
1816 (create_page_account_details):
1817 * src/maemo/modest-account-settings-dialog.c:
1818 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1819 widgets, because this might not be the default in future versions of the Maemo GTK+.
1820 However, I can not not get capitalization to work even in a simple test case.
1822 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1824 * src/maemo/easysetup/modest-easysetup-wizard.c:
1825 (create_page_custom_incoming), (create_page_custom_outgoing):
1826 * src/maemo/modest-account-settings-dialog.c:
1827 (create_page_account_details), (create_page_incoming),
1828 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1829 instead of using gtk_check_button_with_label(), so they are aligned like the other
1830 widgets, as per the UI spec.
1832 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/easysetup/modest-easysetup-wizard.c:
1835 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1836 * src/widgets/modest-validating-entry.c:
1837 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1838 Modest prefix instead of an EasySetup prefix.
1840 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1842 * src/widgets/modest-validating-entry.h:
1843 * src/widgets/modest-validating-entry.c: (on_insert_text),
1844 Added easysetup_validating_entry_set_max_func(), used to set a callback
1845 to call when the max number of characters is reached. GtkEntry has a max-length
1846 already but is silent about it.
1848 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1849 (create_page_account_details), (create_page_user_details),
1851 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1852 (create_page_account_details), (create_page_user_details),
1853 (create_page_outgoing):
1854 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1855 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1856 the UI spec, when the user tries to enter more than the max number of characters.
1858 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/easysetup/modest-easysetup-wizard.c:
1861 (create_page_user_details), (create_page_custom_incoming),
1862 (create_page_custom_outgoing):
1863 * src/maemo/modest-account-settings-dialog.c:
1864 (create_page_user_details), (create_page_incoming),
1865 (create_page_outgoing):
1866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1867 (modest_connection_specific_smtp_edit_window_init):
1868 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1869 not appropriate. Bad Maemo-specific defaults!.
1871 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1873 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1874 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1875 (modest_signature_editor_dialog_set_settings):
1876 Disable the label and textview when the checkbox is disabled, and use the
1877 specified (UI spec) default signature text.
1879 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1882 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1884 * src/modest-defs.h:
1885 * src/modest-account-mgr-helpers.h:
1886 * src/modest-account-mgr-helpers.c:
1887 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1889 * src/maemo/Makefile.am:
1890 * src/maemo/modest-signature-editor-dialog.c:
1891 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1894 * src/maemo/modest-account-settings-dialog.h:
1895 * src/maemo/modest-account-settings-dialog.c:
1896 (modest_account_settings_dialog_finalize), (on_button_signature),
1897 (save_configuration): Use the new dialog when the Edit button is pressed, and
1898 save the changes if necessary, as per the UI spec.
1900 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/Makefile.am:
1903 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1904 based on maemo-develoers email from Dirk.
1906 * src/maemo/easysetup/modest-easysetup-wizard.c:
1907 (create_page_welcome), (create_page_account_details),
1908 (create_page_user_details), (create_page_complete_easysetup),
1909 (create_page_custom_incoming), (create_page_custom_outgoing),
1910 (create_page_complete_custom),
1911 (modest_easysetup_wizard_dialog_init):
1912 * src/maemo/modest-account-settings-dialog.c:
1913 (create_page_account_details), (create_page_user_details),
1914 (create_page_incoming), (create_page_outgoing),
1915 (modest_account_settings_dialog_init):
1916 * src/maemo/modest-connection-specific-smtp-window.c:
1917 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1919 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/easysetup/modest-easysetup-wizard.c:
1922 (create_page_account_details), (create_page_custom_outgoing),
1923 (create_page_complete_custom):
1924 * src/maemo/modest-account-settings-dialog.c:
1925 (create_page_user_details), (create_page_incoming),
1926 (create_page_outgoing):
1927 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1928 (modest_connection_specific_smtp_edit_window_init):
1929 Use the correct (UI spec) port min/max, and use horizontal separators,
1932 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1934 * src/maemo/easysetup/modest-easysetup-wizard.c:
1935 (set_default_custom_servernames):
1936 * src/maemo/modest-account-settings-dialog.c:
1937 (create_page_incoming), (on_combo_outgoing_security_changed),
1938 (on_combo_incoming_security_changed), (create_page_outgoing),
1939 (modest_account_settings_dialog_set_account_name),
1940 (save_configuration):
1941 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1942 (on_combo_security_changed),
1943 (modest_connection_specific_smtp_edit_window_init),
1944 (modest_connection_specific_smtp_edit_window_set_connection),
1945 (modest_connection_specific_smtp_edit_window_get_settings):
1946 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1949 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1952 * src/maemo/easysetup/modest-easysetup-wizard.c:
1953 (create_page_custom_outgoing), (create_page_complete_custom):
1954 * src/maemo/modest-account-settings-dialog.c:
1955 (create_page_user_details), (create_page_outgoing):
1956 * src/maemo/modest-account-view-window.c: (button_box_new):
1957 Use changed logical IDs as per the most recent UI spec:
1958 mcen_bd_emailsetup_edit -> mcen_bd_edit
1959 mcen_bd_emailsetup_delete -> mcen_bd_delete
1960 mcen_bd_emailsetup_close -> mcen_bd_close
1962 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1966 * src/dbus_api/Makefile.am:
1967 * src/dbus_api/modest-dbus-callbacks.c:
1968 * src/dbus_api/modest-dbus-callbacks.h:
1969 * src/maemo/modest-platform.c: (modest_platform_init):
1970 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1972 * tests/Makefile.am:
1973 * tests/dbus_api/Makefile.am:
1974 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1976 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-account-settings-dialog.c:
1979 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1980 Removed unnecessary includes.
1982 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/easysetup/modest-easysetup-wizard.c:
1985 * src/maemo/modest-account-settings-dialog.c:
1986 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1987 * src/widgets/Makefile.am:
1988 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1989 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1990 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1991 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1992 * src/widgets/modest-secureauth-combo-box.c:
1993 * src/widgets/modest-secureauth-combo-box.h:
1994 * src/widgets/modest-serversecurity-combo-box.c:
1995 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1996 made the GObject names more consistent with the rest of the Modest code.
1998 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2000 * src/maemo/easysetup/Makefile.am:
2001 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2002 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2003 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2004 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2005 * src/maemo/easysetup/modest-easysetup-wizard.c:
2006 * src/maemo/easysetup/modest-validating-entry.c:
2007 * src/maemo/easysetup/modest-validating-entry.h:
2008 * src/maemo/modest-account-settings-dialog.c:
2009 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2010 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2011 widgets/ because they are used outside of easysetup too. After checking in,
2012 svn will allow me to rename them too.
2014 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2016 * src/gnome/modest-msg-edit-window.c:
2017 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2018 linker error, to fix the build on the GNOME platform.
2019 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2020 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2021 ifdefed out to avoid a warning.
2023 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2025 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2026 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2027 some alternative for GTK+ 2.6.
2029 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2031 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2033 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2034 specified for EmailAccountsDialog in UI spec.
2036 * src/maemo/easysetup/modest-easysetup-wizard.c:
2037 * src/maemo/easysetup/modest-easysetup-wizard.h:
2038 * src/maemo/modest-account-settings-dialog.c:
2039 * src/maemo/modest-account-settings-dialog.h:
2040 Reuse a member window widget for the connection-specific SMTP server accounts,
2041 so we can tell it to create/save the accounts only if we actually save changes.
2043 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2044 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2045 (modest_connection_specific_smtp_edit_window_get_settings):
2046 Return a struct instance for temporarily remembering the entered data.
2048 * src/maemo/modest-connection-specific-smtp-window.h:
2049 * src/maemo/modest-connection-specific-smtp-window.c:
2050 (modest_connection_specific_smtp_window_finalize),
2051 (modest_connection_specific_smtp_window_fill_with_connections),
2053 (modest_connection_specific_smtp_window_save_server_accounts),
2054 (update_model_server_names): Do not actually save data until asked,
2055 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2057 (on_selection_changed),
2058 (modest_connection_specific_smtp_window_init): Disable the edit
2059 button when nothing is selected.
2061 * src/modest-account-mgr-helpers.c:
2062 * src/modest-account-mgr-helpers.h:
2063 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2066 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-account-mgr-helpers.h:
2069 * src/modest-account-mgr-helpers.c:
2070 (modest_account_mgr_get_unused_account_name),
2071 (modest_account_mgr_get_unused_account_display_name): Added these
2072 utility functions, to avoid code duplication.
2074 * src/maemo/easysetup/modest-easysetup-wizard.c:
2075 (create_page_account_details), (create_account):
2076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2077 (on_combo_security_changed),
2078 (modest_connection_specific_smtp_edit_window_init),
2079 (modest_connection_specific_smtp_edit_window_save_settings):
2080 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2081 * src/maemo/modest-connection-specific-smtp-window.c:
2082 (modest_connection_specific_smtp_window_finalize),
2083 (modest_connection_specific_smtp_window_fill_with_connections),
2084 (on_button_edit), (modest_connection_specific_smtp_window_init):
2085 * src/maemo/modest-connection-specific-smtp-window.h:
2086 Implementing saving of connection-specific server accounts.
2088 But I need to refactor this so we can save the data for each
2089 possible connection-specific account and only actually create the server accounts
2090 when the easysetup finished, or the OK button is pressed on the account settings
2093 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2096 (on_combo_security_changed):
2097 (modest_connection_specific_smtp_edit_window_init):
2098 Auto-fill the port number as in the account settings.
2100 (modest_connection_specific_smtp_edit_window_set_connection):
2101 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2102 * src/maemo/modest-connection-specific-smtp-window.c:
2103 (fill_with_connections), (on_button_edit),
2104 (modest_connection_specific_smtp_window_init):
2105 Turn the edit window into a dialog to simplify the code, and
2106 set a WM hint as in a GtkDialog, because only a popup can be on top of
2107 another window in Maemo, and popups usually have no WM decoration.
2109 * src/modest-defs.h:
2110 * src/modest-account-mgr-helpers.c:
2111 (modest_account_mgr_set_connection_specific_smtp),
2112 (modest_account_mgr_remove_connection_specific_smtp),
2113 (modest_account_mgr_get_connection_specific_smtp):
2114 * src/modest-account-mgr-helpers.h: Some functions to write the
2115 connection-specific SMTP server information. Not yet used.
2118 * src/widgets/modest-folder-view.c: (text_cell_data):
2119 Fix a warning about an uninitialized variable.
2120 (on_configuration_key_changed): Put an #ifdef around the use
2121 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2123 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/modest-account-settings-dialog.h:
2126 * src/maemo/modest-account-settings-dialog.c:
2127 Added connect_for_modified() utility function to mark the new modified boolean.
2129 (create_page_account_details), (create_page_user_details),
2130 (create_page_incoming), (create_page_outgoing), (on_response),
2131 (modest_account_settings_dialog_init),
2132 (modest_account_settings_dialog_set_account_name):
2133 Only warn about unsaved changes when there are actually unsaved changes.
2135 * src/modest-account-mgr-helpers.c:
2136 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2137 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2138 to get the data from there in future.
2140 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2142 * src/modest-defs.h:
2144 * src/modest-account-mgr-helpers.h:
2145 * src/modest-account-mgr-helpers.c:
2146 Store the security account setting in a single conf key instead of using
2147 the options list, so that the list is left for just the to-be-removed camel hack,
2148 and because gconf_client_set_list() is failing for some reason.
2150 * src/modest-account-mgr.c:
2151 (modest_account_mgr_add_server_account):
2152 * src/maemo/modest-account-settings-dialog.c:
2153 (modest_account_settings_dialog_set_account_name),
2154 (save_configuration): Use the renamed functions.
2157 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2159 * src/widgets/Makefile.am:
2160 * src/widgets/modest-limit-retrieve-combo-box.c:
2161 * src/widgets/modest-limit-retrieve-combo-box.h:
2162 * src/widgets/modest-retrieve-combo-box.c:
2163 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2164 the account settings dialog.
2166 * src/modest-defs.h:
2167 * src/modest-account-mgr-helpers.h:
2168 * src/modest-account-mgr-helpers.c:
2169 (modest_server_account_get_option_secure_auth),
2170 (modest_server_account_set_option_secure_auth):
2171 * src/modest-account-mgr.c:
2172 (modest_account_mgr_add_server_account):
2173 Use the existing AUTH_MECH conf key for the secure-auth setting,
2174 instead of putting it in the list options, because this was actually used already.
2176 * src/maemo/modest-account-settings-dialog.c:
2177 (create_page_account_details),
2178 (modest_account_settings_dialog_set_account_name),
2179 (save_configuration):
2180 * src/maemo/modest-account-settings-dialog.h:
2181 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2182 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2184 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2187 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2188 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2190 * src/modest-defs.h:
2191 * src/maemo/modest-account-settings-dialog.c:
2192 (create_page_incoming), (on_combo_outgoing_security_changed),
2193 (on_combo_incoming_security_changed), (create_page_outgoing),
2194 (modest_account_settings_dialog_set_account_name),
2195 (save_configuration): Load/Save the port number, and change it when the
2196 security combo changes, to suitable defaults.
2198 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-account-mgr.c:
2201 (modest_account_mgr_add_server_account): Set the security and secure-auth
2202 options, and add a comment saying that the other camel-specific options should be
2205 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2209 * src/modest-tny-account-store.c: (account_list_free),
2210 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2211 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2214 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2216 * src/modest-protocol-info.c:
2217 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2218 is required by our UI spec. Maybe something in our implementation will use this eventually.
2219 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2220 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2221 instead of the previous 0 placeholder.
2223 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2224 secure-auth settings.
2225 * src/modest-account-mgr-helpers.h:
2226 * src/modest-account-mgr-helpers.c:
2227 (modest_server_account_data_get_option_secure_auth),
2228 (modest_server_account_set_option_secure_auth),
2229 (modest_server_account_data_get_option_security),
2230 (modest_server_account_set_option_security): Added this API for getting and setting the security
2231 and secure-auth settings.
2233 * src/maemo/modest-account-settings-dialog.h:
2234 * src/maemo/modest-account-settings-dialog.c:
2235 (modest_account_settings_dialog_finalize), (check_data),
2236 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2237 about changing titles.
2238 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2239 (save_configuration): Save the security and secure-auth settings.
2241 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2242 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2244 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2246 * src/modest-defs.h:
2247 * src/modest-account-mgr.c:
2248 (modest_account_mgr_add_server_account):
2249 Added and used defines for the options key and value pair strings,
2250 that are used so far, though they do not seem to correspond to anything in our
2251 UI specs or ModestProtocol enum.
2253 * src/modest-account-mgr-helpers.h:
2254 * src/modest-account-mgr-helpers.c:
2255 (compare_option_strings_for_name),
2256 (modest_server_account_data_get_option_value),
2257 (modest_server_account_data_get_option_bool),
2258 (modest_account_mgr_get_server_account_option):
2259 Added helper functions for parsing the options GSList.
2261 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2263 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2264 display name is based on the supplied account name.
2265 * src/modest-account-mgr.c:
2266 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2267 with an inefficient, but good-enough, implementation.
2269 * src/maemo/easysetup/modest-easysetup-wizard.c:
2270 (create_page_account_details), (on_before_next), (create_account):
2271 Check for existing display names rather than (non-user-visible) account names, and just
2272 create and set a unique account name at the end.
2274 * src/maemo/modest-account-settings-dialog.c:
2275 (modest_account_settings_dialog_init),
2276 (modest_account_settings_dialog_set_account_name),
2277 (create_page_incoming): Show the display name, instead of the account name.
2278 (on_response): Do some (not all) extra checks, as in the UI spec.
2279 (save_configuration): Save the display name if it was changed.
2281 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2283 * po/en_GB.po: Added needed logical ID and translation.
2284 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2285 (init_view): Made the is-default column clicking work.
2287 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2290 * src/maemo/easysetup/Makefile.am:
2291 * src/maemo/easysetup/modest-easysetup-wizard.c:
2292 (modest_easysetup_wizard_dialog_init):
2293 * src/maemo/easysetup/provider-data-test.keyfile:
2294 * src/maemo/easysetup/provider-data.keyfile:
2295 Moved the provider data file to the new modest-providers-data package and used it from there.
2297 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2299 * src/modest-local-folder-info.c:
2300 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2301 N_() was already used on the static strings, but this just marks it for translation without
2302 using the translation.
2304 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/modest-account-settings-dialog.c:
2307 (create_page_incoming),
2308 (modest_account_settings_dialog_set_account_name):
2309 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2310 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2311 I will do this if nobody else gets there first.
2313 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2315 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2316 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2317 save the security stuff.
2319 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2322 Set the email address and user fullname, which I now see must be
2325 * src/maemo/modest-account-settings-dialog.h:
2326 * src/maemo/modest-account-settings-dialog.c:
2328 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2329 leave-on-server and authentication.
2330 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2333 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2336 * src/maemo/modest-account-settings-dialog.c:
2337 * src/maemo/modest-account-settings-dialog.h:
2338 Most (but not all) of the widgets are now present as specified by the UI spec.
2339 No changes are yet saved, and some details are not properly shown yet.
2341 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2343 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2345 * src/maemo/Makefile.am:
2346 * src/maemo/modest-account-settings-dialog.c:
2347 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2348 an existing account. Doesn't do much yet.
2350 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2351 Open the accounts settings dialog when Edit is clicked.
2353 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2355 * src/maemo/easysetup/Makefile.am:
2356 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2358 * src/maemo/easysetup/modest-easysetup-wizard.c:
2359 (modest_easysetup_wizard_dialog_init):
2360 Try to get the source directory from the build system,
2361 instead of hard-coding "./" into the source code, when opening our local
2362 copies of the configuration files.
2363 But this still fails when opening the wizard from the Accounts window,
2364 maybe because the working directory seems to change at runtime.
2365 So the wizard will fail the second time unless you copy the files into their
2366 proper locations - see the stdout warnings for the paths.
2368 (create_page_account_details),(on_before_next):
2369 Check for existing non-server accounts instead of server accounts,
2370 so the default account name is useful again, and to prevent trying to
2373 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2374 Show the wizard when New is clicked.
2376 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2377 (init_view): Show the column headers, and show the columns that are
2378 specified in the UI specs. However, something in Maemo's GTK+ prevents
2379 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2380 change the default account. This is despite unsetting the special properties.
2382 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2384 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2385 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2386 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2387 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2388 to make that clearer.
2389 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2391 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2393 * src/maemo/modest-account-view-window.c:
2394 (modest_account_view_window_init),
2395 (modest_account_view_window_new):
2396 Use the same buttons as specified in the
2397 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2398 the existing widgets, which never had a chance of working.
2399 Put the ModestAccountView treeview in a scrolled window.
2400 Do not repeat the initialization in both _init() and _new().
2402 * src/widgets/modest-account-view.c: (update_account_view):
2403 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2404 this widget and window shows no accounts.
2406 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2408 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/easysetup/modest-easysetup-wizard.c:
2411 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2412 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2413 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2416 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2417 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2418 accounts exist yet, as in the UI spec.
2420 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2422 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/Makefile.am:
2425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2426 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2427 New window for editing connection-specific smtp details.
2428 Not fully implemented.
2430 * src/maemo/modest-connection-specific-smtp-window.c:
2431 (modest_connection_specific_smtp_window_finalize) :
2432 unref the tree model.
2433 (on_button_edit): Show the edit window.
2435 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2437 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2440 * src/maemo/Makefile.am:
2441 * src/maemo/modest-connection-specific-smtp-window.c:
2442 * src/maemo/modest-connection-specific-smtp-window.h:
2443 New window for showing the list of connections, for connection-specific
2444 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2445 * src/maemo/easysetup/modest-easysetup-wizard.c:
2446 (create_page_custom_outgoing): Show the new window when the button is clicked.
2448 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2451 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2452 * src/maemo/modest-msg-edit-window.c:
2453 (modest_msg_edit_window_insert_image):
2454 * src/modest-conf.c: (modest_conf_key_escape):
2455 * src/modest-mail-operation.c:
2456 (modest_mail_operation_send_new_mail):
2457 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2458 (modest_ui_actions_on_new_account):
2459 * src/widgets/modest-attachment-view.c: (update_filename_request):
2460 * src/widgets/modest-mail-header-view.c:
2461 Corrected warnings that were breaking the build, by commenting out unused variables,
2462 and a function, and by including a header.
2464 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2466 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2467 so we can #ifdef around platform-specific code when necessary.
2468 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2469 to allow this to build for the GNOME platform too.
2471 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2473 * src/maemo/easysetup/modest-easysetup-wizard.c:
2474 Added util_increment_name() and used it in create_page_account_details()
2475 to make sure that the default account name is always a new name.
2477 (modest_easysetup_wizard_dialog_init),
2478 (set_default_custom_servernames): Some minor memory management fixes.
2480 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-runtime.c: (init_i18n): Restored the translation
2485 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2486 are defined in config.h, and the translations are installed.
2488 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2489 is defined for translation.
2491 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2493 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2495 * src/maemo/easysetup/modest-easysetup-wizard.c:
2496 (modest_easysetup_wizard_dialog_init):
2497 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2498 Use realistic paths (though they should use $prefix generically) to the
2499 mcc_mapping and provider-data.keyfile files which might work when they
2500 are installed by the future version of the operator-wizard package,
2501 and then fallback to paths in our source code, with an explanatory
2504 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2508 * src/maemo/Makefile.am:
2509 * src/maemo/easysetup/: Added files from the previously-exernal
2510 osso-modest-easysetup.
2511 * src/maemo/modest-main-window-ui.h:
2512 * src/modest-ui-actions.c:
2513 * src/modest-ui-actions.h:
2514 Added modest_ui_actions_on_new_account() as a signal handler for the
2515 New Account menu item. It shows the easysetup wizard.
2516 * po/en_GB.po: Added additional needed logical IDs and translations.
2518 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2519 Apparently ChangeLog is not used for some vague Nokia legal reasons.