1 2007-06-28 Murray Cumming <murrayc@murrayc.com
3 * src/modest-tny-account.c: (on_modest_file_system_info),
4 (modest_tny_account_get_mmc_account_name):
5 Always call the callback, without checking whether the name has changed.
6 * src/widgets/modest-folder-view.c: (strings_are_equal),
7 (on_model_foreach_set_name), (on_get_mmc_account_name),
8 (text_cell_data): Compare the name here, and use the name from
9 the account rather than from the
10 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
11 if the name was changed after the account was added to the model.
12 That's a tinymail bug but not one that I want to fix now.
14 This finally fixes projects.maemo.org bug NB#59301.
16 2007-06-27 Armin Burgmeier <armin@openismus.com>
18 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
21 2007-06-27 Murray Cumming <murrayc@murrayc.com
23 * src/modest-tny-account.h:
24 * src/modest-tny-account.c:
25 Added modest_tny_account_get_mmc_account_name(), to set the memory
26 card name asynchronously for the given account and then notify.
27 (modest_tny_account_new_for_local_folders): Use this new function instead
28 of using hildon_file_system_info_async_new() directly.
30 * src/widgets/modest-folder-view.c: (text_cell_data):
31 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
32 gtk_tree_model_row_changed() when it is available.
34 This should fix projects.maemo.org bug NB#59301.
36 2007-06-27 Murray Cumming <murrayc@murrayc.com
38 * src/modest-mail-operation.c: (update_account_thread),
39 (get_msgs_full_thread): Fix typo failures in the revert
42 2007-06-27 Murray Cumming <murrayc@murrayc.com
44 * src/maemo/modest-maemo-global-settings-dialog.c:
45 (idle_select_default_focus):
46 * src/modest-mail-operation.c: (idle_notify_progress),
47 (idle_notify_progress_once), (set_last_updated_idle),
48 (update_account_thread), (get_msgs_full_thread):
49 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
50 * src/widgets/modest-header-view.c:
51 (idle_notify_headers_count_changed_destroy),
52 (idle_notify_headers_count_changed):
53 Reverted the additions of gdk_threads_enter/leave(), in case this
54 helps with a startup hang on the device.
56 2007-06-26 Armin Burgmeier <armin@openismus.com>
58 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
59 for supported secure authentication methods from server by
60 gtk_dialog_run(), saving CPU time and a potential race condition.
62 2007-06-26 Armin Burgmeier <armin@openismus.com>
64 * src/maemo/modest-maemo-utils.h:
65 * src/maemo/modest-maemo-utils.c: Added a
66 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
67 only error code to tell the calling code when the user canceled the
70 * src/maemo/modest-account-settings-dialog.h:
71 * src/maemo/modest-account-settings-dialog.c:
72 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
73 message if the retrieval of secure authentication methods was canceled
74 by the user. Perform the check before saving anything to configuration
75 to not end up with half-committed configuration changes, do not show
76 a "Saving to configuration failed" note when authentication methods
77 could not be retrieved.
79 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
82 2007-06-26 Murray Cumming <murrayc@murrayc.com>
84 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
85 Only return the first level of folders under accounts, because the
86 osso-global-search UI spec doesn't want the rest.
87 This fixed projects.maemo.org bug NB#61811.
89 2007-06-26 Murray Cumming <murrayc@murrayc.com>
91 * src/modest-tny-account-store.c:
92 * src/modest-tny-account-store.h:
93 Added modest_tny_account_is_memory_card_account().
94 * src/maemo/modest-main-window.c: (create_details_widget):
95 Show the same information items for the memory card as we show for the
96 local-folders, to fix projects.maemo.org bug NB#59307.
98 2007-06-26 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-tny-account-store.c: (get_password):
101 Added some checks for NULL to maybe prevent crashes, though I think
102 it was Philip's last commit that actually prevented the crash here
103 when creating a first new account.
104 But the new account is still not usable (no messages are shown)
105 until a restart of the application.
107 2007-06-26 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-maemo-global-settings-dialog.c:
110 (idle_select_default_focus):
111 * src/modest-mail-operation.c: (idle_notify_progress),
112 (idle_notify_progress_once), (idle_notify_update_account_queue),
113 (set_last_updated_idle), (update_account_thread),
114 (notify_get_msgs_full), (get_msgs_full_destroyer),
115 (get_msgs_full_thread):
116 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
117 * src/widgets/modest-header-view.c:
118 (idle_notify_headers_count_changed_destroy),
119 (idle_notify_headers_count_changed):
120 Use gdk_threads_enter() and gdk_threads_enter_leave() in
121 all idle handlers, because some other thread could be blocking
122 the GDK lock, so that it can do GUI stuff.
124 2007-06-26 Murray Cumming <murrayc@murrayc.com>
126 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
127 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
128 (on_idle_send_receive), (on_idle_open_default_inbox):
129 * src/maemo/modest-msg-edit-window.c:
130 (modest_msg_edit_window_attach_file_noninteractive):
131 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
132 to prevent a hang. I don't quite understand why these are necessary,
133 beause we should already be in the main loop. I guess something outside
134 of the main loop is taking the lock.
136 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
137 we are really using URIs, and use files that are more likely to exist.
139 2007-06-26 Murray Cumming <murrayc@murrayc.com>
141 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
142 necessary because configure.ac now defines different variables.
144 2007-06-26 Murray Cumming <murrayc@murrayc.com>
146 * libmodest-dbus-client/libmodest-dbus-client.c:
147 * libmodest-dbus-client/libmodest-dbus-client.h:
148 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
149 libmodest_dbus_client_compose_mail() is what things actually use.
151 * src/dbus_api/modest-dbus-api.h:
152 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
153 * tests/dbus_api/Makefile.am:
154 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
157 2007-06-26 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-init.c: (modest_init_local_folders):
160 For memory-card (or other non local-folders) maildir accounts,
161 always create an Archive folder, so that there is somewhere to put
162 messages. This should be less confusing, because the user does not need
163 to guess that the need to create a folder.
165 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
167 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
168 Fixed icon size by using (50, 50) which is the same as defined by
171 2007-06-25 Armin Burgmeier <armin@openismus.com>
173 * src/widgets/modest-window-mgr.c:
175 * configure.ac: Correctly recognize hildon-notify presence and fixed
176 the build without it being installed.
178 2007-06-25 Murray Cumming <murrayc@murrayc.com>
180 * libmodest-dbus-client/libmodest-dbus-client.c:
181 (libmodest_dbus_client_search): Fix the build. Sorry.
182 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
183 (reply_forward_cb): Initialize variables to fix the build.
185 * src/modest-tny-account-store.c:
186 (modest_tny_account_store_get_tny_account_by): Fix the account URI
187 comparison (a silly typo) so that email search results can be opened
188 when there are more than one account.
190 2007-06-25 Murray Cumming <murrayc@murrayc.com>
192 * libmodest-dbus-client/libmodest-dbus-client.c:
193 (libmodest_dbus_client_search),
194 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
195 instead of 1 second, because the search gets folders and messages from
196 the server, which can take a long time. When it times out,
197 osso-global-search will report no results.
199 We need to specify whether we should search only cached information
200 (maybe with a user preference), and the osso-email-search-plugin
201 API should really be improved to allow that option, and to allow results
202 to be delivered asynchronously in batches.
204 2007-06-25 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
207 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
208 GTK_ICON_SIZE_DIALOG is probably the wrong size.
210 2007-06-25 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
213 that is an empty string. D-Bus seems to give us these instead of NULL.
215 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
217 * src/dbus_api/modest-dbus-callbacks.c:
218 * src/maemo/easysetup/modest-easysetup-wizard.h:
219 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
220 * src/maemo/modest-connection-specific-smtp-edit-window.c:
221 (modest_connection_specific_smtp_edit_window_init):
222 * src/maemo/modest-maemo-global-settings-dialog.c:
224 * src/maemo/modest-maemo-utils.c:
225 (modest_maemo_utils_setup_images_filechooser):
226 * src/maemo/modest-main-window.c: (create_details_widget):
227 * src/maemo/modest-msg-edit-window.c:
228 (modest_msg_edit_window_attach_file_noninteractive),
229 (modest_msg_edit_window_color_button_change),
230 (modest_msg_edit_window_set_zoom):
231 * src/modest-mail-operation.c: (update_account_thread):
232 * src/modest-tny-account-store.c:
233 * src/modest-tny-account.c:
234 * src/widgets/modest-global-settings-dialog.c:
235 * src/widgets/modest-window.h:
239 2007-06-25 Murray Cumming <murrayc@murrayc.com>
241 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
242 * src/modest-search.c: (modest_search_folder),
243 (modest_search_all_accounts): Actually search only in the specified folder,
244 doing a simple match on the folder ID.
245 * src/modest-search.h: Added a folder field to the ModestSearch struct,
246 and added some documentation.
248 2007-06-22 Armin Burgmeier <armin@openismus.com>
250 * src/maemo/modest-maemo-utils.h:
251 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
252 modest_maemo_utils_get_supported_secure_authentication_methods.
254 * src/maemo/easysetup/modest-easysetup-wizard.c:
255 * src/maemo/modest-account-settings-dialog.c: Show correct error if
256 one occured, not just "Server does not support secure authentication".
258 2007-06-22 Murray Cumming <murrayc@murrayc.com>
260 * src/modest-tny-account-store.c: (get_password):
261 Restored the call to tny_account_set_user() because Philip seems to have
262 stopped this from crashing (by not using the freed string). It still does
263 not work, but now we can test it.
265 2007-06-22 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/modest-msg-edit-window.c: (init_window):
268 Comment out use of an uninitialzed GtkScrolledWindow variable,
269 to fix the build and stop a crash. Yet again.
271 2007-06-22 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account-store.c: (get_password):
274 Remove the call to tny_account_set_user() because this actually crashes.
275 As mentioned in the last commit, it is known to not work anyway.
277 2007-06-22 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-tny-account-store.c: (get_password):
280 Use tny_account_set_username() to tell tinymail that the username might
281 have changed too. But tinymail ignores this: see projects.maemo.org
283 * src/modest-ui-actions.c:
284 (modest_ui_actions_on_password_requested): Remove the useless attempt to
285 reset the connection when changing the username, and improve the comments.
286 Save the changed username to gconf at least, so it is used when Modest is
289 2007-06-21 Murray Cumming <murrayc@murrayc.com>
291 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
292 Do not use a query, so that we get all folders, including for POP and
293 local-folders. They work as search criteria too.
294 This fixes projects.maemo.org bug NB#57740.
296 2007-06-21 Murray Cumming <murrayc@murrayc.com>
298 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
299 Comment out the use of hildon_notification_set_sound() because it is
300 not declared, to fix the build. Warnings are serious, people.
302 2007-06-21 Armin Burgmeier <armin@openismus.com>
304 * src/maemo/modest-maemo-utils.h:
305 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
306 modest_maemo_utils_get_supported_secure_authentication_methods()
307 to query authentication methods for a specific user. This should fix
308 projects.maemo.org bug NB#61369.
310 * src/maemo/easysetup/modest-easysetup-wizard.c:
311 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
314 2007-06-21 Murray Cumming <murrayc@murrayc.com>
316 * libmodest-dbus-client/libmodest-dbus-client.h:
317 * libmodest-dbus-client/libmodest-dbus-client.c:
318 (modest_dbus_message_iter_get_search_hit),
319 (libmodest_dbus_client_search):
320 Reorganised and commented this.
321 Removed modest_search_hit_free() from the public API because it
324 Added libmodest_dbus_client_get_folders() and
325 modest_folder_result_list_free().
327 * src/dbus_api/modest-dbus-api.h:
328 * src/dbus_api/modest-dbus-callbacks.c:
329 (modest_dbus_req_filter): Commented. Moved most code to
330 on_dbus_method_search() and added on_dbus_method_get_folders().
332 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
333 of the extra D-Bus handler.
335 * tests/dbus_api/Makefile.am:
336 * tests/dbus_api/test_get_folders.c: New test for
337 libmodest_dbus_client_get_folders(). This seems to return an empty list
338 at the moment. That could be the same error that causes the message list
339 to be empty sometimes.
340 This should help with projects.maemo.org bug NB#57740.
342 2007-06-21 Armin Burgmeier <armin@openismus.com>
344 * src/modest-mail-operation.c: Do not call
345 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
346 notify the operation's end after having set the status to CANCELED for
347 the operation queue to listen on. This fixes a deadlock when there
348 were mail operations in the queue during its finalization.
350 * src/modest-singletons.c: Reordered uninitialization of the account
351 manager to happen after the mail operation queue was uninitialized
352 because the mail operation's in the queue might still try to access
353 the account manager (see modest_mail_operation_notify_end()). This
354 fixes a potential crash when terminating the application.
356 2007-06-21 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-search.c:
359 (search_mime_part_and_child_parts): Moved some code here so we
360 can search recursively in child folders.
361 (modest_search_folder): Search in the message as a mime part, instead
362 of just its child mime parts.
363 (read_chunk), (search_mime_part_ogs):
364 Check how many bytes were read, to prevent an endless loop.
365 Searching in message bodies now works. This finishes the fix for
366 projects.maemo.org bug NB#61007.
368 2007-06-20 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
371 Add a g_warning when the item is not a folder.
373 * src/modest-ui-dimming-rules.c:
374 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
375 when selected item is not a folder (for instance, an account), because
376 the UI spec only talks about folders.
377 I am not sure what the UI spec wants, so this might not totally fix
378 projects.maemo.org bug NB#60794.
380 2007-06-20 Murray Cumming <murrayc@murrayc.com>
382 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
383 (load_from_file): Sort the list. The unsorted list would be more noticeable
384 in non-English locales.
386 * src/maemo/modest-msg-edit-window.c:
387 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
388 warning and fix the build.
390 * src/maemo/modest-progress-bar-widget.c:
391 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
392 avoid a g_warning, and probably to avoid a crash.
394 2007-06-20 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-search.c: (modest_search_folder): Check for a GError
397 when calling tny_folder_get_headers(), to show that this is not the cause
400 2007-06-20 Murray Cumming <murrayc@murrayc.com>
402 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
403 Actually set the body query instead of the subject query.
405 * src/modest-search.c: (search_mime_part_ogs),
406 (search_mime_part_strcmp): Remove extra space from the text/* regex,
407 which would probably cause it to fail if we got this far.
409 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
410 to simplify the code.
411 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
412 be causing search-in-body to fail.
414 2007-06-20 Murray Cumming <murrayc@murrayc.com>
416 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
418 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
419 Better debug message when the folder cannot be found.
420 This should help with fixing projects.maemo.org bug #61287.
421 * src/modest-search.c: (add_hit): Do not leak the furl string.
423 2007-06-20 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-ui-actions.c:
426 (modest_ui_actions_on_folder_selection_changed):
427 Do not special-case TNY_MERGE_FOLDER here, because
428 modest_tny_folder_get_account() already does that. This fixes
429 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
430 shown when the Outbox was selected).
432 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
434 * libmodest-dbus-client/libmodest-dbus-client.c:
435 (_dbus_iter_get_string_or_null): Initialize the string variable in
436 case this helps with Dirk's crash.
438 2007-06-19 Murray Cumming <murrayc@murrayc.com>
440 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
441 though it is not implemented yet (this function is maybe not even used),
442 to avoid breaking ABI in future.
443 * libmodest-dbus-client/libmodest-dbus-client.c:
444 (get_attachments_string): Moved some code into this generic function.
445 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
446 sends email. It is maybe not used.
447 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
448 (on_send_mail): Use attachments.
450 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
451 * src/maemo/modest-msg-edit-window.c:
452 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
453 a filename before using it, to fix projects.maemo.org bug NB#58233.
455 2007-06-19 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
458 Initialize the continue_download variable to fix the build, and probably
459 to fix randome behaviour.
461 2007-06-18 Armin Burgmeier <armin@openismus.com>
463 * src/modest-tny-send-queue.h:
464 * src/modest-tny-send-queue.c: Keep track of the status of messages in
465 the queue so we can later show it in the UI. Replaced
466 modest_tny_send_queue_msg_is_being_sent() by
467 modest_tny_send_queue_get_msg_status().
469 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
471 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
472 gpointer. This probably was not harmful, but just to be sure.
474 2007-06-18 Murray Cumming <murrayc@murrayc.com>
476 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
477 Fix the build, but leave the function broken on Bora, because
478 hildon_uri_action_get_service() does not exist.
479 osso_uri_action_get_service() does not exist either, it seems.
481 2007-06-18 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-tny-account.c:
484 (modest_tny_account_new_from_server_account):
485 Uncommented the url debug output again, because it is useful for
486 debugging, as I said in the comment.
488 2007-06-18 Murray Cumming <murrayc@murrayc.com>
490 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
492 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
493 for Mameo Bora, to fix the build.
495 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
498 Fixed build with hildon < 0.99
500 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
501 Check if the selected account is busy instead of checking all accounts
503 * src/modest-account-mgr-priv.h:
504 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
505 (modest_account_mgr_init), (compare_account_name),
506 (modest_account_mgr_set_account_busy),
507 (modest_account_mgr_account_is_busy):
508 * src/modest-account-mgr.h:
509 Added busy information to the account manager. It possible to
510 set an account to busy or not busy now.
512 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
513 (modest_mail_operation_update_account),
514 (modest_mail_operation_notify_end):
515 Set the account to busy/not busy depending on the operation state.
517 * src/widgets/modest-account-view.c:
518 (modest_account_view_finalize), (get_last_updated_string),
519 (update_account_view), (on_account_busy_changed), (init_view):
520 Show string "Refreshing..." if the account is currently busy.
522 All this fixes projects.maemo.org bug NB#59711
524 2007-06-14 Armin Burgmeier <armin@openismus.com>
526 * src/widgets/modest-attachments-view.h:
527 * src/widgets/modest-attachments-view.c: Added
528 modest_attachments_view_has_attachments() and fixed coordinate
529 transformation in get_att_view_at_coords(). This fixes attachment
532 * src/widgets/modest-msg-view.c: Make use of
533 modest_attachments_view_has_attachments() to decide whether to show
534 attachments in the header.
536 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
538 * src/maemo/modest-connection-specific-smtp-edit-window.c:
539 (on_change), (on_combo_security_changed),
540 (modest_connection_specific_smtp_edit_window_init),
541 (modest_connection_specific_smtp_edit_window_set_connection),
542 (modest_connection_specific_smtp_edit_window_is_dirty):
543 * src/maemo/modest-connection-specific-smtp-edit-window.h:
544 * src/maemo/modest-connection-specific-smtp-window.c:
547 Show an comfirmation dialog for the smpt-edit-window if there are
548 unsaved changes and the user hits cancel.
549 (projects.maemo.org bug NB#60479)
551 2007-06-14 Armin Burgmeier <armin@openismus.com>
553 * src/maemo/easysetup/modest-easysetup-wizard.c:
554 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
555 address" info in banner instead of node, and select all the text as
556 per UI spec. This fixes projects.maemo.org bug NB#60550.
558 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
560 reviewed by: <delete if not using a buddy>
562 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
563 * src/modest-ui-actions.c: (folder_refreshed_cb):
565 2007-06-14 Murray Cumming <murrayc@murrayc.com>
567 * src/widgets/modest-folder-view.c: (filter_row):
568 Explictly filter out the per-account outbox accounts. I don't know why
569 these only sometimes show up, but now they should never show up in the UI.
570 This should fix projects.maemo.org bug NB#60160.
572 2007-06-14 Murray Cumming <murrayc@murrayc.com>
574 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
575 when the toolbar does not exist yet.
576 * src/modest-widget-memory.c: (save_settings_header_view):
577 Added g_warnings() to help us to discover when we are trying to set
578 an empty columns list in gconf.
580 2007-06-14 Murray Cumming <murrayc@murrayc.com>
584 Added modest_init_get_default_header_view_column_ids().
586 * src/modest-widget-memory.c: (restore_settings_header_view):
587 Use the new function to get defaults, if the gconf key is empty,
588 instead of not creating any columns. This seems to fix the
589 empty right-hand pane problems.
591 * src/widgets/modest-header-view.h: Improved documentation.
593 2007-06-13 Murray Cumming <murrayc@murrayc.com>
595 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
596 Revert the use of the display name as the account name, because this
597 is generally wrong and would break the code that follows.
599 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
601 * src/maemo/easysetup/modest-easysetup-wizard.c:
602 (check_for_supported_auth_methods), (on_before_next),
605 More correct fix for projects.maemo.org bug NB# 58991
606 Do not longer accept AUTH_PASSWORD as secure method and choose
607 correct method when creating the account.
609 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
611 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
612 Fixed projects.maemo.org bug NB# 58991
614 2007-06-13 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-init.c: (modest_init_init_core),
617 (modest_init_local_folders): Fixed compilation errors.
619 2007-06-13 Murray Cumming <murrayc@murrayc.com>
621 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
622 Remove unnecessary lib/include, though it is good in principle when needed.
624 * src/modest-init.c: (modest_init_one_local_folder),
625 (modest_init_local_folders):
626 * src/modest-init.h: Initialize the .modest library for memory cards,
627 instead of just doing nothing for them. This should allow us to create
628 folders there, fixing projects.maemo.org bug NB#59297.
630 2007-06-13 Murray Cumming <murrayc@murrayc.com>
632 * libmodest-dbus-client/libmodest-dbus-client.c:
633 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
634 (libmodest_dbus_client_compose_mail),
635 (libmodest_dbus_client_open_message),
636 (libmodest_dbus_client_send_and_receive),
637 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
639 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
640 (on_idle_open_message), (modest_dbus_req_handler),
641 (search_result_to_message), (modest_dbus_req_filter):
642 * src/modest-search.c: (add_hit), (modest_search_folder),
643 (modest_search_all_accounts): Improved debug messages.
645 * tests/dbus_api/test_open_message.c: (main): Improved comments.
647 * src/modest-tny-account-store.c:
648 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
651 2007-06-13 Murray Cumming <murrayc@murrayc.com>
654 2007-06-12 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-tny-account-store.c: (get_server_accounts):
657 Call modest_tny_local_folders_account_add_merged_outbox_folders()
658 even when there are no accounts, so that the Outbox folder is always
659 visible. This fixes projects.maemo.org bug NB#60158.
661 2007-06-12 Murray Cumming <murrayc@murrayc.com>
663 * src/maemo/modest-main-window.c: (create_details_widget):
664 Use the mcen_va_never logical ID.
666 2007-06-12 Murray Cumming <murrayc@murrayc.com>
668 * src/dbus_api/modest-dbus-api.h:
669 * src/dbus_api/modest-dbus-callbacks.c:
670 (on_idle_open_default_inbox), (on_open_default_inbox),
671 (modest_dbus_req_handler):
672 Added a new OpenDefaultInbox method.
674 * libmodest-dbus-client/libmodest-dbus-client.h:
675 * libmodest-dbus-client/libmodest-dbus-client.c:
676 Added libmodest_dbus_client_open_default_inbox() to call the new
677 dbus method. This should be useful to projects.maemo.org bug NB#57214,
678 though it should maybe be used by a new osso-email-interface function.
680 * tests/dbus_api/Makefile.am:
681 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
684 2007-06-12 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
687 NULL, so that the signals get all the keys. This should not actually
688 change any behaviour because we currently update everything when anything
691 2007-06-12 Murray Cumming <murrayc@murrayc.com>
693 * src/widgets/modest-folder-view.c: (text_cell_data),
694 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
695 (find_inbox_iter): If tinymail tells us that the folder is
696 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
697 This causes the inbox to be selected at startup, fixing part of
698 projects.maemo.org bug NB#56305.
700 * src/modest-ui-dimming-rules.c:
701 (modest_ui_dimming_rules_on_tools_smtp_servers):
702 * src/modest-ui-dimming-rules.h: Added a callback function to dim
703 the SMTP servers menu item.
704 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
705 that the SMTP Servers menu item is dimmed when there are no accounts,
706 as a future version of the UI spec will require. This fixes
707 projects.maemo.org bug NB#56305.
709 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
711 * src/maemo/modest-maemo-utils.c:
712 (modest_maemo_utils_get_supported_secure_authentication_methods):
713 Added label to dialog instead of unreadable title
715 * src/maemo/modest-main-window.c: (sync_accounts_cb),
716 (modest_main_window_new):
717 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
720 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
721 * src/modest-account-mgr.h:
722 Added method to avoid code duplication
724 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
725 (modest_ui_actions_on_send_receive):
726 Use modest_account_mgr_has_accounts
728 2007-06-11 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/easysetup/modest-presets.c:
731 (modest_presets_get_info_server_security): Do not report secure auth
733 * src/modest-protocol-info.c: Use the defines for the gconf key names
734 for secure authentication. This was not working because we were writing
735 Password and reading password, and the check was case sensitive.
736 With this, gmail now works for receiving and sending when created via
739 2007-06-11 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/easysetup/modest-presets.c:
742 (modest_presets_get_info_server_security): Correct the key name for
743 SecureSmtp, because it seems to be case-sensitive.
744 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
745 Do not try to get the 0th notebook page if there are 0 pages, to
748 2007-06-11 Murray Cumming <murrayc@murrayc.com>
750 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
751 Prevent use of the new notification feature for now, because it currently
752 shows one dialog for each new email, which is annoying.
754 2007-06-11 Murray Cumming <murrayc@murrayc.com>
756 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
757 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
758 when no country was selected, so that we show the global ones.
759 * src/maemo/easysetup/modest-presets.c:
760 (modest_presets_get_providers): Return only the global providers, not
761 all providers when mmc=0 was requested.
763 2007-06-11 Murray Cumming <murrayc@murrayc.com>
765 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
766 (easysetup_provider_combo_box_fill): Remove debug code that showed the
767 provider ID in the combo.
769 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
770 Do not show the page numbers, because it would be confusing when we add
771 the 2 extra pages for the custom setup, when the user chooses the "Other"
772 provider. This fixes projects.maemo.org bug NB#59028
774 * src/modest-init.c: (modest_init_init_core),
775 (modest_init_local_folders):
777 * src/modest-tny-account.c:
778 (modest_tny_account_new_for_local_folders): Do not create default folders
779 for the memory card. This should fix projects.maemo.org bug NB#59328.
781 2007-06-11 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
784 Free the changed_conf_keys string items. They are already freed in the
785 idle handler if that runs first.
787 2007-06-11 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-ui-actions.c:
790 (modest_ui_actions_on_password_requested): Check that the server name
791 is not NULL, because I just saw a password dialog with (null) as the
794 * src/modest-tny-folder.[h|c]: Added
795 modest_tny_folder_is_memory_card_folder().
796 * src/modest-ui-dimming-rules.c:
797 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
798 menu item for memory cards, as per the UI spec (section 7.4). This should
799 fix projects.maemo.org bug NB#59297.
801 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
803 * src/maemo/modest-main-window.c: (sync_accounts_cb):
804 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
805 is another problem with the code, see Murray's comment at line 772)
807 2007-06-08 Murray Cumming <murrayc@murrayc.com>
809 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
810 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
811 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
812 (load_from_file), (easysetup_country_combo_box_init),
813 (easysetup_country_combo_box_get_active_country_ids),
814 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
815 instead of just one ID, to avoid duplicate country names in the UI.
817 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
818 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
819 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
820 a single ID, avoiding duplicate providers.
821 * src/maemo/easysetup/modest-easysetup-wizard.c:
822 (on_combo_account_country): Adapt to use a list.
824 2007-06-08 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
827 keys changed in the last X seconds.
829 * src/modest-account-mgr.h:
830 * src/modest-account-mgr.c: (on_timeout_notify_changes),
831 (on_key_change), (modest_account_mgr_class_init),
832 (modest_account_mgr_init), (modest_account_mgr_finalize):
833 As the keys are changed, save them in a GSList* and signal that GSList*
834 further every X seconds, to batch changes, to allow us to do just one
835 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
836 bug NB#56941 and other (UI-blocking) delays when changing account settings.
838 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
839 changed signal signature.
841 * src/modest-conf.c: (modest_conf_set_list),
842 (modest_conf_on_change): Reenable notification.
844 (modest_conf_maemo_fake_on_change): Comment out the hack that
845 notified immediately instead of asynchronously.
847 * src/widgets/modest-account-view.h:
848 * src/widgets/modest-account-view.c:
849 (update_account_view): Select the previously-selected account ID,
850 if possible. This fixes projects.maemo.org bug NB#56933.
852 (on_account_changed), (on_account_removed),
853 (modest_account_view_select_account):
855 Remove the block/unblock functions
856 because they were not useful.
858 * src/maemo/modest-account-view-window.c:
859 (on_delete_button_clicked), (on_edit_button_clicked),
860 (on_new_button_clicked): Remove the use of the non-working block/unblock.
862 2007-06-08 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
865 Improve the error dialog to show Incorrect Account Settings, which seems
866 clearer, and say that the internal error message (to be removed from the
867 dialog later) is often misleading.
868 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
870 * src/modest-tny-account.c:
871 (modest_tny_account_new_from_server_account): Uncomment the printf of the
872 URL because this is so useful for debugging on the device.
874 * src/widgets/modest-serversecurity-combo-box.c:
875 (modest_serversecurity_combo_box_fill): Correct a logical ID.
877 2007-06-08 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-mail-operation.c:
880 (modest_mail_operation_send_new_mail):
881 Added a comment about a nasty but apparently harmless message. Details
882 added to the wiki g_warnings() page.
884 2007-06-08 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
887 (modest_tny_send_queue_class_init):
888 Do not use the priv struct because it is empty, to avoid g_warnings
889 about a non-existant priv struct.
891 * src/modest-tny-account-store.c:
892 (modest_tny_account_store_get_server_account),
893 (modest_tny_account_store_get_transport_account_for_open_connection
894 ): Do not try to get transport server accounts for local folders,
895 because they don't have any. This avoids a g_warning().
897 * src/maemo/modest-main-window.c:
898 (modest_main_window_notify_send_receive_initied),
899 (on_configuration_key_changed):
900 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
902 * src/modest-mail-operation.c:
903 (modest_mail_operation_update_account):
904 * src/modest-tny-account-store.h:
905 * src/modest-tny-account.c:
906 (modest_tny_account_get_special_folder),
907 (modest_tny_account_new_for_local_folders),
908 (modest_tny_account_new_for_per_account_local_outbox_folder):
909 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
910 * src/modest-tny-local-folders-account.c:
911 (add_account_folders_to_merged_folder):
912 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
913 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
914 (modest_ui_actions_on_send):
915 * src/widgets/modest-folder-view.c: (update_model):
916 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
917 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
918 modest_tny_account_store_get_tny_account_by_account() to
919 modest_tny_account_store_get_server_account() to make the code clearer.
921 2007-06-07 Marcus Bauer <marcusb@openismus.com>
923 * src/dbus_api/modest-dbus-api.h:
924 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
925 * src/maemo/modest-msg-edit-window.c:
926 (modest_msg_edit_window_attach_file_noninteractive):
927 added g_warning in case the file to be attached does not exist
928 * tests/dbus_api/test_compose_mail.c: (main):
929 removed obsolete comment, added generic files as test case
931 2007-06-07 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-tny-account-store.c: (get_server_accounts):
934 Create the local folders account only once, not once for each outbox, and
935 not only when there are some outboxes.
937 2007-06-07 Murray Cumming <murrayc@murrayc.com>
939 * src/widgets/modest-folder-view.c: (update_model): Comment out some
940 code that is causing a crash at startup. Sergio says that he is fixing this.
942 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
944 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
945 * src/maemo/modest-account-settings-dialog.c:
946 (create_page_outgoing),
947 (modest_account_settings_dialog_set_account_name),
948 (save_configuration):
949 - Fixed handling of the "Use secure authentication" toggle to comply with
950 the ui specification. See also projects.maemo.org bug NB#58400
952 - Restore the Secure connection setting combo correctly when loading
955 * src/maemo/modest-maemo-utils.c:
956 (on_camel_account_get_supported_secure_authentication),
957 (modest_maemo_utils_get_supported_secure_authentication_methods):
958 Fixed a crasher if operation is canceled
960 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
961 (modest_protocol_info_auth_is_secure):
962 * src/modest-protocol-info.h:
964 Added two new methods to determine if a protocol/auth method is secure/encrypted in
965 the sense of the "Use secure authentication" toggle.
967 2007-06-07 Murray Cumming <murrayc@murrayc.com>
969 * src/modest-tny-account-store.h:
970 * src/modest-tny-account-store.c:
971 Added modest_tny_account_store_get_local_folders_account().
973 * src/modest-tny-folder.h:
974 * src/modest-tny-folder.c:
975 (modest_tny_folder_get_account):
976 Added this replacement for tny_folder_get_account() which returns
977 the local-folders account for TnyMergeFolders, to avoid the
978 warning about the unimplemented get_account_func() vfunc().
980 (modest_tny_folder_get_rules),
981 * src/modest-ui-actions.c:
982 (modest_ui_actions_on_folder_selection_changed):
983 * src/modest-mail-operation.c:
984 (modest_mail_operation_remove_folder),
985 (modest_mail_operation_xfer_folder),
986 (modest_mail_operation_rename_folder),
987 (modest_mail_operation_get_msg),
988 (modest_mail_operation_get_msgs_full),
989 (modest_mail_operation_remove_msg),
990 (modest_mail_operation_xfer_msgs),
991 (modest_mail_operation_refresh_folder):
992 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
994 2007-06-07 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
997 (modest_server_account_set_security):
998 * src/modest-defs.h: Add comments explaining that our
999 UI spec means TLS when it says Normal, so these do not look like errors.
1001 * src/modest-tny-account.c:
1002 (modest_tny_account_new_from_server_account): Use the new tinymail
1003 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1004 for TLS. This should fix projects.maemo.org bug NB#58460.
1006 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1008 * src/maemo/easysetup/modest-easysetup-wizard.c:
1009 (create_account): Correct the position of the gconf sanity check warning.
1010 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1011 of using the g_idle_add() hack, because this does not seem to be necessary
1012 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1013 caused by something other than maemo's gconf.
1014 This fixes projects.maemo.org bug #59022.
1016 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-account-mgr-helpers.c:
1019 (modest_account_mgr_get_default_account): Do not check that the account
1020 exists if there is no default account (NULL), to fix a runtime warning.
1022 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1024 * src/widgets/modest-folder-view.c: (update_model):
1025 Do not unref the treemodel before we have finished with it.
1026 This prevents a valgrind warning and an occasional crash at startup.
1028 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1030 * libmodest-dbus-client/libmodest-dbus-client.h:
1031 added libmodest_dbus_client_compose_mail()
1032 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1034 added functions needed for SendAsMail() functionality
1035 * src/maemo/modest-msg-edit-window.c:
1036 (modest_msg_edit_window_attach_file_noninteractive):
1037 non interactively attaching files to message edit window
1038 * src/widgets/modest-msg-edit-window.h:
1039 * tests/dbus_api/Makefile.am:
1040 added test_compose_mail.c
1041 * tests/dbus_api/test_compose_mail.c: (main):
1043 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1045 * src/modest-account-view.c:
1046 Fixed bug projects.maemo.org bug NB#59307
1048 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1050 * src/maemo/easysetup/modest-easysetup-wizard.c:
1051 (get_serverport_incoming), (on_before_next), (create_account):
1052 * src/maemo/modest-account-settings-dialog.c:
1053 (modest_account_settings_dialog_set_account_name):
1054 * src/maemo/modest-maemo-utils.c:
1055 (on_camel_account_get_supported_secure_authentication_status),
1056 (on_camel_account_get_supported_secure_authentication),
1057 (on_secure_auth_cancel),
1058 (modest_maemo_utils_get_supported_secure_authentication_methods):
1060 Implemented security authentication for settings and easysetup.
1062 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/modest-main-window.c: (create_details_widget):
1065 Show the total size for memory card accounts too, instead of showing
1066 the name again. Fixes bug projects.maemo.org bug NB#59307.
1068 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-tny-simple-folder-store.c:
1072 * src/modest-tny-simple-folder-store.h: Removed.
1074 * src/modest-tny-local-folders-account.h
1075 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1076 for the local-folders maildir, with an extra TnyMergedFolder containing
1077 the folders of the per-account outbox store accounts.
1078 * src/modest-tny-account-store.c: (get_server_accounts):
1079 Add the outboxes to the special local folders account after creating it.
1081 * src/modest-tny-account.c:
1082 (modest_tny_account_new_for_local_folders): Create the derived
1083 account when creating the main local-folders account.
1085 * src/maemo/modest-main-window.c: (create_details_widget),
1086 (modest_main_window_set_contents_style):
1087 Adapted to the use of the derived account instead of the folder store.
1089 * src/modest-ui-actions.c:
1090 (modest_ui_actions_on_folder_selection_changed):
1091 * src/modest-ui-dimming-rules.c:
1092 (modest_ui_dimming_rules_on_new_folder):
1093 * src/widgets/modest-folder-view.c: (text_cell_data),
1094 (icon_cell_data), (filter_row), (update_model),
1095 (get_cmp_rows_type_pos):
1098 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1099 Do not get the priv struct, because no priv struct has been set,
1100 to avoid a runtime warning.
1102 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1103 #ifelse with #else, to fix a warning, to fix the build.
1106 2007-06-05 Christian Kellner <ckellner@openismus.com>
1108 * libmodest-dbus-client/libmodest-dbus-client.c:
1109 Fix small typo in doc (why do you always see them
1110 AFTER committing stuff?)
1113 2007-06-05 Christian Kellner <ckellner@openismus.com>
1115 * libmodest-dbus-client/libmodest-dbus-client.c:
1116 (libmodest_dbus_client_search):
1117 Initialize hit list with NULL. Also set folder list
1118 to "" if NULL was supplied.
1121 2007-06-03 Christian Kellner <ckellner@openismus.com>
1123 * libmodest-dbus-client/libmodest-dbus-client.c:
1124 (modest_search_hit_list_free):
1125 Make it save to call it with NULL.
1127 * src/dbus_api/modest-dbus-callbacks.c:
1128 * src/modest-search.c:
1129 Return full ModestSearchHits as the search result list not TnyHeader
1130 since can't be around withouth the correspoding TnyFolder.
1132 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1134 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1135 Added currently commented code to check for secure auth
1137 * src/maemo/modest-account-settings-dialog.c: (on_response),
1138 (save_configuration), (show_ok):
1139 Fixed projects.maemo.org bugs NB #59248 and #59251
1141 * src/maemo/modest-maemo-utils.c:
1142 (on_camel_account_get_supported_secure_authentication_status),
1143 (on_camel_account_get_supported_secure_authentication),
1144 (modest_maemo_utils_get_supported_secure_authentication_methods):
1145 * src/maemo/modest-maemo-utils.h:
1146 Moved get_supported_secure_authentication() method here to be able
1147 to use it from easysetup wizard.
1149 * src/modest-pair.c: (on_pair_compare_as_string):
1150 Should compare string with first part of pair and not
1151 strcmp pairs which will crash.
1153 * src/modest-protocol-info.c:
1154 (modest_protocol_info_protocol_is_store):
1155 * src/modest-protocol-info.h:
1156 Added modest_protocol_info_get_auth_protocol_name()
1158 2007-06-03 Armin Burgmeier <armin@openismus.com>
1160 * src/modest-mail-operation.c:
1161 (modest_mail_operation_get_msgs_full): Set priv->account also when
1162 only retrieving a single message. This avoids a crash when canceling
1165 (modest_mail_operation_notify_end): Do not explicitely remove the
1166 operation from the queue but only emit the progress_changed signal.
1167 The queue itself listens to that signal to remove the operation when
1168 it is finished. This reduces coupling and removes a potential deadlock
1169 when modest_mail_operation_notify_end() is called from the queue
1170 itself. If that is a problem performance-wise, I would suggest to
1171 implement a status-changed signal or something.
1173 * src/modest-mail-operation-queue.c: Make sure to never call a
1174 function from another file while the queue is locked. This (hopefully)
1175 fixes another deadlock when exiting the application while retrieving
1178 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1180 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1181 Fixed build if libogs is not available
1183 2007-06-03 Christian Kellner <ckellner@openismus.com>
1185 * libmodest-dbus-client/libmodest-dbus-client.h:
1186 * libmodest-dbus-client/libmodest-dbus-client.c:
1187 (libmodest_dbus_client_delete_message):
1188 Implement deletion of messages (Client side).
1190 (modest_search_hit_free),
1191 (modest_search_hit_list_free):
1192 Utility functions to free the result hits.
1194 * src/dbus_api/modest-dbus-api.h:
1195 * src/dbus_api/modest-dbus-callbacks.c:
1196 (on_delete_message),
1197 (modest_dbus_req_handler):
1198 Implement deletion of messages (Server side).
1200 * tests/dbus_api/test_search.c: (main):
1203 * tests/dbus_api/Makefile.am:
1204 * tests/dbus_api/test_delete_message:
1205 Add little test for the message deletion logic
1207 2007-06-03 Armin Burgmeier <armin@openismus.com>
1209 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1210 when the operation queue was not empty. projects.maemo.org bug
1213 2007-06-03 Armin Burgmeier <armin@openismus.com>
1215 * src/widgets/modest-account-view.c
1216 (on_account_default_toggled): Toggle default account column
1217 explicitely instead of waiting for gconf notification (which is
1218 currently ignored). This should fix projects.maemo.org bug NB#56910
1219 for now. It should probably be removed when gconf notifications are
1222 2007-06-03 Christian Kellner <ckellner@openismus.com>
1224 * libmodest-dbus-client/libmodest-dbus-client.c:
1225 Removed debugging spew.
1227 * src/dbus_api/modest-dbus-callbacks.c:
1228 Added debugging info.
1230 * src/modest-search.c:
1231 (modest_search_all_accounts):
1232 Use tny_account_store_get_accounts () on the account store
1233 to get all accounts which is the way to get all accounts.
1235 * tests/dbus_api/test_search.c: (main):
1236 Make it possible to supply the search term on the command line.
1238 2007-06-03 Christian Kellner <ckellner@openismus.com>
1240 * libmodest-dbus-client/libmodest-dbus-client.c:
1241 * libmodest-dbus-client/libmodest-dbus-client.h:
1242 Implement searching for mesages over raw dbus. (Client side)
1244 * src/dbus_api/Makefile.am:
1245 * src/dbus_api/modest-dbus-api.h:
1246 * src/dbus_api/modest-dbus-callbacks.c:
1247 * src/dbus_api/modest-dbus-callbacks.h:
1248 Search framework (Server side). Also implement on_idle_open_message().
1250 * src/maemo/modest-platform.c: (modest_platform_init):
1251 Prepare for raw dbus/osso rpc interaction.
1253 * src/modest-search.h:
1254 Changed minsize from unspecific guint to guint32.
1256 * src/modest-search.c:
1258 Added strange hack which magically made tnymail work.
1260 (modest_search_folder),
1261 (modest_search_account),
1262 (modest_search_all_accounts):
1263 Implement helper functions to search all accounts, specific account
1266 * tests/dbus_api/Makefile.am:
1267 * tests/dbus_api/test_open_message.c:
1268 Read url to open from commandline.
1270 * tests/dbus_api/test_search.c:
1271 Implement small test for dbus search stuff
1273 2007-06-02 Armin Burgmeier <armin@openismus.com>
1275 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1276 include account type and account title. This fixes projects.maemo.org
1279 * src/maemo/modest-account-view-window.c: Set a title for the window.
1281 2007-06-02 Armin Burgmeier <armin@openismus.com>
1283 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1284 incoming and outgoing server name based on email address and server
1285 types as long as the names have not been edited manually. This fixes
1286 projects.maemo.org bug NB#58671.
1288 2007-06-02 Armin Burgmeier <armin@openismus.com>
1290 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1291 server type cannot be changed in future to the incoming details page
1292 when creating an account. This fixes projects.maemo.org bug NB#59029.
1294 2007-06-02 Armin Burgmeier <armin@openismus.com>
1296 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1297 and assigned max width chars so that they wrap instead of being
1298 truncated. Fixes projects.maemo.org bug NB#56126.
1300 2007-06-02 Armin Burgmeier <armin@openismus.com>
1302 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1303 introductory note to the connection specific smtp servers dialog, as
1304 section 8.12 of the email UI specification requires. This fixes
1305 projects.maemo.org bug NB#59212.
1307 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1309 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1310 Check for running mail operations, and offer to cancel them, as per the UI
1311 spec. This fixes projects.maemo.org bug NB#59041 .
1312 However, I suspect that tinymail may still use the network connection
1313 in ways that we cannot detect or cancel. But it should at least adapt to
1314 changes fairly well.
1316 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-tny-account-store.c: (recreate_all_accounts),
1319 (get_cached_accounts), (get_server_accounts): Do more sensible
1320 ref-counting of the temporarily-cached outbox accounts list. This seems
1321 to fix a crash when entering the password when the password was wrong.
1323 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1325 * src/gnome/modest-main-window.c: (connect_signals):
1326 * src/modest-tny-account-store.c: (get_password),
1327 (modest_tny_account_store_alert): Added comments and clues and
1328 commented-out code about how we currently fail to deal with connection
1329 errors and wrong passwords, and how we should.
1331 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1333 * src/widgets/modest-retrieve-combo-box.c:
1334 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1335 This fixes projects.maemo.org bug NB#58472 .
1337 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1339 * src/maemo/easysetup/modest-easysetup-wizard.c:
1340 (create_page_complete_easysetup):
1341 (create_page_complete_custom): Correct the last commit,
1342 putting the correct sentences in the correct pages.
1344 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1346 * src/maemo/easysetup/modest-easysetup-wizard.c:
1347 (create_page_complete_custom): Show the second sentence of text
1348 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1351 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1353 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1354 Set the leave-on-server conf key by default. This fixes
1355 projects.maemo.org bug NB#59258 .
1357 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1359 * src/maemo/modest-account-view-window.c:
1360 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1361 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1364 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1366 * src/maemo/easysetup/modest-easysetup-wizard.c:
1367 (create_caption_new_with_asterisk):
1368 * src/maemo/modest-account-settings-dialog.c:
1369 (create_caption_new_with_asterisk):
1370 Uncomment the code to add the asterisk, because they are no longer in the
1371 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1372 (update_incoming_server_title): Add an asterisk here too.
1374 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/modest-maemo-global-settings-dialog.c:
1377 (current_connection): Check that we are even connected before trying to
1378 get the current connection name, to prevent a warning.
1380 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1381 Change the comments because tny_maemo_conic_device_connect() is now meant to
1383 * src/modest-mail-operation.c:
1384 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1385 make sure we have a connection and fail if we can't connect.
1387 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/modest-main-window.c:
1390 (on_account_store_connecting_finished): Do not try to get the
1391 connection ID if we are not really connected. I am surprised that
1392 this signal handler is called when we are not connected.
1394 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1396 * src/modest-error.h:
1397 * src/modest-ui-actions.c:
1398 (modest_ui_actions_get_msgs_full_error_handler):
1399 Renamed an enum, added comments, added an enum
1400 for retrieve-limit errors.
1402 * src/modest-mail-operation.c: (foreach_add_item),
1403 (internal_folder_observer_update), (update_account_thread),
1404 (modest_mail_operation_get_msgs_full):
1405 (modest_mail_operation_update_account),
1406 Added comments about how this works, and some code that should
1407 (but does not) check the retrieve-limit. See the TODO comment.
1409 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1412 Initialize help_id to fix the build. Warnings are good.
1414 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1416 * src/widgets/modest-hbox-cell-renderer.c:
1417 (modest_hbox_cell_renderer_append):
1418 * src/widgets/modest-vbox-cell-renderer.c:
1419 (modest_vbox_cell_renderer_append):
1420 Fix the last commit by doing an extra ref.
1422 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1424 * src/widgets/modest-hbox-cell-renderer.c:
1425 (modest_hbox_cell_renderer_append):
1426 * src/widgets/modest-vbox-cell-renderer.c:
1427 (modest_vbox_cell_renderer_append):
1428 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1429 to fix the build with Maemo Bora.
1430 However, there seems to be a remaining crash, probably due to reference
1433 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1435 * src/modest-tny-account.c:
1436 (modest_tny_account_new_for_local_folders):
1437 Use hildon_file_system_info_async_new() to get a better name for
1438 the memory card account, setting it as the account name.
1439 The timing seems to work, but this is probably
1440 not the best place to do this. See the TODO comment.
1441 * src/maemo/modest-main-window.c: (create_details_widget):
1442 * src/widgets/modest-folder-view.c: (text_cell_data):
1443 Use the tny account name instead of hardcoding a name.
1445 2007-05-30 Christian Kellner <ckellner@openismus.com>
1447 * src/modest-search.c: (modest_search):
1448 Correctly set part_search_func even if we have already parsed
1449 the query and thus a valid OgsTextSearcher object.
1451 2007-05-30 Christian Kellner <ckellner@openismus.com>
1454 Search and check for libogs.
1457 Incooparte the ogs build env.
1459 * src/modest-mime-part-search-stream.c:
1460 * src/modest-mime-part-search-stream.h:
1461 Removed since we do the real searching now in modest-search.c.
1463 * src/modest-search.c:
1464 * src/modest-search.h:
1465 Implement support for ogs. We use that if available and requested
1466 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1467 should now handle the corner case when the search term is spread
1468 across multiple reads.
1469 Also the logic in modest_search () was corrected to search all
1470 requested fields until one is found.
1472 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1474 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1476 * src/modest-init.h:
1477 * src/modest-init.c: Made modest_init_local_folders() take a
1478 path and be public so we can iniitialize maildir folders on
1481 * src/modest-local-folder-info.h:
1482 * src/modest-local-folder-info.c:
1483 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1485 * src/modest-tny-account.c:
1486 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1487 still means the standard local-folders path on the local volume.
1489 * src/modest-tny-account-store.c:
1490 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1491 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1492 all accounts when that happens.
1493 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1494 this too, so it shows up in the treeview.
1496 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/modest-maemo-global-settings-dialog.c:
1499 (current_connection):
1500 * src/widgets/modest-global-settings-dialog.c:
1501 (current_connection_default):
1502 Use the enum values instead of 0, 1 and -1,
1503 to make the code clearer.
1505 * src/modest-account-mgr-helpers.c:
1506 (modest_account_mgr_get_connection_specific_smtp): Make this code
1509 * src/modest-runtime.h:
1510 * src/modest-runtime.c:
1511 Added modest_runtime_remove_all_send_queues().
1512 * src/maemo/modest-main-window.c:
1513 (on_account_store_connecting_finished): Recreate the send queues,
1514 using the appropriate transport accounts for this new connection.
1515 Some futher adapting might be needed if the old send queues are not
1516 automatically stopped at this point.
1518 * src/modest-tny-account-store.c: (get_server_accounts):
1519 Create the connection-specific transport accounts, so that they can
1520 be found later by their ID.
1522 * src/modest-tny-account.h:
1523 * src/modest-tny-account.c:
1524 Added modest_tny_account_new_from_server_account_name().
1525 modest_tny_account_new_from_server_account(): Do not create the
1526 send queues here, because they will be
1527 recreated anyway when the connection changes for the first time.
1529 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-local-folder-info.h:
1532 * src/modest-local-folder-info.c:
1533 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1534 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1535 tbox_folder): Take a modest account name instead of a server TnyAccount,
1536 so we can have per-modest-account rather than per-transport-account
1538 We must make sure that we change or recreate the exisitng send queues
1539 when the connection changes for connection-specific transport accounts.
1541 * src/modest-tny-account-store.c:
1542 (create_per_account_local_outbox_folders): Create outboxed per modest
1543 account, not per transport account.
1545 * src/modest-tny-account.h:
1546 * src/modest-tny-account.c:
1547 (modest_tny_account_get_special_folder): For outboxes, get the
1548 parent modest account name. The account is ignored for other folders.
1549 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1550 modest account name rather than a server TnyAccount.
1552 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1554 * src/modest-tny-account.c:
1555 (modest_tny_account_new_from_server_account):
1556 Call modest_runtime_get_send_queue() immediately after creating transport
1557 accounts, so that they start trying to send email from the outbox as soon
1558 as possible at startup. This is probably what we want.
1560 * src/modest-mail-operation.c: (update_account_thread):
1561 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1562 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1563 * src/modest-tny-send-queue.h:
1564 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1565 (modest_ui_actions_on_send):
1566 Added comments about how sending works, though it needs some more work.
1568 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-tny-account.c:
1571 (modest_tny_account_get_special_folder): Add TODO because this fails when
1572 the network is busy.
1573 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1574 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1575 Do not try to show this window when there is no active account. The UI
1576 specs does not tell us what to do in this case.
1578 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/Makefile.am:
1583 * src/widgets/Makefile.am: Some dist fixes.
1585 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-connection-specific-smtp-window.c:
1588 (on_button_edit): Make the code clearer, to prevent a double free.
1590 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1592 * src/maemo/modest-account-settings-dialog.c:
1593 (modest_account_settings_dialog_set_account_name),
1594 Check the connection-specific smtp servers checkbox if there are any.
1596 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1597 (modest_connection_specific_smtp_edit_window_init):
1598 Start with a suitable port number.
1600 * src/modest-account-mgr-helpers.h:
1601 * src/modest-account-mgr-helpers.c: Added
1602 modest_account_mgr_get_has_connection_specific_smtp().
1604 (modest_account_mgr_set_connection_specific_smtp),
1605 (modest_account_mgr_remove_connection_specific_smtp),
1606 (modest_account_mgr_get_has_connection_specific_smtp),
1607 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1608 connection-specific smtp server accounts in the account, rather than
1609 the server account conf dir.
1611 This fixes bug projects.maemo.org bug NB#58263 .
1613 * src/modest-tny-account-store.c:
1614 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1615 if there are no server accounts yet, to prevent an infinite loop when there
1616 are no accounts. Document that one must be called before the other.
1618 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1620 * src/modest-account-mgr-helpers.c:
1621 (modest_account_mgr_get_default_account): Make sure that at least
1622 one account is always the default, if there are any enabled accounts.
1623 This is just a sanity check that shouldn't be necessary.
1625 * src/modest-account-mgr-priv.c:
1626 (_modest_account_mgr_account_from_key): Unescape the conf key to
1627 get the real account name. For instance, this is an issue if a space
1628 was in the account name, which can happen because the account name
1629 is generated from the display name.
1630 (_modest_account_mgr_get_account_keyname): Always escape the
1632 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1633 Unescape the conf keys to get the real account names.
1635 For instance, previously the is-default radio button in the accounts
1636 list was not checked for any accounts at first. This fixes that,
1637 and might fix several similar bugs.
1639 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1641 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1642 Removed some debug printfs.
1644 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1646 Modest on-disk outbox directories are now here, for instance:
1647 $HOME/.modest/outboxes/<account-id-1>/outbox
1648 $HOME/.modest/outboxes/<account-id-2>/outbox
1650 $HOME/.modest/local-folders/outbox
1651 so we can have a separate outbox for each account.
1652 But they are shown as one outbox in the GtkTreeView, by using a
1653 TnyMergeFolder in a ModestTnySimpleFolderStore.
1656 * src/modest-tny-simple-folder-store.c:
1657 * src/modest-tny-simple-folder-store.h:
1658 Added ModestTnySimpleFolderStore, used to contain folders from
1659 other folder stores, such as other accounts.
1661 * src/modest-tny-outbox-account.h:
1662 * src/modest-tny-outbox-account.c:
1663 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1664 used for the per-account local outbox folders.
1666 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1667 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1668 only use this (internally) now for the non-outbox local folders.
1670 * src/modest-init.h:
1671 * src/modest-init.c: Added modest_init_one_local_folder(), for
1672 setting up the directory structure for each local folder.
1674 * src/modest-local-folder-info.c:
1675 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1676 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1678 * src/modest-local-folder-info.h:
1679 * src/modest-tny-account-store.c: (on_account_removed),
1680 (on_account_changed), (create_per_account_local_outbox_folders),
1681 (get_server_accounts), (modest_tny_account_store_get_accounts),
1682 (modest_tny_account_store_get_tny_account_by_account),
1683 (modest_tny_folder_store_is_virtual_local_folders):
1685 * src/modest-tny-account.h:
1686 * src/modest-tny-account.c:
1687 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1688 to create an on-disk per-account local outbox folder for each
1690 (create_per_account_local_outbox_folders): Create a local outbox folder
1691 for each transport account.
1692 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1693 for all local folders.
1695 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1696 instead of using g_object_get/set() directly. It is clearer.
1698 (modest_tny_folder_store_get_message_count),
1699 (modest_tny_folder_store_get_local_size
1700 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1701 because we now use these with non-acount folder stores.
1703 (modest_tny_account_get_special_folder),
1704 (modest_tny_account_new_from_server_account),
1705 (modest_tny_account_new_from_account):
1706 (recurse_folders): Adjust to the new outbox system.
1708 * src/modest-tny-folder.h:
1709 * src/modest-tny-folder.c:
1710 (modest_tny_folder_is_local_folder),
1711 (modest_tny_folder_get_local_folder_type),
1712 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1714 * src/widgets/modest-main-window.h:
1715 * src/maemo/modest-main-window.c: (create_details_widget),
1716 (modest_main_window_set_contents_style): Show details for any folder store,
1719 (modest_tny_folder_get_rules):
1720 Remove the const. C does not support constness enough for this.
1722 * src/modest-ui-actions.c:
1723 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1724 make all outboxes appear as one, in the usual local-folders tree node.
1726 (set_active_account_from_tny_account),
1727 (modest_ui_actions_on_folder_selection_changed):
1728 * src/widgets/modest-folder-view.c: (text_cell_data),
1729 (icon_cell_data), (filter_row),
1730 (add_account_folders_to_merged_folder),
1731 (add_account_folders_to_simple_folder_store), (),
1732 (get_cmp_rows_type_pos), (cmp_rows),
1733 (modest_folder_view_set_account_id_of_visible_server_account):
1734 Adjust to the new outbox system, using generic folder stores and folders
1735 in the GtkTreeModel.
1737 2007-05-23 Christian Kellner <ckellner@openismus.com>
1739 * src/modest-mail-operation.c:
1740 (modest_mail_operation_update_account):
1741 Use info->max_size instead of unintialized local var [small
1742 build fix]. (Added TODO to review that change since I don't
1745 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1747 * libmodest-dbus-client/libmodest-dbus-client.c:
1748 (libmodest_dbus_client_compose_mail): function added
1749 * src/dbus_api/modest-dbus-api.h:
1750 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1751 (on_compose_mail): Implementation of the SendAsMail functionality
1753 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1755 * src/modest-account-mgr.c:
1756 (modest_account_mgr_add_server_account): Set the secure-connection
1757 conf key for transport accounts as well as store accounts. I don't know
1758 why the if was there. For instance, this makes sure that we use SSL
1759 for the gmail preset from the easysetup wizard.
1761 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1763 * src/gnome/modest-main-window.c:
1764 (on_account_store_connecting_finished), (connect_signals):
1765 * src/maemo/modest-main-window.c:
1766 (on_account_store_connecting_finished), (connect_signals),
1767 (modest_main_window_new):
1768 Handle TnyAccountStore::connecting-finished instead of
1769 TnyDevice::connection-changed, because we cannot actually perform
1770 operations on accounts until TnyAccountStore has itself responded to
1771 the TnyDevice::connection-changed signal. This prevents a GError from
1773 Do not try to update at startup, because we (at least on scratchbox)
1774 already do an update at startup when the device goes online.
1775 This prevents a GError from tinymail.
1776 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1777 Added TODO about stopping simultaneous operations.
1779 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1782 * src/modest-mail-operation-queue.c:
1783 (modest_mail_operation_queue_remove):
1784 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1785 about where they happened.
1787 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1789 * src/modest-ui-actions.c:
1790 (modest_ui_actions_on_password_requested): Make sure that the remember
1791 output parameter is always TRUE.
1793 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1795 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1796 Show a OK/Cancel dialog if the error is a question, though we still do not
1797 know anything more about what we are asking the user.
1798 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1799 Fix an uninitialized variable (helper). This is a logic error, however.
1801 2007-05-21 Christian Kellner <ckellner@openismus.com>
1803 * src/modest-search.h:
1804 Correct bit shifting in the ModestSearchFlags enum.
1806 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-tny-account.c:
1809 (modest_tny_account_new_from_server_account): Do not use the lsub and
1810 check-all hard-coded IMAP options when using POP.
1812 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-tny-account.c:
1815 (modest_tny_account_new_from_server_account):
1816 Use NULL for the secure-auth method for POP when Password auth has been
1817 specified by the user, as we already do for IMAP. "auth=Login" causes
1818 an error from camel or the server.
1820 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1822 * src/maemo/modest-account-settings-dialog.c:
1823 (create_page_account_details),
1824 (modest_account_settings_dialog_set_account_name):
1825 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1826 for the leave-on-server checkbox, rathr than just the checkbox, when
1827 the protocol is not POP.
1829 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1831 * src/widgets/modest-account-view.c:
1832 * src/widgets/modest-account-view.h:
1833 Added modest_account_view_select_account() which will be useful later
1834 to asynchronously re-select the edited account.
1836 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1838 * src/maemo/modest-account-settings-dialog.c:
1839 (modest_account_settings_dialog_set_account_name):
1840 Automatically choose the port numbers based on the secure authentication
1841 methods, if they have not been chosen before.
1842 This fixes projects.maemo.org bug NB#56273 .
1844 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/modest-main-window-ui.h:
1847 * src/modest-ui-actions.c:
1848 * src/modest-ui-actions.h:
1849 Connect the Tools/SMTP Servers menu item to
1850 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1851 SMTP servers dialog, as in the UI specification and saves changes when it
1852 is closed. This fixed projects.maemo.org bug NB#56305 .
1854 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/modest-connection-specific-smtp-window.c:
1857 (modest_connection_specific_smtp_window_init):
1858 Use gtk_window_set_default_size() to make this window big enough, so
1859 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1861 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1864 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1865 (modest_connection_specific_smtp_edit_window_init),
1866 Do not try to connect to a combobox signal before the combobox exists.
1867 This fixes the cras in projects.maemo.org bug NB#56288 .
1868 (modest_connection_specific_smtp_edit_window_get_settings):
1869 Remove the server_account_name parameter which was being checked for NULL
1870 though it was not used.
1872 * src/maemo/modest-connection-specific-smtp-window.c:
1873 (modest_connection_specific_smtp_window_fill_with_connections),
1874 (on_button_edit), (modest_connection_specific_smtp_window_init):
1875 Correct the number of treemodel columns to prevent a warning.
1876 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1877 libconic does not work.
1879 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1881 * src/modest-tny-account.c:
1882 (modest_tny_account_new_from_server_account):
1883 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1884 SMTP when "None" was chosen by the user. However, with my SMTP server that
1885 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1888 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1891 to explain the memory management issue with the ID in the ModestPair.
1893 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1894 (add_sending_page), (modest_account_assistant_finalize):
1895 * src/gnome/modest-gnome-global-settings-dialog.c:
1896 (create_updating_page), (create_composing_page):
1897 * src/gnome/modest-msg-edit-window.c: (get_transports),
1898 (init_window), (modest_msg_edit_window_finalize),
1899 (modest_msg_edit_window_get_msg_data):
1900 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1901 * src/gnome/modest-transport-widget.c:
1902 (modest_transport_widget_finalize), (smtp_configuration):
1903 * src/maemo/modest-maemo-global-settings-dialog.c:
1904 (create_updating_page), (create_composing_page):
1905 * src/maemo/modest-msg-edit-window.c: (get_transports),
1906 (init_window), (modest_msg_edit_window_finalize),
1907 (modest_msg_edit_window_get_msg_data),
1908 (modest_msg_edit_window_free_msg_data):
1909 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1910 (modest_store_widget_finalize):
1911 * src/maemo/modest-transport-widget.c:
1912 (modest_transport_widget_finalize), (smtp_configuration):
1913 * src/modest-main.c: (send_mail):
1914 * src/widgets/modest-combo-box.h:
1915 * src/widgets/modest-global-settings-dialog-priv.h:
1916 * src/widgets/modest-global-settings-dialog.c:
1917 (modest_global_settings_dialog_finalize):
1918 * src/widgets/modest-msg-edit-window.h:
1919 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1920 as long as the combo box, to prevent use of freed memory for the ID.
1922 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1925 get_accounts(), to make this clearer. Do not check for the enabled gconf
1926 key, because we do not use this for server accounts (at least, not yet).
1927 This allows us to send email again.
1929 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1931 * src/maemo/modest-platform.c:
1932 (on_modest_conf_update_interval_changed), (modest_platform_init):
1933 Only respond to this particular key change. All these strcmp()s cannot be
1936 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/modest-maemo-global-settings-dialog.c:
1939 (current_connection): Prevent a crash in scratchbox when
1940 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1941 * src/maemo/modest-platform.c:
1942 (on_modest_conf_update_interval_changed), (modest_platform_init):
1943 Get the update interval from gconf and reset it when the gconf key changes.
1945 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-protocol-info.c:
1948 * src/modest-protocol-info.h: Adde enum-specific get functions,
1949 instead of using a ModestProtocolType enum parameter.
1951 * src/gnome/modest-account-assistant.c:
1952 * src/gnome/modest-store-widget.c:
1953 * src/gnome/modest-store-widget.h:
1954 * src/gnome/modest-transport-widget.c:
1955 * src/gnome/modest-transport-widget.h:
1956 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1957 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1958 * src/maemo/easysetup/modest-easysetup-wizard.c:
1959 * src/maemo/modest-account-settings-dialog.c:
1960 * src/maemo/modest-account-settings-dialog.h:
1961 * src/maemo/modest-store-widget.c:
1962 * src/maemo/modest-store-widget.h:
1963 * src/maemo/modest-transport-widget.c:
1964 * src/maemo/modest-transport-widget.h:
1965 * src/modest-account-mgr-helpers.c:
1966 * src/modest-account-mgr-helpers.h:
1967 * src/modest-account-mgr.c:
1968 * src/modest-account-mgr.h:
1969 * src/modest-tny-account.c:
1970 * src/modest-tny-folder.c:
1971 * src/widgets/modest-account-view.c:
1972 * src/widgets/modest-retrieve-combo-box.c:
1973 * src/widgets/modest-retrieve-combo-box.h:
1974 * src/widgets/modest-secureauth-combo-box.c:
1975 * src/widgets/modest-serversecurity-combo-box.c:
1976 * src/widgets/modest-serversecurity-combo-box.h:
1977 * tests/check_account-mgr.c:
1978 Use the specific functions, and use the re-renamed enum values for GNOME too.
1980 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-pair.h:
1983 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1984 so we can get the second based on the first.
1986 * src/maemo/modest-account-settings-dialog.h:
1987 * src/maemo/modest-account-settings-dialog.c:
1988 Added get_supported_secure_authentication_methods(), though it is mostly
1989 commented-out for now until the necessary API is committed to tinymail.
1990 (modest_account_settings_dialog_set_account_name),
1991 (save_configuration): Request the supported authentication methods from the
1992 server, so we can choose a working method.
1994 * src/modest-tny-account-store.h:
1995 * src/modest-tny-account-store.c:
1996 (modest_tny_account_store_get_session): Rename from
1997 tny_account_store_get_session().
1999 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-protocol-info.h: Split the ModestProtocol enum
2002 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2003 There was no need to have these unrelated values in one enum.
2005 * src/: many files: Adapted to changed enum. This makes the code a bit
2006 clearer, and the compiler could catch some errors.
2008 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2010 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2011 Show the detailed internal camel error message when an error happens
2012 during the configuration, so that our testers can give us more clues.
2013 For instance, in projects.maemo.org bug NB#56910 .
2015 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2017 * src/modest-tny-account.c:
2018 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2019 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2021 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2023 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2024 * src/maemo/modest-account-settings-dialog.c:
2025 (modest_account_settings_dialog_set_account_name),
2026 (save_configuration): For the incoming secure authentication checkbox,
2027 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2028 the UI specification. PLAIN does not seem to be supported for most IMAP
2029 servers anyway, and I am not sure what it would mean.
2030 However, we probably need to discover which of the secure-authentication
2031 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2032 * src/modest-account-mgr-helpers.c:
2033 (modest_account_mgr_get_server_account_data):
2035 * src/modest-tny-account.c:
2036 (modest_tny_account_new_from_server_account):
2037 Use tny_account_set_mech() to set secure-authentication methods,
2038 with some special-casing for IMAP, based on my observations of how
2041 * src/modest-account-mgr-helpers.h:
2042 * src/modest-account-mgr.c:
2043 * src/modest-defs.h: Comment that the URI is only used for local folders.
2045 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2047 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2048 parameter const, just to be neat.
2049 * src/modest-text-utils.c: (modest_text_utils_inline):
2050 End g_strconcat() with NULL, as its documentation says. This is almost
2051 certainly the cause of my crash at startup on the device. Interestingly,
2052 valgrind doesn't tell us about these errors.
2054 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2056 * scripts/build-packages: Added more precise comments about how to use
2057 this script, though I still get this error:
2058 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2059 error building tinymail
2061 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/modest-main-window.c: (on_account_update):
2064 Very slight cleanup, hoping to make it simpler to discover what causes
2065 a crash here sometimes.
2067 * src/modest-tny-account.c:
2068 (modest_tny_account_new_from_server_account): Set the port. Added
2069 comments about the options and a TODO comment because I need to find out
2070 how to specify the secure authentication method.
2072 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2074 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2075 changed CFlags paths form modest to libmodest
2077 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2079 * src/modest-account-mgr-helpers.c:
2080 (modest_account_mgr_get_server_account_data),
2081 (modest_account_mgr_free_server_account_data):
2082 * src/modest-account-mgr-helpers.h:
2083 * src/modest-account-mgr.c:
2084 (modest_account_mgr_add_server_account):
2085 * src/modest-defs.h:
2086 * src/modest-tny-account.c:
2087 (modest_tny_account_new_from_server_account):
2088 Determine the options for tny_camel_account_add_option() here,
2089 based on the settings, rather than storing them directly in gconf.
2091 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2093 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2094 Show a more friendly error dialog now that we expect (from the tinymail
2095 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2097 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/modest-main-window.c: (on_account_update): Check that
2100 account_name is not NULL, to prevent a crash at startup that I am
2101 seeing on the N800. I do wonder why it is NULL.
2103 * src/maemo/easysetup/modest-easysetup-wizard.c:
2104 (create_page_user_details):
2105 * src/maemo/modest-account-settings-dialog.c:
2106 (create_page_user_details), (create_page_outgoing):
2107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2108 (modest_connection_specific_smtp_edit_window_init):
2109 * src/modest-ui-actions.c:
2110 (modest_ui_actions_on_password_requested):
2111 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2112 might do something useful with the on-screen keyboard.
2114 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-main-window.c: (on_account_update):
2117 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2118 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2120 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2122 * src/modest-tny-account-store.c: (on_account_changed):
2123 Correct the signature of this signal handler.
2125 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2127 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2128 Show a HildonNote instead of a GtkDialog for Maemo.
2130 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2132 * src/widgets/modest-account-view.h:
2133 * src/widgets/modest-account-view.c: (on_account_changed),
2134 (on_account_removed). Added a boolean flag, set/unset by
2135 modest_account_view_block_conf_updates(),
2136 modest_account_view_unblock_conf_updates() to prevent unnecessary
2137 updates, but this is not very useful because the gconf notifications are
2138 so delays (maybe only on Maemo Bora).
2139 So auto-updating is turned off, and these functions do an explicit
2140 update when necessary.
2141 However, something else is still doing too much work when adding/removing
2142 accounts, probably in another part of the application.
2144 * src/maemo/modest-account-view-window.c:
2145 (on_delete_button_clicked), (on_edit_button_clicked),
2146 (on_new_button_clicked): Use the new functions.
2148 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-account-mgr-helpers.c:
2151 (modest_account_mgr_set_first_account_as_default):
2152 Sort the list of names alphabetically-by-title, so we choose the first one
2154 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2155 alphabetically by the title.
2157 This fixes projects.maemo.org bug NB#56418 .
2159 * src/modest-account-mgr-priv.c:
2160 (_modest_account_mgr_account_from_key):
2161 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2162 avoid a valgrind error, and possible random behaviour.
2164 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2167 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2168 tinymail documentation to say that this can be expected.
2169 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2170 pretty, and should not happen, but I would prefer to know when it does.
2172 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2174 * configure.ac: When using the older hildon version, probably on Bora,
2175 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2177 * src/widgets/modest-attachment-view.c:
2178 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2181 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2183 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2184 Implemented the prototype. Can be tested with
2185 tests/dbus_api/test_open_message:
2187 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-tny-account-store.c:
2190 (modest_tny_account_store_instance_init), (get_password):
2191 * src/modest-ui-actions.c:
2192 (modest_ui_actions_on_password_requested):
2193 Do not store the password in gconf, because this function is called
2194 for non-remembered passwords. Actually use the cached (in the hash map)
2195 password instead of releasing it.
2196 The password will now not be remembered if it is asked via the protected
2197 password dialog, as per the UI spec.
2199 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2201 * src/modest-defs.h:
2202 * src/modest-account-mgr-helpers.h:
2203 * src/modest-account-mgr-helpers.c:
2204 Added modest_server_account_get_username_has_succeeded(),
2205 modest_server_account_set_username_has_succeeded().
2206 (modest_server_account_set_username),
2207 Reset the has-succeeded flag if the username changes.
2209 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2210 * src/maemo/modest-connection-specific-smtp-window.c:
2211 (modest_connection_specific_smtp_window_save_server_accounts):
2212 Use modest_server_account_set_username() instead of using
2213 modest_conf_set_string() directly, so that the has-succeeded flag is always
2216 * src/modest-ui-actions.c:
2217 (modest_ui_actions_on_password_requested): Dim the username entry if
2218 the username has ever worked, as per the UI spec.
2220 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2222 * src/modest-tny-account-store.c: (get_password):
2223 * src/modest-ui-actions.c:
2224 (modest_ui_actions_on_password_requested):
2225 Allow the username to be changed too, though there is more work to
2226 be done on exactly how this behaves.
2228 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2230 * src/modest-account-mgr-helpers.h:
2231 * src/modest-account-mgr-helpers.c:
2232 Added modest_account_mgr_get_display_name(),
2233 modest_server_account_get_username(),
2234 modest_server_account_set_username(),
2235 modest_server_account_set_password(),
2236 modest_server_account_get_hostname() functions so we do not need to
2237 use the conf API directly.
2239 * src/maemo/modest-main-window.c: (connect_signals):
2240 Actually connect ot the ModestAccountStore::request-password signal,
2241 so that we show the dialog when the password is requested by Tinymail,
2242 for isntance if it is empty.
2244 * src/modest-marshal.list:
2245 * src/modest-tny-account-store.c:
2246 (modest_tny_account_store_class_init), (get_password),
2247 (modest_tny_account_store_alert):
2248 * src/modest-tny-account-store.h:
2249 * src/modest-ui-actions.h:
2250 * src/modest-ui-actions.c:
2251 (modest_ui_actions_on_password_requested):
2252 Change the signal parameters, so it is obvious that we are providing
2253 the non human-readable server name, and receiving both the username
2254 and password, though changing of the username is not yet implemented.
2255 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2256 for the GNOME version.
2258 This should fix the projects.maemo.org bug NB#56209, though it does not
2259 work on Bora, because the gconf_client_get() for the password fails
2260 immediately after we save it with gconf_client_set().
2262 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2265 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2266 caused an undefined symbol error:
2267 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2269 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-tny-account-store.c:
2272 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2273 using a GError instead of a string message, so we can translate it in
2276 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/modest-address-book.c:
2279 (modest_address_book_check_names):
2280 * src/maemo/modest-msg-view-window.c:
2281 (modest_msg_view_window_clipboard_owner_change):
2282 * src/modest-init.c: (modest_init_init_ui):
2283 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2284 (update_folders_cb), (modest_mail_operation_update_account):
2285 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2286 (modest_ui_actions_on_msg_attachment_clicked),
2287 (modest_ui_actions_on_msg_recpt_activated):
2288 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2289 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2290 (modest_msg_view_search_next):
2291 * src/widgets/modest-recpt-editor.c:
2292 (modest_recpt_editor_on_button_release_event),
2293 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2294 g_message(). At this point we should only be seeing interesting errors on
2295 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2297 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2299 (modest_wizard_dialog_force_title_update):
2300 * src/maemo/easysetup/modest-wizard-dialog.h:
2301 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2302 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2303 can update the title when appropriate. Otherwise the title is wrong if the
2304 pages are added after adding the notebook to the dialog.
2305 This must be a problem in HildonWizardDialog too.
2306 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2308 * src/maemo/easysetup/modest-easysetup-wizard.c:
2309 (create_subsequent_customsetup_pages),
2310 (create_subsequent_easysetup_pages):
2311 Call modest_wizard_dialog_force_title_update() so that the title is
2312 correct even with GTK+ < 2.10.
2313 This fixes projects.maemo.org bug NB#56145 .
2315 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2317 * src/maemo/modest-platform.c:
2318 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2319 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2322 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2324 * src/widgets/modest-window.h:
2325 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2326 and modest_window_save_state(), which invokes it.
2328 * src/widgets/modest-window-mgr.h:
2329 * src/widgets/modest-window-mgr.c:
2330 Added modest_window_mgr_save_state_for_all_windows(), which calls
2331 the save_state vfunc on all registered windows, if implemented.
2333 * src/gnome/modest-msg-edit-window.c:
2334 * src/gnome/modest-msg-view-window.c:
2335 * src/maemo/modest-msg-edit-window.c:
2336 * src/maemo/modest-msg-view-window.c:
2337 * src/maemo/modest-main-window.c:
2338 Specify the existing save_settings functions as implementations of
2339 ModestWindow::save_state_func().
2341 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2342 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2343 enabling hibernation, for instance.
2345 We may need to do the same thing for restoring settings.
2348 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2350 * src/widgets/modest-window-mgr.c:
2351 * src/widgets/modest-window-mgr.h:
2352 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2353 modest_window_mgr_get_hibernation_is_prevented().
2355 * src/maemo/modest-main-window.c:
2356 (on_hildon_program_is_topmost_notify): Prevent hibernation
2357 (possible when the application goes to the background in the WM),
2358 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2360 * src/maemo/easysetup/modest-easysetup-wizard.c:
2361 (modest_easysetup_wizard_dialog_init):
2362 * src/maemo/modest-account-settings-dialog.c:
2363 (modest_account_settings_dialog_init):
2364 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2365 (modest_connection_specific_smtp_edit_window_init):
2366 * src/maemo/modest-connection-specific-smtp-window.c:
2367 (modest_connection_specific_smtp_window_init):
2368 * src/maemo/modest-signature-editor-dialog.c:
2369 (modest_signature_editor_dialog_init):
2370 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2371 prevent hibernation while any of these account settings dialogs are open.
2373 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/Makefile.am:
2376 * src/maemo/modest-osso-state-saving.c:
2377 * src/maemo/modest-osso-state-saving.h: Added
2378 modest_osso_load_state() and modest_osso_save_state() though they do
2379 nothing now. They should iterate through all the open windows and load/save
2381 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2382 save state when closing.
2384 * src/maemo/modest-main-window.c:
2385 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2386 Add a notification handler for the HildonProgram::is-topmost property,
2387 so we can allow hibernation when the application goes into the background.
2388 But we still need to detect when the accounts setup windows are open so
2389 we can stop hibernation when they are open.
2390 To do this, I also added the main window the HildonProgram. This might have
2391 other side-effects/benefits, and should maybe be done for other windows.
2393 * src/maemo/modest-osso-autosave-callbacks.h:
2394 * src/maemo/modest-osso-autosave-callbacks.c:
2395 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2396 though it does not do anything yet, and we might never need this to do
2397 anything. For instance, we already save drafts.
2399 * src/maemo/modest-platform.c: (modest_platform_init):
2400 Specify the libosso auto-save callback.
2402 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2404 * src/maemo/modest-platform.c:
2405 (modest_platform_set_update_interval):
2406 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2407 aparently stays valid between application instances, so we can use this
2408 to remove and reset it later. According to a maemo-developers email from
2411 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2413 * configure.ac: Depend on libalarm for Maemo.
2415 * src/dbus_api/modest-dbus-api.h:
2416 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2417 (on_send_receive), (modest_dbus_req_handler):
2418 Handle a SEND_RECEIVE D-Bus method.
2420 * libmodest-dbus-client/libmodest-dbus-client.c:
2421 (libmodest_dbus_client_send_and_receive):
2422 * libmodest-dbus-client/libmodest-dbus-client.h:
2423 Add C convenience functions for calling the new D-Bus method.
2425 * src/modest-platform.h:
2426 * src/gnome/modest-platform.c:
2427 * src/maemo/modest-platform.c:
2428 Added modest_platform_set_update_interval(), which uses the
2429 alarmd API on Maemo.
2430 (modest_platform_init),
2431 Call modest_platform_set_update_interval(), using a hard-coded
2432 interval for now (until the global settings dialog is implemented),
2433 though I am not sure that this makes sense yet.
2435 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2437 * src/dbus_api/modest-dbus-callbacks.c:
2438 (modest_osso_cb_hw_state_handler):
2439 * src/dbus_api/modest-dbus-callbacks.h:
2440 * src/maemo/modest-platform.c: (modest_platform_init):
2441 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2442 in case this has some effect on the ability for Maemo to ping the
2445 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2447 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2448 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2449 warning. It is probably a logic error, but I need to fix the build.
2451 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2453 * src/modest-account-mgr.h:
2454 * src/modest-account-mgr.c:
2455 (modest_account_mgr_account_names): Add a gboolean enabled_only
2456 parameter, so we can get lists of onlt the enabled accounts.
2458 (modest_account_mgr_add_account),,
2459 (modest_account_mgr_account_with_display_name_exists):
2460 * src/maemo/modest-msg-edit-window.c: (get_transports):
2461 * src/modest-account-mgr-helpers.c:
2462 (modest_account_mgr_set_first_account_as_default):
2463 * src/modest-init.c: (init_default_account_maybe):
2464 * src/modest-tny-account-store.c: (get_accounts):
2465 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2466 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2467 * tests/check_account-mgr.c: (START_TEST):
2468 Provide the extra parameter, as appropriate.
2470 * src/widgets/modest-account-view.c: (update_account_view):
2471 Do not show disabled accounts (meaning that there is no way to
2472 enable/disable accounts in the UI (the feature is not in our UI
2473 specification), so we can use this internally only to mark unfinished
2474 or temporary account data.
2476 * src/maemo/easysetup/modest-easysetup-wizard.c:
2477 (create_account): Add boolean enable parameter, so we can specify FALSE
2478 to create the temporary account.
2479 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2480 (on_before_next): When finishing, when there is a temporary account, just
2482 Also, use a timeout to delay the showing of the dialog until gconf is likely
2483 to return correct information, due to a maemo gconf bug that is fixed in
2484 osso 1.1, but not yet in Bora.
2485 However, the dialog stays on screen after it is destroyed.
2487 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2488 for invalid data when cancelling. Use a hildon note instead of a dialog
2489 to complain about invalid data. Do not show the account-saved note if the
2490 account is disabled (a temporary account that will not really be saved for use
2493 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2495 * src/modest-account-mgr-helpers.h:
2496 * src/modest-account-mgr-helpers.c:
2497 Added modest_account_mgr_unset_default_account(),
2498 Added modest_account_mgr_set_first_account_as_default().
2500 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2501 If it was the default account, unset the default account name.
2503 * src/maemo/modest-account-view-window.c:
2504 (on_delete_button_clicked): If it was the default account,
2505 set the first remaining account as the default instead.
2507 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2508 a NULL account or a NULL default account, to prevent a crash. This should
2509 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2512 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2514 * src/widgets/modest-recpt-editor.c:
2515 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2516 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2517 TODO comment for this. This fixes the build.
2519 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2520 be the best place for it. This will in future update all auto-update accounts,
2521 rather than just the current/default account, when that gconf key exists.
2522 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2523 if there are no accounts, before calling do_send_receive().
2524 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2526 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2527 * src/maemo/modest-main-window-ui.h:
2528 * src/maemo/modest-main-window.c: (on_connection_changed),
2529 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2530 directly, becaue the signal handler does more.
2532 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2534 * src/modest-account-mgr-helpers.c:
2535 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2536 for the case that the account does not exist.
2538 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2539 (equivalent to the modest account name) rather than the tinymail account name
2540 (equivalent to the modest account title - human readable) to get the account data.
2541 Check for null account data to prevent the crash, and add a TODO comment saying that
2542 this needs fixing because it is using the server account name instead of the account name.
2544 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2547 * src/maemo/modest-account-settings-dialog.c: (show_error),
2549 Use hildon_note_new_information() for informative and error messages,
2550 which seems to be expected for Maemo applications (no documentation that I know of
2551 says this). I am surprised that there is no distinction between info and error
2554 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2557 it is easy to find where this is used.
2559 * src/maemo/easysetup/modest-easysetup-wizard.c:
2560 (create_page_welcome), (create_page_account_details),
2561 (create_page_user_details), (create_page_complete_easysetup),
2562 (create_page_custom_incoming), (create_page_custom_outgoing),
2563 (create_page_complete_custom):
2564 * src/maemo/modest-account-settings-dialog.c:
2565 (create_page_account_details), (create_page_user_details),
2566 (create_page_incoming), (create_page_outgoing):
2567 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2568 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2569 (modest_connection_specific_smtp_edit_window_init):
2570 * src/maemo/modest-connection-specific-smtp-window.c:
2571 (modest_connection_specific_smtp_window_init):
2572 * src/maemo/modest-signature-editor-dialog.c:
2573 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2574 and scrolling policy as per the Email Application Layout Guide, if I have
2577 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2579 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2580 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2581 which were empty, because these vfuncs have been removed from TnyAccountStore.
2582 This fixes the build.
2584 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/modest-main-window.c:
2587 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2588 showing/hiding it. Added TODO because it probably should not be NULL.
2589 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2590 because unnecessary g_warnings() make degugging difficult.
2592 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2594 * src/maemo/modest-msg-edit-window.c:
2595 (modest_msg_edit_window_select_color),
2596 (modest_msg_edit_window_select_background_color): 2 const corrections and
2597 moving 2 #endifs before closing brackets, to fix the build.
2599 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2601 * src/maemo/easysetup/modest-easysetup-wizard.h:
2602 * src/maemo/easysetup/modest-easysetup-wizard.c:
2603 (modest_easysetup_wizard_dialog_finalize),
2604 (on_button_edit_advanced_settings), (create_page_complete_custom),
2605 (on_response), (create_account):
2606 Implement the Advanced Settings edit button, by saving the account information,
2607 for the Advanded Settings dialog to use directly from gconf, and removing it
2608 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2609 Bug #5533 in the projects.maemo.org bugzilla.
2611 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/modest-msg-view-window.c:
2614 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2615 when opening a message window.
2617 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2619 * src/maemo/easysetup/modest-easysetup-wizard.c:
2620 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2623 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2624 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2625 gconf settings. I probably added more checks than necessary, but that is safer.
2627 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2628 variable to fix the build, but this seems to be used when it is still NULL.
2630 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-platform.h:
2633 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2634 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2635 * src/modest-main.c: Implement this function so we can avoid using
2636 maemo-specific API from cross-platform code.
2638 * src/modest-tny-account-store.c:
2639 (get_smtp_specific_transport_account_for_open_connection):
2640 * src/modest-ui-actions.c: (check_for_connection),
2641 (modest_ui_actions_on_item_not_found):
2642 Use modest_platform_connect_and_wait() and put #idefs around other
2643 maemo-specific code, because only maemo currently has a way to
2644 identify connection names.
2646 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2648 * src/modest-tny-account-store.h:
2649 * src/modest-tny-account-store.c:
2650 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2651 the connection-specific SMTP server settings in the configuration.
2653 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2655 * src/maemo/modest-main-window.c: (on_connection_changed),
2657 * src/modest-main.c: (main), (start_ui), (send_mail):
2658 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2659 that is what is intended.
2661 * src/modest-ui-actions.c: (action_send), (action_receive),
2662 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2663 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2664 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2665 SMTP server is used when it is specified.
2667 (modest_ui_actions_on_send_receive):
2668 Check that a connection is open before proceeding.
2669 Receive and then send, instead of vice-versa, as per the specification.
2671 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-mail-operation.c:
2674 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2675 though I guess it should be something other than NULL.
2677 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/easysetup/modest-easysetup-wizard.c:
2680 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2681 combo twice, to avoid an g_warning and to make it visible again.
2682 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2683 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2684 (already intended) dereference when detaching, because we then recreate the menu.
2685 But I am not sure why the warning was happening, and it is possible that this is a memory
2688 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2690 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2691 and uri_parse_mailto() utility functions.
2692 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2694 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2696 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2698 * src/dbus_api/modest-dbus-api.h:
2699 * src/dbus_api/modest-dbus-callbacks.c:
2700 Use an idle callback to execute the modest code in the application's own thread.
2701 Remove the helloworld example method.
2702 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2703 parsed, and the open-message method is not implemented because this is not yet implemented in
2705 * libmodest-dbus-client/libmodest-dbus-client.c:
2706 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2707 (libmodest_dbus_client_open_message):
2708 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2710 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2711 body without crashing.
2713 * tests/dbus_api/Makefile.am:
2714 * tests/dbus_api/test_mail_to.c:
2715 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2717 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2719 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2720 Added file to fix the build. Sorry.
2722 * src/dbus_api/Makefile.am:
2723 * src/dbus_api/modest-dbus-api.h:
2724 * src/dbus_api/modest-dbus-callbacks.h:
2725 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2726 (modest_dbus_req_handler):
2727 Put constants in a separate header so it can be reused by the
2728 client library, without duplication
2730 * libmodest-dbus-client/Makefile.am:
2731 * libmodest-dbus-client/libmodest-dbus-client.c:
2732 (libmodest_dbus_client_call_helloworld),
2733 (libmodfest_dbus_client_send_mail),
2734 (libmodfest_dbus_client_mailto),
2735 (libmodfest_dbus_client_open_message):
2736 * libmodest-dbus-client/libmodest-dbus-client.h:
2737 (Partly) Implement a send_mail D-Bus method.
2739 * tests/dbus_api/Makefile.am:
2740 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2741 the send_email D-Bus method.
2743 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2747 * libmodest-dbus-client/Makefile.am:
2748 * libmodest-dbus-client/libmodest-dbus-client.c:
2749 * libmodest-dbus-client/libmodest-dbus-client.h:
2750 * tests/dbus_api/Makefile.am:
2751 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2752 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2754 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2756 * src/maemo/easysetup/modest-easysetup-wizard.c:
2757 (create_page_account_details):
2758 * src/maemo/modest-account-settings-dialog.c:
2759 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2760 widgets, because this might not be the default in future versions of the Maemo GTK+.
2761 However, I can not not get capitalization to work even in a simple test case.
2763 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2765 * src/maemo/easysetup/modest-easysetup-wizard.c:
2766 (create_page_custom_incoming), (create_page_custom_outgoing):
2767 * src/maemo/modest-account-settings-dialog.c:
2768 (create_page_account_details), (create_page_incoming),
2769 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2770 instead of using gtk_check_button_with_label(), so they are aligned like the other
2771 widgets, as per the UI spec.
2773 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2775 * src/maemo/easysetup/modest-easysetup-wizard.c:
2776 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2777 * src/widgets/modest-validating-entry.c:
2778 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2779 Modest prefix instead of an EasySetup prefix.
2781 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2783 * src/widgets/modest-validating-entry.h:
2784 * src/widgets/modest-validating-entry.c: (on_insert_text),
2785 Added easysetup_validating_entry_set_max_func(), used to set a callback
2786 to call when the max number of characters is reached. GtkEntry has a max-length
2787 already but is silent about it.
2789 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2790 (create_page_account_details), (create_page_user_details),
2792 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2793 (create_page_account_details), (create_page_user_details),
2794 (create_page_outgoing):
2795 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2796 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2797 the UI spec, when the user tries to enter more than the max number of characters.
2799 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/easysetup/modest-easysetup-wizard.c:
2802 (create_page_user_details), (create_page_custom_incoming),
2803 (create_page_custom_outgoing):
2804 * src/maemo/modest-account-settings-dialog.c:
2805 (create_page_user_details), (create_page_incoming),
2806 (create_page_outgoing):
2807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2808 (modest_connection_specific_smtp_edit_window_init):
2809 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2810 not appropriate. Bad Maemo-specific defaults!.
2812 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2814 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2815 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2816 (modest_signature_editor_dialog_set_settings):
2817 Disable the label and textview when the checkbox is disabled, and use the
2818 specified (UI spec) default signature text.
2820 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2823 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2825 * src/modest-defs.h:
2826 * src/modest-account-mgr-helpers.h:
2827 * src/modest-account-mgr-helpers.c:
2828 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2830 * src/maemo/Makefile.am:
2831 * src/maemo/modest-signature-editor-dialog.c:
2832 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2835 * src/maemo/modest-account-settings-dialog.h:
2836 * src/maemo/modest-account-settings-dialog.c:
2837 (modest_account_settings_dialog_finalize), (on_button_signature),
2838 (save_configuration): Use the new dialog when the Edit button is pressed, and
2839 save the changes if necessary, as per the UI spec.
2841 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2843 * src/maemo/Makefile.am:
2844 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2845 based on maemo-develoers email from Dirk.
2847 * src/maemo/easysetup/modest-easysetup-wizard.c:
2848 (create_page_welcome), (create_page_account_details),
2849 (create_page_user_details), (create_page_complete_easysetup),
2850 (create_page_custom_incoming), (create_page_custom_outgoing),
2851 (create_page_complete_custom),
2852 (modest_easysetup_wizard_dialog_init):
2853 * src/maemo/modest-account-settings-dialog.c:
2854 (create_page_account_details), (create_page_user_details),
2855 (create_page_incoming), (create_page_outgoing),
2856 (modest_account_settings_dialog_init):
2857 * src/maemo/modest-connection-specific-smtp-window.c:
2858 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2860 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2862 * src/maemo/easysetup/modest-easysetup-wizard.c:
2863 (create_page_account_details), (create_page_custom_outgoing),
2864 (create_page_complete_custom):
2865 * src/maemo/modest-account-settings-dialog.c:
2866 (create_page_user_details), (create_page_incoming),
2867 (create_page_outgoing):
2868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2869 (modest_connection_specific_smtp_edit_window_init):
2870 Use the correct (UI spec) port min/max, and use horizontal separators,
2873 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2875 * src/maemo/easysetup/modest-easysetup-wizard.c:
2876 (set_default_custom_servernames):
2877 * src/maemo/modest-account-settings-dialog.c:
2878 (create_page_incoming), (on_combo_outgoing_security_changed),
2879 (on_combo_incoming_security_changed), (create_page_outgoing),
2880 (modest_account_settings_dialog_set_account_name),
2881 (save_configuration):
2882 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2883 (on_combo_security_changed),
2884 (modest_connection_specific_smtp_edit_window_init),
2885 (modest_connection_specific_smtp_edit_window_set_connection),
2886 (modest_connection_specific_smtp_edit_window_get_settings):
2887 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2890 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/easysetup/modest-easysetup-wizard.c:
2894 (create_page_custom_outgoing), (create_page_complete_custom):
2895 * src/maemo/modest-account-settings-dialog.c:
2896 (create_page_user_details), (create_page_outgoing):
2897 * src/maemo/modest-account-view-window.c: (button_box_new):
2898 Use changed logical IDs as per the most recent UI spec:
2899 mcen_bd_emailsetup_edit -> mcen_bd_edit
2900 mcen_bd_emailsetup_delete -> mcen_bd_delete
2901 mcen_bd_emailsetup_close -> mcen_bd_close
2903 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2907 * src/dbus_api/Makefile.am:
2908 * src/dbus_api/modest-dbus-callbacks.c:
2909 * src/dbus_api/modest-dbus-callbacks.h:
2910 * src/maemo/modest-platform.c: (modest_platform_init):
2911 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2913 * tests/Makefile.am:
2914 * tests/dbus_api/Makefile.am:
2915 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2917 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2919 * src/maemo/modest-account-settings-dialog.c:
2920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2921 Removed unnecessary includes.
2923 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2925 * src/maemo/easysetup/modest-easysetup-wizard.c:
2926 * src/maemo/modest-account-settings-dialog.c:
2927 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2928 * src/widgets/Makefile.am:
2929 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2930 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2931 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2932 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2933 * src/widgets/modest-secureauth-combo-box.c:
2934 * src/widgets/modest-secureauth-combo-box.h:
2935 * src/widgets/modest-serversecurity-combo-box.c:
2936 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2937 made the GObject names more consistent with the rest of the Modest code.
2939 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/easysetup/Makefile.am:
2942 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2943 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2944 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2945 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2946 * src/maemo/easysetup/modest-easysetup-wizard.c:
2947 * src/maemo/easysetup/modest-validating-entry.c:
2948 * src/maemo/easysetup/modest-validating-entry.h:
2949 * src/maemo/modest-account-settings-dialog.c:
2950 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2951 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2952 widgets/ because they are used outside of easysetup too. After checking in,
2953 svn will allow me to rename them too.
2955 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2957 * src/gnome/modest-msg-edit-window.c:
2958 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2959 linker error, to fix the build on the GNOME platform.
2960 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2961 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2962 ifdefed out to avoid a warning.
2964 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2966 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2967 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2968 some alternative for GTK+ 2.6.
2970 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2974 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2975 specified for EmailAccountsDialog in UI spec.
2977 * src/maemo/easysetup/modest-easysetup-wizard.c:
2978 * src/maemo/easysetup/modest-easysetup-wizard.h:
2979 * src/maemo/modest-account-settings-dialog.c:
2980 * src/maemo/modest-account-settings-dialog.h:
2981 Reuse a member window widget for the connection-specific SMTP server accounts,
2982 so we can tell it to create/save the accounts only if we actually save changes.
2984 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2986 (modest_connection_specific_smtp_edit_window_get_settings):
2987 Return a struct instance for temporarily remembering the entered data.
2989 * src/maemo/modest-connection-specific-smtp-window.h:
2990 * src/maemo/modest-connection-specific-smtp-window.c:
2991 (modest_connection_specific_smtp_window_finalize),
2992 (modest_connection_specific_smtp_window_fill_with_connections),
2994 (modest_connection_specific_smtp_window_save_server_accounts),
2995 (update_model_server_names): Do not actually save data until asked,
2996 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2998 (on_selection_changed),
2999 (modest_connection_specific_smtp_window_init): Disable the edit
3000 button when nothing is selected.
3002 * src/modest-account-mgr-helpers.c:
3003 * src/modest-account-mgr-helpers.h:
3004 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3007 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3009 * src/modest-account-mgr-helpers.h:
3010 * src/modest-account-mgr-helpers.c:
3011 (modest_account_mgr_get_unused_account_name),
3012 (modest_account_mgr_get_unused_account_display_name): Added these
3013 utility functions, to avoid code duplication.
3015 * src/maemo/easysetup/modest-easysetup-wizard.c:
3016 (create_page_account_details), (create_account):
3017 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3018 (on_combo_security_changed),
3019 (modest_connection_specific_smtp_edit_window_init),
3020 (modest_connection_specific_smtp_edit_window_save_settings):
3021 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3022 * src/maemo/modest-connection-specific-smtp-window.c:
3023 (modest_connection_specific_smtp_window_finalize),
3024 (modest_connection_specific_smtp_window_fill_with_connections),
3025 (on_button_edit), (modest_connection_specific_smtp_window_init):
3026 * src/maemo/modest-connection-specific-smtp-window.h:
3027 Implementing saving of connection-specific server accounts.
3029 But I need to refactor this so we can save the data for each
3030 possible connection-specific account and only actually create the server accounts
3031 when the easysetup finished, or the OK button is pressed on the account settings
3034 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3037 (on_combo_security_changed):
3038 (modest_connection_specific_smtp_edit_window_init):
3039 Auto-fill the port number as in the account settings.
3041 (modest_connection_specific_smtp_edit_window_set_connection):
3042 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3043 * src/maemo/modest-connection-specific-smtp-window.c:
3044 (fill_with_connections), (on_button_edit),
3045 (modest_connection_specific_smtp_window_init):
3046 Turn the edit window into a dialog to simplify the code, and
3047 set a WM hint as in a GtkDialog, because only a popup can be on top of
3048 another window in Maemo, and popups usually have no WM decoration.
3050 * src/modest-defs.h:
3051 * src/modest-account-mgr-helpers.c:
3052 (modest_account_mgr_set_connection_specific_smtp),
3053 (modest_account_mgr_remove_connection_specific_smtp),
3054 (modest_account_mgr_get_connection_specific_smtp):
3055 * src/modest-account-mgr-helpers.h: Some functions to write the
3056 connection-specific SMTP server information. Not yet used.
3059 * src/widgets/modest-folder-view.c: (text_cell_data):
3060 Fix a warning about an uninitialized variable.
3061 (on_configuration_key_changed): Put an #ifdef around the use
3062 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3064 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/modest-account-settings-dialog.h:
3067 * src/maemo/modest-account-settings-dialog.c:
3068 Added connect_for_modified() utility function to mark the new modified boolean.
3070 (create_page_account_details), (create_page_user_details),
3071 (create_page_incoming), (create_page_outgoing), (on_response),
3072 (modest_account_settings_dialog_init),
3073 (modest_account_settings_dialog_set_account_name):
3074 Only warn about unsaved changes when there are actually unsaved changes.
3076 * src/modest-account-mgr-helpers.c:
3077 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3078 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3079 to get the data from there in future.
3081 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3083 * src/modest-defs.h:
3085 * src/modest-account-mgr-helpers.h:
3086 * src/modest-account-mgr-helpers.c:
3087 Store the security account setting in a single conf key instead of using
3088 the options list, so that the list is left for just the to-be-removed camel hack,
3089 and because gconf_client_set_list() is failing for some reason.
3091 * src/modest-account-mgr.c:
3092 (modest_account_mgr_add_server_account):
3093 * src/maemo/modest-account-settings-dialog.c:
3094 (modest_account_settings_dialog_set_account_name),
3095 (save_configuration): Use the renamed functions.
3098 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3100 * src/widgets/Makefile.am:
3101 * src/widgets/modest-limit-retrieve-combo-box.c:
3102 * src/widgets/modest-limit-retrieve-combo-box.h:
3103 * src/widgets/modest-retrieve-combo-box.c:
3104 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3105 the account settings dialog.
3107 * src/modest-defs.h:
3108 * src/modest-account-mgr-helpers.h:
3109 * src/modest-account-mgr-helpers.c:
3110 (modest_server_account_get_option_secure_auth),
3111 (modest_server_account_set_option_secure_auth):
3112 * src/modest-account-mgr.c:
3113 (modest_account_mgr_add_server_account):
3114 Use the existing AUTH_MECH conf key for the secure-auth setting,
3115 instead of putting it in the list options, because this was actually used already.
3117 * src/maemo/modest-account-settings-dialog.c:
3118 (create_page_account_details),
3119 (modest_account_settings_dialog_set_account_name),
3120 (save_configuration):
3121 * src/maemo/modest-account-settings-dialog.h:
3122 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3123 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3125 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3127 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3128 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3129 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3131 * src/modest-defs.h:
3132 * src/maemo/modest-account-settings-dialog.c:
3133 (create_page_incoming), (on_combo_outgoing_security_changed),
3134 (on_combo_incoming_security_changed), (create_page_outgoing),
3135 (modest_account_settings_dialog_set_account_name),
3136 (save_configuration): Load/Save the port number, and change it when the
3137 security combo changes, to suitable defaults.
3139 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3141 * src/modest-account-mgr.c:
3142 (modest_account_mgr_add_server_account): Set the security and secure-auth
3143 options, and add a comment saying that the other camel-specific options should be
3146 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3148 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3150 * src/modest-tny-account-store.c: (account_list_free),
3151 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3152 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3155 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3157 * src/modest-protocol-info.c:
3158 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3159 is required by our UI spec. Maybe something in our implementation will use this eventually.
3160 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3161 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3162 instead of the previous 0 placeholder.
3164 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3165 secure-auth settings.
3166 * src/modest-account-mgr-helpers.h:
3167 * src/modest-account-mgr-helpers.c:
3168 (modest_server_account_data_get_option_secure_auth),
3169 (modest_server_account_set_option_secure_auth),
3170 (modest_server_account_data_get_option_security),
3171 (modest_server_account_set_option_security): Added this API for getting and setting the security
3172 and secure-auth settings.
3174 * src/maemo/modest-account-settings-dialog.h:
3175 * src/maemo/modest-account-settings-dialog.c:
3176 (modest_account_settings_dialog_finalize), (check_data),
3177 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3178 about changing titles.
3179 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3180 (save_configuration): Save the security and secure-auth settings.
3182 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3183 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3185 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3187 * src/modest-defs.h:
3188 * src/modest-account-mgr.c:
3189 (modest_account_mgr_add_server_account):
3190 Added and used defines for the options key and value pair strings,
3191 that are used so far, though they do not seem to correspond to anything in our
3192 UI specs or ModestProtocol enum.
3194 * src/modest-account-mgr-helpers.h:
3195 * src/modest-account-mgr-helpers.c:
3196 (compare_option_strings_for_name),
3197 (modest_server_account_data_get_option_value),
3198 (modest_server_account_data_get_option_bool),
3199 (modest_account_mgr_get_server_account_option):
3200 Added helper functions for parsing the options GSList.
3202 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3204 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3205 display name is based on the supplied account name.
3206 * src/modest-account-mgr.c:
3207 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3208 with an inefficient, but good-enough, implementation.
3210 * src/maemo/easysetup/modest-easysetup-wizard.c:
3211 (create_page_account_details), (on_before_next), (create_account):
3212 Check for existing display names rather than (non-user-visible) account names, and just
3213 create and set a unique account name at the end.
3215 * src/maemo/modest-account-settings-dialog.c:
3216 (modest_account_settings_dialog_init),
3217 (modest_account_settings_dialog_set_account_name),
3218 (create_page_incoming): Show the display name, instead of the account name.
3219 (on_response): Do some (not all) extra checks, as in the UI spec.
3220 (save_configuration): Save the display name if it was changed.
3222 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3224 * po/en_GB.po: Added needed logical ID and translation.
3225 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3226 (init_view): Made the is-default column clicking work.
3228 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/easysetup/Makefile.am:
3232 * src/maemo/easysetup/modest-easysetup-wizard.c:
3233 (modest_easysetup_wizard_dialog_init):
3234 * src/maemo/easysetup/provider-data-test.keyfile:
3235 * src/maemo/easysetup/provider-data.keyfile:
3236 Moved the provider data file to the new modest-providers-data package and used it from there.
3238 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3240 * src/modest-local-folder-info.c:
3241 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3242 N_() was already used on the static strings, but this just marks it for translation without
3243 using the translation.
3245 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3247 * src/maemo/modest-account-settings-dialog.c:
3248 (create_page_incoming),
3249 (modest_account_settings_dialog_set_account_name):
3250 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3251 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3252 I will do this if nobody else gets there first.
3254 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3256 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3257 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3258 save the security stuff.
3260 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3262 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3263 Set the email address and user fullname, which I now see must be
3266 * src/maemo/modest-account-settings-dialog.h:
3267 * src/maemo/modest-account-settings-dialog.c:
3269 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3270 leave-on-server and authentication.
3271 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3274 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3277 * src/maemo/modest-account-settings-dialog.c:
3278 * src/maemo/modest-account-settings-dialog.h:
3279 Most (but not all) of the widgets are now present as specified by the UI spec.
3280 No changes are yet saved, and some details are not properly shown yet.
3282 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3284 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3286 * src/maemo/Makefile.am:
3287 * src/maemo/modest-account-settings-dialog.c:
3288 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3289 an existing account. Doesn't do much yet.
3291 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3292 Open the accounts settings dialog when Edit is clicked.
3294 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/easysetup/Makefile.am:
3297 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3299 * src/maemo/easysetup/modest-easysetup-wizard.c:
3300 (modest_easysetup_wizard_dialog_init):
3301 Try to get the source directory from the build system,
3302 instead of hard-coding "./" into the source code, when opening our local
3303 copies of the configuration files.
3304 But this still fails when opening the wizard from the Accounts window,
3305 maybe because the working directory seems to change at runtime.
3306 So the wizard will fail the second time unless you copy the files into their
3307 proper locations - see the stdout warnings for the paths.
3309 (create_page_account_details),(on_before_next):
3310 Check for existing non-server accounts instead of server accounts,
3311 so the default account name is useful again, and to prevent trying to
3314 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3315 Show the wizard when New is clicked.
3317 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3318 (init_view): Show the column headers, and show the columns that are
3319 specified in the UI specs. However, something in Maemo's GTK+ prevents
3320 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3321 change the default account. This is despite unsetting the special properties.
3323 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3325 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3326 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3327 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3328 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3329 to make that clearer.
3330 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3332 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3334 * src/maemo/modest-account-view-window.c:
3335 (modest_account_view_window_init),
3336 (modest_account_view_window_new):
3337 Use the same buttons as specified in the
3338 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3339 the existing widgets, which never had a chance of working.
3340 Put the ModestAccountView treeview in a scrolled window.
3341 Do not repeat the initialization in both _init() and _new().
3343 * src/widgets/modest-account-view.c: (update_account_view):
3344 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3345 this widget and window shows no accounts.
3347 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3349 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/easysetup/modest-easysetup-wizard.c:
3352 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3353 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3354 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3357 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3358 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3359 accounts exist yet, as in the UI spec.
3361 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3363 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3365 * src/maemo/Makefile.am:
3366 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3367 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3368 New window for editing connection-specific smtp details.
3369 Not fully implemented.
3371 * src/maemo/modest-connection-specific-smtp-window.c:
3372 (modest_connection_specific_smtp_window_finalize) :
3373 unref the tree model.
3374 (on_button_edit): Show the edit window.
3376 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3378 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3381 * src/maemo/Makefile.am:
3382 * src/maemo/modest-connection-specific-smtp-window.c:
3383 * src/maemo/modest-connection-specific-smtp-window.h:
3384 New window for showing the list of connections, for connection-specific
3385 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3386 * src/maemo/easysetup/modest-easysetup-wizard.c:
3387 (create_page_custom_outgoing): Show the new window when the button is clicked.
3389 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3391 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3392 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3393 * src/maemo/modest-msg-edit-window.c:
3394 (modest_msg_edit_window_insert_image):
3395 * src/modest-conf.c: (modest_conf_key_escape):
3396 * src/modest-mail-operation.c:
3397 (modest_mail_operation_send_new_mail):
3398 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3399 (modest_ui_actions_on_new_account):
3400 * src/widgets/modest-attachment-view.c: (update_filename_request):
3401 * src/widgets/modest-mail-header-view.c:
3402 Corrected warnings that were breaking the build, by commenting out unused variables,
3403 and a function, and by including a header.
3405 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3407 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3408 so we can #ifdef around platform-specific code when necessary.
3409 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3410 to allow this to build for the GNOME platform too.
3412 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3414 * src/maemo/easysetup/modest-easysetup-wizard.c:
3415 Added util_increment_name() and used it in create_page_account_details()
3416 to make sure that the default account name is always a new name.
3418 (modest_easysetup_wizard_dialog_init),
3419 (set_default_custom_servernames): Some minor memory management fixes.
3421 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3425 * src/modest-runtime.c: (init_i18n): Restored the translation
3426 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3427 are defined in config.h, and the translations are installed.
3429 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3430 is defined for translation.
3432 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3436 * src/maemo/easysetup/modest-easysetup-wizard.c:
3437 (modest_easysetup_wizard_dialog_init):
3438 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3439 Use realistic paths (though they should use $prefix generically) to the
3440 mcc_mapping and provider-data.keyfile files which might work when they
3441 are installed by the future version of the operator-wizard package,
3442 and then fallback to paths in our source code, with an explanatory
3445 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/Makefile.am:
3450 * src/maemo/easysetup/: Added files from the previously-exernal
3451 osso-modest-easysetup.
3452 * src/maemo/modest-main-window-ui.h:
3453 * src/modest-ui-actions.c:
3454 * src/modest-ui-actions.h:
3455 Added modest_ui_actions_on_new_account() as a signal handler for the
3456 New Account menu item. It shows the easysetup wizard.
3457 * po/en_GB.po: Added additional needed logical IDs and translations.