git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * scripts/build-packages: Added more precise comments about how to use
   4         this script, though I still get this error:
   5         dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
   6         error building tinymail
   7
   8 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
   9
  10         * src/maemo/modest-main-window.c: (on_account_update):
  11         Very slight cleanup, hoping to make it simpler to discover what causes
  12         a crash here sometimes.
  13
  14         * src/modest-tny-account.c:
  15         (modest_tny_account_new_from_server_account): Set the port. Added
  16         comments about the options and a TODO comment because I need to find out
  17         how to specify the secure authentication method.
  18
  19 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
  20
  21         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
  22         changed CFlags paths form modest to libmodest
  23
  24 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  25
  26         * src/modest-account-mgr-helpers.c:
  27         (modest_account_mgr_get_server_account_data),
  28         (modest_account_mgr_free_server_account_data):
  29         * src/modest-account-mgr-helpers.h:
  30         * src/modest-account-mgr.c:
  31         (modest_account_mgr_add_server_account):
  32         * src/modest-defs.h:
  33         * src/modest-tny-account.c:
  34         (modest_tny_account_new_from_server_account):
  35         Determine the options for tny_camel_account_add_option() here,
  36         based on the settings, rather than storing them directly in gconf.
  37
  38 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  39
  40         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  41         Show a more friendly error dialog now that we expect (from the tinymail
  42         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
  43
  44 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  45
  46         * src/maemo/modest-main-window.c: (on_account_update): Check that
  47         account_name is not NULL, to prevent a crash at startup that I am
  48         seeing on the N800. I do wonder why it is NULL.
  49
  50         * src/maemo/easysetup/modest-easysetup-wizard.c:
  51         (create_page_user_details):
  52         * src/maemo/modest-account-settings-dialog.c:
  53         (create_page_user_details), (create_page_outgoing):
  54         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  55         (modest_connection_specific_smtp_edit_window_init):
  56         * src/modest-ui-actions.c:
  57         (modest_ui_actions_on_password_requested):
  58         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
  59         might do something useful with the on-screen keyboard.
  60
  61 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  62
  63         * src/maemo/modest-main-window.c: (on_account_update):
  64         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
  65         NULL, to avoid lots of warnings. However, it probably should not be NULL.
  66
  67 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  68
  69         * src/modest-tny-account-store.c: (on_account_changed):
  70         Correct the signature of this signal handler.
  71
  72 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  73
  74         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  75         Show a HildonNote instead of a GtkDialog for Maemo.
  76
  77 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  78
  79         * src/widgets/modest-account-view.h:
  80         * src/widgets/modest-account-view.c: (on_account_changed),
  81         (on_account_removed). Added a boolean flag, set/unset by
  82         modest_account_view_block_conf_updates(),
  83         modest_account_view_unblock_conf_updates() to prevent unnecessary
  84         updates, but this is not very useful because the gconf notifications are
  85         so delays (maybe only on Maemo Bora).
  86         So auto-updating is turned off, and these functions do an explicit
  87         update when necessary.
  88         However, something else is still doing too much work when adding/removing
  89         accounts, probably in another part of the application.
  90
  91         * src/maemo/modest-account-view-window.c:
  92         (on_delete_button_clicked), (on_edit_button_clicked),
  93         (on_new_button_clicked): Use the new functions.
  94
  95 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  96
  97         * src/modest-account-mgr-helpers.c:
  98         (modest_account_mgr_set_first_account_as_default):
  99         Sort the list of names alphabetically-by-title, so we choose the first one
 100         based on that.
 101         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
 102         alphabetically by the title.
 103
 104         This fixes projects.maemo.org bug NB#56418 .
 105
 106         * src/modest-account-mgr-priv.c:
 107         (_modest_account_mgr_account_from_key):
 108         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
 109         avoid a valgrind error, and possible random behaviour.
 110
 111 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 112
 113         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 114         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
 115         tinymail documentation to say that this can be expected.
 116         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
 117         pretty, and should not happen, but I would prefer to know when it does.
 118
 119 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 120
 121         * configure.ac: When using the older hildon version, probably on Bora,
 122         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 123         to fix the build.
 124         * src/widgets/modest-attachment-view.c:
 125         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 126         build.
 127
 128 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 129
 130         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 131         Implemented the prototype. Can be tested with
 132         tests/dbus_api/test_open_message:
 133
 134 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 135
 136         * src/modest-tny-account-store.c:
 137         (modest_tny_account_store_instance_init), (get_password):
 138         * src/modest-ui-actions.c:
 139         (modest_ui_actions_on_password_requested):
 140         Do not store the password in gconf, because this function is called
 141         for non-remembered passwords. Actually use the cached (in the hash map)
 142         password instead of releasing it.
 143         The password will now not be remembered if it is asked via the protected
 144         password dialog, as per the UI spec.
 145
 146 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 147
 148         * src/modest-defs.h:
 149         * src/modest-account-mgr-helpers.h:
 150         * src/modest-account-mgr-helpers.c:
 151         Added modest_server_account_get_username_has_succeeded(),
 152         modest_server_account_set_username_has_succeeded().
 153         (modest_server_account_set_username),
 154         Reset the has-succeeded flag if the username changes.
 155
 156         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 157         * src/maemo/modest-connection-specific-smtp-window.c:
 158         (modest_connection_specific_smtp_window_save_server_accounts):
 159         Use modest_server_account_set_username() instead of using
 160         modest_conf_set_string() directly, so that the has-succeeded flag is always
 161         reset.
 162
 163         * src/modest-ui-actions.c:
 164         (modest_ui_actions_on_password_requested): Dim the username entry if
 165         the username has ever worked, as per the UI spec.
 166
 167 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * src/modest-tny-account-store.c: (get_password):
 170         * src/modest-ui-actions.c:
 171         (modest_ui_actions_on_password_requested):
 172         Allow the username to be changed too, though there is more work to
 173         be done on exactly how this behaves.
 174
 175 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 176
 177         * src/modest-account-mgr-helpers.h:
 178         * src/modest-account-mgr-helpers.c:
 179         Added modest_account_mgr_get_display_name(),
 180         modest_server_account_get_username(),
 181         modest_server_account_set_username(),
 182         modest_server_account_set_password(),
 183         modest_server_account_get_hostname() functions so we do not need to
 184         use the conf API directly.
 185
 186         * src/maemo/modest-main-window.c: (connect_signals):
 187         Actually connect ot the ModestAccountStore::request-password signal,
 188         so that we show the dialog when the password is requested by Tinymail,
 189         for isntance if it is empty.
 190
 191         * src/modest-marshal.list:
 192         * src/modest-tny-account-store.c:
 193         (modest_tny_account_store_class_init), (get_password),
 194         (modest_tny_account_store_alert):
 195         * src/modest-tny-account-store.h:
 196         * src/modest-ui-actions.h:
 197         * src/modest-ui-actions.c:
 198         (modest_ui_actions_on_password_requested):
 199         Change the signal parameters, so it is obvious that we are providing
 200         the non human-readable server name, and receiving both the username
 201         and password, though changing of the username is not yet implemented.
 202         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 203         for the GNOME version.
 204
 205         This should fix the projects.maemo.org bug NB#56209, though it does not
 206         work on Bora, because the gconf_client_get() for the password fails
 207         immediately after we save it with gconf_client_set().
 208
 209 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 210
 211         * configure.ac:
 212         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 213         caused an undefined symbol error:
 214         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 215
 216 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/modest-tny-account-store.c:
 219         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 220         using a GError instead of a string message, so we can translate it in
 221         Modest.
 222
 223 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 224
 225         * src/maemo/modest-address-book.c:
 226         (modest_address_book_check_names):
 227         * src/maemo/modest-msg-view-window.c:
 228         (modest_msg_view_window_clipboard_owner_change):
 229         * src/modest-init.c: (modest_init_init_ui):
 230         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 231         (update_folders_cb), (modest_mail_operation_update_account):
 232         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 233         (modest_ui_actions_on_msg_attachment_clicked),
 234         (modest_ui_actions_on_msg_recpt_activated):
 235         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 236         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 237         (modest_msg_view_search_next):
 238         * src/widgets/modest-recpt-editor.c:
 239         (modest_recpt_editor_on_button_release_event),
 240         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 241         g_message(). At this point we should only be seeing interesting errors on
 242         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 243
 244 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 245
 246         (modest_wizard_dialog_force_title_update):
 247         * src/maemo/easysetup/modest-wizard-dialog.h:
 248         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 249         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 250         can update the title when appropriate. Otherwise the title is wrong if the
 251         pages are added after adding the notebook to the dialog.
 252         This must be a problem in HildonWizardDialog too.
 253         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 254
 255         * src/maemo/easysetup/modest-easysetup-wizard.c:
 256         (create_subsequent_customsetup_pages),
 257         (create_subsequent_easysetup_pages):
 258         Call modest_wizard_dialog_force_title_update() so that the title is
 259         correct even with GTK+ < 2.10.
 260         This fixes projects.maemo.org bug NB#56145 .
 261
 262 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/maemo/modest-platform.c:
 265         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 266         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 267         from being shown.
 268
 269 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/widgets/modest-window.h:
 272         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 273         and modest_window_save_state(), which invokes it.
 274
 275         * src/widgets/modest-window-mgr.h:
 276         * src/widgets/modest-window-mgr.c:
 277         Added modest_window_mgr_save_state_for_all_windows(), which calls
 278         the save_state vfunc on all registered windows, if implemented.
 279
 280         * src/gnome/modest-msg-edit-window.c:
 281         * src/gnome/modest-msg-view-window.c:
 282         * src/maemo/modest-msg-edit-window.c:
 283         * src/maemo/modest-msg-view-window.c:
 284         * src/maemo/modest-main-window.c:
 285         Specify the existing save_settings functions as implementations of
 286         ModestWindow::save_state_func().
 287
 288         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 289         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 290         enabling hibernation, for instance.
 291
 292         We may need to do the same thing for restoring settings.
 293
 294
 295 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 296
 297         * src/widgets/modest-window-mgr.c:
 298         * src/widgets/modest-window-mgr.h:
 299         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 300         modest_window_mgr_get_hibernation_is_prevented().
 301
 302         * src/maemo/modest-main-window.c:
 303         (on_hildon_program_is_topmost_notify): Prevent hibernation
 304         (possible when the application goes to the background in the WM),
 305         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 306
 307         * src/maemo/easysetup/modest-easysetup-wizard.c:
 308         (modest_easysetup_wizard_dialog_init):
 309         * src/maemo/modest-account-settings-dialog.c:
 310         (modest_account_settings_dialog_init):
 311         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 312         (modest_connection_specific_smtp_edit_window_init):
 313         * src/maemo/modest-connection-specific-smtp-window.c:
 314         (modest_connection_specific_smtp_window_init):
 315         * src/maemo/modest-signature-editor-dialog.c:
 316         (modest_signature_editor_dialog_init):
 317         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 318         prevent hibernation while any of these account settings dialogs are open.
 319
 320 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 321
 322         * src/maemo/Makefile.am:
 323         * src/maemo/modest-osso-state-saving.c:
 324         * src/maemo/modest-osso-state-saving.h: Added
 325         modest_osso_load_state() and modest_osso_save_state() though they do
 326         nothing now. They should iterate through all the open windows and load/save
 327         their state.
 328         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 329         save state when closing.
 330
 331         * src/maemo/modest-main-window.c:
 332         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 333         Add a notification handler for the HildonProgram::is-topmost property,
 334         so we can allow hibernation when the application goes into the background.
 335         But we still need to detect when the accounts setup windows are open so
 336         we can stop hibernation when they are open.
 337         To do this, I also added the main window the HildonProgram. This might have
 338         other side-effects/benefits, and should maybe be done for other windows.
 339
 340         * src/maemo/modest-osso-autosave-callbacks.h:
 341         * src/maemo/modest-osso-autosave-callbacks.c:
 342         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 343         though it does not do anything yet, and we might never need this to do
 344         anything. For instance, we already save drafts.
 345
 346         * src/maemo/modest-platform.c: (modest_platform_init):
 347         Specify the libosso auto-save callback.
 348
 349 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 350
 351         * src/maemo/modest-platform.c:
 352         (modest_platform_set_update_interval):
 353         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 354         aparently stays valid between application instances, so we can use this
 355         to remove and reset it later. According to a maemo-developers email from
 356         David Weinehall.
 357
 358 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 359
 360         * configure.ac: Depend on libalarm for Maemo.
 361
 362         * src/dbus_api/modest-dbus-api.h:
 363         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 364         (on_send_receive), (modest_dbus_req_handler):
 365         Handle a SEND_RECEIVE D-Bus method.
 366
 367         * libmodest-dbus-client/libmodest-dbus-client.c:
 368         (libmodest_dbus_client_send_and_receive):
 369         * libmodest-dbus-client/libmodest-dbus-client.h:
 370         Add C convenience functions for calling the new D-Bus method.
 371
 372         * src/modest-platform.h:
 373         * src/gnome/modest-platform.c:
 374         * src/maemo/modest-platform.c:
 375         Added modest_platform_set_update_interval(), which uses the
 376         alarmd API on Maemo.
 377         (modest_platform_init),
 378         Call modest_platform_set_update_interval(), using a hard-coded
 379         interval for now (until the global settings dialog is implemented),
 380         though I am not sure that this makes sense yet.
 381
 382 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 383
 384         * src/dbus_api/modest-dbus-callbacks.c:
 385         (modest_osso_cb_hw_state_handler):
 386         * src/dbus_api/modest-dbus-callbacks.h:
 387         * src/maemo/modest-platform.c: (modest_platform_init):
 388         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 389         in case this has some effect on the ability for Maemo to ping the
 390         application.
 391
 392 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 393
 394         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 395         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 396         warning. It is probably a logic error, but I need to fix the build.
 397
 398 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 399
 400         * src/modest-account-mgr.h:
 401         * src/modest-account-mgr.c:
 402         (modest_account_mgr_account_names): Add a gboolean enabled_only
 403         parameter, so we can get lists of onlt the enabled accounts.
 404
 405         (modest_account_mgr_add_account),,
 406         (modest_account_mgr_account_with_display_name_exists):
 407         * src/maemo/modest-msg-edit-window.c: (get_transports):
 408         * src/modest-account-mgr-helpers.c:
 409         (modest_account_mgr_set_first_account_as_default):
 410         * src/modest-init.c: (init_default_account_maybe):
 411         * src/modest-tny-account-store.c: (get_accounts):
 412         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 413         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 414         * tests/check_account-mgr.c: (START_TEST):
 415         Provide the extra parameter, as appropriate.
 416
 417         * src/widgets/modest-account-view.c: (update_account_view):
 418         Do not show disabled accounts (meaning that there is no way to
 419         enable/disable accounts in the UI (the feature is not in our UI
 420         specification), so we can use this internally only to mark unfinished
 421         or temporary account data.
 422
 423         * src/maemo/easysetup/modest-easysetup-wizard.c:
 424         (create_account): Add boolean enable parameter, so we can specify FALSE
 425         to create the temporary account.
 426         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 427         (on_before_next): When finishing, when there is a temporary account, just
 428         set it as enabled.
 429         Also, use a timeout to delay the showing of the dialog until gconf is likely
 430         to return correct information, due to a maemo gconf bug that is fixed in
 431         osso 1.1, but not yet in Bora.
 432         However, the dialog stays on screen after it is destroyed.
 433
 434         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 435         for invalid data when cancelling. Use a hildon note instead of a dialog
 436         to complain about invalid data. Do not show the account-saved note if the
 437         account is disabled (a temporary account that will not really be saved for use
 438         until later.)
 439
 440 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 441
 442         * src/modest-account-mgr-helpers.h:
 443         * src/modest-account-mgr-helpers.c:
 444         Added modest_account_mgr_unset_default_account(),
 445         Added modest_account_mgr_set_first_account_as_default().
 446
 447         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 448         If it was the default account, unset the default account name.
 449
 450         * src/maemo/modest-account-view-window.c:
 451         (on_delete_button_clicked): If it was the default account,
 452         set the first remaining account as the default instead.
 453
 454         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 455         a NULL account or a NULL default account, to prevent a crash. This should
 456         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 457
 458
 459 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 460
 461         * src/widgets/modest-recpt-editor.c:
 462         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 463         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 464         TODO comment for this. This fixes the build.
 465
 466         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 467         be the best place for it. This will in future update all auto-update accounts,
 468         rather than just the current/default account, when that gconf key exists.
 469         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 470         if there are no accounts, before calling do_send_receive().
 471         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 472
 473         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 474         * src/maemo/modest-main-window-ui.h:
 475         * src/maemo/modest-main-window.c: (on_connection_changed),
 476         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 477         directly, becaue the signal handler does more.
 478
 479 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 480
 481         * src/modest-account-mgr-helpers.c:
 482         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 483         for the case that the account does not exist.
 484
 485         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 486         (equivalent to the modest account name) rather than the tinymail account name
 487         (equivalent to the modest account title - human readable) to get the account data.
 488         Check for null account data to prevent the crash, and add a TODO comment saying that
 489         this needs fixing because it is using the server account name instead of the account name.
 490
 491 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 492
 493         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 494         * src/maemo/modest-account-settings-dialog.c: (show_error),
 495         (show_ok):
 496         Use hildon_note_new_information() for informative and error messages,
 497         which seems to be expected for Maemo applications (no documentation that I know of
 498         says this). I am surprised that there is no distinction between info and error
 499         dialogs.
 500
 501 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 502
 503         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 504         it is easy to find where this is used.
 505
 506         * src/maemo/easysetup/modest-easysetup-wizard.c:
 507         (create_page_welcome), (create_page_account_details),
 508         (create_page_user_details), (create_page_complete_easysetup),
 509         (create_page_custom_incoming), (create_page_custom_outgoing),
 510         (create_page_complete_custom):
 511         * src/maemo/modest-account-settings-dialog.c:
 512         (create_page_account_details), (create_page_user_details),
 513         (create_page_incoming), (create_page_outgoing):
 514         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 515         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 516         (modest_connection_specific_smtp_edit_window_init):
 517         * src/maemo/modest-connection-specific-smtp-window.c:
 518         (modest_connection_specific_smtp_window_init):
 519         * src/maemo/modest-signature-editor-dialog.c:
 520         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 521         and scrolling policy as per the Email Application Layout Guide, if I have
 522         understood it.
 523
 524 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 527         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 528         which were empty, because these vfuncs have been removed from TnyAccountStore.
 529         This fixes the build.
 530
 531 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 532
 533         * src/maemo/modest-main-window.c:
 534         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 535         showing/hiding it. Added TODO because it probably should not be NULL.
 536         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 537         because unnecessary g_warnings() make degugging difficult.
 538
 539 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 540
 541         * src/maemo/modest-msg-edit-window.c:
 542         (modest_msg_edit_window_select_color),
 543         (modest_msg_edit_window_select_background_color): 2 const corrections and
 544         moving 2 #endifs before closing brackets, to fix the build.
 545
 546 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 547
 548         * src/maemo/easysetup/modest-easysetup-wizard.h:
 549         * src/maemo/easysetup/modest-easysetup-wizard.c:
 550         (modest_easysetup_wizard_dialog_finalize),
 551         (on_button_edit_advanced_settings), (create_page_complete_custom),
 552         (on_response), (create_account):
 553         Implement the Advanced Settings edit button, by saving the account information,
 554         for the Advanded Settings dialog to use directly from gconf, and removing it
 555         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 556         Bug #5533 in the projects.maemo.org bugzilla.
 557
 558 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 559
 560         * src/maemo/modest-msg-view-window.c:
 561         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 562         when opening a message window.
 563
 564 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 565
 566         * src/maemo/easysetup/modest-easysetup-wizard.c:
 567         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 568         match the UI spec.
 569
 570         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 571         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 572         gconf settings. I probably added more checks than necessary, but that is safer.
 573
 574         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 575         variable to fix the build, but this seems to be used when it is still NULL.
 576
 577 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 578
 579         * src/modest-platform.h:
 580         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 581         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 582         * src/modest-main.c: Implement this function so we can avoid using
 583         maemo-specific API from cross-platform code.
 584         (main):
 585         * src/modest-tny-account-store.c:
 586         (get_smtp_specific_transport_account_for_open_connection):
 587         * src/modest-ui-actions.c: (check_for_connection),
 588         (modest_ui_actions_on_item_not_found):
 589         Use modest_platform_connect_and_wait() and put #idefs around other
 590         maemo-specific code, because only maemo currently has a way to
 591         identify connection names.
 592
 593 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 594
 595         * src/modest-tny-account-store.h:
 596         * src/modest-tny-account-store.c:
 597         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 598         the connection-specific SMTP server settings in the configuration.
 599
 600         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 601         (on_idle_mail_to):
 602         * src/maemo/modest-main-window.c: (on_connection_changed),
 603         (connect_signals):
 604         * src/modest-main.c: (main), (start_ui), (send_mail):
 605         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 606         that is what is intended.
 607
 608         * src/modest-ui-actions.c: (action_send), (action_receive),
 609         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 610         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 611         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 612         SMTP server is used when it is specified.
 613
 614         (modest_ui_actions_on_send_receive):
 615         Check that a connection is open before proceeding.
 616         Receive and then send, instead of vice-versa, as per the specification.
 617
 618 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 619
 620         * src/modest-mail-operation.c:
 621         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 622         though I guess it should be something other than NULL.
 623
 624 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 625
 626         * src/maemo/easysetup/modest-easysetup-wizard.c:
 627         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 628         combo twice, to avoid an g_warning and to make it visible again.
 629         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 630         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 631         (already intended) dereference when detaching, because we then recreate the menu.
 632         But I am not sure why the warning was happening, and it is possible that this is a memory
 633         leak.
 634
 635 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 636
 637         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 638         and uri_parse_mailto() utility functions.
 639         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 640         the mailto URI.
 641         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 642
 643 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 644
 645         * src/dbus_api/modest-dbus-api.h:
 646         * src/dbus_api/modest-dbus-callbacks.c:
 647         Use an idle callback to execute the modest code in the application's own thread.
 648         Remove the helloworld example method.
 649         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 650         parsed, and the open-message method is not implemented because this is not yet implemented in
 651         modest itself.
 652         * libmodest-dbus-client/libmodest-dbus-client.c:
 653         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 654         (libmodest_dbus_client_open_message):
 655         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 656
 657         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 658         body without crashing.
 659
 660         * tests/dbus_api/Makefile.am:
 661         * tests/dbus_api/test_mail_to.c:
 662         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 663
 664 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 665
 666         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 667         Added file to fix the build. Sorry.
 668
 669         * src/dbus_api/Makefile.am:
 670         * src/dbus_api/modest-dbus-api.h:
 671         * src/dbus_api/modest-dbus-callbacks.h:
 672         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 673         (modest_dbus_req_handler):
 674         Put constants in a separate header so it can be reused by the
 675         client library, without duplication
 676
 677         * libmodest-dbus-client/Makefile.am:
 678         * libmodest-dbus-client/libmodest-dbus-client.c:
 679         (libmodest_dbus_client_call_helloworld),
 680         (libmodfest_dbus_client_send_mail),
 681         (libmodfest_dbus_client_mailto),
 682         (libmodfest_dbus_client_open_message):
 683         * libmodest-dbus-client/libmodest-dbus-client.h:
 684         (Partly) Implement a send_mail D-Bus method.
 685
 686         * tests/dbus_api/Makefile.am:
 687         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 688         the send_email D-Bus method.
 689
 690 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 691
 692         * Makefile.am:
 693         * configure.ac:
 694         * libmodest-dbus-client/Makefile.am:
 695         * libmodest-dbus-client/libmodest-dbus-client.c:
 696         * libmodest-dbus-client/libmodest-dbus-client.h:
 697         * tests/dbus_api/Makefile.am:
 698         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 699         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 700
 701 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 702
 703         * src/maemo/easysetup/modest-easysetup-wizard.c:
 704         (create_page_account_details):
 705         * src/maemo/modest-account-settings-dialog.c:
 706         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 707         widgets, because this might not be the default in future versions of the Maemo GTK+.
 708         However, I can not not get capitalization to work even in a simple test case.
 709
 710 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 711
 712         * src/maemo/easysetup/modest-easysetup-wizard.c:
 713         (create_page_custom_incoming), (create_page_custom_outgoing):
 714         * src/maemo/modest-account-settings-dialog.c:
 715         (create_page_account_details), (create_page_incoming),
 716         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 717         instead of using gtk_check_button_with_label(), so they are aligned like the other
 718         widgets, as per the UI spec.
 719
 720 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 721
 722         * src/maemo/easysetup/modest-easysetup-wizard.c:
 723         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 724         * src/widgets/modest-validating-entry.c:
 725         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 726         Modest prefix instead of an EasySetup prefix.
 727
 728 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 729
 730         * src/widgets/modest-validating-entry.h:
 731         * src/widgets/modest-validating-entry.c: (on_insert_text),
 732         Added easysetup_validating_entry_set_max_func(), used to set a callback
 733         to call when the max number of characters is reached. GtkEntry has a max-length
 734         already but is silent about it.
 735
 736         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 737         (create_page_account_details), (create_page_user_details),
 738         (create_account):
 739         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 740         (create_page_account_details), (create_page_user_details),
 741         (create_page_outgoing):
 742         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 743         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 744         the UI spec, when the user tries to enter more than the max number of characters.
 745
 746 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 747
 748         * src/maemo/easysetup/modest-easysetup-wizard.c:
 749         (create_page_user_details), (create_page_custom_incoming),
 750         (create_page_custom_outgoing):
 751         * src/maemo/modest-account-settings-dialog.c:
 752         (create_page_user_details), (create_page_incoming),
 753         (create_page_outgoing):
 754         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 755         (modest_connection_specific_smtp_edit_window_init):
 756         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 757         not appropriate. Bad Maemo-specific defaults!.
 758
 759 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 760
 761         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 762         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 763         (modest_signature_editor_dialog_set_settings):
 764         Disable the label and textview when the checkbox is disabled, and use the
 765         specified (UI spec) default signature text.
 766
 767 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 768
 769         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 770         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 771
 772         * src/modest-defs.h:
 773         * src/modest-account-mgr-helpers.h:
 774         * src/modest-account-mgr-helpers.c:
 775         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 776
 777         * src/maemo/Makefile.am:
 778         * src/maemo/modest-signature-editor-dialog.c:
 779         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 780         as per the UI spec.
 781
 782         * src/maemo/modest-account-settings-dialog.h:
 783         * src/maemo/modest-account-settings-dialog.c:
 784         (modest_account_settings_dialog_finalize), (on_button_signature),
 785         (save_configuration): Use the new dialog when the Edit button is pressed, and
 786         save the changes if necessary, as per the UI spec.
 787
 788 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 789
 790         * src/maemo/Makefile.am:
 791         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 792         based on maemo-develoers email from Dirk.
 793
 794         * src/maemo/easysetup/modest-easysetup-wizard.c:
 795         (create_page_welcome), (create_page_account_details),
 796         (create_page_user_details), (create_page_complete_easysetup),
 797         (create_page_custom_incoming), (create_page_custom_outgoing),
 798         (create_page_complete_custom),
 799         (modest_easysetup_wizard_dialog_init):
 800         * src/maemo/modest-account-settings-dialog.c:
 801         (create_page_account_details), (create_page_user_details),
 802         (create_page_incoming), (create_page_outgoing),
 803         (modest_account_settings_dialog_init):
 804         * src/maemo/modest-connection-specific-smtp-window.c:
 805         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 806
 807 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 808
 809         * src/maemo/easysetup/modest-easysetup-wizard.c:
 810         (create_page_account_details), (create_page_custom_outgoing),
 811         (create_page_complete_custom):
 812         * src/maemo/modest-account-settings-dialog.c:
 813         (create_page_user_details), (create_page_incoming),
 814         (create_page_outgoing):
 815         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 816         (modest_connection_specific_smtp_edit_window_init):
 817         Use the correct (UI spec) port min/max, and use horizontal separators,
 818         as per the UI spec.
 819
 820 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 821
 822         * src/maemo/easysetup/modest-easysetup-wizard.c:
 823         (set_default_custom_servernames):
 824         * src/maemo/modest-account-settings-dialog.c:
 825         (create_page_incoming), (on_combo_outgoing_security_changed),
 826         (on_combo_incoming_security_changed), (create_page_outgoing),
 827         (modest_account_settings_dialog_set_account_name),
 828         (save_configuration):
 829         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 830         (on_combo_security_changed),
 831         (modest_connection_specific_smtp_edit_window_init),
 832         (modest_connection_specific_smtp_edit_window_set_connection),
 833         (modest_connection_specific_smtp_edit_window_get_settings):
 834         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 835         as per the UI spec.
 836
 837 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 838
 839         * po/en_GB.po:
 840         * src/maemo/easysetup/modest-easysetup-wizard.c:
 841         (create_page_custom_outgoing), (create_page_complete_custom):
 842         * src/maemo/modest-account-settings-dialog.c:
 843         (create_page_user_details), (create_page_outgoing):
 844         * src/maemo/modest-account-view-window.c: (button_box_new):
 845         Use changed logical IDs as per the most recent UI spec:
 846         mcen_bd_emailsetup_edit -> mcen_bd_edit
 847         mcen_bd_emailsetup_delete -> mcen_bd_delete
 848         mcen_bd_emailsetup_close -> mcen_bd_close
 849
 850 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 851
 852         * configure.ac:
 853         * src/Makefile.am:
 854         * src/dbus_api/Makefile.am:
 855         * src/dbus_api/modest-dbus-callbacks.c:
 856         * src/dbus_api/modest-dbus-callbacks.h:
 857         * src/maemo/modest-platform.c: (modest_platform_init):
 858         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 859         method.
 860         * tests/Makefile.am:
 861         * tests/dbus_api/Makefile.am:
 862         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 863
 864 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 865
 866         * src/maemo/modest-account-settings-dialog.c:
 867         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 868         Removed unnecessary includes.
 869
 870 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 871
 872         * src/maemo/easysetup/modest-easysetup-wizard.c:
 873         * src/maemo/modest-account-settings-dialog.c:
 874         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 875         * src/widgets/Makefile.am:
 876         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 877         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 878         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 879         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 880         * src/widgets/modest-secureauth-combo-box.c:
 881         * src/widgets/modest-secureauth-combo-box.h:
 882         * src/widgets/modest-serversecurity-combo-box.c:
 883         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 884         made the GObject names more consistent with the rest of the Modest code.
 885
 886 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 887
 888         * src/maemo/easysetup/Makefile.am:
 889         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 890         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 891         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 892         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 893         * src/maemo/easysetup/modest-easysetup-wizard.c:
 894         * src/maemo/easysetup/modest-validating-entry.c:
 895         * src/maemo/easysetup/modest-validating-entry.h:
 896         * src/maemo/modest-account-settings-dialog.c:
 897         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 898         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 899         widgets/ because they are used outside of easysetup too. After checking in,
 900         svn will allow me to rename them too.
 901
 902 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 903
 904         * src/gnome/modest-msg-edit-window.c:
 905         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 906         linker error, to fix the build on the GNOME platform.
 907         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 908         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 909         ifdefed out to avoid a warning.
 910
 911 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 912
 913         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 914         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 915         some alternative for GTK+ 2.6.
 916
 917 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 918
 919         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 920
 921         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 922         specified for EmailAccountsDialog in UI spec.
 923
 924         * src/maemo/easysetup/modest-easysetup-wizard.c:
 925         * src/maemo/easysetup/modest-easysetup-wizard.h:
 926         * src/maemo/modest-account-settings-dialog.c:
 927         * src/maemo/modest-account-settings-dialog.h:
 928         Reuse a member window widget for the connection-specific SMTP server accounts,
 929         so we can tell it to create/save the accounts only if we actually save changes.
 930
 931         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 932         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 933         (modest_connection_specific_smtp_edit_window_get_settings):
 934         Return a struct instance for temporarily remembering the entered data.
 935
 936         * src/maemo/modest-connection-specific-smtp-window.h:
 937         * src/maemo/modest-connection-specific-smtp-window.c:
 938         (modest_connection_specific_smtp_window_finalize),
 939         (modest_connection_specific_smtp_window_fill_with_connections),
 940         (on_button_edit),
 941         (modest_connection_specific_smtp_window_save_server_accounts),
 942         (update_model_server_names): Do not actually save data until asked,
 943         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 944
 945         (on_selection_changed),
 946         (modest_connection_specific_smtp_window_init): Disable the edit
 947         button when nothing is selected.
 948
 949         * src/modest-account-mgr-helpers.c:
 950         * src/modest-account-mgr-helpers.h:
 951         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 952         elsewhere.
 953
 954 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 955
 956         * src/modest-account-mgr-helpers.h:
 957         * src/modest-account-mgr-helpers.c:
 958         (modest_account_mgr_get_unused_account_name),
 959         (modest_account_mgr_get_unused_account_display_name): Added these
 960         utility functions, to avoid code duplication.
 961
 962         * src/maemo/easysetup/modest-easysetup-wizard.c:
 963         (create_page_account_details), (create_account):
 964         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 965         (on_combo_security_changed),
 966         (modest_connection_specific_smtp_edit_window_init),
 967         (modest_connection_specific_smtp_edit_window_save_settings):
 968         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 969         * src/maemo/modest-connection-specific-smtp-window.c:
 970         (modest_connection_specific_smtp_window_finalize),
 971         (modest_connection_specific_smtp_window_fill_with_connections),
 972         (on_button_edit), (modest_connection_specific_smtp_window_init):
 973         * src/maemo/modest-connection-specific-smtp-window.h:
 974         Implementing saving of connection-specific server accounts.
 975
 976         But I need to refactor this so we can save the data for each
 977         possible connection-specific account and only actually create the server accounts
 978         when the easysetup finished, or the OK button is pressed on the account settings
 979         dialog.
 980
 981 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 982
 983         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 984         (on_combo_security_changed):
 985         (modest_connection_specific_smtp_edit_window_init):
 986         Auto-fill the port number as in the account settings.
 987
 988         (modest_connection_specific_smtp_edit_window_set_connection):
 989         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 990         * src/maemo/modest-connection-specific-smtp-window.c:
 991         (fill_with_connections), (on_button_edit),
 992         (modest_connection_specific_smtp_window_init):
 993         Turn the edit window into a dialog to simplify the code, and
 994         set a WM hint as in a GtkDialog, because only a popup can be on top of
 995         another window in Maemo, and popups usually have no WM decoration.
 996
 997         * src/modest-defs.h:
 998         * src/modest-account-mgr-helpers.c:
 999         (modest_account_mgr_set_connection_specific_smtp),
1000         (modest_account_mgr_remove_connection_specific_smtp),
1001         (modest_account_mgr_get_connection_specific_smtp):
1002         * src/modest-account-mgr-helpers.h: Some functions to write the
1003         connection-specific SMTP server information. Not yet used.
1004
1005
1006         * src/widgets/modest-folder-view.c: (text_cell_data):
1007         Fix a warning about an uninitialized variable.
1008         (on_configuration_key_changed): Put an #ifdef around the use
1009         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1010
1011 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1012
1013         * src/maemo/modest-account-settings-dialog.h:
1014         * src/maemo/modest-account-settings-dialog.c:
1015         Added connect_for_modified() utility function to mark the new modified boolean.
1016
1017         (create_page_account_details), (create_page_user_details),
1018         (create_page_incoming), (create_page_outgoing), (on_response),
1019         (modest_account_settings_dialog_init),
1020         (modest_account_settings_dialog_set_account_name):
1021         Only warn about unsaved changes when there are actually unsaved changes.
1022
1023         * src/modest-account-mgr-helpers.c:
1024         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1025         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1026         to get the data from there in future.
1027
1028 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1029
1030         * src/modest-defs.h:
1031
1032         * src/modest-account-mgr-helpers.h:
1033         * src/modest-account-mgr-helpers.c:
1034         Store the security account setting in a single conf key instead of using
1035         the options list, so that the list is left for just the to-be-removed camel hack,
1036         and because gconf_client_set_list() is failing for some reason.
1037
1038         * src/modest-account-mgr.c:
1039         (modest_account_mgr_add_server_account):
1040         * src/maemo/modest-account-settings-dialog.c:
1041         (modest_account_settings_dialog_set_account_name),
1042         (save_configuration): Use the renamed functions.
1043
1044
1045 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1046
1047         * src/widgets/Makefile.am:
1048         * src/widgets/modest-limit-retrieve-combo-box.c:
1049         * src/widgets/modest-limit-retrieve-combo-box.h:
1050         * src/widgets/modest-retrieve-combo-box.c:
1051         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1052         the account settings dialog.
1053
1054         * src/modest-defs.h:
1055         * src/modest-account-mgr-helpers.h:
1056         * src/modest-account-mgr-helpers.c:
1057         (modest_server_account_get_option_secure_auth),
1058         (modest_server_account_set_option_secure_auth):
1059         * src/modest-account-mgr.c:
1060         (modest_account_mgr_add_server_account):
1061         Use the existing AUTH_MECH conf key for the secure-auth setting,
1062         instead of putting it in the list options, because this was actually used already.
1063
1064         * src/maemo/modest-account-settings-dialog.c:
1065         (create_page_account_details),
1066         (modest_account_settings_dialog_set_account_name),
1067         (save_configuration):
1068         * src/maemo/modest-account-settings-dialog.h:
1069         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1070         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1071
1072 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1073
1074         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1075         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1076         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1077
1078         * src/modest-defs.h:
1079         * src/maemo/modest-account-settings-dialog.c:
1080         (create_page_incoming), (on_combo_outgoing_security_changed),
1081         (on_combo_incoming_security_changed), (create_page_outgoing),
1082         (modest_account_settings_dialog_set_account_name),
1083         (save_configuration): Load/Save the port number, and change it when the
1084         security combo changes, to suitable defaults.
1085
1086 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1087
1088         * src/modest-account-mgr.c:
1089         (modest_account_mgr_add_server_account): Set the security and secure-auth
1090         options, and add a comment saying that the other camel-specific options should be
1091         removed in future.
1092
1093 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1094
1095         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1096         found by valgrind.
1097         * src/modest-tny-account-store.c: (account_list_free),
1098         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1099         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1100         easy to fix.
1101
1102 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1103
1104         * src/modest-protocol-info.c:
1105         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1106         is required by our UI spec. Maybe something in our implementation will use this eventually.
1107         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1108         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1109         instead of the previous 0 placeholder.
1110
1111         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1112         secure-auth settings.
1113         * src/modest-account-mgr-helpers.h:
1114         * src/modest-account-mgr-helpers.c:
1115         (modest_server_account_data_get_option_secure_auth),
1116         (modest_server_account_set_option_secure_auth),
1117         (modest_server_account_data_get_option_security),
1118         (modest_server_account_set_option_security): Added this API for getting and setting the security
1119         and secure-auth settings.
1120
1121         * src/maemo/modest-account-settings-dialog.h:
1122         * src/maemo/modest-account-settings-dialog.c:
1123         (modest_account_settings_dialog_finalize), (check_data),
1124         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1125         about changing titles.
1126         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1127         (save_configuration): Save the security and secure-auth settings.
1128
1129         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1130         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1131
1132 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1133
1134         * src/modest-defs.h:
1135         * src/modest-account-mgr.c:
1136         (modest_account_mgr_add_server_account):
1137         Added and used defines for the options key and value pair strings,
1138         that are used so far, though they do not seem to correspond to anything in our
1139         UI specs or ModestProtocol enum.
1140
1141         * src/modest-account-mgr-helpers.h:
1142         * src/modest-account-mgr-helpers.c:
1143         (compare_option_strings_for_name),
1144         (modest_server_account_data_get_option_value),
1145         (modest_server_account_data_get_option_bool),
1146         (modest_account_mgr_get_server_account_option):
1147         Added helper functions for parsing the options GSList.
1148
1149 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1150
1151         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1152         display name is based on the supplied account name.
1153         * src/modest-account-mgr.c:
1154         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1155         with an inefficient, but good-enough, implementation.
1156
1157         * src/maemo/easysetup/modest-easysetup-wizard.c:
1158         (create_page_account_details), (on_before_next), (create_account):
1159         Check for existing display names rather than (non-user-visible) account names, and just
1160         create and set a unique account name at the end.
1161
1162         * src/maemo/modest-account-settings-dialog.c:
1163         (modest_account_settings_dialog_init),
1164         (modest_account_settings_dialog_set_account_name),
1165         (create_page_incoming): Show the display name, instead of the account name.
1166         (on_response): Do some (not all) extra checks, as in the UI spec.
1167         (save_configuration): Save the display name if it was changed.
1168
1169 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1170
1171         * po/en_GB.po: Added needed logical ID and translation.
1172         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1173         (init_view): Made the is-default column clicking work.
1174
1175 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1176
1177         * configure.ac:
1178         * src/maemo/easysetup/Makefile.am:
1179         * src/maemo/easysetup/modest-easysetup-wizard.c:
1180         (modest_easysetup_wizard_dialog_init):
1181         * src/maemo/easysetup/provider-data-test.keyfile:
1182         * src/maemo/easysetup/provider-data.keyfile:
1183         Moved the provider data file to the new modest-providers-data package and used it from there.
1184
1185 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1186
1187         * src/modest-local-folder-info.c:
1188         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1189         N_() was already used on the static strings, but this just marks it for translation without
1190         using the translation.
1191
1192 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1193
1194         * src/maemo/modest-account-settings-dialog.c:
1195         (create_page_incoming),
1196         (modest_account_settings_dialog_set_account_name):
1197         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1198         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1199         I will do this if nobody else gets there first.
1200
1201 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1202
1203         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1204         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1205         save the security stuff.
1206
1207 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1208
1209         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1210         Set the email address and user fullname, which I now see must be
1211         done separately.
1212
1213         * src/maemo/modest-account-settings-dialog.h:
1214         * src/maemo/modest-account-settings-dialog.c:
1215          (on_response),
1216         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1217         leave-on-server and authentication.
1218         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1219         how to do the rest.
1220
1221 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1222
1223
1224         * src/maemo/modest-account-settings-dialog.c:
1225         * src/maemo/modest-account-settings-dialog.h:
1226         Most (but not all) of the widgets are now present as specified by the UI spec.
1227         No changes are yet saved, and some details are not properly shown yet.
1228
1229         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1230
1231 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1232
1233         * src/maemo/Makefile.am:
1234         * src/maemo/modest-account-settings-dialog.c:
1235         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1236         an existing account. Doesn't do much yet.
1237
1238         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1239         Open the accounts settings dialog when Edit is clicked.
1240
1241 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1242
1243         * src/maemo/easysetup/Makefile.am:
1244         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1245         (load_from_file):
1246         * src/maemo/easysetup/modest-easysetup-wizard.c:
1247         (modest_easysetup_wizard_dialog_init):
1248         Try to get the source directory from the build system,
1249         instead of hard-coding "./" into the source code, when opening our local
1250         copies of the configuration files.
1251         But this still fails when opening the wizard from the Accounts window,
1252         maybe because the working directory seems to change at runtime.
1253         So the wizard will fail the second time unless you copy the files into their
1254         proper locations - see the stdout warnings for the paths.
1255
1256         (create_page_account_details),(on_before_next):
1257         Check for existing non-server accounts instead of server accounts,
1258         so the default account name is useful again, and to prevent trying to
1259         recreate accounts.
1260
1261         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1262         Show the wizard when New is clicked.
1263
1264         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1265         (init_view): Show the column headers, and show the columns that are
1266         specified in the UI specs. However, something in Maemo's GTK+ prevents
1267         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1268         change the default account. This is despite unsetting the special properties.
1269
1270 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1271
1272         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1273         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1274         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1275         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1276         to make that clearer.
1277         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1278
1279 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1280
1281         * src/maemo/modest-account-view-window.c:
1282         (modest_account_view_window_init),
1283         (modest_account_view_window_new):
1284         Use the same buttons as specified in the
1285         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1286         the existing widgets, which never had a chance of working.
1287         Put the ModestAccountView treeview in a scrolled window.
1288         Do not repeat the initialization in both _init() and _new().
1289
1290         * src/widgets/modest-account-view.c: (update_account_view):
1291         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1292         this widget and window shows no accounts.
1293
1294         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1295
1296 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1297
1298         * src/maemo/easysetup/modest-easysetup-wizard.c:
1299         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1300         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1301         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1302         which seems wrong.
1303
1304         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1305         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1306         accounts exist yet, as in the UI spec.
1307
1308         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1309
1310 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1311
1312         * src/maemo/Makefile.am:
1313         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1314         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1315         New window for editing connection-specific smtp details.
1316         Not fully implemented.
1317
1318         * src/maemo/modest-connection-specific-smtp-window.c:
1319         (modest_connection_specific_smtp_window_finalize) :
1320         unref the tree model.
1321         (on_button_edit): Show the edit window.
1322
1323 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1324
1325         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1326         error for me.
1327
1328         * src/maemo/Makefile.am:
1329         * src/maemo/modest-connection-specific-smtp-window.c:
1330         * src/maemo/modest-connection-specific-smtp-window.h:
1331         New window for showing the list of connections, for connection-specific
1332         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1333         * src/maemo/easysetup/modest-easysetup-wizard.c:
1334         (create_page_custom_outgoing): Show the new window when the button is clicked.
1335
1336 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1337
1338         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1339         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1340         * src/maemo/modest-msg-edit-window.c:
1341         (modest_msg_edit_window_insert_image):
1342         * src/modest-conf.c: (modest_conf_key_escape):
1343         * src/modest-mail-operation.c:
1344         (modest_mail_operation_send_new_mail):
1345         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1346         (modest_ui_actions_on_new_account):
1347         * src/widgets/modest-attachment-view.c: (update_filename_request):
1348         * src/widgets/modest-mail-header-view.c:
1349         Corrected warnings that were breaking the build, by commenting out unused variables,
1350         and a function, and by including a header.
1351
1352 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1353
1354         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1355         so we can #ifdef around platform-specific code when necessary.
1356         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1357         to allow this to build for the GNOME platform too.
1358
1359 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1360
1361         * src/maemo/easysetup/modest-easysetup-wizard.c:
1362         Added util_increment_name() and used it in create_page_account_details()
1363         to make sure that the default account name is always a new name.
1364
1365         (modest_easysetup_wizard_dialog_init),
1366         (set_default_custom_servernames): Some minor memory management fixes.
1367
1368 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1369
1370         * Makefile.am:
1371         * configure.ac:
1372         * src/modest-runtime.c: (init_i18n): Restored the translation
1373         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1374         are defined in config.h, and the translations are installed.
1375
1376         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1377         is defined for translation.
1378
1379 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1380
1381         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1382         (load_from_file):
1383         * src/maemo/easysetup/modest-easysetup-wizard.c:
1384         (modest_easysetup_wizard_dialog_init):
1385         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1386         Use realistic paths (though they should use $prefix generically) to the
1387         mcc_mapping and provider-data.keyfile files which might work when they
1388         are installed by the future version of the operator-wizard package,
1389         and then fallback to paths in our source code, with an explanatory
1390         warning.
1391
1392 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1393
1394         * configure.ac:
1395         * src/Makefile.am:
1396         * src/maemo/Makefile.am:
1397         * src/maemo/easysetup/: Added files from the previously-exernal
1398         osso-modest-easysetup.
1399         * src/maemo/modest-main-window-ui.h:
1400         * src/modest-ui-actions.c:
1401         * src/modest-ui-actions.h:
1402         Added modest_ui_actions_on_new_account() as a signal handler for the
1403         New Account menu item. It shows the easysetup wizard.
1404         * po/en_GB.po: Added additional needed logical IDs and translations.
1405
1406 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1407 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1408