1 2007-06-13 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4 Revert the use of the display name as the account name, because this
5 is generally wrong and would break the code that follows.
7 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c:
10 (check_for_supported_auth_methods), (on_before_next),
13 More correct fix for projects.maemo.org bug NB# 58991
14 Do not longer accept AUTH_PASSWORD as secure method and choose
15 correct method when creating the account.
17 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
19 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
20 Fixed projects.maemo.org bug NB# 58991
22 2007-06-13 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-init.c: (modest_init_init_core),
25 (modest_init_local_folders): Fixed compilation errors.
27 2007-06-13 Murray Cumming <murrayc@murrayc.com>
29 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
30 Remove unnecessary lib/include, though it is good in principle when needed.
32 * src/modest-init.c: (modest_init_one_local_folder),
33 (modest_init_local_folders):
34 * src/modest-init.h: Initialize the .modest library for memory cards,
35 instead of just doing nothing for them. This should allow us to create
36 folders there, fixing projects.maemo.org bug NB#59297.
38 2007-06-13 Murray Cumming <murrayc@murrayc.com>
40 * libmodest-dbus-client/libmodest-dbus-client.c:
41 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
42 (libmodest_dbus_client_compose_mail),
43 (libmodest_dbus_client_open_message),
44 (libmodest_dbus_client_send_and_receive),
45 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
47 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
48 (on_idle_open_message), (modest_dbus_req_handler),
49 (search_result_to_message), (modest_dbus_req_filter):
50 * src/modest-search.c: (add_hit), (modest_search_folder),
51 (modest_search_all_accounts): Improved debug messages.
53 * tests/dbus_api/test_open_message.c: (main): Improved comments.
55 * src/modest-tny-account-store.c:
56 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
59 2007-06-13 Murray Cumming <murrayc@murrayc.com>
62 2007-06-12 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account-store.c: (get_server_accounts):
65 Call modest_tny_local_folders_account_add_merged_outbox_folders()
66 even when there are no accounts, so that the Outbox folder is always
67 visible. This fixes projects.maemo.org bug NB#60158.
69 2007-06-12 Murray Cumming <murrayc@murrayc.com>
71 * src/maemo/modest-main-window.c: (create_details_widget):
72 Use the mcen_va_never logical ID.
74 2007-06-12 Murray Cumming <murrayc@murrayc.com>
76 * src/dbus_api/modest-dbus-api.h:
77 * src/dbus_api/modest-dbus-callbacks.c:
78 (on_idle_open_default_inbox), (on_open_default_inbox),
79 (modest_dbus_req_handler):
80 Added a new OpenDefaultInbox method.
82 * libmodest-dbus-client/libmodest-dbus-client.h:
83 * libmodest-dbus-client/libmodest-dbus-client.c:
84 Added libmodest_dbus_client_open_default_inbox() to call the new
85 dbus method. This should be useful to projects.maemo.org bug NB#57214,
86 though it should maybe be used by a new osso-email-interface function.
88 * tests/dbus_api/Makefile.am:
89 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
92 2007-06-12 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
95 NULL, so that the signals get all the keys. This should not actually
96 change any behaviour because we currently update everything when anything
99 2007-06-12 Murray Cumming <murrayc@murrayc.com>
101 * src/widgets/modest-folder-view.c: (text_cell_data),
102 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
103 (find_inbox_iter): If tinymail tells us that the folder is
104 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
105 This causes the inbox to be selected at startup, fixing part of
106 projects.maemo.org bug NB#56305.
108 * src/modest-ui-dimming-rules.c:
109 (modest_ui_dimming_rules_on_tools_smtp_servers):
110 * src/modest-ui-dimming-rules.h: Added a callback function to dim
111 the SMTP servers menu item.
112 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
113 that the SMTP Servers menu item is dimmed when there are no accounts,
114 as a future version of the UI spec will require. This fixes
115 projects.maemo.org bug NB#56305.
117 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
119 * src/maemo/modest-maemo-utils.c:
120 (modest_maemo_utils_get_supported_secure_authentication_methods):
121 Added label to dialog instead of unreadable title
123 * src/maemo/modest-main-window.c: (sync_accounts_cb),
124 (modest_main_window_new):
125 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
128 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
129 * src/modest-account-mgr.h:
130 Added method to avoid code duplication
132 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
133 (modest_ui_actions_on_send_receive):
134 Use modest_account_mgr_has_accounts
136 2007-06-11 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/easysetup/modest-presets.c:
139 (modest_presets_get_info_server_security): Do not report secure auth
141 * src/modest-protocol-info.c: Use the defines for the gconf key names
142 for secure authentication. This was not working because we were writing
143 Password and reading password, and the check was case sensitive.
144 With this, gmail now works for receiving and sending when created via
147 2007-06-11 Murray Cumming <murrayc@murrayc.com>
149 * src/maemo/easysetup/modest-presets.c:
150 (modest_presets_get_info_server_security): Correct the key name for
151 SecureSmtp, because it seems to be case-sensitive.
152 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
153 Do not try to get the 0th notebook page if there are 0 pages, to
156 2007-06-11 Murray Cumming <murrayc@murrayc.com>
158 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
159 Prevent use of the new notification feature for now, because it currently
160 shows one dialog for each new email, which is annoying.
162 2007-06-11 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
165 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
166 when no country was selected, so that we show the global ones.
167 * src/maemo/easysetup/modest-presets.c:
168 (modest_presets_get_providers): Return only the global providers, not
169 all providers when mmc=0 was requested.
171 2007-06-11 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
174 (easysetup_provider_combo_box_fill): Remove debug code that showed the
175 provider ID in the combo.
177 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
178 Do not show the page numbers, because it would be confusing when we add
179 the 2 extra pages for the custom setup, when the user chooses the "Other"
180 provider. This fixes projects.maemo.org bug NB#59028
182 * src/modest-init.c: (modest_init_init_core),
183 (modest_init_local_folders):
185 * src/modest-tny-account.c:
186 (modest_tny_account_new_for_local_folders): Do not create default folders
187 for the memory card. This should fix projects.maemo.org bug NB#59328.
189 2007-06-11 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
192 Free the changed_conf_keys string items. They are already freed in the
193 idle handler if that runs first.
195 2007-06-11 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-ui-actions.c:
198 (modest_ui_actions_on_password_requested): Check that the server name
199 is not NULL, because I just saw a password dialog with (null) as the
202 * src/modest-tny-folder.[h|c]: Added
203 modest_tny_folder_is_memory_card_folder().
204 * src/modest-ui-dimming-rules.c:
205 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
206 menu item for memory cards, as per the UI spec (section 7.4). This should
207 fix projects.maemo.org bug NB#59297.
209 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
211 * src/maemo/modest-main-window.c: (sync_accounts_cb):
212 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
213 is another problem with the code, see Murray's comment at line 772)
215 2007-06-08 Murray Cumming <murrayc@murrayc.com>
217 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
218 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
219 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
220 (load_from_file), (easysetup_country_combo_box_init),
221 (easysetup_country_combo_box_get_active_country_ids),
222 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
223 instead of just one ID, to avoid duplicate country names in the UI.
225 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
226 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
227 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
228 a single ID, avoiding duplicate providers.
229 * src/maemo/easysetup/modest-easysetup-wizard.c:
230 (on_combo_account_country): Adapt to use a list.
232 2007-06-08 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
235 keys changed in the last X seconds.
237 * src/modest-account-mgr.h:
238 * src/modest-account-mgr.c: (on_timeout_notify_changes),
239 (on_key_change), (modest_account_mgr_class_init),
240 (modest_account_mgr_init), (modest_account_mgr_finalize):
241 As the keys are changed, save them in a GSList* and signal that GSList*
242 further every X seconds, to batch changes, to allow us to do just one
243 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
244 bug NB#56941 and other (UI-blocking) delays when changing account settings.
246 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
247 changed signal signature.
249 * src/modest-conf.c: (modest_conf_set_list),
250 (modest_conf_on_change): Reenable notification.
252 (modest_conf_maemo_fake_on_change): Comment out the hack that
253 notified immediately instead of asynchronously.
255 * src/widgets/modest-account-view.h:
256 * src/widgets/modest-account-view.c:
257 (update_account_view): Select the previously-selected account ID,
258 if possible. This fixes projects.maemo.org bug NB#56933.
260 (on_account_changed), (on_account_removed),
261 (modest_account_view_select_account):
263 Remove the block/unblock functions
264 because they were not useful.
266 * src/maemo/modest-account-view-window.c:
267 (on_delete_button_clicked), (on_edit_button_clicked),
268 (on_new_button_clicked): Remove the use of the non-working block/unblock.
270 2007-06-08 Murray Cumming <murrayc@murrayc.com>
272 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
273 Improve the error dialog to show Incorrect Account Settings, which seems
274 clearer, and say that the internal error message (to be removed from the
275 dialog later) is often misleading.
276 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
278 * src/modest-tny-account.c:
279 (modest_tny_account_new_from_server_account): Uncomment the printf of the
280 URL because this is so useful for debugging on the device.
282 * src/widgets/modest-serversecurity-combo-box.c:
283 (modest_serversecurity_combo_box_fill): Correct a logical ID.
285 2007-06-08 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-mail-operation.c:
288 (modest_mail_operation_send_new_mail):
289 Added a comment about a nasty but apparently harmless message. Details
290 added to the wiki g_warnings() page.
292 2007-06-08 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
295 (modest_tny_send_queue_class_init):
296 Do not use the priv struct because it is empty, to avoid g_warnings
297 about a non-existant priv struct.
299 * src/modest-tny-account-store.c:
300 (modest_tny_account_store_get_server_account),
301 (modest_tny_account_store_get_transport_account_for_open_connection
302 ): Do not try to get transport server accounts for local folders,
303 because they don't have any. This avoids a g_warning().
305 * src/maemo/modest-main-window.c:
306 (modest_main_window_notify_send_receive_initied),
307 (on_configuration_key_changed):
308 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
310 * src/modest-mail-operation.c:
311 (modest_mail_operation_update_account):
312 * src/modest-tny-account-store.h:
313 * src/modest-tny-account.c:
314 (modest_tny_account_get_special_folder),
315 (modest_tny_account_new_for_local_folders),
316 (modest_tny_account_new_for_per_account_local_outbox_folder):
317 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
318 * src/modest-tny-local-folders-account.c:
319 (add_account_folders_to_merged_folder):
320 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
321 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
322 (modest_ui_actions_on_send):
323 * src/widgets/modest-folder-view.c: (update_model):
324 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
325 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
326 modest_tny_account_store_get_tny_account_by_account() to
327 modest_tny_account_store_get_server_account() to make the code clearer.
329 2007-06-07 Marcus Bauer <marcusb@openismus.com>
331 * src/dbus_api/modest-dbus-api.h:
332 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
333 * src/maemo/modest-msg-edit-window.c:
334 (modest_msg_edit_window_attach_file_noninteractive):
335 added g_warning in case the file to be attached does not exist
336 * tests/dbus_api/test_compose_mail.c: (main):
337 removed obsolete comment, added generic files as test case
339 2007-06-07 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-tny-account-store.c: (get_server_accounts):
342 Create the local folders account only once, not once for each outbox, and
343 not only when there are some outboxes.
345 2007-06-07 Murray Cumming <murrayc@murrayc.com>
347 * src/widgets/modest-folder-view.c: (update_model): Comment out some
348 code that is causing a crash at startup. Sergio says that he is fixing this.
350 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
352 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
353 * src/maemo/modest-account-settings-dialog.c:
354 (create_page_outgoing),
355 (modest_account_settings_dialog_set_account_name),
356 (save_configuration):
357 - Fixed handling of the "Use secure authentication" toggle to comply with
358 the ui specification. See also projects.maemo.org bug NB#58400
360 - Restore the Secure connection setting combo correctly when loading
363 * src/maemo/modest-maemo-utils.c:
364 (on_camel_account_get_supported_secure_authentication),
365 (modest_maemo_utils_get_supported_secure_authentication_methods):
366 Fixed a crasher if operation is canceled
368 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
369 (modest_protocol_info_auth_is_secure):
370 * src/modest-protocol-info.h:
372 Added two new methods to determine if a protocol/auth method is secure/encrypted in
373 the sense of the "Use secure authentication" toggle.
375 2007-06-07 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account-store.h:
378 * src/modest-tny-account-store.c:
379 Added modest_tny_account_store_get_local_folders_account().
381 * src/modest-tny-folder.h:
382 * src/modest-tny-folder.c:
383 (modest_tny_folder_get_account):
384 Added this replacement for tny_folder_get_account() which returns
385 the local-folders account for TnyMergeFolders, to avoid the
386 warning about the unimplemented get_account_func() vfunc().
388 (modest_tny_folder_get_rules),
389 * src/modest-ui-actions.c:
390 (modest_ui_actions_on_folder_selection_changed):
391 * src/modest-mail-operation.c:
392 (modest_mail_operation_remove_folder),
393 (modest_mail_operation_xfer_folder),
394 (modest_mail_operation_rename_folder),
395 (modest_mail_operation_get_msg),
396 (modest_mail_operation_get_msgs_full),
397 (modest_mail_operation_remove_msg),
398 (modest_mail_operation_xfer_msgs),
399 (modest_mail_operation_refresh_folder):
400 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
402 2007-06-07 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
405 (modest_server_account_set_security):
406 * src/modest-defs.h: Add comments explaining that our
407 UI spec means TLS when it says Normal, so these do not look like errors.
409 * src/modest-tny-account.c:
410 (modest_tny_account_new_from_server_account): Use the new tinymail
411 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
412 for TLS. This should fix projects.maemo.org bug NB#58460.
414 2007-06-06 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/easysetup/modest-easysetup-wizard.c:
417 (create_account): Correct the position of the gconf sanity check warning.
418 (on_button_edit_advanced_settings): Show the dialog immediately, instead
419 of using the g_idle_add() hack, because this does not seem to be necessary
420 on osso 1.1. It might even work on Maemo Bora if the problems were actually
421 caused by something other than maemo's gconf.
422 This fixes projects.maemo.org bug #59022.
424 2007-06-06 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-account-mgr-helpers.c:
427 (modest_account_mgr_get_default_account): Do not check that the account
428 exists if there is no default account (NULL), to fix a runtime warning.
430 2007-06-06 Murray Cumming <murrayc@murrayc.com>
432 * src/widgets/modest-folder-view.c: (update_model):
433 Do not unref the treemodel before we have finished with it.
434 This prevents a valgrind warning and an occasional crash at startup.
436 2007-06-06 Marcus Bauer <marcusb@openismus.com>
438 * libmodest-dbus-client/libmodest-dbus-client.h:
439 added libmodest_dbus_client_compose_mail()
440 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
442 added functions needed for SendAsMail() functionality
443 * src/maemo/modest-msg-edit-window.c:
444 (modest_msg_edit_window_attach_file_noninteractive):
445 non interactively attaching files to message edit window
446 * src/widgets/modest-msg-edit-window.h:
447 * tests/dbus_api/Makefile.am:
448 added test_compose_mail.c
449 * tests/dbus_api/test_compose_mail.c: (main):
451 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
453 * src/modest-account-view.c:
454 Fixed bug projects.maemo.org bug NB#59307
456 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
458 * src/maemo/easysetup/modest-easysetup-wizard.c:
459 (get_serverport_incoming), (on_before_next), (create_account):
460 * src/maemo/modest-account-settings-dialog.c:
461 (modest_account_settings_dialog_set_account_name):
462 * src/maemo/modest-maemo-utils.c:
463 (on_camel_account_get_supported_secure_authentication_status),
464 (on_camel_account_get_supported_secure_authentication),
465 (on_secure_auth_cancel),
466 (modest_maemo_utils_get_supported_secure_authentication_methods):
468 Implemented security authentication for settings and easysetup.
470 2007-06-05 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/modest-main-window.c: (create_details_widget):
473 Show the total size for memory card accounts too, instead of showing
474 the name again. Fixes bug projects.maemo.org bug NB#59307.
476 2007-06-05 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-simple-folder-store.c:
480 * src/modest-tny-simple-folder-store.h: Removed.
482 * src/modest-tny-local-folders-account.h
483 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
484 for the local-folders maildir, with an extra TnyMergedFolder containing
485 the folders of the per-account outbox store accounts.
486 * src/modest-tny-account-store.c: (get_server_accounts):
487 Add the outboxes to the special local folders account after creating it.
489 * src/modest-tny-account.c:
490 (modest_tny_account_new_for_local_folders): Create the derived
491 account when creating the main local-folders account.
493 * src/maemo/modest-main-window.c: (create_details_widget),
494 (modest_main_window_set_contents_style):
495 Adapted to the use of the derived account instead of the folder store.
497 * src/modest-ui-actions.c:
498 (modest_ui_actions_on_folder_selection_changed):
499 * src/modest-ui-dimming-rules.c:
500 (modest_ui_dimming_rules_on_new_folder):
501 * src/widgets/modest-folder-view.c: (text_cell_data),
502 (icon_cell_data), (filter_row), (update_model),
503 (get_cmp_rows_type_pos):
506 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
507 Do not get the priv struct, because no priv struct has been set,
508 to avoid a runtime warning.
510 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
511 #ifelse with #else, to fix a warning, to fix the build.
514 2007-06-05 Christian Kellner <ckellner@openismus.com>
516 * libmodest-dbus-client/libmodest-dbus-client.c:
517 Fix small typo in doc (why do you always see them
518 AFTER committing stuff?)
521 2007-06-05 Christian Kellner <ckellner@openismus.com>
523 * libmodest-dbus-client/libmodest-dbus-client.c:
524 (libmodest_dbus_client_search):
525 Initialize hit list with NULL. Also set folder list
526 to "" if NULL was supplied.
529 2007-06-03 Christian Kellner <ckellner@openismus.com>
531 * libmodest-dbus-client/libmodest-dbus-client.c:
532 (modest_search_hit_list_free):
533 Make it save to call it with NULL.
535 * src/dbus_api/modest-dbus-callbacks.c:
536 * src/modest-search.c:
537 Return full ModestSearchHits as the search result list not TnyHeader
538 since can't be around withouth the correspoding TnyFolder.
540 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
542 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
543 Added currently commented code to check for secure auth
545 * src/maemo/modest-account-settings-dialog.c: (on_response),
546 (save_configuration), (show_ok):
547 Fixed projects.maemo.org bugs NB #59248 and #59251
549 * src/maemo/modest-maemo-utils.c:
550 (on_camel_account_get_supported_secure_authentication_status),
551 (on_camel_account_get_supported_secure_authentication),
552 (modest_maemo_utils_get_supported_secure_authentication_methods):
553 * src/maemo/modest-maemo-utils.h:
554 Moved get_supported_secure_authentication() method here to be able
555 to use it from easysetup wizard.
557 * src/modest-pair.c: (on_pair_compare_as_string):
558 Should compare string with first part of pair and not
559 strcmp pairs which will crash.
561 * src/modest-protocol-info.c:
562 (modest_protocol_info_protocol_is_store):
563 * src/modest-protocol-info.h:
564 Added modest_protocol_info_get_auth_protocol_name()
566 2007-06-03 Armin Burgmeier <armin@openismus.com>
568 * src/modest-mail-operation.c:
569 (modest_mail_operation_get_msgs_full): Set priv->account also when
570 only retrieving a single message. This avoids a crash when canceling
573 (modest_mail_operation_notify_end): Do not explicitely remove the
574 operation from the queue but only emit the progress_changed signal.
575 The queue itself listens to that signal to remove the operation when
576 it is finished. This reduces coupling and removes a potential deadlock
577 when modest_mail_operation_notify_end() is called from the queue
578 itself. If that is a problem performance-wise, I would suggest to
579 implement a status-changed signal or something.
581 * src/modest-mail-operation-queue.c: Make sure to never call a
582 function from another file while the queue is locked. This (hopefully)
583 fixes another deadlock when exiting the application while retrieving
586 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
588 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
589 Fixed build if libogs is not available
591 2007-06-03 Christian Kellner <ckellner@openismus.com>
593 * libmodest-dbus-client/libmodest-dbus-client.h:
594 * libmodest-dbus-client/libmodest-dbus-client.c:
595 (libmodest_dbus_client_delete_message):
596 Implement deletion of messages (Client side).
598 (modest_search_hit_free),
599 (modest_search_hit_list_free):
600 Utility functions to free the result hits.
602 * src/dbus_api/modest-dbus-api.h:
603 * src/dbus_api/modest-dbus-callbacks.c:
605 (modest_dbus_req_handler):
606 Implement deletion of messages (Server side).
608 * tests/dbus_api/test_search.c: (main):
611 * tests/dbus_api/Makefile.am:
612 * tests/dbus_api/test_delete_message:
613 Add little test for the message deletion logic
615 2007-06-03 Armin Burgmeier <armin@openismus.com>
617 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
618 when the operation queue was not empty. projects.maemo.org bug
621 2007-06-03 Armin Burgmeier <armin@openismus.com>
623 * src/widgets/modest-account-view.c
624 (on_account_default_toggled): Toggle default account column
625 explicitely instead of waiting for gconf notification (which is
626 currently ignored). This should fix projects.maemo.org bug NB#56910
627 for now. It should probably be removed when gconf notifications are
630 2007-06-03 Christian Kellner <ckellner@openismus.com>
632 * libmodest-dbus-client/libmodest-dbus-client.c:
633 Removed debugging spew.
635 * src/dbus_api/modest-dbus-callbacks.c:
636 Added debugging info.
638 * src/modest-search.c:
639 (modest_search_all_accounts):
640 Use tny_account_store_get_accounts () on the account store
641 to get all accounts which is the way to get all accounts.
643 * tests/dbus_api/test_search.c: (main):
644 Make it possible to supply the search term on the command line.
646 2007-06-03 Christian Kellner <ckellner@openismus.com>
648 * libmodest-dbus-client/libmodest-dbus-client.c:
649 * libmodest-dbus-client/libmodest-dbus-client.h:
650 Implement searching for mesages over raw dbus. (Client side)
652 * src/dbus_api/Makefile.am:
653 * src/dbus_api/modest-dbus-api.h:
654 * src/dbus_api/modest-dbus-callbacks.c:
655 * src/dbus_api/modest-dbus-callbacks.h:
656 Search framework (Server side). Also implement on_idle_open_message().
658 * src/maemo/modest-platform.c: (modest_platform_init):
659 Prepare for raw dbus/osso rpc interaction.
661 * src/modest-search.h:
662 Changed minsize from unspecific guint to guint32.
664 * src/modest-search.c:
666 Added strange hack which magically made tnymail work.
668 (modest_search_folder),
669 (modest_search_account),
670 (modest_search_all_accounts):
671 Implement helper functions to search all accounts, specific account
674 * tests/dbus_api/Makefile.am:
675 * tests/dbus_api/test_open_message.c:
676 Read url to open from commandline.
678 * tests/dbus_api/test_search.c:
679 Implement small test for dbus search stuff
681 2007-06-02 Armin Burgmeier <armin@openismus.com>
683 * src/maemo/modest-account-settings-dialog.c: Changed window title to
684 include account type and account title. This fixes projects.maemo.org
687 * src/maemo/modest-account-view-window.c: Set a title for the window.
689 2007-06-02 Armin Burgmeier <armin@openismus.com>
691 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
692 incoming and outgoing server name based on email address and server
693 types as long as the names have not been edited manually. This fixes
694 projects.maemo.org bug NB#58671.
696 2007-06-02 Armin Burgmeier <armin@openismus.com>
698 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
699 server type cannot be changed in future to the incoming details page
700 when creating an account. This fixes projects.maemo.org bug NB#59029.
702 2007-06-02 Armin Burgmeier <armin@openismus.com>
704 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
705 and assigned max width chars so that they wrap instead of being
706 truncated. Fixes projects.maemo.org bug NB#56126.
708 2007-06-02 Armin Burgmeier <armin@openismus.com>
710 * src/maemo/modest-connection-specific-smtp-window.c: Add an
711 introductory note to the connection specific smtp servers dialog, as
712 section 8.12 of the email UI specification requires. This fixes
713 projects.maemo.org bug NB#59212.
715 2007-06-01 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
718 Check for running mail operations, and offer to cancel them, as per the UI
719 spec. This fixes projects.maemo.org bug NB#59041 .
720 However, I suspect that tinymail may still use the network connection
721 in ways that we cannot detect or cancel. But it should at least adapt to
724 2007-06-01 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-tny-account-store.c: (recreate_all_accounts),
727 (get_cached_accounts), (get_server_accounts): Do more sensible
728 ref-counting of the temporarily-cached outbox accounts list. This seems
729 to fix a crash when entering the password when the password was wrong.
731 2007-06-01 Murray Cumming <murrayc@murrayc.com>
733 * src/gnome/modest-main-window.c: (connect_signals):
734 * src/modest-tny-account-store.c: (get_password),
735 (modest_tny_account_store_alert): Added comments and clues and
736 commented-out code about how we currently fail to deal with connection
737 errors and wrong passwords, and how we should.
739 2007-06-01 Murray Cumming <murrayc@murrayc.com>
741 * src/widgets/modest-retrieve-combo-box.c:
742 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
743 This fixes projects.maemo.org bug NB#58472 .
745 2007-06-01 Murray Cumming <murrayc@murrayc.com>
747 * src/maemo/easysetup/modest-easysetup-wizard.c:
748 (create_page_complete_easysetup):
749 (create_page_complete_custom): Correct the last commit,
750 putting the correct sentences in the correct pages.
752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
754 * src/maemo/easysetup/modest-easysetup-wizard.c:
755 (create_page_complete_custom): Show the second sentence of text
756 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
759 2007-06-01 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
762 Set the leave-on-server conf key by default. This fixes
763 projects.maemo.org bug NB#59258 .
765 2007-06-01 Murray Cumming <murrayc@murrayc.com>
767 * src/maemo/modest-account-view-window.c:
768 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
769 logical ID for the confirmation messages. Fixed projects.maemo.org bug
772 2007-06-01 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/easysetup/modest-easysetup-wizard.c:
775 (create_caption_new_with_asterisk):
776 * src/maemo/modest-account-settings-dialog.c:
777 (create_caption_new_with_asterisk):
778 Uncomment the code to add the asterisk, because they are no longer in the
779 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
780 (update_incoming_server_title): Add an asterisk here too.
782 2007-06-01 Murray Cumming <murrayc@murrayc.com>
784 * src/maemo/modest-maemo-global-settings-dialog.c:
785 (current_connection): Check that we are even connected before trying to
786 get the current connection name, to prevent a warning.
788 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
789 Change the comments because tny_maemo_conic_device_connect() is now meant to
791 * src/modest-mail-operation.c:
792 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
793 make sure we have a connection and fail if we can't connect.
795 2007-05-31 Murray Cumming <murrayc@murrayc.com>
797 * src/maemo/modest-main-window.c:
798 (on_account_store_connecting_finished): Do not try to get the
799 connection ID if we are not really connected. I am surprised that
800 this signal handler is called when we are not connected.
802 2007-05-31 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-error.h:
805 * src/modest-ui-actions.c:
806 (modest_ui_actions_get_msgs_full_error_handler):
807 Renamed an enum, added comments, added an enum
808 for retrieve-limit errors.
810 * src/modest-mail-operation.c: (foreach_add_item),
811 (internal_folder_observer_update), (update_account_thread),
812 (modest_mail_operation_get_msgs_full):
813 (modest_mail_operation_update_account),
814 Added comments about how this works, and some code that should
815 (but does not) check the retrieve-limit. See the TODO comment.
817 2007-05-31 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
820 Initialize help_id to fix the build. Warnings are good.
822 2007-05-31 Murray Cumming <murrayc@murrayc.com>
824 * src/widgets/modest-hbox-cell-renderer.c:
825 (modest_hbox_cell_renderer_append):
826 * src/widgets/modest-vbox-cell-renderer.c:
827 (modest_vbox_cell_renderer_append):
828 Fix the last commit by doing an extra ref.
830 2007-05-31 Murray Cumming <murrayc@murrayc.com>
832 * src/widgets/modest-hbox-cell-renderer.c:
833 (modest_hbox_cell_renderer_append):
834 * src/widgets/modest-vbox-cell-renderer.c:
835 (modest_vbox_cell_renderer_append):
836 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
837 to fix the build with Maemo Bora.
838 However, there seems to be a remaining crash, probably due to reference
841 2007-05-30 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account.c:
844 (modest_tny_account_new_for_local_folders):
845 Use hildon_file_system_info_async_new() to get a better name for
846 the memory card account, setting it as the account name.
847 The timing seems to work, but this is probably
848 not the best place to do this. See the TODO comment.
849 * src/maemo/modest-main-window.c: (create_details_widget):
850 * src/widgets/modest-folder-view.c: (text_cell_data):
851 Use the tny account name instead of hardcoding a name.
853 2007-05-30 Christian Kellner <ckellner@openismus.com>
855 * src/modest-search.c: (modest_search):
856 Correctly set part_search_func even if we have already parsed
857 the query and thus a valid OgsTextSearcher object.
859 2007-05-30 Christian Kellner <ckellner@openismus.com>
862 Search and check for libogs.
865 Incooparte the ogs build env.
867 * src/modest-mime-part-search-stream.c:
868 * src/modest-mime-part-search-stream.h:
869 Removed since we do the real searching now in modest-search.c.
871 * src/modest-search.c:
872 * src/modest-search.h:
873 Implement support for ogs. We use that if available and requested
874 and fall back to modest_text_utils_utf8_strcmp (). The search logic
875 should now handle the corner case when the search term is spread
876 across multiple reads.
877 Also the logic in modest_search () was corrected to search all
878 requested fields until one is found.
880 2007-05-30 Murray Cumming <murrayc@murrayc.com>
882 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
885 * src/modest-init.c: Made modest_init_local_folders() take a
886 path and be public so we can iniitialize maildir folders on
889 * src/modest-local-folder-info.h:
890 * src/modest-local-folder-info.c:
891 (modest_local_folder_info_get_maildir_path): Add a path parameter.
893 * src/modest-tny-account.c:
894 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
895 still means the standard local-folders path on the local volume.
897 * src/modest-tny-account-store.c:
898 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
899 signal so we can detect mount/unmount of the MMC1 card, and do an update of
900 all accounts when that happens.
901 (get_server_accounts): If the MMC1 card is mounted, create a store account for
902 this too, so it shows up in the treeview.
904 2007-05-28 Murray Cumming <murrayc@murrayc.com>
906 * src/maemo/modest-maemo-global-settings-dialog.c:
907 (current_connection):
908 * src/widgets/modest-global-settings-dialog.c:
909 (current_connection_default):
910 Use the enum values instead of 0, 1 and -1,
911 to make the code clearer.
913 * src/modest-account-mgr-helpers.c:
914 (modest_account_mgr_get_connection_specific_smtp): Make this code
917 * src/modest-runtime.h:
918 * src/modest-runtime.c:
919 Added modest_runtime_remove_all_send_queues().
920 * src/maemo/modest-main-window.c:
921 (on_account_store_connecting_finished): Recreate the send queues,
922 using the appropriate transport accounts for this new connection.
923 Some futher adapting might be needed if the old send queues are not
924 automatically stopped at this point.
926 * src/modest-tny-account-store.c: (get_server_accounts):
927 Create the connection-specific transport accounts, so that they can
928 be found later by their ID.
930 * src/modest-tny-account.h:
931 * src/modest-tny-account.c:
932 Added modest_tny_account_new_from_server_account_name().
933 modest_tny_account_new_from_server_account(): Do not create the
934 send queues here, because they will be
935 recreated anyway when the connection changes for the first time.
937 2007-05-28 Murray Cumming <murrayc@murrayc.com>
939 * src/modest-local-folder-info.h:
940 * src/modest-local-folder-info.c:
941 (modest_per_account_local_outbox_folder_info_get_maildir_path),
942 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
943 tbox_folder): Take a modest account name instead of a server TnyAccount,
944 so we can have per-modest-account rather than per-transport-account
946 We must make sure that we change or recreate the exisitng send queues
947 when the connection changes for connection-specific transport accounts.
949 * src/modest-tny-account-store.c:
950 (create_per_account_local_outbox_folders): Create outboxed per modest
951 account, not per transport account.
953 * src/modest-tny-account.h:
954 * src/modest-tny-account.c:
955 (modest_tny_account_get_special_folder): For outboxes, get the
956 parent modest account name. The account is ignored for other folders.
957 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
958 modest account name rather than a server TnyAccount.
960 2007-05-25 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account.c:
963 (modest_tny_account_new_from_server_account):
964 Call modest_runtime_get_send_queue() immediately after creating transport
965 accounts, so that they start trying to send email from the outbox as soon
966 as possible at startup. This is probably what we want.
968 * src/modest-mail-operation.c: (update_account_thread):
969 * src/modest-runtime.c: (modest_runtime_get_send_queue):
970 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
971 * src/modest-tny-send-queue.h:
972 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
973 (modest_ui_actions_on_send):
974 Added comments about how sending works, though it needs some more work.
976 2007-05-25 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-tny-account.c:
979 (modest_tny_account_get_special_folder): Add TODO because this fails when
981 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
982 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
983 Do not try to show this window when there is no active account. The UI
984 specs does not tell us what to do in this case.
986 2007-05-24 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/Makefile.am:
991 * src/widgets/Makefile.am: Some dist fixes.
993 2007-05-24 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/modest-connection-specific-smtp-window.c:
996 (on_button_edit): Make the code clearer, to prevent a double free.
998 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1000 * src/maemo/modest-account-settings-dialog.c:
1001 (modest_account_settings_dialog_set_account_name),
1002 Check the connection-specific smtp servers checkbox if there are any.
1004 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1005 (modest_connection_specific_smtp_edit_window_init):
1006 Start with a suitable port number.
1008 * src/modest-account-mgr-helpers.h:
1009 * src/modest-account-mgr-helpers.c: Added
1010 modest_account_mgr_get_has_connection_specific_smtp().
1012 (modest_account_mgr_set_connection_specific_smtp),
1013 (modest_account_mgr_remove_connection_specific_smtp),
1014 (modest_account_mgr_get_has_connection_specific_smtp),
1015 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1016 connection-specific smtp server accounts in the account, rather than
1017 the server account conf dir.
1019 This fixes bug projects.maemo.org bug NB#58263 .
1021 * src/modest-tny-account-store.c:
1022 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1023 if there are no server accounts yet, to prevent an infinite loop when there
1024 are no accounts. Document that one must be called before the other.
1026 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-account-mgr-helpers.c:
1029 (modest_account_mgr_get_default_account): Make sure that at least
1030 one account is always the default, if there are any enabled accounts.
1031 This is just a sanity check that shouldn't be necessary.
1033 * src/modest-account-mgr-priv.c:
1034 (_modest_account_mgr_account_from_key): Unescape the conf key to
1035 get the real account name. For instance, this is an issue if a space
1036 was in the account name, which can happen because the account name
1037 is generated from the display name.
1038 (_modest_account_mgr_get_account_keyname): Always escape the
1040 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1041 Unescape the conf keys to get the real account names.
1043 For instance, previously the is-default radio button in the accounts
1044 list was not checked for any accounts at first. This fixes that,
1045 and might fix several similar bugs.
1047 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1049 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1050 Removed some debug printfs.
1052 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1054 Modest on-disk outbox directories are now here, for instance:
1055 $HOME/.modest/outboxes/<account-id-1>/outbox
1056 $HOME/.modest/outboxes/<account-id-2>/outbox
1058 $HOME/.modest/local-folders/outbox
1059 so we can have a separate outbox for each account.
1060 But they are shown as one outbox in the GtkTreeView, by using a
1061 TnyMergeFolder in a ModestTnySimpleFolderStore.
1064 * src/modest-tny-simple-folder-store.c:
1065 * src/modest-tny-simple-folder-store.h:
1066 Added ModestTnySimpleFolderStore, used to contain folders from
1067 other folder stores, such as other accounts.
1069 * src/modest-tny-outbox-account.h:
1070 * src/modest-tny-outbox-account.c:
1071 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1072 used for the per-account local outbox folders.
1074 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1075 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1076 only use this (internally) now for the non-outbox local folders.
1078 * src/modest-init.h:
1079 * src/modest-init.c: Added modest_init_one_local_folder(), for
1080 setting up the directory structure for each local folder.
1082 * src/modest-local-folder-info.c:
1083 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1084 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1086 * src/modest-local-folder-info.h:
1087 * src/modest-tny-account-store.c: (on_account_removed),
1088 (on_account_changed), (create_per_account_local_outbox_folders),
1089 (get_server_accounts), (modest_tny_account_store_get_accounts),
1090 (modest_tny_account_store_get_tny_account_by_account),
1091 (modest_tny_folder_store_is_virtual_local_folders):
1093 * src/modest-tny-account.h:
1094 * src/modest-tny-account.c:
1095 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1096 to create an on-disk per-account local outbox folder for each
1098 (create_per_account_local_outbox_folders): Create a local outbox folder
1099 for each transport account.
1100 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1101 for all local folders.
1103 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1104 instead of using g_object_get/set() directly. It is clearer.
1106 (modest_tny_folder_store_get_message_count),
1107 (modest_tny_folder_store_get_local_size
1108 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1109 because we now use these with non-acount folder stores.
1111 (modest_tny_account_get_special_folder),
1112 (modest_tny_account_new_from_server_account),
1113 (modest_tny_account_new_from_account):
1114 (recurse_folders): Adjust to the new outbox system.
1116 * src/modest-tny-folder.h:
1117 * src/modest-tny-folder.c:
1118 (modest_tny_folder_is_local_folder),
1119 (modest_tny_folder_get_local_folder_type),
1120 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1122 * src/widgets/modest-main-window.h:
1123 * src/maemo/modest-main-window.c: (create_details_widget),
1124 (modest_main_window_set_contents_style): Show details for any folder store,
1127 (modest_tny_folder_get_rules):
1128 Remove the const. C does not support constness enough for this.
1130 * src/modest-ui-actions.c:
1131 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1132 make all outboxes appear as one, in the usual local-folders tree node.
1134 (set_active_account_from_tny_account),
1135 (modest_ui_actions_on_folder_selection_changed):
1136 * src/widgets/modest-folder-view.c: (text_cell_data),
1137 (icon_cell_data), (filter_row),
1138 (add_account_folders_to_merged_folder),
1139 (add_account_folders_to_simple_folder_store), (),
1140 (get_cmp_rows_type_pos), (cmp_rows),
1141 (modest_folder_view_set_account_id_of_visible_server_account):
1142 Adjust to the new outbox system, using generic folder stores and folders
1143 in the GtkTreeModel.
1145 2007-05-23 Christian Kellner <ckellner@openismus.com>
1147 * src/modest-mail-operation.c:
1148 (modest_mail_operation_update_account):
1149 Use info->max_size instead of unintialized local var [small
1150 build fix]. (Added TODO to review that change since I don't
1153 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1155 * libmodest-dbus-client/libmodest-dbus-client.c:
1156 (libmodest_dbus_client_compose_mail): function added
1157 * src/dbus_api/modest-dbus-api.h:
1158 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1159 (on_compose_mail): Implementation of the SendAsMail functionality
1161 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-account-mgr.c:
1164 (modest_account_mgr_add_server_account): Set the secure-connection
1165 conf key for transport accounts as well as store accounts. I don't know
1166 why the if was there. For instance, this makes sure that we use SSL
1167 for the gmail preset from the easysetup wizard.
1169 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1171 * src/gnome/modest-main-window.c:
1172 (on_account_store_connecting_finished), (connect_signals):
1173 * src/maemo/modest-main-window.c:
1174 (on_account_store_connecting_finished), (connect_signals),
1175 (modest_main_window_new):
1176 Handle TnyAccountStore::connecting-finished instead of
1177 TnyDevice::connection-changed, because we cannot actually perform
1178 operations on accounts until TnyAccountStore has itself responded to
1179 the TnyDevice::connection-changed signal. This prevents a GError from
1181 Do not try to update at startup, because we (at least on scratchbox)
1182 already do an update at startup when the device goes online.
1183 This prevents a GError from tinymail.
1184 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1185 Added TODO about stopping simultaneous operations.
1187 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1189 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1190 * src/modest-mail-operation-queue.c:
1191 (modest_mail_operation_queue_remove):
1192 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1193 about where they happened.
1195 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-ui-actions.c:
1198 (modest_ui_actions_on_password_requested): Make sure that the remember
1199 output parameter is always TRUE.
1201 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1203 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1204 Show a OK/Cancel dialog if the error is a question, though we still do not
1205 know anything more about what we are asking the user.
1206 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1207 Fix an uninitialized variable (helper). This is a logic error, however.
1209 2007-05-21 Christian Kellner <ckellner@openismus.com>
1211 * src/modest-search.h:
1212 Correct bit shifting in the ModestSearchFlags enum.
1214 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account.c:
1217 (modest_tny_account_new_from_server_account): Do not use the lsub and
1218 check-all hard-coded IMAP options when using POP.
1220 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-tny-account.c:
1223 (modest_tny_account_new_from_server_account):
1224 Use NULL for the secure-auth method for POP when Password auth has been
1225 specified by the user, as we already do for IMAP. "auth=Login" causes
1226 an error from camel or the server.
1228 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1230 * src/maemo/modest-account-settings-dialog.c:
1231 (create_page_account_details),
1232 (modest_account_settings_dialog_set_account_name):
1233 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1234 for the leave-on-server checkbox, rathr than just the checkbox, when
1235 the protocol is not POP.
1237 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1239 * src/widgets/modest-account-view.c:
1240 * src/widgets/modest-account-view.h:
1241 Added modest_account_view_select_account() which will be useful later
1242 to asynchronously re-select the edited account.
1244 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1246 * src/maemo/modest-account-settings-dialog.c:
1247 (modest_account_settings_dialog_set_account_name):
1248 Automatically choose the port numbers based on the secure authentication
1249 methods, if they have not been chosen before.
1250 This fixes projects.maemo.org bug NB#56273 .
1252 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1254 * src/maemo/modest-main-window-ui.h:
1255 * src/modest-ui-actions.c:
1256 * src/modest-ui-actions.h:
1257 Connect the Tools/SMTP Servers menu item to
1258 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1259 SMTP servers dialog, as in the UI specification and saves changes when it
1260 is closed. This fixed projects.maemo.org bug NB#56305 .
1262 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1264 * src/maemo/modest-connection-specific-smtp-window.c:
1265 (modest_connection_specific_smtp_window_init):
1266 Use gtk_window_set_default_size() to make this window big enough, so
1267 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1269 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1272 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1273 (modest_connection_specific_smtp_edit_window_init),
1274 Do not try to connect to a combobox signal before the combobox exists.
1275 This fixes the cras in projects.maemo.org bug NB#56288 .
1276 (modest_connection_specific_smtp_edit_window_get_settings):
1277 Remove the server_account_name parameter which was being checked for NULL
1278 though it was not used.
1280 * src/maemo/modest-connection-specific-smtp-window.c:
1281 (modest_connection_specific_smtp_window_fill_with_connections),
1282 (on_button_edit), (modest_connection_specific_smtp_window_init):
1283 Correct the number of treemodel columns to prevent a warning.
1284 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1285 libconic does not work.
1287 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-tny-account.c:
1290 (modest_tny_account_new_from_server_account):
1291 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1292 SMTP when "None" was chosen by the user. However, with my SMTP server that
1293 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1296 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1299 to explain the memory management issue with the ID in the ModestPair.
1301 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1302 (add_sending_page), (modest_account_assistant_finalize):
1303 * src/gnome/modest-gnome-global-settings-dialog.c:
1304 (create_updating_page), (create_composing_page):
1305 * src/gnome/modest-msg-edit-window.c: (get_transports),
1306 (init_window), (modest_msg_edit_window_finalize),
1307 (modest_msg_edit_window_get_msg_data):
1308 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1309 * src/gnome/modest-transport-widget.c:
1310 (modest_transport_widget_finalize), (smtp_configuration):
1311 * src/maemo/modest-maemo-global-settings-dialog.c:
1312 (create_updating_page), (create_composing_page):
1313 * src/maemo/modest-msg-edit-window.c: (get_transports),
1314 (init_window), (modest_msg_edit_window_finalize),
1315 (modest_msg_edit_window_get_msg_data),
1316 (modest_msg_edit_window_free_msg_data):
1317 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1318 (modest_store_widget_finalize):
1319 * src/maemo/modest-transport-widget.c:
1320 (modest_transport_widget_finalize), (smtp_configuration):
1321 * src/modest-main.c: (send_mail):
1322 * src/widgets/modest-combo-box.h:
1323 * src/widgets/modest-global-settings-dialog-priv.h:
1324 * src/widgets/modest-global-settings-dialog.c:
1325 (modest_global_settings_dialog_finalize):
1326 * src/widgets/modest-msg-edit-window.h:
1327 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1328 as long as the combo box, to prevent use of freed memory for the ID.
1330 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1333 get_accounts(), to make this clearer. Do not check for the enabled gconf
1334 key, because we do not use this for server accounts (at least, not yet).
1335 This allows us to send email again.
1337 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1339 * src/maemo/modest-platform.c:
1340 (on_modest_conf_update_interval_changed), (modest_platform_init):
1341 Only respond to this particular key change. All these strcmp()s cannot be
1344 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1346 * src/maemo/modest-maemo-global-settings-dialog.c:
1347 (current_connection): Prevent a crash in scratchbox when
1348 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1349 * src/maemo/modest-platform.c:
1350 (on_modest_conf_update_interval_changed), (modest_platform_init):
1351 Get the update interval from gconf and reset it when the gconf key changes.
1353 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-protocol-info.c:
1356 * src/modest-protocol-info.h: Adde enum-specific get functions,
1357 instead of using a ModestProtocolType enum parameter.
1359 * src/gnome/modest-account-assistant.c:
1360 * src/gnome/modest-store-widget.c:
1361 * src/gnome/modest-store-widget.h:
1362 * src/gnome/modest-transport-widget.c:
1363 * src/gnome/modest-transport-widget.h:
1364 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1365 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1366 * src/maemo/easysetup/modest-easysetup-wizard.c:
1367 * src/maemo/modest-account-settings-dialog.c:
1368 * src/maemo/modest-account-settings-dialog.h:
1369 * src/maemo/modest-store-widget.c:
1370 * src/maemo/modest-store-widget.h:
1371 * src/maemo/modest-transport-widget.c:
1372 * src/maemo/modest-transport-widget.h:
1373 * src/modest-account-mgr-helpers.c:
1374 * src/modest-account-mgr-helpers.h:
1375 * src/modest-account-mgr.c:
1376 * src/modest-account-mgr.h:
1377 * src/modest-tny-account.c:
1378 * src/modest-tny-folder.c:
1379 * src/widgets/modest-account-view.c:
1380 * src/widgets/modest-retrieve-combo-box.c:
1381 * src/widgets/modest-retrieve-combo-box.h:
1382 * src/widgets/modest-secureauth-combo-box.c:
1383 * src/widgets/modest-serversecurity-combo-box.c:
1384 * src/widgets/modest-serversecurity-combo-box.h:
1385 * tests/check_account-mgr.c:
1386 Use the specific functions, and use the re-renamed enum values for GNOME too.
1388 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-pair.h:
1391 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1392 so we can get the second based on the first.
1394 * src/maemo/modest-account-settings-dialog.h:
1395 * src/maemo/modest-account-settings-dialog.c:
1396 Added get_supported_secure_authentication_methods(), though it is mostly
1397 commented-out for now until the necessary API is committed to tinymail.
1398 (modest_account_settings_dialog_set_account_name),
1399 (save_configuration): Request the supported authentication methods from the
1400 server, so we can choose a working method.
1402 * src/modest-tny-account-store.h:
1403 * src/modest-tny-account-store.c:
1404 (modest_tny_account_store_get_session): Rename from
1405 tny_account_store_get_session().
1407 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1409 * src/modest-protocol-info.h: Split the ModestProtocol enum
1410 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1411 There was no need to have these unrelated values in one enum.
1413 * src/: many files: Adapted to changed enum. This makes the code a bit
1414 clearer, and the compiler could catch some errors.
1416 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1418 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1419 Show the detailed internal camel error message when an error happens
1420 during the configuration, so that our testers can give us more clues.
1421 For instance, in projects.maemo.org bug NB#56910 .
1423 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1425 * src/modest-tny-account.c:
1426 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1427 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1429 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1432 * src/maemo/modest-account-settings-dialog.c:
1433 (modest_account_settings_dialog_set_account_name),
1434 (save_configuration): For the incoming secure authentication checkbox,
1435 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1436 the UI specification. PLAIN does not seem to be supported for most IMAP
1437 servers anyway, and I am not sure what it would mean.
1438 However, we probably need to discover which of the secure-authentication
1439 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1440 * src/modest-account-mgr-helpers.c:
1441 (modest_account_mgr_get_server_account_data):
1443 * src/modest-tny-account.c:
1444 (modest_tny_account_new_from_server_account):
1445 Use tny_account_set_mech() to set secure-authentication methods,
1446 with some special-casing for IMAP, based on my observations of how
1449 * src/modest-account-mgr-helpers.h:
1450 * src/modest-account-mgr.c:
1451 * src/modest-defs.h: Comment that the URI is only used for local folders.
1453 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1456 parameter const, just to be neat.
1457 * src/modest-text-utils.c: (modest_text_utils_inline):
1458 End g_strconcat() with NULL, as its documentation says. This is almost
1459 certainly the cause of my crash at startup on the device. Interestingly,
1460 valgrind doesn't tell us about these errors.
1462 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1464 * scripts/build-packages: Added more precise comments about how to use
1465 this script, though I still get this error:
1466 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1467 error building tinymail
1469 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1471 * src/maemo/modest-main-window.c: (on_account_update):
1472 Very slight cleanup, hoping to make it simpler to discover what causes
1473 a crash here sometimes.
1475 * src/modest-tny-account.c:
1476 (modest_tny_account_new_from_server_account): Set the port. Added
1477 comments about the options and a TODO comment because I need to find out
1478 how to specify the secure authentication method.
1480 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1482 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1483 changed CFlags paths form modest to libmodest
1485 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-account-mgr-helpers.c:
1488 (modest_account_mgr_get_server_account_data),
1489 (modest_account_mgr_free_server_account_data):
1490 * src/modest-account-mgr-helpers.h:
1491 * src/modest-account-mgr.c:
1492 (modest_account_mgr_add_server_account):
1493 * src/modest-defs.h:
1494 * src/modest-tny-account.c:
1495 (modest_tny_account_new_from_server_account):
1496 Determine the options for tny_camel_account_add_option() here,
1497 based on the settings, rather than storing them directly in gconf.
1499 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1502 Show a more friendly error dialog now that we expect (from the tinymail
1503 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1505 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/modest-main-window.c: (on_account_update): Check that
1508 account_name is not NULL, to prevent a crash at startup that I am
1509 seeing on the N800. I do wonder why it is NULL.
1511 * src/maemo/easysetup/modest-easysetup-wizard.c:
1512 (create_page_user_details):
1513 * src/maemo/modest-account-settings-dialog.c:
1514 (create_page_user_details), (create_page_outgoing):
1515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1516 (modest_connection_specific_smtp_edit_window_init):
1517 * src/modest-ui-actions.c:
1518 (modest_ui_actions_on_password_requested):
1519 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1520 might do something useful with the on-screen keyboard.
1522 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1524 * src/maemo/modest-main-window.c: (on_account_update):
1525 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1526 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1528 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1530 * src/modest-tny-account-store.c: (on_account_changed):
1531 Correct the signature of this signal handler.
1533 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1535 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1536 Show a HildonNote instead of a GtkDialog for Maemo.
1538 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1540 * src/widgets/modest-account-view.h:
1541 * src/widgets/modest-account-view.c: (on_account_changed),
1542 (on_account_removed). Added a boolean flag, set/unset by
1543 modest_account_view_block_conf_updates(),
1544 modest_account_view_unblock_conf_updates() to prevent unnecessary
1545 updates, but this is not very useful because the gconf notifications are
1546 so delays (maybe only on Maemo Bora).
1547 So auto-updating is turned off, and these functions do an explicit
1548 update when necessary.
1549 However, something else is still doing too much work when adding/removing
1550 accounts, probably in another part of the application.
1552 * src/maemo/modest-account-view-window.c:
1553 (on_delete_button_clicked), (on_edit_button_clicked),
1554 (on_new_button_clicked): Use the new functions.
1556 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1558 * src/modest-account-mgr-helpers.c:
1559 (modest_account_mgr_set_first_account_as_default):
1560 Sort the list of names alphabetically-by-title, so we choose the first one
1562 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1563 alphabetically by the title.
1565 This fixes projects.maemo.org bug NB#56418 .
1567 * src/modest-account-mgr-priv.c:
1568 (_modest_account_mgr_account_from_key):
1569 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1570 avoid a valgrind error, and possible random behaviour.
1572 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1574 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1575 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1576 tinymail documentation to say that this can be expected.
1577 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1578 pretty, and should not happen, but I would prefer to know when it does.
1580 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1582 * configure.ac: When using the older hildon version, probably on Bora,
1583 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1585 * src/widgets/modest-attachment-view.c:
1586 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1589 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1591 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1592 Implemented the prototype. Can be tested with
1593 tests/dbus_api/test_open_message:
1595 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-tny-account-store.c:
1598 (modest_tny_account_store_instance_init), (get_password):
1599 * src/modest-ui-actions.c:
1600 (modest_ui_actions_on_password_requested):
1601 Do not store the password in gconf, because this function is called
1602 for non-remembered passwords. Actually use the cached (in the hash map)
1603 password instead of releasing it.
1604 The password will now not be remembered if it is asked via the protected
1605 password dialog, as per the UI spec.
1607 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1609 * src/modest-defs.h:
1610 * src/modest-account-mgr-helpers.h:
1611 * src/modest-account-mgr-helpers.c:
1612 Added modest_server_account_get_username_has_succeeded(),
1613 modest_server_account_set_username_has_succeeded().
1614 (modest_server_account_set_username),
1615 Reset the has-succeeded flag if the username changes.
1617 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1618 * src/maemo/modest-connection-specific-smtp-window.c:
1619 (modest_connection_specific_smtp_window_save_server_accounts):
1620 Use modest_server_account_set_username() instead of using
1621 modest_conf_set_string() directly, so that the has-succeeded flag is always
1624 * src/modest-ui-actions.c:
1625 (modest_ui_actions_on_password_requested): Dim the username entry if
1626 the username has ever worked, as per the UI spec.
1628 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1630 * src/modest-tny-account-store.c: (get_password):
1631 * src/modest-ui-actions.c:
1632 (modest_ui_actions_on_password_requested):
1633 Allow the username to be changed too, though there is more work to
1634 be done on exactly how this behaves.
1636 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-account-mgr-helpers.h:
1639 * src/modest-account-mgr-helpers.c:
1640 Added modest_account_mgr_get_display_name(),
1641 modest_server_account_get_username(),
1642 modest_server_account_set_username(),
1643 modest_server_account_set_password(),
1644 modest_server_account_get_hostname() functions so we do not need to
1645 use the conf API directly.
1647 * src/maemo/modest-main-window.c: (connect_signals):
1648 Actually connect ot the ModestAccountStore::request-password signal,
1649 so that we show the dialog when the password is requested by Tinymail,
1650 for isntance if it is empty.
1652 * src/modest-marshal.list:
1653 * src/modest-tny-account-store.c:
1654 (modest_tny_account_store_class_init), (get_password),
1655 (modest_tny_account_store_alert):
1656 * src/modest-tny-account-store.h:
1657 * src/modest-ui-actions.h:
1658 * src/modest-ui-actions.c:
1659 (modest_ui_actions_on_password_requested):
1660 Change the signal parameters, so it is obvious that we are providing
1661 the non human-readable server name, and receiving both the username
1662 and password, though changing of the username is not yet implemented.
1663 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1664 for the GNOME version.
1666 This should fix the projects.maemo.org bug NB#56209, though it does not
1667 work on Bora, because the gconf_client_get() for the password fails
1668 immediately after we save it with gconf_client_set().
1670 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1673 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1674 caused an undefined symbol error:
1675 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1677 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1679 * src/modest-tny-account-store.c:
1680 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1681 using a GError instead of a string message, so we can translate it in
1684 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/modest-address-book.c:
1687 (modest_address_book_check_names):
1688 * src/maemo/modest-msg-view-window.c:
1689 (modest_msg_view_window_clipboard_owner_change):
1690 * src/modest-init.c: (modest_init_init_ui):
1691 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1692 (update_folders_cb), (modest_mail_operation_update_account):
1693 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1694 (modest_ui_actions_on_msg_attachment_clicked),
1695 (modest_ui_actions_on_msg_recpt_activated):
1696 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1697 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1698 (modest_msg_view_search_next):
1699 * src/widgets/modest-recpt-editor.c:
1700 (modest_recpt_editor_on_button_release_event),
1701 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1702 g_message(). At this point we should only be seeing interesting errors on
1703 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1705 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1707 (modest_wizard_dialog_force_title_update):
1708 * src/maemo/easysetup/modest-wizard-dialog.h:
1709 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1710 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1711 can update the title when appropriate. Otherwise the title is wrong if the
1712 pages are added after adding the notebook to the dialog.
1713 This must be a problem in HildonWizardDialog too.
1714 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1716 * src/maemo/easysetup/modest-easysetup-wizard.c:
1717 (create_subsequent_customsetup_pages),
1718 (create_subsequent_easysetup_pages):
1719 Call modest_wizard_dialog_force_title_update() so that the title is
1720 correct even with GTK+ < 2.10.
1721 This fixes projects.maemo.org bug NB#56145 .
1723 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1725 * src/maemo/modest-platform.c:
1726 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1727 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1730 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1732 * src/widgets/modest-window.h:
1733 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1734 and modest_window_save_state(), which invokes it.
1736 * src/widgets/modest-window-mgr.h:
1737 * src/widgets/modest-window-mgr.c:
1738 Added modest_window_mgr_save_state_for_all_windows(), which calls
1739 the save_state vfunc on all registered windows, if implemented.
1741 * src/gnome/modest-msg-edit-window.c:
1742 * src/gnome/modest-msg-view-window.c:
1743 * src/maemo/modest-msg-edit-window.c:
1744 * src/maemo/modest-msg-view-window.c:
1745 * src/maemo/modest-main-window.c:
1746 Specify the existing save_settings functions as implementations of
1747 ModestWindow::save_state_func().
1749 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1750 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1751 enabling hibernation, for instance.
1753 We may need to do the same thing for restoring settings.
1756 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1758 * src/widgets/modest-window-mgr.c:
1759 * src/widgets/modest-window-mgr.h:
1760 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1761 modest_window_mgr_get_hibernation_is_prevented().
1763 * src/maemo/modest-main-window.c:
1764 (on_hildon_program_is_topmost_notify): Prevent hibernation
1765 (possible when the application goes to the background in the WM),
1766 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1768 * src/maemo/easysetup/modest-easysetup-wizard.c:
1769 (modest_easysetup_wizard_dialog_init):
1770 * src/maemo/modest-account-settings-dialog.c:
1771 (modest_account_settings_dialog_init):
1772 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1773 (modest_connection_specific_smtp_edit_window_init):
1774 * src/maemo/modest-connection-specific-smtp-window.c:
1775 (modest_connection_specific_smtp_window_init):
1776 * src/maemo/modest-signature-editor-dialog.c:
1777 (modest_signature_editor_dialog_init):
1778 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1779 prevent hibernation while any of these account settings dialogs are open.
1781 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1783 * src/maemo/Makefile.am:
1784 * src/maemo/modest-osso-state-saving.c:
1785 * src/maemo/modest-osso-state-saving.h: Added
1786 modest_osso_load_state() and modest_osso_save_state() though they do
1787 nothing now. They should iterate through all the open windows and load/save
1789 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1790 save state when closing.
1792 * src/maemo/modest-main-window.c:
1793 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1794 Add a notification handler for the HildonProgram::is-topmost property,
1795 so we can allow hibernation when the application goes into the background.
1796 But we still need to detect when the accounts setup windows are open so
1797 we can stop hibernation when they are open.
1798 To do this, I also added the main window the HildonProgram. This might have
1799 other side-effects/benefits, and should maybe be done for other windows.
1801 * src/maemo/modest-osso-autosave-callbacks.h:
1802 * src/maemo/modest-osso-autosave-callbacks.c:
1803 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1804 though it does not do anything yet, and we might never need this to do
1805 anything. For instance, we already save drafts.
1807 * src/maemo/modest-platform.c: (modest_platform_init):
1808 Specify the libosso auto-save callback.
1810 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1812 * src/maemo/modest-platform.c:
1813 (modest_platform_set_update_interval):
1814 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1815 aparently stays valid between application instances, so we can use this
1816 to remove and reset it later. According to a maemo-developers email from
1819 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1821 * configure.ac: Depend on libalarm for Maemo.
1823 * src/dbus_api/modest-dbus-api.h:
1824 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1825 (on_send_receive), (modest_dbus_req_handler):
1826 Handle a SEND_RECEIVE D-Bus method.
1828 * libmodest-dbus-client/libmodest-dbus-client.c:
1829 (libmodest_dbus_client_send_and_receive):
1830 * libmodest-dbus-client/libmodest-dbus-client.h:
1831 Add C convenience functions for calling the new D-Bus method.
1833 * src/modest-platform.h:
1834 * src/gnome/modest-platform.c:
1835 * src/maemo/modest-platform.c:
1836 Added modest_platform_set_update_interval(), which uses the
1837 alarmd API on Maemo.
1838 (modest_platform_init),
1839 Call modest_platform_set_update_interval(), using a hard-coded
1840 interval for now (until the global settings dialog is implemented),
1841 though I am not sure that this makes sense yet.
1843 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1845 * src/dbus_api/modest-dbus-callbacks.c:
1846 (modest_osso_cb_hw_state_handler):
1847 * src/dbus_api/modest-dbus-callbacks.h:
1848 * src/maemo/modest-platform.c: (modest_platform_init):
1849 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1850 in case this has some effect on the ability for Maemo to ping the
1853 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1856 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1857 warning. It is probably a logic error, but I need to fix the build.
1859 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1861 * src/modest-account-mgr.h:
1862 * src/modest-account-mgr.c:
1863 (modest_account_mgr_account_names): Add a gboolean enabled_only
1864 parameter, so we can get lists of onlt the enabled accounts.
1866 (modest_account_mgr_add_account),,
1867 (modest_account_mgr_account_with_display_name_exists):
1868 * src/maemo/modest-msg-edit-window.c: (get_transports):
1869 * src/modest-account-mgr-helpers.c:
1870 (modest_account_mgr_set_first_account_as_default):
1871 * src/modest-init.c: (init_default_account_maybe):
1872 * src/modest-tny-account-store.c: (get_accounts):
1873 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1874 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1875 * tests/check_account-mgr.c: (START_TEST):
1876 Provide the extra parameter, as appropriate.
1878 * src/widgets/modest-account-view.c: (update_account_view):
1879 Do not show disabled accounts (meaning that there is no way to
1880 enable/disable accounts in the UI (the feature is not in our UI
1881 specification), so we can use this internally only to mark unfinished
1882 or temporary account data.
1884 * src/maemo/easysetup/modest-easysetup-wizard.c:
1885 (create_account): Add boolean enable parameter, so we can specify FALSE
1886 to create the temporary account.
1887 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1888 (on_before_next): When finishing, when there is a temporary account, just
1890 Also, use a timeout to delay the showing of the dialog until gconf is likely
1891 to return correct information, due to a maemo gconf bug that is fixed in
1892 osso 1.1, but not yet in Bora.
1893 However, the dialog stays on screen after it is destroyed.
1895 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1896 for invalid data when cancelling. Use a hildon note instead of a dialog
1897 to complain about invalid data. Do not show the account-saved note if the
1898 account is disabled (a temporary account that will not really be saved for use
1901 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1903 * src/modest-account-mgr-helpers.h:
1904 * src/modest-account-mgr-helpers.c:
1905 Added modest_account_mgr_unset_default_account(),
1906 Added modest_account_mgr_set_first_account_as_default().
1908 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1909 If it was the default account, unset the default account name.
1911 * src/maemo/modest-account-view-window.c:
1912 (on_delete_button_clicked): If it was the default account,
1913 set the first remaining account as the default instead.
1915 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1916 a NULL account or a NULL default account, to prevent a crash. This should
1917 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1920 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1922 * src/widgets/modest-recpt-editor.c:
1923 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1924 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1925 TODO comment for this. This fixes the build.
1927 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1928 be the best place for it. This will in future update all auto-update accounts,
1929 rather than just the current/default account, when that gconf key exists.
1930 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1931 if there are no accounts, before calling do_send_receive().
1932 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1934 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1935 * src/maemo/modest-main-window-ui.h:
1936 * src/maemo/modest-main-window.c: (on_connection_changed),
1937 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1938 directly, becaue the signal handler does more.
1940 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-account-mgr-helpers.c:
1943 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1944 for the case that the account does not exist.
1946 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1947 (equivalent to the modest account name) rather than the tinymail account name
1948 (equivalent to the modest account title - human readable) to get the account data.
1949 Check for null account data to prevent the crash, and add a TODO comment saying that
1950 this needs fixing because it is using the server account name instead of the account name.
1952 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1954 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1955 * src/maemo/modest-account-settings-dialog.c: (show_error),
1957 Use hildon_note_new_information() for informative and error messages,
1958 which seems to be expected for Maemo applications (no documentation that I know of
1959 says this). I am surprised that there is no distinction between info and error
1962 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1964 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1965 it is easy to find where this is used.
1967 * src/maemo/easysetup/modest-easysetup-wizard.c:
1968 (create_page_welcome), (create_page_account_details),
1969 (create_page_user_details), (create_page_complete_easysetup),
1970 (create_page_custom_incoming), (create_page_custom_outgoing),
1971 (create_page_complete_custom):
1972 * src/maemo/modest-account-settings-dialog.c:
1973 (create_page_account_details), (create_page_user_details),
1974 (create_page_incoming), (create_page_outgoing):
1975 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1977 (modest_connection_specific_smtp_edit_window_init):
1978 * src/maemo/modest-connection-specific-smtp-window.c:
1979 (modest_connection_specific_smtp_window_init):
1980 * src/maemo/modest-signature-editor-dialog.c:
1981 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1982 and scrolling policy as per the Email Application Layout Guide, if I have
1985 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1988 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1989 which were empty, because these vfuncs have been removed from TnyAccountStore.
1990 This fixes the build.
1992 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1994 * src/maemo/modest-main-window.c:
1995 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1996 showing/hiding it. Added TODO because it probably should not be NULL.
1997 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1998 because unnecessary g_warnings() make degugging difficult.
2000 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/modest-msg-edit-window.c:
2003 (modest_msg_edit_window_select_color),
2004 (modest_msg_edit_window_select_background_color): 2 const corrections and
2005 moving 2 #endifs before closing brackets, to fix the build.
2007 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/easysetup/modest-easysetup-wizard.h:
2010 * src/maemo/easysetup/modest-easysetup-wizard.c:
2011 (modest_easysetup_wizard_dialog_finalize),
2012 (on_button_edit_advanced_settings), (create_page_complete_custom),
2013 (on_response), (create_account):
2014 Implement the Advanced Settings edit button, by saving the account information,
2015 for the Advanded Settings dialog to use directly from gconf, and removing it
2016 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2017 Bug #5533 in the projects.maemo.org bugzilla.
2019 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/modest-msg-view-window.c:
2022 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2023 when opening a message window.
2025 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2027 * src/maemo/easysetup/modest-easysetup-wizard.c:
2028 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2031 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2032 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2033 gconf settings. I probably added more checks than necessary, but that is safer.
2035 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2036 variable to fix the build, but this seems to be used when it is still NULL.
2038 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2040 * src/modest-platform.h:
2041 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2042 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2043 * src/modest-main.c: Implement this function so we can avoid using
2044 maemo-specific API from cross-platform code.
2046 * src/modest-tny-account-store.c:
2047 (get_smtp_specific_transport_account_for_open_connection):
2048 * src/modest-ui-actions.c: (check_for_connection),
2049 (modest_ui_actions_on_item_not_found):
2050 Use modest_platform_connect_and_wait() and put #idefs around other
2051 maemo-specific code, because only maemo currently has a way to
2052 identify connection names.
2054 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-tny-account-store.h:
2057 * src/modest-tny-account-store.c:
2058 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2059 the connection-specific SMTP server settings in the configuration.
2061 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2063 * src/maemo/modest-main-window.c: (on_connection_changed),
2065 * src/modest-main.c: (main), (start_ui), (send_mail):
2066 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2067 that is what is intended.
2069 * src/modest-ui-actions.c: (action_send), (action_receive),
2070 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2071 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2072 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2073 SMTP server is used when it is specified.
2075 (modest_ui_actions_on_send_receive):
2076 Check that a connection is open before proceeding.
2077 Receive and then send, instead of vice-versa, as per the specification.
2079 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2081 * src/modest-mail-operation.c:
2082 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2083 though I guess it should be something other than NULL.
2085 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/easysetup/modest-easysetup-wizard.c:
2088 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2089 combo twice, to avoid an g_warning and to make it visible again.
2090 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2091 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2092 (already intended) dereference when detaching, because we then recreate the menu.
2093 But I am not sure why the warning was happening, and it is possible that this is a memory
2096 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2098 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2099 and uri_parse_mailto() utility functions.
2100 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2102 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2104 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2106 * src/dbus_api/modest-dbus-api.h:
2107 * src/dbus_api/modest-dbus-callbacks.c:
2108 Use an idle callback to execute the modest code in the application's own thread.
2109 Remove the helloworld example method.
2110 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2111 parsed, and the open-message method is not implemented because this is not yet implemented in
2113 * libmodest-dbus-client/libmodest-dbus-client.c:
2114 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2115 (libmodest_dbus_client_open_message):
2116 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2118 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2119 body without crashing.
2121 * tests/dbus_api/Makefile.am:
2122 * tests/dbus_api/test_mail_to.c:
2123 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2125 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2127 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2128 Added file to fix the build. Sorry.
2130 * src/dbus_api/Makefile.am:
2131 * src/dbus_api/modest-dbus-api.h:
2132 * src/dbus_api/modest-dbus-callbacks.h:
2133 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2134 (modest_dbus_req_handler):
2135 Put constants in a separate header so it can be reused by the
2136 client library, without duplication
2138 * libmodest-dbus-client/Makefile.am:
2139 * libmodest-dbus-client/libmodest-dbus-client.c:
2140 (libmodest_dbus_client_call_helloworld),
2141 (libmodfest_dbus_client_send_mail),
2142 (libmodfest_dbus_client_mailto),
2143 (libmodfest_dbus_client_open_message):
2144 * libmodest-dbus-client/libmodest-dbus-client.h:
2145 (Partly) Implement a send_mail D-Bus method.
2147 * tests/dbus_api/Makefile.am:
2148 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2149 the send_email D-Bus method.
2151 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2155 * libmodest-dbus-client/Makefile.am:
2156 * libmodest-dbus-client/libmodest-dbus-client.c:
2157 * libmodest-dbus-client/libmodest-dbus-client.h:
2158 * tests/dbus_api/Makefile.am:
2159 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2160 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2162 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2164 * src/maemo/easysetup/modest-easysetup-wizard.c:
2165 (create_page_account_details):
2166 * src/maemo/modest-account-settings-dialog.c:
2167 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2168 widgets, because this might not be the default in future versions of the Maemo GTK+.
2169 However, I can not not get capitalization to work even in a simple test case.
2171 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2173 * src/maemo/easysetup/modest-easysetup-wizard.c:
2174 (create_page_custom_incoming), (create_page_custom_outgoing):
2175 * src/maemo/modest-account-settings-dialog.c:
2176 (create_page_account_details), (create_page_incoming),
2177 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2178 instead of using gtk_check_button_with_label(), so they are aligned like the other
2179 widgets, as per the UI spec.
2181 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/easysetup/modest-easysetup-wizard.c:
2184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2185 * src/widgets/modest-validating-entry.c:
2186 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2187 Modest prefix instead of an EasySetup prefix.
2189 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2191 * src/widgets/modest-validating-entry.h:
2192 * src/widgets/modest-validating-entry.c: (on_insert_text),
2193 Added easysetup_validating_entry_set_max_func(), used to set a callback
2194 to call when the max number of characters is reached. GtkEntry has a max-length
2195 already but is silent about it.
2197 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2198 (create_page_account_details), (create_page_user_details),
2200 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2201 (create_page_account_details), (create_page_user_details),
2202 (create_page_outgoing):
2203 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2204 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2205 the UI spec, when the user tries to enter more than the max number of characters.
2207 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2209 * src/maemo/easysetup/modest-easysetup-wizard.c:
2210 (create_page_user_details), (create_page_custom_incoming),
2211 (create_page_custom_outgoing):
2212 * src/maemo/modest-account-settings-dialog.c:
2213 (create_page_user_details), (create_page_incoming),
2214 (create_page_outgoing):
2215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2216 (modest_connection_specific_smtp_edit_window_init):
2217 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2218 not appropriate. Bad Maemo-specific defaults!.
2220 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2223 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2224 (modest_signature_editor_dialog_set_settings):
2225 Disable the label and textview when the checkbox is disabled, and use the
2226 specified (UI spec) default signature text.
2228 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2231 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2233 * src/modest-defs.h:
2234 * src/modest-account-mgr-helpers.h:
2235 * src/modest-account-mgr-helpers.c:
2236 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2238 * src/maemo/Makefile.am:
2239 * src/maemo/modest-signature-editor-dialog.c:
2240 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2243 * src/maemo/modest-account-settings-dialog.h:
2244 * src/maemo/modest-account-settings-dialog.c:
2245 (modest_account_settings_dialog_finalize), (on_button_signature),
2246 (save_configuration): Use the new dialog when the Edit button is pressed, and
2247 save the changes if necessary, as per the UI spec.
2249 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/Makefile.am:
2252 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2253 based on maemo-develoers email from Dirk.
2255 * src/maemo/easysetup/modest-easysetup-wizard.c:
2256 (create_page_welcome), (create_page_account_details),
2257 (create_page_user_details), (create_page_complete_easysetup),
2258 (create_page_custom_incoming), (create_page_custom_outgoing),
2259 (create_page_complete_custom),
2260 (modest_easysetup_wizard_dialog_init):
2261 * src/maemo/modest-account-settings-dialog.c:
2262 (create_page_account_details), (create_page_user_details),
2263 (create_page_incoming), (create_page_outgoing),
2264 (modest_account_settings_dialog_init):
2265 * src/maemo/modest-connection-specific-smtp-window.c:
2266 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2268 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2270 * src/maemo/easysetup/modest-easysetup-wizard.c:
2271 (create_page_account_details), (create_page_custom_outgoing),
2272 (create_page_complete_custom):
2273 * src/maemo/modest-account-settings-dialog.c:
2274 (create_page_user_details), (create_page_incoming),
2275 (create_page_outgoing):
2276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2277 (modest_connection_specific_smtp_edit_window_init):
2278 Use the correct (UI spec) port min/max, and use horizontal separators,
2281 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/easysetup/modest-easysetup-wizard.c:
2284 (set_default_custom_servernames):
2285 * src/maemo/modest-account-settings-dialog.c:
2286 (create_page_incoming), (on_combo_outgoing_security_changed),
2287 (on_combo_incoming_security_changed), (create_page_outgoing),
2288 (modest_account_settings_dialog_set_account_name),
2289 (save_configuration):
2290 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2291 (on_combo_security_changed),
2292 (modest_connection_specific_smtp_edit_window_init),
2293 (modest_connection_specific_smtp_edit_window_set_connection),
2294 (modest_connection_specific_smtp_edit_window_get_settings):
2295 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2298 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2301 * src/maemo/easysetup/modest-easysetup-wizard.c:
2302 (create_page_custom_outgoing), (create_page_complete_custom):
2303 * src/maemo/modest-account-settings-dialog.c:
2304 (create_page_user_details), (create_page_outgoing):
2305 * src/maemo/modest-account-view-window.c: (button_box_new):
2306 Use changed logical IDs as per the most recent UI spec:
2307 mcen_bd_emailsetup_edit -> mcen_bd_edit
2308 mcen_bd_emailsetup_delete -> mcen_bd_delete
2309 mcen_bd_emailsetup_close -> mcen_bd_close
2311 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2315 * src/dbus_api/Makefile.am:
2316 * src/dbus_api/modest-dbus-callbacks.c:
2317 * src/dbus_api/modest-dbus-callbacks.h:
2318 * src/maemo/modest-platform.c: (modest_platform_init):
2319 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2321 * tests/Makefile.am:
2322 * tests/dbus_api/Makefile.am:
2323 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2325 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/modest-account-settings-dialog.c:
2328 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2329 Removed unnecessary includes.
2331 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2333 * src/maemo/easysetup/modest-easysetup-wizard.c:
2334 * src/maemo/modest-account-settings-dialog.c:
2335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2336 * src/widgets/Makefile.am:
2337 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2338 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2339 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2340 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2341 * src/widgets/modest-secureauth-combo-box.c:
2342 * src/widgets/modest-secureauth-combo-box.h:
2343 * src/widgets/modest-serversecurity-combo-box.c:
2344 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2345 made the GObject names more consistent with the rest of the Modest code.
2347 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/easysetup/Makefile.am:
2350 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2351 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2352 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2353 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2354 * src/maemo/easysetup/modest-easysetup-wizard.c:
2355 * src/maemo/easysetup/modest-validating-entry.c:
2356 * src/maemo/easysetup/modest-validating-entry.h:
2357 * src/maemo/modest-account-settings-dialog.c:
2358 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2359 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2360 widgets/ because they are used outside of easysetup too. After checking in,
2361 svn will allow me to rename them too.
2363 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2365 * src/gnome/modest-msg-edit-window.c:
2366 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2367 linker error, to fix the build on the GNOME platform.
2368 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2369 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2370 ifdefed out to avoid a warning.
2372 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2374 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2375 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2376 some alternative for GTK+ 2.6.
2378 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2380 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2382 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2383 specified for EmailAccountsDialog in UI spec.
2385 * src/maemo/easysetup/modest-easysetup-wizard.c:
2386 * src/maemo/easysetup/modest-easysetup-wizard.h:
2387 * src/maemo/modest-account-settings-dialog.c:
2388 * src/maemo/modest-account-settings-dialog.h:
2389 Reuse a member window widget for the connection-specific SMTP server accounts,
2390 so we can tell it to create/save the accounts only if we actually save changes.
2392 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2393 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2394 (modest_connection_specific_smtp_edit_window_get_settings):
2395 Return a struct instance for temporarily remembering the entered data.
2397 * src/maemo/modest-connection-specific-smtp-window.h:
2398 * src/maemo/modest-connection-specific-smtp-window.c:
2399 (modest_connection_specific_smtp_window_finalize),
2400 (modest_connection_specific_smtp_window_fill_with_connections),
2402 (modest_connection_specific_smtp_window_save_server_accounts),
2403 (update_model_server_names): Do not actually save data until asked,
2404 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2406 (on_selection_changed),
2407 (modest_connection_specific_smtp_window_init): Disable the edit
2408 button when nothing is selected.
2410 * src/modest-account-mgr-helpers.c:
2411 * src/modest-account-mgr-helpers.h:
2412 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2415 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2417 * src/modest-account-mgr-helpers.h:
2418 * src/modest-account-mgr-helpers.c:
2419 (modest_account_mgr_get_unused_account_name),
2420 (modest_account_mgr_get_unused_account_display_name): Added these
2421 utility functions, to avoid code duplication.
2423 * src/maemo/easysetup/modest-easysetup-wizard.c:
2424 (create_page_account_details), (create_account):
2425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2426 (on_combo_security_changed),
2427 (modest_connection_specific_smtp_edit_window_init),
2428 (modest_connection_specific_smtp_edit_window_save_settings):
2429 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2430 * src/maemo/modest-connection-specific-smtp-window.c:
2431 (modest_connection_specific_smtp_window_finalize),
2432 (modest_connection_specific_smtp_window_fill_with_connections),
2433 (on_button_edit), (modest_connection_specific_smtp_window_init):
2434 * src/maemo/modest-connection-specific-smtp-window.h:
2435 Implementing saving of connection-specific server accounts.
2437 But I need to refactor this so we can save the data for each
2438 possible connection-specific account and only actually create the server accounts
2439 when the easysetup finished, or the OK button is pressed on the account settings
2442 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2445 (on_combo_security_changed):
2446 (modest_connection_specific_smtp_edit_window_init):
2447 Auto-fill the port number as in the account settings.
2449 (modest_connection_specific_smtp_edit_window_set_connection):
2450 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2451 * src/maemo/modest-connection-specific-smtp-window.c:
2452 (fill_with_connections), (on_button_edit),
2453 (modest_connection_specific_smtp_window_init):
2454 Turn the edit window into a dialog to simplify the code, and
2455 set a WM hint as in a GtkDialog, because only a popup can be on top of
2456 another window in Maemo, and popups usually have no WM decoration.
2458 * src/modest-defs.h:
2459 * src/modest-account-mgr-helpers.c:
2460 (modest_account_mgr_set_connection_specific_smtp),
2461 (modest_account_mgr_remove_connection_specific_smtp),
2462 (modest_account_mgr_get_connection_specific_smtp):
2463 * src/modest-account-mgr-helpers.h: Some functions to write the
2464 connection-specific SMTP server information. Not yet used.
2467 * src/widgets/modest-folder-view.c: (text_cell_data):
2468 Fix a warning about an uninitialized variable.
2469 (on_configuration_key_changed): Put an #ifdef around the use
2470 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2472 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2474 * src/maemo/modest-account-settings-dialog.h:
2475 * src/maemo/modest-account-settings-dialog.c:
2476 Added connect_for_modified() utility function to mark the new modified boolean.
2478 (create_page_account_details), (create_page_user_details),
2479 (create_page_incoming), (create_page_outgoing), (on_response),
2480 (modest_account_settings_dialog_init),
2481 (modest_account_settings_dialog_set_account_name):
2482 Only warn about unsaved changes when there are actually unsaved changes.
2484 * src/modest-account-mgr-helpers.c:
2485 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2486 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2487 to get the data from there in future.
2489 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-defs.h:
2493 * src/modest-account-mgr-helpers.h:
2494 * src/modest-account-mgr-helpers.c:
2495 Store the security account setting in a single conf key instead of using
2496 the options list, so that the list is left for just the to-be-removed camel hack,
2497 and because gconf_client_set_list() is failing for some reason.
2499 * src/modest-account-mgr.c:
2500 (modest_account_mgr_add_server_account):
2501 * src/maemo/modest-account-settings-dialog.c:
2502 (modest_account_settings_dialog_set_account_name),
2503 (save_configuration): Use the renamed functions.
2506 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2508 * src/widgets/Makefile.am:
2509 * src/widgets/modest-limit-retrieve-combo-box.c:
2510 * src/widgets/modest-limit-retrieve-combo-box.h:
2511 * src/widgets/modest-retrieve-combo-box.c:
2512 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2513 the account settings dialog.
2515 * src/modest-defs.h:
2516 * src/modest-account-mgr-helpers.h:
2517 * src/modest-account-mgr-helpers.c:
2518 (modest_server_account_get_option_secure_auth),
2519 (modest_server_account_set_option_secure_auth):
2520 * src/modest-account-mgr.c:
2521 (modest_account_mgr_add_server_account):
2522 Use the existing AUTH_MECH conf key for the secure-auth setting,
2523 instead of putting it in the list options, because this was actually used already.
2525 * src/maemo/modest-account-settings-dialog.c:
2526 (create_page_account_details),
2527 (modest_account_settings_dialog_set_account_name),
2528 (save_configuration):
2529 * src/maemo/modest-account-settings-dialog.h:
2530 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2531 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2533 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2535 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2536 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2537 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2539 * src/modest-defs.h:
2540 * src/maemo/modest-account-settings-dialog.c:
2541 (create_page_incoming), (on_combo_outgoing_security_changed),
2542 (on_combo_incoming_security_changed), (create_page_outgoing),
2543 (modest_account_settings_dialog_set_account_name),
2544 (save_configuration): Load/Save the port number, and change it when the
2545 security combo changes, to suitable defaults.
2547 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2549 * src/modest-account-mgr.c:
2550 (modest_account_mgr_add_server_account): Set the security and secure-auth
2551 options, and add a comment saying that the other camel-specific options should be
2554 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2558 * src/modest-tny-account-store.c: (account_list_free),
2559 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2560 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2563 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2565 * src/modest-protocol-info.c:
2566 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2567 is required by our UI spec. Maybe something in our implementation will use this eventually.
2568 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2569 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2570 instead of the previous 0 placeholder.
2572 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2573 secure-auth settings.
2574 * src/modest-account-mgr-helpers.h:
2575 * src/modest-account-mgr-helpers.c:
2576 (modest_server_account_data_get_option_secure_auth),
2577 (modest_server_account_set_option_secure_auth),
2578 (modest_server_account_data_get_option_security),
2579 (modest_server_account_set_option_security): Added this API for getting and setting the security
2580 and secure-auth settings.
2582 * src/maemo/modest-account-settings-dialog.h:
2583 * src/maemo/modest-account-settings-dialog.c:
2584 (modest_account_settings_dialog_finalize), (check_data),
2585 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2586 about changing titles.
2587 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2588 (save_configuration): Save the security and secure-auth settings.
2590 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2591 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2593 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-defs.h:
2596 * src/modest-account-mgr.c:
2597 (modest_account_mgr_add_server_account):
2598 Added and used defines for the options key and value pair strings,
2599 that are used so far, though they do not seem to correspond to anything in our
2600 UI specs or ModestProtocol enum.
2602 * src/modest-account-mgr-helpers.h:
2603 * src/modest-account-mgr-helpers.c:
2604 (compare_option_strings_for_name),
2605 (modest_server_account_data_get_option_value),
2606 (modest_server_account_data_get_option_bool),
2607 (modest_account_mgr_get_server_account_option):
2608 Added helper functions for parsing the options GSList.
2610 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2613 display name is based on the supplied account name.
2614 * src/modest-account-mgr.c:
2615 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2616 with an inefficient, but good-enough, implementation.
2618 * src/maemo/easysetup/modest-easysetup-wizard.c:
2619 (create_page_account_details), (on_before_next), (create_account):
2620 Check for existing display names rather than (non-user-visible) account names, and just
2621 create and set a unique account name at the end.
2623 * src/maemo/modest-account-settings-dialog.c:
2624 (modest_account_settings_dialog_init),
2625 (modest_account_settings_dialog_set_account_name),
2626 (create_page_incoming): Show the display name, instead of the account name.
2627 (on_response): Do some (not all) extra checks, as in the UI spec.
2628 (save_configuration): Save the display name if it was changed.
2630 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2632 * po/en_GB.po: Added needed logical ID and translation.
2633 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2634 (init_view): Made the is-default column clicking work.
2636 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2639 * src/maemo/easysetup/Makefile.am:
2640 * src/maemo/easysetup/modest-easysetup-wizard.c:
2641 (modest_easysetup_wizard_dialog_init):
2642 * src/maemo/easysetup/provider-data-test.keyfile:
2643 * src/maemo/easysetup/provider-data.keyfile:
2644 Moved the provider data file to the new modest-providers-data package and used it from there.
2646 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2648 * src/modest-local-folder-info.c:
2649 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2650 N_() was already used on the static strings, but this just marks it for translation without
2651 using the translation.
2653 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/modest-account-settings-dialog.c:
2656 (create_page_incoming),
2657 (modest_account_settings_dialog_set_account_name):
2658 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2659 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2660 I will do this if nobody else gets there first.
2662 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2664 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2665 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2666 save the security stuff.
2668 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2670 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2671 Set the email address and user fullname, which I now see must be
2674 * src/maemo/modest-account-settings-dialog.h:
2675 * src/maemo/modest-account-settings-dialog.c:
2677 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2678 leave-on-server and authentication.
2679 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2682 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/modest-account-settings-dialog.c:
2686 * src/maemo/modest-account-settings-dialog.h:
2687 Most (but not all) of the widgets are now present as specified by the UI spec.
2688 No changes are yet saved, and some details are not properly shown yet.
2690 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2692 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2694 * src/maemo/Makefile.am:
2695 * src/maemo/modest-account-settings-dialog.c:
2696 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2697 an existing account. Doesn't do much yet.
2699 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2700 Open the accounts settings dialog when Edit is clicked.
2702 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2704 * src/maemo/easysetup/Makefile.am:
2705 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2707 * src/maemo/easysetup/modest-easysetup-wizard.c:
2708 (modest_easysetup_wizard_dialog_init):
2709 Try to get the source directory from the build system,
2710 instead of hard-coding "./" into the source code, when opening our local
2711 copies of the configuration files.
2712 But this still fails when opening the wizard from the Accounts window,
2713 maybe because the working directory seems to change at runtime.
2714 So the wizard will fail the second time unless you copy the files into their
2715 proper locations - see the stdout warnings for the paths.
2717 (create_page_account_details),(on_before_next):
2718 Check for existing non-server accounts instead of server accounts,
2719 so the default account name is useful again, and to prevent trying to
2722 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2723 Show the wizard when New is clicked.
2725 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2726 (init_view): Show the column headers, and show the columns that are
2727 specified in the UI specs. However, something in Maemo's GTK+ prevents
2728 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2729 change the default account. This is despite unsetting the special properties.
2731 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2733 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2734 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2735 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2736 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2737 to make that clearer.
2738 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2740 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2742 * src/maemo/modest-account-view-window.c:
2743 (modest_account_view_window_init),
2744 (modest_account_view_window_new):
2745 Use the same buttons as specified in the
2746 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2747 the existing widgets, which never had a chance of working.
2748 Put the ModestAccountView treeview in a scrolled window.
2749 Do not repeat the initialization in both _init() and _new().
2751 * src/widgets/modest-account-view.c: (update_account_view):
2752 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2753 this widget and window shows no accounts.
2755 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2757 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/easysetup/modest-easysetup-wizard.c:
2760 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2761 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2762 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2765 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2766 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2767 accounts exist yet, as in the UI spec.
2769 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2771 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/Makefile.am:
2774 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2775 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2776 New window for editing connection-specific smtp details.
2777 Not fully implemented.
2779 * src/maemo/modest-connection-specific-smtp-window.c:
2780 (modest_connection_specific_smtp_window_finalize) :
2781 unref the tree model.
2782 (on_button_edit): Show the edit window.
2784 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2786 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2789 * src/maemo/Makefile.am:
2790 * src/maemo/modest-connection-specific-smtp-window.c:
2791 * src/maemo/modest-connection-specific-smtp-window.h:
2792 New window for showing the list of connections, for connection-specific
2793 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2794 * src/maemo/easysetup/modest-easysetup-wizard.c:
2795 (create_page_custom_outgoing): Show the new window when the button is clicked.
2797 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2800 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2801 * src/maemo/modest-msg-edit-window.c:
2802 (modest_msg_edit_window_insert_image):
2803 * src/modest-conf.c: (modest_conf_key_escape):
2804 * src/modest-mail-operation.c:
2805 (modest_mail_operation_send_new_mail):
2806 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2807 (modest_ui_actions_on_new_account):
2808 * src/widgets/modest-attachment-view.c: (update_filename_request):
2809 * src/widgets/modest-mail-header-view.c:
2810 Corrected warnings that were breaking the build, by commenting out unused variables,
2811 and a function, and by including a header.
2813 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2815 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2816 so we can #ifdef around platform-specific code when necessary.
2817 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2818 to allow this to build for the GNOME platform too.
2820 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2822 * src/maemo/easysetup/modest-easysetup-wizard.c:
2823 Added util_increment_name() and used it in create_page_account_details()
2824 to make sure that the default account name is always a new name.
2826 (modest_easysetup_wizard_dialog_init),
2827 (set_default_custom_servernames): Some minor memory management fixes.
2829 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2833 * src/modest-runtime.c: (init_i18n): Restored the translation
2834 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2835 are defined in config.h, and the translations are installed.
2837 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2838 is defined for translation.
2840 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2844 * src/maemo/easysetup/modest-easysetup-wizard.c:
2845 (modest_easysetup_wizard_dialog_init):
2846 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2847 Use realistic paths (though they should use $prefix generically) to the
2848 mcc_mapping and provider-data.keyfile files which might work when they
2849 are installed by the future version of the operator-wizard package,
2850 and then fallback to paths in our source code, with an explanatory
2853 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/Makefile.am:
2858 * src/maemo/easysetup/: Added files from the previously-exernal
2859 osso-modest-easysetup.
2860 * src/maemo/modest-main-window-ui.h:
2861 * src/modest-ui-actions.c:
2862 * src/modest-ui-actions.h:
2863 Added modest_ui_actions_on_new_account() as a signal handler for the
2864 New Account menu item. It shows the easysetup wizard.
2865 * po/en_GB.po: Added additional needed logical IDs and translations.
2867 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2868 Apparently ChangeLog is not used for some vague Nokia legal reasons.