1 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 Added scrollbars to account wizard dialog.
5 Fixed projects.maemo.org NB #62744
7 2007-07-16 Murray Cumming <murrayc@murrayc.com>
9 * src/widgets/modest-msg-view.h:
10 * src/widgets/modest-msg-view.c:
11 Added modest_msg_view_get_message_is_empty() but this needs
13 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
14 Check if there is any text in the message yet.
15 But this needs to be implemented properly.
16 (modest_msg_edit_window_toggle_find_toolbar):
17 * src/maemo/modest-msg-view-window.c:
18 (modest_msg_view_window_toggle_find_toolbar):
19 Show a banner warning if there is no text to search, when
20 trying to start a search. This partially fixes
21 projects.maemo.org bug NB#62350.
23 2007-07-13 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-mail-operation.c: (update_account_thread):
26 Initialized num_new_headers to fix the build.
28 2007-07-13 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
31 Ignore modest accounts whose server accounts don't exist in gconf.
32 This prevents us trying to create TnyAccount instances for those
33 server accounts when the server account has been removed from gconf,
34 but the parent modest account has not yet been removed from modest.
35 I don't know why this is only noticeable now. It was probably just
36 a harmeless g_warning() anyway.
38 2007-07-13 Murray Cumming <murrayc@murrayc.com>
40 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
41 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
43 2007-07-12 Armin Burgmeier <armin@openismus.com>
45 * src/maemo/modest-main-window.c: Make default account appear bold
46 in view, tools/send & receive and toolbar/send & receive SCM menus.
47 This fixes projects.maemo.org bug NB#59010.
49 2007-07-12 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
52 Add a short-cut, by checking if the folder store is an account.
53 This ensures that the Sort menu item and toolbar is dimmed for
54 the local-folders account root item, fixing
55 projects.maemo.org bug NB#62545.
57 2007-07-12 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-account-store.c: (get_password):
60 Show the password dialog (via the signal) only in the mainloop, via
61 an idle handler that we wait for. This could theoretically prevent
62 hangs, though I worry that it could introduce some too.
64 2007-07-12 Murray Cumming <murrayc@murrayc.com>
66 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
67 * src/maemo/modest-platform.c:
68 (modest_platform_connect_and_wait):
69 Take a TnyAccount* parameter and try to set it to online
70 (a TnyCamel-only API), because tinymail sets accounts to offline
71 when the user cancels a password dialog, and doesn't ask again until
72 it has been set to online.
73 However, this is commented out because it causes a hang now.
75 (modest_platform_connect_and_wait_if_network_account):
76 * src/modest-mail-operation.c:
77 (modest_mail_operation_update_account):
78 * src/modest-platform.h:
79 * src/modest-ui-actions.c: (_modest_ui_actions_open),
80 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
82 2007-07-12 Armin Burgmeier <armin@openismus.com>
84 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
86 * src/modest-mail-operation.c:
87 * src/modest-ui-actions.c: Check for already existing folder before
88 querying the server, show error message from camel if the request
89 still fails. This fixes projects.maemo.org bug NB#58701.
91 2007-07-12 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-tny-account-store.h:
94 * src/modest-tny-account-store.c:
95 Added modest_tny_account_store_forget_password_in_memory(),
96 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
97 when creating a new account, so that new passwords will be used, instead of
98 us thinking that it's a second request as a result of a failed password again.
100 2007-07-12 Murray Cumming <murrayc@murrayc.com>
102 * src/dbus_api/modest-dbus-callbacks.c:
103 (on_idle_open_message): If the message is in drafts then open it
104 in an edit window instead of a view window. This fixes
105 projects.maemo.org bug NB#63005.
107 2007-07-12 Murray Cumming <murrayc@murrayc.com>
109 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
110 Avoided a harmless g_warning().
112 2007-07-12 Murray Cumming <murrayc@murrayc.com>
114 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
115 Pass the modest account name, not the TnyAccount display name to
116 modest_msg_view_window_new() so that the reply feature works,
117 fixing projects.maemo.org bug NB#62892.
119 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
120 (modest_msg_view_window_new_with_header_model):
121 * src/maemo/modest-msg-view-window.c:
122 (modest_msg_view_window_new_with_header_model),
123 (modest_msg_view_window_new):
124 * src/modest-ui-actions.c: (reply_forward):
125 * src/widgets/modest-msg-view-window.h:
126 * src/widgets/modest-window.c: (modest_window_set_active_account):
127 Rename an account parameter to modest_account_name to make this clearer.
129 2007-07-11 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-ui-actions.h:
132 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
133 modest_do_message_delete().
134 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
135 Call modest_do_message_delete(), hoping that this would cause messages
136 to be really deleted from search instead of just marked with strike through.
137 Does not seem to help.
139 2007-07-11 Armin Burgmeier <armin@openismus.com>
141 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
142 priv->reselect to FALSE prior to calling
143 modest_folder_view_select_first_inbox_or_local() to prevent endless
144 recursion and thus a crash on startup.
146 2007-07-11 Armin Burgmeier <armin@openismus.com>
148 * src/maemo/modest-account-settings-dialog.h: Include
149 <gtk/gtknotebook.h> to fix the build (at least for me).
151 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
152 Use "New FolderN" as default suggested name if "New folder" already
153 exists, with N being the first free number, though never exceed "New
154 folder99" in which case we just fall back to "New Folder" even though
155 it already exists. This fixes projects.maemo.org bug NB#58663.
157 2007-07-11 Murray Cumming <murrayc@murrayc.com>
159 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
160 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
161 projects.maemo.org bug NB#62778.
163 2007-07-11 Murray Cumming <murrayc@murrayc.com>
165 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
166 Ignore the wrong (for now) secure-smtp setting in the presets -
167 just default to requiring secure authentication for SMTP, because
170 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
172 * src/widgets/modest-folder-view.c: (filter_row)
173 Do not show drafts folder (see UI specs)
175 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
177 * src/modest-ui-actions.c:
178 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
179 place and also not necessary.
181 * src/widgets/modest-folder-view.c: (filter_row)
182 Guess folder type and hide Sent & Outbox if necessary.
183 Fixed project.maemo.org NB#57328
185 2007-07-11 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-ui-actions.h:
188 * src/modest-ui-actions.c:
189 (modest_ui_actions_on_delete_message):
190 Move some code into a new
191 modest_ui_actions_refresh_message_window_after_delete()
192 function so we can use it from elsewhere.
194 * src/dbus_api/modest-dbus-callbacks.c:
195 (on_idle_delete_message), (on_delete_message): Used an idle
196 handler, as we do for the other D-Bus method handlers.
197 Call modest_ui_actions_refresh_message_window_after_delete()
198 if the deleted message was open in a window. This fixed
199 projects.maemo.org bug NB#62862.
201 2007-07-11 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-main.c: (main): Only show the UI at the start if
204 the showui command line option was given. For instance,
205 run-standalone src/modest showui
206 Otherwise, we wait for the top_application D-Bus method to
207 be sent by hildon-desktop when the application is selected
209 This allows us to run without a UI when osso-global-search
210 uses our D-Bus methods.
212 2007-07-11 Murray Cumming <murrayc@murrayc.com>
214 * src/dbus_api/modest-dbus-api.h: Added a define for a
215 top-application D-Bus method.
216 * src/dbus_api/modest-dbus-callbacks.c:
217 (on_top_application),
218 (modest_dbus_req_handler): Handle the top-application D-Bus
219 method, which might be an undocumented D-Bus signal sent by
220 hildon-desktop when it starts the application from the menu.
221 But I am not sure and I need to test it on the device, because
222 my scratchbox does not have the application in the menu now.
223 This method shows the main window, so that it can be invisible
224 when started, for instance, just for email searching from
227 * src/maemo/modest-main-window.c: (restore_settings),
228 (modest_main_window_new): Do not show the window immediately
229 upon creation. We show it later.
230 * src/modest-widget-memory.c: (save_settings_paned):
231 Try (unsuccessfully) to avoid saving the paned position when
232 it is not even visible.
233 (restore_settings_paned): Do not allow a silly paned position.
234 This seems necessary when not showing the window at first.
236 * tests/dbus_api/Makefile.am:
237 * tests/dbus_api/test_top_application.c: (main): Test for the
240 2007-07-10 Murray Cumming <murrayc@murrayc.com>
242 * src/modest-ui-dimming-rules.c:
243 (modest_ui_dimming_rules_on_new_msg),
244 (modest_ui_dimming_rules_on_reply_msg),
245 (modest_ui_dimming_rules_on_delete_msg),
246 (modest_ui_dimming_rules_on_details),
247 (modest_ui_dimming_rules_on_view_window_move_to),
248 (modest_ui_dimming_rules_on_view_previous),
249 (modest_ui_dimming_rules_on_view_next),
250 (_invalid_folder_for_purge): Added checks before
251 casting the window. This looks like an actual
252 logic error in _invalid_folder_for_purge(), because it
253 tries to use a ModestMainWindow as a message window.
255 2007-07-10 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/modest-account-settings-dialog.c:
258 (show_error): Use the same implementation as in
259 modest-easysetup-wizard.c:
260 (on_entry_invalid_character): The logical ID contains a %s.
261 Guessed what it should be.
262 (on_entry_max), (check_data), (on_response): Adapt to
263 changed show_error().
264 (create_page_account_details): Really call
265 modest_validating_entry_set_func() on the correct widgets.
266 * src/maemo/easysetup/modest-easysetup-wizard.c:
267 (on_entry_invalid_character): Fix the logical ID here too.
268 (create_page_account_details),
269 (create_page_user_details):
271 modest_validating_entry_set_func() on the correct widgets.
273 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
274 Do not try to use the account if it is NULL.
276 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
278 * src/modest-ui-actions.c: (create_move_to_dialog),
279 (modest_ui_actions_on_main_window_move_to),
280 (modest_ui_actions_on_msg_view_window_move_to):
281 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
282 (filter_row), (modest_folder_view_show_non_move_folders):
283 * src/widgets/modest-folder-view.h:
285 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
286 the Sent folder yet as it does not report the correct folder type.
288 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
290 * src/maemo/modest-msg-edit-window.c: (init_window):
293 2007-07-10 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
296 Take a parent widget instead of a parent window, and
297 implement this with hildon_banner_show_information() instead.
298 Non-Maemo builds can just ifdef that there.
299 This fixed projects.maemo.org bug NB#62766.
301 (on_entry_invalid_character): Use show_error() again instead
302 of using hildon directly, and use the _CS() macro to use the correct
304 (create_account), (check_for_supported_auth_methods), (on_entry_max):
305 Pass a widget instead od a window to show_error().
307 2007-07-10 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
310 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
311 This allows us to show the server name in the error message, fixing
312 projects.maemo.org bug NB#62904.
313 Also, use the appropriate logical ID message for the account protocol.
315 2007-07-10 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-tny-account-store.c: (on_idle_wrong_password):
318 A compilation fix, though the build wasn't broken for me.
320 2007-07-09 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
323 Do not try to unref a NULL folder store, to avoid a runtime warning.
324 This seems to happen sometimes when changing accounts settings.
326 2007-07-09 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account-store.c:
329 (modest_tny_account_store_instance_init),
330 (modest_tny_account_store_finalize),
331 (on_account_settings_hide), (on_idle_wrong_password):
332 Use a GHashTable to ensure that we only show one account settings
333 dialog per modest account. This avoids us having a dialog open for
334 both the store and transport accounts, or due to repeated get_password()
335 calls that shouldn't happen anyway.
337 2007-07-09 Murray Cumming <murrayc@murrayc.com>
339 * src/maemo/modest-maemo-utils.c: (on_hide),
340 (modest_maemo_show_dialog_and_forget): Handle the response, because
341 the window is not even hidden by default.
343 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
344 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
345 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
346 which seems to prevent some modality problems.
348 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
349 Ignore user cancellation errors.
351 * src/modest-account-mgr-helpers.h:
352 * src/modest-account-mgr-helpers.c:
353 Added modest_server_account_get_password() and
354 modest_server_account_get_has_password() to avoid direct use of
357 * src/maemo/modest-account-settings-dialog.h:
358 * src/maemo/modest-account-settings-dialog.c:
359 (modest_account_settings_dialog_init): Store the notebook so we can
361 Added modest_account_settings_dialog_switch_to_user_info().
363 * src/modest-tny-account-store.c:
364 (get_password): When the password in the account settings is wrong (we think),
365 show the relevant page of the account settings dialog, in the mainloop.
366 However, we currently get many of these at once because cancel does not
368 (forget_password): Do not forget the password
369 from the account settings, because this causes side-effects when
370 tinymail seems to call it at strange time, maybe because of how we
371 are cancelling get_password().
372 (modest_tny_account_store_alert): Ignore user cancellations.
374 2007-07-09 Murray Cumming <murrayc@murrayc.com>
376 * src/maemo/modest-maemo-utils.h:
377 * src/maemo/modest-maemo-utils.c:
378 Added modest_maemo_show_information_note_and_forget() for use instead of
379 gtk_dialog_run() when the response is not needed, to avoid an extra
380 mainloop which could cause a hang.
382 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
383 Use the logical IDs for the error message, though they are not
384 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
385 because gtk_dialog_run() caused a hang here (the window did not close).
386 This fixes projects.maemo.org bug NB#62646.
388 2007-07-09 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-account-mgr-helpers.h:
391 * src/modest-account-mgr-helpers.c:
392 Added modest_account_mgr_get_store_protocol().
394 * src/maemo/modest-account-view-window.c:
395 (on_delete_button_clicked): Show different warning text depending on
396 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
397 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
400 2007-07-09 Murray Cumming <murrayc@murrayc.com>
402 * src/maemo/modest-msg-edit-window.c:
403 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
404 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
406 2007-07-07 Armin Burgmeier <armin@openismus.com>
408 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
409 ckdg_ib_maximum_characters_reached from correct package.
411 * src/modest-ui-actions.c: Show an error message when a folder could
412 not be created. Tinymail does not give us specific error codes about
413 what has gone wrong, so we assume that a folder with that name
414 already exists, though there might be other reasons.
416 2007-07-06 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
419 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
420 give a more exact error message that can be partly translated.
422 2007-07-05 Murray Cumming <murrayc@murrayc.com>
424 * src/maemo/modest-address-book.c:
425 (select_email_addrs_for_contact): Specify a default window size for the
426 select-email-address dialog, so that it is probably big enough for the
427 title. This should fix projects.maemo.org bug NB#62277.
429 2007-07-05 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/easysetup/modest-easysetup-wizard.c:
432 (create_page_complete_easysetup): Use
433 gtk_widget_set_size() request to ensure that the text wraps
436 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
438 * src/maemo/easysetup/modest-easysetup-wizard.c:
439 (on_entry_invalid_character), (create_page_account_details),
440 (create_page_user_details):
441 Use new API of ModestValidatingEntry. But for some reason the banner is
442 not shown. I will have to investigate that further.
444 * src/widgets/modest-validating-entry.c: (on_insert_text),
445 (modest_validating_entry_set_func):
446 * src/widgets/modest-validating-entry.h:
447 Added a new callback function to be able to react to prevented
448 characters whitespaces to e.g show a banner.
450 2007-07-05 Armin Burgmeier <armin@openismus.com>
452 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
453 notification of HildonNumberEditor instead of remembering the port
454 number. Thanks to Johannes for pointing this out.
456 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
458 * src/maemo/easysetup/modest-easysetup-wizard.c:
459 Check if there are any user changes before showing a confirmation
460 dialog (projects.maemo.org NB#60946)
462 2007-07-05 Armin Burgmeier <armin@openismus.com>
464 * src/maemo/modest-account-settings-dialog.c: Remember custom port
465 number at the beginning of the dialog and set the modified flag at the
466 end if the port number has changed. This is necessary because
467 HildonNumberEditor does not support notification when the value has
470 2007-07-05 Murray Cumming <murrayc@murrayc.com>
472 * src/modest-ui-actions.c:
473 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
474 a connection before asking anything else. Correct the check for the destination
475 folder so that it succeeds when online.
476 This fixed projects.maemo.org bug NB#61645.
478 2007-07-05 Murray Cumming <murrayc@murrayc.com>
480 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
481 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
482 to fix projects.maemo.org bug NB#62439.
484 2007-07-05 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-tny-account.c: (on_connection_status_changed):
487 Really do not use tny_device_force_offline() here. See the previous comment.
489 2007-07-04 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-tny-account.c: (on_connection_status_changed):
492 Do not use tny_device_force_offline() when tinymail says that something
493 went wrong with the connection. It seems to report this unnecessarily.
495 2007-07-04 Murray Cumming <murrayc@murrayc.com>
497 * src/maemo/modest-connection-specific-smtp-window.c:
498 (modest_connection_specific_smtp_window_init):
499 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
500 does not seem to have any effect in osso 1.1 (though it works in
501 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
503 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
505 * src/maemo/modest-connection-specific-smtp-window.c:
506 Fix UI specification problems with projects.meamo.org NB#60479
508 2007-07-04 Murray Cumming <murrayc@murrayc.com>
510 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
511 clue when this has failed, because the error dialog is not always shown
512 (at least in earlier version).
514 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
515 GError message, because the generic error dialog is not helpful.
517 'This message is not currently available (can't let a new connection go online)'
518 when trying to open an IMAP message.
520 (_modest_ui_actions_open): Offer a connection when some messages would
521 have to be downloaded and we are offline.
523 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
525 * src/widgets/modest-folder-view.c:
526 Don't check for MERGE type anymore as we use the correct type
528 NOTE: For the last two changes you need to update your tinymail copy
529 because of API changes!
531 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
533 * src/modest-tny-local-folders-account.c:
534 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
535 (see projects.maemo.org NB#61580)
537 2007-07-04 Murray Cumming <murrayc@murrayc.com>
539 * src/modest-tny-account.c: (on_connection_status_changed):
540 Commented out the call to modest_platform_connect_and_wait() because this
541 seems to always hang, and I would like to know if this is the only thing
542 that causes a hang when showing the connection dialog.
543 It is not very useful anyway.
545 2007-07-04 Murray Cumming <murrayc@murrayc.com>
547 * src/maemo/modest-msg-view-window.c:
548 (modest_msg_view_window_select_next_message):
550 * src/modest-platform.h:
551 * src/maemo/modest-platform.c:
552 Added modest_platform_connect_and_wait(), which calls
553 tny_maemo_conic_device_connect() always in the main thread, by calling it
554 in an idle handler and waiting for the idle handler to run. It should be
555 in the main thread because it uses GTK+ UI code. It just returns TRUE
556 if the device is already online.
558 There is some nasty code to ensure that subsequent calls to
559 modest_platform_connect_and_wait() just wait for the first one to finish,
560 by checking repeatedly in another idle handler. This is necessary,
561 because other threads (or even the main thread, via another idle handler)
562 can call modest_platform_connect_and_wait() while
563 modest_platform_connect_and_wait() is running.
565 (modest_platform_connect_and_wait_if_network_account),
566 (modest_platform_connect_and_wait_if_network_folderstore):
567 Convenience functions that calls modest_platform_connect_and_wait() if
568 the account or folder might want network access.
570 * src/modest-mail-operation.c:
571 (modest_mail_operation_update_account):
572 * src/modest-ui-actions.c: (download_uncached_messages),
573 (modest_ui_actions_on_rename_folder), (delete_folder),
574 (modest_ui_actions_on_main_window_move_to),
575 (modest_ui_actions_on_msg_view_window_move_to):
576 * src/widgets/modest-folder-view.c:
577 (drag_and_drop_from_folder_view):
578 Offer a connection if we are offline.
580 * src/modest-tny-account.c: (on_connection_status_changed):
581 Document this as only handling errors during network operations in progress,
582 and replace the idle code with a simple call to
583 modest_platform_connect_and_wait(), which does this instead.
585 2007-07-03 Murray Cumming <murrayc@murrayc.com>
587 * src/modest-tny-account.c:
588 (modest_tny_account_get_special_folder): (util_on_idle),
589 Handle the GError so we can see when tny_folder_store_get_folders()
590 fails, as it currently does while something else is connecting.
592 Added util_run_in_main_thread_and_wait()
593 which uses an idlen handler and mainloop to ensure that the function
594 is called in the main thread.
595 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
596 to make sure that we call attempt the connection in the mainloop only,
597 which might solve some hangs.
599 2007-07-03 Murray Cumming <murrayc@murrayc.com>
601 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
602 be found by their display name. This is never useful.
603 * src/modest-tny-account-store.c: (on_account_removed): Find the account
604 by its ID, instead of trying to use its ID as its display name.
606 * src/modest-tny-account-store.h:
607 * src/modest-tny-account.c:
608 (modest_tny_account_get_special_folder): Add a g_warning() when
609 tny_folder_store_get_folders() returns an empty list for the maildir.
611 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
612 Add a g_warning() when this returns NULL, because that it not allowed
615 2007-07-02 Armin Burgmeier <armin@openismus.com>
617 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
618 note when trying to cancel the wizard. This fixes projects.maemo.org
621 2007-07-02 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-tny-account.h:
624 * src/modest-tny-account.c:
625 (modest_tny_account_new_from_server_account),
626 (modest_tny_account_new_from_server_account_name),
627 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
628 because this must now be set before setting the proto. This is usd in
629 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
630 warning in camel_session_get_service() caused by
631 tny_camel_transport_account_prepare().
633 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
636 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
638 * src/maemo/modest-connection-specific-smtp-edit-window.c:
640 (modest_connection_specific_smtp_edit_window_init):
642 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
645 2007-06-29 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-tny-account.c:
648 (modest_tny_account_new_from_server_account):
649 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
650 now uses to request a connection when it needs one, and which it uses
651 to tell us that something is wrong with the connection, so we can force
652 the accounts offline to prevent further problems.
655 * src/modest-init.c: (init_default_settings):
656 * src/modest-mail-operation.c:
657 (modest_mail_operation_update_account):
658 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
659 This should not be necessary anymore. Do not set the conf key that
660 determined this (it was always TRUE and not set anywhere else).
662 * src/modest-ui-actions.h: Remove unused and unimplemented
663 modest_ui_actions_on_online_toggle_toggled().
665 2007-06-29 Murray Cumming <murrayc@murrayc.com
667 * src/maemo/modest-main-window.c: (connect_signals):
668 Don't connect to delete_event twice. Maybe this was harmless.
670 2007-06-29 Murray Cumming <murrayc@murrayc.com
672 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
673 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
674 Debug output to give some more clue when a folder move is not allowed.
676 2007-06-28 Murray Cumming <murrayc@murrayc.com
678 * src/modest-tny-account.c: (on_modest_file_system_info),
679 (modest_tny_account_get_mmc_account_name):
680 Always call the callback, without checking whether the name has changed.
681 * src/widgets/modest-folder-view.c: (strings_are_equal),
682 (on_model_foreach_set_name), (on_get_mmc_account_name),
683 (text_cell_data): Compare the name here, and use the name from
684 the account rather than from the
685 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
686 if the name was changed after the account was added to the model.
687 That's a tinymail bug but not one that I want to fix now.
689 This finally fixes projects.maemo.org bug NB#59301.
691 2007-06-27 Armin Burgmeier <armin@openismus.com>
693 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
696 2007-06-27 Murray Cumming <murrayc@murrayc.com
698 * src/modest-tny-account.h:
699 * src/modest-tny-account.c:
700 Added modest_tny_account_get_mmc_account_name(), to set the memory
701 card name asynchronously for the given account and then notify.
702 (modest_tny_account_new_for_local_folders): Use this new function instead
703 of using hildon_file_system_info_async_new() directly.
705 * src/widgets/modest-folder-view.c: (text_cell_data):
706 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
707 gtk_tree_model_row_changed() when it is available.
709 This should fix projects.maemo.org bug NB#59301.
711 2007-06-27 Murray Cumming <murrayc@murrayc.com
713 * src/modest-mail-operation.c: (update_account_thread),
714 (get_msgs_full_thread): Fix typo failures in the revert
717 2007-06-27 Murray Cumming <murrayc@murrayc.com
719 * src/maemo/modest-maemo-global-settings-dialog.c:
720 (idle_select_default_focus):
721 * src/modest-mail-operation.c: (idle_notify_progress),
722 (idle_notify_progress_once), (set_last_updated_idle),
723 (update_account_thread), (get_msgs_full_thread):
724 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
725 * src/widgets/modest-header-view.c:
726 (idle_notify_headers_count_changed_destroy),
727 (idle_notify_headers_count_changed):
728 Reverted the additions of gdk_threads_enter/leave(), in case this
729 helps with a startup hang on the device.
731 2007-06-26 Armin Burgmeier <armin@openismus.com>
733 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
734 for supported secure authentication methods from server by
735 gtk_dialog_run(), saving CPU time and a potential race condition.
737 2007-06-26 Armin Burgmeier <armin@openismus.com>
739 * src/maemo/modest-maemo-utils.h:
740 * src/maemo/modest-maemo-utils.c: Added a
741 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
742 only error code to tell the calling code when the user canceled the
745 * src/maemo/modest-account-settings-dialog.h:
746 * src/maemo/modest-account-settings-dialog.c:
747 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
748 message if the retrieval of secure authentication methods was canceled
749 by the user. Perform the check before saving anything to configuration
750 to not end up with half-committed configuration changes, do not show
751 a "Saving to configuration failed" note when authentication methods
752 could not be retrieved.
754 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
757 2007-06-26 Murray Cumming <murrayc@murrayc.com>
759 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
760 Only return the first level of folders under accounts, because the
761 osso-global-search UI spec doesn't want the rest.
762 This fixed projects.maemo.org bug NB#61811.
764 2007-06-26 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-tny-account-store.c:
767 * src/modest-tny-account-store.h:
768 Added modest_tny_account_is_memory_card_account().
769 * src/maemo/modest-main-window.c: (create_details_widget):
770 Show the same information items for the memory card as we show for the
771 local-folders, to fix projects.maemo.org bug NB#59307.
773 2007-06-26 Murray Cumming <murrayc@murrayc.com>
775 * src/modest-tny-account-store.c: (get_password):
776 Added some checks for NULL to maybe prevent crashes, though I think
777 it was Philip's last commit that actually prevented the crash here
778 when creating a first new account.
779 But the new account is still not usable (no messages are shown)
780 until a restart of the application.
782 2007-06-26 Murray Cumming <murrayc@murrayc.com>
784 * src/maemo/modest-maemo-global-settings-dialog.c:
785 (idle_select_default_focus):
786 * src/modest-mail-operation.c: (idle_notify_progress),
787 (idle_notify_progress_once), (idle_notify_update_account_queue),
788 (set_last_updated_idle), (update_account_thread),
789 (notify_get_msgs_full), (get_msgs_full_destroyer),
790 (get_msgs_full_thread):
791 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
792 * src/widgets/modest-header-view.c:
793 (idle_notify_headers_count_changed_destroy),
794 (idle_notify_headers_count_changed):
795 Use gdk_threads_enter() and gdk_threads_enter_leave() in
796 all idle handlers, because some other thread could be blocking
797 the GDK lock, so that it can do GUI stuff.
799 2007-06-26 Murray Cumming <murrayc@murrayc.com>
801 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
802 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
803 (on_idle_send_receive), (on_idle_open_default_inbox):
804 * src/maemo/modest-msg-edit-window.c:
805 (modest_msg_edit_window_attach_file_noninteractive):
806 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
807 to prevent a hang. I don't quite understand why these are necessary,
808 beause we should already be in the main loop. I guess something outside
809 of the main loop is taking the lock.
811 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
812 we are really using URIs, and use files that are more likely to exist.
814 2007-06-26 Murray Cumming <murrayc@murrayc.com>
816 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
817 necessary because configure.ac now defines different variables.
819 2007-06-26 Murray Cumming <murrayc@murrayc.com>
821 * libmodest-dbus-client/libmodest-dbus-client.c:
822 * libmodest-dbus-client/libmodest-dbus-client.h:
823 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
824 libmodest_dbus_client_compose_mail() is what things actually use.
826 * src/dbus_api/modest-dbus-api.h:
827 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
828 * tests/dbus_api/Makefile.am:
829 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
832 2007-06-26 Murray Cumming <murrayc@murrayc.com>
834 * src/modest-init.c: (modest_init_local_folders):
835 For memory-card (or other non local-folders) maildir accounts,
836 always create an Archive folder, so that there is somewhere to put
837 messages. This should be less confusing, because the user does not need
838 to guess that the need to create a folder.
840 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
842 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
843 Fixed icon size by using (50, 50) which is the same as defined by
846 2007-06-25 Armin Burgmeier <armin@openismus.com>
848 * src/widgets/modest-window-mgr.c:
850 * configure.ac: Correctly recognize hildon-notify presence and fixed
851 the build without it being installed.
853 2007-06-25 Murray Cumming <murrayc@murrayc.com>
855 * libmodest-dbus-client/libmodest-dbus-client.c:
856 (libmodest_dbus_client_search): Fix the build. Sorry.
857 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
858 (reply_forward_cb): Initialize variables to fix the build.
860 * src/modest-tny-account-store.c:
861 (modest_tny_account_store_get_tny_account_by): Fix the account URI
862 comparison (a silly typo) so that email search results can be opened
863 when there are more than one account.
865 2007-06-25 Murray Cumming <murrayc@murrayc.com>
867 * libmodest-dbus-client/libmodest-dbus-client.c:
868 (libmodest_dbus_client_search),
869 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
870 instead of 1 second, because the search gets folders and messages from
871 the server, which can take a long time. When it times out,
872 osso-global-search will report no results.
874 We need to specify whether we should search only cached information
875 (maybe with a user preference), and the osso-email-search-plugin
876 API should really be improved to allow that option, and to allow results
877 to be delivered asynchronously in batches.
879 2007-06-25 Murray Cumming <murrayc@murrayc.com>
881 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
882 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
883 GTK_ICON_SIZE_DIALOG is probably the wrong size.
885 2007-06-25 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
888 that is an empty string. D-Bus seems to give us these instead of NULL.
890 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
892 * src/dbus_api/modest-dbus-callbacks.c:
893 * src/maemo/easysetup/modest-easysetup-wizard.h:
894 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
895 * src/maemo/modest-connection-specific-smtp-edit-window.c:
896 (modest_connection_specific_smtp_edit_window_init):
897 * src/maemo/modest-maemo-global-settings-dialog.c:
899 * src/maemo/modest-maemo-utils.c:
900 (modest_maemo_utils_setup_images_filechooser):
901 * src/maemo/modest-main-window.c: (create_details_widget):
902 * src/maemo/modest-msg-edit-window.c:
903 (modest_msg_edit_window_attach_file_noninteractive),
904 (modest_msg_edit_window_color_button_change),
905 (modest_msg_edit_window_set_zoom):
906 * src/modest-mail-operation.c: (update_account_thread):
907 * src/modest-tny-account-store.c:
908 * src/modest-tny-account.c:
909 * src/widgets/modest-global-settings-dialog.c:
910 * src/widgets/modest-window.h:
914 2007-06-25 Murray Cumming <murrayc@murrayc.com>
916 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
917 * src/modest-search.c: (modest_search_folder),
918 (modest_search_all_accounts): Actually search only in the specified folder,
919 doing a simple match on the folder ID.
920 * src/modest-search.h: Added a folder field to the ModestSearch struct,
921 and added some documentation.
923 2007-06-22 Armin Burgmeier <armin@openismus.com>
925 * src/maemo/modest-maemo-utils.h:
926 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
927 modest_maemo_utils_get_supported_secure_authentication_methods.
929 * src/maemo/easysetup/modest-easysetup-wizard.c:
930 * src/maemo/modest-account-settings-dialog.c: Show correct error if
931 one occured, not just "Server does not support secure authentication".
933 2007-06-22 Murray Cumming <murrayc@murrayc.com>
935 * src/modest-tny-account-store.c: (get_password):
936 Restored the call to tny_account_set_user() because Philip seems to have
937 stopped this from crashing (by not using the freed string). It still does
938 not work, but now we can test it.
940 2007-06-22 Murray Cumming <murrayc@murrayc.com>
942 * src/maemo/modest-msg-edit-window.c: (init_window):
943 Comment out use of an uninitialzed GtkScrolledWindow variable,
944 to fix the build and stop a crash. Yet again.
946 2007-06-22 Murray Cumming <murrayc@murrayc.com>
948 * src/modest-tny-account-store.c: (get_password):
949 Remove the call to tny_account_set_user() because this actually crashes.
950 As mentioned in the last commit, it is known to not work anyway.
952 2007-06-22 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-tny-account-store.c: (get_password):
955 Use tny_account_set_username() to tell tinymail that the username might
956 have changed too. But tinymail ignores this: see projects.maemo.org
958 * src/modest-ui-actions.c:
959 (modest_ui_actions_on_password_requested): Remove the useless attempt to
960 reset the connection when changing the username, and improve the comments.
961 Save the changed username to gconf at least, so it is used when Modest is
964 2007-06-21 Murray Cumming <murrayc@murrayc.com>
966 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
967 Do not use a query, so that we get all folders, including for POP and
968 local-folders. They work as search criteria too.
969 This fixes projects.maemo.org bug NB#57740.
971 2007-06-21 Murray Cumming <murrayc@murrayc.com>
973 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
974 Comment out the use of hildon_notification_set_sound() because it is
975 not declared, to fix the build. Warnings are serious, people.
977 2007-06-21 Armin Burgmeier <armin@openismus.com>
979 * src/maemo/modest-maemo-utils.h:
980 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
981 modest_maemo_utils_get_supported_secure_authentication_methods()
982 to query authentication methods for a specific user. This should fix
983 projects.maemo.org bug NB#61369.
985 * src/maemo/easysetup/modest-easysetup-wizard.c:
986 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
989 2007-06-21 Murray Cumming <murrayc@murrayc.com>
991 * libmodest-dbus-client/libmodest-dbus-client.h:
992 * libmodest-dbus-client/libmodest-dbus-client.c:
993 (modest_dbus_message_iter_get_search_hit),
994 (libmodest_dbus_client_search):
995 Reorganised and commented this.
996 Removed modest_search_hit_free() from the public API because it
999 Added libmodest_dbus_client_get_folders() and
1000 modest_folder_result_list_free().
1002 * src/dbus_api/modest-dbus-api.h:
1003 * src/dbus_api/modest-dbus-callbacks.c:
1004 (modest_dbus_req_filter): Commented. Moved most code to
1005 on_dbus_method_search() and added on_dbus_method_get_folders().
1007 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1008 of the extra D-Bus handler.
1010 * tests/dbus_api/Makefile.am:
1011 * tests/dbus_api/test_get_folders.c: New test for
1012 libmodest_dbus_client_get_folders(). This seems to return an empty list
1013 at the moment. That could be the same error that causes the message list
1014 to be empty sometimes.
1015 This should help with projects.maemo.org bug NB#57740.
1017 2007-06-21 Armin Burgmeier <armin@openismus.com>
1019 * src/modest-mail-operation.c: Do not call
1020 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1021 notify the operation's end after having set the status to CANCELED for
1022 the operation queue to listen on. This fixes a deadlock when there
1023 were mail operations in the queue during its finalization.
1025 * src/modest-singletons.c: Reordered uninitialization of the account
1026 manager to happen after the mail operation queue was uninitialized
1027 because the mail operation's in the queue might still try to access
1028 the account manager (see modest_mail_operation_notify_end()). This
1029 fixes a potential crash when terminating the application.
1031 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1033 * src/modest-search.c:
1034 (search_mime_part_and_child_parts): Moved some code here so we
1035 can search recursively in child folders.
1036 (modest_search_folder): Search in the message as a mime part, instead
1037 of just its child mime parts.
1038 (read_chunk), (search_mime_part_ogs):
1039 Check how many bytes were read, to prevent an endless loop.
1040 Searching in message bodies now works. This finishes the fix for
1041 projects.maemo.org bug NB#61007.
1043 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1046 Add a g_warning when the item is not a folder.
1048 * src/modest-ui-dimming-rules.c:
1049 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1050 when selected item is not a folder (for instance, an account), because
1051 the UI spec only talks about folders.
1052 I am not sure what the UI spec wants, so this might not totally fix
1053 projects.maemo.org bug NB#60794.
1055 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1058 (load_from_file): Sort the list. The unsorted list would be more noticeable
1059 in non-English locales.
1061 * src/maemo/modest-msg-edit-window.c:
1062 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1063 warning and fix the build.
1065 * src/maemo/modest-progress-bar-widget.c:
1066 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1067 avoid a g_warning, and probably to avoid a crash.
1069 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-search.c: (modest_search_folder): Check for a GError
1072 when calling tny_folder_get_headers(), to show that this is not the cause
1075 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1077 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1078 Actually set the body query instead of the subject query.
1080 * src/modest-search.c: (search_mime_part_ogs),
1081 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1082 which would probably cause it to fail if we got this far.
1084 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1085 to simplify the code.
1086 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1087 be causing search-in-body to fail.
1089 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1091 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1093 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1094 Better debug message when the folder cannot be found.
1095 This should help with fixing projects.maemo.org bug #61287.
1096 * src/modest-search.c: (add_hit): Do not leak the furl string.
1098 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-ui-actions.c:
1101 (modest_ui_actions_on_folder_selection_changed):
1102 Do not special-case TNY_MERGE_FOLDER here, because
1103 modest_tny_folder_get_account() already does that. This fixes
1104 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1105 shown when the Outbox was selected).
1107 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1109 * libmodest-dbus-client/libmodest-dbus-client.c:
1110 (_dbus_iter_get_string_or_null): Initialize the string variable in
1111 case this helps with Dirk's crash.
1113 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1115 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1116 though it is not implemented yet (this function is maybe not even used),
1117 to avoid breaking ABI in future.
1118 * libmodest-dbus-client/libmodest-dbus-client.c:
1119 (get_attachments_string): Moved some code into this generic function.
1120 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1121 sends email. It is maybe not used.
1122 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1123 (on_send_mail): Use attachments.
1125 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1126 * src/maemo/modest-msg-edit-window.c:
1127 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1128 a filename before using it, to fix projects.maemo.org bug NB#58233.
1130 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1133 Initialize the continue_download variable to fix the build, and probably
1134 to fix randome behaviour.
1136 2007-06-18 Armin Burgmeier <armin@openismus.com>
1138 * src/modest-tny-send-queue.h:
1139 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1140 the queue so we can later show it in the UI. Replaced
1141 modest_tny_send_queue_msg_is_being_sent() by
1142 modest_tny_send_queue_get_msg_status().
1144 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1146 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1147 gpointer. This probably was not harmful, but just to be sure.
1149 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1151 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1152 Fix the build, but leave the function broken on Bora, because
1153 hildon_uri_action_get_service() does not exist.
1154 osso_uri_action_get_service() does not exist either, it seems.
1156 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1158 * src/modest-tny-account.c:
1159 (modest_tny_account_new_from_server_account):
1160 Uncommented the url debug output again, because it is useful for
1161 debugging, as I said in the comment.
1163 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1165 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1167 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1168 for Mameo Bora, to fix the build.
1170 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1173 Fixed build with hildon < 0.99
1175 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1176 Check if the selected account is busy instead of checking all accounts
1178 * src/modest-account-mgr-priv.h:
1179 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1180 (modest_account_mgr_init), (compare_account_name),
1181 (modest_account_mgr_set_account_busy),
1182 (modest_account_mgr_account_is_busy):
1183 * src/modest-account-mgr.h:
1184 Added busy information to the account manager. It possible to
1185 set an account to busy or not busy now.
1187 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1188 (modest_mail_operation_update_account),
1189 (modest_mail_operation_notify_end):
1190 Set the account to busy/not busy depending on the operation state.
1192 * src/widgets/modest-account-view.c:
1193 (modest_account_view_finalize), (get_last_updated_string),
1194 (update_account_view), (on_account_busy_changed), (init_view):
1195 Show string "Refreshing..." if the account is currently busy.
1197 All this fixes projects.maemo.org bug NB#59711
1199 2007-06-14 Armin Burgmeier <armin@openismus.com>
1201 * src/widgets/modest-attachments-view.h:
1202 * src/widgets/modest-attachments-view.c: Added
1203 modest_attachments_view_has_attachments() and fixed coordinate
1204 transformation in get_att_view_at_coords(). This fixes attachment
1207 * src/widgets/modest-msg-view.c: Make use of
1208 modest_attachments_view_has_attachments() to decide whether to show
1209 attachments in the header.
1211 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1213 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1214 (on_change), (on_combo_security_changed),
1215 (modest_connection_specific_smtp_edit_window_init),
1216 (modest_connection_specific_smtp_edit_window_set_connection),
1217 (modest_connection_specific_smtp_edit_window_is_dirty):
1218 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1219 * src/maemo/modest-connection-specific-smtp-window.c:
1222 Show an comfirmation dialog for the smpt-edit-window if there are
1223 unsaved changes and the user hits cancel.
1224 (projects.maemo.org bug NB#60479)
1226 2007-06-14 Armin Burgmeier <armin@openismus.com>
1228 * src/maemo/easysetup/modest-easysetup-wizard.c:
1229 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1230 address" info in banner instead of node, and select all the text as
1231 per UI spec. This fixes projects.maemo.org bug NB#60550.
1233 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1235 reviewed by: <delete if not using a buddy>
1237 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1238 * src/modest-ui-actions.c: (folder_refreshed_cb):
1240 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1242 * src/widgets/modest-folder-view.c: (filter_row):
1243 Explictly filter out the per-account outbox accounts. I don't know why
1244 these only sometimes show up, but now they should never show up in the UI.
1245 This should fix projects.maemo.org bug NB#60160.
1247 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1249 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1250 when the toolbar does not exist yet.
1251 * src/modest-widget-memory.c: (save_settings_header_view):
1252 Added g_warnings() to help us to discover when we are trying to set
1253 an empty columns list in gconf.
1255 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-init.h:
1258 * src/modest-init.c:
1259 Added modest_init_get_default_header_view_column_ids().
1261 * src/modest-widget-memory.c: (restore_settings_header_view):
1262 Use the new function to get defaults, if the gconf key is empty,
1263 instead of not creating any columns. This seems to fix the
1264 empty right-hand pane problems.
1266 * src/widgets/modest-header-view.h: Improved documentation.
1268 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1271 Revert the use of the display name as the account name, because this
1272 is generally wrong and would break the code that follows.
1274 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1276 * src/maemo/easysetup/modest-easysetup-wizard.c:
1277 (check_for_supported_auth_methods), (on_before_next),
1280 More correct fix for projects.maemo.org bug NB# 58991
1281 Do not longer accept AUTH_PASSWORD as secure method and choose
1282 correct method when creating the account.
1284 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1286 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1287 Fixed projects.maemo.org bug NB# 58991
1289 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1291 * src/modest-init.c: (modest_init_init_core),
1292 (modest_init_local_folders): Fixed compilation errors.
1294 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1296 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1297 Remove unnecessary lib/include, though it is good in principle when needed.
1299 * src/modest-init.c: (modest_init_one_local_folder),
1300 (modest_init_local_folders):
1301 * src/modest-init.h: Initialize the .modest library for memory cards,
1302 instead of just doing nothing for them. This should allow us to create
1303 folders there, fixing projects.maemo.org bug NB#59297.
1305 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1307 * libmodest-dbus-client/libmodest-dbus-client.c:
1308 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1309 (libmodest_dbus_client_compose_mail),
1310 (libmodest_dbus_client_open_message),
1311 (libmodest_dbus_client_send_and_receive),
1312 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1314 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1315 (on_idle_open_message), (modest_dbus_req_handler),
1316 (search_result_to_message), (modest_dbus_req_filter):
1317 * src/modest-search.c: (add_hit), (modest_search_folder),
1318 (modest_search_all_accounts): Improved debug messages.
1320 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1322 * src/modest-tny-account-store.c:
1323 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1326 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1329 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-tny-account-store.c: (get_server_accounts):
1332 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1333 even when there are no accounts, so that the Outbox folder is always
1334 visible. This fixes projects.maemo.org bug NB#60158.
1336 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1338 * src/maemo/modest-main-window.c: (create_details_widget):
1339 Use the mcen_va_never logical ID.
1341 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1343 * src/dbus_api/modest-dbus-api.h:
1344 * src/dbus_api/modest-dbus-callbacks.c:
1345 (on_idle_open_default_inbox), (on_open_default_inbox),
1346 (modest_dbus_req_handler):
1347 Added a new OpenDefaultInbox method.
1349 * libmodest-dbus-client/libmodest-dbus-client.h:
1350 * libmodest-dbus-client/libmodest-dbus-client.c:
1351 Added libmodest_dbus_client_open_default_inbox() to call the new
1352 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1353 though it should maybe be used by a new osso-email-interface function.
1355 * tests/dbus_api/Makefile.am:
1356 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1359 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1362 NULL, so that the signals get all the keys. This should not actually
1363 change any behaviour because we currently update everything when anything
1366 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1368 * src/widgets/modest-folder-view.c: (text_cell_data),
1369 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1370 (find_inbox_iter): If tinymail tells us that the folder is
1371 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1372 This causes the inbox to be selected at startup, fixing part of
1373 projects.maemo.org bug NB#56305.
1375 * src/modest-ui-dimming-rules.c:
1376 (modest_ui_dimming_rules_on_tools_smtp_servers):
1377 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1378 the SMTP servers menu item.
1379 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1380 that the SMTP Servers menu item is dimmed when there are no accounts,
1381 as a future version of the UI spec will require. This fixes
1382 projects.maemo.org bug NB#56305.
1384 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1386 * src/maemo/modest-maemo-utils.c:
1387 (modest_maemo_utils_get_supported_secure_authentication_methods):
1388 Added label to dialog instead of unreadable title
1390 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1391 (modest_main_window_new):
1392 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1395 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1396 * src/modest-account-mgr.h:
1397 Added method to avoid code duplication
1399 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1400 (modest_ui_actions_on_send_receive):
1401 Use modest_account_mgr_has_accounts
1403 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1405 * src/maemo/easysetup/modest-presets.c:
1406 (modest_presets_get_info_server_security): Do not report secure auth
1408 * src/modest-protocol-info.c: Use the defines for the gconf key names
1409 for secure authentication. This was not working because we were writing
1410 Password and reading password, and the check was case sensitive.
1411 With this, gmail now works for receiving and sending when created via
1414 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1416 * src/maemo/easysetup/modest-presets.c:
1417 (modest_presets_get_info_server_security): Correct the key name for
1418 SecureSmtp, because it seems to be case-sensitive.
1419 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1420 Do not try to get the 0th notebook page if there are 0 pages, to
1421 avoid a g_warning().
1423 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1426 Prevent use of the new notification feature for now, because it currently
1427 shows one dialog for each new email, which is annoying.
1429 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1432 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1433 when no country was selected, so that we show the global ones.
1434 * src/maemo/easysetup/modest-presets.c:
1435 (modest_presets_get_providers): Return only the global providers, not
1436 all providers when mmc=0 was requested.
1438 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1440 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1441 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1442 provider ID in the combo.
1444 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1445 Do not show the page numbers, because it would be confusing when we add
1446 the 2 extra pages for the custom setup, when the user chooses the "Other"
1447 provider. This fixes projects.maemo.org bug NB#59028
1449 * src/modest-init.c: (modest_init_init_core),
1450 (modest_init_local_folders):
1451 * src/modest-init.h:
1452 * src/modest-tny-account.c:
1453 (modest_tny_account_new_for_local_folders): Do not create default folders
1454 for the memory card. This should fix projects.maemo.org bug NB#59328.
1456 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1458 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1459 Free the changed_conf_keys string items. They are already freed in the
1460 idle handler if that runs first.
1462 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-ui-actions.c:
1465 (modest_ui_actions_on_password_requested): Check that the server name
1466 is not NULL, because I just saw a password dialog with (null) as the
1469 * src/modest-tny-folder.[h|c]: Added
1470 modest_tny_folder_is_memory_card_folder().
1471 * src/modest-ui-dimming-rules.c:
1472 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1473 menu item for memory cards, as per the UI spec (section 7.4). This should
1474 fix projects.maemo.org bug NB#59297.
1476 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1478 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1479 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1480 is another problem with the code, see Murray's comment at line 772)
1482 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1485 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1486 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1487 (load_from_file), (easysetup_country_combo_box_init),
1488 (easysetup_country_combo_box_get_active_country_ids),
1489 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1490 instead of just one ID, to avoid duplicate country names in the UI.
1492 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1493 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1494 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1495 a single ID, avoiding duplicate providers.
1496 * src/maemo/easysetup/modest-easysetup-wizard.c:
1497 (on_combo_account_country): Adapt to use a list.
1499 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1502 keys changed in the last X seconds.
1504 * src/modest-account-mgr.h:
1505 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1506 (on_key_change), (modest_account_mgr_class_init),
1507 (modest_account_mgr_init), (modest_account_mgr_finalize):
1508 As the keys are changed, save them in a GSList* and signal that GSList*
1509 further every X seconds, to batch changes, to allow us to do just one
1510 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1511 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1513 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1514 changed signal signature.
1516 * src/modest-conf.c: (modest_conf_set_list),
1517 (modest_conf_on_change): Reenable notification.
1519 (modest_conf_maemo_fake_on_change): Comment out the hack that
1520 notified immediately instead of asynchronously.
1522 * src/widgets/modest-account-view.h:
1523 * src/widgets/modest-account-view.c:
1524 (update_account_view): Select the previously-selected account ID,
1525 if possible. This fixes projects.maemo.org bug NB#56933.
1527 (on_account_changed), (on_account_removed),
1528 (modest_account_view_select_account):
1530 Remove the block/unblock functions
1531 because they were not useful.
1533 * src/maemo/modest-account-view-window.c:
1534 (on_delete_button_clicked), (on_edit_button_clicked),
1535 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1537 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1540 Improve the error dialog to show Incorrect Account Settings, which seems
1541 clearer, and say that the internal error message (to be removed from the
1542 dialog later) is often misleading.
1543 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1545 * src/modest-tny-account.c:
1546 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1547 URL because this is so useful for debugging on the device.
1549 * src/widgets/modest-serversecurity-combo-box.c:
1550 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1552 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1554 * src/modest-mail-operation.c:
1555 (modest_mail_operation_send_new_mail):
1556 Added a comment about a nasty but apparently harmless message. Details
1557 added to the wiki g_warnings() page.
1559 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1561 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1562 (modest_tny_send_queue_class_init):
1563 Do not use the priv struct because it is empty, to avoid g_warnings
1564 about a non-existant priv struct.
1566 * src/modest-tny-account-store.c:
1567 (modest_tny_account_store_get_server_account),
1568 (modest_tny_account_store_get_transport_account_for_open_connection
1569 ): Do not try to get transport server accounts for local folders,
1570 because they don't have any. This avoids a g_warning().
1572 * src/maemo/modest-main-window.c:
1573 (modest_main_window_notify_send_receive_initied),
1574 (on_configuration_key_changed):
1575 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1576 * src/modest-defs.h:
1577 * src/modest-mail-operation.c:
1578 (modest_mail_operation_update_account):
1579 * src/modest-tny-account-store.h:
1580 * src/modest-tny-account.c:
1581 (modest_tny_account_get_special_folder),
1582 (modest_tny_account_new_for_local_folders),
1583 (modest_tny_account_new_for_per_account_local_outbox_folder):
1584 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1585 * src/modest-tny-local-folders-account.c:
1586 (add_account_folders_to_merged_folder):
1587 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1588 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1589 (modest_ui_actions_on_send):
1590 * src/widgets/modest-folder-view.c: (update_model):
1591 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1592 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1593 modest_tny_account_store_get_tny_account_by_account() to
1594 modest_tny_account_store_get_server_account() to make the code clearer.
1596 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1598 * src/dbus_api/modest-dbus-api.h:
1599 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1600 * src/maemo/modest-msg-edit-window.c:
1601 (modest_msg_edit_window_attach_file_noninteractive):
1602 added g_warning in case the file to be attached does not exist
1603 * tests/dbus_api/test_compose_mail.c: (main):
1604 removed obsolete comment, added generic files as test case
1606 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-tny-account-store.c: (get_server_accounts):
1609 Create the local folders account only once, not once for each outbox, and
1610 not only when there are some outboxes.
1612 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1614 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1615 code that is causing a crash at startup. Sergio says that he is fixing this.
1617 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1619 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1620 * src/maemo/modest-account-settings-dialog.c:
1621 (create_page_outgoing),
1622 (modest_account_settings_dialog_set_account_name),
1623 (save_configuration):
1624 - Fixed handling of the "Use secure authentication" toggle to comply with
1625 the ui specification. See also projects.maemo.org bug NB#58400
1627 - Restore the Secure connection setting combo correctly when loading
1630 * src/maemo/modest-maemo-utils.c:
1631 (on_camel_account_get_supported_secure_authentication),
1632 (modest_maemo_utils_get_supported_secure_authentication_methods):
1633 Fixed a crasher if operation is canceled
1635 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1636 (modest_protocol_info_auth_is_secure):
1637 * src/modest-protocol-info.h:
1639 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1640 the sense of the "Use secure authentication" toggle.
1642 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-tny-account-store.h:
1645 * src/modest-tny-account-store.c:
1646 Added modest_tny_account_store_get_local_folders_account().
1648 * src/modest-tny-folder.h:
1649 * src/modest-tny-folder.c:
1650 (modest_tny_folder_get_account):
1651 Added this replacement for tny_folder_get_account() which returns
1652 the local-folders account for TnyMergeFolders, to avoid the
1653 warning about the unimplemented get_account_func() vfunc().
1655 (modest_tny_folder_get_rules),
1656 * src/modest-ui-actions.c:
1657 (modest_ui_actions_on_folder_selection_changed):
1658 * src/modest-mail-operation.c:
1659 (modest_mail_operation_remove_folder),
1660 (modest_mail_operation_xfer_folder),
1661 (modest_mail_operation_rename_folder),
1662 (modest_mail_operation_get_msg),
1663 (modest_mail_operation_get_msgs_full),
1664 (modest_mail_operation_remove_msg),
1665 (modest_mail_operation_xfer_msgs),
1666 (modest_mail_operation_refresh_folder):
1667 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1669 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1672 (modest_server_account_set_security):
1673 * src/modest-defs.h: Add comments explaining that our
1674 UI spec means TLS when it says Normal, so these do not look like errors.
1676 * src/modest-tny-account.c:
1677 (modest_tny_account_new_from_server_account): Use the new tinymail
1678 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1679 for TLS. This should fix projects.maemo.org bug NB#58460.
1681 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/easysetup/modest-easysetup-wizard.c:
1684 (create_account): Correct the position of the gconf sanity check warning.
1685 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1686 of using the g_idle_add() hack, because this does not seem to be necessary
1687 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1688 caused by something other than maemo's gconf.
1689 This fixes projects.maemo.org bug #59022.
1691 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-account-mgr-helpers.c:
1694 (modest_account_mgr_get_default_account): Do not check that the account
1695 exists if there is no default account (NULL), to fix a runtime warning.
1697 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1699 * src/widgets/modest-folder-view.c: (update_model):
1700 Do not unref the treemodel before we have finished with it.
1701 This prevents a valgrind warning and an occasional crash at startup.
1703 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1705 * libmodest-dbus-client/libmodest-dbus-client.h:
1706 added libmodest_dbus_client_compose_mail()
1707 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1709 added functions needed for SendAsMail() functionality
1710 * src/maemo/modest-msg-edit-window.c:
1711 (modest_msg_edit_window_attach_file_noninteractive):
1712 non interactively attaching files to message edit window
1713 * src/widgets/modest-msg-edit-window.h:
1714 * tests/dbus_api/Makefile.am:
1715 added test_compose_mail.c
1716 * tests/dbus_api/test_compose_mail.c: (main):
1718 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1720 * src/modest-account-view.c:
1721 Fixed bug projects.maemo.org bug NB#59307
1723 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1725 * src/maemo/easysetup/modest-easysetup-wizard.c:
1726 (get_serverport_incoming), (on_before_next), (create_account):
1727 * src/maemo/modest-account-settings-dialog.c:
1728 (modest_account_settings_dialog_set_account_name):
1729 * src/maemo/modest-maemo-utils.c:
1730 (on_camel_account_get_supported_secure_authentication_status),
1731 (on_camel_account_get_supported_secure_authentication),
1732 (on_secure_auth_cancel),
1733 (modest_maemo_utils_get_supported_secure_authentication_methods):
1735 Implemented security authentication for settings and easysetup.
1737 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/modest-main-window.c: (create_details_widget):
1740 Show the total size for memory card accounts too, instead of showing
1741 the name again. Fixes bug projects.maemo.org bug NB#59307.
1743 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-tny-simple-folder-store.c:
1747 * src/modest-tny-simple-folder-store.h: Removed.
1749 * src/modest-tny-local-folders-account.h
1750 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1751 for the local-folders maildir, with an extra TnyMergedFolder containing
1752 the folders of the per-account outbox store accounts.
1753 * src/modest-tny-account-store.c: (get_server_accounts):
1754 Add the outboxes to the special local folders account after creating it.
1756 * src/modest-tny-account.c:
1757 (modest_tny_account_new_for_local_folders): Create the derived
1758 account when creating the main local-folders account.
1760 * src/maemo/modest-main-window.c: (create_details_widget),
1761 (modest_main_window_set_contents_style):
1762 Adapted to the use of the derived account instead of the folder store.
1764 * src/modest-ui-actions.c:
1765 (modest_ui_actions_on_folder_selection_changed):
1766 * src/modest-ui-dimming-rules.c:
1767 (modest_ui_dimming_rules_on_new_folder):
1768 * src/widgets/modest-folder-view.c: (text_cell_data),
1769 (icon_cell_data), (filter_row), (update_model),
1770 (get_cmp_rows_type_pos):
1773 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1774 Do not get the priv struct, because no priv struct has been set,
1775 to avoid a runtime warning.
1777 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1778 #ifelse with #else, to fix a warning, to fix the build.
1781 2007-06-05 Christian Kellner <ckellner@openismus.com>
1783 * libmodest-dbus-client/libmodest-dbus-client.c:
1784 Fix small typo in doc (why do you always see them
1785 AFTER committing stuff?)
1788 2007-06-05 Christian Kellner <ckellner@openismus.com>
1790 * libmodest-dbus-client/libmodest-dbus-client.c:
1791 (libmodest_dbus_client_search):
1792 Initialize hit list with NULL. Also set folder list
1793 to "" if NULL was supplied.
1796 2007-06-03 Christian Kellner <ckellner@openismus.com>
1798 * libmodest-dbus-client/libmodest-dbus-client.c:
1799 (modest_search_hit_list_free):
1800 Make it save to call it with NULL.
1802 * src/dbus_api/modest-dbus-callbacks.c:
1803 * src/modest-search.c:
1804 Return full ModestSearchHits as the search result list not TnyHeader
1805 since can't be around withouth the correspoding TnyFolder.
1807 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1809 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1810 Added currently commented code to check for secure auth
1812 * src/maemo/modest-account-settings-dialog.c: (on_response),
1813 (save_configuration), (show_ok):
1814 Fixed projects.maemo.org bugs NB #59248 and #59251
1816 * src/maemo/modest-maemo-utils.c:
1817 (on_camel_account_get_supported_secure_authentication_status),
1818 (on_camel_account_get_supported_secure_authentication),
1819 (modest_maemo_utils_get_supported_secure_authentication_methods):
1820 * src/maemo/modest-maemo-utils.h:
1821 Moved get_supported_secure_authentication() method here to be able
1822 to use it from easysetup wizard.
1824 * src/modest-pair.c: (on_pair_compare_as_string):
1825 Should compare string with first part of pair and not
1826 strcmp pairs which will crash.
1828 * src/modest-protocol-info.c:
1829 (modest_protocol_info_protocol_is_store):
1830 * src/modest-protocol-info.h:
1831 Added modest_protocol_info_get_auth_protocol_name()
1833 2007-06-03 Armin Burgmeier <armin@openismus.com>
1835 * src/modest-mail-operation.c:
1836 (modest_mail_operation_get_msgs_full): Set priv->account also when
1837 only retrieving a single message. This avoids a crash when canceling
1840 (modest_mail_operation_notify_end): Do not explicitely remove the
1841 operation from the queue but only emit the progress_changed signal.
1842 The queue itself listens to that signal to remove the operation when
1843 it is finished. This reduces coupling and removes a potential deadlock
1844 when modest_mail_operation_notify_end() is called from the queue
1845 itself. If that is a problem performance-wise, I would suggest to
1846 implement a status-changed signal or something.
1848 * src/modest-mail-operation-queue.c: Make sure to never call a
1849 function from another file while the queue is locked. This (hopefully)
1850 fixes another deadlock when exiting the application while retrieving
1853 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1855 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1856 Fixed build if libogs is not available
1858 2007-06-03 Christian Kellner <ckellner@openismus.com>
1860 * libmodest-dbus-client/libmodest-dbus-client.h:
1861 * libmodest-dbus-client/libmodest-dbus-client.c:
1862 (libmodest_dbus_client_delete_message):
1863 Implement deletion of messages (Client side).
1865 (modest_search_hit_free),
1866 (modest_search_hit_list_free):
1867 Utility functions to free the result hits.
1869 * src/dbus_api/modest-dbus-api.h:
1870 * src/dbus_api/modest-dbus-callbacks.c:
1871 (on_delete_message),
1872 (modest_dbus_req_handler):
1873 Implement deletion of messages (Server side).
1875 * tests/dbus_api/test_search.c: (main):
1878 * tests/dbus_api/Makefile.am:
1879 * tests/dbus_api/test_delete_message:
1880 Add little test for the message deletion logic
1882 2007-06-03 Armin Burgmeier <armin@openismus.com>
1884 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1885 when the operation queue was not empty. projects.maemo.org bug
1888 2007-06-03 Armin Burgmeier <armin@openismus.com>
1890 * src/widgets/modest-account-view.c
1891 (on_account_default_toggled): Toggle default account column
1892 explicitely instead of waiting for gconf notification (which is
1893 currently ignored). This should fix projects.maemo.org bug NB#56910
1894 for now. It should probably be removed when gconf notifications are
1897 2007-06-03 Christian Kellner <ckellner@openismus.com>
1899 * libmodest-dbus-client/libmodest-dbus-client.c:
1900 Removed debugging spew.
1902 * src/dbus_api/modest-dbus-callbacks.c:
1903 Added debugging info.
1905 * src/modest-search.c:
1906 (modest_search_all_accounts):
1907 Use tny_account_store_get_accounts () on the account store
1908 to get all accounts which is the way to get all accounts.
1910 * tests/dbus_api/test_search.c: (main):
1911 Make it possible to supply the search term on the command line.
1913 2007-06-03 Christian Kellner <ckellner@openismus.com>
1915 * libmodest-dbus-client/libmodest-dbus-client.c:
1916 * libmodest-dbus-client/libmodest-dbus-client.h:
1917 Implement searching for mesages over raw dbus. (Client side)
1919 * src/dbus_api/Makefile.am:
1920 * src/dbus_api/modest-dbus-api.h:
1921 * src/dbus_api/modest-dbus-callbacks.c:
1922 * src/dbus_api/modest-dbus-callbacks.h:
1923 Search framework (Server side). Also implement on_idle_open_message().
1925 * src/maemo/modest-platform.c: (modest_platform_init):
1926 Prepare for raw dbus/osso rpc interaction.
1928 * src/modest-search.h:
1929 Changed minsize from unspecific guint to guint32.
1931 * src/modest-search.c:
1933 Added strange hack which magically made tnymail work.
1935 (modest_search_folder),
1936 (modest_search_account),
1937 (modest_search_all_accounts):
1938 Implement helper functions to search all accounts, specific account
1941 * tests/dbus_api/Makefile.am:
1942 * tests/dbus_api/test_open_message.c:
1943 Read url to open from commandline.
1945 * tests/dbus_api/test_search.c:
1946 Implement small test for dbus search stuff
1948 2007-06-02 Armin Burgmeier <armin@openismus.com>
1950 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1951 include account type and account title. This fixes projects.maemo.org
1954 * src/maemo/modest-account-view-window.c: Set a title for the window.
1956 2007-06-02 Armin Burgmeier <armin@openismus.com>
1958 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1959 incoming and outgoing server name based on email address and server
1960 types as long as the names have not been edited manually. This fixes
1961 projects.maemo.org bug NB#58671.
1963 2007-06-02 Armin Burgmeier <armin@openismus.com>
1965 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1966 server type cannot be changed in future to the incoming details page
1967 when creating an account. This fixes projects.maemo.org bug NB#59029.
1969 2007-06-02 Armin Burgmeier <armin@openismus.com>
1971 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1972 and assigned max width chars so that they wrap instead of being
1973 truncated. Fixes projects.maemo.org bug NB#56126.
1975 2007-06-02 Armin Burgmeier <armin@openismus.com>
1977 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1978 introductory note to the connection specific smtp servers dialog, as
1979 section 8.12 of the email UI specification requires. This fixes
1980 projects.maemo.org bug NB#59212.
1982 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1985 Check for running mail operations, and offer to cancel them, as per the UI
1986 spec. This fixes projects.maemo.org bug NB#59041 .
1987 However, I suspect that tinymail may still use the network connection
1988 in ways that we cannot detect or cancel. But it should at least adapt to
1989 changes fairly well.
1991 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-tny-account-store.c: (recreate_all_accounts),
1994 (get_cached_accounts), (get_server_accounts): Do more sensible
1995 ref-counting of the temporarily-cached outbox accounts list. This seems
1996 to fix a crash when entering the password when the password was wrong.
1998 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2000 * src/gnome/modest-main-window.c: (connect_signals):
2001 * src/modest-tny-account-store.c: (get_password),
2002 (modest_tny_account_store_alert): Added comments and clues and
2003 commented-out code about how we currently fail to deal with connection
2004 errors and wrong passwords, and how we should.
2006 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2008 * src/widgets/modest-retrieve-combo-box.c:
2009 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2010 This fixes projects.maemo.org bug NB#58472 .
2012 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/easysetup/modest-easysetup-wizard.c:
2015 (create_page_complete_easysetup):
2016 (create_page_complete_custom): Correct the last commit,
2017 putting the correct sentences in the correct pages.
2019 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/modest-easysetup-wizard.c:
2022 (create_page_complete_custom): Show the second sentence of text
2023 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2026 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2029 Set the leave-on-server conf key by default. This fixes
2030 projects.maemo.org bug NB#59258 .
2032 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/modest-account-view-window.c:
2035 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2036 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2039 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-easysetup-wizard.c:
2042 (create_caption_new_with_asterisk):
2043 * src/maemo/modest-account-settings-dialog.c:
2044 (create_caption_new_with_asterisk):
2045 Uncomment the code to add the asterisk, because they are no longer in the
2046 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2047 (update_incoming_server_title): Add an asterisk here too.
2049 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/modest-maemo-global-settings-dialog.c:
2052 (current_connection): Check that we are even connected before trying to
2053 get the current connection name, to prevent a warning.
2055 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2056 Change the comments because tny_maemo_conic_device_connect() is now meant to
2058 * src/modest-mail-operation.c:
2059 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2060 make sure we have a connection and fail if we can't connect.
2062 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/modest-main-window.c:
2065 (on_account_store_connecting_finished): Do not try to get the
2066 connection ID if we are not really connected. I am surprised that
2067 this signal handler is called when we are not connected.
2069 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2071 * src/modest-error.h:
2072 * src/modest-ui-actions.c:
2073 (modest_ui_actions_get_msgs_full_error_handler):
2074 Renamed an enum, added comments, added an enum
2075 for retrieve-limit errors.
2077 * src/modest-mail-operation.c: (foreach_add_item),
2078 (internal_folder_observer_update), (update_account_thread),
2079 (modest_mail_operation_get_msgs_full):
2080 (modest_mail_operation_update_account),
2081 Added comments about how this works, and some code that should
2082 (but does not) check the retrieve-limit. See the TODO comment.
2084 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2086 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2087 Initialize help_id to fix the build. Warnings are good.
2089 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2091 * src/widgets/modest-hbox-cell-renderer.c:
2092 (modest_hbox_cell_renderer_append):
2093 * src/widgets/modest-vbox-cell-renderer.c:
2094 (modest_vbox_cell_renderer_append):
2095 Fix the last commit by doing an extra ref.
2097 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2099 * src/widgets/modest-hbox-cell-renderer.c:
2100 (modest_hbox_cell_renderer_append):
2101 * src/widgets/modest-vbox-cell-renderer.c:
2102 (modest_vbox_cell_renderer_append):
2103 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2104 to fix the build with Maemo Bora.
2105 However, there seems to be a remaining crash, probably due to reference
2108 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-tny-account.c:
2111 (modest_tny_account_new_for_local_folders):
2112 Use hildon_file_system_info_async_new() to get a better name for
2113 the memory card account, setting it as the account name.
2114 The timing seems to work, but this is probably
2115 not the best place to do this. See the TODO comment.
2116 * src/maemo/modest-main-window.c: (create_details_widget):
2117 * src/widgets/modest-folder-view.c: (text_cell_data):
2118 Use the tny account name instead of hardcoding a name.
2120 2007-05-30 Christian Kellner <ckellner@openismus.com>
2122 * src/modest-search.c: (modest_search):
2123 Correctly set part_search_func even if we have already parsed
2124 the query and thus a valid OgsTextSearcher object.
2126 2007-05-30 Christian Kellner <ckellner@openismus.com>
2129 Search and check for libogs.
2132 Incooparte the ogs build env.
2134 * src/modest-mime-part-search-stream.c:
2135 * src/modest-mime-part-search-stream.h:
2136 Removed since we do the real searching now in modest-search.c.
2138 * src/modest-search.c:
2139 * src/modest-search.h:
2140 Implement support for ogs. We use that if available and requested
2141 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2142 should now handle the corner case when the search term is spread
2143 across multiple reads.
2144 Also the logic in modest_search () was corrected to search all
2145 requested fields until one is found.
2147 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2149 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2151 * src/modest-init.h:
2152 * src/modest-init.c: Made modest_init_local_folders() take a
2153 path and be public so we can iniitialize maildir folders on
2156 * src/modest-local-folder-info.h:
2157 * src/modest-local-folder-info.c:
2158 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2160 * src/modest-tny-account.c:
2161 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2162 still means the standard local-folders path on the local volume.
2164 * src/modest-tny-account-store.c:
2165 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2166 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2167 all accounts when that happens.
2168 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2169 this too, so it shows up in the treeview.
2171 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2173 * src/maemo/modest-maemo-global-settings-dialog.c:
2174 (current_connection):
2175 * src/widgets/modest-global-settings-dialog.c:
2176 (current_connection_default):
2177 Use the enum values instead of 0, 1 and -1,
2178 to make the code clearer.
2180 * src/modest-account-mgr-helpers.c:
2181 (modest_account_mgr_get_connection_specific_smtp): Make this code
2184 * src/modest-runtime.h:
2185 * src/modest-runtime.c:
2186 Added modest_runtime_remove_all_send_queues().
2187 * src/maemo/modest-main-window.c:
2188 (on_account_store_connecting_finished): Recreate the send queues,
2189 using the appropriate transport accounts for this new connection.
2190 Some futher adapting might be needed if the old send queues are not
2191 automatically stopped at this point.
2193 * src/modest-tny-account-store.c: (get_server_accounts):
2194 Create the connection-specific transport accounts, so that they can
2195 be found later by their ID.
2197 * src/modest-tny-account.h:
2198 * src/modest-tny-account.c:
2199 Added modest_tny_account_new_from_server_account_name().
2200 modest_tny_account_new_from_server_account(): Do not create the
2201 send queues here, because they will be
2202 recreated anyway when the connection changes for the first time.
2204 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2206 * src/modest-local-folder-info.h:
2207 * src/modest-local-folder-info.c:
2208 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2209 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2210 tbox_folder): Take a modest account name instead of a server TnyAccount,
2211 so we can have per-modest-account rather than per-transport-account
2213 We must make sure that we change or recreate the exisitng send queues
2214 when the connection changes for connection-specific transport accounts.
2216 * src/modest-tny-account-store.c:
2217 (create_per_account_local_outbox_folders): Create outboxed per modest
2218 account, not per transport account.
2220 * src/modest-tny-account.h:
2221 * src/modest-tny-account.c:
2222 (modest_tny_account_get_special_folder): For outboxes, get the
2223 parent modest account name. The account is ignored for other folders.
2224 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2225 modest account name rather than a server TnyAccount.
2227 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2229 * src/modest-tny-account.c:
2230 (modest_tny_account_new_from_server_account):
2231 Call modest_runtime_get_send_queue() immediately after creating transport
2232 accounts, so that they start trying to send email from the outbox as soon
2233 as possible at startup. This is probably what we want.
2235 * src/modest-mail-operation.c: (update_account_thread):
2236 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2237 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2238 * src/modest-tny-send-queue.h:
2239 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2240 (modest_ui_actions_on_send):
2241 Added comments about how sending works, though it needs some more work.
2243 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2245 * src/modest-tny-account.c:
2246 (modest_tny_account_get_special_folder): Add TODO because this fails when
2247 the network is busy.
2248 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2249 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2250 Do not try to show this window when there is no active account. The UI
2251 specs does not tell us what to do in this case.
2253 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2257 * src/maemo/Makefile.am:
2258 * src/widgets/Makefile.am: Some dist fixes.
2260 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/modest-connection-specific-smtp-window.c:
2263 (on_button_edit): Make the code clearer, to prevent a double free.
2265 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/modest-account-settings-dialog.c:
2268 (modest_account_settings_dialog_set_account_name),
2269 Check the connection-specific smtp servers checkbox if there are any.
2271 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2272 (modest_connection_specific_smtp_edit_window_init):
2273 Start with a suitable port number.
2275 * src/modest-account-mgr-helpers.h:
2276 * src/modest-account-mgr-helpers.c: Added
2277 modest_account_mgr_get_has_connection_specific_smtp().
2279 (modest_account_mgr_set_connection_specific_smtp),
2280 (modest_account_mgr_remove_connection_specific_smtp),
2281 (modest_account_mgr_get_has_connection_specific_smtp),
2282 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2283 connection-specific smtp server accounts in the account, rather than
2284 the server account conf dir.
2286 This fixes bug projects.maemo.org bug NB#58263 .
2288 * src/modest-tny-account-store.c:
2289 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2290 if there are no server accounts yet, to prevent an infinite loop when there
2291 are no accounts. Document that one must be called before the other.
2293 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-account-mgr-helpers.c:
2296 (modest_account_mgr_get_default_account): Make sure that at least
2297 one account is always the default, if there are any enabled accounts.
2298 This is just a sanity check that shouldn't be necessary.
2300 * src/modest-account-mgr-priv.c:
2301 (_modest_account_mgr_account_from_key): Unescape the conf key to
2302 get the real account name. For instance, this is an issue if a space
2303 was in the account name, which can happen because the account name
2304 is generated from the display name.
2305 (_modest_account_mgr_get_account_keyname): Always escape the
2307 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2308 Unescape the conf keys to get the real account names.
2310 For instance, previously the is-default radio button in the accounts
2311 list was not checked for any accounts at first. This fixes that,
2312 and might fix several similar bugs.
2314 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2316 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2317 Removed some debug printfs.
2319 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2321 Modest on-disk outbox directories are now here, for instance:
2322 $HOME/.modest/outboxes/<account-id-1>/outbox
2323 $HOME/.modest/outboxes/<account-id-2>/outbox
2325 $HOME/.modest/local-folders/outbox
2326 so we can have a separate outbox for each account.
2327 But they are shown as one outbox in the GtkTreeView, by using a
2328 TnyMergeFolder in a ModestTnySimpleFolderStore.
2331 * src/modest-tny-simple-folder-store.c:
2332 * src/modest-tny-simple-folder-store.h:
2333 Added ModestTnySimpleFolderStore, used to contain folders from
2334 other folder stores, such as other accounts.
2336 * src/modest-tny-outbox-account.h:
2337 * src/modest-tny-outbox-account.c:
2338 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2339 used for the per-account local outbox folders.
2341 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2342 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2343 only use this (internally) now for the non-outbox local folders.
2345 * src/modest-init.h:
2346 * src/modest-init.c: Added modest_init_one_local_folder(), for
2347 setting up the directory structure for each local folder.
2349 * src/modest-local-folder-info.c:
2350 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2351 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2353 * src/modest-local-folder-info.h:
2354 * src/modest-tny-account-store.c: (on_account_removed),
2355 (on_account_changed), (create_per_account_local_outbox_folders),
2356 (get_server_accounts), (modest_tny_account_store_get_accounts),
2357 (modest_tny_account_store_get_tny_account_by_account),
2358 (modest_tny_folder_store_is_virtual_local_folders):
2360 * src/modest-tny-account.h:
2361 * src/modest-tny-account.c:
2362 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2363 to create an on-disk per-account local outbox folder for each
2365 (create_per_account_local_outbox_folders): Create a local outbox folder
2366 for each transport account.
2367 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2368 for all local folders.
2370 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2371 instead of using g_object_get/set() directly. It is clearer.
2373 (modest_tny_folder_store_get_message_count),
2374 (modest_tny_folder_store_get_local_size
2375 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2376 because we now use these with non-acount folder stores.
2378 (modest_tny_account_get_special_folder),
2379 (modest_tny_account_new_from_server_account),
2380 (modest_tny_account_new_from_account):
2381 (recurse_folders): Adjust to the new outbox system.
2383 * src/modest-tny-folder.h:
2384 * src/modest-tny-folder.c:
2385 (modest_tny_folder_is_local_folder),
2386 (modest_tny_folder_get_local_folder_type),
2387 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2389 * src/widgets/modest-main-window.h:
2390 * src/maemo/modest-main-window.c: (create_details_widget),
2391 (modest_main_window_set_contents_style): Show details for any folder store,
2394 (modest_tny_folder_get_rules):
2395 Remove the const. C does not support constness enough for this.
2397 * src/modest-ui-actions.c:
2398 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2399 make all outboxes appear as one, in the usual local-folders tree node.
2401 (set_active_account_from_tny_account),
2402 (modest_ui_actions_on_folder_selection_changed):
2403 * src/widgets/modest-folder-view.c: (text_cell_data),
2404 (icon_cell_data), (filter_row),
2405 (add_account_folders_to_merged_folder),
2406 (add_account_folders_to_simple_folder_store), (),
2407 (get_cmp_rows_type_pos), (cmp_rows),
2408 (modest_folder_view_set_account_id_of_visible_server_account):
2409 Adjust to the new outbox system, using generic folder stores and folders
2410 in the GtkTreeModel.
2412 2007-05-23 Christian Kellner <ckellner@openismus.com>
2414 * src/modest-mail-operation.c:
2415 (modest_mail_operation_update_account):
2416 Use info->max_size instead of unintialized local var [small
2417 build fix]. (Added TODO to review that change since I don't
2420 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2422 * libmodest-dbus-client/libmodest-dbus-client.c:
2423 (libmodest_dbus_client_compose_mail): function added
2424 * src/dbus_api/modest-dbus-api.h:
2425 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2426 (on_compose_mail): Implementation of the SendAsMail functionality
2428 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2430 * src/modest-account-mgr.c:
2431 (modest_account_mgr_add_server_account): Set the secure-connection
2432 conf key for transport accounts as well as store accounts. I don't know
2433 why the if was there. For instance, this makes sure that we use SSL
2434 for the gmail preset from the easysetup wizard.
2436 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2438 * src/gnome/modest-main-window.c:
2439 (on_account_store_connecting_finished), (connect_signals):
2440 * src/maemo/modest-main-window.c:
2441 (on_account_store_connecting_finished), (connect_signals),
2442 (modest_main_window_new):
2443 Handle TnyAccountStore::connecting-finished instead of
2444 TnyDevice::connection-changed, because we cannot actually perform
2445 operations on accounts until TnyAccountStore has itself responded to
2446 the TnyDevice::connection-changed signal. This prevents a GError from
2448 Do not try to update at startup, because we (at least on scratchbox)
2449 already do an update at startup when the device goes online.
2450 This prevents a GError from tinymail.
2451 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2452 Added TODO about stopping simultaneous operations.
2454 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2456 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2457 * src/modest-mail-operation-queue.c:
2458 (modest_mail_operation_queue_remove):
2459 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2460 about where they happened.
2462 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2464 * src/modest-ui-actions.c:
2465 (modest_ui_actions_on_password_requested): Make sure that the remember
2466 output parameter is always TRUE.
2468 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2470 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2471 Show a OK/Cancel dialog if the error is a question, though we still do not
2472 know anything more about what we are asking the user.
2473 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2474 Fix an uninitialized variable (helper). This is a logic error, however.
2476 2007-05-21 Christian Kellner <ckellner@openismus.com>
2478 * src/modest-search.h:
2479 Correct bit shifting in the ModestSearchFlags enum.
2481 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2483 * src/modest-tny-account.c:
2484 (modest_tny_account_new_from_server_account): Do not use the lsub and
2485 check-all hard-coded IMAP options when using POP.
2487 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2489 * src/modest-tny-account.c:
2490 (modest_tny_account_new_from_server_account):
2491 Use NULL for the secure-auth method for POP when Password auth has been
2492 specified by the user, as we already do for IMAP. "auth=Login" causes
2493 an error from camel or the server.
2495 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2497 * src/maemo/modest-account-settings-dialog.c:
2498 (create_page_account_details),
2499 (modest_account_settings_dialog_set_account_name):
2500 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2501 for the leave-on-server checkbox, rathr than just the checkbox, when
2502 the protocol is not POP.
2504 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2506 * src/widgets/modest-account-view.c:
2507 * src/widgets/modest-account-view.h:
2508 Added modest_account_view_select_account() which will be useful later
2509 to asynchronously re-select the edited account.
2511 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/modest-account-settings-dialog.c:
2514 (modest_account_settings_dialog_set_account_name):
2515 Automatically choose the port numbers based on the secure authentication
2516 methods, if they have not been chosen before.
2517 This fixes projects.maemo.org bug NB#56273 .
2519 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2521 * src/maemo/modest-main-window-ui.h:
2522 * src/modest-ui-actions.c:
2523 * src/modest-ui-actions.h:
2524 Connect the Tools/SMTP Servers menu item to
2525 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2526 SMTP servers dialog, as in the UI specification and saves changes when it
2527 is closed. This fixed projects.maemo.org bug NB#56305 .
2529 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/modest-connection-specific-smtp-window.c:
2532 (modest_connection_specific_smtp_window_init):
2533 Use gtk_window_set_default_size() to make this window big enough, so
2534 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2536 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2538 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2540 (modest_connection_specific_smtp_edit_window_init),
2541 Do not try to connect to a combobox signal before the combobox exists.
2542 This fixes the cras in projects.maemo.org bug NB#56288 .
2543 (modest_connection_specific_smtp_edit_window_get_settings):
2544 Remove the server_account_name parameter which was being checked for NULL
2545 though it was not used.
2547 * src/maemo/modest-connection-specific-smtp-window.c:
2548 (modest_connection_specific_smtp_window_fill_with_connections),
2549 (on_button_edit), (modest_connection_specific_smtp_window_init):
2550 Correct the number of treemodel columns to prevent a warning.
2551 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2552 libconic does not work.
2554 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2556 * src/modest-tny-account.c:
2557 (modest_tny_account_new_from_server_account):
2558 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2559 SMTP when "None" was chosen by the user. However, with my SMTP server that
2560 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2563 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2565 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2566 to explain the memory management issue with the ID in the ModestPair.
2568 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2569 (add_sending_page), (modest_account_assistant_finalize):
2570 * src/gnome/modest-gnome-global-settings-dialog.c:
2571 (create_updating_page), (create_composing_page):
2572 * src/gnome/modest-msg-edit-window.c: (get_transports),
2573 (init_window), (modest_msg_edit_window_finalize),
2574 (modest_msg_edit_window_get_msg_data):
2575 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2576 * src/gnome/modest-transport-widget.c:
2577 (modest_transport_widget_finalize), (smtp_configuration):
2578 * src/maemo/modest-maemo-global-settings-dialog.c:
2579 (create_updating_page), (create_composing_page):
2580 * src/maemo/modest-msg-edit-window.c: (get_transports),
2581 (init_window), (modest_msg_edit_window_finalize),
2582 (modest_msg_edit_window_get_msg_data),
2583 (modest_msg_edit_window_free_msg_data):
2584 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2585 (modest_store_widget_finalize):
2586 * src/maemo/modest-transport-widget.c:
2587 (modest_transport_widget_finalize), (smtp_configuration):
2588 * src/modest-main.c: (send_mail):
2589 * src/widgets/modest-combo-box.h:
2590 * src/widgets/modest-global-settings-dialog-priv.h:
2591 * src/widgets/modest-global-settings-dialog.c:
2592 (modest_global_settings_dialog_finalize):
2593 * src/widgets/modest-msg-edit-window.h:
2594 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2595 as long as the combo box, to prevent use of freed memory for the ID.
2597 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2599 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2600 get_accounts(), to make this clearer. Do not check for the enabled gconf
2601 key, because we do not use this for server accounts (at least, not yet).
2602 This allows us to send email again.
2604 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2606 * src/maemo/modest-platform.c:
2607 (on_modest_conf_update_interval_changed), (modest_platform_init):
2608 Only respond to this particular key change. All these strcmp()s cannot be
2611 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/modest-maemo-global-settings-dialog.c:
2614 (current_connection): Prevent a crash in scratchbox when
2615 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2616 * src/maemo/modest-platform.c:
2617 (on_modest_conf_update_interval_changed), (modest_platform_init):
2618 Get the update interval from gconf and reset it when the gconf key changes.
2620 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-protocol-info.c:
2623 * src/modest-protocol-info.h: Adde enum-specific get functions,
2624 instead of using a ModestProtocolType enum parameter.
2626 * src/gnome/modest-account-assistant.c:
2627 * src/gnome/modest-store-widget.c:
2628 * src/gnome/modest-store-widget.h:
2629 * src/gnome/modest-transport-widget.c:
2630 * src/gnome/modest-transport-widget.h:
2631 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2632 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2633 * src/maemo/easysetup/modest-easysetup-wizard.c:
2634 * src/maemo/modest-account-settings-dialog.c:
2635 * src/maemo/modest-account-settings-dialog.h:
2636 * src/maemo/modest-store-widget.c:
2637 * src/maemo/modest-store-widget.h:
2638 * src/maemo/modest-transport-widget.c:
2639 * src/maemo/modest-transport-widget.h:
2640 * src/modest-account-mgr-helpers.c:
2641 * src/modest-account-mgr-helpers.h:
2642 * src/modest-account-mgr.c:
2643 * src/modest-account-mgr.h:
2644 * src/modest-tny-account.c:
2645 * src/modest-tny-folder.c:
2646 * src/widgets/modest-account-view.c:
2647 * src/widgets/modest-retrieve-combo-box.c:
2648 * src/widgets/modest-retrieve-combo-box.h:
2649 * src/widgets/modest-secureauth-combo-box.c:
2650 * src/widgets/modest-serversecurity-combo-box.c:
2651 * src/widgets/modest-serversecurity-combo-box.h:
2652 * tests/check_account-mgr.c:
2653 Use the specific functions, and use the re-renamed enum values for GNOME too.
2655 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2657 * src/modest-pair.h:
2658 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2659 so we can get the second based on the first.
2661 * src/maemo/modest-account-settings-dialog.h:
2662 * src/maemo/modest-account-settings-dialog.c:
2663 Added get_supported_secure_authentication_methods(), though it is mostly
2664 commented-out for now until the necessary API is committed to tinymail.
2665 (modest_account_settings_dialog_set_account_name),
2666 (save_configuration): Request the supported authentication methods from the
2667 server, so we can choose a working method.
2669 * src/modest-tny-account-store.h:
2670 * src/modest-tny-account-store.c:
2671 (modest_tny_account_store_get_session): Rename from
2672 tny_account_store_get_session().
2674 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2676 * src/modest-protocol-info.h: Split the ModestProtocol enum
2677 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2678 There was no need to have these unrelated values in one enum.
2680 * src/: many files: Adapted to changed enum. This makes the code a bit
2681 clearer, and the compiler could catch some errors.
2683 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2685 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2686 Show the detailed internal camel error message when an error happens
2687 during the configuration, so that our testers can give us more clues.
2688 For instance, in projects.maemo.org bug NB#56910 .
2690 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2692 * src/modest-tny-account.c:
2693 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2694 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2696 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2699 * src/maemo/modest-account-settings-dialog.c:
2700 (modest_account_settings_dialog_set_account_name),
2701 (save_configuration): For the incoming secure authentication checkbox,
2702 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2703 the UI specification. PLAIN does not seem to be supported for most IMAP
2704 servers anyway, and I am not sure what it would mean.
2705 However, we probably need to discover which of the secure-authentication
2706 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2707 * src/modest-account-mgr-helpers.c:
2708 (modest_account_mgr_get_server_account_data):
2710 * src/modest-tny-account.c:
2711 (modest_tny_account_new_from_server_account):
2712 Use tny_account_set_mech() to set secure-authentication methods,
2713 with some special-casing for IMAP, based on my observations of how
2716 * src/modest-account-mgr-helpers.h:
2717 * src/modest-account-mgr.c:
2718 * src/modest-defs.h: Comment that the URI is only used for local folders.
2720 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2722 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2723 parameter const, just to be neat.
2724 * src/modest-text-utils.c: (modest_text_utils_inline):
2725 End g_strconcat() with NULL, as its documentation says. This is almost
2726 certainly the cause of my crash at startup on the device. Interestingly,
2727 valgrind doesn't tell us about these errors.
2729 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2731 * scripts/build-packages: Added more precise comments about how to use
2732 this script, though I still get this error:
2733 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2734 error building tinymail
2736 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2738 * src/maemo/modest-main-window.c: (on_account_update):
2739 Very slight cleanup, hoping to make it simpler to discover what causes
2740 a crash here sometimes.
2742 * src/modest-tny-account.c:
2743 (modest_tny_account_new_from_server_account): Set the port. Added
2744 comments about the options and a TODO comment because I need to find out
2745 how to specify the secure authentication method.
2747 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2749 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2750 changed CFlags paths form modest to libmodest
2752 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2754 * src/modest-account-mgr-helpers.c:
2755 (modest_account_mgr_get_server_account_data),
2756 (modest_account_mgr_free_server_account_data):
2757 * src/modest-account-mgr-helpers.h:
2758 * src/modest-account-mgr.c:
2759 (modest_account_mgr_add_server_account):
2760 * src/modest-defs.h:
2761 * src/modest-tny-account.c:
2762 (modest_tny_account_new_from_server_account):
2763 Determine the options for tny_camel_account_add_option() here,
2764 based on the settings, rather than storing them directly in gconf.
2766 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2768 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2769 Show a more friendly error dialog now that we expect (from the tinymail
2770 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2772 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/modest-main-window.c: (on_account_update): Check that
2775 account_name is not NULL, to prevent a crash at startup that I am
2776 seeing on the N800. I do wonder why it is NULL.
2778 * src/maemo/easysetup/modest-easysetup-wizard.c:
2779 (create_page_user_details):
2780 * src/maemo/modest-account-settings-dialog.c:
2781 (create_page_user_details), (create_page_outgoing):
2782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2783 (modest_connection_specific_smtp_edit_window_init):
2784 * src/modest-ui-actions.c:
2785 (modest_ui_actions_on_password_requested):
2786 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2787 might do something useful with the on-screen keyboard.
2789 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2791 * src/maemo/modest-main-window.c: (on_account_update):
2792 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2793 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2795 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2797 * src/modest-tny-account-store.c: (on_account_changed):
2798 Correct the signature of this signal handler.
2800 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2802 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2803 Show a HildonNote instead of a GtkDialog for Maemo.
2805 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2807 * src/widgets/modest-account-view.h:
2808 * src/widgets/modest-account-view.c: (on_account_changed),
2809 (on_account_removed). Added a boolean flag, set/unset by
2810 modest_account_view_block_conf_updates(),
2811 modest_account_view_unblock_conf_updates() to prevent unnecessary
2812 updates, but this is not very useful because the gconf notifications are
2813 so delays (maybe only on Maemo Bora).
2814 So auto-updating is turned off, and these functions do an explicit
2815 update when necessary.
2816 However, something else is still doing too much work when adding/removing
2817 accounts, probably in another part of the application.
2819 * src/maemo/modest-account-view-window.c:
2820 (on_delete_button_clicked), (on_edit_button_clicked),
2821 (on_new_button_clicked): Use the new functions.
2823 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2825 * src/modest-account-mgr-helpers.c:
2826 (modest_account_mgr_set_first_account_as_default):
2827 Sort the list of names alphabetically-by-title, so we choose the first one
2829 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2830 alphabetically by the title.
2832 This fixes projects.maemo.org bug NB#56418 .
2834 * src/modest-account-mgr-priv.c:
2835 (_modest_account_mgr_account_from_key):
2836 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2837 avoid a valgrind error, and possible random behaviour.
2839 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2841 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2842 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2843 tinymail documentation to say that this can be expected.
2844 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2845 pretty, and should not happen, but I would prefer to know when it does.
2847 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2849 * configure.ac: When using the older hildon version, probably on Bora,
2850 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2852 * src/widgets/modest-attachment-view.c:
2853 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2856 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2858 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2859 Implemented the prototype. Can be tested with
2860 tests/dbus_api/test_open_message:
2862 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2864 * src/modest-tny-account-store.c:
2865 (modest_tny_account_store_instance_init), (get_password):
2866 * src/modest-ui-actions.c:
2867 (modest_ui_actions_on_password_requested):
2868 Do not store the password in gconf, because this function is called
2869 for non-remembered passwords. Actually use the cached (in the hash map)
2870 password instead of releasing it.
2871 The password will now not be remembered if it is asked via the protected
2872 password dialog, as per the UI spec.
2874 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2876 * src/modest-defs.h:
2877 * src/modest-account-mgr-helpers.h:
2878 * src/modest-account-mgr-helpers.c:
2879 Added modest_server_account_get_username_has_succeeded(),
2880 modest_server_account_set_username_has_succeeded().
2881 (modest_server_account_set_username),
2882 Reset the has-succeeded flag if the username changes.
2884 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2885 * src/maemo/modest-connection-specific-smtp-window.c:
2886 (modest_connection_specific_smtp_window_save_server_accounts):
2887 Use modest_server_account_set_username() instead of using
2888 modest_conf_set_string() directly, so that the has-succeeded flag is always
2891 * src/modest-ui-actions.c:
2892 (modest_ui_actions_on_password_requested): Dim the username entry if
2893 the username has ever worked, as per the UI spec.
2895 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2897 * src/modest-tny-account-store.c: (get_password):
2898 * src/modest-ui-actions.c:
2899 (modest_ui_actions_on_password_requested):
2900 Allow the username to be changed too, though there is more work to
2901 be done on exactly how this behaves.
2903 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2905 * src/modest-account-mgr-helpers.h:
2906 * src/modest-account-mgr-helpers.c:
2907 Added modest_account_mgr_get_display_name(),
2908 modest_server_account_get_username(),
2909 modest_server_account_set_username(),
2910 modest_server_account_set_password(),
2911 modest_server_account_get_hostname() functions so we do not need to
2912 use the conf API directly.
2914 * src/maemo/modest-main-window.c: (connect_signals):
2915 Actually connect ot the ModestAccountStore::request-password signal,
2916 so that we show the dialog when the password is requested by Tinymail,
2917 for isntance if it is empty.
2919 * src/modest-marshal.list:
2920 * src/modest-tny-account-store.c:
2921 (modest_tny_account_store_class_init), (get_password),
2922 (modest_tny_account_store_alert):
2923 * src/modest-tny-account-store.h:
2924 * src/modest-ui-actions.h:
2925 * src/modest-ui-actions.c:
2926 (modest_ui_actions_on_password_requested):
2927 Change the signal parameters, so it is obvious that we are providing
2928 the non human-readable server name, and receiving both the username
2929 and password, though changing of the username is not yet implemented.
2930 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2931 for the GNOME version.
2933 This should fix the projects.maemo.org bug NB#56209, though it does not
2934 work on Bora, because the gconf_client_get() for the password fails
2935 immediately after we save it with gconf_client_set().
2937 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2940 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2941 caused an undefined symbol error:
2942 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2944 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2946 * src/modest-tny-account-store.c:
2947 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2948 using a GError instead of a string message, so we can translate it in
2951 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2953 * src/maemo/modest-address-book.c:
2954 (modest_address_book_check_names):
2955 * src/maemo/modest-msg-view-window.c:
2956 (modest_msg_view_window_clipboard_owner_change):
2957 * src/modest-init.c: (modest_init_init_ui):
2958 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2959 (update_folders_cb), (modest_mail_operation_update_account):
2960 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2961 (modest_ui_actions_on_msg_attachment_clicked),
2962 (modest_ui_actions_on_msg_recpt_activated):
2963 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2964 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2965 (modest_msg_view_search_next):
2966 * src/widgets/modest-recpt-editor.c:
2967 (modest_recpt_editor_on_button_release_event),
2968 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2969 g_message(). At this point we should only be seeing interesting errors on
2970 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2972 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2974 (modest_wizard_dialog_force_title_update):
2975 * src/maemo/easysetup/modest-wizard-dialog.h:
2976 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2977 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2978 can update the title when appropriate. Otherwise the title is wrong if the
2979 pages are added after adding the notebook to the dialog.
2980 This must be a problem in HildonWizardDialog too.
2981 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2983 * src/maemo/easysetup/modest-easysetup-wizard.c:
2984 (create_subsequent_customsetup_pages),
2985 (create_subsequent_easysetup_pages):
2986 Call modest_wizard_dialog_force_title_update() so that the title is
2987 correct even with GTK+ < 2.10.
2988 This fixes projects.maemo.org bug NB#56145 .
2990 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2992 * src/maemo/modest-platform.c:
2993 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2994 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2997 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2999 * src/widgets/modest-window.h:
3000 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3001 and modest_window_save_state(), which invokes it.
3003 * src/widgets/modest-window-mgr.h:
3004 * src/widgets/modest-window-mgr.c:
3005 Added modest_window_mgr_save_state_for_all_windows(), which calls
3006 the save_state vfunc on all registered windows, if implemented.
3008 * src/gnome/modest-msg-edit-window.c:
3009 * src/gnome/modest-msg-view-window.c:
3010 * src/maemo/modest-msg-edit-window.c:
3011 * src/maemo/modest-msg-view-window.c:
3012 * src/maemo/modest-main-window.c:
3013 Specify the existing save_settings functions as implementations of
3014 ModestWindow::save_state_func().
3016 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3017 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3018 enabling hibernation, for instance.
3020 We may need to do the same thing for restoring settings.
3023 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3025 * src/widgets/modest-window-mgr.c:
3026 * src/widgets/modest-window-mgr.h:
3027 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3028 modest_window_mgr_get_hibernation_is_prevented().
3030 * src/maemo/modest-main-window.c:
3031 (on_hildon_program_is_topmost_notify): Prevent hibernation
3032 (possible when the application goes to the background in the WM),
3033 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 (modest_easysetup_wizard_dialog_init):
3037 * src/maemo/modest-account-settings-dialog.c:
3038 (modest_account_settings_dialog_init):
3039 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3040 (modest_connection_specific_smtp_edit_window_init):
3041 * src/maemo/modest-connection-specific-smtp-window.c:
3042 (modest_connection_specific_smtp_window_init):
3043 * src/maemo/modest-signature-editor-dialog.c:
3044 (modest_signature_editor_dialog_init):
3045 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3046 prevent hibernation while any of these account settings dialogs are open.
3048 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3050 * src/maemo/Makefile.am:
3051 * src/maemo/modest-osso-state-saving.c:
3052 * src/maemo/modest-osso-state-saving.h: Added
3053 modest_osso_load_state() and modest_osso_save_state() though they do
3054 nothing now. They should iterate through all the open windows and load/save
3056 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3057 save state when closing.
3059 * src/maemo/modest-main-window.c:
3060 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3061 Add a notification handler for the HildonProgram::is-topmost property,
3062 so we can allow hibernation when the application goes into the background.
3063 But we still need to detect when the accounts setup windows are open so
3064 we can stop hibernation when they are open.
3065 To do this, I also added the main window the HildonProgram. This might have
3066 other side-effects/benefits, and should maybe be done for other windows.
3068 * src/maemo/modest-osso-autosave-callbacks.h:
3069 * src/maemo/modest-osso-autosave-callbacks.c:
3070 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3071 though it does not do anything yet, and we might never need this to do
3072 anything. For instance, we already save drafts.
3074 * src/maemo/modest-platform.c: (modest_platform_init):
3075 Specify the libosso auto-save callback.
3077 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3079 * src/maemo/modest-platform.c:
3080 (modest_platform_set_update_interval):
3081 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3082 aparently stays valid between application instances, so we can use this
3083 to remove and reset it later. According to a maemo-developers email from
3086 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3088 * configure.ac: Depend on libalarm for Maemo.
3090 * src/dbus_api/modest-dbus-api.h:
3091 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3092 (on_send_receive), (modest_dbus_req_handler):
3093 Handle a SEND_RECEIVE D-Bus method.
3095 * libmodest-dbus-client/libmodest-dbus-client.c:
3096 (libmodest_dbus_client_send_and_receive):
3097 * libmodest-dbus-client/libmodest-dbus-client.h:
3098 Add C convenience functions for calling the new D-Bus method.
3100 * src/modest-platform.h:
3101 * src/gnome/modest-platform.c:
3102 * src/maemo/modest-platform.c:
3103 Added modest_platform_set_update_interval(), which uses the
3104 alarmd API on Maemo.
3105 (modest_platform_init),
3106 Call modest_platform_set_update_interval(), using a hard-coded
3107 interval for now (until the global settings dialog is implemented),
3108 though I am not sure that this makes sense yet.
3110 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3112 * src/dbus_api/modest-dbus-callbacks.c:
3113 (modest_osso_cb_hw_state_handler):
3114 * src/dbus_api/modest-dbus-callbacks.h:
3115 * src/maemo/modest-platform.c: (modest_platform_init):
3116 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3117 in case this has some effect on the ability for Maemo to ping the
3120 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3123 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3124 warning. It is probably a logic error, but I need to fix the build.
3126 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3128 * src/modest-account-mgr.h:
3129 * src/modest-account-mgr.c:
3130 (modest_account_mgr_account_names): Add a gboolean enabled_only
3131 parameter, so we can get lists of onlt the enabled accounts.
3133 (modest_account_mgr_add_account),,
3134 (modest_account_mgr_account_with_display_name_exists):
3135 * src/maemo/modest-msg-edit-window.c: (get_transports):
3136 * src/modest-account-mgr-helpers.c:
3137 (modest_account_mgr_set_first_account_as_default):
3138 * src/modest-init.c: (init_default_account_maybe):
3139 * src/modest-tny-account-store.c: (get_accounts):
3140 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3141 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3142 * tests/check_account-mgr.c: (START_TEST):
3143 Provide the extra parameter, as appropriate.
3145 * src/widgets/modest-account-view.c: (update_account_view):
3146 Do not show disabled accounts (meaning that there is no way to
3147 enable/disable accounts in the UI (the feature is not in our UI
3148 specification), so we can use this internally only to mark unfinished
3149 or temporary account data.
3151 * src/maemo/easysetup/modest-easysetup-wizard.c:
3152 (create_account): Add boolean enable parameter, so we can specify FALSE
3153 to create the temporary account.
3154 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3155 (on_before_next): When finishing, when there is a temporary account, just
3157 Also, use a timeout to delay the showing of the dialog until gconf is likely
3158 to return correct information, due to a maemo gconf bug that is fixed in
3159 osso 1.1, but not yet in Bora.
3160 However, the dialog stays on screen after it is destroyed.
3162 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3163 for invalid data when cancelling. Use a hildon note instead of a dialog
3164 to complain about invalid data. Do not show the account-saved note if the
3165 account is disabled (a temporary account that will not really be saved for use
3168 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3170 * src/modest-account-mgr-helpers.h:
3171 * src/modest-account-mgr-helpers.c:
3172 Added modest_account_mgr_unset_default_account(),
3173 Added modest_account_mgr_set_first_account_as_default().
3175 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3176 If it was the default account, unset the default account name.
3178 * src/maemo/modest-account-view-window.c:
3179 (on_delete_button_clicked): If it was the default account,
3180 set the first remaining account as the default instead.
3182 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3183 a NULL account or a NULL default account, to prevent a crash. This should
3184 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3187 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3189 * src/widgets/modest-recpt-editor.c:
3190 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3191 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3192 TODO comment for this. This fixes the build.
3194 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3195 be the best place for it. This will in future update all auto-update accounts,
3196 rather than just the current/default account, when that gconf key exists.
3197 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3198 if there are no accounts, before calling do_send_receive().
3199 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3201 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3202 * src/maemo/modest-main-window-ui.h:
3203 * src/maemo/modest-main-window.c: (on_connection_changed),
3204 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3205 directly, becaue the signal handler does more.
3207 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3209 * src/modest-account-mgr-helpers.c:
3210 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3211 for the case that the account does not exist.
3213 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3214 (equivalent to the modest account name) rather than the tinymail account name
3215 (equivalent to the modest account title - human readable) to get the account data.
3216 Check for null account data to prevent the crash, and add a TODO comment saying that
3217 this needs fixing because it is using the server account name instead of the account name.
3219 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3222 * src/maemo/modest-account-settings-dialog.c: (show_error),
3224 Use hildon_note_new_information() for informative and error messages,
3225 which seems to be expected for Maemo applications (no documentation that I know of
3226 says this). I am surprised that there is no distinction between info and error
3229 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3232 it is easy to find where this is used.
3234 * src/maemo/easysetup/modest-easysetup-wizard.c:
3235 (create_page_welcome), (create_page_account_details),
3236 (create_page_user_details), (create_page_complete_easysetup),
3237 (create_page_custom_incoming), (create_page_custom_outgoing),
3238 (create_page_complete_custom):
3239 * src/maemo/modest-account-settings-dialog.c:
3240 (create_page_account_details), (create_page_user_details),
3241 (create_page_incoming), (create_page_outgoing):
3242 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3244 (modest_connection_specific_smtp_edit_window_init):
3245 * src/maemo/modest-connection-specific-smtp-window.c:
3246 (modest_connection_specific_smtp_window_init):
3247 * src/maemo/modest-signature-editor-dialog.c:
3248 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3249 and scrolling policy as per the Email Application Layout Guide, if I have
3252 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3254 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3255 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3256 which were empty, because these vfuncs have been removed from TnyAccountStore.
3257 This fixes the build.
3259 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3261 * src/maemo/modest-main-window.c:
3262 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3263 showing/hiding it. Added TODO because it probably should not be NULL.
3264 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3265 because unnecessary g_warnings() make degugging difficult.
3267 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3269 * src/maemo/modest-msg-edit-window.c:
3270 (modest_msg_edit_window_select_color),
3271 (modest_msg_edit_window_select_background_color): 2 const corrections and
3272 moving 2 #endifs before closing brackets, to fix the build.
3274 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3276 * src/maemo/easysetup/modest-easysetup-wizard.h:
3277 * src/maemo/easysetup/modest-easysetup-wizard.c:
3278 (modest_easysetup_wizard_dialog_finalize),
3279 (on_button_edit_advanced_settings), (create_page_complete_custom),
3280 (on_response), (create_account):
3281 Implement the Advanced Settings edit button, by saving the account information,
3282 for the Advanded Settings dialog to use directly from gconf, and removing it
3283 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3284 Bug #5533 in the projects.maemo.org bugzilla.
3286 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3288 * src/maemo/modest-msg-view-window.c:
3289 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3290 when opening a message window.
3292 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3294 * src/maemo/easysetup/modest-easysetup-wizard.c:
3295 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3298 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3299 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3300 gconf settings. I probably added more checks than necessary, but that is safer.
3302 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3303 variable to fix the build, but this seems to be used when it is still NULL.
3305 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3307 * src/modest-platform.h:
3308 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3309 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3310 * src/modest-main.c: Implement this function so we can avoid using
3311 maemo-specific API from cross-platform code.
3313 * src/modest-tny-account-store.c:
3314 (get_smtp_specific_transport_account_for_open_connection):
3315 * src/modest-ui-actions.c: (check_for_connection),
3316 (modest_ui_actions_on_item_not_found):
3317 Use modest_platform_connect_and_wait() and put #idefs around other
3318 maemo-specific code, because only maemo currently has a way to
3319 identify connection names.
3321 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3323 * src/modest-tny-account-store.h:
3324 * src/modest-tny-account-store.c:
3325 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3326 the connection-specific SMTP server settings in the configuration.
3328 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3330 * src/maemo/modest-main-window.c: (on_connection_changed),
3332 * src/modest-main.c: (main), (start_ui), (send_mail):
3333 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3334 that is what is intended.
3336 * src/modest-ui-actions.c: (action_send), (action_receive),
3337 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3338 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3339 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3340 SMTP server is used when it is specified.
3342 (modest_ui_actions_on_send_receive):
3343 Check that a connection is open before proceeding.
3344 Receive and then send, instead of vice-versa, as per the specification.
3346 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3348 * src/modest-mail-operation.c:
3349 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3350 though I guess it should be something other than NULL.
3352 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3354 * src/maemo/easysetup/modest-easysetup-wizard.c:
3355 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3356 combo twice, to avoid an g_warning and to make it visible again.
3357 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3358 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3359 (already intended) dereference when detaching, because we then recreate the menu.
3360 But I am not sure why the warning was happening, and it is possible that this is a memory
3363 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3365 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3366 and uri_parse_mailto() utility functions.
3367 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3369 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3371 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3373 * src/dbus_api/modest-dbus-api.h:
3374 * src/dbus_api/modest-dbus-callbacks.c:
3375 Use an idle callback to execute the modest code in the application's own thread.
3376 Remove the helloworld example method.
3377 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3378 parsed, and the open-message method is not implemented because this is not yet implemented in
3380 * libmodest-dbus-client/libmodest-dbus-client.c:
3381 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3382 (libmodest_dbus_client_open_message):
3383 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3385 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3386 body without crashing.
3388 * tests/dbus_api/Makefile.am:
3389 * tests/dbus_api/test_mail_to.c:
3390 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3392 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3394 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3395 Added file to fix the build. Sorry.
3397 * src/dbus_api/Makefile.am:
3398 * src/dbus_api/modest-dbus-api.h:
3399 * src/dbus_api/modest-dbus-callbacks.h:
3400 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3401 (modest_dbus_req_handler):
3402 Put constants in a separate header so it can be reused by the
3403 client library, without duplication
3405 * libmodest-dbus-client/Makefile.am:
3406 * libmodest-dbus-client/libmodest-dbus-client.c:
3407 (libmodest_dbus_client_call_helloworld),
3408 (libmodfest_dbus_client_send_mail),
3409 (libmodfest_dbus_client_mailto),
3410 (libmodfest_dbus_client_open_message):
3411 * libmodest-dbus-client/libmodest-dbus-client.h:
3412 (Partly) Implement a send_mail D-Bus method.
3414 * tests/dbus_api/Makefile.am:
3415 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3416 the send_email D-Bus method.
3418 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3422 * libmodest-dbus-client/Makefile.am:
3423 * libmodest-dbus-client/libmodest-dbus-client.c:
3424 * libmodest-dbus-client/libmodest-dbus-client.h:
3425 * tests/dbus_api/Makefile.am:
3426 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3427 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3429 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/easysetup/modest-easysetup-wizard.c:
3432 (create_page_account_details):
3433 * src/maemo/modest-account-settings-dialog.c:
3434 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3435 widgets, because this might not be the default in future versions of the Maemo GTK+.
3436 However, I can not not get capitalization to work even in a simple test case.
3438 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3440 * src/maemo/easysetup/modest-easysetup-wizard.c:
3441 (create_page_custom_incoming), (create_page_custom_outgoing):
3442 * src/maemo/modest-account-settings-dialog.c:
3443 (create_page_account_details), (create_page_incoming),
3444 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3445 instead of using gtk_check_button_with_label(), so they are aligned like the other
3446 widgets, as per the UI spec.
3448 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3450 * src/maemo/easysetup/modest-easysetup-wizard.c:
3451 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3452 * src/widgets/modest-validating-entry.c:
3453 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3454 Modest prefix instead of an EasySetup prefix.
3456 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3458 * src/widgets/modest-validating-entry.h:
3459 * src/widgets/modest-validating-entry.c: (on_insert_text),
3460 Added easysetup_validating_entry_set_max_func(), used to set a callback
3461 to call when the max number of characters is reached. GtkEntry has a max-length
3462 already but is silent about it.
3464 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3465 (create_page_account_details), (create_page_user_details),
3467 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3468 (create_page_account_details), (create_page_user_details),
3469 (create_page_outgoing):
3470 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3471 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3472 the UI spec, when the user tries to enter more than the max number of characters.
3474 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3476 * src/maemo/easysetup/modest-easysetup-wizard.c:
3477 (create_page_user_details), (create_page_custom_incoming),
3478 (create_page_custom_outgoing):
3479 * src/maemo/modest-account-settings-dialog.c:
3480 (create_page_user_details), (create_page_incoming),
3481 (create_page_outgoing):
3482 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3483 (modest_connection_specific_smtp_edit_window_init):
3484 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3485 not appropriate. Bad Maemo-specific defaults!.
3487 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3490 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3491 (modest_signature_editor_dialog_set_settings):
3492 Disable the label and textview when the checkbox is disabled, and use the
3493 specified (UI spec) default signature text.
3495 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3498 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3500 * src/modest-defs.h:
3501 * src/modest-account-mgr-helpers.h:
3502 * src/modest-account-mgr-helpers.c:
3503 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3505 * src/maemo/Makefile.am:
3506 * src/maemo/modest-signature-editor-dialog.c:
3507 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3510 * src/maemo/modest-account-settings-dialog.h:
3511 * src/maemo/modest-account-settings-dialog.c:
3512 (modest_account_settings_dialog_finalize), (on_button_signature),
3513 (save_configuration): Use the new dialog when the Edit button is pressed, and
3514 save the changes if necessary, as per the UI spec.
3516 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3518 * src/maemo/Makefile.am:
3519 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3520 based on maemo-develoers email from Dirk.
3522 * src/maemo/easysetup/modest-easysetup-wizard.c:
3523 (create_page_welcome), (create_page_account_details),
3524 (create_page_user_details), (create_page_complete_easysetup),
3525 (create_page_custom_incoming), (create_page_custom_outgoing),
3526 (create_page_complete_custom),
3527 (modest_easysetup_wizard_dialog_init):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (create_page_account_details), (create_page_user_details),
3530 (create_page_incoming), (create_page_outgoing),
3531 (modest_account_settings_dialog_init):
3532 * src/maemo/modest-connection-specific-smtp-window.c:
3533 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3535 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3537 * src/maemo/easysetup/modest-easysetup-wizard.c:
3538 (create_page_account_details), (create_page_custom_outgoing),
3539 (create_page_complete_custom):
3540 * src/maemo/modest-account-settings-dialog.c:
3541 (create_page_user_details), (create_page_incoming),
3542 (create_page_outgoing):
3543 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3544 (modest_connection_specific_smtp_edit_window_init):
3545 Use the correct (UI spec) port min/max, and use horizontal separators,
3548 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3550 * src/maemo/easysetup/modest-easysetup-wizard.c:
3551 (set_default_custom_servernames):
3552 * src/maemo/modest-account-settings-dialog.c:
3553 (create_page_incoming), (on_combo_outgoing_security_changed),
3554 (on_combo_incoming_security_changed), (create_page_outgoing),
3555 (modest_account_settings_dialog_set_account_name),
3556 (save_configuration):
3557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3558 (on_combo_security_changed),
3559 (modest_connection_specific_smtp_edit_window_init),
3560 (modest_connection_specific_smtp_edit_window_set_connection),
3561 (modest_connection_specific_smtp_edit_window_get_settings):
3562 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3565 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3568 * src/maemo/easysetup/modest-easysetup-wizard.c:
3569 (create_page_custom_outgoing), (create_page_complete_custom):
3570 * src/maemo/modest-account-settings-dialog.c:
3571 (create_page_user_details), (create_page_outgoing):
3572 * src/maemo/modest-account-view-window.c: (button_box_new):
3573 Use changed logical IDs as per the most recent UI spec:
3574 mcen_bd_emailsetup_edit -> mcen_bd_edit
3575 mcen_bd_emailsetup_delete -> mcen_bd_delete
3576 mcen_bd_emailsetup_close -> mcen_bd_close
3578 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3582 * src/dbus_api/Makefile.am:
3583 * src/dbus_api/modest-dbus-callbacks.c:
3584 * src/dbus_api/modest-dbus-callbacks.h:
3585 * src/maemo/modest-platform.c: (modest_platform_init):
3586 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3588 * tests/Makefile.am:
3589 * tests/dbus_api/Makefile.am:
3590 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3592 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/modest-account-settings-dialog.c:
3595 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3596 Removed unnecessary includes.
3598 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3600 * src/maemo/easysetup/modest-easysetup-wizard.c:
3601 * src/maemo/modest-account-settings-dialog.c:
3602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3603 * src/widgets/Makefile.am:
3604 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3605 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3606 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3607 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3608 * src/widgets/modest-secureauth-combo-box.c:
3609 * src/widgets/modest-secureauth-combo-box.h:
3610 * src/widgets/modest-serversecurity-combo-box.c:
3611 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3612 made the GObject names more consistent with the rest of the Modest code.
3614 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3616 * src/maemo/easysetup/Makefile.am:
3617 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3618 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3619 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3620 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3621 * src/maemo/easysetup/modest-easysetup-wizard.c:
3622 * src/maemo/easysetup/modest-validating-entry.c:
3623 * src/maemo/easysetup/modest-validating-entry.h:
3624 * src/maemo/modest-account-settings-dialog.c:
3625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3626 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3627 widgets/ because they are used outside of easysetup too. After checking in,
3628 svn will allow me to rename them too.
3630 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3632 * src/gnome/modest-msg-edit-window.c:
3633 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3634 linker error, to fix the build on the GNOME platform.
3635 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3636 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3637 ifdefed out to avoid a warning.
3639 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3641 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3642 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3643 some alternative for GTK+ 2.6.
3645 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3647 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3649 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3650 specified for EmailAccountsDialog in UI spec.
3652 * src/maemo/easysetup/modest-easysetup-wizard.c:
3653 * src/maemo/easysetup/modest-easysetup-wizard.h:
3654 * src/maemo/modest-account-settings-dialog.c:
3655 * src/maemo/modest-account-settings-dialog.h:
3656 Reuse a member window widget for the connection-specific SMTP server accounts,
3657 so we can tell it to create/save the accounts only if we actually save changes.
3659 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3660 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3661 (modest_connection_specific_smtp_edit_window_get_settings):
3662 Return a struct instance for temporarily remembering the entered data.
3664 * src/maemo/modest-connection-specific-smtp-window.h:
3665 * src/maemo/modest-connection-specific-smtp-window.c:
3666 (modest_connection_specific_smtp_window_finalize),
3667 (modest_connection_specific_smtp_window_fill_with_connections),
3669 (modest_connection_specific_smtp_window_save_server_accounts),
3670 (update_model_server_names): Do not actually save data until asked,
3671 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3673 (on_selection_changed),
3674 (modest_connection_specific_smtp_window_init): Disable the edit
3675 button when nothing is selected.
3677 * src/modest-account-mgr-helpers.c:
3678 * src/modest-account-mgr-helpers.h:
3679 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3682 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3684 * src/modest-account-mgr-helpers.h:
3685 * src/modest-account-mgr-helpers.c:
3686 (modest_account_mgr_get_unused_account_name),
3687 (modest_account_mgr_get_unused_account_display_name): Added these
3688 utility functions, to avoid code duplication.
3690 * src/maemo/easysetup/modest-easysetup-wizard.c:
3691 (create_page_account_details), (create_account):
3692 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3693 (on_combo_security_changed),
3694 (modest_connection_specific_smtp_edit_window_init),
3695 (modest_connection_specific_smtp_edit_window_save_settings):
3696 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3697 * src/maemo/modest-connection-specific-smtp-window.c:
3698 (modest_connection_specific_smtp_window_finalize),
3699 (modest_connection_specific_smtp_window_fill_with_connections),
3700 (on_button_edit), (modest_connection_specific_smtp_window_init):
3701 * src/maemo/modest-connection-specific-smtp-window.h:
3702 Implementing saving of connection-specific server accounts.
3704 But I need to refactor this so we can save the data for each
3705 possible connection-specific account and only actually create the server accounts
3706 when the easysetup finished, or the OK button is pressed on the account settings
3709 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3712 (on_combo_security_changed):
3713 (modest_connection_specific_smtp_edit_window_init):
3714 Auto-fill the port number as in the account settings.
3716 (modest_connection_specific_smtp_edit_window_set_connection):
3717 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3718 * src/maemo/modest-connection-specific-smtp-window.c:
3719 (fill_with_connections), (on_button_edit),
3720 (modest_connection_specific_smtp_window_init):
3721 Turn the edit window into a dialog to simplify the code, and
3722 set a WM hint as in a GtkDialog, because only a popup can be on top of
3723 another window in Maemo, and popups usually have no WM decoration.
3725 * src/modest-defs.h:
3726 * src/modest-account-mgr-helpers.c:
3727 (modest_account_mgr_set_connection_specific_smtp),
3728 (modest_account_mgr_remove_connection_specific_smtp),
3729 (modest_account_mgr_get_connection_specific_smtp):
3730 * src/modest-account-mgr-helpers.h: Some functions to write the
3731 connection-specific SMTP server information. Not yet used.
3734 * src/widgets/modest-folder-view.c: (text_cell_data):
3735 Fix a warning about an uninitialized variable.
3736 (on_configuration_key_changed): Put an #ifdef around the use
3737 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3739 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3741 * src/maemo/modest-account-settings-dialog.h:
3742 * src/maemo/modest-account-settings-dialog.c:
3743 Added connect_for_modified() utility function to mark the new modified boolean.
3745 (create_page_account_details), (create_page_user_details),
3746 (create_page_incoming), (create_page_outgoing), (on_response),
3747 (modest_account_settings_dialog_init),
3748 (modest_account_settings_dialog_set_account_name):
3749 Only warn about unsaved changes when there are actually unsaved changes.
3751 * src/modest-account-mgr-helpers.c:
3752 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3753 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3754 to get the data from there in future.
3756 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3758 * src/modest-defs.h:
3760 * src/modest-account-mgr-helpers.h:
3761 * src/modest-account-mgr-helpers.c:
3762 Store the security account setting in a single conf key instead of using
3763 the options list, so that the list is left for just the to-be-removed camel hack,
3764 and because gconf_client_set_list() is failing for some reason.
3766 * src/modest-account-mgr.c:
3767 (modest_account_mgr_add_server_account):
3768 * src/maemo/modest-account-settings-dialog.c:
3769 (modest_account_settings_dialog_set_account_name),
3770 (save_configuration): Use the renamed functions.
3773 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3775 * src/widgets/Makefile.am:
3776 * src/widgets/modest-limit-retrieve-combo-box.c:
3777 * src/widgets/modest-limit-retrieve-combo-box.h:
3778 * src/widgets/modest-retrieve-combo-box.c:
3779 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3780 the account settings dialog.
3782 * src/modest-defs.h:
3783 * src/modest-account-mgr-helpers.h:
3784 * src/modest-account-mgr-helpers.c:
3785 (modest_server_account_get_option_secure_auth),
3786 (modest_server_account_set_option_secure_auth):
3787 * src/modest-account-mgr.c:
3788 (modest_account_mgr_add_server_account):
3789 Use the existing AUTH_MECH conf key for the secure-auth setting,
3790 instead of putting it in the list options, because this was actually used already.
3792 * src/maemo/modest-account-settings-dialog.c:
3793 (create_page_account_details),
3794 (modest_account_settings_dialog_set_account_name),
3795 (save_configuration):
3796 * src/maemo/modest-account-settings-dialog.h:
3797 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3798 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3800 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3802 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3803 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3804 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3806 * src/modest-defs.h:
3807 * src/maemo/modest-account-settings-dialog.c:
3808 (create_page_incoming), (on_combo_outgoing_security_changed),
3809 (on_combo_incoming_security_changed), (create_page_outgoing),
3810 (modest_account_settings_dialog_set_account_name),
3811 (save_configuration): Load/Save the port number, and change it when the
3812 security combo changes, to suitable defaults.
3814 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3816 * src/modest-account-mgr.c:
3817 (modest_account_mgr_add_server_account): Set the security and secure-auth
3818 options, and add a comment saying that the other camel-specific options should be
3821 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3823 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3825 * src/modest-tny-account-store.c: (account_list_free),
3826 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3827 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3830 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3832 * src/modest-protocol-info.c:
3833 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3834 is required by our UI spec. Maybe something in our implementation will use this eventually.
3835 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3836 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3837 instead of the previous 0 placeholder.
3839 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3840 secure-auth settings.
3841 * src/modest-account-mgr-helpers.h:
3842 * src/modest-account-mgr-helpers.c:
3843 (modest_server_account_data_get_option_secure_auth),
3844 (modest_server_account_set_option_secure_auth),
3845 (modest_server_account_data_get_option_security),
3846 (modest_server_account_set_option_security): Added this API for getting and setting the security
3847 and secure-auth settings.
3849 * src/maemo/modest-account-settings-dialog.h:
3850 * src/maemo/modest-account-settings-dialog.c:
3851 (modest_account_settings_dialog_finalize), (check_data),
3852 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3853 about changing titles.
3854 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3855 (save_configuration): Save the security and secure-auth settings.
3857 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3858 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3860 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3862 * src/modest-defs.h:
3863 * src/modest-account-mgr.c:
3864 (modest_account_mgr_add_server_account):
3865 Added and used defines for the options key and value pair strings,
3866 that are used so far, though they do not seem to correspond to anything in our
3867 UI specs or ModestProtocol enum.
3869 * src/modest-account-mgr-helpers.h:
3870 * src/modest-account-mgr-helpers.c:
3871 (compare_option_strings_for_name),
3872 (modest_server_account_data_get_option_value),
3873 (modest_server_account_data_get_option_bool),
3874 (modest_account_mgr_get_server_account_option):
3875 Added helper functions for parsing the options GSList.
3877 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3879 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3880 display name is based on the supplied account name.
3881 * src/modest-account-mgr.c:
3882 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3883 with an inefficient, but good-enough, implementation.
3885 * src/maemo/easysetup/modest-easysetup-wizard.c:
3886 (create_page_account_details), (on_before_next), (create_account):
3887 Check for existing display names rather than (non-user-visible) account names, and just
3888 create and set a unique account name at the end.
3890 * src/maemo/modest-account-settings-dialog.c:
3891 (modest_account_settings_dialog_init),
3892 (modest_account_settings_dialog_set_account_name),
3893 (create_page_incoming): Show the display name, instead of the account name.
3894 (on_response): Do some (not all) extra checks, as in the UI spec.
3895 (save_configuration): Save the display name if it was changed.
3897 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3899 * po/en_GB.po: Added needed logical ID and translation.
3900 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3901 (init_view): Made the is-default column clicking work.
3903 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3906 * src/maemo/easysetup/Makefile.am:
3907 * src/maemo/easysetup/modest-easysetup-wizard.c:
3908 (modest_easysetup_wizard_dialog_init):
3909 * src/maemo/easysetup/provider-data-test.keyfile:
3910 * src/maemo/easysetup/provider-data.keyfile:
3911 Moved the provider data file to the new modest-providers-data package and used it from there.
3913 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3915 * src/modest-local-folder-info.c:
3916 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3917 N_() was already used on the static strings, but this just marks it for translation without
3918 using the translation.
3920 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3922 * src/maemo/modest-account-settings-dialog.c:
3923 (create_page_incoming),
3924 (modest_account_settings_dialog_set_account_name):
3925 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3926 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3927 I will do this if nobody else gets there first.
3929 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3931 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3932 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3933 save the security stuff.
3935 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3937 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3938 Set the email address and user fullname, which I now see must be
3941 * src/maemo/modest-account-settings-dialog.h:
3942 * src/maemo/modest-account-settings-dialog.c:
3944 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3945 leave-on-server and authentication.
3946 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3949 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3952 * src/maemo/modest-account-settings-dialog.c:
3953 * src/maemo/modest-account-settings-dialog.h:
3954 Most (but not all) of the widgets are now present as specified by the UI spec.
3955 No changes are yet saved, and some details are not properly shown yet.
3957 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3959 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3961 * src/maemo/Makefile.am:
3962 * src/maemo/modest-account-settings-dialog.c:
3963 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3964 an existing account. Doesn't do much yet.
3966 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3967 Open the accounts settings dialog when Edit is clicked.
3969 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3971 * src/maemo/easysetup/Makefile.am:
3972 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3974 * src/maemo/easysetup/modest-easysetup-wizard.c:
3975 (modest_easysetup_wizard_dialog_init):
3976 Try to get the source directory from the build system,
3977 instead of hard-coding "./" into the source code, when opening our local
3978 copies of the configuration files.
3979 But this still fails when opening the wizard from the Accounts window,
3980 maybe because the working directory seems to change at runtime.
3981 So the wizard will fail the second time unless you copy the files into their
3982 proper locations - see the stdout warnings for the paths.
3984 (create_page_account_details),(on_before_next):
3985 Check for existing non-server accounts instead of server accounts,
3986 so the default account name is useful again, and to prevent trying to
3989 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3990 Show the wizard when New is clicked.
3992 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3993 (init_view): Show the column headers, and show the columns that are
3994 specified in the UI specs. However, something in Maemo's GTK+ prevents
3995 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3996 change the default account. This is despite unsetting the special properties.
3998 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4000 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4001 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4002 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4003 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4004 to make that clearer.
4005 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4007 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4009 * src/maemo/modest-account-view-window.c:
4010 (modest_account_view_window_init),
4011 (modest_account_view_window_new):
4012 Use the same buttons as specified in the
4013 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4014 the existing widgets, which never had a chance of working.
4015 Put the ModestAccountView treeview in a scrolled window.
4016 Do not repeat the initialization in both _init() and _new().
4018 * src/widgets/modest-account-view.c: (update_account_view):
4019 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4020 this widget and window shows no accounts.
4022 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4024 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4026 * src/maemo/easysetup/modest-easysetup-wizard.c:
4027 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4028 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4029 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4032 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4033 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4034 accounts exist yet, as in the UI spec.
4036 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4038 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4040 * src/maemo/Makefile.am:
4041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4042 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4043 New window for editing connection-specific smtp details.
4044 Not fully implemented.
4046 * src/maemo/modest-connection-specific-smtp-window.c:
4047 (modest_connection_specific_smtp_window_finalize) :
4048 unref the tree model.
4049 (on_button_edit): Show the edit window.
4051 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4053 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4056 * src/maemo/Makefile.am:
4057 * src/maemo/modest-connection-specific-smtp-window.c:
4058 * src/maemo/modest-connection-specific-smtp-window.h:
4059 New window for showing the list of connections, for connection-specific
4060 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4061 * src/maemo/easysetup/modest-easysetup-wizard.c:
4062 (create_page_custom_outgoing): Show the new window when the button is clicked.
4064 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4066 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4067 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4068 * src/maemo/modest-msg-edit-window.c:
4069 (modest_msg_edit_window_insert_image):
4070 * src/modest-conf.c: (modest_conf_key_escape):
4071 * src/modest-mail-operation.c:
4072 (modest_mail_operation_send_new_mail):
4073 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4074 (modest_ui_actions_on_new_account):
4075 * src/widgets/modest-attachment-view.c: (update_filename_request):
4076 * src/widgets/modest-mail-header-view.c:
4077 Corrected warnings that were breaking the build, by commenting out unused variables,
4078 and a function, and by including a header.
4080 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4082 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4083 so we can #ifdef around platform-specific code when necessary.
4084 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4085 to allow this to build for the GNOME platform too.
4087 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4089 * src/maemo/easysetup/modest-easysetup-wizard.c:
4090 Added util_increment_name() and used it in create_page_account_details()
4091 to make sure that the default account name is always a new name.
4093 (modest_easysetup_wizard_dialog_init),
4094 (set_default_custom_servernames): Some minor memory management fixes.
4096 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4100 * src/modest-runtime.c: (init_i18n): Restored the translation
4101 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4102 are defined in config.h, and the translations are installed.
4104 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4105 is defined for translation.
4107 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4109 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4111 * src/maemo/easysetup/modest-easysetup-wizard.c:
4112 (modest_easysetup_wizard_dialog_init):
4113 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4114 Use realistic paths (though they should use $prefix generically) to the
4115 mcc_mapping and provider-data.keyfile files which might work when they
4116 are installed by the future version of the operator-wizard package,
4117 and then fallback to paths in our source code, with an explanatory
4120 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4124 * src/maemo/Makefile.am:
4125 * src/maemo/easysetup/: Added files from the previously-exernal
4126 osso-modest-easysetup.
4127 * src/maemo/modest-main-window-ui.h:
4128 * src/modest-ui-actions.c:
4129 * src/modest-ui-actions.h:
4130 Added modest_ui_actions_on_new_account() as a signal handler for the
4131 New Account menu item. It shows the easysetup wizard.
4132 * po/en_GB.po: Added additional needed logical IDs and translations.