1 2007-06-07 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.h:
4 * src/modest-tny-account-store.c:
5 Added modest_tny_account_store_get_local_folders_account().
7 * src/modest-tny-folder.h:
8 * src/modest-tny-folder.c:
9 (modest_tny_folder_get_account):
10 Added this replacement for tny_folder_get_account() which returns
11 the local-folders account for TnyMergeFolders, to avoid the
12 warning about the unimplemented get_account_func() vfunc().
14 (modest_tny_folder_get_rules),
15 * src/modest-ui-actions.c:
16 (modest_ui_actions_on_folder_selection_changed):
17 * src/modest-mail-operation.c:
18 (modest_mail_operation_remove_folder),
19 (modest_mail_operation_xfer_folder),
20 (modest_mail_operation_rename_folder),
21 (modest_mail_operation_get_msg),
22 (modest_mail_operation_get_msgs_full),
23 (modest_mail_operation_remove_msg),
24 (modest_mail_operation_xfer_msgs),
25 (modest_mail_operation_refresh_folder):
26 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
28 2007-06-07 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
31 (modest_server_account_set_security):
32 * src/modest-defs.h: Add comments explaining that our
33 UI spec means TLS when it says Normal, so these do not look like errors.
35 * src/modest-tny-account.c:
36 (modest_tny_account_new_from_server_account): Use the new tinymail
37 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
38 for TLS. This should fix projects.maemo.org bug NB#58460.
40 2007-06-06 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/easysetup/modest-easysetup-wizard.c:
43 (create_account): Correct the position of the gconf sanity check warning.
44 (on_button_edit_advanced_settings): Show the dialog immediately, instead
45 of using the g_idle_add() hack, because this does not seem to be necessary
46 on osso 1.1. It might even work on Maemo Bora if the problems were actually
47 caused by something other than maemo's gconf.
48 This fixes projects.maemo.org bug #59022.
50 2007-06-06 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-account-mgr-helpers.c:
53 (modest_account_mgr_get_default_account): Do not check that the account
54 exists if there is no default account (NULL), to fix a runtime warning.
56 2007-06-06 Murray Cumming <murrayc@murrayc.com>
58 * src/widgets/modest-folder-view.c: (update_model):
59 Do not unref the treemodel before we have finished with it.
60 This prevents a valgrind warning and an occasional crash at startup.
62 2007-06-06 Marcus Bauer <marcusb@openismus.com>
64 * libmodest-dbus-client/libmodest-dbus-client.h:
65 added libmodest_dbus_client_compose_mail()
66 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
68 added functions needed for SendAsMail() functionality
69 * src/maemo/modest-msg-edit-window.c:
70 (modest_msg_edit_window_attach_file_noninteractive):
71 non interactively attaching files to message edit window
72 * src/widgets/modest-msg-edit-window.h:
73 * tests/dbus_api/Makefile.am:
74 added test_compose_mail.c
75 * tests/dbus_api/test_compose_mail.c: (main):
77 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
79 * src/modest-account-view.c:
80 Fixed bug projects.maemo.org bug NB#59307
82 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
84 * src/maemo/easysetup/modest-easysetup-wizard.c:
85 (get_serverport_incoming), (on_before_next), (create_account):
86 * src/maemo/modest-account-settings-dialog.c:
87 (modest_account_settings_dialog_set_account_name):
88 * src/maemo/modest-maemo-utils.c:
89 (on_camel_account_get_supported_secure_authentication_status),
90 (on_camel_account_get_supported_secure_authentication),
91 (on_secure_auth_cancel),
92 (modest_maemo_utils_get_supported_secure_authentication_methods):
94 Implemented security authentication for settings and easysetup.
96 2007-06-05 Murray Cumming <murrayc@murrayc.com>
98 * src/maemo/modest-main-window.c: (create_details_widget):
99 Show the total size for memory card accounts too, instead of showing
100 the name again. Fixes bug projects.maemo.org bug NB#59307.
102 2007-06-05 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-tny-simple-folder-store.c:
106 * src/modest-tny-simple-folder-store.h: Removed.
108 * src/modest-tny-local-folders-account.h
109 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
110 for the local-folders maildir, with an extra TnyMergedFolder containing
111 the folders of the per-account outbox store accounts.
112 * src/modest-tny-account-store.c: (get_server_accounts):
113 Add the outboxes to the special local folders account after creating it.
115 * src/modest-tny-account.c:
116 (modest_tny_account_new_for_local_folders): Create the derived
117 account when creating the main local-folders account.
119 * src/maemo/modest-main-window.c: (create_details_widget),
120 (modest_main_window_set_contents_style):
121 Adapted to the use of the derived account instead of the folder store.
123 * src/modest-ui-actions.c:
124 (modest_ui_actions_on_folder_selection_changed):
125 * src/modest-ui-dimming-rules.c:
126 (modest_ui_dimming_rules_on_new_folder):
127 * src/widgets/modest-folder-view.c: (text_cell_data),
128 (icon_cell_data), (filter_row), (update_model),
129 (get_cmp_rows_type_pos):
132 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
133 Do not get the priv struct, because no priv struct has been set,
134 to avoid a runtime warning.
136 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
137 #ifelse with #else, to fix a warning, to fix the build.
140 2007-06-05 Christian Kellner <ckellner@openismus.com>
142 * libmodest-dbus-client/libmodest-dbus-client.c:
143 Fix small typo in doc (why do you always see them
144 AFTER committing stuff?)
147 2007-06-05 Christian Kellner <ckellner@openismus.com>
149 * libmodest-dbus-client/libmodest-dbus-client.c:
150 (libmodest_dbus_client_search):
151 Initialize hit list with NULL. Also set folder list
152 to "" if NULL was supplied.
155 2007-06-03 Christian Kellner <ckellner@openismus.com>
157 * libmodest-dbus-client/libmodest-dbus-client.c:
158 (modest_search_hit_list_free):
159 Make it save to call it with NULL.
161 * src/dbus_api/modest-dbus-callbacks.c:
162 * src/modest-search.c:
163 Return full ModestSearchHits as the search result list not TnyHeader
164 since can't be around withouth the correspoding TnyFolder.
166 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
168 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
169 Added currently commented code to check for secure auth
171 * src/maemo/modest-account-settings-dialog.c: (on_response),
172 (save_configuration), (show_ok):
173 Fixed projects.maemo.org bugs NB #59248 and #59251
175 * src/maemo/modest-maemo-utils.c:
176 (on_camel_account_get_supported_secure_authentication_status),
177 (on_camel_account_get_supported_secure_authentication),
178 (modest_maemo_utils_get_supported_secure_authentication_methods):
179 * src/maemo/modest-maemo-utils.h:
180 Moved get_supported_secure_authentication() method here to be able
181 to use it from easysetup wizard.
183 * src/modest-pair.c: (on_pair_compare_as_string):
184 Should compare string with first part of pair and not
185 strcmp pairs which will crash.
187 * src/modest-protocol-info.c:
188 (modest_protocol_info_protocol_is_store):
189 * src/modest-protocol-info.h:
190 Added modest_protocol_info_get_auth_protocol_name()
192 2007-06-03 Armin Burgmeier <armin@openismus.com>
194 * src/modest-mail-operation.c:
195 (modest_mail_operation_get_msgs_full): Set priv->account also when
196 only retrieving a single message. This avoids a crash when canceling
199 (modest_mail_operation_notify_end): Do not explicitely remove the
200 operation from the queue but only emit the progress_changed signal.
201 The queue itself listens to that signal to remove the operation when
202 it is finished. This reduces coupling and removes a potential deadlock
203 when modest_mail_operation_notify_end() is called from the queue
204 itself. If that is a problem performance-wise, I would suggest to
205 implement a status-changed signal or something.
207 * src/modest-mail-operation-queue.c: Make sure to never call a
208 function from another file while the queue is locked. This (hopefully)
209 fixes another deadlock when exiting the application while retrieving
212 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
214 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
215 Fixed build if libogs is not available
217 2007-06-03 Christian Kellner <ckellner@openismus.com>
219 * libmodest-dbus-client/libmodest-dbus-client.h:
220 * libmodest-dbus-client/libmodest-dbus-client.c:
221 (libmodest_dbus_client_delete_message):
222 Implement deletion of messages (Client side).
224 (modest_search_hit_free),
225 (modest_search_hit_list_free):
226 Utility functions to free the result hits.
228 * src/dbus_api/modest-dbus-api.h:
229 * src/dbus_api/modest-dbus-callbacks.c:
231 (modest_dbus_req_handler):
232 Implement deletion of messages (Server side).
234 * tests/dbus_api/test_search.c: (main):
237 * tests/dbus_api/Makefile.am:
238 * tests/dbus_api/test_delete_message:
239 Add little test for the message deletion logic
241 2007-06-03 Armin Burgmeier <armin@openismus.com>
243 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
244 when the operation queue was not empty. projects.maemo.org bug
247 2007-06-03 Armin Burgmeier <armin@openismus.com>
249 * src/widgets/modest-account-view.c
250 (on_account_default_toggled): Toggle default account column
251 explicitely instead of waiting for gconf notification (which is
252 currently ignored). This should fix projects.maemo.org bug NB#56910
253 for now. It should probably be removed when gconf notifications are
256 2007-06-03 Christian Kellner <ckellner@openismus.com>
258 * libmodest-dbus-client/libmodest-dbus-client.c:
259 Removed debugging spew.
261 * src/dbus_api/modest-dbus-callbacks.c:
262 Added debugging info.
264 * src/modest-search.c:
265 (modest_search_all_accounts):
266 Use tny_account_store_get_accounts () on the account store
267 to get all accounts which is the way to get all accounts.
269 * tests/dbus_api/test_search.c: (main):
270 Make it possible to supply the search term on the command line.
272 2007-06-03 Christian Kellner <ckellner@openismus.com>
274 * libmodest-dbus-client/libmodest-dbus-client.c:
275 * libmodest-dbus-client/libmodest-dbus-client.h:
276 Implement searching for mesages over raw dbus. (Client side)
278 * src/dbus_api/Makefile.am:
279 * src/dbus_api/modest-dbus-api.h:
280 * src/dbus_api/modest-dbus-callbacks.c:
281 * src/dbus_api/modest-dbus-callbacks.h:
282 Search framework (Server side). Also implement on_idle_open_message().
284 * src/maemo/modest-platform.c: (modest_platform_init):
285 Prepare for raw dbus/osso rpc interaction.
287 * src/modest-search.h:
288 Changed minsize from unspecific guint to guint32.
290 * src/modest-search.c:
292 Added strange hack which magically made tnymail work.
294 (modest_search_folder),
295 (modest_search_account),
296 (modest_search_all_accounts):
297 Implement helper functions to search all accounts, specific account
300 * tests/dbus_api/Makefile.am:
301 * tests/dbus_api/test_open_message.c:
302 Read url to open from commandline.
304 * tests/dbus_api/test_search.c:
305 Implement small test for dbus search stuff
307 2007-06-02 Armin Burgmeier <armin@openismus.com>
309 * src/maemo/modest-account-settings-dialog.c: Changed window title to
310 include account type and account title. This fixes projects.maemo.org
313 * src/maemo/modest-account-view-window.c: Set a title for the window.
315 2007-06-02 Armin Burgmeier <armin@openismus.com>
317 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
318 incoming and outgoing server name based on email address and server
319 types as long as the names have not been edited manually. This fixes
320 projects.maemo.org bug NB#58671.
322 2007-06-02 Armin Burgmeier <armin@openismus.com>
324 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
325 server type cannot be changed in future to the incoming details page
326 when creating an account. This fixes projects.maemo.org bug NB#59029.
328 2007-06-02 Armin Burgmeier <armin@openismus.com>
330 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
331 and assigned max width chars so that they wrap instead of being
332 truncated. Fixes projects.maemo.org bug NB#56126.
334 2007-06-02 Armin Burgmeier <armin@openismus.com>
336 * src/maemo/modest-connection-specific-smtp-window.c: Add an
337 introductory note to the connection specific smtp servers dialog, as
338 section 8.12 of the email UI specification requires. This fixes
339 projects.maemo.org bug NB#59212.
341 2007-06-01 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
344 Check for running mail operations, and offer to cancel them, as per the UI
345 spec. This fixes projects.maemo.org bug NB#59041 .
346 However, I suspect that tinymail may still use the network connection
347 in ways that we cannot detect or cancel. But it should at least adapt to
350 2007-06-01 Murray Cumming <murrayc@murrayc.com>
352 * src/modest-tny-account-store.c: (recreate_all_accounts),
353 (get_cached_accounts), (get_server_accounts): Do more sensible
354 ref-counting of the temporarily-cached outbox accounts list. This seems
355 to fix a crash when entering the password when the password was wrong.
357 2007-06-01 Murray Cumming <murrayc@murrayc.com>
359 * src/gnome/modest-main-window.c: (connect_signals):
360 * src/modest-tny-account-store.c: (get_password),
361 (modest_tny_account_store_alert): Added comments and clues and
362 commented-out code about how we currently fail to deal with connection
363 errors and wrong passwords, and how we should.
365 2007-06-01 Murray Cumming <murrayc@murrayc.com>
367 * src/widgets/modest-retrieve-combo-box.c:
368 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
369 This fixes projects.maemo.org bug NB#58472 .
371 2007-06-01 Murray Cumming <murrayc@murrayc.com>
373 * src/maemo/easysetup/modest-easysetup-wizard.c:
374 (create_page_complete_easysetup):
375 (create_page_complete_custom): Correct the last commit,
376 putting the correct sentences in the correct pages.
378 2007-06-01 Murray Cumming <murrayc@murrayc.com>
380 * src/maemo/easysetup/modest-easysetup-wizard.c:
381 (create_page_complete_custom): Show the second sentence of text
382 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
385 2007-06-01 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
388 Set the leave-on-server conf key by default. This fixes
389 projects.maemo.org bug NB#59258 .
391 2007-06-01 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/modest-account-view-window.c:
394 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
395 logical ID for the confirmation messages. Fixed projects.maemo.org bug
398 2007-06-01 Murray Cumming <murrayc@murrayc.com>
400 * src/maemo/easysetup/modest-easysetup-wizard.c:
401 (create_caption_new_with_asterisk):
402 * src/maemo/modest-account-settings-dialog.c:
403 (create_caption_new_with_asterisk):
404 Uncomment the code to add the asterisk, because they are no longer in the
405 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
406 (update_incoming_server_title): Add an asterisk here too.
408 2007-06-01 Murray Cumming <murrayc@murrayc.com>
410 * src/maemo/modest-maemo-global-settings-dialog.c:
411 (current_connection): Check that we are even connected before trying to
412 get the current connection name, to prevent a warning.
414 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
415 Change the comments because tny_maemo_conic_device_connect() is now meant to
417 * src/modest-mail-operation.c:
418 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
419 make sure we have a connection and fail if we can't connect.
421 2007-05-31 Murray Cumming <murrayc@murrayc.com>
423 * src/maemo/modest-main-window.c:
424 (on_account_store_connecting_finished): Do not try to get the
425 connection ID if we are not really connected. I am surprised that
426 this signal handler is called when we are not connected.
428 2007-05-31 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-error.h:
431 * src/modest-ui-actions.c:
432 (modest_ui_actions_get_msgs_full_error_handler):
433 Renamed an enum, added comments, added an enum
434 for retrieve-limit errors.
436 * src/modest-mail-operation.c: (foreach_add_item),
437 (internal_folder_observer_update), (update_account_thread),
438 (modest_mail_operation_get_msgs_full):
439 (modest_mail_operation_update_account),
440 Added comments about how this works, and some code that should
441 (but does not) check the retrieve-limit. See the TODO comment.
443 2007-05-31 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
446 Initialize help_id to fix the build. Warnings are good.
448 2007-05-31 Murray Cumming <murrayc@murrayc.com>
450 * src/widgets/modest-hbox-cell-renderer.c:
451 (modest_hbox_cell_renderer_append):
452 * src/widgets/modest-vbox-cell-renderer.c:
453 (modest_vbox_cell_renderer_append):
454 Fix the last commit by doing an extra ref.
456 2007-05-31 Murray Cumming <murrayc@murrayc.com>
458 * src/widgets/modest-hbox-cell-renderer.c:
459 (modest_hbox_cell_renderer_append):
460 * src/widgets/modest-vbox-cell-renderer.c:
461 (modest_vbox_cell_renderer_append):
462 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
463 to fix the build with Maemo Bora.
464 However, there seems to be a remaining crash, probably due to reference
467 2007-05-30 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-tny-account.c:
470 (modest_tny_account_new_for_local_folders):
471 Use hildon_file_system_info_async_new() to get a better name for
472 the memory card account, setting it as the account name.
473 The timing seems to work, but this is probably
474 not the best place to do this. See the TODO comment.
475 * src/maemo/modest-main-window.c: (create_details_widget):
476 * src/widgets/modest-folder-view.c: (text_cell_data):
477 Use the tny account name instead of hardcoding a name.
479 2007-05-30 Christian Kellner <ckellner@openismus.com>
481 * src/modest-search.c: (modest_search):
482 Correctly set part_search_func even if we have already parsed
483 the query and thus a valid OgsTextSearcher object.
485 2007-05-30 Christian Kellner <ckellner@openismus.com>
488 Search and check for libogs.
491 Incooparte the ogs build env.
493 * src/modest-mime-part-search-stream.c:
494 * src/modest-mime-part-search-stream.h:
495 Removed since we do the real searching now in modest-search.c.
497 * src/modest-search.c:
498 * src/modest-search.h:
499 Implement support for ogs. We use that if available and requested
500 and fall back to modest_text_utils_utf8_strcmp (). The search logic
501 should now handle the corner case when the search term is spread
502 across multiple reads.
503 Also the logic in modest_search () was corrected to search all
504 requested fields until one is found.
506 2007-05-30 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
511 * src/modest-init.c: Made modest_init_local_folders() take a
512 path and be public so we can iniitialize maildir folders on
515 * src/modest-local-folder-info.h:
516 * src/modest-local-folder-info.c:
517 (modest_local_folder_info_get_maildir_path): Add a path parameter.
519 * src/modest-tny-account.c:
520 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
521 still means the standard local-folders path on the local volume.
523 * src/modest-tny-account-store.c:
524 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
525 signal so we can detect mount/unmount of the MMC1 card, and do an update of
526 all accounts when that happens.
527 (get_server_accounts): If the MMC1 card is mounted, create a store account for
528 this too, so it shows up in the treeview.
530 2007-05-28 Murray Cumming <murrayc@murrayc.com>
532 * src/maemo/modest-maemo-global-settings-dialog.c:
533 (current_connection):
534 * src/widgets/modest-global-settings-dialog.c:
535 (current_connection_default):
536 Use the enum values instead of 0, 1 and -1,
537 to make the code clearer.
539 * src/modest-account-mgr-helpers.c:
540 (modest_account_mgr_get_connection_specific_smtp): Make this code
543 * src/modest-runtime.h:
544 * src/modest-runtime.c:
545 Added modest_runtime_remove_all_send_queues().
546 * src/maemo/modest-main-window.c:
547 (on_account_store_connecting_finished): Recreate the send queues,
548 using the appropriate transport accounts for this new connection.
549 Some futher adapting might be needed if the old send queues are not
550 automatically stopped at this point.
552 * src/modest-tny-account-store.c: (get_server_accounts):
553 Create the connection-specific transport accounts, so that they can
554 be found later by their ID.
556 * src/modest-tny-account.h:
557 * src/modest-tny-account.c:
558 Added modest_tny_account_new_from_server_account_name().
559 modest_tny_account_new_from_server_account(): Do not create the
560 send queues here, because they will be
561 recreated anyway when the connection changes for the first time.
563 2007-05-28 Murray Cumming <murrayc@murrayc.com>
565 * src/modest-local-folder-info.h:
566 * src/modest-local-folder-info.c:
567 (modest_per_account_local_outbox_folder_info_get_maildir_path),
568 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
569 tbox_folder): Take a modest account name instead of a server TnyAccount,
570 so we can have per-modest-account rather than per-transport-account
572 We must make sure that we change or recreate the exisitng send queues
573 when the connection changes for connection-specific transport accounts.
575 * src/modest-tny-account-store.c:
576 (create_per_account_local_outbox_folders): Create outboxed per modest
577 account, not per transport account.
579 * src/modest-tny-account.h:
580 * src/modest-tny-account.c:
581 (modest_tny_account_get_special_folder): For outboxes, get the
582 parent modest account name. The account is ignored for other folders.
583 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
584 modest account name rather than a server TnyAccount.
586 2007-05-25 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account.c:
589 (modest_tny_account_new_from_server_account):
590 Call modest_runtime_get_send_queue() immediately after creating transport
591 accounts, so that they start trying to send email from the outbox as soon
592 as possible at startup. This is probably what we want.
594 * src/modest-mail-operation.c: (update_account_thread):
595 * src/modest-runtime.c: (modest_runtime_get_send_queue):
596 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
597 * src/modest-tny-send-queue.h:
598 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
599 (modest_ui_actions_on_send):
600 Added comments about how sending works, though it needs some more work.
602 2007-05-25 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-tny-account.c:
605 (modest_tny_account_get_special_folder): Add TODO because this fails when
607 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
608 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
609 Do not try to show this window when there is no active account. The UI
610 specs does not tell us what to do in this case.
612 2007-05-24 Murray Cumming <murrayc@murrayc.com>
616 * src/maemo/Makefile.am:
617 * src/widgets/Makefile.am: Some dist fixes.
619 2007-05-24 Murray Cumming <murrayc@murrayc.com>
621 * src/maemo/modest-connection-specific-smtp-window.c:
622 (on_button_edit): Make the code clearer, to prevent a double free.
624 2007-05-24 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-account-settings-dialog.c:
627 (modest_account_settings_dialog_set_account_name),
628 Check the connection-specific smtp servers checkbox if there are any.
630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
631 (modest_connection_specific_smtp_edit_window_init):
632 Start with a suitable port number.
634 * src/modest-account-mgr-helpers.h:
635 * src/modest-account-mgr-helpers.c: Added
636 modest_account_mgr_get_has_connection_specific_smtp().
638 (modest_account_mgr_set_connection_specific_smtp),
639 (modest_account_mgr_remove_connection_specific_smtp),
640 (modest_account_mgr_get_has_connection_specific_smtp),
641 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
642 connection-specific smtp server accounts in the account, rather than
643 the server account conf dir.
645 This fixes bug projects.maemo.org bug NB#58263 .
647 * src/modest-tny-account-store.c:
648 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
649 if there are no server accounts yet, to prevent an infinite loop when there
650 are no accounts. Document that one must be called before the other.
652 2007-05-24 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-account-mgr-helpers.c:
655 (modest_account_mgr_get_default_account): Make sure that at least
656 one account is always the default, if there are any enabled accounts.
657 This is just a sanity check that shouldn't be necessary.
659 * src/modest-account-mgr-priv.c:
660 (_modest_account_mgr_account_from_key): Unescape the conf key to
661 get the real account name. For instance, this is an issue if a space
662 was in the account name, which can happen because the account name
663 is generated from the display name.
664 (_modest_account_mgr_get_account_keyname): Always escape the
666 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
667 Unescape the conf keys to get the real account names.
669 For instance, previously the is-default radio button in the accounts
670 list was not checked for any accounts at first. This fixes that,
671 and might fix several similar bugs.
673 2007-05-23 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
676 Removed some debug printfs.
678 2007-05-23 Murray Cumming <murrayc@murrayc.com>
680 Modest on-disk outbox directories are now here, for instance:
681 $HOME/.modest/outboxes/<account-id-1>/outbox
682 $HOME/.modest/outboxes/<account-id-2>/outbox
684 $HOME/.modest/local-folders/outbox
685 so we can have a separate outbox for each account.
686 But they are shown as one outbox in the GtkTreeView, by using a
687 TnyMergeFolder in a ModestTnySimpleFolderStore.
690 * src/modest-tny-simple-folder-store.c:
691 * src/modest-tny-simple-folder-store.h:
692 Added ModestTnySimpleFolderStore, used to contain folders from
693 other folder stores, such as other accounts.
695 * src/modest-tny-outbox-account.h:
696 * src/modest-tny-outbox-account.c:
697 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
698 used for the per-account local outbox folders.
700 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
701 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
702 only use this (internally) now for the non-outbox local folders.
705 * src/modest-init.c: Added modest_init_one_local_folder(), for
706 setting up the directory structure for each local folder.
708 * src/modest-local-folder-info.c:
709 (modest_per_account_local_outbox_folder_info_get_maildir_path),
710 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
712 * src/modest-local-folder-info.h:
713 * src/modest-tny-account-store.c: (on_account_removed),
714 (on_account_changed), (create_per_account_local_outbox_folders),
715 (get_server_accounts), (modest_tny_account_store_get_accounts),
716 (modest_tny_account_store_get_tny_account_by_account),
717 (modest_tny_folder_store_is_virtual_local_folders):
719 * src/modest-tny-account.h:
720 * src/modest-tny-account.c:
721 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
722 to create an on-disk per-account local outbox folder for each
724 (create_per_account_local_outbox_folders): Create a local outbox folder
725 for each transport account.
726 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
727 for all local folders.
729 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
730 instead of using g_object_get/set() directly. It is clearer.
732 (modest_tny_folder_store_get_message_count),
733 (modest_tny_folder_store_get_local_size
734 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
735 because we now use these with non-acount folder stores.
737 (modest_tny_account_get_special_folder),
738 (modest_tny_account_new_from_server_account),
739 (modest_tny_account_new_from_account):
740 (recurse_folders): Adjust to the new outbox system.
742 * src/modest-tny-folder.h:
743 * src/modest-tny-folder.c:
744 (modest_tny_folder_is_local_folder),
745 (modest_tny_folder_get_local_folder_type),
746 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
748 * src/widgets/modest-main-window.h:
749 * src/maemo/modest-main-window.c: (create_details_widget),
750 (modest_main_window_set_contents_style): Show details for any folder store,
753 (modest_tny_folder_get_rules):
754 Remove the const. C does not support constness enough for this.
756 * src/modest-ui-actions.c:
757 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
758 make all outboxes appear as one, in the usual local-folders tree node.
760 (set_active_account_from_tny_account),
761 (modest_ui_actions_on_folder_selection_changed):
762 * src/widgets/modest-folder-view.c: (text_cell_data),
763 (icon_cell_data), (filter_row),
764 (add_account_folders_to_merged_folder),
765 (add_account_folders_to_simple_folder_store), (),
766 (get_cmp_rows_type_pos), (cmp_rows),
767 (modest_folder_view_set_account_id_of_visible_server_account):
768 Adjust to the new outbox system, using generic folder stores and folders
771 2007-05-23 Christian Kellner <ckellner@openismus.com>
773 * src/modest-mail-operation.c:
774 (modest_mail_operation_update_account):
775 Use info->max_size instead of unintialized local var [small
776 build fix]. (Added TODO to review that change since I don't
779 2007-05-23 Marcus Bauer <marcusb@openismus.com>
781 * libmodest-dbus-client/libmodest-dbus-client.c:
782 (libmodest_dbus_client_compose_mail): function added
783 * src/dbus_api/modest-dbus-api.h:
784 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
785 (on_compose_mail): Implementation of the SendAsMail functionality
787 2007-05-22 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-account-mgr.c:
790 (modest_account_mgr_add_server_account): Set the secure-connection
791 conf key for transport accounts as well as store accounts. I don't know
792 why the if was there. For instance, this makes sure that we use SSL
793 for the gmail preset from the easysetup wizard.
795 2007-05-22 Murray Cumming <murrayc@murrayc.com>
797 * src/gnome/modest-main-window.c:
798 (on_account_store_connecting_finished), (connect_signals):
799 * src/maemo/modest-main-window.c:
800 (on_account_store_connecting_finished), (connect_signals),
801 (modest_main_window_new):
802 Handle TnyAccountStore::connecting-finished instead of
803 TnyDevice::connection-changed, because we cannot actually perform
804 operations on accounts until TnyAccountStore has itself responded to
805 the TnyDevice::connection-changed signal. This prevents a GError from
807 Do not try to update at startup, because we (at least on scratchbox)
808 already do an update at startup when the device goes online.
809 This prevents a GError from tinymail.
810 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
811 Added TODO about stopping simultaneous operations.
813 2007-05-21 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
816 * src/modest-mail-operation-queue.c:
817 (modest_mail_operation_queue_remove):
818 * src/modest-tny-account-store.c: When GErrors happen, give more clues
819 about where they happened.
821 2007-05-21 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-ui-actions.c:
824 (modest_ui_actions_on_password_requested): Make sure that the remember
825 output parameter is always TRUE.
827 2007-05-21 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
830 Show a OK/Cancel dialog if the error is a question, though we still do not
831 know anything more about what we are asking the user.
832 * src/widgets/modest-folder-view.c: (on_drag_data_received):
833 Fix an uninitialized variable (helper). This is a logic error, however.
835 2007-05-21 Christian Kellner <ckellner@openismus.com>
837 * src/modest-search.h:
838 Correct bit shifting in the ModestSearchFlags enum.
840 2007-05-21 Murray Cumming <murrayc@murrayc.com>
842 * src/modest-tny-account.c:
843 (modest_tny_account_new_from_server_account): Do not use the lsub and
844 check-all hard-coded IMAP options when using POP.
846 2007-05-21 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-tny-account.c:
849 (modest_tny_account_new_from_server_account):
850 Use NULL for the secure-auth method for POP when Password auth has been
851 specified by the user, as we already do for IMAP. "auth=Login" causes
852 an error from camel or the server.
854 2007-05-17 Murray Cumming <murrayc@murrayc.com>
856 * src/maemo/modest-account-settings-dialog.c:
857 (create_page_account_details),
858 (modest_account_settings_dialog_set_account_name):
859 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
860 for the leave-on-server checkbox, rathr than just the checkbox, when
861 the protocol is not POP.
863 2007-05-17 Murray Cumming <murrayc@murrayc.com>
865 * src/widgets/modest-account-view.c:
866 * src/widgets/modest-account-view.h:
867 Added modest_account_view_select_account() which will be useful later
868 to asynchronously re-select the edited account.
870 2007-05-17 Murray Cumming <murrayc@murrayc.com>
872 * src/maemo/modest-account-settings-dialog.c:
873 (modest_account_settings_dialog_set_account_name):
874 Automatically choose the port numbers based on the secure authentication
875 methods, if they have not been chosen before.
876 This fixes projects.maemo.org bug NB#56273 .
878 2007-05-17 Murray Cumming <murrayc@murrayc.com>
880 * src/maemo/modest-main-window-ui.h:
881 * src/modest-ui-actions.c:
882 * src/modest-ui-actions.h:
883 Connect the Tools/SMTP Servers menu item to
884 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
885 SMTP servers dialog, as in the UI specification and saves changes when it
886 is closed. This fixed projects.maemo.org bug NB#56305 .
888 2007-05-17 Murray Cumming <murrayc@murrayc.com>
890 * src/maemo/modest-connection-specific-smtp-window.c:
891 (modest_connection_specific_smtp_window_init):
892 Use gtk_window_set_default_size() to make this window big enough, so
893 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
895 2007-05-17 Murray Cumming <murrayc@murrayc.com>
897 * src/maemo/modest-connection-specific-smtp-edit-window.h:
898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
899 (modest_connection_specific_smtp_edit_window_init),
900 Do not try to connect to a combobox signal before the combobox exists.
901 This fixes the cras in projects.maemo.org bug NB#56288 .
902 (modest_connection_specific_smtp_edit_window_get_settings):
903 Remove the server_account_name parameter which was being checked for NULL
904 though it was not used.
906 * src/maemo/modest-connection-specific-smtp-window.c:
907 (modest_connection_specific_smtp_window_fill_with_connections),
908 (on_button_edit), (modest_connection_specific_smtp_window_init):
909 Correct the number of treemodel columns to prevent a warning.
910 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
911 libconic does not work.
913 2007-05-16 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-tny-account.c:
916 (modest_tny_account_new_from_server_account):
917 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
918 SMTP when "None" was chosen by the user. However, with my SMTP server that
919 does not support ANONYMOUS, the emails do not leave the Outbox and I see
922 2007-05-16 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
925 to explain the memory management issue with the ID in the ModestPair.
927 * src/gnome/modest-account-assistant.c: (add_receiving_page),
928 (add_sending_page), (modest_account_assistant_finalize):
929 * src/gnome/modest-gnome-global-settings-dialog.c:
930 (create_updating_page), (create_composing_page):
931 * src/gnome/modest-msg-edit-window.c: (get_transports),
932 (init_window), (modest_msg_edit_window_finalize),
933 (modest_msg_edit_window_get_msg_data):
934 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
935 * src/gnome/modest-transport-widget.c:
936 (modest_transport_widget_finalize), (smtp_configuration):
937 * src/maemo/modest-maemo-global-settings-dialog.c:
938 (create_updating_page), (create_composing_page):
939 * src/maemo/modest-msg-edit-window.c: (get_transports),
940 (init_window), (modest_msg_edit_window_finalize),
941 (modest_msg_edit_window_get_msg_data),
942 (modest_msg_edit_window_free_msg_data):
943 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
944 (modest_store_widget_finalize):
945 * src/maemo/modest-transport-widget.c:
946 (modest_transport_widget_finalize), (smtp_configuration):
947 * src/modest-main.c: (send_mail):
948 * src/widgets/modest-combo-box.h:
949 * src/widgets/modest-global-settings-dialog-priv.h:
950 * src/widgets/modest-global-settings-dialog.c:
951 (modest_global_settings_dialog_finalize):
952 * src/widgets/modest-msg-edit-window.h:
953 Whenever using modest_combo_box_new(), keep the ModestPairList alive
954 as long as the combo box, to prevent use of freed memory for the ID.
956 2007-05-15 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
959 get_accounts(), to make this clearer. Do not check for the enabled gconf
960 key, because we do not use this for server accounts (at least, not yet).
961 This allows us to send email again.
963 2007-05-15 Murray Cumming <murrayc@murrayc.com>
965 * src/maemo/modest-platform.c:
966 (on_modest_conf_update_interval_changed), (modest_platform_init):
967 Only respond to this particular key change. All these strcmp()s cannot be
970 2007-05-15 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/modest-maemo-global-settings-dialog.c:
973 (current_connection): Prevent a crash in scratchbox when
974 ny_maemo_conic_device_get_current_iap_id() returns NULL.
975 * src/maemo/modest-platform.c:
976 (on_modest_conf_update_interval_changed), (modest_platform_init):
977 Get the update interval from gconf and reset it when the gconf key changes.
979 2007-05-15 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-protocol-info.c:
982 * src/modest-protocol-info.h: Adde enum-specific get functions,
983 instead of using a ModestProtocolType enum parameter.
985 * src/gnome/modest-account-assistant.c:
986 * src/gnome/modest-store-widget.c:
987 * src/gnome/modest-store-widget.h:
988 * src/gnome/modest-transport-widget.c:
989 * src/gnome/modest-transport-widget.h:
990 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
991 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
992 * src/maemo/easysetup/modest-easysetup-wizard.c:
993 * src/maemo/modest-account-settings-dialog.c:
994 * src/maemo/modest-account-settings-dialog.h:
995 * src/maemo/modest-store-widget.c:
996 * src/maemo/modest-store-widget.h:
997 * src/maemo/modest-transport-widget.c:
998 * src/maemo/modest-transport-widget.h:
999 * src/modest-account-mgr-helpers.c:
1000 * src/modest-account-mgr-helpers.h:
1001 * src/modest-account-mgr.c:
1002 * src/modest-account-mgr.h:
1003 * src/modest-tny-account.c:
1004 * src/modest-tny-folder.c:
1005 * src/widgets/modest-account-view.c:
1006 * src/widgets/modest-retrieve-combo-box.c:
1007 * src/widgets/modest-retrieve-combo-box.h:
1008 * src/widgets/modest-secureauth-combo-box.c:
1009 * src/widgets/modest-serversecurity-combo-box.c:
1010 * src/widgets/modest-serversecurity-combo-box.h:
1011 * tests/check_account-mgr.c:
1012 Use the specific functions, and use the re-renamed enum values for GNOME too.
1014 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-pair.h:
1017 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1018 so we can get the second based on the first.
1020 * src/maemo/modest-account-settings-dialog.h:
1021 * src/maemo/modest-account-settings-dialog.c:
1022 Added get_supported_secure_authentication_methods(), though it is mostly
1023 commented-out for now until the necessary API is committed to tinymail.
1024 (modest_account_settings_dialog_set_account_name),
1025 (save_configuration): Request the supported authentication methods from the
1026 server, so we can choose a working method.
1028 * src/modest-tny-account-store.h:
1029 * src/modest-tny-account-store.c:
1030 (modest_tny_account_store_get_session): Rename from
1031 tny_account_store_get_session().
1033 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-protocol-info.h: Split the ModestProtocol enum
1036 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1037 There was no need to have these unrelated values in one enum.
1039 * src/: many files: Adapted to changed enum. This makes the code a bit
1040 clearer, and the compiler could catch some errors.
1042 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1045 Show the detailed internal camel error message when an error happens
1046 during the configuration, so that our testers can give us more clues.
1047 For instance, in projects.maemo.org bug NB#56910 .
1049 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-tny-account.c:
1052 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1053 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1055 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (modest_account_settings_dialog_set_account_name),
1060 (save_configuration): For the incoming secure authentication checkbox,
1061 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1062 the UI specification. PLAIN does not seem to be supported for most IMAP
1063 servers anyway, and I am not sure what it would mean.
1064 However, we probably need to discover which of the secure-authentication
1065 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1066 * src/modest-account-mgr-helpers.c:
1067 (modest_account_mgr_get_server_account_data):
1069 * src/modest-tny-account.c:
1070 (modest_tny_account_new_from_server_account):
1071 Use tny_account_set_mech() to set secure-authentication methods,
1072 with some special-casing for IMAP, based on my observations of how
1075 * src/modest-account-mgr-helpers.h:
1076 * src/modest-account-mgr.c:
1077 * src/modest-defs.h: Comment that the URI is only used for local folders.
1079 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1081 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1082 parameter const, just to be neat.
1083 * src/modest-text-utils.c: (modest_text_utils_inline):
1084 End g_strconcat() with NULL, as its documentation says. This is almost
1085 certainly the cause of my crash at startup on the device. Interestingly,
1086 valgrind doesn't tell us about these errors.
1088 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1090 * scripts/build-packages: Added more precise comments about how to use
1091 this script, though I still get this error:
1092 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1093 error building tinymail
1095 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/modest-main-window.c: (on_account_update):
1098 Very slight cleanup, hoping to make it simpler to discover what causes
1099 a crash here sometimes.
1101 * src/modest-tny-account.c:
1102 (modest_tny_account_new_from_server_account): Set the port. Added
1103 comments about the options and a TODO comment because I need to find out
1104 how to specify the secure authentication method.
1106 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1108 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1109 changed CFlags paths form modest to libmodest
1111 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1113 * src/modest-account-mgr-helpers.c:
1114 (modest_account_mgr_get_server_account_data),
1115 (modest_account_mgr_free_server_account_data):
1116 * src/modest-account-mgr-helpers.h:
1117 * src/modest-account-mgr.c:
1118 (modest_account_mgr_add_server_account):
1119 * src/modest-defs.h:
1120 * src/modest-tny-account.c:
1121 (modest_tny_account_new_from_server_account):
1122 Determine the options for tny_camel_account_add_option() here,
1123 based on the settings, rather than storing them directly in gconf.
1125 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1127 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1128 Show a more friendly error dialog now that we expect (from the tinymail
1129 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1131 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1133 * src/maemo/modest-main-window.c: (on_account_update): Check that
1134 account_name is not NULL, to prevent a crash at startup that I am
1135 seeing on the N800. I do wonder why it is NULL.
1137 * src/maemo/easysetup/modest-easysetup-wizard.c:
1138 (create_page_user_details):
1139 * src/maemo/modest-account-settings-dialog.c:
1140 (create_page_user_details), (create_page_outgoing):
1141 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1142 (modest_connection_specific_smtp_edit_window_init):
1143 * src/modest-ui-actions.c:
1144 (modest_ui_actions_on_password_requested):
1145 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1146 might do something useful with the on-screen keyboard.
1148 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-main-window.c: (on_account_update):
1151 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1152 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1154 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1156 * src/modest-tny-account-store.c: (on_account_changed):
1157 Correct the signature of this signal handler.
1159 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1162 Show a HildonNote instead of a GtkDialog for Maemo.
1164 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1166 * src/widgets/modest-account-view.h:
1167 * src/widgets/modest-account-view.c: (on_account_changed),
1168 (on_account_removed). Added a boolean flag, set/unset by
1169 modest_account_view_block_conf_updates(),
1170 modest_account_view_unblock_conf_updates() to prevent unnecessary
1171 updates, but this is not very useful because the gconf notifications are
1172 so delays (maybe only on Maemo Bora).
1173 So auto-updating is turned off, and these functions do an explicit
1174 update when necessary.
1175 However, something else is still doing too much work when adding/removing
1176 accounts, probably in another part of the application.
1178 * src/maemo/modest-account-view-window.c:
1179 (on_delete_button_clicked), (on_edit_button_clicked),
1180 (on_new_button_clicked): Use the new functions.
1182 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1184 * src/modest-account-mgr-helpers.c:
1185 (modest_account_mgr_set_first_account_as_default):
1186 Sort the list of names alphabetically-by-title, so we choose the first one
1188 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1189 alphabetically by the title.
1191 This fixes projects.maemo.org bug NB#56418 .
1193 * src/modest-account-mgr-priv.c:
1194 (_modest_account_mgr_account_from_key):
1195 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1196 avoid a valgrind error, and possible random behaviour.
1198 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1200 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1201 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1202 tinymail documentation to say that this can be expected.
1203 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1204 pretty, and should not happen, but I would prefer to know when it does.
1206 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1208 * configure.ac: When using the older hildon version, probably on Bora,
1209 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1211 * src/widgets/modest-attachment-view.c:
1212 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1215 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1217 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1218 Implemented the prototype. Can be tested with
1219 tests/dbus_api/test_open_message:
1221 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1223 * src/modest-tny-account-store.c:
1224 (modest_tny_account_store_instance_init), (get_password):
1225 * src/modest-ui-actions.c:
1226 (modest_ui_actions_on_password_requested):
1227 Do not store the password in gconf, because this function is called
1228 for non-remembered passwords. Actually use the cached (in the hash map)
1229 password instead of releasing it.
1230 The password will now not be remembered if it is asked via the protected
1231 password dialog, as per the UI spec.
1233 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-defs.h:
1236 * src/modest-account-mgr-helpers.h:
1237 * src/modest-account-mgr-helpers.c:
1238 Added modest_server_account_get_username_has_succeeded(),
1239 modest_server_account_set_username_has_succeeded().
1240 (modest_server_account_set_username),
1241 Reset the has-succeeded flag if the username changes.
1243 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1244 * src/maemo/modest-connection-specific-smtp-window.c:
1245 (modest_connection_specific_smtp_window_save_server_accounts):
1246 Use modest_server_account_set_username() instead of using
1247 modest_conf_set_string() directly, so that the has-succeeded flag is always
1250 * src/modest-ui-actions.c:
1251 (modest_ui_actions_on_password_requested): Dim the username entry if
1252 the username has ever worked, as per the UI spec.
1254 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1256 * src/modest-tny-account-store.c: (get_password):
1257 * src/modest-ui-actions.c:
1258 (modest_ui_actions_on_password_requested):
1259 Allow the username to be changed too, though there is more work to
1260 be done on exactly how this behaves.
1262 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-account-mgr-helpers.h:
1265 * src/modest-account-mgr-helpers.c:
1266 Added modest_account_mgr_get_display_name(),
1267 modest_server_account_get_username(),
1268 modest_server_account_set_username(),
1269 modest_server_account_set_password(),
1270 modest_server_account_get_hostname() functions so we do not need to
1271 use the conf API directly.
1273 * src/maemo/modest-main-window.c: (connect_signals):
1274 Actually connect ot the ModestAccountStore::request-password signal,
1275 so that we show the dialog when the password is requested by Tinymail,
1276 for isntance if it is empty.
1278 * src/modest-marshal.list:
1279 * src/modest-tny-account-store.c:
1280 (modest_tny_account_store_class_init), (get_password),
1281 (modest_tny_account_store_alert):
1282 * src/modest-tny-account-store.h:
1283 * src/modest-ui-actions.h:
1284 * src/modest-ui-actions.c:
1285 (modest_ui_actions_on_password_requested):
1286 Change the signal parameters, so it is obvious that we are providing
1287 the non human-readable server name, and receiving both the username
1288 and password, though changing of the username is not yet implemented.
1289 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1290 for the GNOME version.
1292 This should fix the projects.maemo.org bug NB#56209, though it does not
1293 work on Bora, because the gconf_client_get() for the password fails
1294 immediately after we save it with gconf_client_set().
1296 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1299 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1300 caused an undefined symbol error:
1301 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1303 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-tny-account-store.c:
1306 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1307 using a GError instead of a string message, so we can translate it in
1310 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1312 * src/maemo/modest-address-book.c:
1313 (modest_address_book_check_names):
1314 * src/maemo/modest-msg-view-window.c:
1315 (modest_msg_view_window_clipboard_owner_change):
1316 * src/modest-init.c: (modest_init_init_ui):
1317 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1318 (update_folders_cb), (modest_mail_operation_update_account):
1319 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1320 (modest_ui_actions_on_msg_attachment_clicked),
1321 (modest_ui_actions_on_msg_recpt_activated):
1322 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1323 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1324 (modest_msg_view_search_next):
1325 * src/widgets/modest-recpt-editor.c:
1326 (modest_recpt_editor_on_button_release_event),
1327 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1328 g_message(). At this point we should only be seeing interesting errors on
1329 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1331 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1333 (modest_wizard_dialog_force_title_update):
1334 * src/maemo/easysetup/modest-wizard-dialog.h:
1335 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1336 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1337 can update the title when appropriate. Otherwise the title is wrong if the
1338 pages are added after adding the notebook to the dialog.
1339 This must be a problem in HildonWizardDialog too.
1340 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1342 * src/maemo/easysetup/modest-easysetup-wizard.c:
1343 (create_subsequent_customsetup_pages),
1344 (create_subsequent_easysetup_pages):
1345 Call modest_wizard_dialog_force_title_update() so that the title is
1346 correct even with GTK+ < 2.10.
1347 This fixes projects.maemo.org bug NB#56145 .
1349 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/modest-platform.c:
1352 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1353 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1356 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1358 * src/widgets/modest-window.h:
1359 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1360 and modest_window_save_state(), which invokes it.
1362 * src/widgets/modest-window-mgr.h:
1363 * src/widgets/modest-window-mgr.c:
1364 Added modest_window_mgr_save_state_for_all_windows(), which calls
1365 the save_state vfunc on all registered windows, if implemented.
1367 * src/gnome/modest-msg-edit-window.c:
1368 * src/gnome/modest-msg-view-window.c:
1369 * src/maemo/modest-msg-edit-window.c:
1370 * src/maemo/modest-msg-view-window.c:
1371 * src/maemo/modest-main-window.c:
1372 Specify the existing save_settings functions as implementations of
1373 ModestWindow::save_state_func().
1375 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1376 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1377 enabling hibernation, for instance.
1379 We may need to do the same thing for restoring settings.
1382 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1384 * src/widgets/modest-window-mgr.c:
1385 * src/widgets/modest-window-mgr.h:
1386 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1387 modest_window_mgr_get_hibernation_is_prevented().
1389 * src/maemo/modest-main-window.c:
1390 (on_hildon_program_is_topmost_notify): Prevent hibernation
1391 (possible when the application goes to the background in the WM),
1392 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1394 * src/maemo/easysetup/modest-easysetup-wizard.c:
1395 (modest_easysetup_wizard_dialog_init):
1396 * src/maemo/modest-account-settings-dialog.c:
1397 (modest_account_settings_dialog_init):
1398 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1399 (modest_connection_specific_smtp_edit_window_init):
1400 * src/maemo/modest-connection-specific-smtp-window.c:
1401 (modest_connection_specific_smtp_window_init):
1402 * src/maemo/modest-signature-editor-dialog.c:
1403 (modest_signature_editor_dialog_init):
1404 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1405 prevent hibernation while any of these account settings dialogs are open.
1407 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/Makefile.am:
1410 * src/maemo/modest-osso-state-saving.c:
1411 * src/maemo/modest-osso-state-saving.h: Added
1412 modest_osso_load_state() and modest_osso_save_state() though they do
1413 nothing now. They should iterate through all the open windows and load/save
1415 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1416 save state when closing.
1418 * src/maemo/modest-main-window.c:
1419 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1420 Add a notification handler for the HildonProgram::is-topmost property,
1421 so we can allow hibernation when the application goes into the background.
1422 But we still need to detect when the accounts setup windows are open so
1423 we can stop hibernation when they are open.
1424 To do this, I also added the main window the HildonProgram. This might have
1425 other side-effects/benefits, and should maybe be done for other windows.
1427 * src/maemo/modest-osso-autosave-callbacks.h:
1428 * src/maemo/modest-osso-autosave-callbacks.c:
1429 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1430 though it does not do anything yet, and we might never need this to do
1431 anything. For instance, we already save drafts.
1433 * src/maemo/modest-platform.c: (modest_platform_init):
1434 Specify the libosso auto-save callback.
1436 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1438 * src/maemo/modest-platform.c:
1439 (modest_platform_set_update_interval):
1440 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1441 aparently stays valid between application instances, so we can use this
1442 to remove and reset it later. According to a maemo-developers email from
1445 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1447 * configure.ac: Depend on libalarm for Maemo.
1449 * src/dbus_api/modest-dbus-api.h:
1450 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1451 (on_send_receive), (modest_dbus_req_handler):
1452 Handle a SEND_RECEIVE D-Bus method.
1454 * libmodest-dbus-client/libmodest-dbus-client.c:
1455 (libmodest_dbus_client_send_and_receive):
1456 * libmodest-dbus-client/libmodest-dbus-client.h:
1457 Add C convenience functions for calling the new D-Bus method.
1459 * src/modest-platform.h:
1460 * src/gnome/modest-platform.c:
1461 * src/maemo/modest-platform.c:
1462 Added modest_platform_set_update_interval(), which uses the
1463 alarmd API on Maemo.
1464 (modest_platform_init),
1465 Call modest_platform_set_update_interval(), using a hard-coded
1466 interval for now (until the global settings dialog is implemented),
1467 though I am not sure that this makes sense yet.
1469 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1471 * src/dbus_api/modest-dbus-callbacks.c:
1472 (modest_osso_cb_hw_state_handler):
1473 * src/dbus_api/modest-dbus-callbacks.h:
1474 * src/maemo/modest-platform.c: (modest_platform_init):
1475 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1476 in case this has some effect on the ability for Maemo to ping the
1479 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1481 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1482 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1483 warning. It is probably a logic error, but I need to fix the build.
1485 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-account-mgr.h:
1488 * src/modest-account-mgr.c:
1489 (modest_account_mgr_account_names): Add a gboolean enabled_only
1490 parameter, so we can get lists of onlt the enabled accounts.
1492 (modest_account_mgr_add_account),,
1493 (modest_account_mgr_account_with_display_name_exists):
1494 * src/maemo/modest-msg-edit-window.c: (get_transports):
1495 * src/modest-account-mgr-helpers.c:
1496 (modest_account_mgr_set_first_account_as_default):
1497 * src/modest-init.c: (init_default_account_maybe):
1498 * src/modest-tny-account-store.c: (get_accounts):
1499 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1500 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1501 * tests/check_account-mgr.c: (START_TEST):
1502 Provide the extra parameter, as appropriate.
1504 * src/widgets/modest-account-view.c: (update_account_view):
1505 Do not show disabled accounts (meaning that there is no way to
1506 enable/disable accounts in the UI (the feature is not in our UI
1507 specification), so we can use this internally only to mark unfinished
1508 or temporary account data.
1510 * src/maemo/easysetup/modest-easysetup-wizard.c:
1511 (create_account): Add boolean enable parameter, so we can specify FALSE
1512 to create the temporary account.
1513 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1514 (on_before_next): When finishing, when there is a temporary account, just
1516 Also, use a timeout to delay the showing of the dialog until gconf is likely
1517 to return correct information, due to a maemo gconf bug that is fixed in
1518 osso 1.1, but not yet in Bora.
1519 However, the dialog stays on screen after it is destroyed.
1521 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1522 for invalid data when cancelling. Use a hildon note instead of a dialog
1523 to complain about invalid data. Do not show the account-saved note if the
1524 account is disabled (a temporary account that will not really be saved for use
1527 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-account-mgr-helpers.h:
1530 * src/modest-account-mgr-helpers.c:
1531 Added modest_account_mgr_unset_default_account(),
1532 Added modest_account_mgr_set_first_account_as_default().
1534 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1535 If it was the default account, unset the default account name.
1537 * src/maemo/modest-account-view-window.c:
1538 (on_delete_button_clicked): If it was the default account,
1539 set the first remaining account as the default instead.
1541 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1542 a NULL account or a NULL default account, to prevent a crash. This should
1543 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1546 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1548 * src/widgets/modest-recpt-editor.c:
1549 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1550 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1551 TODO comment for this. This fixes the build.
1553 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1554 be the best place for it. This will in future update all auto-update accounts,
1555 rather than just the current/default account, when that gconf key exists.
1556 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1557 if there are no accounts, before calling do_send_receive().
1558 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1560 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1561 * src/maemo/modest-main-window-ui.h:
1562 * src/maemo/modest-main-window.c: (on_connection_changed),
1563 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1564 directly, becaue the signal handler does more.
1566 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1568 * src/modest-account-mgr-helpers.c:
1569 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1570 for the case that the account does not exist.
1572 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1573 (equivalent to the modest account name) rather than the tinymail account name
1574 (equivalent to the modest account title - human readable) to get the account data.
1575 Check for null account data to prevent the crash, and add a TODO comment saying that
1576 this needs fixing because it is using the server account name instead of the account name.
1578 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1581 * src/maemo/modest-account-settings-dialog.c: (show_error),
1583 Use hildon_note_new_information() for informative and error messages,
1584 which seems to be expected for Maemo applications (no documentation that I know of
1585 says this). I am surprised that there is no distinction between info and error
1588 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1591 it is easy to find where this is used.
1593 * src/maemo/easysetup/modest-easysetup-wizard.c:
1594 (create_page_welcome), (create_page_account_details),
1595 (create_page_user_details), (create_page_complete_easysetup),
1596 (create_page_custom_incoming), (create_page_custom_outgoing),
1597 (create_page_complete_custom):
1598 * src/maemo/modest-account-settings-dialog.c:
1599 (create_page_account_details), (create_page_user_details),
1600 (create_page_incoming), (create_page_outgoing):
1601 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1603 (modest_connection_specific_smtp_edit_window_init):
1604 * src/maemo/modest-connection-specific-smtp-window.c:
1605 (modest_connection_specific_smtp_window_init):
1606 * src/maemo/modest-signature-editor-dialog.c:
1607 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1608 and scrolling policy as per the Email Application Layout Guide, if I have
1611 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1614 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1615 which were empty, because these vfuncs have been removed from TnyAccountStore.
1616 This fixes the build.
1618 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1620 * src/maemo/modest-main-window.c:
1621 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1622 showing/hiding it. Added TODO because it probably should not be NULL.
1623 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1624 because unnecessary g_warnings() make degugging difficult.
1626 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1628 * src/maemo/modest-msg-edit-window.c:
1629 (modest_msg_edit_window_select_color),
1630 (modest_msg_edit_window_select_background_color): 2 const corrections and
1631 moving 2 #endifs before closing brackets, to fix the build.
1633 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1635 * src/maemo/easysetup/modest-easysetup-wizard.h:
1636 * src/maemo/easysetup/modest-easysetup-wizard.c:
1637 (modest_easysetup_wizard_dialog_finalize),
1638 (on_button_edit_advanced_settings), (create_page_complete_custom),
1639 (on_response), (create_account):
1640 Implement the Advanced Settings edit button, by saving the account information,
1641 for the Advanded Settings dialog to use directly from gconf, and removing it
1642 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1643 Bug #5533 in the projects.maemo.org bugzilla.
1645 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/modest-msg-view-window.c:
1648 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1649 when opening a message window.
1651 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/easysetup/modest-easysetup-wizard.c:
1654 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1657 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1658 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1659 gconf settings. I probably added more checks than necessary, but that is safer.
1661 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1662 variable to fix the build, but this seems to be used when it is still NULL.
1664 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-platform.h:
1667 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1668 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1669 * src/modest-main.c: Implement this function so we can avoid using
1670 maemo-specific API from cross-platform code.
1672 * src/modest-tny-account-store.c:
1673 (get_smtp_specific_transport_account_for_open_connection):
1674 * src/modest-ui-actions.c: (check_for_connection),
1675 (modest_ui_actions_on_item_not_found):
1676 Use modest_platform_connect_and_wait() and put #idefs around other
1677 maemo-specific code, because only maemo currently has a way to
1678 identify connection names.
1680 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1682 * src/modest-tny-account-store.h:
1683 * src/modest-tny-account-store.c:
1684 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1685 the connection-specific SMTP server settings in the configuration.
1687 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1689 * src/maemo/modest-main-window.c: (on_connection_changed),
1691 * src/modest-main.c: (main), (start_ui), (send_mail):
1692 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1693 that is what is intended.
1695 * src/modest-ui-actions.c: (action_send), (action_receive),
1696 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1697 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1698 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1699 SMTP server is used when it is specified.
1701 (modest_ui_actions_on_send_receive):
1702 Check that a connection is open before proceeding.
1703 Receive and then send, instead of vice-versa, as per the specification.
1705 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-mail-operation.c:
1708 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1709 though I guess it should be something other than NULL.
1711 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/easysetup/modest-easysetup-wizard.c:
1714 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1715 combo twice, to avoid an g_warning and to make it visible again.
1716 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1717 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1718 (already intended) dereference when detaching, because we then recreate the menu.
1719 But I am not sure why the warning was happening, and it is possible that this is a memory
1722 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1724 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1725 and uri_parse_mailto() utility functions.
1726 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1728 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1730 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1732 * src/dbus_api/modest-dbus-api.h:
1733 * src/dbus_api/modest-dbus-callbacks.c:
1734 Use an idle callback to execute the modest code in the application's own thread.
1735 Remove the helloworld example method.
1736 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1737 parsed, and the open-message method is not implemented because this is not yet implemented in
1739 * libmodest-dbus-client/libmodest-dbus-client.c:
1740 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1741 (libmodest_dbus_client_open_message):
1742 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1744 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1745 body without crashing.
1747 * tests/dbus_api/Makefile.am:
1748 * tests/dbus_api/test_mail_to.c:
1749 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1751 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1753 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1754 Added file to fix the build. Sorry.
1756 * src/dbus_api/Makefile.am:
1757 * src/dbus_api/modest-dbus-api.h:
1758 * src/dbus_api/modest-dbus-callbacks.h:
1759 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1760 (modest_dbus_req_handler):
1761 Put constants in a separate header so it can be reused by the
1762 client library, without duplication
1764 * libmodest-dbus-client/Makefile.am:
1765 * libmodest-dbus-client/libmodest-dbus-client.c:
1766 (libmodest_dbus_client_call_helloworld),
1767 (libmodfest_dbus_client_send_mail),
1768 (libmodfest_dbus_client_mailto),
1769 (libmodfest_dbus_client_open_message):
1770 * libmodest-dbus-client/libmodest-dbus-client.h:
1771 (Partly) Implement a send_mail D-Bus method.
1773 * tests/dbus_api/Makefile.am:
1774 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1775 the send_email D-Bus method.
1777 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1781 * libmodest-dbus-client/Makefile.am:
1782 * libmodest-dbus-client/libmodest-dbus-client.c:
1783 * libmodest-dbus-client/libmodest-dbus-client.h:
1784 * tests/dbus_api/Makefile.am:
1785 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1786 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1788 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1790 * src/maemo/easysetup/modest-easysetup-wizard.c:
1791 (create_page_account_details):
1792 * src/maemo/modest-account-settings-dialog.c:
1793 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1794 widgets, because this might not be the default in future versions of the Maemo GTK+.
1795 However, I can not not get capitalization to work even in a simple test case.
1797 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/easysetup/modest-easysetup-wizard.c:
1800 (create_page_custom_incoming), (create_page_custom_outgoing):
1801 * src/maemo/modest-account-settings-dialog.c:
1802 (create_page_account_details), (create_page_incoming),
1803 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1804 instead of using gtk_check_button_with_label(), so they are aligned like the other
1805 widgets, as per the UI spec.
1807 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1809 * src/maemo/easysetup/modest-easysetup-wizard.c:
1810 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1811 * src/widgets/modest-validating-entry.c:
1812 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1813 Modest prefix instead of an EasySetup prefix.
1815 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1817 * src/widgets/modest-validating-entry.h:
1818 * src/widgets/modest-validating-entry.c: (on_insert_text),
1819 Added easysetup_validating_entry_set_max_func(), used to set a callback
1820 to call when the max number of characters is reached. GtkEntry has a max-length
1821 already but is silent about it.
1823 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1824 (create_page_account_details), (create_page_user_details),
1826 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1827 (create_page_account_details), (create_page_user_details),
1828 (create_page_outgoing):
1829 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1830 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1831 the UI spec, when the user tries to enter more than the max number of characters.
1833 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1835 * src/maemo/easysetup/modest-easysetup-wizard.c:
1836 (create_page_user_details), (create_page_custom_incoming),
1837 (create_page_custom_outgoing):
1838 * src/maemo/modest-account-settings-dialog.c:
1839 (create_page_user_details), (create_page_incoming),
1840 (create_page_outgoing):
1841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1842 (modest_connection_specific_smtp_edit_window_init):
1843 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1844 not appropriate. Bad Maemo-specific defaults!.
1846 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1849 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1850 (modest_signature_editor_dialog_set_settings):
1851 Disable the label and textview when the checkbox is disabled, and use the
1852 specified (UI spec) default signature text.
1854 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1857 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1859 * src/modest-defs.h:
1860 * src/modest-account-mgr-helpers.h:
1861 * src/modest-account-mgr-helpers.c:
1862 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1864 * src/maemo/Makefile.am:
1865 * src/maemo/modest-signature-editor-dialog.c:
1866 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1869 * src/maemo/modest-account-settings-dialog.h:
1870 * src/maemo/modest-account-settings-dialog.c:
1871 (modest_account_settings_dialog_finalize), (on_button_signature),
1872 (save_configuration): Use the new dialog when the Edit button is pressed, and
1873 save the changes if necessary, as per the UI spec.
1875 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/Makefile.am:
1878 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1879 based on maemo-develoers email from Dirk.
1881 * src/maemo/easysetup/modest-easysetup-wizard.c:
1882 (create_page_welcome), (create_page_account_details),
1883 (create_page_user_details), (create_page_complete_easysetup),
1884 (create_page_custom_incoming), (create_page_custom_outgoing),
1885 (create_page_complete_custom),
1886 (modest_easysetup_wizard_dialog_init):
1887 * src/maemo/modest-account-settings-dialog.c:
1888 (create_page_account_details), (create_page_user_details),
1889 (create_page_incoming), (create_page_outgoing),
1890 (modest_account_settings_dialog_init):
1891 * src/maemo/modest-connection-specific-smtp-window.c:
1892 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1894 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/easysetup/modest-easysetup-wizard.c:
1897 (create_page_account_details), (create_page_custom_outgoing),
1898 (create_page_complete_custom):
1899 * src/maemo/modest-account-settings-dialog.c:
1900 (create_page_user_details), (create_page_incoming),
1901 (create_page_outgoing):
1902 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1903 (modest_connection_specific_smtp_edit_window_init):
1904 Use the correct (UI spec) port min/max, and use horizontal separators,
1907 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1909 * src/maemo/easysetup/modest-easysetup-wizard.c:
1910 (set_default_custom_servernames):
1911 * src/maemo/modest-account-settings-dialog.c:
1912 (create_page_incoming), (on_combo_outgoing_security_changed),
1913 (on_combo_incoming_security_changed), (create_page_outgoing),
1914 (modest_account_settings_dialog_set_account_name),
1915 (save_configuration):
1916 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1917 (on_combo_security_changed),
1918 (modest_connection_specific_smtp_edit_window_init),
1919 (modest_connection_specific_smtp_edit_window_set_connection),
1920 (modest_connection_specific_smtp_edit_window_get_settings):
1921 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1924 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/easysetup/modest-easysetup-wizard.c:
1928 (create_page_custom_outgoing), (create_page_complete_custom):
1929 * src/maemo/modest-account-settings-dialog.c:
1930 (create_page_user_details), (create_page_outgoing):
1931 * src/maemo/modest-account-view-window.c: (button_box_new):
1932 Use changed logical IDs as per the most recent UI spec:
1933 mcen_bd_emailsetup_edit -> mcen_bd_edit
1934 mcen_bd_emailsetup_delete -> mcen_bd_delete
1935 mcen_bd_emailsetup_close -> mcen_bd_close
1937 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1941 * src/dbus_api/Makefile.am:
1942 * src/dbus_api/modest-dbus-callbacks.c:
1943 * src/dbus_api/modest-dbus-callbacks.h:
1944 * src/maemo/modest-platform.c: (modest_platform_init):
1945 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1947 * tests/Makefile.am:
1948 * tests/dbus_api/Makefile.am:
1949 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1951 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-account-settings-dialog.c:
1954 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1955 Removed unnecessary includes.
1957 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/easysetup/modest-easysetup-wizard.c:
1960 * src/maemo/modest-account-settings-dialog.c:
1961 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1962 * src/widgets/Makefile.am:
1963 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1964 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1965 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1966 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1967 * src/widgets/modest-secureauth-combo-box.c:
1968 * src/widgets/modest-secureauth-combo-box.h:
1969 * src/widgets/modest-serversecurity-combo-box.c:
1970 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1971 made the GObject names more consistent with the rest of the Modest code.
1973 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/easysetup/Makefile.am:
1976 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1977 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1978 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1979 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1980 * src/maemo/easysetup/modest-easysetup-wizard.c:
1981 * src/maemo/easysetup/modest-validating-entry.c:
1982 * src/maemo/easysetup/modest-validating-entry.h:
1983 * src/maemo/modest-account-settings-dialog.c:
1984 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1985 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1986 widgets/ because they are used outside of easysetup too. After checking in,
1987 svn will allow me to rename them too.
1989 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1991 * src/gnome/modest-msg-edit-window.c:
1992 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1993 linker error, to fix the build on the GNOME platform.
1994 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1995 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1996 ifdefed out to avoid a warning.
1998 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2000 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2001 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2002 some alternative for GTK+ 2.6.
2004 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2008 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2009 specified for EmailAccountsDialog in UI spec.
2011 * src/maemo/easysetup/modest-easysetup-wizard.c:
2012 * src/maemo/easysetup/modest-easysetup-wizard.h:
2013 * src/maemo/modest-account-settings-dialog.c:
2014 * src/maemo/modest-account-settings-dialog.h:
2015 Reuse a member window widget for the connection-specific SMTP server accounts,
2016 so we can tell it to create/save the accounts only if we actually save changes.
2018 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2019 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2020 (modest_connection_specific_smtp_edit_window_get_settings):
2021 Return a struct instance for temporarily remembering the entered data.
2023 * src/maemo/modest-connection-specific-smtp-window.h:
2024 * src/maemo/modest-connection-specific-smtp-window.c:
2025 (modest_connection_specific_smtp_window_finalize),
2026 (modest_connection_specific_smtp_window_fill_with_connections),
2028 (modest_connection_specific_smtp_window_save_server_accounts),
2029 (update_model_server_names): Do not actually save data until asked,
2030 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2032 (on_selection_changed),
2033 (modest_connection_specific_smtp_window_init): Disable the edit
2034 button when nothing is selected.
2036 * src/modest-account-mgr-helpers.c:
2037 * src/modest-account-mgr-helpers.h:
2038 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2041 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-account-mgr-helpers.h:
2044 * src/modest-account-mgr-helpers.c:
2045 (modest_account_mgr_get_unused_account_name),
2046 (modest_account_mgr_get_unused_account_display_name): Added these
2047 utility functions, to avoid code duplication.
2049 * src/maemo/easysetup/modest-easysetup-wizard.c:
2050 (create_page_account_details), (create_account):
2051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2052 (on_combo_security_changed),
2053 (modest_connection_specific_smtp_edit_window_init),
2054 (modest_connection_specific_smtp_edit_window_save_settings):
2055 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2056 * src/maemo/modest-connection-specific-smtp-window.c:
2057 (modest_connection_specific_smtp_window_finalize),
2058 (modest_connection_specific_smtp_window_fill_with_connections),
2059 (on_button_edit), (modest_connection_specific_smtp_window_init):
2060 * src/maemo/modest-connection-specific-smtp-window.h:
2061 Implementing saving of connection-specific server accounts.
2063 But I need to refactor this so we can save the data for each
2064 possible connection-specific account and only actually create the server accounts
2065 when the easysetup finished, or the OK button is pressed on the account settings
2068 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2071 (on_combo_security_changed):
2072 (modest_connection_specific_smtp_edit_window_init):
2073 Auto-fill the port number as in the account settings.
2075 (modest_connection_specific_smtp_edit_window_set_connection):
2076 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2077 * src/maemo/modest-connection-specific-smtp-window.c:
2078 (fill_with_connections), (on_button_edit),
2079 (modest_connection_specific_smtp_window_init):
2080 Turn the edit window into a dialog to simplify the code, and
2081 set a WM hint as in a GtkDialog, because only a popup can be on top of
2082 another window in Maemo, and popups usually have no WM decoration.
2084 * src/modest-defs.h:
2085 * src/modest-account-mgr-helpers.c:
2086 (modest_account_mgr_set_connection_specific_smtp),
2087 (modest_account_mgr_remove_connection_specific_smtp),
2088 (modest_account_mgr_get_connection_specific_smtp):
2089 * src/modest-account-mgr-helpers.h: Some functions to write the
2090 connection-specific SMTP server information. Not yet used.
2093 * src/widgets/modest-folder-view.c: (text_cell_data):
2094 Fix a warning about an uninitialized variable.
2095 (on_configuration_key_changed): Put an #ifdef around the use
2096 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2098 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/modest-account-settings-dialog.h:
2101 * src/maemo/modest-account-settings-dialog.c:
2102 Added connect_for_modified() utility function to mark the new modified boolean.
2104 (create_page_account_details), (create_page_user_details),
2105 (create_page_incoming), (create_page_outgoing), (on_response),
2106 (modest_account_settings_dialog_init),
2107 (modest_account_settings_dialog_set_account_name):
2108 Only warn about unsaved changes when there are actually unsaved changes.
2110 * src/modest-account-mgr-helpers.c:
2111 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2112 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2113 to get the data from there in future.
2115 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2117 * src/modest-defs.h:
2119 * src/modest-account-mgr-helpers.h:
2120 * src/modest-account-mgr-helpers.c:
2121 Store the security account setting in a single conf key instead of using
2122 the options list, so that the list is left for just the to-be-removed camel hack,
2123 and because gconf_client_set_list() is failing for some reason.
2125 * src/modest-account-mgr.c:
2126 (modest_account_mgr_add_server_account):
2127 * src/maemo/modest-account-settings-dialog.c:
2128 (modest_account_settings_dialog_set_account_name),
2129 (save_configuration): Use the renamed functions.
2132 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2134 * src/widgets/Makefile.am:
2135 * src/widgets/modest-limit-retrieve-combo-box.c:
2136 * src/widgets/modest-limit-retrieve-combo-box.h:
2137 * src/widgets/modest-retrieve-combo-box.c:
2138 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2139 the account settings dialog.
2141 * src/modest-defs.h:
2142 * src/modest-account-mgr-helpers.h:
2143 * src/modest-account-mgr-helpers.c:
2144 (modest_server_account_get_option_secure_auth),
2145 (modest_server_account_set_option_secure_auth):
2146 * src/modest-account-mgr.c:
2147 (modest_account_mgr_add_server_account):
2148 Use the existing AUTH_MECH conf key for the secure-auth setting,
2149 instead of putting it in the list options, because this was actually used already.
2151 * src/maemo/modest-account-settings-dialog.c:
2152 (create_page_account_details),
2153 (modest_account_settings_dialog_set_account_name),
2154 (save_configuration):
2155 * src/maemo/modest-account-settings-dialog.h:
2156 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2157 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2159 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2161 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2162 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2163 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2165 * src/modest-defs.h:
2166 * src/maemo/modest-account-settings-dialog.c:
2167 (create_page_incoming), (on_combo_outgoing_security_changed),
2168 (on_combo_incoming_security_changed), (create_page_outgoing),
2169 (modest_account_settings_dialog_set_account_name),
2170 (save_configuration): Load/Save the port number, and change it when the
2171 security combo changes, to suitable defaults.
2173 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2175 * src/modest-account-mgr.c:
2176 (modest_account_mgr_add_server_account): Set the security and secure-auth
2177 options, and add a comment saying that the other camel-specific options should be
2180 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2182 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2184 * src/modest-tny-account-store.c: (account_list_free),
2185 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2186 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2189 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2191 * src/modest-protocol-info.c:
2192 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2193 is required by our UI spec. Maybe something in our implementation will use this eventually.
2194 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2195 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2196 instead of the previous 0 placeholder.
2198 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2199 secure-auth settings.
2200 * src/modest-account-mgr-helpers.h:
2201 * src/modest-account-mgr-helpers.c:
2202 (modest_server_account_data_get_option_secure_auth),
2203 (modest_server_account_set_option_secure_auth),
2204 (modest_server_account_data_get_option_security),
2205 (modest_server_account_set_option_security): Added this API for getting and setting the security
2206 and secure-auth settings.
2208 * src/maemo/modest-account-settings-dialog.h:
2209 * src/maemo/modest-account-settings-dialog.c:
2210 (modest_account_settings_dialog_finalize), (check_data),
2211 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2212 about changing titles.
2213 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2214 (save_configuration): Save the security and secure-auth settings.
2216 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2217 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2219 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-defs.h:
2222 * src/modest-account-mgr.c:
2223 (modest_account_mgr_add_server_account):
2224 Added and used defines for the options key and value pair strings,
2225 that are used so far, though they do not seem to correspond to anything in our
2226 UI specs or ModestProtocol enum.
2228 * src/modest-account-mgr-helpers.h:
2229 * src/modest-account-mgr-helpers.c:
2230 (compare_option_strings_for_name),
2231 (modest_server_account_data_get_option_value),
2232 (modest_server_account_data_get_option_bool),
2233 (modest_account_mgr_get_server_account_option):
2234 Added helper functions for parsing the options GSList.
2236 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2238 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2239 display name is based on the supplied account name.
2240 * src/modest-account-mgr.c:
2241 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2242 with an inefficient, but good-enough, implementation.
2244 * src/maemo/easysetup/modest-easysetup-wizard.c:
2245 (create_page_account_details), (on_before_next), (create_account):
2246 Check for existing display names rather than (non-user-visible) account names, and just
2247 create and set a unique account name at the end.
2249 * src/maemo/modest-account-settings-dialog.c:
2250 (modest_account_settings_dialog_init),
2251 (modest_account_settings_dialog_set_account_name),
2252 (create_page_incoming): Show the display name, instead of the account name.
2253 (on_response): Do some (not all) extra checks, as in the UI spec.
2254 (save_configuration): Save the display name if it was changed.
2256 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2258 * po/en_GB.po: Added needed logical ID and translation.
2259 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2260 (init_view): Made the is-default column clicking work.
2262 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2265 * src/maemo/easysetup/Makefile.am:
2266 * src/maemo/easysetup/modest-easysetup-wizard.c:
2267 (modest_easysetup_wizard_dialog_init):
2268 * src/maemo/easysetup/provider-data-test.keyfile:
2269 * src/maemo/easysetup/provider-data.keyfile:
2270 Moved the provider data file to the new modest-providers-data package and used it from there.
2272 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-local-folder-info.c:
2275 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2276 N_() was already used on the static strings, but this just marks it for translation without
2277 using the translation.
2279 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/modest-account-settings-dialog.c:
2282 (create_page_incoming),
2283 (modest_account_settings_dialog_set_account_name):
2284 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2285 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2286 I will do this if nobody else gets there first.
2288 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2290 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2291 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2292 save the security stuff.
2294 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2296 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2297 Set the email address and user fullname, which I now see must be
2300 * src/maemo/modest-account-settings-dialog.h:
2301 * src/maemo/modest-account-settings-dialog.c:
2303 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2304 leave-on-server and authentication.
2305 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2308 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/modest-account-settings-dialog.c:
2312 * src/maemo/modest-account-settings-dialog.h:
2313 Most (but not all) of the widgets are now present as specified by the UI spec.
2314 No changes are yet saved, and some details are not properly shown yet.
2316 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2318 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2320 * src/maemo/Makefile.am:
2321 * src/maemo/modest-account-settings-dialog.c:
2322 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2323 an existing account. Doesn't do much yet.
2325 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2326 Open the accounts settings dialog when Edit is clicked.
2328 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2330 * src/maemo/easysetup/Makefile.am:
2331 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2333 * src/maemo/easysetup/modest-easysetup-wizard.c:
2334 (modest_easysetup_wizard_dialog_init):
2335 Try to get the source directory from the build system,
2336 instead of hard-coding "./" into the source code, when opening our local
2337 copies of the configuration files.
2338 But this still fails when opening the wizard from the Accounts window,
2339 maybe because the working directory seems to change at runtime.
2340 So the wizard will fail the second time unless you copy the files into their
2341 proper locations - see the stdout warnings for the paths.
2343 (create_page_account_details),(on_before_next):
2344 Check for existing non-server accounts instead of server accounts,
2345 so the default account name is useful again, and to prevent trying to
2348 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2349 Show the wizard when New is clicked.
2351 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2352 (init_view): Show the column headers, and show the columns that are
2353 specified in the UI specs. However, something in Maemo's GTK+ prevents
2354 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2355 change the default account. This is despite unsetting the special properties.
2357 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2359 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2360 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2361 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2362 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2363 to make that clearer.
2364 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2366 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2368 * src/maemo/modest-account-view-window.c:
2369 (modest_account_view_window_init),
2370 (modest_account_view_window_new):
2371 Use the same buttons as specified in the
2372 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2373 the existing widgets, which never had a chance of working.
2374 Put the ModestAccountView treeview in a scrolled window.
2375 Do not repeat the initialization in both _init() and _new().
2377 * src/widgets/modest-account-view.c: (update_account_view):
2378 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2379 this widget and window shows no accounts.
2381 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2383 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2385 * src/maemo/easysetup/modest-easysetup-wizard.c:
2386 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2387 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2388 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2391 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2392 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2393 accounts exist yet, as in the UI spec.
2395 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2397 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2399 * src/maemo/Makefile.am:
2400 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2401 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2402 New window for editing connection-specific smtp details.
2403 Not fully implemented.
2405 * src/maemo/modest-connection-specific-smtp-window.c:
2406 (modest_connection_specific_smtp_window_finalize) :
2407 unref the tree model.
2408 (on_button_edit): Show the edit window.
2410 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2412 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2415 * src/maemo/Makefile.am:
2416 * src/maemo/modest-connection-specific-smtp-window.c:
2417 * src/maemo/modest-connection-specific-smtp-window.h:
2418 New window for showing the list of connections, for connection-specific
2419 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2420 * src/maemo/easysetup/modest-easysetup-wizard.c:
2421 (create_page_custom_outgoing): Show the new window when the button is clicked.
2423 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2425 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2426 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2427 * src/maemo/modest-msg-edit-window.c:
2428 (modest_msg_edit_window_insert_image):
2429 * src/modest-conf.c: (modest_conf_key_escape):
2430 * src/modest-mail-operation.c:
2431 (modest_mail_operation_send_new_mail):
2432 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2433 (modest_ui_actions_on_new_account):
2434 * src/widgets/modest-attachment-view.c: (update_filename_request):
2435 * src/widgets/modest-mail-header-view.c:
2436 Corrected warnings that were breaking the build, by commenting out unused variables,
2437 and a function, and by including a header.
2439 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2441 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2442 so we can #ifdef around platform-specific code when necessary.
2443 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2444 to allow this to build for the GNOME platform too.
2446 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2448 * src/maemo/easysetup/modest-easysetup-wizard.c:
2449 Added util_increment_name() and used it in create_page_account_details()
2450 to make sure that the default account name is always a new name.
2452 (modest_easysetup_wizard_dialog_init),
2453 (set_default_custom_servernames): Some minor memory management fixes.
2455 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-runtime.c: (init_i18n): Restored the translation
2460 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2461 are defined in config.h, and the translations are installed.
2463 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2464 is defined for translation.
2466 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2470 * src/maemo/easysetup/modest-easysetup-wizard.c:
2471 (modest_easysetup_wizard_dialog_init):
2472 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2473 Use realistic paths (though they should use $prefix generically) to the
2474 mcc_mapping and provider-data.keyfile files which might work when they
2475 are installed by the future version of the operator-wizard package,
2476 and then fallback to paths in our source code, with an explanatory
2479 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2483 * src/maemo/Makefile.am:
2484 * src/maemo/easysetup/: Added files from the previously-exernal
2485 osso-modest-easysetup.
2486 * src/maemo/modest-main-window-ui.h:
2487 * src/modest-ui-actions.c:
2488 * src/modest-ui-actions.h:
2489 Added modest_ui_actions_on_new_account() as a signal handler for the
2490 New Account menu item. It shows the easysetup wizard.
2491 * po/en_GB.po: Added additional needed logical IDs and translations.
2493 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2494 Apparently ChangeLog is not used for some vague Nokia legal reasons.