1 2007-06-21 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
4 Comment out the use of hildon_notification_set_sound() because it is
5 not declared, to fix the build. Warnings are serious, people.
7 2007-06-21 Armin Burgmeier <armin@openismus.com>
9 * src/maemo/modest-maemo-utils.h:
10 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
11 modest_maemo_utils_get_supported_secure_authentication_methods()
12 to query authentication methods for a specific user. This should fix
13 projects.maemo.org bug NB#61369.
15 * src/maemo/easysetup/modest-easysetup-wizard.c:
16 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
19 2007-06-21 Murray Cumming <murrayc@murrayc.com>
21 * libmodest-dbus-client/libmodest-dbus-client.h:
22 * libmodest-dbus-client/libmodest-dbus-client.c:
23 (modest_dbus_message_iter_get_search_hit),
24 (libmodest_dbus_client_search):
25 Reorganised and commented this.
26 Removed modest_search_hit_free() from the public API because it
29 Added libmodest_dbus_client_get_folders() and
30 modest_folder_result_list_free().
32 * src/dbus_api/modest-dbus-api.h:
33 * src/dbus_api/modest-dbus-callbacks.c:
34 (modest_dbus_req_filter): Commented. Moved most code to
35 on_dbus_method_search() and added on_dbus_method_get_folders().
37 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
38 of the extra D-Bus handler.
40 * tests/dbus_api/Makefile.am:
41 * tests/dbus_api/test_get_folders.c: New test for
42 libmodest_dbus_client_get_folders(). This seems to return an empty list
43 at the moment. That could be the same error that causes the message list
44 to be empty sometimes.
45 This should help with projects.maemo.org bug NB#57740.
47 2007-06-21 Armin Burgmeier <armin@openismus.com>
49 * src/modest-mail-operation.c: Do not call
50 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
51 notify the operation's end after having set the status to CANCELED for
52 the operation queue to listen on. This fixes a deadlock when there
53 were mail operations in the queue during its finalization.
55 * src/modest-singletons.c: Reordered uninitialization of the account
56 manager to happen after the mail operation queue was uninitialized
57 because the mail operation's in the queue might still try to access
58 the account manager (see modest_mail_operation_notify_end()). This
59 fixes a potential crash when terminating the application.
61 2007-06-21 Murray Cumming <murrayc@murrayc.com>
63 * src/modest-search.c:
64 (search_mime_part_and_child_parts): Moved some code here so we
65 can search recursively in child folders.
66 (modest_search_folder): Search in the message as a mime part, instead
67 of just its child mime parts.
68 (read_chunk), (search_mime_part_ogs):
69 Check how many bytes were read, to prevent an endless loop.
70 Searching in message bodies now works. This finishes the fix for
71 projects.maemo.org bug NB#61007.
73 2007-06-20 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
76 Add a g_warning when the item is not a folder.
78 * src/modest-ui-dimming-rules.c:
79 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
80 when selected item is not a folder (for instance, an account), because
81 the UI spec only talks about folders.
82 I am not sure what the UI spec wants, so this might not totally fix
83 projects.maemo.org bug NB#60794.
85 2007-06-20 Murray Cumming <murrayc@murrayc.com>
87 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
88 (load_from_file): Sort the list. The unsorted list would be more noticeable
89 in non-English locales.
91 * src/maemo/modest-msg-edit-window.c:
92 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
93 warning and fix the build.
95 * src/maemo/modest-progress-bar-widget.c:
96 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
97 avoid a g_warning, and probably to avoid a crash.
99 2007-06-20 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-search.c: (modest_search_folder): Check for a GError
102 when calling tny_folder_get_headers(), to show that this is not the cause
105 2007-06-20 Murray Cumming <murrayc@murrayc.com>
107 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
108 Actually set the body query instead of the subject query.
110 * src/modest-search.c: (search_mime_part_ogs),
111 (search_mime_part_strcmp): Remove extra space from the text/* regex,
112 which would probably cause it to fail if we got this far.
114 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
115 to simplify the code.
116 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
117 be causing search-in-body to fail.
119 2007-06-20 Murray Cumming <murrayc@murrayc.com>
121 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
123 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
124 Better debug message when the folder cannot be found.
125 This should help with fixing projects.maemo.org bug #61287.
126 * src/modest-search.c: (add_hit): Do not leak the furl string.
128 2007-06-20 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-ui-actions.c:
131 (modest_ui_actions_on_folder_selection_changed):
132 Do not special-case TNY_MERGE_FOLDER here, because
133 modest_tny_folder_get_account() already does that. This fixes
134 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
135 shown when the Outbox was selected).
137 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
139 * libmodest-dbus-client/libmodest-dbus-client.c:
140 (_dbus_iter_get_string_or_null): Initialize the string variable in
141 case this helps with Dirk's crash.
143 2007-06-19 Murray Cumming <murrayc@murrayc.com>
145 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
146 though it is not implemented yet (this function is maybe not even used),
147 to avoid breaking ABI in future.
148 * libmodest-dbus-client/libmodest-dbus-client.c:
149 (get_attachments_string): Moved some code into this generic function.
150 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
151 sends email. It is maybe not used.
152 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
153 (on_send_mail): Use attachments.
155 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
156 * src/maemo/modest-msg-edit-window.c:
157 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
158 a filename before using it, to fix projects.maemo.org bug NB#58233.
160 2007-06-19 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
163 Initialize the continue_download variable to fix the build, and probably
164 to fix randome behaviour.
166 2007-06-18 Armin Burgmeier <armin@openismus.com>
168 * src/modest-tny-send-queue.h:
169 * src/modest-tny-send-queue.c: Keep track of the status of messages in
170 the queue so we can later show it in the UI. Replaced
171 modest_tny_send_queue_msg_is_being_sent() by
172 modest_tny_send_queue_get_msg_status().
174 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
176 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
177 gpointer. This probably was not harmful, but just to be sure.
179 2007-06-18 Murray Cumming <murrayc@murrayc.com>
181 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
182 Fix the build, but leave the function broken on Bora, because
183 hildon_uri_action_get_service() does not exist.
184 osso_uri_action_get_service() does not exist either, it seems.
186 2007-06-18 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-tny-account.c:
189 (modest_tny_account_new_from_server_account):
190 Uncommented the url debug output again, because it is useful for
191 debugging, as I said in the comment.
193 2007-06-18 Murray Cumming <murrayc@murrayc.com>
195 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
197 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
198 for Mameo Bora, to fix the build.
200 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
203 Fixed build with hildon < 0.99
205 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
206 Check if the selected account is busy instead of checking all accounts
208 * src/modest-account-mgr-priv.h:
209 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
210 (modest_account_mgr_init), (compare_account_name),
211 (modest_account_mgr_set_account_busy),
212 (modest_account_mgr_account_is_busy):
213 * src/modest-account-mgr.h:
214 Added busy information to the account manager. It possible to
215 set an account to busy or not busy now.
217 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
218 (modest_mail_operation_update_account),
219 (modest_mail_operation_notify_end):
220 Set the account to busy/not busy depending on the operation state.
222 * src/widgets/modest-account-view.c:
223 (modest_account_view_finalize), (get_last_updated_string),
224 (update_account_view), (on_account_busy_changed), (init_view):
225 Show string "Refreshing..." if the account is currently busy.
227 All this fixes projects.maemo.org bug NB#59711
229 2007-06-14 Armin Burgmeier <armin@openismus.com>
231 * src/widgets/modest-attachments-view.h:
232 * src/widgets/modest-attachments-view.c: Added
233 modest_attachments_view_has_attachments() and fixed coordinate
234 transformation in get_att_view_at_coords(). This fixes attachment
237 * src/widgets/modest-msg-view.c: Make use of
238 modest_attachments_view_has_attachments() to decide whether to show
239 attachments in the header.
241 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
244 (on_change), (on_combo_security_changed),
245 (modest_connection_specific_smtp_edit_window_init),
246 (modest_connection_specific_smtp_edit_window_set_connection),
247 (modest_connection_specific_smtp_edit_window_is_dirty):
248 * src/maemo/modest-connection-specific-smtp-edit-window.h:
249 * src/maemo/modest-connection-specific-smtp-window.c:
252 Show an comfirmation dialog for the smpt-edit-window if there are
253 unsaved changes and the user hits cancel.
254 (projects.maemo.org bug NB#60479)
256 2007-06-14 Armin Burgmeier <armin@openismus.com>
258 * src/maemo/easysetup/modest-easysetup-wizard.c:
259 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
260 address" info in banner instead of node, and select all the text as
261 per UI spec. This fixes projects.maemo.org bug NB#60550.
263 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
265 reviewed by: <delete if not using a buddy>
267 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
268 * src/modest-ui-actions.c: (folder_refreshed_cb):
270 2007-06-14 Murray Cumming <murrayc@murrayc.com>
272 * src/widgets/modest-folder-view.c: (filter_row):
273 Explictly filter out the per-account outbox accounts. I don't know why
274 these only sometimes show up, but now they should never show up in the UI.
275 This should fix projects.maemo.org bug NB#60160.
277 2007-06-14 Murray Cumming <murrayc@murrayc.com>
279 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
280 when the toolbar does not exist yet.
281 * src/modest-widget-memory.c: (save_settings_header_view):
282 Added g_warnings() to help us to discover when we are trying to set
283 an empty columns list in gconf.
285 2007-06-14 Murray Cumming <murrayc@murrayc.com>
289 Added modest_init_get_default_header_view_column_ids().
291 * src/modest-widget-memory.c: (restore_settings_header_view):
292 Use the new function to get defaults, if the gconf key is empty,
293 instead of not creating any columns. This seems to fix the
294 empty right-hand pane problems.
296 * src/widgets/modest-header-view.h: Improved documentation.
298 2007-06-13 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
301 Revert the use of the display name as the account name, because this
302 is generally wrong and would break the code that follows.
304 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
306 * src/maemo/easysetup/modest-easysetup-wizard.c:
307 (check_for_supported_auth_methods), (on_before_next),
310 More correct fix for projects.maemo.org bug NB# 58991
311 Do not longer accept AUTH_PASSWORD as secure method and choose
312 correct method when creating the account.
314 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
316 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
317 Fixed projects.maemo.org bug NB# 58991
319 2007-06-13 Murray Cumming <murrayc@murrayc.com>
321 * src/modest-init.c: (modest_init_init_core),
322 (modest_init_local_folders): Fixed compilation errors.
324 2007-06-13 Murray Cumming <murrayc@murrayc.com>
326 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
327 Remove unnecessary lib/include, though it is good in principle when needed.
329 * src/modest-init.c: (modest_init_one_local_folder),
330 (modest_init_local_folders):
331 * src/modest-init.h: Initialize the .modest library for memory cards,
332 instead of just doing nothing for them. This should allow us to create
333 folders there, fixing projects.maemo.org bug NB#59297.
335 2007-06-13 Murray Cumming <murrayc@murrayc.com>
337 * libmodest-dbus-client/libmodest-dbus-client.c:
338 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
339 (libmodest_dbus_client_compose_mail),
340 (libmodest_dbus_client_open_message),
341 (libmodest_dbus_client_send_and_receive),
342 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
344 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
345 (on_idle_open_message), (modest_dbus_req_handler),
346 (search_result_to_message), (modest_dbus_req_filter):
347 * src/modest-search.c: (add_hit), (modest_search_folder),
348 (modest_search_all_accounts): Improved debug messages.
350 * tests/dbus_api/test_open_message.c: (main): Improved comments.
352 * src/modest-tny-account-store.c:
353 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
356 2007-06-13 Murray Cumming <murrayc@murrayc.com>
359 2007-06-12 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-tny-account-store.c: (get_server_accounts):
362 Call modest_tny_local_folders_account_add_merged_outbox_folders()
363 even when there are no accounts, so that the Outbox folder is always
364 visible. This fixes projects.maemo.org bug NB#60158.
366 2007-06-12 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/modest-main-window.c: (create_details_widget):
369 Use the mcen_va_never logical ID.
371 2007-06-12 Murray Cumming <murrayc@murrayc.com>
373 * src/dbus_api/modest-dbus-api.h:
374 * src/dbus_api/modest-dbus-callbacks.c:
375 (on_idle_open_default_inbox), (on_open_default_inbox),
376 (modest_dbus_req_handler):
377 Added a new OpenDefaultInbox method.
379 * libmodest-dbus-client/libmodest-dbus-client.h:
380 * libmodest-dbus-client/libmodest-dbus-client.c:
381 Added libmodest_dbus_client_open_default_inbox() to call the new
382 dbus method. This should be useful to projects.maemo.org bug NB#57214,
383 though it should maybe be used by a new osso-email-interface function.
385 * tests/dbus_api/Makefile.am:
386 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
389 2007-06-12 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
392 NULL, so that the signals get all the keys. This should not actually
393 change any behaviour because we currently update everything when anything
396 2007-06-12 Murray Cumming <murrayc@murrayc.com>
398 * src/widgets/modest-folder-view.c: (text_cell_data),
399 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
400 (find_inbox_iter): If tinymail tells us that the folder is
401 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
402 This causes the inbox to be selected at startup, fixing part of
403 projects.maemo.org bug NB#56305.
405 * src/modest-ui-dimming-rules.c:
406 (modest_ui_dimming_rules_on_tools_smtp_servers):
407 * src/modest-ui-dimming-rules.h: Added a callback function to dim
408 the SMTP servers menu item.
409 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
410 that the SMTP Servers menu item is dimmed when there are no accounts,
411 as a future version of the UI spec will require. This fixes
412 projects.maemo.org bug NB#56305.
414 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
416 * src/maemo/modest-maemo-utils.c:
417 (modest_maemo_utils_get_supported_secure_authentication_methods):
418 Added label to dialog instead of unreadable title
420 * src/maemo/modest-main-window.c: (sync_accounts_cb),
421 (modest_main_window_new):
422 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
425 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
426 * src/modest-account-mgr.h:
427 Added method to avoid code duplication
429 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
430 (modest_ui_actions_on_send_receive):
431 Use modest_account_mgr_has_accounts
433 2007-06-11 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/easysetup/modest-presets.c:
436 (modest_presets_get_info_server_security): Do not report secure auth
438 * src/modest-protocol-info.c: Use the defines for the gconf key names
439 for secure authentication. This was not working because we were writing
440 Password and reading password, and the check was case sensitive.
441 With this, gmail now works for receiving and sending when created via
444 2007-06-11 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/easysetup/modest-presets.c:
447 (modest_presets_get_info_server_security): Correct the key name for
448 SecureSmtp, because it seems to be case-sensitive.
449 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
450 Do not try to get the 0th notebook page if there are 0 pages, to
453 2007-06-11 Murray Cumming <murrayc@murrayc.com>
455 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
456 Prevent use of the new notification feature for now, because it currently
457 shows one dialog for each new email, which is annoying.
459 2007-06-11 Murray Cumming <murrayc@murrayc.com>
461 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
462 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
463 when no country was selected, so that we show the global ones.
464 * src/maemo/easysetup/modest-presets.c:
465 (modest_presets_get_providers): Return only the global providers, not
466 all providers when mmc=0 was requested.
468 2007-06-11 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
471 (easysetup_provider_combo_box_fill): Remove debug code that showed the
472 provider ID in the combo.
474 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
475 Do not show the page numbers, because it would be confusing when we add
476 the 2 extra pages for the custom setup, when the user chooses the "Other"
477 provider. This fixes projects.maemo.org bug NB#59028
479 * src/modest-init.c: (modest_init_init_core),
480 (modest_init_local_folders):
482 * src/modest-tny-account.c:
483 (modest_tny_account_new_for_local_folders): Do not create default folders
484 for the memory card. This should fix projects.maemo.org bug NB#59328.
486 2007-06-11 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
489 Free the changed_conf_keys string items. They are already freed in the
490 idle handler if that runs first.
492 2007-06-11 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-ui-actions.c:
495 (modest_ui_actions_on_password_requested): Check that the server name
496 is not NULL, because I just saw a password dialog with (null) as the
499 * src/modest-tny-folder.[h|c]: Added
500 modest_tny_folder_is_memory_card_folder().
501 * src/modest-ui-dimming-rules.c:
502 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
503 menu item for memory cards, as per the UI spec (section 7.4). This should
504 fix projects.maemo.org bug NB#59297.
506 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
508 * src/maemo/modest-main-window.c: (sync_accounts_cb):
509 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
510 is another problem with the code, see Murray's comment at line 772)
512 2007-06-08 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
515 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
516 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
517 (load_from_file), (easysetup_country_combo_box_init),
518 (easysetup_country_combo_box_get_active_country_ids),
519 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
520 instead of just one ID, to avoid duplicate country names in the UI.
522 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
523 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
524 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
525 a single ID, avoiding duplicate providers.
526 * src/maemo/easysetup/modest-easysetup-wizard.c:
527 (on_combo_account_country): Adapt to use a list.
529 2007-06-08 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
532 keys changed in the last X seconds.
534 * src/modest-account-mgr.h:
535 * src/modest-account-mgr.c: (on_timeout_notify_changes),
536 (on_key_change), (modest_account_mgr_class_init),
537 (modest_account_mgr_init), (modest_account_mgr_finalize):
538 As the keys are changed, save them in a GSList* and signal that GSList*
539 further every X seconds, to batch changes, to allow us to do just one
540 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
541 bug NB#56941 and other (UI-blocking) delays when changing account settings.
543 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
544 changed signal signature.
546 * src/modest-conf.c: (modest_conf_set_list),
547 (modest_conf_on_change): Reenable notification.
549 (modest_conf_maemo_fake_on_change): Comment out the hack that
550 notified immediately instead of asynchronously.
552 * src/widgets/modest-account-view.h:
553 * src/widgets/modest-account-view.c:
554 (update_account_view): Select the previously-selected account ID,
555 if possible. This fixes projects.maemo.org bug NB#56933.
557 (on_account_changed), (on_account_removed),
558 (modest_account_view_select_account):
560 Remove the block/unblock functions
561 because they were not useful.
563 * src/maemo/modest-account-view-window.c:
564 (on_delete_button_clicked), (on_edit_button_clicked),
565 (on_new_button_clicked): Remove the use of the non-working block/unblock.
567 2007-06-08 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
570 Improve the error dialog to show Incorrect Account Settings, which seems
571 clearer, and say that the internal error message (to be removed from the
572 dialog later) is often misleading.
573 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
575 * src/modest-tny-account.c:
576 (modest_tny_account_new_from_server_account): Uncomment the printf of the
577 URL because this is so useful for debugging on the device.
579 * src/widgets/modest-serversecurity-combo-box.c:
580 (modest_serversecurity_combo_box_fill): Correct a logical ID.
582 2007-06-08 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-mail-operation.c:
585 (modest_mail_operation_send_new_mail):
586 Added a comment about a nasty but apparently harmless message. Details
587 added to the wiki g_warnings() page.
589 2007-06-08 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
592 (modest_tny_send_queue_class_init):
593 Do not use the priv struct because it is empty, to avoid g_warnings
594 about a non-existant priv struct.
596 * src/modest-tny-account-store.c:
597 (modest_tny_account_store_get_server_account),
598 (modest_tny_account_store_get_transport_account_for_open_connection
599 ): Do not try to get transport server accounts for local folders,
600 because they don't have any. This avoids a g_warning().
602 * src/maemo/modest-main-window.c:
603 (modest_main_window_notify_send_receive_initied),
604 (on_configuration_key_changed):
605 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
607 * src/modest-mail-operation.c:
608 (modest_mail_operation_update_account):
609 * src/modest-tny-account-store.h:
610 * src/modest-tny-account.c:
611 (modest_tny_account_get_special_folder),
612 (modest_tny_account_new_for_local_folders),
613 (modest_tny_account_new_for_per_account_local_outbox_folder):
614 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
615 * src/modest-tny-local-folders-account.c:
616 (add_account_folders_to_merged_folder):
617 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
618 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
619 (modest_ui_actions_on_send):
620 * src/widgets/modest-folder-view.c: (update_model):
621 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
622 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
623 modest_tny_account_store_get_tny_account_by_account() to
624 modest_tny_account_store_get_server_account() to make the code clearer.
626 2007-06-07 Marcus Bauer <marcusb@openismus.com>
628 * src/dbus_api/modest-dbus-api.h:
629 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
630 * src/maemo/modest-msg-edit-window.c:
631 (modest_msg_edit_window_attach_file_noninteractive):
632 added g_warning in case the file to be attached does not exist
633 * tests/dbus_api/test_compose_mail.c: (main):
634 removed obsolete comment, added generic files as test case
636 2007-06-07 Murray Cumming <murrayc@murrayc.com>
638 * src/modest-tny-account-store.c: (get_server_accounts):
639 Create the local folders account only once, not once for each outbox, and
640 not only when there are some outboxes.
642 2007-06-07 Murray Cumming <murrayc@murrayc.com>
644 * src/widgets/modest-folder-view.c: (update_model): Comment out some
645 code that is causing a crash at startup. Sergio says that he is fixing this.
647 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
649 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
650 * src/maemo/modest-account-settings-dialog.c:
651 (create_page_outgoing),
652 (modest_account_settings_dialog_set_account_name),
653 (save_configuration):
654 - Fixed handling of the "Use secure authentication" toggle to comply with
655 the ui specification. See also projects.maemo.org bug NB#58400
657 - Restore the Secure connection setting combo correctly when loading
660 * src/maemo/modest-maemo-utils.c:
661 (on_camel_account_get_supported_secure_authentication),
662 (modest_maemo_utils_get_supported_secure_authentication_methods):
663 Fixed a crasher if operation is canceled
665 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
666 (modest_protocol_info_auth_is_secure):
667 * src/modest-protocol-info.h:
669 Added two new methods to determine if a protocol/auth method is secure/encrypted in
670 the sense of the "Use secure authentication" toggle.
672 2007-06-07 Murray Cumming <murrayc@murrayc.com>
674 * src/modest-tny-account-store.h:
675 * src/modest-tny-account-store.c:
676 Added modest_tny_account_store_get_local_folders_account().
678 * src/modest-tny-folder.h:
679 * src/modest-tny-folder.c:
680 (modest_tny_folder_get_account):
681 Added this replacement for tny_folder_get_account() which returns
682 the local-folders account for TnyMergeFolders, to avoid the
683 warning about the unimplemented get_account_func() vfunc().
685 (modest_tny_folder_get_rules),
686 * src/modest-ui-actions.c:
687 (modest_ui_actions_on_folder_selection_changed):
688 * src/modest-mail-operation.c:
689 (modest_mail_operation_remove_folder),
690 (modest_mail_operation_xfer_folder),
691 (modest_mail_operation_rename_folder),
692 (modest_mail_operation_get_msg),
693 (modest_mail_operation_get_msgs_full),
694 (modest_mail_operation_remove_msg),
695 (modest_mail_operation_xfer_msgs),
696 (modest_mail_operation_refresh_folder):
697 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
699 2007-06-07 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
702 (modest_server_account_set_security):
703 * src/modest-defs.h: Add comments explaining that our
704 UI spec means TLS when it says Normal, so these do not look like errors.
706 * src/modest-tny-account.c:
707 (modest_tny_account_new_from_server_account): Use the new tinymail
708 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
709 for TLS. This should fix projects.maemo.org bug NB#58460.
711 2007-06-06 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/easysetup/modest-easysetup-wizard.c:
714 (create_account): Correct the position of the gconf sanity check warning.
715 (on_button_edit_advanced_settings): Show the dialog immediately, instead
716 of using the g_idle_add() hack, because this does not seem to be necessary
717 on osso 1.1. It might even work on Maemo Bora if the problems were actually
718 caused by something other than maemo's gconf.
719 This fixes projects.maemo.org bug #59022.
721 2007-06-06 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-account-mgr-helpers.c:
724 (modest_account_mgr_get_default_account): Do not check that the account
725 exists if there is no default account (NULL), to fix a runtime warning.
727 2007-06-06 Murray Cumming <murrayc@murrayc.com>
729 * src/widgets/modest-folder-view.c: (update_model):
730 Do not unref the treemodel before we have finished with it.
731 This prevents a valgrind warning and an occasional crash at startup.
733 2007-06-06 Marcus Bauer <marcusb@openismus.com>
735 * libmodest-dbus-client/libmodest-dbus-client.h:
736 added libmodest_dbus_client_compose_mail()
737 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
739 added functions needed for SendAsMail() functionality
740 * src/maemo/modest-msg-edit-window.c:
741 (modest_msg_edit_window_attach_file_noninteractive):
742 non interactively attaching files to message edit window
743 * src/widgets/modest-msg-edit-window.h:
744 * tests/dbus_api/Makefile.am:
745 added test_compose_mail.c
746 * tests/dbus_api/test_compose_mail.c: (main):
748 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
750 * src/modest-account-view.c:
751 Fixed bug projects.maemo.org bug NB#59307
753 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
755 * src/maemo/easysetup/modest-easysetup-wizard.c:
756 (get_serverport_incoming), (on_before_next), (create_account):
757 * src/maemo/modest-account-settings-dialog.c:
758 (modest_account_settings_dialog_set_account_name):
759 * src/maemo/modest-maemo-utils.c:
760 (on_camel_account_get_supported_secure_authentication_status),
761 (on_camel_account_get_supported_secure_authentication),
762 (on_secure_auth_cancel),
763 (modest_maemo_utils_get_supported_secure_authentication_methods):
765 Implemented security authentication for settings and easysetup.
767 2007-06-05 Murray Cumming <murrayc@murrayc.com>
769 * src/maemo/modest-main-window.c: (create_details_widget):
770 Show the total size for memory card accounts too, instead of showing
771 the name again. Fixes bug projects.maemo.org bug NB#59307.
773 2007-06-05 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-tny-simple-folder-store.c:
777 * src/modest-tny-simple-folder-store.h: Removed.
779 * src/modest-tny-local-folders-account.h
780 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
781 for the local-folders maildir, with an extra TnyMergedFolder containing
782 the folders of the per-account outbox store accounts.
783 * src/modest-tny-account-store.c: (get_server_accounts):
784 Add the outboxes to the special local folders account after creating it.
786 * src/modest-tny-account.c:
787 (modest_tny_account_new_for_local_folders): Create the derived
788 account when creating the main local-folders account.
790 * src/maemo/modest-main-window.c: (create_details_widget),
791 (modest_main_window_set_contents_style):
792 Adapted to the use of the derived account instead of the folder store.
794 * src/modest-ui-actions.c:
795 (modest_ui_actions_on_folder_selection_changed):
796 * src/modest-ui-dimming-rules.c:
797 (modest_ui_dimming_rules_on_new_folder):
798 * src/widgets/modest-folder-view.c: (text_cell_data),
799 (icon_cell_data), (filter_row), (update_model),
800 (get_cmp_rows_type_pos):
803 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
804 Do not get the priv struct, because no priv struct has been set,
805 to avoid a runtime warning.
807 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
808 #ifelse with #else, to fix a warning, to fix the build.
811 2007-06-05 Christian Kellner <ckellner@openismus.com>
813 * libmodest-dbus-client/libmodest-dbus-client.c:
814 Fix small typo in doc (why do you always see them
815 AFTER committing stuff?)
818 2007-06-05 Christian Kellner <ckellner@openismus.com>
820 * libmodest-dbus-client/libmodest-dbus-client.c:
821 (libmodest_dbus_client_search):
822 Initialize hit list with NULL. Also set folder list
823 to "" if NULL was supplied.
826 2007-06-03 Christian Kellner <ckellner@openismus.com>
828 * libmodest-dbus-client/libmodest-dbus-client.c:
829 (modest_search_hit_list_free):
830 Make it save to call it with NULL.
832 * src/dbus_api/modest-dbus-callbacks.c:
833 * src/modest-search.c:
834 Return full ModestSearchHits as the search result list not TnyHeader
835 since can't be around withouth the correspoding TnyFolder.
837 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
839 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
840 Added currently commented code to check for secure auth
842 * src/maemo/modest-account-settings-dialog.c: (on_response),
843 (save_configuration), (show_ok):
844 Fixed projects.maemo.org bugs NB #59248 and #59251
846 * src/maemo/modest-maemo-utils.c:
847 (on_camel_account_get_supported_secure_authentication_status),
848 (on_camel_account_get_supported_secure_authentication),
849 (modest_maemo_utils_get_supported_secure_authentication_methods):
850 * src/maemo/modest-maemo-utils.h:
851 Moved get_supported_secure_authentication() method here to be able
852 to use it from easysetup wizard.
854 * src/modest-pair.c: (on_pair_compare_as_string):
855 Should compare string with first part of pair and not
856 strcmp pairs which will crash.
858 * src/modest-protocol-info.c:
859 (modest_protocol_info_protocol_is_store):
860 * src/modest-protocol-info.h:
861 Added modest_protocol_info_get_auth_protocol_name()
863 2007-06-03 Armin Burgmeier <armin@openismus.com>
865 * src/modest-mail-operation.c:
866 (modest_mail_operation_get_msgs_full): Set priv->account also when
867 only retrieving a single message. This avoids a crash when canceling
870 (modest_mail_operation_notify_end): Do not explicitely remove the
871 operation from the queue but only emit the progress_changed signal.
872 The queue itself listens to that signal to remove the operation when
873 it is finished. This reduces coupling and removes a potential deadlock
874 when modest_mail_operation_notify_end() is called from the queue
875 itself. If that is a problem performance-wise, I would suggest to
876 implement a status-changed signal or something.
878 * src/modest-mail-operation-queue.c: Make sure to never call a
879 function from another file while the queue is locked. This (hopefully)
880 fixes another deadlock when exiting the application while retrieving
883 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
885 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
886 Fixed build if libogs is not available
888 2007-06-03 Christian Kellner <ckellner@openismus.com>
890 * libmodest-dbus-client/libmodest-dbus-client.h:
891 * libmodest-dbus-client/libmodest-dbus-client.c:
892 (libmodest_dbus_client_delete_message):
893 Implement deletion of messages (Client side).
895 (modest_search_hit_free),
896 (modest_search_hit_list_free):
897 Utility functions to free the result hits.
899 * src/dbus_api/modest-dbus-api.h:
900 * src/dbus_api/modest-dbus-callbacks.c:
902 (modest_dbus_req_handler):
903 Implement deletion of messages (Server side).
905 * tests/dbus_api/test_search.c: (main):
908 * tests/dbus_api/Makefile.am:
909 * tests/dbus_api/test_delete_message:
910 Add little test for the message deletion logic
912 2007-06-03 Armin Burgmeier <armin@openismus.com>
914 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
915 when the operation queue was not empty. projects.maemo.org bug
918 2007-06-03 Armin Burgmeier <armin@openismus.com>
920 * src/widgets/modest-account-view.c
921 (on_account_default_toggled): Toggle default account column
922 explicitely instead of waiting for gconf notification (which is
923 currently ignored). This should fix projects.maemo.org bug NB#56910
924 for now. It should probably be removed when gconf notifications are
927 2007-06-03 Christian Kellner <ckellner@openismus.com>
929 * libmodest-dbus-client/libmodest-dbus-client.c:
930 Removed debugging spew.
932 * src/dbus_api/modest-dbus-callbacks.c:
933 Added debugging info.
935 * src/modest-search.c:
936 (modest_search_all_accounts):
937 Use tny_account_store_get_accounts () on the account store
938 to get all accounts which is the way to get all accounts.
940 * tests/dbus_api/test_search.c: (main):
941 Make it possible to supply the search term on the command line.
943 2007-06-03 Christian Kellner <ckellner@openismus.com>
945 * libmodest-dbus-client/libmodest-dbus-client.c:
946 * libmodest-dbus-client/libmodest-dbus-client.h:
947 Implement searching for mesages over raw dbus. (Client side)
949 * src/dbus_api/Makefile.am:
950 * src/dbus_api/modest-dbus-api.h:
951 * src/dbus_api/modest-dbus-callbacks.c:
952 * src/dbus_api/modest-dbus-callbacks.h:
953 Search framework (Server side). Also implement on_idle_open_message().
955 * src/maemo/modest-platform.c: (modest_platform_init):
956 Prepare for raw dbus/osso rpc interaction.
958 * src/modest-search.h:
959 Changed minsize from unspecific guint to guint32.
961 * src/modest-search.c:
963 Added strange hack which magically made tnymail work.
965 (modest_search_folder),
966 (modest_search_account),
967 (modest_search_all_accounts):
968 Implement helper functions to search all accounts, specific account
971 * tests/dbus_api/Makefile.am:
972 * tests/dbus_api/test_open_message.c:
973 Read url to open from commandline.
975 * tests/dbus_api/test_search.c:
976 Implement small test for dbus search stuff
978 2007-06-02 Armin Burgmeier <armin@openismus.com>
980 * src/maemo/modest-account-settings-dialog.c: Changed window title to
981 include account type and account title. This fixes projects.maemo.org
984 * src/maemo/modest-account-view-window.c: Set a title for the window.
986 2007-06-02 Armin Burgmeier <armin@openismus.com>
988 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
989 incoming and outgoing server name based on email address and server
990 types as long as the names have not been edited manually. This fixes
991 projects.maemo.org bug NB#58671.
993 2007-06-02 Armin Burgmeier <armin@openismus.com>
995 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
996 server type cannot be changed in future to the incoming details page
997 when creating an account. This fixes projects.maemo.org bug NB#59029.
999 2007-06-02 Armin Burgmeier <armin@openismus.com>
1001 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1002 and assigned max width chars so that they wrap instead of being
1003 truncated. Fixes projects.maemo.org bug NB#56126.
1005 2007-06-02 Armin Burgmeier <armin@openismus.com>
1007 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1008 introductory note to the connection specific smtp servers dialog, as
1009 section 8.12 of the email UI specification requires. This fixes
1010 projects.maemo.org bug NB#59212.
1012 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1014 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1015 Check for running mail operations, and offer to cancel them, as per the UI
1016 spec. This fixes projects.maemo.org bug NB#59041 .
1017 However, I suspect that tinymail may still use the network connection
1018 in ways that we cannot detect or cancel. But it should at least adapt to
1019 changes fairly well.
1021 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1023 * src/modest-tny-account-store.c: (recreate_all_accounts),
1024 (get_cached_accounts), (get_server_accounts): Do more sensible
1025 ref-counting of the temporarily-cached outbox accounts list. This seems
1026 to fix a crash when entering the password when the password was wrong.
1028 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1030 * src/gnome/modest-main-window.c: (connect_signals):
1031 * src/modest-tny-account-store.c: (get_password),
1032 (modest_tny_account_store_alert): Added comments and clues and
1033 commented-out code about how we currently fail to deal with connection
1034 errors and wrong passwords, and how we should.
1036 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1038 * src/widgets/modest-retrieve-combo-box.c:
1039 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1040 This fixes projects.maemo.org bug NB#58472 .
1042 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/easysetup/modest-easysetup-wizard.c:
1045 (create_page_complete_easysetup):
1046 (create_page_complete_custom): Correct the last commit,
1047 putting the correct sentences in the correct pages.
1049 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/easysetup/modest-easysetup-wizard.c:
1052 (create_page_complete_custom): Show the second sentence of text
1053 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1056 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1059 Set the leave-on-server conf key by default. This fixes
1060 projects.maemo.org bug NB#59258 .
1062 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/modest-account-view-window.c:
1065 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1066 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1071 * src/maemo/easysetup/modest-easysetup-wizard.c:
1072 (create_caption_new_with_asterisk):
1073 * src/maemo/modest-account-settings-dialog.c:
1074 (create_caption_new_with_asterisk):
1075 Uncomment the code to add the asterisk, because they are no longer in the
1076 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1077 (update_incoming_server_title): Add an asterisk here too.
1079 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1081 * src/maemo/modest-maemo-global-settings-dialog.c:
1082 (current_connection): Check that we are even connected before trying to
1083 get the current connection name, to prevent a warning.
1085 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1086 Change the comments because tny_maemo_conic_device_connect() is now meant to
1088 * src/modest-mail-operation.c:
1089 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1090 make sure we have a connection and fail if we can't connect.
1092 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1094 * src/maemo/modest-main-window.c:
1095 (on_account_store_connecting_finished): Do not try to get the
1096 connection ID if we are not really connected. I am surprised that
1097 this signal handler is called when we are not connected.
1099 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-error.h:
1102 * src/modest-ui-actions.c:
1103 (modest_ui_actions_get_msgs_full_error_handler):
1104 Renamed an enum, added comments, added an enum
1105 for retrieve-limit errors.
1107 * src/modest-mail-operation.c: (foreach_add_item),
1108 (internal_folder_observer_update), (update_account_thread),
1109 (modest_mail_operation_get_msgs_full):
1110 (modest_mail_operation_update_account),
1111 Added comments about how this works, and some code that should
1112 (but does not) check the retrieve-limit. See the TODO comment.
1114 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1117 Initialize help_id to fix the build. Warnings are good.
1119 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1121 * src/widgets/modest-hbox-cell-renderer.c:
1122 (modest_hbox_cell_renderer_append):
1123 * src/widgets/modest-vbox-cell-renderer.c:
1124 (modest_vbox_cell_renderer_append):
1125 Fix the last commit by doing an extra ref.
1127 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1129 * src/widgets/modest-hbox-cell-renderer.c:
1130 (modest_hbox_cell_renderer_append):
1131 * src/widgets/modest-vbox-cell-renderer.c:
1132 (modest_vbox_cell_renderer_append):
1133 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1134 to fix the build with Maemo Bora.
1135 However, there seems to be a remaining crash, probably due to reference
1138 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-tny-account.c:
1141 (modest_tny_account_new_for_local_folders):
1142 Use hildon_file_system_info_async_new() to get a better name for
1143 the memory card account, setting it as the account name.
1144 The timing seems to work, but this is probably
1145 not the best place to do this. See the TODO comment.
1146 * src/maemo/modest-main-window.c: (create_details_widget):
1147 * src/widgets/modest-folder-view.c: (text_cell_data):
1148 Use the tny account name instead of hardcoding a name.
1150 2007-05-30 Christian Kellner <ckellner@openismus.com>
1152 * src/modest-search.c: (modest_search):
1153 Correctly set part_search_func even if we have already parsed
1154 the query and thus a valid OgsTextSearcher object.
1156 2007-05-30 Christian Kellner <ckellner@openismus.com>
1159 Search and check for libogs.
1162 Incooparte the ogs build env.
1164 * src/modest-mime-part-search-stream.c:
1165 * src/modest-mime-part-search-stream.h:
1166 Removed since we do the real searching now in modest-search.c.
1168 * src/modest-search.c:
1169 * src/modest-search.h:
1170 Implement support for ogs. We use that if available and requested
1171 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1172 should now handle the corner case when the search term is spread
1173 across multiple reads.
1174 Also the logic in modest_search () was corrected to search all
1175 requested fields until one is found.
1177 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1179 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1181 * src/modest-init.h:
1182 * src/modest-init.c: Made modest_init_local_folders() take a
1183 path and be public so we can iniitialize maildir folders on
1186 * src/modest-local-folder-info.h:
1187 * src/modest-local-folder-info.c:
1188 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1190 * src/modest-tny-account.c:
1191 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1192 still means the standard local-folders path on the local volume.
1194 * src/modest-tny-account-store.c:
1195 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1196 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1197 all accounts when that happens.
1198 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1199 this too, so it shows up in the treeview.
1201 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-maemo-global-settings-dialog.c:
1204 (current_connection):
1205 * src/widgets/modest-global-settings-dialog.c:
1206 (current_connection_default):
1207 Use the enum values instead of 0, 1 and -1,
1208 to make the code clearer.
1210 * src/modest-account-mgr-helpers.c:
1211 (modest_account_mgr_get_connection_specific_smtp): Make this code
1214 * src/modest-runtime.h:
1215 * src/modest-runtime.c:
1216 Added modest_runtime_remove_all_send_queues().
1217 * src/maemo/modest-main-window.c:
1218 (on_account_store_connecting_finished): Recreate the send queues,
1219 using the appropriate transport accounts for this new connection.
1220 Some futher adapting might be needed if the old send queues are not
1221 automatically stopped at this point.
1223 * src/modest-tny-account-store.c: (get_server_accounts):
1224 Create the connection-specific transport accounts, so that they can
1225 be found later by their ID.
1227 * src/modest-tny-account.h:
1228 * src/modest-tny-account.c:
1229 Added modest_tny_account_new_from_server_account_name().
1230 modest_tny_account_new_from_server_account(): Do not create the
1231 send queues here, because they will be
1232 recreated anyway when the connection changes for the first time.
1234 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-local-folder-info.h:
1237 * src/modest-local-folder-info.c:
1238 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1239 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1240 tbox_folder): Take a modest account name instead of a server TnyAccount,
1241 so we can have per-modest-account rather than per-transport-account
1243 We must make sure that we change or recreate the exisitng send queues
1244 when the connection changes for connection-specific transport accounts.
1246 * src/modest-tny-account-store.c:
1247 (create_per_account_local_outbox_folders): Create outboxed per modest
1248 account, not per transport account.
1250 * src/modest-tny-account.h:
1251 * src/modest-tny-account.c:
1252 (modest_tny_account_get_special_folder): For outboxes, get the
1253 parent modest account name. The account is ignored for other folders.
1254 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1255 modest account name rather than a server TnyAccount.
1257 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1259 * src/modest-tny-account.c:
1260 (modest_tny_account_new_from_server_account):
1261 Call modest_runtime_get_send_queue() immediately after creating transport
1262 accounts, so that they start trying to send email from the outbox as soon
1263 as possible at startup. This is probably what we want.
1265 * src/modest-mail-operation.c: (update_account_thread):
1266 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1267 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1268 * src/modest-tny-send-queue.h:
1269 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1270 (modest_ui_actions_on_send):
1271 Added comments about how sending works, though it needs some more work.
1273 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1275 * src/modest-tny-account.c:
1276 (modest_tny_account_get_special_folder): Add TODO because this fails when
1277 the network is busy.
1278 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1279 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1280 Do not try to show this window when there is no active account. The UI
1281 specs does not tell us what to do in this case.
1283 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/Makefile.am:
1288 * src/widgets/Makefile.am: Some dist fixes.
1290 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1292 * src/maemo/modest-connection-specific-smtp-window.c:
1293 (on_button_edit): Make the code clearer, to prevent a double free.
1295 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1297 * src/maemo/modest-account-settings-dialog.c:
1298 (modest_account_settings_dialog_set_account_name),
1299 Check the connection-specific smtp servers checkbox if there are any.
1301 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1302 (modest_connection_specific_smtp_edit_window_init):
1303 Start with a suitable port number.
1305 * src/modest-account-mgr-helpers.h:
1306 * src/modest-account-mgr-helpers.c: Added
1307 modest_account_mgr_get_has_connection_specific_smtp().
1309 (modest_account_mgr_set_connection_specific_smtp),
1310 (modest_account_mgr_remove_connection_specific_smtp),
1311 (modest_account_mgr_get_has_connection_specific_smtp),
1312 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1313 connection-specific smtp server accounts in the account, rather than
1314 the server account conf dir.
1316 This fixes bug projects.maemo.org bug NB#58263 .
1318 * src/modest-tny-account-store.c:
1319 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1320 if there are no server accounts yet, to prevent an infinite loop when there
1321 are no accounts. Document that one must be called before the other.
1323 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1325 * src/modest-account-mgr-helpers.c:
1326 (modest_account_mgr_get_default_account): Make sure that at least
1327 one account is always the default, if there are any enabled accounts.
1328 This is just a sanity check that shouldn't be necessary.
1330 * src/modest-account-mgr-priv.c:
1331 (_modest_account_mgr_account_from_key): Unescape the conf key to
1332 get the real account name. For instance, this is an issue if a space
1333 was in the account name, which can happen because the account name
1334 is generated from the display name.
1335 (_modest_account_mgr_get_account_keyname): Always escape the
1337 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1338 Unescape the conf keys to get the real account names.
1340 For instance, previously the is-default radio button in the accounts
1341 list was not checked for any accounts at first. This fixes that,
1342 and might fix several similar bugs.
1344 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1347 Removed some debug printfs.
1349 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1351 Modest on-disk outbox directories are now here, for instance:
1352 $HOME/.modest/outboxes/<account-id-1>/outbox
1353 $HOME/.modest/outboxes/<account-id-2>/outbox
1355 $HOME/.modest/local-folders/outbox
1356 so we can have a separate outbox for each account.
1357 But they are shown as one outbox in the GtkTreeView, by using a
1358 TnyMergeFolder in a ModestTnySimpleFolderStore.
1361 * src/modest-tny-simple-folder-store.c:
1362 * src/modest-tny-simple-folder-store.h:
1363 Added ModestTnySimpleFolderStore, used to contain folders from
1364 other folder stores, such as other accounts.
1366 * src/modest-tny-outbox-account.h:
1367 * src/modest-tny-outbox-account.c:
1368 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1369 used for the per-account local outbox folders.
1371 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1372 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1373 only use this (internally) now for the non-outbox local folders.
1375 * src/modest-init.h:
1376 * src/modest-init.c: Added modest_init_one_local_folder(), for
1377 setting up the directory structure for each local folder.
1379 * src/modest-local-folder-info.c:
1380 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1381 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1383 * src/modest-local-folder-info.h:
1384 * src/modest-tny-account-store.c: (on_account_removed),
1385 (on_account_changed), (create_per_account_local_outbox_folders),
1386 (get_server_accounts), (modest_tny_account_store_get_accounts),
1387 (modest_tny_account_store_get_tny_account_by_account),
1388 (modest_tny_folder_store_is_virtual_local_folders):
1390 * src/modest-tny-account.h:
1391 * src/modest-tny-account.c:
1392 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1393 to create an on-disk per-account local outbox folder for each
1395 (create_per_account_local_outbox_folders): Create a local outbox folder
1396 for each transport account.
1397 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1398 for all local folders.
1400 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1401 instead of using g_object_get/set() directly. It is clearer.
1403 (modest_tny_folder_store_get_message_count),
1404 (modest_tny_folder_store_get_local_size
1405 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1406 because we now use these with non-acount folder stores.
1408 (modest_tny_account_get_special_folder),
1409 (modest_tny_account_new_from_server_account),
1410 (modest_tny_account_new_from_account):
1411 (recurse_folders): Adjust to the new outbox system.
1413 * src/modest-tny-folder.h:
1414 * src/modest-tny-folder.c:
1415 (modest_tny_folder_is_local_folder),
1416 (modest_tny_folder_get_local_folder_type),
1417 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1419 * src/widgets/modest-main-window.h:
1420 * src/maemo/modest-main-window.c: (create_details_widget),
1421 (modest_main_window_set_contents_style): Show details for any folder store,
1424 (modest_tny_folder_get_rules):
1425 Remove the const. C does not support constness enough for this.
1427 * src/modest-ui-actions.c:
1428 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1429 make all outboxes appear as one, in the usual local-folders tree node.
1431 (set_active_account_from_tny_account),
1432 (modest_ui_actions_on_folder_selection_changed):
1433 * src/widgets/modest-folder-view.c: (text_cell_data),
1434 (icon_cell_data), (filter_row),
1435 (add_account_folders_to_merged_folder),
1436 (add_account_folders_to_simple_folder_store), (),
1437 (get_cmp_rows_type_pos), (cmp_rows),
1438 (modest_folder_view_set_account_id_of_visible_server_account):
1439 Adjust to the new outbox system, using generic folder stores and folders
1440 in the GtkTreeModel.
1442 2007-05-23 Christian Kellner <ckellner@openismus.com>
1444 * src/modest-mail-operation.c:
1445 (modest_mail_operation_update_account):
1446 Use info->max_size instead of unintialized local var [small
1447 build fix]. (Added TODO to review that change since I don't
1450 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1452 * libmodest-dbus-client/libmodest-dbus-client.c:
1453 (libmodest_dbus_client_compose_mail): function added
1454 * src/dbus_api/modest-dbus-api.h:
1455 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1456 (on_compose_mail): Implementation of the SendAsMail functionality
1458 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-account-mgr.c:
1461 (modest_account_mgr_add_server_account): Set the secure-connection
1462 conf key for transport accounts as well as store accounts. I don't know
1463 why the if was there. For instance, this makes sure that we use SSL
1464 for the gmail preset from the easysetup wizard.
1466 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1468 * src/gnome/modest-main-window.c:
1469 (on_account_store_connecting_finished), (connect_signals):
1470 * src/maemo/modest-main-window.c:
1471 (on_account_store_connecting_finished), (connect_signals),
1472 (modest_main_window_new):
1473 Handle TnyAccountStore::connecting-finished instead of
1474 TnyDevice::connection-changed, because we cannot actually perform
1475 operations on accounts until TnyAccountStore has itself responded to
1476 the TnyDevice::connection-changed signal. This prevents a GError from
1478 Do not try to update at startup, because we (at least on scratchbox)
1479 already do an update at startup when the device goes online.
1480 This prevents a GError from tinymail.
1481 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1482 Added TODO about stopping simultaneous operations.
1484 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1486 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1487 * src/modest-mail-operation-queue.c:
1488 (modest_mail_operation_queue_remove):
1489 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1490 about where they happened.
1492 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1494 * src/modest-ui-actions.c:
1495 (modest_ui_actions_on_password_requested): Make sure that the remember
1496 output parameter is always TRUE.
1498 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1500 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1501 Show a OK/Cancel dialog if the error is a question, though we still do not
1502 know anything more about what we are asking the user.
1503 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1504 Fix an uninitialized variable (helper). This is a logic error, however.
1506 2007-05-21 Christian Kellner <ckellner@openismus.com>
1508 * src/modest-search.h:
1509 Correct bit shifting in the ModestSearchFlags enum.
1511 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1513 * src/modest-tny-account.c:
1514 (modest_tny_account_new_from_server_account): Do not use the lsub and
1515 check-all hard-coded IMAP options when using POP.
1517 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-tny-account.c:
1520 (modest_tny_account_new_from_server_account):
1521 Use NULL for the secure-auth method for POP when Password auth has been
1522 specified by the user, as we already do for IMAP. "auth=Login" causes
1523 an error from camel or the server.
1525 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/modest-account-settings-dialog.c:
1528 (create_page_account_details),
1529 (modest_account_settings_dialog_set_account_name):
1530 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1531 for the leave-on-server checkbox, rathr than just the checkbox, when
1532 the protocol is not POP.
1534 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1536 * src/widgets/modest-account-view.c:
1537 * src/widgets/modest-account-view.h:
1538 Added modest_account_view_select_account() which will be useful later
1539 to asynchronously re-select the edited account.
1541 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1543 * src/maemo/modest-account-settings-dialog.c:
1544 (modest_account_settings_dialog_set_account_name):
1545 Automatically choose the port numbers based on the secure authentication
1546 methods, if they have not been chosen before.
1547 This fixes projects.maemo.org bug NB#56273 .
1549 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/modest-main-window-ui.h:
1552 * src/modest-ui-actions.c:
1553 * src/modest-ui-actions.h:
1554 Connect the Tools/SMTP Servers menu item to
1555 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1556 SMTP servers dialog, as in the UI specification and saves changes when it
1557 is closed. This fixed projects.maemo.org bug NB#56305 .
1559 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1561 * src/maemo/modest-connection-specific-smtp-window.c:
1562 (modest_connection_specific_smtp_window_init):
1563 Use gtk_window_set_default_size() to make this window big enough, so
1564 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1566 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1570 (modest_connection_specific_smtp_edit_window_init),
1571 Do not try to connect to a combobox signal before the combobox exists.
1572 This fixes the cras in projects.maemo.org bug NB#56288 .
1573 (modest_connection_specific_smtp_edit_window_get_settings):
1574 Remove the server_account_name parameter which was being checked for NULL
1575 though it was not used.
1577 * src/maemo/modest-connection-specific-smtp-window.c:
1578 (modest_connection_specific_smtp_window_fill_with_connections),
1579 (on_button_edit), (modest_connection_specific_smtp_window_init):
1580 Correct the number of treemodel columns to prevent a warning.
1581 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1582 libconic does not work.
1584 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account.c:
1587 (modest_tny_account_new_from_server_account):
1588 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1589 SMTP when "None" was chosen by the user. However, with my SMTP server that
1590 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1593 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1595 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1596 to explain the memory management issue with the ID in the ModestPair.
1598 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1599 (add_sending_page), (modest_account_assistant_finalize):
1600 * src/gnome/modest-gnome-global-settings-dialog.c:
1601 (create_updating_page), (create_composing_page):
1602 * src/gnome/modest-msg-edit-window.c: (get_transports),
1603 (init_window), (modest_msg_edit_window_finalize),
1604 (modest_msg_edit_window_get_msg_data):
1605 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1606 * src/gnome/modest-transport-widget.c:
1607 (modest_transport_widget_finalize), (smtp_configuration):
1608 * src/maemo/modest-maemo-global-settings-dialog.c:
1609 (create_updating_page), (create_composing_page):
1610 * src/maemo/modest-msg-edit-window.c: (get_transports),
1611 (init_window), (modest_msg_edit_window_finalize),
1612 (modest_msg_edit_window_get_msg_data),
1613 (modest_msg_edit_window_free_msg_data):
1614 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1615 (modest_store_widget_finalize):
1616 * src/maemo/modest-transport-widget.c:
1617 (modest_transport_widget_finalize), (smtp_configuration):
1618 * src/modest-main.c: (send_mail):
1619 * src/widgets/modest-combo-box.h:
1620 * src/widgets/modest-global-settings-dialog-priv.h:
1621 * src/widgets/modest-global-settings-dialog.c:
1622 (modest_global_settings_dialog_finalize):
1623 * src/widgets/modest-msg-edit-window.h:
1624 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1625 as long as the combo box, to prevent use of freed memory for the ID.
1627 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1629 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1630 get_accounts(), to make this clearer. Do not check for the enabled gconf
1631 key, because we do not use this for server accounts (at least, not yet).
1632 This allows us to send email again.
1634 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/modest-platform.c:
1637 (on_modest_conf_update_interval_changed), (modest_platform_init):
1638 Only respond to this particular key change. All these strcmp()s cannot be
1641 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-maemo-global-settings-dialog.c:
1644 (current_connection): Prevent a crash in scratchbox when
1645 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1646 * src/maemo/modest-platform.c:
1647 (on_modest_conf_update_interval_changed), (modest_platform_init):
1648 Get the update interval from gconf and reset it when the gconf key changes.
1650 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1652 * src/modest-protocol-info.c:
1653 * src/modest-protocol-info.h: Adde enum-specific get functions,
1654 instead of using a ModestProtocolType enum parameter.
1656 * src/gnome/modest-account-assistant.c:
1657 * src/gnome/modest-store-widget.c:
1658 * src/gnome/modest-store-widget.h:
1659 * src/gnome/modest-transport-widget.c:
1660 * src/gnome/modest-transport-widget.h:
1661 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1662 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1663 * src/maemo/easysetup/modest-easysetup-wizard.c:
1664 * src/maemo/modest-account-settings-dialog.c:
1665 * src/maemo/modest-account-settings-dialog.h:
1666 * src/maemo/modest-store-widget.c:
1667 * src/maemo/modest-store-widget.h:
1668 * src/maemo/modest-transport-widget.c:
1669 * src/maemo/modest-transport-widget.h:
1670 * src/modest-account-mgr-helpers.c:
1671 * src/modest-account-mgr-helpers.h:
1672 * src/modest-account-mgr.c:
1673 * src/modest-account-mgr.h:
1674 * src/modest-tny-account.c:
1675 * src/modest-tny-folder.c:
1676 * src/widgets/modest-account-view.c:
1677 * src/widgets/modest-retrieve-combo-box.c:
1678 * src/widgets/modest-retrieve-combo-box.h:
1679 * src/widgets/modest-secureauth-combo-box.c:
1680 * src/widgets/modest-serversecurity-combo-box.c:
1681 * src/widgets/modest-serversecurity-combo-box.h:
1682 * tests/check_account-mgr.c:
1683 Use the specific functions, and use the re-renamed enum values for GNOME too.
1685 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-pair.h:
1688 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1689 so we can get the second based on the first.
1691 * src/maemo/modest-account-settings-dialog.h:
1692 * src/maemo/modest-account-settings-dialog.c:
1693 Added get_supported_secure_authentication_methods(), though it is mostly
1694 commented-out for now until the necessary API is committed to tinymail.
1695 (modest_account_settings_dialog_set_account_name),
1696 (save_configuration): Request the supported authentication methods from the
1697 server, so we can choose a working method.
1699 * src/modest-tny-account-store.h:
1700 * src/modest-tny-account-store.c:
1701 (modest_tny_account_store_get_session): Rename from
1702 tny_account_store_get_session().
1704 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1706 * src/modest-protocol-info.h: Split the ModestProtocol enum
1707 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1708 There was no need to have these unrelated values in one enum.
1710 * src/: many files: Adapted to changed enum. This makes the code a bit
1711 clearer, and the compiler could catch some errors.
1713 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1716 Show the detailed internal camel error message when an error happens
1717 during the configuration, so that our testers can give us more clues.
1718 For instance, in projects.maemo.org bug NB#56910 .
1720 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-tny-account.c:
1723 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1724 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1726 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1728 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1729 * src/maemo/modest-account-settings-dialog.c:
1730 (modest_account_settings_dialog_set_account_name),
1731 (save_configuration): For the incoming secure authentication checkbox,
1732 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1733 the UI specification. PLAIN does not seem to be supported for most IMAP
1734 servers anyway, and I am not sure what it would mean.
1735 However, we probably need to discover which of the secure-authentication
1736 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1737 * src/modest-account-mgr-helpers.c:
1738 (modest_account_mgr_get_server_account_data):
1740 * src/modest-tny-account.c:
1741 (modest_tny_account_new_from_server_account):
1742 Use tny_account_set_mech() to set secure-authentication methods,
1743 with some special-casing for IMAP, based on my observations of how
1746 * src/modest-account-mgr-helpers.h:
1747 * src/modest-account-mgr.c:
1748 * src/modest-defs.h: Comment that the URI is only used for local folders.
1750 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1752 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1753 parameter const, just to be neat.
1754 * src/modest-text-utils.c: (modest_text_utils_inline):
1755 End g_strconcat() with NULL, as its documentation says. This is almost
1756 certainly the cause of my crash at startup on the device. Interestingly,
1757 valgrind doesn't tell us about these errors.
1759 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1761 * scripts/build-packages: Added more precise comments about how to use
1762 this script, though I still get this error:
1763 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1764 error building tinymail
1766 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/modest-main-window.c: (on_account_update):
1769 Very slight cleanup, hoping to make it simpler to discover what causes
1770 a crash here sometimes.
1772 * src/modest-tny-account.c:
1773 (modest_tny_account_new_from_server_account): Set the port. Added
1774 comments about the options and a TODO comment because I need to find out
1775 how to specify the secure authentication method.
1777 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1779 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1780 changed CFlags paths form modest to libmodest
1782 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-account-mgr-helpers.c:
1785 (modest_account_mgr_get_server_account_data),
1786 (modest_account_mgr_free_server_account_data):
1787 * src/modest-account-mgr-helpers.h:
1788 * src/modest-account-mgr.c:
1789 (modest_account_mgr_add_server_account):
1790 * src/modest-defs.h:
1791 * src/modest-tny-account.c:
1792 (modest_tny_account_new_from_server_account):
1793 Determine the options for tny_camel_account_add_option() here,
1794 based on the settings, rather than storing them directly in gconf.
1796 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1798 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1799 Show a more friendly error dialog now that we expect (from the tinymail
1800 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1802 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1804 * src/maemo/modest-main-window.c: (on_account_update): Check that
1805 account_name is not NULL, to prevent a crash at startup that I am
1806 seeing on the N800. I do wonder why it is NULL.
1808 * src/maemo/easysetup/modest-easysetup-wizard.c:
1809 (create_page_user_details):
1810 * src/maemo/modest-account-settings-dialog.c:
1811 (create_page_user_details), (create_page_outgoing):
1812 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1813 (modest_connection_specific_smtp_edit_window_init):
1814 * src/modest-ui-actions.c:
1815 (modest_ui_actions_on_password_requested):
1816 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1817 might do something useful with the on-screen keyboard.
1819 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/modest-main-window.c: (on_account_update):
1822 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1823 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1825 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-tny-account-store.c: (on_account_changed):
1828 Correct the signature of this signal handler.
1830 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1833 Show a HildonNote instead of a GtkDialog for Maemo.
1835 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-account-view.h:
1838 * src/widgets/modest-account-view.c: (on_account_changed),
1839 (on_account_removed). Added a boolean flag, set/unset by
1840 modest_account_view_block_conf_updates(),
1841 modest_account_view_unblock_conf_updates() to prevent unnecessary
1842 updates, but this is not very useful because the gconf notifications are
1843 so delays (maybe only on Maemo Bora).
1844 So auto-updating is turned off, and these functions do an explicit
1845 update when necessary.
1846 However, something else is still doing too much work when adding/removing
1847 accounts, probably in another part of the application.
1849 * src/maemo/modest-account-view-window.c:
1850 (on_delete_button_clicked), (on_edit_button_clicked),
1851 (on_new_button_clicked): Use the new functions.
1853 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-account-mgr-helpers.c:
1856 (modest_account_mgr_set_first_account_as_default):
1857 Sort the list of names alphabetically-by-title, so we choose the first one
1859 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1860 alphabetically by the title.
1862 This fixes projects.maemo.org bug NB#56418 .
1864 * src/modest-account-mgr-priv.c:
1865 (_modest_account_mgr_account_from_key):
1866 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1867 avoid a valgrind error, and possible random behaviour.
1869 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1871 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1872 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1873 tinymail documentation to say that this can be expected.
1874 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1875 pretty, and should not happen, but I would prefer to know when it does.
1877 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1879 * configure.ac: When using the older hildon version, probably on Bora,
1880 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1882 * src/widgets/modest-attachment-view.c:
1883 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1886 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1888 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1889 Implemented the prototype. Can be tested with
1890 tests/dbus_api/test_open_message:
1892 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-tny-account-store.c:
1895 (modest_tny_account_store_instance_init), (get_password):
1896 * src/modest-ui-actions.c:
1897 (modest_ui_actions_on_password_requested):
1898 Do not store the password in gconf, because this function is called
1899 for non-remembered passwords. Actually use the cached (in the hash map)
1900 password instead of releasing it.
1901 The password will now not be remembered if it is asked via the protected
1902 password dialog, as per the UI spec.
1904 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1906 * src/modest-defs.h:
1907 * src/modest-account-mgr-helpers.h:
1908 * src/modest-account-mgr-helpers.c:
1909 Added modest_server_account_get_username_has_succeeded(),
1910 modest_server_account_set_username_has_succeeded().
1911 (modest_server_account_set_username),
1912 Reset the has-succeeded flag if the username changes.
1914 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1915 * src/maemo/modest-connection-specific-smtp-window.c:
1916 (modest_connection_specific_smtp_window_save_server_accounts):
1917 Use modest_server_account_set_username() instead of using
1918 modest_conf_set_string() directly, so that the has-succeeded flag is always
1921 * src/modest-ui-actions.c:
1922 (modest_ui_actions_on_password_requested): Dim the username entry if
1923 the username has ever worked, as per the UI spec.
1925 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1927 * src/modest-tny-account-store.c: (get_password):
1928 * src/modest-ui-actions.c:
1929 (modest_ui_actions_on_password_requested):
1930 Allow the username to be changed too, though there is more work to
1931 be done on exactly how this behaves.
1933 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1935 * src/modest-account-mgr-helpers.h:
1936 * src/modest-account-mgr-helpers.c:
1937 Added modest_account_mgr_get_display_name(),
1938 modest_server_account_get_username(),
1939 modest_server_account_set_username(),
1940 modest_server_account_set_password(),
1941 modest_server_account_get_hostname() functions so we do not need to
1942 use the conf API directly.
1944 * src/maemo/modest-main-window.c: (connect_signals):
1945 Actually connect ot the ModestAccountStore::request-password signal,
1946 so that we show the dialog when the password is requested by Tinymail,
1947 for isntance if it is empty.
1949 * src/modest-marshal.list:
1950 * src/modest-tny-account-store.c:
1951 (modest_tny_account_store_class_init), (get_password),
1952 (modest_tny_account_store_alert):
1953 * src/modest-tny-account-store.h:
1954 * src/modest-ui-actions.h:
1955 * src/modest-ui-actions.c:
1956 (modest_ui_actions_on_password_requested):
1957 Change the signal parameters, so it is obvious that we are providing
1958 the non human-readable server name, and receiving both the username
1959 and password, though changing of the username is not yet implemented.
1960 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1961 for the GNOME version.
1963 This should fix the projects.maemo.org bug NB#56209, though it does not
1964 work on Bora, because the gconf_client_get() for the password fails
1965 immediately after we save it with gconf_client_set().
1967 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1970 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1971 caused an undefined symbol error:
1972 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1974 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-tny-account-store.c:
1977 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1978 using a GError instead of a string message, so we can translate it in
1981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/modest-address-book.c:
1984 (modest_address_book_check_names):
1985 * src/maemo/modest-msg-view-window.c:
1986 (modest_msg_view_window_clipboard_owner_change):
1987 * src/modest-init.c: (modest_init_init_ui):
1988 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1989 (update_folders_cb), (modest_mail_operation_update_account):
1990 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1991 (modest_ui_actions_on_msg_attachment_clicked),
1992 (modest_ui_actions_on_msg_recpt_activated):
1993 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1994 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1995 (modest_msg_view_search_next):
1996 * src/widgets/modest-recpt-editor.c:
1997 (modest_recpt_editor_on_button_release_event),
1998 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1999 g_message(). At this point we should only be seeing interesting errors on
2000 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2002 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2004 (modest_wizard_dialog_force_title_update):
2005 * src/maemo/easysetup/modest-wizard-dialog.h:
2006 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2007 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2008 can update the title when appropriate. Otherwise the title is wrong if the
2009 pages are added after adding the notebook to the dialog.
2010 This must be a problem in HildonWizardDialog too.
2011 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2013 * src/maemo/easysetup/modest-easysetup-wizard.c:
2014 (create_subsequent_customsetup_pages),
2015 (create_subsequent_easysetup_pages):
2016 Call modest_wizard_dialog_force_title_update() so that the title is
2017 correct even with GTK+ < 2.10.
2018 This fixes projects.maemo.org bug NB#56145 .
2020 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/modest-platform.c:
2023 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2024 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2027 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2029 * src/widgets/modest-window.h:
2030 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2031 and modest_window_save_state(), which invokes it.
2033 * src/widgets/modest-window-mgr.h:
2034 * src/widgets/modest-window-mgr.c:
2035 Added modest_window_mgr_save_state_for_all_windows(), which calls
2036 the save_state vfunc on all registered windows, if implemented.
2038 * src/gnome/modest-msg-edit-window.c:
2039 * src/gnome/modest-msg-view-window.c:
2040 * src/maemo/modest-msg-edit-window.c:
2041 * src/maemo/modest-msg-view-window.c:
2042 * src/maemo/modest-main-window.c:
2043 Specify the existing save_settings functions as implementations of
2044 ModestWindow::save_state_func().
2046 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2047 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2048 enabling hibernation, for instance.
2050 We may need to do the same thing for restoring settings.
2053 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2055 * src/widgets/modest-window-mgr.c:
2056 * src/widgets/modest-window-mgr.h:
2057 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2058 modest_window_mgr_get_hibernation_is_prevented().
2060 * src/maemo/modest-main-window.c:
2061 (on_hildon_program_is_topmost_notify): Prevent hibernation
2062 (possible when the application goes to the background in the WM),
2063 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2065 * src/maemo/easysetup/modest-easysetup-wizard.c:
2066 (modest_easysetup_wizard_dialog_init):
2067 * src/maemo/modest-account-settings-dialog.c:
2068 (modest_account_settings_dialog_init):
2069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2070 (modest_connection_specific_smtp_edit_window_init):
2071 * src/maemo/modest-connection-specific-smtp-window.c:
2072 (modest_connection_specific_smtp_window_init):
2073 * src/maemo/modest-signature-editor-dialog.c:
2074 (modest_signature_editor_dialog_init):
2075 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2076 prevent hibernation while any of these account settings dialogs are open.
2078 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2080 * src/maemo/Makefile.am:
2081 * src/maemo/modest-osso-state-saving.c:
2082 * src/maemo/modest-osso-state-saving.h: Added
2083 modest_osso_load_state() and modest_osso_save_state() though they do
2084 nothing now. They should iterate through all the open windows and load/save
2086 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2087 save state when closing.
2089 * src/maemo/modest-main-window.c:
2090 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2091 Add a notification handler for the HildonProgram::is-topmost property,
2092 so we can allow hibernation when the application goes into the background.
2093 But we still need to detect when the accounts setup windows are open so
2094 we can stop hibernation when they are open.
2095 To do this, I also added the main window the HildonProgram. This might have
2096 other side-effects/benefits, and should maybe be done for other windows.
2098 * src/maemo/modest-osso-autosave-callbacks.h:
2099 * src/maemo/modest-osso-autosave-callbacks.c:
2100 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2101 though it does not do anything yet, and we might never need this to do
2102 anything. For instance, we already save drafts.
2104 * src/maemo/modest-platform.c: (modest_platform_init):
2105 Specify the libosso auto-save callback.
2107 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2109 * src/maemo/modest-platform.c:
2110 (modest_platform_set_update_interval):
2111 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2112 aparently stays valid between application instances, so we can use this
2113 to remove and reset it later. According to a maemo-developers email from
2116 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2118 * configure.ac: Depend on libalarm for Maemo.
2120 * src/dbus_api/modest-dbus-api.h:
2121 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2122 (on_send_receive), (modest_dbus_req_handler):
2123 Handle a SEND_RECEIVE D-Bus method.
2125 * libmodest-dbus-client/libmodest-dbus-client.c:
2126 (libmodest_dbus_client_send_and_receive):
2127 * libmodest-dbus-client/libmodest-dbus-client.h:
2128 Add C convenience functions for calling the new D-Bus method.
2130 * src/modest-platform.h:
2131 * src/gnome/modest-platform.c:
2132 * src/maemo/modest-platform.c:
2133 Added modest_platform_set_update_interval(), which uses the
2134 alarmd API on Maemo.
2135 (modest_platform_init),
2136 Call modest_platform_set_update_interval(), using a hard-coded
2137 interval for now (until the global settings dialog is implemented),
2138 though I am not sure that this makes sense yet.
2140 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2142 * src/dbus_api/modest-dbus-callbacks.c:
2143 (modest_osso_cb_hw_state_handler):
2144 * src/dbus_api/modest-dbus-callbacks.h:
2145 * src/maemo/modest-platform.c: (modest_platform_init):
2146 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2147 in case this has some effect on the ability for Maemo to ping the
2150 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2152 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2153 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2154 warning. It is probably a logic error, but I need to fix the build.
2156 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2158 * src/modest-account-mgr.h:
2159 * src/modest-account-mgr.c:
2160 (modest_account_mgr_account_names): Add a gboolean enabled_only
2161 parameter, so we can get lists of onlt the enabled accounts.
2163 (modest_account_mgr_add_account),,
2164 (modest_account_mgr_account_with_display_name_exists):
2165 * src/maemo/modest-msg-edit-window.c: (get_transports):
2166 * src/modest-account-mgr-helpers.c:
2167 (modest_account_mgr_set_first_account_as_default):
2168 * src/modest-init.c: (init_default_account_maybe):
2169 * src/modest-tny-account-store.c: (get_accounts):
2170 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2171 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2172 * tests/check_account-mgr.c: (START_TEST):
2173 Provide the extra parameter, as appropriate.
2175 * src/widgets/modest-account-view.c: (update_account_view):
2176 Do not show disabled accounts (meaning that there is no way to
2177 enable/disable accounts in the UI (the feature is not in our UI
2178 specification), so we can use this internally only to mark unfinished
2179 or temporary account data.
2181 * src/maemo/easysetup/modest-easysetup-wizard.c:
2182 (create_account): Add boolean enable parameter, so we can specify FALSE
2183 to create the temporary account.
2184 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2185 (on_before_next): When finishing, when there is a temporary account, just
2187 Also, use a timeout to delay the showing of the dialog until gconf is likely
2188 to return correct information, due to a maemo gconf bug that is fixed in
2189 osso 1.1, but not yet in Bora.
2190 However, the dialog stays on screen after it is destroyed.
2192 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2193 for invalid data when cancelling. Use a hildon note instead of a dialog
2194 to complain about invalid data. Do not show the account-saved note if the
2195 account is disabled (a temporary account that will not really be saved for use
2198 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-account-mgr-helpers.h:
2201 * src/modest-account-mgr-helpers.c:
2202 Added modest_account_mgr_unset_default_account(),
2203 Added modest_account_mgr_set_first_account_as_default().
2205 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2206 If it was the default account, unset the default account name.
2208 * src/maemo/modest-account-view-window.c:
2209 (on_delete_button_clicked): If it was the default account,
2210 set the first remaining account as the default instead.
2212 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2213 a NULL account or a NULL default account, to prevent a crash. This should
2214 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2217 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2219 * src/widgets/modest-recpt-editor.c:
2220 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2221 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2222 TODO comment for this. This fixes the build.
2224 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2225 be the best place for it. This will in future update all auto-update accounts,
2226 rather than just the current/default account, when that gconf key exists.
2227 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2228 if there are no accounts, before calling do_send_receive().
2229 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2231 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2232 * src/maemo/modest-main-window-ui.h:
2233 * src/maemo/modest-main-window.c: (on_connection_changed),
2234 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2235 directly, becaue the signal handler does more.
2237 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-account-mgr-helpers.c:
2240 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2241 for the case that the account does not exist.
2243 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2244 (equivalent to the modest account name) rather than the tinymail account name
2245 (equivalent to the modest account title - human readable) to get the account data.
2246 Check for null account data to prevent the crash, and add a TODO comment saying that
2247 this needs fixing because it is using the server account name instead of the account name.
2249 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2252 * src/maemo/modest-account-settings-dialog.c: (show_error),
2254 Use hildon_note_new_information() for informative and error messages,
2255 which seems to be expected for Maemo applications (no documentation that I know of
2256 says this). I am surprised that there is no distinction between info and error
2259 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2261 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2262 it is easy to find where this is used.
2264 * src/maemo/easysetup/modest-easysetup-wizard.c:
2265 (create_page_welcome), (create_page_account_details),
2266 (create_page_user_details), (create_page_complete_easysetup),
2267 (create_page_custom_incoming), (create_page_custom_outgoing),
2268 (create_page_complete_custom):
2269 * src/maemo/modest-account-settings-dialog.c:
2270 (create_page_account_details), (create_page_user_details),
2271 (create_page_incoming), (create_page_outgoing):
2272 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2273 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2274 (modest_connection_specific_smtp_edit_window_init):
2275 * src/maemo/modest-connection-specific-smtp-window.c:
2276 (modest_connection_specific_smtp_window_init):
2277 * src/maemo/modest-signature-editor-dialog.c:
2278 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2279 and scrolling policy as per the Email Application Layout Guide, if I have
2282 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2284 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2285 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2286 which were empty, because these vfuncs have been removed from TnyAccountStore.
2287 This fixes the build.
2289 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2291 * src/maemo/modest-main-window.c:
2292 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2293 showing/hiding it. Added TODO because it probably should not be NULL.
2294 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2295 because unnecessary g_warnings() make degugging difficult.
2297 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/modest-msg-edit-window.c:
2300 (modest_msg_edit_window_select_color),
2301 (modest_msg_edit_window_select_background_color): 2 const corrections and
2302 moving 2 #endifs before closing brackets, to fix the build.
2304 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/easysetup/modest-easysetup-wizard.h:
2307 * src/maemo/easysetup/modest-easysetup-wizard.c:
2308 (modest_easysetup_wizard_dialog_finalize),
2309 (on_button_edit_advanced_settings), (create_page_complete_custom),
2310 (on_response), (create_account):
2311 Implement the Advanced Settings edit button, by saving the account information,
2312 for the Advanded Settings dialog to use directly from gconf, and removing it
2313 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2314 Bug #5533 in the projects.maemo.org bugzilla.
2316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/modest-msg-view-window.c:
2319 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2320 when opening a message window.
2322 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2324 * src/maemo/easysetup/modest-easysetup-wizard.c:
2325 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2328 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2329 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2330 gconf settings. I probably added more checks than necessary, but that is safer.
2332 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2333 variable to fix the build, but this seems to be used when it is still NULL.
2335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2337 * src/modest-platform.h:
2338 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2339 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2340 * src/modest-main.c: Implement this function so we can avoid using
2341 maemo-specific API from cross-platform code.
2343 * src/modest-tny-account-store.c:
2344 (get_smtp_specific_transport_account_for_open_connection):
2345 * src/modest-ui-actions.c: (check_for_connection),
2346 (modest_ui_actions_on_item_not_found):
2347 Use modest_platform_connect_and_wait() and put #idefs around other
2348 maemo-specific code, because only maemo currently has a way to
2349 identify connection names.
2351 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-tny-account-store.h:
2354 * src/modest-tny-account-store.c:
2355 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2356 the connection-specific SMTP server settings in the configuration.
2358 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2360 * src/maemo/modest-main-window.c: (on_connection_changed),
2362 * src/modest-main.c: (main), (start_ui), (send_mail):
2363 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2364 that is what is intended.
2366 * src/modest-ui-actions.c: (action_send), (action_receive),
2367 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2368 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2369 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2370 SMTP server is used when it is specified.
2372 (modest_ui_actions_on_send_receive):
2373 Check that a connection is open before proceeding.
2374 Receive and then send, instead of vice-versa, as per the specification.
2376 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-mail-operation.c:
2379 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2380 though I guess it should be something other than NULL.
2382 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2384 * src/maemo/easysetup/modest-easysetup-wizard.c:
2385 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2386 combo twice, to avoid an g_warning and to make it visible again.
2387 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2388 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2389 (already intended) dereference when detaching, because we then recreate the menu.
2390 But I am not sure why the warning was happening, and it is possible that this is a memory
2393 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2395 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2396 and uri_parse_mailto() utility functions.
2397 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2399 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2401 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2403 * src/dbus_api/modest-dbus-api.h:
2404 * src/dbus_api/modest-dbus-callbacks.c:
2405 Use an idle callback to execute the modest code in the application's own thread.
2406 Remove the helloworld example method.
2407 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2408 parsed, and the open-message method is not implemented because this is not yet implemented in
2410 * libmodest-dbus-client/libmodest-dbus-client.c:
2411 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2412 (libmodest_dbus_client_open_message):
2413 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2415 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2416 body without crashing.
2418 * tests/dbus_api/Makefile.am:
2419 * tests/dbus_api/test_mail_to.c:
2420 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2422 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2424 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2425 Added file to fix the build. Sorry.
2427 * src/dbus_api/Makefile.am:
2428 * src/dbus_api/modest-dbus-api.h:
2429 * src/dbus_api/modest-dbus-callbacks.h:
2430 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2431 (modest_dbus_req_handler):
2432 Put constants in a separate header so it can be reused by the
2433 client library, without duplication
2435 * libmodest-dbus-client/Makefile.am:
2436 * libmodest-dbus-client/libmodest-dbus-client.c:
2437 (libmodest_dbus_client_call_helloworld),
2438 (libmodfest_dbus_client_send_mail),
2439 (libmodfest_dbus_client_mailto),
2440 (libmodfest_dbus_client_open_message):
2441 * libmodest-dbus-client/libmodest-dbus-client.h:
2442 (Partly) Implement a send_mail D-Bus method.
2444 * tests/dbus_api/Makefile.am:
2445 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2446 the send_email D-Bus method.
2448 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2452 * libmodest-dbus-client/Makefile.am:
2453 * libmodest-dbus-client/libmodest-dbus-client.c:
2454 * libmodest-dbus-client/libmodest-dbus-client.h:
2455 * tests/dbus_api/Makefile.am:
2456 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2457 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2459 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/easysetup/modest-easysetup-wizard.c:
2462 (create_page_account_details):
2463 * src/maemo/modest-account-settings-dialog.c:
2464 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2465 widgets, because this might not be the default in future versions of the Maemo GTK+.
2466 However, I can not not get capitalization to work even in a simple test case.
2468 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/easysetup/modest-easysetup-wizard.c:
2471 (create_page_custom_incoming), (create_page_custom_outgoing):
2472 * src/maemo/modest-account-settings-dialog.c:
2473 (create_page_account_details), (create_page_incoming),
2474 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2475 instead of using gtk_check_button_with_label(), so they are aligned like the other
2476 widgets, as per the UI spec.
2478 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2480 * src/maemo/easysetup/modest-easysetup-wizard.c:
2481 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2482 * src/widgets/modest-validating-entry.c:
2483 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2484 Modest prefix instead of an EasySetup prefix.
2486 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2488 * src/widgets/modest-validating-entry.h:
2489 * src/widgets/modest-validating-entry.c: (on_insert_text),
2490 Added easysetup_validating_entry_set_max_func(), used to set a callback
2491 to call when the max number of characters is reached. GtkEntry has a max-length
2492 already but is silent about it.
2494 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2495 (create_page_account_details), (create_page_user_details),
2497 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2498 (create_page_account_details), (create_page_user_details),
2499 (create_page_outgoing):
2500 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2501 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2502 the UI spec, when the user tries to enter more than the max number of characters.
2504 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/easysetup/modest-easysetup-wizard.c:
2507 (create_page_user_details), (create_page_custom_incoming),
2508 (create_page_custom_outgoing):
2509 * src/maemo/modest-account-settings-dialog.c:
2510 (create_page_user_details), (create_page_incoming),
2511 (create_page_outgoing):
2512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2513 (modest_connection_specific_smtp_edit_window_init):
2514 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2515 not appropriate. Bad Maemo-specific defaults!.
2517 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2519 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2520 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2521 (modest_signature_editor_dialog_set_settings):
2522 Disable the label and textview when the checkbox is disabled, and use the
2523 specified (UI spec) default signature text.
2525 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2528 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2530 * src/modest-defs.h:
2531 * src/modest-account-mgr-helpers.h:
2532 * src/modest-account-mgr-helpers.c:
2533 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2535 * src/maemo/Makefile.am:
2536 * src/maemo/modest-signature-editor-dialog.c:
2537 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2540 * src/maemo/modest-account-settings-dialog.h:
2541 * src/maemo/modest-account-settings-dialog.c:
2542 (modest_account_settings_dialog_finalize), (on_button_signature),
2543 (save_configuration): Use the new dialog when the Edit button is pressed, and
2544 save the changes if necessary, as per the UI spec.
2546 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/Makefile.am:
2549 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2550 based on maemo-develoers email from Dirk.
2552 * src/maemo/easysetup/modest-easysetup-wizard.c:
2553 (create_page_welcome), (create_page_account_details),
2554 (create_page_user_details), (create_page_complete_easysetup),
2555 (create_page_custom_incoming), (create_page_custom_outgoing),
2556 (create_page_complete_custom),
2557 (modest_easysetup_wizard_dialog_init):
2558 * src/maemo/modest-account-settings-dialog.c:
2559 (create_page_account_details), (create_page_user_details),
2560 (create_page_incoming), (create_page_outgoing),
2561 (modest_account_settings_dialog_init):
2562 * src/maemo/modest-connection-specific-smtp-window.c:
2563 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2565 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/easysetup/modest-easysetup-wizard.c:
2568 (create_page_account_details), (create_page_custom_outgoing),
2569 (create_page_complete_custom):
2570 * src/maemo/modest-account-settings-dialog.c:
2571 (create_page_user_details), (create_page_incoming),
2572 (create_page_outgoing):
2573 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2574 (modest_connection_specific_smtp_edit_window_init):
2575 Use the correct (UI spec) port min/max, and use horizontal separators,
2578 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2580 * src/maemo/easysetup/modest-easysetup-wizard.c:
2581 (set_default_custom_servernames):
2582 * src/maemo/modest-account-settings-dialog.c:
2583 (create_page_incoming), (on_combo_outgoing_security_changed),
2584 (on_combo_incoming_security_changed), (create_page_outgoing),
2585 (modest_account_settings_dialog_set_account_name),
2586 (save_configuration):
2587 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2588 (on_combo_security_changed),
2589 (modest_connection_specific_smtp_edit_window_init),
2590 (modest_connection_specific_smtp_edit_window_set_connection),
2591 (modest_connection_specific_smtp_edit_window_get_settings):
2592 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2595 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 (create_page_custom_outgoing), (create_page_complete_custom):
2600 * src/maemo/modest-account-settings-dialog.c:
2601 (create_page_user_details), (create_page_outgoing):
2602 * src/maemo/modest-account-view-window.c: (button_box_new):
2603 Use changed logical IDs as per the most recent UI spec:
2604 mcen_bd_emailsetup_edit -> mcen_bd_edit
2605 mcen_bd_emailsetup_delete -> mcen_bd_delete
2606 mcen_bd_emailsetup_close -> mcen_bd_close
2608 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2612 * src/dbus_api/Makefile.am:
2613 * src/dbus_api/modest-dbus-callbacks.c:
2614 * src/dbus_api/modest-dbus-callbacks.h:
2615 * src/maemo/modest-platform.c: (modest_platform_init):
2616 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2618 * tests/Makefile.am:
2619 * tests/dbus_api/Makefile.am:
2620 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2622 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/modest-account-settings-dialog.c:
2625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2626 Removed unnecessary includes.
2628 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2630 * src/maemo/easysetup/modest-easysetup-wizard.c:
2631 * src/maemo/modest-account-settings-dialog.c:
2632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2633 * src/widgets/Makefile.am:
2634 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2635 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2636 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2637 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2638 * src/widgets/modest-secureauth-combo-box.c:
2639 * src/widgets/modest-secureauth-combo-box.h:
2640 * src/widgets/modest-serversecurity-combo-box.c:
2641 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2642 made the GObject names more consistent with the rest of the Modest code.
2644 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2646 * src/maemo/easysetup/Makefile.am:
2647 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2648 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2649 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2650 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2651 * src/maemo/easysetup/modest-easysetup-wizard.c:
2652 * src/maemo/easysetup/modest-validating-entry.c:
2653 * src/maemo/easysetup/modest-validating-entry.h:
2654 * src/maemo/modest-account-settings-dialog.c:
2655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2656 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2657 widgets/ because they are used outside of easysetup too. After checking in,
2658 svn will allow me to rename them too.
2660 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2662 * src/gnome/modest-msg-edit-window.c:
2663 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2664 linker error, to fix the build on the GNOME platform.
2665 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2666 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2667 ifdefed out to avoid a warning.
2669 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2671 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2672 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2673 some alternative for GTK+ 2.6.
2675 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2679 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2680 specified for EmailAccountsDialog in UI spec.
2682 * src/maemo/easysetup/modest-easysetup-wizard.c:
2683 * src/maemo/easysetup/modest-easysetup-wizard.h:
2684 * src/maemo/modest-account-settings-dialog.c:
2685 * src/maemo/modest-account-settings-dialog.h:
2686 Reuse a member window widget for the connection-specific SMTP server accounts,
2687 so we can tell it to create/save the accounts only if we actually save changes.
2689 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2690 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2691 (modest_connection_specific_smtp_edit_window_get_settings):
2692 Return a struct instance for temporarily remembering the entered data.
2694 * src/maemo/modest-connection-specific-smtp-window.h:
2695 * src/maemo/modest-connection-specific-smtp-window.c:
2696 (modest_connection_specific_smtp_window_finalize),
2697 (modest_connection_specific_smtp_window_fill_with_connections),
2699 (modest_connection_specific_smtp_window_save_server_accounts),
2700 (update_model_server_names): Do not actually save data until asked,
2701 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2703 (on_selection_changed),
2704 (modest_connection_specific_smtp_window_init): Disable the edit
2705 button when nothing is selected.
2707 * src/modest-account-mgr-helpers.c:
2708 * src/modest-account-mgr-helpers.h:
2709 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2712 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2714 * src/modest-account-mgr-helpers.h:
2715 * src/modest-account-mgr-helpers.c:
2716 (modest_account_mgr_get_unused_account_name),
2717 (modest_account_mgr_get_unused_account_display_name): Added these
2718 utility functions, to avoid code duplication.
2720 * src/maemo/easysetup/modest-easysetup-wizard.c:
2721 (create_page_account_details), (create_account):
2722 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2723 (on_combo_security_changed),
2724 (modest_connection_specific_smtp_edit_window_init),
2725 (modest_connection_specific_smtp_edit_window_save_settings):
2726 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2727 * src/maemo/modest-connection-specific-smtp-window.c:
2728 (modest_connection_specific_smtp_window_finalize),
2729 (modest_connection_specific_smtp_window_fill_with_connections),
2730 (on_button_edit), (modest_connection_specific_smtp_window_init):
2731 * src/maemo/modest-connection-specific-smtp-window.h:
2732 Implementing saving of connection-specific server accounts.
2734 But I need to refactor this so we can save the data for each
2735 possible connection-specific account and only actually create the server accounts
2736 when the easysetup finished, or the OK button is pressed on the account settings
2739 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2742 (on_combo_security_changed):
2743 (modest_connection_specific_smtp_edit_window_init):
2744 Auto-fill the port number as in the account settings.
2746 (modest_connection_specific_smtp_edit_window_set_connection):
2747 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2748 * src/maemo/modest-connection-specific-smtp-window.c:
2749 (fill_with_connections), (on_button_edit),
2750 (modest_connection_specific_smtp_window_init):
2751 Turn the edit window into a dialog to simplify the code, and
2752 set a WM hint as in a GtkDialog, because only a popup can be on top of
2753 another window in Maemo, and popups usually have no WM decoration.
2755 * src/modest-defs.h:
2756 * src/modest-account-mgr-helpers.c:
2757 (modest_account_mgr_set_connection_specific_smtp),
2758 (modest_account_mgr_remove_connection_specific_smtp),
2759 (modest_account_mgr_get_connection_specific_smtp):
2760 * src/modest-account-mgr-helpers.h: Some functions to write the
2761 connection-specific SMTP server information. Not yet used.
2764 * src/widgets/modest-folder-view.c: (text_cell_data):
2765 Fix a warning about an uninitialized variable.
2766 (on_configuration_key_changed): Put an #ifdef around the use
2767 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2769 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2771 * src/maemo/modest-account-settings-dialog.h:
2772 * src/maemo/modest-account-settings-dialog.c:
2773 Added connect_for_modified() utility function to mark the new modified boolean.
2775 (create_page_account_details), (create_page_user_details),
2776 (create_page_incoming), (create_page_outgoing), (on_response),
2777 (modest_account_settings_dialog_init),
2778 (modest_account_settings_dialog_set_account_name):
2779 Only warn about unsaved changes when there are actually unsaved changes.
2781 * src/modest-account-mgr-helpers.c:
2782 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2783 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2784 to get the data from there in future.
2786 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2788 * src/modest-defs.h:
2790 * src/modest-account-mgr-helpers.h:
2791 * src/modest-account-mgr-helpers.c:
2792 Store the security account setting in a single conf key instead of using
2793 the options list, so that the list is left for just the to-be-removed camel hack,
2794 and because gconf_client_set_list() is failing for some reason.
2796 * src/modest-account-mgr.c:
2797 (modest_account_mgr_add_server_account):
2798 * src/maemo/modest-account-settings-dialog.c:
2799 (modest_account_settings_dialog_set_account_name),
2800 (save_configuration): Use the renamed functions.
2803 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2805 * src/widgets/Makefile.am:
2806 * src/widgets/modest-limit-retrieve-combo-box.c:
2807 * src/widgets/modest-limit-retrieve-combo-box.h:
2808 * src/widgets/modest-retrieve-combo-box.c:
2809 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2810 the account settings dialog.
2812 * src/modest-defs.h:
2813 * src/modest-account-mgr-helpers.h:
2814 * src/modest-account-mgr-helpers.c:
2815 (modest_server_account_get_option_secure_auth),
2816 (modest_server_account_set_option_secure_auth):
2817 * src/modest-account-mgr.c:
2818 (modest_account_mgr_add_server_account):
2819 Use the existing AUTH_MECH conf key for the secure-auth setting,
2820 instead of putting it in the list options, because this was actually used already.
2822 * src/maemo/modest-account-settings-dialog.c:
2823 (create_page_account_details),
2824 (modest_account_settings_dialog_set_account_name),
2825 (save_configuration):
2826 * src/maemo/modest-account-settings-dialog.h:
2827 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2828 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2830 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2833 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2834 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2836 * src/modest-defs.h:
2837 * src/maemo/modest-account-settings-dialog.c:
2838 (create_page_incoming), (on_combo_outgoing_security_changed),
2839 (on_combo_incoming_security_changed), (create_page_outgoing),
2840 (modest_account_settings_dialog_set_account_name),
2841 (save_configuration): Load/Save the port number, and change it when the
2842 security combo changes, to suitable defaults.
2844 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-account-mgr.c:
2847 (modest_account_mgr_add_server_account): Set the security and secure-auth
2848 options, and add a comment saying that the other camel-specific options should be
2851 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2853 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2855 * src/modest-tny-account-store.c: (account_list_free),
2856 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2857 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2860 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-protocol-info.c:
2863 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2864 is required by our UI spec. Maybe something in our implementation will use this eventually.
2865 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2866 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2867 instead of the previous 0 placeholder.
2869 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2870 secure-auth settings.
2871 * src/modest-account-mgr-helpers.h:
2872 * src/modest-account-mgr-helpers.c:
2873 (modest_server_account_data_get_option_secure_auth),
2874 (modest_server_account_set_option_secure_auth),
2875 (modest_server_account_data_get_option_security),
2876 (modest_server_account_set_option_security): Added this API for getting and setting the security
2877 and secure-auth settings.
2879 * src/maemo/modest-account-settings-dialog.h:
2880 * src/maemo/modest-account-settings-dialog.c:
2881 (modest_account_settings_dialog_finalize), (check_data),
2882 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2883 about changing titles.
2884 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2885 (save_configuration): Save the security and secure-auth settings.
2887 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2888 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2890 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2892 * src/modest-defs.h:
2893 * src/modest-account-mgr.c:
2894 (modest_account_mgr_add_server_account):
2895 Added and used defines for the options key and value pair strings,
2896 that are used so far, though they do not seem to correspond to anything in our
2897 UI specs or ModestProtocol enum.
2899 * src/modest-account-mgr-helpers.h:
2900 * src/modest-account-mgr-helpers.c:
2901 (compare_option_strings_for_name),
2902 (modest_server_account_data_get_option_value),
2903 (modest_server_account_data_get_option_bool),
2904 (modest_account_mgr_get_server_account_option):
2905 Added helper functions for parsing the options GSList.
2907 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2909 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2910 display name is based on the supplied account name.
2911 * src/modest-account-mgr.c:
2912 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2913 with an inefficient, but good-enough, implementation.
2915 * src/maemo/easysetup/modest-easysetup-wizard.c:
2916 (create_page_account_details), (on_before_next), (create_account):
2917 Check for existing display names rather than (non-user-visible) account names, and just
2918 create and set a unique account name at the end.
2920 * src/maemo/modest-account-settings-dialog.c:
2921 (modest_account_settings_dialog_init),
2922 (modest_account_settings_dialog_set_account_name),
2923 (create_page_incoming): Show the display name, instead of the account name.
2924 (on_response): Do some (not all) extra checks, as in the UI spec.
2925 (save_configuration): Save the display name if it was changed.
2927 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2929 * po/en_GB.po: Added needed logical ID and translation.
2930 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2931 (init_view): Made the is-default column clicking work.
2933 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/easysetup/Makefile.am:
2937 * src/maemo/easysetup/modest-easysetup-wizard.c:
2938 (modest_easysetup_wizard_dialog_init):
2939 * src/maemo/easysetup/provider-data-test.keyfile:
2940 * src/maemo/easysetup/provider-data.keyfile:
2941 Moved the provider data file to the new modest-providers-data package and used it from there.
2943 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2945 * src/modest-local-folder-info.c:
2946 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2947 N_() was already used on the static strings, but this just marks it for translation without
2948 using the translation.
2950 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-account-settings-dialog.c:
2953 (create_page_incoming),
2954 (modest_account_settings_dialog_set_account_name):
2955 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2956 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2957 I will do this if nobody else gets there first.
2959 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2961 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2962 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2963 save the security stuff.
2965 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2968 Set the email address and user fullname, which I now see must be
2971 * src/maemo/modest-account-settings-dialog.h:
2972 * src/maemo/modest-account-settings-dialog.c:
2974 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2975 leave-on-server and authentication.
2976 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2979 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-account-settings-dialog.c:
2983 * src/maemo/modest-account-settings-dialog.h:
2984 Most (but not all) of the widgets are now present as specified by the UI spec.
2985 No changes are yet saved, and some details are not properly shown yet.
2987 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2989 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2991 * src/maemo/Makefile.am:
2992 * src/maemo/modest-account-settings-dialog.c:
2993 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2994 an existing account. Doesn't do much yet.
2996 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2997 Open the accounts settings dialog when Edit is clicked.
2999 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/easysetup/Makefile.am:
3002 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3004 * src/maemo/easysetup/modest-easysetup-wizard.c:
3005 (modest_easysetup_wizard_dialog_init):
3006 Try to get the source directory from the build system,
3007 instead of hard-coding "./" into the source code, when opening our local
3008 copies of the configuration files.
3009 But this still fails when opening the wizard from the Accounts window,
3010 maybe because the working directory seems to change at runtime.
3011 So the wizard will fail the second time unless you copy the files into their
3012 proper locations - see the stdout warnings for the paths.
3014 (create_page_account_details),(on_before_next):
3015 Check for existing non-server accounts instead of server accounts,
3016 so the default account name is useful again, and to prevent trying to
3019 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3020 Show the wizard when New is clicked.
3022 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3023 (init_view): Show the column headers, and show the columns that are
3024 specified in the UI specs. However, something in Maemo's GTK+ prevents
3025 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3026 change the default account. This is despite unsetting the special properties.
3028 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3030 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3031 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3032 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3033 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3034 to make that clearer.
3035 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3037 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3039 * src/maemo/modest-account-view-window.c:
3040 (modest_account_view_window_init),
3041 (modest_account_view_window_new):
3042 Use the same buttons as specified in the
3043 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3044 the existing widgets, which never had a chance of working.
3045 Put the ModestAccountView treeview in a scrolled window.
3046 Do not repeat the initialization in both _init() and _new().
3048 * src/widgets/modest-account-view.c: (update_account_view):
3049 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3050 this widget and window shows no accounts.
3052 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3054 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3056 * src/maemo/easysetup/modest-easysetup-wizard.c:
3057 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3058 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3059 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3062 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3063 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3064 accounts exist yet, as in the UI spec.
3066 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3068 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3070 * src/maemo/Makefile.am:
3071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3072 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3073 New window for editing connection-specific smtp details.
3074 Not fully implemented.
3076 * src/maemo/modest-connection-specific-smtp-window.c:
3077 (modest_connection_specific_smtp_window_finalize) :
3078 unref the tree model.
3079 (on_button_edit): Show the edit window.
3081 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3083 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3086 * src/maemo/Makefile.am:
3087 * src/maemo/modest-connection-specific-smtp-window.c:
3088 * src/maemo/modest-connection-specific-smtp-window.h:
3089 New window for showing the list of connections, for connection-specific
3090 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3091 * src/maemo/easysetup/modest-easysetup-wizard.c:
3092 (create_page_custom_outgoing): Show the new window when the button is clicked.
3094 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3096 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3097 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3098 * src/maemo/modest-msg-edit-window.c:
3099 (modest_msg_edit_window_insert_image):
3100 * src/modest-conf.c: (modest_conf_key_escape):
3101 * src/modest-mail-operation.c:
3102 (modest_mail_operation_send_new_mail):
3103 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3104 (modest_ui_actions_on_new_account):
3105 * src/widgets/modest-attachment-view.c: (update_filename_request):
3106 * src/widgets/modest-mail-header-view.c:
3107 Corrected warnings that were breaking the build, by commenting out unused variables,
3108 and a function, and by including a header.
3110 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3112 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3113 so we can #ifdef around platform-specific code when necessary.
3114 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3115 to allow this to build for the GNOME platform too.
3117 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/easysetup/modest-easysetup-wizard.c:
3120 Added util_increment_name() and used it in create_page_account_details()
3121 to make sure that the default account name is always a new name.
3123 (modest_easysetup_wizard_dialog_init),
3124 (set_default_custom_servernames): Some minor memory management fixes.
3126 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3130 * src/modest-runtime.c: (init_i18n): Restored the translation
3131 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3132 are defined in config.h, and the translations are installed.
3134 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3135 is defined for translation.
3137 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3139 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3141 * src/maemo/easysetup/modest-easysetup-wizard.c:
3142 (modest_easysetup_wizard_dialog_init):
3143 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3144 Use realistic paths (though they should use $prefix generically) to the
3145 mcc_mapping and provider-data.keyfile files which might work when they
3146 are installed by the future version of the operator-wizard package,
3147 and then fallback to paths in our source code, with an explanatory
3150 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3154 * src/maemo/Makefile.am:
3155 * src/maemo/easysetup/: Added files from the previously-exernal
3156 osso-modest-easysetup.
3157 * src/maemo/modest-main-window-ui.h:
3158 * src/modest-ui-actions.c:
3159 * src/modest-ui-actions.h:
3160 Added modest_ui_actions_on_new_account() as a signal handler for the
3161 New Account menu item. It shows the easysetup wizard.
3162 * po/en_GB.po: Added additional needed logical IDs and translations.