1 2007-07-23 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c:
4 (modest_tny_account_get_special_folder): Use an if instead of
5 an assert for when the parent account name is NULL, because this
6 might be causing a crash in projects.maemo.org bug 63192.
7 * src/modest-mail-operation.c:
8 (modest_mail_operation_send_new_mail_cb),
9 (modest_mail_operation_remove_folder): unref the folder that is
10 returned from modest_tny_account_get_special_folder().
12 2007-07-23 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-ui-actions.c:
15 (modest_ui_actions_on_password_requested):
16 Show mail_ib_login_cancelled info banner when the user cancels
17 the protected password dialog, to fix projects.maemo.org
20 2007-07-23 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-account-settings-dialog.c:
23 (create_page_outgoing): Put this page in a GtkScrolledWindow,
24 matching the UI mock-up in the UI spec, and allowing access
25 to all widgets even when the on-screen keyboard is active.
27 2007-07-23 Murray Cumming <murrayc@murrayc.com>
29 Reverted this previous commit from Johannes,
30 because the scrollbars are always visible and because
31 I think we only need it on onepage of the account
32 settings, not the account wizard.
33 (I wrote the wrong instructions in the bug.)
35 * src/maemo/easysetup/modest-easysetup-wizard.c:
36 Added scrollbars to account wizard dialog.
37 Fixed projects.maemo.org NB #62744
39 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
41 * src/maemo/easysetup/modest-easysetup-wizard.c:
42 (create_page_user_details):
43 Use auto-cap for name (projects.maemo.org NB#63716)
44 * src/widgets/modest-account-view.c: (on_account_busy_changed):
46 2007-07-22 Armin Burgmeier <armin@openismus.com>
48 * src/maemo/modest-ui-actions.c: Use current account instead of
49 default account for creating viewer windows, so that the viewer
50 window knows to which account the viewed message belongs.
52 * src/maemo/modest-msg-view-window.c: Destroy the window when the
53 corresponding account is deleted. This fixes projects.maemo.org bug
56 2007-07-18 Armin Burgmeier <armin@openismus.com>
58 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
59 the dialog close after entering an invalid port number and clicking
60 OK. This fixes projects.maemo.org bug NB#63602.
62 2007-07-18 Armin Burgmeier <armin@openismus.com>
64 * src/modest-tny-account-store.c:
65 (get_server_accounts): Set parent modest account name for each
66 connection-specific transport account so that special folders of such
67 an account can be looked up. This fixes a crash when changing account
68 settings. This might also be related to projects.maemo.org bug
71 2007-07-16 Armin Burgmeier <armin@openismus.com>
73 * src/modest-ui-actions.c: Added a button to create a folder to the
74 move-to dialog. This fixes projects.maemo.org bug NB#.
76 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
78 * src/maemo/easysetup/modest-easysetup-wizard.c:
79 Added scrollbars to account wizard dialog.
80 Fixed projects.maemo.org NB #62744
82 2007-07-16 Murray Cumming <murrayc@murrayc.com>
84 * src/widgets/modest-msg-view.h:
85 * src/widgets/modest-msg-view.c:
86 Added modest_msg_view_get_message_is_empty() but this needs
88 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
89 Check if there is any text in the message yet.
90 But this needs to be implemented properly.
91 (modest_msg_edit_window_toggle_find_toolbar):
92 * src/maemo/modest-msg-view-window.c:
93 (modest_msg_view_window_toggle_find_toolbar):
94 Show a banner warning if there is no text to search, when
95 trying to start a search. This partially fixes
96 projects.maemo.org bug NB#62350.
98 2007-07-13 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-mail-operation.c: (update_account_thread):
101 Initialized num_new_headers to fix the build.
103 2007-07-13 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
106 Ignore modest accounts whose server accounts don't exist in gconf.
107 This prevents us trying to create TnyAccount instances for those
108 server accounts when the server account has been removed from gconf,
109 but the parent modest account has not yet been removed from modest.
110 I don't know why this is only noticeable now. It was probably just
111 a harmeless g_warning() anyway.
113 2007-07-13 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
116 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
118 2007-07-12 Armin Burgmeier <armin@openismus.com>
120 * src/maemo/modest-main-window.c: Make default account appear bold
121 in view, tools/send & receive and toolbar/send & receive SCM menus.
122 This fixes projects.maemo.org bug NB#59010.
124 2007-07-12 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
127 Add a short-cut, by checking if the folder store is an account.
128 This ensures that the Sort menu item and toolbar is dimmed for
129 the local-folders account root item, fixing
130 projects.maemo.org bug NB#62545.
132 2007-07-12 Murray Cumming <murrayc@murrayc.com>
134 * src/modest-tny-account-store.c: (get_password):
135 Show the password dialog (via the signal) only in the mainloop, via
136 an idle handler that we wait for. This could theoretically prevent
137 hangs, though I worry that it could introduce some too.
139 2007-07-12 Murray Cumming <murrayc@murrayc.com>
141 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
142 * src/maemo/modest-platform.c:
143 (modest_platform_connect_and_wait):
144 Take a TnyAccount* parameter and try to set it to online
145 (a TnyCamel-only API), because tinymail sets accounts to offline
146 when the user cancels a password dialog, and doesn't ask again until
147 it has been set to online.
148 However, this is commented out because it causes a hang now.
150 (modest_platform_connect_and_wait_if_network_account):
151 * src/modest-mail-operation.c:
152 (modest_mail_operation_update_account):
153 * src/modest-platform.h:
154 * src/modest-ui-actions.c: (_modest_ui_actions_open),
155 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
157 2007-07-12 Armin Burgmeier <armin@openismus.com>
159 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
161 * src/modest-mail-operation.c:
162 * src/modest-ui-actions.c: Check for already existing folder before
163 querying the server, show error message from camel if the request
164 still fails. This fixes projects.maemo.org bug NB#58701.
166 2007-07-12 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-tny-account-store.h:
169 * src/modest-tny-account-store.c:
170 Added modest_tny_account_store_forget_password_in_memory(),
171 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
172 when creating a new account, so that new passwords will be used, instead of
173 us thinking that it's a second request as a result of a failed password again.
175 2007-07-12 Murray Cumming <murrayc@murrayc.com>
177 * src/dbus_api/modest-dbus-callbacks.c:
178 (on_idle_open_message): If the message is in drafts then open it
179 in an edit window instead of a view window. This fixes
180 projects.maemo.org bug NB#63005.
182 2007-07-12 Murray Cumming <murrayc@murrayc.com>
184 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
185 Avoided a harmless g_warning().
187 2007-07-12 Murray Cumming <murrayc@murrayc.com>
189 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
190 Pass the modest account name, not the TnyAccount display name to
191 modest_msg_view_window_new() so that the reply feature works,
192 fixing projects.maemo.org bug NB#62892.
194 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
195 (modest_msg_view_window_new_with_header_model):
196 * src/maemo/modest-msg-view-window.c:
197 (modest_msg_view_window_new_with_header_model),
198 (modest_msg_view_window_new):
199 * src/modest-ui-actions.c: (reply_forward):
200 * src/widgets/modest-msg-view-window.h:
201 * src/widgets/modest-window.c: (modest_window_set_active_account):
202 Rename an account parameter to modest_account_name to make this clearer.
204 2007-07-11 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-ui-actions.h:
207 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
208 modest_do_message_delete().
209 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
210 Call modest_do_message_delete(), hoping that this would cause messages
211 to be really deleted from search instead of just marked with strike through.
212 Does not seem to help.
214 2007-07-11 Armin Burgmeier <armin@openismus.com>
216 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
217 priv->reselect to FALSE prior to calling
218 modest_folder_view_select_first_inbox_or_local() to prevent endless
219 recursion and thus a crash on startup.
221 2007-07-11 Armin Burgmeier <armin@openismus.com>
223 * src/maemo/modest-account-settings-dialog.h: Include
224 <gtk/gtknotebook.h> to fix the build (at least for me).
226 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
227 Use "New FolderN" as default suggested name if "New folder" already
228 exists, with N being the first free number, though never exceed "New
229 folder99" in which case we just fall back to "New Folder" even though
230 it already exists. This fixes projects.maemo.org bug NB#58663.
232 2007-07-11 Murray Cumming <murrayc@murrayc.com>
234 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
235 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
236 projects.maemo.org bug NB#62778.
238 2007-07-11 Murray Cumming <murrayc@murrayc.com>
240 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
241 Ignore the wrong (for now) secure-smtp setting in the presets -
242 just default to requiring secure authentication for SMTP, because
245 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
247 * src/widgets/modest-folder-view.c: (filter_row)
248 Do not show drafts folder (see UI specs)
250 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
252 * src/modest-ui-actions.c:
253 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
254 place and also not necessary.
256 * src/widgets/modest-folder-view.c: (filter_row)
257 Guess folder type and hide Sent & Outbox if necessary.
258 Fixed project.maemo.org NB#57328
260 2007-07-11 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-ui-actions.h:
263 * src/modest-ui-actions.c:
264 (modest_ui_actions_on_delete_message):
265 Move some code into a new
266 modest_ui_actions_refresh_message_window_after_delete()
267 function so we can use it from elsewhere.
269 * src/dbus_api/modest-dbus-callbacks.c:
270 (on_idle_delete_message), (on_delete_message): Used an idle
271 handler, as we do for the other D-Bus method handlers.
272 Call modest_ui_actions_refresh_message_window_after_delete()
273 if the deleted message was open in a window. This fixed
274 projects.maemo.org bug NB#62862.
276 2007-07-11 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-main.c: (main): Only show the UI at the start if
279 the showui command line option was given. For instance,
280 run-standalone src/modest showui
281 Otherwise, we wait for the top_application D-Bus method to
282 be sent by hildon-desktop when the application is selected
284 This allows us to run without a UI when osso-global-search
285 uses our D-Bus methods.
287 2007-07-11 Murray Cumming <murrayc@murrayc.com>
289 * src/dbus_api/modest-dbus-api.h: Added a define for a
290 top-application D-Bus method.
291 * src/dbus_api/modest-dbus-callbacks.c:
292 (on_top_application),
293 (modest_dbus_req_handler): Handle the top-application D-Bus
294 method, which might be an undocumented D-Bus signal sent by
295 hildon-desktop when it starts the application from the menu.
296 But I am not sure and I need to test it on the device, because
297 my scratchbox does not have the application in the menu now.
298 This method shows the main window, so that it can be invisible
299 when started, for instance, just for email searching from
302 * src/maemo/modest-main-window.c: (restore_settings),
303 (modest_main_window_new): Do not show the window immediately
304 upon creation. We show it later.
305 * src/modest-widget-memory.c: (save_settings_paned):
306 Try (unsuccessfully) to avoid saving the paned position when
307 it is not even visible.
308 (restore_settings_paned): Do not allow a silly paned position.
309 This seems necessary when not showing the window at first.
311 * tests/dbus_api/Makefile.am:
312 * tests/dbus_api/test_top_application.c: (main): Test for the
315 2007-07-10 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-ui-dimming-rules.c:
318 (modest_ui_dimming_rules_on_new_msg),
319 (modest_ui_dimming_rules_on_reply_msg),
320 (modest_ui_dimming_rules_on_delete_msg),
321 (modest_ui_dimming_rules_on_details),
322 (modest_ui_dimming_rules_on_view_window_move_to),
323 (modest_ui_dimming_rules_on_view_previous),
324 (modest_ui_dimming_rules_on_view_next),
325 (_invalid_folder_for_purge): Added checks before
326 casting the window. This looks like an actual
327 logic error in _invalid_folder_for_purge(), because it
328 tries to use a ModestMainWindow as a message window.
330 2007-07-10 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/modest-account-settings-dialog.c:
333 (show_error): Use the same implementation as in
334 modest-easysetup-wizard.c:
335 (on_entry_invalid_character): The logical ID contains a %s.
336 Guessed what it should be.
337 (on_entry_max), (check_data), (on_response): Adapt to
338 changed show_error().
339 (create_page_account_details): Really call
340 modest_validating_entry_set_func() on the correct widgets.
341 * src/maemo/easysetup/modest-easysetup-wizard.c:
342 (on_entry_invalid_character): Fix the logical ID here too.
343 (create_page_account_details),
344 (create_page_user_details):
346 modest_validating_entry_set_func() on the correct widgets.
348 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
349 Do not try to use the account if it is NULL.
351 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
353 * src/modest-ui-actions.c: (create_move_to_dialog),
354 (modest_ui_actions_on_main_window_move_to),
355 (modest_ui_actions_on_msg_view_window_move_to):
356 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
357 (filter_row), (modest_folder_view_show_non_move_folders):
358 * src/widgets/modest-folder-view.h:
360 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
361 the Sent folder yet as it does not report the correct folder type.
363 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
365 * src/maemo/modest-msg-edit-window.c: (init_window):
368 2007-07-10 Murray Cumming <murrayc@murrayc.com>
370 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
371 Take a parent widget instead of a parent window, and
372 implement this with hildon_banner_show_information() instead.
373 Non-Maemo builds can just ifdef that there.
374 This fixed projects.maemo.org bug NB#62766.
376 (on_entry_invalid_character): Use show_error() again instead
377 of using hildon directly, and use the _CS() macro to use the correct
379 (create_account), (check_for_supported_auth_methods), (on_entry_max):
380 Pass a widget instead od a window to show_error().
382 2007-07-10 Murray Cumming <murrayc@murrayc.com>
384 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
385 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
386 This allows us to show the server name in the error message, fixing
387 projects.maemo.org bug NB#62904.
388 Also, use the appropriate logical ID message for the account protocol.
390 2007-07-10 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account-store.c: (on_idle_wrong_password):
393 A compilation fix, though the build wasn't broken for me.
395 2007-07-09 Murray Cumming <murrayc@murrayc.com>
397 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
398 Do not try to unref a NULL folder store, to avoid a runtime warning.
399 This seems to happen sometimes when changing accounts settings.
401 2007-07-09 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-tny-account-store.c:
404 (modest_tny_account_store_instance_init),
405 (modest_tny_account_store_finalize),
406 (on_account_settings_hide), (on_idle_wrong_password):
407 Use a GHashTable to ensure that we only show one account settings
408 dialog per modest account. This avoids us having a dialog open for
409 both the store and transport accounts, or due to repeated get_password()
410 calls that shouldn't happen anyway.
412 2007-07-09 Murray Cumming <murrayc@murrayc.com>
414 * src/maemo/modest-maemo-utils.c: (on_hide),
415 (modest_maemo_show_dialog_and_forget): Handle the response, because
416 the window is not even hidden by default.
418 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
419 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
420 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
421 which seems to prevent some modality problems.
423 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
424 Ignore user cancellation errors.
426 * src/modest-account-mgr-helpers.h:
427 * src/modest-account-mgr-helpers.c:
428 Added modest_server_account_get_password() and
429 modest_server_account_get_has_password() to avoid direct use of
432 * src/maemo/modest-account-settings-dialog.h:
433 * src/maemo/modest-account-settings-dialog.c:
434 (modest_account_settings_dialog_init): Store the notebook so we can
436 Added modest_account_settings_dialog_switch_to_user_info().
438 * src/modest-tny-account-store.c:
439 (get_password): When the password in the account settings is wrong (we think),
440 show the relevant page of the account settings dialog, in the mainloop.
441 However, we currently get many of these at once because cancel does not
443 (forget_password): Do not forget the password
444 from the account settings, because this causes side-effects when
445 tinymail seems to call it at strange time, maybe because of how we
446 are cancelling get_password().
447 (modest_tny_account_store_alert): Ignore user cancellations.
449 2007-07-09 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/modest-maemo-utils.h:
452 * src/maemo/modest-maemo-utils.c:
453 Added modest_maemo_show_information_note_and_forget() for use instead of
454 gtk_dialog_run() when the response is not needed, to avoid an extra
455 mainloop which could cause a hang.
457 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
458 Use the logical IDs for the error message, though they are not
459 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
460 because gtk_dialog_run() caused a hang here (the window did not close).
461 This fixes projects.maemo.org bug NB#62646.
463 2007-07-09 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-account-mgr-helpers.h:
466 * src/modest-account-mgr-helpers.c:
467 Added modest_account_mgr_get_store_protocol().
469 * src/maemo/modest-account-view-window.c:
470 (on_delete_button_clicked): Show different warning text depending on
471 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
472 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
475 2007-07-09 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/modest-msg-edit-window.c:
478 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
479 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
481 2007-07-07 Armin Burgmeier <armin@openismus.com>
483 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
484 ckdg_ib_maximum_characters_reached from correct package.
486 * src/modest-ui-actions.c: Show an error message when a folder could
487 not be created. Tinymail does not give us specific error codes about
488 what has gone wrong, so we assume that a folder with that name
489 already exists, though there might be other reasons.
491 2007-07-06 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
494 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
495 give a more exact error message that can be partly translated.
497 2007-07-05 Murray Cumming <murrayc@murrayc.com>
499 * src/maemo/modest-address-book.c:
500 (select_email_addrs_for_contact): Specify a default window size for the
501 select-email-address dialog, so that it is probably big enough for the
502 title. This should fix projects.maemo.org bug NB#62277.
504 2007-07-05 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/easysetup/modest-easysetup-wizard.c:
507 (create_page_complete_easysetup): Use
508 gtk_widget_set_size() request to ensure that the text wraps
511 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
513 * src/maemo/easysetup/modest-easysetup-wizard.c:
514 (on_entry_invalid_character), (create_page_account_details),
515 (create_page_user_details):
516 Use new API of ModestValidatingEntry. But for some reason the banner is
517 not shown. I will have to investigate that further.
519 * src/widgets/modest-validating-entry.c: (on_insert_text),
520 (modest_validating_entry_set_func):
521 * src/widgets/modest-validating-entry.h:
522 Added a new callback function to be able to react to prevented
523 characters whitespaces to e.g show a banner.
525 2007-07-05 Armin Burgmeier <armin@openismus.com>
527 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
528 notification of HildonNumberEditor instead of remembering the port
529 number. Thanks to Johannes for pointing this out.
531 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
533 * src/maemo/easysetup/modest-easysetup-wizard.c:
534 Check if there are any user changes before showing a confirmation
535 dialog (projects.maemo.org NB#60946)
537 2007-07-05 Armin Burgmeier <armin@openismus.com>
539 * src/maemo/modest-account-settings-dialog.c: Remember custom port
540 number at the beginning of the dialog and set the modified flag at the
541 end if the port number has changed. This is necessary because
542 HildonNumberEditor does not support notification when the value has
545 2007-07-05 Murray Cumming <murrayc@murrayc.com>
547 * src/modest-ui-actions.c:
548 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
549 a connection before asking anything else. Correct the check for the destination
550 folder so that it succeeds when online.
551 This fixed projects.maemo.org bug NB#61645.
553 2007-07-05 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
556 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
557 to fix projects.maemo.org bug NB#62439.
559 2007-07-05 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-tny-account.c: (on_connection_status_changed):
562 Really do not use tny_device_force_offline() here. See the previous comment.
564 2007-07-04 Murray Cumming <murrayc@murrayc.com>
566 * src/modest-tny-account.c: (on_connection_status_changed):
567 Do not use tny_device_force_offline() when tinymail says that something
568 went wrong with the connection. It seems to report this unnecessarily.
570 2007-07-04 Murray Cumming <murrayc@murrayc.com>
572 * src/maemo/modest-connection-specific-smtp-window.c:
573 (modest_connection_specific_smtp_window_init):
574 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
575 does not seem to have any effect in osso 1.1 (though it works in
576 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
578 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
580 * src/maemo/modest-connection-specific-smtp-window.c:
581 Fix UI specification problems with projects.meamo.org NB#60479
583 2007-07-04 Murray Cumming <murrayc@murrayc.com>
585 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
586 clue when this has failed, because the error dialog is not always shown
587 (at least in earlier version).
589 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
590 GError message, because the generic error dialog is not helpful.
592 'This message is not currently available (can't let a new connection go online)'
593 when trying to open an IMAP message.
595 (_modest_ui_actions_open): Offer a connection when some messages would
596 have to be downloaded and we are offline.
598 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
600 * src/widgets/modest-folder-view.c:
601 Don't check for MERGE type anymore as we use the correct type
603 NOTE: For the last two changes you need to update your tinymail copy
604 because of API changes!
606 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
608 * src/modest-tny-local-folders-account.c:
609 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
610 (see projects.maemo.org NB#61580)
612 2007-07-04 Murray Cumming <murrayc@murrayc.com>
614 * src/modest-tny-account.c: (on_connection_status_changed):
615 Commented out the call to modest_platform_connect_and_wait() because this
616 seems to always hang, and I would like to know if this is the only thing
617 that causes a hang when showing the connection dialog.
618 It is not very useful anyway.
620 2007-07-04 Murray Cumming <murrayc@murrayc.com>
622 * src/maemo/modest-msg-view-window.c:
623 (modest_msg_view_window_select_next_message):
625 * src/modest-platform.h:
626 * src/maemo/modest-platform.c:
627 Added modest_platform_connect_and_wait(), which calls
628 tny_maemo_conic_device_connect() always in the main thread, by calling it
629 in an idle handler and waiting for the idle handler to run. It should be
630 in the main thread because it uses GTK+ UI code. It just returns TRUE
631 if the device is already online.
633 There is some nasty code to ensure that subsequent calls to
634 modest_platform_connect_and_wait() just wait for the first one to finish,
635 by checking repeatedly in another idle handler. This is necessary,
636 because other threads (or even the main thread, via another idle handler)
637 can call modest_platform_connect_and_wait() while
638 modest_platform_connect_and_wait() is running.
640 (modest_platform_connect_and_wait_if_network_account),
641 (modest_platform_connect_and_wait_if_network_folderstore):
642 Convenience functions that calls modest_platform_connect_and_wait() if
643 the account or folder might want network access.
645 * src/modest-mail-operation.c:
646 (modest_mail_operation_update_account):
647 * src/modest-ui-actions.c: (download_uncached_messages),
648 (modest_ui_actions_on_rename_folder), (delete_folder),
649 (modest_ui_actions_on_main_window_move_to),
650 (modest_ui_actions_on_msg_view_window_move_to):
651 * src/widgets/modest-folder-view.c:
652 (drag_and_drop_from_folder_view):
653 Offer a connection if we are offline.
655 * src/modest-tny-account.c: (on_connection_status_changed):
656 Document this as only handling errors during network operations in progress,
657 and replace the idle code with a simple call to
658 modest_platform_connect_and_wait(), which does this instead.
660 2007-07-03 Murray Cumming <murrayc@murrayc.com>
662 * src/modest-tny-account.c:
663 (modest_tny_account_get_special_folder): (util_on_idle),
664 Handle the GError so we can see when tny_folder_store_get_folders()
665 fails, as it currently does while something else is connecting.
667 Added util_run_in_main_thread_and_wait()
668 which uses an idlen handler and mainloop to ensure that the function
669 is called in the main thread.
670 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
671 to make sure that we call attempt the connection in the mainloop only,
672 which might solve some hangs.
674 2007-07-03 Murray Cumming <murrayc@murrayc.com>
676 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
677 be found by their display name. This is never useful.
678 * src/modest-tny-account-store.c: (on_account_removed): Find the account
679 by its ID, instead of trying to use its ID as its display name.
681 * src/modest-tny-account-store.h:
682 * src/modest-tny-account.c:
683 (modest_tny_account_get_special_folder): Add a g_warning() when
684 tny_folder_store_get_folders() returns an empty list for the maildir.
686 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
687 Add a g_warning() when this returns NULL, because that it not allowed
690 2007-07-02 Armin Burgmeier <armin@openismus.com>
692 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
693 note when trying to cancel the wizard. This fixes projects.maemo.org
696 2007-07-02 Murray Cumming <murrayc@murrayc.com>
698 * src/modest-tny-account.h:
699 * src/modest-tny-account.c:
700 (modest_tny_account_new_from_server_account),
701 (modest_tny_account_new_from_server_account_name),
702 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
703 because this must now be set before setting the proto. This is usd in
704 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
705 warning in camel_session_get_service() caused by
706 tny_camel_transport_account_prepare().
708 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
711 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
713 * src/maemo/modest-connection-specific-smtp-edit-window.c:
715 (modest_connection_specific_smtp_edit_window_init):
717 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
720 2007-06-29 Murray Cumming <murrayc@murrayc.com>
722 * src/modest-tny-account.c:
723 (modest_tny_account_new_from_server_account):
724 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
725 now uses to request a connection when it needs one, and which it uses
726 to tell us that something is wrong with the connection, so we can force
727 the accounts offline to prevent further problems.
730 * src/modest-init.c: (init_default_settings):
731 * src/modest-mail-operation.c:
732 (modest_mail_operation_update_account):
733 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
734 This should not be necessary anymore. Do not set the conf key that
735 determined this (it was always TRUE and not set anywhere else).
737 * src/modest-ui-actions.h: Remove unused and unimplemented
738 modest_ui_actions_on_online_toggle_toggled().
740 2007-06-29 Murray Cumming <murrayc@murrayc.com
742 * src/maemo/modest-main-window.c: (connect_signals):
743 Don't connect to delete_event twice. Maybe this was harmless.
745 2007-06-29 Murray Cumming <murrayc@murrayc.com
747 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
748 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
749 Debug output to give some more clue when a folder move is not allowed.
751 2007-06-28 Murray Cumming <murrayc@murrayc.com
753 * src/modest-tny-account.c: (on_modest_file_system_info),
754 (modest_tny_account_get_mmc_account_name):
755 Always call the callback, without checking whether the name has changed.
756 * src/widgets/modest-folder-view.c: (strings_are_equal),
757 (on_model_foreach_set_name), (on_get_mmc_account_name),
758 (text_cell_data): Compare the name here, and use the name from
759 the account rather than from the
760 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
761 if the name was changed after the account was added to the model.
762 That's a tinymail bug but not one that I want to fix now.
764 This finally fixes projects.maemo.org bug NB#59301.
766 2007-06-27 Armin Burgmeier <armin@openismus.com>
768 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
771 2007-06-27 Murray Cumming <murrayc@murrayc.com
773 * src/modest-tny-account.h:
774 * src/modest-tny-account.c:
775 Added modest_tny_account_get_mmc_account_name(), to set the memory
776 card name asynchronously for the given account and then notify.
777 (modest_tny_account_new_for_local_folders): Use this new function instead
778 of using hildon_file_system_info_async_new() directly.
780 * src/widgets/modest-folder-view.c: (text_cell_data):
781 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
782 gtk_tree_model_row_changed() when it is available.
784 This should fix projects.maemo.org bug NB#59301.
786 2007-06-27 Murray Cumming <murrayc@murrayc.com
788 * src/modest-mail-operation.c: (update_account_thread),
789 (get_msgs_full_thread): Fix typo failures in the revert
792 2007-06-27 Murray Cumming <murrayc@murrayc.com
794 * src/maemo/modest-maemo-global-settings-dialog.c:
795 (idle_select_default_focus):
796 * src/modest-mail-operation.c: (idle_notify_progress),
797 (idle_notify_progress_once), (set_last_updated_idle),
798 (update_account_thread), (get_msgs_full_thread):
799 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
800 * src/widgets/modest-header-view.c:
801 (idle_notify_headers_count_changed_destroy),
802 (idle_notify_headers_count_changed):
803 Reverted the additions of gdk_threads_enter/leave(), in case this
804 helps with a startup hang on the device.
806 2007-06-26 Armin Burgmeier <armin@openismus.com>
808 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
809 for supported secure authentication methods from server by
810 gtk_dialog_run(), saving CPU time and a potential race condition.
812 2007-06-26 Armin Burgmeier <armin@openismus.com>
814 * src/maemo/modest-maemo-utils.h:
815 * src/maemo/modest-maemo-utils.c: Added a
816 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
817 only error code to tell the calling code when the user canceled the
820 * src/maemo/modest-account-settings-dialog.h:
821 * src/maemo/modest-account-settings-dialog.c:
822 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
823 message if the retrieval of secure authentication methods was canceled
824 by the user. Perform the check before saving anything to configuration
825 to not end up with half-committed configuration changes, do not show
826 a "Saving to configuration failed" note when authentication methods
827 could not be retrieved.
829 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
832 2007-06-26 Murray Cumming <murrayc@murrayc.com>
834 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
835 Only return the first level of folders under accounts, because the
836 osso-global-search UI spec doesn't want the rest.
837 This fixed projects.maemo.org bug NB#61811.
839 2007-06-26 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-tny-account-store.c:
842 * src/modest-tny-account-store.h:
843 Added modest_tny_account_is_memory_card_account().
844 * src/maemo/modest-main-window.c: (create_details_widget):
845 Show the same information items for the memory card as we show for the
846 local-folders, to fix projects.maemo.org bug NB#59307.
848 2007-06-26 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-tny-account-store.c: (get_password):
851 Added some checks for NULL to maybe prevent crashes, though I think
852 it was Philip's last commit that actually prevented the crash here
853 when creating a first new account.
854 But the new account is still not usable (no messages are shown)
855 until a restart of the application.
857 2007-06-26 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/modest-maemo-global-settings-dialog.c:
860 (idle_select_default_focus):
861 * src/modest-mail-operation.c: (idle_notify_progress),
862 (idle_notify_progress_once), (idle_notify_update_account_queue),
863 (set_last_updated_idle), (update_account_thread),
864 (notify_get_msgs_full), (get_msgs_full_destroyer),
865 (get_msgs_full_thread):
866 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
867 * src/widgets/modest-header-view.c:
868 (idle_notify_headers_count_changed_destroy),
869 (idle_notify_headers_count_changed):
870 Use gdk_threads_enter() and gdk_threads_enter_leave() in
871 all idle handlers, because some other thread could be blocking
872 the GDK lock, so that it can do GUI stuff.
874 2007-06-26 Murray Cumming <murrayc@murrayc.com>
876 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
877 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
878 (on_idle_send_receive), (on_idle_open_default_inbox):
879 * src/maemo/modest-msg-edit-window.c:
880 (modest_msg_edit_window_attach_file_noninteractive):
881 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
882 to prevent a hang. I don't quite understand why these are necessary,
883 beause we should already be in the main loop. I guess something outside
884 of the main loop is taking the lock.
886 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
887 we are really using URIs, and use files that are more likely to exist.
889 2007-06-26 Murray Cumming <murrayc@murrayc.com>
891 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
892 necessary because configure.ac now defines different variables.
894 2007-06-26 Murray Cumming <murrayc@murrayc.com>
896 * libmodest-dbus-client/libmodest-dbus-client.c:
897 * libmodest-dbus-client/libmodest-dbus-client.h:
898 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
899 libmodest_dbus_client_compose_mail() is what things actually use.
901 * src/dbus_api/modest-dbus-api.h:
902 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
903 * tests/dbus_api/Makefile.am:
904 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
907 2007-06-26 Murray Cumming <murrayc@murrayc.com>
909 * src/modest-init.c: (modest_init_local_folders):
910 For memory-card (or other non local-folders) maildir accounts,
911 always create an Archive folder, so that there is somewhere to put
912 messages. This should be less confusing, because the user does not need
913 to guess that the need to create a folder.
915 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
917 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
918 Fixed icon size by using (50, 50) which is the same as defined by
921 2007-06-25 Armin Burgmeier <armin@openismus.com>
923 * src/widgets/modest-window-mgr.c:
925 * configure.ac: Correctly recognize hildon-notify presence and fixed
926 the build without it being installed.
928 2007-06-25 Murray Cumming <murrayc@murrayc.com>
930 * libmodest-dbus-client/libmodest-dbus-client.c:
931 (libmodest_dbus_client_search): Fix the build. Sorry.
932 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
933 (reply_forward_cb): Initialize variables to fix the build.
935 * src/modest-tny-account-store.c:
936 (modest_tny_account_store_get_tny_account_by): Fix the account URI
937 comparison (a silly typo) so that email search results can be opened
938 when there are more than one account.
940 2007-06-25 Murray Cumming <murrayc@murrayc.com>
942 * libmodest-dbus-client/libmodest-dbus-client.c:
943 (libmodest_dbus_client_search),
944 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
945 instead of 1 second, because the search gets folders and messages from
946 the server, which can take a long time. When it times out,
947 osso-global-search will report no results.
949 We need to specify whether we should search only cached information
950 (maybe with a user preference), and the osso-email-search-plugin
951 API should really be improved to allow that option, and to allow results
952 to be delivered asynchronously in batches.
954 2007-06-25 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
957 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
958 GTK_ICON_SIZE_DIALOG is probably the wrong size.
960 2007-06-25 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
963 that is an empty string. D-Bus seems to give us these instead of NULL.
965 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
967 * src/dbus_api/modest-dbus-callbacks.c:
968 * src/maemo/easysetup/modest-easysetup-wizard.h:
969 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
971 (modest_connection_specific_smtp_edit_window_init):
972 * src/maemo/modest-maemo-global-settings-dialog.c:
974 * src/maemo/modest-maemo-utils.c:
975 (modest_maemo_utils_setup_images_filechooser):
976 * src/maemo/modest-main-window.c: (create_details_widget):
977 * src/maemo/modest-msg-edit-window.c:
978 (modest_msg_edit_window_attach_file_noninteractive),
979 (modest_msg_edit_window_color_button_change),
980 (modest_msg_edit_window_set_zoom):
981 * src/modest-mail-operation.c: (update_account_thread):
982 * src/modest-tny-account-store.c:
983 * src/modest-tny-account.c:
984 * src/widgets/modest-global-settings-dialog.c:
985 * src/widgets/modest-window.h:
989 2007-06-25 Murray Cumming <murrayc@murrayc.com>
991 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
992 * src/modest-search.c: (modest_search_folder),
993 (modest_search_all_accounts): Actually search only in the specified folder,
994 doing a simple match on the folder ID.
995 * src/modest-search.h: Added a folder field to the ModestSearch struct,
996 and added some documentation.
998 2007-06-22 Armin Burgmeier <armin@openismus.com>
1000 * src/maemo/modest-maemo-utils.h:
1001 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1002 modest_maemo_utils_get_supported_secure_authentication_methods.
1004 * src/maemo/easysetup/modest-easysetup-wizard.c:
1005 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1006 one occured, not just "Server does not support secure authentication".
1008 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-tny-account-store.c: (get_password):
1011 Restored the call to tny_account_set_user() because Philip seems to have
1012 stopped this from crashing (by not using the freed string). It still does
1013 not work, but now we can test it.
1015 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1017 * src/maemo/modest-msg-edit-window.c: (init_window):
1018 Comment out use of an uninitialzed GtkScrolledWindow variable,
1019 to fix the build and stop a crash. Yet again.
1021 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1023 * src/modest-tny-account-store.c: (get_password):
1024 Remove the call to tny_account_set_user() because this actually crashes.
1025 As mentioned in the last commit, it is known to not work anyway.
1027 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1029 * src/modest-tny-account-store.c: (get_password):
1030 Use tny_account_set_username() to tell tinymail that the username might
1031 have changed too. But tinymail ignores this: see projects.maemo.org
1033 * src/modest-ui-actions.c:
1034 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1035 reset the connection when changing the username, and improve the comments.
1036 Save the changed username to gconf at least, so it is used when Modest is
1039 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1041 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1042 Do not use a query, so that we get all folders, including for POP and
1043 local-folders. They work as search criteria too.
1044 This fixes projects.maemo.org bug NB#57740.
1046 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1048 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1049 Comment out the use of hildon_notification_set_sound() because it is
1050 not declared, to fix the build. Warnings are serious, people.
1052 2007-06-21 Armin Burgmeier <armin@openismus.com>
1054 * src/maemo/modest-maemo-utils.h:
1055 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1056 modest_maemo_utils_get_supported_secure_authentication_methods()
1057 to query authentication methods for a specific user. This should fix
1058 projects.maemo.org bug NB#61369.
1060 * src/maemo/easysetup/modest-easysetup-wizard.c:
1061 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1064 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1066 * libmodest-dbus-client/libmodest-dbus-client.h:
1067 * libmodest-dbus-client/libmodest-dbus-client.c:
1068 (modest_dbus_message_iter_get_search_hit),
1069 (libmodest_dbus_client_search):
1070 Reorganised and commented this.
1071 Removed modest_search_hit_free() from the public API because it
1074 Added libmodest_dbus_client_get_folders() and
1075 modest_folder_result_list_free().
1077 * src/dbus_api/modest-dbus-api.h:
1078 * src/dbus_api/modest-dbus-callbacks.c:
1079 (modest_dbus_req_filter): Commented. Moved most code to
1080 on_dbus_method_search() and added on_dbus_method_get_folders().
1082 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1083 of the extra D-Bus handler.
1085 * tests/dbus_api/Makefile.am:
1086 * tests/dbus_api/test_get_folders.c: New test for
1087 libmodest_dbus_client_get_folders(). This seems to return an empty list
1088 at the moment. That could be the same error that causes the message list
1089 to be empty sometimes.
1090 This should help with projects.maemo.org bug NB#57740.
1092 2007-06-21 Armin Burgmeier <armin@openismus.com>
1094 * src/modest-mail-operation.c: Do not call
1095 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1096 notify the operation's end after having set the status to CANCELED for
1097 the operation queue to listen on. This fixes a deadlock when there
1098 were mail operations in the queue during its finalization.
1100 * src/modest-singletons.c: Reordered uninitialization of the account
1101 manager to happen after the mail operation queue was uninitialized
1102 because the mail operation's in the queue might still try to access
1103 the account manager (see modest_mail_operation_notify_end()). This
1104 fixes a potential crash when terminating the application.
1106 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1108 * src/modest-search.c:
1109 (search_mime_part_and_child_parts): Moved some code here so we
1110 can search recursively in child folders.
1111 (modest_search_folder): Search in the message as a mime part, instead
1112 of just its child mime parts.
1113 (read_chunk), (search_mime_part_ogs):
1114 Check how many bytes were read, to prevent an endless loop.
1115 Searching in message bodies now works. This finishes the fix for
1116 projects.maemo.org bug NB#61007.
1118 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1120 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1121 Add a g_warning when the item is not a folder.
1123 * src/modest-ui-dimming-rules.c:
1124 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1125 when selected item is not a folder (for instance, an account), because
1126 the UI spec only talks about folders.
1127 I am not sure what the UI spec wants, so this might not totally fix
1128 projects.maemo.org bug NB#60794.
1130 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1133 (load_from_file): Sort the list. The unsorted list would be more noticeable
1134 in non-English locales.
1136 * src/maemo/modest-msg-edit-window.c:
1137 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1138 warning and fix the build.
1140 * src/maemo/modest-progress-bar-widget.c:
1141 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1142 avoid a g_warning, and probably to avoid a crash.
1144 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-search.c: (modest_search_folder): Check for a GError
1147 when calling tny_folder_get_headers(), to show that this is not the cause
1150 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1152 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1153 Actually set the body query instead of the subject query.
1155 * src/modest-search.c: (search_mime_part_ogs),
1156 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1157 which would probably cause it to fail if we got this far.
1159 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1160 to simplify the code.
1161 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1162 be causing search-in-body to fail.
1164 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1166 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1168 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1169 Better debug message when the folder cannot be found.
1170 This should help with fixing projects.maemo.org bug #61287.
1171 * src/modest-search.c: (add_hit): Do not leak the furl string.
1173 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-ui-actions.c:
1176 (modest_ui_actions_on_folder_selection_changed):
1177 Do not special-case TNY_MERGE_FOLDER here, because
1178 modest_tny_folder_get_account() already does that. This fixes
1179 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1180 shown when the Outbox was selected).
1182 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1184 * libmodest-dbus-client/libmodest-dbus-client.c:
1185 (_dbus_iter_get_string_or_null): Initialize the string variable in
1186 case this helps with Dirk's crash.
1188 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1190 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1191 though it is not implemented yet (this function is maybe not even used),
1192 to avoid breaking ABI in future.
1193 * libmodest-dbus-client/libmodest-dbus-client.c:
1194 (get_attachments_string): Moved some code into this generic function.
1195 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1196 sends email. It is maybe not used.
1197 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1198 (on_send_mail): Use attachments.
1200 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1201 * src/maemo/modest-msg-edit-window.c:
1202 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1203 a filename before using it, to fix projects.maemo.org bug NB#58233.
1205 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1208 Initialize the continue_download variable to fix the build, and probably
1209 to fix randome behaviour.
1211 2007-06-18 Armin Burgmeier <armin@openismus.com>
1213 * src/modest-tny-send-queue.h:
1214 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1215 the queue so we can later show it in the UI. Replaced
1216 modest_tny_send_queue_msg_is_being_sent() by
1217 modest_tny_send_queue_get_msg_status().
1219 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1221 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1222 gpointer. This probably was not harmful, but just to be sure.
1224 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1226 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1227 Fix the build, but leave the function broken on Bora, because
1228 hildon_uri_action_get_service() does not exist.
1229 osso_uri_action_get_service() does not exist either, it seems.
1231 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1233 * src/modest-tny-account.c:
1234 (modest_tny_account_new_from_server_account):
1235 Uncommented the url debug output again, because it is useful for
1236 debugging, as I said in the comment.
1238 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1240 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1242 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1243 for Mameo Bora, to fix the build.
1245 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1248 Fixed build with hildon < 0.99
1250 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1251 Check if the selected account is busy instead of checking all accounts
1253 * src/modest-account-mgr-priv.h:
1254 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1255 (modest_account_mgr_init), (compare_account_name),
1256 (modest_account_mgr_set_account_busy),
1257 (modest_account_mgr_account_is_busy):
1258 * src/modest-account-mgr.h:
1259 Added busy information to the account manager. It possible to
1260 set an account to busy or not busy now.
1262 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1263 (modest_mail_operation_update_account),
1264 (modest_mail_operation_notify_end):
1265 Set the account to busy/not busy depending on the operation state.
1267 * src/widgets/modest-account-view.c:
1268 (modest_account_view_finalize), (get_last_updated_string),
1269 (update_account_view), (on_account_busy_changed), (init_view):
1270 Show string "Refreshing..." if the account is currently busy.
1272 All this fixes projects.maemo.org bug NB#59711
1274 2007-06-14 Armin Burgmeier <armin@openismus.com>
1276 * src/widgets/modest-attachments-view.h:
1277 * src/widgets/modest-attachments-view.c: Added
1278 modest_attachments_view_has_attachments() and fixed coordinate
1279 transformation in get_att_view_at_coords(). This fixes attachment
1282 * src/widgets/modest-msg-view.c: Make use of
1283 modest_attachments_view_has_attachments() to decide whether to show
1284 attachments in the header.
1286 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1288 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1289 (on_change), (on_combo_security_changed),
1290 (modest_connection_specific_smtp_edit_window_init),
1291 (modest_connection_specific_smtp_edit_window_set_connection),
1292 (modest_connection_specific_smtp_edit_window_is_dirty):
1293 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1294 * src/maemo/modest-connection-specific-smtp-window.c:
1297 Show an comfirmation dialog for the smpt-edit-window if there are
1298 unsaved changes and the user hits cancel.
1299 (projects.maemo.org bug NB#60479)
1301 2007-06-14 Armin Burgmeier <armin@openismus.com>
1303 * src/maemo/easysetup/modest-easysetup-wizard.c:
1304 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1305 address" info in banner instead of node, and select all the text as
1306 per UI spec. This fixes projects.maemo.org bug NB#60550.
1308 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1310 reviewed by: <delete if not using a buddy>
1312 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1313 * src/modest-ui-actions.c: (folder_refreshed_cb):
1315 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1317 * src/widgets/modest-folder-view.c: (filter_row):
1318 Explictly filter out the per-account outbox accounts. I don't know why
1319 these only sometimes show up, but now they should never show up in the UI.
1320 This should fix projects.maemo.org bug NB#60160.
1322 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1325 when the toolbar does not exist yet.
1326 * src/modest-widget-memory.c: (save_settings_header_view):
1327 Added g_warnings() to help us to discover when we are trying to set
1328 an empty columns list in gconf.
1330 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-init.h:
1333 * src/modest-init.c:
1334 Added modest_init_get_default_header_view_column_ids().
1336 * src/modest-widget-memory.c: (restore_settings_header_view):
1337 Use the new function to get defaults, if the gconf key is empty,
1338 instead of not creating any columns. This seems to fix the
1339 empty right-hand pane problems.
1341 * src/widgets/modest-header-view.h: Improved documentation.
1343 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1345 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1346 Revert the use of the display name as the account name, because this
1347 is generally wrong and would break the code that follows.
1349 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1351 * src/maemo/easysetup/modest-easysetup-wizard.c:
1352 (check_for_supported_auth_methods), (on_before_next),
1355 More correct fix for projects.maemo.org bug NB# 58991
1356 Do not longer accept AUTH_PASSWORD as secure method and choose
1357 correct method when creating the account.
1359 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1361 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1362 Fixed projects.maemo.org bug NB# 58991
1364 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-init.c: (modest_init_init_core),
1367 (modest_init_local_folders): Fixed compilation errors.
1369 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1371 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1372 Remove unnecessary lib/include, though it is good in principle when needed.
1374 * src/modest-init.c: (modest_init_one_local_folder),
1375 (modest_init_local_folders):
1376 * src/modest-init.h: Initialize the .modest library for memory cards,
1377 instead of just doing nothing for them. This should allow us to create
1378 folders there, fixing projects.maemo.org bug NB#59297.
1380 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1382 * libmodest-dbus-client/libmodest-dbus-client.c:
1383 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1384 (libmodest_dbus_client_compose_mail),
1385 (libmodest_dbus_client_open_message),
1386 (libmodest_dbus_client_send_and_receive),
1387 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1389 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1390 (on_idle_open_message), (modest_dbus_req_handler),
1391 (search_result_to_message), (modest_dbus_req_filter):
1392 * src/modest-search.c: (add_hit), (modest_search_folder),
1393 (modest_search_all_accounts): Improved debug messages.
1395 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1397 * src/modest-tny-account-store.c:
1398 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1401 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1404 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-tny-account-store.c: (get_server_accounts):
1407 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1408 even when there are no accounts, so that the Outbox folder is always
1409 visible. This fixes projects.maemo.org bug NB#60158.
1411 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1413 * src/maemo/modest-main-window.c: (create_details_widget):
1414 Use the mcen_va_never logical ID.
1416 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1418 * src/dbus_api/modest-dbus-api.h:
1419 * src/dbus_api/modest-dbus-callbacks.c:
1420 (on_idle_open_default_inbox), (on_open_default_inbox),
1421 (modest_dbus_req_handler):
1422 Added a new OpenDefaultInbox method.
1424 * libmodest-dbus-client/libmodest-dbus-client.h:
1425 * libmodest-dbus-client/libmodest-dbus-client.c:
1426 Added libmodest_dbus_client_open_default_inbox() to call the new
1427 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1428 though it should maybe be used by a new osso-email-interface function.
1430 * tests/dbus_api/Makefile.am:
1431 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1434 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1437 NULL, so that the signals get all the keys. This should not actually
1438 change any behaviour because we currently update everything when anything
1441 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1443 * src/widgets/modest-folder-view.c: (text_cell_data),
1444 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1445 (find_inbox_iter): If tinymail tells us that the folder is
1446 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1447 This causes the inbox to be selected at startup, fixing part of
1448 projects.maemo.org bug NB#56305.
1450 * src/modest-ui-dimming-rules.c:
1451 (modest_ui_dimming_rules_on_tools_smtp_servers):
1452 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1453 the SMTP servers menu item.
1454 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1455 that the SMTP Servers menu item is dimmed when there are no accounts,
1456 as a future version of the UI spec will require. This fixes
1457 projects.maemo.org bug NB#56305.
1459 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1461 * src/maemo/modest-maemo-utils.c:
1462 (modest_maemo_utils_get_supported_secure_authentication_methods):
1463 Added label to dialog instead of unreadable title
1465 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1466 (modest_main_window_new):
1467 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1470 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1471 * src/modest-account-mgr.h:
1472 Added method to avoid code duplication
1474 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1475 (modest_ui_actions_on_send_receive):
1476 Use modest_account_mgr_has_accounts
1478 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1480 * src/maemo/easysetup/modest-presets.c:
1481 (modest_presets_get_info_server_security): Do not report secure auth
1483 * src/modest-protocol-info.c: Use the defines for the gconf key names
1484 for secure authentication. This was not working because we were writing
1485 Password and reading password, and the check was case sensitive.
1486 With this, gmail now works for receiving and sending when created via
1489 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1491 * src/maemo/easysetup/modest-presets.c:
1492 (modest_presets_get_info_server_security): Correct the key name for
1493 SecureSmtp, because it seems to be case-sensitive.
1494 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1495 Do not try to get the 0th notebook page if there are 0 pages, to
1496 avoid a g_warning().
1498 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1501 Prevent use of the new notification feature for now, because it currently
1502 shows one dialog for each new email, which is annoying.
1504 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1507 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1508 when no country was selected, so that we show the global ones.
1509 * src/maemo/easysetup/modest-presets.c:
1510 (modest_presets_get_providers): Return only the global providers, not
1511 all providers when mmc=0 was requested.
1513 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1516 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1517 provider ID in the combo.
1519 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1520 Do not show the page numbers, because it would be confusing when we add
1521 the 2 extra pages for the custom setup, when the user chooses the "Other"
1522 provider. This fixes projects.maemo.org bug NB#59028
1524 * src/modest-init.c: (modest_init_init_core),
1525 (modest_init_local_folders):
1526 * src/modest-init.h:
1527 * src/modest-tny-account.c:
1528 (modest_tny_account_new_for_local_folders): Do not create default folders
1529 for the memory card. This should fix projects.maemo.org bug NB#59328.
1531 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1534 Free the changed_conf_keys string items. They are already freed in the
1535 idle handler if that runs first.
1537 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-ui-actions.c:
1540 (modest_ui_actions_on_password_requested): Check that the server name
1541 is not NULL, because I just saw a password dialog with (null) as the
1544 * src/modest-tny-folder.[h|c]: Added
1545 modest_tny_folder_is_memory_card_folder().
1546 * src/modest-ui-dimming-rules.c:
1547 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1548 menu item for memory cards, as per the UI spec (section 7.4). This should
1549 fix projects.maemo.org bug NB#59297.
1551 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1553 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1554 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1555 is another problem with the code, see Murray's comment at line 772)
1557 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1560 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1561 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1562 (load_from_file), (easysetup_country_combo_box_init),
1563 (easysetup_country_combo_box_get_active_country_ids),
1564 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1565 instead of just one ID, to avoid duplicate country names in the UI.
1567 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1568 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1569 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1570 a single ID, avoiding duplicate providers.
1571 * src/maemo/easysetup/modest-easysetup-wizard.c:
1572 (on_combo_account_country): Adapt to use a list.
1574 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1576 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1577 keys changed in the last X seconds.
1579 * src/modest-account-mgr.h:
1580 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1581 (on_key_change), (modest_account_mgr_class_init),
1582 (modest_account_mgr_init), (modest_account_mgr_finalize):
1583 As the keys are changed, save them in a GSList* and signal that GSList*
1584 further every X seconds, to batch changes, to allow us to do just one
1585 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1586 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1588 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1589 changed signal signature.
1591 * src/modest-conf.c: (modest_conf_set_list),
1592 (modest_conf_on_change): Reenable notification.
1594 (modest_conf_maemo_fake_on_change): Comment out the hack that
1595 notified immediately instead of asynchronously.
1597 * src/widgets/modest-account-view.h:
1598 * src/widgets/modest-account-view.c:
1599 (update_account_view): Select the previously-selected account ID,
1600 if possible. This fixes projects.maemo.org bug NB#56933.
1602 (on_account_changed), (on_account_removed),
1603 (modest_account_view_select_account):
1605 Remove the block/unblock functions
1606 because they were not useful.
1608 * src/maemo/modest-account-view-window.c:
1609 (on_delete_button_clicked), (on_edit_button_clicked),
1610 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1612 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1614 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1615 Improve the error dialog to show Incorrect Account Settings, which seems
1616 clearer, and say that the internal error message (to be removed from the
1617 dialog later) is often misleading.
1618 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1620 * src/modest-tny-account.c:
1621 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1622 URL because this is so useful for debugging on the device.
1624 * src/widgets/modest-serversecurity-combo-box.c:
1625 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1627 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1629 * src/modest-mail-operation.c:
1630 (modest_mail_operation_send_new_mail):
1631 Added a comment about a nasty but apparently harmless message. Details
1632 added to the wiki g_warnings() page.
1634 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1636 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1637 (modest_tny_send_queue_class_init):
1638 Do not use the priv struct because it is empty, to avoid g_warnings
1639 about a non-existant priv struct.
1641 * src/modest-tny-account-store.c:
1642 (modest_tny_account_store_get_server_account),
1643 (modest_tny_account_store_get_transport_account_for_open_connection
1644 ): Do not try to get transport server accounts for local folders,
1645 because they don't have any. This avoids a g_warning().
1647 * src/maemo/modest-main-window.c:
1648 (modest_main_window_notify_send_receive_initied),
1649 (on_configuration_key_changed):
1650 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1651 * src/modest-defs.h:
1652 * src/modest-mail-operation.c:
1653 (modest_mail_operation_update_account):
1654 * src/modest-tny-account-store.h:
1655 * src/modest-tny-account.c:
1656 (modest_tny_account_get_special_folder),
1657 (modest_tny_account_new_for_local_folders),
1658 (modest_tny_account_new_for_per_account_local_outbox_folder):
1659 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1660 * src/modest-tny-local-folders-account.c:
1661 (add_account_folders_to_merged_folder):
1662 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1663 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1664 (modest_ui_actions_on_send):
1665 * src/widgets/modest-folder-view.c: (update_model):
1666 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1667 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1668 modest_tny_account_store_get_tny_account_by_account() to
1669 modest_tny_account_store_get_server_account() to make the code clearer.
1671 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1673 * src/dbus_api/modest-dbus-api.h:
1674 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1675 * src/maemo/modest-msg-edit-window.c:
1676 (modest_msg_edit_window_attach_file_noninteractive):
1677 added g_warning in case the file to be attached does not exist
1678 * tests/dbus_api/test_compose_mail.c: (main):
1679 removed obsolete comment, added generic files as test case
1681 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1683 * src/modest-tny-account-store.c: (get_server_accounts):
1684 Create the local folders account only once, not once for each outbox, and
1685 not only when there are some outboxes.
1687 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1689 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1690 code that is causing a crash at startup. Sergio says that he is fixing this.
1692 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1694 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1695 * src/maemo/modest-account-settings-dialog.c:
1696 (create_page_outgoing),
1697 (modest_account_settings_dialog_set_account_name),
1698 (save_configuration):
1699 - Fixed handling of the "Use secure authentication" toggle to comply with
1700 the ui specification. See also projects.maemo.org bug NB#58400
1702 - Restore the Secure connection setting combo correctly when loading
1705 * src/maemo/modest-maemo-utils.c:
1706 (on_camel_account_get_supported_secure_authentication),
1707 (modest_maemo_utils_get_supported_secure_authentication_methods):
1708 Fixed a crasher if operation is canceled
1710 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1711 (modest_protocol_info_auth_is_secure):
1712 * src/modest-protocol-info.h:
1714 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1715 the sense of the "Use secure authentication" toggle.
1717 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1719 * src/modest-tny-account-store.h:
1720 * src/modest-tny-account-store.c:
1721 Added modest_tny_account_store_get_local_folders_account().
1723 * src/modest-tny-folder.h:
1724 * src/modest-tny-folder.c:
1725 (modest_tny_folder_get_account):
1726 Added this replacement for tny_folder_get_account() which returns
1727 the local-folders account for TnyMergeFolders, to avoid the
1728 warning about the unimplemented get_account_func() vfunc().
1730 (modest_tny_folder_get_rules),
1731 * src/modest-ui-actions.c:
1732 (modest_ui_actions_on_folder_selection_changed):
1733 * src/modest-mail-operation.c:
1734 (modest_mail_operation_remove_folder),
1735 (modest_mail_operation_xfer_folder),
1736 (modest_mail_operation_rename_folder),
1737 (modest_mail_operation_get_msg),
1738 (modest_mail_operation_get_msgs_full),
1739 (modest_mail_operation_remove_msg),
1740 (modest_mail_operation_xfer_msgs),
1741 (modest_mail_operation_refresh_folder):
1742 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1744 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1747 (modest_server_account_set_security):
1748 * src/modest-defs.h: Add comments explaining that our
1749 UI spec means TLS when it says Normal, so these do not look like errors.
1751 * src/modest-tny-account.c:
1752 (modest_tny_account_new_from_server_account): Use the new tinymail
1753 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1754 for TLS. This should fix projects.maemo.org bug NB#58460.
1756 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/easysetup/modest-easysetup-wizard.c:
1759 (create_account): Correct the position of the gconf sanity check warning.
1760 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1761 of using the g_idle_add() hack, because this does not seem to be necessary
1762 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1763 caused by something other than maemo's gconf.
1764 This fixes projects.maemo.org bug #59022.
1766 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-account-mgr-helpers.c:
1769 (modest_account_mgr_get_default_account): Do not check that the account
1770 exists if there is no default account (NULL), to fix a runtime warning.
1772 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1774 * src/widgets/modest-folder-view.c: (update_model):
1775 Do not unref the treemodel before we have finished with it.
1776 This prevents a valgrind warning and an occasional crash at startup.
1778 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1780 * libmodest-dbus-client/libmodest-dbus-client.h:
1781 added libmodest_dbus_client_compose_mail()
1782 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1784 added functions needed for SendAsMail() functionality
1785 * src/maemo/modest-msg-edit-window.c:
1786 (modest_msg_edit_window_attach_file_noninteractive):
1787 non interactively attaching files to message edit window
1788 * src/widgets/modest-msg-edit-window.h:
1789 * tests/dbus_api/Makefile.am:
1790 added test_compose_mail.c
1791 * tests/dbus_api/test_compose_mail.c: (main):
1793 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1795 * src/modest-account-view.c:
1796 Fixed bug projects.maemo.org bug NB#59307
1798 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1800 * src/maemo/easysetup/modest-easysetup-wizard.c:
1801 (get_serverport_incoming), (on_before_next), (create_account):
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (modest_account_settings_dialog_set_account_name):
1804 * src/maemo/modest-maemo-utils.c:
1805 (on_camel_account_get_supported_secure_authentication_status),
1806 (on_camel_account_get_supported_secure_authentication),
1807 (on_secure_auth_cancel),
1808 (modest_maemo_utils_get_supported_secure_authentication_methods):
1810 Implemented security authentication for settings and easysetup.
1812 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/modest-main-window.c: (create_details_widget):
1815 Show the total size for memory card accounts too, instead of showing
1816 the name again. Fixes bug projects.maemo.org bug NB#59307.
1818 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1821 * src/modest-tny-simple-folder-store.c:
1822 * src/modest-tny-simple-folder-store.h: Removed.
1824 * src/modest-tny-local-folders-account.h
1825 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1826 for the local-folders maildir, with an extra TnyMergedFolder containing
1827 the folders of the per-account outbox store accounts.
1828 * src/modest-tny-account-store.c: (get_server_accounts):
1829 Add the outboxes to the special local folders account after creating it.
1831 * src/modest-tny-account.c:
1832 (modest_tny_account_new_for_local_folders): Create the derived
1833 account when creating the main local-folders account.
1835 * src/maemo/modest-main-window.c: (create_details_widget),
1836 (modest_main_window_set_contents_style):
1837 Adapted to the use of the derived account instead of the folder store.
1839 * src/modest-ui-actions.c:
1840 (modest_ui_actions_on_folder_selection_changed):
1841 * src/modest-ui-dimming-rules.c:
1842 (modest_ui_dimming_rules_on_new_folder):
1843 * src/widgets/modest-folder-view.c: (text_cell_data),
1844 (icon_cell_data), (filter_row), (update_model),
1845 (get_cmp_rows_type_pos):
1848 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1849 Do not get the priv struct, because no priv struct has been set,
1850 to avoid a runtime warning.
1852 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1853 #ifelse with #else, to fix a warning, to fix the build.
1856 2007-06-05 Christian Kellner <ckellner@openismus.com>
1858 * libmodest-dbus-client/libmodest-dbus-client.c:
1859 Fix small typo in doc (why do you always see them
1860 AFTER committing stuff?)
1863 2007-06-05 Christian Kellner <ckellner@openismus.com>
1865 * libmodest-dbus-client/libmodest-dbus-client.c:
1866 (libmodest_dbus_client_search):
1867 Initialize hit list with NULL. Also set folder list
1868 to "" if NULL was supplied.
1871 2007-06-03 Christian Kellner <ckellner@openismus.com>
1873 * libmodest-dbus-client/libmodest-dbus-client.c:
1874 (modest_search_hit_list_free):
1875 Make it save to call it with NULL.
1877 * src/dbus_api/modest-dbus-callbacks.c:
1878 * src/modest-search.c:
1879 Return full ModestSearchHits as the search result list not TnyHeader
1880 since can't be around withouth the correspoding TnyFolder.
1882 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1884 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1885 Added currently commented code to check for secure auth
1887 * src/maemo/modest-account-settings-dialog.c: (on_response),
1888 (save_configuration), (show_ok):
1889 Fixed projects.maemo.org bugs NB #59248 and #59251
1891 * src/maemo/modest-maemo-utils.c:
1892 (on_camel_account_get_supported_secure_authentication_status),
1893 (on_camel_account_get_supported_secure_authentication),
1894 (modest_maemo_utils_get_supported_secure_authentication_methods):
1895 * src/maemo/modest-maemo-utils.h:
1896 Moved get_supported_secure_authentication() method here to be able
1897 to use it from easysetup wizard.
1899 * src/modest-pair.c: (on_pair_compare_as_string):
1900 Should compare string with first part of pair and not
1901 strcmp pairs which will crash.
1903 * src/modest-protocol-info.c:
1904 (modest_protocol_info_protocol_is_store):
1905 * src/modest-protocol-info.h:
1906 Added modest_protocol_info_get_auth_protocol_name()
1908 2007-06-03 Armin Burgmeier <armin@openismus.com>
1910 * src/modest-mail-operation.c:
1911 (modest_mail_operation_get_msgs_full): Set priv->account also when
1912 only retrieving a single message. This avoids a crash when canceling
1915 (modest_mail_operation_notify_end): Do not explicitely remove the
1916 operation from the queue but only emit the progress_changed signal.
1917 The queue itself listens to that signal to remove the operation when
1918 it is finished. This reduces coupling and removes a potential deadlock
1919 when modest_mail_operation_notify_end() is called from the queue
1920 itself. If that is a problem performance-wise, I would suggest to
1921 implement a status-changed signal or something.
1923 * src/modest-mail-operation-queue.c: Make sure to never call a
1924 function from another file while the queue is locked. This (hopefully)
1925 fixes another deadlock when exiting the application while retrieving
1928 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1930 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1931 Fixed build if libogs is not available
1933 2007-06-03 Christian Kellner <ckellner@openismus.com>
1935 * libmodest-dbus-client/libmodest-dbus-client.h:
1936 * libmodest-dbus-client/libmodest-dbus-client.c:
1937 (libmodest_dbus_client_delete_message):
1938 Implement deletion of messages (Client side).
1940 (modest_search_hit_free),
1941 (modest_search_hit_list_free):
1942 Utility functions to free the result hits.
1944 * src/dbus_api/modest-dbus-api.h:
1945 * src/dbus_api/modest-dbus-callbacks.c:
1946 (on_delete_message),
1947 (modest_dbus_req_handler):
1948 Implement deletion of messages (Server side).
1950 * tests/dbus_api/test_search.c: (main):
1953 * tests/dbus_api/Makefile.am:
1954 * tests/dbus_api/test_delete_message:
1955 Add little test for the message deletion logic
1957 2007-06-03 Armin Burgmeier <armin@openismus.com>
1959 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1960 when the operation queue was not empty. projects.maemo.org bug
1963 2007-06-03 Armin Burgmeier <armin@openismus.com>
1965 * src/widgets/modest-account-view.c
1966 (on_account_default_toggled): Toggle default account column
1967 explicitely instead of waiting for gconf notification (which is
1968 currently ignored). This should fix projects.maemo.org bug NB#56910
1969 for now. It should probably be removed when gconf notifications are
1972 2007-06-03 Christian Kellner <ckellner@openismus.com>
1974 * libmodest-dbus-client/libmodest-dbus-client.c:
1975 Removed debugging spew.
1977 * src/dbus_api/modest-dbus-callbacks.c:
1978 Added debugging info.
1980 * src/modest-search.c:
1981 (modest_search_all_accounts):
1982 Use tny_account_store_get_accounts () on the account store
1983 to get all accounts which is the way to get all accounts.
1985 * tests/dbus_api/test_search.c: (main):
1986 Make it possible to supply the search term on the command line.
1988 2007-06-03 Christian Kellner <ckellner@openismus.com>
1990 * libmodest-dbus-client/libmodest-dbus-client.c:
1991 * libmodest-dbus-client/libmodest-dbus-client.h:
1992 Implement searching for mesages over raw dbus. (Client side)
1994 * src/dbus_api/Makefile.am:
1995 * src/dbus_api/modest-dbus-api.h:
1996 * src/dbus_api/modest-dbus-callbacks.c:
1997 * src/dbus_api/modest-dbus-callbacks.h:
1998 Search framework (Server side). Also implement on_idle_open_message().
2000 * src/maemo/modest-platform.c: (modest_platform_init):
2001 Prepare for raw dbus/osso rpc interaction.
2003 * src/modest-search.h:
2004 Changed minsize from unspecific guint to guint32.
2006 * src/modest-search.c:
2008 Added strange hack which magically made tnymail work.
2010 (modest_search_folder),
2011 (modest_search_account),
2012 (modest_search_all_accounts):
2013 Implement helper functions to search all accounts, specific account
2016 * tests/dbus_api/Makefile.am:
2017 * tests/dbus_api/test_open_message.c:
2018 Read url to open from commandline.
2020 * tests/dbus_api/test_search.c:
2021 Implement small test for dbus search stuff
2023 2007-06-02 Armin Burgmeier <armin@openismus.com>
2025 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2026 include account type and account title. This fixes projects.maemo.org
2029 * src/maemo/modest-account-view-window.c: Set a title for the window.
2031 2007-06-02 Armin Burgmeier <armin@openismus.com>
2033 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2034 incoming and outgoing server name based on email address and server
2035 types as long as the names have not been edited manually. This fixes
2036 projects.maemo.org bug NB#58671.
2038 2007-06-02 Armin Burgmeier <armin@openismus.com>
2040 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2041 server type cannot be changed in future to the incoming details page
2042 when creating an account. This fixes projects.maemo.org bug NB#59029.
2044 2007-06-02 Armin Burgmeier <armin@openismus.com>
2046 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2047 and assigned max width chars so that they wrap instead of being
2048 truncated. Fixes projects.maemo.org bug NB#56126.
2050 2007-06-02 Armin Burgmeier <armin@openismus.com>
2052 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2053 introductory note to the connection specific smtp servers dialog, as
2054 section 8.12 of the email UI specification requires. This fixes
2055 projects.maemo.org bug NB#59212.
2057 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2059 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2060 Check for running mail operations, and offer to cancel them, as per the UI
2061 spec. This fixes projects.maemo.org bug NB#59041 .
2062 However, I suspect that tinymail may still use the network connection
2063 in ways that we cannot detect or cancel. But it should at least adapt to
2064 changes fairly well.
2066 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-tny-account-store.c: (recreate_all_accounts),
2069 (get_cached_accounts), (get_server_accounts): Do more sensible
2070 ref-counting of the temporarily-cached outbox accounts list. This seems
2071 to fix a crash when entering the password when the password was wrong.
2073 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2075 * src/gnome/modest-main-window.c: (connect_signals):
2076 * src/modest-tny-account-store.c: (get_password),
2077 (modest_tny_account_store_alert): Added comments and clues and
2078 commented-out code about how we currently fail to deal with connection
2079 errors and wrong passwords, and how we should.
2081 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2083 * src/widgets/modest-retrieve-combo-box.c:
2084 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2085 This fixes projects.maemo.org bug NB#58472 .
2087 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2089 * src/maemo/easysetup/modest-easysetup-wizard.c:
2090 (create_page_complete_easysetup):
2091 (create_page_complete_custom): Correct the last commit,
2092 putting the correct sentences in the correct pages.
2094 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/easysetup/modest-easysetup-wizard.c:
2097 (create_page_complete_custom): Show the second sentence of text
2098 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2101 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2103 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2104 Set the leave-on-server conf key by default. This fixes
2105 projects.maemo.org bug NB#59258 .
2107 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2109 * src/maemo/modest-account-view-window.c:
2110 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2111 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2114 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/easysetup/modest-easysetup-wizard.c:
2117 (create_caption_new_with_asterisk):
2118 * src/maemo/modest-account-settings-dialog.c:
2119 (create_caption_new_with_asterisk):
2120 Uncomment the code to add the asterisk, because they are no longer in the
2121 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2122 (update_incoming_server_title): Add an asterisk here too.
2124 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/modest-maemo-global-settings-dialog.c:
2127 (current_connection): Check that we are even connected before trying to
2128 get the current connection name, to prevent a warning.
2130 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2131 Change the comments because tny_maemo_conic_device_connect() is now meant to
2133 * src/modest-mail-operation.c:
2134 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2135 make sure we have a connection and fail if we can't connect.
2137 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-main-window.c:
2140 (on_account_store_connecting_finished): Do not try to get the
2141 connection ID if we are not really connected. I am surprised that
2142 this signal handler is called when we are not connected.
2144 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2146 * src/modest-error.h:
2147 * src/modest-ui-actions.c:
2148 (modest_ui_actions_get_msgs_full_error_handler):
2149 Renamed an enum, added comments, added an enum
2150 for retrieve-limit errors.
2152 * src/modest-mail-operation.c: (foreach_add_item),
2153 (internal_folder_observer_update), (update_account_thread),
2154 (modest_mail_operation_get_msgs_full):
2155 (modest_mail_operation_update_account),
2156 Added comments about how this works, and some code that should
2157 (but does not) check the retrieve-limit. See the TODO comment.
2159 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2162 Initialize help_id to fix the build. Warnings are good.
2164 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2166 * src/widgets/modest-hbox-cell-renderer.c:
2167 (modest_hbox_cell_renderer_append):
2168 * src/widgets/modest-vbox-cell-renderer.c:
2169 (modest_vbox_cell_renderer_append):
2170 Fix the last commit by doing an extra ref.
2172 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2174 * src/widgets/modest-hbox-cell-renderer.c:
2175 (modest_hbox_cell_renderer_append):
2176 * src/widgets/modest-vbox-cell-renderer.c:
2177 (modest_vbox_cell_renderer_append):
2178 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2179 to fix the build with Maemo Bora.
2180 However, there seems to be a remaining crash, probably due to reference
2183 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2185 * src/modest-tny-account.c:
2186 (modest_tny_account_new_for_local_folders):
2187 Use hildon_file_system_info_async_new() to get a better name for
2188 the memory card account, setting it as the account name.
2189 The timing seems to work, but this is probably
2190 not the best place to do this. See the TODO comment.
2191 * src/maemo/modest-main-window.c: (create_details_widget):
2192 * src/widgets/modest-folder-view.c: (text_cell_data):
2193 Use the tny account name instead of hardcoding a name.
2195 2007-05-30 Christian Kellner <ckellner@openismus.com>
2197 * src/modest-search.c: (modest_search):
2198 Correctly set part_search_func even if we have already parsed
2199 the query and thus a valid OgsTextSearcher object.
2201 2007-05-30 Christian Kellner <ckellner@openismus.com>
2204 Search and check for libogs.
2207 Incooparte the ogs build env.
2209 * src/modest-mime-part-search-stream.c:
2210 * src/modest-mime-part-search-stream.h:
2211 Removed since we do the real searching now in modest-search.c.
2213 * src/modest-search.c:
2214 * src/modest-search.h:
2215 Implement support for ogs. We use that if available and requested
2216 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2217 should now handle the corner case when the search term is spread
2218 across multiple reads.
2219 Also the logic in modest_search () was corrected to search all
2220 requested fields until one is found.
2222 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2224 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2226 * src/modest-init.h:
2227 * src/modest-init.c: Made modest_init_local_folders() take a
2228 path and be public so we can iniitialize maildir folders on
2231 * src/modest-local-folder-info.h:
2232 * src/modest-local-folder-info.c:
2233 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2235 * src/modest-tny-account.c:
2236 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2237 still means the standard local-folders path on the local volume.
2239 * src/modest-tny-account-store.c:
2240 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2241 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2242 all accounts when that happens.
2243 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2244 this too, so it shows up in the treeview.
2246 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2248 * src/maemo/modest-maemo-global-settings-dialog.c:
2249 (current_connection):
2250 * src/widgets/modest-global-settings-dialog.c:
2251 (current_connection_default):
2252 Use the enum values instead of 0, 1 and -1,
2253 to make the code clearer.
2255 * src/modest-account-mgr-helpers.c:
2256 (modest_account_mgr_get_connection_specific_smtp): Make this code
2259 * src/modest-runtime.h:
2260 * src/modest-runtime.c:
2261 Added modest_runtime_remove_all_send_queues().
2262 * src/maemo/modest-main-window.c:
2263 (on_account_store_connecting_finished): Recreate the send queues,
2264 using the appropriate transport accounts for this new connection.
2265 Some futher adapting might be needed if the old send queues are not
2266 automatically stopped at this point.
2268 * src/modest-tny-account-store.c: (get_server_accounts):
2269 Create the connection-specific transport accounts, so that they can
2270 be found later by their ID.
2272 * src/modest-tny-account.h:
2273 * src/modest-tny-account.c:
2274 Added modest_tny_account_new_from_server_account_name().
2275 modest_tny_account_new_from_server_account(): Do not create the
2276 send queues here, because they will be
2277 recreated anyway when the connection changes for the first time.
2279 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-local-folder-info.h:
2282 * src/modest-local-folder-info.c:
2283 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2284 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2285 tbox_folder): Take a modest account name instead of a server TnyAccount,
2286 so we can have per-modest-account rather than per-transport-account
2288 We must make sure that we change or recreate the exisitng send queues
2289 when the connection changes for connection-specific transport accounts.
2291 * src/modest-tny-account-store.c:
2292 (create_per_account_local_outbox_folders): Create outboxed per modest
2293 account, not per transport account.
2295 * src/modest-tny-account.h:
2296 * src/modest-tny-account.c:
2297 (modest_tny_account_get_special_folder): For outboxes, get the
2298 parent modest account name. The account is ignored for other folders.
2299 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2300 modest account name rather than a server TnyAccount.
2302 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2304 * src/modest-tny-account.c:
2305 (modest_tny_account_new_from_server_account):
2306 Call modest_runtime_get_send_queue() immediately after creating transport
2307 accounts, so that they start trying to send email from the outbox as soon
2308 as possible at startup. This is probably what we want.
2310 * src/modest-mail-operation.c: (update_account_thread):
2311 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2312 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2313 * src/modest-tny-send-queue.h:
2314 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2315 (modest_ui_actions_on_send):
2316 Added comments about how sending works, though it needs some more work.
2318 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-tny-account.c:
2321 (modest_tny_account_get_special_folder): Add TODO because this fails when
2322 the network is busy.
2323 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2324 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2325 Do not try to show this window when there is no active account. The UI
2326 specs does not tell us what to do in this case.
2328 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2332 * src/maemo/Makefile.am:
2333 * src/widgets/Makefile.am: Some dist fixes.
2335 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2337 * src/maemo/modest-connection-specific-smtp-window.c:
2338 (on_button_edit): Make the code clearer, to prevent a double free.
2340 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/modest-account-settings-dialog.c:
2343 (modest_account_settings_dialog_set_account_name),
2344 Check the connection-specific smtp servers checkbox if there are any.
2346 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2347 (modest_connection_specific_smtp_edit_window_init):
2348 Start with a suitable port number.
2350 * src/modest-account-mgr-helpers.h:
2351 * src/modest-account-mgr-helpers.c: Added
2352 modest_account_mgr_get_has_connection_specific_smtp().
2354 (modest_account_mgr_set_connection_specific_smtp),
2355 (modest_account_mgr_remove_connection_specific_smtp),
2356 (modest_account_mgr_get_has_connection_specific_smtp),
2357 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2358 connection-specific smtp server accounts in the account, rather than
2359 the server account conf dir.
2361 This fixes bug projects.maemo.org bug NB#58263 .
2363 * src/modest-tny-account-store.c:
2364 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2365 if there are no server accounts yet, to prevent an infinite loop when there
2366 are no accounts. Document that one must be called before the other.
2368 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-account-mgr-helpers.c:
2371 (modest_account_mgr_get_default_account): Make sure that at least
2372 one account is always the default, if there are any enabled accounts.
2373 This is just a sanity check that shouldn't be necessary.
2375 * src/modest-account-mgr-priv.c:
2376 (_modest_account_mgr_account_from_key): Unescape the conf key to
2377 get the real account name. For instance, this is an issue if a space
2378 was in the account name, which can happen because the account name
2379 is generated from the display name.
2380 (_modest_account_mgr_get_account_keyname): Always escape the
2382 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2383 Unescape the conf keys to get the real account names.
2385 For instance, previously the is-default radio button in the accounts
2386 list was not checked for any accounts at first. This fixes that,
2387 and might fix several similar bugs.
2389 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2392 Removed some debug printfs.
2394 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2396 Modest on-disk outbox directories are now here, for instance:
2397 $HOME/.modest/outboxes/<account-id-1>/outbox
2398 $HOME/.modest/outboxes/<account-id-2>/outbox
2400 $HOME/.modest/local-folders/outbox
2401 so we can have a separate outbox for each account.
2402 But they are shown as one outbox in the GtkTreeView, by using a
2403 TnyMergeFolder in a ModestTnySimpleFolderStore.
2406 * src/modest-tny-simple-folder-store.c:
2407 * src/modest-tny-simple-folder-store.h:
2408 Added ModestTnySimpleFolderStore, used to contain folders from
2409 other folder stores, such as other accounts.
2411 * src/modest-tny-outbox-account.h:
2412 * src/modest-tny-outbox-account.c:
2413 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2414 used for the per-account local outbox folders.
2416 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2417 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2418 only use this (internally) now for the non-outbox local folders.
2420 * src/modest-init.h:
2421 * src/modest-init.c: Added modest_init_one_local_folder(), for
2422 setting up the directory structure for each local folder.
2424 * src/modest-local-folder-info.c:
2425 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2426 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2428 * src/modest-local-folder-info.h:
2429 * src/modest-tny-account-store.c: (on_account_removed),
2430 (on_account_changed), (create_per_account_local_outbox_folders),
2431 (get_server_accounts), (modest_tny_account_store_get_accounts),
2432 (modest_tny_account_store_get_tny_account_by_account),
2433 (modest_tny_folder_store_is_virtual_local_folders):
2435 * src/modest-tny-account.h:
2436 * src/modest-tny-account.c:
2437 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2438 to create an on-disk per-account local outbox folder for each
2440 (create_per_account_local_outbox_folders): Create a local outbox folder
2441 for each transport account.
2442 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2443 for all local folders.
2445 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2446 instead of using g_object_get/set() directly. It is clearer.
2448 (modest_tny_folder_store_get_message_count),
2449 (modest_tny_folder_store_get_local_size
2450 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2451 because we now use these with non-acount folder stores.
2453 (modest_tny_account_get_special_folder),
2454 (modest_tny_account_new_from_server_account),
2455 (modest_tny_account_new_from_account):
2456 (recurse_folders): Adjust to the new outbox system.
2458 * src/modest-tny-folder.h:
2459 * src/modest-tny-folder.c:
2460 (modest_tny_folder_is_local_folder),
2461 (modest_tny_folder_get_local_folder_type),
2462 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2464 * src/widgets/modest-main-window.h:
2465 * src/maemo/modest-main-window.c: (create_details_widget),
2466 (modest_main_window_set_contents_style): Show details for any folder store,
2469 (modest_tny_folder_get_rules):
2470 Remove the const. C does not support constness enough for this.
2472 * src/modest-ui-actions.c:
2473 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2474 make all outboxes appear as one, in the usual local-folders tree node.
2476 (set_active_account_from_tny_account),
2477 (modest_ui_actions_on_folder_selection_changed):
2478 * src/widgets/modest-folder-view.c: (text_cell_data),
2479 (icon_cell_data), (filter_row),
2480 (add_account_folders_to_merged_folder),
2481 (add_account_folders_to_simple_folder_store), (),
2482 (get_cmp_rows_type_pos), (cmp_rows),
2483 (modest_folder_view_set_account_id_of_visible_server_account):
2484 Adjust to the new outbox system, using generic folder stores and folders
2485 in the GtkTreeModel.
2487 2007-05-23 Christian Kellner <ckellner@openismus.com>
2489 * src/modest-mail-operation.c:
2490 (modest_mail_operation_update_account):
2491 Use info->max_size instead of unintialized local var [small
2492 build fix]. (Added TODO to review that change since I don't
2495 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2497 * libmodest-dbus-client/libmodest-dbus-client.c:
2498 (libmodest_dbus_client_compose_mail): function added
2499 * src/dbus_api/modest-dbus-api.h:
2500 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2501 (on_compose_mail): Implementation of the SendAsMail functionality
2503 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-account-mgr.c:
2506 (modest_account_mgr_add_server_account): Set the secure-connection
2507 conf key for transport accounts as well as store accounts. I don't know
2508 why the if was there. For instance, this makes sure that we use SSL
2509 for the gmail preset from the easysetup wizard.
2511 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2513 * src/gnome/modest-main-window.c:
2514 (on_account_store_connecting_finished), (connect_signals):
2515 * src/maemo/modest-main-window.c:
2516 (on_account_store_connecting_finished), (connect_signals),
2517 (modest_main_window_new):
2518 Handle TnyAccountStore::connecting-finished instead of
2519 TnyDevice::connection-changed, because we cannot actually perform
2520 operations on accounts until TnyAccountStore has itself responded to
2521 the TnyDevice::connection-changed signal. This prevents a GError from
2523 Do not try to update at startup, because we (at least on scratchbox)
2524 already do an update at startup when the device goes online.
2525 This prevents a GError from tinymail.
2526 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2527 Added TODO about stopping simultaneous operations.
2529 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2531 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2532 * src/modest-mail-operation-queue.c:
2533 (modest_mail_operation_queue_remove):
2534 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2535 about where they happened.
2537 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2539 * src/modest-ui-actions.c:
2540 (modest_ui_actions_on_password_requested): Make sure that the remember
2541 output parameter is always TRUE.
2543 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2545 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2546 Show a OK/Cancel dialog if the error is a question, though we still do not
2547 know anything more about what we are asking the user.
2548 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2549 Fix an uninitialized variable (helper). This is a logic error, however.
2551 2007-05-21 Christian Kellner <ckellner@openismus.com>
2553 * src/modest-search.h:
2554 Correct bit shifting in the ModestSearchFlags enum.
2556 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2558 * src/modest-tny-account.c:
2559 (modest_tny_account_new_from_server_account): Do not use the lsub and
2560 check-all hard-coded IMAP options when using POP.
2562 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2564 * src/modest-tny-account.c:
2565 (modest_tny_account_new_from_server_account):
2566 Use NULL for the secure-auth method for POP when Password auth has been
2567 specified by the user, as we already do for IMAP. "auth=Login" causes
2568 an error from camel or the server.
2570 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2572 * src/maemo/modest-account-settings-dialog.c:
2573 (create_page_account_details),
2574 (modest_account_settings_dialog_set_account_name):
2575 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2576 for the leave-on-server checkbox, rathr than just the checkbox, when
2577 the protocol is not POP.
2579 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2581 * src/widgets/modest-account-view.c:
2582 * src/widgets/modest-account-view.h:
2583 Added modest_account_view_select_account() which will be useful later
2584 to asynchronously re-select the edited account.
2586 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2588 * src/maemo/modest-account-settings-dialog.c:
2589 (modest_account_settings_dialog_set_account_name):
2590 Automatically choose the port numbers based on the secure authentication
2591 methods, if they have not been chosen before.
2592 This fixes projects.maemo.org bug NB#56273 .
2594 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2596 * src/maemo/modest-main-window-ui.h:
2597 * src/modest-ui-actions.c:
2598 * src/modest-ui-actions.h:
2599 Connect the Tools/SMTP Servers menu item to
2600 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2601 SMTP servers dialog, as in the UI specification and saves changes when it
2602 is closed. This fixed projects.maemo.org bug NB#56305 .
2604 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2606 * src/maemo/modest-connection-specific-smtp-window.c:
2607 (modest_connection_specific_smtp_window_init):
2608 Use gtk_window_set_default_size() to make this window big enough, so
2609 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2611 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2614 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2615 (modest_connection_specific_smtp_edit_window_init),
2616 Do not try to connect to a combobox signal before the combobox exists.
2617 This fixes the cras in projects.maemo.org bug NB#56288 .
2618 (modest_connection_specific_smtp_edit_window_get_settings):
2619 Remove the server_account_name parameter which was being checked for NULL
2620 though it was not used.
2622 * src/maemo/modest-connection-specific-smtp-window.c:
2623 (modest_connection_specific_smtp_window_fill_with_connections),
2624 (on_button_edit), (modest_connection_specific_smtp_window_init):
2625 Correct the number of treemodel columns to prevent a warning.
2626 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2627 libconic does not work.
2629 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2631 * src/modest-tny-account.c:
2632 (modest_tny_account_new_from_server_account):
2633 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2634 SMTP when "None" was chosen by the user. However, with my SMTP server that
2635 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2638 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2641 to explain the memory management issue with the ID in the ModestPair.
2643 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2644 (add_sending_page), (modest_account_assistant_finalize):
2645 * src/gnome/modest-gnome-global-settings-dialog.c:
2646 (create_updating_page), (create_composing_page):
2647 * src/gnome/modest-msg-edit-window.c: (get_transports),
2648 (init_window), (modest_msg_edit_window_finalize),
2649 (modest_msg_edit_window_get_msg_data):
2650 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2651 * src/gnome/modest-transport-widget.c:
2652 (modest_transport_widget_finalize), (smtp_configuration):
2653 * src/maemo/modest-maemo-global-settings-dialog.c:
2654 (create_updating_page), (create_composing_page):
2655 * src/maemo/modest-msg-edit-window.c: (get_transports),
2656 (init_window), (modest_msg_edit_window_finalize),
2657 (modest_msg_edit_window_get_msg_data),
2658 (modest_msg_edit_window_free_msg_data):
2659 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2660 (modest_store_widget_finalize):
2661 * src/maemo/modest-transport-widget.c:
2662 (modest_transport_widget_finalize), (smtp_configuration):
2663 * src/modest-main.c: (send_mail):
2664 * src/widgets/modest-combo-box.h:
2665 * src/widgets/modest-global-settings-dialog-priv.h:
2666 * src/widgets/modest-global-settings-dialog.c:
2667 (modest_global_settings_dialog_finalize):
2668 * src/widgets/modest-msg-edit-window.h:
2669 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2670 as long as the combo box, to prevent use of freed memory for the ID.
2672 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2674 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2675 get_accounts(), to make this clearer. Do not check for the enabled gconf
2676 key, because we do not use this for server accounts (at least, not yet).
2677 This allows us to send email again.
2679 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2681 * src/maemo/modest-platform.c:
2682 (on_modest_conf_update_interval_changed), (modest_platform_init):
2683 Only respond to this particular key change. All these strcmp()s cannot be
2686 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2688 * src/maemo/modest-maemo-global-settings-dialog.c:
2689 (current_connection): Prevent a crash in scratchbox when
2690 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2691 * src/maemo/modest-platform.c:
2692 (on_modest_conf_update_interval_changed), (modest_platform_init):
2693 Get the update interval from gconf and reset it when the gconf key changes.
2695 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2697 * src/modest-protocol-info.c:
2698 * src/modest-protocol-info.h: Adde enum-specific get functions,
2699 instead of using a ModestProtocolType enum parameter.
2701 * src/gnome/modest-account-assistant.c:
2702 * src/gnome/modest-store-widget.c:
2703 * src/gnome/modest-store-widget.h:
2704 * src/gnome/modest-transport-widget.c:
2705 * src/gnome/modest-transport-widget.h:
2706 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2707 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2708 * src/maemo/easysetup/modest-easysetup-wizard.c:
2709 * src/maemo/modest-account-settings-dialog.c:
2710 * src/maemo/modest-account-settings-dialog.h:
2711 * src/maemo/modest-store-widget.c:
2712 * src/maemo/modest-store-widget.h:
2713 * src/maemo/modest-transport-widget.c:
2714 * src/maemo/modest-transport-widget.h:
2715 * src/modest-account-mgr-helpers.c:
2716 * src/modest-account-mgr-helpers.h:
2717 * src/modest-account-mgr.c:
2718 * src/modest-account-mgr.h:
2719 * src/modest-tny-account.c:
2720 * src/modest-tny-folder.c:
2721 * src/widgets/modest-account-view.c:
2722 * src/widgets/modest-retrieve-combo-box.c:
2723 * src/widgets/modest-retrieve-combo-box.h:
2724 * src/widgets/modest-secureauth-combo-box.c:
2725 * src/widgets/modest-serversecurity-combo-box.c:
2726 * src/widgets/modest-serversecurity-combo-box.h:
2727 * tests/check_account-mgr.c:
2728 Use the specific functions, and use the re-renamed enum values for GNOME too.
2730 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2732 * src/modest-pair.h:
2733 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2734 so we can get the second based on the first.
2736 * src/maemo/modest-account-settings-dialog.h:
2737 * src/maemo/modest-account-settings-dialog.c:
2738 Added get_supported_secure_authentication_methods(), though it is mostly
2739 commented-out for now until the necessary API is committed to tinymail.
2740 (modest_account_settings_dialog_set_account_name),
2741 (save_configuration): Request the supported authentication methods from the
2742 server, so we can choose a working method.
2744 * src/modest-tny-account-store.h:
2745 * src/modest-tny-account-store.c:
2746 (modest_tny_account_store_get_session): Rename from
2747 tny_account_store_get_session().
2749 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2751 * src/modest-protocol-info.h: Split the ModestProtocol enum
2752 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2753 There was no need to have these unrelated values in one enum.
2755 * src/: many files: Adapted to changed enum. This makes the code a bit
2756 clearer, and the compiler could catch some errors.
2758 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2761 Show the detailed internal camel error message when an error happens
2762 during the configuration, so that our testers can give us more clues.
2763 For instance, in projects.maemo.org bug NB#56910 .
2765 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2767 * src/modest-tny-account.c:
2768 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2769 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2771 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2774 * src/maemo/modest-account-settings-dialog.c:
2775 (modest_account_settings_dialog_set_account_name),
2776 (save_configuration): For the incoming secure authentication checkbox,
2777 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2778 the UI specification. PLAIN does not seem to be supported for most IMAP
2779 servers anyway, and I am not sure what it would mean.
2780 However, we probably need to discover which of the secure-authentication
2781 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2782 * src/modest-account-mgr-helpers.c:
2783 (modest_account_mgr_get_server_account_data):
2785 * src/modest-tny-account.c:
2786 (modest_tny_account_new_from_server_account):
2787 Use tny_account_set_mech() to set secure-authentication methods,
2788 with some special-casing for IMAP, based on my observations of how
2791 * src/modest-account-mgr-helpers.h:
2792 * src/modest-account-mgr.c:
2793 * src/modest-defs.h: Comment that the URI is only used for local folders.
2795 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2797 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2798 parameter const, just to be neat.
2799 * src/modest-text-utils.c: (modest_text_utils_inline):
2800 End g_strconcat() with NULL, as its documentation says. This is almost
2801 certainly the cause of my crash at startup on the device. Interestingly,
2802 valgrind doesn't tell us about these errors.
2804 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2806 * scripts/build-packages: Added more precise comments about how to use
2807 this script, though I still get this error:
2808 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2809 error building tinymail
2811 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2813 * src/maemo/modest-main-window.c: (on_account_update):
2814 Very slight cleanup, hoping to make it simpler to discover what causes
2815 a crash here sometimes.
2817 * src/modest-tny-account.c:
2818 (modest_tny_account_new_from_server_account): Set the port. Added
2819 comments about the options and a TODO comment because I need to find out
2820 how to specify the secure authentication method.
2822 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2824 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2825 changed CFlags paths form modest to libmodest
2827 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2829 * src/modest-account-mgr-helpers.c:
2830 (modest_account_mgr_get_server_account_data),
2831 (modest_account_mgr_free_server_account_data):
2832 * src/modest-account-mgr-helpers.h:
2833 * src/modest-account-mgr.c:
2834 (modest_account_mgr_add_server_account):
2835 * src/modest-defs.h:
2836 * src/modest-tny-account.c:
2837 (modest_tny_account_new_from_server_account):
2838 Determine the options for tny_camel_account_add_option() here,
2839 based on the settings, rather than storing them directly in gconf.
2841 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2843 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2844 Show a more friendly error dialog now that we expect (from the tinymail
2845 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2847 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2849 * src/maemo/modest-main-window.c: (on_account_update): Check that
2850 account_name is not NULL, to prevent a crash at startup that I am
2851 seeing on the N800. I do wonder why it is NULL.
2853 * src/maemo/easysetup/modest-easysetup-wizard.c:
2854 (create_page_user_details):
2855 * src/maemo/modest-account-settings-dialog.c:
2856 (create_page_user_details), (create_page_outgoing):
2857 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2858 (modest_connection_specific_smtp_edit_window_init):
2859 * src/modest-ui-actions.c:
2860 (modest_ui_actions_on_password_requested):
2861 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2862 might do something useful with the on-screen keyboard.
2864 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/modest-main-window.c: (on_account_update):
2867 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2868 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2870 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2872 * src/modest-tny-account-store.c: (on_account_changed):
2873 Correct the signature of this signal handler.
2875 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2877 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2878 Show a HildonNote instead of a GtkDialog for Maemo.
2880 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2882 * src/widgets/modest-account-view.h:
2883 * src/widgets/modest-account-view.c: (on_account_changed),
2884 (on_account_removed). Added a boolean flag, set/unset by
2885 modest_account_view_block_conf_updates(),
2886 modest_account_view_unblock_conf_updates() to prevent unnecessary
2887 updates, but this is not very useful because the gconf notifications are
2888 so delays (maybe only on Maemo Bora).
2889 So auto-updating is turned off, and these functions do an explicit
2890 update when necessary.
2891 However, something else is still doing too much work when adding/removing
2892 accounts, probably in another part of the application.
2894 * src/maemo/modest-account-view-window.c:
2895 (on_delete_button_clicked), (on_edit_button_clicked),
2896 (on_new_button_clicked): Use the new functions.
2898 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2900 * src/modest-account-mgr-helpers.c:
2901 (modest_account_mgr_set_first_account_as_default):
2902 Sort the list of names alphabetically-by-title, so we choose the first one
2904 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2905 alphabetically by the title.
2907 This fixes projects.maemo.org bug NB#56418 .
2909 * src/modest-account-mgr-priv.c:
2910 (_modest_account_mgr_account_from_key):
2911 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2912 avoid a valgrind error, and possible random behaviour.
2914 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2916 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2917 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2918 tinymail documentation to say that this can be expected.
2919 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2920 pretty, and should not happen, but I would prefer to know when it does.
2922 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2924 * configure.ac: When using the older hildon version, probably on Bora,
2925 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2927 * src/widgets/modest-attachment-view.c:
2928 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2931 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2933 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2934 Implemented the prototype. Can be tested with
2935 tests/dbus_api/test_open_message:
2937 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2939 * src/modest-tny-account-store.c:
2940 (modest_tny_account_store_instance_init), (get_password):
2941 * src/modest-ui-actions.c:
2942 (modest_ui_actions_on_password_requested):
2943 Do not store the password in gconf, because this function is called
2944 for non-remembered passwords. Actually use the cached (in the hash map)
2945 password instead of releasing it.
2946 The password will now not be remembered if it is asked via the protected
2947 password dialog, as per the UI spec.
2949 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2951 * src/modest-defs.h:
2952 * src/modest-account-mgr-helpers.h:
2953 * src/modest-account-mgr-helpers.c:
2954 Added modest_server_account_get_username_has_succeeded(),
2955 modest_server_account_set_username_has_succeeded().
2956 (modest_server_account_set_username),
2957 Reset the has-succeeded flag if the username changes.
2959 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2960 * src/maemo/modest-connection-specific-smtp-window.c:
2961 (modest_connection_specific_smtp_window_save_server_accounts):
2962 Use modest_server_account_set_username() instead of using
2963 modest_conf_set_string() directly, so that the has-succeeded flag is always
2966 * src/modest-ui-actions.c:
2967 (modest_ui_actions_on_password_requested): Dim the username entry if
2968 the username has ever worked, as per the UI spec.
2970 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2972 * src/modest-tny-account-store.c: (get_password):
2973 * src/modest-ui-actions.c:
2974 (modest_ui_actions_on_password_requested):
2975 Allow the username to be changed too, though there is more work to
2976 be done on exactly how this behaves.
2978 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2980 * src/modest-account-mgr-helpers.h:
2981 * src/modest-account-mgr-helpers.c:
2982 Added modest_account_mgr_get_display_name(),
2983 modest_server_account_get_username(),
2984 modest_server_account_set_username(),
2985 modest_server_account_set_password(),
2986 modest_server_account_get_hostname() functions so we do not need to
2987 use the conf API directly.
2989 * src/maemo/modest-main-window.c: (connect_signals):
2990 Actually connect ot the ModestAccountStore::request-password signal,
2991 so that we show the dialog when the password is requested by Tinymail,
2992 for isntance if it is empty.
2994 * src/modest-marshal.list:
2995 * src/modest-tny-account-store.c:
2996 (modest_tny_account_store_class_init), (get_password),
2997 (modest_tny_account_store_alert):
2998 * src/modest-tny-account-store.h:
2999 * src/modest-ui-actions.h:
3000 * src/modest-ui-actions.c:
3001 (modest_ui_actions_on_password_requested):
3002 Change the signal parameters, so it is obvious that we are providing
3003 the non human-readable server name, and receiving both the username
3004 and password, though changing of the username is not yet implemented.
3005 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3006 for the GNOME version.
3008 This should fix the projects.maemo.org bug NB#56209, though it does not
3009 work on Bora, because the gconf_client_get() for the password fails
3010 immediately after we save it with gconf_client_set().
3012 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3015 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3016 caused an undefined symbol error:
3017 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3019 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3021 * src/modest-tny-account-store.c:
3022 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3023 using a GError instead of a string message, so we can translate it in
3026 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/modest-address-book.c:
3029 (modest_address_book_check_names):
3030 * src/maemo/modest-msg-view-window.c:
3031 (modest_msg_view_window_clipboard_owner_change):
3032 * src/modest-init.c: (modest_init_init_ui):
3033 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3034 (update_folders_cb), (modest_mail_operation_update_account):
3035 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3036 (modest_ui_actions_on_msg_attachment_clicked),
3037 (modest_ui_actions_on_msg_recpt_activated):
3038 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3039 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3040 (modest_msg_view_search_next):
3041 * src/widgets/modest-recpt-editor.c:
3042 (modest_recpt_editor_on_button_release_event),
3043 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3044 g_message(). At this point we should only be seeing interesting errors on
3045 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3047 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3049 (modest_wizard_dialog_force_title_update):
3050 * src/maemo/easysetup/modest-wizard-dialog.h:
3051 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3052 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3053 can update the title when appropriate. Otherwise the title is wrong if the
3054 pages are added after adding the notebook to the dialog.
3055 This must be a problem in HildonWizardDialog too.
3056 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3058 * src/maemo/easysetup/modest-easysetup-wizard.c:
3059 (create_subsequent_customsetup_pages),
3060 (create_subsequent_easysetup_pages):
3061 Call modest_wizard_dialog_force_title_update() so that the title is
3062 correct even with GTK+ < 2.10.
3063 This fixes projects.maemo.org bug NB#56145 .
3065 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/modest-platform.c:
3068 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3069 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3072 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3074 * src/widgets/modest-window.h:
3075 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3076 and modest_window_save_state(), which invokes it.
3078 * src/widgets/modest-window-mgr.h:
3079 * src/widgets/modest-window-mgr.c:
3080 Added modest_window_mgr_save_state_for_all_windows(), which calls
3081 the save_state vfunc on all registered windows, if implemented.
3083 * src/gnome/modest-msg-edit-window.c:
3084 * src/gnome/modest-msg-view-window.c:
3085 * src/maemo/modest-msg-edit-window.c:
3086 * src/maemo/modest-msg-view-window.c:
3087 * src/maemo/modest-main-window.c:
3088 Specify the existing save_settings functions as implementations of
3089 ModestWindow::save_state_func().
3091 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3092 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3093 enabling hibernation, for instance.
3095 We may need to do the same thing for restoring settings.
3098 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3100 * src/widgets/modest-window-mgr.c:
3101 * src/widgets/modest-window-mgr.h:
3102 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3103 modest_window_mgr_get_hibernation_is_prevented().
3105 * src/maemo/modest-main-window.c:
3106 (on_hildon_program_is_topmost_notify): Prevent hibernation
3107 (possible when the application goes to the background in the WM),
3108 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3110 * src/maemo/easysetup/modest-easysetup-wizard.c:
3111 (modest_easysetup_wizard_dialog_init):
3112 * src/maemo/modest-account-settings-dialog.c:
3113 (modest_account_settings_dialog_init):
3114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3115 (modest_connection_specific_smtp_edit_window_init):
3116 * src/maemo/modest-connection-specific-smtp-window.c:
3117 (modest_connection_specific_smtp_window_init):
3118 * src/maemo/modest-signature-editor-dialog.c:
3119 (modest_signature_editor_dialog_init):
3120 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3121 prevent hibernation while any of these account settings dialogs are open.
3123 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/Makefile.am:
3126 * src/maemo/modest-osso-state-saving.c:
3127 * src/maemo/modest-osso-state-saving.h: Added
3128 modest_osso_load_state() and modest_osso_save_state() though they do
3129 nothing now. They should iterate through all the open windows and load/save
3131 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3132 save state when closing.
3134 * src/maemo/modest-main-window.c:
3135 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3136 Add a notification handler for the HildonProgram::is-topmost property,
3137 so we can allow hibernation when the application goes into the background.
3138 But we still need to detect when the accounts setup windows are open so
3139 we can stop hibernation when they are open.
3140 To do this, I also added the main window the HildonProgram. This might have
3141 other side-effects/benefits, and should maybe be done for other windows.
3143 * src/maemo/modest-osso-autosave-callbacks.h:
3144 * src/maemo/modest-osso-autosave-callbacks.c:
3145 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3146 though it does not do anything yet, and we might never need this to do
3147 anything. For instance, we already save drafts.
3149 * src/maemo/modest-platform.c: (modest_platform_init):
3150 Specify the libosso auto-save callback.
3152 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3154 * src/maemo/modest-platform.c:
3155 (modest_platform_set_update_interval):
3156 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3157 aparently stays valid between application instances, so we can use this
3158 to remove and reset it later. According to a maemo-developers email from
3161 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3163 * configure.ac: Depend on libalarm for Maemo.
3165 * src/dbus_api/modest-dbus-api.h:
3166 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3167 (on_send_receive), (modest_dbus_req_handler):
3168 Handle a SEND_RECEIVE D-Bus method.
3170 * libmodest-dbus-client/libmodest-dbus-client.c:
3171 (libmodest_dbus_client_send_and_receive):
3172 * libmodest-dbus-client/libmodest-dbus-client.h:
3173 Add C convenience functions for calling the new D-Bus method.
3175 * src/modest-platform.h:
3176 * src/gnome/modest-platform.c:
3177 * src/maemo/modest-platform.c:
3178 Added modest_platform_set_update_interval(), which uses the
3179 alarmd API on Maemo.
3180 (modest_platform_init),
3181 Call modest_platform_set_update_interval(), using a hard-coded
3182 interval for now (until the global settings dialog is implemented),
3183 though I am not sure that this makes sense yet.
3185 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3187 * src/dbus_api/modest-dbus-callbacks.c:
3188 (modest_osso_cb_hw_state_handler):
3189 * src/dbus_api/modest-dbus-callbacks.h:
3190 * src/maemo/modest-platform.c: (modest_platform_init):
3191 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3192 in case this has some effect on the ability for Maemo to ping the
3195 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3197 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3198 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3199 warning. It is probably a logic error, but I need to fix the build.
3201 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3203 * src/modest-account-mgr.h:
3204 * src/modest-account-mgr.c:
3205 (modest_account_mgr_account_names): Add a gboolean enabled_only
3206 parameter, so we can get lists of onlt the enabled accounts.
3208 (modest_account_mgr_add_account),,
3209 (modest_account_mgr_account_with_display_name_exists):
3210 * src/maemo/modest-msg-edit-window.c: (get_transports):
3211 * src/modest-account-mgr-helpers.c:
3212 (modest_account_mgr_set_first_account_as_default):
3213 * src/modest-init.c: (init_default_account_maybe):
3214 * src/modest-tny-account-store.c: (get_accounts):
3215 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3216 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3217 * tests/check_account-mgr.c: (START_TEST):
3218 Provide the extra parameter, as appropriate.
3220 * src/widgets/modest-account-view.c: (update_account_view):
3221 Do not show disabled accounts (meaning that there is no way to
3222 enable/disable accounts in the UI (the feature is not in our UI
3223 specification), so we can use this internally only to mark unfinished
3224 or temporary account data.
3226 * src/maemo/easysetup/modest-easysetup-wizard.c:
3227 (create_account): Add boolean enable parameter, so we can specify FALSE
3228 to create the temporary account.
3229 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3230 (on_before_next): When finishing, when there is a temporary account, just
3232 Also, use a timeout to delay the showing of the dialog until gconf is likely
3233 to return correct information, due to a maemo gconf bug that is fixed in
3234 osso 1.1, but not yet in Bora.
3235 However, the dialog stays on screen after it is destroyed.
3237 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3238 for invalid data when cancelling. Use a hildon note instead of a dialog
3239 to complain about invalid data. Do not show the account-saved note if the
3240 account is disabled (a temporary account that will not really be saved for use
3243 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3245 * src/modest-account-mgr-helpers.h:
3246 * src/modest-account-mgr-helpers.c:
3247 Added modest_account_mgr_unset_default_account(),
3248 Added modest_account_mgr_set_first_account_as_default().
3250 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3251 If it was the default account, unset the default account name.
3253 * src/maemo/modest-account-view-window.c:
3254 (on_delete_button_clicked): If it was the default account,
3255 set the first remaining account as the default instead.
3257 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3258 a NULL account or a NULL default account, to prevent a crash. This should
3259 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3262 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3264 * src/widgets/modest-recpt-editor.c:
3265 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3266 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3267 TODO comment for this. This fixes the build.
3269 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3270 be the best place for it. This will in future update all auto-update accounts,
3271 rather than just the current/default account, when that gconf key exists.
3272 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3273 if there are no accounts, before calling do_send_receive().
3274 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3276 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3277 * src/maemo/modest-main-window-ui.h:
3278 * src/maemo/modest-main-window.c: (on_connection_changed),
3279 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3280 directly, becaue the signal handler does more.
3282 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3284 * src/modest-account-mgr-helpers.c:
3285 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3286 for the case that the account does not exist.
3288 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3289 (equivalent to the modest account name) rather than the tinymail account name
3290 (equivalent to the modest account title - human readable) to get the account data.
3291 Check for null account data to prevent the crash, and add a TODO comment saying that
3292 this needs fixing because it is using the server account name instead of the account name.
3294 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3297 * src/maemo/modest-account-settings-dialog.c: (show_error),
3299 Use hildon_note_new_information() for informative and error messages,
3300 which seems to be expected for Maemo applications (no documentation that I know of
3301 says this). I am surprised that there is no distinction between info and error
3304 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3306 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3307 it is easy to find where this is used.
3309 * src/maemo/easysetup/modest-easysetup-wizard.c:
3310 (create_page_welcome), (create_page_account_details),
3311 (create_page_user_details), (create_page_complete_easysetup),
3312 (create_page_custom_incoming), (create_page_custom_outgoing),
3313 (create_page_complete_custom):
3314 * src/maemo/modest-account-settings-dialog.c:
3315 (create_page_account_details), (create_page_user_details),
3316 (create_page_incoming), (create_page_outgoing):
3317 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3318 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3319 (modest_connection_specific_smtp_edit_window_init):
3320 * src/maemo/modest-connection-specific-smtp-window.c:
3321 (modest_connection_specific_smtp_window_init):
3322 * src/maemo/modest-signature-editor-dialog.c:
3323 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3324 and scrolling policy as per the Email Application Layout Guide, if I have
3327 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3329 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3330 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3331 which were empty, because these vfuncs have been removed from TnyAccountStore.
3332 This fixes the build.
3334 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/modest-main-window.c:
3337 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3338 showing/hiding it. Added TODO because it probably should not be NULL.
3339 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3340 because unnecessary g_warnings() make degugging difficult.
3342 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3344 * src/maemo/modest-msg-edit-window.c:
3345 (modest_msg_edit_window_select_color),
3346 (modest_msg_edit_window_select_background_color): 2 const corrections and
3347 moving 2 #endifs before closing brackets, to fix the build.
3349 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/easysetup/modest-easysetup-wizard.h:
3352 * src/maemo/easysetup/modest-easysetup-wizard.c:
3353 (modest_easysetup_wizard_dialog_finalize),
3354 (on_button_edit_advanced_settings), (create_page_complete_custom),
3355 (on_response), (create_account):
3356 Implement the Advanced Settings edit button, by saving the account information,
3357 for the Advanded Settings dialog to use directly from gconf, and removing it
3358 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3359 Bug #5533 in the projects.maemo.org bugzilla.
3361 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3363 * src/maemo/modest-msg-view-window.c:
3364 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3365 when opening a message window.
3367 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3369 * src/maemo/easysetup/modest-easysetup-wizard.c:
3370 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3373 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3374 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3375 gconf settings. I probably added more checks than necessary, but that is safer.
3377 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3378 variable to fix the build, but this seems to be used when it is still NULL.
3380 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3382 * src/modest-platform.h:
3383 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3384 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3385 * src/modest-main.c: Implement this function so we can avoid using
3386 maemo-specific API from cross-platform code.
3388 * src/modest-tny-account-store.c:
3389 (get_smtp_specific_transport_account_for_open_connection):
3390 * src/modest-ui-actions.c: (check_for_connection),
3391 (modest_ui_actions_on_item_not_found):
3392 Use modest_platform_connect_and_wait() and put #idefs around other
3393 maemo-specific code, because only maemo currently has a way to
3394 identify connection names.
3396 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3398 * src/modest-tny-account-store.h:
3399 * src/modest-tny-account-store.c:
3400 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3401 the connection-specific SMTP server settings in the configuration.
3403 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3405 * src/maemo/modest-main-window.c: (on_connection_changed),
3407 * src/modest-main.c: (main), (start_ui), (send_mail):
3408 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3409 that is what is intended.
3411 * src/modest-ui-actions.c: (action_send), (action_receive),
3412 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3413 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3414 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3415 SMTP server is used when it is specified.
3417 (modest_ui_actions_on_send_receive):
3418 Check that a connection is open before proceeding.
3419 Receive and then send, instead of vice-versa, as per the specification.
3421 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3423 * src/modest-mail-operation.c:
3424 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3425 though I guess it should be something other than NULL.
3427 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/easysetup/modest-easysetup-wizard.c:
3430 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3431 combo twice, to avoid an g_warning and to make it visible again.
3432 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3433 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3434 (already intended) dereference when detaching, because we then recreate the menu.
3435 But I am not sure why the warning was happening, and it is possible that this is a memory
3438 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3440 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3441 and uri_parse_mailto() utility functions.
3442 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3444 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3446 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3448 * src/dbus_api/modest-dbus-api.h:
3449 * src/dbus_api/modest-dbus-callbacks.c:
3450 Use an idle callback to execute the modest code in the application's own thread.
3451 Remove the helloworld example method.
3452 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3453 parsed, and the open-message method is not implemented because this is not yet implemented in
3455 * libmodest-dbus-client/libmodest-dbus-client.c:
3456 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3457 (libmodest_dbus_client_open_message):
3458 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3460 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3461 body without crashing.
3463 * tests/dbus_api/Makefile.am:
3464 * tests/dbus_api/test_mail_to.c:
3465 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3467 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3469 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3470 Added file to fix the build. Sorry.
3472 * src/dbus_api/Makefile.am:
3473 * src/dbus_api/modest-dbus-api.h:
3474 * src/dbus_api/modest-dbus-callbacks.h:
3475 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3476 (modest_dbus_req_handler):
3477 Put constants in a separate header so it can be reused by the
3478 client library, without duplication
3480 * libmodest-dbus-client/Makefile.am:
3481 * libmodest-dbus-client/libmodest-dbus-client.c:
3482 (libmodest_dbus_client_call_helloworld),
3483 (libmodfest_dbus_client_send_mail),
3484 (libmodfest_dbus_client_mailto),
3485 (libmodfest_dbus_client_open_message):
3486 * libmodest-dbus-client/libmodest-dbus-client.h:
3487 (Partly) Implement a send_mail D-Bus method.
3489 * tests/dbus_api/Makefile.am:
3490 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3491 the send_email D-Bus method.
3493 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3497 * libmodest-dbus-client/Makefile.am:
3498 * libmodest-dbus-client/libmodest-dbus-client.c:
3499 * libmodest-dbus-client/libmodest-dbus-client.h:
3500 * tests/dbus_api/Makefile.am:
3501 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3502 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3504 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3506 * src/maemo/easysetup/modest-easysetup-wizard.c:
3507 (create_page_account_details):
3508 * src/maemo/modest-account-settings-dialog.c:
3509 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3510 widgets, because this might not be the default in future versions of the Maemo GTK+.
3511 However, I can not not get capitalization to work even in a simple test case.
3513 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3515 * src/maemo/easysetup/modest-easysetup-wizard.c:
3516 (create_page_custom_incoming), (create_page_custom_outgoing):
3517 * src/maemo/modest-account-settings-dialog.c:
3518 (create_page_account_details), (create_page_incoming),
3519 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3520 instead of using gtk_check_button_with_label(), so they are aligned like the other
3521 widgets, as per the UI spec.
3523 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3525 * src/maemo/easysetup/modest-easysetup-wizard.c:
3526 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3527 * src/widgets/modest-validating-entry.c:
3528 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3529 Modest prefix instead of an EasySetup prefix.
3531 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3533 * src/widgets/modest-validating-entry.h:
3534 * src/widgets/modest-validating-entry.c: (on_insert_text),
3535 Added easysetup_validating_entry_set_max_func(), used to set a callback
3536 to call when the max number of characters is reached. GtkEntry has a max-length
3537 already but is silent about it.
3539 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3540 (create_page_account_details), (create_page_user_details),
3542 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3543 (create_page_account_details), (create_page_user_details),
3544 (create_page_outgoing):
3545 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3546 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3547 the UI spec, when the user tries to enter more than the max number of characters.
3549 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3551 * src/maemo/easysetup/modest-easysetup-wizard.c:
3552 (create_page_user_details), (create_page_custom_incoming),
3553 (create_page_custom_outgoing):
3554 * src/maemo/modest-account-settings-dialog.c:
3555 (create_page_user_details), (create_page_incoming),
3556 (create_page_outgoing):
3557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3558 (modest_connection_specific_smtp_edit_window_init):
3559 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3560 not appropriate. Bad Maemo-specific defaults!.
3562 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3564 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3565 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3566 (modest_signature_editor_dialog_set_settings):
3567 Disable the label and textview when the checkbox is disabled, and use the
3568 specified (UI spec) default signature text.
3570 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3572 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3573 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3575 * src/modest-defs.h:
3576 * src/modest-account-mgr-helpers.h:
3577 * src/modest-account-mgr-helpers.c:
3578 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3580 * src/maemo/Makefile.am:
3581 * src/maemo/modest-signature-editor-dialog.c:
3582 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3585 * src/maemo/modest-account-settings-dialog.h:
3586 * src/maemo/modest-account-settings-dialog.c:
3587 (modest_account_settings_dialog_finalize), (on_button_signature),
3588 (save_configuration): Use the new dialog when the Edit button is pressed, and
3589 save the changes if necessary, as per the UI spec.
3591 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3593 * src/maemo/Makefile.am:
3594 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3595 based on maemo-develoers email from Dirk.
3597 * src/maemo/easysetup/modest-easysetup-wizard.c:
3598 (create_page_welcome), (create_page_account_details),
3599 (create_page_user_details), (create_page_complete_easysetup),
3600 (create_page_custom_incoming), (create_page_custom_outgoing),
3601 (create_page_complete_custom),
3602 (modest_easysetup_wizard_dialog_init):
3603 * src/maemo/modest-account-settings-dialog.c:
3604 (create_page_account_details), (create_page_user_details),
3605 (create_page_incoming), (create_page_outgoing),
3606 (modest_account_settings_dialog_init):
3607 * src/maemo/modest-connection-specific-smtp-window.c:
3608 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3610 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/easysetup/modest-easysetup-wizard.c:
3613 (create_page_account_details), (create_page_custom_outgoing),
3614 (create_page_complete_custom):
3615 * src/maemo/modest-account-settings-dialog.c:
3616 (create_page_user_details), (create_page_incoming),
3617 (create_page_outgoing):
3618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3619 (modest_connection_specific_smtp_edit_window_init):
3620 Use the correct (UI spec) port min/max, and use horizontal separators,
3623 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3625 * src/maemo/easysetup/modest-easysetup-wizard.c:
3626 (set_default_custom_servernames):
3627 * src/maemo/modest-account-settings-dialog.c:
3628 (create_page_incoming), (on_combo_outgoing_security_changed),
3629 (on_combo_incoming_security_changed), (create_page_outgoing),
3630 (modest_account_settings_dialog_set_account_name),
3631 (save_configuration):
3632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3633 (on_combo_security_changed),
3634 (modest_connection_specific_smtp_edit_window_init),
3635 (modest_connection_specific_smtp_edit_window_set_connection),
3636 (modest_connection_specific_smtp_edit_window_get_settings):
3637 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3640 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3643 * src/maemo/easysetup/modest-easysetup-wizard.c:
3644 (create_page_custom_outgoing), (create_page_complete_custom):
3645 * src/maemo/modest-account-settings-dialog.c:
3646 (create_page_user_details), (create_page_outgoing):
3647 * src/maemo/modest-account-view-window.c: (button_box_new):
3648 Use changed logical IDs as per the most recent UI spec:
3649 mcen_bd_emailsetup_edit -> mcen_bd_edit
3650 mcen_bd_emailsetup_delete -> mcen_bd_delete
3651 mcen_bd_emailsetup_close -> mcen_bd_close
3653 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3657 * src/dbus_api/Makefile.am:
3658 * src/dbus_api/modest-dbus-callbacks.c:
3659 * src/dbus_api/modest-dbus-callbacks.h:
3660 * src/maemo/modest-platform.c: (modest_platform_init):
3661 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3663 * tests/Makefile.am:
3664 * tests/dbus_api/Makefile.am:
3665 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3667 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3669 * src/maemo/modest-account-settings-dialog.c:
3670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3671 Removed unnecessary includes.
3673 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3675 * src/maemo/easysetup/modest-easysetup-wizard.c:
3676 * src/maemo/modest-account-settings-dialog.c:
3677 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3678 * src/widgets/Makefile.am:
3679 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3680 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3681 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3682 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3683 * src/widgets/modest-secureauth-combo-box.c:
3684 * src/widgets/modest-secureauth-combo-box.h:
3685 * src/widgets/modest-serversecurity-combo-box.c:
3686 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3687 made the GObject names more consistent with the rest of the Modest code.
3689 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3691 * src/maemo/easysetup/Makefile.am:
3692 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3693 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3694 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3695 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3696 * src/maemo/easysetup/modest-easysetup-wizard.c:
3697 * src/maemo/easysetup/modest-validating-entry.c:
3698 * src/maemo/easysetup/modest-validating-entry.h:
3699 * src/maemo/modest-account-settings-dialog.c:
3700 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3701 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3702 widgets/ because they are used outside of easysetup too. After checking in,
3703 svn will allow me to rename them too.
3705 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3707 * src/gnome/modest-msg-edit-window.c:
3708 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3709 linker error, to fix the build on the GNOME platform.
3710 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3711 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3712 ifdefed out to avoid a warning.
3714 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3716 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3717 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3718 some alternative for GTK+ 2.6.
3720 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3722 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3724 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3725 specified for EmailAccountsDialog in UI spec.
3727 * src/maemo/easysetup/modest-easysetup-wizard.c:
3728 * src/maemo/easysetup/modest-easysetup-wizard.h:
3729 * src/maemo/modest-account-settings-dialog.c:
3730 * src/maemo/modest-account-settings-dialog.h:
3731 Reuse a member window widget for the connection-specific SMTP server accounts,
3732 so we can tell it to create/save the accounts only if we actually save changes.
3734 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3736 (modest_connection_specific_smtp_edit_window_get_settings):
3737 Return a struct instance for temporarily remembering the entered data.
3739 * src/maemo/modest-connection-specific-smtp-window.h:
3740 * src/maemo/modest-connection-specific-smtp-window.c:
3741 (modest_connection_specific_smtp_window_finalize),
3742 (modest_connection_specific_smtp_window_fill_with_connections),
3744 (modest_connection_specific_smtp_window_save_server_accounts),
3745 (update_model_server_names): Do not actually save data until asked,
3746 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3748 (on_selection_changed),
3749 (modest_connection_specific_smtp_window_init): Disable the edit
3750 button when nothing is selected.
3752 * src/modest-account-mgr-helpers.c:
3753 * src/modest-account-mgr-helpers.h:
3754 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3757 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3759 * src/modest-account-mgr-helpers.h:
3760 * src/modest-account-mgr-helpers.c:
3761 (modest_account_mgr_get_unused_account_name),
3762 (modest_account_mgr_get_unused_account_display_name): Added these
3763 utility functions, to avoid code duplication.
3765 * src/maemo/easysetup/modest-easysetup-wizard.c:
3766 (create_page_account_details), (create_account):
3767 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3768 (on_combo_security_changed),
3769 (modest_connection_specific_smtp_edit_window_init),
3770 (modest_connection_specific_smtp_edit_window_save_settings):
3771 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3772 * src/maemo/modest-connection-specific-smtp-window.c:
3773 (modest_connection_specific_smtp_window_finalize),
3774 (modest_connection_specific_smtp_window_fill_with_connections),
3775 (on_button_edit), (modest_connection_specific_smtp_window_init):
3776 * src/maemo/modest-connection-specific-smtp-window.h:
3777 Implementing saving of connection-specific server accounts.
3779 But I need to refactor this so we can save the data for each
3780 possible connection-specific account and only actually create the server accounts
3781 when the easysetup finished, or the OK button is pressed on the account settings
3784 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3786 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3787 (on_combo_security_changed):
3788 (modest_connection_specific_smtp_edit_window_init):
3789 Auto-fill the port number as in the account settings.
3791 (modest_connection_specific_smtp_edit_window_set_connection):
3792 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3793 * src/maemo/modest-connection-specific-smtp-window.c:
3794 (fill_with_connections), (on_button_edit),
3795 (modest_connection_specific_smtp_window_init):
3796 Turn the edit window into a dialog to simplify the code, and
3797 set a WM hint as in a GtkDialog, because only a popup can be on top of
3798 another window in Maemo, and popups usually have no WM decoration.
3800 * src/modest-defs.h:
3801 * src/modest-account-mgr-helpers.c:
3802 (modest_account_mgr_set_connection_specific_smtp),
3803 (modest_account_mgr_remove_connection_specific_smtp),
3804 (modest_account_mgr_get_connection_specific_smtp):
3805 * src/modest-account-mgr-helpers.h: Some functions to write the
3806 connection-specific SMTP server information. Not yet used.
3809 * src/widgets/modest-folder-view.c: (text_cell_data):
3810 Fix a warning about an uninitialized variable.
3811 (on_configuration_key_changed): Put an #ifdef around the use
3812 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3814 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/modest-account-settings-dialog.h:
3817 * src/maemo/modest-account-settings-dialog.c:
3818 Added connect_for_modified() utility function to mark the new modified boolean.
3820 (create_page_account_details), (create_page_user_details),
3821 (create_page_incoming), (create_page_outgoing), (on_response),
3822 (modest_account_settings_dialog_init),
3823 (modest_account_settings_dialog_set_account_name):
3824 Only warn about unsaved changes when there are actually unsaved changes.
3826 * src/modest-account-mgr-helpers.c:
3827 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3828 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3829 to get the data from there in future.
3831 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3833 * src/modest-defs.h:
3835 * src/modest-account-mgr-helpers.h:
3836 * src/modest-account-mgr-helpers.c:
3837 Store the security account setting in a single conf key instead of using
3838 the options list, so that the list is left for just the to-be-removed camel hack,
3839 and because gconf_client_set_list() is failing for some reason.
3841 * src/modest-account-mgr.c:
3842 (modest_account_mgr_add_server_account):
3843 * src/maemo/modest-account-settings-dialog.c:
3844 (modest_account_settings_dialog_set_account_name),
3845 (save_configuration): Use the renamed functions.
3848 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3850 * src/widgets/Makefile.am:
3851 * src/widgets/modest-limit-retrieve-combo-box.c:
3852 * src/widgets/modest-limit-retrieve-combo-box.h:
3853 * src/widgets/modest-retrieve-combo-box.c:
3854 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3855 the account settings dialog.
3857 * src/modest-defs.h:
3858 * src/modest-account-mgr-helpers.h:
3859 * src/modest-account-mgr-helpers.c:
3860 (modest_server_account_get_option_secure_auth),
3861 (modest_server_account_set_option_secure_auth):
3862 * src/modest-account-mgr.c:
3863 (modest_account_mgr_add_server_account):
3864 Use the existing AUTH_MECH conf key for the secure-auth setting,
3865 instead of putting it in the list options, because this was actually used already.
3867 * src/maemo/modest-account-settings-dialog.c:
3868 (create_page_account_details),
3869 (modest_account_settings_dialog_set_account_name),
3870 (save_configuration):
3871 * src/maemo/modest-account-settings-dialog.h:
3872 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3873 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3875 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3877 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3878 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3879 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3881 * src/modest-defs.h:
3882 * src/maemo/modest-account-settings-dialog.c:
3883 (create_page_incoming), (on_combo_outgoing_security_changed),
3884 (on_combo_incoming_security_changed), (create_page_outgoing),
3885 (modest_account_settings_dialog_set_account_name),
3886 (save_configuration): Load/Save the port number, and change it when the
3887 security combo changes, to suitable defaults.
3889 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3891 * src/modest-account-mgr.c:
3892 (modest_account_mgr_add_server_account): Set the security and secure-auth
3893 options, and add a comment saying that the other camel-specific options should be
3896 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3898 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3900 * src/modest-tny-account-store.c: (account_list_free),
3901 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3902 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3905 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3907 * src/modest-protocol-info.c:
3908 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3909 is required by our UI spec. Maybe something in our implementation will use this eventually.
3910 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3911 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3912 instead of the previous 0 placeholder.
3914 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3915 secure-auth settings.
3916 * src/modest-account-mgr-helpers.h:
3917 * src/modest-account-mgr-helpers.c:
3918 (modest_server_account_data_get_option_secure_auth),
3919 (modest_server_account_set_option_secure_auth),
3920 (modest_server_account_data_get_option_security),
3921 (modest_server_account_set_option_security): Added this API for getting and setting the security
3922 and secure-auth settings.
3924 * src/maemo/modest-account-settings-dialog.h:
3925 * src/maemo/modest-account-settings-dialog.c:
3926 (modest_account_settings_dialog_finalize), (check_data),
3927 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3928 about changing titles.
3929 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3930 (save_configuration): Save the security and secure-auth settings.
3932 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3933 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3935 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3937 * src/modest-defs.h:
3938 * src/modest-account-mgr.c:
3939 (modest_account_mgr_add_server_account):
3940 Added and used defines for the options key and value pair strings,
3941 that are used so far, though they do not seem to correspond to anything in our
3942 UI specs or ModestProtocol enum.
3944 * src/modest-account-mgr-helpers.h:
3945 * src/modest-account-mgr-helpers.c:
3946 (compare_option_strings_for_name),
3947 (modest_server_account_data_get_option_value),
3948 (modest_server_account_data_get_option_bool),
3949 (modest_account_mgr_get_server_account_option):
3950 Added helper functions for parsing the options GSList.
3952 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3954 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3955 display name is based on the supplied account name.
3956 * src/modest-account-mgr.c:
3957 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3958 with an inefficient, but good-enough, implementation.
3960 * src/maemo/easysetup/modest-easysetup-wizard.c:
3961 (create_page_account_details), (on_before_next), (create_account):
3962 Check for existing display names rather than (non-user-visible) account names, and just
3963 create and set a unique account name at the end.
3965 * src/maemo/modest-account-settings-dialog.c:
3966 (modest_account_settings_dialog_init),
3967 (modest_account_settings_dialog_set_account_name),
3968 (create_page_incoming): Show the display name, instead of the account name.
3969 (on_response): Do some (not all) extra checks, as in the UI spec.
3970 (save_configuration): Save the display name if it was changed.
3972 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3974 * po/en_GB.po: Added needed logical ID and translation.
3975 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3976 (init_view): Made the is-default column clicking work.
3978 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3981 * src/maemo/easysetup/Makefile.am:
3982 * src/maemo/easysetup/modest-easysetup-wizard.c:
3983 (modest_easysetup_wizard_dialog_init):
3984 * src/maemo/easysetup/provider-data-test.keyfile:
3985 * src/maemo/easysetup/provider-data.keyfile:
3986 Moved the provider data file to the new modest-providers-data package and used it from there.
3988 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3990 * src/modest-local-folder-info.c:
3991 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3992 N_() was already used on the static strings, but this just marks it for translation without
3993 using the translation.
3995 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3997 * src/maemo/modest-account-settings-dialog.c:
3998 (create_page_incoming),
3999 (modest_account_settings_dialog_set_account_name):
4000 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4001 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4002 I will do this if nobody else gets there first.
4004 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4006 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4007 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4008 save the security stuff.
4010 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4012 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4013 Set the email address and user fullname, which I now see must be
4016 * src/maemo/modest-account-settings-dialog.h:
4017 * src/maemo/modest-account-settings-dialog.c:
4019 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4020 leave-on-server and authentication.
4021 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4024 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4027 * src/maemo/modest-account-settings-dialog.c:
4028 * src/maemo/modest-account-settings-dialog.h:
4029 Most (but not all) of the widgets are now present as specified by the UI spec.
4030 No changes are yet saved, and some details are not properly shown yet.
4032 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4034 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4036 * src/maemo/Makefile.am:
4037 * src/maemo/modest-account-settings-dialog.c:
4038 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4039 an existing account. Doesn't do much yet.
4041 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4042 Open the accounts settings dialog when Edit is clicked.
4044 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4046 * src/maemo/easysetup/Makefile.am:
4047 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4049 * src/maemo/easysetup/modest-easysetup-wizard.c:
4050 (modest_easysetup_wizard_dialog_init):
4051 Try to get the source directory from the build system,
4052 instead of hard-coding "./" into the source code, when opening our local
4053 copies of the configuration files.
4054 But this still fails when opening the wizard from the Accounts window,
4055 maybe because the working directory seems to change at runtime.
4056 So the wizard will fail the second time unless you copy the files into their
4057 proper locations - see the stdout warnings for the paths.
4059 (create_page_account_details),(on_before_next):
4060 Check for existing non-server accounts instead of server accounts,
4061 so the default account name is useful again, and to prevent trying to
4064 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4065 Show the wizard when New is clicked.
4067 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4068 (init_view): Show the column headers, and show the columns that are
4069 specified in the UI specs. However, something in Maemo's GTK+ prevents
4070 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4071 change the default account. This is despite unsetting the special properties.
4073 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4075 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4076 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4077 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4078 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4079 to make that clearer.
4080 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4082 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4084 * src/maemo/modest-account-view-window.c:
4085 (modest_account_view_window_init),
4086 (modest_account_view_window_new):
4087 Use the same buttons as specified in the
4088 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4089 the existing widgets, which never had a chance of working.
4090 Put the ModestAccountView treeview in a scrolled window.
4091 Do not repeat the initialization in both _init() and _new().
4093 * src/widgets/modest-account-view.c: (update_account_view):
4094 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4095 this widget and window shows no accounts.
4097 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4099 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4101 * src/maemo/easysetup/modest-easysetup-wizard.c:
4102 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4103 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4104 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4107 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4108 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4109 accounts exist yet, as in the UI spec.
4111 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4113 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4115 * src/maemo/Makefile.am:
4116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4117 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4118 New window for editing connection-specific smtp details.
4119 Not fully implemented.
4121 * src/maemo/modest-connection-specific-smtp-window.c:
4122 (modest_connection_specific_smtp_window_finalize) :
4123 unref the tree model.
4124 (on_button_edit): Show the edit window.
4126 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4128 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4131 * src/maemo/Makefile.am:
4132 * src/maemo/modest-connection-specific-smtp-window.c:
4133 * src/maemo/modest-connection-specific-smtp-window.h:
4134 New window for showing the list of connections, for connection-specific
4135 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4136 * src/maemo/easysetup/modest-easysetup-wizard.c:
4137 (create_page_custom_outgoing): Show the new window when the button is clicked.
4139 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4141 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4142 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4143 * src/maemo/modest-msg-edit-window.c:
4144 (modest_msg_edit_window_insert_image):
4145 * src/modest-conf.c: (modest_conf_key_escape):
4146 * src/modest-mail-operation.c:
4147 (modest_mail_operation_send_new_mail):
4148 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4149 (modest_ui_actions_on_new_account):
4150 * src/widgets/modest-attachment-view.c: (update_filename_request):
4151 * src/widgets/modest-mail-header-view.c:
4152 Corrected warnings that were breaking the build, by commenting out unused variables,
4153 and a function, and by including a header.
4155 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4157 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4158 so we can #ifdef around platform-specific code when necessary.
4159 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4160 to allow this to build for the GNOME platform too.
4162 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4164 * src/maemo/easysetup/modest-easysetup-wizard.c:
4165 Added util_increment_name() and used it in create_page_account_details()
4166 to make sure that the default account name is always a new name.
4168 (modest_easysetup_wizard_dialog_init),
4169 (set_default_custom_servernames): Some minor memory management fixes.
4171 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4175 * src/modest-runtime.c: (init_i18n): Restored the translation
4176 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4177 are defined in config.h, and the translations are installed.
4179 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4180 is defined for translation.
4182 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4184 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4186 * src/maemo/easysetup/modest-easysetup-wizard.c:
4187 (modest_easysetup_wizard_dialog_init):
4188 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4189 Use realistic paths (though they should use $prefix generically) to the
4190 mcc_mapping and provider-data.keyfile files which might work when they
4191 are installed by the future version of the operator-wizard package,
4192 and then fallback to paths in our source code, with an explanatory
4195 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4199 * src/maemo/Makefile.am:
4200 * src/maemo/easysetup/: Added files from the previously-exernal
4201 osso-modest-easysetup.
4202 * src/maemo/modest-main-window-ui.h:
4203 * src/modest-ui-actions.c:
4204 * src/modest-ui-actions.h:
4205 Added modest_ui_actions_on_new_account() as a signal handler for the
4206 New Account menu item. It shows the easysetup wizard.
4207 * po/en_GB.po: Added additional needed logical IDs and translations.