1 2007-06-29 Murray Cumming <murrayc@murrayc-desktop>
3 * src/maemo/modest-main-window.c: (connect_signals):
4 Don't connect to delete_event twice. Maybe this was harmless.
6 2007-06-29 Murray Cumming <murrayc@murrayc.com
8 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
9 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
10 Debug output to give some more clue when a folder move is not allowed.
12 2007-06-28 Murray Cumming <murrayc@murrayc.com
14 * src/modest-tny-account.c: (on_modest_file_system_info),
15 (modest_tny_account_get_mmc_account_name):
16 Always call the callback, without checking whether the name has changed.
17 * src/widgets/modest-folder-view.c: (strings_are_equal),
18 (on_model_foreach_set_name), (on_get_mmc_account_name),
19 (text_cell_data): Compare the name here, and use the name from
20 the account rather than from the
21 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
22 if the name was changed after the account was added to the model.
23 That's a tinymail bug but not one that I want to fix now.
25 This finally fixes projects.maemo.org bug NB#59301.
27 2007-06-27 Armin Burgmeier <armin@openismus.com>
29 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
32 2007-06-27 Murray Cumming <murrayc@murrayc.com
34 * src/modest-tny-account.h:
35 * src/modest-tny-account.c:
36 Added modest_tny_account_get_mmc_account_name(), to set the memory
37 card name asynchronously for the given account and then notify.
38 (modest_tny_account_new_for_local_folders): Use this new function instead
39 of using hildon_file_system_info_async_new() directly.
41 * src/widgets/modest-folder-view.c: (text_cell_data):
42 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
43 gtk_tree_model_row_changed() when it is available.
45 This should fix projects.maemo.org bug NB#59301.
47 2007-06-27 Murray Cumming <murrayc@murrayc.com
49 * src/modest-mail-operation.c: (update_account_thread),
50 (get_msgs_full_thread): Fix typo failures in the revert
53 2007-06-27 Murray Cumming <murrayc@murrayc.com
55 * src/maemo/modest-maemo-global-settings-dialog.c:
56 (idle_select_default_focus):
57 * src/modest-mail-operation.c: (idle_notify_progress),
58 (idle_notify_progress_once), (set_last_updated_idle),
59 (update_account_thread), (get_msgs_full_thread):
60 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
61 * src/widgets/modest-header-view.c:
62 (idle_notify_headers_count_changed_destroy),
63 (idle_notify_headers_count_changed):
64 Reverted the additions of gdk_threads_enter/leave(), in case this
65 helps with a startup hang on the device.
67 2007-06-26 Armin Burgmeier <armin@openismus.com>
69 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
70 for supported secure authentication methods from server by
71 gtk_dialog_run(), saving CPU time and a potential race condition.
73 2007-06-26 Armin Burgmeier <armin@openismus.com>
75 * src/maemo/modest-maemo-utils.h:
76 * src/maemo/modest-maemo-utils.c: Added a
77 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
78 only error code to tell the calling code when the user canceled the
81 * src/maemo/modest-account-settings-dialog.h:
82 * src/maemo/modest-account-settings-dialog.c:
83 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
84 message if the retrieval of secure authentication methods was canceled
85 by the user. Perform the check before saving anything to configuration
86 to not end up with half-committed configuration changes, do not show
87 a "Saving to configuration failed" note when authentication methods
88 could not be retrieved.
90 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
93 2007-06-26 Murray Cumming <murrayc@murrayc.com>
95 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
96 Only return the first level of folders under accounts, because the
97 osso-global-search UI spec doesn't want the rest.
98 This fixed projects.maemo.org bug NB#61811.
100 2007-06-26 Murray Cumming <murrayc@murrayc.com>
102 * src/modest-tny-account-store.c:
103 * src/modest-tny-account-store.h:
104 Added modest_tny_account_is_memory_card_account().
105 * src/maemo/modest-main-window.c: (create_details_widget):
106 Show the same information items for the memory card as we show for the
107 local-folders, to fix projects.maemo.org bug NB#59307.
109 2007-06-26 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-tny-account-store.c: (get_password):
112 Added some checks for NULL to maybe prevent crashes, though I think
113 it was Philip's last commit that actually prevented the crash here
114 when creating a first new account.
115 But the new account is still not usable (no messages are shown)
116 until a restart of the application.
118 2007-06-26 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/modest-maemo-global-settings-dialog.c:
121 (idle_select_default_focus):
122 * src/modest-mail-operation.c: (idle_notify_progress),
123 (idle_notify_progress_once), (idle_notify_update_account_queue),
124 (set_last_updated_idle), (update_account_thread),
125 (notify_get_msgs_full), (get_msgs_full_destroyer),
126 (get_msgs_full_thread):
127 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
128 * src/widgets/modest-header-view.c:
129 (idle_notify_headers_count_changed_destroy),
130 (idle_notify_headers_count_changed):
131 Use gdk_threads_enter() and gdk_threads_enter_leave() in
132 all idle handlers, because some other thread could be blocking
133 the GDK lock, so that it can do GUI stuff.
135 2007-06-26 Murray Cumming <murrayc@murrayc.com>
137 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
138 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
139 (on_idle_send_receive), (on_idle_open_default_inbox):
140 * src/maemo/modest-msg-edit-window.c:
141 (modest_msg_edit_window_attach_file_noninteractive):
142 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
143 to prevent a hang. I don't quite understand why these are necessary,
144 beause we should already be in the main loop. I guess something outside
145 of the main loop is taking the lock.
147 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
148 we are really using URIs, and use files that are more likely to exist.
150 2007-06-26 Murray Cumming <murrayc@murrayc.com>
152 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
153 necessary because configure.ac now defines different variables.
155 2007-06-26 Murray Cumming <murrayc@murrayc.com>
157 * libmodest-dbus-client/libmodest-dbus-client.c:
158 * libmodest-dbus-client/libmodest-dbus-client.h:
159 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
160 libmodest_dbus_client_compose_mail() is what things actually use.
162 * src/dbus_api/modest-dbus-api.h:
163 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
164 * tests/dbus_api/Makefile.am:
165 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
168 2007-06-26 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-init.c: (modest_init_local_folders):
171 For memory-card (or other non local-folders) maildir accounts,
172 always create an Archive folder, so that there is somewhere to put
173 messages. This should be less confusing, because the user does not need
174 to guess that the need to create a folder.
176 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
178 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
179 Fixed icon size by using (50, 50) which is the same as defined by
182 2007-06-25 Armin Burgmeier <armin@openismus.com>
184 * src/widgets/modest-window-mgr.c:
186 * configure.ac: Correctly recognize hildon-notify presence and fixed
187 the build without it being installed.
189 2007-06-25 Murray Cumming <murrayc@murrayc.com>
191 * libmodest-dbus-client/libmodest-dbus-client.c:
192 (libmodest_dbus_client_search): Fix the build. Sorry.
193 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
194 (reply_forward_cb): Initialize variables to fix the build.
196 * src/modest-tny-account-store.c:
197 (modest_tny_account_store_get_tny_account_by): Fix the account URI
198 comparison (a silly typo) so that email search results can be opened
199 when there are more than one account.
201 2007-06-25 Murray Cumming <murrayc@murrayc.com>
203 * libmodest-dbus-client/libmodest-dbus-client.c:
204 (libmodest_dbus_client_search),
205 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
206 instead of 1 second, because the search gets folders and messages from
207 the server, which can take a long time. When it times out,
208 osso-global-search will report no results.
210 We need to specify whether we should search only cached information
211 (maybe with a user preference), and the osso-email-search-plugin
212 API should really be improved to allow that option, and to allow results
213 to be delivered asynchronously in batches.
215 2007-06-25 Murray Cumming <murrayc@murrayc.com>
217 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
218 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
219 GTK_ICON_SIZE_DIALOG is probably the wrong size.
221 2007-06-25 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
224 that is an empty string. D-Bus seems to give us these instead of NULL.
226 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
228 * src/dbus_api/modest-dbus-callbacks.c:
229 * src/maemo/easysetup/modest-easysetup-wizard.h:
230 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
231 * src/maemo/modest-connection-specific-smtp-edit-window.c:
232 (modest_connection_specific_smtp_edit_window_init):
233 * src/maemo/modest-maemo-global-settings-dialog.c:
235 * src/maemo/modest-maemo-utils.c:
236 (modest_maemo_utils_setup_images_filechooser):
237 * src/maemo/modest-main-window.c: (create_details_widget):
238 * src/maemo/modest-msg-edit-window.c:
239 (modest_msg_edit_window_attach_file_noninteractive),
240 (modest_msg_edit_window_color_button_change),
241 (modest_msg_edit_window_set_zoom):
242 * src/modest-mail-operation.c: (update_account_thread):
243 * src/modest-tny-account-store.c:
244 * src/modest-tny-account.c:
245 * src/widgets/modest-global-settings-dialog.c:
246 * src/widgets/modest-window.h:
250 2007-06-25 Murray Cumming <murrayc@murrayc.com>
252 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
253 * src/modest-search.c: (modest_search_folder),
254 (modest_search_all_accounts): Actually search only in the specified folder,
255 doing a simple match on the folder ID.
256 * src/modest-search.h: Added a folder field to the ModestSearch struct,
257 and added some documentation.
259 2007-06-22 Armin Burgmeier <armin@openismus.com>
261 * src/maemo/modest-maemo-utils.h:
262 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
263 modest_maemo_utils_get_supported_secure_authentication_methods.
265 * src/maemo/easysetup/modest-easysetup-wizard.c:
266 * src/maemo/modest-account-settings-dialog.c: Show correct error if
267 one occured, not just "Server does not support secure authentication".
269 2007-06-22 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-tny-account-store.c: (get_password):
272 Restored the call to tny_account_set_user() because Philip seems to have
273 stopped this from crashing (by not using the freed string). It still does
274 not work, but now we can test it.
276 2007-06-22 Murray Cumming <murrayc@murrayc.com>
278 * src/maemo/modest-msg-edit-window.c: (init_window):
279 Comment out use of an uninitialzed GtkScrolledWindow variable,
280 to fix the build and stop a crash. Yet again.
282 2007-06-22 Murray Cumming <murrayc@murrayc.com>
284 * src/modest-tny-account-store.c: (get_password):
285 Remove the call to tny_account_set_user() because this actually crashes.
286 As mentioned in the last commit, it is known to not work anyway.
288 2007-06-22 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-tny-account-store.c: (get_password):
291 Use tny_account_set_username() to tell tinymail that the username might
292 have changed too. But tinymail ignores this: see projects.maemo.org
294 * src/modest-ui-actions.c:
295 (modest_ui_actions_on_password_requested): Remove the useless attempt to
296 reset the connection when changing the username, and improve the comments.
297 Save the changed username to gconf at least, so it is used when Modest is
300 2007-06-21 Murray Cumming <murrayc@murrayc.com>
302 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
303 Do not use a query, so that we get all folders, including for POP and
304 local-folders. They work as search criteria too.
305 This fixes projects.maemo.org bug NB#57740.
307 2007-06-21 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
310 Comment out the use of hildon_notification_set_sound() because it is
311 not declared, to fix the build. Warnings are serious, people.
313 2007-06-21 Armin Burgmeier <armin@openismus.com>
315 * src/maemo/modest-maemo-utils.h:
316 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
317 modest_maemo_utils_get_supported_secure_authentication_methods()
318 to query authentication methods for a specific user. This should fix
319 projects.maemo.org bug NB#61369.
321 * src/maemo/easysetup/modest-easysetup-wizard.c:
322 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
325 2007-06-21 Murray Cumming <murrayc@murrayc.com>
327 * libmodest-dbus-client/libmodest-dbus-client.h:
328 * libmodest-dbus-client/libmodest-dbus-client.c:
329 (modest_dbus_message_iter_get_search_hit),
330 (libmodest_dbus_client_search):
331 Reorganised and commented this.
332 Removed modest_search_hit_free() from the public API because it
335 Added libmodest_dbus_client_get_folders() and
336 modest_folder_result_list_free().
338 * src/dbus_api/modest-dbus-api.h:
339 * src/dbus_api/modest-dbus-callbacks.c:
340 (modest_dbus_req_filter): Commented. Moved most code to
341 on_dbus_method_search() and added on_dbus_method_get_folders().
343 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
344 of the extra D-Bus handler.
346 * tests/dbus_api/Makefile.am:
347 * tests/dbus_api/test_get_folders.c: New test for
348 libmodest_dbus_client_get_folders(). This seems to return an empty list
349 at the moment. That could be the same error that causes the message list
350 to be empty sometimes.
351 This should help with projects.maemo.org bug NB#57740.
353 2007-06-21 Armin Burgmeier <armin@openismus.com>
355 * src/modest-mail-operation.c: Do not call
356 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
357 notify the operation's end after having set the status to CANCELED for
358 the operation queue to listen on. This fixes a deadlock when there
359 were mail operations in the queue during its finalization.
361 * src/modest-singletons.c: Reordered uninitialization of the account
362 manager to happen after the mail operation queue was uninitialized
363 because the mail operation's in the queue might still try to access
364 the account manager (see modest_mail_operation_notify_end()). This
365 fixes a potential crash when terminating the application.
367 2007-06-21 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-search.c:
370 (search_mime_part_and_child_parts): Moved some code here so we
371 can search recursively in child folders.
372 (modest_search_folder): Search in the message as a mime part, instead
373 of just its child mime parts.
374 (read_chunk), (search_mime_part_ogs):
375 Check how many bytes were read, to prevent an endless loop.
376 Searching in message bodies now works. This finishes the fix for
377 projects.maemo.org bug NB#61007.
379 2007-06-20 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
382 Add a g_warning when the item is not a folder.
384 * src/modest-ui-dimming-rules.c:
385 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
386 when selected item is not a folder (for instance, an account), because
387 the UI spec only talks about folders.
388 I am not sure what the UI spec wants, so this might not totally fix
389 projects.maemo.org bug NB#60794.
391 2007-06-20 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
394 (load_from_file): Sort the list. The unsorted list would be more noticeable
395 in non-English locales.
397 * src/maemo/modest-msg-edit-window.c:
398 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
399 warning and fix the build.
401 * src/maemo/modest-progress-bar-widget.c:
402 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
403 avoid a g_warning, and probably to avoid a crash.
405 2007-06-20 Murray Cumming <murrayc@murrayc.com>
407 * src/modest-search.c: (modest_search_folder): Check for a GError
408 when calling tny_folder_get_headers(), to show that this is not the cause
411 2007-06-20 Murray Cumming <murrayc@murrayc.com>
413 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
414 Actually set the body query instead of the subject query.
416 * src/modest-search.c: (search_mime_part_ogs),
417 (search_mime_part_strcmp): Remove extra space from the text/* regex,
418 which would probably cause it to fail if we got this far.
420 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
421 to simplify the code.
422 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
423 be causing search-in-body to fail.
425 2007-06-20 Murray Cumming <murrayc@murrayc.com>
427 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
429 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
430 Better debug message when the folder cannot be found.
431 This should help with fixing projects.maemo.org bug #61287.
432 * src/modest-search.c: (add_hit): Do not leak the furl string.
434 2007-06-20 Murray Cumming <murrayc@murrayc.com>
436 * src/modest-ui-actions.c:
437 (modest_ui_actions_on_folder_selection_changed):
438 Do not special-case TNY_MERGE_FOLDER here, because
439 modest_tny_folder_get_account() already does that. This fixes
440 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
441 shown when the Outbox was selected).
443 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
445 * libmodest-dbus-client/libmodest-dbus-client.c:
446 (_dbus_iter_get_string_or_null): Initialize the string variable in
447 case this helps with Dirk's crash.
449 2007-06-19 Murray Cumming <murrayc@murrayc.com>
451 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
452 though it is not implemented yet (this function is maybe not even used),
453 to avoid breaking ABI in future.
454 * libmodest-dbus-client/libmodest-dbus-client.c:
455 (get_attachments_string): Moved some code into this generic function.
456 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
457 sends email. It is maybe not used.
458 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
459 (on_send_mail): Use attachments.
461 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
462 * src/maemo/modest-msg-edit-window.c:
463 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
464 a filename before using it, to fix projects.maemo.org bug NB#58233.
466 2007-06-19 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
469 Initialize the continue_download variable to fix the build, and probably
470 to fix randome behaviour.
472 2007-06-18 Armin Burgmeier <armin@openismus.com>
474 * src/modest-tny-send-queue.h:
475 * src/modest-tny-send-queue.c: Keep track of the status of messages in
476 the queue so we can later show it in the UI. Replaced
477 modest_tny_send_queue_msg_is_being_sent() by
478 modest_tny_send_queue_get_msg_status().
480 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
482 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
483 gpointer. This probably was not harmful, but just to be sure.
485 2007-06-18 Murray Cumming <murrayc@murrayc.com>
487 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
488 Fix the build, but leave the function broken on Bora, because
489 hildon_uri_action_get_service() does not exist.
490 osso_uri_action_get_service() does not exist either, it seems.
492 2007-06-18 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-tny-account.c:
495 (modest_tny_account_new_from_server_account):
496 Uncommented the url debug output again, because it is useful for
497 debugging, as I said in the comment.
499 2007-06-18 Murray Cumming <murrayc@murrayc.com>
501 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
503 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
504 for Mameo Bora, to fix the build.
506 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
509 Fixed build with hildon < 0.99
511 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
512 Check if the selected account is busy instead of checking all accounts
514 * src/modest-account-mgr-priv.h:
515 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
516 (modest_account_mgr_init), (compare_account_name),
517 (modest_account_mgr_set_account_busy),
518 (modest_account_mgr_account_is_busy):
519 * src/modest-account-mgr.h:
520 Added busy information to the account manager. It possible to
521 set an account to busy or not busy now.
523 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
524 (modest_mail_operation_update_account),
525 (modest_mail_operation_notify_end):
526 Set the account to busy/not busy depending on the operation state.
528 * src/widgets/modest-account-view.c:
529 (modest_account_view_finalize), (get_last_updated_string),
530 (update_account_view), (on_account_busy_changed), (init_view):
531 Show string "Refreshing..." if the account is currently busy.
533 All this fixes projects.maemo.org bug NB#59711
535 2007-06-14 Armin Burgmeier <armin@openismus.com>
537 * src/widgets/modest-attachments-view.h:
538 * src/widgets/modest-attachments-view.c: Added
539 modest_attachments_view_has_attachments() and fixed coordinate
540 transformation in get_att_view_at_coords(). This fixes attachment
543 * src/widgets/modest-msg-view.c: Make use of
544 modest_attachments_view_has_attachments() to decide whether to show
545 attachments in the header.
547 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
550 (on_change), (on_combo_security_changed),
551 (modest_connection_specific_smtp_edit_window_init),
552 (modest_connection_specific_smtp_edit_window_set_connection),
553 (modest_connection_specific_smtp_edit_window_is_dirty):
554 * src/maemo/modest-connection-specific-smtp-edit-window.h:
555 * src/maemo/modest-connection-specific-smtp-window.c:
558 Show an comfirmation dialog for the smpt-edit-window if there are
559 unsaved changes and the user hits cancel.
560 (projects.maemo.org bug NB#60479)
562 2007-06-14 Armin Burgmeier <armin@openismus.com>
564 * src/maemo/easysetup/modest-easysetup-wizard.c:
565 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
566 address" info in banner instead of node, and select all the text as
567 per UI spec. This fixes projects.maemo.org bug NB#60550.
569 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
571 reviewed by: <delete if not using a buddy>
573 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
574 * src/modest-ui-actions.c: (folder_refreshed_cb):
576 2007-06-14 Murray Cumming <murrayc@murrayc.com>
578 * src/widgets/modest-folder-view.c: (filter_row):
579 Explictly filter out the per-account outbox accounts. I don't know why
580 these only sometimes show up, but now they should never show up in the UI.
581 This should fix projects.maemo.org bug NB#60160.
583 2007-06-14 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
586 when the toolbar does not exist yet.
587 * src/modest-widget-memory.c: (save_settings_header_view):
588 Added g_warnings() to help us to discover when we are trying to set
589 an empty columns list in gconf.
591 2007-06-14 Murray Cumming <murrayc@murrayc.com>
595 Added modest_init_get_default_header_view_column_ids().
597 * src/modest-widget-memory.c: (restore_settings_header_view):
598 Use the new function to get defaults, if the gconf key is empty,
599 instead of not creating any columns. This seems to fix the
600 empty right-hand pane problems.
602 * src/widgets/modest-header-view.h: Improved documentation.
604 2007-06-13 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
607 Revert the use of the display name as the account name, because this
608 is generally wrong and would break the code that follows.
610 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 (check_for_supported_auth_methods), (on_before_next),
616 More correct fix for projects.maemo.org bug NB# 58991
617 Do not longer accept AUTH_PASSWORD as secure method and choose
618 correct method when creating the account.
620 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
622 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
623 Fixed projects.maemo.org bug NB# 58991
625 2007-06-13 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-init.c: (modest_init_init_core),
628 (modest_init_local_folders): Fixed compilation errors.
630 2007-06-13 Murray Cumming <murrayc@murrayc.com>
632 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
633 Remove unnecessary lib/include, though it is good in principle when needed.
635 * src/modest-init.c: (modest_init_one_local_folder),
636 (modest_init_local_folders):
637 * src/modest-init.h: Initialize the .modest library for memory cards,
638 instead of just doing nothing for them. This should allow us to create
639 folders there, fixing projects.maemo.org bug NB#59297.
641 2007-06-13 Murray Cumming <murrayc@murrayc.com>
643 * libmodest-dbus-client/libmodest-dbus-client.c:
644 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
645 (libmodest_dbus_client_compose_mail),
646 (libmodest_dbus_client_open_message),
647 (libmodest_dbus_client_send_and_receive),
648 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
650 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
651 (on_idle_open_message), (modest_dbus_req_handler),
652 (search_result_to_message), (modest_dbus_req_filter):
653 * src/modest-search.c: (add_hit), (modest_search_folder),
654 (modest_search_all_accounts): Improved debug messages.
656 * tests/dbus_api/test_open_message.c: (main): Improved comments.
658 * src/modest-tny-account-store.c:
659 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
662 2007-06-13 Murray Cumming <murrayc@murrayc.com>
665 2007-06-12 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account-store.c: (get_server_accounts):
668 Call modest_tny_local_folders_account_add_merged_outbox_folders()
669 even when there are no accounts, so that the Outbox folder is always
670 visible. This fixes projects.maemo.org bug NB#60158.
672 2007-06-12 Murray Cumming <murrayc@murrayc.com>
674 * src/maemo/modest-main-window.c: (create_details_widget):
675 Use the mcen_va_never logical ID.
677 2007-06-12 Murray Cumming <murrayc@murrayc.com>
679 * src/dbus_api/modest-dbus-api.h:
680 * src/dbus_api/modest-dbus-callbacks.c:
681 (on_idle_open_default_inbox), (on_open_default_inbox),
682 (modest_dbus_req_handler):
683 Added a new OpenDefaultInbox method.
685 * libmodest-dbus-client/libmodest-dbus-client.h:
686 * libmodest-dbus-client/libmodest-dbus-client.c:
687 Added libmodest_dbus_client_open_default_inbox() to call the new
688 dbus method. This should be useful to projects.maemo.org bug NB#57214,
689 though it should maybe be used by a new osso-email-interface function.
691 * tests/dbus_api/Makefile.am:
692 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
695 2007-06-12 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
698 NULL, so that the signals get all the keys. This should not actually
699 change any behaviour because we currently update everything when anything
702 2007-06-12 Murray Cumming <murrayc@murrayc.com>
704 * src/widgets/modest-folder-view.c: (text_cell_data),
705 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
706 (find_inbox_iter): If tinymail tells us that the folder is
707 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
708 This causes the inbox to be selected at startup, fixing part of
709 projects.maemo.org bug NB#56305.
711 * src/modest-ui-dimming-rules.c:
712 (modest_ui_dimming_rules_on_tools_smtp_servers):
713 * src/modest-ui-dimming-rules.h: Added a callback function to dim
714 the SMTP servers menu item.
715 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
716 that the SMTP Servers menu item is dimmed when there are no accounts,
717 as a future version of the UI spec will require. This fixes
718 projects.maemo.org bug NB#56305.
720 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
722 * src/maemo/modest-maemo-utils.c:
723 (modest_maemo_utils_get_supported_secure_authentication_methods):
724 Added label to dialog instead of unreadable title
726 * src/maemo/modest-main-window.c: (sync_accounts_cb),
727 (modest_main_window_new):
728 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
731 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
732 * src/modest-account-mgr.h:
733 Added method to avoid code duplication
735 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
736 (modest_ui_actions_on_send_receive):
737 Use modest_account_mgr_has_accounts
739 2007-06-11 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/easysetup/modest-presets.c:
742 (modest_presets_get_info_server_security): Do not report secure auth
744 * src/modest-protocol-info.c: Use the defines for the gconf key names
745 for secure authentication. This was not working because we were writing
746 Password and reading password, and the check was case sensitive.
747 With this, gmail now works for receiving and sending when created via
750 2007-06-11 Murray Cumming <murrayc@murrayc.com>
752 * src/maemo/easysetup/modest-presets.c:
753 (modest_presets_get_info_server_security): Correct the key name for
754 SecureSmtp, because it seems to be case-sensitive.
755 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
756 Do not try to get the 0th notebook page if there are 0 pages, to
759 2007-06-11 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
762 Prevent use of the new notification feature for now, because it currently
763 shows one dialog for each new email, which is annoying.
765 2007-06-11 Murray Cumming <murrayc@murrayc.com>
767 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
768 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
769 when no country was selected, so that we show the global ones.
770 * src/maemo/easysetup/modest-presets.c:
771 (modest_presets_get_providers): Return only the global providers, not
772 all providers when mmc=0 was requested.
774 2007-06-11 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
777 (easysetup_provider_combo_box_fill): Remove debug code that showed the
778 provider ID in the combo.
780 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
781 Do not show the page numbers, because it would be confusing when we add
782 the 2 extra pages for the custom setup, when the user chooses the "Other"
783 provider. This fixes projects.maemo.org bug NB#59028
785 * src/modest-init.c: (modest_init_init_core),
786 (modest_init_local_folders):
788 * src/modest-tny-account.c:
789 (modest_tny_account_new_for_local_folders): Do not create default folders
790 for the memory card. This should fix projects.maemo.org bug NB#59328.
792 2007-06-11 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
795 Free the changed_conf_keys string items. They are already freed in the
796 idle handler if that runs first.
798 2007-06-11 Murray Cumming <murrayc@murrayc.com>
800 * src/modest-ui-actions.c:
801 (modest_ui_actions_on_password_requested): Check that the server name
802 is not NULL, because I just saw a password dialog with (null) as the
805 * src/modest-tny-folder.[h|c]: Added
806 modest_tny_folder_is_memory_card_folder().
807 * src/modest-ui-dimming-rules.c:
808 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
809 menu item for memory cards, as per the UI spec (section 7.4). This should
810 fix projects.maemo.org bug NB#59297.
812 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
814 * src/maemo/modest-main-window.c: (sync_accounts_cb):
815 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
816 is another problem with the code, see Murray's comment at line 772)
818 2007-06-08 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
821 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
822 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
823 (load_from_file), (easysetup_country_combo_box_init),
824 (easysetup_country_combo_box_get_active_country_ids),
825 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
826 instead of just one ID, to avoid duplicate country names in the UI.
828 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
829 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
830 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
831 a single ID, avoiding duplicate providers.
832 * src/maemo/easysetup/modest-easysetup-wizard.c:
833 (on_combo_account_country): Adapt to use a list.
835 2007-06-08 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
838 keys changed in the last X seconds.
840 * src/modest-account-mgr.h:
841 * src/modest-account-mgr.c: (on_timeout_notify_changes),
842 (on_key_change), (modest_account_mgr_class_init),
843 (modest_account_mgr_init), (modest_account_mgr_finalize):
844 As the keys are changed, save them in a GSList* and signal that GSList*
845 further every X seconds, to batch changes, to allow us to do just one
846 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
847 bug NB#56941 and other (UI-blocking) delays when changing account settings.
849 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
850 changed signal signature.
852 * src/modest-conf.c: (modest_conf_set_list),
853 (modest_conf_on_change): Reenable notification.
855 (modest_conf_maemo_fake_on_change): Comment out the hack that
856 notified immediately instead of asynchronously.
858 * src/widgets/modest-account-view.h:
859 * src/widgets/modest-account-view.c:
860 (update_account_view): Select the previously-selected account ID,
861 if possible. This fixes projects.maemo.org bug NB#56933.
863 (on_account_changed), (on_account_removed),
864 (modest_account_view_select_account):
866 Remove the block/unblock functions
867 because they were not useful.
869 * src/maemo/modest-account-view-window.c:
870 (on_delete_button_clicked), (on_edit_button_clicked),
871 (on_new_button_clicked): Remove the use of the non-working block/unblock.
873 2007-06-08 Murray Cumming <murrayc@murrayc.com>
875 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
876 Improve the error dialog to show Incorrect Account Settings, which seems
877 clearer, and say that the internal error message (to be removed from the
878 dialog later) is often misleading.
879 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
881 * src/modest-tny-account.c:
882 (modest_tny_account_new_from_server_account): Uncomment the printf of the
883 URL because this is so useful for debugging on the device.
885 * src/widgets/modest-serversecurity-combo-box.c:
886 (modest_serversecurity_combo_box_fill): Correct a logical ID.
888 2007-06-08 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-mail-operation.c:
891 (modest_mail_operation_send_new_mail):
892 Added a comment about a nasty but apparently harmless message. Details
893 added to the wiki g_warnings() page.
895 2007-06-08 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
898 (modest_tny_send_queue_class_init):
899 Do not use the priv struct because it is empty, to avoid g_warnings
900 about a non-existant priv struct.
902 * src/modest-tny-account-store.c:
903 (modest_tny_account_store_get_server_account),
904 (modest_tny_account_store_get_transport_account_for_open_connection
905 ): Do not try to get transport server accounts for local folders,
906 because they don't have any. This avoids a g_warning().
908 * src/maemo/modest-main-window.c:
909 (modest_main_window_notify_send_receive_initied),
910 (on_configuration_key_changed):
911 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
913 * src/modest-mail-operation.c:
914 (modest_mail_operation_update_account):
915 * src/modest-tny-account-store.h:
916 * src/modest-tny-account.c:
917 (modest_tny_account_get_special_folder),
918 (modest_tny_account_new_for_local_folders),
919 (modest_tny_account_new_for_per_account_local_outbox_folder):
920 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
921 * src/modest-tny-local-folders-account.c:
922 (add_account_folders_to_merged_folder):
923 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
924 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
925 (modest_ui_actions_on_send):
926 * src/widgets/modest-folder-view.c: (update_model):
927 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
928 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
929 modest_tny_account_store_get_tny_account_by_account() to
930 modest_tny_account_store_get_server_account() to make the code clearer.
932 2007-06-07 Marcus Bauer <marcusb@openismus.com>
934 * src/dbus_api/modest-dbus-api.h:
935 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
936 * src/maemo/modest-msg-edit-window.c:
937 (modest_msg_edit_window_attach_file_noninteractive):
938 added g_warning in case the file to be attached does not exist
939 * tests/dbus_api/test_compose_mail.c: (main):
940 removed obsolete comment, added generic files as test case
942 2007-06-07 Murray Cumming <murrayc@murrayc.com>
944 * src/modest-tny-account-store.c: (get_server_accounts):
945 Create the local folders account only once, not once for each outbox, and
946 not only when there are some outboxes.
948 2007-06-07 Murray Cumming <murrayc@murrayc.com>
950 * src/widgets/modest-folder-view.c: (update_model): Comment out some
951 code that is causing a crash at startup. Sergio says that he is fixing this.
953 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
955 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
956 * src/maemo/modest-account-settings-dialog.c:
957 (create_page_outgoing),
958 (modest_account_settings_dialog_set_account_name),
959 (save_configuration):
960 - Fixed handling of the "Use secure authentication" toggle to comply with
961 the ui specification. See also projects.maemo.org bug NB#58400
963 - Restore the Secure connection setting combo correctly when loading
966 * src/maemo/modest-maemo-utils.c:
967 (on_camel_account_get_supported_secure_authentication),
968 (modest_maemo_utils_get_supported_secure_authentication_methods):
969 Fixed a crasher if operation is canceled
971 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
972 (modest_protocol_info_auth_is_secure):
973 * src/modest-protocol-info.h:
975 Added two new methods to determine if a protocol/auth method is secure/encrypted in
976 the sense of the "Use secure authentication" toggle.
978 2007-06-07 Murray Cumming <murrayc@murrayc.com>
980 * src/modest-tny-account-store.h:
981 * src/modest-tny-account-store.c:
982 Added modest_tny_account_store_get_local_folders_account().
984 * src/modest-tny-folder.h:
985 * src/modest-tny-folder.c:
986 (modest_tny_folder_get_account):
987 Added this replacement for tny_folder_get_account() which returns
988 the local-folders account for TnyMergeFolders, to avoid the
989 warning about the unimplemented get_account_func() vfunc().
991 (modest_tny_folder_get_rules),
992 * src/modest-ui-actions.c:
993 (modest_ui_actions_on_folder_selection_changed):
994 * src/modest-mail-operation.c:
995 (modest_mail_operation_remove_folder),
996 (modest_mail_operation_xfer_folder),
997 (modest_mail_operation_rename_folder),
998 (modest_mail_operation_get_msg),
999 (modest_mail_operation_get_msgs_full),
1000 (modest_mail_operation_remove_msg),
1001 (modest_mail_operation_xfer_msgs),
1002 (modest_mail_operation_refresh_folder):
1003 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1005 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1008 (modest_server_account_set_security):
1009 * src/modest-defs.h: Add comments explaining that our
1010 UI spec means TLS when it says Normal, so these do not look like errors.
1012 * src/modest-tny-account.c:
1013 (modest_tny_account_new_from_server_account): Use the new tinymail
1014 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1015 for TLS. This should fix projects.maemo.org bug NB#58460.
1017 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1019 * src/maemo/easysetup/modest-easysetup-wizard.c:
1020 (create_account): Correct the position of the gconf sanity check warning.
1021 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1022 of using the g_idle_add() hack, because this does not seem to be necessary
1023 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1024 caused by something other than maemo's gconf.
1025 This fixes projects.maemo.org bug #59022.
1027 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1029 * src/modest-account-mgr-helpers.c:
1030 (modest_account_mgr_get_default_account): Do not check that the account
1031 exists if there is no default account (NULL), to fix a runtime warning.
1033 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1035 * src/widgets/modest-folder-view.c: (update_model):
1036 Do not unref the treemodel before we have finished with it.
1037 This prevents a valgrind warning and an occasional crash at startup.
1039 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1041 * libmodest-dbus-client/libmodest-dbus-client.h:
1042 added libmodest_dbus_client_compose_mail()
1043 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1045 added functions needed for SendAsMail() functionality
1046 * src/maemo/modest-msg-edit-window.c:
1047 (modest_msg_edit_window_attach_file_noninteractive):
1048 non interactively attaching files to message edit window
1049 * src/widgets/modest-msg-edit-window.h:
1050 * tests/dbus_api/Makefile.am:
1051 added test_compose_mail.c
1052 * tests/dbus_api/test_compose_mail.c: (main):
1054 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1056 * src/modest-account-view.c:
1057 Fixed bug projects.maemo.org bug NB#59307
1059 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1061 * src/maemo/easysetup/modest-easysetup-wizard.c:
1062 (get_serverport_incoming), (on_before_next), (create_account):
1063 * src/maemo/modest-account-settings-dialog.c:
1064 (modest_account_settings_dialog_set_account_name):
1065 * src/maemo/modest-maemo-utils.c:
1066 (on_camel_account_get_supported_secure_authentication_status),
1067 (on_camel_account_get_supported_secure_authentication),
1068 (on_secure_auth_cancel),
1069 (modest_maemo_utils_get_supported_secure_authentication_methods):
1071 Implemented security authentication for settings and easysetup.
1073 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1075 * src/maemo/modest-main-window.c: (create_details_widget):
1076 Show the total size for memory card accounts too, instead of showing
1077 the name again. Fixes bug projects.maemo.org bug NB#59307.
1079 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-tny-simple-folder-store.c:
1083 * src/modest-tny-simple-folder-store.h: Removed.
1085 * src/modest-tny-local-folders-account.h
1086 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1087 for the local-folders maildir, with an extra TnyMergedFolder containing
1088 the folders of the per-account outbox store accounts.
1089 * src/modest-tny-account-store.c: (get_server_accounts):
1090 Add the outboxes to the special local folders account after creating it.
1092 * src/modest-tny-account.c:
1093 (modest_tny_account_new_for_local_folders): Create the derived
1094 account when creating the main local-folders account.
1096 * src/maemo/modest-main-window.c: (create_details_widget),
1097 (modest_main_window_set_contents_style):
1098 Adapted to the use of the derived account instead of the folder store.
1100 * src/modest-ui-actions.c:
1101 (modest_ui_actions_on_folder_selection_changed):
1102 * src/modest-ui-dimming-rules.c:
1103 (modest_ui_dimming_rules_on_new_folder):
1104 * src/widgets/modest-folder-view.c: (text_cell_data),
1105 (icon_cell_data), (filter_row), (update_model),
1106 (get_cmp_rows_type_pos):
1109 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1110 Do not get the priv struct, because no priv struct has been set,
1111 to avoid a runtime warning.
1113 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1114 #ifelse with #else, to fix a warning, to fix the build.
1117 2007-06-05 Christian Kellner <ckellner@openismus.com>
1119 * libmodest-dbus-client/libmodest-dbus-client.c:
1120 Fix small typo in doc (why do you always see them
1121 AFTER committing stuff?)
1124 2007-06-05 Christian Kellner <ckellner@openismus.com>
1126 * libmodest-dbus-client/libmodest-dbus-client.c:
1127 (libmodest_dbus_client_search):
1128 Initialize hit list with NULL. Also set folder list
1129 to "" if NULL was supplied.
1132 2007-06-03 Christian Kellner <ckellner@openismus.com>
1134 * libmodest-dbus-client/libmodest-dbus-client.c:
1135 (modest_search_hit_list_free):
1136 Make it save to call it with NULL.
1138 * src/dbus_api/modest-dbus-callbacks.c:
1139 * src/modest-search.c:
1140 Return full ModestSearchHits as the search result list not TnyHeader
1141 since can't be around withouth the correspoding TnyFolder.
1143 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1145 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1146 Added currently commented code to check for secure auth
1148 * src/maemo/modest-account-settings-dialog.c: (on_response),
1149 (save_configuration), (show_ok):
1150 Fixed projects.maemo.org bugs NB #59248 and #59251
1152 * src/maemo/modest-maemo-utils.c:
1153 (on_camel_account_get_supported_secure_authentication_status),
1154 (on_camel_account_get_supported_secure_authentication),
1155 (modest_maemo_utils_get_supported_secure_authentication_methods):
1156 * src/maemo/modest-maemo-utils.h:
1157 Moved get_supported_secure_authentication() method here to be able
1158 to use it from easysetup wizard.
1160 * src/modest-pair.c: (on_pair_compare_as_string):
1161 Should compare string with first part of pair and not
1162 strcmp pairs which will crash.
1164 * src/modest-protocol-info.c:
1165 (modest_protocol_info_protocol_is_store):
1166 * src/modest-protocol-info.h:
1167 Added modest_protocol_info_get_auth_protocol_name()
1169 2007-06-03 Armin Burgmeier <armin@openismus.com>
1171 * src/modest-mail-operation.c:
1172 (modest_mail_operation_get_msgs_full): Set priv->account also when
1173 only retrieving a single message. This avoids a crash when canceling
1176 (modest_mail_operation_notify_end): Do not explicitely remove the
1177 operation from the queue but only emit the progress_changed signal.
1178 The queue itself listens to that signal to remove the operation when
1179 it is finished. This reduces coupling and removes a potential deadlock
1180 when modest_mail_operation_notify_end() is called from the queue
1181 itself. If that is a problem performance-wise, I would suggest to
1182 implement a status-changed signal or something.
1184 * src/modest-mail-operation-queue.c: Make sure to never call a
1185 function from another file while the queue is locked. This (hopefully)
1186 fixes another deadlock when exiting the application while retrieving
1189 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1191 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1192 Fixed build if libogs is not available
1194 2007-06-03 Christian Kellner <ckellner@openismus.com>
1196 * libmodest-dbus-client/libmodest-dbus-client.h:
1197 * libmodest-dbus-client/libmodest-dbus-client.c:
1198 (libmodest_dbus_client_delete_message):
1199 Implement deletion of messages (Client side).
1201 (modest_search_hit_free),
1202 (modest_search_hit_list_free):
1203 Utility functions to free the result hits.
1205 * src/dbus_api/modest-dbus-api.h:
1206 * src/dbus_api/modest-dbus-callbacks.c:
1207 (on_delete_message),
1208 (modest_dbus_req_handler):
1209 Implement deletion of messages (Server side).
1211 * tests/dbus_api/test_search.c: (main):
1214 * tests/dbus_api/Makefile.am:
1215 * tests/dbus_api/test_delete_message:
1216 Add little test for the message deletion logic
1218 2007-06-03 Armin Burgmeier <armin@openismus.com>
1220 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1221 when the operation queue was not empty. projects.maemo.org bug
1224 2007-06-03 Armin Burgmeier <armin@openismus.com>
1226 * src/widgets/modest-account-view.c
1227 (on_account_default_toggled): Toggle default account column
1228 explicitely instead of waiting for gconf notification (which is
1229 currently ignored). This should fix projects.maemo.org bug NB#56910
1230 for now. It should probably be removed when gconf notifications are
1233 2007-06-03 Christian Kellner <ckellner@openismus.com>
1235 * libmodest-dbus-client/libmodest-dbus-client.c:
1236 Removed debugging spew.
1238 * src/dbus_api/modest-dbus-callbacks.c:
1239 Added debugging info.
1241 * src/modest-search.c:
1242 (modest_search_all_accounts):
1243 Use tny_account_store_get_accounts () on the account store
1244 to get all accounts which is the way to get all accounts.
1246 * tests/dbus_api/test_search.c: (main):
1247 Make it possible to supply the search term on the command line.
1249 2007-06-03 Christian Kellner <ckellner@openismus.com>
1251 * libmodest-dbus-client/libmodest-dbus-client.c:
1252 * libmodest-dbus-client/libmodest-dbus-client.h:
1253 Implement searching for mesages over raw dbus. (Client side)
1255 * src/dbus_api/Makefile.am:
1256 * src/dbus_api/modest-dbus-api.h:
1257 * src/dbus_api/modest-dbus-callbacks.c:
1258 * src/dbus_api/modest-dbus-callbacks.h:
1259 Search framework (Server side). Also implement on_idle_open_message().
1261 * src/maemo/modest-platform.c: (modest_platform_init):
1262 Prepare for raw dbus/osso rpc interaction.
1264 * src/modest-search.h:
1265 Changed minsize from unspecific guint to guint32.
1267 * src/modest-search.c:
1269 Added strange hack which magically made tnymail work.
1271 (modest_search_folder),
1272 (modest_search_account),
1273 (modest_search_all_accounts):
1274 Implement helper functions to search all accounts, specific account
1277 * tests/dbus_api/Makefile.am:
1278 * tests/dbus_api/test_open_message.c:
1279 Read url to open from commandline.
1281 * tests/dbus_api/test_search.c:
1282 Implement small test for dbus search stuff
1284 2007-06-02 Armin Burgmeier <armin@openismus.com>
1286 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1287 include account type and account title. This fixes projects.maemo.org
1290 * src/maemo/modest-account-view-window.c: Set a title for the window.
1292 2007-06-02 Armin Burgmeier <armin@openismus.com>
1294 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1295 incoming and outgoing server name based on email address and server
1296 types as long as the names have not been edited manually. This fixes
1297 projects.maemo.org bug NB#58671.
1299 2007-06-02 Armin Burgmeier <armin@openismus.com>
1301 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1302 server type cannot be changed in future to the incoming details page
1303 when creating an account. This fixes projects.maemo.org bug NB#59029.
1305 2007-06-02 Armin Burgmeier <armin@openismus.com>
1307 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1308 and assigned max width chars so that they wrap instead of being
1309 truncated. Fixes projects.maemo.org bug NB#56126.
1311 2007-06-02 Armin Burgmeier <armin@openismus.com>
1313 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1314 introductory note to the connection specific smtp servers dialog, as
1315 section 8.12 of the email UI specification requires. This fixes
1316 projects.maemo.org bug NB#59212.
1318 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1321 Check for running mail operations, and offer to cancel them, as per the UI
1322 spec. This fixes projects.maemo.org bug NB#59041 .
1323 However, I suspect that tinymail may still use the network connection
1324 in ways that we cannot detect or cancel. But it should at least adapt to
1325 changes fairly well.
1327 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-tny-account-store.c: (recreate_all_accounts),
1330 (get_cached_accounts), (get_server_accounts): Do more sensible
1331 ref-counting of the temporarily-cached outbox accounts list. This seems
1332 to fix a crash when entering the password when the password was wrong.
1334 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1336 * src/gnome/modest-main-window.c: (connect_signals):
1337 * src/modest-tny-account-store.c: (get_password),
1338 (modest_tny_account_store_alert): Added comments and clues and
1339 commented-out code about how we currently fail to deal with connection
1340 errors and wrong passwords, and how we should.
1342 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1344 * src/widgets/modest-retrieve-combo-box.c:
1345 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1346 This fixes projects.maemo.org bug NB#58472 .
1348 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1350 * src/maemo/easysetup/modest-easysetup-wizard.c:
1351 (create_page_complete_easysetup):
1352 (create_page_complete_custom): Correct the last commit,
1353 putting the correct sentences in the correct pages.
1355 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1357 * src/maemo/easysetup/modest-easysetup-wizard.c:
1358 (create_page_complete_custom): Show the second sentence of text
1359 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1362 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1365 Set the leave-on-server conf key by default. This fixes
1366 projects.maemo.org bug NB#59258 .
1368 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/modest-account-view-window.c:
1371 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1372 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1375 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1377 * src/maemo/easysetup/modest-easysetup-wizard.c:
1378 (create_caption_new_with_asterisk):
1379 * src/maemo/modest-account-settings-dialog.c:
1380 (create_caption_new_with_asterisk):
1381 Uncomment the code to add the asterisk, because they are no longer in the
1382 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1383 (update_incoming_server_title): Add an asterisk here too.
1385 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1387 * src/maemo/modest-maemo-global-settings-dialog.c:
1388 (current_connection): Check that we are even connected before trying to
1389 get the current connection name, to prevent a warning.
1391 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1392 Change the comments because tny_maemo_conic_device_connect() is now meant to
1394 * src/modest-mail-operation.c:
1395 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1396 make sure we have a connection and fail if we can't connect.
1398 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1400 * src/maemo/modest-main-window.c:
1401 (on_account_store_connecting_finished): Do not try to get the
1402 connection ID if we are not really connected. I am surprised that
1403 this signal handler is called when we are not connected.
1405 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1407 * src/modest-error.h:
1408 * src/modest-ui-actions.c:
1409 (modest_ui_actions_get_msgs_full_error_handler):
1410 Renamed an enum, added comments, added an enum
1411 for retrieve-limit errors.
1413 * src/modest-mail-operation.c: (foreach_add_item),
1414 (internal_folder_observer_update), (update_account_thread),
1415 (modest_mail_operation_get_msgs_full):
1416 (modest_mail_operation_update_account),
1417 Added comments about how this works, and some code that should
1418 (but does not) check the retrieve-limit. See the TODO comment.
1420 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1423 Initialize help_id to fix the build. Warnings are good.
1425 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1427 * src/widgets/modest-hbox-cell-renderer.c:
1428 (modest_hbox_cell_renderer_append):
1429 * src/widgets/modest-vbox-cell-renderer.c:
1430 (modest_vbox_cell_renderer_append):
1431 Fix the last commit by doing an extra ref.
1433 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1435 * src/widgets/modest-hbox-cell-renderer.c:
1436 (modest_hbox_cell_renderer_append):
1437 * src/widgets/modest-vbox-cell-renderer.c:
1438 (modest_vbox_cell_renderer_append):
1439 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1440 to fix the build with Maemo Bora.
1441 However, there seems to be a remaining crash, probably due to reference
1444 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1446 * src/modest-tny-account.c:
1447 (modest_tny_account_new_for_local_folders):
1448 Use hildon_file_system_info_async_new() to get a better name for
1449 the memory card account, setting it as the account name.
1450 The timing seems to work, but this is probably
1451 not the best place to do this. See the TODO comment.
1452 * src/maemo/modest-main-window.c: (create_details_widget):
1453 * src/widgets/modest-folder-view.c: (text_cell_data):
1454 Use the tny account name instead of hardcoding a name.
1456 2007-05-30 Christian Kellner <ckellner@openismus.com>
1458 * src/modest-search.c: (modest_search):
1459 Correctly set part_search_func even if we have already parsed
1460 the query and thus a valid OgsTextSearcher object.
1462 2007-05-30 Christian Kellner <ckellner@openismus.com>
1465 Search and check for libogs.
1468 Incooparte the ogs build env.
1470 * src/modest-mime-part-search-stream.c:
1471 * src/modest-mime-part-search-stream.h:
1472 Removed since we do the real searching now in modest-search.c.
1474 * src/modest-search.c:
1475 * src/modest-search.h:
1476 Implement support for ogs. We use that if available and requested
1477 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1478 should now handle the corner case when the search term is spread
1479 across multiple reads.
1480 Also the logic in modest_search () was corrected to search all
1481 requested fields until one is found.
1483 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1487 * src/modest-init.h:
1488 * src/modest-init.c: Made modest_init_local_folders() take a
1489 path and be public so we can iniitialize maildir folders on
1492 * src/modest-local-folder-info.h:
1493 * src/modest-local-folder-info.c:
1494 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1496 * src/modest-tny-account.c:
1497 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1498 still means the standard local-folders path on the local volume.
1500 * src/modest-tny-account-store.c:
1501 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1502 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1503 all accounts when that happens.
1504 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1505 this too, so it shows up in the treeview.
1507 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1509 * src/maemo/modest-maemo-global-settings-dialog.c:
1510 (current_connection):
1511 * src/widgets/modest-global-settings-dialog.c:
1512 (current_connection_default):
1513 Use the enum values instead of 0, 1 and -1,
1514 to make the code clearer.
1516 * src/modest-account-mgr-helpers.c:
1517 (modest_account_mgr_get_connection_specific_smtp): Make this code
1520 * src/modest-runtime.h:
1521 * src/modest-runtime.c:
1522 Added modest_runtime_remove_all_send_queues().
1523 * src/maemo/modest-main-window.c:
1524 (on_account_store_connecting_finished): Recreate the send queues,
1525 using the appropriate transport accounts for this new connection.
1526 Some futher adapting might be needed if the old send queues are not
1527 automatically stopped at this point.
1529 * src/modest-tny-account-store.c: (get_server_accounts):
1530 Create the connection-specific transport accounts, so that they can
1531 be found later by their ID.
1533 * src/modest-tny-account.h:
1534 * src/modest-tny-account.c:
1535 Added modest_tny_account_new_from_server_account_name().
1536 modest_tny_account_new_from_server_account(): Do not create the
1537 send queues here, because they will be
1538 recreated anyway when the connection changes for the first time.
1540 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1542 * src/modest-local-folder-info.h:
1543 * src/modest-local-folder-info.c:
1544 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1545 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1546 tbox_folder): Take a modest account name instead of a server TnyAccount,
1547 so we can have per-modest-account rather than per-transport-account
1549 We must make sure that we change or recreate the exisitng send queues
1550 when the connection changes for connection-specific transport accounts.
1552 * src/modest-tny-account-store.c:
1553 (create_per_account_local_outbox_folders): Create outboxed per modest
1554 account, not per transport account.
1556 * src/modest-tny-account.h:
1557 * src/modest-tny-account.c:
1558 (modest_tny_account_get_special_folder): For outboxes, get the
1559 parent modest account name. The account is ignored for other folders.
1560 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1561 modest account name rather than a server TnyAccount.
1563 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-tny-account.c:
1566 (modest_tny_account_new_from_server_account):
1567 Call modest_runtime_get_send_queue() immediately after creating transport
1568 accounts, so that they start trying to send email from the outbox as soon
1569 as possible at startup. This is probably what we want.
1571 * src/modest-mail-operation.c: (update_account_thread):
1572 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1573 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1574 * src/modest-tny-send-queue.h:
1575 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1576 (modest_ui_actions_on_send):
1577 Added comments about how sending works, though it needs some more work.
1579 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-account.c:
1582 (modest_tny_account_get_special_folder): Add TODO because this fails when
1583 the network is busy.
1584 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1585 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1586 Do not try to show this window when there is no active account. The UI
1587 specs does not tell us what to do in this case.
1589 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/Makefile.am:
1594 * src/widgets/Makefile.am: Some dist fixes.
1596 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-connection-specific-smtp-window.c:
1599 (on_button_edit): Make the code clearer, to prevent a double free.
1601 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1603 * src/maemo/modest-account-settings-dialog.c:
1604 (modest_account_settings_dialog_set_account_name),
1605 Check the connection-specific smtp servers checkbox if there are any.
1607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1608 (modest_connection_specific_smtp_edit_window_init):
1609 Start with a suitable port number.
1611 * src/modest-account-mgr-helpers.h:
1612 * src/modest-account-mgr-helpers.c: Added
1613 modest_account_mgr_get_has_connection_specific_smtp().
1615 (modest_account_mgr_set_connection_specific_smtp),
1616 (modest_account_mgr_remove_connection_specific_smtp),
1617 (modest_account_mgr_get_has_connection_specific_smtp),
1618 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1619 connection-specific smtp server accounts in the account, rather than
1620 the server account conf dir.
1622 This fixes bug projects.maemo.org bug NB#58263 .
1624 * src/modest-tny-account-store.c:
1625 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1626 if there are no server accounts yet, to prevent an infinite loop when there
1627 are no accounts. Document that one must be called before the other.
1629 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-account-mgr-helpers.c:
1632 (modest_account_mgr_get_default_account): Make sure that at least
1633 one account is always the default, if there are any enabled accounts.
1634 This is just a sanity check that shouldn't be necessary.
1636 * src/modest-account-mgr-priv.c:
1637 (_modest_account_mgr_account_from_key): Unescape the conf key to
1638 get the real account name. For instance, this is an issue if a space
1639 was in the account name, which can happen because the account name
1640 is generated from the display name.
1641 (_modest_account_mgr_get_account_keyname): Always escape the
1643 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1644 Unescape the conf keys to get the real account names.
1646 For instance, previously the is-default radio button in the accounts
1647 list was not checked for any accounts at first. This fixes that,
1648 and might fix several similar bugs.
1650 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1652 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1653 Removed some debug printfs.
1655 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1657 Modest on-disk outbox directories are now here, for instance:
1658 $HOME/.modest/outboxes/<account-id-1>/outbox
1659 $HOME/.modest/outboxes/<account-id-2>/outbox
1661 $HOME/.modest/local-folders/outbox
1662 so we can have a separate outbox for each account.
1663 But they are shown as one outbox in the GtkTreeView, by using a
1664 TnyMergeFolder in a ModestTnySimpleFolderStore.
1667 * src/modest-tny-simple-folder-store.c:
1668 * src/modest-tny-simple-folder-store.h:
1669 Added ModestTnySimpleFolderStore, used to contain folders from
1670 other folder stores, such as other accounts.
1672 * src/modest-tny-outbox-account.h:
1673 * src/modest-tny-outbox-account.c:
1674 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1675 used for the per-account local outbox folders.
1677 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1678 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1679 only use this (internally) now for the non-outbox local folders.
1681 * src/modest-init.h:
1682 * src/modest-init.c: Added modest_init_one_local_folder(), for
1683 setting up the directory structure for each local folder.
1685 * src/modest-local-folder-info.c:
1686 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1687 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1689 * src/modest-local-folder-info.h:
1690 * src/modest-tny-account-store.c: (on_account_removed),
1691 (on_account_changed), (create_per_account_local_outbox_folders),
1692 (get_server_accounts), (modest_tny_account_store_get_accounts),
1693 (modest_tny_account_store_get_tny_account_by_account),
1694 (modest_tny_folder_store_is_virtual_local_folders):
1696 * src/modest-tny-account.h:
1697 * src/modest-tny-account.c:
1698 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1699 to create an on-disk per-account local outbox folder for each
1701 (create_per_account_local_outbox_folders): Create a local outbox folder
1702 for each transport account.
1703 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1704 for all local folders.
1706 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1707 instead of using g_object_get/set() directly. It is clearer.
1709 (modest_tny_folder_store_get_message_count),
1710 (modest_tny_folder_store_get_local_size
1711 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1712 because we now use these with non-acount folder stores.
1714 (modest_tny_account_get_special_folder),
1715 (modest_tny_account_new_from_server_account),
1716 (modest_tny_account_new_from_account):
1717 (recurse_folders): Adjust to the new outbox system.
1719 * src/modest-tny-folder.h:
1720 * src/modest-tny-folder.c:
1721 (modest_tny_folder_is_local_folder),
1722 (modest_tny_folder_get_local_folder_type),
1723 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1725 * src/widgets/modest-main-window.h:
1726 * src/maemo/modest-main-window.c: (create_details_widget),
1727 (modest_main_window_set_contents_style): Show details for any folder store,
1730 (modest_tny_folder_get_rules):
1731 Remove the const. C does not support constness enough for this.
1733 * src/modest-ui-actions.c:
1734 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1735 make all outboxes appear as one, in the usual local-folders tree node.
1737 (set_active_account_from_tny_account),
1738 (modest_ui_actions_on_folder_selection_changed):
1739 * src/widgets/modest-folder-view.c: (text_cell_data),
1740 (icon_cell_data), (filter_row),
1741 (add_account_folders_to_merged_folder),
1742 (add_account_folders_to_simple_folder_store), (),
1743 (get_cmp_rows_type_pos), (cmp_rows),
1744 (modest_folder_view_set_account_id_of_visible_server_account):
1745 Adjust to the new outbox system, using generic folder stores and folders
1746 in the GtkTreeModel.
1748 2007-05-23 Christian Kellner <ckellner@openismus.com>
1750 * src/modest-mail-operation.c:
1751 (modest_mail_operation_update_account):
1752 Use info->max_size instead of unintialized local var [small
1753 build fix]. (Added TODO to review that change since I don't
1756 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1758 * libmodest-dbus-client/libmodest-dbus-client.c:
1759 (libmodest_dbus_client_compose_mail): function added
1760 * src/dbus_api/modest-dbus-api.h:
1761 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1762 (on_compose_mail): Implementation of the SendAsMail functionality
1764 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1766 * src/modest-account-mgr.c:
1767 (modest_account_mgr_add_server_account): Set the secure-connection
1768 conf key for transport accounts as well as store accounts. I don't know
1769 why the if was there. For instance, this makes sure that we use SSL
1770 for the gmail preset from the easysetup wizard.
1772 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1774 * src/gnome/modest-main-window.c:
1775 (on_account_store_connecting_finished), (connect_signals):
1776 * src/maemo/modest-main-window.c:
1777 (on_account_store_connecting_finished), (connect_signals),
1778 (modest_main_window_new):
1779 Handle TnyAccountStore::connecting-finished instead of
1780 TnyDevice::connection-changed, because we cannot actually perform
1781 operations on accounts until TnyAccountStore has itself responded to
1782 the TnyDevice::connection-changed signal. This prevents a GError from
1784 Do not try to update at startup, because we (at least on scratchbox)
1785 already do an update at startup when the device goes online.
1786 This prevents a GError from tinymail.
1787 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1788 Added TODO about stopping simultaneous operations.
1790 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1792 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1793 * src/modest-mail-operation-queue.c:
1794 (modest_mail_operation_queue_remove):
1795 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1796 about where they happened.
1798 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-ui-actions.c:
1801 (modest_ui_actions_on_password_requested): Make sure that the remember
1802 output parameter is always TRUE.
1804 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1806 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1807 Show a OK/Cancel dialog if the error is a question, though we still do not
1808 know anything more about what we are asking the user.
1809 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1810 Fix an uninitialized variable (helper). This is a logic error, however.
1812 2007-05-21 Christian Kellner <ckellner@openismus.com>
1814 * src/modest-search.h:
1815 Correct bit shifting in the ModestSearchFlags enum.
1817 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-tny-account.c:
1820 (modest_tny_account_new_from_server_account): Do not use the lsub and
1821 check-all hard-coded IMAP options when using POP.
1823 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1825 * src/modest-tny-account.c:
1826 (modest_tny_account_new_from_server_account):
1827 Use NULL for the secure-auth method for POP when Password auth has been
1828 specified by the user, as we already do for IMAP. "auth=Login" causes
1829 an error from camel or the server.
1831 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/modest-account-settings-dialog.c:
1834 (create_page_account_details),
1835 (modest_account_settings_dialog_set_account_name):
1836 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1837 for the leave-on-server checkbox, rathr than just the checkbox, when
1838 the protocol is not POP.
1840 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1842 * src/widgets/modest-account-view.c:
1843 * src/widgets/modest-account-view.h:
1844 Added modest_account_view_select_account() which will be useful later
1845 to asynchronously re-select the edited account.
1847 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1849 * src/maemo/modest-account-settings-dialog.c:
1850 (modest_account_settings_dialog_set_account_name):
1851 Automatically choose the port numbers based on the secure authentication
1852 methods, if they have not been chosen before.
1853 This fixes projects.maemo.org bug NB#56273 .
1855 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1857 * src/maemo/modest-main-window-ui.h:
1858 * src/modest-ui-actions.c:
1859 * src/modest-ui-actions.h:
1860 Connect the Tools/SMTP Servers menu item to
1861 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1862 SMTP servers dialog, as in the UI specification and saves changes when it
1863 is closed. This fixed projects.maemo.org bug NB#56305 .
1865 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1867 * src/maemo/modest-connection-specific-smtp-window.c:
1868 (modest_connection_specific_smtp_window_init):
1869 Use gtk_window_set_default_size() to make this window big enough, so
1870 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1872 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1875 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1876 (modest_connection_specific_smtp_edit_window_init),
1877 Do not try to connect to a combobox signal before the combobox exists.
1878 This fixes the cras in projects.maemo.org bug NB#56288 .
1879 (modest_connection_specific_smtp_edit_window_get_settings):
1880 Remove the server_account_name parameter which was being checked for NULL
1881 though it was not used.
1883 * src/maemo/modest-connection-specific-smtp-window.c:
1884 (modest_connection_specific_smtp_window_fill_with_connections),
1885 (on_button_edit), (modest_connection_specific_smtp_window_init):
1886 Correct the number of treemodel columns to prevent a warning.
1887 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1888 libconic does not work.
1890 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1892 * src/modest-tny-account.c:
1893 (modest_tny_account_new_from_server_account):
1894 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1895 SMTP when "None" was chosen by the user. However, with my SMTP server that
1896 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1899 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1902 to explain the memory management issue with the ID in the ModestPair.
1904 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1905 (add_sending_page), (modest_account_assistant_finalize):
1906 * src/gnome/modest-gnome-global-settings-dialog.c:
1907 (create_updating_page), (create_composing_page):
1908 * src/gnome/modest-msg-edit-window.c: (get_transports),
1909 (init_window), (modest_msg_edit_window_finalize),
1910 (modest_msg_edit_window_get_msg_data):
1911 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1912 * src/gnome/modest-transport-widget.c:
1913 (modest_transport_widget_finalize), (smtp_configuration):
1914 * src/maemo/modest-maemo-global-settings-dialog.c:
1915 (create_updating_page), (create_composing_page):
1916 * src/maemo/modest-msg-edit-window.c: (get_transports),
1917 (init_window), (modest_msg_edit_window_finalize),
1918 (modest_msg_edit_window_get_msg_data),
1919 (modest_msg_edit_window_free_msg_data):
1920 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1921 (modest_store_widget_finalize):
1922 * src/maemo/modest-transport-widget.c:
1923 (modest_transport_widget_finalize), (smtp_configuration):
1924 * src/modest-main.c: (send_mail):
1925 * src/widgets/modest-combo-box.h:
1926 * src/widgets/modest-global-settings-dialog-priv.h:
1927 * src/widgets/modest-global-settings-dialog.c:
1928 (modest_global_settings_dialog_finalize):
1929 * src/widgets/modest-msg-edit-window.h:
1930 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1931 as long as the combo box, to prevent use of freed memory for the ID.
1933 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1935 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1936 get_accounts(), to make this clearer. Do not check for the enabled gconf
1937 key, because we do not use this for server accounts (at least, not yet).
1938 This allows us to send email again.
1940 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/modest-platform.c:
1943 (on_modest_conf_update_interval_changed), (modest_platform_init):
1944 Only respond to this particular key change. All these strcmp()s cannot be
1947 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1949 * src/maemo/modest-maemo-global-settings-dialog.c:
1950 (current_connection): Prevent a crash in scratchbox when
1951 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1952 * src/maemo/modest-platform.c:
1953 (on_modest_conf_update_interval_changed), (modest_platform_init):
1954 Get the update interval from gconf and reset it when the gconf key changes.
1956 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1958 * src/modest-protocol-info.c:
1959 * src/modest-protocol-info.h: Adde enum-specific get functions,
1960 instead of using a ModestProtocolType enum parameter.
1962 * src/gnome/modest-account-assistant.c:
1963 * src/gnome/modest-store-widget.c:
1964 * src/gnome/modest-store-widget.h:
1965 * src/gnome/modest-transport-widget.c:
1966 * src/gnome/modest-transport-widget.h:
1967 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1968 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1969 * src/maemo/easysetup/modest-easysetup-wizard.c:
1970 * src/maemo/modest-account-settings-dialog.c:
1971 * src/maemo/modest-account-settings-dialog.h:
1972 * src/maemo/modest-store-widget.c:
1973 * src/maemo/modest-store-widget.h:
1974 * src/maemo/modest-transport-widget.c:
1975 * src/maemo/modest-transport-widget.h:
1976 * src/modest-account-mgr-helpers.c:
1977 * src/modest-account-mgr-helpers.h:
1978 * src/modest-account-mgr.c:
1979 * src/modest-account-mgr.h:
1980 * src/modest-tny-account.c:
1981 * src/modest-tny-folder.c:
1982 * src/widgets/modest-account-view.c:
1983 * src/widgets/modest-retrieve-combo-box.c:
1984 * src/widgets/modest-retrieve-combo-box.h:
1985 * src/widgets/modest-secureauth-combo-box.c:
1986 * src/widgets/modest-serversecurity-combo-box.c:
1987 * src/widgets/modest-serversecurity-combo-box.h:
1988 * tests/check_account-mgr.c:
1989 Use the specific functions, and use the re-renamed enum values for GNOME too.
1991 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-pair.h:
1994 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1995 so we can get the second based on the first.
1997 * src/maemo/modest-account-settings-dialog.h:
1998 * src/maemo/modest-account-settings-dialog.c:
1999 Added get_supported_secure_authentication_methods(), though it is mostly
2000 commented-out for now until the necessary API is committed to tinymail.
2001 (modest_account_settings_dialog_set_account_name),
2002 (save_configuration): Request the supported authentication methods from the
2003 server, so we can choose a working method.
2005 * src/modest-tny-account-store.h:
2006 * src/modest-tny-account-store.c:
2007 (modest_tny_account_store_get_session): Rename from
2008 tny_account_store_get_session().
2010 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-protocol-info.h: Split the ModestProtocol enum
2013 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2014 There was no need to have these unrelated values in one enum.
2016 * src/: many files: Adapted to changed enum. This makes the code a bit
2017 clearer, and the compiler could catch some errors.
2019 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2022 Show the detailed internal camel error message when an error happens
2023 during the configuration, so that our testers can give us more clues.
2024 For instance, in projects.maemo.org bug NB#56910 .
2026 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-tny-account.c:
2029 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2030 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2032 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2035 * src/maemo/modest-account-settings-dialog.c:
2036 (modest_account_settings_dialog_set_account_name),
2037 (save_configuration): For the incoming secure authentication checkbox,
2038 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2039 the UI specification. PLAIN does not seem to be supported for most IMAP
2040 servers anyway, and I am not sure what it would mean.
2041 However, we probably need to discover which of the secure-authentication
2042 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2043 * src/modest-account-mgr-helpers.c:
2044 (modest_account_mgr_get_server_account_data):
2046 * src/modest-tny-account.c:
2047 (modest_tny_account_new_from_server_account):
2048 Use tny_account_set_mech() to set secure-authentication methods,
2049 with some special-casing for IMAP, based on my observations of how
2052 * src/modest-account-mgr-helpers.h:
2053 * src/modest-account-mgr.c:
2054 * src/modest-defs.h: Comment that the URI is only used for local folders.
2056 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2059 parameter const, just to be neat.
2060 * src/modest-text-utils.c: (modest_text_utils_inline):
2061 End g_strconcat() with NULL, as its documentation says. This is almost
2062 certainly the cause of my crash at startup on the device. Interestingly,
2063 valgrind doesn't tell us about these errors.
2065 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2067 * scripts/build-packages: Added more precise comments about how to use
2068 this script, though I still get this error:
2069 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2070 error building tinymail
2072 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2074 * src/maemo/modest-main-window.c: (on_account_update):
2075 Very slight cleanup, hoping to make it simpler to discover what causes
2076 a crash here sometimes.
2078 * src/modest-tny-account.c:
2079 (modest_tny_account_new_from_server_account): Set the port. Added
2080 comments about the options and a TODO comment because I need to find out
2081 how to specify the secure authentication method.
2083 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2085 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2086 changed CFlags paths form modest to libmodest
2088 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2090 * src/modest-account-mgr-helpers.c:
2091 (modest_account_mgr_get_server_account_data),
2092 (modest_account_mgr_free_server_account_data):
2093 * src/modest-account-mgr-helpers.h:
2094 * src/modest-account-mgr.c:
2095 (modest_account_mgr_add_server_account):
2096 * src/modest-defs.h:
2097 * src/modest-tny-account.c:
2098 (modest_tny_account_new_from_server_account):
2099 Determine the options for tny_camel_account_add_option() here,
2100 based on the settings, rather than storing them directly in gconf.
2102 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2104 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2105 Show a more friendly error dialog now that we expect (from the tinymail
2106 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2108 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2110 * src/maemo/modest-main-window.c: (on_account_update): Check that
2111 account_name is not NULL, to prevent a crash at startup that I am
2112 seeing on the N800. I do wonder why it is NULL.
2114 * src/maemo/easysetup/modest-easysetup-wizard.c:
2115 (create_page_user_details):
2116 * src/maemo/modest-account-settings-dialog.c:
2117 (create_page_user_details), (create_page_outgoing):
2118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2119 (modest_connection_specific_smtp_edit_window_init):
2120 * src/modest-ui-actions.c:
2121 (modest_ui_actions_on_password_requested):
2122 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2123 might do something useful with the on-screen keyboard.
2125 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2127 * src/maemo/modest-main-window.c: (on_account_update):
2128 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2129 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2131 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-tny-account-store.c: (on_account_changed):
2134 Correct the signature of this signal handler.
2136 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2138 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2139 Show a HildonNote instead of a GtkDialog for Maemo.
2141 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2143 * src/widgets/modest-account-view.h:
2144 * src/widgets/modest-account-view.c: (on_account_changed),
2145 (on_account_removed). Added a boolean flag, set/unset by
2146 modest_account_view_block_conf_updates(),
2147 modest_account_view_unblock_conf_updates() to prevent unnecessary
2148 updates, but this is not very useful because the gconf notifications are
2149 so delays (maybe only on Maemo Bora).
2150 So auto-updating is turned off, and these functions do an explicit
2151 update when necessary.
2152 However, something else is still doing too much work when adding/removing
2153 accounts, probably in another part of the application.
2155 * src/maemo/modest-account-view-window.c:
2156 (on_delete_button_clicked), (on_edit_button_clicked),
2157 (on_new_button_clicked): Use the new functions.
2159 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-account-mgr-helpers.c:
2162 (modest_account_mgr_set_first_account_as_default):
2163 Sort the list of names alphabetically-by-title, so we choose the first one
2165 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2166 alphabetically by the title.
2168 This fixes projects.maemo.org bug NB#56418 .
2170 * src/modest-account-mgr-priv.c:
2171 (_modest_account_mgr_account_from_key):
2172 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2173 avoid a valgrind error, and possible random behaviour.
2175 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2178 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2179 tinymail documentation to say that this can be expected.
2180 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2181 pretty, and should not happen, but I would prefer to know when it does.
2183 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2185 * configure.ac: When using the older hildon version, probably on Bora,
2186 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2188 * src/widgets/modest-attachment-view.c:
2189 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2192 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2194 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2195 Implemented the prototype. Can be tested with
2196 tests/dbus_api/test_open_message:
2198 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-tny-account-store.c:
2201 (modest_tny_account_store_instance_init), (get_password):
2202 * src/modest-ui-actions.c:
2203 (modest_ui_actions_on_password_requested):
2204 Do not store the password in gconf, because this function is called
2205 for non-remembered passwords. Actually use the cached (in the hash map)
2206 password instead of releasing it.
2207 The password will now not be remembered if it is asked via the protected
2208 password dialog, as per the UI spec.
2210 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2212 * src/modest-defs.h:
2213 * src/modest-account-mgr-helpers.h:
2214 * src/modest-account-mgr-helpers.c:
2215 Added modest_server_account_get_username_has_succeeded(),
2216 modest_server_account_set_username_has_succeeded().
2217 (modest_server_account_set_username),
2218 Reset the has-succeeded flag if the username changes.
2220 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2221 * src/maemo/modest-connection-specific-smtp-window.c:
2222 (modest_connection_specific_smtp_window_save_server_accounts):
2223 Use modest_server_account_set_username() instead of using
2224 modest_conf_set_string() directly, so that the has-succeeded flag is always
2227 * src/modest-ui-actions.c:
2228 (modest_ui_actions_on_password_requested): Dim the username entry if
2229 the username has ever worked, as per the UI spec.
2231 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2233 * src/modest-tny-account-store.c: (get_password):
2234 * src/modest-ui-actions.c:
2235 (modest_ui_actions_on_password_requested):
2236 Allow the username to be changed too, though there is more work to
2237 be done on exactly how this behaves.
2239 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2241 * src/modest-account-mgr-helpers.h:
2242 * src/modest-account-mgr-helpers.c:
2243 Added modest_account_mgr_get_display_name(),
2244 modest_server_account_get_username(),
2245 modest_server_account_set_username(),
2246 modest_server_account_set_password(),
2247 modest_server_account_get_hostname() functions so we do not need to
2248 use the conf API directly.
2250 * src/maemo/modest-main-window.c: (connect_signals):
2251 Actually connect ot the ModestAccountStore::request-password signal,
2252 so that we show the dialog when the password is requested by Tinymail,
2253 for isntance if it is empty.
2255 * src/modest-marshal.list:
2256 * src/modest-tny-account-store.c:
2257 (modest_tny_account_store_class_init), (get_password),
2258 (modest_tny_account_store_alert):
2259 * src/modest-tny-account-store.h:
2260 * src/modest-ui-actions.h:
2261 * src/modest-ui-actions.c:
2262 (modest_ui_actions_on_password_requested):
2263 Change the signal parameters, so it is obvious that we are providing
2264 the non human-readable server name, and receiving both the username
2265 and password, though changing of the username is not yet implemented.
2266 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2267 for the GNOME version.
2269 This should fix the projects.maemo.org bug NB#56209, though it does not
2270 work on Bora, because the gconf_client_get() for the password fails
2271 immediately after we save it with gconf_client_set().
2273 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2276 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2277 caused an undefined symbol error:
2278 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2280 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2282 * src/modest-tny-account-store.c:
2283 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2284 using a GError instead of a string message, so we can translate it in
2287 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2289 * src/maemo/modest-address-book.c:
2290 (modest_address_book_check_names):
2291 * src/maemo/modest-msg-view-window.c:
2292 (modest_msg_view_window_clipboard_owner_change):
2293 * src/modest-init.c: (modest_init_init_ui):
2294 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2295 (update_folders_cb), (modest_mail_operation_update_account):
2296 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2297 (modest_ui_actions_on_msg_attachment_clicked),
2298 (modest_ui_actions_on_msg_recpt_activated):
2299 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2300 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2301 (modest_msg_view_search_next):
2302 * src/widgets/modest-recpt-editor.c:
2303 (modest_recpt_editor_on_button_release_event),
2304 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2305 g_message(). At this point we should only be seeing interesting errors on
2306 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2308 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2310 (modest_wizard_dialog_force_title_update):
2311 * src/maemo/easysetup/modest-wizard-dialog.h:
2312 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2313 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2314 can update the title when appropriate. Otherwise the title is wrong if the
2315 pages are added after adding the notebook to the dialog.
2316 This must be a problem in HildonWizardDialog too.
2317 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2319 * src/maemo/easysetup/modest-easysetup-wizard.c:
2320 (create_subsequent_customsetup_pages),
2321 (create_subsequent_easysetup_pages):
2322 Call modest_wizard_dialog_force_title_update() so that the title is
2323 correct even with GTK+ < 2.10.
2324 This fixes projects.maemo.org bug NB#56145 .
2326 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-platform.c:
2329 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2330 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2333 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2335 * src/widgets/modest-window.h:
2336 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2337 and modest_window_save_state(), which invokes it.
2339 * src/widgets/modest-window-mgr.h:
2340 * src/widgets/modest-window-mgr.c:
2341 Added modest_window_mgr_save_state_for_all_windows(), which calls
2342 the save_state vfunc on all registered windows, if implemented.
2344 * src/gnome/modest-msg-edit-window.c:
2345 * src/gnome/modest-msg-view-window.c:
2346 * src/maemo/modest-msg-edit-window.c:
2347 * src/maemo/modest-msg-view-window.c:
2348 * src/maemo/modest-main-window.c:
2349 Specify the existing save_settings functions as implementations of
2350 ModestWindow::save_state_func().
2352 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2353 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2354 enabling hibernation, for instance.
2356 We may need to do the same thing for restoring settings.
2359 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2361 * src/widgets/modest-window-mgr.c:
2362 * src/widgets/modest-window-mgr.h:
2363 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2364 modest_window_mgr_get_hibernation_is_prevented().
2366 * src/maemo/modest-main-window.c:
2367 (on_hildon_program_is_topmost_notify): Prevent hibernation
2368 (possible when the application goes to the background in the WM),
2369 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2371 * src/maemo/easysetup/modest-easysetup-wizard.c:
2372 (modest_easysetup_wizard_dialog_init):
2373 * src/maemo/modest-account-settings-dialog.c:
2374 (modest_account_settings_dialog_init):
2375 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2376 (modest_connection_specific_smtp_edit_window_init):
2377 * src/maemo/modest-connection-specific-smtp-window.c:
2378 (modest_connection_specific_smtp_window_init):
2379 * src/maemo/modest-signature-editor-dialog.c:
2380 (modest_signature_editor_dialog_init):
2381 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2382 prevent hibernation while any of these account settings dialogs are open.
2384 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/Makefile.am:
2387 * src/maemo/modest-osso-state-saving.c:
2388 * src/maemo/modest-osso-state-saving.h: Added
2389 modest_osso_load_state() and modest_osso_save_state() though they do
2390 nothing now. They should iterate through all the open windows and load/save
2392 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2393 save state when closing.
2395 * src/maemo/modest-main-window.c:
2396 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2397 Add a notification handler for the HildonProgram::is-topmost property,
2398 so we can allow hibernation when the application goes into the background.
2399 But we still need to detect when the accounts setup windows are open so
2400 we can stop hibernation when they are open.
2401 To do this, I also added the main window the HildonProgram. This might have
2402 other side-effects/benefits, and should maybe be done for other windows.
2404 * src/maemo/modest-osso-autosave-callbacks.h:
2405 * src/maemo/modest-osso-autosave-callbacks.c:
2406 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2407 though it does not do anything yet, and we might never need this to do
2408 anything. For instance, we already save drafts.
2410 * src/maemo/modest-platform.c: (modest_platform_init):
2411 Specify the libosso auto-save callback.
2413 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/modest-platform.c:
2416 (modest_platform_set_update_interval):
2417 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2418 aparently stays valid between application instances, so we can use this
2419 to remove and reset it later. According to a maemo-developers email from
2422 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2424 * configure.ac: Depend on libalarm for Maemo.
2426 * src/dbus_api/modest-dbus-api.h:
2427 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2428 (on_send_receive), (modest_dbus_req_handler):
2429 Handle a SEND_RECEIVE D-Bus method.
2431 * libmodest-dbus-client/libmodest-dbus-client.c:
2432 (libmodest_dbus_client_send_and_receive):
2433 * libmodest-dbus-client/libmodest-dbus-client.h:
2434 Add C convenience functions for calling the new D-Bus method.
2436 * src/modest-platform.h:
2437 * src/gnome/modest-platform.c:
2438 * src/maemo/modest-platform.c:
2439 Added modest_platform_set_update_interval(), which uses the
2440 alarmd API on Maemo.
2441 (modest_platform_init),
2442 Call modest_platform_set_update_interval(), using a hard-coded
2443 interval for now (until the global settings dialog is implemented),
2444 though I am not sure that this makes sense yet.
2446 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2448 * src/dbus_api/modest-dbus-callbacks.c:
2449 (modest_osso_cb_hw_state_handler):
2450 * src/dbus_api/modest-dbus-callbacks.h:
2451 * src/maemo/modest-platform.c: (modest_platform_init):
2452 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2453 in case this has some effect on the ability for Maemo to ping the
2456 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2458 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2459 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2460 warning. It is probably a logic error, but I need to fix the build.
2462 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2464 * src/modest-account-mgr.h:
2465 * src/modest-account-mgr.c:
2466 (modest_account_mgr_account_names): Add a gboolean enabled_only
2467 parameter, so we can get lists of onlt the enabled accounts.
2469 (modest_account_mgr_add_account),,
2470 (modest_account_mgr_account_with_display_name_exists):
2471 * src/maemo/modest-msg-edit-window.c: (get_transports):
2472 * src/modest-account-mgr-helpers.c:
2473 (modest_account_mgr_set_first_account_as_default):
2474 * src/modest-init.c: (init_default_account_maybe):
2475 * src/modest-tny-account-store.c: (get_accounts):
2476 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2477 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2478 * tests/check_account-mgr.c: (START_TEST):
2479 Provide the extra parameter, as appropriate.
2481 * src/widgets/modest-account-view.c: (update_account_view):
2482 Do not show disabled accounts (meaning that there is no way to
2483 enable/disable accounts in the UI (the feature is not in our UI
2484 specification), so we can use this internally only to mark unfinished
2485 or temporary account data.
2487 * src/maemo/easysetup/modest-easysetup-wizard.c:
2488 (create_account): Add boolean enable parameter, so we can specify FALSE
2489 to create the temporary account.
2490 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2491 (on_before_next): When finishing, when there is a temporary account, just
2493 Also, use a timeout to delay the showing of the dialog until gconf is likely
2494 to return correct information, due to a maemo gconf bug that is fixed in
2495 osso 1.1, but not yet in Bora.
2496 However, the dialog stays on screen after it is destroyed.
2498 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2499 for invalid data when cancelling. Use a hildon note instead of a dialog
2500 to complain about invalid data. Do not show the account-saved note if the
2501 account is disabled (a temporary account that will not really be saved for use
2504 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2506 * src/modest-account-mgr-helpers.h:
2507 * src/modest-account-mgr-helpers.c:
2508 Added modest_account_mgr_unset_default_account(),
2509 Added modest_account_mgr_set_first_account_as_default().
2511 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2512 If it was the default account, unset the default account name.
2514 * src/maemo/modest-account-view-window.c:
2515 (on_delete_button_clicked): If it was the default account,
2516 set the first remaining account as the default instead.
2518 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2519 a NULL account or a NULL default account, to prevent a crash. This should
2520 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2523 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2525 * src/widgets/modest-recpt-editor.c:
2526 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2527 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2528 TODO comment for this. This fixes the build.
2530 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2531 be the best place for it. This will in future update all auto-update accounts,
2532 rather than just the current/default account, when that gconf key exists.
2533 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2534 if there are no accounts, before calling do_send_receive().
2535 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2537 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2538 * src/maemo/modest-main-window-ui.h:
2539 * src/maemo/modest-main-window.c: (on_connection_changed),
2540 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2541 directly, becaue the signal handler does more.
2543 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2545 * src/modest-account-mgr-helpers.c:
2546 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2547 for the case that the account does not exist.
2549 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2550 (equivalent to the modest account name) rather than the tinymail account name
2551 (equivalent to the modest account title - human readable) to get the account data.
2552 Check for null account data to prevent the crash, and add a TODO comment saying that
2553 this needs fixing because it is using the server account name instead of the account name.
2555 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2557 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2558 * src/maemo/modest-account-settings-dialog.c: (show_error),
2560 Use hildon_note_new_information() for informative and error messages,
2561 which seems to be expected for Maemo applications (no documentation that I know of
2562 says this). I am surprised that there is no distinction between info and error
2565 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2568 it is easy to find where this is used.
2570 * src/maemo/easysetup/modest-easysetup-wizard.c:
2571 (create_page_welcome), (create_page_account_details),
2572 (create_page_user_details), (create_page_complete_easysetup),
2573 (create_page_custom_incoming), (create_page_custom_outgoing),
2574 (create_page_complete_custom):
2575 * src/maemo/modest-account-settings-dialog.c:
2576 (create_page_account_details), (create_page_user_details),
2577 (create_page_incoming), (create_page_outgoing):
2578 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2579 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2580 (modest_connection_specific_smtp_edit_window_init):
2581 * src/maemo/modest-connection-specific-smtp-window.c:
2582 (modest_connection_specific_smtp_window_init):
2583 * src/maemo/modest-signature-editor-dialog.c:
2584 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2585 and scrolling policy as per the Email Application Layout Guide, if I have
2588 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2590 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2591 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2592 which were empty, because these vfuncs have been removed from TnyAccountStore.
2593 This fixes the build.
2595 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2597 * src/maemo/modest-main-window.c:
2598 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2599 showing/hiding it. Added TODO because it probably should not be NULL.
2600 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2601 because unnecessary g_warnings() make degugging difficult.
2603 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/modest-msg-edit-window.c:
2606 (modest_msg_edit_window_select_color),
2607 (modest_msg_edit_window_select_background_color): 2 const corrections and
2608 moving 2 #endifs before closing brackets, to fix the build.
2610 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/easysetup/modest-easysetup-wizard.h:
2613 * src/maemo/easysetup/modest-easysetup-wizard.c:
2614 (modest_easysetup_wizard_dialog_finalize),
2615 (on_button_edit_advanced_settings), (create_page_complete_custom),
2616 (on_response), (create_account):
2617 Implement the Advanced Settings edit button, by saving the account information,
2618 for the Advanded Settings dialog to use directly from gconf, and removing it
2619 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2620 Bug #5533 in the projects.maemo.org bugzilla.
2622 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/modest-msg-view-window.c:
2625 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2626 when opening a message window.
2628 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2630 * src/maemo/easysetup/modest-easysetup-wizard.c:
2631 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2634 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2635 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2636 gconf settings. I probably added more checks than necessary, but that is safer.
2638 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2639 variable to fix the build, but this seems to be used when it is still NULL.
2641 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2643 * src/modest-platform.h:
2644 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2645 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2646 * src/modest-main.c: Implement this function so we can avoid using
2647 maemo-specific API from cross-platform code.
2649 * src/modest-tny-account-store.c:
2650 (get_smtp_specific_transport_account_for_open_connection):
2651 * src/modest-ui-actions.c: (check_for_connection),
2652 (modest_ui_actions_on_item_not_found):
2653 Use modest_platform_connect_and_wait() and put #idefs around other
2654 maemo-specific code, because only maemo currently has a way to
2655 identify connection names.
2657 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-tny-account-store.h:
2660 * src/modest-tny-account-store.c:
2661 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2662 the connection-specific SMTP server settings in the configuration.
2664 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2666 * src/maemo/modest-main-window.c: (on_connection_changed),
2668 * src/modest-main.c: (main), (start_ui), (send_mail):
2669 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2670 that is what is intended.
2672 * src/modest-ui-actions.c: (action_send), (action_receive),
2673 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2674 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2675 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2676 SMTP server is used when it is specified.
2678 (modest_ui_actions_on_send_receive):
2679 Check that a connection is open before proceeding.
2680 Receive and then send, instead of vice-versa, as per the specification.
2682 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-mail-operation.c:
2685 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2686 though I guess it should be something other than NULL.
2688 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2690 * src/maemo/easysetup/modest-easysetup-wizard.c:
2691 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2692 combo twice, to avoid an g_warning and to make it visible again.
2693 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2694 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2695 (already intended) dereference when detaching, because we then recreate the menu.
2696 But I am not sure why the warning was happening, and it is possible that this is a memory
2699 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2701 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2702 and uri_parse_mailto() utility functions.
2703 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2705 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2707 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2709 * src/dbus_api/modest-dbus-api.h:
2710 * src/dbus_api/modest-dbus-callbacks.c:
2711 Use an idle callback to execute the modest code in the application's own thread.
2712 Remove the helloworld example method.
2713 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2714 parsed, and the open-message method is not implemented because this is not yet implemented in
2716 * libmodest-dbus-client/libmodest-dbus-client.c:
2717 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2718 (libmodest_dbus_client_open_message):
2719 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2721 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2722 body without crashing.
2724 * tests/dbus_api/Makefile.am:
2725 * tests/dbus_api/test_mail_to.c:
2726 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2728 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2730 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2731 Added file to fix the build. Sorry.
2733 * src/dbus_api/Makefile.am:
2734 * src/dbus_api/modest-dbus-api.h:
2735 * src/dbus_api/modest-dbus-callbacks.h:
2736 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2737 (modest_dbus_req_handler):
2738 Put constants in a separate header so it can be reused by the
2739 client library, without duplication
2741 * libmodest-dbus-client/Makefile.am:
2742 * libmodest-dbus-client/libmodest-dbus-client.c:
2743 (libmodest_dbus_client_call_helloworld),
2744 (libmodfest_dbus_client_send_mail),
2745 (libmodfest_dbus_client_mailto),
2746 (libmodfest_dbus_client_open_message):
2747 * libmodest-dbus-client/libmodest-dbus-client.h:
2748 (Partly) Implement a send_mail D-Bus method.
2750 * tests/dbus_api/Makefile.am:
2751 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2752 the send_email D-Bus method.
2754 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2758 * libmodest-dbus-client/Makefile.am:
2759 * libmodest-dbus-client/libmodest-dbus-client.c:
2760 * libmodest-dbus-client/libmodest-dbus-client.h:
2761 * tests/dbus_api/Makefile.am:
2762 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2763 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2765 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/easysetup/modest-easysetup-wizard.c:
2768 (create_page_account_details):
2769 * src/maemo/modest-account-settings-dialog.c:
2770 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2771 widgets, because this might not be the default in future versions of the Maemo GTK+.
2772 However, I can not not get capitalization to work even in a simple test case.
2774 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2776 * src/maemo/easysetup/modest-easysetup-wizard.c:
2777 (create_page_custom_incoming), (create_page_custom_outgoing):
2778 * src/maemo/modest-account-settings-dialog.c:
2779 (create_page_account_details), (create_page_incoming),
2780 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2781 instead of using gtk_check_button_with_label(), so they are aligned like the other
2782 widgets, as per the UI spec.
2784 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/easysetup/modest-easysetup-wizard.c:
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 * src/widgets/modest-validating-entry.c:
2789 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2790 Modest prefix instead of an EasySetup prefix.
2792 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2794 * src/widgets/modest-validating-entry.h:
2795 * src/widgets/modest-validating-entry.c: (on_insert_text),
2796 Added easysetup_validating_entry_set_max_func(), used to set a callback
2797 to call when the max number of characters is reached. GtkEntry has a max-length
2798 already but is silent about it.
2800 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2801 (create_page_account_details), (create_page_user_details),
2803 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2804 (create_page_account_details), (create_page_user_details),
2805 (create_page_outgoing):
2806 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2807 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2808 the UI spec, when the user tries to enter more than the max number of characters.
2810 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/easysetup/modest-easysetup-wizard.c:
2813 (create_page_user_details), (create_page_custom_incoming),
2814 (create_page_custom_outgoing):
2815 * src/maemo/modest-account-settings-dialog.c:
2816 (create_page_user_details), (create_page_incoming),
2817 (create_page_outgoing):
2818 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2819 (modest_connection_specific_smtp_edit_window_init):
2820 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2821 not appropriate. Bad Maemo-specific defaults!.
2823 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2825 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2826 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2827 (modest_signature_editor_dialog_set_settings):
2828 Disable the label and textview when the checkbox is disabled, and use the
2829 specified (UI spec) default signature text.
2831 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2833 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2834 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2836 * src/modest-defs.h:
2837 * src/modest-account-mgr-helpers.h:
2838 * src/modest-account-mgr-helpers.c:
2839 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2841 * src/maemo/Makefile.am:
2842 * src/maemo/modest-signature-editor-dialog.c:
2843 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2846 * src/maemo/modest-account-settings-dialog.h:
2847 * src/maemo/modest-account-settings-dialog.c:
2848 (modest_account_settings_dialog_finalize), (on_button_signature),
2849 (save_configuration): Use the new dialog when the Edit button is pressed, and
2850 save the changes if necessary, as per the UI spec.
2852 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/Makefile.am:
2855 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2856 based on maemo-develoers email from Dirk.
2858 * src/maemo/easysetup/modest-easysetup-wizard.c:
2859 (create_page_welcome), (create_page_account_details),
2860 (create_page_user_details), (create_page_complete_easysetup),
2861 (create_page_custom_incoming), (create_page_custom_outgoing),
2862 (create_page_complete_custom),
2863 (modest_easysetup_wizard_dialog_init):
2864 * src/maemo/modest-account-settings-dialog.c:
2865 (create_page_account_details), (create_page_user_details),
2866 (create_page_incoming), (create_page_outgoing),
2867 (modest_account_settings_dialog_init):
2868 * src/maemo/modest-connection-specific-smtp-window.c:
2869 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2871 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/easysetup/modest-easysetup-wizard.c:
2874 (create_page_account_details), (create_page_custom_outgoing),
2875 (create_page_complete_custom):
2876 * src/maemo/modest-account-settings-dialog.c:
2877 (create_page_user_details), (create_page_incoming),
2878 (create_page_outgoing):
2879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2880 (modest_connection_specific_smtp_edit_window_init):
2881 Use the correct (UI spec) port min/max, and use horizontal separators,
2884 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2886 * src/maemo/easysetup/modest-easysetup-wizard.c:
2887 (set_default_custom_servernames):
2888 * src/maemo/modest-account-settings-dialog.c:
2889 (create_page_incoming), (on_combo_outgoing_security_changed),
2890 (on_combo_incoming_security_changed), (create_page_outgoing),
2891 (modest_account_settings_dialog_set_account_name),
2892 (save_configuration):
2893 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2894 (on_combo_security_changed),
2895 (modest_connection_specific_smtp_edit_window_init),
2896 (modest_connection_specific_smtp_edit_window_set_connection),
2897 (modest_connection_specific_smtp_edit_window_get_settings):
2898 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2901 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2904 * src/maemo/easysetup/modest-easysetup-wizard.c:
2905 (create_page_custom_outgoing), (create_page_complete_custom):
2906 * src/maemo/modest-account-settings-dialog.c:
2907 (create_page_user_details), (create_page_outgoing):
2908 * src/maemo/modest-account-view-window.c: (button_box_new):
2909 Use changed logical IDs as per the most recent UI spec:
2910 mcen_bd_emailsetup_edit -> mcen_bd_edit
2911 mcen_bd_emailsetup_delete -> mcen_bd_delete
2912 mcen_bd_emailsetup_close -> mcen_bd_close
2914 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2918 * src/dbus_api/Makefile.am:
2919 * src/dbus_api/modest-dbus-callbacks.c:
2920 * src/dbus_api/modest-dbus-callbacks.h:
2921 * src/maemo/modest-platform.c: (modest_platform_init):
2922 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2924 * tests/Makefile.am:
2925 * tests/dbus_api/Makefile.am:
2926 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2928 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2930 * src/maemo/modest-account-settings-dialog.c:
2931 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2932 Removed unnecessary includes.
2934 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/easysetup/modest-easysetup-wizard.c:
2937 * src/maemo/modest-account-settings-dialog.c:
2938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2939 * src/widgets/Makefile.am:
2940 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2941 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2942 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2943 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2944 * src/widgets/modest-secureauth-combo-box.c:
2945 * src/widgets/modest-secureauth-combo-box.h:
2946 * src/widgets/modest-serversecurity-combo-box.c:
2947 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2948 made the GObject names more consistent with the rest of the Modest code.
2950 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/easysetup/Makefile.am:
2953 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2954 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2955 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2956 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2957 * src/maemo/easysetup/modest-easysetup-wizard.c:
2958 * src/maemo/easysetup/modest-validating-entry.c:
2959 * src/maemo/easysetup/modest-validating-entry.h:
2960 * src/maemo/modest-account-settings-dialog.c:
2961 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2962 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2963 widgets/ because they are used outside of easysetup too. After checking in,
2964 svn will allow me to rename them too.
2966 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2968 * src/gnome/modest-msg-edit-window.c:
2969 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2970 linker error, to fix the build on the GNOME platform.
2971 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2972 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2973 ifdefed out to avoid a warning.
2975 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2977 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2978 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2979 some alternative for GTK+ 2.6.
2981 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2985 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2986 specified for EmailAccountsDialog in UI spec.
2988 * src/maemo/easysetup/modest-easysetup-wizard.c:
2989 * src/maemo/easysetup/modest-easysetup-wizard.h:
2990 * src/maemo/modest-account-settings-dialog.c:
2991 * src/maemo/modest-account-settings-dialog.h:
2992 Reuse a member window widget for the connection-specific SMTP server accounts,
2993 so we can tell it to create/save the accounts only if we actually save changes.
2995 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2996 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2997 (modest_connection_specific_smtp_edit_window_get_settings):
2998 Return a struct instance for temporarily remembering the entered data.
3000 * src/maemo/modest-connection-specific-smtp-window.h:
3001 * src/maemo/modest-connection-specific-smtp-window.c:
3002 (modest_connection_specific_smtp_window_finalize),
3003 (modest_connection_specific_smtp_window_fill_with_connections),
3005 (modest_connection_specific_smtp_window_save_server_accounts),
3006 (update_model_server_names): Do not actually save data until asked,
3007 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3009 (on_selection_changed),
3010 (modest_connection_specific_smtp_window_init): Disable the edit
3011 button when nothing is selected.
3013 * src/modest-account-mgr-helpers.c:
3014 * src/modest-account-mgr-helpers.h:
3015 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3018 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3020 * src/modest-account-mgr-helpers.h:
3021 * src/modest-account-mgr-helpers.c:
3022 (modest_account_mgr_get_unused_account_name),
3023 (modest_account_mgr_get_unused_account_display_name): Added these
3024 utility functions, to avoid code duplication.
3026 * src/maemo/easysetup/modest-easysetup-wizard.c:
3027 (create_page_account_details), (create_account):
3028 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3029 (on_combo_security_changed),
3030 (modest_connection_specific_smtp_edit_window_init),
3031 (modest_connection_specific_smtp_edit_window_save_settings):
3032 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3033 * src/maemo/modest-connection-specific-smtp-window.c:
3034 (modest_connection_specific_smtp_window_finalize),
3035 (modest_connection_specific_smtp_window_fill_with_connections),
3036 (on_button_edit), (modest_connection_specific_smtp_window_init):
3037 * src/maemo/modest-connection-specific-smtp-window.h:
3038 Implementing saving of connection-specific server accounts.
3040 But I need to refactor this so we can save the data for each
3041 possible connection-specific account and only actually create the server accounts
3042 when the easysetup finished, or the OK button is pressed on the account settings
3045 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3047 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3048 (on_combo_security_changed):
3049 (modest_connection_specific_smtp_edit_window_init):
3050 Auto-fill the port number as in the account settings.
3052 (modest_connection_specific_smtp_edit_window_set_connection):
3053 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3054 * src/maemo/modest-connection-specific-smtp-window.c:
3055 (fill_with_connections), (on_button_edit),
3056 (modest_connection_specific_smtp_window_init):
3057 Turn the edit window into a dialog to simplify the code, and
3058 set a WM hint as in a GtkDialog, because only a popup can be on top of
3059 another window in Maemo, and popups usually have no WM decoration.
3061 * src/modest-defs.h:
3062 * src/modest-account-mgr-helpers.c:
3063 (modest_account_mgr_set_connection_specific_smtp),
3064 (modest_account_mgr_remove_connection_specific_smtp),
3065 (modest_account_mgr_get_connection_specific_smtp):
3066 * src/modest-account-mgr-helpers.h: Some functions to write the
3067 connection-specific SMTP server information. Not yet used.
3070 * src/widgets/modest-folder-view.c: (text_cell_data):
3071 Fix a warning about an uninitialized variable.
3072 (on_configuration_key_changed): Put an #ifdef around the use
3073 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3075 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/modest-account-settings-dialog.h:
3078 * src/maemo/modest-account-settings-dialog.c:
3079 Added connect_for_modified() utility function to mark the new modified boolean.
3081 (create_page_account_details), (create_page_user_details),
3082 (create_page_incoming), (create_page_outgoing), (on_response),
3083 (modest_account_settings_dialog_init),
3084 (modest_account_settings_dialog_set_account_name):
3085 Only warn about unsaved changes when there are actually unsaved changes.
3087 * src/modest-account-mgr-helpers.c:
3088 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3089 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3090 to get the data from there in future.
3092 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3094 * src/modest-defs.h:
3096 * src/modest-account-mgr-helpers.h:
3097 * src/modest-account-mgr-helpers.c:
3098 Store the security account setting in a single conf key instead of using
3099 the options list, so that the list is left for just the to-be-removed camel hack,
3100 and because gconf_client_set_list() is failing for some reason.
3102 * src/modest-account-mgr.c:
3103 (modest_account_mgr_add_server_account):
3104 * src/maemo/modest-account-settings-dialog.c:
3105 (modest_account_settings_dialog_set_account_name),
3106 (save_configuration): Use the renamed functions.
3109 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3111 * src/widgets/Makefile.am:
3112 * src/widgets/modest-limit-retrieve-combo-box.c:
3113 * src/widgets/modest-limit-retrieve-combo-box.h:
3114 * src/widgets/modest-retrieve-combo-box.c:
3115 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3116 the account settings dialog.
3118 * src/modest-defs.h:
3119 * src/modest-account-mgr-helpers.h:
3120 * src/modest-account-mgr-helpers.c:
3121 (modest_server_account_get_option_secure_auth),
3122 (modest_server_account_set_option_secure_auth):
3123 * src/modest-account-mgr.c:
3124 (modest_account_mgr_add_server_account):
3125 Use the existing AUTH_MECH conf key for the secure-auth setting,
3126 instead of putting it in the list options, because this was actually used already.
3128 * src/maemo/modest-account-settings-dialog.c:
3129 (create_page_account_details),
3130 (modest_account_settings_dialog_set_account_name),
3131 (save_configuration):
3132 * src/maemo/modest-account-settings-dialog.h:
3133 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3134 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3136 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3139 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3140 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3142 * src/modest-defs.h:
3143 * src/maemo/modest-account-settings-dialog.c:
3144 (create_page_incoming), (on_combo_outgoing_security_changed),
3145 (on_combo_incoming_security_changed), (create_page_outgoing),
3146 (modest_account_settings_dialog_set_account_name),
3147 (save_configuration): Load/Save the port number, and change it when the
3148 security combo changes, to suitable defaults.
3150 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3152 * src/modest-account-mgr.c:
3153 (modest_account_mgr_add_server_account): Set the security and secure-auth
3154 options, and add a comment saying that the other camel-specific options should be
3157 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3159 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3161 * src/modest-tny-account-store.c: (account_list_free),
3162 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3163 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3166 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3168 * src/modest-protocol-info.c:
3169 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3170 is required by our UI spec. Maybe something in our implementation will use this eventually.
3171 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3172 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3173 instead of the previous 0 placeholder.
3175 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3176 secure-auth settings.
3177 * src/modest-account-mgr-helpers.h:
3178 * src/modest-account-mgr-helpers.c:
3179 (modest_server_account_data_get_option_secure_auth),
3180 (modest_server_account_set_option_secure_auth),
3181 (modest_server_account_data_get_option_security),
3182 (modest_server_account_set_option_security): Added this API for getting and setting the security
3183 and secure-auth settings.
3185 * src/maemo/modest-account-settings-dialog.h:
3186 * src/maemo/modest-account-settings-dialog.c:
3187 (modest_account_settings_dialog_finalize), (check_data),
3188 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3189 about changing titles.
3190 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3191 (save_configuration): Save the security and secure-auth settings.
3193 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3194 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3196 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3198 * src/modest-defs.h:
3199 * src/modest-account-mgr.c:
3200 (modest_account_mgr_add_server_account):
3201 Added and used defines for the options key and value pair strings,
3202 that are used so far, though they do not seem to correspond to anything in our
3203 UI specs or ModestProtocol enum.
3205 * src/modest-account-mgr-helpers.h:
3206 * src/modest-account-mgr-helpers.c:
3207 (compare_option_strings_for_name),
3208 (modest_server_account_data_get_option_value),
3209 (modest_server_account_data_get_option_bool),
3210 (modest_account_mgr_get_server_account_option):
3211 Added helper functions for parsing the options GSList.
3213 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3215 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3216 display name is based on the supplied account name.
3217 * src/modest-account-mgr.c:
3218 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3219 with an inefficient, but good-enough, implementation.
3221 * src/maemo/easysetup/modest-easysetup-wizard.c:
3222 (create_page_account_details), (on_before_next), (create_account):
3223 Check for existing display names rather than (non-user-visible) account names, and just
3224 create and set a unique account name at the end.
3226 * src/maemo/modest-account-settings-dialog.c:
3227 (modest_account_settings_dialog_init),
3228 (modest_account_settings_dialog_set_account_name),
3229 (create_page_incoming): Show the display name, instead of the account name.
3230 (on_response): Do some (not all) extra checks, as in the UI spec.
3231 (save_configuration): Save the display name if it was changed.
3233 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3235 * po/en_GB.po: Added needed logical ID and translation.
3236 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3237 (init_view): Made the is-default column clicking work.
3239 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/easysetup/Makefile.am:
3243 * src/maemo/easysetup/modest-easysetup-wizard.c:
3244 (modest_easysetup_wizard_dialog_init):
3245 * src/maemo/easysetup/provider-data-test.keyfile:
3246 * src/maemo/easysetup/provider-data.keyfile:
3247 Moved the provider data file to the new modest-providers-data package and used it from there.
3249 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3251 * src/modest-local-folder-info.c:
3252 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3253 N_() was already used on the static strings, but this just marks it for translation without
3254 using the translation.
3256 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/modest-account-settings-dialog.c:
3259 (create_page_incoming),
3260 (modest_account_settings_dialog_set_account_name):
3261 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3262 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3263 I will do this if nobody else gets there first.
3265 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3267 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3268 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3269 save the security stuff.
3271 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3273 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3274 Set the email address and user fullname, which I now see must be
3277 * src/maemo/modest-account-settings-dialog.h:
3278 * src/maemo/modest-account-settings-dialog.c:
3280 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3281 leave-on-server and authentication.
3282 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3285 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3288 * src/maemo/modest-account-settings-dialog.c:
3289 * src/maemo/modest-account-settings-dialog.h:
3290 Most (but not all) of the widgets are now present as specified by the UI spec.
3291 No changes are yet saved, and some details are not properly shown yet.
3293 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3295 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3297 * src/maemo/Makefile.am:
3298 * src/maemo/modest-account-settings-dialog.c:
3299 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3300 an existing account. Doesn't do much yet.
3302 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3303 Open the accounts settings dialog when Edit is clicked.
3305 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/easysetup/Makefile.am:
3308 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3310 * src/maemo/easysetup/modest-easysetup-wizard.c:
3311 (modest_easysetup_wizard_dialog_init):
3312 Try to get the source directory from the build system,
3313 instead of hard-coding "./" into the source code, when opening our local
3314 copies of the configuration files.
3315 But this still fails when opening the wizard from the Accounts window,
3316 maybe because the working directory seems to change at runtime.
3317 So the wizard will fail the second time unless you copy the files into their
3318 proper locations - see the stdout warnings for the paths.
3320 (create_page_account_details),(on_before_next):
3321 Check for existing non-server accounts instead of server accounts,
3322 so the default account name is useful again, and to prevent trying to
3325 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3326 Show the wizard when New is clicked.
3328 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3329 (init_view): Show the column headers, and show the columns that are
3330 specified in the UI specs. However, something in Maemo's GTK+ prevents
3331 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3332 change the default account. This is despite unsetting the special properties.
3334 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3336 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3337 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3338 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3339 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3340 to make that clearer.
3341 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3343 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3345 * src/maemo/modest-account-view-window.c:
3346 (modest_account_view_window_init),
3347 (modest_account_view_window_new):
3348 Use the same buttons as specified in the
3349 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3350 the existing widgets, which never had a chance of working.
3351 Put the ModestAccountView treeview in a scrolled window.
3352 Do not repeat the initialization in both _init() and _new().
3354 * src/widgets/modest-account-view.c: (update_account_view):
3355 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3356 this widget and window shows no accounts.
3358 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3360 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3362 * src/maemo/easysetup/modest-easysetup-wizard.c:
3363 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3364 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3365 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3368 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3369 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3370 accounts exist yet, as in the UI spec.
3372 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3374 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3376 * src/maemo/Makefile.am:
3377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3378 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3379 New window for editing connection-specific smtp details.
3380 Not fully implemented.
3382 * src/maemo/modest-connection-specific-smtp-window.c:
3383 (modest_connection_specific_smtp_window_finalize) :
3384 unref the tree model.
3385 (on_button_edit): Show the edit window.
3387 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3389 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3392 * src/maemo/Makefile.am:
3393 * src/maemo/modest-connection-specific-smtp-window.c:
3394 * src/maemo/modest-connection-specific-smtp-window.h:
3395 New window for showing the list of connections, for connection-specific
3396 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3397 * src/maemo/easysetup/modest-easysetup-wizard.c:
3398 (create_page_custom_outgoing): Show the new window when the button is clicked.
3400 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3402 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3403 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3404 * src/maemo/modest-msg-edit-window.c:
3405 (modest_msg_edit_window_insert_image):
3406 * src/modest-conf.c: (modest_conf_key_escape):
3407 * src/modest-mail-operation.c:
3408 (modest_mail_operation_send_new_mail):
3409 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3410 (modest_ui_actions_on_new_account):
3411 * src/widgets/modest-attachment-view.c: (update_filename_request):
3412 * src/widgets/modest-mail-header-view.c:
3413 Corrected warnings that were breaking the build, by commenting out unused variables,
3414 and a function, and by including a header.
3416 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3418 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3419 so we can #ifdef around platform-specific code when necessary.
3420 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3421 to allow this to build for the GNOME platform too.
3423 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/easysetup/modest-easysetup-wizard.c:
3426 Added util_increment_name() and used it in create_page_account_details()
3427 to make sure that the default account name is always a new name.
3429 (modest_easysetup_wizard_dialog_init),
3430 (set_default_custom_servernames): Some minor memory management fixes.
3432 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3436 * src/modest-runtime.c: (init_i18n): Restored the translation
3437 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3438 are defined in config.h, and the translations are installed.
3440 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3441 is defined for translation.
3443 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3445 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3447 * src/maemo/easysetup/modest-easysetup-wizard.c:
3448 (modest_easysetup_wizard_dialog_init):
3449 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3450 Use realistic paths (though they should use $prefix generically) to the
3451 mcc_mapping and provider-data.keyfile files which might work when they
3452 are installed by the future version of the operator-wizard package,
3453 and then fallback to paths in our source code, with an explanatory
3456 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/Makefile.am:
3461 * src/maemo/easysetup/: Added files from the previously-exernal
3462 osso-modest-easysetup.
3463 * src/maemo/modest-main-window-ui.h:
3464 * src/modest-ui-actions.c:
3465 * src/modest-ui-actions.h:
3466 Added modest_ui_actions_on_new_account() as a signal handler for the
3467 New Account menu item. It shows the easysetup wizard.
3468 * po/en_GB.po: Added additional needed logical IDs and translations.