1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_password):
4 Added some checks for NULL to maybe prevent crashes, though I think
5 it was Philip's last commit that actually prevented the crash here
6 when creating a first new account.
7 But the new account is still not usable (no messages are shown)
8 until a restart of the application.
10 2007-06-26 Murray Cumming <murrayc@murrayc.com>
12 * src/maemo/modest-maemo-global-settings-dialog.c:
13 (idle_select_default_focus):
14 * src/modest-mail-operation.c: (idle_notify_progress),
15 (idle_notify_progress_once), (idle_notify_update_account_queue),
16 (set_last_updated_idle), (update_account_thread),
17 (notify_get_msgs_full), (get_msgs_full_destroyer),
18 (get_msgs_full_thread):
19 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
20 * src/widgets/modest-header-view.c:
21 (idle_notify_headers_count_changed_destroy),
22 (idle_notify_headers_count_changed):
23 Use gdk_threads_enter() and gdk_threads_enter_leave() in
24 all idle handlers, because some other thread could be blocking
25 the GDK lock, so that it can do GUI stuff.
27 2007-06-26 Murray Cumming <murrayc@murrayc.com>
29 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
30 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
31 (on_idle_send_receive), (on_idle_open_default_inbox):
32 * src/maemo/modest-msg-edit-window.c:
33 (modest_msg_edit_window_attach_file_noninteractive):
34 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
35 to prevent a hang. I don't quite understand why these are necessary,
36 beause we should already be in the main loop. I guess something outside
37 of the main loop is taking the lock.
39 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
40 we are really using URIs, and use files that are more likely to exist.
42 2007-06-26 Murray Cumming <murrayc@murrayc.com>
44 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
45 necessary because configure.ac now defines different variables.
47 2007-06-26 Murray Cumming <murrayc@murrayc.com>
49 * libmodest-dbus-client/libmodest-dbus-client.c:
50 * libmodest-dbus-client/libmodest-dbus-client.h:
51 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
52 libmodest_dbus_client_compose_mail() is what things actually use.
54 * src/dbus_api/modest-dbus-api.h:
55 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
56 * tests/dbus_api/Makefile.am:
57 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
60 2007-06-26 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-init.c: (modest_init_local_folders):
63 For memory-card (or other non local-folders) maildir accounts,
64 always create an Archive folder, so that there is somewhere to put
65 messages. This should be less confusing, because the user does not need
66 to guess that the need to create a folder.
68 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
70 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
71 Fixed icon size by using (50, 50) which is the same as defined by
74 2007-06-25 Armin Burgmeier <armin@openismus.com>
76 * src/widgets/modest-window-mgr.c:
78 * configure.ac: Correctly recognize hildon-notify presence and fixed
79 the build without it being installed.
81 2007-06-25 Murray Cumming <murrayc@murrayc.com>
83 * libmodest-dbus-client/libmodest-dbus-client.c:
84 (libmodest_dbus_client_search): Fix the build. Sorry.
85 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
86 (reply_forward_cb): Initialize variables to fix the build.
88 * src/modest-tny-account-store.c:
89 (modest_tny_account_store_get_tny_account_by): Fix the account URI
90 comparison (a silly typo) so that email search results can be opened
91 when there are more than one account.
93 2007-06-25 Murray Cumming <murrayc@murrayc.com>
95 * libmodest-dbus-client/libmodest-dbus-client.c:
96 (libmodest_dbus_client_search),
97 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
98 instead of 1 second, because the search gets folders and messages from
99 the server, which can take a long time. When it times out,
100 osso-global-search will report no results.
102 We need to specify whether we should search only cached information
103 (maybe with a user preference), and the osso-email-search-plugin
104 API should really be improved to allow that option, and to allow results
105 to be delivered asynchronously in batches.
107 2007-06-25 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
110 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
111 GTK_ICON_SIZE_DIALOG is probably the wrong size.
113 2007-06-25 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
116 that is an empty string. D-Bus seems to give us these instead of NULL.
118 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
120 * src/dbus_api/modest-dbus-callbacks.c:
121 * src/maemo/easysetup/modest-easysetup-wizard.h:
122 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
124 (modest_connection_specific_smtp_edit_window_init):
125 * src/maemo/modest-maemo-global-settings-dialog.c:
127 * src/maemo/modest-maemo-utils.c:
128 (modest_maemo_utils_setup_images_filechooser):
129 * src/maemo/modest-main-window.c: (create_details_widget):
130 * src/maemo/modest-msg-edit-window.c:
131 (modest_msg_edit_window_attach_file_noninteractive),
132 (modest_msg_edit_window_color_button_change),
133 (modest_msg_edit_window_set_zoom):
134 * src/modest-mail-operation.c: (update_account_thread):
135 * src/modest-tny-account-store.c:
136 * src/modest-tny-account.c:
137 * src/widgets/modest-global-settings-dialog.c:
138 * src/widgets/modest-window.h:
142 2007-06-25 Murray Cumming <murrayc@murrayc.com>
144 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
145 * src/modest-search.c: (modest_search_folder),
146 (modest_search_all_accounts): Actually search only in the specified folder,
147 doing a simple match on the folder ID.
148 * src/modest-search.h: Added a folder field to the ModestSearch struct,
149 and added some documentation.
151 2007-06-22 Armin Burgmeier <armin@openismus.com>
153 * src/maemo/modest-maemo-utils.h:
154 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
155 modest_maemo_utils_get_supported_secure_authentication_methods.
157 * src/maemo/easysetup/modest-easysetup-wizard.c:
158 * src/maemo/modest-account-settings-dialog.c: Show correct error if
159 one occured, not just "Server does not support secure authentication".
161 2007-06-22 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-tny-account-store.c: (get_password):
164 Restored the call to tny_account_set_user() because Philip seems to have
165 stopped this from crashing (by not using the freed string). It still does
166 not work, but now we can test it.
168 2007-06-22 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/modest-msg-edit-window.c: (init_window):
171 Comment out use of an uninitialzed GtkScrolledWindow variable,
172 to fix the build and stop a crash. Yet again.
174 2007-06-22 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-tny-account-store.c: (get_password):
177 Remove the call to tny_account_set_user() because this actually crashes.
178 As mentioned in the last commit, it is known to not work anyway.
180 2007-06-22 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account-store.c: (get_password):
183 Use tny_account_set_username() to tell tinymail that the username might
184 have changed too. But tinymail ignores this: see projects.maemo.org
186 * src/modest-ui-actions.c:
187 (modest_ui_actions_on_password_requested): Remove the useless attempt to
188 reset the connection when changing the username, and improve the comments.
189 Save the changed username to gconf at least, so it is used when Modest is
192 2007-06-21 Murray Cumming <murrayc@murrayc.com>
194 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
195 Do not use a query, so that we get all folders, including for POP and
196 local-folders. They work as search criteria too.
197 This fixes projects.maemo.org bug NB#57740.
199 2007-06-21 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
202 Comment out the use of hildon_notification_set_sound() because it is
203 not declared, to fix the build. Warnings are serious, people.
205 2007-06-21 Armin Burgmeier <armin@openismus.com>
207 * src/maemo/modest-maemo-utils.h:
208 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
209 modest_maemo_utils_get_supported_secure_authentication_methods()
210 to query authentication methods for a specific user. This should fix
211 projects.maemo.org bug NB#61369.
213 * src/maemo/easysetup/modest-easysetup-wizard.c:
214 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
217 2007-06-21 Murray Cumming <murrayc@murrayc.com>
219 * libmodest-dbus-client/libmodest-dbus-client.h:
220 * libmodest-dbus-client/libmodest-dbus-client.c:
221 (modest_dbus_message_iter_get_search_hit),
222 (libmodest_dbus_client_search):
223 Reorganised and commented this.
224 Removed modest_search_hit_free() from the public API because it
227 Added libmodest_dbus_client_get_folders() and
228 modest_folder_result_list_free().
230 * src/dbus_api/modest-dbus-api.h:
231 * src/dbus_api/modest-dbus-callbacks.c:
232 (modest_dbus_req_filter): Commented. Moved most code to
233 on_dbus_method_search() and added on_dbus_method_get_folders().
235 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
236 of the extra D-Bus handler.
238 * tests/dbus_api/Makefile.am:
239 * tests/dbus_api/test_get_folders.c: New test for
240 libmodest_dbus_client_get_folders(). This seems to return an empty list
241 at the moment. That could be the same error that causes the message list
242 to be empty sometimes.
243 This should help with projects.maemo.org bug NB#57740.
245 2007-06-21 Armin Burgmeier <armin@openismus.com>
247 * src/modest-mail-operation.c: Do not call
248 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
249 notify the operation's end after having set the status to CANCELED for
250 the operation queue to listen on. This fixes a deadlock when there
251 were mail operations in the queue during its finalization.
253 * src/modest-singletons.c: Reordered uninitialization of the account
254 manager to happen after the mail operation queue was uninitialized
255 because the mail operation's in the queue might still try to access
256 the account manager (see modest_mail_operation_notify_end()). This
257 fixes a potential crash when terminating the application.
259 2007-06-21 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-search.c:
262 (search_mime_part_and_child_parts): Moved some code here so we
263 can search recursively in child folders.
264 (modest_search_folder): Search in the message as a mime part, instead
265 of just its child mime parts.
266 (read_chunk), (search_mime_part_ogs):
267 Check how many bytes were read, to prevent an endless loop.
268 Searching in message bodies now works. This finishes the fix for
269 projects.maemo.org bug NB#61007.
271 2007-06-20 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
274 Add a g_warning when the item is not a folder.
276 * src/modest-ui-dimming-rules.c:
277 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
278 when selected item is not a folder (for instance, an account), because
279 the UI spec only talks about folders.
280 I am not sure what the UI spec wants, so this might not totally fix
281 projects.maemo.org bug NB#60794.
283 2007-06-20 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
286 (load_from_file): Sort the list. The unsorted list would be more noticeable
287 in non-English locales.
289 * src/maemo/modest-msg-edit-window.c:
290 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
291 warning and fix the build.
293 * src/maemo/modest-progress-bar-widget.c:
294 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
295 avoid a g_warning, and probably to avoid a crash.
297 2007-06-20 Murray Cumming <murrayc@murrayc.com>
299 * src/modest-search.c: (modest_search_folder): Check for a GError
300 when calling tny_folder_get_headers(), to show that this is not the cause
303 2007-06-20 Murray Cumming <murrayc@murrayc.com>
305 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
306 Actually set the body query instead of the subject query.
308 * src/modest-search.c: (search_mime_part_ogs),
309 (search_mime_part_strcmp): Remove extra space from the text/* regex,
310 which would probably cause it to fail if we got this far.
312 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
313 to simplify the code.
314 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
315 be causing search-in-body to fail.
317 2007-06-20 Murray Cumming <murrayc@murrayc.com>
319 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
321 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
322 Better debug message when the folder cannot be found.
323 This should help with fixing projects.maemo.org bug #61287.
324 * src/modest-search.c: (add_hit): Do not leak the furl string.
326 2007-06-20 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-ui-actions.c:
329 (modest_ui_actions_on_folder_selection_changed):
330 Do not special-case TNY_MERGE_FOLDER here, because
331 modest_tny_folder_get_account() already does that. This fixes
332 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
333 shown when the Outbox was selected).
335 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
337 * libmodest-dbus-client/libmodest-dbus-client.c:
338 (_dbus_iter_get_string_or_null): Initialize the string variable in
339 case this helps with Dirk's crash.
341 2007-06-19 Murray Cumming <murrayc@murrayc.com>
343 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
344 though it is not implemented yet (this function is maybe not even used),
345 to avoid breaking ABI in future.
346 * libmodest-dbus-client/libmodest-dbus-client.c:
347 (get_attachments_string): Moved some code into this generic function.
348 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
349 sends email. It is maybe not used.
350 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
351 (on_send_mail): Use attachments.
353 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
354 * src/maemo/modest-msg-edit-window.c:
355 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
356 a filename before using it, to fix projects.maemo.org bug NB#58233.
358 2007-06-19 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
361 Initialize the continue_download variable to fix the build, and probably
362 to fix randome behaviour.
364 2007-06-18 Armin Burgmeier <armin@openismus.com>
366 * src/modest-tny-send-queue.h:
367 * src/modest-tny-send-queue.c: Keep track of the status of messages in
368 the queue so we can later show it in the UI. Replaced
369 modest_tny_send_queue_msg_is_being_sent() by
370 modest_tny_send_queue_get_msg_status().
372 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
374 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
375 gpointer. This probably was not harmful, but just to be sure.
377 2007-06-18 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
380 Fix the build, but leave the function broken on Bora, because
381 hildon_uri_action_get_service() does not exist.
382 osso_uri_action_get_service() does not exist either, it seems.
384 2007-06-18 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-tny-account.c:
387 (modest_tny_account_new_from_server_account):
388 Uncommented the url debug output again, because it is useful for
389 debugging, as I said in the comment.
391 2007-06-18 Murray Cumming <murrayc@murrayc.com>
393 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
395 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
396 for Mameo Bora, to fix the build.
398 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
401 Fixed build with hildon < 0.99
403 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
404 Check if the selected account is busy instead of checking all accounts
406 * src/modest-account-mgr-priv.h:
407 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
408 (modest_account_mgr_init), (compare_account_name),
409 (modest_account_mgr_set_account_busy),
410 (modest_account_mgr_account_is_busy):
411 * src/modest-account-mgr.h:
412 Added busy information to the account manager. It possible to
413 set an account to busy or not busy now.
415 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
416 (modest_mail_operation_update_account),
417 (modest_mail_operation_notify_end):
418 Set the account to busy/not busy depending on the operation state.
420 * src/widgets/modest-account-view.c:
421 (modest_account_view_finalize), (get_last_updated_string),
422 (update_account_view), (on_account_busy_changed), (init_view):
423 Show string "Refreshing..." if the account is currently busy.
425 All this fixes projects.maemo.org bug NB#59711
427 2007-06-14 Armin Burgmeier <armin@openismus.com>
429 * src/widgets/modest-attachments-view.h:
430 * src/widgets/modest-attachments-view.c: Added
431 modest_attachments_view_has_attachments() and fixed coordinate
432 transformation in get_att_view_at_coords(). This fixes attachment
435 * src/widgets/modest-msg-view.c: Make use of
436 modest_attachments_view_has_attachments() to decide whether to show
437 attachments in the header.
439 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
441 * src/maemo/modest-connection-specific-smtp-edit-window.c:
442 (on_change), (on_combo_security_changed),
443 (modest_connection_specific_smtp_edit_window_init),
444 (modest_connection_specific_smtp_edit_window_set_connection),
445 (modest_connection_specific_smtp_edit_window_is_dirty):
446 * src/maemo/modest-connection-specific-smtp-edit-window.h:
447 * src/maemo/modest-connection-specific-smtp-window.c:
450 Show an comfirmation dialog for the smpt-edit-window if there are
451 unsaved changes and the user hits cancel.
452 (projects.maemo.org bug NB#60479)
454 2007-06-14 Armin Burgmeier <armin@openismus.com>
456 * src/maemo/easysetup/modest-easysetup-wizard.c:
457 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
458 address" info in banner instead of node, and select all the text as
459 per UI spec. This fixes projects.maemo.org bug NB#60550.
461 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
463 reviewed by: <delete if not using a buddy>
465 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
466 * src/modest-ui-actions.c: (folder_refreshed_cb):
468 2007-06-14 Murray Cumming <murrayc@murrayc.com>
470 * src/widgets/modest-folder-view.c: (filter_row):
471 Explictly filter out the per-account outbox accounts. I don't know why
472 these only sometimes show up, but now they should never show up in the UI.
473 This should fix projects.maemo.org bug NB#60160.
475 2007-06-14 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
478 when the toolbar does not exist yet.
479 * src/modest-widget-memory.c: (save_settings_header_view):
480 Added g_warnings() to help us to discover when we are trying to set
481 an empty columns list in gconf.
483 2007-06-14 Murray Cumming <murrayc@murrayc.com>
487 Added modest_init_get_default_header_view_column_ids().
489 * src/modest-widget-memory.c: (restore_settings_header_view):
490 Use the new function to get defaults, if the gconf key is empty,
491 instead of not creating any columns. This seems to fix the
492 empty right-hand pane problems.
494 * src/widgets/modest-header-view.h: Improved documentation.
496 2007-06-13 Murray Cumming <murrayc@murrayc.com>
498 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
499 Revert the use of the display name as the account name, because this
500 is generally wrong and would break the code that follows.
502 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
504 * src/maemo/easysetup/modest-easysetup-wizard.c:
505 (check_for_supported_auth_methods), (on_before_next),
508 More correct fix for projects.maemo.org bug NB# 58991
509 Do not longer accept AUTH_PASSWORD as secure method and choose
510 correct method when creating the account.
512 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
514 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
515 Fixed projects.maemo.org bug NB# 58991
517 2007-06-13 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-init.c: (modest_init_init_core),
520 (modest_init_local_folders): Fixed compilation errors.
522 2007-06-13 Murray Cumming <murrayc@murrayc.com>
524 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
525 Remove unnecessary lib/include, though it is good in principle when needed.
527 * src/modest-init.c: (modest_init_one_local_folder),
528 (modest_init_local_folders):
529 * src/modest-init.h: Initialize the .modest library for memory cards,
530 instead of just doing nothing for them. This should allow us to create
531 folders there, fixing projects.maemo.org bug NB#59297.
533 2007-06-13 Murray Cumming <murrayc@murrayc.com>
535 * libmodest-dbus-client/libmodest-dbus-client.c:
536 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
537 (libmodest_dbus_client_compose_mail),
538 (libmodest_dbus_client_open_message),
539 (libmodest_dbus_client_send_and_receive),
540 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
542 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
543 (on_idle_open_message), (modest_dbus_req_handler),
544 (search_result_to_message), (modest_dbus_req_filter):
545 * src/modest-search.c: (add_hit), (modest_search_folder),
546 (modest_search_all_accounts): Improved debug messages.
548 * tests/dbus_api/test_open_message.c: (main): Improved comments.
550 * src/modest-tny-account-store.c:
551 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
554 2007-06-13 Murray Cumming <murrayc@murrayc.com>
557 2007-06-12 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-tny-account-store.c: (get_server_accounts):
560 Call modest_tny_local_folders_account_add_merged_outbox_folders()
561 even when there are no accounts, so that the Outbox folder is always
562 visible. This fixes projects.maemo.org bug NB#60158.
564 2007-06-12 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-main-window.c: (create_details_widget):
567 Use the mcen_va_never logical ID.
569 2007-06-12 Murray Cumming <murrayc@murrayc.com>
571 * src/dbus_api/modest-dbus-api.h:
572 * src/dbus_api/modest-dbus-callbacks.c:
573 (on_idle_open_default_inbox), (on_open_default_inbox),
574 (modest_dbus_req_handler):
575 Added a new OpenDefaultInbox method.
577 * libmodest-dbus-client/libmodest-dbus-client.h:
578 * libmodest-dbus-client/libmodest-dbus-client.c:
579 Added libmodest_dbus_client_open_default_inbox() to call the new
580 dbus method. This should be useful to projects.maemo.org bug NB#57214,
581 though it should maybe be used by a new osso-email-interface function.
583 * tests/dbus_api/Makefile.am:
584 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
587 2007-06-12 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
590 NULL, so that the signals get all the keys. This should not actually
591 change any behaviour because we currently update everything when anything
594 2007-06-12 Murray Cumming <murrayc@murrayc.com>
596 * src/widgets/modest-folder-view.c: (text_cell_data),
597 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
598 (find_inbox_iter): If tinymail tells us that the folder is
599 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
600 This causes the inbox to be selected at startup, fixing part of
601 projects.maemo.org bug NB#56305.
603 * src/modest-ui-dimming-rules.c:
604 (modest_ui_dimming_rules_on_tools_smtp_servers):
605 * src/modest-ui-dimming-rules.h: Added a callback function to dim
606 the SMTP servers menu item.
607 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
608 that the SMTP Servers menu item is dimmed when there are no accounts,
609 as a future version of the UI spec will require. This fixes
610 projects.maemo.org bug NB#56305.
612 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
614 * src/maemo/modest-maemo-utils.c:
615 (modest_maemo_utils_get_supported_secure_authentication_methods):
616 Added label to dialog instead of unreadable title
618 * src/maemo/modest-main-window.c: (sync_accounts_cb),
619 (modest_main_window_new):
620 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
623 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
624 * src/modest-account-mgr.h:
625 Added method to avoid code duplication
627 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
628 (modest_ui_actions_on_send_receive):
629 Use modest_account_mgr_has_accounts
631 2007-06-11 Murray Cumming <murrayc@murrayc.com>
633 * src/maemo/easysetup/modest-presets.c:
634 (modest_presets_get_info_server_security): Do not report secure auth
636 * src/modest-protocol-info.c: Use the defines for the gconf key names
637 for secure authentication. This was not working because we were writing
638 Password and reading password, and the check was case sensitive.
639 With this, gmail now works for receiving and sending when created via
642 2007-06-11 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/easysetup/modest-presets.c:
645 (modest_presets_get_info_server_security): Correct the key name for
646 SecureSmtp, because it seems to be case-sensitive.
647 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
648 Do not try to get the 0th notebook page if there are 0 pages, to
651 2007-06-11 Murray Cumming <murrayc@murrayc.com>
653 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
654 Prevent use of the new notification feature for now, because it currently
655 shows one dialog for each new email, which is annoying.
657 2007-06-11 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
660 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
661 when no country was selected, so that we show the global ones.
662 * src/maemo/easysetup/modest-presets.c:
663 (modest_presets_get_providers): Return only the global providers, not
664 all providers when mmc=0 was requested.
666 2007-06-11 Murray Cumming <murrayc@murrayc.com>
668 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
669 (easysetup_provider_combo_box_fill): Remove debug code that showed the
670 provider ID in the combo.
672 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
673 Do not show the page numbers, because it would be confusing when we add
674 the 2 extra pages for the custom setup, when the user chooses the "Other"
675 provider. This fixes projects.maemo.org bug NB#59028
677 * src/modest-init.c: (modest_init_init_core),
678 (modest_init_local_folders):
680 * src/modest-tny-account.c:
681 (modest_tny_account_new_for_local_folders): Do not create default folders
682 for the memory card. This should fix projects.maemo.org bug NB#59328.
684 2007-06-11 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
687 Free the changed_conf_keys string items. They are already freed in the
688 idle handler if that runs first.
690 2007-06-11 Murray Cumming <murrayc@murrayc.com>
692 * src/modest-ui-actions.c:
693 (modest_ui_actions_on_password_requested): Check that the server name
694 is not NULL, because I just saw a password dialog with (null) as the
697 * src/modest-tny-folder.[h|c]: Added
698 modest_tny_folder_is_memory_card_folder().
699 * src/modest-ui-dimming-rules.c:
700 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
701 menu item for memory cards, as per the UI spec (section 7.4). This should
702 fix projects.maemo.org bug NB#59297.
704 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
706 * src/maemo/modest-main-window.c: (sync_accounts_cb):
707 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
708 is another problem with the code, see Murray's comment at line 772)
710 2007-06-08 Murray Cumming <murrayc@murrayc.com>
712 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
713 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
714 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
715 (load_from_file), (easysetup_country_combo_box_init),
716 (easysetup_country_combo_box_get_active_country_ids),
717 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
718 instead of just one ID, to avoid duplicate country names in the UI.
720 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
721 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
722 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
723 a single ID, avoiding duplicate providers.
724 * src/maemo/easysetup/modest-easysetup-wizard.c:
725 (on_combo_account_country): Adapt to use a list.
727 2007-06-08 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
730 keys changed in the last X seconds.
732 * src/modest-account-mgr.h:
733 * src/modest-account-mgr.c: (on_timeout_notify_changes),
734 (on_key_change), (modest_account_mgr_class_init),
735 (modest_account_mgr_init), (modest_account_mgr_finalize):
736 As the keys are changed, save them in a GSList* and signal that GSList*
737 further every X seconds, to batch changes, to allow us to do just one
738 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
739 bug NB#56941 and other (UI-blocking) delays when changing account settings.
741 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
742 changed signal signature.
744 * src/modest-conf.c: (modest_conf_set_list),
745 (modest_conf_on_change): Reenable notification.
747 (modest_conf_maemo_fake_on_change): Comment out the hack that
748 notified immediately instead of asynchronously.
750 * src/widgets/modest-account-view.h:
751 * src/widgets/modest-account-view.c:
752 (update_account_view): Select the previously-selected account ID,
753 if possible. This fixes projects.maemo.org bug NB#56933.
755 (on_account_changed), (on_account_removed),
756 (modest_account_view_select_account):
758 Remove the block/unblock functions
759 because they were not useful.
761 * src/maemo/modest-account-view-window.c:
762 (on_delete_button_clicked), (on_edit_button_clicked),
763 (on_new_button_clicked): Remove the use of the non-working block/unblock.
765 2007-06-08 Murray Cumming <murrayc@murrayc.com>
767 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
768 Improve the error dialog to show Incorrect Account Settings, which seems
769 clearer, and say that the internal error message (to be removed from the
770 dialog later) is often misleading.
771 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
773 * src/modest-tny-account.c:
774 (modest_tny_account_new_from_server_account): Uncomment the printf of the
775 URL because this is so useful for debugging on the device.
777 * src/widgets/modest-serversecurity-combo-box.c:
778 (modest_serversecurity_combo_box_fill): Correct a logical ID.
780 2007-06-08 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-mail-operation.c:
783 (modest_mail_operation_send_new_mail):
784 Added a comment about a nasty but apparently harmless message. Details
785 added to the wiki g_warnings() page.
787 2007-06-08 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
790 (modest_tny_send_queue_class_init):
791 Do not use the priv struct because it is empty, to avoid g_warnings
792 about a non-existant priv struct.
794 * src/modest-tny-account-store.c:
795 (modest_tny_account_store_get_server_account),
796 (modest_tny_account_store_get_transport_account_for_open_connection
797 ): Do not try to get transport server accounts for local folders,
798 because they don't have any. This avoids a g_warning().
800 * src/maemo/modest-main-window.c:
801 (modest_main_window_notify_send_receive_initied),
802 (on_configuration_key_changed):
803 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
805 * src/modest-mail-operation.c:
806 (modest_mail_operation_update_account):
807 * src/modest-tny-account-store.h:
808 * src/modest-tny-account.c:
809 (modest_tny_account_get_special_folder),
810 (modest_tny_account_new_for_local_folders),
811 (modest_tny_account_new_for_per_account_local_outbox_folder):
812 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
813 * src/modest-tny-local-folders-account.c:
814 (add_account_folders_to_merged_folder):
815 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
816 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
817 (modest_ui_actions_on_send):
818 * src/widgets/modest-folder-view.c: (update_model):
819 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
820 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
821 modest_tny_account_store_get_tny_account_by_account() to
822 modest_tny_account_store_get_server_account() to make the code clearer.
824 2007-06-07 Marcus Bauer <marcusb@openismus.com>
826 * src/dbus_api/modest-dbus-api.h:
827 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
828 * src/maemo/modest-msg-edit-window.c:
829 (modest_msg_edit_window_attach_file_noninteractive):
830 added g_warning in case the file to be attached does not exist
831 * tests/dbus_api/test_compose_mail.c: (main):
832 removed obsolete comment, added generic files as test case
834 2007-06-07 Murray Cumming <murrayc@murrayc.com>
836 * src/modest-tny-account-store.c: (get_server_accounts):
837 Create the local folders account only once, not once for each outbox, and
838 not only when there are some outboxes.
840 2007-06-07 Murray Cumming <murrayc@murrayc.com>
842 * src/widgets/modest-folder-view.c: (update_model): Comment out some
843 code that is causing a crash at startup. Sergio says that he is fixing this.
845 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
847 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
848 * src/maemo/modest-account-settings-dialog.c:
849 (create_page_outgoing),
850 (modest_account_settings_dialog_set_account_name),
851 (save_configuration):
852 - Fixed handling of the "Use secure authentication" toggle to comply with
853 the ui specification. See also projects.maemo.org bug NB#58400
855 - Restore the Secure connection setting combo correctly when loading
858 * src/maemo/modest-maemo-utils.c:
859 (on_camel_account_get_supported_secure_authentication),
860 (modest_maemo_utils_get_supported_secure_authentication_methods):
861 Fixed a crasher if operation is canceled
863 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
864 (modest_protocol_info_auth_is_secure):
865 * src/modest-protocol-info.h:
867 Added two new methods to determine if a protocol/auth method is secure/encrypted in
868 the sense of the "Use secure authentication" toggle.
870 2007-06-07 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-tny-account-store.h:
873 * src/modest-tny-account-store.c:
874 Added modest_tny_account_store_get_local_folders_account().
876 * src/modest-tny-folder.h:
877 * src/modest-tny-folder.c:
878 (modest_tny_folder_get_account):
879 Added this replacement for tny_folder_get_account() which returns
880 the local-folders account for TnyMergeFolders, to avoid the
881 warning about the unimplemented get_account_func() vfunc().
883 (modest_tny_folder_get_rules),
884 * src/modest-ui-actions.c:
885 (modest_ui_actions_on_folder_selection_changed):
886 * src/modest-mail-operation.c:
887 (modest_mail_operation_remove_folder),
888 (modest_mail_operation_xfer_folder),
889 (modest_mail_operation_rename_folder),
890 (modest_mail_operation_get_msg),
891 (modest_mail_operation_get_msgs_full),
892 (modest_mail_operation_remove_msg),
893 (modest_mail_operation_xfer_msgs),
894 (modest_mail_operation_refresh_folder):
895 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
897 2007-06-07 Murray Cumming <murrayc@murrayc.com>
899 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
900 (modest_server_account_set_security):
901 * src/modest-defs.h: Add comments explaining that our
902 UI spec means TLS when it says Normal, so these do not look like errors.
904 * src/modest-tny-account.c:
905 (modest_tny_account_new_from_server_account): Use the new tinymail
906 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
907 for TLS. This should fix projects.maemo.org bug NB#58460.
909 2007-06-06 Murray Cumming <murrayc@murrayc.com>
911 * src/maemo/easysetup/modest-easysetup-wizard.c:
912 (create_account): Correct the position of the gconf sanity check warning.
913 (on_button_edit_advanced_settings): Show the dialog immediately, instead
914 of using the g_idle_add() hack, because this does not seem to be necessary
915 on osso 1.1. It might even work on Maemo Bora if the problems were actually
916 caused by something other than maemo's gconf.
917 This fixes projects.maemo.org bug #59022.
919 2007-06-06 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-account-mgr-helpers.c:
922 (modest_account_mgr_get_default_account): Do not check that the account
923 exists if there is no default account (NULL), to fix a runtime warning.
925 2007-06-06 Murray Cumming <murrayc@murrayc.com>
927 * src/widgets/modest-folder-view.c: (update_model):
928 Do not unref the treemodel before we have finished with it.
929 This prevents a valgrind warning and an occasional crash at startup.
931 2007-06-06 Marcus Bauer <marcusb@openismus.com>
933 * libmodest-dbus-client/libmodest-dbus-client.h:
934 added libmodest_dbus_client_compose_mail()
935 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
937 added functions needed for SendAsMail() functionality
938 * src/maemo/modest-msg-edit-window.c:
939 (modest_msg_edit_window_attach_file_noninteractive):
940 non interactively attaching files to message edit window
941 * src/widgets/modest-msg-edit-window.h:
942 * tests/dbus_api/Makefile.am:
943 added test_compose_mail.c
944 * tests/dbus_api/test_compose_mail.c: (main):
946 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
948 * src/modest-account-view.c:
949 Fixed bug projects.maemo.org bug NB#59307
951 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
953 * src/maemo/easysetup/modest-easysetup-wizard.c:
954 (get_serverport_incoming), (on_before_next), (create_account):
955 * src/maemo/modest-account-settings-dialog.c:
956 (modest_account_settings_dialog_set_account_name):
957 * src/maemo/modest-maemo-utils.c:
958 (on_camel_account_get_supported_secure_authentication_status),
959 (on_camel_account_get_supported_secure_authentication),
960 (on_secure_auth_cancel),
961 (modest_maemo_utils_get_supported_secure_authentication_methods):
963 Implemented security authentication for settings and easysetup.
965 2007-06-05 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/modest-main-window.c: (create_details_widget):
968 Show the total size for memory card accounts too, instead of showing
969 the name again. Fixes bug projects.maemo.org bug NB#59307.
971 2007-06-05 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-tny-simple-folder-store.c:
975 * src/modest-tny-simple-folder-store.h: Removed.
977 * src/modest-tny-local-folders-account.h
978 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
979 for the local-folders maildir, with an extra TnyMergedFolder containing
980 the folders of the per-account outbox store accounts.
981 * src/modest-tny-account-store.c: (get_server_accounts):
982 Add the outboxes to the special local folders account after creating it.
984 * src/modest-tny-account.c:
985 (modest_tny_account_new_for_local_folders): Create the derived
986 account when creating the main local-folders account.
988 * src/maemo/modest-main-window.c: (create_details_widget),
989 (modest_main_window_set_contents_style):
990 Adapted to the use of the derived account instead of the folder store.
992 * src/modest-ui-actions.c:
993 (modest_ui_actions_on_folder_selection_changed):
994 * src/modest-ui-dimming-rules.c:
995 (modest_ui_dimming_rules_on_new_folder):
996 * src/widgets/modest-folder-view.c: (text_cell_data),
997 (icon_cell_data), (filter_row), (update_model),
998 (get_cmp_rows_type_pos):
1001 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1002 Do not get the priv struct, because no priv struct has been set,
1003 to avoid a runtime warning.
1005 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1006 #ifelse with #else, to fix a warning, to fix the build.
1009 2007-06-05 Christian Kellner <ckellner@openismus.com>
1011 * libmodest-dbus-client/libmodest-dbus-client.c:
1012 Fix small typo in doc (why do you always see them
1013 AFTER committing stuff?)
1016 2007-06-05 Christian Kellner <ckellner@openismus.com>
1018 * libmodest-dbus-client/libmodest-dbus-client.c:
1019 (libmodest_dbus_client_search):
1020 Initialize hit list with NULL. Also set folder list
1021 to "" if NULL was supplied.
1024 2007-06-03 Christian Kellner <ckellner@openismus.com>
1026 * libmodest-dbus-client/libmodest-dbus-client.c:
1027 (modest_search_hit_list_free):
1028 Make it save to call it with NULL.
1030 * src/dbus_api/modest-dbus-callbacks.c:
1031 * src/modest-search.c:
1032 Return full ModestSearchHits as the search result list not TnyHeader
1033 since can't be around withouth the correspoding TnyFolder.
1035 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1037 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1038 Added currently commented code to check for secure auth
1040 * src/maemo/modest-account-settings-dialog.c: (on_response),
1041 (save_configuration), (show_ok):
1042 Fixed projects.maemo.org bugs NB #59248 and #59251
1044 * src/maemo/modest-maemo-utils.c:
1045 (on_camel_account_get_supported_secure_authentication_status),
1046 (on_camel_account_get_supported_secure_authentication),
1047 (modest_maemo_utils_get_supported_secure_authentication_methods):
1048 * src/maemo/modest-maemo-utils.h:
1049 Moved get_supported_secure_authentication() method here to be able
1050 to use it from easysetup wizard.
1052 * src/modest-pair.c: (on_pair_compare_as_string):
1053 Should compare string with first part of pair and not
1054 strcmp pairs which will crash.
1056 * src/modest-protocol-info.c:
1057 (modest_protocol_info_protocol_is_store):
1058 * src/modest-protocol-info.h:
1059 Added modest_protocol_info_get_auth_protocol_name()
1061 2007-06-03 Armin Burgmeier <armin@openismus.com>
1063 * src/modest-mail-operation.c:
1064 (modest_mail_operation_get_msgs_full): Set priv->account also when
1065 only retrieving a single message. This avoids a crash when canceling
1068 (modest_mail_operation_notify_end): Do not explicitely remove the
1069 operation from the queue but only emit the progress_changed signal.
1070 The queue itself listens to that signal to remove the operation when
1071 it is finished. This reduces coupling and removes a potential deadlock
1072 when modest_mail_operation_notify_end() is called from the queue
1073 itself. If that is a problem performance-wise, I would suggest to
1074 implement a status-changed signal or something.
1076 * src/modest-mail-operation-queue.c: Make sure to never call a
1077 function from another file while the queue is locked. This (hopefully)
1078 fixes another deadlock when exiting the application while retrieving
1081 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1083 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1084 Fixed build if libogs is not available
1086 2007-06-03 Christian Kellner <ckellner@openismus.com>
1088 * libmodest-dbus-client/libmodest-dbus-client.h:
1089 * libmodest-dbus-client/libmodest-dbus-client.c:
1090 (libmodest_dbus_client_delete_message):
1091 Implement deletion of messages (Client side).
1093 (modest_search_hit_free),
1094 (modest_search_hit_list_free):
1095 Utility functions to free the result hits.
1097 * src/dbus_api/modest-dbus-api.h:
1098 * src/dbus_api/modest-dbus-callbacks.c:
1099 (on_delete_message),
1100 (modest_dbus_req_handler):
1101 Implement deletion of messages (Server side).
1103 * tests/dbus_api/test_search.c: (main):
1106 * tests/dbus_api/Makefile.am:
1107 * tests/dbus_api/test_delete_message:
1108 Add little test for the message deletion logic
1110 2007-06-03 Armin Burgmeier <armin@openismus.com>
1112 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1113 when the operation queue was not empty. projects.maemo.org bug
1116 2007-06-03 Armin Burgmeier <armin@openismus.com>
1118 * src/widgets/modest-account-view.c
1119 (on_account_default_toggled): Toggle default account column
1120 explicitely instead of waiting for gconf notification (which is
1121 currently ignored). This should fix projects.maemo.org bug NB#56910
1122 for now. It should probably be removed when gconf notifications are
1125 2007-06-03 Christian Kellner <ckellner@openismus.com>
1127 * libmodest-dbus-client/libmodest-dbus-client.c:
1128 Removed debugging spew.
1130 * src/dbus_api/modest-dbus-callbacks.c:
1131 Added debugging info.
1133 * src/modest-search.c:
1134 (modest_search_all_accounts):
1135 Use tny_account_store_get_accounts () on the account store
1136 to get all accounts which is the way to get all accounts.
1138 * tests/dbus_api/test_search.c: (main):
1139 Make it possible to supply the search term on the command line.
1141 2007-06-03 Christian Kellner <ckellner@openismus.com>
1143 * libmodest-dbus-client/libmodest-dbus-client.c:
1144 * libmodest-dbus-client/libmodest-dbus-client.h:
1145 Implement searching for mesages over raw dbus. (Client side)
1147 * src/dbus_api/Makefile.am:
1148 * src/dbus_api/modest-dbus-api.h:
1149 * src/dbus_api/modest-dbus-callbacks.c:
1150 * src/dbus_api/modest-dbus-callbacks.h:
1151 Search framework (Server side). Also implement on_idle_open_message().
1153 * src/maemo/modest-platform.c: (modest_platform_init):
1154 Prepare for raw dbus/osso rpc interaction.
1156 * src/modest-search.h:
1157 Changed minsize from unspecific guint to guint32.
1159 * src/modest-search.c:
1161 Added strange hack which magically made tnymail work.
1163 (modest_search_folder),
1164 (modest_search_account),
1165 (modest_search_all_accounts):
1166 Implement helper functions to search all accounts, specific account
1169 * tests/dbus_api/Makefile.am:
1170 * tests/dbus_api/test_open_message.c:
1171 Read url to open from commandline.
1173 * tests/dbus_api/test_search.c:
1174 Implement small test for dbus search stuff
1176 2007-06-02 Armin Burgmeier <armin@openismus.com>
1178 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1179 include account type and account title. This fixes projects.maemo.org
1182 * src/maemo/modest-account-view-window.c: Set a title for the window.
1184 2007-06-02 Armin Burgmeier <armin@openismus.com>
1186 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1187 incoming and outgoing server name based on email address and server
1188 types as long as the names have not been edited manually. This fixes
1189 projects.maemo.org bug NB#58671.
1191 2007-06-02 Armin Burgmeier <armin@openismus.com>
1193 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1194 server type cannot be changed in future to the incoming details page
1195 when creating an account. This fixes projects.maemo.org bug NB#59029.
1197 2007-06-02 Armin Burgmeier <armin@openismus.com>
1199 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1200 and assigned max width chars so that they wrap instead of being
1201 truncated. Fixes projects.maemo.org bug NB#56126.
1203 2007-06-02 Armin Burgmeier <armin@openismus.com>
1205 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1206 introductory note to the connection specific smtp servers dialog, as
1207 section 8.12 of the email UI specification requires. This fixes
1208 projects.maemo.org bug NB#59212.
1210 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1213 Check for running mail operations, and offer to cancel them, as per the UI
1214 spec. This fixes projects.maemo.org bug NB#59041 .
1215 However, I suspect that tinymail may still use the network connection
1216 in ways that we cannot detect or cancel. But it should at least adapt to
1217 changes fairly well.
1219 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-tny-account-store.c: (recreate_all_accounts),
1222 (get_cached_accounts), (get_server_accounts): Do more sensible
1223 ref-counting of the temporarily-cached outbox accounts list. This seems
1224 to fix a crash when entering the password when the password was wrong.
1226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1228 * src/gnome/modest-main-window.c: (connect_signals):
1229 * src/modest-tny-account-store.c: (get_password),
1230 (modest_tny_account_store_alert): Added comments and clues and
1231 commented-out code about how we currently fail to deal with connection
1232 errors and wrong passwords, and how we should.
1234 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1236 * src/widgets/modest-retrieve-combo-box.c:
1237 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1238 This fixes projects.maemo.org bug NB#58472 .
1240 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 (create_page_complete_easysetup):
1244 (create_page_complete_custom): Correct the last commit,
1245 putting the correct sentences in the correct pages.
1247 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1249 * src/maemo/easysetup/modest-easysetup-wizard.c:
1250 (create_page_complete_custom): Show the second sentence of text
1251 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1254 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1256 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1257 Set the leave-on-server conf key by default. This fixes
1258 projects.maemo.org bug NB#59258 .
1260 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1262 * src/maemo/modest-account-view-window.c:
1263 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1264 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1267 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/easysetup/modest-easysetup-wizard.c:
1270 (create_caption_new_with_asterisk):
1271 * src/maemo/modest-account-settings-dialog.c:
1272 (create_caption_new_with_asterisk):
1273 Uncomment the code to add the asterisk, because they are no longer in the
1274 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1275 (update_incoming_server_title): Add an asterisk here too.
1277 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-maemo-global-settings-dialog.c:
1280 (current_connection): Check that we are even connected before trying to
1281 get the current connection name, to prevent a warning.
1283 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1284 Change the comments because tny_maemo_conic_device_connect() is now meant to
1286 * src/modest-mail-operation.c:
1287 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1288 make sure we have a connection and fail if we can't connect.
1290 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1292 * src/maemo/modest-main-window.c:
1293 (on_account_store_connecting_finished): Do not try to get the
1294 connection ID if we are not really connected. I am surprised that
1295 this signal handler is called when we are not connected.
1297 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-error.h:
1300 * src/modest-ui-actions.c:
1301 (modest_ui_actions_get_msgs_full_error_handler):
1302 Renamed an enum, added comments, added an enum
1303 for retrieve-limit errors.
1305 * src/modest-mail-operation.c: (foreach_add_item),
1306 (internal_folder_observer_update), (update_account_thread),
1307 (modest_mail_operation_get_msgs_full):
1308 (modest_mail_operation_update_account),
1309 Added comments about how this works, and some code that should
1310 (but does not) check the retrieve-limit. See the TODO comment.
1312 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1314 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1315 Initialize help_id to fix the build. Warnings are good.
1317 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1319 * src/widgets/modest-hbox-cell-renderer.c:
1320 (modest_hbox_cell_renderer_append):
1321 * src/widgets/modest-vbox-cell-renderer.c:
1322 (modest_vbox_cell_renderer_append):
1323 Fix the last commit by doing an extra ref.
1325 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1327 * src/widgets/modest-hbox-cell-renderer.c:
1328 (modest_hbox_cell_renderer_append):
1329 * src/widgets/modest-vbox-cell-renderer.c:
1330 (modest_vbox_cell_renderer_append):
1331 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1332 to fix the build with Maemo Bora.
1333 However, there seems to be a remaining crash, probably due to reference
1336 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-tny-account.c:
1339 (modest_tny_account_new_for_local_folders):
1340 Use hildon_file_system_info_async_new() to get a better name for
1341 the memory card account, setting it as the account name.
1342 The timing seems to work, but this is probably
1343 not the best place to do this. See the TODO comment.
1344 * src/maemo/modest-main-window.c: (create_details_widget):
1345 * src/widgets/modest-folder-view.c: (text_cell_data):
1346 Use the tny account name instead of hardcoding a name.
1348 2007-05-30 Christian Kellner <ckellner@openismus.com>
1350 * src/modest-search.c: (modest_search):
1351 Correctly set part_search_func even if we have already parsed
1352 the query and thus a valid OgsTextSearcher object.
1354 2007-05-30 Christian Kellner <ckellner@openismus.com>
1357 Search and check for libogs.
1360 Incooparte the ogs build env.
1362 * src/modest-mime-part-search-stream.c:
1363 * src/modest-mime-part-search-stream.h:
1364 Removed since we do the real searching now in modest-search.c.
1366 * src/modest-search.c:
1367 * src/modest-search.h:
1368 Implement support for ogs. We use that if available and requested
1369 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1370 should now handle the corner case when the search term is spread
1371 across multiple reads.
1372 Also the logic in modest_search () was corrected to search all
1373 requested fields until one is found.
1375 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1379 * src/modest-init.h:
1380 * src/modest-init.c: Made modest_init_local_folders() take a
1381 path and be public so we can iniitialize maildir folders on
1384 * src/modest-local-folder-info.h:
1385 * src/modest-local-folder-info.c:
1386 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1388 * src/modest-tny-account.c:
1389 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1390 still means the standard local-folders path on the local volume.
1392 * src/modest-tny-account-store.c:
1393 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1394 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1395 all accounts when that happens.
1396 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1397 this too, so it shows up in the treeview.
1399 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1401 * src/maemo/modest-maemo-global-settings-dialog.c:
1402 (current_connection):
1403 * src/widgets/modest-global-settings-dialog.c:
1404 (current_connection_default):
1405 Use the enum values instead of 0, 1 and -1,
1406 to make the code clearer.
1408 * src/modest-account-mgr-helpers.c:
1409 (modest_account_mgr_get_connection_specific_smtp): Make this code
1412 * src/modest-runtime.h:
1413 * src/modest-runtime.c:
1414 Added modest_runtime_remove_all_send_queues().
1415 * src/maemo/modest-main-window.c:
1416 (on_account_store_connecting_finished): Recreate the send queues,
1417 using the appropriate transport accounts for this new connection.
1418 Some futher adapting might be needed if the old send queues are not
1419 automatically stopped at this point.
1421 * src/modest-tny-account-store.c: (get_server_accounts):
1422 Create the connection-specific transport accounts, so that they can
1423 be found later by their ID.
1425 * src/modest-tny-account.h:
1426 * src/modest-tny-account.c:
1427 Added modest_tny_account_new_from_server_account_name().
1428 modest_tny_account_new_from_server_account(): Do not create the
1429 send queues here, because they will be
1430 recreated anyway when the connection changes for the first time.
1432 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1434 * src/modest-local-folder-info.h:
1435 * src/modest-local-folder-info.c:
1436 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1437 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1438 tbox_folder): Take a modest account name instead of a server TnyAccount,
1439 so we can have per-modest-account rather than per-transport-account
1441 We must make sure that we change or recreate the exisitng send queues
1442 when the connection changes for connection-specific transport accounts.
1444 * src/modest-tny-account-store.c:
1445 (create_per_account_local_outbox_folders): Create outboxed per modest
1446 account, not per transport account.
1448 * src/modest-tny-account.h:
1449 * src/modest-tny-account.c:
1450 (modest_tny_account_get_special_folder): For outboxes, get the
1451 parent modest account name. The account is ignored for other folders.
1452 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1453 modest account name rather than a server TnyAccount.
1455 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1457 * src/modest-tny-account.c:
1458 (modest_tny_account_new_from_server_account):
1459 Call modest_runtime_get_send_queue() immediately after creating transport
1460 accounts, so that they start trying to send email from the outbox as soon
1461 as possible at startup. This is probably what we want.
1463 * src/modest-mail-operation.c: (update_account_thread):
1464 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1465 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1466 * src/modest-tny-send-queue.h:
1467 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1468 (modest_ui_actions_on_send):
1469 Added comments about how sending works, though it needs some more work.
1471 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-tny-account.c:
1474 (modest_tny_account_get_special_folder): Add TODO because this fails when
1475 the network is busy.
1476 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1477 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1478 Do not try to show this window when there is no active account. The UI
1479 specs does not tell us what to do in this case.
1481 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/Makefile.am:
1486 * src/widgets/Makefile.am: Some dist fixes.
1488 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1490 * src/maemo/modest-connection-specific-smtp-window.c:
1491 (on_button_edit): Make the code clearer, to prevent a double free.
1493 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/modest-account-settings-dialog.c:
1496 (modest_account_settings_dialog_set_account_name),
1497 Check the connection-specific smtp servers checkbox if there are any.
1499 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1500 (modest_connection_specific_smtp_edit_window_init):
1501 Start with a suitable port number.
1503 * src/modest-account-mgr-helpers.h:
1504 * src/modest-account-mgr-helpers.c: Added
1505 modest_account_mgr_get_has_connection_specific_smtp().
1507 (modest_account_mgr_set_connection_specific_smtp),
1508 (modest_account_mgr_remove_connection_specific_smtp),
1509 (modest_account_mgr_get_has_connection_specific_smtp),
1510 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1511 connection-specific smtp server accounts in the account, rather than
1512 the server account conf dir.
1514 This fixes bug projects.maemo.org bug NB#58263 .
1516 * src/modest-tny-account-store.c:
1517 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1518 if there are no server accounts yet, to prevent an infinite loop when there
1519 are no accounts. Document that one must be called before the other.
1521 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-account-mgr-helpers.c:
1524 (modest_account_mgr_get_default_account): Make sure that at least
1525 one account is always the default, if there are any enabled accounts.
1526 This is just a sanity check that shouldn't be necessary.
1528 * src/modest-account-mgr-priv.c:
1529 (_modest_account_mgr_account_from_key): Unescape the conf key to
1530 get the real account name. For instance, this is an issue if a space
1531 was in the account name, which can happen because the account name
1532 is generated from the display name.
1533 (_modest_account_mgr_get_account_keyname): Always escape the
1535 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1536 Unescape the conf keys to get the real account names.
1538 For instance, previously the is-default radio button in the accounts
1539 list was not checked for any accounts at first. This fixes that,
1540 and might fix several similar bugs.
1542 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1545 Removed some debug printfs.
1547 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1549 Modest on-disk outbox directories are now here, for instance:
1550 $HOME/.modest/outboxes/<account-id-1>/outbox
1551 $HOME/.modest/outboxes/<account-id-2>/outbox
1553 $HOME/.modest/local-folders/outbox
1554 so we can have a separate outbox for each account.
1555 But they are shown as one outbox in the GtkTreeView, by using a
1556 TnyMergeFolder in a ModestTnySimpleFolderStore.
1559 * src/modest-tny-simple-folder-store.c:
1560 * src/modest-tny-simple-folder-store.h:
1561 Added ModestTnySimpleFolderStore, used to contain folders from
1562 other folder stores, such as other accounts.
1564 * src/modest-tny-outbox-account.h:
1565 * src/modest-tny-outbox-account.c:
1566 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1567 used for the per-account local outbox folders.
1569 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1570 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1571 only use this (internally) now for the non-outbox local folders.
1573 * src/modest-init.h:
1574 * src/modest-init.c: Added modest_init_one_local_folder(), for
1575 setting up the directory structure for each local folder.
1577 * src/modest-local-folder-info.c:
1578 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1579 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1581 * src/modest-local-folder-info.h:
1582 * src/modest-tny-account-store.c: (on_account_removed),
1583 (on_account_changed), (create_per_account_local_outbox_folders),
1584 (get_server_accounts), (modest_tny_account_store_get_accounts),
1585 (modest_tny_account_store_get_tny_account_by_account),
1586 (modest_tny_folder_store_is_virtual_local_folders):
1588 * src/modest-tny-account.h:
1589 * src/modest-tny-account.c:
1590 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1591 to create an on-disk per-account local outbox folder for each
1593 (create_per_account_local_outbox_folders): Create a local outbox folder
1594 for each transport account.
1595 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1596 for all local folders.
1598 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1599 instead of using g_object_get/set() directly. It is clearer.
1601 (modest_tny_folder_store_get_message_count),
1602 (modest_tny_folder_store_get_local_size
1603 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1604 because we now use these with non-acount folder stores.
1606 (modest_tny_account_get_special_folder),
1607 (modest_tny_account_new_from_server_account),
1608 (modest_tny_account_new_from_account):
1609 (recurse_folders): Adjust to the new outbox system.
1611 * src/modest-tny-folder.h:
1612 * src/modest-tny-folder.c:
1613 (modest_tny_folder_is_local_folder),
1614 (modest_tny_folder_get_local_folder_type),
1615 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1617 * src/widgets/modest-main-window.h:
1618 * src/maemo/modest-main-window.c: (create_details_widget),
1619 (modest_main_window_set_contents_style): Show details for any folder store,
1622 (modest_tny_folder_get_rules):
1623 Remove the const. C does not support constness enough for this.
1625 * src/modest-ui-actions.c:
1626 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1627 make all outboxes appear as one, in the usual local-folders tree node.
1629 (set_active_account_from_tny_account),
1630 (modest_ui_actions_on_folder_selection_changed):
1631 * src/widgets/modest-folder-view.c: (text_cell_data),
1632 (icon_cell_data), (filter_row),
1633 (add_account_folders_to_merged_folder),
1634 (add_account_folders_to_simple_folder_store), (),
1635 (get_cmp_rows_type_pos), (cmp_rows),
1636 (modest_folder_view_set_account_id_of_visible_server_account):
1637 Adjust to the new outbox system, using generic folder stores and folders
1638 in the GtkTreeModel.
1640 2007-05-23 Christian Kellner <ckellner@openismus.com>
1642 * src/modest-mail-operation.c:
1643 (modest_mail_operation_update_account):
1644 Use info->max_size instead of unintialized local var [small
1645 build fix]. (Added TODO to review that change since I don't
1648 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1650 * libmodest-dbus-client/libmodest-dbus-client.c:
1651 (libmodest_dbus_client_compose_mail): function added
1652 * src/dbus_api/modest-dbus-api.h:
1653 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1654 (on_compose_mail): Implementation of the SendAsMail functionality
1656 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-account-mgr.c:
1659 (modest_account_mgr_add_server_account): Set the secure-connection
1660 conf key for transport accounts as well as store accounts. I don't know
1661 why the if was there. For instance, this makes sure that we use SSL
1662 for the gmail preset from the easysetup wizard.
1664 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1666 * src/gnome/modest-main-window.c:
1667 (on_account_store_connecting_finished), (connect_signals):
1668 * src/maemo/modest-main-window.c:
1669 (on_account_store_connecting_finished), (connect_signals),
1670 (modest_main_window_new):
1671 Handle TnyAccountStore::connecting-finished instead of
1672 TnyDevice::connection-changed, because we cannot actually perform
1673 operations on accounts until TnyAccountStore has itself responded to
1674 the TnyDevice::connection-changed signal. This prevents a GError from
1676 Do not try to update at startup, because we (at least on scratchbox)
1677 already do an update at startup when the device goes online.
1678 This prevents a GError from tinymail.
1679 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1680 Added TODO about stopping simultaneous operations.
1682 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1684 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1685 * src/modest-mail-operation-queue.c:
1686 (modest_mail_operation_queue_remove):
1687 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1688 about where they happened.
1690 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-ui-actions.c:
1693 (modest_ui_actions_on_password_requested): Make sure that the remember
1694 output parameter is always TRUE.
1696 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1698 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1699 Show a OK/Cancel dialog if the error is a question, though we still do not
1700 know anything more about what we are asking the user.
1701 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1702 Fix an uninitialized variable (helper). This is a logic error, however.
1704 2007-05-21 Christian Kellner <ckellner@openismus.com>
1706 * src/modest-search.h:
1707 Correct bit shifting in the ModestSearchFlags enum.
1709 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1711 * src/modest-tny-account.c:
1712 (modest_tny_account_new_from_server_account): Do not use the lsub and
1713 check-all hard-coded IMAP options when using POP.
1715 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1717 * src/modest-tny-account.c:
1718 (modest_tny_account_new_from_server_account):
1719 Use NULL for the secure-auth method for POP when Password auth has been
1720 specified by the user, as we already do for IMAP. "auth=Login" causes
1721 an error from camel or the server.
1723 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1725 * src/maemo/modest-account-settings-dialog.c:
1726 (create_page_account_details),
1727 (modest_account_settings_dialog_set_account_name):
1728 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1729 for the leave-on-server checkbox, rathr than just the checkbox, when
1730 the protocol is not POP.
1732 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1734 * src/widgets/modest-account-view.c:
1735 * src/widgets/modest-account-view.h:
1736 Added modest_account_view_select_account() which will be useful later
1737 to asynchronously re-select the edited account.
1739 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1741 * src/maemo/modest-account-settings-dialog.c:
1742 (modest_account_settings_dialog_set_account_name):
1743 Automatically choose the port numbers based on the secure authentication
1744 methods, if they have not been chosen before.
1745 This fixes projects.maemo.org bug NB#56273 .
1747 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/modest-main-window-ui.h:
1750 * src/modest-ui-actions.c:
1751 * src/modest-ui-actions.h:
1752 Connect the Tools/SMTP Servers menu item to
1753 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1754 SMTP servers dialog, as in the UI specification and saves changes when it
1755 is closed. This fixed projects.maemo.org bug NB#56305 .
1757 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/modest-connection-specific-smtp-window.c:
1760 (modest_connection_specific_smtp_window_init):
1761 Use gtk_window_set_default_size() to make this window big enough, so
1762 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1764 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1766 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1767 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1768 (modest_connection_specific_smtp_edit_window_init),
1769 Do not try to connect to a combobox signal before the combobox exists.
1770 This fixes the cras in projects.maemo.org bug NB#56288 .
1771 (modest_connection_specific_smtp_edit_window_get_settings):
1772 Remove the server_account_name parameter which was being checked for NULL
1773 though it was not used.
1775 * src/maemo/modest-connection-specific-smtp-window.c:
1776 (modest_connection_specific_smtp_window_fill_with_connections),
1777 (on_button_edit), (modest_connection_specific_smtp_window_init):
1778 Correct the number of treemodel columns to prevent a warning.
1779 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1780 libconic does not work.
1782 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-tny-account.c:
1785 (modest_tny_account_new_from_server_account):
1786 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1787 SMTP when "None" was chosen by the user. However, with my SMTP server that
1788 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1791 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1794 to explain the memory management issue with the ID in the ModestPair.
1796 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1797 (add_sending_page), (modest_account_assistant_finalize):
1798 * src/gnome/modest-gnome-global-settings-dialog.c:
1799 (create_updating_page), (create_composing_page):
1800 * src/gnome/modest-msg-edit-window.c: (get_transports),
1801 (init_window), (modest_msg_edit_window_finalize),
1802 (modest_msg_edit_window_get_msg_data):
1803 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1804 * src/gnome/modest-transport-widget.c:
1805 (modest_transport_widget_finalize), (smtp_configuration):
1806 * src/maemo/modest-maemo-global-settings-dialog.c:
1807 (create_updating_page), (create_composing_page):
1808 * src/maemo/modest-msg-edit-window.c: (get_transports),
1809 (init_window), (modest_msg_edit_window_finalize),
1810 (modest_msg_edit_window_get_msg_data),
1811 (modest_msg_edit_window_free_msg_data):
1812 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1813 (modest_store_widget_finalize):
1814 * src/maemo/modest-transport-widget.c:
1815 (modest_transport_widget_finalize), (smtp_configuration):
1816 * src/modest-main.c: (send_mail):
1817 * src/widgets/modest-combo-box.h:
1818 * src/widgets/modest-global-settings-dialog-priv.h:
1819 * src/widgets/modest-global-settings-dialog.c:
1820 (modest_global_settings_dialog_finalize):
1821 * src/widgets/modest-msg-edit-window.h:
1822 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1823 as long as the combo box, to prevent use of freed memory for the ID.
1825 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1827 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1828 get_accounts(), to make this clearer. Do not check for the enabled gconf
1829 key, because we do not use this for server accounts (at least, not yet).
1830 This allows us to send email again.
1832 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/modest-platform.c:
1835 (on_modest_conf_update_interval_changed), (modest_platform_init):
1836 Only respond to this particular key change. All these strcmp()s cannot be
1839 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/modest-maemo-global-settings-dialog.c:
1842 (current_connection): Prevent a crash in scratchbox when
1843 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1844 * src/maemo/modest-platform.c:
1845 (on_modest_conf_update_interval_changed), (modest_platform_init):
1846 Get the update interval from gconf and reset it when the gconf key changes.
1848 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1850 * src/modest-protocol-info.c:
1851 * src/modest-protocol-info.h: Adde enum-specific get functions,
1852 instead of using a ModestProtocolType enum parameter.
1854 * src/gnome/modest-account-assistant.c:
1855 * src/gnome/modest-store-widget.c:
1856 * src/gnome/modest-store-widget.h:
1857 * src/gnome/modest-transport-widget.c:
1858 * src/gnome/modest-transport-widget.h:
1859 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1860 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1861 * src/maemo/easysetup/modest-easysetup-wizard.c:
1862 * src/maemo/modest-account-settings-dialog.c:
1863 * src/maemo/modest-account-settings-dialog.h:
1864 * src/maemo/modest-store-widget.c:
1865 * src/maemo/modest-store-widget.h:
1866 * src/maemo/modest-transport-widget.c:
1867 * src/maemo/modest-transport-widget.h:
1868 * src/modest-account-mgr-helpers.c:
1869 * src/modest-account-mgr-helpers.h:
1870 * src/modest-account-mgr.c:
1871 * src/modest-account-mgr.h:
1872 * src/modest-tny-account.c:
1873 * src/modest-tny-folder.c:
1874 * src/widgets/modest-account-view.c:
1875 * src/widgets/modest-retrieve-combo-box.c:
1876 * src/widgets/modest-retrieve-combo-box.h:
1877 * src/widgets/modest-secureauth-combo-box.c:
1878 * src/widgets/modest-serversecurity-combo-box.c:
1879 * src/widgets/modest-serversecurity-combo-box.h:
1880 * tests/check_account-mgr.c:
1881 Use the specific functions, and use the re-renamed enum values for GNOME too.
1883 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1885 * src/modest-pair.h:
1886 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1887 so we can get the second based on the first.
1889 * src/maemo/modest-account-settings-dialog.h:
1890 * src/maemo/modest-account-settings-dialog.c:
1891 Added get_supported_secure_authentication_methods(), though it is mostly
1892 commented-out for now until the necessary API is committed to tinymail.
1893 (modest_account_settings_dialog_set_account_name),
1894 (save_configuration): Request the supported authentication methods from the
1895 server, so we can choose a working method.
1897 * src/modest-tny-account-store.h:
1898 * src/modest-tny-account-store.c:
1899 (modest_tny_account_store_get_session): Rename from
1900 tny_account_store_get_session().
1902 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-protocol-info.h: Split the ModestProtocol enum
1905 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1906 There was no need to have these unrelated values in one enum.
1908 * src/: many files: Adapted to changed enum. This makes the code a bit
1909 clearer, and the compiler could catch some errors.
1911 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1914 Show the detailed internal camel error message when an error happens
1915 during the configuration, so that our testers can give us more clues.
1916 For instance, in projects.maemo.org bug NB#56910 .
1918 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-tny-account.c:
1921 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1922 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1924 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1927 * src/maemo/modest-account-settings-dialog.c:
1928 (modest_account_settings_dialog_set_account_name),
1929 (save_configuration): For the incoming secure authentication checkbox,
1930 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1931 the UI specification. PLAIN does not seem to be supported for most IMAP
1932 servers anyway, and I am not sure what it would mean.
1933 However, we probably need to discover which of the secure-authentication
1934 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1935 * src/modest-account-mgr-helpers.c:
1936 (modest_account_mgr_get_server_account_data):
1938 * src/modest-tny-account.c:
1939 (modest_tny_account_new_from_server_account):
1940 Use tny_account_set_mech() to set secure-authentication methods,
1941 with some special-casing for IMAP, based on my observations of how
1944 * src/modest-account-mgr-helpers.h:
1945 * src/modest-account-mgr.c:
1946 * src/modest-defs.h: Comment that the URI is only used for local folders.
1948 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1951 parameter const, just to be neat.
1952 * src/modest-text-utils.c: (modest_text_utils_inline):
1953 End g_strconcat() with NULL, as its documentation says. This is almost
1954 certainly the cause of my crash at startup on the device. Interestingly,
1955 valgrind doesn't tell us about these errors.
1957 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1959 * scripts/build-packages: Added more precise comments about how to use
1960 this script, though I still get this error:
1961 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1962 error building tinymail
1964 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1966 * src/maemo/modest-main-window.c: (on_account_update):
1967 Very slight cleanup, hoping to make it simpler to discover what causes
1968 a crash here sometimes.
1970 * src/modest-tny-account.c:
1971 (modest_tny_account_new_from_server_account): Set the port. Added
1972 comments about the options and a TODO comment because I need to find out
1973 how to specify the secure authentication method.
1975 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1977 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1978 changed CFlags paths form modest to libmodest
1980 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-account-mgr-helpers.c:
1983 (modest_account_mgr_get_server_account_data),
1984 (modest_account_mgr_free_server_account_data):
1985 * src/modest-account-mgr-helpers.h:
1986 * src/modest-account-mgr.c:
1987 (modest_account_mgr_add_server_account):
1988 * src/modest-defs.h:
1989 * src/modest-tny-account.c:
1990 (modest_tny_account_new_from_server_account):
1991 Determine the options for tny_camel_account_add_option() here,
1992 based on the settings, rather than storing them directly in gconf.
1994 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1996 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1997 Show a more friendly error dialog now that we expect (from the tinymail
1998 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2000 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/modest-main-window.c: (on_account_update): Check that
2003 account_name is not NULL, to prevent a crash at startup that I am
2004 seeing on the N800. I do wonder why it is NULL.
2006 * src/maemo/easysetup/modest-easysetup-wizard.c:
2007 (create_page_user_details):
2008 * src/maemo/modest-account-settings-dialog.c:
2009 (create_page_user_details), (create_page_outgoing):
2010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2011 (modest_connection_specific_smtp_edit_window_init):
2012 * src/modest-ui-actions.c:
2013 (modest_ui_actions_on_password_requested):
2014 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2015 might do something useful with the on-screen keyboard.
2017 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-main-window.c: (on_account_update):
2020 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2021 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2023 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2025 * src/modest-tny-account-store.c: (on_account_changed):
2026 Correct the signature of this signal handler.
2028 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2031 Show a HildonNote instead of a GtkDialog for Maemo.
2033 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2035 * src/widgets/modest-account-view.h:
2036 * src/widgets/modest-account-view.c: (on_account_changed),
2037 (on_account_removed). Added a boolean flag, set/unset by
2038 modest_account_view_block_conf_updates(),
2039 modest_account_view_unblock_conf_updates() to prevent unnecessary
2040 updates, but this is not very useful because the gconf notifications are
2041 so delays (maybe only on Maemo Bora).
2042 So auto-updating is turned off, and these functions do an explicit
2043 update when necessary.
2044 However, something else is still doing too much work when adding/removing
2045 accounts, probably in another part of the application.
2047 * src/maemo/modest-account-view-window.c:
2048 (on_delete_button_clicked), (on_edit_button_clicked),
2049 (on_new_button_clicked): Use the new functions.
2051 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2053 * src/modest-account-mgr-helpers.c:
2054 (modest_account_mgr_set_first_account_as_default):
2055 Sort the list of names alphabetically-by-title, so we choose the first one
2057 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2058 alphabetically by the title.
2060 This fixes projects.maemo.org bug NB#56418 .
2062 * src/modest-account-mgr-priv.c:
2063 (_modest_account_mgr_account_from_key):
2064 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2065 avoid a valgrind error, and possible random behaviour.
2067 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2070 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2071 tinymail documentation to say that this can be expected.
2072 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2073 pretty, and should not happen, but I would prefer to know when it does.
2075 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2077 * configure.ac: When using the older hildon version, probably on Bora,
2078 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2080 * src/widgets/modest-attachment-view.c:
2081 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2084 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2086 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2087 Implemented the prototype. Can be tested with
2088 tests/dbus_api/test_open_message:
2090 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-tny-account-store.c:
2093 (modest_tny_account_store_instance_init), (get_password):
2094 * src/modest-ui-actions.c:
2095 (modest_ui_actions_on_password_requested):
2096 Do not store the password in gconf, because this function is called
2097 for non-remembered passwords. Actually use the cached (in the hash map)
2098 password instead of releasing it.
2099 The password will now not be remembered if it is asked via the protected
2100 password dialog, as per the UI spec.
2102 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2104 * src/modest-defs.h:
2105 * src/modest-account-mgr-helpers.h:
2106 * src/modest-account-mgr-helpers.c:
2107 Added modest_server_account_get_username_has_succeeded(),
2108 modest_server_account_set_username_has_succeeded().
2109 (modest_server_account_set_username),
2110 Reset the has-succeeded flag if the username changes.
2112 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2113 * src/maemo/modest-connection-specific-smtp-window.c:
2114 (modest_connection_specific_smtp_window_save_server_accounts):
2115 Use modest_server_account_set_username() instead of using
2116 modest_conf_set_string() directly, so that the has-succeeded flag is always
2119 * src/modest-ui-actions.c:
2120 (modest_ui_actions_on_password_requested): Dim the username entry if
2121 the username has ever worked, as per the UI spec.
2123 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-tny-account-store.c: (get_password):
2126 * src/modest-ui-actions.c:
2127 (modest_ui_actions_on_password_requested):
2128 Allow the username to be changed too, though there is more work to
2129 be done on exactly how this behaves.
2131 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-account-mgr-helpers.h:
2134 * src/modest-account-mgr-helpers.c:
2135 Added modest_account_mgr_get_display_name(),
2136 modest_server_account_get_username(),
2137 modest_server_account_set_username(),
2138 modest_server_account_set_password(),
2139 modest_server_account_get_hostname() functions so we do not need to
2140 use the conf API directly.
2142 * src/maemo/modest-main-window.c: (connect_signals):
2143 Actually connect ot the ModestAccountStore::request-password signal,
2144 so that we show the dialog when the password is requested by Tinymail,
2145 for isntance if it is empty.
2147 * src/modest-marshal.list:
2148 * src/modest-tny-account-store.c:
2149 (modest_tny_account_store_class_init), (get_password),
2150 (modest_tny_account_store_alert):
2151 * src/modest-tny-account-store.h:
2152 * src/modest-ui-actions.h:
2153 * src/modest-ui-actions.c:
2154 (modest_ui_actions_on_password_requested):
2155 Change the signal parameters, so it is obvious that we are providing
2156 the non human-readable server name, and receiving both the username
2157 and password, though changing of the username is not yet implemented.
2158 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2159 for the GNOME version.
2161 This should fix the projects.maemo.org bug NB#56209, though it does not
2162 work on Bora, because the gconf_client_get() for the password fails
2163 immediately after we save it with gconf_client_set().
2165 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2168 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2169 caused an undefined symbol error:
2170 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2172 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-tny-account-store.c:
2175 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2176 using a GError instead of a string message, so we can translate it in
2179 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/modest-address-book.c:
2182 (modest_address_book_check_names):
2183 * src/maemo/modest-msg-view-window.c:
2184 (modest_msg_view_window_clipboard_owner_change):
2185 * src/modest-init.c: (modest_init_init_ui):
2186 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2187 (update_folders_cb), (modest_mail_operation_update_account):
2188 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2189 (modest_ui_actions_on_msg_attachment_clicked),
2190 (modest_ui_actions_on_msg_recpt_activated):
2191 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2192 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2193 (modest_msg_view_search_next):
2194 * src/widgets/modest-recpt-editor.c:
2195 (modest_recpt_editor_on_button_release_event),
2196 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2197 g_message(). At this point we should only be seeing interesting errors on
2198 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2200 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2202 (modest_wizard_dialog_force_title_update):
2203 * src/maemo/easysetup/modest-wizard-dialog.h:
2204 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2205 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2206 can update the title when appropriate. Otherwise the title is wrong if the
2207 pages are added after adding the notebook to the dialog.
2208 This must be a problem in HildonWizardDialog too.
2209 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2211 * src/maemo/easysetup/modest-easysetup-wizard.c:
2212 (create_subsequent_customsetup_pages),
2213 (create_subsequent_easysetup_pages):
2214 Call modest_wizard_dialog_force_title_update() so that the title is
2215 correct even with GTK+ < 2.10.
2216 This fixes projects.maemo.org bug NB#56145 .
2218 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/modest-platform.c:
2221 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2222 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2225 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2227 * src/widgets/modest-window.h:
2228 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2229 and modest_window_save_state(), which invokes it.
2231 * src/widgets/modest-window-mgr.h:
2232 * src/widgets/modest-window-mgr.c:
2233 Added modest_window_mgr_save_state_for_all_windows(), which calls
2234 the save_state vfunc on all registered windows, if implemented.
2236 * src/gnome/modest-msg-edit-window.c:
2237 * src/gnome/modest-msg-view-window.c:
2238 * src/maemo/modest-msg-edit-window.c:
2239 * src/maemo/modest-msg-view-window.c:
2240 * src/maemo/modest-main-window.c:
2241 Specify the existing save_settings functions as implementations of
2242 ModestWindow::save_state_func().
2244 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2245 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2246 enabling hibernation, for instance.
2248 We may need to do the same thing for restoring settings.
2251 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2253 * src/widgets/modest-window-mgr.c:
2254 * src/widgets/modest-window-mgr.h:
2255 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2256 modest_window_mgr_get_hibernation_is_prevented().
2258 * src/maemo/modest-main-window.c:
2259 (on_hildon_program_is_topmost_notify): Prevent hibernation
2260 (possible when the application goes to the background in the WM),
2261 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2263 * src/maemo/easysetup/modest-easysetup-wizard.c:
2264 (modest_easysetup_wizard_dialog_init):
2265 * src/maemo/modest-account-settings-dialog.c:
2266 (modest_account_settings_dialog_init):
2267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2268 (modest_connection_specific_smtp_edit_window_init):
2269 * src/maemo/modest-connection-specific-smtp-window.c:
2270 (modest_connection_specific_smtp_window_init):
2271 * src/maemo/modest-signature-editor-dialog.c:
2272 (modest_signature_editor_dialog_init):
2273 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2274 prevent hibernation while any of these account settings dialogs are open.
2276 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/Makefile.am:
2279 * src/maemo/modest-osso-state-saving.c:
2280 * src/maemo/modest-osso-state-saving.h: Added
2281 modest_osso_load_state() and modest_osso_save_state() though they do
2282 nothing now. They should iterate through all the open windows and load/save
2284 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2285 save state when closing.
2287 * src/maemo/modest-main-window.c:
2288 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2289 Add a notification handler for the HildonProgram::is-topmost property,
2290 so we can allow hibernation when the application goes into the background.
2291 But we still need to detect when the accounts setup windows are open so
2292 we can stop hibernation when they are open.
2293 To do this, I also added the main window the HildonProgram. This might have
2294 other side-effects/benefits, and should maybe be done for other windows.
2296 * src/maemo/modest-osso-autosave-callbacks.h:
2297 * src/maemo/modest-osso-autosave-callbacks.c:
2298 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2299 though it does not do anything yet, and we might never need this to do
2300 anything. For instance, we already save drafts.
2302 * src/maemo/modest-platform.c: (modest_platform_init):
2303 Specify the libosso auto-save callback.
2305 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/modest-platform.c:
2308 (modest_platform_set_update_interval):
2309 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2310 aparently stays valid between application instances, so we can use this
2311 to remove and reset it later. According to a maemo-developers email from
2314 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2316 * configure.ac: Depend on libalarm for Maemo.
2318 * src/dbus_api/modest-dbus-api.h:
2319 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2320 (on_send_receive), (modest_dbus_req_handler):
2321 Handle a SEND_RECEIVE D-Bus method.
2323 * libmodest-dbus-client/libmodest-dbus-client.c:
2324 (libmodest_dbus_client_send_and_receive):
2325 * libmodest-dbus-client/libmodest-dbus-client.h:
2326 Add C convenience functions for calling the new D-Bus method.
2328 * src/modest-platform.h:
2329 * src/gnome/modest-platform.c:
2330 * src/maemo/modest-platform.c:
2331 Added modest_platform_set_update_interval(), which uses the
2332 alarmd API on Maemo.
2333 (modest_platform_init),
2334 Call modest_platform_set_update_interval(), using a hard-coded
2335 interval for now (until the global settings dialog is implemented),
2336 though I am not sure that this makes sense yet.
2338 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2340 * src/dbus_api/modest-dbus-callbacks.c:
2341 (modest_osso_cb_hw_state_handler):
2342 * src/dbus_api/modest-dbus-callbacks.h:
2343 * src/maemo/modest-platform.c: (modest_platform_init):
2344 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2345 in case this has some effect on the ability for Maemo to ping the
2348 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2350 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2351 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2352 warning. It is probably a logic error, but I need to fix the build.
2354 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-account-mgr.h:
2357 * src/modest-account-mgr.c:
2358 (modest_account_mgr_account_names): Add a gboolean enabled_only
2359 parameter, so we can get lists of onlt the enabled accounts.
2361 (modest_account_mgr_add_account),,
2362 (modest_account_mgr_account_with_display_name_exists):
2363 * src/maemo/modest-msg-edit-window.c: (get_transports):
2364 * src/modest-account-mgr-helpers.c:
2365 (modest_account_mgr_set_first_account_as_default):
2366 * src/modest-init.c: (init_default_account_maybe):
2367 * src/modest-tny-account-store.c: (get_accounts):
2368 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2369 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2370 * tests/check_account-mgr.c: (START_TEST):
2371 Provide the extra parameter, as appropriate.
2373 * src/widgets/modest-account-view.c: (update_account_view):
2374 Do not show disabled accounts (meaning that there is no way to
2375 enable/disable accounts in the UI (the feature is not in our UI
2376 specification), so we can use this internally only to mark unfinished
2377 or temporary account data.
2379 * src/maemo/easysetup/modest-easysetup-wizard.c:
2380 (create_account): Add boolean enable parameter, so we can specify FALSE
2381 to create the temporary account.
2382 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2383 (on_before_next): When finishing, when there is a temporary account, just
2385 Also, use a timeout to delay the showing of the dialog until gconf is likely
2386 to return correct information, due to a maemo gconf bug that is fixed in
2387 osso 1.1, but not yet in Bora.
2388 However, the dialog stays on screen after it is destroyed.
2390 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2391 for invalid data when cancelling. Use a hildon note instead of a dialog
2392 to complain about invalid data. Do not show the account-saved note if the
2393 account is disabled (a temporary account that will not really be saved for use
2396 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-account-mgr-helpers.h:
2399 * src/modest-account-mgr-helpers.c:
2400 Added modest_account_mgr_unset_default_account(),
2401 Added modest_account_mgr_set_first_account_as_default().
2403 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2404 If it was the default account, unset the default account name.
2406 * src/maemo/modest-account-view-window.c:
2407 (on_delete_button_clicked): If it was the default account,
2408 set the first remaining account as the default instead.
2410 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2411 a NULL account or a NULL default account, to prevent a crash. This should
2412 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2415 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2417 * src/widgets/modest-recpt-editor.c:
2418 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2419 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2420 TODO comment for this. This fixes the build.
2422 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2423 be the best place for it. This will in future update all auto-update accounts,
2424 rather than just the current/default account, when that gconf key exists.
2425 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2426 if there are no accounts, before calling do_send_receive().
2427 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2429 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2430 * src/maemo/modest-main-window-ui.h:
2431 * src/maemo/modest-main-window.c: (on_connection_changed),
2432 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2433 directly, becaue the signal handler does more.
2435 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2437 * src/modest-account-mgr-helpers.c:
2438 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2439 for the case that the account does not exist.
2441 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2442 (equivalent to the modest account name) rather than the tinymail account name
2443 (equivalent to the modest account title - human readable) to get the account data.
2444 Check for null account data to prevent the crash, and add a TODO comment saying that
2445 this needs fixing because it is using the server account name instead of the account name.
2447 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2450 * src/maemo/modest-account-settings-dialog.c: (show_error),
2452 Use hildon_note_new_information() for informative and error messages,
2453 which seems to be expected for Maemo applications (no documentation that I know of
2454 says this). I am surprised that there is no distinction between info and error
2457 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2459 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2460 it is easy to find where this is used.
2462 * src/maemo/easysetup/modest-easysetup-wizard.c:
2463 (create_page_welcome), (create_page_account_details),
2464 (create_page_user_details), (create_page_complete_easysetup),
2465 (create_page_custom_incoming), (create_page_custom_outgoing),
2466 (create_page_complete_custom):
2467 * src/maemo/modest-account-settings-dialog.c:
2468 (create_page_account_details), (create_page_user_details),
2469 (create_page_incoming), (create_page_outgoing):
2470 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2471 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2472 (modest_connection_specific_smtp_edit_window_init):
2473 * src/maemo/modest-connection-specific-smtp-window.c:
2474 (modest_connection_specific_smtp_window_init):
2475 * src/maemo/modest-signature-editor-dialog.c:
2476 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2477 and scrolling policy as per the Email Application Layout Guide, if I have
2480 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2482 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2483 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2484 which were empty, because these vfuncs have been removed from TnyAccountStore.
2485 This fixes the build.
2487 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2489 * src/maemo/modest-main-window.c:
2490 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2491 showing/hiding it. Added TODO because it probably should not be NULL.
2492 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2493 because unnecessary g_warnings() make degugging difficult.
2495 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2497 * src/maemo/modest-msg-edit-window.c:
2498 (modest_msg_edit_window_select_color),
2499 (modest_msg_edit_window_select_background_color): 2 const corrections and
2500 moving 2 #endifs before closing brackets, to fix the build.
2502 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/easysetup/modest-easysetup-wizard.h:
2505 * src/maemo/easysetup/modest-easysetup-wizard.c:
2506 (modest_easysetup_wizard_dialog_finalize),
2507 (on_button_edit_advanced_settings), (create_page_complete_custom),
2508 (on_response), (create_account):
2509 Implement the Advanced Settings edit button, by saving the account information,
2510 for the Advanded Settings dialog to use directly from gconf, and removing it
2511 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2512 Bug #5533 in the projects.maemo.org bugzilla.
2514 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/modest-msg-view-window.c:
2517 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2518 when opening a message window.
2520 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2522 * src/maemo/easysetup/modest-easysetup-wizard.c:
2523 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2526 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2527 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2528 gconf settings. I probably added more checks than necessary, but that is safer.
2530 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2531 variable to fix the build, but this seems to be used when it is still NULL.
2533 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2535 * src/modest-platform.h:
2536 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2537 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2538 * src/modest-main.c: Implement this function so we can avoid using
2539 maemo-specific API from cross-platform code.
2541 * src/modest-tny-account-store.c:
2542 (get_smtp_specific_transport_account_for_open_connection):
2543 * src/modest-ui-actions.c: (check_for_connection),
2544 (modest_ui_actions_on_item_not_found):
2545 Use modest_platform_connect_and_wait() and put #idefs around other
2546 maemo-specific code, because only maemo currently has a way to
2547 identify connection names.
2549 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2551 * src/modest-tny-account-store.h:
2552 * src/modest-tny-account-store.c:
2553 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2554 the connection-specific SMTP server settings in the configuration.
2556 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2558 * src/maemo/modest-main-window.c: (on_connection_changed),
2560 * src/modest-main.c: (main), (start_ui), (send_mail):
2561 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2562 that is what is intended.
2564 * src/modest-ui-actions.c: (action_send), (action_receive),
2565 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2566 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2567 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2568 SMTP server is used when it is specified.
2570 (modest_ui_actions_on_send_receive):
2571 Check that a connection is open before proceeding.
2572 Receive and then send, instead of vice-versa, as per the specification.
2574 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2576 * src/modest-mail-operation.c:
2577 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2578 though I guess it should be something other than NULL.
2580 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2582 * src/maemo/easysetup/modest-easysetup-wizard.c:
2583 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2584 combo twice, to avoid an g_warning and to make it visible again.
2585 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2586 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2587 (already intended) dereference when detaching, because we then recreate the menu.
2588 But I am not sure why the warning was happening, and it is possible that this is a memory
2591 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2593 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2594 and uri_parse_mailto() utility functions.
2595 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2597 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2599 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2601 * src/dbus_api/modest-dbus-api.h:
2602 * src/dbus_api/modest-dbus-callbacks.c:
2603 Use an idle callback to execute the modest code in the application's own thread.
2604 Remove the helloworld example method.
2605 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2606 parsed, and the open-message method is not implemented because this is not yet implemented in
2608 * libmodest-dbus-client/libmodest-dbus-client.c:
2609 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2610 (libmodest_dbus_client_open_message):
2611 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2613 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2614 body without crashing.
2616 * tests/dbus_api/Makefile.am:
2617 * tests/dbus_api/test_mail_to.c:
2618 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2620 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2622 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2623 Added file to fix the build. Sorry.
2625 * src/dbus_api/Makefile.am:
2626 * src/dbus_api/modest-dbus-api.h:
2627 * src/dbus_api/modest-dbus-callbacks.h:
2628 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2629 (modest_dbus_req_handler):
2630 Put constants in a separate header so it can be reused by the
2631 client library, without duplication
2633 * libmodest-dbus-client/Makefile.am:
2634 * libmodest-dbus-client/libmodest-dbus-client.c:
2635 (libmodest_dbus_client_call_helloworld),
2636 (libmodfest_dbus_client_send_mail),
2637 (libmodfest_dbus_client_mailto),
2638 (libmodfest_dbus_client_open_message):
2639 * libmodest-dbus-client/libmodest-dbus-client.h:
2640 (Partly) Implement a send_mail D-Bus method.
2642 * tests/dbus_api/Makefile.am:
2643 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2644 the send_email D-Bus method.
2646 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2650 * libmodest-dbus-client/Makefile.am:
2651 * libmodest-dbus-client/libmodest-dbus-client.c:
2652 * libmodest-dbus-client/libmodest-dbus-client.h:
2653 * tests/dbus_api/Makefile.am:
2654 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2655 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2657 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_account_details):
2661 * src/maemo/modest-account-settings-dialog.c:
2662 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2663 widgets, because this might not be the default in future versions of the Maemo GTK+.
2664 However, I can not not get capitalization to work even in a simple test case.
2666 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/easysetup/modest-easysetup-wizard.c:
2669 (create_page_custom_incoming), (create_page_custom_outgoing):
2670 * src/maemo/modest-account-settings-dialog.c:
2671 (create_page_account_details), (create_page_incoming),
2672 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2673 instead of using gtk_check_button_with_label(), so they are aligned like the other
2674 widgets, as per the UI spec.
2676 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/easysetup/modest-easysetup-wizard.c:
2679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2680 * src/widgets/modest-validating-entry.c:
2681 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2682 Modest prefix instead of an EasySetup prefix.
2684 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2686 * src/widgets/modest-validating-entry.h:
2687 * src/widgets/modest-validating-entry.c: (on_insert_text),
2688 Added easysetup_validating_entry_set_max_func(), used to set a callback
2689 to call when the max number of characters is reached. GtkEntry has a max-length
2690 already but is silent about it.
2692 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2693 (create_page_account_details), (create_page_user_details),
2695 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2696 (create_page_account_details), (create_page_user_details),
2697 (create_page_outgoing):
2698 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2699 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2700 the UI spec, when the user tries to enter more than the max number of characters.
2702 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2704 * src/maemo/easysetup/modest-easysetup-wizard.c:
2705 (create_page_user_details), (create_page_custom_incoming),
2706 (create_page_custom_outgoing):
2707 * src/maemo/modest-account-settings-dialog.c:
2708 (create_page_user_details), (create_page_incoming),
2709 (create_page_outgoing):
2710 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2711 (modest_connection_specific_smtp_edit_window_init):
2712 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2713 not appropriate. Bad Maemo-specific defaults!.
2715 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2718 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2719 (modest_signature_editor_dialog_set_settings):
2720 Disable the label and textview when the checkbox is disabled, and use the
2721 specified (UI spec) default signature text.
2723 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2726 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2728 * src/modest-defs.h:
2729 * src/modest-account-mgr-helpers.h:
2730 * src/modest-account-mgr-helpers.c:
2731 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2733 * src/maemo/Makefile.am:
2734 * src/maemo/modest-signature-editor-dialog.c:
2735 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2738 * src/maemo/modest-account-settings-dialog.h:
2739 * src/maemo/modest-account-settings-dialog.c:
2740 (modest_account_settings_dialog_finalize), (on_button_signature),
2741 (save_configuration): Use the new dialog when the Edit button is pressed, and
2742 save the changes if necessary, as per the UI spec.
2744 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2746 * src/maemo/Makefile.am:
2747 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2748 based on maemo-develoers email from Dirk.
2750 * src/maemo/easysetup/modest-easysetup-wizard.c:
2751 (create_page_welcome), (create_page_account_details),
2752 (create_page_user_details), (create_page_complete_easysetup),
2753 (create_page_custom_incoming), (create_page_custom_outgoing),
2754 (create_page_complete_custom),
2755 (modest_easysetup_wizard_dialog_init):
2756 * src/maemo/modest-account-settings-dialog.c:
2757 (create_page_account_details), (create_page_user_details),
2758 (create_page_incoming), (create_page_outgoing),
2759 (modest_account_settings_dialog_init):
2760 * src/maemo/modest-connection-specific-smtp-window.c:
2761 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2763 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2765 * src/maemo/easysetup/modest-easysetup-wizard.c:
2766 (create_page_account_details), (create_page_custom_outgoing),
2767 (create_page_complete_custom):
2768 * src/maemo/modest-account-settings-dialog.c:
2769 (create_page_user_details), (create_page_incoming),
2770 (create_page_outgoing):
2771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2772 (modest_connection_specific_smtp_edit_window_init):
2773 Use the correct (UI spec) port min/max, and use horizontal separators,
2776 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2778 * src/maemo/easysetup/modest-easysetup-wizard.c:
2779 (set_default_custom_servernames):
2780 * src/maemo/modest-account-settings-dialog.c:
2781 (create_page_incoming), (on_combo_outgoing_security_changed),
2782 (on_combo_incoming_security_changed), (create_page_outgoing),
2783 (modest_account_settings_dialog_set_account_name),
2784 (save_configuration):
2785 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2786 (on_combo_security_changed),
2787 (modest_connection_specific_smtp_edit_window_init),
2788 (modest_connection_specific_smtp_edit_window_set_connection),
2789 (modest_connection_specific_smtp_edit_window_get_settings):
2790 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2793 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/easysetup/modest-easysetup-wizard.c:
2797 (create_page_custom_outgoing), (create_page_complete_custom):
2798 * src/maemo/modest-account-settings-dialog.c:
2799 (create_page_user_details), (create_page_outgoing):
2800 * src/maemo/modest-account-view-window.c: (button_box_new):
2801 Use changed logical IDs as per the most recent UI spec:
2802 mcen_bd_emailsetup_edit -> mcen_bd_edit
2803 mcen_bd_emailsetup_delete -> mcen_bd_delete
2804 mcen_bd_emailsetup_close -> mcen_bd_close
2806 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2810 * src/dbus_api/Makefile.am:
2811 * src/dbus_api/modest-dbus-callbacks.c:
2812 * src/dbus_api/modest-dbus-callbacks.h:
2813 * src/maemo/modest-platform.c: (modest_platform_init):
2814 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2816 * tests/Makefile.am:
2817 * tests/dbus_api/Makefile.am:
2818 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2820 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2822 * src/maemo/modest-account-settings-dialog.c:
2823 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2824 Removed unnecessary includes.
2826 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/easysetup/modest-easysetup-wizard.c:
2829 * src/maemo/modest-account-settings-dialog.c:
2830 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2831 * src/widgets/Makefile.am:
2832 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2833 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2834 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2835 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2836 * src/widgets/modest-secureauth-combo-box.c:
2837 * src/widgets/modest-secureauth-combo-box.h:
2838 * src/widgets/modest-serversecurity-combo-box.c:
2839 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2840 made the GObject names more consistent with the rest of the Modest code.
2842 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/easysetup/Makefile.am:
2845 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2846 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2847 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2848 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2849 * src/maemo/easysetup/modest-easysetup-wizard.c:
2850 * src/maemo/easysetup/modest-validating-entry.c:
2851 * src/maemo/easysetup/modest-validating-entry.h:
2852 * src/maemo/modest-account-settings-dialog.c:
2853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2854 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2855 widgets/ because they are used outside of easysetup too. After checking in,
2856 svn will allow me to rename them too.
2858 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2860 * src/gnome/modest-msg-edit-window.c:
2861 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2862 linker error, to fix the build on the GNOME platform.
2863 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2864 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2865 ifdefed out to avoid a warning.
2867 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2869 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2870 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2871 some alternative for GTK+ 2.6.
2873 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2875 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2877 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2878 specified for EmailAccountsDialog in UI spec.
2880 * src/maemo/easysetup/modest-easysetup-wizard.c:
2881 * src/maemo/easysetup/modest-easysetup-wizard.h:
2882 * src/maemo/modest-account-settings-dialog.c:
2883 * src/maemo/modest-account-settings-dialog.h:
2884 Reuse a member window widget for the connection-specific SMTP server accounts,
2885 so we can tell it to create/save the accounts only if we actually save changes.
2887 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2889 (modest_connection_specific_smtp_edit_window_get_settings):
2890 Return a struct instance for temporarily remembering the entered data.
2892 * src/maemo/modest-connection-specific-smtp-window.h:
2893 * src/maemo/modest-connection-specific-smtp-window.c:
2894 (modest_connection_specific_smtp_window_finalize),
2895 (modest_connection_specific_smtp_window_fill_with_connections),
2897 (modest_connection_specific_smtp_window_save_server_accounts),
2898 (update_model_server_names): Do not actually save data until asked,
2899 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2901 (on_selection_changed),
2902 (modest_connection_specific_smtp_window_init): Disable the edit
2903 button when nothing is selected.
2905 * src/modest-account-mgr-helpers.c:
2906 * src/modest-account-mgr-helpers.h:
2907 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2910 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2912 * src/modest-account-mgr-helpers.h:
2913 * src/modest-account-mgr-helpers.c:
2914 (modest_account_mgr_get_unused_account_name),
2915 (modest_account_mgr_get_unused_account_display_name): Added these
2916 utility functions, to avoid code duplication.
2918 * src/maemo/easysetup/modest-easysetup-wizard.c:
2919 (create_page_account_details), (create_account):
2920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2921 (on_combo_security_changed),
2922 (modest_connection_specific_smtp_edit_window_init),
2923 (modest_connection_specific_smtp_edit_window_save_settings):
2924 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2925 * src/maemo/modest-connection-specific-smtp-window.c:
2926 (modest_connection_specific_smtp_window_finalize),
2927 (modest_connection_specific_smtp_window_fill_with_connections),
2928 (on_button_edit), (modest_connection_specific_smtp_window_init):
2929 * src/maemo/modest-connection-specific-smtp-window.h:
2930 Implementing saving of connection-specific server accounts.
2932 But I need to refactor this so we can save the data for each
2933 possible connection-specific account and only actually create the server accounts
2934 when the easysetup finished, or the OK button is pressed on the account settings
2937 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2939 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2940 (on_combo_security_changed):
2941 (modest_connection_specific_smtp_edit_window_init):
2942 Auto-fill the port number as in the account settings.
2944 (modest_connection_specific_smtp_edit_window_set_connection):
2945 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2946 * src/maemo/modest-connection-specific-smtp-window.c:
2947 (fill_with_connections), (on_button_edit),
2948 (modest_connection_specific_smtp_window_init):
2949 Turn the edit window into a dialog to simplify the code, and
2950 set a WM hint as in a GtkDialog, because only a popup can be on top of
2951 another window in Maemo, and popups usually have no WM decoration.
2953 * src/modest-defs.h:
2954 * src/modest-account-mgr-helpers.c:
2955 (modest_account_mgr_set_connection_specific_smtp),
2956 (modest_account_mgr_remove_connection_specific_smtp),
2957 (modest_account_mgr_get_connection_specific_smtp):
2958 * src/modest-account-mgr-helpers.h: Some functions to write the
2959 connection-specific SMTP server information. Not yet used.
2962 * src/widgets/modest-folder-view.c: (text_cell_data):
2963 Fix a warning about an uninitialized variable.
2964 (on_configuration_key_changed): Put an #ifdef around the use
2965 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2967 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/modest-account-settings-dialog.h:
2970 * src/maemo/modest-account-settings-dialog.c:
2971 Added connect_for_modified() utility function to mark the new modified boolean.
2973 (create_page_account_details), (create_page_user_details),
2974 (create_page_incoming), (create_page_outgoing), (on_response),
2975 (modest_account_settings_dialog_init),
2976 (modest_account_settings_dialog_set_account_name):
2977 Only warn about unsaved changes when there are actually unsaved changes.
2979 * src/modest-account-mgr-helpers.c:
2980 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2981 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2982 to get the data from there in future.
2984 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2986 * src/modest-defs.h:
2988 * src/modest-account-mgr-helpers.h:
2989 * src/modest-account-mgr-helpers.c:
2990 Store the security account setting in a single conf key instead of using
2991 the options list, so that the list is left for just the to-be-removed camel hack,
2992 and because gconf_client_set_list() is failing for some reason.
2994 * src/modest-account-mgr.c:
2995 (modest_account_mgr_add_server_account):
2996 * src/maemo/modest-account-settings-dialog.c:
2997 (modest_account_settings_dialog_set_account_name),
2998 (save_configuration): Use the renamed functions.
3001 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3003 * src/widgets/Makefile.am:
3004 * src/widgets/modest-limit-retrieve-combo-box.c:
3005 * src/widgets/modest-limit-retrieve-combo-box.h:
3006 * src/widgets/modest-retrieve-combo-box.c:
3007 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3008 the account settings dialog.
3010 * src/modest-defs.h:
3011 * src/modest-account-mgr-helpers.h:
3012 * src/modest-account-mgr-helpers.c:
3013 (modest_server_account_get_option_secure_auth),
3014 (modest_server_account_set_option_secure_auth):
3015 * src/modest-account-mgr.c:
3016 (modest_account_mgr_add_server_account):
3017 Use the existing AUTH_MECH conf key for the secure-auth setting,
3018 instead of putting it in the list options, because this was actually used already.
3020 * src/maemo/modest-account-settings-dialog.c:
3021 (create_page_account_details),
3022 (modest_account_settings_dialog_set_account_name),
3023 (save_configuration):
3024 * src/maemo/modest-account-settings-dialog.h:
3025 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3026 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3028 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3030 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3031 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3032 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3034 * src/modest-defs.h:
3035 * src/maemo/modest-account-settings-dialog.c:
3036 (create_page_incoming), (on_combo_outgoing_security_changed),
3037 (on_combo_incoming_security_changed), (create_page_outgoing),
3038 (modest_account_settings_dialog_set_account_name),
3039 (save_configuration): Load/Save the port number, and change it when the
3040 security combo changes, to suitable defaults.
3042 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3044 * src/modest-account-mgr.c:
3045 (modest_account_mgr_add_server_account): Set the security and secure-auth
3046 options, and add a comment saying that the other camel-specific options should be
3049 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3051 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3053 * src/modest-tny-account-store.c: (account_list_free),
3054 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3055 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3058 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-protocol-info.c:
3061 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3062 is required by our UI spec. Maybe something in our implementation will use this eventually.
3063 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3064 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3065 instead of the previous 0 placeholder.
3067 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3068 secure-auth settings.
3069 * src/modest-account-mgr-helpers.h:
3070 * src/modest-account-mgr-helpers.c:
3071 (modest_server_account_data_get_option_secure_auth),
3072 (modest_server_account_set_option_secure_auth),
3073 (modest_server_account_data_get_option_security),
3074 (modest_server_account_set_option_security): Added this API for getting and setting the security
3075 and secure-auth settings.
3077 * src/maemo/modest-account-settings-dialog.h:
3078 * src/maemo/modest-account-settings-dialog.c:
3079 (modest_account_settings_dialog_finalize), (check_data),
3080 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3081 about changing titles.
3082 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3083 (save_configuration): Save the security and secure-auth settings.
3085 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3086 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3088 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3090 * src/modest-defs.h:
3091 * src/modest-account-mgr.c:
3092 (modest_account_mgr_add_server_account):
3093 Added and used defines for the options key and value pair strings,
3094 that are used so far, though they do not seem to correspond to anything in our
3095 UI specs or ModestProtocol enum.
3097 * src/modest-account-mgr-helpers.h:
3098 * src/modest-account-mgr-helpers.c:
3099 (compare_option_strings_for_name),
3100 (modest_server_account_data_get_option_value),
3101 (modest_server_account_data_get_option_bool),
3102 (modest_account_mgr_get_server_account_option):
3103 Added helper functions for parsing the options GSList.
3105 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3108 display name is based on the supplied account name.
3109 * src/modest-account-mgr.c:
3110 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3111 with an inefficient, but good-enough, implementation.
3113 * src/maemo/easysetup/modest-easysetup-wizard.c:
3114 (create_page_account_details), (on_before_next), (create_account):
3115 Check for existing display names rather than (non-user-visible) account names, and just
3116 create and set a unique account name at the end.
3118 * src/maemo/modest-account-settings-dialog.c:
3119 (modest_account_settings_dialog_init),
3120 (modest_account_settings_dialog_set_account_name),
3121 (create_page_incoming): Show the display name, instead of the account name.
3122 (on_response): Do some (not all) extra checks, as in the UI spec.
3123 (save_configuration): Save the display name if it was changed.
3125 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3127 * po/en_GB.po: Added needed logical ID and translation.
3128 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3129 (init_view): Made the is-default column clicking work.
3131 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3134 * src/maemo/easysetup/Makefile.am:
3135 * src/maemo/easysetup/modest-easysetup-wizard.c:
3136 (modest_easysetup_wizard_dialog_init):
3137 * src/maemo/easysetup/provider-data-test.keyfile:
3138 * src/maemo/easysetup/provider-data.keyfile:
3139 Moved the provider data file to the new modest-providers-data package and used it from there.
3141 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-local-folder-info.c:
3144 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3145 N_() was already used on the static strings, but this just marks it for translation without
3146 using the translation.
3148 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/modest-account-settings-dialog.c:
3151 (create_page_incoming),
3152 (modest_account_settings_dialog_set_account_name):
3153 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3154 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3155 I will do this if nobody else gets there first.
3157 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3159 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3160 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3161 save the security stuff.
3163 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3165 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3166 Set the email address and user fullname, which I now see must be
3169 * src/maemo/modest-account-settings-dialog.h:
3170 * src/maemo/modest-account-settings-dialog.c:
3172 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3173 leave-on-server and authentication.
3174 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3177 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3180 * src/maemo/modest-account-settings-dialog.c:
3181 * src/maemo/modest-account-settings-dialog.h:
3182 Most (but not all) of the widgets are now present as specified by the UI spec.
3183 No changes are yet saved, and some details are not properly shown yet.
3185 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3187 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/Makefile.am:
3190 * src/maemo/modest-account-settings-dialog.c:
3191 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3192 an existing account. Doesn't do much yet.
3194 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3195 Open the accounts settings dialog when Edit is clicked.
3197 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3199 * src/maemo/easysetup/Makefile.am:
3200 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3202 * src/maemo/easysetup/modest-easysetup-wizard.c:
3203 (modest_easysetup_wizard_dialog_init):
3204 Try to get the source directory from the build system,
3205 instead of hard-coding "./" into the source code, when opening our local
3206 copies of the configuration files.
3207 But this still fails when opening the wizard from the Accounts window,
3208 maybe because the working directory seems to change at runtime.
3209 So the wizard will fail the second time unless you copy the files into their
3210 proper locations - see the stdout warnings for the paths.
3212 (create_page_account_details),(on_before_next):
3213 Check for existing non-server accounts instead of server accounts,
3214 so the default account name is useful again, and to prevent trying to
3217 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3218 Show the wizard when New is clicked.
3220 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3221 (init_view): Show the column headers, and show the columns that are
3222 specified in the UI specs. However, something in Maemo's GTK+ prevents
3223 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3224 change the default account. This is despite unsetting the special properties.
3226 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3228 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3229 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3230 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3231 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3232 to make that clearer.
3233 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3235 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3237 * src/maemo/modest-account-view-window.c:
3238 (modest_account_view_window_init),
3239 (modest_account_view_window_new):
3240 Use the same buttons as specified in the
3241 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3242 the existing widgets, which never had a chance of working.
3243 Put the ModestAccountView treeview in a scrolled window.
3244 Do not repeat the initialization in both _init() and _new().
3246 * src/widgets/modest-account-view.c: (update_account_view):
3247 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3248 this widget and window shows no accounts.
3250 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3254 * src/maemo/easysetup/modest-easysetup-wizard.c:
3255 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3256 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3257 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3260 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3261 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3262 accounts exist yet, as in the UI spec.
3264 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3266 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3268 * src/maemo/Makefile.am:
3269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3270 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3271 New window for editing connection-specific smtp details.
3272 Not fully implemented.
3274 * src/maemo/modest-connection-specific-smtp-window.c:
3275 (modest_connection_specific_smtp_window_finalize) :
3276 unref the tree model.
3277 (on_button_edit): Show the edit window.
3279 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3281 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3284 * src/maemo/Makefile.am:
3285 * src/maemo/modest-connection-specific-smtp-window.c:
3286 * src/maemo/modest-connection-specific-smtp-window.h:
3287 New window for showing the list of connections, for connection-specific
3288 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3289 * src/maemo/easysetup/modest-easysetup-wizard.c:
3290 (create_page_custom_outgoing): Show the new window when the button is clicked.
3292 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3294 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3295 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3296 * src/maemo/modest-msg-edit-window.c:
3297 (modest_msg_edit_window_insert_image):
3298 * src/modest-conf.c: (modest_conf_key_escape):
3299 * src/modest-mail-operation.c:
3300 (modest_mail_operation_send_new_mail):
3301 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3302 (modest_ui_actions_on_new_account):
3303 * src/widgets/modest-attachment-view.c: (update_filename_request):
3304 * src/widgets/modest-mail-header-view.c:
3305 Corrected warnings that were breaking the build, by commenting out unused variables,
3306 and a function, and by including a header.
3308 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3310 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3311 so we can #ifdef around platform-specific code when necessary.
3312 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3313 to allow this to build for the GNOME platform too.
3315 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/easysetup/modest-easysetup-wizard.c:
3318 Added util_increment_name() and used it in create_page_account_details()
3319 to make sure that the default account name is always a new name.
3321 (modest_easysetup_wizard_dialog_init),
3322 (set_default_custom_servernames): Some minor memory management fixes.
3324 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3328 * src/modest-runtime.c: (init_i18n): Restored the translation
3329 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3330 are defined in config.h, and the translations are installed.
3332 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3333 is defined for translation.
3335 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3337 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3339 * src/maemo/easysetup/modest-easysetup-wizard.c:
3340 (modest_easysetup_wizard_dialog_init):
3341 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3342 Use realistic paths (though they should use $prefix generically) to the
3343 mcc_mapping and provider-data.keyfile files which might work when they
3344 are installed by the future version of the operator-wizard package,
3345 and then fallback to paths in our source code, with an explanatory
3348 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3352 * src/maemo/Makefile.am:
3353 * src/maemo/easysetup/: Added files from the previously-exernal
3354 osso-modest-easysetup.
3355 * src/maemo/modest-main-window-ui.h:
3356 * src/modest-ui-actions.c:
3357 * src/modest-ui-actions.h:
3358 Added modest_ui_actions_on_new_account() as a signal handler for the
3359 New Account menu item. It shows the easysetup wizard.
3360 * po/en_GB.po: Added additional needed logical IDs and translations.