1 2007-08-29 Armin Burgmeier <armin@openismus.com>
3 * src/modest-protocol-info.h:
4 * src/modest-protocol-info.c: Added
5 modest_protocol_info_get_auth_protocol() to translate an
6 authentication protocol name to the corresponding enum value.
8 * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
9 generation using the newly added function.
11 * src/maemo/modest-account-settings-dialog.c: Use the current element
12 when traversing through the list of supported authentication methods,
15 2007-08-29 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/easysetup/modest-easysetup-wizard.c:
18 (check_first_supported_auth_method), (on_before_next),
20 * src/maemo/modest-account-settings-dialog.c: (check_data):
21 Some cleanup, to make the code clearer.
23 2007-08-29 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
26 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
27 logical ID when the secure authentication method is not supported by
28 the server, as requested by Mox on the wiki, though I hate not
29 giving the user the clue.
31 2007-08-29 Murray Cumming <murrayc@murrayc.com>
33 * src/modest-search.c: (modest_search_all_accounts):
34 * src/modest-platform.h:
35 * src/maemo/modest-platform.c: Moved and renamed
36 check_and_wait_for_account_is_online() to
37 modest_platform_check_and_wait_for_account_is_online() so it
38 can be used in more places.
40 2007-08-29 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
43 Removed the sleep(1) experiment because it does not seem to help,
44 and I should not have checked the experiment in anyway.
45 The problem is maybe in the TnyAccount connected state - I will
46 investigate that instead.
48 2007-08-28 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
51 Added a sleep(1) in case it helps with bug #66769.
53 2007-08-28 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-search.c: (on_timeout_check_account_is_online),
56 (check_and_wait_for_account_is_online):
57 It is OK for local-folder and mmc accounts to be used when they
58 are in the _INIT folder, instead of waiting for them to change
60 For POP and IMAP, wait from them to stop being _INIT, rather than
61 waiting from them to be _CONNECTED, because that seems to be
62 the status that causes the problems.
64 2007-08-28 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-search.c: (check_and_wait_for_account_is_online):
67 Actually pass the account to the timeout callback.
69 2007-08-28 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-search.c: (on_timeout_check_account_is_online):
72 Added some debug output to help me debug a problem on the N800.
73 (check_and_wait_for_account_is_online): Fail immediately if the
75 modest_search_all_accounts(): Try the search even if the account does
76 not seem to be online, because this can work sometimes, and should work
77 with the cache if there is no active libconic connection.
79 2007-08-27 Armin Burgmeier <armin@openismus.com>
81 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
82 observe outbox for added messages to assign them a status. Previously,
83 this was done in modest_tny_send_queue_add(), but the message id might
84 not yet be known at that point. This reduces warnings when sending
85 mail, though I am not sure how this even worked before.
87 2007-08-27 Murray Cumming <murrayc@murrayc.com>
89 * src/maemo/modest-account-settings-dialog.c:
90 (modest_account_settings_dialog_init):
91 * src/maemo/modest-connection-specific-smtp-edit-window.c:
92 (modest_connection_specific_smtp_edit_window_init):
93 * src/maemo/modest-connection-specific-smtp-window.c:
94 (modest_connection_specific_smtp_window_init):
95 * src/maemo/modest-maemo-utils.c:
96 (modest_maemo_utils_get_supported_secure_authentication_methods):
97 * src/maemo/modest-platform.c:
98 (modest_platform_run_folder_name_dialog):
99 * src/maemo/modest-signature-editor-dialog.c:
100 (modest_signature_editor_dialog_init):
101 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
102 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
103 * src/widgets/modest-global-settings-dialog.c:
104 (modest_global_settings_dialog_init):
105 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
107 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
108 GTK_STOCK_EDIT with mcen_bd_edit, and
109 GTK_STOCK_CLOSE with mcen_bd_close,
110 to fix projects.maemo.org bug NB#64995.
111 I strongly believe that Maemo's GTK+ should have the wanted translations
112 instead of duplicating this in each application and complicating the code.
114 2007-08-27 Armin Burgmeier <armin@openismus.com>
116 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
117 recursion when entering text in the subject field.
119 2007-08-27 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
122 which checks every second, 10 times, to wait until the account is online
123 so that we can use it, if the account is in the process of going online.
124 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
125 so that searching works even when the application was not yet started before.
126 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
128 2007-08-24 Armin Burgmeier <armin@openismus.com>
130 * src/modest-widget-memory.c: Always show the default account when the
131 application is started, as stated in the UI spec. This fixes
132 projects.maemo.org bug NB#66630.
134 2007-08-24 Armin Burgmeier <armin@openismus.com>
136 * src/maemo/modest-platform.c:
137 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
138 english text for strings in the rename folder dialog, fixing
139 projects.maemo.org bug NB#66338.
141 2007-08-22 Armin Burgmeier <armin@openismus.com>
143 * src/widgets/modest-account-view.c: Fix for bora by using
144 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
145 latter seems not be used anymore.
147 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
150 * src/maemo/modest-main-window.c: Update menu items when the default
151 account changes so that the current default account is always bolded.
152 This fixes maemo.projects.org bug NB#66173.
154 2007-08-17 Murray Cumming <murrayc@murrayc.com>
156 * src/dbus_api/modest-dbus-callbacks.c:
157 (on_dbus_method_get_folders): Avoid trying to get the account name
158 when there are no accounts, to avoid critical g_warnings, fixing
159 projects.maemo.org bug NB#65574.
161 2007-08-17 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
164 Use modest_account_mgr_get_signature() instead of accessing gconf
165 directly, to slightly simplify the code.
166 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
167 Append the signature also when opening via other applications,
168 fixing projects.maemo.org bug NB#65828.
170 2007-08-17 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
173 Check for NULLs to prevent a crash when opening an email that is
174 an attachment in another email, fixing projects.maemo.org bug
177 2007-08-17 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-ui-dimming-rules.c:
180 (modest_ui_dimming_rules_on_view_window_move_to):
181 Enable the Move To toolbar button for search results, fixing the
182 last part of projects.maemo.org bug NB#63807.
184 2007-08-17 Murray Cumming <murrayc@murrayc.com>
186 * src/dbus_api/modest-dbus-callbacks.c:
187 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
188 because this is called from idle handlers, to fix hangs afte the
190 (find_message_by_url): Added a TODO comment about a crash that
191 happens when tinymail was built with DBC checks.
193 2007-08-16 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-search.c: (modest_search_folder):
196 * src/modest-search.h: Rename ModestSearch::before to start_date
197 and after to end_date, using the same names as the libogs struct
199 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
200 The start_date and end_date were swapped in the check. This
201 fixes date range searches, fixing projects.maemo.org bug NB#63407.
203 2007-08-16 Murray Cumming <murrayc@murrayc.com>
205 * src/maemo/modest-account-view-window.c:
206 Added (check_for_active_acount).
207 (on_delete_button_clicked), (on_edit_button_clicked):
208 When an account is doing something (such as refreshing),
209 show the same warning for account deletion as for account
210 editing, to fix projects.maemo.org bug NB#64588.
212 2007-08-16 Murray Cumming <murrayc@murrayc.com>
214 * src/widgets/modest-msg-view-window.h:
215 * src/gnome/modest-msg-view-window.c:
216 * src/maemo/modest-msg-view-window.c:
217 Added modest_msg_view_window_construct().
218 (modest_msg_view_window_new_with_header_model),
219 Added modest_msg_view_window_new_for_search_result),
220 Renamed modest_msg_view_window_new() to
221 modest_msg_view_window_new_for_attachment(),
222 and modest_msg_view_window_is_search_result(),
223 so we can explicitly know that the window is for an
224 attachment or a search result or a message from the list.
226 (modest_msg_view_window_view_attachment):
227 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
228 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
229 Use modest_msg_view_window_new_for_search_result().
231 * src/modest-ui-dimming-rules.c:
232 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
233 for search results, fixing projects.maemo.org bug NB#63811.
235 2007-08-16 Armin Burgmeier <armin@openismus.com>
237 * src/modest-ui-actions.c: Show a banner instead of a dialog when
238 renaming a folder fails, to stay consistent with what happens when
239 creating a folder fails.
241 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
242 slightly country loading from the mmc_mappings file, fixed a memory
245 2007-08-16 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-tny-account-store.c: (volume_path_is_mounted):
248 Check the GnomeVFSVolume activation path instead of the device path,
249 so that the memory card is really really shown in the UI.
251 2007-08-16 Murray Cumming <murrayc@murrayc.com>
253 * src/maemo/easysetup/modest-easysetup-wizard.c:
254 (get_entered_account_title), (on_before_next), (entry_is_empty),
256 * src/maemo/modest-account-settings-dialog.c:
257 (get_entered_account_title), (on_button_signature), (check_data),
258 (save_configuration), (entry_is_empty):
259 Strip the account title of whitespace at the start and end before
260 using it or checking it. This means that an all-whitespace title
261 is not allowed, fixing projects.maemo.org bug NB#64977.
263 2007-08-15 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-ui-actions.h:
266 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
267 to modest_run_account_setup_wizard() and made it public.
268 * src/dbus_api/modest-dbus-callbacks.c:
269 (check_and_offer_account_creation), (on_idle_mail_to),
270 (on_idle_compose_mail), (on_idle_open_default_inbox):
271 Offer account creation if necessary, fixing projects.maemo.org
274 2007-08-15 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-ui-actions.c: (run_account_setup_wizard):
277 Return a gboolean to indicate success.
278 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
279 (modest_ui_actions_on_send): When offering account creation, only
280 give up (return) if account creation failed. Otherwise continue
281 with the original request. This fixed projects.maemo.org bug
284 2007-08-15 Murray Cumming <murrayc@murrayc.com>
286 * src/widgets/modest-recpt-editor.c:
287 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
288 to fix projects.maemo.org bug NB#63789.
290 2007-08-15 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
293 (modest_tny_account_store_new): Properly detect the memory card at
294 startup, and add an account for it.
296 2007-08-14 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
299 Commented out the MMC code again because it mistakenly detects
300 the card even when it isn't inserted.
302 2007-08-14 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
305 Renabled the call to add_mmc_account() because I do not believe
306 it could be the cause of the mentioned hang (in scratchbox, where
307 there is no memory card), and because I have tested that it works
310 2007-08-14 Murray Cumming <murrayc@murrayc.com>
312 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
313 Comment out part of the last commit because it apparently causes
316 2007-08-14 Murray Cumming <murrayc@murrayc.com>
318 * src/modest-tny-account-store.c: Added the add_mmc_account()
319 function to save some copy/pasting.
320 (modest_tny_account_store_new): If the memory card is mounted,
321 create an account for it at the start, instead of waiting for the
322 user to unmount it and mount it.
324 2007-08-13 Murray Cumming <murrayc@murrayc.com>
326 * src/widgets/modest-account-view.c: (on_account_changed):
327 Do not try to use the human-readable TnyAccount name instead of the
328 ID of the modest account to get the transport account. And unref
329 the transport account. This prevents a g_warning(), and a possible
332 2007-08-13 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/modest-platform.c:
335 (modest_platform_set_update_interval): Handle the new
336 alarmd error to warn when alarmd is not running, as is the case in
337 scratchbox for me now because
338 "Module /usr/lib/alarmd/libretu.so initialization failed"
340 2007-08-13 Murray Cumming <murrayc@murrayc.com>
342 * src/widgets/modest-header-view-render.c:
343 (_modest_header_view_compact_header_cell_data):
344 NULL some strings after freeing them, trying to deal with
345 the double deletion found in projects.maemo.org bug 64183,
346 probably having no effect.
348 2007-08-13 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/modest-account-settings-dialog.c:
351 (create_page_incoming), (create_page_outgoing): Use a define
352 for the min and max port numbers.
354 (check_hildon_number_editor_and_warn_value_not_in_range),
355 (check_data): Do an extra check for an invalid port number, as needed
356 in projects.maemo.org bug #64275, when the number is cleared, but this
357 does not work due to bugs.maemo.org bug #1806.
359 2007-08-13 Murray Cumming <murrayc@murrayc.com>
361 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
362 Comment out the debug warning about the unexpected D-Bus methods.
363 They are just annoying now.
364 * src/maemo/modest-platform.c:
365 (modest_platform_set_update_interval): Correct the D-Bus path, instead
366 of using a file path, though it did not seem to break things before.
367 It might be needed now:
368 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
369 modest is not already running. This is the behaviour of the old client, and
370 Mox says it is what we should do for modest.
371 This closes projects.maemo.org bug NB#64327.
373 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
375 * src/modest-text-utils.c:
376 Fixed invalid jump due to incorrect string/pointer
378 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
381 2007-08-01 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-account-mgr-helpers.h:
384 * src/modest-account-mgr-helpers.c:
385 Added modest_account_mgr_get_first_account_name(),
386 using code from modest_account_mgr_set_first_account_as_default().
388 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
389 (account_number_changed): Call set_at_least_one_account_visible() so that
390 the first account is visible when first added, without the user having to
392 I do wonder how this worked before.
394 2007-08-01 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-tny-account-store.c: (show_password_warning_only),
397 (show_wrong_password), (request_password_and_wait), (get_password),
398 (modest_tny_account_store_alert): Remove the (incomplete anyway)
399 attempts to show UI only in the main context, which used g_idle_add()
400 and mainloops, because tinymail now guarantees that it only calls these
401 callbacks in the mainloop with the gdk lock. This makes everything much
404 2007-08-01 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
407 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
408 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
409 error dialog, instead of ignoring it.
411 2007-08-01 Murray Cumming <murrayc@murrayc.com>
413 * src/maemo/modest-msg-view-window.c:
414 (modest_msg_view_window_get_header),
415 (modest_msg_view_window_last_message_selected):
416 Added comments to explain the use of priv->header_model.
417 * src/modest-ui-dimming-rules.c:
418 (modest_ui_dimming_rules_on_open_msg),
419 (modest_ui_dimming_rules_on_mark_as_read_msg),
420 (modest_ui_dimming_rules_on_mark_as_unread_msg),
421 (modest_ui_dimming_rules_on_remove_attachments),
422 (_invalid_attach_selected), (_selected_msg_marked_as):
423 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
424 and changed the parameter to a ModestMainWindow to make it clearer that
425 it never uses any other kind of window.
426 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
427 instead of the selected message.
428 I notice that much of the dimming code and the ModestMsgViewWindow code
429 hard-codes the assumption that the viewed message is always selected in
430 the header view. This does not seem wise or simple.
432 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
433 examine the actual message instead of whatever might be selected
434 in the header view. This stops the delete toolbar button and menu item
435 from being dimmed when opening a message view the search UI,
436 partially fixing projects.maemo.org bug NB#63811.
438 However, when actually deleting, I now get this warning:
439 "tny_header_set_flags: This is a header instance for a new message.
440 Only priority and attachment flags are supported"
442 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
444 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
446 Show account wizard if no accounts are defined while sending
447 (automatic sending after the account wizard finished does not
448 work because it takes some time until the account manager
449 synchronizes everything. (projects.maemo.org NB#62792)
451 2007-07-30 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-tny-account-store.c: (on_account_removed),
454 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
455 account is removed from the View menu. We have TnyAccountStore
456 and ModestTnyAccountStore signals that seem very similar, but this
457 seems to work for now.
459 * src/maemo/modest-main-window.c:
460 (on_show_account_action_activated): Prevent dereference
461 of a NULL if the accoutn does not really exist, though that
462 should not happen anymore.
464 This fixes projects.maemo.org bug NB#64606.
466 2007-07-30 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-ui-actions.c: (run_account_setup_wizard),
469 (modest_ui_actions_on_accounts): Revert a change that set these
470 to modal dialogs, freezing the UI when they show secondary dialogs.
471 This fixed projects.maemo.org bug NB#64519.
473 2007-07-27 Murray Cumming <murrayc@murrayc.com>
475 * src/widgets/modest-header-view-render.c:
476 (_modest_header_view_compact_header_cell_data):
477 Some checks and initialization to try to deal with a crash,
478 probably ineffective.
480 2007-07-27 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/modest-maemo-utils.c:
483 (modest_maemo_utils_get_supported_secure_authentication_methods):
484 Make sure that we have a connection, asking the user for one
486 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
487 Check for a connection before showing the wizard, because
488 the wizard needs a connection to check for server capabilities.
490 2007-07-27 Murray Cumming <murrayc@murrayc.com>
492 * src/maemo/modest-account-view-window.c:
493 (on_new_button_clicked): Remember the wizard dialog instance,
494 so we can just present it again if necessary. This prevents
495 multiple windows from appearing if you click again quickly on the
496 New button before the dialog appears, fixing projects.maemo.org
499 2007-07-27 Murray Cumming <murrayc@murrayc.com>
501 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
502 Offer a connection dialog if there is no connection when
503 starting modest. This should fix projects.maemo.org bug NB#61134.
505 2007-07-27 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
508 Reverted my last commit. I was able to fix the build by doing
509 apt-get install wpeditor0 (replacing other wpeditor packages) and
510 an explicit apt-get install wpeditor-dev to upgrade the -dev
513 2007-07-27 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
516 Commented out the use of wp_text_buffer_replace_image()
517 because it does not exist, to break the build. Added a TODO for it.
519 2007-07-26 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-tny-account-store.c: (recreate_all_accounts):
522 Recreate them even if they were NULL before. I guess something
523 else was already creating them before, or this would never
525 (modest_tny_account_store_get_server_account): Make sure that
526 the tny accounts have been created before trying to find one.
527 This allows libmodest_dbus_client_compose_mail() to work
528 when the UI is not yet visible.
529 This is probably useful in other cases too.
531 (get_password): When the password is wrong after it is entered
532 in the protected password dialog, show an info banner (in an
533 idle handler) before showing the protected password dialog
536 2007-07-26 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-ui-actions.h:
539 * src/modest-ui-actions.c: Added
540 modest_do_refresh_current_folder() containing some code from
541 modest_ui_actions_on_send_receive().
542 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
543 Call modest_do_refresh_current_folder() before refreshing the
544 requested account, as in modest_ui_actions_on_send_receive().
545 This is strange, but seems to be necessary to show new mails.
546 Now new emails are finally visible in the UI when downloaded
547 via the automatic update interval, fixing bug NB#57458.
548 This also works because bug NB#57458 has been fixed somehow.
550 2007-07-26 Murray Cumming <murrayc@murrayc.com>
552 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
553 printf more details when we get unhandled D-Bus methods, because
556 * src/modest-mail-operation.c: (update_account_thread):
557 Comment out the tny_camel_pop_store_account_reconnect(), because this
558 is apparently no longer needed, and it did not work before anyway.
559 See the comment in the code.
561 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
562 by checking the header flags. This fixes projects.maemo.org bug
565 2007-07-25 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/modest-maemo-utils.h:
568 * src/maemo/modest-maemo-utils.c: Added
569 modest_maemo_show_information_note_in_main_context_and_forget().
570 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
571 Use the new function to show simple error dialogs in the main
572 context, though question dialogs are still in the current context,
573 which is unfortunately usually not the main context. This should
576 2007-07-25 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-tny-account-store.c: (get_password):
579 Never save the entered username and password in gconf,
580 because the UI spec says we should not. This helps
581 slightly with projects.maemo.org bug NB#63671.
583 2007-07-25 Murray Cumming <murrayc@murrayc.com>
585 * src/widgets/modest-msg-edit-window.h:
586 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
587 Moved some code here to make it simpler.
588 (modest_msg_edit_window_attach_file_one): Renamed from
589 modest_msg_edit_window_attach_file_interactive().
590 (modest_msg_edit_window_offer_attach_file): Renamed from
591 modest_msg_edit_window_attach_file() and used
592 modest_msg_edit_window_attach_file_one() instead of
593 copy/pasting the code. The old code for one was not using
594 GnomeVFS. This allows use of smb:// URLs when using send-as
595 from external applications, fixing bug NB#63741.
597 (modest_msg_edit_window_insert_image),
598 (modest_msg_edit_window_add_attachment_clicked):
599 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
600 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
601 Adapted to the new function names.
603 2007-07-25 Murray Cumming <murrayc@murrayc.com>
605 (modest_platform_set_update_interval): Set the alarm recurrence
606 fields so that auto-update does not just happen the first time.
607 This should have fixed projects.maemo.org bug NB#63938.
609 When this happens you can see a printf when the D-Bus method is
611 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
613 However, I do not actually seem to get new POP messages even when
614 clicking the refresh button manually. A restart gets them.
615 This might be a problem in today's tinymail only.
617 2007-07-24 Murray Cumming <murrayc@murrayc.com>
619 * src/maemo/modest-maemo-global-settings-dialog.c:
620 (current_connection):
621 Avoid a crash (probably only in scratchbox) when strcmp()ing a
622 NULL when closing the dialog.
624 2007-07-24 Murray Cumming <murrayc@murrayc.com>
626 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
627 Remove the hacky send/receive that didn't work, and instead
628 refilter the treemodel to make the deleted email really vanish from
629 the UI (though the delete-from-menu code does has commented out
630 the code that does that). This fixes projects.maemo.org bug
633 2007-07-24 Murray Cumming <murrayc@murrayc.com>
635 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
636 Try a couple of tricks to force the treeview to update (
637 poke the folder, and do a send/receive refresh), but the deleted
638 email still appears with a strike-through instead of really being
641 2007-07-23 Murray Cumming <murrayc@murrayc.com>
643 * src/dbus_api/modest-dbus-callbacks.c:
644 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
645 because their ID is not human-readable (see the comment about
646 improvements needed to the osso-email-interface API) and
647 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
649 2007-07-23 Murray Cumming <murrayc@murrayc.com>
651 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
652 (add_folders_to_list), (on_dbus_method_get_folders),
653 (modest_dbus_req_filter):
654 * src/maemo/modest-maemo-utils.c:
655 (on_camel_account_get_supported_secure_authentication):
656 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
657 (on_header_view_focus_in):
658 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
659 * src/modest-formatter.c: (modest_formatter_create_body_part):
660 * src/modest-mail-operation.c: (recurse_folders),
661 (update_account_thread), (get_msgs_full_thread),
662 (modest_mail_operation_get_msgs_full),
663 (modest_mail_operation_xfer_msgs):
664 * src/modest-search.c: (search_mime_part_and_child_parts),
665 (modest_search_account), (modest_search_all_accounts):
666 * src/modest-tny-account.c:
667 (modest_tny_account_get_special_folder), (recurse_folders):
668 * src/modest-tny-local-folders-account.c:
669 (modest_tny_local_folders_account_query_passes):
670 * src/modest-tny-msg.c: (copy_mime_part),
671 (modest_tny_msg_find_body_part_from_mime_part):
672 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
673 (modest_tny_send_queue_try_to_send):
674 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
675 (_modest_ui_actions_open), (download_uncached_messages),
676 (reply_forward), (modest_ui_actions_on_copy),
677 (modest_ui_actions_on_details), (has_retrieved_msgs),
678 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
680 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
681 (_selected_msg_marked_as), (_msg_download_completed),
682 (_selected_msg_sent_in_progress):
683 * src/widgets/modest-attachments-view.c:
684 (modest_attachments_view_set_message):
685 * src/widgets/modest-msg-view.c: (find_cid_image):
686 * tests/check_folder-transfer.c: (find_folders):
687 * tests/check_update-account.c: (func):
688 * tests/dbus_api/test_get_folders.c: (main):
689 Checked all uses of tny_iterator_get_current(), making sure
690 that the object is unreferenced (3 or 4 places did not),
691 and adding checks for NULL.
693 2007-07-23 Murray Cumming <murrayc@murrayc.com>
695 * src/dbus_api/modest-dbus-callbacks.c:
696 (on_idle_open_default_inbox): Make sure that the application UI is
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 (on_entry_invalid_character): Show the word whitespace instead
700 of (null) in the banner when whitespace was entered.
701 (show_error): Add a comment that this does not work in
702 Maemo Bora, though we do not know why.
704 2007-07-23 Murray Cumming <murrayc@murrayc.com>
706 * src/modest-tny-account.c:
707 (modest_tny_account_get_special_folder): Use an if instead of
708 an assert for when the parent account name is NULL, because this
709 might be causing a crash in projects.maemo.org bug 63192.
710 * src/modest-mail-operation.c:
711 (modest_mail_operation_send_new_mail_cb),
712 (modest_mail_operation_remove_folder): unref the folder that is
713 returned from modest_tny_account_get_special_folder().
715 2007-07-23 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-ui-actions.c:
718 (modest_ui_actions_on_password_requested):
719 Show mail_ib_login_cancelled info banner when the user cancels
720 the protected password dialog, to fix projects.maemo.org
723 2007-07-23 Murray Cumming <murrayc@murrayc.com>
725 * src/maemo/modest-account-settings-dialog.c:
726 (create_page_outgoing): Put this page in a GtkScrolledWindow,
727 matching the UI mock-up in the UI spec, and allowing access
728 to all widgets even when the on-screen keyboard is active.
730 2007-07-23 Murray Cumming <murrayc@murrayc.com>
732 Reverted this previous commit from Johannes,
733 because the scrollbars are always visible and because
734 I think we only need it on onepage of the account
735 settings, not the account wizard.
736 (I wrote the wrong instructions in the bug.)
738 * src/maemo/easysetup/modest-easysetup-wizard.c:
739 Added scrollbars to account wizard dialog.
740 Fixed projects.maemo.org NB #62744
742 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
744 * src/maemo/easysetup/modest-easysetup-wizard.c:
745 (create_page_user_details):
746 Use auto-cap for name (projects.maemo.org NB#63716)
747 * src/widgets/modest-account-view.c: (on_account_busy_changed):
749 2007-07-22 Armin Burgmeier <armin@openismus.com>
751 * src/maemo/modest-ui-actions.c: Use current account instead of
752 default account for creating viewer windows, so that the viewer
753 window knows to which account the viewed message belongs.
755 * src/maemo/modest-msg-view-window.c: Destroy the window when the
756 corresponding account is deleted. This fixes projects.maemo.org bug
759 2007-07-18 Armin Burgmeier <armin@openismus.com>
761 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
762 the dialog close after entering an invalid port number and clicking
763 OK. This fixes projects.maemo.org bug NB#63602.
765 2007-07-18 Armin Burgmeier <armin@openismus.com>
767 * src/modest-tny-account-store.c:
768 (get_server_accounts): Set parent modest account name for each
769 connection-specific transport account so that special folders of such
770 an account can be looked up. This fixes a crash when changing account
771 settings. This might also be related to projects.maemo.org bug
774 2007-07-16 Armin Burgmeier <armin@openismus.com>
776 * src/modest-ui-actions.c: Added a button to create a folder to the
777 move-to dialog. This fixes projects.maemo.org bug NB#59863.
779 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
781 * src/maemo/easysetup/modest-easysetup-wizard.c:
782 Added scrollbars to account wizard dialog.
783 Fixed projects.maemo.org NB #62744
785 2007-07-16 Murray Cumming <murrayc@murrayc.com>
787 * src/widgets/modest-msg-view.h:
788 * src/widgets/modest-msg-view.c:
789 Added modest_msg_view_get_message_is_empty() but this needs
791 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
792 Check if there is any text in the message yet.
793 But this needs to be implemented properly.
794 (modest_msg_edit_window_toggle_find_toolbar):
795 * src/maemo/modest-msg-view-window.c:
796 (modest_msg_view_window_toggle_find_toolbar):
797 Show a banner warning if there is no text to search, when
798 trying to start a search. This partially fixes
799 projects.maemo.org bug NB#62350.
801 2007-07-13 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-mail-operation.c: (update_account_thread):
804 Initialized num_new_headers to fix the build.
806 2007-07-13 Murray Cumming <murrayc@murrayc.com>
808 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
809 Ignore modest accounts whose server accounts don't exist in gconf.
810 This prevents us trying to create TnyAccount instances for those
811 server accounts when the server account has been removed from gconf,
812 but the parent modest account has not yet been removed from modest.
813 I don't know why this is only noticeable now. It was probably just
814 a harmeless g_warning() anyway.
816 2007-07-13 Murray Cumming <murrayc@murrayc.com>
818 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
819 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
821 2007-07-12 Armin Burgmeier <armin@openismus.com>
823 * src/maemo/modest-main-window.c: Make default account appear bold
824 in view, tools/send & receive and toolbar/send & receive SCM menus.
825 This fixes projects.maemo.org bug NB#59010.
827 2007-07-12 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
830 Add a short-cut, by checking if the folder store is an account.
831 This ensures that the Sort menu item and toolbar is dimmed for
832 the local-folders account root item, fixing
833 projects.maemo.org bug NB#62545.
835 2007-07-12 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account-store.c: (get_password):
838 Show the password dialog (via the signal) only in the mainloop, via
839 an idle handler that we wait for. This could theoretically prevent
840 hangs, though I worry that it could introduce some too.
842 2007-07-12 Murray Cumming <murrayc@murrayc.com>
844 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
845 * src/maemo/modest-platform.c:
846 (modest_platform_connect_and_wait):
847 Take a TnyAccount* parameter and try to set it to online
848 (a TnyCamel-only API), because tinymail sets accounts to offline
849 when the user cancels a password dialog, and doesn't ask again until
850 it has been set to online.
851 However, this is commented out because it causes a hang now.
853 (modest_platform_connect_and_wait_if_network_account):
854 * src/modest-mail-operation.c:
855 (modest_mail_operation_update_account):
856 * src/modest-platform.h:
857 * src/modest-ui-actions.c: (_modest_ui_actions_open),
858 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
860 2007-07-12 Armin Burgmeier <armin@openismus.com>
862 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
864 * src/modest-mail-operation.c:
865 * src/modest-ui-actions.c: Check for already existing folder before
866 querying the server, show error message from camel if the request
867 still fails. This fixes projects.maemo.org bug NB#58701.
869 2007-07-12 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-tny-account-store.h:
872 * src/modest-tny-account-store.c:
873 Added modest_tny_account_store_forget_password_in_memory(),
874 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
875 when creating a new account, so that new passwords will be used, instead of
876 us thinking that it's a second request as a result of a failed password again.
878 2007-07-12 Murray Cumming <murrayc@murrayc.com>
880 * src/dbus_api/modest-dbus-callbacks.c:
881 (on_idle_open_message): If the message is in drafts then open it
882 in an edit window instead of a view window. This fixes
883 projects.maemo.org bug NB#63005.
885 2007-07-12 Murray Cumming <murrayc@murrayc.com>
887 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
888 Avoided a harmless g_warning().
890 2007-07-12 Murray Cumming <murrayc@murrayc.com>
892 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
893 Pass the modest account name, not the TnyAccount display name to
894 modest_msg_view_window_new() so that the reply feature works,
895 fixing projects.maemo.org bug NB#62892.
897 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
898 (modest_msg_view_window_new_with_header_model):
899 * src/maemo/modest-msg-view-window.c:
900 (modest_msg_view_window_new_with_header_model),
901 (modest_msg_view_window_new):
902 * src/modest-ui-actions.c: (reply_forward):
903 * src/widgets/modest-msg-view-window.h:
904 * src/widgets/modest-window.c: (modest_window_set_active_account):
905 Rename an account parameter to modest_account_name to make this clearer.
907 2007-07-11 Murray Cumming <murrayc@murrayc.com>
909 * src/modest-ui-actions.h:
910 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
911 modest_do_message_delete().
912 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
913 Call modest_do_message_delete(), hoping that this would cause messages
914 to be really deleted from search instead of just marked with strike through.
915 Does not seem to help.
917 2007-07-11 Armin Burgmeier <armin@openismus.com>
919 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
920 priv->reselect to FALSE prior to calling
921 modest_folder_view_select_first_inbox_or_local() to prevent endless
922 recursion and thus a crash on startup.
924 2007-07-11 Armin Burgmeier <armin@openismus.com>
926 * src/maemo/modest-account-settings-dialog.h: Include
927 <gtk/gtknotebook.h> to fix the build (at least for me).
929 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
930 Use "New FolderN" as default suggested name if "New folder" already
931 exists, with N being the first free number, though never exceed "New
932 folder99" in which case we just fall back to "New Folder" even though
933 it already exists. This fixes projects.maemo.org bug NB#58663.
935 2007-07-11 Murray Cumming <murrayc@murrayc.com>
937 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
938 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
939 projects.maemo.org bug NB#62778.
941 2007-07-11 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
944 Ignore the wrong (for now) secure-smtp setting in the presets -
945 just default to requiring secure authentication for SMTP, because
948 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
950 * src/widgets/modest-folder-view.c: (filter_row)
951 Do not show drafts folder (see UI specs)
953 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
955 * src/modest-ui-actions.c:
956 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
957 place and also not necessary.
959 * src/widgets/modest-folder-view.c: (filter_row)
960 Guess folder type and hide Sent & Outbox if necessary.
961 Fixed project.maemo.org NB#57328
963 2007-07-11 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-ui-actions.h:
966 * src/modest-ui-actions.c:
967 (modest_ui_actions_on_delete_message):
968 Move some code into a new
969 modest_ui_actions_refresh_message_window_after_delete()
970 function so we can use it from elsewhere.
972 * src/dbus_api/modest-dbus-callbacks.c:
973 (on_idle_delete_message), (on_delete_message): Used an idle
974 handler, as we do for the other D-Bus method handlers.
975 Call modest_ui_actions_refresh_message_window_after_delete()
976 if the deleted message was open in a window. This fixed
977 projects.maemo.org bug NB#62862.
979 2007-07-11 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-main.c: (main): Only show the UI at the start if
982 the showui command line option was given. For instance,
983 run-standalone src/modest showui
984 Otherwise, we wait for the top_application D-Bus method to
985 be sent by hildon-desktop when the application is selected
987 This allows us to run without a UI when osso-global-search
988 uses our D-Bus methods.
990 2007-07-11 Murray Cumming <murrayc@murrayc.com>
992 * src/dbus_api/modest-dbus-api.h: Added a define for a
993 top-application D-Bus method.
994 * src/dbus_api/modest-dbus-callbacks.c:
995 (on_top_application),
996 (modest_dbus_req_handler): Handle the top-application D-Bus
997 method, which might be an undocumented D-Bus signal sent by
998 hildon-desktop when it starts the application from the menu.
999 But I am not sure and I need to test it on the device, because
1000 my scratchbox does not have the application in the menu now.
1001 This method shows the main window, so that it can be invisible
1002 when started, for instance, just for email searching from
1005 * src/maemo/modest-main-window.c: (restore_settings),
1006 (modest_main_window_new): Do not show the window immediately
1007 upon creation. We show it later.
1008 * src/modest-widget-memory.c: (save_settings_paned):
1009 Try (unsuccessfully) to avoid saving the paned position when
1010 it is not even visible.
1011 (restore_settings_paned): Do not allow a silly paned position.
1012 This seems necessary when not showing the window at first.
1014 * tests/dbus_api/Makefile.am:
1015 * tests/dbus_api/test_top_application.c: (main): Test for the
1018 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-ui-dimming-rules.c:
1021 (modest_ui_dimming_rules_on_new_msg),
1022 (modest_ui_dimming_rules_on_reply_msg),
1023 (modest_ui_dimming_rules_on_delete_msg),
1024 (modest_ui_dimming_rules_on_details),
1025 (modest_ui_dimming_rules_on_view_window_move_to),
1026 (modest_ui_dimming_rules_on_view_previous),
1027 (modest_ui_dimming_rules_on_view_next),
1028 (_invalid_folder_for_purge): Added checks before
1029 casting the window. This looks like an actual
1030 logic error in _invalid_folder_for_purge(), because it
1031 tries to use a ModestMainWindow as a message window.
1033 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/modest-account-settings-dialog.c:
1036 (show_error): Use the same implementation as in
1037 modest-easysetup-wizard.c:
1038 (on_entry_invalid_character): The logical ID contains a %s.
1039 Guessed what it should be.
1040 (on_entry_max), (check_data), (on_response): Adapt to
1041 changed show_error().
1042 (create_page_account_details): Really call
1043 modest_validating_entry_set_func() on the correct widgets.
1044 * src/maemo/easysetup/modest-easysetup-wizard.c:
1045 (on_entry_invalid_character): Fix the logical ID here too.
1046 (create_page_account_details),
1047 (create_page_user_details):
1049 modest_validating_entry_set_func() on the correct widgets.
1051 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1052 Do not try to use the account if it is NULL.
1054 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1056 * src/modest-ui-actions.c: (create_move_to_dialog),
1057 (modest_ui_actions_on_main_window_move_to),
1058 (modest_ui_actions_on_msg_view_window_move_to):
1059 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1060 (filter_row), (modest_folder_view_show_non_move_folders):
1061 * src/widgets/modest-folder-view.h:
1063 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1064 the Sent folder yet as it does not report the correct folder type.
1066 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1068 * src/maemo/modest-msg-edit-window.c: (init_window):
1071 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1073 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1074 Take a parent widget instead of a parent window, and
1075 implement this with hildon_banner_show_information() instead.
1076 Non-Maemo builds can just ifdef that there.
1077 This fixed projects.maemo.org bug NB#62766.
1079 (on_entry_invalid_character): Use show_error() again instead
1080 of using hildon directly, and use the _CS() macro to use the correct
1082 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1083 Pass a widget instead od a window to show_error().
1085 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1087 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1088 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1089 This allows us to show the server name in the error message, fixing
1090 projects.maemo.org bug NB#62904.
1091 Also, use the appropriate logical ID message for the account protocol.
1093 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1096 A compilation fix, though the build wasn't broken for me.
1098 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1101 Do not try to unref a NULL folder store, to avoid a runtime warning.
1102 This seems to happen sometimes when changing accounts settings.
1104 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-tny-account-store.c:
1107 (modest_tny_account_store_instance_init),
1108 (modest_tny_account_store_finalize),
1109 (on_account_settings_hide), (on_idle_wrong_password):
1110 Use a GHashTable to ensure that we only show one account settings
1111 dialog per modest account. This avoids us having a dialog open for
1112 both the store and transport accounts, or due to repeated get_password()
1113 calls that shouldn't happen anyway.
1115 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1117 * src/maemo/modest-maemo-utils.c: (on_hide),
1118 (modest_maemo_show_dialog_and_forget): Handle the response, because
1119 the window is not even hidden by default.
1121 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1122 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1123 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1124 which seems to prevent some modality problems.
1126 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1127 Ignore user cancellation errors.
1129 * src/modest-account-mgr-helpers.h:
1130 * src/modest-account-mgr-helpers.c:
1131 Added modest_server_account_get_password() and
1132 modest_server_account_get_has_password() to avoid direct use of
1135 * src/maemo/modest-account-settings-dialog.h:
1136 * src/maemo/modest-account-settings-dialog.c:
1137 (modest_account_settings_dialog_init): Store the notebook so we can
1139 Added modest_account_settings_dialog_switch_to_user_info().
1141 * src/modest-tny-account-store.c:
1142 (get_password): When the password in the account settings is wrong (we think),
1143 show the relevant page of the account settings dialog, in the mainloop.
1144 However, we currently get many of these at once because cancel does not
1146 (forget_password): Do not forget the password
1147 from the account settings, because this causes side-effects when
1148 tinymail seems to call it at strange time, maybe because of how we
1149 are cancelling get_password().
1150 (modest_tny_account_store_alert): Ignore user cancellations.
1152 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1154 * src/maemo/modest-maemo-utils.h:
1155 * src/maemo/modest-maemo-utils.c:
1156 Added modest_maemo_show_information_note_and_forget() for use instead of
1157 gtk_dialog_run() when the response is not needed, to avoid an extra
1158 mainloop which could cause a hang.
1160 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1161 Use the logical IDs for the error message, though they are not
1162 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1163 because gtk_dialog_run() caused a hang here (the window did not close).
1164 This fixes projects.maemo.org bug NB#62646.
1166 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1168 * src/modest-account-mgr-helpers.h:
1169 * src/modest-account-mgr-helpers.c:
1170 Added modest_account_mgr_get_store_protocol().
1172 * src/maemo/modest-account-view-window.c:
1173 (on_delete_button_clicked): Show different warning text depending on
1174 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1175 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1178 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/modest-msg-edit-window.c:
1181 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1182 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1184 2007-07-07 Armin Burgmeier <armin@openismus.com>
1186 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1187 ckdg_ib_maximum_characters_reached from correct package.
1189 * src/modest-ui-actions.c: Show an error message when a folder could
1190 not be created. Tinymail does not give us specific error codes about
1191 what has gone wrong, so we assume that a folder with that name
1192 already exists, though there might be other reasons.
1194 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1197 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1198 give a more exact error message that can be partly translated.
1200 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1202 * src/maemo/modest-address-book.c:
1203 (select_email_addrs_for_contact): Specify a default window size for the
1204 select-email-address dialog, so that it is probably big enough for the
1205 title. This should fix projects.maemo.org bug NB#62277.
1207 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1209 * src/maemo/easysetup/modest-easysetup-wizard.c:
1210 (create_page_complete_easysetup): Use
1211 gtk_widget_set_size() request to ensure that the text wraps
1214 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1216 * src/maemo/easysetup/modest-easysetup-wizard.c:
1217 (on_entry_invalid_character), (create_page_account_details),
1218 (create_page_user_details):
1219 Use new API of ModestValidatingEntry. But for some reason the banner is
1220 not shown. I will have to investigate that further.
1222 * src/widgets/modest-validating-entry.c: (on_insert_text),
1223 (modest_validating_entry_set_func):
1224 * src/widgets/modest-validating-entry.h:
1225 Added a new callback function to be able to react to prevented
1226 characters whitespaces to e.g show a banner.
1228 2007-07-05 Armin Burgmeier <armin@openismus.com>
1230 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1231 notification of HildonNumberEditor instead of remembering the port
1232 number. Thanks to Johannes for pointing this out.
1234 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1236 * src/maemo/easysetup/modest-easysetup-wizard.c:
1237 Check if there are any user changes before showing a confirmation
1238 dialog (projects.maemo.org NB#60946)
1240 2007-07-05 Armin Burgmeier <armin@openismus.com>
1242 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1243 number at the beginning of the dialog and set the modified flag at the
1244 end if the port number has changed. This is necessary because
1245 HildonNumberEditor does not support notification when the value has
1248 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1250 * src/modest-ui-actions.c:
1251 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1252 a connection before asking anything else. Correct the check for the destination
1253 folder so that it succeeds when online.
1254 This fixed projects.maemo.org bug NB#61645.
1256 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1259 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1260 to fix projects.maemo.org bug NB#62439.
1262 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-tny-account.c: (on_connection_status_changed):
1265 Really do not use tny_device_force_offline() here. See the previous comment.
1267 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1269 * src/modest-tny-account.c: (on_connection_status_changed):
1270 Do not use tny_device_force_offline() when tinymail says that something
1271 went wrong with the connection. It seems to report this unnecessarily.
1273 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1275 * src/maemo/modest-connection-specific-smtp-window.c:
1276 (modest_connection_specific_smtp_window_init):
1277 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1278 does not seem to have any effect in osso 1.1 (though it works in
1279 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1281 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1283 * src/maemo/modest-connection-specific-smtp-window.c:
1284 Fix UI specification problems with projects.meamo.org NB#60479
1286 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1288 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1289 clue when this has failed, because the error dialog is not always shown
1290 (at least in earlier version).
1292 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1293 GError message, because the generic error dialog is not helpful.
1295 'This message is not currently available (can't let a new connection go online)'
1296 when trying to open an IMAP message.
1298 (_modest_ui_actions_open): Offer a connection when some messages would
1299 have to be downloaded and we are offline.
1301 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1303 * src/widgets/modest-folder-view.c:
1304 Don't check for MERGE type anymore as we use the correct type
1306 NOTE: For the last two changes you need to update your tinymail copy
1307 because of API changes!
1309 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1311 * src/modest-tny-local-folders-account.c:
1312 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1313 (see projects.maemo.org NB#61580)
1315 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-tny-account.c: (on_connection_status_changed):
1318 Commented out the call to modest_platform_connect_and_wait() because this
1319 seems to always hang, and I would like to know if this is the only thing
1320 that causes a hang when showing the connection dialog.
1321 It is not very useful anyway.
1323 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/modest-msg-view-window.c:
1326 (modest_msg_view_window_select_next_message):
1328 * src/modest-platform.h:
1329 * src/maemo/modest-platform.c:
1330 Added modest_platform_connect_and_wait(), which calls
1331 tny_maemo_conic_device_connect() always in the main thread, by calling it
1332 in an idle handler and waiting for the idle handler to run. It should be
1333 in the main thread because it uses GTK+ UI code. It just returns TRUE
1334 if the device is already online.
1336 There is some nasty code to ensure that subsequent calls to
1337 modest_platform_connect_and_wait() just wait for the first one to finish,
1338 by checking repeatedly in another idle handler. This is necessary,
1339 because other threads (or even the main thread, via another idle handler)
1340 can call modest_platform_connect_and_wait() while
1341 modest_platform_connect_and_wait() is running.
1343 (modest_platform_connect_and_wait_if_network_account),
1344 (modest_platform_connect_and_wait_if_network_folderstore):
1345 Convenience functions that calls modest_platform_connect_and_wait() if
1346 the account or folder might want network access.
1348 * src/modest-mail-operation.c:
1349 (modest_mail_operation_update_account):
1350 * src/modest-ui-actions.c: (download_uncached_messages),
1351 (modest_ui_actions_on_rename_folder), (delete_folder),
1352 (modest_ui_actions_on_main_window_move_to),
1353 (modest_ui_actions_on_msg_view_window_move_to):
1354 * src/widgets/modest-folder-view.c:
1355 (drag_and_drop_from_folder_view):
1356 Offer a connection if we are offline.
1358 * src/modest-tny-account.c: (on_connection_status_changed):
1359 Document this as only handling errors during network operations in progress,
1360 and replace the idle code with a simple call to
1361 modest_platform_connect_and_wait(), which does this instead.
1363 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1365 * src/modest-tny-account.c:
1366 (modest_tny_account_get_special_folder): (util_on_idle),
1367 Handle the GError so we can see when tny_folder_store_get_folders()
1368 fails, as it currently does while something else is connecting.
1370 Added util_run_in_main_thread_and_wait()
1371 which uses an idlen handler and mainloop to ensure that the function
1372 is called in the main thread.
1373 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1374 to make sure that we call attempt the connection in the mainloop only,
1375 which might solve some hangs.
1377 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1379 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1380 be found by their display name. This is never useful.
1381 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1382 by its ID, instead of trying to use its ID as its display name.
1384 * src/modest-tny-account-store.h:
1385 * src/modest-tny-account.c:
1386 (modest_tny_account_get_special_folder): Add a g_warning() when
1387 tny_folder_store_get_folders() returns an empty list for the maildir.
1389 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1390 Add a g_warning() when this returns NULL, because that it not allowed
1393 2007-07-02 Armin Burgmeier <armin@openismus.com>
1395 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1396 note when trying to cancel the wizard. This fixes projects.maemo.org
1399 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account.h:
1402 * src/modest-tny-account.c:
1403 (modest_tny_account_new_from_server_account),
1404 (modest_tny_account_new_from_server_account_name),
1405 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1406 because this must now be set before setting the proto. This is usd in
1407 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1408 warning in camel_session_get_service() caused by
1409 tny_camel_transport_account_prepare().
1411 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1414 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1416 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1418 (modest_connection_specific_smtp_edit_window_init):
1420 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1421 of "changed" for now
1423 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1425 * src/modest-tny-account.c:
1426 (modest_tny_account_new_from_server_account):
1427 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1428 now uses to request a connection when it needs one, and which it uses
1429 to tell us that something is wrong with the connection, so we can force
1430 the accounts offline to prevent further problems.
1432 * src/modest-defs.h:
1433 * src/modest-init.c: (init_default_settings):
1434 * src/modest-mail-operation.c:
1435 (modest_mail_operation_update_account):
1436 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1437 This should not be necessary anymore. Do not set the conf key that
1438 determined this (it was always TRUE and not set anywhere else).
1440 * src/modest-ui-actions.h: Remove unused and unimplemented
1441 modest_ui_actions_on_online_toggle_toggled().
1443 2007-06-29 Murray Cumming <murrayc@murrayc.com
1445 * src/maemo/modest-main-window.c: (connect_signals):
1446 Don't connect to delete_event twice. Maybe this was harmless.
1448 2007-06-29 Murray Cumming <murrayc@murrayc.com
1450 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1451 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1452 Debug output to give some more clue when a folder move is not allowed.
1454 2007-06-28 Murray Cumming <murrayc@murrayc.com
1456 * src/modest-tny-account.c: (on_modest_file_system_info),
1457 (modest_tny_account_get_mmc_account_name):
1458 Always call the callback, without checking whether the name has changed.
1459 * src/widgets/modest-folder-view.c: (strings_are_equal),
1460 (on_model_foreach_set_name), (on_get_mmc_account_name),
1461 (text_cell_data): Compare the name here, and use the name from
1462 the account rather than from the
1463 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1464 if the name was changed after the account was added to the model.
1465 That's a tinymail bug but not one that I want to fix now.
1467 This finally fixes projects.maemo.org bug NB#59301.
1469 2007-06-27 Armin Burgmeier <armin@openismus.com>
1471 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1474 2007-06-27 Murray Cumming <murrayc@murrayc.com
1476 * src/modest-tny-account.h:
1477 * src/modest-tny-account.c:
1478 Added modest_tny_account_get_mmc_account_name(), to set the memory
1479 card name asynchronously for the given account and then notify.
1480 (modest_tny_account_new_for_local_folders): Use this new function instead
1481 of using hildon_file_system_info_async_new() directly.
1483 * src/widgets/modest-folder-view.c: (text_cell_data):
1484 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1485 gtk_tree_model_row_changed() when it is available.
1487 This should fix projects.maemo.org bug NB#59301.
1489 2007-06-27 Murray Cumming <murrayc@murrayc.com
1491 * src/modest-mail-operation.c: (update_account_thread),
1492 (get_msgs_full_thread): Fix typo failures in the revert
1495 2007-06-27 Murray Cumming <murrayc@murrayc.com
1497 * src/maemo/modest-maemo-global-settings-dialog.c:
1498 (idle_select_default_focus):
1499 * src/modest-mail-operation.c: (idle_notify_progress),
1500 (idle_notify_progress_once), (set_last_updated_idle),
1501 (update_account_thread), (get_msgs_full_thread):
1502 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1503 * src/widgets/modest-header-view.c:
1504 (idle_notify_headers_count_changed_destroy),
1505 (idle_notify_headers_count_changed):
1506 Reverted the additions of gdk_threads_enter/leave(), in case this
1507 helps with a startup hang on the device.
1509 2007-06-26 Armin Burgmeier <armin@openismus.com>
1511 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1512 for supported secure authentication methods from server by
1513 gtk_dialog_run(), saving CPU time and a potential race condition.
1515 2007-06-26 Armin Burgmeier <armin@openismus.com>
1517 * src/maemo/modest-maemo-utils.h:
1518 * src/maemo/modest-maemo-utils.c: Added a
1519 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1520 only error code to tell the calling code when the user canceled the
1523 * src/maemo/modest-account-settings-dialog.h:
1524 * src/maemo/modest-account-settings-dialog.c:
1525 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1526 message if the retrieval of secure authentication methods was canceled
1527 by the user. Perform the check before saving anything to configuration
1528 to not end up with half-committed configuration changes, do not show
1529 a "Saving to configuration failed" note when authentication methods
1530 could not be retrieved.
1532 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1535 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1537 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1538 Only return the first level of folders under accounts, because the
1539 osso-global-search UI spec doesn't want the rest.
1540 This fixed projects.maemo.org bug NB#61811.
1542 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account-store.c:
1545 * src/modest-tny-account-store.h:
1546 Added modest_tny_account_is_memory_card_account().
1547 * src/maemo/modest-main-window.c: (create_details_widget):
1548 Show the same information items for the memory card as we show for the
1549 local-folders, to fix projects.maemo.org bug NB#59307.
1551 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1553 * src/modest-tny-account-store.c: (get_password):
1554 Added some checks for NULL to maybe prevent crashes, though I think
1555 it was Philip's last commit that actually prevented the crash here
1556 when creating a first new account.
1557 But the new account is still not usable (no messages are shown)
1558 until a restart of the application.
1560 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/modest-maemo-global-settings-dialog.c:
1563 (idle_select_default_focus):
1564 * src/modest-mail-operation.c: (idle_notify_progress),
1565 (idle_notify_progress_once), (idle_notify_update_account_queue),
1566 (set_last_updated_idle), (update_account_thread),
1567 (notify_get_msgs_full), (get_msgs_full_destroyer),
1568 (get_msgs_full_thread):
1569 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1570 * src/widgets/modest-header-view.c:
1571 (idle_notify_headers_count_changed_destroy),
1572 (idle_notify_headers_count_changed):
1573 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1574 all idle handlers, because some other thread could be blocking
1575 the GDK lock, so that it can do GUI stuff.
1577 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1579 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1580 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1581 (on_idle_send_receive), (on_idle_open_default_inbox):
1582 * src/maemo/modest-msg-edit-window.c:
1583 (modest_msg_edit_window_attach_file_noninteractive):
1584 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1585 to prevent a hang. I don't quite understand why these are necessary,
1586 beause we should already be in the main loop. I guess something outside
1587 of the main loop is taking the lock.
1589 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1590 we are really using URIs, and use files that are more likely to exist.
1592 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1594 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1595 necessary because configure.ac now defines different variables.
1597 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1599 * libmodest-dbus-client/libmodest-dbus-client.c:
1600 * libmodest-dbus-client/libmodest-dbus-client.h:
1601 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1602 libmodest_dbus_client_compose_mail() is what things actually use.
1604 * src/dbus_api/modest-dbus-api.h:
1605 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1606 * tests/dbus_api/Makefile.am:
1607 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1610 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-init.c: (modest_init_local_folders):
1613 For memory-card (or other non local-folders) maildir accounts,
1614 always create an Archive folder, so that there is somewhere to put
1615 messages. This should be less confusing, because the user does not need
1616 to guess that the need to create a folder.
1618 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1620 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1621 Fixed icon size by using (50, 50) which is the same as defined by
1624 2007-06-25 Armin Burgmeier <armin@openismus.com>
1626 * src/widgets/modest-window-mgr.c:
1627 * src/modest-init.c:
1628 * configure.ac: Correctly recognize hildon-notify presence and fixed
1629 the build without it being installed.
1631 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1633 * libmodest-dbus-client/libmodest-dbus-client.c:
1634 (libmodest_dbus_client_search): Fix the build. Sorry.
1635 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1636 (reply_forward_cb): Initialize variables to fix the build.
1638 * src/modest-tny-account-store.c:
1639 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1640 comparison (a silly typo) so that email search results can be opened
1641 when there are more than one account.
1643 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1645 * libmodest-dbus-client/libmodest-dbus-client.c:
1646 (libmodest_dbus_client_search),
1647 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1648 instead of 1 second, because the search gets folders and messages from
1649 the server, which can take a long time. When it times out,
1650 osso-global-search will report no results.
1652 We need to specify whether we should search only cached information
1653 (maybe with a user preference), and the osso-email-search-plugin
1654 API should really be improved to allow that option, and to allow results
1655 to be delivered asynchronously in batches.
1657 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1659 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1660 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1661 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1663 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1666 that is an empty string. D-Bus seems to give us these instead of NULL.
1668 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1670 * src/dbus_api/modest-dbus-callbacks.c:
1671 * src/maemo/easysetup/modest-easysetup-wizard.h:
1672 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1674 (modest_connection_specific_smtp_edit_window_init):
1675 * src/maemo/modest-maemo-global-settings-dialog.c:
1677 * src/maemo/modest-maemo-utils.c:
1678 (modest_maemo_utils_setup_images_filechooser):
1679 * src/maemo/modest-main-window.c: (create_details_widget):
1680 * src/maemo/modest-msg-edit-window.c:
1681 (modest_msg_edit_window_attach_file_noninteractive),
1682 (modest_msg_edit_window_color_button_change),
1683 (modest_msg_edit_window_set_zoom):
1684 * src/modest-mail-operation.c: (update_account_thread):
1685 * src/modest-tny-account-store.c:
1686 * src/modest-tny-account.c:
1687 * src/widgets/modest-global-settings-dialog.c:
1688 * src/widgets/modest-window.h:
1690 Fixed build on bora!
1692 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1694 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1695 * src/modest-search.c: (modest_search_folder),
1696 (modest_search_all_accounts): Actually search only in the specified folder,
1697 doing a simple match on the folder ID.
1698 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1699 and added some documentation.
1701 2007-06-22 Armin Burgmeier <armin@openismus.com>
1703 * src/maemo/modest-maemo-utils.h:
1704 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1705 modest_maemo_utils_get_supported_secure_authentication_methods.
1707 * src/maemo/easysetup/modest-easysetup-wizard.c:
1708 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1709 one occured, not just "Server does not support secure authentication".
1711 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1713 * src/modest-tny-account-store.c: (get_password):
1714 Restored the call to tny_account_set_user() because Philip seems to have
1715 stopped this from crashing (by not using the freed string). It still does
1716 not work, but now we can test it.
1718 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/modest-msg-edit-window.c: (init_window):
1721 Comment out use of an uninitialzed GtkScrolledWindow variable,
1722 to fix the build and stop a crash. Yet again.
1724 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-tny-account-store.c: (get_password):
1727 Remove the call to tny_account_set_user() because this actually crashes.
1728 As mentioned in the last commit, it is known to not work anyway.
1730 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1732 * src/modest-tny-account-store.c: (get_password):
1733 Use tny_account_set_username() to tell tinymail that the username might
1734 have changed too. But tinymail ignores this: see projects.maemo.org
1736 * src/modest-ui-actions.c:
1737 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1738 reset the connection when changing the username, and improve the comments.
1739 Save the changed username to gconf at least, so it is used when Modest is
1742 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1744 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1745 Do not use a query, so that we get all folders, including for POP and
1746 local-folders. They work as search criteria too.
1747 This fixes projects.maemo.org bug NB#57740.
1749 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1751 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1752 Comment out the use of hildon_notification_set_sound() because it is
1753 not declared, to fix the build. Warnings are serious, people.
1755 2007-06-21 Armin Burgmeier <armin@openismus.com>
1757 * src/maemo/modest-maemo-utils.h:
1758 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1759 modest_maemo_utils_get_supported_secure_authentication_methods()
1760 to query authentication methods for a specific user. This should fix
1761 projects.maemo.org bug NB#61369.
1763 * src/maemo/easysetup/modest-easysetup-wizard.c:
1764 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1767 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1769 * libmodest-dbus-client/libmodest-dbus-client.h:
1770 * libmodest-dbus-client/libmodest-dbus-client.c:
1771 (modest_dbus_message_iter_get_search_hit),
1772 (libmodest_dbus_client_search):
1773 Reorganised and commented this.
1774 Removed modest_search_hit_free() from the public API because it
1777 Added libmodest_dbus_client_get_folders() and
1778 modest_folder_result_list_free().
1780 * src/dbus_api/modest-dbus-api.h:
1781 * src/dbus_api/modest-dbus-callbacks.c:
1782 (modest_dbus_req_filter): Commented. Moved most code to
1783 on_dbus_method_search() and added on_dbus_method_get_folders().
1785 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1786 of the extra D-Bus handler.
1788 * tests/dbus_api/Makefile.am:
1789 * tests/dbus_api/test_get_folders.c: New test for
1790 libmodest_dbus_client_get_folders(). This seems to return an empty list
1791 at the moment. That could be the same error that causes the message list
1792 to be empty sometimes.
1793 This should help with projects.maemo.org bug NB#57740.
1795 2007-06-21 Armin Burgmeier <armin@openismus.com>
1797 * src/modest-mail-operation.c: Do not call
1798 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1799 notify the operation's end after having set the status to CANCELED for
1800 the operation queue to listen on. This fixes a deadlock when there
1801 were mail operations in the queue during its finalization.
1803 * src/modest-singletons.c: Reordered uninitialization of the account
1804 manager to happen after the mail operation queue was uninitialized
1805 because the mail operation's in the queue might still try to access
1806 the account manager (see modest_mail_operation_notify_end()). This
1807 fixes a potential crash when terminating the application.
1809 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-search.c:
1812 (search_mime_part_and_child_parts): Moved some code here so we
1813 can search recursively in child folders.
1814 (modest_search_folder): Search in the message as a mime part, instead
1815 of just its child mime parts.
1816 (read_chunk), (search_mime_part_ogs):
1817 Check how many bytes were read, to prevent an endless loop.
1818 Searching in message bodies now works. This finishes the fix for
1819 projects.maemo.org bug NB#61007.
1821 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1823 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1824 Add a g_warning when the item is not a folder.
1826 * src/modest-ui-dimming-rules.c:
1827 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1828 when selected item is not a folder (for instance, an account), because
1829 the UI spec only talks about folders.
1830 I am not sure what the UI spec wants, so this might not totally fix
1831 projects.maemo.org bug NB#60794.
1833 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1835 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1836 (load_from_file): Sort the list. The unsorted list would be more noticeable
1837 in non-English locales.
1839 * src/maemo/modest-msg-edit-window.c:
1840 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1841 warning and fix the build.
1843 * src/maemo/modest-progress-bar-widget.c:
1844 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1845 avoid a g_warning, and probably to avoid a crash.
1847 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1849 * src/modest-search.c: (modest_search_folder): Check for a GError
1850 when calling tny_folder_get_headers(), to show that this is not the cause
1853 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1855 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1856 Actually set the body query instead of the subject query.
1858 * src/modest-search.c: (search_mime_part_ogs),
1859 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1860 which would probably cause it to fail if we got this far.
1862 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1863 to simplify the code.
1864 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1865 be causing search-in-body to fail.
1867 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1869 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1871 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1872 Better debug message when the folder cannot be found.
1873 This should help with fixing projects.maemo.org bug #61287.
1874 * src/modest-search.c: (add_hit): Do not leak the furl string.
1876 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-ui-actions.c:
1879 (modest_ui_actions_on_folder_selection_changed):
1880 Do not special-case TNY_MERGE_FOLDER here, because
1881 modest_tny_folder_get_account() already does that. This fixes
1882 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1883 shown when the Outbox was selected).
1885 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1887 * libmodest-dbus-client/libmodest-dbus-client.c:
1888 (_dbus_iter_get_string_or_null): Initialize the string variable in
1889 case this helps with Dirk's crash.
1891 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1893 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1894 though it is not implemented yet (this function is maybe not even used),
1895 to avoid breaking ABI in future.
1896 * libmodest-dbus-client/libmodest-dbus-client.c:
1897 (get_attachments_string): Moved some code into this generic function.
1898 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1899 sends email. It is maybe not used.
1900 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1901 (on_send_mail): Use attachments.
1903 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1904 * src/maemo/modest-msg-edit-window.c:
1905 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1906 a filename before using it, to fix projects.maemo.org bug NB#58233.
1908 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1911 Initialize the continue_download variable to fix the build, and probably
1912 to fix randome behaviour.
1914 2007-06-18 Armin Burgmeier <armin@openismus.com>
1916 * src/modest-tny-send-queue.h:
1917 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1918 the queue so we can later show it in the UI. Replaced
1919 modest_tny_send_queue_msg_is_being_sent() by
1920 modest_tny_send_queue_get_msg_status().
1922 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1924 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1925 gpointer. This probably was not harmful, but just to be sure.
1927 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1929 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1930 Fix the build, but leave the function broken on Bora, because
1931 hildon_uri_action_get_service() does not exist.
1932 osso_uri_action_get_service() does not exist either, it seems.
1934 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-tny-account.c:
1937 (modest_tny_account_new_from_server_account):
1938 Uncommented the url debug output again, because it is useful for
1939 debugging, as I said in the comment.
1941 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1943 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1945 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1946 for Mameo Bora, to fix the build.
1948 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1951 Fixed build with hildon < 0.99
1953 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1954 Check if the selected account is busy instead of checking all accounts
1956 * src/modest-account-mgr-priv.h:
1957 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1958 (modest_account_mgr_init), (compare_account_name),
1959 (modest_account_mgr_set_account_busy),
1960 (modest_account_mgr_account_is_busy):
1961 * src/modest-account-mgr.h:
1962 Added busy information to the account manager. It possible to
1963 set an account to busy or not busy now.
1965 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1966 (modest_mail_operation_update_account),
1967 (modest_mail_operation_notify_end):
1968 Set the account to busy/not busy depending on the operation state.
1970 * src/widgets/modest-account-view.c:
1971 (modest_account_view_finalize), (get_last_updated_string),
1972 (update_account_view), (on_account_busy_changed), (init_view):
1973 Show string "Refreshing..." if the account is currently busy.
1975 All this fixes projects.maemo.org bug NB#59711
1977 2007-06-14 Armin Burgmeier <armin@openismus.com>
1979 * src/widgets/modest-attachments-view.h:
1980 * src/widgets/modest-attachments-view.c: Added
1981 modest_attachments_view_has_attachments() and fixed coordinate
1982 transformation in get_att_view_at_coords(). This fixes attachment
1985 * src/widgets/modest-msg-view.c: Make use of
1986 modest_attachments_view_has_attachments() to decide whether to show
1987 attachments in the header.
1989 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1992 (on_change), (on_combo_security_changed),
1993 (modest_connection_specific_smtp_edit_window_init),
1994 (modest_connection_specific_smtp_edit_window_set_connection),
1995 (modest_connection_specific_smtp_edit_window_is_dirty):
1996 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1997 * src/maemo/modest-connection-specific-smtp-window.c:
2000 Show an comfirmation dialog for the smpt-edit-window if there are
2001 unsaved changes and the user hits cancel.
2002 (projects.maemo.org bug NB#60479)
2004 2007-06-14 Armin Burgmeier <armin@openismus.com>
2006 * src/maemo/easysetup/modest-easysetup-wizard.c:
2007 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
2008 address" info in banner instead of node, and select all the text as
2009 per UI spec. This fixes projects.maemo.org bug NB#60550.
2011 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
2013 reviewed by: <delete if not using a buddy>
2015 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2016 * src/modest-ui-actions.c: (folder_refreshed_cb):
2018 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2020 * src/widgets/modest-folder-view.c: (filter_row):
2021 Explictly filter out the per-account outbox accounts. I don't know why
2022 these only sometimes show up, but now they should never show up in the UI.
2023 This should fix projects.maemo.org bug NB#60160.
2025 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2027 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2028 when the toolbar does not exist yet.
2029 * src/modest-widget-memory.c: (save_settings_header_view):
2030 Added g_warnings() to help us to discover when we are trying to set
2031 an empty columns list in gconf.
2033 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-init.h:
2036 * src/modest-init.c:
2037 Added modest_init_get_default_header_view_column_ids().
2039 * src/modest-widget-memory.c: (restore_settings_header_view):
2040 Use the new function to get defaults, if the gconf key is empty,
2041 instead of not creating any columns. This seems to fix the
2042 empty right-hand pane problems.
2044 * src/widgets/modest-header-view.h: Improved documentation.
2046 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2049 Revert the use of the display name as the account name, because this
2050 is generally wrong and would break the code that follows.
2052 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2054 * src/maemo/easysetup/modest-easysetup-wizard.c:
2055 (check_for_supported_auth_methods), (on_before_next),
2058 More correct fix for projects.maemo.org bug NB# 58991
2059 Do not longer accept AUTH_PASSWORD as secure method and choose
2060 correct method when creating the account.
2062 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2064 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2065 Fixed projects.maemo.org bug NB# 58991
2067 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-init.c: (modest_init_init_core),
2070 (modest_init_local_folders): Fixed compilation errors.
2072 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2074 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2075 Remove unnecessary lib/include, though it is good in principle when needed.
2077 * src/modest-init.c: (modest_init_one_local_folder),
2078 (modest_init_local_folders):
2079 * src/modest-init.h: Initialize the .modest library for memory cards,
2080 instead of just doing nothing for them. This should allow us to create
2081 folders there, fixing projects.maemo.org bug NB#59297.
2083 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2085 * libmodest-dbus-client/libmodest-dbus-client.c:
2086 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2087 (libmodest_dbus_client_compose_mail),
2088 (libmodest_dbus_client_open_message),
2089 (libmodest_dbus_client_send_and_receive),
2090 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2092 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2093 (on_idle_open_message), (modest_dbus_req_handler),
2094 (search_result_to_message), (modest_dbus_req_filter):
2095 * src/modest-search.c: (add_hit), (modest_search_folder),
2096 (modest_search_all_accounts): Improved debug messages.
2098 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2100 * src/modest-tny-account-store.c:
2101 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2104 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2107 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-tny-account-store.c: (get_server_accounts):
2110 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2111 even when there are no accounts, so that the Outbox folder is always
2112 visible. This fixes projects.maemo.org bug NB#60158.
2114 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-main-window.c: (create_details_widget):
2117 Use the mcen_va_never logical ID.
2119 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2121 * src/dbus_api/modest-dbus-api.h:
2122 * src/dbus_api/modest-dbus-callbacks.c:
2123 (on_idle_open_default_inbox), (on_open_default_inbox),
2124 (modest_dbus_req_handler):
2125 Added a new OpenDefaultInbox method.
2127 * libmodest-dbus-client/libmodest-dbus-client.h:
2128 * libmodest-dbus-client/libmodest-dbus-client.c:
2129 Added libmodest_dbus_client_open_default_inbox() to call the new
2130 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2131 though it should maybe be used by a new osso-email-interface function.
2133 * tests/dbus_api/Makefile.am:
2134 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2137 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2140 NULL, so that the signals get all the keys. This should not actually
2141 change any behaviour because we currently update everything when anything
2144 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2146 * src/widgets/modest-folder-view.c: (text_cell_data),
2147 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2148 (find_inbox_iter): If tinymail tells us that the folder is
2149 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2150 This causes the inbox to be selected at startup, fixing part of
2151 projects.maemo.org bug NB#56305.
2153 * src/modest-ui-dimming-rules.c:
2154 (modest_ui_dimming_rules_on_tools_smtp_servers):
2155 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2156 the SMTP servers menu item.
2157 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2158 that the SMTP Servers menu item is dimmed when there are no accounts,
2159 as a future version of the UI spec will require. This fixes
2160 projects.maemo.org bug NB#56305.
2162 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2164 * src/maemo/modest-maemo-utils.c:
2165 (modest_maemo_utils_get_supported_secure_authentication_methods):
2166 Added label to dialog instead of unreadable title
2168 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2169 (modest_main_window_new):
2170 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2173 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2174 * src/modest-account-mgr.h:
2175 Added method to avoid code duplication
2177 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2178 (modest_ui_actions_on_send_receive):
2179 Use modest_account_mgr_has_accounts
2181 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/easysetup/modest-presets.c:
2184 (modest_presets_get_info_server_security): Do not report secure auth
2186 * src/modest-protocol-info.c: Use the defines for the gconf key names
2187 for secure authentication. This was not working because we were writing
2188 Password and reading password, and the check was case sensitive.
2189 With this, gmail now works for receiving and sending when created via
2192 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/easysetup/modest-presets.c:
2195 (modest_presets_get_info_server_security): Correct the key name for
2196 SecureSmtp, because it seems to be case-sensitive.
2197 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2198 Do not try to get the 0th notebook page if there are 0 pages, to
2199 avoid a g_warning().
2201 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2203 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2204 Prevent use of the new notification feature for now, because it currently
2205 shows one dialog for each new email, which is annoying.
2207 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2209 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2210 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2211 when no country was selected, so that we show the global ones.
2212 * src/maemo/easysetup/modest-presets.c:
2213 (modest_presets_get_providers): Return only the global providers, not
2214 all providers when mmc=0 was requested.
2216 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2218 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2219 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2220 provider ID in the combo.
2222 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2223 Do not show the page numbers, because it would be confusing when we add
2224 the 2 extra pages for the custom setup, when the user chooses the "Other"
2225 provider. This fixes projects.maemo.org bug NB#59028
2227 * src/modest-init.c: (modest_init_init_core),
2228 (modest_init_local_folders):
2229 * src/modest-init.h:
2230 * src/modest-tny-account.c:
2231 (modest_tny_account_new_for_local_folders): Do not create default folders
2232 for the memory card. This should fix projects.maemo.org bug NB#59328.
2234 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2237 Free the changed_conf_keys string items. They are already freed in the
2238 idle handler if that runs first.
2240 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2242 * src/modest-ui-actions.c:
2243 (modest_ui_actions_on_password_requested): Check that the server name
2244 is not NULL, because I just saw a password dialog with (null) as the
2247 * src/modest-tny-folder.[h|c]: Added
2248 modest_tny_folder_is_memory_card_folder().
2249 * src/modest-ui-dimming-rules.c:
2250 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2251 menu item for memory cards, as per the UI spec (section 7.4). This should
2252 fix projects.maemo.org bug NB#59297.
2254 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2256 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2257 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2258 is another problem with the code, see Murray's comment at line 772)
2260 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2263 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2264 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2265 (load_from_file), (easysetup_country_combo_box_init),
2266 (easysetup_country_combo_box_get_active_country_ids),
2267 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2268 instead of just one ID, to avoid duplicate country names in the UI.
2270 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2271 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2272 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2273 a single ID, avoiding duplicate providers.
2274 * src/maemo/easysetup/modest-easysetup-wizard.c:
2275 (on_combo_account_country): Adapt to use a list.
2277 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2279 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2280 keys changed in the last X seconds.
2282 * src/modest-account-mgr.h:
2283 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2284 (on_key_change), (modest_account_mgr_class_init),
2285 (modest_account_mgr_init), (modest_account_mgr_finalize):
2286 As the keys are changed, save them in a GSList* and signal that GSList*
2287 further every X seconds, to batch changes, to allow us to do just one
2288 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2289 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2291 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2292 changed signal signature.
2294 * src/modest-conf.c: (modest_conf_set_list),
2295 (modest_conf_on_change): Reenable notification.
2297 (modest_conf_maemo_fake_on_change): Comment out the hack that
2298 notified immediately instead of asynchronously.
2300 * src/widgets/modest-account-view.h:
2301 * src/widgets/modest-account-view.c:
2302 (update_account_view): Select the previously-selected account ID,
2303 if possible. This fixes projects.maemo.org bug NB#56933.
2305 (on_account_changed), (on_account_removed),
2306 (modest_account_view_select_account):
2308 Remove the block/unblock functions
2309 because they were not useful.
2311 * src/maemo/modest-account-view-window.c:
2312 (on_delete_button_clicked), (on_edit_button_clicked),
2313 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2315 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2317 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2318 Improve the error dialog to show Incorrect Account Settings, which seems
2319 clearer, and say that the internal error message (to be removed from the
2320 dialog later) is often misleading.
2321 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2323 * src/modest-tny-account.c:
2324 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2325 URL because this is so useful for debugging on the device.
2327 * src/widgets/modest-serversecurity-combo-box.c:
2328 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2330 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-mail-operation.c:
2333 (modest_mail_operation_send_new_mail):
2334 Added a comment about a nasty but apparently harmless message. Details
2335 added to the wiki g_warnings() page.
2337 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2339 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2340 (modest_tny_send_queue_class_init):
2341 Do not use the priv struct because it is empty, to avoid g_warnings
2342 about a non-existant priv struct.
2344 * src/modest-tny-account-store.c:
2345 (modest_tny_account_store_get_server_account),
2346 (modest_tny_account_store_get_transport_account_for_open_connection
2347 ): Do not try to get transport server accounts for local folders,
2348 because they don't have any. This avoids a g_warning().
2350 * src/maemo/modest-main-window.c:
2351 (modest_main_window_notify_send_receive_initied),
2352 (on_configuration_key_changed):
2353 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2354 * src/modest-defs.h:
2355 * src/modest-mail-operation.c:
2356 (modest_mail_operation_update_account):
2357 * src/modest-tny-account-store.h:
2358 * src/modest-tny-account.c:
2359 (modest_tny_account_get_special_folder),
2360 (modest_tny_account_new_for_local_folders),
2361 (modest_tny_account_new_for_per_account_local_outbox_folder):
2362 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2363 * src/modest-tny-local-folders-account.c:
2364 (add_account_folders_to_merged_folder):
2365 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2366 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2367 (modest_ui_actions_on_send):
2368 * src/widgets/modest-folder-view.c: (update_model):
2369 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2370 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2371 modest_tny_account_store_get_tny_account_by_account() to
2372 modest_tny_account_store_get_server_account() to make the code clearer.
2374 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2376 * src/dbus_api/modest-dbus-api.h:
2377 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2378 * src/maemo/modest-msg-edit-window.c:
2379 (modest_msg_edit_window_attach_file_noninteractive):
2380 added g_warning in case the file to be attached does not exist
2381 * tests/dbus_api/test_compose_mail.c: (main):
2382 removed obsolete comment, added generic files as test case
2384 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2386 * src/modest-tny-account-store.c: (get_server_accounts):
2387 Create the local folders account only once, not once for each outbox, and
2388 not only when there are some outboxes.
2390 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2392 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2393 code that is causing a crash at startup. Sergio says that he is fixing this.
2395 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2397 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2398 * src/maemo/modest-account-settings-dialog.c:
2399 (create_page_outgoing),
2400 (modest_account_settings_dialog_set_account_name),
2401 (save_configuration):
2402 - Fixed handling of the "Use secure authentication" toggle to comply with
2403 the ui specification. See also projects.maemo.org bug NB#58400
2405 - Restore the Secure connection setting combo correctly when loading
2408 * src/maemo/modest-maemo-utils.c:
2409 (on_camel_account_get_supported_secure_authentication),
2410 (modest_maemo_utils_get_supported_secure_authentication_methods):
2411 Fixed a crasher if operation is canceled
2413 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2414 (modest_protocol_info_auth_is_secure):
2415 * src/modest-protocol-info.h:
2417 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2418 the sense of the "Use secure authentication" toggle.
2420 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2422 * src/modest-tny-account-store.h:
2423 * src/modest-tny-account-store.c:
2424 Added modest_tny_account_store_get_local_folders_account().
2426 * src/modest-tny-folder.h:
2427 * src/modest-tny-folder.c:
2428 (modest_tny_folder_get_account):
2429 Added this replacement for tny_folder_get_account() which returns
2430 the local-folders account for TnyMergeFolders, to avoid the
2431 warning about the unimplemented get_account_func() vfunc().
2433 (modest_tny_folder_get_rules),
2434 * src/modest-ui-actions.c:
2435 (modest_ui_actions_on_folder_selection_changed):
2436 * src/modest-mail-operation.c:
2437 (modest_mail_operation_remove_folder),
2438 (modest_mail_operation_xfer_folder),
2439 (modest_mail_operation_rename_folder),
2440 (modest_mail_operation_get_msg),
2441 (modest_mail_operation_get_msgs_full),
2442 (modest_mail_operation_remove_msg),
2443 (modest_mail_operation_xfer_msgs),
2444 (modest_mail_operation_refresh_folder):
2445 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2447 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2450 (modest_server_account_set_security):
2451 * src/modest-defs.h: Add comments explaining that our
2452 UI spec means TLS when it says Normal, so these do not look like errors.
2454 * src/modest-tny-account.c:
2455 (modest_tny_account_new_from_server_account): Use the new tinymail
2456 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2457 for TLS. This should fix projects.maemo.org bug NB#58460.
2459 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/easysetup/modest-easysetup-wizard.c:
2462 (create_account): Correct the position of the gconf sanity check warning.
2463 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2464 of using the g_idle_add() hack, because this does not seem to be necessary
2465 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2466 caused by something other than maemo's gconf.
2467 This fixes projects.maemo.org bug #59022.
2469 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2471 * src/modest-account-mgr-helpers.c:
2472 (modest_account_mgr_get_default_account): Do not check that the account
2473 exists if there is no default account (NULL), to fix a runtime warning.
2475 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2477 * src/widgets/modest-folder-view.c: (update_model):
2478 Do not unref the treemodel before we have finished with it.
2479 This prevents a valgrind warning and an occasional crash at startup.
2481 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2483 * libmodest-dbus-client/libmodest-dbus-client.h:
2484 added libmodest_dbus_client_compose_mail()
2485 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2487 added functions needed for SendAsMail() functionality
2488 * src/maemo/modest-msg-edit-window.c:
2489 (modest_msg_edit_window_attach_file_noninteractive):
2490 non interactively attaching files to message edit window
2491 * src/widgets/modest-msg-edit-window.h:
2492 * tests/dbus_api/Makefile.am:
2493 added test_compose_mail.c
2494 * tests/dbus_api/test_compose_mail.c: (main):
2496 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2498 * src/modest-account-view.c:
2499 Fixed bug projects.maemo.org bug NB#59307
2501 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2503 * src/maemo/easysetup/modest-easysetup-wizard.c:
2504 (get_serverport_incoming), (on_before_next), (create_account):
2505 * src/maemo/modest-account-settings-dialog.c:
2506 (modest_account_settings_dialog_set_account_name):
2507 * src/maemo/modest-maemo-utils.c:
2508 (on_camel_account_get_supported_secure_authentication_status),
2509 (on_camel_account_get_supported_secure_authentication),
2510 (on_secure_auth_cancel),
2511 (modest_maemo_utils_get_supported_secure_authentication_methods):
2513 Implemented security authentication for settings and easysetup.
2515 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2517 * src/maemo/modest-main-window.c: (create_details_widget):
2518 Show the total size for memory card accounts too, instead of showing
2519 the name again. Fixes bug projects.maemo.org bug NB#59307.
2521 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2524 * src/modest-tny-simple-folder-store.c:
2525 * src/modest-tny-simple-folder-store.h: Removed.
2527 * src/modest-tny-local-folders-account.h
2528 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2529 for the local-folders maildir, with an extra TnyMergedFolder containing
2530 the folders of the per-account outbox store accounts.
2531 * src/modest-tny-account-store.c: (get_server_accounts):
2532 Add the outboxes to the special local folders account after creating it.
2534 * src/modest-tny-account.c:
2535 (modest_tny_account_new_for_local_folders): Create the derived
2536 account when creating the main local-folders account.
2538 * src/maemo/modest-main-window.c: (create_details_widget),
2539 (modest_main_window_set_contents_style):
2540 Adapted to the use of the derived account instead of the folder store.
2542 * src/modest-ui-actions.c:
2543 (modest_ui_actions_on_folder_selection_changed):
2544 * src/modest-ui-dimming-rules.c:
2545 (modest_ui_dimming_rules_on_new_folder):
2546 * src/widgets/modest-folder-view.c: (text_cell_data),
2547 (icon_cell_data), (filter_row), (update_model),
2548 (get_cmp_rows_type_pos):
2551 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2552 Do not get the priv struct, because no priv struct has been set,
2553 to avoid a runtime warning.
2555 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2556 #ifelse with #else, to fix a warning, to fix the build.
2559 2007-06-05 Christian Kellner <ckellner@openismus.com>
2561 * libmodest-dbus-client/libmodest-dbus-client.c:
2562 Fix small typo in doc (why do you always see them
2563 AFTER committing stuff?)
2566 2007-06-05 Christian Kellner <ckellner@openismus.com>
2568 * libmodest-dbus-client/libmodest-dbus-client.c:
2569 (libmodest_dbus_client_search):
2570 Initialize hit list with NULL. Also set folder list
2571 to "" if NULL was supplied.
2574 2007-06-03 Christian Kellner <ckellner@openismus.com>
2576 * libmodest-dbus-client/libmodest-dbus-client.c:
2577 (modest_search_hit_list_free):
2578 Make it save to call it with NULL.
2580 * src/dbus_api/modest-dbus-callbacks.c:
2581 * src/modest-search.c:
2582 Return full ModestSearchHits as the search result list not TnyHeader
2583 since can't be around withouth the correspoding TnyFolder.
2585 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2587 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2588 Added currently commented code to check for secure auth
2590 * src/maemo/modest-account-settings-dialog.c: (on_response),
2591 (save_configuration), (show_ok):
2592 Fixed projects.maemo.org bugs NB #59248 and #59251
2594 * src/maemo/modest-maemo-utils.c:
2595 (on_camel_account_get_supported_secure_authentication_status),
2596 (on_camel_account_get_supported_secure_authentication),
2597 (modest_maemo_utils_get_supported_secure_authentication_methods):
2598 * src/maemo/modest-maemo-utils.h:
2599 Moved get_supported_secure_authentication() method here to be able
2600 to use it from easysetup wizard.
2602 * src/modest-pair.c: (on_pair_compare_as_string):
2603 Should compare string with first part of pair and not
2604 strcmp pairs which will crash.
2606 * src/modest-protocol-info.c:
2607 (modest_protocol_info_protocol_is_store):
2608 * src/modest-protocol-info.h:
2609 Added modest_protocol_info_get_auth_protocol_name()
2611 2007-06-03 Armin Burgmeier <armin@openismus.com>
2613 * src/modest-mail-operation.c:
2614 (modest_mail_operation_get_msgs_full): Set priv->account also when
2615 only retrieving a single message. This avoids a crash when canceling
2618 (modest_mail_operation_notify_end): Do not explicitely remove the
2619 operation from the queue but only emit the progress_changed signal.
2620 The queue itself listens to that signal to remove the operation when
2621 it is finished. This reduces coupling and removes a potential deadlock
2622 when modest_mail_operation_notify_end() is called from the queue
2623 itself. If that is a problem performance-wise, I would suggest to
2624 implement a status-changed signal or something.
2626 * src/modest-mail-operation-queue.c: Make sure to never call a
2627 function from another file while the queue is locked. This (hopefully)
2628 fixes another deadlock when exiting the application while retrieving
2631 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2633 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2634 Fixed build if libogs is not available
2636 2007-06-03 Christian Kellner <ckellner@openismus.com>
2638 * libmodest-dbus-client/libmodest-dbus-client.h:
2639 * libmodest-dbus-client/libmodest-dbus-client.c:
2640 (libmodest_dbus_client_delete_message):
2641 Implement deletion of messages (Client side).
2643 (modest_search_hit_free),
2644 (modest_search_hit_list_free):
2645 Utility functions to free the result hits.
2647 * src/dbus_api/modest-dbus-api.h:
2648 * src/dbus_api/modest-dbus-callbacks.c:
2649 (on_delete_message),
2650 (modest_dbus_req_handler):
2651 Implement deletion of messages (Server side).
2653 * tests/dbus_api/test_search.c: (main):
2656 * tests/dbus_api/Makefile.am:
2657 * tests/dbus_api/test_delete_message:
2658 Add little test for the message deletion logic
2660 2007-06-03 Armin Burgmeier <armin@openismus.com>
2662 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2663 when the operation queue was not empty. projects.maemo.org bug
2666 2007-06-03 Armin Burgmeier <armin@openismus.com>
2668 * src/widgets/modest-account-view.c
2669 (on_account_default_toggled): Toggle default account column
2670 explicitely instead of waiting for gconf notification (which is
2671 currently ignored). This should fix projects.maemo.org bug NB#56910
2672 for now. It should probably be removed when gconf notifications are
2675 2007-06-03 Christian Kellner <ckellner@openismus.com>
2677 * libmodest-dbus-client/libmodest-dbus-client.c:
2678 Removed debugging spew.
2680 * src/dbus_api/modest-dbus-callbacks.c:
2681 Added debugging info.
2683 * src/modest-search.c:
2684 (modest_search_all_accounts):
2685 Use tny_account_store_get_accounts () on the account store
2686 to get all accounts which is the way to get all accounts.
2688 * tests/dbus_api/test_search.c: (main):
2689 Make it possible to supply the search term on the command line.
2691 2007-06-03 Christian Kellner <ckellner@openismus.com>
2693 * libmodest-dbus-client/libmodest-dbus-client.c:
2694 * libmodest-dbus-client/libmodest-dbus-client.h:
2695 Implement searching for mesages over raw dbus. (Client side)
2697 * src/dbus_api/Makefile.am:
2698 * src/dbus_api/modest-dbus-api.h:
2699 * src/dbus_api/modest-dbus-callbacks.c:
2700 * src/dbus_api/modest-dbus-callbacks.h:
2701 Search framework (Server side). Also implement on_idle_open_message().
2703 * src/maemo/modest-platform.c: (modest_platform_init):
2704 Prepare for raw dbus/osso rpc interaction.
2706 * src/modest-search.h:
2707 Changed minsize from unspecific guint to guint32.
2709 * src/modest-search.c:
2711 Added strange hack which magically made tnymail work.
2713 (modest_search_folder),
2714 (modest_search_account),
2715 (modest_search_all_accounts):
2716 Implement helper functions to search all accounts, specific account
2719 * tests/dbus_api/Makefile.am:
2720 * tests/dbus_api/test_open_message.c:
2721 Read url to open from commandline.
2723 * tests/dbus_api/test_search.c:
2724 Implement small test for dbus search stuff
2726 2007-06-02 Armin Burgmeier <armin@openismus.com>
2728 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2729 include account type and account title. This fixes projects.maemo.org
2732 * src/maemo/modest-account-view-window.c: Set a title for the window.
2734 2007-06-02 Armin Burgmeier <armin@openismus.com>
2736 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2737 incoming and outgoing server name based on email address and server
2738 types as long as the names have not been edited manually. This fixes
2739 projects.maemo.org bug NB#58671.
2741 2007-06-02 Armin Burgmeier <armin@openismus.com>
2743 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2744 server type cannot be changed in future to the incoming details page
2745 when creating an account. This fixes projects.maemo.org bug NB#59029.
2747 2007-06-02 Armin Burgmeier <armin@openismus.com>
2749 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2750 and assigned max width chars so that they wrap instead of being
2751 truncated. Fixes projects.maemo.org bug NB#56126.
2753 2007-06-02 Armin Burgmeier <armin@openismus.com>
2755 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2756 introductory note to the connection specific smtp servers dialog, as
2757 section 8.12 of the email UI specification requires. This fixes
2758 projects.maemo.org bug NB#59212.
2760 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2763 Check for running mail operations, and offer to cancel them, as per the UI
2764 spec. This fixes projects.maemo.org bug NB#59041 .
2765 However, I suspect that tinymail may still use the network connection
2766 in ways that we cannot detect or cancel. But it should at least adapt to
2767 changes fairly well.
2769 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-tny-account-store.c: (recreate_all_accounts),
2772 (get_cached_accounts), (get_server_accounts): Do more sensible
2773 ref-counting of the temporarily-cached outbox accounts list. This seems
2774 to fix a crash when entering the password when the password was wrong.
2776 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2778 * src/gnome/modest-main-window.c: (connect_signals):
2779 * src/modest-tny-account-store.c: (get_password),
2780 (modest_tny_account_store_alert): Added comments and clues and
2781 commented-out code about how we currently fail to deal with connection
2782 errors and wrong passwords, and how we should.
2784 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2786 * src/widgets/modest-retrieve-combo-box.c:
2787 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2788 This fixes projects.maemo.org bug NB#58472 .
2790 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/easysetup/modest-easysetup-wizard.c:
2793 (create_page_complete_easysetup):
2794 (create_page_complete_custom): Correct the last commit,
2795 putting the correct sentences in the correct pages.
2797 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/easysetup/modest-easysetup-wizard.c:
2800 (create_page_complete_custom): Show the second sentence of text
2801 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2804 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2806 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2807 Set the leave-on-server conf key by default. This fixes
2808 projects.maemo.org bug NB#59258 .
2810 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/modest-account-view-window.c:
2813 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2814 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2817 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2819 * src/maemo/easysetup/modest-easysetup-wizard.c:
2820 (create_caption_new_with_asterisk):
2821 * src/maemo/modest-account-settings-dialog.c:
2822 (create_caption_new_with_asterisk):
2823 Uncomment the code to add the asterisk, because they are no longer in the
2824 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2825 (update_incoming_server_title): Add an asterisk here too.
2827 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2829 * src/maemo/modest-maemo-global-settings-dialog.c:
2830 (current_connection): Check that we are even connected before trying to
2831 get the current connection name, to prevent a warning.
2833 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2834 Change the comments because tny_maemo_conic_device_connect() is now meant to
2836 * src/modest-mail-operation.c:
2837 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2838 make sure we have a connection and fail if we can't connect.
2840 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/modest-main-window.c:
2843 (on_account_store_connecting_finished): Do not try to get the
2844 connection ID if we are not really connected. I am surprised that
2845 this signal handler is called when we are not connected.
2847 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2849 * src/modest-error.h:
2850 * src/modest-ui-actions.c:
2851 (modest_ui_actions_get_msgs_full_error_handler):
2852 Renamed an enum, added comments, added an enum
2853 for retrieve-limit errors.
2855 * src/modest-mail-operation.c: (foreach_add_item),
2856 (internal_folder_observer_update), (update_account_thread),
2857 (modest_mail_operation_get_msgs_full):
2858 (modest_mail_operation_update_account),
2859 Added comments about how this works, and some code that should
2860 (but does not) check the retrieve-limit. See the TODO comment.
2862 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2864 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2865 Initialize help_id to fix the build. Warnings are good.
2867 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2869 * src/widgets/modest-hbox-cell-renderer.c:
2870 (modest_hbox_cell_renderer_append):
2871 * src/widgets/modest-vbox-cell-renderer.c:
2872 (modest_vbox_cell_renderer_append):
2873 Fix the last commit by doing an extra ref.
2875 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2877 * src/widgets/modest-hbox-cell-renderer.c:
2878 (modest_hbox_cell_renderer_append):
2879 * src/widgets/modest-vbox-cell-renderer.c:
2880 (modest_vbox_cell_renderer_append):
2881 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2882 to fix the build with Maemo Bora.
2883 However, there seems to be a remaining crash, probably due to reference
2886 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2888 * src/modest-tny-account.c:
2889 (modest_tny_account_new_for_local_folders):
2890 Use hildon_file_system_info_async_new() to get a better name for
2891 the memory card account, setting it as the account name.
2892 The timing seems to work, but this is probably
2893 not the best place to do this. See the TODO comment.
2894 * src/maemo/modest-main-window.c: (create_details_widget):
2895 * src/widgets/modest-folder-view.c: (text_cell_data):
2896 Use the tny account name instead of hardcoding a name.
2898 2007-05-30 Christian Kellner <ckellner@openismus.com>
2900 * src/modest-search.c: (modest_search):
2901 Correctly set part_search_func even if we have already parsed
2902 the query and thus a valid OgsTextSearcher object.
2904 2007-05-30 Christian Kellner <ckellner@openismus.com>
2907 Search and check for libogs.
2910 Incooparte the ogs build env.
2912 * src/modest-mime-part-search-stream.c:
2913 * src/modest-mime-part-search-stream.h:
2914 Removed since we do the real searching now in modest-search.c.
2916 * src/modest-search.c:
2917 * src/modest-search.h:
2918 Implement support for ogs. We use that if available and requested
2919 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2920 should now handle the corner case when the search term is spread
2921 across multiple reads.
2922 Also the logic in modest_search () was corrected to search all
2923 requested fields until one is found.
2925 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2929 * src/modest-init.h:
2930 * src/modest-init.c: Made modest_init_local_folders() take a
2931 path and be public so we can iniitialize maildir folders on
2934 * src/modest-local-folder-info.h:
2935 * src/modest-local-folder-info.c:
2936 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2938 * src/modest-tny-account.c:
2939 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2940 still means the standard local-folders path on the local volume.
2942 * src/modest-tny-account-store.c:
2943 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2944 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2945 all accounts when that happens.
2946 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2947 this too, so it shows up in the treeview.
2949 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2951 * src/maemo/modest-maemo-global-settings-dialog.c:
2952 (current_connection):
2953 * src/widgets/modest-global-settings-dialog.c:
2954 (current_connection_default):
2955 Use the enum values instead of 0, 1 and -1,
2956 to make the code clearer.
2958 * src/modest-account-mgr-helpers.c:
2959 (modest_account_mgr_get_connection_specific_smtp): Make this code
2962 * src/modest-runtime.h:
2963 * src/modest-runtime.c:
2964 Added modest_runtime_remove_all_send_queues().
2965 * src/maemo/modest-main-window.c:
2966 (on_account_store_connecting_finished): Recreate the send queues,
2967 using the appropriate transport accounts for this new connection.
2968 Some futher adapting might be needed if the old send queues are not
2969 automatically stopped at this point.
2971 * src/modest-tny-account-store.c: (get_server_accounts):
2972 Create the connection-specific transport accounts, so that they can
2973 be found later by their ID.
2975 * src/modest-tny-account.h:
2976 * src/modest-tny-account.c:
2977 Added modest_tny_account_new_from_server_account_name().
2978 modest_tny_account_new_from_server_account(): Do not create the
2979 send queues here, because they will be
2980 recreated anyway when the connection changes for the first time.
2982 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2984 * src/modest-local-folder-info.h:
2985 * src/modest-local-folder-info.c:
2986 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2987 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2988 tbox_folder): Take a modest account name instead of a server TnyAccount,
2989 so we can have per-modest-account rather than per-transport-account
2991 We must make sure that we change or recreate the exisitng send queues
2992 when the connection changes for connection-specific transport accounts.
2994 * src/modest-tny-account-store.c:
2995 (create_per_account_local_outbox_folders): Create outboxed per modest
2996 account, not per transport account.
2998 * src/modest-tny-account.h:
2999 * src/modest-tny-account.c:
3000 (modest_tny_account_get_special_folder): For outboxes, get the
3001 parent modest account name. The account is ignored for other folders.
3002 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
3003 modest account name rather than a server TnyAccount.
3005 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3007 * src/modest-tny-account.c:
3008 (modest_tny_account_new_from_server_account):
3009 Call modest_runtime_get_send_queue() immediately after creating transport
3010 accounts, so that they start trying to send email from the outbox as soon
3011 as possible at startup. This is probably what we want.
3013 * src/modest-mail-operation.c: (update_account_thread):
3014 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3015 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3016 * src/modest-tny-send-queue.h:
3017 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3018 (modest_ui_actions_on_send):
3019 Added comments about how sending works, though it needs some more work.
3021 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3023 * src/modest-tny-account.c:
3024 (modest_tny_account_get_special_folder): Add TODO because this fails when
3025 the network is busy.
3026 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3027 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3028 Do not try to show this window when there is no active account. The UI
3029 specs does not tell us what to do in this case.
3031 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/Makefile.am:
3036 * src/widgets/Makefile.am: Some dist fixes.
3038 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3040 * src/maemo/modest-connection-specific-smtp-window.c:
3041 (on_button_edit): Make the code clearer, to prevent a double free.
3043 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3045 * src/maemo/modest-account-settings-dialog.c:
3046 (modest_account_settings_dialog_set_account_name),
3047 Check the connection-specific smtp servers checkbox if there are any.
3049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3050 (modest_connection_specific_smtp_edit_window_init):
3051 Start with a suitable port number.
3053 * src/modest-account-mgr-helpers.h:
3054 * src/modest-account-mgr-helpers.c: Added
3055 modest_account_mgr_get_has_connection_specific_smtp().
3057 (modest_account_mgr_set_connection_specific_smtp),
3058 (modest_account_mgr_remove_connection_specific_smtp),
3059 (modest_account_mgr_get_has_connection_specific_smtp),
3060 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3061 connection-specific smtp server accounts in the account, rather than
3062 the server account conf dir.
3064 This fixes bug projects.maemo.org bug NB#58263 .
3066 * src/modest-tny-account-store.c:
3067 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3068 if there are no server accounts yet, to prevent an infinite loop when there
3069 are no accounts. Document that one must be called before the other.
3071 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3073 * src/modest-account-mgr-helpers.c:
3074 (modest_account_mgr_get_default_account): Make sure that at least
3075 one account is always the default, if there are any enabled accounts.
3076 This is just a sanity check that shouldn't be necessary.
3078 * src/modest-account-mgr-priv.c:
3079 (_modest_account_mgr_account_from_key): Unescape the conf key to
3080 get the real account name. For instance, this is an issue if a space
3081 was in the account name, which can happen because the account name
3082 is generated from the display name.
3083 (_modest_account_mgr_get_account_keyname): Always escape the
3085 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3086 Unescape the conf keys to get the real account names.
3088 For instance, previously the is-default radio button in the accounts
3089 list was not checked for any accounts at first. This fixes that,
3090 and might fix several similar bugs.
3092 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3094 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3095 Removed some debug printfs.
3097 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3099 Modest on-disk outbox directories are now here, for instance:
3100 $HOME/.modest/outboxes/<account-id-1>/outbox
3101 $HOME/.modest/outboxes/<account-id-2>/outbox
3103 $HOME/.modest/local-folders/outbox
3104 so we can have a separate outbox for each account.
3105 But they are shown as one outbox in the GtkTreeView, by using a
3106 TnyMergeFolder in a ModestTnySimpleFolderStore.
3109 * src/modest-tny-simple-folder-store.c:
3110 * src/modest-tny-simple-folder-store.h:
3111 Added ModestTnySimpleFolderStore, used to contain folders from
3112 other folder stores, such as other accounts.
3114 * src/modest-tny-outbox-account.h:
3115 * src/modest-tny-outbox-account.c:
3116 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3117 used for the per-account local outbox folders.
3119 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3120 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3121 only use this (internally) now for the non-outbox local folders.
3123 * src/modest-init.h:
3124 * src/modest-init.c: Added modest_init_one_local_folder(), for
3125 setting up the directory structure for each local folder.
3127 * src/modest-local-folder-info.c:
3128 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3129 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3131 * src/modest-local-folder-info.h:
3132 * src/modest-tny-account-store.c: (on_account_removed),
3133 (on_account_changed), (create_per_account_local_outbox_folders),
3134 (get_server_accounts), (modest_tny_account_store_get_accounts),
3135 (modest_tny_account_store_get_tny_account_by_account),
3136 (modest_tny_folder_store_is_virtual_local_folders):
3138 * src/modest-tny-account.h:
3139 * src/modest-tny-account.c:
3140 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3141 to create an on-disk per-account local outbox folder for each
3143 (create_per_account_local_outbox_folders): Create a local outbox folder
3144 for each transport account.
3145 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3146 for all local folders.
3148 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3149 instead of using g_object_get/set() directly. It is clearer.
3151 (modest_tny_folder_store_get_message_count),
3152 (modest_tny_folder_store_get_local_size
3153 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3154 because we now use these with non-acount folder stores.
3156 (modest_tny_account_get_special_folder),
3157 (modest_tny_account_new_from_server_account),
3158 (modest_tny_account_new_from_account):
3159 (recurse_folders): Adjust to the new outbox system.
3161 * src/modest-tny-folder.h:
3162 * src/modest-tny-folder.c:
3163 (modest_tny_folder_is_local_folder),
3164 (modest_tny_folder_get_local_folder_type),
3165 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3167 * src/widgets/modest-main-window.h:
3168 * src/maemo/modest-main-window.c: (create_details_widget),
3169 (modest_main_window_set_contents_style): Show details for any folder store,
3172 (modest_tny_folder_get_rules):
3173 Remove the const. C does not support constness enough for this.
3175 * src/modest-ui-actions.c:
3176 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3177 make all outboxes appear as one, in the usual local-folders tree node.
3179 (set_active_account_from_tny_account),
3180 (modest_ui_actions_on_folder_selection_changed):
3181 * src/widgets/modest-folder-view.c: (text_cell_data),
3182 (icon_cell_data), (filter_row),
3183 (add_account_folders_to_merged_folder),
3184 (add_account_folders_to_simple_folder_store), (),
3185 (get_cmp_rows_type_pos), (cmp_rows),
3186 (modest_folder_view_set_account_id_of_visible_server_account):
3187 Adjust to the new outbox system, using generic folder stores and folders
3188 in the GtkTreeModel.
3190 2007-05-23 Christian Kellner <ckellner@openismus.com>
3192 * src/modest-mail-operation.c:
3193 (modest_mail_operation_update_account):
3194 Use info->max_size instead of unintialized local var [small
3195 build fix]. (Added TODO to review that change since I don't
3198 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3200 * libmodest-dbus-client/libmodest-dbus-client.c:
3201 (libmodest_dbus_client_compose_mail): function added
3202 * src/dbus_api/modest-dbus-api.h:
3203 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3204 (on_compose_mail): Implementation of the SendAsMail functionality
3206 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-account-mgr.c:
3209 (modest_account_mgr_add_server_account): Set the secure-connection
3210 conf key for transport accounts as well as store accounts. I don't know
3211 why the if was there. For instance, this makes sure that we use SSL
3212 for the gmail preset from the easysetup wizard.
3214 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3216 * src/gnome/modest-main-window.c:
3217 (on_account_store_connecting_finished), (connect_signals):
3218 * src/maemo/modest-main-window.c:
3219 (on_account_store_connecting_finished), (connect_signals),
3220 (modest_main_window_new):
3221 Handle TnyAccountStore::connecting-finished instead of
3222 TnyDevice::connection-changed, because we cannot actually perform
3223 operations on accounts until TnyAccountStore has itself responded to
3224 the TnyDevice::connection-changed signal. This prevents a GError from
3226 Do not try to update at startup, because we (at least on scratchbox)
3227 already do an update at startup when the device goes online.
3228 This prevents a GError from tinymail.
3229 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3230 Added TODO about stopping simultaneous operations.
3232 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3234 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3235 * src/modest-mail-operation-queue.c:
3236 (modest_mail_operation_queue_remove):
3237 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3238 about where they happened.
3240 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3242 * src/modest-ui-actions.c:
3243 (modest_ui_actions_on_password_requested): Make sure that the remember
3244 output parameter is always TRUE.
3246 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3248 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3249 Show a OK/Cancel dialog if the error is a question, though we still do not
3250 know anything more about what we are asking the user.
3251 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3252 Fix an uninitialized variable (helper). This is a logic error, however.
3254 2007-05-21 Christian Kellner <ckellner@openismus.com>
3256 * src/modest-search.h:
3257 Correct bit shifting in the ModestSearchFlags enum.
3259 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3261 * src/modest-tny-account.c:
3262 (modest_tny_account_new_from_server_account): Do not use the lsub and
3263 check-all hard-coded IMAP options when using POP.
3265 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3267 * src/modest-tny-account.c:
3268 (modest_tny_account_new_from_server_account):
3269 Use NULL for the secure-auth method for POP when Password auth has been
3270 specified by the user, as we already do for IMAP. "auth=Login" causes
3271 an error from camel or the server.
3273 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/modest-account-settings-dialog.c:
3276 (create_page_account_details),
3277 (modest_account_settings_dialog_set_account_name):
3278 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3279 for the leave-on-server checkbox, rathr than just the checkbox, when
3280 the protocol is not POP.
3282 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3284 * src/widgets/modest-account-view.c:
3285 * src/widgets/modest-account-view.h:
3286 Added modest_account_view_select_account() which will be useful later
3287 to asynchronously re-select the edited account.
3289 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/modest-account-settings-dialog.c:
3292 (modest_account_settings_dialog_set_account_name):
3293 Automatically choose the port numbers based on the secure authentication
3294 methods, if they have not been chosen before.
3295 This fixes projects.maemo.org bug NB#56273 .
3297 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3299 * src/maemo/modest-main-window-ui.h:
3300 * src/modest-ui-actions.c:
3301 * src/modest-ui-actions.h:
3302 Connect the Tools/SMTP Servers menu item to
3303 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3304 SMTP servers dialog, as in the UI specification and saves changes when it
3305 is closed. This fixed projects.maemo.org bug NB#56305 .
3307 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3309 * src/maemo/modest-connection-specific-smtp-window.c:
3310 (modest_connection_specific_smtp_window_init):
3311 Use gtk_window_set_default_size() to make this window big enough, so
3312 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3314 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3316 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3317 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3318 (modest_connection_specific_smtp_edit_window_init),
3319 Do not try to connect to a combobox signal before the combobox exists.
3320 This fixes the cras in projects.maemo.org bug NB#56288 .
3321 (modest_connection_specific_smtp_edit_window_get_settings):
3322 Remove the server_account_name parameter which was being checked for NULL
3323 though it was not used.
3325 * src/maemo/modest-connection-specific-smtp-window.c:
3326 (modest_connection_specific_smtp_window_fill_with_connections),
3327 (on_button_edit), (modest_connection_specific_smtp_window_init):
3328 Correct the number of treemodel columns to prevent a warning.
3329 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3330 libconic does not work.
3332 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3334 * src/modest-tny-account.c:
3335 (modest_tny_account_new_from_server_account):
3336 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3337 SMTP when "None" was chosen by the user. However, with my SMTP server that
3338 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3341 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3343 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3344 to explain the memory management issue with the ID in the ModestPair.
3346 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3347 (add_sending_page), (modest_account_assistant_finalize):
3348 * src/gnome/modest-gnome-global-settings-dialog.c:
3349 (create_updating_page), (create_composing_page):
3350 * src/gnome/modest-msg-edit-window.c: (get_transports),
3351 (init_window), (modest_msg_edit_window_finalize),
3352 (modest_msg_edit_window_get_msg_data):
3353 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3354 * src/gnome/modest-transport-widget.c:
3355 (modest_transport_widget_finalize), (smtp_configuration):
3356 * src/maemo/modest-maemo-global-settings-dialog.c:
3357 (create_updating_page), (create_composing_page):
3358 * src/maemo/modest-msg-edit-window.c: (get_transports),
3359 (init_window), (modest_msg_edit_window_finalize),
3360 (modest_msg_edit_window_get_msg_data),
3361 (modest_msg_edit_window_free_msg_data):
3362 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3363 (modest_store_widget_finalize):
3364 * src/maemo/modest-transport-widget.c:
3365 (modest_transport_widget_finalize), (smtp_configuration):
3366 * src/modest-main.c: (send_mail):
3367 * src/widgets/modest-combo-box.h:
3368 * src/widgets/modest-global-settings-dialog-priv.h:
3369 * src/widgets/modest-global-settings-dialog.c:
3370 (modest_global_settings_dialog_finalize):
3371 * src/widgets/modest-msg-edit-window.h:
3372 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3373 as long as the combo box, to prevent use of freed memory for the ID.
3375 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3377 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3378 get_accounts(), to make this clearer. Do not check for the enabled gconf
3379 key, because we do not use this for server accounts (at least, not yet).
3380 This allows us to send email again.
3382 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3384 * src/maemo/modest-platform.c:
3385 (on_modest_conf_update_interval_changed), (modest_platform_init):
3386 Only respond to this particular key change. All these strcmp()s cannot be
3389 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3391 * src/maemo/modest-maemo-global-settings-dialog.c:
3392 (current_connection): Prevent a crash in scratchbox when
3393 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3394 * src/maemo/modest-platform.c:
3395 (on_modest_conf_update_interval_changed), (modest_platform_init):
3396 Get the update interval from gconf and reset it when the gconf key changes.
3398 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3400 * src/modest-protocol-info.c:
3401 * src/modest-protocol-info.h: Adde enum-specific get functions,
3402 instead of using a ModestProtocolType enum parameter.
3404 * src/gnome/modest-account-assistant.c:
3405 * src/gnome/modest-store-widget.c:
3406 * src/gnome/modest-store-widget.h:
3407 * src/gnome/modest-transport-widget.c:
3408 * src/gnome/modest-transport-widget.h:
3409 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3410 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3411 * src/maemo/easysetup/modest-easysetup-wizard.c:
3412 * src/maemo/modest-account-settings-dialog.c:
3413 * src/maemo/modest-account-settings-dialog.h:
3414 * src/maemo/modest-store-widget.c:
3415 * src/maemo/modest-store-widget.h:
3416 * src/maemo/modest-transport-widget.c:
3417 * src/maemo/modest-transport-widget.h:
3418 * src/modest-account-mgr-helpers.c:
3419 * src/modest-account-mgr-helpers.h:
3420 * src/modest-account-mgr.c:
3421 * src/modest-account-mgr.h:
3422 * src/modest-tny-account.c:
3423 * src/modest-tny-folder.c:
3424 * src/widgets/modest-account-view.c:
3425 * src/widgets/modest-retrieve-combo-box.c:
3426 * src/widgets/modest-retrieve-combo-box.h:
3427 * src/widgets/modest-secureauth-combo-box.c:
3428 * src/widgets/modest-serversecurity-combo-box.c:
3429 * src/widgets/modest-serversecurity-combo-box.h:
3430 * tests/check_account-mgr.c:
3431 Use the specific functions, and use the re-renamed enum values for GNOME too.
3433 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3435 * src/modest-pair.h:
3436 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3437 so we can get the second based on the first.
3439 * src/maemo/modest-account-settings-dialog.h:
3440 * src/maemo/modest-account-settings-dialog.c:
3441 Added get_supported_secure_authentication_methods(), though it is mostly
3442 commented-out for now until the necessary API is committed to tinymail.
3443 (modest_account_settings_dialog_set_account_name),
3444 (save_configuration): Request the supported authentication methods from the
3445 server, so we can choose a working method.
3447 * src/modest-tny-account-store.h:
3448 * src/modest-tny-account-store.c:
3449 (modest_tny_account_store_get_session): Rename from
3450 tny_account_store_get_session().
3452 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3454 * src/modest-protocol-info.h: Split the ModestProtocol enum
3455 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3456 There was no need to have these unrelated values in one enum.
3458 * src/: many files: Adapted to changed enum. This makes the code a bit
3459 clearer, and the compiler could catch some errors.
3461 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3463 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3464 Show the detailed internal camel error message when an error happens
3465 during the configuration, so that our testers can give us more clues.
3466 For instance, in projects.maemo.org bug NB#56910 .
3468 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3470 * src/modest-tny-account.c:
3471 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3472 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3474 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3476 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3477 * src/maemo/modest-account-settings-dialog.c:
3478 (modest_account_settings_dialog_set_account_name),
3479 (save_configuration): For the incoming secure authentication checkbox,
3480 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3481 the UI specification. PLAIN does not seem to be supported for most IMAP
3482 servers anyway, and I am not sure what it would mean.
3483 However, we probably need to discover which of the secure-authentication
3484 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3485 * src/modest-account-mgr-helpers.c:
3486 (modest_account_mgr_get_server_account_data):
3488 * src/modest-tny-account.c:
3489 (modest_tny_account_new_from_server_account):
3490 Use tny_account_set_mech() to set secure-authentication methods,
3491 with some special-casing for IMAP, based on my observations of how
3494 * src/modest-account-mgr-helpers.h:
3495 * src/modest-account-mgr.c:
3496 * src/modest-defs.h: Comment that the URI is only used for local folders.
3498 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3500 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3501 parameter const, just to be neat.
3502 * src/modest-text-utils.c: (modest_text_utils_inline):
3503 End g_strconcat() with NULL, as its documentation says. This is almost
3504 certainly the cause of my crash at startup on the device. Interestingly,
3505 valgrind doesn't tell us about these errors.
3507 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3509 * scripts/build-packages: Added more precise comments about how to use
3510 this script, though I still get this error:
3511 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3512 error building tinymail
3514 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3516 * src/maemo/modest-main-window.c: (on_account_update):
3517 Very slight cleanup, hoping to make it simpler to discover what causes
3518 a crash here sometimes.
3520 * src/modest-tny-account.c:
3521 (modest_tny_account_new_from_server_account): Set the port. Added
3522 comments about the options and a TODO comment because I need to find out
3523 how to specify the secure authentication method.
3525 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3527 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3528 changed CFlags paths form modest to libmodest
3530 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3532 * src/modest-account-mgr-helpers.c:
3533 (modest_account_mgr_get_server_account_data),
3534 (modest_account_mgr_free_server_account_data):
3535 * src/modest-account-mgr-helpers.h:
3536 * src/modest-account-mgr.c:
3537 (modest_account_mgr_add_server_account):
3538 * src/modest-defs.h:
3539 * src/modest-tny-account.c:
3540 (modest_tny_account_new_from_server_account):
3541 Determine the options for tny_camel_account_add_option() here,
3542 based on the settings, rather than storing them directly in gconf.
3544 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3546 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3547 Show a more friendly error dialog now that we expect (from the tinymail
3548 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3550 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3552 * src/maemo/modest-main-window.c: (on_account_update): Check that
3553 account_name is not NULL, to prevent a crash at startup that I am
3554 seeing on the N800. I do wonder why it is NULL.
3556 * src/maemo/easysetup/modest-easysetup-wizard.c:
3557 (create_page_user_details):
3558 * src/maemo/modest-account-settings-dialog.c:
3559 (create_page_user_details), (create_page_outgoing):
3560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3561 (modest_connection_specific_smtp_edit_window_init):
3562 * src/modest-ui-actions.c:
3563 (modest_ui_actions_on_password_requested):
3564 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3565 might do something useful with the on-screen keyboard.
3567 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3569 * src/maemo/modest-main-window.c: (on_account_update):
3570 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3571 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3573 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3575 * src/modest-tny-account-store.c: (on_account_changed):
3576 Correct the signature of this signal handler.
3578 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3580 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3581 Show a HildonNote instead of a GtkDialog for Maemo.
3583 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3585 * src/widgets/modest-account-view.h:
3586 * src/widgets/modest-account-view.c: (on_account_changed),
3587 (on_account_removed). Added a boolean flag, set/unset by
3588 modest_account_view_block_conf_updates(),
3589 modest_account_view_unblock_conf_updates() to prevent unnecessary
3590 updates, but this is not very useful because the gconf notifications are
3591 so delays (maybe only on Maemo Bora).
3592 So auto-updating is turned off, and these functions do an explicit
3593 update when necessary.
3594 However, something else is still doing too much work when adding/removing
3595 accounts, probably in another part of the application.
3597 * src/maemo/modest-account-view-window.c:
3598 (on_delete_button_clicked), (on_edit_button_clicked),
3599 (on_new_button_clicked): Use the new functions.
3601 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3603 * src/modest-account-mgr-helpers.c:
3604 (modest_account_mgr_set_first_account_as_default):
3605 Sort the list of names alphabetically-by-title, so we choose the first one
3607 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3608 alphabetically by the title.
3610 This fixes projects.maemo.org bug NB#56418 .
3612 * src/modest-account-mgr-priv.c:
3613 (_modest_account_mgr_account_from_key):
3614 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3615 avoid a valgrind error, and possible random behaviour.
3617 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3619 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3620 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3621 tinymail documentation to say that this can be expected.
3622 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3623 pretty, and should not happen, but I would prefer to know when it does.
3625 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3627 * configure.ac: When using the older hildon version, probably on Bora,
3628 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3630 * src/widgets/modest-attachment-view.c:
3631 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3634 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3636 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3637 Implemented the prototype. Can be tested with
3638 tests/dbus_api/test_open_message:
3640 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3642 * src/modest-tny-account-store.c:
3643 (modest_tny_account_store_instance_init), (get_password):
3644 * src/modest-ui-actions.c:
3645 (modest_ui_actions_on_password_requested):
3646 Do not store the password in gconf, because this function is called
3647 for non-remembered passwords. Actually use the cached (in the hash map)
3648 password instead of releasing it.
3649 The password will now not be remembered if it is asked via the protected
3650 password dialog, as per the UI spec.
3652 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3654 * src/modest-defs.h:
3655 * src/modest-account-mgr-helpers.h:
3656 * src/modest-account-mgr-helpers.c:
3657 Added modest_server_account_get_username_has_succeeded(),
3658 modest_server_account_set_username_has_succeeded().
3659 (modest_server_account_set_username),
3660 Reset the has-succeeded flag if the username changes.
3662 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3663 * src/maemo/modest-connection-specific-smtp-window.c:
3664 (modest_connection_specific_smtp_window_save_server_accounts):
3665 Use modest_server_account_set_username() instead of using
3666 modest_conf_set_string() directly, so that the has-succeeded flag is always
3669 * src/modest-ui-actions.c:
3670 (modest_ui_actions_on_password_requested): Dim the username entry if
3671 the username has ever worked, as per the UI spec.
3673 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3675 * src/modest-tny-account-store.c: (get_password):
3676 * src/modest-ui-actions.c:
3677 (modest_ui_actions_on_password_requested):
3678 Allow the username to be changed too, though there is more work to
3679 be done on exactly how this behaves.
3681 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3683 * src/modest-account-mgr-helpers.h:
3684 * src/modest-account-mgr-helpers.c:
3685 Added modest_account_mgr_get_display_name(),
3686 modest_server_account_get_username(),
3687 modest_server_account_set_username(),
3688 modest_server_account_set_password(),
3689 modest_server_account_get_hostname() functions so we do not need to
3690 use the conf API directly.
3692 * src/maemo/modest-main-window.c: (connect_signals):
3693 Actually connect ot the ModestAccountStore::request-password signal,
3694 so that we show the dialog when the password is requested by Tinymail,
3695 for isntance if it is empty.
3697 * src/modest-marshal.list:
3698 * src/modest-tny-account-store.c:
3699 (modest_tny_account_store_class_init), (get_password),
3700 (modest_tny_account_store_alert):
3701 * src/modest-tny-account-store.h:
3702 * src/modest-ui-actions.h:
3703 * src/modest-ui-actions.c:
3704 (modest_ui_actions_on_password_requested):
3705 Change the signal parameters, so it is obvious that we are providing
3706 the non human-readable server name, and receiving both the username
3707 and password, though changing of the username is not yet implemented.
3708 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3709 for the GNOME version.
3711 This should fix the projects.maemo.org bug NB#56209, though it does not
3712 work on Bora, because the gconf_client_get() for the password fails
3713 immediately after we save it with gconf_client_set().
3715 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3718 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3719 caused an undefined symbol error:
3720 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3722 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3724 * src/modest-tny-account-store.c:
3725 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3726 using a GError instead of a string message, so we can translate it in
3729 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3731 * src/maemo/modest-address-book.c:
3732 (modest_address_book_check_names):
3733 * src/maemo/modest-msg-view-window.c:
3734 (modest_msg_view_window_clipboard_owner_change):
3735 * src/modest-init.c: (modest_init_init_ui):
3736 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3737 (update_folders_cb), (modest_mail_operation_update_account):
3738 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3739 (modest_ui_actions_on_msg_attachment_clicked),
3740 (modest_ui_actions_on_msg_recpt_activated):
3741 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3742 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3743 (modest_msg_view_search_next):
3744 * src/widgets/modest-recpt-editor.c:
3745 (modest_recpt_editor_on_button_release_event),
3746 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3747 g_message(). At this point we should only be seeing interesting errors on
3748 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3750 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3752 (modest_wizard_dialog_force_title_update):
3753 * src/maemo/easysetup/modest-wizard-dialog.h:
3754 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3755 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3756 can update the title when appropriate. Otherwise the title is wrong if the
3757 pages are added after adding the notebook to the dialog.
3758 This must be a problem in HildonWizardDialog too.
3759 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3761 * src/maemo/easysetup/modest-easysetup-wizard.c:
3762 (create_subsequent_customsetup_pages),
3763 (create_subsequent_easysetup_pages):
3764 Call modest_wizard_dialog_force_title_update() so that the title is
3765 correct even with GTK+ < 2.10.
3766 This fixes projects.maemo.org bug NB#56145 .
3768 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3770 * src/maemo/modest-platform.c:
3771 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3772 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3775 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3777 * src/widgets/modest-window.h:
3778 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3779 and modest_window_save_state(), which invokes it.
3781 * src/widgets/modest-window-mgr.h:
3782 * src/widgets/modest-window-mgr.c:
3783 Added modest_window_mgr_save_state_for_all_windows(), which calls
3784 the save_state vfunc on all registered windows, if implemented.
3786 * src/gnome/modest-msg-edit-window.c:
3787 * src/gnome/modest-msg-view-window.c:
3788 * src/maemo/modest-msg-edit-window.c:
3789 * src/maemo/modest-msg-view-window.c:
3790 * src/maemo/modest-main-window.c:
3791 Specify the existing save_settings functions as implementations of
3792 ModestWindow::save_state_func().
3794 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3795 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3796 enabling hibernation, for instance.
3798 We may need to do the same thing for restoring settings.
3801 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3803 * src/widgets/modest-window-mgr.c:
3804 * src/widgets/modest-window-mgr.h:
3805 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3806 modest_window_mgr_get_hibernation_is_prevented().
3808 * src/maemo/modest-main-window.c:
3809 (on_hildon_program_is_topmost_notify): Prevent hibernation
3810 (possible when the application goes to the background in the WM),
3811 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3813 * src/maemo/easysetup/modest-easysetup-wizard.c:
3814 (modest_easysetup_wizard_dialog_init):
3815 * src/maemo/modest-account-settings-dialog.c:
3816 (modest_account_settings_dialog_init):
3817 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3818 (modest_connection_specific_smtp_edit_window_init):
3819 * src/maemo/modest-connection-specific-smtp-window.c:
3820 (modest_connection_specific_smtp_window_init):
3821 * src/maemo/modest-signature-editor-dialog.c:
3822 (modest_signature_editor_dialog_init):
3823 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3824 prevent hibernation while any of these account settings dialogs are open.
3826 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3828 * src/maemo/Makefile.am:
3829 * src/maemo/modest-osso-state-saving.c:
3830 * src/maemo/modest-osso-state-saving.h: Added
3831 modest_osso_load_state() and modest_osso_save_state() though they do
3832 nothing now. They should iterate through all the open windows and load/save
3834 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3835 save state when closing.
3837 * src/maemo/modest-main-window.c:
3838 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3839 Add a notification handler for the HildonProgram::is-topmost property,
3840 so we can allow hibernation when the application goes into the background.
3841 But we still need to detect when the accounts setup windows are open so
3842 we can stop hibernation when they are open.
3843 To do this, I also added the main window the HildonProgram. This might have
3844 other side-effects/benefits, and should maybe be done for other windows.
3846 * src/maemo/modest-osso-autosave-callbacks.h:
3847 * src/maemo/modest-osso-autosave-callbacks.c:
3848 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3849 though it does not do anything yet, and we might never need this to do
3850 anything. For instance, we already save drafts.
3852 * src/maemo/modest-platform.c: (modest_platform_init):
3853 Specify the libosso auto-save callback.
3855 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3857 * src/maemo/modest-platform.c:
3858 (modest_platform_set_update_interval):
3859 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3860 aparently stays valid between application instances, so we can use this
3861 to remove and reset it later. According to a maemo-developers email from
3864 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3866 * configure.ac: Depend on libalarm for Maemo.
3868 * src/dbus_api/modest-dbus-api.h:
3869 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3870 (on_send_receive), (modest_dbus_req_handler):
3871 Handle a SEND_RECEIVE D-Bus method.
3873 * libmodest-dbus-client/libmodest-dbus-client.c:
3874 (libmodest_dbus_client_send_and_receive):
3875 * libmodest-dbus-client/libmodest-dbus-client.h:
3876 Add C convenience functions for calling the new D-Bus method.
3878 * src/modest-platform.h:
3879 * src/gnome/modest-platform.c:
3880 * src/maemo/modest-platform.c:
3881 Added modest_platform_set_update_interval(), which uses the
3882 alarmd API on Maemo.
3883 (modest_platform_init),
3884 Call modest_platform_set_update_interval(), using a hard-coded
3885 interval for now (until the global settings dialog is implemented),
3886 though I am not sure that this makes sense yet.
3888 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3890 * src/dbus_api/modest-dbus-callbacks.c:
3891 (modest_osso_cb_hw_state_handler):
3892 * src/dbus_api/modest-dbus-callbacks.h:
3893 * src/maemo/modest-platform.c: (modest_platform_init):
3894 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3895 in case this has some effect on the ability for Maemo to ping the
3898 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3900 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3901 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3902 warning. It is probably a logic error, but I need to fix the build.
3904 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3906 * src/modest-account-mgr.h:
3907 * src/modest-account-mgr.c:
3908 (modest_account_mgr_account_names): Add a gboolean enabled_only
3909 parameter, so we can get lists of onlt the enabled accounts.
3911 (modest_account_mgr_add_account),,
3912 (modest_account_mgr_account_with_display_name_exists):
3913 * src/maemo/modest-msg-edit-window.c: (get_transports):
3914 * src/modest-account-mgr-helpers.c:
3915 (modest_account_mgr_set_first_account_as_default):
3916 * src/modest-init.c: (init_default_account_maybe):
3917 * src/modest-tny-account-store.c: (get_accounts):
3918 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3919 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3920 * tests/check_account-mgr.c: (START_TEST):
3921 Provide the extra parameter, as appropriate.
3923 * src/widgets/modest-account-view.c: (update_account_view):
3924 Do not show disabled accounts (meaning that there is no way to
3925 enable/disable accounts in the UI (the feature is not in our UI
3926 specification), so we can use this internally only to mark unfinished
3927 or temporary account data.
3929 * src/maemo/easysetup/modest-easysetup-wizard.c:
3930 (create_account): Add boolean enable parameter, so we can specify FALSE
3931 to create the temporary account.
3932 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3933 (on_before_next): When finishing, when there is a temporary account, just
3935 Also, use a timeout to delay the showing of the dialog until gconf is likely
3936 to return correct information, due to a maemo gconf bug that is fixed in
3937 osso 1.1, but not yet in Bora.
3938 However, the dialog stays on screen after it is destroyed.
3940 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3941 for invalid data when cancelling. Use a hildon note instead of a dialog
3942 to complain about invalid data. Do not show the account-saved note if the
3943 account is disabled (a temporary account that will not really be saved for use
3946 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3948 * src/modest-account-mgr-helpers.h:
3949 * src/modest-account-mgr-helpers.c:
3950 Added modest_account_mgr_unset_default_account(),
3951 Added modest_account_mgr_set_first_account_as_default().
3953 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3954 If it was the default account, unset the default account name.
3956 * src/maemo/modest-account-view-window.c:
3957 (on_delete_button_clicked): If it was the default account,
3958 set the first remaining account as the default instead.
3960 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3961 a NULL account or a NULL default account, to prevent a crash. This should
3962 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3965 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3967 * src/widgets/modest-recpt-editor.c:
3968 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3969 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3970 TODO comment for this. This fixes the build.
3972 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3973 be the best place for it. This will in future update all auto-update accounts,
3974 rather than just the current/default account, when that gconf key exists.
3975 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3976 if there are no accounts, before calling do_send_receive().
3977 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3979 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3980 * src/maemo/modest-main-window-ui.h:
3981 * src/maemo/modest-main-window.c: (on_connection_changed),
3982 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3983 directly, becaue the signal handler does more.
3985 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3987 * src/modest-account-mgr-helpers.c:
3988 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3989 for the case that the account does not exist.
3991 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3992 (equivalent to the modest account name) rather than the tinymail account name
3993 (equivalent to the modest account title - human readable) to get the account data.
3994 Check for null account data to prevent the crash, and add a TODO comment saying that
3995 this needs fixing because it is using the server account name instead of the account name.
3997 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3999 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
4000 * src/maemo/modest-account-settings-dialog.c: (show_error),
4002 Use hildon_note_new_information() for informative and error messages,
4003 which seems to be expected for Maemo applications (no documentation that I know of
4004 says this). I am surprised that there is no distinction between info and error
4007 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4009 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
4010 it is easy to find where this is used.
4012 * src/maemo/easysetup/modest-easysetup-wizard.c:
4013 (create_page_welcome), (create_page_account_details),
4014 (create_page_user_details), (create_page_complete_easysetup),
4015 (create_page_custom_incoming), (create_page_custom_outgoing),
4016 (create_page_complete_custom):
4017 * src/maemo/modest-account-settings-dialog.c:
4018 (create_page_account_details), (create_page_user_details),
4019 (create_page_incoming), (create_page_outgoing):
4020 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4022 (modest_connection_specific_smtp_edit_window_init):
4023 * src/maemo/modest-connection-specific-smtp-window.c:
4024 (modest_connection_specific_smtp_window_init):
4025 * src/maemo/modest-signature-editor-dialog.c:
4026 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4027 and scrolling policy as per the Email Application Layout Guide, if I have
4030 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4032 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4033 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4034 which were empty, because these vfuncs have been removed from TnyAccountStore.
4035 This fixes the build.
4037 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4039 * src/maemo/modest-main-window.c:
4040 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4041 showing/hiding it. Added TODO because it probably should not be NULL.
4042 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4043 because unnecessary g_warnings() make degugging difficult.
4045 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4047 * src/maemo/modest-msg-edit-window.c:
4048 (modest_msg_edit_window_select_color),
4049 (modest_msg_edit_window_select_background_color): 2 const corrections and
4050 moving 2 #endifs before closing brackets, to fix the build.
4052 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4054 * src/maemo/easysetup/modest-easysetup-wizard.h:
4055 * src/maemo/easysetup/modest-easysetup-wizard.c:
4056 (modest_easysetup_wizard_dialog_finalize),
4057 (on_button_edit_advanced_settings), (create_page_complete_custom),
4058 (on_response), (create_account):
4059 Implement the Advanced Settings edit button, by saving the account information,
4060 for the Advanded Settings dialog to use directly from gconf, and removing it
4061 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4062 Bug #5533 in the projects.maemo.org bugzilla.
4064 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4066 * src/maemo/modest-msg-view-window.c:
4067 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4068 when opening a message window.
4070 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4072 * src/maemo/easysetup/modest-easysetup-wizard.c:
4073 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4076 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4077 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4078 gconf settings. I probably added more checks than necessary, but that is safer.
4080 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4081 variable to fix the build, but this seems to be used when it is still NULL.
4083 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4085 * src/modest-platform.h:
4086 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4087 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4088 * src/modest-main.c: Implement this function so we can avoid using
4089 maemo-specific API from cross-platform code.
4091 * src/modest-tny-account-store.c:
4092 (get_smtp_specific_transport_account_for_open_connection):
4093 * src/modest-ui-actions.c: (check_for_connection),
4094 (modest_ui_actions_on_item_not_found):
4095 Use modest_platform_connect_and_wait() and put #idefs around other
4096 maemo-specific code, because only maemo currently has a way to
4097 identify connection names.
4099 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4101 * src/modest-tny-account-store.h:
4102 * src/modest-tny-account-store.c:
4103 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4104 the connection-specific SMTP server settings in the configuration.
4106 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4108 * src/maemo/modest-main-window.c: (on_connection_changed),
4110 * src/modest-main.c: (main), (start_ui), (send_mail):
4111 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4112 that is what is intended.
4114 * src/modest-ui-actions.c: (action_send), (action_receive),
4115 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4116 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4117 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4118 SMTP server is used when it is specified.
4120 (modest_ui_actions_on_send_receive):
4121 Check that a connection is open before proceeding.
4122 Receive and then send, instead of vice-versa, as per the specification.
4124 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4126 * src/modest-mail-operation.c:
4127 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4128 though I guess it should be something other than NULL.
4130 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4132 * src/maemo/easysetup/modest-easysetup-wizard.c:
4133 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4134 combo twice, to avoid an g_warning and to make it visible again.
4135 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4136 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4137 (already intended) dereference when detaching, because we then recreate the menu.
4138 But I am not sure why the warning was happening, and it is possible that this is a memory
4141 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4143 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4144 and uri_parse_mailto() utility functions.
4145 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4147 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4149 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4151 * src/dbus_api/modest-dbus-api.h:
4152 * src/dbus_api/modest-dbus-callbacks.c:
4153 Use an idle callback to execute the modest code in the application's own thread.
4154 Remove the helloworld example method.
4155 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4156 parsed, and the open-message method is not implemented because this is not yet implemented in
4158 * libmodest-dbus-client/libmodest-dbus-client.c:
4159 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4160 (libmodest_dbus_client_open_message):
4161 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4163 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4164 body without crashing.
4166 * tests/dbus_api/Makefile.am:
4167 * tests/dbus_api/test_mail_to.c:
4168 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4170 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4172 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4173 Added file to fix the build. Sorry.
4175 * src/dbus_api/Makefile.am:
4176 * src/dbus_api/modest-dbus-api.h:
4177 * src/dbus_api/modest-dbus-callbacks.h:
4178 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4179 (modest_dbus_req_handler):
4180 Put constants in a separate header so it can be reused by the
4181 client library, without duplication
4183 * libmodest-dbus-client/Makefile.am:
4184 * libmodest-dbus-client/libmodest-dbus-client.c:
4185 (libmodest_dbus_client_call_helloworld),
4186 (libmodfest_dbus_client_send_mail),
4187 (libmodfest_dbus_client_mailto),
4188 (libmodfest_dbus_client_open_message):
4189 * libmodest-dbus-client/libmodest-dbus-client.h:
4190 (Partly) Implement a send_mail D-Bus method.
4192 * tests/dbus_api/Makefile.am:
4193 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4194 the send_email D-Bus method.
4196 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4200 * libmodest-dbus-client/Makefile.am:
4201 * libmodest-dbus-client/libmodest-dbus-client.c:
4202 * libmodest-dbus-client/libmodest-dbus-client.h:
4203 * tests/dbus_api/Makefile.am:
4204 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4205 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4207 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4209 * src/maemo/easysetup/modest-easysetup-wizard.c:
4210 (create_page_account_details):
4211 * src/maemo/modest-account-settings-dialog.c:
4212 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4213 widgets, because this might not be the default in future versions of the Maemo GTK+.
4214 However, I can not not get capitalization to work even in a simple test case.
4216 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4218 * src/maemo/easysetup/modest-easysetup-wizard.c:
4219 (create_page_custom_incoming), (create_page_custom_outgoing):
4220 * src/maemo/modest-account-settings-dialog.c:
4221 (create_page_account_details), (create_page_incoming),
4222 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4223 instead of using gtk_check_button_with_label(), so they are aligned like the other
4224 widgets, as per the UI spec.
4226 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4228 * src/maemo/easysetup/modest-easysetup-wizard.c:
4229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4230 * src/widgets/modest-validating-entry.c:
4231 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4232 Modest prefix instead of an EasySetup prefix.
4234 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4236 * src/widgets/modest-validating-entry.h:
4237 * src/widgets/modest-validating-entry.c: (on_insert_text),
4238 Added easysetup_validating_entry_set_max_func(), used to set a callback
4239 to call when the max number of characters is reached. GtkEntry has a max-length
4240 already but is silent about it.
4242 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4243 (create_page_account_details), (create_page_user_details),
4245 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4246 (create_page_account_details), (create_page_user_details),
4247 (create_page_outgoing):
4248 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4249 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4250 the UI spec, when the user tries to enter more than the max number of characters.
4252 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/easysetup/modest-easysetup-wizard.c:
4255 (create_page_user_details), (create_page_custom_incoming),
4256 (create_page_custom_outgoing):
4257 * src/maemo/modest-account-settings-dialog.c:
4258 (create_page_user_details), (create_page_incoming),
4259 (create_page_outgoing):
4260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4261 (modest_connection_specific_smtp_edit_window_init):
4262 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4263 not appropriate. Bad Maemo-specific defaults!.
4265 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4267 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4268 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4269 (modest_signature_editor_dialog_set_settings):
4270 Disable the label and textview when the checkbox is disabled, and use the
4271 specified (UI spec) default signature text.
4273 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4275 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4276 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4278 * src/modest-defs.h:
4279 * src/modest-account-mgr-helpers.h:
4280 * src/modest-account-mgr-helpers.c:
4281 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4283 * src/maemo/Makefile.am:
4284 * src/maemo/modest-signature-editor-dialog.c:
4285 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4288 * src/maemo/modest-account-settings-dialog.h:
4289 * src/maemo/modest-account-settings-dialog.c:
4290 (modest_account_settings_dialog_finalize), (on_button_signature),
4291 (save_configuration): Use the new dialog when the Edit button is pressed, and
4292 save the changes if necessary, as per the UI spec.
4294 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4296 * src/maemo/Makefile.am:
4297 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4298 based on maemo-develoers email from Dirk.
4300 * src/maemo/easysetup/modest-easysetup-wizard.c:
4301 (create_page_welcome), (create_page_account_details),
4302 (create_page_user_details), (create_page_complete_easysetup),
4303 (create_page_custom_incoming), (create_page_custom_outgoing),
4304 (create_page_complete_custom),
4305 (modest_easysetup_wizard_dialog_init):
4306 * src/maemo/modest-account-settings-dialog.c:
4307 (create_page_account_details), (create_page_user_details),
4308 (create_page_incoming), (create_page_outgoing),
4309 (modest_account_settings_dialog_init):
4310 * src/maemo/modest-connection-specific-smtp-window.c:
4311 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4313 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4315 * src/maemo/easysetup/modest-easysetup-wizard.c:
4316 (create_page_account_details), (create_page_custom_outgoing),
4317 (create_page_complete_custom):
4318 * src/maemo/modest-account-settings-dialog.c:
4319 (create_page_user_details), (create_page_incoming),
4320 (create_page_outgoing):
4321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4322 (modest_connection_specific_smtp_edit_window_init):
4323 Use the correct (UI spec) port min/max, and use horizontal separators,
4326 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4328 * src/maemo/easysetup/modest-easysetup-wizard.c:
4329 (set_default_custom_servernames):
4330 * src/maemo/modest-account-settings-dialog.c:
4331 (create_page_incoming), (on_combo_outgoing_security_changed),
4332 (on_combo_incoming_security_changed), (create_page_outgoing),
4333 (modest_account_settings_dialog_set_account_name),
4334 (save_configuration):
4335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4336 (on_combo_security_changed),
4337 (modest_connection_specific_smtp_edit_window_init),
4338 (modest_connection_specific_smtp_edit_window_set_connection),
4339 (modest_connection_specific_smtp_edit_window_get_settings):
4340 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4343 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4346 * src/maemo/easysetup/modest-easysetup-wizard.c:
4347 (create_page_custom_outgoing), (create_page_complete_custom):
4348 * src/maemo/modest-account-settings-dialog.c:
4349 (create_page_user_details), (create_page_outgoing):
4350 * src/maemo/modest-account-view-window.c: (button_box_new):
4351 Use changed logical IDs as per the most recent UI spec:
4352 mcen_bd_emailsetup_edit -> mcen_bd_edit
4353 mcen_bd_emailsetup_delete -> mcen_bd_delete
4354 mcen_bd_emailsetup_close -> mcen_bd_close
4356 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4360 * src/dbus_api/Makefile.am:
4361 * src/dbus_api/modest-dbus-callbacks.c:
4362 * src/dbus_api/modest-dbus-callbacks.h:
4363 * src/maemo/modest-platform.c: (modest_platform_init):
4364 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4366 * tests/Makefile.am:
4367 * tests/dbus_api/Makefile.am:
4368 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4370 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4372 * src/maemo/modest-account-settings-dialog.c:
4373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4374 Removed unnecessary includes.
4376 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4378 * src/maemo/easysetup/modest-easysetup-wizard.c:
4379 * src/maemo/modest-account-settings-dialog.c:
4380 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4381 * src/widgets/Makefile.am:
4382 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4383 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4384 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4385 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4386 * src/widgets/modest-secureauth-combo-box.c:
4387 * src/widgets/modest-secureauth-combo-box.h:
4388 * src/widgets/modest-serversecurity-combo-box.c:
4389 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4390 made the GObject names more consistent with the rest of the Modest code.
4392 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4394 * src/maemo/easysetup/Makefile.am:
4395 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4396 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4397 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4398 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4399 * src/maemo/easysetup/modest-easysetup-wizard.c:
4400 * src/maemo/easysetup/modest-validating-entry.c:
4401 * src/maemo/easysetup/modest-validating-entry.h:
4402 * src/maemo/modest-account-settings-dialog.c:
4403 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4404 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4405 widgets/ because they are used outside of easysetup too. After checking in,
4406 svn will allow me to rename them too.
4408 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4410 * src/gnome/modest-msg-edit-window.c:
4411 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4412 linker error, to fix the build on the GNOME platform.
4413 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4414 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4415 ifdefed out to avoid a warning.
4417 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4419 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4420 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4421 some alternative for GTK+ 2.6.
4423 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4425 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4427 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4428 specified for EmailAccountsDialog in UI spec.
4430 * src/maemo/easysetup/modest-easysetup-wizard.c:
4431 * src/maemo/easysetup/modest-easysetup-wizard.h:
4432 * src/maemo/modest-account-settings-dialog.c:
4433 * src/maemo/modest-account-settings-dialog.h:
4434 Reuse a member window widget for the connection-specific SMTP server accounts,
4435 so we can tell it to create/save the accounts only if we actually save changes.
4437 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4438 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4439 (modest_connection_specific_smtp_edit_window_get_settings):
4440 Return a struct instance for temporarily remembering the entered data.
4442 * src/maemo/modest-connection-specific-smtp-window.h:
4443 * src/maemo/modest-connection-specific-smtp-window.c:
4444 (modest_connection_specific_smtp_window_finalize),
4445 (modest_connection_specific_smtp_window_fill_with_connections),
4447 (modest_connection_specific_smtp_window_save_server_accounts),
4448 (update_model_server_names): Do not actually save data until asked,
4449 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4451 (on_selection_changed),
4452 (modest_connection_specific_smtp_window_init): Disable the edit
4453 button when nothing is selected.
4455 * src/modest-account-mgr-helpers.c:
4456 * src/modest-account-mgr-helpers.h:
4457 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4460 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4462 * src/modest-account-mgr-helpers.h:
4463 * src/modest-account-mgr-helpers.c:
4464 (modest_account_mgr_get_unused_account_name),
4465 (modest_account_mgr_get_unused_account_display_name): Added these
4466 utility functions, to avoid code duplication.
4468 * src/maemo/easysetup/modest-easysetup-wizard.c:
4469 (create_page_account_details), (create_account):
4470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4471 (on_combo_security_changed),
4472 (modest_connection_specific_smtp_edit_window_init),
4473 (modest_connection_specific_smtp_edit_window_save_settings):
4474 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4475 * src/maemo/modest-connection-specific-smtp-window.c:
4476 (modest_connection_specific_smtp_window_finalize),
4477 (modest_connection_specific_smtp_window_fill_with_connections),
4478 (on_button_edit), (modest_connection_specific_smtp_window_init):
4479 * src/maemo/modest-connection-specific-smtp-window.h:
4480 Implementing saving of connection-specific server accounts.
4482 But I need to refactor this so we can save the data for each
4483 possible connection-specific account and only actually create the server accounts
4484 when the easysetup finished, or the OK button is pressed on the account settings
4487 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4490 (on_combo_security_changed):
4491 (modest_connection_specific_smtp_edit_window_init):
4492 Auto-fill the port number as in the account settings.
4494 (modest_connection_specific_smtp_edit_window_set_connection):
4495 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4496 * src/maemo/modest-connection-specific-smtp-window.c:
4497 (fill_with_connections), (on_button_edit),
4498 (modest_connection_specific_smtp_window_init):
4499 Turn the edit window into a dialog to simplify the code, and
4500 set a WM hint as in a GtkDialog, because only a popup can be on top of
4501 another window in Maemo, and popups usually have no WM decoration.
4503 * src/modest-defs.h:
4504 * src/modest-account-mgr-helpers.c:
4505 (modest_account_mgr_set_connection_specific_smtp),
4506 (modest_account_mgr_remove_connection_specific_smtp),
4507 (modest_account_mgr_get_connection_specific_smtp):
4508 * src/modest-account-mgr-helpers.h: Some functions to write the
4509 connection-specific SMTP server information. Not yet used.
4512 * src/widgets/modest-folder-view.c: (text_cell_data):
4513 Fix a warning about an uninitialized variable.
4514 (on_configuration_key_changed): Put an #ifdef around the use
4515 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4517 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4519 * src/maemo/modest-account-settings-dialog.h:
4520 * src/maemo/modest-account-settings-dialog.c:
4521 Added connect_for_modified() utility function to mark the new modified boolean.
4523 (create_page_account_details), (create_page_user_details),
4524 (create_page_incoming), (create_page_outgoing), (on_response),
4525 (modest_account_settings_dialog_init),
4526 (modest_account_settings_dialog_set_account_name):
4527 Only warn about unsaved changes when there are actually unsaved changes.
4529 * src/modest-account-mgr-helpers.c:
4530 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4531 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4532 to get the data from there in future.
4534 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4536 * src/modest-defs.h:
4538 * src/modest-account-mgr-helpers.h:
4539 * src/modest-account-mgr-helpers.c:
4540 Store the security account setting in a single conf key instead of using
4541 the options list, so that the list is left for just the to-be-removed camel hack,
4542 and because gconf_client_set_list() is failing for some reason.
4544 * src/modest-account-mgr.c:
4545 (modest_account_mgr_add_server_account):
4546 * src/maemo/modest-account-settings-dialog.c:
4547 (modest_account_settings_dialog_set_account_name),
4548 (save_configuration): Use the renamed functions.
4551 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4553 * src/widgets/Makefile.am:
4554 * src/widgets/modest-limit-retrieve-combo-box.c:
4555 * src/widgets/modest-limit-retrieve-combo-box.h:
4556 * src/widgets/modest-retrieve-combo-box.c:
4557 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4558 the account settings dialog.
4560 * src/modest-defs.h:
4561 * src/modest-account-mgr-helpers.h:
4562 * src/modest-account-mgr-helpers.c:
4563 (modest_server_account_get_option_secure_auth),
4564 (modest_server_account_set_option_secure_auth):
4565 * src/modest-account-mgr.c:
4566 (modest_account_mgr_add_server_account):
4567 Use the existing AUTH_MECH conf key for the secure-auth setting,
4568 instead of putting it in the list options, because this was actually used already.
4570 * src/maemo/modest-account-settings-dialog.c:
4571 (create_page_account_details),
4572 (modest_account_settings_dialog_set_account_name),
4573 (save_configuration):
4574 * src/maemo/modest-account-settings-dialog.h:
4575 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4576 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4578 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4580 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4581 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4582 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4584 * src/modest-defs.h:
4585 * src/maemo/modest-account-settings-dialog.c:
4586 (create_page_incoming), (on_combo_outgoing_security_changed),
4587 (on_combo_incoming_security_changed), (create_page_outgoing),
4588 (modest_account_settings_dialog_set_account_name),
4589 (save_configuration): Load/Save the port number, and change it when the
4590 security combo changes, to suitable defaults.
4592 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4594 * src/modest-account-mgr.c:
4595 (modest_account_mgr_add_server_account): Set the security and secure-auth
4596 options, and add a comment saying that the other camel-specific options should be
4599 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4601 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4603 * src/modest-tny-account-store.c: (account_list_free),
4604 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4605 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4608 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4610 * src/modest-protocol-info.c:
4611 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4612 is required by our UI spec. Maybe something in our implementation will use this eventually.
4613 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4614 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4615 instead of the previous 0 placeholder.
4617 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4618 secure-auth settings.
4619 * src/modest-account-mgr-helpers.h:
4620 * src/modest-account-mgr-helpers.c:
4621 (modest_server_account_data_get_option_secure_auth),
4622 (modest_server_account_set_option_secure_auth),
4623 (modest_server_account_data_get_option_security),
4624 (modest_server_account_set_option_security): Added this API for getting and setting the security
4625 and secure-auth settings.
4627 * src/maemo/modest-account-settings-dialog.h:
4628 * src/maemo/modest-account-settings-dialog.c:
4629 (modest_account_settings_dialog_finalize), (check_data),
4630 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4631 about changing titles.
4632 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4633 (save_configuration): Save the security and secure-auth settings.
4635 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4636 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4638 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4640 * src/modest-defs.h:
4641 * src/modest-account-mgr.c:
4642 (modest_account_mgr_add_server_account):
4643 Added and used defines for the options key and value pair strings,
4644 that are used so far, though they do not seem to correspond to anything in our
4645 UI specs or ModestProtocol enum.
4647 * src/modest-account-mgr-helpers.h:
4648 * src/modest-account-mgr-helpers.c:
4649 (compare_option_strings_for_name),
4650 (modest_server_account_data_get_option_value),
4651 (modest_server_account_data_get_option_bool),
4652 (modest_account_mgr_get_server_account_option):
4653 Added helper functions for parsing the options GSList.
4655 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4657 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4658 display name is based on the supplied account name.
4659 * src/modest-account-mgr.c:
4660 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4661 with an inefficient, but good-enough, implementation.
4663 * src/maemo/easysetup/modest-easysetup-wizard.c:
4664 (create_page_account_details), (on_before_next), (create_account):
4665 Check for existing display names rather than (non-user-visible) account names, and just
4666 create and set a unique account name at the end.
4668 * src/maemo/modest-account-settings-dialog.c:
4669 (modest_account_settings_dialog_init),
4670 (modest_account_settings_dialog_set_account_name),
4671 (create_page_incoming): Show the display name, instead of the account name.
4672 (on_response): Do some (not all) extra checks, as in the UI spec.
4673 (save_configuration): Save the display name if it was changed.
4675 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4677 * po/en_GB.po: Added needed logical ID and translation.
4678 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4679 (init_view): Made the is-default column clicking work.
4681 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4684 * src/maemo/easysetup/Makefile.am:
4685 * src/maemo/easysetup/modest-easysetup-wizard.c:
4686 (modest_easysetup_wizard_dialog_init):
4687 * src/maemo/easysetup/provider-data-test.keyfile:
4688 * src/maemo/easysetup/provider-data.keyfile:
4689 Moved the provider data file to the new modest-providers-data package and used it from there.
4691 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4693 * src/modest-local-folder-info.c:
4694 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4695 N_() was already used on the static strings, but this just marks it for translation without
4696 using the translation.
4698 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4700 * src/maemo/modest-account-settings-dialog.c:
4701 (create_page_incoming),
4702 (modest_account_settings_dialog_set_account_name):
4703 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4704 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4705 I will do this if nobody else gets there first.
4707 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4709 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4710 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4711 save the security stuff.
4713 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4715 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4716 Set the email address and user fullname, which I now see must be
4719 * src/maemo/modest-account-settings-dialog.h:
4720 * src/maemo/modest-account-settings-dialog.c:
4722 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4723 leave-on-server and authentication.
4724 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4727 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4730 * src/maemo/modest-account-settings-dialog.c:
4731 * src/maemo/modest-account-settings-dialog.h:
4732 Most (but not all) of the widgets are now present as specified by the UI spec.
4733 No changes are yet saved, and some details are not properly shown yet.
4735 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4737 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4739 * src/maemo/Makefile.am:
4740 * src/maemo/modest-account-settings-dialog.c:
4741 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4742 an existing account. Doesn't do much yet.
4744 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4745 Open the accounts settings dialog when Edit is clicked.
4747 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4749 * src/maemo/easysetup/Makefile.am:
4750 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4752 * src/maemo/easysetup/modest-easysetup-wizard.c:
4753 (modest_easysetup_wizard_dialog_init):
4754 Try to get the source directory from the build system,
4755 instead of hard-coding "./" into the source code, when opening our local
4756 copies of the configuration files.
4757 But this still fails when opening the wizard from the Accounts window,
4758 maybe because the working directory seems to change at runtime.
4759 So the wizard will fail the second time unless you copy the files into their
4760 proper locations - see the stdout warnings for the paths.
4762 (create_page_account_details),(on_before_next):
4763 Check for existing non-server accounts instead of server accounts,
4764 so the default account name is useful again, and to prevent trying to
4767 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4768 Show the wizard when New is clicked.
4770 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4771 (init_view): Show the column headers, and show the columns that are
4772 specified in the UI specs. However, something in Maemo's GTK+ prevents
4773 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4774 change the default account. This is despite unsetting the special properties.
4776 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4778 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4779 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4780 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4781 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4782 to make that clearer.
4783 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4785 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4787 * src/maemo/modest-account-view-window.c:
4788 (modest_account_view_window_init),
4789 (modest_account_view_window_new):
4790 Use the same buttons as specified in the
4791 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4792 the existing widgets, which never had a chance of working.
4793 Put the ModestAccountView treeview in a scrolled window.
4794 Do not repeat the initialization in both _init() and _new().
4796 * src/widgets/modest-account-view.c: (update_account_view):
4797 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4798 this widget and window shows no accounts.
4800 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4802 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4804 * src/maemo/easysetup/modest-easysetup-wizard.c:
4805 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4806 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4807 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4810 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4811 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4812 accounts exist yet, as in the UI spec.
4814 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4816 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4818 * src/maemo/Makefile.am:
4819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4820 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4821 New window for editing connection-specific smtp details.
4822 Not fully implemented.
4824 * src/maemo/modest-connection-specific-smtp-window.c:
4825 (modest_connection_specific_smtp_window_finalize) :
4826 unref the tree model.
4827 (on_button_edit): Show the edit window.
4829 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4831 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4834 * src/maemo/Makefile.am:
4835 * src/maemo/modest-connection-specific-smtp-window.c:
4836 * src/maemo/modest-connection-specific-smtp-window.h:
4837 New window for showing the list of connections, for connection-specific
4838 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4839 * src/maemo/easysetup/modest-easysetup-wizard.c:
4840 (create_page_custom_outgoing): Show the new window when the button is clicked.
4842 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4844 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4845 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4846 * src/maemo/modest-msg-edit-window.c:
4847 (modest_msg_edit_window_insert_image):
4848 * src/modest-conf.c: (modest_conf_key_escape):
4849 * src/modest-mail-operation.c:
4850 (modest_mail_operation_send_new_mail):
4851 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4852 (modest_ui_actions_on_new_account):
4853 * src/widgets/modest-attachment-view.c: (update_filename_request):
4854 * src/widgets/modest-mail-header-view.c:
4855 Corrected warnings that were breaking the build, by commenting out unused variables,
4856 and a function, and by including a header.
4858 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4860 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4861 so we can #ifdef around platform-specific code when necessary.
4862 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4863 to allow this to build for the GNOME platform too.
4865 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4867 * src/maemo/easysetup/modest-easysetup-wizard.c:
4868 Added util_increment_name() and used it in create_page_account_details()
4869 to make sure that the default account name is always a new name.
4871 (modest_easysetup_wizard_dialog_init),
4872 (set_default_custom_servernames): Some minor memory management fixes.
4874 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4878 * src/modest-runtime.c: (init_i18n): Restored the translation
4879 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4880 are defined in config.h, and the translations are installed.
4882 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4883 is defined for translation.
4885 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4887 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4889 * src/maemo/easysetup/modest-easysetup-wizard.c:
4890 (modest_easysetup_wizard_dialog_init):
4891 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4892 Use realistic paths (though they should use $prefix generically) to the
4893 mcc_mapping and provider-data.keyfile files which might work when they
4894 are installed by the future version of the operator-wizard package,
4895 and then fallback to paths in our source code, with an explanatory
4898 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4902 * src/maemo/Makefile.am:
4903 * src/maemo/easysetup/: Added files from the previously-exernal
4904 osso-modest-easysetup.
4905 * src/maemo/modest-main-window-ui.h:
4906 * src/modest-ui-actions.c:
4907 * src/modest-ui-actions.h:
4908 Added modest_ui_actions_on_new_account() as a signal handler for the
4909 New Account menu item. It shows the easysetup wizard.
4910 * po/en_GB.po: Added additional needed logical IDs and translations.