1 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
4 Fixed build with hildon < 0.99
6 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
7 Check if the selected account is busy instead of checking all accounts
9 * src/modest-account-mgr-priv.h:
10 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
11 (modest_account_mgr_init), (compare_account_name),
12 (modest_account_mgr_set_account_busy),
13 (modest_account_mgr_account_is_busy):
14 * src/modest-account-mgr.h:
15 Added busy information to the account manager. It possible to
16 set an account to busy or not busy now.
18 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
19 (modest_mail_operation_update_account),
20 (modest_mail_operation_notify_end):
21 Set the account to busy/not busy depending on the operation state.
23 * src/widgets/modest-account-view.c:
24 (modest_account_view_finalize), (get_last_updated_string),
25 (update_account_view), (on_account_busy_changed), (init_view):
26 Show string "Refreshing..." if the account is currently busy.
28 All this fixes projects.maemo.org bug NB#59711
30 2007-06-14 Armin Burgmeier <armin@openismus.com>
32 * src/widgets/modest-attachments-view.h:
33 * src/widgets/modest-attachments-view.c: Added
34 modest_attachments_view_has_attachments() and fixed coordinate
35 transformation in get_att_view_at_coords(). This fixes attachment
38 * src/widgets/modest-msg-view.c: Make use of
39 modest_attachments_view_has_attachments() to decide whether to show
40 attachments in the header.
42 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
44 * src/maemo/modest-connection-specific-smtp-edit-window.c:
45 (on_change), (on_combo_security_changed),
46 (modest_connection_specific_smtp_edit_window_init),
47 (modest_connection_specific_smtp_edit_window_set_connection),
48 (modest_connection_specific_smtp_edit_window_is_dirty):
49 * src/maemo/modest-connection-specific-smtp-edit-window.h:
50 * src/maemo/modest-connection-specific-smtp-window.c:
53 Show an comfirmation dialog for the smpt-edit-window if there are
54 unsaved changes and the user hits cancel.
55 (projects.maemo.org bug NB#60479)
57 2007-06-14 Armin Burgmeier <armin@openismus.com>
59 * src/maemo/easysetup/modest-easysetup-wizard.c:
60 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
61 address" info in banner instead of node, and select all the text as
62 per UI spec. This fixes projects.maemo.org bug NB#60550.
64 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
66 reviewed by: <delete if not using a buddy>
68 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
69 * src/modest-ui-actions.c: (folder_refreshed_cb):
71 2007-06-14 Murray Cumming <murrayc@murrayc.com>
73 * src/widgets/modest-folder-view.c: (filter_row):
74 Explictly filter out the per-account outbox accounts. I don't know why
75 these only sometimes show up, but now they should never show up in the UI.
76 This should fix projects.maemo.org bug NB#60160.
78 2007-06-14 Murray Cumming <murrayc@murrayc.com>
80 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
81 when the toolbar does not exist yet.
82 * src/modest-widget-memory.c: (save_settings_header_view):
83 Added g_warnings() to help us to discover when we are trying to set
84 an empty columns list in gconf.
86 2007-06-14 Murray Cumming <murrayc@murrayc.com>
90 Added modest_init_get_default_header_view_column_ids().
92 * src/modest-widget-memory.c: (restore_settings_header_view):
93 Use the new function to get defaults, if the gconf key is empty,
94 instead of not creating any columns. This seems to fix the
95 empty right-hand pane problems.
97 * src/widgets/modest-header-view.h: Improved documentation.
99 2007-06-13 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
102 Revert the use of the display name as the account name, because this
103 is generally wrong and would break the code that follows.
105 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
107 * src/maemo/easysetup/modest-easysetup-wizard.c:
108 (check_for_supported_auth_methods), (on_before_next),
111 More correct fix for projects.maemo.org bug NB# 58991
112 Do not longer accept AUTH_PASSWORD as secure method and choose
113 correct method when creating the account.
115 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
117 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
118 Fixed projects.maemo.org bug NB# 58991
120 2007-06-13 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-init.c: (modest_init_init_core),
123 (modest_init_local_folders): Fixed compilation errors.
125 2007-06-13 Murray Cumming <murrayc@murrayc.com>
127 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
128 Remove unnecessary lib/include, though it is good in principle when needed.
130 * src/modest-init.c: (modest_init_one_local_folder),
131 (modest_init_local_folders):
132 * src/modest-init.h: Initialize the .modest library for memory cards,
133 instead of just doing nothing for them. This should allow us to create
134 folders there, fixing projects.maemo.org bug NB#59297.
136 2007-06-13 Murray Cumming <murrayc@murrayc.com>
138 * libmodest-dbus-client/libmodest-dbus-client.c:
139 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
140 (libmodest_dbus_client_compose_mail),
141 (libmodest_dbus_client_open_message),
142 (libmodest_dbus_client_send_and_receive),
143 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
145 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
146 (on_idle_open_message), (modest_dbus_req_handler),
147 (search_result_to_message), (modest_dbus_req_filter):
148 * src/modest-search.c: (add_hit), (modest_search_folder),
149 (modest_search_all_accounts): Improved debug messages.
151 * tests/dbus_api/test_open_message.c: (main): Improved comments.
153 * src/modest-tny-account-store.c:
154 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
157 2007-06-13 Murray Cumming <murrayc@murrayc.com>
160 2007-06-12 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-tny-account-store.c: (get_server_accounts):
163 Call modest_tny_local_folders_account_add_merged_outbox_folders()
164 even when there are no accounts, so that the Outbox folder is always
165 visible. This fixes projects.maemo.org bug NB#60158.
167 2007-06-12 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/modest-main-window.c: (create_details_widget):
170 Use the mcen_va_never logical ID.
172 2007-06-12 Murray Cumming <murrayc@murrayc.com>
174 * src/dbus_api/modest-dbus-api.h:
175 * src/dbus_api/modest-dbus-callbacks.c:
176 (on_idle_open_default_inbox), (on_open_default_inbox),
177 (modest_dbus_req_handler):
178 Added a new OpenDefaultInbox method.
180 * libmodest-dbus-client/libmodest-dbus-client.h:
181 * libmodest-dbus-client/libmodest-dbus-client.c:
182 Added libmodest_dbus_client_open_default_inbox() to call the new
183 dbus method. This should be useful to projects.maemo.org bug NB#57214,
184 though it should maybe be used by a new osso-email-interface function.
186 * tests/dbus_api/Makefile.am:
187 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
190 2007-06-12 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
193 NULL, so that the signals get all the keys. This should not actually
194 change any behaviour because we currently update everything when anything
197 2007-06-12 Murray Cumming <murrayc@murrayc.com>
199 * src/widgets/modest-folder-view.c: (text_cell_data),
200 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
201 (find_inbox_iter): If tinymail tells us that the folder is
202 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
203 This causes the inbox to be selected at startup, fixing part of
204 projects.maemo.org bug NB#56305.
206 * src/modest-ui-dimming-rules.c:
207 (modest_ui_dimming_rules_on_tools_smtp_servers):
208 * src/modest-ui-dimming-rules.h: Added a callback function to dim
209 the SMTP servers menu item.
210 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
211 that the SMTP Servers menu item is dimmed when there are no accounts,
212 as a future version of the UI spec will require. This fixes
213 projects.maemo.org bug NB#56305.
215 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
217 * src/maemo/modest-maemo-utils.c:
218 (modest_maemo_utils_get_supported_secure_authentication_methods):
219 Added label to dialog instead of unreadable title
221 * src/maemo/modest-main-window.c: (sync_accounts_cb),
222 (modest_main_window_new):
223 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
226 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
227 * src/modest-account-mgr.h:
228 Added method to avoid code duplication
230 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
231 (modest_ui_actions_on_send_receive):
232 Use modest_account_mgr_has_accounts
234 2007-06-11 Murray Cumming <murrayc@murrayc.com>
236 * src/maemo/easysetup/modest-presets.c:
237 (modest_presets_get_info_server_security): Do not report secure auth
239 * src/modest-protocol-info.c: Use the defines for the gconf key names
240 for secure authentication. This was not working because we were writing
241 Password and reading password, and the check was case sensitive.
242 With this, gmail now works for receiving and sending when created via
245 2007-06-11 Murray Cumming <murrayc@murrayc.com>
247 * src/maemo/easysetup/modest-presets.c:
248 (modest_presets_get_info_server_security): Correct the key name for
249 SecureSmtp, because it seems to be case-sensitive.
250 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
251 Do not try to get the 0th notebook page if there are 0 pages, to
254 2007-06-11 Murray Cumming <murrayc@murrayc.com>
256 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
257 Prevent use of the new notification feature for now, because it currently
258 shows one dialog for each new email, which is annoying.
260 2007-06-11 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
263 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
264 when no country was selected, so that we show the global ones.
265 * src/maemo/easysetup/modest-presets.c:
266 (modest_presets_get_providers): Return only the global providers, not
267 all providers when mmc=0 was requested.
269 2007-06-11 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
272 (easysetup_provider_combo_box_fill): Remove debug code that showed the
273 provider ID in the combo.
275 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
276 Do not show the page numbers, because it would be confusing when we add
277 the 2 extra pages for the custom setup, when the user chooses the "Other"
278 provider. This fixes projects.maemo.org bug NB#59028
280 * src/modest-init.c: (modest_init_init_core),
281 (modest_init_local_folders):
283 * src/modest-tny-account.c:
284 (modest_tny_account_new_for_local_folders): Do not create default folders
285 for the memory card. This should fix projects.maemo.org bug NB#59328.
287 2007-06-11 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
290 Free the changed_conf_keys string items. They are already freed in the
291 idle handler if that runs first.
293 2007-06-11 Murray Cumming <murrayc@murrayc.com>
295 * src/modest-ui-actions.c:
296 (modest_ui_actions_on_password_requested): Check that the server name
297 is not NULL, because I just saw a password dialog with (null) as the
300 * src/modest-tny-folder.[h|c]: Added
301 modest_tny_folder_is_memory_card_folder().
302 * src/modest-ui-dimming-rules.c:
303 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
304 menu item for memory cards, as per the UI spec (section 7.4). This should
305 fix projects.maemo.org bug NB#59297.
307 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
309 * src/maemo/modest-main-window.c: (sync_accounts_cb):
310 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
311 is another problem with the code, see Murray's comment at line 772)
313 2007-06-08 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
316 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
317 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
318 (load_from_file), (easysetup_country_combo_box_init),
319 (easysetup_country_combo_box_get_active_country_ids),
320 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
321 instead of just one ID, to avoid duplicate country names in the UI.
323 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
324 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
325 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
326 a single ID, avoiding duplicate providers.
327 * src/maemo/easysetup/modest-easysetup-wizard.c:
328 (on_combo_account_country): Adapt to use a list.
330 2007-06-08 Murray Cumming <murrayc@murrayc.com>
332 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
333 keys changed in the last X seconds.
335 * src/modest-account-mgr.h:
336 * src/modest-account-mgr.c: (on_timeout_notify_changes),
337 (on_key_change), (modest_account_mgr_class_init),
338 (modest_account_mgr_init), (modest_account_mgr_finalize):
339 As the keys are changed, save them in a GSList* and signal that GSList*
340 further every X seconds, to batch changes, to allow us to do just one
341 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
342 bug NB#56941 and other (UI-blocking) delays when changing account settings.
344 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
345 changed signal signature.
347 * src/modest-conf.c: (modest_conf_set_list),
348 (modest_conf_on_change): Reenable notification.
350 (modest_conf_maemo_fake_on_change): Comment out the hack that
351 notified immediately instead of asynchronously.
353 * src/widgets/modest-account-view.h:
354 * src/widgets/modest-account-view.c:
355 (update_account_view): Select the previously-selected account ID,
356 if possible. This fixes projects.maemo.org bug NB#56933.
358 (on_account_changed), (on_account_removed),
359 (modest_account_view_select_account):
361 Remove the block/unblock functions
362 because they were not useful.
364 * src/maemo/modest-account-view-window.c:
365 (on_delete_button_clicked), (on_edit_button_clicked),
366 (on_new_button_clicked): Remove the use of the non-working block/unblock.
368 2007-06-08 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
371 Improve the error dialog to show Incorrect Account Settings, which seems
372 clearer, and say that the internal error message (to be removed from the
373 dialog later) is often misleading.
374 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
376 * src/modest-tny-account.c:
377 (modest_tny_account_new_from_server_account): Uncomment the printf of the
378 URL because this is so useful for debugging on the device.
380 * src/widgets/modest-serversecurity-combo-box.c:
381 (modest_serversecurity_combo_box_fill): Correct a logical ID.
383 2007-06-08 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-mail-operation.c:
386 (modest_mail_operation_send_new_mail):
387 Added a comment about a nasty but apparently harmless message. Details
388 added to the wiki g_warnings() page.
390 2007-06-08 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
393 (modest_tny_send_queue_class_init):
394 Do not use the priv struct because it is empty, to avoid g_warnings
395 about a non-existant priv struct.
397 * src/modest-tny-account-store.c:
398 (modest_tny_account_store_get_server_account),
399 (modest_tny_account_store_get_transport_account_for_open_connection
400 ): Do not try to get transport server accounts for local folders,
401 because they don't have any. This avoids a g_warning().
403 * src/maemo/modest-main-window.c:
404 (modest_main_window_notify_send_receive_initied),
405 (on_configuration_key_changed):
406 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
408 * src/modest-mail-operation.c:
409 (modest_mail_operation_update_account):
410 * src/modest-tny-account-store.h:
411 * src/modest-tny-account.c:
412 (modest_tny_account_get_special_folder),
413 (modest_tny_account_new_for_local_folders),
414 (modest_tny_account_new_for_per_account_local_outbox_folder):
415 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
416 * src/modest-tny-local-folders-account.c:
417 (add_account_folders_to_merged_folder):
418 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
419 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
420 (modest_ui_actions_on_send):
421 * src/widgets/modest-folder-view.c: (update_model):
422 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
423 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
424 modest_tny_account_store_get_tny_account_by_account() to
425 modest_tny_account_store_get_server_account() to make the code clearer.
427 2007-06-07 Marcus Bauer <marcusb@openismus.com>
429 * src/dbus_api/modest-dbus-api.h:
430 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
431 * src/maemo/modest-msg-edit-window.c:
432 (modest_msg_edit_window_attach_file_noninteractive):
433 added g_warning in case the file to be attached does not exist
434 * tests/dbus_api/test_compose_mail.c: (main):
435 removed obsolete comment, added generic files as test case
437 2007-06-07 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account-store.c: (get_server_accounts):
440 Create the local folders account only once, not once for each outbox, and
441 not only when there are some outboxes.
443 2007-06-07 Murray Cumming <murrayc@murrayc.com>
445 * src/widgets/modest-folder-view.c: (update_model): Comment out some
446 code that is causing a crash at startup. Sergio says that he is fixing this.
448 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
450 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
451 * src/maemo/modest-account-settings-dialog.c:
452 (create_page_outgoing),
453 (modest_account_settings_dialog_set_account_name),
454 (save_configuration):
455 - Fixed handling of the "Use secure authentication" toggle to comply with
456 the ui specification. See also projects.maemo.org bug NB#58400
458 - Restore the Secure connection setting combo correctly when loading
461 * src/maemo/modest-maemo-utils.c:
462 (on_camel_account_get_supported_secure_authentication),
463 (modest_maemo_utils_get_supported_secure_authentication_methods):
464 Fixed a crasher if operation is canceled
466 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
467 (modest_protocol_info_auth_is_secure):
468 * src/modest-protocol-info.h:
470 Added two new methods to determine if a protocol/auth method is secure/encrypted in
471 the sense of the "Use secure authentication" toggle.
473 2007-06-07 Murray Cumming <murrayc@murrayc.com>
475 * src/modest-tny-account-store.h:
476 * src/modest-tny-account-store.c:
477 Added modest_tny_account_store_get_local_folders_account().
479 * src/modest-tny-folder.h:
480 * src/modest-tny-folder.c:
481 (modest_tny_folder_get_account):
482 Added this replacement for tny_folder_get_account() which returns
483 the local-folders account for TnyMergeFolders, to avoid the
484 warning about the unimplemented get_account_func() vfunc().
486 (modest_tny_folder_get_rules),
487 * src/modest-ui-actions.c:
488 (modest_ui_actions_on_folder_selection_changed):
489 * src/modest-mail-operation.c:
490 (modest_mail_operation_remove_folder),
491 (modest_mail_operation_xfer_folder),
492 (modest_mail_operation_rename_folder),
493 (modest_mail_operation_get_msg),
494 (modest_mail_operation_get_msgs_full),
495 (modest_mail_operation_remove_msg),
496 (modest_mail_operation_xfer_msgs),
497 (modest_mail_operation_refresh_folder):
498 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
500 2007-06-07 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
503 (modest_server_account_set_security):
504 * src/modest-defs.h: Add comments explaining that our
505 UI spec means TLS when it says Normal, so these do not look like errors.
507 * src/modest-tny-account.c:
508 (modest_tny_account_new_from_server_account): Use the new tinymail
509 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
510 for TLS. This should fix projects.maemo.org bug NB#58460.
512 2007-06-06 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/easysetup/modest-easysetup-wizard.c:
515 (create_account): Correct the position of the gconf sanity check warning.
516 (on_button_edit_advanced_settings): Show the dialog immediately, instead
517 of using the g_idle_add() hack, because this does not seem to be necessary
518 on osso 1.1. It might even work on Maemo Bora if the problems were actually
519 caused by something other than maemo's gconf.
520 This fixes projects.maemo.org bug #59022.
522 2007-06-06 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-account-mgr-helpers.c:
525 (modest_account_mgr_get_default_account): Do not check that the account
526 exists if there is no default account (NULL), to fix a runtime warning.
528 2007-06-06 Murray Cumming <murrayc@murrayc.com>
530 * src/widgets/modest-folder-view.c: (update_model):
531 Do not unref the treemodel before we have finished with it.
532 This prevents a valgrind warning and an occasional crash at startup.
534 2007-06-06 Marcus Bauer <marcusb@openismus.com>
536 * libmodest-dbus-client/libmodest-dbus-client.h:
537 added libmodest_dbus_client_compose_mail()
538 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
540 added functions needed for SendAsMail() functionality
541 * src/maemo/modest-msg-edit-window.c:
542 (modest_msg_edit_window_attach_file_noninteractive):
543 non interactively attaching files to message edit window
544 * src/widgets/modest-msg-edit-window.h:
545 * tests/dbus_api/Makefile.am:
546 added test_compose_mail.c
547 * tests/dbus_api/test_compose_mail.c: (main):
549 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
551 * src/modest-account-view.c:
552 Fixed bug projects.maemo.org bug NB#59307
554 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
556 * src/maemo/easysetup/modest-easysetup-wizard.c:
557 (get_serverport_incoming), (on_before_next), (create_account):
558 * src/maemo/modest-account-settings-dialog.c:
559 (modest_account_settings_dialog_set_account_name):
560 * src/maemo/modest-maemo-utils.c:
561 (on_camel_account_get_supported_secure_authentication_status),
562 (on_camel_account_get_supported_secure_authentication),
563 (on_secure_auth_cancel),
564 (modest_maemo_utils_get_supported_secure_authentication_methods):
566 Implemented security authentication for settings and easysetup.
568 2007-06-05 Murray Cumming <murrayc@murrayc.com>
570 * src/maemo/modest-main-window.c: (create_details_widget):
571 Show the total size for memory card accounts too, instead of showing
572 the name again. Fixes bug projects.maemo.org bug NB#59307.
574 2007-06-05 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-tny-simple-folder-store.c:
578 * src/modest-tny-simple-folder-store.h: Removed.
580 * src/modest-tny-local-folders-account.h
581 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
582 for the local-folders maildir, with an extra TnyMergedFolder containing
583 the folders of the per-account outbox store accounts.
584 * src/modest-tny-account-store.c: (get_server_accounts):
585 Add the outboxes to the special local folders account after creating it.
587 * src/modest-tny-account.c:
588 (modest_tny_account_new_for_local_folders): Create the derived
589 account when creating the main local-folders account.
591 * src/maemo/modest-main-window.c: (create_details_widget),
592 (modest_main_window_set_contents_style):
593 Adapted to the use of the derived account instead of the folder store.
595 * src/modest-ui-actions.c:
596 (modest_ui_actions_on_folder_selection_changed):
597 * src/modest-ui-dimming-rules.c:
598 (modest_ui_dimming_rules_on_new_folder):
599 * src/widgets/modest-folder-view.c: (text_cell_data),
600 (icon_cell_data), (filter_row), (update_model),
601 (get_cmp_rows_type_pos):
604 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
605 Do not get the priv struct, because no priv struct has been set,
606 to avoid a runtime warning.
608 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
609 #ifelse with #else, to fix a warning, to fix the build.
612 2007-06-05 Christian Kellner <ckellner@openismus.com>
614 * libmodest-dbus-client/libmodest-dbus-client.c:
615 Fix small typo in doc (why do you always see them
616 AFTER committing stuff?)
619 2007-06-05 Christian Kellner <ckellner@openismus.com>
621 * libmodest-dbus-client/libmodest-dbus-client.c:
622 (libmodest_dbus_client_search):
623 Initialize hit list with NULL. Also set folder list
624 to "" if NULL was supplied.
627 2007-06-03 Christian Kellner <ckellner@openismus.com>
629 * libmodest-dbus-client/libmodest-dbus-client.c:
630 (modest_search_hit_list_free):
631 Make it save to call it with NULL.
633 * src/dbus_api/modest-dbus-callbacks.c:
634 * src/modest-search.c:
635 Return full ModestSearchHits as the search result list not TnyHeader
636 since can't be around withouth the correspoding TnyFolder.
638 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
640 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
641 Added currently commented code to check for secure auth
643 * src/maemo/modest-account-settings-dialog.c: (on_response),
644 (save_configuration), (show_ok):
645 Fixed projects.maemo.org bugs NB #59248 and #59251
647 * src/maemo/modest-maemo-utils.c:
648 (on_camel_account_get_supported_secure_authentication_status),
649 (on_camel_account_get_supported_secure_authentication),
650 (modest_maemo_utils_get_supported_secure_authentication_methods):
651 * src/maemo/modest-maemo-utils.h:
652 Moved get_supported_secure_authentication() method here to be able
653 to use it from easysetup wizard.
655 * src/modest-pair.c: (on_pair_compare_as_string):
656 Should compare string with first part of pair and not
657 strcmp pairs which will crash.
659 * src/modest-protocol-info.c:
660 (modest_protocol_info_protocol_is_store):
661 * src/modest-protocol-info.h:
662 Added modest_protocol_info_get_auth_protocol_name()
664 2007-06-03 Armin Burgmeier <armin@openismus.com>
666 * src/modest-mail-operation.c:
667 (modest_mail_operation_get_msgs_full): Set priv->account also when
668 only retrieving a single message. This avoids a crash when canceling
671 (modest_mail_operation_notify_end): Do not explicitely remove the
672 operation from the queue but only emit the progress_changed signal.
673 The queue itself listens to that signal to remove the operation when
674 it is finished. This reduces coupling and removes a potential deadlock
675 when modest_mail_operation_notify_end() is called from the queue
676 itself. If that is a problem performance-wise, I would suggest to
677 implement a status-changed signal or something.
679 * src/modest-mail-operation-queue.c: Make sure to never call a
680 function from another file while the queue is locked. This (hopefully)
681 fixes another deadlock when exiting the application while retrieving
684 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
686 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
687 Fixed build if libogs is not available
689 2007-06-03 Christian Kellner <ckellner@openismus.com>
691 * libmodest-dbus-client/libmodest-dbus-client.h:
692 * libmodest-dbus-client/libmodest-dbus-client.c:
693 (libmodest_dbus_client_delete_message):
694 Implement deletion of messages (Client side).
696 (modest_search_hit_free),
697 (modest_search_hit_list_free):
698 Utility functions to free the result hits.
700 * src/dbus_api/modest-dbus-api.h:
701 * src/dbus_api/modest-dbus-callbacks.c:
703 (modest_dbus_req_handler):
704 Implement deletion of messages (Server side).
706 * tests/dbus_api/test_search.c: (main):
709 * tests/dbus_api/Makefile.am:
710 * tests/dbus_api/test_delete_message:
711 Add little test for the message deletion logic
713 2007-06-03 Armin Burgmeier <armin@openismus.com>
715 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
716 when the operation queue was not empty. projects.maemo.org bug
719 2007-06-03 Armin Burgmeier <armin@openismus.com>
721 * src/widgets/modest-account-view.c
722 (on_account_default_toggled): Toggle default account column
723 explicitely instead of waiting for gconf notification (which is
724 currently ignored). This should fix projects.maemo.org bug NB#56910
725 for now. It should probably be removed when gconf notifications are
728 2007-06-03 Christian Kellner <ckellner@openismus.com>
730 * libmodest-dbus-client/libmodest-dbus-client.c:
731 Removed debugging spew.
733 * src/dbus_api/modest-dbus-callbacks.c:
734 Added debugging info.
736 * src/modest-search.c:
737 (modest_search_all_accounts):
738 Use tny_account_store_get_accounts () on the account store
739 to get all accounts which is the way to get all accounts.
741 * tests/dbus_api/test_search.c: (main):
742 Make it possible to supply the search term on the command line.
744 2007-06-03 Christian Kellner <ckellner@openismus.com>
746 * libmodest-dbus-client/libmodest-dbus-client.c:
747 * libmodest-dbus-client/libmodest-dbus-client.h:
748 Implement searching for mesages over raw dbus. (Client side)
750 * src/dbus_api/Makefile.am:
751 * src/dbus_api/modest-dbus-api.h:
752 * src/dbus_api/modest-dbus-callbacks.c:
753 * src/dbus_api/modest-dbus-callbacks.h:
754 Search framework (Server side). Also implement on_idle_open_message().
756 * src/maemo/modest-platform.c: (modest_platform_init):
757 Prepare for raw dbus/osso rpc interaction.
759 * src/modest-search.h:
760 Changed minsize from unspecific guint to guint32.
762 * src/modest-search.c:
764 Added strange hack which magically made tnymail work.
766 (modest_search_folder),
767 (modest_search_account),
768 (modest_search_all_accounts):
769 Implement helper functions to search all accounts, specific account
772 * tests/dbus_api/Makefile.am:
773 * tests/dbus_api/test_open_message.c:
774 Read url to open from commandline.
776 * tests/dbus_api/test_search.c:
777 Implement small test for dbus search stuff
779 2007-06-02 Armin Burgmeier <armin@openismus.com>
781 * src/maemo/modest-account-settings-dialog.c: Changed window title to
782 include account type and account title. This fixes projects.maemo.org
785 * src/maemo/modest-account-view-window.c: Set a title for the window.
787 2007-06-02 Armin Burgmeier <armin@openismus.com>
789 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
790 incoming and outgoing server name based on email address and server
791 types as long as the names have not been edited manually. This fixes
792 projects.maemo.org bug NB#58671.
794 2007-06-02 Armin Burgmeier <armin@openismus.com>
796 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
797 server type cannot be changed in future to the incoming details page
798 when creating an account. This fixes projects.maemo.org bug NB#59029.
800 2007-06-02 Armin Burgmeier <armin@openismus.com>
802 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
803 and assigned max width chars so that they wrap instead of being
804 truncated. Fixes projects.maemo.org bug NB#56126.
806 2007-06-02 Armin Burgmeier <armin@openismus.com>
808 * src/maemo/modest-connection-specific-smtp-window.c: Add an
809 introductory note to the connection specific smtp servers dialog, as
810 section 8.12 of the email UI specification requires. This fixes
811 projects.maemo.org bug NB#59212.
813 2007-06-01 Murray Cumming <murrayc@murrayc.com>
815 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
816 Check for running mail operations, and offer to cancel them, as per the UI
817 spec. This fixes projects.maemo.org bug NB#59041 .
818 However, I suspect that tinymail may still use the network connection
819 in ways that we cannot detect or cancel. But it should at least adapt to
822 2007-06-01 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-tny-account-store.c: (recreate_all_accounts),
825 (get_cached_accounts), (get_server_accounts): Do more sensible
826 ref-counting of the temporarily-cached outbox accounts list. This seems
827 to fix a crash when entering the password when the password was wrong.
829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
831 * src/gnome/modest-main-window.c: (connect_signals):
832 * src/modest-tny-account-store.c: (get_password),
833 (modest_tny_account_store_alert): Added comments and clues and
834 commented-out code about how we currently fail to deal with connection
835 errors and wrong passwords, and how we should.
837 2007-06-01 Murray Cumming <murrayc@murrayc.com>
839 * src/widgets/modest-retrieve-combo-box.c:
840 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
841 This fixes projects.maemo.org bug NB#58472 .
843 2007-06-01 Murray Cumming <murrayc@murrayc.com>
845 * src/maemo/easysetup/modest-easysetup-wizard.c:
846 (create_page_complete_easysetup):
847 (create_page_complete_custom): Correct the last commit,
848 putting the correct sentences in the correct pages.
850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
852 * src/maemo/easysetup/modest-easysetup-wizard.c:
853 (create_page_complete_custom): Show the second sentence of text
854 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
857 2007-06-01 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
860 Set the leave-on-server conf key by default. This fixes
861 projects.maemo.org bug NB#59258 .
863 2007-06-01 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/modest-account-view-window.c:
866 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
867 logical ID for the confirmation messages. Fixed projects.maemo.org bug
870 2007-06-01 Murray Cumming <murrayc@murrayc.com>
872 * src/maemo/easysetup/modest-easysetup-wizard.c:
873 (create_caption_new_with_asterisk):
874 * src/maemo/modest-account-settings-dialog.c:
875 (create_caption_new_with_asterisk):
876 Uncomment the code to add the asterisk, because they are no longer in the
877 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
878 (update_incoming_server_title): Add an asterisk here too.
880 2007-06-01 Murray Cumming <murrayc@murrayc.com>
882 * src/maemo/modest-maemo-global-settings-dialog.c:
883 (current_connection): Check that we are even connected before trying to
884 get the current connection name, to prevent a warning.
886 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
887 Change the comments because tny_maemo_conic_device_connect() is now meant to
889 * src/modest-mail-operation.c:
890 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
891 make sure we have a connection and fail if we can't connect.
893 2007-05-31 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/modest-main-window.c:
896 (on_account_store_connecting_finished): Do not try to get the
897 connection ID if we are not really connected. I am surprised that
898 this signal handler is called when we are not connected.
900 2007-05-31 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-error.h:
903 * src/modest-ui-actions.c:
904 (modest_ui_actions_get_msgs_full_error_handler):
905 Renamed an enum, added comments, added an enum
906 for retrieve-limit errors.
908 * src/modest-mail-operation.c: (foreach_add_item),
909 (internal_folder_observer_update), (update_account_thread),
910 (modest_mail_operation_get_msgs_full):
911 (modest_mail_operation_update_account),
912 Added comments about how this works, and some code that should
913 (but does not) check the retrieve-limit. See the TODO comment.
915 2007-05-31 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
918 Initialize help_id to fix the build. Warnings are good.
920 2007-05-31 Murray Cumming <murrayc@murrayc.com>
922 * src/widgets/modest-hbox-cell-renderer.c:
923 (modest_hbox_cell_renderer_append):
924 * src/widgets/modest-vbox-cell-renderer.c:
925 (modest_vbox_cell_renderer_append):
926 Fix the last commit by doing an extra ref.
928 2007-05-31 Murray Cumming <murrayc@murrayc.com>
930 * src/widgets/modest-hbox-cell-renderer.c:
931 (modest_hbox_cell_renderer_append):
932 * src/widgets/modest-vbox-cell-renderer.c:
933 (modest_vbox_cell_renderer_append):
934 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
935 to fix the build with Maemo Bora.
936 However, there seems to be a remaining crash, probably due to reference
939 2007-05-30 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account.c:
942 (modest_tny_account_new_for_local_folders):
943 Use hildon_file_system_info_async_new() to get a better name for
944 the memory card account, setting it as the account name.
945 The timing seems to work, but this is probably
946 not the best place to do this. See the TODO comment.
947 * src/maemo/modest-main-window.c: (create_details_widget):
948 * src/widgets/modest-folder-view.c: (text_cell_data):
949 Use the tny account name instead of hardcoding a name.
951 2007-05-30 Christian Kellner <ckellner@openismus.com>
953 * src/modest-search.c: (modest_search):
954 Correctly set part_search_func even if we have already parsed
955 the query and thus a valid OgsTextSearcher object.
957 2007-05-30 Christian Kellner <ckellner@openismus.com>
960 Search and check for libogs.
963 Incooparte the ogs build env.
965 * src/modest-mime-part-search-stream.c:
966 * src/modest-mime-part-search-stream.h:
967 Removed since we do the real searching now in modest-search.c.
969 * src/modest-search.c:
970 * src/modest-search.h:
971 Implement support for ogs. We use that if available and requested
972 and fall back to modest_text_utils_utf8_strcmp (). The search logic
973 should now handle the corner case when the search term is spread
974 across multiple reads.
975 Also the logic in modest_search () was corrected to search all
976 requested fields until one is found.
978 2007-05-30 Murray Cumming <murrayc@murrayc.com>
980 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
983 * src/modest-init.c: Made modest_init_local_folders() take a
984 path and be public so we can iniitialize maildir folders on
987 * src/modest-local-folder-info.h:
988 * src/modest-local-folder-info.c:
989 (modest_local_folder_info_get_maildir_path): Add a path parameter.
991 * src/modest-tny-account.c:
992 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
993 still means the standard local-folders path on the local volume.
995 * src/modest-tny-account-store.c:
996 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
997 signal so we can detect mount/unmount of the MMC1 card, and do an update of
998 all accounts when that happens.
999 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1000 this too, so it shows up in the treeview.
1002 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/modest-maemo-global-settings-dialog.c:
1005 (current_connection):
1006 * src/widgets/modest-global-settings-dialog.c:
1007 (current_connection_default):
1008 Use the enum values instead of 0, 1 and -1,
1009 to make the code clearer.
1011 * src/modest-account-mgr-helpers.c:
1012 (modest_account_mgr_get_connection_specific_smtp): Make this code
1015 * src/modest-runtime.h:
1016 * src/modest-runtime.c:
1017 Added modest_runtime_remove_all_send_queues().
1018 * src/maemo/modest-main-window.c:
1019 (on_account_store_connecting_finished): Recreate the send queues,
1020 using the appropriate transport accounts for this new connection.
1021 Some futher adapting might be needed if the old send queues are not
1022 automatically stopped at this point.
1024 * src/modest-tny-account-store.c: (get_server_accounts):
1025 Create the connection-specific transport accounts, so that they can
1026 be found later by their ID.
1028 * src/modest-tny-account.h:
1029 * src/modest-tny-account.c:
1030 Added modest_tny_account_new_from_server_account_name().
1031 modest_tny_account_new_from_server_account(): Do not create the
1032 send queues here, because they will be
1033 recreated anyway when the connection changes for the first time.
1035 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-local-folder-info.h:
1038 * src/modest-local-folder-info.c:
1039 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1040 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1041 tbox_folder): Take a modest account name instead of a server TnyAccount,
1042 so we can have per-modest-account rather than per-transport-account
1044 We must make sure that we change or recreate the exisitng send queues
1045 when the connection changes for connection-specific transport accounts.
1047 * src/modest-tny-account-store.c:
1048 (create_per_account_local_outbox_folders): Create outboxed per modest
1049 account, not per transport account.
1051 * src/modest-tny-account.h:
1052 * src/modest-tny-account.c:
1053 (modest_tny_account_get_special_folder): For outboxes, get the
1054 parent modest account name. The account is ignored for other folders.
1055 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1056 modest account name rather than a server TnyAccount.
1058 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-tny-account.c:
1061 (modest_tny_account_new_from_server_account):
1062 Call modest_runtime_get_send_queue() immediately after creating transport
1063 accounts, so that they start trying to send email from the outbox as soon
1064 as possible at startup. This is probably what we want.
1066 * src/modest-mail-operation.c: (update_account_thread):
1067 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1068 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1069 * src/modest-tny-send-queue.h:
1070 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1071 (modest_ui_actions_on_send):
1072 Added comments about how sending works, though it needs some more work.
1074 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-tny-account.c:
1077 (modest_tny_account_get_special_folder): Add TODO because this fails when
1078 the network is busy.
1079 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1080 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1081 Do not try to show this window when there is no active account. The UI
1082 specs does not tell us what to do in this case.
1084 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1088 * src/maemo/Makefile.am:
1089 * src/widgets/Makefile.am: Some dist fixes.
1091 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1093 * src/maemo/modest-connection-specific-smtp-window.c:
1094 (on_button_edit): Make the code clearer, to prevent a double free.
1096 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1098 * src/maemo/modest-account-settings-dialog.c:
1099 (modest_account_settings_dialog_set_account_name),
1100 Check the connection-specific smtp servers checkbox if there are any.
1102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1103 (modest_connection_specific_smtp_edit_window_init):
1104 Start with a suitable port number.
1106 * src/modest-account-mgr-helpers.h:
1107 * src/modest-account-mgr-helpers.c: Added
1108 modest_account_mgr_get_has_connection_specific_smtp().
1110 (modest_account_mgr_set_connection_specific_smtp),
1111 (modest_account_mgr_remove_connection_specific_smtp),
1112 (modest_account_mgr_get_has_connection_specific_smtp),
1113 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1114 connection-specific smtp server accounts in the account, rather than
1115 the server account conf dir.
1117 This fixes bug projects.maemo.org bug NB#58263 .
1119 * src/modest-tny-account-store.c:
1120 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1121 if there are no server accounts yet, to prevent an infinite loop when there
1122 are no accounts. Document that one must be called before the other.
1124 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-account-mgr-helpers.c:
1127 (modest_account_mgr_get_default_account): Make sure that at least
1128 one account is always the default, if there are any enabled accounts.
1129 This is just a sanity check that shouldn't be necessary.
1131 * src/modest-account-mgr-priv.c:
1132 (_modest_account_mgr_account_from_key): Unescape the conf key to
1133 get the real account name. For instance, this is an issue if a space
1134 was in the account name, which can happen because the account name
1135 is generated from the display name.
1136 (_modest_account_mgr_get_account_keyname): Always escape the
1138 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1139 Unescape the conf keys to get the real account names.
1141 For instance, previously the is-default radio button in the accounts
1142 list was not checked for any accounts at first. This fixes that,
1143 and might fix several similar bugs.
1145 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1148 Removed some debug printfs.
1150 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1152 Modest on-disk outbox directories are now here, for instance:
1153 $HOME/.modest/outboxes/<account-id-1>/outbox
1154 $HOME/.modest/outboxes/<account-id-2>/outbox
1156 $HOME/.modest/local-folders/outbox
1157 so we can have a separate outbox for each account.
1158 But they are shown as one outbox in the GtkTreeView, by using a
1159 TnyMergeFolder in a ModestTnySimpleFolderStore.
1162 * src/modest-tny-simple-folder-store.c:
1163 * src/modest-tny-simple-folder-store.h:
1164 Added ModestTnySimpleFolderStore, used to contain folders from
1165 other folder stores, such as other accounts.
1167 * src/modest-tny-outbox-account.h:
1168 * src/modest-tny-outbox-account.c:
1169 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1170 used for the per-account local outbox folders.
1172 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1173 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1174 only use this (internally) now for the non-outbox local folders.
1176 * src/modest-init.h:
1177 * src/modest-init.c: Added modest_init_one_local_folder(), for
1178 setting up the directory structure for each local folder.
1180 * src/modest-local-folder-info.c:
1181 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1182 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1184 * src/modest-local-folder-info.h:
1185 * src/modest-tny-account-store.c: (on_account_removed),
1186 (on_account_changed), (create_per_account_local_outbox_folders),
1187 (get_server_accounts), (modest_tny_account_store_get_accounts),
1188 (modest_tny_account_store_get_tny_account_by_account),
1189 (modest_tny_folder_store_is_virtual_local_folders):
1191 * src/modest-tny-account.h:
1192 * src/modest-tny-account.c:
1193 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1194 to create an on-disk per-account local outbox folder for each
1196 (create_per_account_local_outbox_folders): Create a local outbox folder
1197 for each transport account.
1198 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1199 for all local folders.
1201 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1202 instead of using g_object_get/set() directly. It is clearer.
1204 (modest_tny_folder_store_get_message_count),
1205 (modest_tny_folder_store_get_local_size
1206 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1207 because we now use these with non-acount folder stores.
1209 (modest_tny_account_get_special_folder),
1210 (modest_tny_account_new_from_server_account),
1211 (modest_tny_account_new_from_account):
1212 (recurse_folders): Adjust to the new outbox system.
1214 * src/modest-tny-folder.h:
1215 * src/modest-tny-folder.c:
1216 (modest_tny_folder_is_local_folder),
1217 (modest_tny_folder_get_local_folder_type),
1218 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1220 * src/widgets/modest-main-window.h:
1221 * src/maemo/modest-main-window.c: (create_details_widget),
1222 (modest_main_window_set_contents_style): Show details for any folder store,
1225 (modest_tny_folder_get_rules):
1226 Remove the const. C does not support constness enough for this.
1228 * src/modest-ui-actions.c:
1229 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1230 make all outboxes appear as one, in the usual local-folders tree node.
1232 (set_active_account_from_tny_account),
1233 (modest_ui_actions_on_folder_selection_changed):
1234 * src/widgets/modest-folder-view.c: (text_cell_data),
1235 (icon_cell_data), (filter_row),
1236 (add_account_folders_to_merged_folder),
1237 (add_account_folders_to_simple_folder_store), (),
1238 (get_cmp_rows_type_pos), (cmp_rows),
1239 (modest_folder_view_set_account_id_of_visible_server_account):
1240 Adjust to the new outbox system, using generic folder stores and folders
1241 in the GtkTreeModel.
1243 2007-05-23 Christian Kellner <ckellner@openismus.com>
1245 * src/modest-mail-operation.c:
1246 (modest_mail_operation_update_account):
1247 Use info->max_size instead of unintialized local var [small
1248 build fix]. (Added TODO to review that change since I don't
1251 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1253 * libmodest-dbus-client/libmodest-dbus-client.c:
1254 (libmodest_dbus_client_compose_mail): function added
1255 * src/dbus_api/modest-dbus-api.h:
1256 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1257 (on_compose_mail): Implementation of the SendAsMail functionality
1259 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-account-mgr.c:
1262 (modest_account_mgr_add_server_account): Set the secure-connection
1263 conf key for transport accounts as well as store accounts. I don't know
1264 why the if was there. For instance, this makes sure that we use SSL
1265 for the gmail preset from the easysetup wizard.
1267 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1269 * src/gnome/modest-main-window.c:
1270 (on_account_store_connecting_finished), (connect_signals):
1271 * src/maemo/modest-main-window.c:
1272 (on_account_store_connecting_finished), (connect_signals),
1273 (modest_main_window_new):
1274 Handle TnyAccountStore::connecting-finished instead of
1275 TnyDevice::connection-changed, because we cannot actually perform
1276 operations on accounts until TnyAccountStore has itself responded to
1277 the TnyDevice::connection-changed signal. This prevents a GError from
1279 Do not try to update at startup, because we (at least on scratchbox)
1280 already do an update at startup when the device goes online.
1281 This prevents a GError from tinymail.
1282 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1283 Added TODO about stopping simultaneous operations.
1285 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1288 * src/modest-mail-operation-queue.c:
1289 (modest_mail_operation_queue_remove):
1290 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1291 about where they happened.
1293 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1295 * src/modest-ui-actions.c:
1296 (modest_ui_actions_on_password_requested): Make sure that the remember
1297 output parameter is always TRUE.
1299 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1301 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1302 Show a OK/Cancel dialog if the error is a question, though we still do not
1303 know anything more about what we are asking the user.
1304 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1305 Fix an uninitialized variable (helper). This is a logic error, however.
1307 2007-05-21 Christian Kellner <ckellner@openismus.com>
1309 * src/modest-search.h:
1310 Correct bit shifting in the ModestSearchFlags enum.
1312 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1314 * src/modest-tny-account.c:
1315 (modest_tny_account_new_from_server_account): Do not use the lsub and
1316 check-all hard-coded IMAP options when using POP.
1318 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1320 * src/modest-tny-account.c:
1321 (modest_tny_account_new_from_server_account):
1322 Use NULL for the secure-auth method for POP when Password auth has been
1323 specified by the user, as we already do for IMAP. "auth=Login" causes
1324 an error from camel or the server.
1326 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-account-settings-dialog.c:
1329 (create_page_account_details),
1330 (modest_account_settings_dialog_set_account_name):
1331 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1332 for the leave-on-server checkbox, rathr than just the checkbox, when
1333 the protocol is not POP.
1335 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1337 * src/widgets/modest-account-view.c:
1338 * src/widgets/modest-account-view.h:
1339 Added modest_account_view_select_account() which will be useful later
1340 to asynchronously re-select the edited account.
1342 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/modest-account-settings-dialog.c:
1345 (modest_account_settings_dialog_set_account_name):
1346 Automatically choose the port numbers based on the secure authentication
1347 methods, if they have not been chosen before.
1348 This fixes projects.maemo.org bug NB#56273 .
1350 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/modest-main-window-ui.h:
1353 * src/modest-ui-actions.c:
1354 * src/modest-ui-actions.h:
1355 Connect the Tools/SMTP Servers menu item to
1356 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1357 SMTP servers dialog, as in the UI specification and saves changes when it
1358 is closed. This fixed projects.maemo.org bug NB#56305 .
1360 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1362 * src/maemo/modest-connection-specific-smtp-window.c:
1363 (modest_connection_specific_smtp_window_init):
1364 Use gtk_window_set_default_size() to make this window big enough, so
1365 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1367 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1371 (modest_connection_specific_smtp_edit_window_init),
1372 Do not try to connect to a combobox signal before the combobox exists.
1373 This fixes the cras in projects.maemo.org bug NB#56288 .
1374 (modest_connection_specific_smtp_edit_window_get_settings):
1375 Remove the server_account_name parameter which was being checked for NULL
1376 though it was not used.
1378 * src/maemo/modest-connection-specific-smtp-window.c:
1379 (modest_connection_specific_smtp_window_fill_with_connections),
1380 (on_button_edit), (modest_connection_specific_smtp_window_init):
1381 Correct the number of treemodel columns to prevent a warning.
1382 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1383 libconic does not work.
1385 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-tny-account.c:
1388 (modest_tny_account_new_from_server_account):
1389 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1390 SMTP when "None" was chosen by the user. However, with my SMTP server that
1391 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1394 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1396 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1397 to explain the memory management issue with the ID in the ModestPair.
1399 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1400 (add_sending_page), (modest_account_assistant_finalize):
1401 * src/gnome/modest-gnome-global-settings-dialog.c:
1402 (create_updating_page), (create_composing_page):
1403 * src/gnome/modest-msg-edit-window.c: (get_transports),
1404 (init_window), (modest_msg_edit_window_finalize),
1405 (modest_msg_edit_window_get_msg_data):
1406 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1407 * src/gnome/modest-transport-widget.c:
1408 (modest_transport_widget_finalize), (smtp_configuration):
1409 * src/maemo/modest-maemo-global-settings-dialog.c:
1410 (create_updating_page), (create_composing_page):
1411 * src/maemo/modest-msg-edit-window.c: (get_transports),
1412 (init_window), (modest_msg_edit_window_finalize),
1413 (modest_msg_edit_window_get_msg_data),
1414 (modest_msg_edit_window_free_msg_data):
1415 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1416 (modest_store_widget_finalize):
1417 * src/maemo/modest-transport-widget.c:
1418 (modest_transport_widget_finalize), (smtp_configuration):
1419 * src/modest-main.c: (send_mail):
1420 * src/widgets/modest-combo-box.h:
1421 * src/widgets/modest-global-settings-dialog-priv.h:
1422 * src/widgets/modest-global-settings-dialog.c:
1423 (modest_global_settings_dialog_finalize):
1424 * src/widgets/modest-msg-edit-window.h:
1425 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1426 as long as the combo box, to prevent use of freed memory for the ID.
1428 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1430 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1431 get_accounts(), to make this clearer. Do not check for the enabled gconf
1432 key, because we do not use this for server accounts (at least, not yet).
1433 This allows us to send email again.
1435 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/modest-platform.c:
1438 (on_modest_conf_update_interval_changed), (modest_platform_init):
1439 Only respond to this particular key change. All these strcmp()s cannot be
1442 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/modest-maemo-global-settings-dialog.c:
1445 (current_connection): Prevent a crash in scratchbox when
1446 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1447 * src/maemo/modest-platform.c:
1448 (on_modest_conf_update_interval_changed), (modest_platform_init):
1449 Get the update interval from gconf and reset it when the gconf key changes.
1451 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-protocol-info.c:
1454 * src/modest-protocol-info.h: Adde enum-specific get functions,
1455 instead of using a ModestProtocolType enum parameter.
1457 * src/gnome/modest-account-assistant.c:
1458 * src/gnome/modest-store-widget.c:
1459 * src/gnome/modest-store-widget.h:
1460 * src/gnome/modest-transport-widget.c:
1461 * src/gnome/modest-transport-widget.h:
1462 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1463 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1464 * src/maemo/easysetup/modest-easysetup-wizard.c:
1465 * src/maemo/modest-account-settings-dialog.c:
1466 * src/maemo/modest-account-settings-dialog.h:
1467 * src/maemo/modest-store-widget.c:
1468 * src/maemo/modest-store-widget.h:
1469 * src/maemo/modest-transport-widget.c:
1470 * src/maemo/modest-transport-widget.h:
1471 * src/modest-account-mgr-helpers.c:
1472 * src/modest-account-mgr-helpers.h:
1473 * src/modest-account-mgr.c:
1474 * src/modest-account-mgr.h:
1475 * src/modest-tny-account.c:
1476 * src/modest-tny-folder.c:
1477 * src/widgets/modest-account-view.c:
1478 * src/widgets/modest-retrieve-combo-box.c:
1479 * src/widgets/modest-retrieve-combo-box.h:
1480 * src/widgets/modest-secureauth-combo-box.c:
1481 * src/widgets/modest-serversecurity-combo-box.c:
1482 * src/widgets/modest-serversecurity-combo-box.h:
1483 * tests/check_account-mgr.c:
1484 Use the specific functions, and use the re-renamed enum values for GNOME too.
1486 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-pair.h:
1489 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1490 so we can get the second based on the first.
1492 * src/maemo/modest-account-settings-dialog.h:
1493 * src/maemo/modest-account-settings-dialog.c:
1494 Added get_supported_secure_authentication_methods(), though it is mostly
1495 commented-out for now until the necessary API is committed to tinymail.
1496 (modest_account_settings_dialog_set_account_name),
1497 (save_configuration): Request the supported authentication methods from the
1498 server, so we can choose a working method.
1500 * src/modest-tny-account-store.h:
1501 * src/modest-tny-account-store.c:
1502 (modest_tny_account_store_get_session): Rename from
1503 tny_account_store_get_session().
1505 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-protocol-info.h: Split the ModestProtocol enum
1508 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1509 There was no need to have these unrelated values in one enum.
1511 * src/: many files: Adapted to changed enum. This makes the code a bit
1512 clearer, and the compiler could catch some errors.
1514 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1516 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1517 Show the detailed internal camel error message when an error happens
1518 during the configuration, so that our testers can give us more clues.
1519 For instance, in projects.maemo.org bug NB#56910 .
1521 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-tny-account.c:
1524 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1525 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1527 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1529 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1530 * src/maemo/modest-account-settings-dialog.c:
1531 (modest_account_settings_dialog_set_account_name),
1532 (save_configuration): For the incoming secure authentication checkbox,
1533 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1534 the UI specification. PLAIN does not seem to be supported for most IMAP
1535 servers anyway, and I am not sure what it would mean.
1536 However, we probably need to discover which of the secure-authentication
1537 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1538 * src/modest-account-mgr-helpers.c:
1539 (modest_account_mgr_get_server_account_data):
1541 * src/modest-tny-account.c:
1542 (modest_tny_account_new_from_server_account):
1543 Use tny_account_set_mech() to set secure-authentication methods,
1544 with some special-casing for IMAP, based on my observations of how
1547 * src/modest-account-mgr-helpers.h:
1548 * src/modest-account-mgr.c:
1549 * src/modest-defs.h: Comment that the URI is only used for local folders.
1551 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1553 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1554 parameter const, just to be neat.
1555 * src/modest-text-utils.c: (modest_text_utils_inline):
1556 End g_strconcat() with NULL, as its documentation says. This is almost
1557 certainly the cause of my crash at startup on the device. Interestingly,
1558 valgrind doesn't tell us about these errors.
1560 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1562 * scripts/build-packages: Added more precise comments about how to use
1563 this script, though I still get this error:
1564 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1565 error building tinymail
1567 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/modest-main-window.c: (on_account_update):
1570 Very slight cleanup, hoping to make it simpler to discover what causes
1571 a crash here sometimes.
1573 * src/modest-tny-account.c:
1574 (modest_tny_account_new_from_server_account): Set the port. Added
1575 comments about the options and a TODO comment because I need to find out
1576 how to specify the secure authentication method.
1578 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1580 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1581 changed CFlags paths form modest to libmodest
1583 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1585 * src/modest-account-mgr-helpers.c:
1586 (modest_account_mgr_get_server_account_data),
1587 (modest_account_mgr_free_server_account_data):
1588 * src/modest-account-mgr-helpers.h:
1589 * src/modest-account-mgr.c:
1590 (modest_account_mgr_add_server_account):
1591 * src/modest-defs.h:
1592 * src/modest-tny-account.c:
1593 (modest_tny_account_new_from_server_account):
1594 Determine the options for tny_camel_account_add_option() here,
1595 based on the settings, rather than storing them directly in gconf.
1597 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1600 Show a more friendly error dialog now that we expect (from the tinymail
1601 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1603 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1605 * src/maemo/modest-main-window.c: (on_account_update): Check that
1606 account_name is not NULL, to prevent a crash at startup that I am
1607 seeing on the N800. I do wonder why it is NULL.
1609 * src/maemo/easysetup/modest-easysetup-wizard.c:
1610 (create_page_user_details):
1611 * src/maemo/modest-account-settings-dialog.c:
1612 (create_page_user_details), (create_page_outgoing):
1613 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1614 (modest_connection_specific_smtp_edit_window_init):
1615 * src/modest-ui-actions.c:
1616 (modest_ui_actions_on_password_requested):
1617 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1618 might do something useful with the on-screen keyboard.
1620 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/modest-main-window.c: (on_account_update):
1623 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1624 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1626 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1628 * src/modest-tny-account-store.c: (on_account_changed):
1629 Correct the signature of this signal handler.
1631 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1633 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1634 Show a HildonNote instead of a GtkDialog for Maemo.
1636 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1638 * src/widgets/modest-account-view.h:
1639 * src/widgets/modest-account-view.c: (on_account_changed),
1640 (on_account_removed). Added a boolean flag, set/unset by
1641 modest_account_view_block_conf_updates(),
1642 modest_account_view_unblock_conf_updates() to prevent unnecessary
1643 updates, but this is not very useful because the gconf notifications are
1644 so delays (maybe only on Maemo Bora).
1645 So auto-updating is turned off, and these functions do an explicit
1646 update when necessary.
1647 However, something else is still doing too much work when adding/removing
1648 accounts, probably in another part of the application.
1650 * src/maemo/modest-account-view-window.c:
1651 (on_delete_button_clicked), (on_edit_button_clicked),
1652 (on_new_button_clicked): Use the new functions.
1654 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1656 * src/modest-account-mgr-helpers.c:
1657 (modest_account_mgr_set_first_account_as_default):
1658 Sort the list of names alphabetically-by-title, so we choose the first one
1660 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1661 alphabetically by the title.
1663 This fixes projects.maemo.org bug NB#56418 .
1665 * src/modest-account-mgr-priv.c:
1666 (_modest_account_mgr_account_from_key):
1667 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1668 avoid a valgrind error, and possible random behaviour.
1670 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1673 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1674 tinymail documentation to say that this can be expected.
1675 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1676 pretty, and should not happen, but I would prefer to know when it does.
1678 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1680 * configure.ac: When using the older hildon version, probably on Bora,
1681 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1683 * src/widgets/modest-attachment-view.c:
1684 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1687 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1689 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1690 Implemented the prototype. Can be tested with
1691 tests/dbus_api/test_open_message:
1693 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1695 * src/modest-tny-account-store.c:
1696 (modest_tny_account_store_instance_init), (get_password):
1697 * src/modest-ui-actions.c:
1698 (modest_ui_actions_on_password_requested):
1699 Do not store the password in gconf, because this function is called
1700 for non-remembered passwords. Actually use the cached (in the hash map)
1701 password instead of releasing it.
1702 The password will now not be remembered if it is asked via the protected
1703 password dialog, as per the UI spec.
1705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-defs.h:
1708 * src/modest-account-mgr-helpers.h:
1709 * src/modest-account-mgr-helpers.c:
1710 Added modest_server_account_get_username_has_succeeded(),
1711 modest_server_account_set_username_has_succeeded().
1712 (modest_server_account_set_username),
1713 Reset the has-succeeded flag if the username changes.
1715 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1716 * src/maemo/modest-connection-specific-smtp-window.c:
1717 (modest_connection_specific_smtp_window_save_server_accounts):
1718 Use modest_server_account_set_username() instead of using
1719 modest_conf_set_string() directly, so that the has-succeeded flag is always
1722 * src/modest-ui-actions.c:
1723 (modest_ui_actions_on_password_requested): Dim the username entry if
1724 the username has ever worked, as per the UI spec.
1726 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-tny-account-store.c: (get_password):
1729 * src/modest-ui-actions.c:
1730 (modest_ui_actions_on_password_requested):
1731 Allow the username to be changed too, though there is more work to
1732 be done on exactly how this behaves.
1734 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1736 * src/modest-account-mgr-helpers.h:
1737 * src/modest-account-mgr-helpers.c:
1738 Added modest_account_mgr_get_display_name(),
1739 modest_server_account_get_username(),
1740 modest_server_account_set_username(),
1741 modest_server_account_set_password(),
1742 modest_server_account_get_hostname() functions so we do not need to
1743 use the conf API directly.
1745 * src/maemo/modest-main-window.c: (connect_signals):
1746 Actually connect ot the ModestAccountStore::request-password signal,
1747 so that we show the dialog when the password is requested by Tinymail,
1748 for isntance if it is empty.
1750 * src/modest-marshal.list:
1751 * src/modest-tny-account-store.c:
1752 (modest_tny_account_store_class_init), (get_password),
1753 (modest_tny_account_store_alert):
1754 * src/modest-tny-account-store.h:
1755 * src/modest-ui-actions.h:
1756 * src/modest-ui-actions.c:
1757 (modest_ui_actions_on_password_requested):
1758 Change the signal parameters, so it is obvious that we are providing
1759 the non human-readable server name, and receiving both the username
1760 and password, though changing of the username is not yet implemented.
1761 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1762 for the GNOME version.
1764 This should fix the projects.maemo.org bug NB#56209, though it does not
1765 work on Bora, because the gconf_client_get() for the password fails
1766 immediately after we save it with gconf_client_set().
1768 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1771 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1772 caused an undefined symbol error:
1773 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1775 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-tny-account-store.c:
1778 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1779 using a GError instead of a string message, so we can translate it in
1782 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/modest-address-book.c:
1785 (modest_address_book_check_names):
1786 * src/maemo/modest-msg-view-window.c:
1787 (modest_msg_view_window_clipboard_owner_change):
1788 * src/modest-init.c: (modest_init_init_ui):
1789 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1790 (update_folders_cb), (modest_mail_operation_update_account):
1791 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1792 (modest_ui_actions_on_msg_attachment_clicked),
1793 (modest_ui_actions_on_msg_recpt_activated):
1794 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1795 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1796 (modest_msg_view_search_next):
1797 * src/widgets/modest-recpt-editor.c:
1798 (modest_recpt_editor_on_button_release_event),
1799 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1800 g_message(). At this point we should only be seeing interesting errors on
1801 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1803 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1805 (modest_wizard_dialog_force_title_update):
1806 * src/maemo/easysetup/modest-wizard-dialog.h:
1807 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1808 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1809 can update the title when appropriate. Otherwise the title is wrong if the
1810 pages are added after adding the notebook to the dialog.
1811 This must be a problem in HildonWizardDialog too.
1812 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1814 * src/maemo/easysetup/modest-easysetup-wizard.c:
1815 (create_subsequent_customsetup_pages),
1816 (create_subsequent_easysetup_pages):
1817 Call modest_wizard_dialog_force_title_update() so that the title is
1818 correct even with GTK+ < 2.10.
1819 This fixes projects.maemo.org bug NB#56145 .
1821 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1823 * src/maemo/modest-platform.c:
1824 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1825 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1828 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1830 * src/widgets/modest-window.h:
1831 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1832 and modest_window_save_state(), which invokes it.
1834 * src/widgets/modest-window-mgr.h:
1835 * src/widgets/modest-window-mgr.c:
1836 Added modest_window_mgr_save_state_for_all_windows(), which calls
1837 the save_state vfunc on all registered windows, if implemented.
1839 * src/gnome/modest-msg-edit-window.c:
1840 * src/gnome/modest-msg-view-window.c:
1841 * src/maemo/modest-msg-edit-window.c:
1842 * src/maemo/modest-msg-view-window.c:
1843 * src/maemo/modest-main-window.c:
1844 Specify the existing save_settings functions as implementations of
1845 ModestWindow::save_state_func().
1847 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1848 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1849 enabling hibernation, for instance.
1851 We may need to do the same thing for restoring settings.
1854 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1856 * src/widgets/modest-window-mgr.c:
1857 * src/widgets/modest-window-mgr.h:
1858 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1859 modest_window_mgr_get_hibernation_is_prevented().
1861 * src/maemo/modest-main-window.c:
1862 (on_hildon_program_is_topmost_notify): Prevent hibernation
1863 (possible when the application goes to the background in the WM),
1864 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1866 * src/maemo/easysetup/modest-easysetup-wizard.c:
1867 (modest_easysetup_wizard_dialog_init):
1868 * src/maemo/modest-account-settings-dialog.c:
1869 (modest_account_settings_dialog_init):
1870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1871 (modest_connection_specific_smtp_edit_window_init):
1872 * src/maemo/modest-connection-specific-smtp-window.c:
1873 (modest_connection_specific_smtp_window_init):
1874 * src/maemo/modest-signature-editor-dialog.c:
1875 (modest_signature_editor_dialog_init):
1876 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1877 prevent hibernation while any of these account settings dialogs are open.
1879 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/Makefile.am:
1882 * src/maemo/modest-osso-state-saving.c:
1883 * src/maemo/modest-osso-state-saving.h: Added
1884 modest_osso_load_state() and modest_osso_save_state() though they do
1885 nothing now. They should iterate through all the open windows and load/save
1887 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1888 save state when closing.
1890 * src/maemo/modest-main-window.c:
1891 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1892 Add a notification handler for the HildonProgram::is-topmost property,
1893 so we can allow hibernation when the application goes into the background.
1894 But we still need to detect when the accounts setup windows are open so
1895 we can stop hibernation when they are open.
1896 To do this, I also added the main window the HildonProgram. This might have
1897 other side-effects/benefits, and should maybe be done for other windows.
1899 * src/maemo/modest-osso-autosave-callbacks.h:
1900 * src/maemo/modest-osso-autosave-callbacks.c:
1901 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1902 though it does not do anything yet, and we might never need this to do
1903 anything. For instance, we already save drafts.
1905 * src/maemo/modest-platform.c: (modest_platform_init):
1906 Specify the libosso auto-save callback.
1908 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1910 * src/maemo/modest-platform.c:
1911 (modest_platform_set_update_interval):
1912 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1913 aparently stays valid between application instances, so we can use this
1914 to remove and reset it later. According to a maemo-developers email from
1917 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1919 * configure.ac: Depend on libalarm for Maemo.
1921 * src/dbus_api/modest-dbus-api.h:
1922 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1923 (on_send_receive), (modest_dbus_req_handler):
1924 Handle a SEND_RECEIVE D-Bus method.
1926 * libmodest-dbus-client/libmodest-dbus-client.c:
1927 (libmodest_dbus_client_send_and_receive):
1928 * libmodest-dbus-client/libmodest-dbus-client.h:
1929 Add C convenience functions for calling the new D-Bus method.
1931 * src/modest-platform.h:
1932 * src/gnome/modest-platform.c:
1933 * src/maemo/modest-platform.c:
1934 Added modest_platform_set_update_interval(), which uses the
1935 alarmd API on Maemo.
1936 (modest_platform_init),
1937 Call modest_platform_set_update_interval(), using a hard-coded
1938 interval for now (until the global settings dialog is implemented),
1939 though I am not sure that this makes sense yet.
1941 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1943 * src/dbus_api/modest-dbus-callbacks.c:
1944 (modest_osso_cb_hw_state_handler):
1945 * src/dbus_api/modest-dbus-callbacks.h:
1946 * src/maemo/modest-platform.c: (modest_platform_init):
1947 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1948 in case this has some effect on the ability for Maemo to ping the
1951 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1954 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1955 warning. It is probably a logic error, but I need to fix the build.
1957 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-account-mgr.h:
1960 * src/modest-account-mgr.c:
1961 (modest_account_mgr_account_names): Add a gboolean enabled_only
1962 parameter, so we can get lists of onlt the enabled accounts.
1964 (modest_account_mgr_add_account),,
1965 (modest_account_mgr_account_with_display_name_exists):
1966 * src/maemo/modest-msg-edit-window.c: (get_transports):
1967 * src/modest-account-mgr-helpers.c:
1968 (modest_account_mgr_set_first_account_as_default):
1969 * src/modest-init.c: (init_default_account_maybe):
1970 * src/modest-tny-account-store.c: (get_accounts):
1971 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1972 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1973 * tests/check_account-mgr.c: (START_TEST):
1974 Provide the extra parameter, as appropriate.
1976 * src/widgets/modest-account-view.c: (update_account_view):
1977 Do not show disabled accounts (meaning that there is no way to
1978 enable/disable accounts in the UI (the feature is not in our UI
1979 specification), so we can use this internally only to mark unfinished
1980 or temporary account data.
1982 * src/maemo/easysetup/modest-easysetup-wizard.c:
1983 (create_account): Add boolean enable parameter, so we can specify FALSE
1984 to create the temporary account.
1985 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1986 (on_before_next): When finishing, when there is a temporary account, just
1988 Also, use a timeout to delay the showing of the dialog until gconf is likely
1989 to return correct information, due to a maemo gconf bug that is fixed in
1990 osso 1.1, but not yet in Bora.
1991 However, the dialog stays on screen after it is destroyed.
1993 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1994 for invalid data when cancelling. Use a hildon note instead of a dialog
1995 to complain about invalid data. Do not show the account-saved note if the
1996 account is disabled (a temporary account that will not really be saved for use
1999 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-account-mgr-helpers.h:
2002 * src/modest-account-mgr-helpers.c:
2003 Added modest_account_mgr_unset_default_account(),
2004 Added modest_account_mgr_set_first_account_as_default().
2006 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2007 If it was the default account, unset the default account name.
2009 * src/maemo/modest-account-view-window.c:
2010 (on_delete_button_clicked): If it was the default account,
2011 set the first remaining account as the default instead.
2013 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2014 a NULL account or a NULL default account, to prevent a crash. This should
2015 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2018 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2020 * src/widgets/modest-recpt-editor.c:
2021 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2022 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2023 TODO comment for this. This fixes the build.
2025 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2026 be the best place for it. This will in future update all auto-update accounts,
2027 rather than just the current/default account, when that gconf key exists.
2028 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2029 if there are no accounts, before calling do_send_receive().
2030 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2032 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2033 * src/maemo/modest-main-window-ui.h:
2034 * src/maemo/modest-main-window.c: (on_connection_changed),
2035 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2036 directly, becaue the signal handler does more.
2038 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2040 * src/modest-account-mgr-helpers.c:
2041 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2042 for the case that the account does not exist.
2044 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2045 (equivalent to the modest account name) rather than the tinymail account name
2046 (equivalent to the modest account title - human readable) to get the account data.
2047 Check for null account data to prevent the crash, and add a TODO comment saying that
2048 this needs fixing because it is using the server account name instead of the account name.
2050 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2053 * src/maemo/modest-account-settings-dialog.c: (show_error),
2055 Use hildon_note_new_information() for informative and error messages,
2056 which seems to be expected for Maemo applications (no documentation that I know of
2057 says this). I am surprised that there is no distinction between info and error
2060 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2063 it is easy to find where this is used.
2065 * src/maemo/easysetup/modest-easysetup-wizard.c:
2066 (create_page_welcome), (create_page_account_details),
2067 (create_page_user_details), (create_page_complete_easysetup),
2068 (create_page_custom_incoming), (create_page_custom_outgoing),
2069 (create_page_complete_custom):
2070 * src/maemo/modest-account-settings-dialog.c:
2071 (create_page_account_details), (create_page_user_details),
2072 (create_page_incoming), (create_page_outgoing):
2073 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2074 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2075 (modest_connection_specific_smtp_edit_window_init):
2076 * src/maemo/modest-connection-specific-smtp-window.c:
2077 (modest_connection_specific_smtp_window_init):
2078 * src/maemo/modest-signature-editor-dialog.c:
2079 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2080 and scrolling policy as per the Email Application Layout Guide, if I have
2083 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2085 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2086 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2087 which were empty, because these vfuncs have been removed from TnyAccountStore.
2088 This fixes the build.
2090 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/modest-main-window.c:
2093 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2094 showing/hiding it. Added TODO because it probably should not be NULL.
2095 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2096 because unnecessary g_warnings() make degugging difficult.
2098 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/modest-msg-edit-window.c:
2101 (modest_msg_edit_window_select_color),
2102 (modest_msg_edit_window_select_background_color): 2 const corrections and
2103 moving 2 #endifs before closing brackets, to fix the build.
2105 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2107 * src/maemo/easysetup/modest-easysetup-wizard.h:
2108 * src/maemo/easysetup/modest-easysetup-wizard.c:
2109 (modest_easysetup_wizard_dialog_finalize),
2110 (on_button_edit_advanced_settings), (create_page_complete_custom),
2111 (on_response), (create_account):
2112 Implement the Advanced Settings edit button, by saving the account information,
2113 for the Advanded Settings dialog to use directly from gconf, and removing it
2114 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2115 Bug #5533 in the projects.maemo.org bugzilla.
2117 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/modest-msg-view-window.c:
2120 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2121 when opening a message window.
2123 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/easysetup/modest-easysetup-wizard.c:
2126 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2129 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2130 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2131 gconf settings. I probably added more checks than necessary, but that is safer.
2133 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2134 variable to fix the build, but this seems to be used when it is still NULL.
2136 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2138 * src/modest-platform.h:
2139 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2140 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2141 * src/modest-main.c: Implement this function so we can avoid using
2142 maemo-specific API from cross-platform code.
2144 * src/modest-tny-account-store.c:
2145 (get_smtp_specific_transport_account_for_open_connection):
2146 * src/modest-ui-actions.c: (check_for_connection),
2147 (modest_ui_actions_on_item_not_found):
2148 Use modest_platform_connect_and_wait() and put #idefs around other
2149 maemo-specific code, because only maemo currently has a way to
2150 identify connection names.
2152 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-tny-account-store.h:
2155 * src/modest-tny-account-store.c:
2156 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2157 the connection-specific SMTP server settings in the configuration.
2159 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2161 * src/maemo/modest-main-window.c: (on_connection_changed),
2163 * src/modest-main.c: (main), (start_ui), (send_mail):
2164 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2165 that is what is intended.
2167 * src/modest-ui-actions.c: (action_send), (action_receive),
2168 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2169 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2170 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2171 SMTP server is used when it is specified.
2173 (modest_ui_actions_on_send_receive):
2174 Check that a connection is open before proceeding.
2175 Receive and then send, instead of vice-versa, as per the specification.
2177 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2179 * src/modest-mail-operation.c:
2180 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2181 though I guess it should be something other than NULL.
2183 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/easysetup/modest-easysetup-wizard.c:
2186 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2187 combo twice, to avoid an g_warning and to make it visible again.
2188 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2189 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2190 (already intended) dereference when detaching, because we then recreate the menu.
2191 But I am not sure why the warning was happening, and it is possible that this is a memory
2194 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2196 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2197 and uri_parse_mailto() utility functions.
2198 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2200 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2202 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2204 * src/dbus_api/modest-dbus-api.h:
2205 * src/dbus_api/modest-dbus-callbacks.c:
2206 Use an idle callback to execute the modest code in the application's own thread.
2207 Remove the helloworld example method.
2208 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2209 parsed, and the open-message method is not implemented because this is not yet implemented in
2211 * libmodest-dbus-client/libmodest-dbus-client.c:
2212 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2213 (libmodest_dbus_client_open_message):
2214 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2216 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2217 body without crashing.
2219 * tests/dbus_api/Makefile.am:
2220 * tests/dbus_api/test_mail_to.c:
2221 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2223 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2225 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2226 Added file to fix the build. Sorry.
2228 * src/dbus_api/Makefile.am:
2229 * src/dbus_api/modest-dbus-api.h:
2230 * src/dbus_api/modest-dbus-callbacks.h:
2231 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2232 (modest_dbus_req_handler):
2233 Put constants in a separate header so it can be reused by the
2234 client library, without duplication
2236 * libmodest-dbus-client/Makefile.am:
2237 * libmodest-dbus-client/libmodest-dbus-client.c:
2238 (libmodest_dbus_client_call_helloworld),
2239 (libmodfest_dbus_client_send_mail),
2240 (libmodfest_dbus_client_mailto),
2241 (libmodfest_dbus_client_open_message):
2242 * libmodest-dbus-client/libmodest-dbus-client.h:
2243 (Partly) Implement a send_mail D-Bus method.
2245 * tests/dbus_api/Makefile.am:
2246 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2247 the send_email D-Bus method.
2249 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2253 * libmodest-dbus-client/Makefile.am:
2254 * libmodest-dbus-client/libmodest-dbus-client.c:
2255 * libmodest-dbus-client/libmodest-dbus-client.h:
2256 * tests/dbus_api/Makefile.am:
2257 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2258 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2260 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/easysetup/modest-easysetup-wizard.c:
2263 (create_page_account_details):
2264 * src/maemo/modest-account-settings-dialog.c:
2265 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2266 widgets, because this might not be the default in future versions of the Maemo GTK+.
2267 However, I can not not get capitalization to work even in a simple test case.
2269 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2271 * src/maemo/easysetup/modest-easysetup-wizard.c:
2272 (create_page_custom_incoming), (create_page_custom_outgoing):
2273 * src/maemo/modest-account-settings-dialog.c:
2274 (create_page_account_details), (create_page_incoming),
2275 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2276 instead of using gtk_check_button_with_label(), so they are aligned like the other
2277 widgets, as per the UI spec.
2279 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/easysetup/modest-easysetup-wizard.c:
2282 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2283 * src/widgets/modest-validating-entry.c:
2284 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2285 Modest prefix instead of an EasySetup prefix.
2287 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2289 * src/widgets/modest-validating-entry.h:
2290 * src/widgets/modest-validating-entry.c: (on_insert_text),
2291 Added easysetup_validating_entry_set_max_func(), used to set a callback
2292 to call when the max number of characters is reached. GtkEntry has a max-length
2293 already but is silent about it.
2295 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2296 (create_page_account_details), (create_page_user_details),
2298 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2299 (create_page_account_details), (create_page_user_details),
2300 (create_page_outgoing):
2301 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2302 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2303 the UI spec, when the user tries to enter more than the max number of characters.
2305 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/easysetup/modest-easysetup-wizard.c:
2308 (create_page_user_details), (create_page_custom_incoming),
2309 (create_page_custom_outgoing):
2310 * src/maemo/modest-account-settings-dialog.c:
2311 (create_page_user_details), (create_page_incoming),
2312 (create_page_outgoing):
2313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2314 (modest_connection_specific_smtp_edit_window_init):
2315 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2316 not appropriate. Bad Maemo-specific defaults!.
2318 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2320 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2321 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2322 (modest_signature_editor_dialog_set_settings):
2323 Disable the label and textview when the checkbox is disabled, and use the
2324 specified (UI spec) default signature text.
2326 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2329 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2331 * src/modest-defs.h:
2332 * src/modest-account-mgr-helpers.h:
2333 * src/modest-account-mgr-helpers.c:
2334 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2336 * src/maemo/Makefile.am:
2337 * src/maemo/modest-signature-editor-dialog.c:
2338 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2341 * src/maemo/modest-account-settings-dialog.h:
2342 * src/maemo/modest-account-settings-dialog.c:
2343 (modest_account_settings_dialog_finalize), (on_button_signature),
2344 (save_configuration): Use the new dialog when the Edit button is pressed, and
2345 save the changes if necessary, as per the UI spec.
2347 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/Makefile.am:
2350 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2351 based on maemo-develoers email from Dirk.
2353 * src/maemo/easysetup/modest-easysetup-wizard.c:
2354 (create_page_welcome), (create_page_account_details),
2355 (create_page_user_details), (create_page_complete_easysetup),
2356 (create_page_custom_incoming), (create_page_custom_outgoing),
2357 (create_page_complete_custom),
2358 (modest_easysetup_wizard_dialog_init):
2359 * src/maemo/modest-account-settings-dialog.c:
2360 (create_page_account_details), (create_page_user_details),
2361 (create_page_incoming), (create_page_outgoing),
2362 (modest_account_settings_dialog_init):
2363 * src/maemo/modest-connection-specific-smtp-window.c:
2364 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2366 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2368 * src/maemo/easysetup/modest-easysetup-wizard.c:
2369 (create_page_account_details), (create_page_custom_outgoing),
2370 (create_page_complete_custom):
2371 * src/maemo/modest-account-settings-dialog.c:
2372 (create_page_user_details), (create_page_incoming),
2373 (create_page_outgoing):
2374 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2375 (modest_connection_specific_smtp_edit_window_init):
2376 Use the correct (UI spec) port min/max, and use horizontal separators,
2379 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2381 * src/maemo/easysetup/modest-easysetup-wizard.c:
2382 (set_default_custom_servernames):
2383 * src/maemo/modest-account-settings-dialog.c:
2384 (create_page_incoming), (on_combo_outgoing_security_changed),
2385 (on_combo_incoming_security_changed), (create_page_outgoing),
2386 (modest_account_settings_dialog_set_account_name),
2387 (save_configuration):
2388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2389 (on_combo_security_changed),
2390 (modest_connection_specific_smtp_edit_window_init),
2391 (modest_connection_specific_smtp_edit_window_set_connection),
2392 (modest_connection_specific_smtp_edit_window_get_settings):
2393 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2396 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2399 * src/maemo/easysetup/modest-easysetup-wizard.c:
2400 (create_page_custom_outgoing), (create_page_complete_custom):
2401 * src/maemo/modest-account-settings-dialog.c:
2402 (create_page_user_details), (create_page_outgoing):
2403 * src/maemo/modest-account-view-window.c: (button_box_new):
2404 Use changed logical IDs as per the most recent UI spec:
2405 mcen_bd_emailsetup_edit -> mcen_bd_edit
2406 mcen_bd_emailsetup_delete -> mcen_bd_delete
2407 mcen_bd_emailsetup_close -> mcen_bd_close
2409 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2413 * src/dbus_api/Makefile.am:
2414 * src/dbus_api/modest-dbus-callbacks.c:
2415 * src/dbus_api/modest-dbus-callbacks.h:
2416 * src/maemo/modest-platform.c: (modest_platform_init):
2417 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2419 * tests/Makefile.am:
2420 * tests/dbus_api/Makefile.am:
2421 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2423 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2425 * src/maemo/modest-account-settings-dialog.c:
2426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2427 Removed unnecessary includes.
2429 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/easysetup/modest-easysetup-wizard.c:
2432 * src/maemo/modest-account-settings-dialog.c:
2433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2434 * src/widgets/Makefile.am:
2435 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2436 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2437 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2438 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2439 * src/widgets/modest-secureauth-combo-box.c:
2440 * src/widgets/modest-secureauth-combo-box.h:
2441 * src/widgets/modest-serversecurity-combo-box.c:
2442 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2443 made the GObject names more consistent with the rest of the Modest code.
2445 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/easysetup/Makefile.am:
2448 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2449 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2450 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2451 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2452 * src/maemo/easysetup/modest-easysetup-wizard.c:
2453 * src/maemo/easysetup/modest-validating-entry.c:
2454 * src/maemo/easysetup/modest-validating-entry.h:
2455 * src/maemo/modest-account-settings-dialog.c:
2456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2457 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2458 widgets/ because they are used outside of easysetup too. After checking in,
2459 svn will allow me to rename them too.
2461 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2463 * src/gnome/modest-msg-edit-window.c:
2464 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2465 linker error, to fix the build on the GNOME platform.
2466 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2467 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2468 ifdefed out to avoid a warning.
2470 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2472 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2473 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2474 some alternative for GTK+ 2.6.
2476 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2478 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2480 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2481 specified for EmailAccountsDialog in UI spec.
2483 * src/maemo/easysetup/modest-easysetup-wizard.c:
2484 * src/maemo/easysetup/modest-easysetup-wizard.h:
2485 * src/maemo/modest-account-settings-dialog.c:
2486 * src/maemo/modest-account-settings-dialog.h:
2487 Reuse a member window widget for the connection-specific SMTP server accounts,
2488 so we can tell it to create/save the accounts only if we actually save changes.
2490 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2491 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2492 (modest_connection_specific_smtp_edit_window_get_settings):
2493 Return a struct instance for temporarily remembering the entered data.
2495 * src/maemo/modest-connection-specific-smtp-window.h:
2496 * src/maemo/modest-connection-specific-smtp-window.c:
2497 (modest_connection_specific_smtp_window_finalize),
2498 (modest_connection_specific_smtp_window_fill_with_connections),
2500 (modest_connection_specific_smtp_window_save_server_accounts),
2501 (update_model_server_names): Do not actually save data until asked,
2502 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2504 (on_selection_changed),
2505 (modest_connection_specific_smtp_window_init): Disable the edit
2506 button when nothing is selected.
2508 * src/modest-account-mgr-helpers.c:
2509 * src/modest-account-mgr-helpers.h:
2510 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2513 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2515 * src/modest-account-mgr-helpers.h:
2516 * src/modest-account-mgr-helpers.c:
2517 (modest_account_mgr_get_unused_account_name),
2518 (modest_account_mgr_get_unused_account_display_name): Added these
2519 utility functions, to avoid code duplication.
2521 * src/maemo/easysetup/modest-easysetup-wizard.c:
2522 (create_page_account_details), (create_account):
2523 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2524 (on_combo_security_changed),
2525 (modest_connection_specific_smtp_edit_window_init),
2526 (modest_connection_specific_smtp_edit_window_save_settings):
2527 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2528 * src/maemo/modest-connection-specific-smtp-window.c:
2529 (modest_connection_specific_smtp_window_finalize),
2530 (modest_connection_specific_smtp_window_fill_with_connections),
2531 (on_button_edit), (modest_connection_specific_smtp_window_init):
2532 * src/maemo/modest-connection-specific-smtp-window.h:
2533 Implementing saving of connection-specific server accounts.
2535 But I need to refactor this so we can save the data for each
2536 possible connection-specific account and only actually create the server accounts
2537 when the easysetup finished, or the OK button is pressed on the account settings
2540 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2542 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2543 (on_combo_security_changed):
2544 (modest_connection_specific_smtp_edit_window_init):
2545 Auto-fill the port number as in the account settings.
2547 (modest_connection_specific_smtp_edit_window_set_connection):
2548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2549 * src/maemo/modest-connection-specific-smtp-window.c:
2550 (fill_with_connections), (on_button_edit),
2551 (modest_connection_specific_smtp_window_init):
2552 Turn the edit window into a dialog to simplify the code, and
2553 set a WM hint as in a GtkDialog, because only a popup can be on top of
2554 another window in Maemo, and popups usually have no WM decoration.
2556 * src/modest-defs.h:
2557 * src/modest-account-mgr-helpers.c:
2558 (modest_account_mgr_set_connection_specific_smtp),
2559 (modest_account_mgr_remove_connection_specific_smtp),
2560 (modest_account_mgr_get_connection_specific_smtp):
2561 * src/modest-account-mgr-helpers.h: Some functions to write the
2562 connection-specific SMTP server information. Not yet used.
2565 * src/widgets/modest-folder-view.c: (text_cell_data):
2566 Fix a warning about an uninitialized variable.
2567 (on_configuration_key_changed): Put an #ifdef around the use
2568 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2570 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2572 * src/maemo/modest-account-settings-dialog.h:
2573 * src/maemo/modest-account-settings-dialog.c:
2574 Added connect_for_modified() utility function to mark the new modified boolean.
2576 (create_page_account_details), (create_page_user_details),
2577 (create_page_incoming), (create_page_outgoing), (on_response),
2578 (modest_account_settings_dialog_init),
2579 (modest_account_settings_dialog_set_account_name):
2580 Only warn about unsaved changes when there are actually unsaved changes.
2582 * src/modest-account-mgr-helpers.c:
2583 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2584 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2585 to get the data from there in future.
2587 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2589 * src/modest-defs.h:
2591 * src/modest-account-mgr-helpers.h:
2592 * src/modest-account-mgr-helpers.c:
2593 Store the security account setting in a single conf key instead of using
2594 the options list, so that the list is left for just the to-be-removed camel hack,
2595 and because gconf_client_set_list() is failing for some reason.
2597 * src/modest-account-mgr.c:
2598 (modest_account_mgr_add_server_account):
2599 * src/maemo/modest-account-settings-dialog.c:
2600 (modest_account_settings_dialog_set_account_name),
2601 (save_configuration): Use the renamed functions.
2604 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2606 * src/widgets/Makefile.am:
2607 * src/widgets/modest-limit-retrieve-combo-box.c:
2608 * src/widgets/modest-limit-retrieve-combo-box.h:
2609 * src/widgets/modest-retrieve-combo-box.c:
2610 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2611 the account settings dialog.
2613 * src/modest-defs.h:
2614 * src/modest-account-mgr-helpers.h:
2615 * src/modest-account-mgr-helpers.c:
2616 (modest_server_account_get_option_secure_auth),
2617 (modest_server_account_set_option_secure_auth):
2618 * src/modest-account-mgr.c:
2619 (modest_account_mgr_add_server_account):
2620 Use the existing AUTH_MECH conf key for the secure-auth setting,
2621 instead of putting it in the list options, because this was actually used already.
2623 * src/maemo/modest-account-settings-dialog.c:
2624 (create_page_account_details),
2625 (modest_account_settings_dialog_set_account_name),
2626 (save_configuration):
2627 * src/maemo/modest-account-settings-dialog.h:
2628 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2629 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2631 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2634 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2635 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2637 * src/modest-defs.h:
2638 * src/maemo/modest-account-settings-dialog.c:
2639 (create_page_incoming), (on_combo_outgoing_security_changed),
2640 (on_combo_incoming_security_changed), (create_page_outgoing),
2641 (modest_account_settings_dialog_set_account_name),
2642 (save_configuration): Load/Save the port number, and change it when the
2643 security combo changes, to suitable defaults.
2645 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2647 * src/modest-account-mgr.c:
2648 (modest_account_mgr_add_server_account): Set the security and secure-auth
2649 options, and add a comment saying that the other camel-specific options should be
2652 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2654 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2656 * src/modest-tny-account-store.c: (account_list_free),
2657 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2658 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2661 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-protocol-info.c:
2664 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2665 is required by our UI spec. Maybe something in our implementation will use this eventually.
2666 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2667 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2668 instead of the previous 0 placeholder.
2670 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2671 secure-auth settings.
2672 * src/modest-account-mgr-helpers.h:
2673 * src/modest-account-mgr-helpers.c:
2674 (modest_server_account_data_get_option_secure_auth),
2675 (modest_server_account_set_option_secure_auth),
2676 (modest_server_account_data_get_option_security),
2677 (modest_server_account_set_option_security): Added this API for getting and setting the security
2678 and secure-auth settings.
2680 * src/maemo/modest-account-settings-dialog.h:
2681 * src/maemo/modest-account-settings-dialog.c:
2682 (modest_account_settings_dialog_finalize), (check_data),
2683 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2684 about changing titles.
2685 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2686 (save_configuration): Save the security and secure-auth settings.
2688 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2689 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2691 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-defs.h:
2694 * src/modest-account-mgr.c:
2695 (modest_account_mgr_add_server_account):
2696 Added and used defines for the options key and value pair strings,
2697 that are used so far, though they do not seem to correspond to anything in our
2698 UI specs or ModestProtocol enum.
2700 * src/modest-account-mgr-helpers.h:
2701 * src/modest-account-mgr-helpers.c:
2702 (compare_option_strings_for_name),
2703 (modest_server_account_data_get_option_value),
2704 (modest_server_account_data_get_option_bool),
2705 (modest_account_mgr_get_server_account_option):
2706 Added helper functions for parsing the options GSList.
2708 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2710 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2711 display name is based on the supplied account name.
2712 * src/modest-account-mgr.c:
2713 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2714 with an inefficient, but good-enough, implementation.
2716 * src/maemo/easysetup/modest-easysetup-wizard.c:
2717 (create_page_account_details), (on_before_next), (create_account):
2718 Check for existing display names rather than (non-user-visible) account names, and just
2719 create and set a unique account name at the end.
2721 * src/maemo/modest-account-settings-dialog.c:
2722 (modest_account_settings_dialog_init),
2723 (modest_account_settings_dialog_set_account_name),
2724 (create_page_incoming): Show the display name, instead of the account name.
2725 (on_response): Do some (not all) extra checks, as in the UI spec.
2726 (save_configuration): Save the display name if it was changed.
2728 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2730 * po/en_GB.po: Added needed logical ID and translation.
2731 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2732 (init_view): Made the is-default column clicking work.
2734 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2737 * src/maemo/easysetup/Makefile.am:
2738 * src/maemo/easysetup/modest-easysetup-wizard.c:
2739 (modest_easysetup_wizard_dialog_init):
2740 * src/maemo/easysetup/provider-data-test.keyfile:
2741 * src/maemo/easysetup/provider-data.keyfile:
2742 Moved the provider data file to the new modest-providers-data package and used it from there.
2744 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2746 * src/modest-local-folder-info.c:
2747 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2748 N_() was already used on the static strings, but this just marks it for translation without
2749 using the translation.
2751 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2753 * src/maemo/modest-account-settings-dialog.c:
2754 (create_page_incoming),
2755 (modest_account_settings_dialog_set_account_name):
2756 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2757 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2758 I will do this if nobody else gets there first.
2760 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2763 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2764 save the security stuff.
2766 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2769 Set the email address and user fullname, which I now see must be
2772 * src/maemo/modest-account-settings-dialog.h:
2773 * src/maemo/modest-account-settings-dialog.c:
2775 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2776 leave-on-server and authentication.
2777 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2780 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2783 * src/maemo/modest-account-settings-dialog.c:
2784 * src/maemo/modest-account-settings-dialog.h:
2785 Most (but not all) of the widgets are now present as specified by the UI spec.
2786 No changes are yet saved, and some details are not properly shown yet.
2788 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2790 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/Makefile.am:
2793 * src/maemo/modest-account-settings-dialog.c:
2794 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2795 an existing account. Doesn't do much yet.
2797 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2798 Open the accounts settings dialog when Edit is clicked.
2800 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/easysetup/Makefile.am:
2803 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2805 * src/maemo/easysetup/modest-easysetup-wizard.c:
2806 (modest_easysetup_wizard_dialog_init):
2807 Try to get the source directory from the build system,
2808 instead of hard-coding "./" into the source code, when opening our local
2809 copies of the configuration files.
2810 But this still fails when opening the wizard from the Accounts window,
2811 maybe because the working directory seems to change at runtime.
2812 So the wizard will fail the second time unless you copy the files into their
2813 proper locations - see the stdout warnings for the paths.
2815 (create_page_account_details),(on_before_next):
2816 Check for existing non-server accounts instead of server accounts,
2817 so the default account name is useful again, and to prevent trying to
2820 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2821 Show the wizard when New is clicked.
2823 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2824 (init_view): Show the column headers, and show the columns that are
2825 specified in the UI specs. However, something in Maemo's GTK+ prevents
2826 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2827 change the default account. This is despite unsetting the special properties.
2829 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2831 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2832 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2833 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2834 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2835 to make that clearer.
2836 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2838 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2840 * src/maemo/modest-account-view-window.c:
2841 (modest_account_view_window_init),
2842 (modest_account_view_window_new):
2843 Use the same buttons as specified in the
2844 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2845 the existing widgets, which never had a chance of working.
2846 Put the ModestAccountView treeview in a scrolled window.
2847 Do not repeat the initialization in both _init() and _new().
2849 * src/widgets/modest-account-view.c: (update_account_view):
2850 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2851 this widget and window shows no accounts.
2853 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2855 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/easysetup/modest-easysetup-wizard.c:
2858 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2859 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2860 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2863 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2864 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2865 accounts exist yet, as in the UI spec.
2867 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2869 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2871 * src/maemo/Makefile.am:
2872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2873 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2874 New window for editing connection-specific smtp details.
2875 Not fully implemented.
2877 * src/maemo/modest-connection-specific-smtp-window.c:
2878 (modest_connection_specific_smtp_window_finalize) :
2879 unref the tree model.
2880 (on_button_edit): Show the edit window.
2882 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2884 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2887 * src/maemo/Makefile.am:
2888 * src/maemo/modest-connection-specific-smtp-window.c:
2889 * src/maemo/modest-connection-specific-smtp-window.h:
2890 New window for showing the list of connections, for connection-specific
2891 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2892 * src/maemo/easysetup/modest-easysetup-wizard.c:
2893 (create_page_custom_outgoing): Show the new window when the button is clicked.
2895 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2897 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2898 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2899 * src/maemo/modest-msg-edit-window.c:
2900 (modest_msg_edit_window_insert_image):
2901 * src/modest-conf.c: (modest_conf_key_escape):
2902 * src/modest-mail-operation.c:
2903 (modest_mail_operation_send_new_mail):
2904 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2905 (modest_ui_actions_on_new_account):
2906 * src/widgets/modest-attachment-view.c: (update_filename_request):
2907 * src/widgets/modest-mail-header-view.c:
2908 Corrected warnings that were breaking the build, by commenting out unused variables,
2909 and a function, and by including a header.
2911 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2913 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2914 so we can #ifdef around platform-specific code when necessary.
2915 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2916 to allow this to build for the GNOME platform too.
2918 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 Added util_increment_name() and used it in create_page_account_details()
2922 to make sure that the default account name is always a new name.
2924 (modest_easysetup_wizard_dialog_init),
2925 (set_default_custom_servernames): Some minor memory management fixes.
2927 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2931 * src/modest-runtime.c: (init_i18n): Restored the translation
2932 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2933 are defined in config.h, and the translations are installed.
2935 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2936 is defined for translation.
2938 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2940 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2942 * src/maemo/easysetup/modest-easysetup-wizard.c:
2943 (modest_easysetup_wizard_dialog_init):
2944 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2945 Use realistic paths (though they should use $prefix generically) to the
2946 mcc_mapping and provider-data.keyfile files which might work when they
2947 are installed by the future version of the operator-wizard package,
2948 and then fallback to paths in our source code, with an explanatory
2951 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/Makefile.am:
2956 * src/maemo/easysetup/: Added files from the previously-exernal
2957 osso-modest-easysetup.
2958 * src/maemo/modest-main-window-ui.h:
2959 * src/modest-ui-actions.c:
2960 * src/modest-ui-actions.h:
2961 Added modest_ui_actions_on_new_account() as a signal handler for the
2962 New Account menu item. It shows the easysetup wizard.
2963 * po/en_GB.po: Added additional needed logical IDs and translations.
2965 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2966 Apparently ChangeLog is not used for some vague Nokia legal reasons.