git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-account-mgr-helpers.h:
   4         * src/modest-account-mgr-helpers.c:
   5         Added modest_account_mgr_unset_default_account(),
   6         Added modest_account_mgr_set_first_account_as_default().
   7
   8         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
   9         If it was the default account, unset the default account name.
  10
  11         * src/maemo/modest-account-view-window.c:
  12         (on_delete_button_clicked): If it was the default account,
  13         set the first remaining account as the default instead.
  14
  15         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
  16         a NULL account or a NULL default account, to prevent a crash. This should
  17         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
  18
  19
  20 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  21
  22         * src/widgets/modest-recpt-editor.c:
  23         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
  24         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
  25         TODO comment for this. This fixes the build.
  26
  27         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
  28         be the best place for it. This will in future update all auto-update accounts,
  29         rather than just the current/default account, when that gconf key exists.
  30         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
  31         if there are no accounts, before calling do_send_receive().
  32         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
  33
  34         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
  35         * src/maemo/modest-main-window-ui.h:
  36         * src/maemo/modest-main-window.c: (on_connection_changed),
  37         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
  38         directly, becaue the signal handler does more.
  39
  40 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  41
  42         * src/modest-account-mgr-helpers.c:
  43         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
  44         for the case that the account does not exist.
  45
  46         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
  47         (equivalent to the modest account name) rather than the tinymail account name
  48         (equivalent to the modest account title - human readable) to get the account data.
  49         Check for null account data to prevent the crash, and add a TODO comment saying that
  50         this needs fixing because it is using the server account name instead of the account name.
  51
  52 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
  53
  54         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
  55         * src/maemo/modest-account-settings-dialog.c: (show_error),
  56         (show_ok):
  57         Use hildon_note_new_information() for informative and error messages,
  58         which seems to be expected for Maemo applications (no documentation that I know of
  59         says this). I am surprised that there is no distinction between info and error
  60         dialogs.
  61
  62 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
  63
  64         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
  65         it is easy to find where this is used.
  66
  67         * src/maemo/easysetup/modest-easysetup-wizard.c:
  68         (create_page_welcome), (create_page_account_details),
  69         (create_page_user_details), (create_page_complete_easysetup),
  70         (create_page_custom_incoming), (create_page_custom_outgoing),
  71         (create_page_complete_custom):
  72         * src/maemo/modest-account-settings-dialog.c:
  73         (create_page_account_details), (create_page_user_details),
  74         (create_page_incoming), (create_page_outgoing):
  75         * src/maemo/modest-account-view-window.c: (window_vbox_new):
  76         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  77         (modest_connection_specific_smtp_edit_window_init):
  78         * src/maemo/modest-connection-specific-smtp-window.c:
  79         (modest_connection_specific_smtp_window_init):
  80         * src/maemo/modest-signature-editor-dialog.c:
  81         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
  82         and scrolling policy as per the Email Application Layout Guide, if I have
  83         understood it.
  84
  85 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  86
  87         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
  88         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
  89         which were empty, because these vfuncs have been removed from TnyAccountStore.
  90         This fixes the build.
  91
  92 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  93
  94         * src/maemo/modest-main-window.c:
  95         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
  96         showing/hiding it. Added TODO because it probably should not be NULL.
  97         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
  98         because unnecessary g_warnings() make degugging difficult.
  99
 100 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 101
 102         * src/maemo/modest-msg-edit-window.c:
 103         (modest_msg_edit_window_select_color),
 104         (modest_msg_edit_window_select_background_color): 2 const corrections and
 105         moving 2 #endifs before closing brackets, to fix the build.
 106
 107 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 108
 109         * src/maemo/easysetup/modest-easysetup-wizard.h:
 110         * src/maemo/easysetup/modest-easysetup-wizard.c:
 111         (modest_easysetup_wizard_dialog_finalize),
 112         (on_button_edit_advanced_settings), (create_page_complete_custom),
 113         (on_response), (create_account):
 114         Implement the Advanced Settings edit button, by saving the account information,
 115         for the Advanded Settings dialog to use directly from gconf, and removing it
 116         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 117         Bug #5533 in the projects.maemo.org bugzilla.
 118
 119 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 120
 121         * src/maemo/modest-msg-view-window.c:
 122         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 123         when opening a message window.
 124
 125 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 126
 127         * src/maemo/easysetup/modest-easysetup-wizard.c:
 128         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 129         match the UI spec.
 130
 131         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 132         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 133         gconf settings. I probably added more checks than necessary, but that is safer.
 134
 135         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 136         variable to fix the build, but this seems to be used when it is still NULL.
 137
 138 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 139
 140         * src/modest-platform.h:
 141         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 142         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 143         * src/modest-main.c: Implement this function so we can avoid using
 144         maemo-specific API from cross-platform code.
 145         (main):
 146         * src/modest-tny-account-store.c:
 147         (get_smtp_specific_transport_account_for_open_connection):
 148         * src/modest-ui-actions.c: (check_for_connection),
 149         (modest_ui_actions_on_item_not_found):
 150         Use modest_platform_connect_and_wait() and put #idefs around other
 151         maemo-specific code, because only maemo currently has a way to
 152         identify connection names.
 153
 154 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 155
 156         * src/modest-tny-account-store.h:
 157         * src/modest-tny-account-store.c:
 158         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 159         the connection-specific SMTP server settings in the configuration.
 160
 161         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 162         (on_idle_mail_to):
 163         * src/maemo/modest-main-window.c: (on_connection_changed),
 164         (connect_signals):
 165         * src/modest-main.c: (main), (start_ui), (send_mail):
 166         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 167         that is what is intended.
 168
 169         * src/modest-ui-actions.c: (action_send), (action_receive),
 170         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 171         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 172         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 173         SMTP server is used when it is specified.
 174
 175         (modest_ui_actions_on_send_receive):
 176         Check that a connection is open before proceeding.
 177         Receive and then send, instead of vice-versa, as per the specification.
 178
 179 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 180
 181         * src/modest-mail-operation.c:
 182         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 183         though I guess it should be something other than NULL.
 184
 185 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 186
 187         * src/maemo/easysetup/modest-easysetup-wizard.c:
 188         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 189         combo twice, to avoid an g_warning and to make it visible again.
 190         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 191         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 192         (already intended) dereference when detaching, because we then recreate the menu.
 193         But I am not sure why the warning was happening, and it is possible that this is a memory
 194         leak.
 195
 196 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 197
 198         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 199         and uri_parse_mailto() utility functions.
 200         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 201         the mailto URI.
 202         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 203
 204 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 205
 206         * src/dbus_api/modest-dbus-api.h:
 207         * src/dbus_api/modest-dbus-callbacks.c:
 208         Use an idle callback to execute the modest code in the application's own thread.
 209         Remove the helloworld example method.
 210         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 211         parsed, and the open-message method is not implemented because this is not yet implemented in
 212         modest itself.
 213         * libmodest-dbus-client/libmodest-dbus-client.c:
 214         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 215         (libmodest_dbus_client_open_message):
 216         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 217
 218         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 219         body without crashing.
 220
 221         * tests/dbus_api/Makefile.am:
 222         * tests/dbus_api/test_mail_to.c:
 223         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 224
 225 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 226
 227         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 228         Added file to fix the build. Sorry.
 229
 230         * src/dbus_api/Makefile.am:
 231         * src/dbus_api/modest-dbus-api.h:
 232         * src/dbus_api/modest-dbus-callbacks.h:
 233         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 234         (modest_dbus_req_handler):
 235         Put constants in a separate header so it can be reused by the
 236         client library, without duplication
 237
 238         * libmodest-dbus-client/Makefile.am:
 239         * libmodest-dbus-client/libmodest-dbus-client.c:
 240         (libmodest_dbus_client_call_helloworld),
 241         (libmodfest_dbus_client_send_mail),
 242         (libmodfest_dbus_client_mailto),
 243         (libmodfest_dbus_client_open_message):
 244         * libmodest-dbus-client/libmodest-dbus-client.h:
 245         (Partly) Implement a send_mail D-Bus method.
 246
 247         * tests/dbus_api/Makefile.am:
 248         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 249         the send_email D-Bus method.
 250
 251 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 252
 253         * Makefile.am:
 254         * configure.ac:
 255         * libmodest-dbus-client/Makefile.am:
 256         * libmodest-dbus-client/libmodest-dbus-client.c:
 257         * libmodest-dbus-client/libmodest-dbus-client.h:
 258         * tests/dbus_api/Makefile.am:
 259         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 260         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 261
 262 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/maemo/easysetup/modest-easysetup-wizard.c:
 265         (create_page_account_details):
 266         * src/maemo/modest-account-settings-dialog.c:
 267         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 268         widgets, because this might not be the default in future versions of the Maemo GTK+.
 269         However, I can not not get capitalization to work even in a simple test case.
 270
 271 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 272
 273         * src/maemo/easysetup/modest-easysetup-wizard.c:
 274         (create_page_custom_incoming), (create_page_custom_outgoing):
 275         * src/maemo/modest-account-settings-dialog.c:
 276         (create_page_account_details), (create_page_incoming),
 277         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 278         instead of using gtk_check_button_with_label(), so they are aligned like the other
 279         widgets, as per the UI spec.
 280
 281 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 282
 283         * src/maemo/easysetup/modest-easysetup-wizard.c:
 284         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 285         * src/widgets/modest-validating-entry.c:
 286         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 287         Modest prefix instead of an EasySetup prefix.
 288
 289 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 290
 291         * src/widgets/modest-validating-entry.h:
 292         * src/widgets/modest-validating-entry.c: (on_insert_text),
 293         Added easysetup_validating_entry_set_max_func(), used to set a callback
 294         to call when the max number of characters is reached. GtkEntry has a max-length
 295         already but is silent about it.
 296
 297         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 298         (create_page_account_details), (create_page_user_details),
 299         (create_account):
 300         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 301         (create_page_account_details), (create_page_user_details),
 302         (create_page_outgoing):
 303         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 304         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 305         the UI spec, when the user tries to enter more than the max number of characters.
 306
 307 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 308
 309         * src/maemo/easysetup/modest-easysetup-wizard.c:
 310         (create_page_user_details), (create_page_custom_incoming),
 311         (create_page_custom_outgoing):
 312         * src/maemo/modest-account-settings-dialog.c:
 313         (create_page_user_details), (create_page_incoming),
 314         (create_page_outgoing):
 315         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 316         (modest_connection_specific_smtp_edit_window_init):
 317         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 318         not appropriate. Bad Maemo-specific defaults!.
 319
 320 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 321
 322         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 323         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 324         (modest_signature_editor_dialog_set_settings):
 325         Disable the label and textview when the checkbox is disabled, and use the
 326         specified (UI spec) default signature text.
 327
 328 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 329
 330         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 331         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 332
 333         * src/modest-defs.h:
 334         * src/modest-account-mgr-helpers.h:
 335         * src/modest-account-mgr-helpers.c:
 336         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 337
 338         * src/maemo/Makefile.am:
 339         * src/maemo/modest-signature-editor-dialog.c:
 340         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 341         as per the UI spec.
 342
 343         * src/maemo/modest-account-settings-dialog.h:
 344         * src/maemo/modest-account-settings-dialog.c:
 345         (modest_account_settings_dialog_finalize), (on_button_signature),
 346         (save_configuration): Use the new dialog when the Edit button is pressed, and
 347         save the changes if necessary, as per the UI spec.
 348
 349 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 350
 351         * src/maemo/Makefile.am:
 352         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 353         based on maemo-develoers email from Dirk.
 354
 355         * src/maemo/easysetup/modest-easysetup-wizard.c:
 356         (create_page_welcome), (create_page_account_details),
 357         (create_page_user_details), (create_page_complete_easysetup),
 358         (create_page_custom_incoming), (create_page_custom_outgoing),
 359         (create_page_complete_custom),
 360         (modest_easysetup_wizard_dialog_init):
 361         * src/maemo/modest-account-settings-dialog.c:
 362         (create_page_account_details), (create_page_user_details),
 363         (create_page_incoming), (create_page_outgoing),
 364         (modest_account_settings_dialog_init):
 365         * src/maemo/modest-connection-specific-smtp-window.c:
 366         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 367
 368 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 369
 370         * src/maemo/easysetup/modest-easysetup-wizard.c:
 371         (create_page_account_details), (create_page_custom_outgoing),
 372         (create_page_complete_custom):
 373         * src/maemo/modest-account-settings-dialog.c:
 374         (create_page_user_details), (create_page_incoming),
 375         (create_page_outgoing):
 376         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 377         (modest_connection_specific_smtp_edit_window_init):
 378         Use the correct (UI spec) port min/max, and use horizontal separators,
 379         as per the UI spec.
 380
 381 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 382
 383         * src/maemo/easysetup/modest-easysetup-wizard.c:
 384         (set_default_custom_servernames):
 385         * src/maemo/modest-account-settings-dialog.c:
 386         (create_page_incoming), (on_combo_outgoing_security_changed),
 387         (on_combo_incoming_security_changed), (create_page_outgoing),
 388         (modest_account_settings_dialog_set_account_name),
 389         (save_configuration):
 390         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 391         (on_combo_security_changed),
 392         (modest_connection_specific_smtp_edit_window_init),
 393         (modest_connection_specific_smtp_edit_window_set_connection),
 394         (modest_connection_specific_smtp_edit_window_get_settings):
 395         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 396         as per the UI spec.
 397
 398 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 399
 400         * po/en_GB.po:
 401         * src/maemo/easysetup/modest-easysetup-wizard.c:
 402         (create_page_custom_outgoing), (create_page_complete_custom):
 403         * src/maemo/modest-account-settings-dialog.c:
 404         (create_page_user_details), (create_page_outgoing):
 405         * src/maemo/modest-account-view-window.c: (button_box_new):
 406         Use changed logical IDs as per the most recent UI spec:
 407         mcen_bd_emailsetup_edit -> mcen_bd_edit
 408         mcen_bd_emailsetup_delete -> mcen_bd_delete
 409         mcen_bd_emailsetup_close -> mcen_bd_close
 410
 411 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 412
 413         * configure.ac:
 414         * src/Makefile.am:
 415         * src/dbus_api/Makefile.am:
 416         * src/dbus_api/modest-dbus-callbacks.c:
 417         * src/dbus_api/modest-dbus-callbacks.h:
 418         * src/maemo/modest-platform.c: (modest_platform_init):
 419         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 420         method.
 421         * tests/Makefile.am:
 422         * tests/dbus_api/Makefile.am:
 423         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 424
 425 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 426
 427         * src/maemo/modest-account-settings-dialog.c:
 428         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 429         Removed unnecessary includes.
 430
 431 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 432
 433         * src/maemo/easysetup/modest-easysetup-wizard.c:
 434         * src/maemo/modest-account-settings-dialog.c:
 435         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 436         * src/widgets/Makefile.am:
 437         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 438         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 439         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 440         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 441         * src/widgets/modest-secureauth-combo-box.c:
 442         * src/widgets/modest-secureauth-combo-box.h:
 443         * src/widgets/modest-serversecurity-combo-box.c:
 444         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 445         made the GObject names more consistent with the rest of the Modest code.
 446
 447 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 448
 449         * src/maemo/easysetup/Makefile.am:
 450         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 451         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 452         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 453         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 454         * src/maemo/easysetup/modest-easysetup-wizard.c:
 455         * src/maemo/easysetup/modest-validating-entry.c:
 456         * src/maemo/easysetup/modest-validating-entry.h:
 457         * src/maemo/modest-account-settings-dialog.c:
 458         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 459         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 460         widgets/ because they are used outside of easysetup too. After checking in,
 461         svn will allow me to rename them too.
 462
 463 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 464
 465         * src/gnome/modest-msg-edit-window.c:
 466         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 467         linker error, to fix the build on the GNOME platform.
 468         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 469         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 470         ifdefed out to avoid a warning.
 471
 472 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 473
 474         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 475         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 476         some alternative for GTK+ 2.6.
 477
 478 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 479
 480         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 481
 482         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 483         specified for EmailAccountsDialog in UI spec.
 484
 485         * src/maemo/easysetup/modest-easysetup-wizard.c:
 486         * src/maemo/easysetup/modest-easysetup-wizard.h:
 487         * src/maemo/modest-account-settings-dialog.c:
 488         * src/maemo/modest-account-settings-dialog.h:
 489         Reuse a member window widget for the connection-specific SMTP server accounts,
 490         so we can tell it to create/save the accounts only if we actually save changes.
 491
 492         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 493         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 494         (modest_connection_specific_smtp_edit_window_get_settings):
 495         Return a struct instance for temporarily remembering the entered data.
 496
 497         * src/maemo/modest-connection-specific-smtp-window.h:
 498         * src/maemo/modest-connection-specific-smtp-window.c:
 499         (modest_connection_specific_smtp_window_finalize),
 500         (modest_connection_specific_smtp_window_fill_with_connections),
 501         (on_button_edit),
 502         (modest_connection_specific_smtp_window_save_server_accounts),
 503         (update_model_server_names): Do not actually save data until asked,
 504         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 505
 506         (on_selection_changed),
 507         (modest_connection_specific_smtp_window_init): Disable the edit
 508         button when nothing is selected.
 509
 510         * src/modest-account-mgr-helpers.c:
 511         * src/modest-account-mgr-helpers.h:
 512         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 513         elsewhere.
 514
 515 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 516
 517         * src/modest-account-mgr-helpers.h:
 518         * src/modest-account-mgr-helpers.c:
 519         (modest_account_mgr_get_unused_account_name),
 520         (modest_account_mgr_get_unused_account_display_name): Added these
 521         utility functions, to avoid code duplication.
 522
 523         * src/maemo/easysetup/modest-easysetup-wizard.c:
 524         (create_page_account_details), (create_account):
 525         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 526         (on_combo_security_changed),
 527         (modest_connection_specific_smtp_edit_window_init),
 528         (modest_connection_specific_smtp_edit_window_save_settings):
 529         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 530         * src/maemo/modest-connection-specific-smtp-window.c:
 531         (modest_connection_specific_smtp_window_finalize),
 532         (modest_connection_specific_smtp_window_fill_with_connections),
 533         (on_button_edit), (modest_connection_specific_smtp_window_init):
 534         * src/maemo/modest-connection-specific-smtp-window.h:
 535         Implementing saving of connection-specific server accounts.
 536
 537         But I need to refactor this so we can save the data for each
 538         possible connection-specific account and only actually create the server accounts
 539         when the easysetup finished, or the OK button is pressed on the account settings
 540         dialog.
 541
 542 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 543
 544         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 545         (on_combo_security_changed):
 546         (modest_connection_specific_smtp_edit_window_init):
 547         Auto-fill the port number as in the account settings.
 548
 549         (modest_connection_specific_smtp_edit_window_set_connection):
 550         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 551         * src/maemo/modest-connection-specific-smtp-window.c:
 552         (fill_with_connections), (on_button_edit),
 553         (modest_connection_specific_smtp_window_init):
 554         Turn the edit window into a dialog to simplify the code, and
 555         set a WM hint as in a GtkDialog, because only a popup can be on top of
 556         another window in Maemo, and popups usually have no WM decoration.
 557
 558         * src/modest-defs.h:
 559         * src/modest-account-mgr-helpers.c:
 560         (modest_account_mgr_set_connection_specific_smtp),
 561         (modest_account_mgr_remove_connection_specific_smtp),
 562         (modest_account_mgr_get_connection_specific_smtp):
 563         * src/modest-account-mgr-helpers.h: Some functions to write the
 564         connection-specific SMTP server information. Not yet used.
 565
 566
 567         * src/widgets/modest-folder-view.c: (text_cell_data):
 568         Fix a warning about an uninitialized variable.
 569         (on_configuration_key_changed): Put an #ifdef around the use
 570         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 571
 572 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 573
 574         * src/maemo/modest-account-settings-dialog.h:
 575         * src/maemo/modest-account-settings-dialog.c:
 576         Added connect_for_modified() utility function to mark the new modified boolean.
 577
 578         (create_page_account_details), (create_page_user_details),
 579         (create_page_incoming), (create_page_outgoing), (on_response),
 580         (modest_account_settings_dialog_init),
 581         (modest_account_settings_dialog_set_account_name):
 582         Only warn about unsaved changes when there are actually unsaved changes.
 583
 584         * src/modest-account-mgr-helpers.c:
 585         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 586         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 587         to get the data from there in future.
 588
 589 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 590
 591         * src/modest-defs.h:
 592
 593         * src/modest-account-mgr-helpers.h:
 594         * src/modest-account-mgr-helpers.c:
 595         Store the security account setting in a single conf key instead of using
 596         the options list, so that the list is left for just the to-be-removed camel hack,
 597         and because gconf_client_set_list() is failing for some reason.
 598
 599         * src/modest-account-mgr.c:
 600         (modest_account_mgr_add_server_account):
 601         * src/maemo/modest-account-settings-dialog.c:
 602         (modest_account_settings_dialog_set_account_name),
 603         (save_configuration): Use the renamed functions.
 604
 605
 606 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * src/widgets/Makefile.am:
 609         * src/widgets/modest-limit-retrieve-combo-box.c:
 610         * src/widgets/modest-limit-retrieve-combo-box.h:
 611         * src/widgets/modest-retrieve-combo-box.c:
 612         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 613         the account settings dialog.
 614
 615         * src/modest-defs.h:
 616         * src/modest-account-mgr-helpers.h:
 617         * src/modest-account-mgr-helpers.c:
 618         (modest_server_account_get_option_secure_auth),
 619         (modest_server_account_set_option_secure_auth):
 620         * src/modest-account-mgr.c:
 621         (modest_account_mgr_add_server_account):
 622         Use the existing AUTH_MECH conf key for the secure-auth setting,
 623         instead of putting it in the list options, because this was actually used already.
 624
 625         * src/maemo/modest-account-settings-dialog.c:
 626         (create_page_account_details),
 627         (modest_account_settings_dialog_set_account_name),
 628         (save_configuration):
 629         * src/maemo/modest-account-settings-dialog.h:
 630         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 631         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 632
 633 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 634
 635         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 636         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 637         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 638
 639         * src/modest-defs.h:
 640         * src/maemo/modest-account-settings-dialog.c:
 641         (create_page_incoming), (on_combo_outgoing_security_changed),
 642         (on_combo_incoming_security_changed), (create_page_outgoing),
 643         (modest_account_settings_dialog_set_account_name),
 644         (save_configuration): Load/Save the port number, and change it when the
 645         security combo changes, to suitable defaults.
 646
 647 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * src/modest-account-mgr.c:
 650         (modest_account_mgr_add_server_account): Set the security and secure-auth
 651         options, and add a comment saying that the other camel-specific options should be
 652         removed in future.
 653
 654 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 655
 656         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 657         found by valgrind.
 658         * src/modest-tny-account-store.c: (account_list_free),
 659         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 660         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 661         easy to fix.
 662
 663 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 664
 665         * src/modest-protocol-info.c:
 666         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 667         is required by our UI spec. Maybe something in our implementation will use this eventually.
 668         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 669         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 670         instead of the previous 0 placeholder.
 671
 672         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 673         secure-auth settings.
 674         * src/modest-account-mgr-helpers.h:
 675         * src/modest-account-mgr-helpers.c:
 676         (modest_server_account_data_get_option_secure_auth),
 677         (modest_server_account_set_option_secure_auth),
 678         (modest_server_account_data_get_option_security),
 679         (modest_server_account_set_option_security): Added this API for getting and setting the security
 680         and secure-auth settings.
 681
 682         * src/maemo/modest-account-settings-dialog.h:
 683         * src/maemo/modest-account-settings-dialog.c:
 684         (modest_account_settings_dialog_finalize), (check_data),
 685         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 686         about changing titles.
 687         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 688         (save_configuration): Save the security and secure-auth settings.
 689
 690         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 691         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 692
 693 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 694
 695         * src/modest-defs.h:
 696         * src/modest-account-mgr.c:
 697         (modest_account_mgr_add_server_account):
 698         Added and used defines for the options key and value pair strings,
 699         that are used so far, though they do not seem to correspond to anything in our
 700         UI specs or ModestProtocol enum.
 701
 702         * src/modest-account-mgr-helpers.h:
 703         * src/modest-account-mgr-helpers.c:
 704         (compare_option_strings_for_name),
 705         (modest_server_account_data_get_option_value),
 706         (modest_server_account_data_get_option_bool),
 707         (modest_account_mgr_get_server_account_option):
 708         Added helper functions for parsing the options GSList.
 709
 710 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 711
 712         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 713         display name is based on the supplied account name.
 714         * src/modest-account-mgr.c:
 715         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 716         with an inefficient, but good-enough, implementation.
 717
 718         * src/maemo/easysetup/modest-easysetup-wizard.c:
 719         (create_page_account_details), (on_before_next), (create_account):
 720         Check for existing display names rather than (non-user-visible) account names, and just
 721         create and set a unique account name at the end.
 722
 723         * src/maemo/modest-account-settings-dialog.c:
 724         (modest_account_settings_dialog_init),
 725         (modest_account_settings_dialog_set_account_name),
 726         (create_page_incoming): Show the display name, instead of the account name.
 727         (on_response): Do some (not all) extra checks, as in the UI spec.
 728         (save_configuration): Save the display name if it was changed.
 729
 730 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 731
 732         * po/en_GB.po: Added needed logical ID and translation.
 733         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 734         (init_view): Made the is-default column clicking work.
 735
 736 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 737
 738         * configure.ac:
 739         * src/maemo/easysetup/Makefile.am:
 740         * src/maemo/easysetup/modest-easysetup-wizard.c:
 741         (modest_easysetup_wizard_dialog_init):
 742         * src/maemo/easysetup/provider-data-test.keyfile:
 743         * src/maemo/easysetup/provider-data.keyfile:
 744         Moved the provider data file to the new modest-providers-data package and used it from there.
 745
 746 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 747
 748         * src/modest-local-folder-info.c:
 749         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 750         N_() was already used on the static strings, but this just marks it for translation without
 751         using the translation.
 752
 753 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 754
 755         * src/maemo/modest-account-settings-dialog.c:
 756         (create_page_incoming),
 757         (modest_account_settings_dialog_set_account_name):
 758         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 759         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 760         I will do this if nobody else gets there first.
 761
 762 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 763
 764         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 765         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 766         save the security stuff.
 767
 768 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 769
 770         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 771         Set the email address and user fullname, which I now see must be
 772         done separately.
 773
 774         * src/maemo/modest-account-settings-dialog.h:
 775         * src/maemo/modest-account-settings-dialog.c:
 776          (on_response),
 777         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 778         leave-on-server and authentication.
 779         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 780         how to do the rest.
 781
 782 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 783
 784
 785         * src/maemo/modest-account-settings-dialog.c:
 786         * src/maemo/modest-account-settings-dialog.h:
 787         Most (but not all) of the widgets are now present as specified by the UI spec.
 788         No changes are yet saved, and some details are not properly shown yet.
 789
 790         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 791
 792 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 793
 794         * src/maemo/Makefile.am:
 795         * src/maemo/modest-account-settings-dialog.c:
 796         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 797         an existing account. Doesn't do much yet.
 798
 799         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 800         Open the accounts settings dialog when Edit is clicked.
 801
 802 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 803
 804         * src/maemo/easysetup/Makefile.am:
 805         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 806         (load_from_file):
 807         * src/maemo/easysetup/modest-easysetup-wizard.c:
 808         (modest_easysetup_wizard_dialog_init):
 809         Try to get the source directory from the build system,
 810         instead of hard-coding "./" into the source code, when opening our local
 811         copies of the configuration files.
 812         But this still fails when opening the wizard from the Accounts window,
 813         maybe because the working directory seems to change at runtime.
 814         So the wizard will fail the second time unless you copy the files into their
 815         proper locations - see the stdout warnings for the paths.
 816
 817         (create_page_account_details),(on_before_next):
 818         Check for existing non-server accounts instead of server accounts,
 819         so the default account name is useful again, and to prevent trying to
 820         recreate accounts.
 821
 822         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 823         Show the wizard when New is clicked.
 824
 825         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 826         (init_view): Show the column headers, and show the columns that are
 827         specified in the UI specs. However, something in Maemo's GTK+ prevents
 828         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 829         change the default account. This is despite unsetting the special properties.
 830
 831 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 832
 833         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 834         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 835         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 836         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 837         to make that clearer.
 838         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 839
 840 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 841
 842         * src/maemo/modest-account-view-window.c:
 843         (modest_account_view_window_init),
 844         (modest_account_view_window_new):
 845         Use the same buttons as specified in the
 846         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 847         the existing widgets, which never had a chance of working.
 848         Put the ModestAccountView treeview in a scrolled window.
 849         Do not repeat the initialization in both _init() and _new().
 850
 851         * src/widgets/modest-account-view.c: (update_account_view):
 852         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 853         this widget and window shows no accounts.
 854
 855         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 856
 857 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 858
 859         * src/maemo/easysetup/modest-easysetup-wizard.c:
 860         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 861         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 862         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 863         which seems wrong.
 864
 865         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 866         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 867         accounts exist yet, as in the UI spec.
 868
 869         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 870
 871 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 872
 873         * src/maemo/Makefile.am:
 874         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 875         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 876         New window for editing connection-specific smtp details.
 877         Not fully implemented.
 878
 879         * src/maemo/modest-connection-specific-smtp-window.c:
 880         (modest_connection_specific_smtp_window_finalize) :
 881         unref the tree model.
 882         (on_button_edit): Show the edit window.
 883
 884 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 885
 886         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 887         error for me.
 888
 889         * src/maemo/Makefile.am:
 890         * src/maemo/modest-connection-specific-smtp-window.c:
 891         * src/maemo/modest-connection-specific-smtp-window.h:
 892         New window for showing the list of connections, for connection-specific
 893         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 894         * src/maemo/easysetup/modest-easysetup-wizard.c:
 895         (create_page_custom_outgoing): Show the new window when the button is clicked.
 896
 897 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 898
 899         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 900         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 901         * src/maemo/modest-msg-edit-window.c:
 902         (modest_msg_edit_window_insert_image):
 903         * src/modest-conf.c: (modest_conf_key_escape):
 904         * src/modest-mail-operation.c:
 905         (modest_mail_operation_send_new_mail):
 906         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 907         (modest_ui_actions_on_new_account):
 908         * src/widgets/modest-attachment-view.c: (update_filename_request):
 909         * src/widgets/modest-mail-header-view.c:
 910         Corrected warnings that were breaking the build, by commenting out unused variables,
 911         and a function, and by including a header.
 912
 913 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 914
 915         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 916         so we can #ifdef around platform-specific code when necessary.
 917         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 918         to allow this to build for the GNOME platform too.
 919
 920 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 921
 922         * src/maemo/easysetup/modest-easysetup-wizard.c:
 923         Added util_increment_name() and used it in create_page_account_details()
 924         to make sure that the default account name is always a new name.
 925
 926         (modest_easysetup_wizard_dialog_init),
 927         (set_default_custom_servernames): Some minor memory management fixes.
 928
 929 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 930
 931         * Makefile.am:
 932         * configure.ac:
 933         * src/modest-runtime.c: (init_i18n): Restored the translation
 934         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 935         are defined in config.h, and the translations are installed.
 936
 937         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 938         is defined for translation.
 939
 940 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 941
 942         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 943         (load_from_file):
 944         * src/maemo/easysetup/modest-easysetup-wizard.c:
 945         (modest_easysetup_wizard_dialog_init):
 946         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 947         Use realistic paths (though they should use $prefix generically) to the
 948         mcc_mapping and provider-data.keyfile files which might work when they
 949         are installed by the future version of the operator-wizard package,
 950         and then fallback to paths in our source code, with an explanatory
 951         warning.
 952
 953 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 954
 955         * configure.ac:
 956         * src/Makefile.am:
 957         * src/maemo/Makefile.am:
 958         * src/maemo/easysetup/: Added files from the previously-exernal
 959         osso-modest-easysetup.
 960         * src/maemo/modest-main-window-ui.h:
 961         * src/modest-ui-actions.c:
 962         * src/modest-ui-actions.h:
 963         Added modest_ui_actions_on_new_account() as a signal handler for the
 964         New Account menu item. It shows the easysetup wizard.
 965         * po/en_GB.po: Added additional needed logical IDs and translations.
 966
 967 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 968 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 969