1 2007-07-03 Murray Cumming <murrayc@murrayc.com>
3 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
4 be found by their display name. This is never useful.
5 * src/modest-tny-account-store.c: (on_account_removed): Find the account
6 by its ID, instead of trying to use its ID as its display name.
8 * src/modest-tny-account-store.h:
9 * src/modest-tny-account.c:
10 (modest_tny_account_get_special_folder): Add a g_warning() when
11 tny_folder_store_get_folders() returns an empty list for the maildir.
13 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
14 Add a g_warning() when this returns NULL, because that it not allowed
17 2007-07-02 Armin Burgmeier <armin@openismus.com>
19 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
20 note when trying to cancel the wizard. This fixes projects.maemo.org
23 2007-07-02 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-tny-account.h:
26 * src/modest-tny-account.c:
27 (modest_tny_account_new_from_server_account),
28 (modest_tny_account_new_from_server_account_name),
29 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
30 because this must now be set before setting the proto. This is usd in
31 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
32 warning in camel_session_get_service() caused by
33 tny_camel_transport_account_prepare().
35 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
38 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
40 * src/maemo/modest-connection-specific-smtp-edit-window.c:
42 (modest_connection_specific_smtp_edit_window_init):
44 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
47 2007-06-29 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-tny-account.c:
50 (modest_tny_account_new_from_server_account):
51 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
52 now uses to request a connection when it needs one, and which it uses
53 to tell us that something is wrong with the connection, so we can force
54 the accounts offline to prevent further problems.
57 * src/modest-init.c: (init_default_settings):
58 * src/modest-mail-operation.c:
59 (modest_mail_operation_update_account):
60 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
61 This should not be necessary anymore. Do not set the conf key that
62 determined this (it was always TRUE and not set anywhere else).
64 * src/modest-ui-actions.h: Remove unused and unimplemented
65 modest_ui_actions_on_online_toggle_toggled().
67 2007-06-29 Murray Cumming <murrayc@murrayc.com
69 * src/maemo/modest-main-window.c: (connect_signals):
70 Don't connect to delete_event twice. Maybe this was harmless.
72 2007-06-29 Murray Cumming <murrayc@murrayc.com
74 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
75 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
76 Debug output to give some more clue when a folder move is not allowed.
78 2007-06-28 Murray Cumming <murrayc@murrayc.com
80 * src/modest-tny-account.c: (on_modest_file_system_info),
81 (modest_tny_account_get_mmc_account_name):
82 Always call the callback, without checking whether the name has changed.
83 * src/widgets/modest-folder-view.c: (strings_are_equal),
84 (on_model_foreach_set_name), (on_get_mmc_account_name),
85 (text_cell_data): Compare the name here, and use the name from
86 the account rather than from the
87 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
88 if the name was changed after the account was added to the model.
89 That's a tinymail bug but not one that I want to fix now.
91 This finally fixes projects.maemo.org bug NB#59301.
93 2007-06-27 Armin Burgmeier <armin@openismus.com>
95 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
98 2007-06-27 Murray Cumming <murrayc@murrayc.com
100 * src/modest-tny-account.h:
101 * src/modest-tny-account.c:
102 Added modest_tny_account_get_mmc_account_name(), to set the memory
103 card name asynchronously for the given account and then notify.
104 (modest_tny_account_new_for_local_folders): Use this new function instead
105 of using hildon_file_system_info_async_new() directly.
107 * src/widgets/modest-folder-view.c: (text_cell_data):
108 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
109 gtk_tree_model_row_changed() when it is available.
111 This should fix projects.maemo.org bug NB#59301.
113 2007-06-27 Murray Cumming <murrayc@murrayc.com
115 * src/modest-mail-operation.c: (update_account_thread),
116 (get_msgs_full_thread): Fix typo failures in the revert
119 2007-06-27 Murray Cumming <murrayc@murrayc.com
121 * src/maemo/modest-maemo-global-settings-dialog.c:
122 (idle_select_default_focus):
123 * src/modest-mail-operation.c: (idle_notify_progress),
124 (idle_notify_progress_once), (set_last_updated_idle),
125 (update_account_thread), (get_msgs_full_thread):
126 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
127 * src/widgets/modest-header-view.c:
128 (idle_notify_headers_count_changed_destroy),
129 (idle_notify_headers_count_changed):
130 Reverted the additions of gdk_threads_enter/leave(), in case this
131 helps with a startup hang on the device.
133 2007-06-26 Armin Burgmeier <armin@openismus.com>
135 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
136 for supported secure authentication methods from server by
137 gtk_dialog_run(), saving CPU time and a potential race condition.
139 2007-06-26 Armin Burgmeier <armin@openismus.com>
141 * src/maemo/modest-maemo-utils.h:
142 * src/maemo/modest-maemo-utils.c: Added a
143 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
144 only error code to tell the calling code when the user canceled the
147 * src/maemo/modest-account-settings-dialog.h:
148 * src/maemo/modest-account-settings-dialog.c:
149 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
150 message if the retrieval of secure authentication methods was canceled
151 by the user. Perform the check before saving anything to configuration
152 to not end up with half-committed configuration changes, do not show
153 a "Saving to configuration failed" note when authentication methods
154 could not be retrieved.
156 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
159 2007-06-26 Murray Cumming <murrayc@murrayc.com>
161 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
162 Only return the first level of folders under accounts, because the
163 osso-global-search UI spec doesn't want the rest.
164 This fixed projects.maemo.org bug NB#61811.
166 2007-06-26 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-tny-account-store.c:
169 * src/modest-tny-account-store.h:
170 Added modest_tny_account_is_memory_card_account().
171 * src/maemo/modest-main-window.c: (create_details_widget):
172 Show the same information items for the memory card as we show for the
173 local-folders, to fix projects.maemo.org bug NB#59307.
175 2007-06-26 Murray Cumming <murrayc@murrayc.com>
177 * src/modest-tny-account-store.c: (get_password):
178 Added some checks for NULL to maybe prevent crashes, though I think
179 it was Philip's last commit that actually prevented the crash here
180 when creating a first new account.
181 But the new account is still not usable (no messages are shown)
182 until a restart of the application.
184 2007-06-26 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/modest-maemo-global-settings-dialog.c:
187 (idle_select_default_focus):
188 * src/modest-mail-operation.c: (idle_notify_progress),
189 (idle_notify_progress_once), (idle_notify_update_account_queue),
190 (set_last_updated_idle), (update_account_thread),
191 (notify_get_msgs_full), (get_msgs_full_destroyer),
192 (get_msgs_full_thread):
193 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
194 * src/widgets/modest-header-view.c:
195 (idle_notify_headers_count_changed_destroy),
196 (idle_notify_headers_count_changed):
197 Use gdk_threads_enter() and gdk_threads_enter_leave() in
198 all idle handlers, because some other thread could be blocking
199 the GDK lock, so that it can do GUI stuff.
201 2007-06-26 Murray Cumming <murrayc@murrayc.com>
203 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
204 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
205 (on_idle_send_receive), (on_idle_open_default_inbox):
206 * src/maemo/modest-msg-edit-window.c:
207 (modest_msg_edit_window_attach_file_noninteractive):
208 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
209 to prevent a hang. I don't quite understand why these are necessary,
210 beause we should already be in the main loop. I guess something outside
211 of the main loop is taking the lock.
213 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
214 we are really using URIs, and use files that are more likely to exist.
216 2007-06-26 Murray Cumming <murrayc@murrayc.com>
218 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
219 necessary because configure.ac now defines different variables.
221 2007-06-26 Murray Cumming <murrayc@murrayc.com>
223 * libmodest-dbus-client/libmodest-dbus-client.c:
224 * libmodest-dbus-client/libmodest-dbus-client.h:
225 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
226 libmodest_dbus_client_compose_mail() is what things actually use.
228 * src/dbus_api/modest-dbus-api.h:
229 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
230 * tests/dbus_api/Makefile.am:
231 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
234 2007-06-26 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-init.c: (modest_init_local_folders):
237 For memory-card (or other non local-folders) maildir accounts,
238 always create an Archive folder, so that there is somewhere to put
239 messages. This should be less confusing, because the user does not need
240 to guess that the need to create a folder.
242 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
244 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
245 Fixed icon size by using (50, 50) which is the same as defined by
248 2007-06-25 Armin Burgmeier <armin@openismus.com>
250 * src/widgets/modest-window-mgr.c:
252 * configure.ac: Correctly recognize hildon-notify presence and fixed
253 the build without it being installed.
255 2007-06-25 Murray Cumming <murrayc@murrayc.com>
257 * libmodest-dbus-client/libmodest-dbus-client.c:
258 (libmodest_dbus_client_search): Fix the build. Sorry.
259 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
260 (reply_forward_cb): Initialize variables to fix the build.
262 * src/modest-tny-account-store.c:
263 (modest_tny_account_store_get_tny_account_by): Fix the account URI
264 comparison (a silly typo) so that email search results can be opened
265 when there are more than one account.
267 2007-06-25 Murray Cumming <murrayc@murrayc.com>
269 * libmodest-dbus-client/libmodest-dbus-client.c:
270 (libmodest_dbus_client_search),
271 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
272 instead of 1 second, because the search gets folders and messages from
273 the server, which can take a long time. When it times out,
274 osso-global-search will report no results.
276 We need to specify whether we should search only cached information
277 (maybe with a user preference), and the osso-email-search-plugin
278 API should really be improved to allow that option, and to allow results
279 to be delivered asynchronously in batches.
281 2007-06-25 Murray Cumming <murrayc@murrayc.com>
283 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
284 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
285 GTK_ICON_SIZE_DIALOG is probably the wrong size.
287 2007-06-25 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
290 that is an empty string. D-Bus seems to give us these instead of NULL.
292 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
294 * src/dbus_api/modest-dbus-callbacks.c:
295 * src/maemo/easysetup/modest-easysetup-wizard.h:
296 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
298 (modest_connection_specific_smtp_edit_window_init):
299 * src/maemo/modest-maemo-global-settings-dialog.c:
301 * src/maemo/modest-maemo-utils.c:
302 (modest_maemo_utils_setup_images_filechooser):
303 * src/maemo/modest-main-window.c: (create_details_widget):
304 * src/maemo/modest-msg-edit-window.c:
305 (modest_msg_edit_window_attach_file_noninteractive),
306 (modest_msg_edit_window_color_button_change),
307 (modest_msg_edit_window_set_zoom):
308 * src/modest-mail-operation.c: (update_account_thread):
309 * src/modest-tny-account-store.c:
310 * src/modest-tny-account.c:
311 * src/widgets/modest-global-settings-dialog.c:
312 * src/widgets/modest-window.h:
316 2007-06-25 Murray Cumming <murrayc@murrayc.com>
318 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
319 * src/modest-search.c: (modest_search_folder),
320 (modest_search_all_accounts): Actually search only in the specified folder,
321 doing a simple match on the folder ID.
322 * src/modest-search.h: Added a folder field to the ModestSearch struct,
323 and added some documentation.
325 2007-06-22 Armin Burgmeier <armin@openismus.com>
327 * src/maemo/modest-maemo-utils.h:
328 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
329 modest_maemo_utils_get_supported_secure_authentication_methods.
331 * src/maemo/easysetup/modest-easysetup-wizard.c:
332 * src/maemo/modest-account-settings-dialog.c: Show correct error if
333 one occured, not just "Server does not support secure authentication".
335 2007-06-22 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-tny-account-store.c: (get_password):
338 Restored the call to tny_account_set_user() because Philip seems to have
339 stopped this from crashing (by not using the freed string). It still does
340 not work, but now we can test it.
342 2007-06-22 Murray Cumming <murrayc@murrayc.com>
344 * src/maemo/modest-msg-edit-window.c: (init_window):
345 Comment out use of an uninitialzed GtkScrolledWindow variable,
346 to fix the build and stop a crash. Yet again.
348 2007-06-22 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-tny-account-store.c: (get_password):
351 Remove the call to tny_account_set_user() because this actually crashes.
352 As mentioned in the last commit, it is known to not work anyway.
354 2007-06-22 Murray Cumming <murrayc@murrayc.com>
356 * src/modest-tny-account-store.c: (get_password):
357 Use tny_account_set_username() to tell tinymail that the username might
358 have changed too. But tinymail ignores this: see projects.maemo.org
360 * src/modest-ui-actions.c:
361 (modest_ui_actions_on_password_requested): Remove the useless attempt to
362 reset the connection when changing the username, and improve the comments.
363 Save the changed username to gconf at least, so it is used when Modest is
366 2007-06-21 Murray Cumming <murrayc@murrayc.com>
368 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
369 Do not use a query, so that we get all folders, including for POP and
370 local-folders. They work as search criteria too.
371 This fixes projects.maemo.org bug NB#57740.
373 2007-06-21 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
376 Comment out the use of hildon_notification_set_sound() because it is
377 not declared, to fix the build. Warnings are serious, people.
379 2007-06-21 Armin Burgmeier <armin@openismus.com>
381 * src/maemo/modest-maemo-utils.h:
382 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
383 modest_maemo_utils_get_supported_secure_authentication_methods()
384 to query authentication methods for a specific user. This should fix
385 projects.maemo.org bug NB#61369.
387 * src/maemo/easysetup/modest-easysetup-wizard.c:
388 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
391 2007-06-21 Murray Cumming <murrayc@murrayc.com>
393 * libmodest-dbus-client/libmodest-dbus-client.h:
394 * libmodest-dbus-client/libmodest-dbus-client.c:
395 (modest_dbus_message_iter_get_search_hit),
396 (libmodest_dbus_client_search):
397 Reorganised and commented this.
398 Removed modest_search_hit_free() from the public API because it
401 Added libmodest_dbus_client_get_folders() and
402 modest_folder_result_list_free().
404 * src/dbus_api/modest-dbus-api.h:
405 * src/dbus_api/modest-dbus-callbacks.c:
406 (modest_dbus_req_filter): Commented. Moved most code to
407 on_dbus_method_search() and added on_dbus_method_get_folders().
409 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
410 of the extra D-Bus handler.
412 * tests/dbus_api/Makefile.am:
413 * tests/dbus_api/test_get_folders.c: New test for
414 libmodest_dbus_client_get_folders(). This seems to return an empty list
415 at the moment. That could be the same error that causes the message list
416 to be empty sometimes.
417 This should help with projects.maemo.org bug NB#57740.
419 2007-06-21 Armin Burgmeier <armin@openismus.com>
421 * src/modest-mail-operation.c: Do not call
422 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
423 notify the operation's end after having set the status to CANCELED for
424 the operation queue to listen on. This fixes a deadlock when there
425 were mail operations in the queue during its finalization.
427 * src/modest-singletons.c: Reordered uninitialization of the account
428 manager to happen after the mail operation queue was uninitialized
429 because the mail operation's in the queue might still try to access
430 the account manager (see modest_mail_operation_notify_end()). This
431 fixes a potential crash when terminating the application.
433 2007-06-21 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-search.c:
436 (search_mime_part_and_child_parts): Moved some code here so we
437 can search recursively in child folders.
438 (modest_search_folder): Search in the message as a mime part, instead
439 of just its child mime parts.
440 (read_chunk), (search_mime_part_ogs):
441 Check how many bytes were read, to prevent an endless loop.
442 Searching in message bodies now works. This finishes the fix for
443 projects.maemo.org bug NB#61007.
445 2007-06-20 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
448 Add a g_warning when the item is not a folder.
450 * src/modest-ui-dimming-rules.c:
451 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
452 when selected item is not a folder (for instance, an account), because
453 the UI spec only talks about folders.
454 I am not sure what the UI spec wants, so this might not totally fix
455 projects.maemo.org bug NB#60794.
457 2007-06-20 Murray Cumming <murrayc@murrayc.com>
459 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
460 (load_from_file): Sort the list. The unsorted list would be more noticeable
461 in non-English locales.
463 * src/maemo/modest-msg-edit-window.c:
464 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
465 warning and fix the build.
467 * src/maemo/modest-progress-bar-widget.c:
468 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
469 avoid a g_warning, and probably to avoid a crash.
471 2007-06-20 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-search.c: (modest_search_folder): Check for a GError
474 when calling tny_folder_get_headers(), to show that this is not the cause
477 2007-06-20 Murray Cumming <murrayc@murrayc.com>
479 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
480 Actually set the body query instead of the subject query.
482 * src/modest-search.c: (search_mime_part_ogs),
483 (search_mime_part_strcmp): Remove extra space from the text/* regex,
484 which would probably cause it to fail if we got this far.
486 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
487 to simplify the code.
488 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
489 be causing search-in-body to fail.
491 2007-06-20 Murray Cumming <murrayc@murrayc.com>
493 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
495 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
496 Better debug message when the folder cannot be found.
497 This should help with fixing projects.maemo.org bug #61287.
498 * src/modest-search.c: (add_hit): Do not leak the furl string.
500 2007-06-20 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-ui-actions.c:
503 (modest_ui_actions_on_folder_selection_changed):
504 Do not special-case TNY_MERGE_FOLDER here, because
505 modest_tny_folder_get_account() already does that. This fixes
506 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
507 shown when the Outbox was selected).
509 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
511 * libmodest-dbus-client/libmodest-dbus-client.c:
512 (_dbus_iter_get_string_or_null): Initialize the string variable in
513 case this helps with Dirk's crash.
515 2007-06-19 Murray Cumming <murrayc@murrayc.com>
517 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
518 though it is not implemented yet (this function is maybe not even used),
519 to avoid breaking ABI in future.
520 * libmodest-dbus-client/libmodest-dbus-client.c:
521 (get_attachments_string): Moved some code into this generic function.
522 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
523 sends email. It is maybe not used.
524 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
525 (on_send_mail): Use attachments.
527 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
528 * src/maemo/modest-msg-edit-window.c:
529 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
530 a filename before using it, to fix projects.maemo.org bug NB#58233.
532 2007-06-19 Murray Cumming <murrayc@murrayc.com>
534 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
535 Initialize the continue_download variable to fix the build, and probably
536 to fix randome behaviour.
538 2007-06-18 Armin Burgmeier <armin@openismus.com>
540 * src/modest-tny-send-queue.h:
541 * src/modest-tny-send-queue.c: Keep track of the status of messages in
542 the queue so we can later show it in the UI. Replaced
543 modest_tny_send_queue_msg_is_being_sent() by
544 modest_tny_send_queue_get_msg_status().
546 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
548 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
549 gpointer. This probably was not harmful, but just to be sure.
551 2007-06-18 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
554 Fix the build, but leave the function broken on Bora, because
555 hildon_uri_action_get_service() does not exist.
556 osso_uri_action_get_service() does not exist either, it seems.
558 2007-06-18 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-tny-account.c:
561 (modest_tny_account_new_from_server_account):
562 Uncommented the url debug output again, because it is useful for
563 debugging, as I said in the comment.
565 2007-06-18 Murray Cumming <murrayc@murrayc.com>
567 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
569 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
570 for Mameo Bora, to fix the build.
572 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
575 Fixed build with hildon < 0.99
577 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
578 Check if the selected account is busy instead of checking all accounts
580 * src/modest-account-mgr-priv.h:
581 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
582 (modest_account_mgr_init), (compare_account_name),
583 (modest_account_mgr_set_account_busy),
584 (modest_account_mgr_account_is_busy):
585 * src/modest-account-mgr.h:
586 Added busy information to the account manager. It possible to
587 set an account to busy or not busy now.
589 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
590 (modest_mail_operation_update_account),
591 (modest_mail_operation_notify_end):
592 Set the account to busy/not busy depending on the operation state.
594 * src/widgets/modest-account-view.c:
595 (modest_account_view_finalize), (get_last_updated_string),
596 (update_account_view), (on_account_busy_changed), (init_view):
597 Show string "Refreshing..." if the account is currently busy.
599 All this fixes projects.maemo.org bug NB#59711
601 2007-06-14 Armin Burgmeier <armin@openismus.com>
603 * src/widgets/modest-attachments-view.h:
604 * src/widgets/modest-attachments-view.c: Added
605 modest_attachments_view_has_attachments() and fixed coordinate
606 transformation in get_att_view_at_coords(). This fixes attachment
609 * src/widgets/modest-msg-view.c: Make use of
610 modest_attachments_view_has_attachments() to decide whether to show
611 attachments in the header.
613 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
615 * src/maemo/modest-connection-specific-smtp-edit-window.c:
616 (on_change), (on_combo_security_changed),
617 (modest_connection_specific_smtp_edit_window_init),
618 (modest_connection_specific_smtp_edit_window_set_connection),
619 (modest_connection_specific_smtp_edit_window_is_dirty):
620 * src/maemo/modest-connection-specific-smtp-edit-window.h:
621 * src/maemo/modest-connection-specific-smtp-window.c:
624 Show an comfirmation dialog for the smpt-edit-window if there are
625 unsaved changes and the user hits cancel.
626 (projects.maemo.org bug NB#60479)
628 2007-06-14 Armin Burgmeier <armin@openismus.com>
630 * src/maemo/easysetup/modest-easysetup-wizard.c:
631 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
632 address" info in banner instead of node, and select all the text as
633 per UI spec. This fixes projects.maemo.org bug NB#60550.
635 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
637 reviewed by: <delete if not using a buddy>
639 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
640 * src/modest-ui-actions.c: (folder_refreshed_cb):
642 2007-06-14 Murray Cumming <murrayc@murrayc.com>
644 * src/widgets/modest-folder-view.c: (filter_row):
645 Explictly filter out the per-account outbox accounts. I don't know why
646 these only sometimes show up, but now they should never show up in the UI.
647 This should fix projects.maemo.org bug NB#60160.
649 2007-06-14 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
652 when the toolbar does not exist yet.
653 * src/modest-widget-memory.c: (save_settings_header_view):
654 Added g_warnings() to help us to discover when we are trying to set
655 an empty columns list in gconf.
657 2007-06-14 Murray Cumming <murrayc@murrayc.com>
661 Added modest_init_get_default_header_view_column_ids().
663 * src/modest-widget-memory.c: (restore_settings_header_view):
664 Use the new function to get defaults, if the gconf key is empty,
665 instead of not creating any columns. This seems to fix the
666 empty right-hand pane problems.
668 * src/widgets/modest-header-view.h: Improved documentation.
670 2007-06-13 Murray Cumming <murrayc@murrayc.com>
672 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
673 Revert the use of the display name as the account name, because this
674 is generally wrong and would break the code that follows.
676 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
678 * src/maemo/easysetup/modest-easysetup-wizard.c:
679 (check_for_supported_auth_methods), (on_before_next),
682 More correct fix for projects.maemo.org bug NB# 58991
683 Do not longer accept AUTH_PASSWORD as secure method and choose
684 correct method when creating the account.
686 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
688 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
689 Fixed projects.maemo.org bug NB# 58991
691 2007-06-13 Murray Cumming <murrayc@murrayc.com>
693 * src/modest-init.c: (modest_init_init_core),
694 (modest_init_local_folders): Fixed compilation errors.
696 2007-06-13 Murray Cumming <murrayc@murrayc.com>
698 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
699 Remove unnecessary lib/include, though it is good in principle when needed.
701 * src/modest-init.c: (modest_init_one_local_folder),
702 (modest_init_local_folders):
703 * src/modest-init.h: Initialize the .modest library for memory cards,
704 instead of just doing nothing for them. This should allow us to create
705 folders there, fixing projects.maemo.org bug NB#59297.
707 2007-06-13 Murray Cumming <murrayc@murrayc.com>
709 * libmodest-dbus-client/libmodest-dbus-client.c:
710 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
711 (libmodest_dbus_client_compose_mail),
712 (libmodest_dbus_client_open_message),
713 (libmodest_dbus_client_send_and_receive),
714 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
716 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
717 (on_idle_open_message), (modest_dbus_req_handler),
718 (search_result_to_message), (modest_dbus_req_filter):
719 * src/modest-search.c: (add_hit), (modest_search_folder),
720 (modest_search_all_accounts): Improved debug messages.
722 * tests/dbus_api/test_open_message.c: (main): Improved comments.
724 * src/modest-tny-account-store.c:
725 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
728 2007-06-13 Murray Cumming <murrayc@murrayc.com>
731 2007-06-12 Murray Cumming <murrayc@murrayc.com>
733 * src/modest-tny-account-store.c: (get_server_accounts):
734 Call modest_tny_local_folders_account_add_merged_outbox_folders()
735 even when there are no accounts, so that the Outbox folder is always
736 visible. This fixes projects.maemo.org bug NB#60158.
738 2007-06-12 Murray Cumming <murrayc@murrayc.com>
740 * src/maemo/modest-main-window.c: (create_details_widget):
741 Use the mcen_va_never logical ID.
743 2007-06-12 Murray Cumming <murrayc@murrayc.com>
745 * src/dbus_api/modest-dbus-api.h:
746 * src/dbus_api/modest-dbus-callbacks.c:
747 (on_idle_open_default_inbox), (on_open_default_inbox),
748 (modest_dbus_req_handler):
749 Added a new OpenDefaultInbox method.
751 * libmodest-dbus-client/libmodest-dbus-client.h:
752 * libmodest-dbus-client/libmodest-dbus-client.c:
753 Added libmodest_dbus_client_open_default_inbox() to call the new
754 dbus method. This should be useful to projects.maemo.org bug NB#57214,
755 though it should maybe be used by a new osso-email-interface function.
757 * tests/dbus_api/Makefile.am:
758 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
761 2007-06-12 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
764 NULL, so that the signals get all the keys. This should not actually
765 change any behaviour because we currently update everything when anything
768 2007-06-12 Murray Cumming <murrayc@murrayc.com>
770 * src/widgets/modest-folder-view.c: (text_cell_data),
771 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
772 (find_inbox_iter): If tinymail tells us that the folder is
773 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
774 This causes the inbox to be selected at startup, fixing part of
775 projects.maemo.org bug NB#56305.
777 * src/modest-ui-dimming-rules.c:
778 (modest_ui_dimming_rules_on_tools_smtp_servers):
779 * src/modest-ui-dimming-rules.h: Added a callback function to dim
780 the SMTP servers menu item.
781 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
782 that the SMTP Servers menu item is dimmed when there are no accounts,
783 as a future version of the UI spec will require. This fixes
784 projects.maemo.org bug NB#56305.
786 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
788 * src/maemo/modest-maemo-utils.c:
789 (modest_maemo_utils_get_supported_secure_authentication_methods):
790 Added label to dialog instead of unreadable title
792 * src/maemo/modest-main-window.c: (sync_accounts_cb),
793 (modest_main_window_new):
794 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
797 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
798 * src/modest-account-mgr.h:
799 Added method to avoid code duplication
801 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
802 (modest_ui_actions_on_send_receive):
803 Use modest_account_mgr_has_accounts
805 2007-06-11 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/easysetup/modest-presets.c:
808 (modest_presets_get_info_server_security): Do not report secure auth
810 * src/modest-protocol-info.c: Use the defines for the gconf key names
811 for secure authentication. This was not working because we were writing
812 Password and reading password, and the check was case sensitive.
813 With this, gmail now works for receiving and sending when created via
816 2007-06-11 Murray Cumming <murrayc@murrayc.com>
818 * src/maemo/easysetup/modest-presets.c:
819 (modest_presets_get_info_server_security): Correct the key name for
820 SecureSmtp, because it seems to be case-sensitive.
821 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
822 Do not try to get the 0th notebook page if there are 0 pages, to
825 2007-06-11 Murray Cumming <murrayc@murrayc.com>
827 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
828 Prevent use of the new notification feature for now, because it currently
829 shows one dialog for each new email, which is annoying.
831 2007-06-11 Murray Cumming <murrayc@murrayc.com>
833 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
834 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
835 when no country was selected, so that we show the global ones.
836 * src/maemo/easysetup/modest-presets.c:
837 (modest_presets_get_providers): Return only the global providers, not
838 all providers when mmc=0 was requested.
840 2007-06-11 Murray Cumming <murrayc@murrayc.com>
842 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
843 (easysetup_provider_combo_box_fill): Remove debug code that showed the
844 provider ID in the combo.
846 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
847 Do not show the page numbers, because it would be confusing when we add
848 the 2 extra pages for the custom setup, when the user chooses the "Other"
849 provider. This fixes projects.maemo.org bug NB#59028
851 * src/modest-init.c: (modest_init_init_core),
852 (modest_init_local_folders):
854 * src/modest-tny-account.c:
855 (modest_tny_account_new_for_local_folders): Do not create default folders
856 for the memory card. This should fix projects.maemo.org bug NB#59328.
858 2007-06-11 Murray Cumming <murrayc@murrayc.com>
860 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
861 Free the changed_conf_keys string items. They are already freed in the
862 idle handler if that runs first.
864 2007-06-11 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-ui-actions.c:
867 (modest_ui_actions_on_password_requested): Check that the server name
868 is not NULL, because I just saw a password dialog with (null) as the
871 * src/modest-tny-folder.[h|c]: Added
872 modest_tny_folder_is_memory_card_folder().
873 * src/modest-ui-dimming-rules.c:
874 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
875 menu item for memory cards, as per the UI spec (section 7.4). This should
876 fix projects.maemo.org bug NB#59297.
878 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
880 * src/maemo/modest-main-window.c: (sync_accounts_cb):
881 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
882 is another problem with the code, see Murray's comment at line 772)
884 2007-06-08 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
887 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
888 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
889 (load_from_file), (easysetup_country_combo_box_init),
890 (easysetup_country_combo_box_get_active_country_ids),
891 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
892 instead of just one ID, to avoid duplicate country names in the UI.
894 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
895 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
896 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
897 a single ID, avoiding duplicate providers.
898 * src/maemo/easysetup/modest-easysetup-wizard.c:
899 (on_combo_account_country): Adapt to use a list.
901 2007-06-08 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
904 keys changed in the last X seconds.
906 * src/modest-account-mgr.h:
907 * src/modest-account-mgr.c: (on_timeout_notify_changes),
908 (on_key_change), (modest_account_mgr_class_init),
909 (modest_account_mgr_init), (modest_account_mgr_finalize):
910 As the keys are changed, save them in a GSList* and signal that GSList*
911 further every X seconds, to batch changes, to allow us to do just one
912 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
913 bug NB#56941 and other (UI-blocking) delays when changing account settings.
915 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
916 changed signal signature.
918 * src/modest-conf.c: (modest_conf_set_list),
919 (modest_conf_on_change): Reenable notification.
921 (modest_conf_maemo_fake_on_change): Comment out the hack that
922 notified immediately instead of asynchronously.
924 * src/widgets/modest-account-view.h:
925 * src/widgets/modest-account-view.c:
926 (update_account_view): Select the previously-selected account ID,
927 if possible. This fixes projects.maemo.org bug NB#56933.
929 (on_account_changed), (on_account_removed),
930 (modest_account_view_select_account):
932 Remove the block/unblock functions
933 because they were not useful.
935 * src/maemo/modest-account-view-window.c:
936 (on_delete_button_clicked), (on_edit_button_clicked),
937 (on_new_button_clicked): Remove the use of the non-working block/unblock.
939 2007-06-08 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
942 Improve the error dialog to show Incorrect Account Settings, which seems
943 clearer, and say that the internal error message (to be removed from the
944 dialog later) is often misleading.
945 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
947 * src/modest-tny-account.c:
948 (modest_tny_account_new_from_server_account): Uncomment the printf of the
949 URL because this is so useful for debugging on the device.
951 * src/widgets/modest-serversecurity-combo-box.c:
952 (modest_serversecurity_combo_box_fill): Correct a logical ID.
954 2007-06-08 Murray Cumming <murrayc@murrayc.com>
956 * src/modest-mail-operation.c:
957 (modest_mail_operation_send_new_mail):
958 Added a comment about a nasty but apparently harmless message. Details
959 added to the wiki g_warnings() page.
961 2007-06-08 Murray Cumming <murrayc@murrayc.com>
963 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
964 (modest_tny_send_queue_class_init):
965 Do not use the priv struct because it is empty, to avoid g_warnings
966 about a non-existant priv struct.
968 * src/modest-tny-account-store.c:
969 (modest_tny_account_store_get_server_account),
970 (modest_tny_account_store_get_transport_account_for_open_connection
971 ): Do not try to get transport server accounts for local folders,
972 because they don't have any. This avoids a g_warning().
974 * src/maemo/modest-main-window.c:
975 (modest_main_window_notify_send_receive_initied),
976 (on_configuration_key_changed):
977 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
979 * src/modest-mail-operation.c:
980 (modest_mail_operation_update_account):
981 * src/modest-tny-account-store.h:
982 * src/modest-tny-account.c:
983 (modest_tny_account_get_special_folder),
984 (modest_tny_account_new_for_local_folders),
985 (modest_tny_account_new_for_per_account_local_outbox_folder):
986 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
987 * src/modest-tny-local-folders-account.c:
988 (add_account_folders_to_merged_folder):
989 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
990 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
991 (modest_ui_actions_on_send):
992 * src/widgets/modest-folder-view.c: (update_model):
993 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
994 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
995 modest_tny_account_store_get_tny_account_by_account() to
996 modest_tny_account_store_get_server_account() to make the code clearer.
998 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1000 * src/dbus_api/modest-dbus-api.h:
1001 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1002 * src/maemo/modest-msg-edit-window.c:
1003 (modest_msg_edit_window_attach_file_noninteractive):
1004 added g_warning in case the file to be attached does not exist
1005 * tests/dbus_api/test_compose_mail.c: (main):
1006 removed obsolete comment, added generic files as test case
1008 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-tny-account-store.c: (get_server_accounts):
1011 Create the local folders account only once, not once for each outbox, and
1012 not only when there are some outboxes.
1014 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1016 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1017 code that is causing a crash at startup. Sergio says that he is fixing this.
1019 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1021 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1022 * src/maemo/modest-account-settings-dialog.c:
1023 (create_page_outgoing),
1024 (modest_account_settings_dialog_set_account_name),
1025 (save_configuration):
1026 - Fixed handling of the "Use secure authentication" toggle to comply with
1027 the ui specification. See also projects.maemo.org bug NB#58400
1029 - Restore the Secure connection setting combo correctly when loading
1032 * src/maemo/modest-maemo-utils.c:
1033 (on_camel_account_get_supported_secure_authentication),
1034 (modest_maemo_utils_get_supported_secure_authentication_methods):
1035 Fixed a crasher if operation is canceled
1037 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1038 (modest_protocol_info_auth_is_secure):
1039 * src/modest-protocol-info.h:
1041 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1042 the sense of the "Use secure authentication" toggle.
1044 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1046 * src/modest-tny-account-store.h:
1047 * src/modest-tny-account-store.c:
1048 Added modest_tny_account_store_get_local_folders_account().
1050 * src/modest-tny-folder.h:
1051 * src/modest-tny-folder.c:
1052 (modest_tny_folder_get_account):
1053 Added this replacement for tny_folder_get_account() which returns
1054 the local-folders account for TnyMergeFolders, to avoid the
1055 warning about the unimplemented get_account_func() vfunc().
1057 (modest_tny_folder_get_rules),
1058 * src/modest-ui-actions.c:
1059 (modest_ui_actions_on_folder_selection_changed):
1060 * src/modest-mail-operation.c:
1061 (modest_mail_operation_remove_folder),
1062 (modest_mail_operation_xfer_folder),
1063 (modest_mail_operation_rename_folder),
1064 (modest_mail_operation_get_msg),
1065 (modest_mail_operation_get_msgs_full),
1066 (modest_mail_operation_remove_msg),
1067 (modest_mail_operation_xfer_msgs),
1068 (modest_mail_operation_refresh_folder):
1069 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1071 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1074 (modest_server_account_set_security):
1075 * src/modest-defs.h: Add comments explaining that our
1076 UI spec means TLS when it says Normal, so these do not look like errors.
1078 * src/modest-tny-account.c:
1079 (modest_tny_account_new_from_server_account): Use the new tinymail
1080 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1081 for TLS. This should fix projects.maemo.org bug NB#58460.
1083 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1085 * src/maemo/easysetup/modest-easysetup-wizard.c:
1086 (create_account): Correct the position of the gconf sanity check warning.
1087 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1088 of using the g_idle_add() hack, because this does not seem to be necessary
1089 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1090 caused by something other than maemo's gconf.
1091 This fixes projects.maemo.org bug #59022.
1093 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-account-mgr-helpers.c:
1096 (modest_account_mgr_get_default_account): Do not check that the account
1097 exists if there is no default account (NULL), to fix a runtime warning.
1099 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1101 * src/widgets/modest-folder-view.c: (update_model):
1102 Do not unref the treemodel before we have finished with it.
1103 This prevents a valgrind warning and an occasional crash at startup.
1105 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1107 * libmodest-dbus-client/libmodest-dbus-client.h:
1108 added libmodest_dbus_client_compose_mail()
1109 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1111 added functions needed for SendAsMail() functionality
1112 * src/maemo/modest-msg-edit-window.c:
1113 (modest_msg_edit_window_attach_file_noninteractive):
1114 non interactively attaching files to message edit window
1115 * src/widgets/modest-msg-edit-window.h:
1116 * tests/dbus_api/Makefile.am:
1117 added test_compose_mail.c
1118 * tests/dbus_api/test_compose_mail.c: (main):
1120 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1122 * src/modest-account-view.c:
1123 Fixed bug projects.maemo.org bug NB#59307
1125 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1127 * src/maemo/easysetup/modest-easysetup-wizard.c:
1128 (get_serverport_incoming), (on_before_next), (create_account):
1129 * src/maemo/modest-account-settings-dialog.c:
1130 (modest_account_settings_dialog_set_account_name):
1131 * src/maemo/modest-maemo-utils.c:
1132 (on_camel_account_get_supported_secure_authentication_status),
1133 (on_camel_account_get_supported_secure_authentication),
1134 (on_secure_auth_cancel),
1135 (modest_maemo_utils_get_supported_secure_authentication_methods):
1137 Implemented security authentication for settings and easysetup.
1139 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/modest-main-window.c: (create_details_widget):
1142 Show the total size for memory card accounts too, instead of showing
1143 the name again. Fixes bug projects.maemo.org bug NB#59307.
1145 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-tny-simple-folder-store.c:
1149 * src/modest-tny-simple-folder-store.h: Removed.
1151 * src/modest-tny-local-folders-account.h
1152 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1153 for the local-folders maildir, with an extra TnyMergedFolder containing
1154 the folders of the per-account outbox store accounts.
1155 * src/modest-tny-account-store.c: (get_server_accounts):
1156 Add the outboxes to the special local folders account after creating it.
1158 * src/modest-tny-account.c:
1159 (modest_tny_account_new_for_local_folders): Create the derived
1160 account when creating the main local-folders account.
1162 * src/maemo/modest-main-window.c: (create_details_widget),
1163 (modest_main_window_set_contents_style):
1164 Adapted to the use of the derived account instead of the folder store.
1166 * src/modest-ui-actions.c:
1167 (modest_ui_actions_on_folder_selection_changed):
1168 * src/modest-ui-dimming-rules.c:
1169 (modest_ui_dimming_rules_on_new_folder):
1170 * src/widgets/modest-folder-view.c: (text_cell_data),
1171 (icon_cell_data), (filter_row), (update_model),
1172 (get_cmp_rows_type_pos):
1175 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1176 Do not get the priv struct, because no priv struct has been set,
1177 to avoid a runtime warning.
1179 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1180 #ifelse with #else, to fix a warning, to fix the build.
1183 2007-06-05 Christian Kellner <ckellner@openismus.com>
1185 * libmodest-dbus-client/libmodest-dbus-client.c:
1186 Fix small typo in doc (why do you always see them
1187 AFTER committing stuff?)
1190 2007-06-05 Christian Kellner <ckellner@openismus.com>
1192 * libmodest-dbus-client/libmodest-dbus-client.c:
1193 (libmodest_dbus_client_search):
1194 Initialize hit list with NULL. Also set folder list
1195 to "" if NULL was supplied.
1198 2007-06-03 Christian Kellner <ckellner@openismus.com>
1200 * libmodest-dbus-client/libmodest-dbus-client.c:
1201 (modest_search_hit_list_free):
1202 Make it save to call it with NULL.
1204 * src/dbus_api/modest-dbus-callbacks.c:
1205 * src/modest-search.c:
1206 Return full ModestSearchHits as the search result list not TnyHeader
1207 since can't be around withouth the correspoding TnyFolder.
1209 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1211 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1212 Added currently commented code to check for secure auth
1214 * src/maemo/modest-account-settings-dialog.c: (on_response),
1215 (save_configuration), (show_ok):
1216 Fixed projects.maemo.org bugs NB #59248 and #59251
1218 * src/maemo/modest-maemo-utils.c:
1219 (on_camel_account_get_supported_secure_authentication_status),
1220 (on_camel_account_get_supported_secure_authentication),
1221 (modest_maemo_utils_get_supported_secure_authentication_methods):
1222 * src/maemo/modest-maemo-utils.h:
1223 Moved get_supported_secure_authentication() method here to be able
1224 to use it from easysetup wizard.
1226 * src/modest-pair.c: (on_pair_compare_as_string):
1227 Should compare string with first part of pair and not
1228 strcmp pairs which will crash.
1230 * src/modest-protocol-info.c:
1231 (modest_protocol_info_protocol_is_store):
1232 * src/modest-protocol-info.h:
1233 Added modest_protocol_info_get_auth_protocol_name()
1235 2007-06-03 Armin Burgmeier <armin@openismus.com>
1237 * src/modest-mail-operation.c:
1238 (modest_mail_operation_get_msgs_full): Set priv->account also when
1239 only retrieving a single message. This avoids a crash when canceling
1242 (modest_mail_operation_notify_end): Do not explicitely remove the
1243 operation from the queue but only emit the progress_changed signal.
1244 The queue itself listens to that signal to remove the operation when
1245 it is finished. This reduces coupling and removes a potential deadlock
1246 when modest_mail_operation_notify_end() is called from the queue
1247 itself. If that is a problem performance-wise, I would suggest to
1248 implement a status-changed signal or something.
1250 * src/modest-mail-operation-queue.c: Make sure to never call a
1251 function from another file while the queue is locked. This (hopefully)
1252 fixes another deadlock when exiting the application while retrieving
1255 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1257 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1258 Fixed build if libogs is not available
1260 2007-06-03 Christian Kellner <ckellner@openismus.com>
1262 * libmodest-dbus-client/libmodest-dbus-client.h:
1263 * libmodest-dbus-client/libmodest-dbus-client.c:
1264 (libmodest_dbus_client_delete_message):
1265 Implement deletion of messages (Client side).
1267 (modest_search_hit_free),
1268 (modest_search_hit_list_free):
1269 Utility functions to free the result hits.
1271 * src/dbus_api/modest-dbus-api.h:
1272 * src/dbus_api/modest-dbus-callbacks.c:
1273 (on_delete_message),
1274 (modest_dbus_req_handler):
1275 Implement deletion of messages (Server side).
1277 * tests/dbus_api/test_search.c: (main):
1280 * tests/dbus_api/Makefile.am:
1281 * tests/dbus_api/test_delete_message:
1282 Add little test for the message deletion logic
1284 2007-06-03 Armin Burgmeier <armin@openismus.com>
1286 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1287 when the operation queue was not empty. projects.maemo.org bug
1290 2007-06-03 Armin Burgmeier <armin@openismus.com>
1292 * src/widgets/modest-account-view.c
1293 (on_account_default_toggled): Toggle default account column
1294 explicitely instead of waiting for gconf notification (which is
1295 currently ignored). This should fix projects.maemo.org bug NB#56910
1296 for now. It should probably be removed when gconf notifications are
1299 2007-06-03 Christian Kellner <ckellner@openismus.com>
1301 * libmodest-dbus-client/libmodest-dbus-client.c:
1302 Removed debugging spew.
1304 * src/dbus_api/modest-dbus-callbacks.c:
1305 Added debugging info.
1307 * src/modest-search.c:
1308 (modest_search_all_accounts):
1309 Use tny_account_store_get_accounts () on the account store
1310 to get all accounts which is the way to get all accounts.
1312 * tests/dbus_api/test_search.c: (main):
1313 Make it possible to supply the search term on the command line.
1315 2007-06-03 Christian Kellner <ckellner@openismus.com>
1317 * libmodest-dbus-client/libmodest-dbus-client.c:
1318 * libmodest-dbus-client/libmodest-dbus-client.h:
1319 Implement searching for mesages over raw dbus. (Client side)
1321 * src/dbus_api/Makefile.am:
1322 * src/dbus_api/modest-dbus-api.h:
1323 * src/dbus_api/modest-dbus-callbacks.c:
1324 * src/dbus_api/modest-dbus-callbacks.h:
1325 Search framework (Server side). Also implement on_idle_open_message().
1327 * src/maemo/modest-platform.c: (modest_platform_init):
1328 Prepare for raw dbus/osso rpc interaction.
1330 * src/modest-search.h:
1331 Changed minsize from unspecific guint to guint32.
1333 * src/modest-search.c:
1335 Added strange hack which magically made tnymail work.
1337 (modest_search_folder),
1338 (modest_search_account),
1339 (modest_search_all_accounts):
1340 Implement helper functions to search all accounts, specific account
1343 * tests/dbus_api/Makefile.am:
1344 * tests/dbus_api/test_open_message.c:
1345 Read url to open from commandline.
1347 * tests/dbus_api/test_search.c:
1348 Implement small test for dbus search stuff
1350 2007-06-02 Armin Burgmeier <armin@openismus.com>
1352 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1353 include account type and account title. This fixes projects.maemo.org
1356 * src/maemo/modest-account-view-window.c: Set a title for the window.
1358 2007-06-02 Armin Burgmeier <armin@openismus.com>
1360 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1361 incoming and outgoing server name based on email address and server
1362 types as long as the names have not been edited manually. This fixes
1363 projects.maemo.org bug NB#58671.
1365 2007-06-02 Armin Burgmeier <armin@openismus.com>
1367 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1368 server type cannot be changed in future to the incoming details page
1369 when creating an account. This fixes projects.maemo.org bug NB#59029.
1371 2007-06-02 Armin Burgmeier <armin@openismus.com>
1373 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1374 and assigned max width chars so that they wrap instead of being
1375 truncated. Fixes projects.maemo.org bug NB#56126.
1377 2007-06-02 Armin Burgmeier <armin@openismus.com>
1379 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1380 introductory note to the connection specific smtp servers dialog, as
1381 section 8.12 of the email UI specification requires. This fixes
1382 projects.maemo.org bug NB#59212.
1384 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1386 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1387 Check for running mail operations, and offer to cancel them, as per the UI
1388 spec. This fixes projects.maemo.org bug NB#59041 .
1389 However, I suspect that tinymail may still use the network connection
1390 in ways that we cannot detect or cancel. But it should at least adapt to
1391 changes fairly well.
1393 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account-store.c: (recreate_all_accounts),
1396 (get_cached_accounts), (get_server_accounts): Do more sensible
1397 ref-counting of the temporarily-cached outbox accounts list. This seems
1398 to fix a crash when entering the password when the password was wrong.
1400 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1402 * src/gnome/modest-main-window.c: (connect_signals):
1403 * src/modest-tny-account-store.c: (get_password),
1404 (modest_tny_account_store_alert): Added comments and clues and
1405 commented-out code about how we currently fail to deal with connection
1406 errors and wrong passwords, and how we should.
1408 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1410 * src/widgets/modest-retrieve-combo-box.c:
1411 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1412 This fixes projects.maemo.org bug NB#58472 .
1414 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1416 * src/maemo/easysetup/modest-easysetup-wizard.c:
1417 (create_page_complete_easysetup):
1418 (create_page_complete_custom): Correct the last commit,
1419 putting the correct sentences in the correct pages.
1421 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1423 * src/maemo/easysetup/modest-easysetup-wizard.c:
1424 (create_page_complete_custom): Show the second sentence of text
1425 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1428 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1430 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1431 Set the leave-on-server conf key by default. This fixes
1432 projects.maemo.org bug NB#59258 .
1434 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/modest-account-view-window.c:
1437 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1438 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1441 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/easysetup/modest-easysetup-wizard.c:
1444 (create_caption_new_with_asterisk):
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (create_caption_new_with_asterisk):
1447 Uncomment the code to add the asterisk, because they are no longer in the
1448 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1449 (update_incoming_server_title): Add an asterisk here too.
1451 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1453 * src/maemo/modest-maemo-global-settings-dialog.c:
1454 (current_connection): Check that we are even connected before trying to
1455 get the current connection name, to prevent a warning.
1457 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1458 Change the comments because tny_maemo_conic_device_connect() is now meant to
1460 * src/modest-mail-operation.c:
1461 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1462 make sure we have a connection and fail if we can't connect.
1464 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/modest-main-window.c:
1467 (on_account_store_connecting_finished): Do not try to get the
1468 connection ID if we are not really connected. I am surprised that
1469 this signal handler is called when we are not connected.
1471 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-error.h:
1474 * src/modest-ui-actions.c:
1475 (modest_ui_actions_get_msgs_full_error_handler):
1476 Renamed an enum, added comments, added an enum
1477 for retrieve-limit errors.
1479 * src/modest-mail-operation.c: (foreach_add_item),
1480 (internal_folder_observer_update), (update_account_thread),
1481 (modest_mail_operation_get_msgs_full):
1482 (modest_mail_operation_update_account),
1483 Added comments about how this works, and some code that should
1484 (but does not) check the retrieve-limit. See the TODO comment.
1486 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1489 Initialize help_id to fix the build. Warnings are good.
1491 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1493 * src/widgets/modest-hbox-cell-renderer.c:
1494 (modest_hbox_cell_renderer_append):
1495 * src/widgets/modest-vbox-cell-renderer.c:
1496 (modest_vbox_cell_renderer_append):
1497 Fix the last commit by doing an extra ref.
1499 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1501 * src/widgets/modest-hbox-cell-renderer.c:
1502 (modest_hbox_cell_renderer_append):
1503 * src/widgets/modest-vbox-cell-renderer.c:
1504 (modest_vbox_cell_renderer_append):
1505 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1506 to fix the build with Maemo Bora.
1507 However, there seems to be a remaining crash, probably due to reference
1510 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-tny-account.c:
1513 (modest_tny_account_new_for_local_folders):
1514 Use hildon_file_system_info_async_new() to get a better name for
1515 the memory card account, setting it as the account name.
1516 The timing seems to work, but this is probably
1517 not the best place to do this. See the TODO comment.
1518 * src/maemo/modest-main-window.c: (create_details_widget):
1519 * src/widgets/modest-folder-view.c: (text_cell_data):
1520 Use the tny account name instead of hardcoding a name.
1522 2007-05-30 Christian Kellner <ckellner@openismus.com>
1524 * src/modest-search.c: (modest_search):
1525 Correctly set part_search_func even if we have already parsed
1526 the query and thus a valid OgsTextSearcher object.
1528 2007-05-30 Christian Kellner <ckellner@openismus.com>
1531 Search and check for libogs.
1534 Incooparte the ogs build env.
1536 * src/modest-mime-part-search-stream.c:
1537 * src/modest-mime-part-search-stream.h:
1538 Removed since we do the real searching now in modest-search.c.
1540 * src/modest-search.c:
1541 * src/modest-search.h:
1542 Implement support for ogs. We use that if available and requested
1543 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1544 should now handle the corner case when the search term is spread
1545 across multiple reads.
1546 Also the logic in modest_search () was corrected to search all
1547 requested fields until one is found.
1549 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1551 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1553 * src/modest-init.h:
1554 * src/modest-init.c: Made modest_init_local_folders() take a
1555 path and be public so we can iniitialize maildir folders on
1558 * src/modest-local-folder-info.h:
1559 * src/modest-local-folder-info.c:
1560 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1562 * src/modest-tny-account.c:
1563 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1564 still means the standard local-folders path on the local volume.
1566 * src/modest-tny-account-store.c:
1567 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1568 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1569 all accounts when that happens.
1570 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1571 this too, so it shows up in the treeview.
1573 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/modest-maemo-global-settings-dialog.c:
1576 (current_connection):
1577 * src/widgets/modest-global-settings-dialog.c:
1578 (current_connection_default):
1579 Use the enum values instead of 0, 1 and -1,
1580 to make the code clearer.
1582 * src/modest-account-mgr-helpers.c:
1583 (modest_account_mgr_get_connection_specific_smtp): Make this code
1586 * src/modest-runtime.h:
1587 * src/modest-runtime.c:
1588 Added modest_runtime_remove_all_send_queues().
1589 * src/maemo/modest-main-window.c:
1590 (on_account_store_connecting_finished): Recreate the send queues,
1591 using the appropriate transport accounts for this new connection.
1592 Some futher adapting might be needed if the old send queues are not
1593 automatically stopped at this point.
1595 * src/modest-tny-account-store.c: (get_server_accounts):
1596 Create the connection-specific transport accounts, so that they can
1597 be found later by their ID.
1599 * src/modest-tny-account.h:
1600 * src/modest-tny-account.c:
1601 Added modest_tny_account_new_from_server_account_name().
1602 modest_tny_account_new_from_server_account(): Do not create the
1603 send queues here, because they will be
1604 recreated anyway when the connection changes for the first time.
1606 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-local-folder-info.h:
1609 * src/modest-local-folder-info.c:
1610 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1611 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1612 tbox_folder): Take a modest account name instead of a server TnyAccount,
1613 so we can have per-modest-account rather than per-transport-account
1615 We must make sure that we change or recreate the exisitng send queues
1616 when the connection changes for connection-specific transport accounts.
1618 * src/modest-tny-account-store.c:
1619 (create_per_account_local_outbox_folders): Create outboxed per modest
1620 account, not per transport account.
1622 * src/modest-tny-account.h:
1623 * src/modest-tny-account.c:
1624 (modest_tny_account_get_special_folder): For outboxes, get the
1625 parent modest account name. The account is ignored for other folders.
1626 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1627 modest account name rather than a server TnyAccount.
1629 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-tny-account.c:
1632 (modest_tny_account_new_from_server_account):
1633 Call modest_runtime_get_send_queue() immediately after creating transport
1634 accounts, so that they start trying to send email from the outbox as soon
1635 as possible at startup. This is probably what we want.
1637 * src/modest-mail-operation.c: (update_account_thread):
1638 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1639 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1640 * src/modest-tny-send-queue.h:
1641 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1642 (modest_ui_actions_on_send):
1643 Added comments about how sending works, though it needs some more work.
1645 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-tny-account.c:
1648 (modest_tny_account_get_special_folder): Add TODO because this fails when
1649 the network is busy.
1650 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1651 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1652 Do not try to show this window when there is no active account. The UI
1653 specs does not tell us what to do in this case.
1655 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1659 * src/maemo/Makefile.am:
1660 * src/widgets/Makefile.am: Some dist fixes.
1662 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1664 * src/maemo/modest-connection-specific-smtp-window.c:
1665 (on_button_edit): Make the code clearer, to prevent a double free.
1667 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1669 * src/maemo/modest-account-settings-dialog.c:
1670 (modest_account_settings_dialog_set_account_name),
1671 Check the connection-specific smtp servers checkbox if there are any.
1673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1674 (modest_connection_specific_smtp_edit_window_init):
1675 Start with a suitable port number.
1677 * src/modest-account-mgr-helpers.h:
1678 * src/modest-account-mgr-helpers.c: Added
1679 modest_account_mgr_get_has_connection_specific_smtp().
1681 (modest_account_mgr_set_connection_specific_smtp),
1682 (modest_account_mgr_remove_connection_specific_smtp),
1683 (modest_account_mgr_get_has_connection_specific_smtp),
1684 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1685 connection-specific smtp server accounts in the account, rather than
1686 the server account conf dir.
1688 This fixes bug projects.maemo.org bug NB#58263 .
1690 * src/modest-tny-account-store.c:
1691 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1692 if there are no server accounts yet, to prevent an infinite loop when there
1693 are no accounts. Document that one must be called before the other.
1695 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1697 * src/modest-account-mgr-helpers.c:
1698 (modest_account_mgr_get_default_account): Make sure that at least
1699 one account is always the default, if there are any enabled accounts.
1700 This is just a sanity check that shouldn't be necessary.
1702 * src/modest-account-mgr-priv.c:
1703 (_modest_account_mgr_account_from_key): Unescape the conf key to
1704 get the real account name. For instance, this is an issue if a space
1705 was in the account name, which can happen because the account name
1706 is generated from the display name.
1707 (_modest_account_mgr_get_account_keyname): Always escape the
1709 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1710 Unescape the conf keys to get the real account names.
1712 For instance, previously the is-default radio button in the accounts
1713 list was not checked for any accounts at first. This fixes that,
1714 and might fix several similar bugs.
1716 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1719 Removed some debug printfs.
1721 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1723 Modest on-disk outbox directories are now here, for instance:
1724 $HOME/.modest/outboxes/<account-id-1>/outbox
1725 $HOME/.modest/outboxes/<account-id-2>/outbox
1727 $HOME/.modest/local-folders/outbox
1728 so we can have a separate outbox for each account.
1729 But they are shown as one outbox in the GtkTreeView, by using a
1730 TnyMergeFolder in a ModestTnySimpleFolderStore.
1733 * src/modest-tny-simple-folder-store.c:
1734 * src/modest-tny-simple-folder-store.h:
1735 Added ModestTnySimpleFolderStore, used to contain folders from
1736 other folder stores, such as other accounts.
1738 * src/modest-tny-outbox-account.h:
1739 * src/modest-tny-outbox-account.c:
1740 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1741 used for the per-account local outbox folders.
1743 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1744 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1745 only use this (internally) now for the non-outbox local folders.
1747 * src/modest-init.h:
1748 * src/modest-init.c: Added modest_init_one_local_folder(), for
1749 setting up the directory structure for each local folder.
1751 * src/modest-local-folder-info.c:
1752 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1753 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1755 * src/modest-local-folder-info.h:
1756 * src/modest-tny-account-store.c: (on_account_removed),
1757 (on_account_changed), (create_per_account_local_outbox_folders),
1758 (get_server_accounts), (modest_tny_account_store_get_accounts),
1759 (modest_tny_account_store_get_tny_account_by_account),
1760 (modest_tny_folder_store_is_virtual_local_folders):
1762 * src/modest-tny-account.h:
1763 * src/modest-tny-account.c:
1764 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1765 to create an on-disk per-account local outbox folder for each
1767 (create_per_account_local_outbox_folders): Create a local outbox folder
1768 for each transport account.
1769 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1770 for all local folders.
1772 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1773 instead of using g_object_get/set() directly. It is clearer.
1775 (modest_tny_folder_store_get_message_count),
1776 (modest_tny_folder_store_get_local_size
1777 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1778 because we now use these with non-acount folder stores.
1780 (modest_tny_account_get_special_folder),
1781 (modest_tny_account_new_from_server_account),
1782 (modest_tny_account_new_from_account):
1783 (recurse_folders): Adjust to the new outbox system.
1785 * src/modest-tny-folder.h:
1786 * src/modest-tny-folder.c:
1787 (modest_tny_folder_is_local_folder),
1788 (modest_tny_folder_get_local_folder_type),
1789 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1791 * src/widgets/modest-main-window.h:
1792 * src/maemo/modest-main-window.c: (create_details_widget),
1793 (modest_main_window_set_contents_style): Show details for any folder store,
1796 (modest_tny_folder_get_rules):
1797 Remove the const. C does not support constness enough for this.
1799 * src/modest-ui-actions.c:
1800 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1801 make all outboxes appear as one, in the usual local-folders tree node.
1803 (set_active_account_from_tny_account),
1804 (modest_ui_actions_on_folder_selection_changed):
1805 * src/widgets/modest-folder-view.c: (text_cell_data),
1806 (icon_cell_data), (filter_row),
1807 (add_account_folders_to_merged_folder),
1808 (add_account_folders_to_simple_folder_store), (),
1809 (get_cmp_rows_type_pos), (cmp_rows),
1810 (modest_folder_view_set_account_id_of_visible_server_account):
1811 Adjust to the new outbox system, using generic folder stores and folders
1812 in the GtkTreeModel.
1814 2007-05-23 Christian Kellner <ckellner@openismus.com>
1816 * src/modest-mail-operation.c:
1817 (modest_mail_operation_update_account):
1818 Use info->max_size instead of unintialized local var [small
1819 build fix]. (Added TODO to review that change since I don't
1822 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1824 * libmodest-dbus-client/libmodest-dbus-client.c:
1825 (libmodest_dbus_client_compose_mail): function added
1826 * src/dbus_api/modest-dbus-api.h:
1827 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1828 (on_compose_mail): Implementation of the SendAsMail functionality
1830 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-account-mgr.c:
1833 (modest_account_mgr_add_server_account): Set the secure-connection
1834 conf key for transport accounts as well as store accounts. I don't know
1835 why the if was there. For instance, this makes sure that we use SSL
1836 for the gmail preset from the easysetup wizard.
1838 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1840 * src/gnome/modest-main-window.c:
1841 (on_account_store_connecting_finished), (connect_signals):
1842 * src/maemo/modest-main-window.c:
1843 (on_account_store_connecting_finished), (connect_signals),
1844 (modest_main_window_new):
1845 Handle TnyAccountStore::connecting-finished instead of
1846 TnyDevice::connection-changed, because we cannot actually perform
1847 operations on accounts until TnyAccountStore has itself responded to
1848 the TnyDevice::connection-changed signal. This prevents a GError from
1850 Do not try to update at startup, because we (at least on scratchbox)
1851 already do an update at startup when the device goes online.
1852 This prevents a GError from tinymail.
1853 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1854 Added TODO about stopping simultaneous operations.
1856 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1859 * src/modest-mail-operation-queue.c:
1860 (modest_mail_operation_queue_remove):
1861 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1862 about where they happened.
1864 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1866 * src/modest-ui-actions.c:
1867 (modest_ui_actions_on_password_requested): Make sure that the remember
1868 output parameter is always TRUE.
1870 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1873 Show a OK/Cancel dialog if the error is a question, though we still do not
1874 know anything more about what we are asking the user.
1875 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1876 Fix an uninitialized variable (helper). This is a logic error, however.
1878 2007-05-21 Christian Kellner <ckellner@openismus.com>
1880 * src/modest-search.h:
1881 Correct bit shifting in the ModestSearchFlags enum.
1883 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1885 * src/modest-tny-account.c:
1886 (modest_tny_account_new_from_server_account): Do not use the lsub and
1887 check-all hard-coded IMAP options when using POP.
1889 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1891 * src/modest-tny-account.c:
1892 (modest_tny_account_new_from_server_account):
1893 Use NULL for the secure-auth method for POP when Password auth has been
1894 specified by the user, as we already do for IMAP. "auth=Login" causes
1895 an error from camel or the server.
1897 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/modest-account-settings-dialog.c:
1900 (create_page_account_details),
1901 (modest_account_settings_dialog_set_account_name):
1902 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1903 for the leave-on-server checkbox, rathr than just the checkbox, when
1904 the protocol is not POP.
1906 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1908 * src/widgets/modest-account-view.c:
1909 * src/widgets/modest-account-view.h:
1910 Added modest_account_view_select_account() which will be useful later
1911 to asynchronously re-select the edited account.
1913 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/modest-account-settings-dialog.c:
1916 (modest_account_settings_dialog_set_account_name):
1917 Automatically choose the port numbers based on the secure authentication
1918 methods, if they have not been chosen before.
1919 This fixes projects.maemo.org bug NB#56273 .
1921 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/modest-main-window-ui.h:
1924 * src/modest-ui-actions.c:
1925 * src/modest-ui-actions.h:
1926 Connect the Tools/SMTP Servers menu item to
1927 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1928 SMTP servers dialog, as in the UI specification and saves changes when it
1929 is closed. This fixed projects.maemo.org bug NB#56305 .
1931 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/modest-connection-specific-smtp-window.c:
1934 (modest_connection_specific_smtp_window_init):
1935 Use gtk_window_set_default_size() to make this window big enough, so
1936 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1938 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1940 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1941 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1942 (modest_connection_specific_smtp_edit_window_init),
1943 Do not try to connect to a combobox signal before the combobox exists.
1944 This fixes the cras in projects.maemo.org bug NB#56288 .
1945 (modest_connection_specific_smtp_edit_window_get_settings):
1946 Remove the server_account_name parameter which was being checked for NULL
1947 though it was not used.
1949 * src/maemo/modest-connection-specific-smtp-window.c:
1950 (modest_connection_specific_smtp_window_fill_with_connections),
1951 (on_button_edit), (modest_connection_specific_smtp_window_init):
1952 Correct the number of treemodel columns to prevent a warning.
1953 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1954 libconic does not work.
1956 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1958 * src/modest-tny-account.c:
1959 (modest_tny_account_new_from_server_account):
1960 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1961 SMTP when "None" was chosen by the user. However, with my SMTP server that
1962 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1965 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1968 to explain the memory management issue with the ID in the ModestPair.
1970 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1971 (add_sending_page), (modest_account_assistant_finalize):
1972 * src/gnome/modest-gnome-global-settings-dialog.c:
1973 (create_updating_page), (create_composing_page):
1974 * src/gnome/modest-msg-edit-window.c: (get_transports),
1975 (init_window), (modest_msg_edit_window_finalize),
1976 (modest_msg_edit_window_get_msg_data):
1977 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1978 * src/gnome/modest-transport-widget.c:
1979 (modest_transport_widget_finalize), (smtp_configuration):
1980 * src/maemo/modest-maemo-global-settings-dialog.c:
1981 (create_updating_page), (create_composing_page):
1982 * src/maemo/modest-msg-edit-window.c: (get_transports),
1983 (init_window), (modest_msg_edit_window_finalize),
1984 (modest_msg_edit_window_get_msg_data),
1985 (modest_msg_edit_window_free_msg_data):
1986 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1987 (modest_store_widget_finalize):
1988 * src/maemo/modest-transport-widget.c:
1989 (modest_transport_widget_finalize), (smtp_configuration):
1990 * src/modest-main.c: (send_mail):
1991 * src/widgets/modest-combo-box.h:
1992 * src/widgets/modest-global-settings-dialog-priv.h:
1993 * src/widgets/modest-global-settings-dialog.c:
1994 (modest_global_settings_dialog_finalize):
1995 * src/widgets/modest-msg-edit-window.h:
1996 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1997 as long as the combo box, to prevent use of freed memory for the ID.
1999 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2002 get_accounts(), to make this clearer. Do not check for the enabled gconf
2003 key, because we do not use this for server accounts (at least, not yet).
2004 This allows us to send email again.
2006 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-platform.c:
2009 (on_modest_conf_update_interval_changed), (modest_platform_init):
2010 Only respond to this particular key change. All these strcmp()s cannot be
2013 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/modest-maemo-global-settings-dialog.c:
2016 (current_connection): Prevent a crash in scratchbox when
2017 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2018 * src/maemo/modest-platform.c:
2019 (on_modest_conf_update_interval_changed), (modest_platform_init):
2020 Get the update interval from gconf and reset it when the gconf key changes.
2022 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2024 * src/modest-protocol-info.c:
2025 * src/modest-protocol-info.h: Adde enum-specific get functions,
2026 instead of using a ModestProtocolType enum parameter.
2028 * src/gnome/modest-account-assistant.c:
2029 * src/gnome/modest-store-widget.c:
2030 * src/gnome/modest-store-widget.h:
2031 * src/gnome/modest-transport-widget.c:
2032 * src/gnome/modest-transport-widget.h:
2033 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2034 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2035 * src/maemo/easysetup/modest-easysetup-wizard.c:
2036 * src/maemo/modest-account-settings-dialog.c:
2037 * src/maemo/modest-account-settings-dialog.h:
2038 * src/maemo/modest-store-widget.c:
2039 * src/maemo/modest-store-widget.h:
2040 * src/maemo/modest-transport-widget.c:
2041 * src/maemo/modest-transport-widget.h:
2042 * src/modest-account-mgr-helpers.c:
2043 * src/modest-account-mgr-helpers.h:
2044 * src/modest-account-mgr.c:
2045 * src/modest-account-mgr.h:
2046 * src/modest-tny-account.c:
2047 * src/modest-tny-folder.c:
2048 * src/widgets/modest-account-view.c:
2049 * src/widgets/modest-retrieve-combo-box.c:
2050 * src/widgets/modest-retrieve-combo-box.h:
2051 * src/widgets/modest-secureauth-combo-box.c:
2052 * src/widgets/modest-serversecurity-combo-box.c:
2053 * src/widgets/modest-serversecurity-combo-box.h:
2054 * tests/check_account-mgr.c:
2055 Use the specific functions, and use the re-renamed enum values for GNOME too.
2057 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-pair.h:
2060 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2061 so we can get the second based on the first.
2063 * src/maemo/modest-account-settings-dialog.h:
2064 * src/maemo/modest-account-settings-dialog.c:
2065 Added get_supported_secure_authentication_methods(), though it is mostly
2066 commented-out for now until the necessary API is committed to tinymail.
2067 (modest_account_settings_dialog_set_account_name),
2068 (save_configuration): Request the supported authentication methods from the
2069 server, so we can choose a working method.
2071 * src/modest-tny-account-store.h:
2072 * src/modest-tny-account-store.c:
2073 (modest_tny_account_store_get_session): Rename from
2074 tny_account_store_get_session().
2076 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-protocol-info.h: Split the ModestProtocol enum
2079 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2080 There was no need to have these unrelated values in one enum.
2082 * src/: many files: Adapted to changed enum. This makes the code a bit
2083 clearer, and the compiler could catch some errors.
2085 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2088 Show the detailed internal camel error message when an error happens
2089 during the configuration, so that our testers can give us more clues.
2090 For instance, in projects.maemo.org bug NB#56910 .
2092 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2094 * src/modest-tny-account.c:
2095 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2096 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2098 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2101 * src/maemo/modest-account-settings-dialog.c:
2102 (modest_account_settings_dialog_set_account_name),
2103 (save_configuration): For the incoming secure authentication checkbox,
2104 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2105 the UI specification. PLAIN does not seem to be supported for most IMAP
2106 servers anyway, and I am not sure what it would mean.
2107 However, we probably need to discover which of the secure-authentication
2108 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2109 * src/modest-account-mgr-helpers.c:
2110 (modest_account_mgr_get_server_account_data):
2112 * src/modest-tny-account.c:
2113 (modest_tny_account_new_from_server_account):
2114 Use tny_account_set_mech() to set secure-authentication methods,
2115 with some special-casing for IMAP, based on my observations of how
2118 * src/modest-account-mgr-helpers.h:
2119 * src/modest-account-mgr.c:
2120 * src/modest-defs.h: Comment that the URI is only used for local folders.
2122 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2124 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2125 parameter const, just to be neat.
2126 * src/modest-text-utils.c: (modest_text_utils_inline):
2127 End g_strconcat() with NULL, as its documentation says. This is almost
2128 certainly the cause of my crash at startup on the device. Interestingly,
2129 valgrind doesn't tell us about these errors.
2131 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2133 * scripts/build-packages: Added more precise comments about how to use
2134 this script, though I still get this error:
2135 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2136 error building tinymail
2138 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-main-window.c: (on_account_update):
2141 Very slight cleanup, hoping to make it simpler to discover what causes
2142 a crash here sometimes.
2144 * src/modest-tny-account.c:
2145 (modest_tny_account_new_from_server_account): Set the port. Added
2146 comments about the options and a TODO comment because I need to find out
2147 how to specify the secure authentication method.
2149 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2151 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2152 changed CFlags paths form modest to libmodest
2154 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2156 * src/modest-account-mgr-helpers.c:
2157 (modest_account_mgr_get_server_account_data),
2158 (modest_account_mgr_free_server_account_data):
2159 * src/modest-account-mgr-helpers.h:
2160 * src/modest-account-mgr.c:
2161 (modest_account_mgr_add_server_account):
2162 * src/modest-defs.h:
2163 * src/modest-tny-account.c:
2164 (modest_tny_account_new_from_server_account):
2165 Determine the options for tny_camel_account_add_option() here,
2166 based on the settings, rather than storing them directly in gconf.
2168 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2170 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2171 Show a more friendly error dialog now that we expect (from the tinymail
2172 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2174 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/modest-main-window.c: (on_account_update): Check that
2177 account_name is not NULL, to prevent a crash at startup that I am
2178 seeing on the N800. I do wonder why it is NULL.
2180 * src/maemo/easysetup/modest-easysetup-wizard.c:
2181 (create_page_user_details):
2182 * src/maemo/modest-account-settings-dialog.c:
2183 (create_page_user_details), (create_page_outgoing):
2184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2185 (modest_connection_specific_smtp_edit_window_init):
2186 * src/modest-ui-actions.c:
2187 (modest_ui_actions_on_password_requested):
2188 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2189 might do something useful with the on-screen keyboard.
2191 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2193 * src/maemo/modest-main-window.c: (on_account_update):
2194 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2195 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2197 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2199 * src/modest-tny-account-store.c: (on_account_changed):
2200 Correct the signature of this signal handler.
2202 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2204 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2205 Show a HildonNote instead of a GtkDialog for Maemo.
2207 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2209 * src/widgets/modest-account-view.h:
2210 * src/widgets/modest-account-view.c: (on_account_changed),
2211 (on_account_removed). Added a boolean flag, set/unset by
2212 modest_account_view_block_conf_updates(),
2213 modest_account_view_unblock_conf_updates() to prevent unnecessary
2214 updates, but this is not very useful because the gconf notifications are
2215 so delays (maybe only on Maemo Bora).
2216 So auto-updating is turned off, and these functions do an explicit
2217 update when necessary.
2218 However, something else is still doing too much work when adding/removing
2219 accounts, probably in another part of the application.
2221 * src/maemo/modest-account-view-window.c:
2222 (on_delete_button_clicked), (on_edit_button_clicked),
2223 (on_new_button_clicked): Use the new functions.
2225 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2227 * src/modest-account-mgr-helpers.c:
2228 (modest_account_mgr_set_first_account_as_default):
2229 Sort the list of names alphabetically-by-title, so we choose the first one
2231 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2232 alphabetically by the title.
2234 This fixes projects.maemo.org bug NB#56418 .
2236 * src/modest-account-mgr-priv.c:
2237 (_modest_account_mgr_account_from_key):
2238 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2239 avoid a valgrind error, and possible random behaviour.
2241 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2243 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2244 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2245 tinymail documentation to say that this can be expected.
2246 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2247 pretty, and should not happen, but I would prefer to know when it does.
2249 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2251 * configure.ac: When using the older hildon version, probably on Bora,
2252 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2254 * src/widgets/modest-attachment-view.c:
2255 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2258 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2260 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2261 Implemented the prototype. Can be tested with
2262 tests/dbus_api/test_open_message:
2264 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-tny-account-store.c:
2267 (modest_tny_account_store_instance_init), (get_password):
2268 * src/modest-ui-actions.c:
2269 (modest_ui_actions_on_password_requested):
2270 Do not store the password in gconf, because this function is called
2271 for non-remembered passwords. Actually use the cached (in the hash map)
2272 password instead of releasing it.
2273 The password will now not be remembered if it is asked via the protected
2274 password dialog, as per the UI spec.
2276 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2278 * src/modest-defs.h:
2279 * src/modest-account-mgr-helpers.h:
2280 * src/modest-account-mgr-helpers.c:
2281 Added modest_server_account_get_username_has_succeeded(),
2282 modest_server_account_set_username_has_succeeded().
2283 (modest_server_account_set_username),
2284 Reset the has-succeeded flag if the username changes.
2286 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2287 * src/maemo/modest-connection-specific-smtp-window.c:
2288 (modest_connection_specific_smtp_window_save_server_accounts):
2289 Use modest_server_account_set_username() instead of using
2290 modest_conf_set_string() directly, so that the has-succeeded flag is always
2293 * src/modest-ui-actions.c:
2294 (modest_ui_actions_on_password_requested): Dim the username entry if
2295 the username has ever worked, as per the UI spec.
2297 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2299 * src/modest-tny-account-store.c: (get_password):
2300 * src/modest-ui-actions.c:
2301 (modest_ui_actions_on_password_requested):
2302 Allow the username to be changed too, though there is more work to
2303 be done on exactly how this behaves.
2305 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2307 * src/modest-account-mgr-helpers.h:
2308 * src/modest-account-mgr-helpers.c:
2309 Added modest_account_mgr_get_display_name(),
2310 modest_server_account_get_username(),
2311 modest_server_account_set_username(),
2312 modest_server_account_set_password(),
2313 modest_server_account_get_hostname() functions so we do not need to
2314 use the conf API directly.
2316 * src/maemo/modest-main-window.c: (connect_signals):
2317 Actually connect ot the ModestAccountStore::request-password signal,
2318 so that we show the dialog when the password is requested by Tinymail,
2319 for isntance if it is empty.
2321 * src/modest-marshal.list:
2322 * src/modest-tny-account-store.c:
2323 (modest_tny_account_store_class_init), (get_password),
2324 (modest_tny_account_store_alert):
2325 * src/modest-tny-account-store.h:
2326 * src/modest-ui-actions.h:
2327 * src/modest-ui-actions.c:
2328 (modest_ui_actions_on_password_requested):
2329 Change the signal parameters, so it is obvious that we are providing
2330 the non human-readable server name, and receiving both the username
2331 and password, though changing of the username is not yet implemented.
2332 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2333 for the GNOME version.
2335 This should fix the projects.maemo.org bug NB#56209, though it does not
2336 work on Bora, because the gconf_client_get() for the password fails
2337 immediately after we save it with gconf_client_set().
2339 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2342 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2343 caused an undefined symbol error:
2344 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2346 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2348 * src/modest-tny-account-store.c:
2349 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2350 using a GError instead of a string message, so we can translate it in
2353 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2355 * src/maemo/modest-address-book.c:
2356 (modest_address_book_check_names):
2357 * src/maemo/modest-msg-view-window.c:
2358 (modest_msg_view_window_clipboard_owner_change):
2359 * src/modest-init.c: (modest_init_init_ui):
2360 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2361 (update_folders_cb), (modest_mail_operation_update_account):
2362 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2363 (modest_ui_actions_on_msg_attachment_clicked),
2364 (modest_ui_actions_on_msg_recpt_activated):
2365 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2366 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2367 (modest_msg_view_search_next):
2368 * src/widgets/modest-recpt-editor.c:
2369 (modest_recpt_editor_on_button_release_event),
2370 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2371 g_message(). At this point we should only be seeing interesting errors on
2372 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2374 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2376 (modest_wizard_dialog_force_title_update):
2377 * src/maemo/easysetup/modest-wizard-dialog.h:
2378 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2379 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2380 can update the title when appropriate. Otherwise the title is wrong if the
2381 pages are added after adding the notebook to the dialog.
2382 This must be a problem in HildonWizardDialog too.
2383 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2385 * src/maemo/easysetup/modest-easysetup-wizard.c:
2386 (create_subsequent_customsetup_pages),
2387 (create_subsequent_easysetup_pages):
2388 Call modest_wizard_dialog_force_title_update() so that the title is
2389 correct even with GTK+ < 2.10.
2390 This fixes projects.maemo.org bug NB#56145 .
2392 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2394 * src/maemo/modest-platform.c:
2395 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2396 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2399 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2401 * src/widgets/modest-window.h:
2402 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2403 and modest_window_save_state(), which invokes it.
2405 * src/widgets/modest-window-mgr.h:
2406 * src/widgets/modest-window-mgr.c:
2407 Added modest_window_mgr_save_state_for_all_windows(), which calls
2408 the save_state vfunc on all registered windows, if implemented.
2410 * src/gnome/modest-msg-edit-window.c:
2411 * src/gnome/modest-msg-view-window.c:
2412 * src/maemo/modest-msg-edit-window.c:
2413 * src/maemo/modest-msg-view-window.c:
2414 * src/maemo/modest-main-window.c:
2415 Specify the existing save_settings functions as implementations of
2416 ModestWindow::save_state_func().
2418 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2419 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2420 enabling hibernation, for instance.
2422 We may need to do the same thing for restoring settings.
2425 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2427 * src/widgets/modest-window-mgr.c:
2428 * src/widgets/modest-window-mgr.h:
2429 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2430 modest_window_mgr_get_hibernation_is_prevented().
2432 * src/maemo/modest-main-window.c:
2433 (on_hildon_program_is_topmost_notify): Prevent hibernation
2434 (possible when the application goes to the background in the WM),
2435 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2437 * src/maemo/easysetup/modest-easysetup-wizard.c:
2438 (modest_easysetup_wizard_dialog_init):
2439 * src/maemo/modest-account-settings-dialog.c:
2440 (modest_account_settings_dialog_init):
2441 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2442 (modest_connection_specific_smtp_edit_window_init):
2443 * src/maemo/modest-connection-specific-smtp-window.c:
2444 (modest_connection_specific_smtp_window_init):
2445 * src/maemo/modest-signature-editor-dialog.c:
2446 (modest_signature_editor_dialog_init):
2447 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2448 prevent hibernation while any of these account settings dialogs are open.
2450 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2452 * src/maemo/Makefile.am:
2453 * src/maemo/modest-osso-state-saving.c:
2454 * src/maemo/modest-osso-state-saving.h: Added
2455 modest_osso_load_state() and modest_osso_save_state() though they do
2456 nothing now. They should iterate through all the open windows and load/save
2458 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2459 save state when closing.
2461 * src/maemo/modest-main-window.c:
2462 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2463 Add a notification handler for the HildonProgram::is-topmost property,
2464 so we can allow hibernation when the application goes into the background.
2465 But we still need to detect when the accounts setup windows are open so
2466 we can stop hibernation when they are open.
2467 To do this, I also added the main window the HildonProgram. This might have
2468 other side-effects/benefits, and should maybe be done for other windows.
2470 * src/maemo/modest-osso-autosave-callbacks.h:
2471 * src/maemo/modest-osso-autosave-callbacks.c:
2472 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2473 though it does not do anything yet, and we might never need this to do
2474 anything. For instance, we already save drafts.
2476 * src/maemo/modest-platform.c: (modest_platform_init):
2477 Specify the libosso auto-save callback.
2479 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2481 * src/maemo/modest-platform.c:
2482 (modest_platform_set_update_interval):
2483 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2484 aparently stays valid between application instances, so we can use this
2485 to remove and reset it later. According to a maemo-developers email from
2488 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2490 * configure.ac: Depend on libalarm for Maemo.
2492 * src/dbus_api/modest-dbus-api.h:
2493 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2494 (on_send_receive), (modest_dbus_req_handler):
2495 Handle a SEND_RECEIVE D-Bus method.
2497 * libmodest-dbus-client/libmodest-dbus-client.c:
2498 (libmodest_dbus_client_send_and_receive):
2499 * libmodest-dbus-client/libmodest-dbus-client.h:
2500 Add C convenience functions for calling the new D-Bus method.
2502 * src/modest-platform.h:
2503 * src/gnome/modest-platform.c:
2504 * src/maemo/modest-platform.c:
2505 Added modest_platform_set_update_interval(), which uses the
2506 alarmd API on Maemo.
2507 (modest_platform_init),
2508 Call modest_platform_set_update_interval(), using a hard-coded
2509 interval for now (until the global settings dialog is implemented),
2510 though I am not sure that this makes sense yet.
2512 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2514 * src/dbus_api/modest-dbus-callbacks.c:
2515 (modest_osso_cb_hw_state_handler):
2516 * src/dbus_api/modest-dbus-callbacks.h:
2517 * src/maemo/modest-platform.c: (modest_platform_init):
2518 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2519 in case this has some effect on the ability for Maemo to ping the
2522 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2524 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2525 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2526 warning. It is probably a logic error, but I need to fix the build.
2528 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2530 * src/modest-account-mgr.h:
2531 * src/modest-account-mgr.c:
2532 (modest_account_mgr_account_names): Add a gboolean enabled_only
2533 parameter, so we can get lists of onlt the enabled accounts.
2535 (modest_account_mgr_add_account),,
2536 (modest_account_mgr_account_with_display_name_exists):
2537 * src/maemo/modest-msg-edit-window.c: (get_transports):
2538 * src/modest-account-mgr-helpers.c:
2539 (modest_account_mgr_set_first_account_as_default):
2540 * src/modest-init.c: (init_default_account_maybe):
2541 * src/modest-tny-account-store.c: (get_accounts):
2542 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2543 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2544 * tests/check_account-mgr.c: (START_TEST):
2545 Provide the extra parameter, as appropriate.
2547 * src/widgets/modest-account-view.c: (update_account_view):
2548 Do not show disabled accounts (meaning that there is no way to
2549 enable/disable accounts in the UI (the feature is not in our UI
2550 specification), so we can use this internally only to mark unfinished
2551 or temporary account data.
2553 * src/maemo/easysetup/modest-easysetup-wizard.c:
2554 (create_account): Add boolean enable parameter, so we can specify FALSE
2555 to create the temporary account.
2556 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2557 (on_before_next): When finishing, when there is a temporary account, just
2559 Also, use a timeout to delay the showing of the dialog until gconf is likely
2560 to return correct information, due to a maemo gconf bug that is fixed in
2561 osso 1.1, but not yet in Bora.
2562 However, the dialog stays on screen after it is destroyed.
2564 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2565 for invalid data when cancelling. Use a hildon note instead of a dialog
2566 to complain about invalid data. Do not show the account-saved note if the
2567 account is disabled (a temporary account that will not really be saved for use
2570 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2572 * src/modest-account-mgr-helpers.h:
2573 * src/modest-account-mgr-helpers.c:
2574 Added modest_account_mgr_unset_default_account(),
2575 Added modest_account_mgr_set_first_account_as_default().
2577 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2578 If it was the default account, unset the default account name.
2580 * src/maemo/modest-account-view-window.c:
2581 (on_delete_button_clicked): If it was the default account,
2582 set the first remaining account as the default instead.
2584 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2585 a NULL account or a NULL default account, to prevent a crash. This should
2586 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2589 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2591 * src/widgets/modest-recpt-editor.c:
2592 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2593 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2594 TODO comment for this. This fixes the build.
2596 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2597 be the best place for it. This will in future update all auto-update accounts,
2598 rather than just the current/default account, when that gconf key exists.
2599 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2600 if there are no accounts, before calling do_send_receive().
2601 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2603 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2604 * src/maemo/modest-main-window-ui.h:
2605 * src/maemo/modest-main-window.c: (on_connection_changed),
2606 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2607 directly, becaue the signal handler does more.
2609 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2611 * src/modest-account-mgr-helpers.c:
2612 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2613 for the case that the account does not exist.
2615 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2616 (equivalent to the modest account name) rather than the tinymail account name
2617 (equivalent to the modest account title - human readable) to get the account data.
2618 Check for null account data to prevent the crash, and add a TODO comment saying that
2619 this needs fixing because it is using the server account name instead of the account name.
2621 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2623 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2624 * src/maemo/modest-account-settings-dialog.c: (show_error),
2626 Use hildon_note_new_information() for informative and error messages,
2627 which seems to be expected for Maemo applications (no documentation that I know of
2628 says this). I am surprised that there is no distinction between info and error
2631 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2633 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2634 it is easy to find where this is used.
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 (create_page_welcome), (create_page_account_details),
2638 (create_page_user_details), (create_page_complete_easysetup),
2639 (create_page_custom_incoming), (create_page_custom_outgoing),
2640 (create_page_complete_custom):
2641 * src/maemo/modest-account-settings-dialog.c:
2642 (create_page_account_details), (create_page_user_details),
2643 (create_page_incoming), (create_page_outgoing):
2644 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2645 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2646 (modest_connection_specific_smtp_edit_window_init):
2647 * src/maemo/modest-connection-specific-smtp-window.c:
2648 (modest_connection_specific_smtp_window_init):
2649 * src/maemo/modest-signature-editor-dialog.c:
2650 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2651 and scrolling policy as per the Email Application Layout Guide, if I have
2654 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2656 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2657 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2658 which were empty, because these vfuncs have been removed from TnyAccountStore.
2659 This fixes the build.
2661 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2663 * src/maemo/modest-main-window.c:
2664 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2665 showing/hiding it. Added TODO because it probably should not be NULL.
2666 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2667 because unnecessary g_warnings() make degugging difficult.
2669 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2671 * src/maemo/modest-msg-edit-window.c:
2672 (modest_msg_edit_window_select_color),
2673 (modest_msg_edit_window_select_background_color): 2 const corrections and
2674 moving 2 #endifs before closing brackets, to fix the build.
2676 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/easysetup/modest-easysetup-wizard.h:
2679 * src/maemo/easysetup/modest-easysetup-wizard.c:
2680 (modest_easysetup_wizard_dialog_finalize),
2681 (on_button_edit_advanced_settings), (create_page_complete_custom),
2682 (on_response), (create_account):
2683 Implement the Advanced Settings edit button, by saving the account information,
2684 for the Advanded Settings dialog to use directly from gconf, and removing it
2685 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2686 Bug #5533 in the projects.maemo.org bugzilla.
2688 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2690 * src/maemo/modest-msg-view-window.c:
2691 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2692 when opening a message window.
2694 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/easysetup/modest-easysetup-wizard.c:
2697 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2700 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2701 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2702 gconf settings. I probably added more checks than necessary, but that is safer.
2704 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2705 variable to fix the build, but this seems to be used when it is still NULL.
2707 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2709 * src/modest-platform.h:
2710 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2711 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2712 * src/modest-main.c: Implement this function so we can avoid using
2713 maemo-specific API from cross-platform code.
2715 * src/modest-tny-account-store.c:
2716 (get_smtp_specific_transport_account_for_open_connection):
2717 * src/modest-ui-actions.c: (check_for_connection),
2718 (modest_ui_actions_on_item_not_found):
2719 Use modest_platform_connect_and_wait() and put #idefs around other
2720 maemo-specific code, because only maemo currently has a way to
2721 identify connection names.
2723 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2725 * src/modest-tny-account-store.h:
2726 * src/modest-tny-account-store.c:
2727 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2728 the connection-specific SMTP server settings in the configuration.
2730 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2732 * src/maemo/modest-main-window.c: (on_connection_changed),
2734 * src/modest-main.c: (main), (start_ui), (send_mail):
2735 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2736 that is what is intended.
2738 * src/modest-ui-actions.c: (action_send), (action_receive),
2739 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2740 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2741 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2742 SMTP server is used when it is specified.
2744 (modest_ui_actions_on_send_receive):
2745 Check that a connection is open before proceeding.
2746 Receive and then send, instead of vice-versa, as per the specification.
2748 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2750 * src/modest-mail-operation.c:
2751 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2752 though I guess it should be something other than NULL.
2754 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2756 * src/maemo/easysetup/modest-easysetup-wizard.c:
2757 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2758 combo twice, to avoid an g_warning and to make it visible again.
2759 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2760 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2761 (already intended) dereference when detaching, because we then recreate the menu.
2762 But I am not sure why the warning was happening, and it is possible that this is a memory
2765 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2767 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2768 and uri_parse_mailto() utility functions.
2769 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2771 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2773 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2775 * src/dbus_api/modest-dbus-api.h:
2776 * src/dbus_api/modest-dbus-callbacks.c:
2777 Use an idle callback to execute the modest code in the application's own thread.
2778 Remove the helloworld example method.
2779 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2780 parsed, and the open-message method is not implemented because this is not yet implemented in
2782 * libmodest-dbus-client/libmodest-dbus-client.c:
2783 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2784 (libmodest_dbus_client_open_message):
2785 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2787 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2788 body without crashing.
2790 * tests/dbus_api/Makefile.am:
2791 * tests/dbus_api/test_mail_to.c:
2792 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2794 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2796 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2797 Added file to fix the build. Sorry.
2799 * src/dbus_api/Makefile.am:
2800 * src/dbus_api/modest-dbus-api.h:
2801 * src/dbus_api/modest-dbus-callbacks.h:
2802 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2803 (modest_dbus_req_handler):
2804 Put constants in a separate header so it can be reused by the
2805 client library, without duplication
2807 * libmodest-dbus-client/Makefile.am:
2808 * libmodest-dbus-client/libmodest-dbus-client.c:
2809 (libmodest_dbus_client_call_helloworld),
2810 (libmodfest_dbus_client_send_mail),
2811 (libmodfest_dbus_client_mailto),
2812 (libmodfest_dbus_client_open_message):
2813 * libmodest-dbus-client/libmodest-dbus-client.h:
2814 (Partly) Implement a send_mail D-Bus method.
2816 * tests/dbus_api/Makefile.am:
2817 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2818 the send_email D-Bus method.
2820 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2824 * libmodest-dbus-client/Makefile.am:
2825 * libmodest-dbus-client/libmodest-dbus-client.c:
2826 * libmodest-dbus-client/libmodest-dbus-client.h:
2827 * tests/dbus_api/Makefile.am:
2828 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2829 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2831 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2833 * src/maemo/easysetup/modest-easysetup-wizard.c:
2834 (create_page_account_details):
2835 * src/maemo/modest-account-settings-dialog.c:
2836 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2837 widgets, because this might not be the default in future versions of the Maemo GTK+.
2838 However, I can not not get capitalization to work even in a simple test case.
2840 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/easysetup/modest-easysetup-wizard.c:
2843 (create_page_custom_incoming), (create_page_custom_outgoing):
2844 * src/maemo/modest-account-settings-dialog.c:
2845 (create_page_account_details), (create_page_incoming),
2846 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2847 instead of using gtk_check_button_with_label(), so they are aligned like the other
2848 widgets, as per the UI spec.
2850 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/easysetup/modest-easysetup-wizard.c:
2853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2854 * src/widgets/modest-validating-entry.c:
2855 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2856 Modest prefix instead of an EasySetup prefix.
2858 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2860 * src/widgets/modest-validating-entry.h:
2861 * src/widgets/modest-validating-entry.c: (on_insert_text),
2862 Added easysetup_validating_entry_set_max_func(), used to set a callback
2863 to call when the max number of characters is reached. GtkEntry has a max-length
2864 already but is silent about it.
2866 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2867 (create_page_account_details), (create_page_user_details),
2869 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2870 (create_page_account_details), (create_page_user_details),
2871 (create_page_outgoing):
2872 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2873 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2874 the UI spec, when the user tries to enter more than the max number of characters.
2876 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/easysetup/modest-easysetup-wizard.c:
2879 (create_page_user_details), (create_page_custom_incoming),
2880 (create_page_custom_outgoing):
2881 * src/maemo/modest-account-settings-dialog.c:
2882 (create_page_user_details), (create_page_incoming),
2883 (create_page_outgoing):
2884 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2885 (modest_connection_specific_smtp_edit_window_init):
2886 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2887 not appropriate. Bad Maemo-specific defaults!.
2889 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2891 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2892 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2893 (modest_signature_editor_dialog_set_settings):
2894 Disable the label and textview when the checkbox is disabled, and use the
2895 specified (UI spec) default signature text.
2897 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2900 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2902 * src/modest-defs.h:
2903 * src/modest-account-mgr-helpers.h:
2904 * src/modest-account-mgr-helpers.c:
2905 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2907 * src/maemo/Makefile.am:
2908 * src/maemo/modest-signature-editor-dialog.c:
2909 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2912 * src/maemo/modest-account-settings-dialog.h:
2913 * src/maemo/modest-account-settings-dialog.c:
2914 (modest_account_settings_dialog_finalize), (on_button_signature),
2915 (save_configuration): Use the new dialog when the Edit button is pressed, and
2916 save the changes if necessary, as per the UI spec.
2918 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2920 * src/maemo/Makefile.am:
2921 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2922 based on maemo-develoers email from Dirk.
2924 * src/maemo/easysetup/modest-easysetup-wizard.c:
2925 (create_page_welcome), (create_page_account_details),
2926 (create_page_user_details), (create_page_complete_easysetup),
2927 (create_page_custom_incoming), (create_page_custom_outgoing),
2928 (create_page_complete_custom),
2929 (modest_easysetup_wizard_dialog_init):
2930 * src/maemo/modest-account-settings-dialog.c:
2931 (create_page_account_details), (create_page_user_details),
2932 (create_page_incoming), (create_page_outgoing),
2933 (modest_account_settings_dialog_init):
2934 * src/maemo/modest-connection-specific-smtp-window.c:
2935 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2937 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2939 * src/maemo/easysetup/modest-easysetup-wizard.c:
2940 (create_page_account_details), (create_page_custom_outgoing),
2941 (create_page_complete_custom):
2942 * src/maemo/modest-account-settings-dialog.c:
2943 (create_page_user_details), (create_page_incoming),
2944 (create_page_outgoing):
2945 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2946 (modest_connection_specific_smtp_edit_window_init):
2947 Use the correct (UI spec) port min/max, and use horizontal separators,
2950 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/easysetup/modest-easysetup-wizard.c:
2953 (set_default_custom_servernames):
2954 * src/maemo/modest-account-settings-dialog.c:
2955 (create_page_incoming), (on_combo_outgoing_security_changed),
2956 (on_combo_incoming_security_changed), (create_page_outgoing),
2957 (modest_account_settings_dialog_set_account_name),
2958 (save_configuration):
2959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2960 (on_combo_security_changed),
2961 (modest_connection_specific_smtp_edit_window_init),
2962 (modest_connection_specific_smtp_edit_window_set_connection),
2963 (modest_connection_specific_smtp_edit_window_get_settings):
2964 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2967 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2970 * src/maemo/easysetup/modest-easysetup-wizard.c:
2971 (create_page_custom_outgoing), (create_page_complete_custom):
2972 * src/maemo/modest-account-settings-dialog.c:
2973 (create_page_user_details), (create_page_outgoing):
2974 * src/maemo/modest-account-view-window.c: (button_box_new):
2975 Use changed logical IDs as per the most recent UI spec:
2976 mcen_bd_emailsetup_edit -> mcen_bd_edit
2977 mcen_bd_emailsetup_delete -> mcen_bd_delete
2978 mcen_bd_emailsetup_close -> mcen_bd_close
2980 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2984 * src/dbus_api/Makefile.am:
2985 * src/dbus_api/modest-dbus-callbacks.c:
2986 * src/dbus_api/modest-dbus-callbacks.h:
2987 * src/maemo/modest-platform.c: (modest_platform_init):
2988 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2990 * tests/Makefile.am:
2991 * tests/dbus_api/Makefile.am:
2992 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2994 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2996 * src/maemo/modest-account-settings-dialog.c:
2997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2998 Removed unnecessary includes.
3000 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3002 * src/maemo/easysetup/modest-easysetup-wizard.c:
3003 * src/maemo/modest-account-settings-dialog.c:
3004 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3005 * src/widgets/Makefile.am:
3006 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3007 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3008 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3009 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3010 * src/widgets/modest-secureauth-combo-box.c:
3011 * src/widgets/modest-secureauth-combo-box.h:
3012 * src/widgets/modest-serversecurity-combo-box.c:
3013 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3014 made the GObject names more consistent with the rest of the Modest code.
3016 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3018 * src/maemo/easysetup/Makefile.am:
3019 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3020 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3021 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3022 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3023 * src/maemo/easysetup/modest-easysetup-wizard.c:
3024 * src/maemo/easysetup/modest-validating-entry.c:
3025 * src/maemo/easysetup/modest-validating-entry.h:
3026 * src/maemo/modest-account-settings-dialog.c:
3027 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3028 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3029 widgets/ because they are used outside of easysetup too. After checking in,
3030 svn will allow me to rename them too.
3032 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3034 * src/gnome/modest-msg-edit-window.c:
3035 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3036 linker error, to fix the build on the GNOME platform.
3037 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3038 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3039 ifdefed out to avoid a warning.
3041 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3043 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3044 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3045 some alternative for GTK+ 2.6.
3047 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3049 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3051 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3052 specified for EmailAccountsDialog in UI spec.
3054 * src/maemo/easysetup/modest-easysetup-wizard.c:
3055 * src/maemo/easysetup/modest-easysetup-wizard.h:
3056 * src/maemo/modest-account-settings-dialog.c:
3057 * src/maemo/modest-account-settings-dialog.h:
3058 Reuse a member window widget for the connection-specific SMTP server accounts,
3059 so we can tell it to create/save the accounts only if we actually save changes.
3061 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3062 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3063 (modest_connection_specific_smtp_edit_window_get_settings):
3064 Return a struct instance for temporarily remembering the entered data.
3066 * src/maemo/modest-connection-specific-smtp-window.h:
3067 * src/maemo/modest-connection-specific-smtp-window.c:
3068 (modest_connection_specific_smtp_window_finalize),
3069 (modest_connection_specific_smtp_window_fill_with_connections),
3071 (modest_connection_specific_smtp_window_save_server_accounts),
3072 (update_model_server_names): Do not actually save data until asked,
3073 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3075 (on_selection_changed),
3076 (modest_connection_specific_smtp_window_init): Disable the edit
3077 button when nothing is selected.
3079 * src/modest-account-mgr-helpers.c:
3080 * src/modest-account-mgr-helpers.h:
3081 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3084 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3086 * src/modest-account-mgr-helpers.h:
3087 * src/modest-account-mgr-helpers.c:
3088 (modest_account_mgr_get_unused_account_name),
3089 (modest_account_mgr_get_unused_account_display_name): Added these
3090 utility functions, to avoid code duplication.
3092 * src/maemo/easysetup/modest-easysetup-wizard.c:
3093 (create_page_account_details), (create_account):
3094 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3095 (on_combo_security_changed),
3096 (modest_connection_specific_smtp_edit_window_init),
3097 (modest_connection_specific_smtp_edit_window_save_settings):
3098 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3099 * src/maemo/modest-connection-specific-smtp-window.c:
3100 (modest_connection_specific_smtp_window_finalize),
3101 (modest_connection_specific_smtp_window_fill_with_connections),
3102 (on_button_edit), (modest_connection_specific_smtp_window_init):
3103 * src/maemo/modest-connection-specific-smtp-window.h:
3104 Implementing saving of connection-specific server accounts.
3106 But I need to refactor this so we can save the data for each
3107 possible connection-specific account and only actually create the server accounts
3108 when the easysetup finished, or the OK button is pressed on the account settings
3111 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3114 (on_combo_security_changed):
3115 (modest_connection_specific_smtp_edit_window_init):
3116 Auto-fill the port number as in the account settings.
3118 (modest_connection_specific_smtp_edit_window_set_connection):
3119 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3120 * src/maemo/modest-connection-specific-smtp-window.c:
3121 (fill_with_connections), (on_button_edit),
3122 (modest_connection_specific_smtp_window_init):
3123 Turn the edit window into a dialog to simplify the code, and
3124 set a WM hint as in a GtkDialog, because only a popup can be on top of
3125 another window in Maemo, and popups usually have no WM decoration.
3127 * src/modest-defs.h:
3128 * src/modest-account-mgr-helpers.c:
3129 (modest_account_mgr_set_connection_specific_smtp),
3130 (modest_account_mgr_remove_connection_specific_smtp),
3131 (modest_account_mgr_get_connection_specific_smtp):
3132 * src/modest-account-mgr-helpers.h: Some functions to write the
3133 connection-specific SMTP server information. Not yet used.
3136 * src/widgets/modest-folder-view.c: (text_cell_data):
3137 Fix a warning about an uninitialized variable.
3138 (on_configuration_key_changed): Put an #ifdef around the use
3139 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3141 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3143 * src/maemo/modest-account-settings-dialog.h:
3144 * src/maemo/modest-account-settings-dialog.c:
3145 Added connect_for_modified() utility function to mark the new modified boolean.
3147 (create_page_account_details), (create_page_user_details),
3148 (create_page_incoming), (create_page_outgoing), (on_response),
3149 (modest_account_settings_dialog_init),
3150 (modest_account_settings_dialog_set_account_name):
3151 Only warn about unsaved changes when there are actually unsaved changes.
3153 * src/modest-account-mgr-helpers.c:
3154 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3155 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3156 to get the data from there in future.
3158 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3160 * src/modest-defs.h:
3162 * src/modest-account-mgr-helpers.h:
3163 * src/modest-account-mgr-helpers.c:
3164 Store the security account setting in a single conf key instead of using
3165 the options list, so that the list is left for just the to-be-removed camel hack,
3166 and because gconf_client_set_list() is failing for some reason.
3168 * src/modest-account-mgr.c:
3169 (modest_account_mgr_add_server_account):
3170 * src/maemo/modest-account-settings-dialog.c:
3171 (modest_account_settings_dialog_set_account_name),
3172 (save_configuration): Use the renamed functions.
3175 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3177 * src/widgets/Makefile.am:
3178 * src/widgets/modest-limit-retrieve-combo-box.c:
3179 * src/widgets/modest-limit-retrieve-combo-box.h:
3180 * src/widgets/modest-retrieve-combo-box.c:
3181 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3182 the account settings dialog.
3184 * src/modest-defs.h:
3185 * src/modest-account-mgr-helpers.h:
3186 * src/modest-account-mgr-helpers.c:
3187 (modest_server_account_get_option_secure_auth),
3188 (modest_server_account_set_option_secure_auth):
3189 * src/modest-account-mgr.c:
3190 (modest_account_mgr_add_server_account):
3191 Use the existing AUTH_MECH conf key for the secure-auth setting,
3192 instead of putting it in the list options, because this was actually used already.
3194 * src/maemo/modest-account-settings-dialog.c:
3195 (create_page_account_details),
3196 (modest_account_settings_dialog_set_account_name),
3197 (save_configuration):
3198 * src/maemo/modest-account-settings-dialog.h:
3199 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3200 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3202 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3204 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3205 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3206 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3208 * src/modest-defs.h:
3209 * src/maemo/modest-account-settings-dialog.c:
3210 (create_page_incoming), (on_combo_outgoing_security_changed),
3211 (on_combo_incoming_security_changed), (create_page_outgoing),
3212 (modest_account_settings_dialog_set_account_name),
3213 (save_configuration): Load/Save the port number, and change it when the
3214 security combo changes, to suitable defaults.
3216 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3218 * src/modest-account-mgr.c:
3219 (modest_account_mgr_add_server_account): Set the security and secure-auth
3220 options, and add a comment saying that the other camel-specific options should be
3223 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3227 * src/modest-tny-account-store.c: (account_list_free),
3228 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3229 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3232 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3234 * src/modest-protocol-info.c:
3235 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3236 is required by our UI spec. Maybe something in our implementation will use this eventually.
3237 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3238 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3239 instead of the previous 0 placeholder.
3241 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3242 secure-auth settings.
3243 * src/modest-account-mgr-helpers.h:
3244 * src/modest-account-mgr-helpers.c:
3245 (modest_server_account_data_get_option_secure_auth),
3246 (modest_server_account_set_option_secure_auth),
3247 (modest_server_account_data_get_option_security),
3248 (modest_server_account_set_option_security): Added this API for getting and setting the security
3249 and secure-auth settings.
3251 * src/maemo/modest-account-settings-dialog.h:
3252 * src/maemo/modest-account-settings-dialog.c:
3253 (modest_account_settings_dialog_finalize), (check_data),
3254 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3255 about changing titles.
3256 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3257 (save_configuration): Save the security and secure-auth settings.
3259 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3260 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3262 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3264 * src/modest-defs.h:
3265 * src/modest-account-mgr.c:
3266 (modest_account_mgr_add_server_account):
3267 Added and used defines for the options key and value pair strings,
3268 that are used so far, though they do not seem to correspond to anything in our
3269 UI specs or ModestProtocol enum.
3271 * src/modest-account-mgr-helpers.h:
3272 * src/modest-account-mgr-helpers.c:
3273 (compare_option_strings_for_name),
3274 (modest_server_account_data_get_option_value),
3275 (modest_server_account_data_get_option_bool),
3276 (modest_account_mgr_get_server_account_option):
3277 Added helper functions for parsing the options GSList.
3279 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3281 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3282 display name is based on the supplied account name.
3283 * src/modest-account-mgr.c:
3284 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3285 with an inefficient, but good-enough, implementation.
3287 * src/maemo/easysetup/modest-easysetup-wizard.c:
3288 (create_page_account_details), (on_before_next), (create_account):
3289 Check for existing display names rather than (non-user-visible) account names, and just
3290 create and set a unique account name at the end.
3292 * src/maemo/modest-account-settings-dialog.c:
3293 (modest_account_settings_dialog_init),
3294 (modest_account_settings_dialog_set_account_name),
3295 (create_page_incoming): Show the display name, instead of the account name.
3296 (on_response): Do some (not all) extra checks, as in the UI spec.
3297 (save_configuration): Save the display name if it was changed.
3299 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3301 * po/en_GB.po: Added needed logical ID and translation.
3302 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3303 (init_view): Made the is-default column clicking work.
3305 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/easysetup/Makefile.am:
3309 * src/maemo/easysetup/modest-easysetup-wizard.c:
3310 (modest_easysetup_wizard_dialog_init):
3311 * src/maemo/easysetup/provider-data-test.keyfile:
3312 * src/maemo/easysetup/provider-data.keyfile:
3313 Moved the provider data file to the new modest-providers-data package and used it from there.
3315 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3317 * src/modest-local-folder-info.c:
3318 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3319 N_() was already used on the static strings, but this just marks it for translation without
3320 using the translation.
3322 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/modest-account-settings-dialog.c:
3325 (create_page_incoming),
3326 (modest_account_settings_dialog_set_account_name):
3327 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3328 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3329 I will do this if nobody else gets there first.
3331 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3334 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3335 save the security stuff.
3337 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3339 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3340 Set the email address and user fullname, which I now see must be
3343 * src/maemo/modest-account-settings-dialog.h:
3344 * src/maemo/modest-account-settings-dialog.c:
3346 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3347 leave-on-server and authentication.
3348 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3351 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3354 * src/maemo/modest-account-settings-dialog.c:
3355 * src/maemo/modest-account-settings-dialog.h:
3356 Most (but not all) of the widgets are now present as specified by the UI spec.
3357 No changes are yet saved, and some details are not properly shown yet.
3359 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3361 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3363 * src/maemo/Makefile.am:
3364 * src/maemo/modest-account-settings-dialog.c:
3365 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3366 an existing account. Doesn't do much yet.
3368 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3369 Open the accounts settings dialog when Edit is clicked.
3371 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3373 * src/maemo/easysetup/Makefile.am:
3374 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3376 * src/maemo/easysetup/modest-easysetup-wizard.c:
3377 (modest_easysetup_wizard_dialog_init):
3378 Try to get the source directory from the build system,
3379 instead of hard-coding "./" into the source code, when opening our local
3380 copies of the configuration files.
3381 But this still fails when opening the wizard from the Accounts window,
3382 maybe because the working directory seems to change at runtime.
3383 So the wizard will fail the second time unless you copy the files into their
3384 proper locations - see the stdout warnings for the paths.
3386 (create_page_account_details),(on_before_next):
3387 Check for existing non-server accounts instead of server accounts,
3388 so the default account name is useful again, and to prevent trying to
3391 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3392 Show the wizard when New is clicked.
3394 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3395 (init_view): Show the column headers, and show the columns that are
3396 specified in the UI specs. However, something in Maemo's GTK+ prevents
3397 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3398 change the default account. This is despite unsetting the special properties.
3400 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3402 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3403 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3404 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3405 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3406 to make that clearer.
3407 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3409 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3411 * src/maemo/modest-account-view-window.c:
3412 (modest_account_view_window_init),
3413 (modest_account_view_window_new):
3414 Use the same buttons as specified in the
3415 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3416 the existing widgets, which never had a chance of working.
3417 Put the ModestAccountView treeview in a scrolled window.
3418 Do not repeat the initialization in both _init() and _new().
3420 * src/widgets/modest-account-view.c: (update_account_view):
3421 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3422 this widget and window shows no accounts.
3424 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3426 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3428 * src/maemo/easysetup/modest-easysetup-wizard.c:
3429 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3430 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3431 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3434 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3435 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3436 accounts exist yet, as in the UI spec.
3438 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3440 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3442 * src/maemo/Makefile.am:
3443 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3444 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3445 New window for editing connection-specific smtp details.
3446 Not fully implemented.
3448 * src/maemo/modest-connection-specific-smtp-window.c:
3449 (modest_connection_specific_smtp_window_finalize) :
3450 unref the tree model.
3451 (on_button_edit): Show the edit window.
3453 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3455 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3458 * src/maemo/Makefile.am:
3459 * src/maemo/modest-connection-specific-smtp-window.c:
3460 * src/maemo/modest-connection-specific-smtp-window.h:
3461 New window for showing the list of connections, for connection-specific
3462 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3463 * src/maemo/easysetup/modest-easysetup-wizard.c:
3464 (create_page_custom_outgoing): Show the new window when the button is clicked.
3466 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3468 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3469 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3470 * src/maemo/modest-msg-edit-window.c:
3471 (modest_msg_edit_window_insert_image):
3472 * src/modest-conf.c: (modest_conf_key_escape):
3473 * src/modest-mail-operation.c:
3474 (modest_mail_operation_send_new_mail):
3475 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3476 (modest_ui_actions_on_new_account):
3477 * src/widgets/modest-attachment-view.c: (update_filename_request):
3478 * src/widgets/modest-mail-header-view.c:
3479 Corrected warnings that were breaking the build, by commenting out unused variables,
3480 and a function, and by including a header.
3482 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3484 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3485 so we can #ifdef around platform-specific code when necessary.
3486 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3487 to allow this to build for the GNOME platform too.
3489 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/easysetup/modest-easysetup-wizard.c:
3492 Added util_increment_name() and used it in create_page_account_details()
3493 to make sure that the default account name is always a new name.
3495 (modest_easysetup_wizard_dialog_init),
3496 (set_default_custom_servernames): Some minor memory management fixes.
3498 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3502 * src/modest-runtime.c: (init_i18n): Restored the translation
3503 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3504 are defined in config.h, and the translations are installed.
3506 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3507 is defined for translation.
3509 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3511 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3513 * src/maemo/easysetup/modest-easysetup-wizard.c:
3514 (modest_easysetup_wizard_dialog_init):
3515 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3516 Use realistic paths (though they should use $prefix generically) to the
3517 mcc_mapping and provider-data.keyfile files which might work when they
3518 are installed by the future version of the operator-wizard package,
3519 and then fallback to paths in our source code, with an explanatory
3522 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/Makefile.am:
3527 * src/maemo/easysetup/: Added files from the previously-exernal
3528 osso-modest-easysetup.
3529 * src/maemo/modest-main-window-ui.h:
3530 * src/modest-ui-actions.c:
3531 * src/modest-ui-actions.h:
3532 Added modest_ui_actions_on_new_account() as a signal handler for the
3533 New Account menu item. It shows the easysetup wizard.
3534 * po/en_GB.po: Added additional needed logical IDs and translations.