1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
4 Prevent use of the new notification feature for now, because it currently
5 shows one dialog for each new email, which is annoying.
7 2007-06-11 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
10 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
11 when no country was selected, so that we show the global ones.
12 * src/maemo/easysetup/modest-presets.c:
13 (modest_presets_get_providers): Return only the global providers, not
14 all providers when mmc=0 was requested.
16 2007-06-11 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
19 (easysetup_provider_combo_box_fill): Remove debug code that showed the
20 provider ID in the combo.
22 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
23 Do not show the page numbers, because it would be confusing when we add
24 the 2 extra pages for the custom setup, when the user chooses the "Other"
25 provider. This fixes projects.maemo.org bug NB#59028
27 * src/modest-init.c: (modest_init_init_core),
28 (modest_init_local_folders):
30 * src/modest-tny-account.c:
31 (modest_tny_account_new_for_local_folders): Do not create default folders
32 for the memory card. This should fix projects.maemo.org bug NB#59328.
34 2007-06-11 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
37 Free the changed_conf_keys string items. They are already freed in the
38 idle handler if that runs first.
40 2007-06-11 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-ui-actions.c:
43 (modest_ui_actions_on_password_requested): Check that the server name
44 is not NULL, because I just saw a password dialog with (null) as the
47 * src/modest-tny-folder.[h|c]: Added
48 modest_tny_folder_is_memory_card_folder().
49 * src/modest-ui-dimming-rules.c:
50 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
51 menu item for memory cards, as per the UI spec (section 7.4). This should
52 fix projects.maemo.org bug NB#59297.
54 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
56 * src/maemo/modest-main-window.c: (sync_accounts_cb):
57 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
58 is another problem with the code, see Murray's comment at line 772)
60 2007-06-08 Murray Cumming <murrayc@murrayc.com>
62 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
63 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
64 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
65 (load_from_file), (easysetup_country_combo_box_init),
66 (easysetup_country_combo_box_get_active_country_ids),
67 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
68 instead of just one ID, to avoid duplicate country names in the UI.
70 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
71 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
72 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
73 a single ID, avoiding duplicate providers.
74 * src/maemo/easysetup/modest-easysetup-wizard.c:
75 (on_combo_account_country): Adapt to use a list.
77 2007-06-08 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
80 keys changed in the last X seconds.
82 * src/modest-account-mgr.h:
83 * src/modest-account-mgr.c: (on_timeout_notify_changes),
84 (on_key_change), (modest_account_mgr_class_init),
85 (modest_account_mgr_init), (modest_account_mgr_finalize):
86 As the keys are changed, save them in a GSList* and signal that GSList*
87 further every X seconds, to batch changes, to allow us to do just one
88 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
89 bug NB#56941 and other (UI-blocking) delays when changing account settings.
91 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
92 changed signal signature.
94 * src/modest-conf.c: (modest_conf_set_list),
95 (modest_conf_on_change): Reenable notification.
97 (modest_conf_maemo_fake_on_change): Comment out the hack that
98 notified immediately instead of asynchronously.
100 * src/widgets/modest-account-view.h:
101 * src/widgets/modest-account-view.c:
102 (update_account_view): Select the previously-selected account ID,
103 if possible. This fixes projects.maemo.org bug NB#56933.
105 (on_account_changed), (on_account_removed),
106 (modest_account_view_select_account):
108 Remove the block/unblock functions
109 because they were not useful.
111 * src/maemo/modest-account-view-window.c:
112 (on_delete_button_clicked), (on_edit_button_clicked),
113 (on_new_button_clicked): Remove the use of the non-working block/unblock.
115 2007-06-08 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
118 Improve the error dialog to show Incorrect Account Settings, which seems
119 clearer, and say that the internal error message (to be removed from the
120 dialog later) is often misleading.
121 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
123 * src/modest-tny-account.c:
124 (modest_tny_account_new_from_server_account): Uncomment the printf of the
125 URL because this is so useful for debugging on the device.
127 * src/widgets/modest-serversecurity-combo-box.c:
128 (modest_serversecurity_combo_box_fill): Correct a logical ID.
130 2007-06-08 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-mail-operation.c:
133 (modest_mail_operation_send_new_mail):
134 Added a comment about a nasty but apparently harmless message. Details
135 added to the wiki g_warnings() page.
137 2007-06-08 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
140 (modest_tny_send_queue_class_init):
141 Do not use the priv struct because it is empty, to avoid g_warnings
142 about a non-existant priv struct.
144 * src/modest-tny-account-store.c:
145 (modest_tny_account_store_get_server_account),
146 (modest_tny_account_store_get_transport_account_for_open_connection
147 ): Do not try to get transport server accounts for local folders,
148 because they don't have any. This avoids a g_warning().
150 * src/maemo/modest-main-window.c:
151 (modest_main_window_notify_send_receive_initied),
152 (on_configuration_key_changed):
153 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
155 * src/modest-mail-operation.c:
156 (modest_mail_operation_update_account):
157 * src/modest-tny-account-store.h:
158 * src/modest-tny-account.c:
159 (modest_tny_account_get_special_folder),
160 (modest_tny_account_new_for_local_folders),
161 (modest_tny_account_new_for_per_account_local_outbox_folder):
162 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
163 * src/modest-tny-local-folders-account.c:
164 (add_account_folders_to_merged_folder):
165 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
166 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
167 (modest_ui_actions_on_send):
168 * src/widgets/modest-folder-view.c: (update_model):
169 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
170 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
171 modest_tny_account_store_get_tny_account_by_account() to
172 modest_tny_account_store_get_server_account() to make the code clearer.
174 2007-06-07 Marcus Bauer <marcusb@openismus.com>
176 * src/dbus_api/modest-dbus-api.h:
177 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
178 * src/maemo/modest-msg-edit-window.c:
179 (modest_msg_edit_window_attach_file_noninteractive):
180 added g_warning in case the file to be attached does not exist
181 * tests/dbus_api/test_compose_mail.c: (main):
182 removed obsolete comment, added generic files as test case
184 2007-06-07 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-tny-account-store.c: (get_server_accounts):
187 Create the local folders account only once, not once for each outbox, and
188 not only when there are some outboxes.
190 2007-06-07 Murray Cumming <murrayc@murrayc.com>
192 * src/widgets/modest-folder-view.c: (update_model): Comment out some
193 code that is causing a crash at startup. Sergio says that he is fixing this.
195 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
197 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
198 * src/maemo/modest-account-settings-dialog.c:
199 (create_page_outgoing),
200 (modest_account_settings_dialog_set_account_name),
201 (save_configuration):
202 - Fixed handling of the "Use secure authentication" toggle to comply with
203 the ui specification. See also projects.maemo.org bug NB#58400
205 - Restore the Secure connection setting combo correctly when loading
208 * src/maemo/modest-maemo-utils.c:
209 (on_camel_account_get_supported_secure_authentication),
210 (modest_maemo_utils_get_supported_secure_authentication_methods):
211 Fixed a crasher if operation is canceled
213 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
214 (modest_protocol_info_auth_is_secure):
215 * src/modest-protocol-info.h:
217 Added two new methods to determine if a protocol/auth method is secure/encrypted in
218 the sense of the "Use secure authentication" toggle.
220 2007-06-07 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-tny-account-store.h:
223 * src/modest-tny-account-store.c:
224 Added modest_tny_account_store_get_local_folders_account().
226 * src/modest-tny-folder.h:
227 * src/modest-tny-folder.c:
228 (modest_tny_folder_get_account):
229 Added this replacement for tny_folder_get_account() which returns
230 the local-folders account for TnyMergeFolders, to avoid the
231 warning about the unimplemented get_account_func() vfunc().
233 (modest_tny_folder_get_rules),
234 * src/modest-ui-actions.c:
235 (modest_ui_actions_on_folder_selection_changed):
236 * src/modest-mail-operation.c:
237 (modest_mail_operation_remove_folder),
238 (modest_mail_operation_xfer_folder),
239 (modest_mail_operation_rename_folder),
240 (modest_mail_operation_get_msg),
241 (modest_mail_operation_get_msgs_full),
242 (modest_mail_operation_remove_msg),
243 (modest_mail_operation_xfer_msgs),
244 (modest_mail_operation_refresh_folder):
245 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
247 2007-06-07 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
250 (modest_server_account_set_security):
251 * src/modest-defs.h: Add comments explaining that our
252 UI spec means TLS when it says Normal, so these do not look like errors.
254 * src/modest-tny-account.c:
255 (modest_tny_account_new_from_server_account): Use the new tinymail
256 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
257 for TLS. This should fix projects.maemo.org bug NB#58460.
259 2007-06-06 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/easysetup/modest-easysetup-wizard.c:
262 (create_account): Correct the position of the gconf sanity check warning.
263 (on_button_edit_advanced_settings): Show the dialog immediately, instead
264 of using the g_idle_add() hack, because this does not seem to be necessary
265 on osso 1.1. It might even work on Maemo Bora if the problems were actually
266 caused by something other than maemo's gconf.
267 This fixes projects.maemo.org bug #59022.
269 2007-06-06 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-account-mgr-helpers.c:
272 (modest_account_mgr_get_default_account): Do not check that the account
273 exists if there is no default account (NULL), to fix a runtime warning.
275 2007-06-06 Murray Cumming <murrayc@murrayc.com>
277 * src/widgets/modest-folder-view.c: (update_model):
278 Do not unref the treemodel before we have finished with it.
279 This prevents a valgrind warning and an occasional crash at startup.
281 2007-06-06 Marcus Bauer <marcusb@openismus.com>
283 * libmodest-dbus-client/libmodest-dbus-client.h:
284 added libmodest_dbus_client_compose_mail()
285 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
287 added functions needed for SendAsMail() functionality
288 * src/maemo/modest-msg-edit-window.c:
289 (modest_msg_edit_window_attach_file_noninteractive):
290 non interactively attaching files to message edit window
291 * src/widgets/modest-msg-edit-window.h:
292 * tests/dbus_api/Makefile.am:
293 added test_compose_mail.c
294 * tests/dbus_api/test_compose_mail.c: (main):
296 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
298 * src/modest-account-view.c:
299 Fixed bug projects.maemo.org bug NB#59307
301 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
303 * src/maemo/easysetup/modest-easysetup-wizard.c:
304 (get_serverport_incoming), (on_before_next), (create_account):
305 * src/maemo/modest-account-settings-dialog.c:
306 (modest_account_settings_dialog_set_account_name):
307 * src/maemo/modest-maemo-utils.c:
308 (on_camel_account_get_supported_secure_authentication_status),
309 (on_camel_account_get_supported_secure_authentication),
310 (on_secure_auth_cancel),
311 (modest_maemo_utils_get_supported_secure_authentication_methods):
313 Implemented security authentication for settings and easysetup.
315 2007-06-05 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/modest-main-window.c: (create_details_widget):
318 Show the total size for memory card accounts too, instead of showing
319 the name again. Fixes bug projects.maemo.org bug NB#59307.
321 2007-06-05 Murray Cumming <murrayc@murrayc.com>
324 * src/modest-tny-simple-folder-store.c:
325 * src/modest-tny-simple-folder-store.h: Removed.
327 * src/modest-tny-local-folders-account.h
328 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
329 for the local-folders maildir, with an extra TnyMergedFolder containing
330 the folders of the per-account outbox store accounts.
331 * src/modest-tny-account-store.c: (get_server_accounts):
332 Add the outboxes to the special local folders account after creating it.
334 * src/modest-tny-account.c:
335 (modest_tny_account_new_for_local_folders): Create the derived
336 account when creating the main local-folders account.
338 * src/maemo/modest-main-window.c: (create_details_widget),
339 (modest_main_window_set_contents_style):
340 Adapted to the use of the derived account instead of the folder store.
342 * src/modest-ui-actions.c:
343 (modest_ui_actions_on_folder_selection_changed):
344 * src/modest-ui-dimming-rules.c:
345 (modest_ui_dimming_rules_on_new_folder):
346 * src/widgets/modest-folder-view.c: (text_cell_data),
347 (icon_cell_data), (filter_row), (update_model),
348 (get_cmp_rows_type_pos):
351 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
352 Do not get the priv struct, because no priv struct has been set,
353 to avoid a runtime warning.
355 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
356 #ifelse with #else, to fix a warning, to fix the build.
359 2007-06-05 Christian Kellner <ckellner@openismus.com>
361 * libmodest-dbus-client/libmodest-dbus-client.c:
362 Fix small typo in doc (why do you always see them
363 AFTER committing stuff?)
366 2007-06-05 Christian Kellner <ckellner@openismus.com>
368 * libmodest-dbus-client/libmodest-dbus-client.c:
369 (libmodest_dbus_client_search):
370 Initialize hit list with NULL. Also set folder list
371 to "" if NULL was supplied.
374 2007-06-03 Christian Kellner <ckellner@openismus.com>
376 * libmodest-dbus-client/libmodest-dbus-client.c:
377 (modest_search_hit_list_free):
378 Make it save to call it with NULL.
380 * src/dbus_api/modest-dbus-callbacks.c:
381 * src/modest-search.c:
382 Return full ModestSearchHits as the search result list not TnyHeader
383 since can't be around withouth the correspoding TnyFolder.
385 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
387 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
388 Added currently commented code to check for secure auth
390 * src/maemo/modest-account-settings-dialog.c: (on_response),
391 (save_configuration), (show_ok):
392 Fixed projects.maemo.org bugs NB #59248 and #59251
394 * src/maemo/modest-maemo-utils.c:
395 (on_camel_account_get_supported_secure_authentication_status),
396 (on_camel_account_get_supported_secure_authentication),
397 (modest_maemo_utils_get_supported_secure_authentication_methods):
398 * src/maemo/modest-maemo-utils.h:
399 Moved get_supported_secure_authentication() method here to be able
400 to use it from easysetup wizard.
402 * src/modest-pair.c: (on_pair_compare_as_string):
403 Should compare string with first part of pair and not
404 strcmp pairs which will crash.
406 * src/modest-protocol-info.c:
407 (modest_protocol_info_protocol_is_store):
408 * src/modest-protocol-info.h:
409 Added modest_protocol_info_get_auth_protocol_name()
411 2007-06-03 Armin Burgmeier <armin@openismus.com>
413 * src/modest-mail-operation.c:
414 (modest_mail_operation_get_msgs_full): Set priv->account also when
415 only retrieving a single message. This avoids a crash when canceling
418 (modest_mail_operation_notify_end): Do not explicitely remove the
419 operation from the queue but only emit the progress_changed signal.
420 The queue itself listens to that signal to remove the operation when
421 it is finished. This reduces coupling and removes a potential deadlock
422 when modest_mail_operation_notify_end() is called from the queue
423 itself. If that is a problem performance-wise, I would suggest to
424 implement a status-changed signal or something.
426 * src/modest-mail-operation-queue.c: Make sure to never call a
427 function from another file while the queue is locked. This (hopefully)
428 fixes another deadlock when exiting the application while retrieving
431 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
433 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
434 Fixed build if libogs is not available
436 2007-06-03 Christian Kellner <ckellner@openismus.com>
438 * libmodest-dbus-client/libmodest-dbus-client.h:
439 * libmodest-dbus-client/libmodest-dbus-client.c:
440 (libmodest_dbus_client_delete_message):
441 Implement deletion of messages (Client side).
443 (modest_search_hit_free),
444 (modest_search_hit_list_free):
445 Utility functions to free the result hits.
447 * src/dbus_api/modest-dbus-api.h:
448 * src/dbus_api/modest-dbus-callbacks.c:
450 (modest_dbus_req_handler):
451 Implement deletion of messages (Server side).
453 * tests/dbus_api/test_search.c: (main):
456 * tests/dbus_api/Makefile.am:
457 * tests/dbus_api/test_delete_message:
458 Add little test for the message deletion logic
460 2007-06-03 Armin Burgmeier <armin@openismus.com>
462 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
463 when the operation queue was not empty. projects.maemo.org bug
466 2007-06-03 Armin Burgmeier <armin@openismus.com>
468 * src/widgets/modest-account-view.c
469 (on_account_default_toggled): Toggle default account column
470 explicitely instead of waiting for gconf notification (which is
471 currently ignored). This should fix projects.maemo.org bug NB#56910
472 for now. It should probably be removed when gconf notifications are
475 2007-06-03 Christian Kellner <ckellner@openismus.com>
477 * libmodest-dbus-client/libmodest-dbus-client.c:
478 Removed debugging spew.
480 * src/dbus_api/modest-dbus-callbacks.c:
481 Added debugging info.
483 * src/modest-search.c:
484 (modest_search_all_accounts):
485 Use tny_account_store_get_accounts () on the account store
486 to get all accounts which is the way to get all accounts.
488 * tests/dbus_api/test_search.c: (main):
489 Make it possible to supply the search term on the command line.
491 2007-06-03 Christian Kellner <ckellner@openismus.com>
493 * libmodest-dbus-client/libmodest-dbus-client.c:
494 * libmodest-dbus-client/libmodest-dbus-client.h:
495 Implement searching for mesages over raw dbus. (Client side)
497 * src/dbus_api/Makefile.am:
498 * src/dbus_api/modest-dbus-api.h:
499 * src/dbus_api/modest-dbus-callbacks.c:
500 * src/dbus_api/modest-dbus-callbacks.h:
501 Search framework (Server side). Also implement on_idle_open_message().
503 * src/maemo/modest-platform.c: (modest_platform_init):
504 Prepare for raw dbus/osso rpc interaction.
506 * src/modest-search.h:
507 Changed minsize from unspecific guint to guint32.
509 * src/modest-search.c:
511 Added strange hack which magically made tnymail work.
513 (modest_search_folder),
514 (modest_search_account),
515 (modest_search_all_accounts):
516 Implement helper functions to search all accounts, specific account
519 * tests/dbus_api/Makefile.am:
520 * tests/dbus_api/test_open_message.c:
521 Read url to open from commandline.
523 * tests/dbus_api/test_search.c:
524 Implement small test for dbus search stuff
526 2007-06-02 Armin Burgmeier <armin@openismus.com>
528 * src/maemo/modest-account-settings-dialog.c: Changed window title to
529 include account type and account title. This fixes projects.maemo.org
532 * src/maemo/modest-account-view-window.c: Set a title for the window.
534 2007-06-02 Armin Burgmeier <armin@openismus.com>
536 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
537 incoming and outgoing server name based on email address and server
538 types as long as the names have not been edited manually. This fixes
539 projects.maemo.org bug NB#58671.
541 2007-06-02 Armin Burgmeier <armin@openismus.com>
543 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
544 server type cannot be changed in future to the incoming details page
545 when creating an account. This fixes projects.maemo.org bug NB#59029.
547 2007-06-02 Armin Burgmeier <armin@openismus.com>
549 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
550 and assigned max width chars so that they wrap instead of being
551 truncated. Fixes projects.maemo.org bug NB#56126.
553 2007-06-02 Armin Burgmeier <armin@openismus.com>
555 * src/maemo/modest-connection-specific-smtp-window.c: Add an
556 introductory note to the connection specific smtp servers dialog, as
557 section 8.12 of the email UI specification requires. This fixes
558 projects.maemo.org bug NB#59212.
560 2007-06-01 Murray Cumming <murrayc@murrayc.com>
562 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
563 Check for running mail operations, and offer to cancel them, as per the UI
564 spec. This fixes projects.maemo.org bug NB#59041 .
565 However, I suspect that tinymail may still use the network connection
566 in ways that we cannot detect or cancel. But it should at least adapt to
569 2007-06-01 Murray Cumming <murrayc@murrayc.com>
571 * src/modest-tny-account-store.c: (recreate_all_accounts),
572 (get_cached_accounts), (get_server_accounts): Do more sensible
573 ref-counting of the temporarily-cached outbox accounts list. This seems
574 to fix a crash when entering the password when the password was wrong.
576 2007-06-01 Murray Cumming <murrayc@murrayc.com>
578 * src/gnome/modest-main-window.c: (connect_signals):
579 * src/modest-tny-account-store.c: (get_password),
580 (modest_tny_account_store_alert): Added comments and clues and
581 commented-out code about how we currently fail to deal with connection
582 errors and wrong passwords, and how we should.
584 2007-06-01 Murray Cumming <murrayc@murrayc.com>
586 * src/widgets/modest-retrieve-combo-box.c:
587 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
588 This fixes projects.maemo.org bug NB#58472 .
590 2007-06-01 Murray Cumming <murrayc@murrayc.com>
592 * src/maemo/easysetup/modest-easysetup-wizard.c:
593 (create_page_complete_easysetup):
594 (create_page_complete_custom): Correct the last commit,
595 putting the correct sentences in the correct pages.
597 2007-06-01 Murray Cumming <murrayc@murrayc.com>
599 * src/maemo/easysetup/modest-easysetup-wizard.c:
600 (create_page_complete_custom): Show the second sentence of text
601 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
604 2007-06-01 Murray Cumming <murrayc@murrayc.com>
606 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
607 Set the leave-on-server conf key by default. This fixes
608 projects.maemo.org bug NB#59258 .
610 2007-06-01 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/modest-account-view-window.c:
613 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
614 logical ID for the confirmation messages. Fixed projects.maemo.org bug
617 2007-06-01 Murray Cumming <murrayc@murrayc.com>
619 * src/maemo/easysetup/modest-easysetup-wizard.c:
620 (create_caption_new_with_asterisk):
621 * src/maemo/modest-account-settings-dialog.c:
622 (create_caption_new_with_asterisk):
623 Uncomment the code to add the asterisk, because they are no longer in the
624 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
625 (update_incoming_server_title): Add an asterisk here too.
627 2007-06-01 Murray Cumming <murrayc@murrayc.com>
629 * src/maemo/modest-maemo-global-settings-dialog.c:
630 (current_connection): Check that we are even connected before trying to
631 get the current connection name, to prevent a warning.
633 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
634 Change the comments because tny_maemo_conic_device_connect() is now meant to
636 * src/modest-mail-operation.c:
637 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
638 make sure we have a connection and fail if we can't connect.
640 2007-05-31 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/modest-main-window.c:
643 (on_account_store_connecting_finished): Do not try to get the
644 connection ID if we are not really connected. I am surprised that
645 this signal handler is called when we are not connected.
647 2007-05-31 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-error.h:
650 * src/modest-ui-actions.c:
651 (modest_ui_actions_get_msgs_full_error_handler):
652 Renamed an enum, added comments, added an enum
653 for retrieve-limit errors.
655 * src/modest-mail-operation.c: (foreach_add_item),
656 (internal_folder_observer_update), (update_account_thread),
657 (modest_mail_operation_get_msgs_full):
658 (modest_mail_operation_update_account),
659 Added comments about how this works, and some code that should
660 (but does not) check the retrieve-limit. See the TODO comment.
662 2007-05-31 Murray Cumming <murrayc@murrayc.com>
664 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
665 Initialize help_id to fix the build. Warnings are good.
667 2007-05-31 Murray Cumming <murrayc@murrayc.com>
669 * src/widgets/modest-hbox-cell-renderer.c:
670 (modest_hbox_cell_renderer_append):
671 * src/widgets/modest-vbox-cell-renderer.c:
672 (modest_vbox_cell_renderer_append):
673 Fix the last commit by doing an extra ref.
675 2007-05-31 Murray Cumming <murrayc@murrayc.com>
677 * src/widgets/modest-hbox-cell-renderer.c:
678 (modest_hbox_cell_renderer_append):
679 * src/widgets/modest-vbox-cell-renderer.c:
680 (modest_vbox_cell_renderer_append):
681 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
682 to fix the build with Maemo Bora.
683 However, there seems to be a remaining crash, probably due to reference
686 2007-05-30 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-tny-account.c:
689 (modest_tny_account_new_for_local_folders):
690 Use hildon_file_system_info_async_new() to get a better name for
691 the memory card account, setting it as the account name.
692 The timing seems to work, but this is probably
693 not the best place to do this. See the TODO comment.
694 * src/maemo/modest-main-window.c: (create_details_widget):
695 * src/widgets/modest-folder-view.c: (text_cell_data):
696 Use the tny account name instead of hardcoding a name.
698 2007-05-30 Christian Kellner <ckellner@openismus.com>
700 * src/modest-search.c: (modest_search):
701 Correctly set part_search_func even if we have already parsed
702 the query and thus a valid OgsTextSearcher object.
704 2007-05-30 Christian Kellner <ckellner@openismus.com>
707 Search and check for libogs.
710 Incooparte the ogs build env.
712 * src/modest-mime-part-search-stream.c:
713 * src/modest-mime-part-search-stream.h:
714 Removed since we do the real searching now in modest-search.c.
716 * src/modest-search.c:
717 * src/modest-search.h:
718 Implement support for ogs. We use that if available and requested
719 and fall back to modest_text_utils_utf8_strcmp (). The search logic
720 should now handle the corner case when the search term is spread
721 across multiple reads.
722 Also the logic in modest_search () was corrected to search all
723 requested fields until one is found.
725 2007-05-30 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
730 * src/modest-init.c: Made modest_init_local_folders() take a
731 path and be public so we can iniitialize maildir folders on
734 * src/modest-local-folder-info.h:
735 * src/modest-local-folder-info.c:
736 (modest_local_folder_info_get_maildir_path): Add a path parameter.
738 * src/modest-tny-account.c:
739 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
740 still means the standard local-folders path on the local volume.
742 * src/modest-tny-account-store.c:
743 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
744 signal so we can detect mount/unmount of the MMC1 card, and do an update of
745 all accounts when that happens.
746 (get_server_accounts): If the MMC1 card is mounted, create a store account for
747 this too, so it shows up in the treeview.
749 2007-05-28 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-maemo-global-settings-dialog.c:
752 (current_connection):
753 * src/widgets/modest-global-settings-dialog.c:
754 (current_connection_default):
755 Use the enum values instead of 0, 1 and -1,
756 to make the code clearer.
758 * src/modest-account-mgr-helpers.c:
759 (modest_account_mgr_get_connection_specific_smtp): Make this code
762 * src/modest-runtime.h:
763 * src/modest-runtime.c:
764 Added modest_runtime_remove_all_send_queues().
765 * src/maemo/modest-main-window.c:
766 (on_account_store_connecting_finished): Recreate the send queues,
767 using the appropriate transport accounts for this new connection.
768 Some futher adapting might be needed if the old send queues are not
769 automatically stopped at this point.
771 * src/modest-tny-account-store.c: (get_server_accounts):
772 Create the connection-specific transport accounts, so that they can
773 be found later by their ID.
775 * src/modest-tny-account.h:
776 * src/modest-tny-account.c:
777 Added modest_tny_account_new_from_server_account_name().
778 modest_tny_account_new_from_server_account(): Do not create the
779 send queues here, because they will be
780 recreated anyway when the connection changes for the first time.
782 2007-05-28 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-local-folder-info.h:
785 * src/modest-local-folder-info.c:
786 (modest_per_account_local_outbox_folder_info_get_maildir_path),
787 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
788 tbox_folder): Take a modest account name instead of a server TnyAccount,
789 so we can have per-modest-account rather than per-transport-account
791 We must make sure that we change or recreate the exisitng send queues
792 when the connection changes for connection-specific transport accounts.
794 * src/modest-tny-account-store.c:
795 (create_per_account_local_outbox_folders): Create outboxed per modest
796 account, not per transport account.
798 * src/modest-tny-account.h:
799 * src/modest-tny-account.c:
800 (modest_tny_account_get_special_folder): For outboxes, get the
801 parent modest account name. The account is ignored for other folders.
802 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
803 modest account name rather than a server TnyAccount.
805 2007-05-25 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-tny-account.c:
808 (modest_tny_account_new_from_server_account):
809 Call modest_runtime_get_send_queue() immediately after creating transport
810 accounts, so that they start trying to send email from the outbox as soon
811 as possible at startup. This is probably what we want.
813 * src/modest-mail-operation.c: (update_account_thread):
814 * src/modest-runtime.c: (modest_runtime_get_send_queue):
815 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
816 * src/modest-tny-send-queue.h:
817 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
818 (modest_ui_actions_on_send):
819 Added comments about how sending works, though it needs some more work.
821 2007-05-25 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account.c:
824 (modest_tny_account_get_special_folder): Add TODO because this fails when
826 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
827 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
828 Do not try to show this window when there is no active account. The UI
829 specs does not tell us what to do in this case.
831 2007-05-24 Murray Cumming <murrayc@murrayc.com>
835 * src/maemo/Makefile.am:
836 * src/widgets/Makefile.am: Some dist fixes.
838 2007-05-24 Murray Cumming <murrayc@murrayc.com>
840 * src/maemo/modest-connection-specific-smtp-window.c:
841 (on_button_edit): Make the code clearer, to prevent a double free.
843 2007-05-24 Murray Cumming <murrayc@murrayc.com>
845 * src/maemo/modest-account-settings-dialog.c:
846 (modest_account_settings_dialog_set_account_name),
847 Check the connection-specific smtp servers checkbox if there are any.
849 * src/maemo/modest-connection-specific-smtp-edit-window.c:
850 (modest_connection_specific_smtp_edit_window_init):
851 Start with a suitable port number.
853 * src/modest-account-mgr-helpers.h:
854 * src/modest-account-mgr-helpers.c: Added
855 modest_account_mgr_get_has_connection_specific_smtp().
857 (modest_account_mgr_set_connection_specific_smtp),
858 (modest_account_mgr_remove_connection_specific_smtp),
859 (modest_account_mgr_get_has_connection_specific_smtp),
860 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
861 connection-specific smtp server accounts in the account, rather than
862 the server account conf dir.
864 This fixes bug projects.maemo.org bug NB#58263 .
866 * src/modest-tny-account-store.c:
867 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
868 if there are no server accounts yet, to prevent an infinite loop when there
869 are no accounts. Document that one must be called before the other.
871 2007-05-24 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-account-mgr-helpers.c:
874 (modest_account_mgr_get_default_account): Make sure that at least
875 one account is always the default, if there are any enabled accounts.
876 This is just a sanity check that shouldn't be necessary.
878 * src/modest-account-mgr-priv.c:
879 (_modest_account_mgr_account_from_key): Unescape the conf key to
880 get the real account name. For instance, this is an issue if a space
881 was in the account name, which can happen because the account name
882 is generated from the display name.
883 (_modest_account_mgr_get_account_keyname): Always escape the
885 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
886 Unescape the conf keys to get the real account names.
888 For instance, previously the is-default radio button in the accounts
889 list was not checked for any accounts at first. This fixes that,
890 and might fix several similar bugs.
892 2007-05-23 Murray Cumming <murrayc@murrayc.com>
894 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
895 Removed some debug printfs.
897 2007-05-23 Murray Cumming <murrayc@murrayc.com>
899 Modest on-disk outbox directories are now here, for instance:
900 $HOME/.modest/outboxes/<account-id-1>/outbox
901 $HOME/.modest/outboxes/<account-id-2>/outbox
903 $HOME/.modest/local-folders/outbox
904 so we can have a separate outbox for each account.
905 But they are shown as one outbox in the GtkTreeView, by using a
906 TnyMergeFolder in a ModestTnySimpleFolderStore.
909 * src/modest-tny-simple-folder-store.c:
910 * src/modest-tny-simple-folder-store.h:
911 Added ModestTnySimpleFolderStore, used to contain folders from
912 other folder stores, such as other accounts.
914 * src/modest-tny-outbox-account.h:
915 * src/modest-tny-outbox-account.c:
916 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
917 used for the per-account local outbox folders.
919 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
920 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
921 only use this (internally) now for the non-outbox local folders.
924 * src/modest-init.c: Added modest_init_one_local_folder(), for
925 setting up the directory structure for each local folder.
927 * src/modest-local-folder-info.c:
928 (modest_per_account_local_outbox_folder_info_get_maildir_path),
929 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
931 * src/modest-local-folder-info.h:
932 * src/modest-tny-account-store.c: (on_account_removed),
933 (on_account_changed), (create_per_account_local_outbox_folders),
934 (get_server_accounts), (modest_tny_account_store_get_accounts),
935 (modest_tny_account_store_get_tny_account_by_account),
936 (modest_tny_folder_store_is_virtual_local_folders):
938 * src/modest-tny-account.h:
939 * src/modest-tny-account.c:
940 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
941 to create an on-disk per-account local outbox folder for each
943 (create_per_account_local_outbox_folders): Create a local outbox folder
944 for each transport account.
945 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
946 for all local folders.
948 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
949 instead of using g_object_get/set() directly. It is clearer.
951 (modest_tny_folder_store_get_message_count),
952 (modest_tny_folder_store_get_local_size
953 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
954 because we now use these with non-acount folder stores.
956 (modest_tny_account_get_special_folder),
957 (modest_tny_account_new_from_server_account),
958 (modest_tny_account_new_from_account):
959 (recurse_folders): Adjust to the new outbox system.
961 * src/modest-tny-folder.h:
962 * src/modest-tny-folder.c:
963 (modest_tny_folder_is_local_folder),
964 (modest_tny_folder_get_local_folder_type),
965 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
967 * src/widgets/modest-main-window.h:
968 * src/maemo/modest-main-window.c: (create_details_widget),
969 (modest_main_window_set_contents_style): Show details for any folder store,
972 (modest_tny_folder_get_rules):
973 Remove the const. C does not support constness enough for this.
975 * src/modest-ui-actions.c:
976 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
977 make all outboxes appear as one, in the usual local-folders tree node.
979 (set_active_account_from_tny_account),
980 (modest_ui_actions_on_folder_selection_changed):
981 * src/widgets/modest-folder-view.c: (text_cell_data),
982 (icon_cell_data), (filter_row),
983 (add_account_folders_to_merged_folder),
984 (add_account_folders_to_simple_folder_store), (),
985 (get_cmp_rows_type_pos), (cmp_rows),
986 (modest_folder_view_set_account_id_of_visible_server_account):
987 Adjust to the new outbox system, using generic folder stores and folders
990 2007-05-23 Christian Kellner <ckellner@openismus.com>
992 * src/modest-mail-operation.c:
993 (modest_mail_operation_update_account):
994 Use info->max_size instead of unintialized local var [small
995 build fix]. (Added TODO to review that change since I don't
998 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1000 * libmodest-dbus-client/libmodest-dbus-client.c:
1001 (libmodest_dbus_client_compose_mail): function added
1002 * src/dbus_api/modest-dbus-api.h:
1003 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1004 (on_compose_mail): Implementation of the SendAsMail functionality
1006 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-account-mgr.c:
1009 (modest_account_mgr_add_server_account): Set the secure-connection
1010 conf key for transport accounts as well as store accounts. I don't know
1011 why the if was there. For instance, this makes sure that we use SSL
1012 for the gmail preset from the easysetup wizard.
1014 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1016 * src/gnome/modest-main-window.c:
1017 (on_account_store_connecting_finished), (connect_signals):
1018 * src/maemo/modest-main-window.c:
1019 (on_account_store_connecting_finished), (connect_signals),
1020 (modest_main_window_new):
1021 Handle TnyAccountStore::connecting-finished instead of
1022 TnyDevice::connection-changed, because we cannot actually perform
1023 operations on accounts until TnyAccountStore has itself responded to
1024 the TnyDevice::connection-changed signal. This prevents a GError from
1026 Do not try to update at startup, because we (at least on scratchbox)
1027 already do an update at startup when the device goes online.
1028 This prevents a GError from tinymail.
1029 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1030 Added TODO about stopping simultaneous operations.
1032 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1035 * src/modest-mail-operation-queue.c:
1036 (modest_mail_operation_queue_remove):
1037 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1038 about where they happened.
1040 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-ui-actions.c:
1043 (modest_ui_actions_on_password_requested): Make sure that the remember
1044 output parameter is always TRUE.
1046 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1048 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1049 Show a OK/Cancel dialog if the error is a question, though we still do not
1050 know anything more about what we are asking the user.
1051 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1052 Fix an uninitialized variable (helper). This is a logic error, however.
1054 2007-05-21 Christian Kellner <ckellner@openismus.com>
1056 * src/modest-search.h:
1057 Correct bit shifting in the ModestSearchFlags enum.
1059 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-tny-account.c:
1062 (modest_tny_account_new_from_server_account): Do not use the lsub and
1063 check-all hard-coded IMAP options when using POP.
1065 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-tny-account.c:
1068 (modest_tny_account_new_from_server_account):
1069 Use NULL for the secure-auth method for POP when Password auth has been
1070 specified by the user, as we already do for IMAP. "auth=Login" causes
1071 an error from camel or the server.
1073 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1075 * src/maemo/modest-account-settings-dialog.c:
1076 (create_page_account_details),
1077 (modest_account_settings_dialog_set_account_name):
1078 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1079 for the leave-on-server checkbox, rathr than just the checkbox, when
1080 the protocol is not POP.
1082 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1084 * src/widgets/modest-account-view.c:
1085 * src/widgets/modest-account-view.h:
1086 Added modest_account_view_select_account() which will be useful later
1087 to asynchronously re-select the edited account.
1089 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/modest-account-settings-dialog.c:
1092 (modest_account_settings_dialog_set_account_name):
1093 Automatically choose the port numbers based on the secure authentication
1094 methods, if they have not been chosen before.
1095 This fixes projects.maemo.org bug NB#56273 .
1097 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/modest-main-window-ui.h:
1100 * src/modest-ui-actions.c:
1101 * src/modest-ui-actions.h:
1102 Connect the Tools/SMTP Servers menu item to
1103 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1104 SMTP servers dialog, as in the UI specification and saves changes when it
1105 is closed. This fixed projects.maemo.org bug NB#56305 .
1107 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1109 * src/maemo/modest-connection-specific-smtp-window.c:
1110 (modest_connection_specific_smtp_window_init):
1111 Use gtk_window_set_default_size() to make this window big enough, so
1112 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1114 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1116 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1117 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1118 (modest_connection_specific_smtp_edit_window_init),
1119 Do not try to connect to a combobox signal before the combobox exists.
1120 This fixes the cras in projects.maemo.org bug NB#56288 .
1121 (modest_connection_specific_smtp_edit_window_get_settings):
1122 Remove the server_account_name parameter which was being checked for NULL
1123 though it was not used.
1125 * src/maemo/modest-connection-specific-smtp-window.c:
1126 (modest_connection_specific_smtp_window_fill_with_connections),
1127 (on_button_edit), (modest_connection_specific_smtp_window_init):
1128 Correct the number of treemodel columns to prevent a warning.
1129 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1130 libconic does not work.
1132 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-tny-account.c:
1135 (modest_tny_account_new_from_server_account):
1136 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1137 SMTP when "None" was chosen by the user. However, with my SMTP server that
1138 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1141 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1143 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1144 to explain the memory management issue with the ID in the ModestPair.
1146 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1147 (add_sending_page), (modest_account_assistant_finalize):
1148 * src/gnome/modest-gnome-global-settings-dialog.c:
1149 (create_updating_page), (create_composing_page):
1150 * src/gnome/modest-msg-edit-window.c: (get_transports),
1151 (init_window), (modest_msg_edit_window_finalize),
1152 (modest_msg_edit_window_get_msg_data):
1153 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1154 * src/gnome/modest-transport-widget.c:
1155 (modest_transport_widget_finalize), (smtp_configuration):
1156 * src/maemo/modest-maemo-global-settings-dialog.c:
1157 (create_updating_page), (create_composing_page):
1158 * src/maemo/modest-msg-edit-window.c: (get_transports),
1159 (init_window), (modest_msg_edit_window_finalize),
1160 (modest_msg_edit_window_get_msg_data),
1161 (modest_msg_edit_window_free_msg_data):
1162 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1163 (modest_store_widget_finalize):
1164 * src/maemo/modest-transport-widget.c:
1165 (modest_transport_widget_finalize), (smtp_configuration):
1166 * src/modest-main.c: (send_mail):
1167 * src/widgets/modest-combo-box.h:
1168 * src/widgets/modest-global-settings-dialog-priv.h:
1169 * src/widgets/modest-global-settings-dialog.c:
1170 (modest_global_settings_dialog_finalize):
1171 * src/widgets/modest-msg-edit-window.h:
1172 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1173 as long as the combo box, to prevent use of freed memory for the ID.
1175 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1178 get_accounts(), to make this clearer. Do not check for the enabled gconf
1179 key, because we do not use this for server accounts (at least, not yet).
1180 This allows us to send email again.
1182 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1184 * src/maemo/modest-platform.c:
1185 (on_modest_conf_update_interval_changed), (modest_platform_init):
1186 Only respond to this particular key change. All these strcmp()s cannot be
1189 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1191 * src/maemo/modest-maemo-global-settings-dialog.c:
1192 (current_connection): Prevent a crash in scratchbox when
1193 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1194 * src/maemo/modest-platform.c:
1195 (on_modest_conf_update_interval_changed), (modest_platform_init):
1196 Get the update interval from gconf and reset it when the gconf key changes.
1198 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1200 * src/modest-protocol-info.c:
1201 * src/modest-protocol-info.h: Adde enum-specific get functions,
1202 instead of using a ModestProtocolType enum parameter.
1204 * src/gnome/modest-account-assistant.c:
1205 * src/gnome/modest-store-widget.c:
1206 * src/gnome/modest-store-widget.h:
1207 * src/gnome/modest-transport-widget.c:
1208 * src/gnome/modest-transport-widget.h:
1209 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1210 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1211 * src/maemo/easysetup/modest-easysetup-wizard.c:
1212 * src/maemo/modest-account-settings-dialog.c:
1213 * src/maemo/modest-account-settings-dialog.h:
1214 * src/maemo/modest-store-widget.c:
1215 * src/maemo/modest-store-widget.h:
1216 * src/maemo/modest-transport-widget.c:
1217 * src/maemo/modest-transport-widget.h:
1218 * src/modest-account-mgr-helpers.c:
1219 * src/modest-account-mgr-helpers.h:
1220 * src/modest-account-mgr.c:
1221 * src/modest-account-mgr.h:
1222 * src/modest-tny-account.c:
1223 * src/modest-tny-folder.c:
1224 * src/widgets/modest-account-view.c:
1225 * src/widgets/modest-retrieve-combo-box.c:
1226 * src/widgets/modest-retrieve-combo-box.h:
1227 * src/widgets/modest-secureauth-combo-box.c:
1228 * src/widgets/modest-serversecurity-combo-box.c:
1229 * src/widgets/modest-serversecurity-combo-box.h:
1230 * tests/check_account-mgr.c:
1231 Use the specific functions, and use the re-renamed enum values for GNOME too.
1233 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-pair.h:
1236 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1237 so we can get the second based on the first.
1239 * src/maemo/modest-account-settings-dialog.h:
1240 * src/maemo/modest-account-settings-dialog.c:
1241 Added get_supported_secure_authentication_methods(), though it is mostly
1242 commented-out for now until the necessary API is committed to tinymail.
1243 (modest_account_settings_dialog_set_account_name),
1244 (save_configuration): Request the supported authentication methods from the
1245 server, so we can choose a working method.
1247 * src/modest-tny-account-store.h:
1248 * src/modest-tny-account-store.c:
1249 (modest_tny_account_store_get_session): Rename from
1250 tny_account_store_get_session().
1252 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-protocol-info.h: Split the ModestProtocol enum
1255 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1256 There was no need to have these unrelated values in one enum.
1258 * src/: many files: Adapted to changed enum. This makes the code a bit
1259 clearer, and the compiler could catch some errors.
1261 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1263 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1264 Show the detailed internal camel error message when an error happens
1265 during the configuration, so that our testers can give us more clues.
1266 For instance, in projects.maemo.org bug NB#56910 .
1268 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1270 * src/modest-tny-account.c:
1271 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1272 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1274 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1276 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1277 * src/maemo/modest-account-settings-dialog.c:
1278 (modest_account_settings_dialog_set_account_name),
1279 (save_configuration): For the incoming secure authentication checkbox,
1280 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1281 the UI specification. PLAIN does not seem to be supported for most IMAP
1282 servers anyway, and I am not sure what it would mean.
1283 However, we probably need to discover which of the secure-authentication
1284 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1285 * src/modest-account-mgr-helpers.c:
1286 (modest_account_mgr_get_server_account_data):
1288 * src/modest-tny-account.c:
1289 (modest_tny_account_new_from_server_account):
1290 Use tny_account_set_mech() to set secure-authentication methods,
1291 with some special-casing for IMAP, based on my observations of how
1294 * src/modest-account-mgr-helpers.h:
1295 * src/modest-account-mgr.c:
1296 * src/modest-defs.h: Comment that the URI is only used for local folders.
1298 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1300 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1301 parameter const, just to be neat.
1302 * src/modest-text-utils.c: (modest_text_utils_inline):
1303 End g_strconcat() with NULL, as its documentation says. This is almost
1304 certainly the cause of my crash at startup on the device. Interestingly,
1305 valgrind doesn't tell us about these errors.
1307 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1309 * scripts/build-packages: Added more precise comments about how to use
1310 this script, though I still get this error:
1311 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1312 error building tinymail
1314 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/modest-main-window.c: (on_account_update):
1317 Very slight cleanup, hoping to make it simpler to discover what causes
1318 a crash here sometimes.
1320 * src/modest-tny-account.c:
1321 (modest_tny_account_new_from_server_account): Set the port. Added
1322 comments about the options and a TODO comment because I need to find out
1323 how to specify the secure authentication method.
1325 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1327 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1328 changed CFlags paths form modest to libmodest
1330 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1332 * src/modest-account-mgr-helpers.c:
1333 (modest_account_mgr_get_server_account_data),
1334 (modest_account_mgr_free_server_account_data):
1335 * src/modest-account-mgr-helpers.h:
1336 * src/modest-account-mgr.c:
1337 (modest_account_mgr_add_server_account):
1338 * src/modest-defs.h:
1339 * src/modest-tny-account.c:
1340 (modest_tny_account_new_from_server_account):
1341 Determine the options for tny_camel_account_add_option() here,
1342 based on the settings, rather than storing them directly in gconf.
1344 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1347 Show a more friendly error dialog now that we expect (from the tinymail
1348 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1350 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/modest-main-window.c: (on_account_update): Check that
1353 account_name is not NULL, to prevent a crash at startup that I am
1354 seeing on the N800. I do wonder why it is NULL.
1356 * src/maemo/easysetup/modest-easysetup-wizard.c:
1357 (create_page_user_details):
1358 * src/maemo/modest-account-settings-dialog.c:
1359 (create_page_user_details), (create_page_outgoing):
1360 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1361 (modest_connection_specific_smtp_edit_window_init):
1362 * src/modest-ui-actions.c:
1363 (modest_ui_actions_on_password_requested):
1364 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1365 might do something useful with the on-screen keyboard.
1367 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/modest-main-window.c: (on_account_update):
1370 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1371 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1373 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1375 * src/modest-tny-account-store.c: (on_account_changed):
1376 Correct the signature of this signal handler.
1378 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1381 Show a HildonNote instead of a GtkDialog for Maemo.
1383 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1385 * src/widgets/modest-account-view.h:
1386 * src/widgets/modest-account-view.c: (on_account_changed),
1387 (on_account_removed). Added a boolean flag, set/unset by
1388 modest_account_view_block_conf_updates(),
1389 modest_account_view_unblock_conf_updates() to prevent unnecessary
1390 updates, but this is not very useful because the gconf notifications are
1391 so delays (maybe only on Maemo Bora).
1392 So auto-updating is turned off, and these functions do an explicit
1393 update when necessary.
1394 However, something else is still doing too much work when adding/removing
1395 accounts, probably in another part of the application.
1397 * src/maemo/modest-account-view-window.c:
1398 (on_delete_button_clicked), (on_edit_button_clicked),
1399 (on_new_button_clicked): Use the new functions.
1401 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-account-mgr-helpers.c:
1404 (modest_account_mgr_set_first_account_as_default):
1405 Sort the list of names alphabetically-by-title, so we choose the first one
1407 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1408 alphabetically by the title.
1410 This fixes projects.maemo.org bug NB#56418 .
1412 * src/modest-account-mgr-priv.c:
1413 (_modest_account_mgr_account_from_key):
1414 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1415 avoid a valgrind error, and possible random behaviour.
1417 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1419 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1420 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1421 tinymail documentation to say that this can be expected.
1422 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1423 pretty, and should not happen, but I would prefer to know when it does.
1425 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1427 * configure.ac: When using the older hildon version, probably on Bora,
1428 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1430 * src/widgets/modest-attachment-view.c:
1431 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1434 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1436 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1437 Implemented the prototype. Can be tested with
1438 tests/dbus_api/test_open_message:
1440 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-tny-account-store.c:
1443 (modest_tny_account_store_instance_init), (get_password):
1444 * src/modest-ui-actions.c:
1445 (modest_ui_actions_on_password_requested):
1446 Do not store the password in gconf, because this function is called
1447 for non-remembered passwords. Actually use the cached (in the hash map)
1448 password instead of releasing it.
1449 The password will now not be remembered if it is asked via the protected
1450 password dialog, as per the UI spec.
1452 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-defs.h:
1455 * src/modest-account-mgr-helpers.h:
1456 * src/modest-account-mgr-helpers.c:
1457 Added modest_server_account_get_username_has_succeeded(),
1458 modest_server_account_set_username_has_succeeded().
1459 (modest_server_account_set_username),
1460 Reset the has-succeeded flag if the username changes.
1462 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1463 * src/maemo/modest-connection-specific-smtp-window.c:
1464 (modest_connection_specific_smtp_window_save_server_accounts):
1465 Use modest_server_account_set_username() instead of using
1466 modest_conf_set_string() directly, so that the has-succeeded flag is always
1469 * src/modest-ui-actions.c:
1470 (modest_ui_actions_on_password_requested): Dim the username entry if
1471 the username has ever worked, as per the UI spec.
1473 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-tny-account-store.c: (get_password):
1476 * src/modest-ui-actions.c:
1477 (modest_ui_actions_on_password_requested):
1478 Allow the username to be changed too, though there is more work to
1479 be done on exactly how this behaves.
1481 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1483 * src/modest-account-mgr-helpers.h:
1484 * src/modest-account-mgr-helpers.c:
1485 Added modest_account_mgr_get_display_name(),
1486 modest_server_account_get_username(),
1487 modest_server_account_set_username(),
1488 modest_server_account_set_password(),
1489 modest_server_account_get_hostname() functions so we do not need to
1490 use the conf API directly.
1492 * src/maemo/modest-main-window.c: (connect_signals):
1493 Actually connect ot the ModestAccountStore::request-password signal,
1494 so that we show the dialog when the password is requested by Tinymail,
1495 for isntance if it is empty.
1497 * src/modest-marshal.list:
1498 * src/modest-tny-account-store.c:
1499 (modest_tny_account_store_class_init), (get_password),
1500 (modest_tny_account_store_alert):
1501 * src/modest-tny-account-store.h:
1502 * src/modest-ui-actions.h:
1503 * src/modest-ui-actions.c:
1504 (modest_ui_actions_on_password_requested):
1505 Change the signal parameters, so it is obvious that we are providing
1506 the non human-readable server name, and receiving both the username
1507 and password, though changing of the username is not yet implemented.
1508 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1509 for the GNOME version.
1511 This should fix the projects.maemo.org bug NB#56209, though it does not
1512 work on Bora, because the gconf_client_get() for the password fails
1513 immediately after we save it with gconf_client_set().
1515 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1518 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1519 caused an undefined symbol error:
1520 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1522 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1524 * src/modest-tny-account-store.c:
1525 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1526 using a GError instead of a string message, so we can translate it in
1529 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1531 * src/maemo/modest-address-book.c:
1532 (modest_address_book_check_names):
1533 * src/maemo/modest-msg-view-window.c:
1534 (modest_msg_view_window_clipboard_owner_change):
1535 * src/modest-init.c: (modest_init_init_ui):
1536 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1537 (update_folders_cb), (modest_mail_operation_update_account):
1538 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1539 (modest_ui_actions_on_msg_attachment_clicked),
1540 (modest_ui_actions_on_msg_recpt_activated):
1541 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1542 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1543 (modest_msg_view_search_next):
1544 * src/widgets/modest-recpt-editor.c:
1545 (modest_recpt_editor_on_button_release_event),
1546 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1547 g_message(). At this point we should only be seeing interesting errors on
1548 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1550 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1552 (modest_wizard_dialog_force_title_update):
1553 * src/maemo/easysetup/modest-wizard-dialog.h:
1554 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1555 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1556 can update the title when appropriate. Otherwise the title is wrong if the
1557 pages are added after adding the notebook to the dialog.
1558 This must be a problem in HildonWizardDialog too.
1559 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1561 * src/maemo/easysetup/modest-easysetup-wizard.c:
1562 (create_subsequent_customsetup_pages),
1563 (create_subsequent_easysetup_pages):
1564 Call modest_wizard_dialog_force_title_update() so that the title is
1565 correct even with GTK+ < 2.10.
1566 This fixes projects.maemo.org bug NB#56145 .
1568 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/modest-platform.c:
1571 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1572 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1575 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1577 * src/widgets/modest-window.h:
1578 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1579 and modest_window_save_state(), which invokes it.
1581 * src/widgets/modest-window-mgr.h:
1582 * src/widgets/modest-window-mgr.c:
1583 Added modest_window_mgr_save_state_for_all_windows(), which calls
1584 the save_state vfunc on all registered windows, if implemented.
1586 * src/gnome/modest-msg-edit-window.c:
1587 * src/gnome/modest-msg-view-window.c:
1588 * src/maemo/modest-msg-edit-window.c:
1589 * src/maemo/modest-msg-view-window.c:
1590 * src/maemo/modest-main-window.c:
1591 Specify the existing save_settings functions as implementations of
1592 ModestWindow::save_state_func().
1594 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1595 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1596 enabling hibernation, for instance.
1598 We may need to do the same thing for restoring settings.
1601 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1603 * src/widgets/modest-window-mgr.c:
1604 * src/widgets/modest-window-mgr.h:
1605 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1606 modest_window_mgr_get_hibernation_is_prevented().
1608 * src/maemo/modest-main-window.c:
1609 (on_hildon_program_is_topmost_notify): Prevent hibernation
1610 (possible when the application goes to the background in the WM),
1611 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1613 * src/maemo/easysetup/modest-easysetup-wizard.c:
1614 (modest_easysetup_wizard_dialog_init):
1615 * src/maemo/modest-account-settings-dialog.c:
1616 (modest_account_settings_dialog_init):
1617 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1618 (modest_connection_specific_smtp_edit_window_init):
1619 * src/maemo/modest-connection-specific-smtp-window.c:
1620 (modest_connection_specific_smtp_window_init):
1621 * src/maemo/modest-signature-editor-dialog.c:
1622 (modest_signature_editor_dialog_init):
1623 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1624 prevent hibernation while any of these account settings dialogs are open.
1626 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1628 * src/maemo/Makefile.am:
1629 * src/maemo/modest-osso-state-saving.c:
1630 * src/maemo/modest-osso-state-saving.h: Added
1631 modest_osso_load_state() and modest_osso_save_state() though they do
1632 nothing now. They should iterate through all the open windows and load/save
1634 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1635 save state when closing.
1637 * src/maemo/modest-main-window.c:
1638 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1639 Add a notification handler for the HildonProgram::is-topmost property,
1640 so we can allow hibernation when the application goes into the background.
1641 But we still need to detect when the accounts setup windows are open so
1642 we can stop hibernation when they are open.
1643 To do this, I also added the main window the HildonProgram. This might have
1644 other side-effects/benefits, and should maybe be done for other windows.
1646 * src/maemo/modest-osso-autosave-callbacks.h:
1647 * src/maemo/modest-osso-autosave-callbacks.c:
1648 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1649 though it does not do anything yet, and we might never need this to do
1650 anything. For instance, we already save drafts.
1652 * src/maemo/modest-platform.c: (modest_platform_init):
1653 Specify the libosso auto-save callback.
1655 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1657 * src/maemo/modest-platform.c:
1658 (modest_platform_set_update_interval):
1659 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1660 aparently stays valid between application instances, so we can use this
1661 to remove and reset it later. According to a maemo-developers email from
1664 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1666 * configure.ac: Depend on libalarm for Maemo.
1668 * src/dbus_api/modest-dbus-api.h:
1669 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1670 (on_send_receive), (modest_dbus_req_handler):
1671 Handle a SEND_RECEIVE D-Bus method.
1673 * libmodest-dbus-client/libmodest-dbus-client.c:
1674 (libmodest_dbus_client_send_and_receive):
1675 * libmodest-dbus-client/libmodest-dbus-client.h:
1676 Add C convenience functions for calling the new D-Bus method.
1678 * src/modest-platform.h:
1679 * src/gnome/modest-platform.c:
1680 * src/maemo/modest-platform.c:
1681 Added modest_platform_set_update_interval(), which uses the
1682 alarmd API on Maemo.
1683 (modest_platform_init),
1684 Call modest_platform_set_update_interval(), using a hard-coded
1685 interval for now (until the global settings dialog is implemented),
1686 though I am not sure that this makes sense yet.
1688 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1690 * src/dbus_api/modest-dbus-callbacks.c:
1691 (modest_osso_cb_hw_state_handler):
1692 * src/dbus_api/modest-dbus-callbacks.h:
1693 * src/maemo/modest-platform.c: (modest_platform_init):
1694 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1695 in case this has some effect on the ability for Maemo to ping the
1698 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1701 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1702 warning. It is probably a logic error, but I need to fix the build.
1704 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1706 * src/modest-account-mgr.h:
1707 * src/modest-account-mgr.c:
1708 (modest_account_mgr_account_names): Add a gboolean enabled_only
1709 parameter, so we can get lists of onlt the enabled accounts.
1711 (modest_account_mgr_add_account),,
1712 (modest_account_mgr_account_with_display_name_exists):
1713 * src/maemo/modest-msg-edit-window.c: (get_transports):
1714 * src/modest-account-mgr-helpers.c:
1715 (modest_account_mgr_set_first_account_as_default):
1716 * src/modest-init.c: (init_default_account_maybe):
1717 * src/modest-tny-account-store.c: (get_accounts):
1718 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1719 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1720 * tests/check_account-mgr.c: (START_TEST):
1721 Provide the extra parameter, as appropriate.
1723 * src/widgets/modest-account-view.c: (update_account_view):
1724 Do not show disabled accounts (meaning that there is no way to
1725 enable/disable accounts in the UI (the feature is not in our UI
1726 specification), so we can use this internally only to mark unfinished
1727 or temporary account data.
1729 * src/maemo/easysetup/modest-easysetup-wizard.c:
1730 (create_account): Add boolean enable parameter, so we can specify FALSE
1731 to create the temporary account.
1732 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1733 (on_before_next): When finishing, when there is a temporary account, just
1735 Also, use a timeout to delay the showing of the dialog until gconf is likely
1736 to return correct information, due to a maemo gconf bug that is fixed in
1737 osso 1.1, but not yet in Bora.
1738 However, the dialog stays on screen after it is destroyed.
1740 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1741 for invalid data when cancelling. Use a hildon note instead of a dialog
1742 to complain about invalid data. Do not show the account-saved note if the
1743 account is disabled (a temporary account that will not really be saved for use
1746 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-account-mgr-helpers.h:
1749 * src/modest-account-mgr-helpers.c:
1750 Added modest_account_mgr_unset_default_account(),
1751 Added modest_account_mgr_set_first_account_as_default().
1753 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1754 If it was the default account, unset the default account name.
1756 * src/maemo/modest-account-view-window.c:
1757 (on_delete_button_clicked): If it was the default account,
1758 set the first remaining account as the default instead.
1760 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1761 a NULL account or a NULL default account, to prevent a crash. This should
1762 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1765 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1767 * src/widgets/modest-recpt-editor.c:
1768 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1769 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1770 TODO comment for this. This fixes the build.
1772 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1773 be the best place for it. This will in future update all auto-update accounts,
1774 rather than just the current/default account, when that gconf key exists.
1775 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1776 if there are no accounts, before calling do_send_receive().
1777 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1779 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1780 * src/maemo/modest-main-window-ui.h:
1781 * src/maemo/modest-main-window.c: (on_connection_changed),
1782 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1783 directly, becaue the signal handler does more.
1785 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-account-mgr-helpers.c:
1788 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1789 for the case that the account does not exist.
1791 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1792 (equivalent to the modest account name) rather than the tinymail account name
1793 (equivalent to the modest account title - human readable) to get the account data.
1794 Check for null account data to prevent the crash, and add a TODO comment saying that
1795 this needs fixing because it is using the server account name instead of the account name.
1797 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1800 * src/maemo/modest-account-settings-dialog.c: (show_error),
1802 Use hildon_note_new_information() for informative and error messages,
1803 which seems to be expected for Maemo applications (no documentation that I know of
1804 says this). I am surprised that there is no distinction between info and error
1807 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1809 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1810 it is easy to find where this is used.
1812 * src/maemo/easysetup/modest-easysetup-wizard.c:
1813 (create_page_welcome), (create_page_account_details),
1814 (create_page_user_details), (create_page_complete_easysetup),
1815 (create_page_custom_incoming), (create_page_custom_outgoing),
1816 (create_page_complete_custom):
1817 * src/maemo/modest-account-settings-dialog.c:
1818 (create_page_account_details), (create_page_user_details),
1819 (create_page_incoming), (create_page_outgoing):
1820 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1822 (modest_connection_specific_smtp_edit_window_init):
1823 * src/maemo/modest-connection-specific-smtp-window.c:
1824 (modest_connection_specific_smtp_window_init):
1825 * src/maemo/modest-signature-editor-dialog.c:
1826 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1827 and scrolling policy as per the Email Application Layout Guide, if I have
1830 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1833 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1834 which were empty, because these vfuncs have been removed from TnyAccountStore.
1835 This fixes the build.
1837 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1839 * src/maemo/modest-main-window.c:
1840 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1841 showing/hiding it. Added TODO because it probably should not be NULL.
1842 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1843 because unnecessary g_warnings() make degugging difficult.
1845 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1847 * src/maemo/modest-msg-edit-window.c:
1848 (modest_msg_edit_window_select_color),
1849 (modest_msg_edit_window_select_background_color): 2 const corrections and
1850 moving 2 #endifs before closing brackets, to fix the build.
1852 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/easysetup/modest-easysetup-wizard.h:
1855 * src/maemo/easysetup/modest-easysetup-wizard.c:
1856 (modest_easysetup_wizard_dialog_finalize),
1857 (on_button_edit_advanced_settings), (create_page_complete_custom),
1858 (on_response), (create_account):
1859 Implement the Advanced Settings edit button, by saving the account information,
1860 for the Advanded Settings dialog to use directly from gconf, and removing it
1861 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1862 Bug #5533 in the projects.maemo.org bugzilla.
1864 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1866 * src/maemo/modest-msg-view-window.c:
1867 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1868 when opening a message window.
1870 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/easysetup/modest-easysetup-wizard.c:
1873 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1876 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1877 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1878 gconf settings. I probably added more checks than necessary, but that is safer.
1880 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1881 variable to fix the build, but this seems to be used when it is still NULL.
1883 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1885 * src/modest-platform.h:
1886 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1887 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1888 * src/modest-main.c: Implement this function so we can avoid using
1889 maemo-specific API from cross-platform code.
1891 * src/modest-tny-account-store.c:
1892 (get_smtp_specific_transport_account_for_open_connection):
1893 * src/modest-ui-actions.c: (check_for_connection),
1894 (modest_ui_actions_on_item_not_found):
1895 Use modest_platform_connect_and_wait() and put #idefs around other
1896 maemo-specific code, because only maemo currently has a way to
1897 identify connection names.
1899 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-tny-account-store.h:
1902 * src/modest-tny-account-store.c:
1903 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1904 the connection-specific SMTP server settings in the configuration.
1906 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1908 * src/maemo/modest-main-window.c: (on_connection_changed),
1910 * src/modest-main.c: (main), (start_ui), (send_mail):
1911 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1912 that is what is intended.
1914 * src/modest-ui-actions.c: (action_send), (action_receive),
1915 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1916 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1917 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1918 SMTP server is used when it is specified.
1920 (modest_ui_actions_on_send_receive):
1921 Check that a connection is open before proceeding.
1922 Receive and then send, instead of vice-versa, as per the specification.
1924 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-mail-operation.c:
1927 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1928 though I guess it should be something other than NULL.
1930 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/easysetup/modest-easysetup-wizard.c:
1933 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1934 combo twice, to avoid an g_warning and to make it visible again.
1935 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1936 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1937 (already intended) dereference when detaching, because we then recreate the menu.
1938 But I am not sure why the warning was happening, and it is possible that this is a memory
1941 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1943 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1944 and uri_parse_mailto() utility functions.
1945 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1947 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1949 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1951 * src/dbus_api/modest-dbus-api.h:
1952 * src/dbus_api/modest-dbus-callbacks.c:
1953 Use an idle callback to execute the modest code in the application's own thread.
1954 Remove the helloworld example method.
1955 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1956 parsed, and the open-message method is not implemented because this is not yet implemented in
1958 * libmodest-dbus-client/libmodest-dbus-client.c:
1959 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1960 (libmodest_dbus_client_open_message):
1961 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1963 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1964 body without crashing.
1966 * tests/dbus_api/Makefile.am:
1967 * tests/dbus_api/test_mail_to.c:
1968 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1970 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1972 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1973 Added file to fix the build. Sorry.
1975 * src/dbus_api/Makefile.am:
1976 * src/dbus_api/modest-dbus-api.h:
1977 * src/dbus_api/modest-dbus-callbacks.h:
1978 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1979 (modest_dbus_req_handler):
1980 Put constants in a separate header so it can be reused by the
1981 client library, without duplication
1983 * libmodest-dbus-client/Makefile.am:
1984 * libmodest-dbus-client/libmodest-dbus-client.c:
1985 (libmodest_dbus_client_call_helloworld),
1986 (libmodfest_dbus_client_send_mail),
1987 (libmodfest_dbus_client_mailto),
1988 (libmodfest_dbus_client_open_message):
1989 * libmodest-dbus-client/libmodest-dbus-client.h:
1990 (Partly) Implement a send_mail D-Bus method.
1992 * tests/dbus_api/Makefile.am:
1993 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1994 the send_email D-Bus method.
1996 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2000 * libmodest-dbus-client/Makefile.am:
2001 * libmodest-dbus-client/libmodest-dbus-client.c:
2002 * libmodest-dbus-client/libmodest-dbus-client.h:
2003 * tests/dbus_api/Makefile.am:
2004 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2005 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2007 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/easysetup/modest-easysetup-wizard.c:
2010 (create_page_account_details):
2011 * src/maemo/modest-account-settings-dialog.c:
2012 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2013 widgets, because this might not be the default in future versions of the Maemo GTK+.
2014 However, I can not not get capitalization to work even in a simple test case.
2016 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/easysetup/modest-easysetup-wizard.c:
2019 (create_page_custom_incoming), (create_page_custom_outgoing):
2020 * src/maemo/modest-account-settings-dialog.c:
2021 (create_page_account_details), (create_page_incoming),
2022 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2023 instead of using gtk_check_button_with_label(), so they are aligned like the other
2024 widgets, as per the UI spec.
2026 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/easysetup/modest-easysetup-wizard.c:
2029 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2030 * src/widgets/modest-validating-entry.c:
2031 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2032 Modest prefix instead of an EasySetup prefix.
2034 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2036 * src/widgets/modest-validating-entry.h:
2037 * src/widgets/modest-validating-entry.c: (on_insert_text),
2038 Added easysetup_validating_entry_set_max_func(), used to set a callback
2039 to call when the max number of characters is reached. GtkEntry has a max-length
2040 already but is silent about it.
2042 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2043 (create_page_account_details), (create_page_user_details),
2045 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2046 (create_page_account_details), (create_page_user_details),
2047 (create_page_outgoing):
2048 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2049 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2050 the UI spec, when the user tries to enter more than the max number of characters.
2052 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2054 * src/maemo/easysetup/modest-easysetup-wizard.c:
2055 (create_page_user_details), (create_page_custom_incoming),
2056 (create_page_custom_outgoing):
2057 * src/maemo/modest-account-settings-dialog.c:
2058 (create_page_user_details), (create_page_incoming),
2059 (create_page_outgoing):
2060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2061 (modest_connection_specific_smtp_edit_window_init):
2062 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2063 not appropriate. Bad Maemo-specific defaults!.
2065 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2068 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2069 (modest_signature_editor_dialog_set_settings):
2070 Disable the label and textview when the checkbox is disabled, and use the
2071 specified (UI spec) default signature text.
2073 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2075 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2076 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2078 * src/modest-defs.h:
2079 * src/modest-account-mgr-helpers.h:
2080 * src/modest-account-mgr-helpers.c:
2081 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2083 * src/maemo/Makefile.am:
2084 * src/maemo/modest-signature-editor-dialog.c:
2085 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2088 * src/maemo/modest-account-settings-dialog.h:
2089 * src/maemo/modest-account-settings-dialog.c:
2090 (modest_account_settings_dialog_finalize), (on_button_signature),
2091 (save_configuration): Use the new dialog when the Edit button is pressed, and
2092 save the changes if necessary, as per the UI spec.
2094 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/Makefile.am:
2097 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2098 based on maemo-develoers email from Dirk.
2100 * src/maemo/easysetup/modest-easysetup-wizard.c:
2101 (create_page_welcome), (create_page_account_details),
2102 (create_page_user_details), (create_page_complete_easysetup),
2103 (create_page_custom_incoming), (create_page_custom_outgoing),
2104 (create_page_complete_custom),
2105 (modest_easysetup_wizard_dialog_init):
2106 * src/maemo/modest-account-settings-dialog.c:
2107 (create_page_account_details), (create_page_user_details),
2108 (create_page_incoming), (create_page_outgoing),
2109 (modest_account_settings_dialog_init):
2110 * src/maemo/modest-connection-specific-smtp-window.c:
2111 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2113 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c:
2116 (create_page_account_details), (create_page_custom_outgoing),
2117 (create_page_complete_custom):
2118 * src/maemo/modest-account-settings-dialog.c:
2119 (create_page_user_details), (create_page_incoming),
2120 (create_page_outgoing):
2121 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2122 (modest_connection_specific_smtp_edit_window_init):
2123 Use the correct (UI spec) port min/max, and use horizontal separators,
2126 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/easysetup/modest-easysetup-wizard.c:
2129 (set_default_custom_servernames):
2130 * src/maemo/modest-account-settings-dialog.c:
2131 (create_page_incoming), (on_combo_outgoing_security_changed),
2132 (on_combo_incoming_security_changed), (create_page_outgoing),
2133 (modest_account_settings_dialog_set_account_name),
2134 (save_configuration):
2135 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2136 (on_combo_security_changed),
2137 (modest_connection_specific_smtp_edit_window_init),
2138 (modest_connection_specific_smtp_edit_window_set_connection),
2139 (modest_connection_specific_smtp_edit_window_get_settings):
2140 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2143 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/easysetup/modest-easysetup-wizard.c:
2147 (create_page_custom_outgoing), (create_page_complete_custom):
2148 * src/maemo/modest-account-settings-dialog.c:
2149 (create_page_user_details), (create_page_outgoing):
2150 * src/maemo/modest-account-view-window.c: (button_box_new):
2151 Use changed logical IDs as per the most recent UI spec:
2152 mcen_bd_emailsetup_edit -> mcen_bd_edit
2153 mcen_bd_emailsetup_delete -> mcen_bd_delete
2154 mcen_bd_emailsetup_close -> mcen_bd_close
2156 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2160 * src/dbus_api/Makefile.am:
2161 * src/dbus_api/modest-dbus-callbacks.c:
2162 * src/dbus_api/modest-dbus-callbacks.h:
2163 * src/maemo/modest-platform.c: (modest_platform_init):
2164 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2166 * tests/Makefile.am:
2167 * tests/dbus_api/Makefile.am:
2168 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2170 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-account-settings-dialog.c:
2173 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2174 Removed unnecessary includes.
2176 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/easysetup/modest-easysetup-wizard.c:
2179 * src/maemo/modest-account-settings-dialog.c:
2180 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2181 * src/widgets/Makefile.am:
2182 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2183 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2184 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2185 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2186 * src/widgets/modest-secureauth-combo-box.c:
2187 * src/widgets/modest-secureauth-combo-box.h:
2188 * src/widgets/modest-serversecurity-combo-box.c:
2189 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2190 made the GObject names more consistent with the rest of the Modest code.
2192 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/easysetup/Makefile.am:
2195 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2196 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2197 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2198 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2199 * src/maemo/easysetup/modest-easysetup-wizard.c:
2200 * src/maemo/easysetup/modest-validating-entry.c:
2201 * src/maemo/easysetup/modest-validating-entry.h:
2202 * src/maemo/modest-account-settings-dialog.c:
2203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2204 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2205 widgets/ because they are used outside of easysetup too. After checking in,
2206 svn will allow me to rename them too.
2208 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2210 * src/gnome/modest-msg-edit-window.c:
2211 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2212 linker error, to fix the build on the GNOME platform.
2213 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2214 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2215 ifdefed out to avoid a warning.
2217 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2219 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2220 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2221 some alternative for GTK+ 2.6.
2223 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2227 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2228 specified for EmailAccountsDialog in UI spec.
2230 * src/maemo/easysetup/modest-easysetup-wizard.c:
2231 * src/maemo/easysetup/modest-easysetup-wizard.h:
2232 * src/maemo/modest-account-settings-dialog.c:
2233 * src/maemo/modest-account-settings-dialog.h:
2234 Reuse a member window widget for the connection-specific SMTP server accounts,
2235 so we can tell it to create/save the accounts only if we actually save changes.
2237 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2238 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2239 (modest_connection_specific_smtp_edit_window_get_settings):
2240 Return a struct instance for temporarily remembering the entered data.
2242 * src/maemo/modest-connection-specific-smtp-window.h:
2243 * src/maemo/modest-connection-specific-smtp-window.c:
2244 (modest_connection_specific_smtp_window_finalize),
2245 (modest_connection_specific_smtp_window_fill_with_connections),
2247 (modest_connection_specific_smtp_window_save_server_accounts),
2248 (update_model_server_names): Do not actually save data until asked,
2249 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2251 (on_selection_changed),
2252 (modest_connection_specific_smtp_window_init): Disable the edit
2253 button when nothing is selected.
2255 * src/modest-account-mgr-helpers.c:
2256 * src/modest-account-mgr-helpers.h:
2257 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2260 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2262 * src/modest-account-mgr-helpers.h:
2263 * src/modest-account-mgr-helpers.c:
2264 (modest_account_mgr_get_unused_account_name),
2265 (modest_account_mgr_get_unused_account_display_name): Added these
2266 utility functions, to avoid code duplication.
2268 * src/maemo/easysetup/modest-easysetup-wizard.c:
2269 (create_page_account_details), (create_account):
2270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2271 (on_combo_security_changed),
2272 (modest_connection_specific_smtp_edit_window_init),
2273 (modest_connection_specific_smtp_edit_window_save_settings):
2274 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2275 * src/maemo/modest-connection-specific-smtp-window.c:
2276 (modest_connection_specific_smtp_window_finalize),
2277 (modest_connection_specific_smtp_window_fill_with_connections),
2278 (on_button_edit), (modest_connection_specific_smtp_window_init):
2279 * src/maemo/modest-connection-specific-smtp-window.h:
2280 Implementing saving of connection-specific server accounts.
2282 But I need to refactor this so we can save the data for each
2283 possible connection-specific account and only actually create the server accounts
2284 when the easysetup finished, or the OK button is pressed on the account settings
2287 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2290 (on_combo_security_changed):
2291 (modest_connection_specific_smtp_edit_window_init):
2292 Auto-fill the port number as in the account settings.
2294 (modest_connection_specific_smtp_edit_window_set_connection):
2295 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2296 * src/maemo/modest-connection-specific-smtp-window.c:
2297 (fill_with_connections), (on_button_edit),
2298 (modest_connection_specific_smtp_window_init):
2299 Turn the edit window into a dialog to simplify the code, and
2300 set a WM hint as in a GtkDialog, because only a popup can be on top of
2301 another window in Maemo, and popups usually have no WM decoration.
2303 * src/modest-defs.h:
2304 * src/modest-account-mgr-helpers.c:
2305 (modest_account_mgr_set_connection_specific_smtp),
2306 (modest_account_mgr_remove_connection_specific_smtp),
2307 (modest_account_mgr_get_connection_specific_smtp):
2308 * src/modest-account-mgr-helpers.h: Some functions to write the
2309 connection-specific SMTP server information. Not yet used.
2312 * src/widgets/modest-folder-view.c: (text_cell_data):
2313 Fix a warning about an uninitialized variable.
2314 (on_configuration_key_changed): Put an #ifdef around the use
2315 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2317 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2319 * src/maemo/modest-account-settings-dialog.h:
2320 * src/maemo/modest-account-settings-dialog.c:
2321 Added connect_for_modified() utility function to mark the new modified boolean.
2323 (create_page_account_details), (create_page_user_details),
2324 (create_page_incoming), (create_page_outgoing), (on_response),
2325 (modest_account_settings_dialog_init),
2326 (modest_account_settings_dialog_set_account_name):
2327 Only warn about unsaved changes when there are actually unsaved changes.
2329 * src/modest-account-mgr-helpers.c:
2330 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2331 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2332 to get the data from there in future.
2334 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2336 * src/modest-defs.h:
2338 * src/modest-account-mgr-helpers.h:
2339 * src/modest-account-mgr-helpers.c:
2340 Store the security account setting in a single conf key instead of using
2341 the options list, so that the list is left for just the to-be-removed camel hack,
2342 and because gconf_client_set_list() is failing for some reason.
2344 * src/modest-account-mgr.c:
2345 (modest_account_mgr_add_server_account):
2346 * src/maemo/modest-account-settings-dialog.c:
2347 (modest_account_settings_dialog_set_account_name),
2348 (save_configuration): Use the renamed functions.
2351 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2353 * src/widgets/Makefile.am:
2354 * src/widgets/modest-limit-retrieve-combo-box.c:
2355 * src/widgets/modest-limit-retrieve-combo-box.h:
2356 * src/widgets/modest-retrieve-combo-box.c:
2357 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2358 the account settings dialog.
2360 * src/modest-defs.h:
2361 * src/modest-account-mgr-helpers.h:
2362 * src/modest-account-mgr-helpers.c:
2363 (modest_server_account_get_option_secure_auth),
2364 (modest_server_account_set_option_secure_auth):
2365 * src/modest-account-mgr.c:
2366 (modest_account_mgr_add_server_account):
2367 Use the existing AUTH_MECH conf key for the secure-auth setting,
2368 instead of putting it in the list options, because this was actually used already.
2370 * src/maemo/modest-account-settings-dialog.c:
2371 (create_page_account_details),
2372 (modest_account_settings_dialog_set_account_name),
2373 (save_configuration):
2374 * src/maemo/modest-account-settings-dialog.h:
2375 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2376 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2378 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2380 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2381 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2382 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2384 * src/modest-defs.h:
2385 * src/maemo/modest-account-settings-dialog.c:
2386 (create_page_incoming), (on_combo_outgoing_security_changed),
2387 (on_combo_incoming_security_changed), (create_page_outgoing),
2388 (modest_account_settings_dialog_set_account_name),
2389 (save_configuration): Load/Save the port number, and change it when the
2390 security combo changes, to suitable defaults.
2392 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2394 * src/modest-account-mgr.c:
2395 (modest_account_mgr_add_server_account): Set the security and secure-auth
2396 options, and add a comment saying that the other camel-specific options should be
2399 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2403 * src/modest-tny-account-store.c: (account_list_free),
2404 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2405 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2408 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2410 * src/modest-protocol-info.c:
2411 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2412 is required by our UI spec. Maybe something in our implementation will use this eventually.
2413 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2414 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2415 instead of the previous 0 placeholder.
2417 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2418 secure-auth settings.
2419 * src/modest-account-mgr-helpers.h:
2420 * src/modest-account-mgr-helpers.c:
2421 (modest_server_account_data_get_option_secure_auth),
2422 (modest_server_account_set_option_secure_auth),
2423 (modest_server_account_data_get_option_security),
2424 (modest_server_account_set_option_security): Added this API for getting and setting the security
2425 and secure-auth settings.
2427 * src/maemo/modest-account-settings-dialog.h:
2428 * src/maemo/modest-account-settings-dialog.c:
2429 (modest_account_settings_dialog_finalize), (check_data),
2430 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2431 about changing titles.
2432 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2433 (save_configuration): Save the security and secure-auth settings.
2435 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2436 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2438 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2440 * src/modest-defs.h:
2441 * src/modest-account-mgr.c:
2442 (modest_account_mgr_add_server_account):
2443 Added and used defines for the options key and value pair strings,
2444 that are used so far, though they do not seem to correspond to anything in our
2445 UI specs or ModestProtocol enum.
2447 * src/modest-account-mgr-helpers.h:
2448 * src/modest-account-mgr-helpers.c:
2449 (compare_option_strings_for_name),
2450 (modest_server_account_data_get_option_value),
2451 (modest_server_account_data_get_option_bool),
2452 (modest_account_mgr_get_server_account_option):
2453 Added helper functions for parsing the options GSList.
2455 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2457 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2458 display name is based on the supplied account name.
2459 * src/modest-account-mgr.c:
2460 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2461 with an inefficient, but good-enough, implementation.
2463 * src/maemo/easysetup/modest-easysetup-wizard.c:
2464 (create_page_account_details), (on_before_next), (create_account):
2465 Check for existing display names rather than (non-user-visible) account names, and just
2466 create and set a unique account name at the end.
2468 * src/maemo/modest-account-settings-dialog.c:
2469 (modest_account_settings_dialog_init),
2470 (modest_account_settings_dialog_set_account_name),
2471 (create_page_incoming): Show the display name, instead of the account name.
2472 (on_response): Do some (not all) extra checks, as in the UI spec.
2473 (save_configuration): Save the display name if it was changed.
2475 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2477 * po/en_GB.po: Added needed logical ID and translation.
2478 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2479 (init_view): Made the is-default column clicking work.
2481 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2484 * src/maemo/easysetup/Makefile.am:
2485 * src/maemo/easysetup/modest-easysetup-wizard.c:
2486 (modest_easysetup_wizard_dialog_init):
2487 * src/maemo/easysetup/provider-data-test.keyfile:
2488 * src/maemo/easysetup/provider-data.keyfile:
2489 Moved the provider data file to the new modest-providers-data package and used it from there.
2491 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-local-folder-info.c:
2494 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2495 N_() was already used on the static strings, but this just marks it for translation without
2496 using the translation.
2498 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/modest-account-settings-dialog.c:
2501 (create_page_incoming),
2502 (modest_account_settings_dialog_set_account_name):
2503 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2504 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2505 I will do this if nobody else gets there first.
2507 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2510 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2511 save the security stuff.
2513 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2516 Set the email address and user fullname, which I now see must be
2519 * src/maemo/modest-account-settings-dialog.h:
2520 * src/maemo/modest-account-settings-dialog.c:
2522 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2523 leave-on-server and authentication.
2524 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2527 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2530 * src/maemo/modest-account-settings-dialog.c:
2531 * src/maemo/modest-account-settings-dialog.h:
2532 Most (but not all) of the widgets are now present as specified by the UI spec.
2533 No changes are yet saved, and some details are not properly shown yet.
2535 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2537 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2539 * src/maemo/Makefile.am:
2540 * src/maemo/modest-account-settings-dialog.c:
2541 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2542 an existing account. Doesn't do much yet.
2544 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2545 Open the accounts settings dialog when Edit is clicked.
2547 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2549 * src/maemo/easysetup/Makefile.am:
2550 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2552 * src/maemo/easysetup/modest-easysetup-wizard.c:
2553 (modest_easysetup_wizard_dialog_init):
2554 Try to get the source directory from the build system,
2555 instead of hard-coding "./" into the source code, when opening our local
2556 copies of the configuration files.
2557 But this still fails when opening the wizard from the Accounts window,
2558 maybe because the working directory seems to change at runtime.
2559 So the wizard will fail the second time unless you copy the files into their
2560 proper locations - see the stdout warnings for the paths.
2562 (create_page_account_details),(on_before_next):
2563 Check for existing non-server accounts instead of server accounts,
2564 so the default account name is useful again, and to prevent trying to
2567 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2568 Show the wizard when New is clicked.
2570 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2571 (init_view): Show the column headers, and show the columns that are
2572 specified in the UI specs. However, something in Maemo's GTK+ prevents
2573 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2574 change the default account. This is despite unsetting the special properties.
2576 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2578 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2579 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2580 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2581 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2582 to make that clearer.
2583 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2585 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/modest-account-view-window.c:
2588 (modest_account_view_window_init),
2589 (modest_account_view_window_new):
2590 Use the same buttons as specified in the
2591 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2592 the existing widgets, which never had a chance of working.
2593 Put the ModestAccountView treeview in a scrolled window.
2594 Do not repeat the initialization in both _init() and _new().
2596 * src/widgets/modest-account-view.c: (update_account_view):
2597 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2598 this widget and window shows no accounts.
2600 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2602 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2604 * src/maemo/easysetup/modest-easysetup-wizard.c:
2605 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2606 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2607 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2610 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2611 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2612 accounts exist yet, as in the UI spec.
2614 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2616 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/Makefile.am:
2619 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2620 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2621 New window for editing connection-specific smtp details.
2622 Not fully implemented.
2624 * src/maemo/modest-connection-specific-smtp-window.c:
2625 (modest_connection_specific_smtp_window_finalize) :
2626 unref the tree model.
2627 (on_button_edit): Show the edit window.
2629 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2631 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2634 * src/maemo/Makefile.am:
2635 * src/maemo/modest-connection-specific-smtp-window.c:
2636 * src/maemo/modest-connection-specific-smtp-window.h:
2637 New window for showing the list of connections, for connection-specific
2638 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2639 * src/maemo/easysetup/modest-easysetup-wizard.c:
2640 (create_page_custom_outgoing): Show the new window when the button is clicked.
2642 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2644 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2645 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2646 * src/maemo/modest-msg-edit-window.c:
2647 (modest_msg_edit_window_insert_image):
2648 * src/modest-conf.c: (modest_conf_key_escape):
2649 * src/modest-mail-operation.c:
2650 (modest_mail_operation_send_new_mail):
2651 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2652 (modest_ui_actions_on_new_account):
2653 * src/widgets/modest-attachment-view.c: (update_filename_request):
2654 * src/widgets/modest-mail-header-view.c:
2655 Corrected warnings that were breaking the build, by commenting out unused variables,
2656 and a function, and by including a header.
2658 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2660 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2661 so we can #ifdef around platform-specific code when necessary.
2662 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2663 to allow this to build for the GNOME platform too.
2665 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2667 * src/maemo/easysetup/modest-easysetup-wizard.c:
2668 Added util_increment_name() and used it in create_page_account_details()
2669 to make sure that the default account name is always a new name.
2671 (modest_easysetup_wizard_dialog_init),
2672 (set_default_custom_servernames): Some minor memory management fixes.
2674 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2678 * src/modest-runtime.c: (init_i18n): Restored the translation
2679 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2680 are defined in config.h, and the translations are installed.
2682 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2683 is defined for translation.
2685 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2689 * src/maemo/easysetup/modest-easysetup-wizard.c:
2690 (modest_easysetup_wizard_dialog_init):
2691 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2692 Use realistic paths (though they should use $prefix generically) to the
2693 mcc_mapping and provider-data.keyfile files which might work when they
2694 are installed by the future version of the operator-wizard package,
2695 and then fallback to paths in our source code, with an explanatory
2698 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2702 * src/maemo/Makefile.am:
2703 * src/maemo/easysetup/: Added files from the previously-exernal
2704 osso-modest-easysetup.
2705 * src/maemo/modest-main-window-ui.h:
2706 * src/modest-ui-actions.c:
2707 * src/modest-ui-actions.h:
2708 Added modest_ui_actions_on_new_account() as a signal handler for the
2709 New Account menu item. It shows the easysetup wizard.
2710 * po/en_GB.po: Added additional needed logical IDs and translations.
2712 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2713 Apparently ChangeLog is not used for some vague Nokia legal reasons.