1 2007-08-01 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr-helpers.h:
4 * src/modest-account-mgr-helpers.c:
5 Added modest_account_mgr_get_first_account_name(),
6 using code from modest_account_mgr_set_first_account_as_default().
8 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
9 (account_number_changed): Call set_at_least_one_account_visible() so that
10 the first account is visible when first added, without the user having to
12 I do wonder how this worked before.
14 2007-08-01 Murray Cumming <murrayc@murrayc.com>
16 * src/modest-tny-account-store.c: (show_password_warning_only),
17 (show_wrong_password), (request_password_and_wait), (get_password),
18 (modest_tny_account_store_alert): Remove the (incomplete anyway)
19 attempts to show UI only in the main context, which used g_idle_add()
20 and mainloops, because tinymail now guarantees that it only calls these
21 callbacks in the mainloop with the gdk lock. This makes everything much
24 2007-08-01 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
27 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
28 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
29 error dialog, instead of ignoring it.
31 2007-08-01 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-msg-view-window.c:
34 (modest_msg_view_window_get_header),
35 (modest_msg_view_window_last_message_selected):
36 Added comments to explain the use of priv->header_model.
37 * src/modest-ui-dimming-rules.c:
38 (modest_ui_dimming_rules_on_open_msg),
39 (modest_ui_dimming_rules_on_mark_as_read_msg),
40 (modest_ui_dimming_rules_on_mark_as_unread_msg),
41 (modest_ui_dimming_rules_on_remove_attachments),
42 (_invalid_attach_selected), (_selected_msg_marked_as):
43 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
44 and changed the parameter to a ModestMainWindow to make it clearer that
45 it never uses any other kind of window.
46 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
47 instead of the selected message.
48 I notice that much of the dimming code and the ModestMsgViewWindow code
49 hard-codes the assumption that the viewed message is always selected in
50 the header view. This does not seem wise or simple.
52 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
53 examine the actual message instead of whatever might be selected
54 in the header view. This stops the delete toolbar button and menu item
55 from being dimmed when opening a message view the search UI,
56 partially fixing projects.maemo.org bug NB#63811.
58 However, when actually deleting, I now get this warning:
59 "tny_header_set_flags: This is a header instance for a new message.
60 Only priority and attachment flags are supported"
62 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
64 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
66 Show account wizard if no accounts are defined while sending
67 (automatic sending after the account wizard finished does not
68 work because it takes some time until the account manager
69 synchronizes everything. (projects.maemo.org NB#62792)
71 2007-07-30 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-tny-account-store.c: (on_account_removed),
74 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
75 account is removed from the View menu. We have TnyAccountStore
76 and ModestTnyAccountStore signals that seem very similar, but this
77 seems to work for now.
79 * src/maemo/modest-main-window.c:
80 (on_show_account_action_activated): Prevent dereference
81 of a NULL if the accoutn does not really exist, though that
82 should not happen anymore.
84 This fixes projects.maemo.org bug NB#64606.
86 2007-07-30 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-ui-actions.c: (run_account_setup_wizard),
89 (modest_ui_actions_on_accounts): Revert a change that set these
90 to modal dialogs, freezing the UI when they show secondary dialogs.
91 This fixed projects.maemo.org bug NB#64519.
93 2007-07-27 Murray Cumming <murrayc@murrayc.com>
95 * src/widgets/modest-header-view-render.c:
96 (_modest_header_view_compact_header_cell_data):
97 Some checks and initialization to try to deal with a crash,
100 2007-07-27 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-maemo-utils.c:
103 (modest_maemo_utils_get_supported_secure_authentication_methods):
104 Make sure that we have a connection, asking the user for one
106 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
107 Check for a connection before showing the wizard, because
108 the wizard needs a connection to check for server capabilities.
110 2007-07-27 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-account-view-window.c:
113 (on_new_button_clicked): Remember the wizard dialog instance,
114 so we can just present it again if necessary. This prevents
115 multiple windows from appearing if you click again quickly on the
116 New button before the dialog appears, fixing projects.maemo.org
119 2007-07-27 Murray Cumming <murrayc@murrayc.com>
121 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
122 Offer a connection dialog if there is no connection when
123 starting modest. This should fix projects.maemo.org bug NB#61134.
125 2007-07-27 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
128 Reverted my last commit. I was able to fix the build by doing
129 apt-get install wpeditor0 (replacing other wpeditor packages) and
130 an explicit apt-get install wpeditor-dev to upgrade the -dev
133 2007-07-27 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
136 Commented out the use of wp_text_buffer_replace_image()
137 because it does not exist, to break the build. Added a TODO for it.
139 2007-07-26 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-tny-account-store.c: (recreate_all_accounts):
142 Recreate them even if they were NULL before. I guess something
143 else was already creating them before, or this would never
145 (modest_tny_account_store_get_server_account): Make sure that
146 the tny accounts have been created before trying to find one.
147 This allows libmodest_dbus_client_compose_mail() to work
148 when the UI is not yet visible.
149 This is probably useful in other cases too.
151 (get_password): When the password is wrong after it is entered
152 in the protected password dialog, show an info banner (in an
153 idle handler) before showing the protected password dialog
156 2007-07-26 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-ui-actions.h:
159 * src/modest-ui-actions.c: Added
160 modest_do_refresh_current_folder() containing some code from
161 modest_ui_actions_on_send_receive().
162 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
163 Call modest_do_refresh_current_folder() before refreshing the
164 requested account, as in modest_ui_actions_on_send_receive().
165 This is strange, but seems to be necessary to show new mails.
166 Now new emails are finally visible in the UI when downloaded
167 via the automatic update interval, fixing bug NB#57458.
168 This also works because bug NB#57458 has been fixed somehow.
170 2007-07-26 Murray Cumming <murrayc@murrayc.com>
172 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
173 printf more details when we get unhandled D-Bus methods, because
176 * src/modest-mail-operation.c: (update_account_thread):
177 Comment out the tny_camel_pop_store_account_reconnect(), because this
178 is apparently no longer needed, and it did not work before anyway.
179 See the comment in the code.
181 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
182 by checking the header flags. This fixes projects.maemo.org bug
185 2007-07-25 Murray Cumming <murrayc@murrayc.com>
187 * src/maemo/modest-maemo-utils.h:
188 * src/maemo/modest-maemo-utils.c: Added
189 modest_maemo_show_information_note_in_main_context_and_forget().
190 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
191 Use the new function to show simple error dialogs in the main
192 context, though question dialogs are still in the current context,
193 which is unfortunately usually not the main context. This should
196 2007-07-25 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account-store.c: (get_password):
199 Never save the entered username and password in gconf,
200 because the UI spec says we should not. This helps
201 slightly with projects.maemo.org bug NB#63671.
203 2007-07-25 Murray Cumming <murrayc@murrayc.com>
205 * src/widgets/modest-msg-edit-window.h:
206 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
207 Moved some code here to make it simpler.
208 (modest_msg_edit_window_attach_file_one): Renamed from
209 modest_msg_edit_window_attach_file_interactive().
210 (modest_msg_edit_window_offer_attach_file): Renamed from
211 modest_msg_edit_window_attach_file() and used
212 modest_msg_edit_window_attach_file_one() instead of
213 copy/pasting the code. The old code for one was not using
214 GnomeVFS. This allows use of smb:// URLs when using send-as
215 from external applications, fixing bug NB#63741.
217 (modest_msg_edit_window_insert_image),
218 (modest_msg_edit_window_add_attachment_clicked):
219 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
220 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
221 Adapted to the new function names.
223 2007-07-25 Murray Cumming <murrayc@murrayc.com>
225 (modest_platform_set_update_interval): Set the alarm recurrence
226 fields so that auto-update does not just happen the first time.
227 This should have fixed projects.maemo.org bug NB#63938.
229 When this happens you can see a printf when the D-Bus method is
231 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
233 However, I do not actually seem to get new POP messages even when
234 clicking the refresh button manually. A restart gets them.
235 This might be a problem in today's tinymail only.
237 2007-07-24 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/modest-maemo-global-settings-dialog.c:
240 (current_connection):
241 Avoid a crash (probably only in scratchbox) when strcmp()ing a
242 NULL when closing the dialog.
244 2007-07-24 Murray Cumming <murrayc@murrayc.com>
246 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
247 Remove the hacky send/receive that didn't work, and instead
248 refilter the treemodel to make the deleted email really vanish from
249 the UI (though the delete-from-menu code does has commented out
250 the code that does that). This fixes projects.maemo.org bug
253 2007-07-24 Murray Cumming <murrayc@murrayc.com>
255 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
256 Try a couple of tricks to force the treeview to update (
257 poke the folder, and do a send/receive refresh), but the deleted
258 email still appears with a strike-through instead of really being
261 2007-07-23 Murray Cumming <murrayc@murrayc.com>
263 * src/dbus_api/modest-dbus-callbacks.c:
264 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
265 because their ID is not human-readable (see the comment about
266 improvements needed to the osso-email-interface API) and
267 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
269 2007-07-23 Murray Cumming <murrayc@murrayc.com>
271 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
272 (add_folders_to_list), (on_dbus_method_get_folders),
273 (modest_dbus_req_filter):
274 * src/maemo/modest-maemo-utils.c:
275 (on_camel_account_get_supported_secure_authentication):
276 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
277 (on_header_view_focus_in):
278 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
279 * src/modest-formatter.c: (modest_formatter_create_body_part):
280 * src/modest-mail-operation.c: (recurse_folders),
281 (update_account_thread), (get_msgs_full_thread),
282 (modest_mail_operation_get_msgs_full),
283 (modest_mail_operation_xfer_msgs):
284 * src/modest-search.c: (search_mime_part_and_child_parts),
285 (modest_search_account), (modest_search_all_accounts):
286 * src/modest-tny-account.c:
287 (modest_tny_account_get_special_folder), (recurse_folders):
288 * src/modest-tny-local-folders-account.c:
289 (modest_tny_local_folders_account_query_passes):
290 * src/modest-tny-msg.c: (copy_mime_part),
291 (modest_tny_msg_find_body_part_from_mime_part):
292 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
293 (modest_tny_send_queue_try_to_send):
294 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
295 (_modest_ui_actions_open), (download_uncached_messages),
296 (reply_forward), (modest_ui_actions_on_copy),
297 (modest_ui_actions_on_details), (has_retrieved_msgs),
298 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
300 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
301 (_selected_msg_marked_as), (_msg_download_completed),
302 (_selected_msg_sent_in_progress):
303 * src/widgets/modest-attachments-view.c:
304 (modest_attachments_view_set_message):
305 * src/widgets/modest-msg-view.c: (find_cid_image):
306 * tests/check_folder-transfer.c: (find_folders):
307 * tests/check_update-account.c: (func):
308 * tests/dbus_api/test_get_folders.c: (main):
309 Checked all uses of tny_iterator_get_current(), making sure
310 that the object is unreferenced (3 or 4 places did not),
311 and adding checks for NULL.
313 2007-07-23 Murray Cumming <murrayc@murrayc.com>
315 * src/dbus_api/modest-dbus-callbacks.c:
316 (on_idle_open_default_inbox): Make sure that the application UI is
318 * src/maemo/easysetup/modest-easysetup-wizard.c:
319 (on_entry_invalid_character): Show the word whitespace instead
320 of (null) in the banner when whitespace was entered.
321 (show_error): Add a comment that this does not work in
322 Maemo Bora, though we do not know why.
324 2007-07-23 Murray Cumming <murrayc@murrayc.com>
326 * src/modest-tny-account.c:
327 (modest_tny_account_get_special_folder): Use an if instead of
328 an assert for when the parent account name is NULL, because this
329 might be causing a crash in projects.maemo.org bug 63192.
330 * src/modest-mail-operation.c:
331 (modest_mail_operation_send_new_mail_cb),
332 (modest_mail_operation_remove_folder): unref the folder that is
333 returned from modest_tny_account_get_special_folder().
335 2007-07-23 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-ui-actions.c:
338 (modest_ui_actions_on_password_requested):
339 Show mail_ib_login_cancelled info banner when the user cancels
340 the protected password dialog, to fix projects.maemo.org
343 2007-07-23 Murray Cumming <murrayc@murrayc.com>
345 * src/maemo/modest-account-settings-dialog.c:
346 (create_page_outgoing): Put this page in a GtkScrolledWindow,
347 matching the UI mock-up in the UI spec, and allowing access
348 to all widgets even when the on-screen keyboard is active.
350 2007-07-23 Murray Cumming <murrayc@murrayc.com>
352 Reverted this previous commit from Johannes,
353 because the scrollbars are always visible and because
354 I think we only need it on onepage of the account
355 settings, not the account wizard.
356 (I wrote the wrong instructions in the bug.)
358 * src/maemo/easysetup/modest-easysetup-wizard.c:
359 Added scrollbars to account wizard dialog.
360 Fixed projects.maemo.org NB #62744
362 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
364 * src/maemo/easysetup/modest-easysetup-wizard.c:
365 (create_page_user_details):
366 Use auto-cap for name (projects.maemo.org NB#63716)
367 * src/widgets/modest-account-view.c: (on_account_busy_changed):
369 2007-07-22 Armin Burgmeier <armin@openismus.com>
371 * src/maemo/modest-ui-actions.c: Use current account instead of
372 default account for creating viewer windows, so that the viewer
373 window knows to which account the viewed message belongs.
375 * src/maemo/modest-msg-view-window.c: Destroy the window when the
376 corresponding account is deleted. This fixes projects.maemo.org bug
379 2007-07-18 Armin Burgmeier <armin@openismus.com>
381 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
382 the dialog close after entering an invalid port number and clicking
383 OK. This fixes projects.maemo.org bug NB#63602.
385 2007-07-18 Armin Burgmeier <armin@openismus.com>
387 * src/modest-tny-account-store.c:
388 (get_server_accounts): Set parent modest account name for each
389 connection-specific transport account so that special folders of such
390 an account can be looked up. This fixes a crash when changing account
391 settings. This might also be related to projects.maemo.org bug
394 2007-07-16 Armin Burgmeier <armin@openismus.com>
396 * src/modest-ui-actions.c: Added a button to create a folder to the
397 move-to dialog. This fixes projects.maemo.org bug NB#.
399 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
401 * src/maemo/easysetup/modest-easysetup-wizard.c:
402 Added scrollbars to account wizard dialog.
403 Fixed projects.maemo.org NB #62744
405 2007-07-16 Murray Cumming <murrayc@murrayc.com>
407 * src/widgets/modest-msg-view.h:
408 * src/widgets/modest-msg-view.c:
409 Added modest_msg_view_get_message_is_empty() but this needs
411 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
412 Check if there is any text in the message yet.
413 But this needs to be implemented properly.
414 (modest_msg_edit_window_toggle_find_toolbar):
415 * src/maemo/modest-msg-view-window.c:
416 (modest_msg_view_window_toggle_find_toolbar):
417 Show a banner warning if there is no text to search, when
418 trying to start a search. This partially fixes
419 projects.maemo.org bug NB#62350.
421 2007-07-13 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-mail-operation.c: (update_account_thread):
424 Initialized num_new_headers to fix the build.
426 2007-07-13 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
429 Ignore modest accounts whose server accounts don't exist in gconf.
430 This prevents us trying to create TnyAccount instances for those
431 server accounts when the server account has been removed from gconf,
432 but the parent modest account has not yet been removed from modest.
433 I don't know why this is only noticeable now. It was probably just
434 a harmeless g_warning() anyway.
436 2007-07-13 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
439 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
441 2007-07-12 Armin Burgmeier <armin@openismus.com>
443 * src/maemo/modest-main-window.c: Make default account appear bold
444 in view, tools/send & receive and toolbar/send & receive SCM menus.
445 This fixes projects.maemo.org bug NB#59010.
447 2007-07-12 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
450 Add a short-cut, by checking if the folder store is an account.
451 This ensures that the Sort menu item and toolbar is dimmed for
452 the local-folders account root item, fixing
453 projects.maemo.org bug NB#62545.
455 2007-07-12 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-tny-account-store.c: (get_password):
458 Show the password dialog (via the signal) only in the mainloop, via
459 an idle handler that we wait for. This could theoretically prevent
460 hangs, though I worry that it could introduce some too.
462 2007-07-12 Murray Cumming <murrayc@murrayc.com>
464 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
465 * src/maemo/modest-platform.c:
466 (modest_platform_connect_and_wait):
467 Take a TnyAccount* parameter and try to set it to online
468 (a TnyCamel-only API), because tinymail sets accounts to offline
469 when the user cancels a password dialog, and doesn't ask again until
470 it has been set to online.
471 However, this is commented out because it causes a hang now.
473 (modest_platform_connect_and_wait_if_network_account):
474 * src/modest-mail-operation.c:
475 (modest_mail_operation_update_account):
476 * src/modest-platform.h:
477 * src/modest-ui-actions.c: (_modest_ui_actions_open),
478 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
480 2007-07-12 Armin Burgmeier <armin@openismus.com>
482 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
484 * src/modest-mail-operation.c:
485 * src/modest-ui-actions.c: Check for already existing folder before
486 querying the server, show error message from camel if the request
487 still fails. This fixes projects.maemo.org bug NB#58701.
489 2007-07-12 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-tny-account-store.h:
492 * src/modest-tny-account-store.c:
493 Added modest_tny_account_store_forget_password_in_memory(),
494 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
495 when creating a new account, so that new passwords will be used, instead of
496 us thinking that it's a second request as a result of a failed password again.
498 2007-07-12 Murray Cumming <murrayc@murrayc.com>
500 * src/dbus_api/modest-dbus-callbacks.c:
501 (on_idle_open_message): If the message is in drafts then open it
502 in an edit window instead of a view window. This fixes
503 projects.maemo.org bug NB#63005.
505 2007-07-12 Murray Cumming <murrayc@murrayc.com>
507 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
508 Avoided a harmless g_warning().
510 2007-07-12 Murray Cumming <murrayc@murrayc.com>
512 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
513 Pass the modest account name, not the TnyAccount display name to
514 modest_msg_view_window_new() so that the reply feature works,
515 fixing projects.maemo.org bug NB#62892.
517 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
518 (modest_msg_view_window_new_with_header_model):
519 * src/maemo/modest-msg-view-window.c:
520 (modest_msg_view_window_new_with_header_model),
521 (modest_msg_view_window_new):
522 * src/modest-ui-actions.c: (reply_forward):
523 * src/widgets/modest-msg-view-window.h:
524 * src/widgets/modest-window.c: (modest_window_set_active_account):
525 Rename an account parameter to modest_account_name to make this clearer.
527 2007-07-11 Murray Cumming <murrayc@murrayc.com>
529 * src/modest-ui-actions.h:
530 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
531 modest_do_message_delete().
532 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
533 Call modest_do_message_delete(), hoping that this would cause messages
534 to be really deleted from search instead of just marked with strike through.
535 Does not seem to help.
537 2007-07-11 Armin Burgmeier <armin@openismus.com>
539 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
540 priv->reselect to FALSE prior to calling
541 modest_folder_view_select_first_inbox_or_local() to prevent endless
542 recursion and thus a crash on startup.
544 2007-07-11 Armin Burgmeier <armin@openismus.com>
546 * src/maemo/modest-account-settings-dialog.h: Include
547 <gtk/gtknotebook.h> to fix the build (at least for me).
549 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
550 Use "New FolderN" as default suggested name if "New folder" already
551 exists, with N being the first free number, though never exceed "New
552 folder99" in which case we just fall back to "New Folder" even though
553 it already exists. This fixes projects.maemo.org bug NB#58663.
555 2007-07-11 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
558 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
559 projects.maemo.org bug NB#62778.
561 2007-07-11 Murray Cumming <murrayc@murrayc.com>
563 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
564 Ignore the wrong (for now) secure-smtp setting in the presets -
565 just default to requiring secure authentication for SMTP, because
568 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/widgets/modest-folder-view.c: (filter_row)
571 Do not show drafts folder (see UI specs)
573 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
575 * src/modest-ui-actions.c:
576 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
577 place and also not necessary.
579 * src/widgets/modest-folder-view.c: (filter_row)
580 Guess folder type and hide Sent & Outbox if necessary.
581 Fixed project.maemo.org NB#57328
583 2007-07-11 Murray Cumming <murrayc@murrayc.com>
585 * src/modest-ui-actions.h:
586 * src/modest-ui-actions.c:
587 (modest_ui_actions_on_delete_message):
588 Move some code into a new
589 modest_ui_actions_refresh_message_window_after_delete()
590 function so we can use it from elsewhere.
592 * src/dbus_api/modest-dbus-callbacks.c:
593 (on_idle_delete_message), (on_delete_message): Used an idle
594 handler, as we do for the other D-Bus method handlers.
595 Call modest_ui_actions_refresh_message_window_after_delete()
596 if the deleted message was open in a window. This fixed
597 projects.maemo.org bug NB#62862.
599 2007-07-11 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-main.c: (main): Only show the UI at the start if
602 the showui command line option was given. For instance,
603 run-standalone src/modest showui
604 Otherwise, we wait for the top_application D-Bus method to
605 be sent by hildon-desktop when the application is selected
607 This allows us to run without a UI when osso-global-search
608 uses our D-Bus methods.
610 2007-07-11 Murray Cumming <murrayc@murrayc.com>
612 * src/dbus_api/modest-dbus-api.h: Added a define for a
613 top-application D-Bus method.
614 * src/dbus_api/modest-dbus-callbacks.c:
615 (on_top_application),
616 (modest_dbus_req_handler): Handle the top-application D-Bus
617 method, which might be an undocumented D-Bus signal sent by
618 hildon-desktop when it starts the application from the menu.
619 But I am not sure and I need to test it on the device, because
620 my scratchbox does not have the application in the menu now.
621 This method shows the main window, so that it can be invisible
622 when started, for instance, just for email searching from
625 * src/maemo/modest-main-window.c: (restore_settings),
626 (modest_main_window_new): Do not show the window immediately
627 upon creation. We show it later.
628 * src/modest-widget-memory.c: (save_settings_paned):
629 Try (unsuccessfully) to avoid saving the paned position when
630 it is not even visible.
631 (restore_settings_paned): Do not allow a silly paned position.
632 This seems necessary when not showing the window at first.
634 * tests/dbus_api/Makefile.am:
635 * tests/dbus_api/test_top_application.c: (main): Test for the
638 2007-07-10 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-ui-dimming-rules.c:
641 (modest_ui_dimming_rules_on_new_msg),
642 (modest_ui_dimming_rules_on_reply_msg),
643 (modest_ui_dimming_rules_on_delete_msg),
644 (modest_ui_dimming_rules_on_details),
645 (modest_ui_dimming_rules_on_view_window_move_to),
646 (modest_ui_dimming_rules_on_view_previous),
647 (modest_ui_dimming_rules_on_view_next),
648 (_invalid_folder_for_purge): Added checks before
649 casting the window. This looks like an actual
650 logic error in _invalid_folder_for_purge(), because it
651 tries to use a ModestMainWindow as a message window.
653 2007-07-10 Murray Cumming <murrayc@murrayc.com>
655 * src/maemo/modest-account-settings-dialog.c:
656 (show_error): Use the same implementation as in
657 modest-easysetup-wizard.c:
658 (on_entry_invalid_character): The logical ID contains a %s.
659 Guessed what it should be.
660 (on_entry_max), (check_data), (on_response): Adapt to
661 changed show_error().
662 (create_page_account_details): Really call
663 modest_validating_entry_set_func() on the correct widgets.
664 * src/maemo/easysetup/modest-easysetup-wizard.c:
665 (on_entry_invalid_character): Fix the logical ID here too.
666 (create_page_account_details),
667 (create_page_user_details):
669 modest_validating_entry_set_func() on the correct widgets.
671 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
672 Do not try to use the account if it is NULL.
674 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
676 * src/modest-ui-actions.c: (create_move_to_dialog),
677 (modest_ui_actions_on_main_window_move_to),
678 (modest_ui_actions_on_msg_view_window_move_to):
679 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
680 (filter_row), (modest_folder_view_show_non_move_folders):
681 * src/widgets/modest-folder-view.h:
683 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
684 the Sent folder yet as it does not report the correct folder type.
686 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
688 * src/maemo/modest-msg-edit-window.c: (init_window):
691 2007-07-10 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
694 Take a parent widget instead of a parent window, and
695 implement this with hildon_banner_show_information() instead.
696 Non-Maemo builds can just ifdef that there.
697 This fixed projects.maemo.org bug NB#62766.
699 (on_entry_invalid_character): Use show_error() again instead
700 of using hildon directly, and use the _CS() macro to use the correct
702 (create_account), (check_for_supported_auth_methods), (on_entry_max):
703 Pass a widget instead od a window to show_error().
705 2007-07-10 Murray Cumming <murrayc@murrayc.com>
707 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
708 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
709 This allows us to show the server name in the error message, fixing
710 projects.maemo.org bug NB#62904.
711 Also, use the appropriate logical ID message for the account protocol.
713 2007-07-10 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-tny-account-store.c: (on_idle_wrong_password):
716 A compilation fix, though the build wasn't broken for me.
718 2007-07-09 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
721 Do not try to unref a NULL folder store, to avoid a runtime warning.
722 This seems to happen sometimes when changing accounts settings.
724 2007-07-09 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-tny-account-store.c:
727 (modest_tny_account_store_instance_init),
728 (modest_tny_account_store_finalize),
729 (on_account_settings_hide), (on_idle_wrong_password):
730 Use a GHashTable to ensure that we only show one account settings
731 dialog per modest account. This avoids us having a dialog open for
732 both the store and transport accounts, or due to repeated get_password()
733 calls that shouldn't happen anyway.
735 2007-07-09 Murray Cumming <murrayc@murrayc.com>
737 * src/maemo/modest-maemo-utils.c: (on_hide),
738 (modest_maemo_show_dialog_and_forget): Handle the response, because
739 the window is not even hidden by default.
741 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
742 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
743 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
744 which seems to prevent some modality problems.
746 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
747 Ignore user cancellation errors.
749 * src/modest-account-mgr-helpers.h:
750 * src/modest-account-mgr-helpers.c:
751 Added modest_server_account_get_password() and
752 modest_server_account_get_has_password() to avoid direct use of
755 * src/maemo/modest-account-settings-dialog.h:
756 * src/maemo/modest-account-settings-dialog.c:
757 (modest_account_settings_dialog_init): Store the notebook so we can
759 Added modest_account_settings_dialog_switch_to_user_info().
761 * src/modest-tny-account-store.c:
762 (get_password): When the password in the account settings is wrong (we think),
763 show the relevant page of the account settings dialog, in the mainloop.
764 However, we currently get many of these at once because cancel does not
766 (forget_password): Do not forget the password
767 from the account settings, because this causes side-effects when
768 tinymail seems to call it at strange time, maybe because of how we
769 are cancelling get_password().
770 (modest_tny_account_store_alert): Ignore user cancellations.
772 2007-07-09 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/modest-maemo-utils.h:
775 * src/maemo/modest-maemo-utils.c:
776 Added modest_maemo_show_information_note_and_forget() for use instead of
777 gtk_dialog_run() when the response is not needed, to avoid an extra
778 mainloop which could cause a hang.
780 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
781 Use the logical IDs for the error message, though they are not
782 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
783 because gtk_dialog_run() caused a hang here (the window did not close).
784 This fixes projects.maemo.org bug NB#62646.
786 2007-07-09 Murray Cumming <murrayc@murrayc.com>
788 * src/modest-account-mgr-helpers.h:
789 * src/modest-account-mgr-helpers.c:
790 Added modest_account_mgr_get_store_protocol().
792 * src/maemo/modest-account-view-window.c:
793 (on_delete_button_clicked): Show different warning text depending on
794 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
795 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
798 2007-07-09 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-msg-edit-window.c:
801 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
802 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
804 2007-07-07 Armin Burgmeier <armin@openismus.com>
806 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
807 ckdg_ib_maximum_characters_reached from correct package.
809 * src/modest-ui-actions.c: Show an error message when a folder could
810 not be created. Tinymail does not give us specific error codes about
811 what has gone wrong, so we assume that a folder with that name
812 already exists, though there might be other reasons.
814 2007-07-06 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
817 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
818 give a more exact error message that can be partly translated.
820 2007-07-05 Murray Cumming <murrayc@murrayc.com>
822 * src/maemo/modest-address-book.c:
823 (select_email_addrs_for_contact): Specify a default window size for the
824 select-email-address dialog, so that it is probably big enough for the
825 title. This should fix projects.maemo.org bug NB#62277.
827 2007-07-05 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/easysetup/modest-easysetup-wizard.c:
830 (create_page_complete_easysetup): Use
831 gtk_widget_set_size() request to ensure that the text wraps
834 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
836 * src/maemo/easysetup/modest-easysetup-wizard.c:
837 (on_entry_invalid_character), (create_page_account_details),
838 (create_page_user_details):
839 Use new API of ModestValidatingEntry. But for some reason the banner is
840 not shown. I will have to investigate that further.
842 * src/widgets/modest-validating-entry.c: (on_insert_text),
843 (modest_validating_entry_set_func):
844 * src/widgets/modest-validating-entry.h:
845 Added a new callback function to be able to react to prevented
846 characters whitespaces to e.g show a banner.
848 2007-07-05 Armin Burgmeier <armin@openismus.com>
850 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
851 notification of HildonNumberEditor instead of remembering the port
852 number. Thanks to Johannes for pointing this out.
854 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
856 * src/maemo/easysetup/modest-easysetup-wizard.c:
857 Check if there are any user changes before showing a confirmation
858 dialog (projects.maemo.org NB#60946)
860 2007-07-05 Armin Burgmeier <armin@openismus.com>
862 * src/maemo/modest-account-settings-dialog.c: Remember custom port
863 number at the beginning of the dialog and set the modified flag at the
864 end if the port number has changed. This is necessary because
865 HildonNumberEditor does not support notification when the value has
868 2007-07-05 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-ui-actions.c:
871 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
872 a connection before asking anything else. Correct the check for the destination
873 folder so that it succeeds when online.
874 This fixed projects.maemo.org bug NB#61645.
876 2007-07-05 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
879 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
880 to fix projects.maemo.org bug NB#62439.
882 2007-07-05 Murray Cumming <murrayc@murrayc.com>
884 * src/modest-tny-account.c: (on_connection_status_changed):
885 Really do not use tny_device_force_offline() here. See the previous comment.
887 2007-07-04 Murray Cumming <murrayc@murrayc.com>
889 * src/modest-tny-account.c: (on_connection_status_changed):
890 Do not use tny_device_force_offline() when tinymail says that something
891 went wrong with the connection. It seems to report this unnecessarily.
893 2007-07-04 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/modest-connection-specific-smtp-window.c:
896 (modest_connection_specific_smtp_window_init):
897 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
898 does not seem to have any effect in osso 1.1 (though it works in
899 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
901 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
903 * src/maemo/modest-connection-specific-smtp-window.c:
904 Fix UI specification problems with projects.meamo.org NB#60479
906 2007-07-04 Murray Cumming <murrayc@murrayc.com>
908 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
909 clue when this has failed, because the error dialog is not always shown
910 (at least in earlier version).
912 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
913 GError message, because the generic error dialog is not helpful.
915 'This message is not currently available (can't let a new connection go online)'
916 when trying to open an IMAP message.
918 (_modest_ui_actions_open): Offer a connection when some messages would
919 have to be downloaded and we are offline.
921 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
923 * src/widgets/modest-folder-view.c:
924 Don't check for MERGE type anymore as we use the correct type
926 NOTE: For the last two changes you need to update your tinymail copy
927 because of API changes!
929 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
931 * src/modest-tny-local-folders-account.c:
932 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
933 (see projects.maemo.org NB#61580)
935 2007-07-04 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-tny-account.c: (on_connection_status_changed):
938 Commented out the call to modest_platform_connect_and_wait() because this
939 seems to always hang, and I would like to know if this is the only thing
940 that causes a hang when showing the connection dialog.
941 It is not very useful anyway.
943 2007-07-04 Murray Cumming <murrayc@murrayc.com>
945 * src/maemo/modest-msg-view-window.c:
946 (modest_msg_view_window_select_next_message):
948 * src/modest-platform.h:
949 * src/maemo/modest-platform.c:
950 Added modest_platform_connect_and_wait(), which calls
951 tny_maemo_conic_device_connect() always in the main thread, by calling it
952 in an idle handler and waiting for the idle handler to run. It should be
953 in the main thread because it uses GTK+ UI code. It just returns TRUE
954 if the device is already online.
956 There is some nasty code to ensure that subsequent calls to
957 modest_platform_connect_and_wait() just wait for the first one to finish,
958 by checking repeatedly in another idle handler. This is necessary,
959 because other threads (or even the main thread, via another idle handler)
960 can call modest_platform_connect_and_wait() while
961 modest_platform_connect_and_wait() is running.
963 (modest_platform_connect_and_wait_if_network_account),
964 (modest_platform_connect_and_wait_if_network_folderstore):
965 Convenience functions that calls modest_platform_connect_and_wait() if
966 the account or folder might want network access.
968 * src/modest-mail-operation.c:
969 (modest_mail_operation_update_account):
970 * src/modest-ui-actions.c: (download_uncached_messages),
971 (modest_ui_actions_on_rename_folder), (delete_folder),
972 (modest_ui_actions_on_main_window_move_to),
973 (modest_ui_actions_on_msg_view_window_move_to):
974 * src/widgets/modest-folder-view.c:
975 (drag_and_drop_from_folder_view):
976 Offer a connection if we are offline.
978 * src/modest-tny-account.c: (on_connection_status_changed):
979 Document this as only handling errors during network operations in progress,
980 and replace the idle code with a simple call to
981 modest_platform_connect_and_wait(), which does this instead.
983 2007-07-03 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-tny-account.c:
986 (modest_tny_account_get_special_folder): (util_on_idle),
987 Handle the GError so we can see when tny_folder_store_get_folders()
988 fails, as it currently does while something else is connecting.
990 Added util_run_in_main_thread_and_wait()
991 which uses an idlen handler and mainloop to ensure that the function
992 is called in the main thread.
993 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
994 to make sure that we call attempt the connection in the mainloop only,
995 which might solve some hangs.
997 2007-07-03 Murray Cumming <murrayc@murrayc.com>
999 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1000 be found by their display name. This is never useful.
1001 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1002 by its ID, instead of trying to use its ID as its display name.
1004 * src/modest-tny-account-store.h:
1005 * src/modest-tny-account.c:
1006 (modest_tny_account_get_special_folder): Add a g_warning() when
1007 tny_folder_store_get_folders() returns an empty list for the maildir.
1009 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1010 Add a g_warning() when this returns NULL, because that it not allowed
1013 2007-07-02 Armin Burgmeier <armin@openismus.com>
1015 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1016 note when trying to cancel the wizard. This fixes projects.maemo.org
1019 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1021 * src/modest-tny-account.h:
1022 * src/modest-tny-account.c:
1023 (modest_tny_account_new_from_server_account),
1024 (modest_tny_account_new_from_server_account_name),
1025 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1026 because this must now be set before setting the proto. This is usd in
1027 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1028 warning in camel_session_get_service() caused by
1029 tny_camel_transport_account_prepare().
1031 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1034 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1038 (modest_connection_specific_smtp_edit_window_init):
1040 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1041 of "changed" for now
1043 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-tny-account.c:
1046 (modest_tny_account_new_from_server_account):
1047 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1048 now uses to request a connection when it needs one, and which it uses
1049 to tell us that something is wrong with the connection, so we can force
1050 the accounts offline to prevent further problems.
1052 * src/modest-defs.h:
1053 * src/modest-init.c: (init_default_settings):
1054 * src/modest-mail-operation.c:
1055 (modest_mail_operation_update_account):
1056 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1057 This should not be necessary anymore. Do not set the conf key that
1058 determined this (it was always TRUE and not set anywhere else).
1060 * src/modest-ui-actions.h: Remove unused and unimplemented
1061 modest_ui_actions_on_online_toggle_toggled().
1063 2007-06-29 Murray Cumming <murrayc@murrayc.com
1065 * src/maemo/modest-main-window.c: (connect_signals):
1066 Don't connect to delete_event twice. Maybe this was harmless.
1068 2007-06-29 Murray Cumming <murrayc@murrayc.com
1070 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1071 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1072 Debug output to give some more clue when a folder move is not allowed.
1074 2007-06-28 Murray Cumming <murrayc@murrayc.com
1076 * src/modest-tny-account.c: (on_modest_file_system_info),
1077 (modest_tny_account_get_mmc_account_name):
1078 Always call the callback, without checking whether the name has changed.
1079 * src/widgets/modest-folder-view.c: (strings_are_equal),
1080 (on_model_foreach_set_name), (on_get_mmc_account_name),
1081 (text_cell_data): Compare the name here, and use the name from
1082 the account rather than from the
1083 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1084 if the name was changed after the account was added to the model.
1085 That's a tinymail bug but not one that I want to fix now.
1087 This finally fixes projects.maemo.org bug NB#59301.
1089 2007-06-27 Armin Burgmeier <armin@openismus.com>
1091 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1094 2007-06-27 Murray Cumming <murrayc@murrayc.com
1096 * src/modest-tny-account.h:
1097 * src/modest-tny-account.c:
1098 Added modest_tny_account_get_mmc_account_name(), to set the memory
1099 card name asynchronously for the given account and then notify.
1100 (modest_tny_account_new_for_local_folders): Use this new function instead
1101 of using hildon_file_system_info_async_new() directly.
1103 * src/widgets/modest-folder-view.c: (text_cell_data):
1104 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1105 gtk_tree_model_row_changed() when it is available.
1107 This should fix projects.maemo.org bug NB#59301.
1109 2007-06-27 Murray Cumming <murrayc@murrayc.com
1111 * src/modest-mail-operation.c: (update_account_thread),
1112 (get_msgs_full_thread): Fix typo failures in the revert
1115 2007-06-27 Murray Cumming <murrayc@murrayc.com
1117 * src/maemo/modest-maemo-global-settings-dialog.c:
1118 (idle_select_default_focus):
1119 * src/modest-mail-operation.c: (idle_notify_progress),
1120 (idle_notify_progress_once), (set_last_updated_idle),
1121 (update_account_thread), (get_msgs_full_thread):
1122 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1123 * src/widgets/modest-header-view.c:
1124 (idle_notify_headers_count_changed_destroy),
1125 (idle_notify_headers_count_changed):
1126 Reverted the additions of gdk_threads_enter/leave(), in case this
1127 helps with a startup hang on the device.
1129 2007-06-26 Armin Burgmeier <armin@openismus.com>
1131 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1132 for supported secure authentication methods from server by
1133 gtk_dialog_run(), saving CPU time and a potential race condition.
1135 2007-06-26 Armin Burgmeier <armin@openismus.com>
1137 * src/maemo/modest-maemo-utils.h:
1138 * src/maemo/modest-maemo-utils.c: Added a
1139 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1140 only error code to tell the calling code when the user canceled the
1143 * src/maemo/modest-account-settings-dialog.h:
1144 * src/maemo/modest-account-settings-dialog.c:
1145 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1146 message if the retrieval of secure authentication methods was canceled
1147 by the user. Perform the check before saving anything to configuration
1148 to not end up with half-committed configuration changes, do not show
1149 a "Saving to configuration failed" note when authentication methods
1150 could not be retrieved.
1152 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1155 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1157 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1158 Only return the first level of folders under accounts, because the
1159 osso-global-search UI spec doesn't want the rest.
1160 This fixed projects.maemo.org bug NB#61811.
1162 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-tny-account-store.c:
1165 * src/modest-tny-account-store.h:
1166 Added modest_tny_account_is_memory_card_account().
1167 * src/maemo/modest-main-window.c: (create_details_widget):
1168 Show the same information items for the memory card as we show for the
1169 local-folders, to fix projects.maemo.org bug NB#59307.
1171 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-tny-account-store.c: (get_password):
1174 Added some checks for NULL to maybe prevent crashes, though I think
1175 it was Philip's last commit that actually prevented the crash here
1176 when creating a first new account.
1177 But the new account is still not usable (no messages are shown)
1178 until a restart of the application.
1180 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1182 * src/maemo/modest-maemo-global-settings-dialog.c:
1183 (idle_select_default_focus):
1184 * src/modest-mail-operation.c: (idle_notify_progress),
1185 (idle_notify_progress_once), (idle_notify_update_account_queue),
1186 (set_last_updated_idle), (update_account_thread),
1187 (notify_get_msgs_full), (get_msgs_full_destroyer),
1188 (get_msgs_full_thread):
1189 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1190 * src/widgets/modest-header-view.c:
1191 (idle_notify_headers_count_changed_destroy),
1192 (idle_notify_headers_count_changed):
1193 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1194 all idle handlers, because some other thread could be blocking
1195 the GDK lock, so that it can do GUI stuff.
1197 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1199 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1200 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1201 (on_idle_send_receive), (on_idle_open_default_inbox):
1202 * src/maemo/modest-msg-edit-window.c:
1203 (modest_msg_edit_window_attach_file_noninteractive):
1204 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1205 to prevent a hang. I don't quite understand why these are necessary,
1206 beause we should already be in the main loop. I guess something outside
1207 of the main loop is taking the lock.
1209 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1210 we are really using URIs, and use files that are more likely to exist.
1212 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1214 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1215 necessary because configure.ac now defines different variables.
1217 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1219 * libmodest-dbus-client/libmodest-dbus-client.c:
1220 * libmodest-dbus-client/libmodest-dbus-client.h:
1221 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1222 libmodest_dbus_client_compose_mail() is what things actually use.
1224 * src/dbus_api/modest-dbus-api.h:
1225 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1226 * tests/dbus_api/Makefile.am:
1227 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1230 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-init.c: (modest_init_local_folders):
1233 For memory-card (or other non local-folders) maildir accounts,
1234 always create an Archive folder, so that there is somewhere to put
1235 messages. This should be less confusing, because the user does not need
1236 to guess that the need to create a folder.
1238 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1240 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1241 Fixed icon size by using (50, 50) which is the same as defined by
1244 2007-06-25 Armin Burgmeier <armin@openismus.com>
1246 * src/widgets/modest-window-mgr.c:
1247 * src/modest-init.c:
1248 * configure.ac: Correctly recognize hildon-notify presence and fixed
1249 the build without it being installed.
1251 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1253 * libmodest-dbus-client/libmodest-dbus-client.c:
1254 (libmodest_dbus_client_search): Fix the build. Sorry.
1255 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1256 (reply_forward_cb): Initialize variables to fix the build.
1258 * src/modest-tny-account-store.c:
1259 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1260 comparison (a silly typo) so that email search results can be opened
1261 when there are more than one account.
1263 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1265 * libmodest-dbus-client/libmodest-dbus-client.c:
1266 (libmodest_dbus_client_search),
1267 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1268 instead of 1 second, because the search gets folders and messages from
1269 the server, which can take a long time. When it times out,
1270 osso-global-search will report no results.
1272 We need to specify whether we should search only cached information
1273 (maybe with a user preference), and the osso-email-search-plugin
1274 API should really be improved to allow that option, and to allow results
1275 to be delivered asynchronously in batches.
1277 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1280 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1281 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1283 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1286 that is an empty string. D-Bus seems to give us these instead of NULL.
1288 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1290 * src/dbus_api/modest-dbus-callbacks.c:
1291 * src/maemo/easysetup/modest-easysetup-wizard.h:
1292 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1293 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1294 (modest_connection_specific_smtp_edit_window_init):
1295 * src/maemo/modest-maemo-global-settings-dialog.c:
1297 * src/maemo/modest-maemo-utils.c:
1298 (modest_maemo_utils_setup_images_filechooser):
1299 * src/maemo/modest-main-window.c: (create_details_widget):
1300 * src/maemo/modest-msg-edit-window.c:
1301 (modest_msg_edit_window_attach_file_noninteractive),
1302 (modest_msg_edit_window_color_button_change),
1303 (modest_msg_edit_window_set_zoom):
1304 * src/modest-mail-operation.c: (update_account_thread):
1305 * src/modest-tny-account-store.c:
1306 * src/modest-tny-account.c:
1307 * src/widgets/modest-global-settings-dialog.c:
1308 * src/widgets/modest-window.h:
1310 Fixed build on bora!
1312 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1314 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1315 * src/modest-search.c: (modest_search_folder),
1316 (modest_search_all_accounts): Actually search only in the specified folder,
1317 doing a simple match on the folder ID.
1318 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1319 and added some documentation.
1321 2007-06-22 Armin Burgmeier <armin@openismus.com>
1323 * src/maemo/modest-maemo-utils.h:
1324 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1325 modest_maemo_utils_get_supported_secure_authentication_methods.
1327 * src/maemo/easysetup/modest-easysetup-wizard.c:
1328 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1329 one occured, not just "Server does not support secure authentication".
1331 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-tny-account-store.c: (get_password):
1334 Restored the call to tny_account_set_user() because Philip seems to have
1335 stopped this from crashing (by not using the freed string). It still does
1336 not work, but now we can test it.
1338 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/modest-msg-edit-window.c: (init_window):
1341 Comment out use of an uninitialzed GtkScrolledWindow variable,
1342 to fix the build and stop a crash. Yet again.
1344 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-tny-account-store.c: (get_password):
1347 Remove the call to tny_account_set_user() because this actually crashes.
1348 As mentioned in the last commit, it is known to not work anyway.
1350 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-tny-account-store.c: (get_password):
1353 Use tny_account_set_username() to tell tinymail that the username might
1354 have changed too. But tinymail ignores this: see projects.maemo.org
1356 * src/modest-ui-actions.c:
1357 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1358 reset the connection when changing the username, and improve the comments.
1359 Save the changed username to gconf at least, so it is used when Modest is
1362 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1364 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1365 Do not use a query, so that we get all folders, including for POP and
1366 local-folders. They work as search criteria too.
1367 This fixes projects.maemo.org bug NB#57740.
1369 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1371 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1372 Comment out the use of hildon_notification_set_sound() because it is
1373 not declared, to fix the build. Warnings are serious, people.
1375 2007-06-21 Armin Burgmeier <armin@openismus.com>
1377 * src/maemo/modest-maemo-utils.h:
1378 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1379 modest_maemo_utils_get_supported_secure_authentication_methods()
1380 to query authentication methods for a specific user. This should fix
1381 projects.maemo.org bug NB#61369.
1383 * src/maemo/easysetup/modest-easysetup-wizard.c:
1384 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1387 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1389 * libmodest-dbus-client/libmodest-dbus-client.h:
1390 * libmodest-dbus-client/libmodest-dbus-client.c:
1391 (modest_dbus_message_iter_get_search_hit),
1392 (libmodest_dbus_client_search):
1393 Reorganised and commented this.
1394 Removed modest_search_hit_free() from the public API because it
1397 Added libmodest_dbus_client_get_folders() and
1398 modest_folder_result_list_free().
1400 * src/dbus_api/modest-dbus-api.h:
1401 * src/dbus_api/modest-dbus-callbacks.c:
1402 (modest_dbus_req_filter): Commented. Moved most code to
1403 on_dbus_method_search() and added on_dbus_method_get_folders().
1405 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1406 of the extra D-Bus handler.
1408 * tests/dbus_api/Makefile.am:
1409 * tests/dbus_api/test_get_folders.c: New test for
1410 libmodest_dbus_client_get_folders(). This seems to return an empty list
1411 at the moment. That could be the same error that causes the message list
1412 to be empty sometimes.
1413 This should help with projects.maemo.org bug NB#57740.
1415 2007-06-21 Armin Burgmeier <armin@openismus.com>
1417 * src/modest-mail-operation.c: Do not call
1418 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1419 notify the operation's end after having set the status to CANCELED for
1420 the operation queue to listen on. This fixes a deadlock when there
1421 were mail operations in the queue during its finalization.
1423 * src/modest-singletons.c: Reordered uninitialization of the account
1424 manager to happen after the mail operation queue was uninitialized
1425 because the mail operation's in the queue might still try to access
1426 the account manager (see modest_mail_operation_notify_end()). This
1427 fixes a potential crash when terminating the application.
1429 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-search.c:
1432 (search_mime_part_and_child_parts): Moved some code here so we
1433 can search recursively in child folders.
1434 (modest_search_folder): Search in the message as a mime part, instead
1435 of just its child mime parts.
1436 (read_chunk), (search_mime_part_ogs):
1437 Check how many bytes were read, to prevent an endless loop.
1438 Searching in message bodies now works. This finishes the fix for
1439 projects.maemo.org bug NB#61007.
1441 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1444 Add a g_warning when the item is not a folder.
1446 * src/modest-ui-dimming-rules.c:
1447 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1448 when selected item is not a folder (for instance, an account), because
1449 the UI spec only talks about folders.
1450 I am not sure what the UI spec wants, so this might not totally fix
1451 projects.maemo.org bug NB#60794.
1453 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1456 (load_from_file): Sort the list. The unsorted list would be more noticeable
1457 in non-English locales.
1459 * src/maemo/modest-msg-edit-window.c:
1460 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1461 warning and fix the build.
1463 * src/maemo/modest-progress-bar-widget.c:
1464 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1465 avoid a g_warning, and probably to avoid a crash.
1467 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-search.c: (modest_search_folder): Check for a GError
1470 when calling tny_folder_get_headers(), to show that this is not the cause
1473 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1475 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1476 Actually set the body query instead of the subject query.
1478 * src/modest-search.c: (search_mime_part_ogs),
1479 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1480 which would probably cause it to fail if we got this far.
1482 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1483 to simplify the code.
1484 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1485 be causing search-in-body to fail.
1487 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1489 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1491 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1492 Better debug message when the folder cannot be found.
1493 This should help with fixing projects.maemo.org bug #61287.
1494 * src/modest-search.c: (add_hit): Do not leak the furl string.
1496 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-ui-actions.c:
1499 (modest_ui_actions_on_folder_selection_changed):
1500 Do not special-case TNY_MERGE_FOLDER here, because
1501 modest_tny_folder_get_account() already does that. This fixes
1502 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1503 shown when the Outbox was selected).
1505 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1507 * libmodest-dbus-client/libmodest-dbus-client.c:
1508 (_dbus_iter_get_string_or_null): Initialize the string variable in
1509 case this helps with Dirk's crash.
1511 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1513 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1514 though it is not implemented yet (this function is maybe not even used),
1515 to avoid breaking ABI in future.
1516 * libmodest-dbus-client/libmodest-dbus-client.c:
1517 (get_attachments_string): Moved some code into this generic function.
1518 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1519 sends email. It is maybe not used.
1520 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1521 (on_send_mail): Use attachments.
1523 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1524 * src/maemo/modest-msg-edit-window.c:
1525 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1526 a filename before using it, to fix projects.maemo.org bug NB#58233.
1528 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1530 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1531 Initialize the continue_download variable to fix the build, and probably
1532 to fix randome behaviour.
1534 2007-06-18 Armin Burgmeier <armin@openismus.com>
1536 * src/modest-tny-send-queue.h:
1537 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1538 the queue so we can later show it in the UI. Replaced
1539 modest_tny_send_queue_msg_is_being_sent() by
1540 modest_tny_send_queue_get_msg_status().
1542 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1544 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1545 gpointer. This probably was not harmful, but just to be sure.
1547 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1549 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1550 Fix the build, but leave the function broken on Bora, because
1551 hildon_uri_action_get_service() does not exist.
1552 osso_uri_action_get_service() does not exist either, it seems.
1554 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1556 * src/modest-tny-account.c:
1557 (modest_tny_account_new_from_server_account):
1558 Uncommented the url debug output again, because it is useful for
1559 debugging, as I said in the comment.
1561 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1563 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1565 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1566 for Mameo Bora, to fix the build.
1568 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1571 Fixed build with hildon < 0.99
1573 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1574 Check if the selected account is busy instead of checking all accounts
1576 * src/modest-account-mgr-priv.h:
1577 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1578 (modest_account_mgr_init), (compare_account_name),
1579 (modest_account_mgr_set_account_busy),
1580 (modest_account_mgr_account_is_busy):
1581 * src/modest-account-mgr.h:
1582 Added busy information to the account manager. It possible to
1583 set an account to busy or not busy now.
1585 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1586 (modest_mail_operation_update_account),
1587 (modest_mail_operation_notify_end):
1588 Set the account to busy/not busy depending on the operation state.
1590 * src/widgets/modest-account-view.c:
1591 (modest_account_view_finalize), (get_last_updated_string),
1592 (update_account_view), (on_account_busy_changed), (init_view):
1593 Show string "Refreshing..." if the account is currently busy.
1595 All this fixes projects.maemo.org bug NB#59711
1597 2007-06-14 Armin Burgmeier <armin@openismus.com>
1599 * src/widgets/modest-attachments-view.h:
1600 * src/widgets/modest-attachments-view.c: Added
1601 modest_attachments_view_has_attachments() and fixed coordinate
1602 transformation in get_att_view_at_coords(). This fixes attachment
1605 * src/widgets/modest-msg-view.c: Make use of
1606 modest_attachments_view_has_attachments() to decide whether to show
1607 attachments in the header.
1609 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1612 (on_change), (on_combo_security_changed),
1613 (modest_connection_specific_smtp_edit_window_init),
1614 (modest_connection_specific_smtp_edit_window_set_connection),
1615 (modest_connection_specific_smtp_edit_window_is_dirty):
1616 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1617 * src/maemo/modest-connection-specific-smtp-window.c:
1620 Show an comfirmation dialog for the smpt-edit-window if there are
1621 unsaved changes and the user hits cancel.
1622 (projects.maemo.org bug NB#60479)
1624 2007-06-14 Armin Burgmeier <armin@openismus.com>
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1628 address" info in banner instead of node, and select all the text as
1629 per UI spec. This fixes projects.maemo.org bug NB#60550.
1631 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1633 reviewed by: <delete if not using a buddy>
1635 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1636 * src/modest-ui-actions.c: (folder_refreshed_cb):
1638 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1640 * src/widgets/modest-folder-view.c: (filter_row):
1641 Explictly filter out the per-account outbox accounts. I don't know why
1642 these only sometimes show up, but now they should never show up in the UI.
1643 This should fix projects.maemo.org bug NB#60160.
1645 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1648 when the toolbar does not exist yet.
1649 * src/modest-widget-memory.c: (save_settings_header_view):
1650 Added g_warnings() to help us to discover when we are trying to set
1651 an empty columns list in gconf.
1653 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1655 * src/modest-init.h:
1656 * src/modest-init.c:
1657 Added modest_init_get_default_header_view_column_ids().
1659 * src/modest-widget-memory.c: (restore_settings_header_view):
1660 Use the new function to get defaults, if the gconf key is empty,
1661 instead of not creating any columns. This seems to fix the
1662 empty right-hand pane problems.
1664 * src/widgets/modest-header-view.h: Improved documentation.
1666 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1669 Revert the use of the display name as the account name, because this
1670 is generally wrong and would break the code that follows.
1672 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1674 * src/maemo/easysetup/modest-easysetup-wizard.c:
1675 (check_for_supported_auth_methods), (on_before_next),
1678 More correct fix for projects.maemo.org bug NB# 58991
1679 Do not longer accept AUTH_PASSWORD as secure method and choose
1680 correct method when creating the account.
1682 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1684 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1685 Fixed projects.maemo.org bug NB# 58991
1687 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1689 * src/modest-init.c: (modest_init_init_core),
1690 (modest_init_local_folders): Fixed compilation errors.
1692 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1694 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1695 Remove unnecessary lib/include, though it is good in principle when needed.
1697 * src/modest-init.c: (modest_init_one_local_folder),
1698 (modest_init_local_folders):
1699 * src/modest-init.h: Initialize the .modest library for memory cards,
1700 instead of just doing nothing for them. This should allow us to create
1701 folders there, fixing projects.maemo.org bug NB#59297.
1703 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1705 * libmodest-dbus-client/libmodest-dbus-client.c:
1706 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1707 (libmodest_dbus_client_compose_mail),
1708 (libmodest_dbus_client_open_message),
1709 (libmodest_dbus_client_send_and_receive),
1710 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1712 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1713 (on_idle_open_message), (modest_dbus_req_handler),
1714 (search_result_to_message), (modest_dbus_req_filter):
1715 * src/modest-search.c: (add_hit), (modest_search_folder),
1716 (modest_search_all_accounts): Improved debug messages.
1718 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1720 * src/modest-tny-account-store.c:
1721 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1724 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1727 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-tny-account-store.c: (get_server_accounts):
1730 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1731 even when there are no accounts, so that the Outbox folder is always
1732 visible. This fixes projects.maemo.org bug NB#60158.
1734 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1736 * src/maemo/modest-main-window.c: (create_details_widget):
1737 Use the mcen_va_never logical ID.
1739 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1741 * src/dbus_api/modest-dbus-api.h:
1742 * src/dbus_api/modest-dbus-callbacks.c:
1743 (on_idle_open_default_inbox), (on_open_default_inbox),
1744 (modest_dbus_req_handler):
1745 Added a new OpenDefaultInbox method.
1747 * libmodest-dbus-client/libmodest-dbus-client.h:
1748 * libmodest-dbus-client/libmodest-dbus-client.c:
1749 Added libmodest_dbus_client_open_default_inbox() to call the new
1750 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1751 though it should maybe be used by a new osso-email-interface function.
1753 * tests/dbus_api/Makefile.am:
1754 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1757 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1759 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1760 NULL, so that the signals get all the keys. This should not actually
1761 change any behaviour because we currently update everything when anything
1764 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1766 * src/widgets/modest-folder-view.c: (text_cell_data),
1767 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1768 (find_inbox_iter): If tinymail tells us that the folder is
1769 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1770 This causes the inbox to be selected at startup, fixing part of
1771 projects.maemo.org bug NB#56305.
1773 * src/modest-ui-dimming-rules.c:
1774 (modest_ui_dimming_rules_on_tools_smtp_servers):
1775 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1776 the SMTP servers menu item.
1777 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1778 that the SMTP Servers menu item is dimmed when there are no accounts,
1779 as a future version of the UI spec will require. This fixes
1780 projects.maemo.org bug NB#56305.
1782 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1784 * src/maemo/modest-maemo-utils.c:
1785 (modest_maemo_utils_get_supported_secure_authentication_methods):
1786 Added label to dialog instead of unreadable title
1788 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1789 (modest_main_window_new):
1790 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1793 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1794 * src/modest-account-mgr.h:
1795 Added method to avoid code duplication
1797 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1798 (modest_ui_actions_on_send_receive):
1799 Use modest_account_mgr_has_accounts
1801 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1803 * src/maemo/easysetup/modest-presets.c:
1804 (modest_presets_get_info_server_security): Do not report secure auth
1806 * src/modest-protocol-info.c: Use the defines for the gconf key names
1807 for secure authentication. This was not working because we were writing
1808 Password and reading password, and the check was case sensitive.
1809 With this, gmail now works for receiving and sending when created via
1812 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/easysetup/modest-presets.c:
1815 (modest_presets_get_info_server_security): Correct the key name for
1816 SecureSmtp, because it seems to be case-sensitive.
1817 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1818 Do not try to get the 0th notebook page if there are 0 pages, to
1819 avoid a g_warning().
1821 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1823 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1824 Prevent use of the new notification feature for now, because it currently
1825 shows one dialog for each new email, which is annoying.
1827 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1830 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1831 when no country was selected, so that we show the global ones.
1832 * src/maemo/easysetup/modest-presets.c:
1833 (modest_presets_get_providers): Return only the global providers, not
1834 all providers when mmc=0 was requested.
1836 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1838 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1839 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1840 provider ID in the combo.
1842 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1843 Do not show the page numbers, because it would be confusing when we add
1844 the 2 extra pages for the custom setup, when the user chooses the "Other"
1845 provider. This fixes projects.maemo.org bug NB#59028
1847 * src/modest-init.c: (modest_init_init_core),
1848 (modest_init_local_folders):
1849 * src/modest-init.h:
1850 * src/modest-tny-account.c:
1851 (modest_tny_account_new_for_local_folders): Do not create default folders
1852 for the memory card. This should fix projects.maemo.org bug NB#59328.
1854 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1857 Free the changed_conf_keys string items. They are already freed in the
1858 idle handler if that runs first.
1860 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1862 * src/modest-ui-actions.c:
1863 (modest_ui_actions_on_password_requested): Check that the server name
1864 is not NULL, because I just saw a password dialog with (null) as the
1867 * src/modest-tny-folder.[h|c]: Added
1868 modest_tny_folder_is_memory_card_folder().
1869 * src/modest-ui-dimming-rules.c:
1870 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1871 menu item for memory cards, as per the UI spec (section 7.4). This should
1872 fix projects.maemo.org bug NB#59297.
1874 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1876 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1877 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1878 is another problem with the code, see Murray's comment at line 772)
1880 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1882 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1883 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1884 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1885 (load_from_file), (easysetup_country_combo_box_init),
1886 (easysetup_country_combo_box_get_active_country_ids),
1887 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1888 instead of just one ID, to avoid duplicate country names in the UI.
1890 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1891 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1892 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1893 a single ID, avoiding duplicate providers.
1894 * src/maemo/easysetup/modest-easysetup-wizard.c:
1895 (on_combo_account_country): Adapt to use a list.
1897 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1899 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1900 keys changed in the last X seconds.
1902 * src/modest-account-mgr.h:
1903 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1904 (on_key_change), (modest_account_mgr_class_init),
1905 (modest_account_mgr_init), (modest_account_mgr_finalize):
1906 As the keys are changed, save them in a GSList* and signal that GSList*
1907 further every X seconds, to batch changes, to allow us to do just one
1908 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1909 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1911 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1912 changed signal signature.
1914 * src/modest-conf.c: (modest_conf_set_list),
1915 (modest_conf_on_change): Reenable notification.
1917 (modest_conf_maemo_fake_on_change): Comment out the hack that
1918 notified immediately instead of asynchronously.
1920 * src/widgets/modest-account-view.h:
1921 * src/widgets/modest-account-view.c:
1922 (update_account_view): Select the previously-selected account ID,
1923 if possible. This fixes projects.maemo.org bug NB#56933.
1925 (on_account_changed), (on_account_removed),
1926 (modest_account_view_select_account):
1928 Remove the block/unblock functions
1929 because they were not useful.
1931 * src/maemo/modest-account-view-window.c:
1932 (on_delete_button_clicked), (on_edit_button_clicked),
1933 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1935 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1937 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1938 Improve the error dialog to show Incorrect Account Settings, which seems
1939 clearer, and say that the internal error message (to be removed from the
1940 dialog later) is often misleading.
1941 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1943 * src/modest-tny-account.c:
1944 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1945 URL because this is so useful for debugging on the device.
1947 * src/widgets/modest-serversecurity-combo-box.c:
1948 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1950 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1952 * src/modest-mail-operation.c:
1953 (modest_mail_operation_send_new_mail):
1954 Added a comment about a nasty but apparently harmless message. Details
1955 added to the wiki g_warnings() page.
1957 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1960 (modest_tny_send_queue_class_init):
1961 Do not use the priv struct because it is empty, to avoid g_warnings
1962 about a non-existant priv struct.
1964 * src/modest-tny-account-store.c:
1965 (modest_tny_account_store_get_server_account),
1966 (modest_tny_account_store_get_transport_account_for_open_connection
1967 ): Do not try to get transport server accounts for local folders,
1968 because they don't have any. This avoids a g_warning().
1970 * src/maemo/modest-main-window.c:
1971 (modest_main_window_notify_send_receive_initied),
1972 (on_configuration_key_changed):
1973 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1974 * src/modest-defs.h:
1975 * src/modest-mail-operation.c:
1976 (modest_mail_operation_update_account):
1977 * src/modest-tny-account-store.h:
1978 * src/modest-tny-account.c:
1979 (modest_tny_account_get_special_folder),
1980 (modest_tny_account_new_for_local_folders),
1981 (modest_tny_account_new_for_per_account_local_outbox_folder):
1982 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1983 * src/modest-tny-local-folders-account.c:
1984 (add_account_folders_to_merged_folder):
1985 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1986 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1987 (modest_ui_actions_on_send):
1988 * src/widgets/modest-folder-view.c: (update_model):
1989 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1990 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1991 modest_tny_account_store_get_tny_account_by_account() to
1992 modest_tny_account_store_get_server_account() to make the code clearer.
1994 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1996 * src/dbus_api/modest-dbus-api.h:
1997 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1998 * src/maemo/modest-msg-edit-window.c:
1999 (modest_msg_edit_window_attach_file_noninteractive):
2000 added g_warning in case the file to be attached does not exist
2001 * tests/dbus_api/test_compose_mail.c: (main):
2002 removed obsolete comment, added generic files as test case
2004 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-tny-account-store.c: (get_server_accounts):
2007 Create the local folders account only once, not once for each outbox, and
2008 not only when there are some outboxes.
2010 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2012 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2013 code that is causing a crash at startup. Sergio says that he is fixing this.
2015 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2017 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2018 * src/maemo/modest-account-settings-dialog.c:
2019 (create_page_outgoing),
2020 (modest_account_settings_dialog_set_account_name),
2021 (save_configuration):
2022 - Fixed handling of the "Use secure authentication" toggle to comply with
2023 the ui specification. See also projects.maemo.org bug NB#58400
2025 - Restore the Secure connection setting combo correctly when loading
2028 * src/maemo/modest-maemo-utils.c:
2029 (on_camel_account_get_supported_secure_authentication),
2030 (modest_maemo_utils_get_supported_secure_authentication_methods):
2031 Fixed a crasher if operation is canceled
2033 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2034 (modest_protocol_info_auth_is_secure):
2035 * src/modest-protocol-info.h:
2037 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2038 the sense of the "Use secure authentication" toggle.
2040 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2042 * src/modest-tny-account-store.h:
2043 * src/modest-tny-account-store.c:
2044 Added modest_tny_account_store_get_local_folders_account().
2046 * src/modest-tny-folder.h:
2047 * src/modest-tny-folder.c:
2048 (modest_tny_folder_get_account):
2049 Added this replacement for tny_folder_get_account() which returns
2050 the local-folders account for TnyMergeFolders, to avoid the
2051 warning about the unimplemented get_account_func() vfunc().
2053 (modest_tny_folder_get_rules),
2054 * src/modest-ui-actions.c:
2055 (modest_ui_actions_on_folder_selection_changed):
2056 * src/modest-mail-operation.c:
2057 (modest_mail_operation_remove_folder),
2058 (modest_mail_operation_xfer_folder),
2059 (modest_mail_operation_rename_folder),
2060 (modest_mail_operation_get_msg),
2061 (modest_mail_operation_get_msgs_full),
2062 (modest_mail_operation_remove_msg),
2063 (modest_mail_operation_xfer_msgs),
2064 (modest_mail_operation_refresh_folder):
2065 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2067 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2070 (modest_server_account_set_security):
2071 * src/modest-defs.h: Add comments explaining that our
2072 UI spec means TLS when it says Normal, so these do not look like errors.
2074 * src/modest-tny-account.c:
2075 (modest_tny_account_new_from_server_account): Use the new tinymail
2076 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2077 for TLS. This should fix projects.maemo.org bug NB#58460.
2079 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/easysetup/modest-easysetup-wizard.c:
2082 (create_account): Correct the position of the gconf sanity check warning.
2083 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2084 of using the g_idle_add() hack, because this does not seem to be necessary
2085 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2086 caused by something other than maemo's gconf.
2087 This fixes projects.maemo.org bug #59022.
2089 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-account-mgr-helpers.c:
2092 (modest_account_mgr_get_default_account): Do not check that the account
2093 exists if there is no default account (NULL), to fix a runtime warning.
2095 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2097 * src/widgets/modest-folder-view.c: (update_model):
2098 Do not unref the treemodel before we have finished with it.
2099 This prevents a valgrind warning and an occasional crash at startup.
2101 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2103 * libmodest-dbus-client/libmodest-dbus-client.h:
2104 added libmodest_dbus_client_compose_mail()
2105 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2107 added functions needed for SendAsMail() functionality
2108 * src/maemo/modest-msg-edit-window.c:
2109 (modest_msg_edit_window_attach_file_noninteractive):
2110 non interactively attaching files to message edit window
2111 * src/widgets/modest-msg-edit-window.h:
2112 * tests/dbus_api/Makefile.am:
2113 added test_compose_mail.c
2114 * tests/dbus_api/test_compose_mail.c: (main):
2116 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2118 * src/modest-account-view.c:
2119 Fixed bug projects.maemo.org bug NB#59307
2121 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2123 * src/maemo/easysetup/modest-easysetup-wizard.c:
2124 (get_serverport_incoming), (on_before_next), (create_account):
2125 * src/maemo/modest-account-settings-dialog.c:
2126 (modest_account_settings_dialog_set_account_name):
2127 * src/maemo/modest-maemo-utils.c:
2128 (on_camel_account_get_supported_secure_authentication_status),
2129 (on_camel_account_get_supported_secure_authentication),
2130 (on_secure_auth_cancel),
2131 (modest_maemo_utils_get_supported_secure_authentication_methods):
2133 Implemented security authentication for settings and easysetup.
2135 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2137 * src/maemo/modest-main-window.c: (create_details_widget):
2138 Show the total size for memory card accounts too, instead of showing
2139 the name again. Fixes bug projects.maemo.org bug NB#59307.
2141 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2144 * src/modest-tny-simple-folder-store.c:
2145 * src/modest-tny-simple-folder-store.h: Removed.
2147 * src/modest-tny-local-folders-account.h
2148 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2149 for the local-folders maildir, with an extra TnyMergedFolder containing
2150 the folders of the per-account outbox store accounts.
2151 * src/modest-tny-account-store.c: (get_server_accounts):
2152 Add the outboxes to the special local folders account after creating it.
2154 * src/modest-tny-account.c:
2155 (modest_tny_account_new_for_local_folders): Create the derived
2156 account when creating the main local-folders account.
2158 * src/maemo/modest-main-window.c: (create_details_widget),
2159 (modest_main_window_set_contents_style):
2160 Adapted to the use of the derived account instead of the folder store.
2162 * src/modest-ui-actions.c:
2163 (modest_ui_actions_on_folder_selection_changed):
2164 * src/modest-ui-dimming-rules.c:
2165 (modest_ui_dimming_rules_on_new_folder):
2166 * src/widgets/modest-folder-view.c: (text_cell_data),
2167 (icon_cell_data), (filter_row), (update_model),
2168 (get_cmp_rows_type_pos):
2171 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2172 Do not get the priv struct, because no priv struct has been set,
2173 to avoid a runtime warning.
2175 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2176 #ifelse with #else, to fix a warning, to fix the build.
2179 2007-06-05 Christian Kellner <ckellner@openismus.com>
2181 * libmodest-dbus-client/libmodest-dbus-client.c:
2182 Fix small typo in doc (why do you always see them
2183 AFTER committing stuff?)
2186 2007-06-05 Christian Kellner <ckellner@openismus.com>
2188 * libmodest-dbus-client/libmodest-dbus-client.c:
2189 (libmodest_dbus_client_search):
2190 Initialize hit list with NULL. Also set folder list
2191 to "" if NULL was supplied.
2194 2007-06-03 Christian Kellner <ckellner@openismus.com>
2196 * libmodest-dbus-client/libmodest-dbus-client.c:
2197 (modest_search_hit_list_free):
2198 Make it save to call it with NULL.
2200 * src/dbus_api/modest-dbus-callbacks.c:
2201 * src/modest-search.c:
2202 Return full ModestSearchHits as the search result list not TnyHeader
2203 since can't be around withouth the correspoding TnyFolder.
2205 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2207 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2208 Added currently commented code to check for secure auth
2210 * src/maemo/modest-account-settings-dialog.c: (on_response),
2211 (save_configuration), (show_ok):
2212 Fixed projects.maemo.org bugs NB #59248 and #59251
2214 * src/maemo/modest-maemo-utils.c:
2215 (on_camel_account_get_supported_secure_authentication_status),
2216 (on_camel_account_get_supported_secure_authentication),
2217 (modest_maemo_utils_get_supported_secure_authentication_methods):
2218 * src/maemo/modest-maemo-utils.h:
2219 Moved get_supported_secure_authentication() method here to be able
2220 to use it from easysetup wizard.
2222 * src/modest-pair.c: (on_pair_compare_as_string):
2223 Should compare string with first part of pair and not
2224 strcmp pairs which will crash.
2226 * src/modest-protocol-info.c:
2227 (modest_protocol_info_protocol_is_store):
2228 * src/modest-protocol-info.h:
2229 Added modest_protocol_info_get_auth_protocol_name()
2231 2007-06-03 Armin Burgmeier <armin@openismus.com>
2233 * src/modest-mail-operation.c:
2234 (modest_mail_operation_get_msgs_full): Set priv->account also when
2235 only retrieving a single message. This avoids a crash when canceling
2238 (modest_mail_operation_notify_end): Do not explicitely remove the
2239 operation from the queue but only emit the progress_changed signal.
2240 The queue itself listens to that signal to remove the operation when
2241 it is finished. This reduces coupling and removes a potential deadlock
2242 when modest_mail_operation_notify_end() is called from the queue
2243 itself. If that is a problem performance-wise, I would suggest to
2244 implement a status-changed signal or something.
2246 * src/modest-mail-operation-queue.c: Make sure to never call a
2247 function from another file while the queue is locked. This (hopefully)
2248 fixes another deadlock when exiting the application while retrieving
2251 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2253 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2254 Fixed build if libogs is not available
2256 2007-06-03 Christian Kellner <ckellner@openismus.com>
2258 * libmodest-dbus-client/libmodest-dbus-client.h:
2259 * libmodest-dbus-client/libmodest-dbus-client.c:
2260 (libmodest_dbus_client_delete_message):
2261 Implement deletion of messages (Client side).
2263 (modest_search_hit_free),
2264 (modest_search_hit_list_free):
2265 Utility functions to free the result hits.
2267 * src/dbus_api/modest-dbus-api.h:
2268 * src/dbus_api/modest-dbus-callbacks.c:
2269 (on_delete_message),
2270 (modest_dbus_req_handler):
2271 Implement deletion of messages (Server side).
2273 * tests/dbus_api/test_search.c: (main):
2276 * tests/dbus_api/Makefile.am:
2277 * tests/dbus_api/test_delete_message:
2278 Add little test for the message deletion logic
2280 2007-06-03 Armin Burgmeier <armin@openismus.com>
2282 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2283 when the operation queue was not empty. projects.maemo.org bug
2286 2007-06-03 Armin Burgmeier <armin@openismus.com>
2288 * src/widgets/modest-account-view.c
2289 (on_account_default_toggled): Toggle default account column
2290 explicitely instead of waiting for gconf notification (which is
2291 currently ignored). This should fix projects.maemo.org bug NB#56910
2292 for now. It should probably be removed when gconf notifications are
2295 2007-06-03 Christian Kellner <ckellner@openismus.com>
2297 * libmodest-dbus-client/libmodest-dbus-client.c:
2298 Removed debugging spew.
2300 * src/dbus_api/modest-dbus-callbacks.c:
2301 Added debugging info.
2303 * src/modest-search.c:
2304 (modest_search_all_accounts):
2305 Use tny_account_store_get_accounts () on the account store
2306 to get all accounts which is the way to get all accounts.
2308 * tests/dbus_api/test_search.c: (main):
2309 Make it possible to supply the search term on the command line.
2311 2007-06-03 Christian Kellner <ckellner@openismus.com>
2313 * libmodest-dbus-client/libmodest-dbus-client.c:
2314 * libmodest-dbus-client/libmodest-dbus-client.h:
2315 Implement searching for mesages over raw dbus. (Client side)
2317 * src/dbus_api/Makefile.am:
2318 * src/dbus_api/modest-dbus-api.h:
2319 * src/dbus_api/modest-dbus-callbacks.c:
2320 * src/dbus_api/modest-dbus-callbacks.h:
2321 Search framework (Server side). Also implement on_idle_open_message().
2323 * src/maemo/modest-platform.c: (modest_platform_init):
2324 Prepare for raw dbus/osso rpc interaction.
2326 * src/modest-search.h:
2327 Changed minsize from unspecific guint to guint32.
2329 * src/modest-search.c:
2331 Added strange hack which magically made tnymail work.
2333 (modest_search_folder),
2334 (modest_search_account),
2335 (modest_search_all_accounts):
2336 Implement helper functions to search all accounts, specific account
2339 * tests/dbus_api/Makefile.am:
2340 * tests/dbus_api/test_open_message.c:
2341 Read url to open from commandline.
2343 * tests/dbus_api/test_search.c:
2344 Implement small test for dbus search stuff
2346 2007-06-02 Armin Burgmeier <armin@openismus.com>
2348 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2349 include account type and account title. This fixes projects.maemo.org
2352 * src/maemo/modest-account-view-window.c: Set a title for the window.
2354 2007-06-02 Armin Burgmeier <armin@openismus.com>
2356 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2357 incoming and outgoing server name based on email address and server
2358 types as long as the names have not been edited manually. This fixes
2359 projects.maemo.org bug NB#58671.
2361 2007-06-02 Armin Burgmeier <armin@openismus.com>
2363 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2364 server type cannot be changed in future to the incoming details page
2365 when creating an account. This fixes projects.maemo.org bug NB#59029.
2367 2007-06-02 Armin Burgmeier <armin@openismus.com>
2369 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2370 and assigned max width chars so that they wrap instead of being
2371 truncated. Fixes projects.maemo.org bug NB#56126.
2373 2007-06-02 Armin Burgmeier <armin@openismus.com>
2375 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2376 introductory note to the connection specific smtp servers dialog, as
2377 section 8.12 of the email UI specification requires. This fixes
2378 projects.maemo.org bug NB#59212.
2380 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2383 Check for running mail operations, and offer to cancel them, as per the UI
2384 spec. This fixes projects.maemo.org bug NB#59041 .
2385 However, I suspect that tinymail may still use the network connection
2386 in ways that we cannot detect or cancel. But it should at least adapt to
2387 changes fairly well.
2389 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-tny-account-store.c: (recreate_all_accounts),
2392 (get_cached_accounts), (get_server_accounts): Do more sensible
2393 ref-counting of the temporarily-cached outbox accounts list. This seems
2394 to fix a crash when entering the password when the password was wrong.
2396 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2398 * src/gnome/modest-main-window.c: (connect_signals):
2399 * src/modest-tny-account-store.c: (get_password),
2400 (modest_tny_account_store_alert): Added comments and clues and
2401 commented-out code about how we currently fail to deal with connection
2402 errors and wrong passwords, and how we should.
2404 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2406 * src/widgets/modest-retrieve-combo-box.c:
2407 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2408 This fixes projects.maemo.org bug NB#58472 .
2410 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2412 * src/maemo/easysetup/modest-easysetup-wizard.c:
2413 (create_page_complete_easysetup):
2414 (create_page_complete_custom): Correct the last commit,
2415 putting the correct sentences in the correct pages.
2417 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2419 * src/maemo/easysetup/modest-easysetup-wizard.c:
2420 (create_page_complete_custom): Show the second sentence of text
2421 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2424 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2426 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2427 Set the leave-on-server conf key by default. This fixes
2428 projects.maemo.org bug NB#59258 .
2430 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-account-view-window.c:
2433 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2434 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2437 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/easysetup/modest-easysetup-wizard.c:
2440 (create_caption_new_with_asterisk):
2441 * src/maemo/modest-account-settings-dialog.c:
2442 (create_caption_new_with_asterisk):
2443 Uncomment the code to add the asterisk, because they are no longer in the
2444 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2445 (update_incoming_server_title): Add an asterisk here too.
2447 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/modest-maemo-global-settings-dialog.c:
2450 (current_connection): Check that we are even connected before trying to
2451 get the current connection name, to prevent a warning.
2453 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2454 Change the comments because tny_maemo_conic_device_connect() is now meant to
2456 * src/modest-mail-operation.c:
2457 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2458 make sure we have a connection and fail if we can't connect.
2460 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/modest-main-window.c:
2463 (on_account_store_connecting_finished): Do not try to get the
2464 connection ID if we are not really connected. I am surprised that
2465 this signal handler is called when we are not connected.
2467 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2469 * src/modest-error.h:
2470 * src/modest-ui-actions.c:
2471 (modest_ui_actions_get_msgs_full_error_handler):
2472 Renamed an enum, added comments, added an enum
2473 for retrieve-limit errors.
2475 * src/modest-mail-operation.c: (foreach_add_item),
2476 (internal_folder_observer_update), (update_account_thread),
2477 (modest_mail_operation_get_msgs_full):
2478 (modest_mail_operation_update_account),
2479 Added comments about how this works, and some code that should
2480 (but does not) check the retrieve-limit. See the TODO comment.
2482 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2485 Initialize help_id to fix the build. Warnings are good.
2487 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2489 * src/widgets/modest-hbox-cell-renderer.c:
2490 (modest_hbox_cell_renderer_append):
2491 * src/widgets/modest-vbox-cell-renderer.c:
2492 (modest_vbox_cell_renderer_append):
2493 Fix the last commit by doing an extra ref.
2495 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2497 * src/widgets/modest-hbox-cell-renderer.c:
2498 (modest_hbox_cell_renderer_append):
2499 * src/widgets/modest-vbox-cell-renderer.c:
2500 (modest_vbox_cell_renderer_append):
2501 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2502 to fix the build with Maemo Bora.
2503 However, there seems to be a remaining crash, probably due to reference
2506 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2508 * src/modest-tny-account.c:
2509 (modest_tny_account_new_for_local_folders):
2510 Use hildon_file_system_info_async_new() to get a better name for
2511 the memory card account, setting it as the account name.
2512 The timing seems to work, but this is probably
2513 not the best place to do this. See the TODO comment.
2514 * src/maemo/modest-main-window.c: (create_details_widget):
2515 * src/widgets/modest-folder-view.c: (text_cell_data):
2516 Use the tny account name instead of hardcoding a name.
2518 2007-05-30 Christian Kellner <ckellner@openismus.com>
2520 * src/modest-search.c: (modest_search):
2521 Correctly set part_search_func even if we have already parsed
2522 the query and thus a valid OgsTextSearcher object.
2524 2007-05-30 Christian Kellner <ckellner@openismus.com>
2527 Search and check for libogs.
2530 Incooparte the ogs build env.
2532 * src/modest-mime-part-search-stream.c:
2533 * src/modest-mime-part-search-stream.h:
2534 Removed since we do the real searching now in modest-search.c.
2536 * src/modest-search.c:
2537 * src/modest-search.h:
2538 Implement support for ogs. We use that if available and requested
2539 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2540 should now handle the corner case when the search term is spread
2541 across multiple reads.
2542 Also the logic in modest_search () was corrected to search all
2543 requested fields until one is found.
2545 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2547 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2549 * src/modest-init.h:
2550 * src/modest-init.c: Made modest_init_local_folders() take a
2551 path and be public so we can iniitialize maildir folders on
2554 * src/modest-local-folder-info.h:
2555 * src/modest-local-folder-info.c:
2556 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2558 * src/modest-tny-account.c:
2559 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2560 still means the standard local-folders path on the local volume.
2562 * src/modest-tny-account-store.c:
2563 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2564 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2565 all accounts when that happens.
2566 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2567 this too, so it shows up in the treeview.
2569 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2571 * src/maemo/modest-maemo-global-settings-dialog.c:
2572 (current_connection):
2573 * src/widgets/modest-global-settings-dialog.c:
2574 (current_connection_default):
2575 Use the enum values instead of 0, 1 and -1,
2576 to make the code clearer.
2578 * src/modest-account-mgr-helpers.c:
2579 (modest_account_mgr_get_connection_specific_smtp): Make this code
2582 * src/modest-runtime.h:
2583 * src/modest-runtime.c:
2584 Added modest_runtime_remove_all_send_queues().
2585 * src/maemo/modest-main-window.c:
2586 (on_account_store_connecting_finished): Recreate the send queues,
2587 using the appropriate transport accounts for this new connection.
2588 Some futher adapting might be needed if the old send queues are not
2589 automatically stopped at this point.
2591 * src/modest-tny-account-store.c: (get_server_accounts):
2592 Create the connection-specific transport accounts, so that they can
2593 be found later by their ID.
2595 * src/modest-tny-account.h:
2596 * src/modest-tny-account.c:
2597 Added modest_tny_account_new_from_server_account_name().
2598 modest_tny_account_new_from_server_account(): Do not create the
2599 send queues here, because they will be
2600 recreated anyway when the connection changes for the first time.
2602 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2604 * src/modest-local-folder-info.h:
2605 * src/modest-local-folder-info.c:
2606 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2607 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2608 tbox_folder): Take a modest account name instead of a server TnyAccount,
2609 so we can have per-modest-account rather than per-transport-account
2611 We must make sure that we change or recreate the exisitng send queues
2612 when the connection changes for connection-specific transport accounts.
2614 * src/modest-tny-account-store.c:
2615 (create_per_account_local_outbox_folders): Create outboxed per modest
2616 account, not per transport account.
2618 * src/modest-tny-account.h:
2619 * src/modest-tny-account.c:
2620 (modest_tny_account_get_special_folder): For outboxes, get the
2621 parent modest account name. The account is ignored for other folders.
2622 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2623 modest account name rather than a server TnyAccount.
2625 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2627 * src/modest-tny-account.c:
2628 (modest_tny_account_new_from_server_account):
2629 Call modest_runtime_get_send_queue() immediately after creating transport
2630 accounts, so that they start trying to send email from the outbox as soon
2631 as possible at startup. This is probably what we want.
2633 * src/modest-mail-operation.c: (update_account_thread):
2634 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2635 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2636 * src/modest-tny-send-queue.h:
2637 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2638 (modest_ui_actions_on_send):
2639 Added comments about how sending works, though it needs some more work.
2641 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2643 * src/modest-tny-account.c:
2644 (modest_tny_account_get_special_folder): Add TODO because this fails when
2645 the network is busy.
2646 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2647 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2648 Do not try to show this window when there is no active account. The UI
2649 specs does not tell us what to do in this case.
2651 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/Makefile.am:
2656 * src/widgets/Makefile.am: Some dist fixes.
2658 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2660 * src/maemo/modest-connection-specific-smtp-window.c:
2661 (on_button_edit): Make the code clearer, to prevent a double free.
2663 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2665 * src/maemo/modest-account-settings-dialog.c:
2666 (modest_account_settings_dialog_set_account_name),
2667 Check the connection-specific smtp servers checkbox if there are any.
2669 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2670 (modest_connection_specific_smtp_edit_window_init):
2671 Start with a suitable port number.
2673 * src/modest-account-mgr-helpers.h:
2674 * src/modest-account-mgr-helpers.c: Added
2675 modest_account_mgr_get_has_connection_specific_smtp().
2677 (modest_account_mgr_set_connection_specific_smtp),
2678 (modest_account_mgr_remove_connection_specific_smtp),
2679 (modest_account_mgr_get_has_connection_specific_smtp),
2680 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2681 connection-specific smtp server accounts in the account, rather than
2682 the server account conf dir.
2684 This fixes bug projects.maemo.org bug NB#58263 .
2686 * src/modest-tny-account-store.c:
2687 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2688 if there are no server accounts yet, to prevent an infinite loop when there
2689 are no accounts. Document that one must be called before the other.
2691 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-account-mgr-helpers.c:
2694 (modest_account_mgr_get_default_account): Make sure that at least
2695 one account is always the default, if there are any enabled accounts.
2696 This is just a sanity check that shouldn't be necessary.
2698 * src/modest-account-mgr-priv.c:
2699 (_modest_account_mgr_account_from_key): Unescape the conf key to
2700 get the real account name. For instance, this is an issue if a space
2701 was in the account name, which can happen because the account name
2702 is generated from the display name.
2703 (_modest_account_mgr_get_account_keyname): Always escape the
2705 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2706 Unescape the conf keys to get the real account names.
2708 For instance, previously the is-default radio button in the accounts
2709 list was not checked for any accounts at first. This fixes that,
2710 and might fix several similar bugs.
2712 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2714 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2715 Removed some debug printfs.
2717 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2719 Modest on-disk outbox directories are now here, for instance:
2720 $HOME/.modest/outboxes/<account-id-1>/outbox
2721 $HOME/.modest/outboxes/<account-id-2>/outbox
2723 $HOME/.modest/local-folders/outbox
2724 so we can have a separate outbox for each account.
2725 But they are shown as one outbox in the GtkTreeView, by using a
2726 TnyMergeFolder in a ModestTnySimpleFolderStore.
2729 * src/modest-tny-simple-folder-store.c:
2730 * src/modest-tny-simple-folder-store.h:
2731 Added ModestTnySimpleFolderStore, used to contain folders from
2732 other folder stores, such as other accounts.
2734 * src/modest-tny-outbox-account.h:
2735 * src/modest-tny-outbox-account.c:
2736 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2737 used for the per-account local outbox folders.
2739 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2740 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2741 only use this (internally) now for the non-outbox local folders.
2743 * src/modest-init.h:
2744 * src/modest-init.c: Added modest_init_one_local_folder(), for
2745 setting up the directory structure for each local folder.
2747 * src/modest-local-folder-info.c:
2748 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2749 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2751 * src/modest-local-folder-info.h:
2752 * src/modest-tny-account-store.c: (on_account_removed),
2753 (on_account_changed), (create_per_account_local_outbox_folders),
2754 (get_server_accounts), (modest_tny_account_store_get_accounts),
2755 (modest_tny_account_store_get_tny_account_by_account),
2756 (modest_tny_folder_store_is_virtual_local_folders):
2758 * src/modest-tny-account.h:
2759 * src/modest-tny-account.c:
2760 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2761 to create an on-disk per-account local outbox folder for each
2763 (create_per_account_local_outbox_folders): Create a local outbox folder
2764 for each transport account.
2765 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2766 for all local folders.
2768 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2769 instead of using g_object_get/set() directly. It is clearer.
2771 (modest_tny_folder_store_get_message_count),
2772 (modest_tny_folder_store_get_local_size
2773 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2774 because we now use these with non-acount folder stores.
2776 (modest_tny_account_get_special_folder),
2777 (modest_tny_account_new_from_server_account),
2778 (modest_tny_account_new_from_account):
2779 (recurse_folders): Adjust to the new outbox system.
2781 * src/modest-tny-folder.h:
2782 * src/modest-tny-folder.c:
2783 (modest_tny_folder_is_local_folder),
2784 (modest_tny_folder_get_local_folder_type),
2785 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2787 * src/widgets/modest-main-window.h:
2788 * src/maemo/modest-main-window.c: (create_details_widget),
2789 (modest_main_window_set_contents_style): Show details for any folder store,
2792 (modest_tny_folder_get_rules):
2793 Remove the const. C does not support constness enough for this.
2795 * src/modest-ui-actions.c:
2796 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2797 make all outboxes appear as one, in the usual local-folders tree node.
2799 (set_active_account_from_tny_account),
2800 (modest_ui_actions_on_folder_selection_changed):
2801 * src/widgets/modest-folder-view.c: (text_cell_data),
2802 (icon_cell_data), (filter_row),
2803 (add_account_folders_to_merged_folder),
2804 (add_account_folders_to_simple_folder_store), (),
2805 (get_cmp_rows_type_pos), (cmp_rows),
2806 (modest_folder_view_set_account_id_of_visible_server_account):
2807 Adjust to the new outbox system, using generic folder stores and folders
2808 in the GtkTreeModel.
2810 2007-05-23 Christian Kellner <ckellner@openismus.com>
2812 * src/modest-mail-operation.c:
2813 (modest_mail_operation_update_account):
2814 Use info->max_size instead of unintialized local var [small
2815 build fix]. (Added TODO to review that change since I don't
2818 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2820 * libmodest-dbus-client/libmodest-dbus-client.c:
2821 (libmodest_dbus_client_compose_mail): function added
2822 * src/dbus_api/modest-dbus-api.h:
2823 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2824 (on_compose_mail): Implementation of the SendAsMail functionality
2826 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2828 * src/modest-account-mgr.c:
2829 (modest_account_mgr_add_server_account): Set the secure-connection
2830 conf key for transport accounts as well as store accounts. I don't know
2831 why the if was there. For instance, this makes sure that we use SSL
2832 for the gmail preset from the easysetup wizard.
2834 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2836 * src/gnome/modest-main-window.c:
2837 (on_account_store_connecting_finished), (connect_signals):
2838 * src/maemo/modest-main-window.c:
2839 (on_account_store_connecting_finished), (connect_signals),
2840 (modest_main_window_new):
2841 Handle TnyAccountStore::connecting-finished instead of
2842 TnyDevice::connection-changed, because we cannot actually perform
2843 operations on accounts until TnyAccountStore has itself responded to
2844 the TnyDevice::connection-changed signal. This prevents a GError from
2846 Do not try to update at startup, because we (at least on scratchbox)
2847 already do an update at startup when the device goes online.
2848 This prevents a GError from tinymail.
2849 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2850 Added TODO about stopping simultaneous operations.
2852 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2855 * src/modest-mail-operation-queue.c:
2856 (modest_mail_operation_queue_remove):
2857 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2858 about where they happened.
2860 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-ui-actions.c:
2863 (modest_ui_actions_on_password_requested): Make sure that the remember
2864 output parameter is always TRUE.
2866 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2868 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2869 Show a OK/Cancel dialog if the error is a question, though we still do not
2870 know anything more about what we are asking the user.
2871 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2872 Fix an uninitialized variable (helper). This is a logic error, however.
2874 2007-05-21 Christian Kellner <ckellner@openismus.com>
2876 * src/modest-search.h:
2877 Correct bit shifting in the ModestSearchFlags enum.
2879 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2881 * src/modest-tny-account.c:
2882 (modest_tny_account_new_from_server_account): Do not use the lsub and
2883 check-all hard-coded IMAP options when using POP.
2885 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2887 * src/modest-tny-account.c:
2888 (modest_tny_account_new_from_server_account):
2889 Use NULL for the secure-auth method for POP when Password auth has been
2890 specified by the user, as we already do for IMAP. "auth=Login" causes
2891 an error from camel or the server.
2893 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/modest-account-settings-dialog.c:
2896 (create_page_account_details),
2897 (modest_account_settings_dialog_set_account_name):
2898 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2899 for the leave-on-server checkbox, rathr than just the checkbox, when
2900 the protocol is not POP.
2902 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2904 * src/widgets/modest-account-view.c:
2905 * src/widgets/modest-account-view.h:
2906 Added modest_account_view_select_account() which will be useful later
2907 to asynchronously re-select the edited account.
2909 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/modest-account-settings-dialog.c:
2912 (modest_account_settings_dialog_set_account_name):
2913 Automatically choose the port numbers based on the secure authentication
2914 methods, if they have not been chosen before.
2915 This fixes projects.maemo.org bug NB#56273 .
2917 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2919 * src/maemo/modest-main-window-ui.h:
2920 * src/modest-ui-actions.c:
2921 * src/modest-ui-actions.h:
2922 Connect the Tools/SMTP Servers menu item to
2923 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2924 SMTP servers dialog, as in the UI specification and saves changes when it
2925 is closed. This fixed projects.maemo.org bug NB#56305 .
2927 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/modest-connection-specific-smtp-window.c:
2930 (modest_connection_specific_smtp_window_init):
2931 Use gtk_window_set_default_size() to make this window big enough, so
2932 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2934 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2938 (modest_connection_specific_smtp_edit_window_init),
2939 Do not try to connect to a combobox signal before the combobox exists.
2940 This fixes the cras in projects.maemo.org bug NB#56288 .
2941 (modest_connection_specific_smtp_edit_window_get_settings):
2942 Remove the server_account_name parameter which was being checked for NULL
2943 though it was not used.
2945 * src/maemo/modest-connection-specific-smtp-window.c:
2946 (modest_connection_specific_smtp_window_fill_with_connections),
2947 (on_button_edit), (modest_connection_specific_smtp_window_init):
2948 Correct the number of treemodel columns to prevent a warning.
2949 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2950 libconic does not work.
2952 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2954 * src/modest-tny-account.c:
2955 (modest_tny_account_new_from_server_account):
2956 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2957 SMTP when "None" was chosen by the user. However, with my SMTP server that
2958 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2961 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2963 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2964 to explain the memory management issue with the ID in the ModestPair.
2966 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2967 (add_sending_page), (modest_account_assistant_finalize):
2968 * src/gnome/modest-gnome-global-settings-dialog.c:
2969 (create_updating_page), (create_composing_page):
2970 * src/gnome/modest-msg-edit-window.c: (get_transports),
2971 (init_window), (modest_msg_edit_window_finalize),
2972 (modest_msg_edit_window_get_msg_data):
2973 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2974 * src/gnome/modest-transport-widget.c:
2975 (modest_transport_widget_finalize), (smtp_configuration):
2976 * src/maemo/modest-maemo-global-settings-dialog.c:
2977 (create_updating_page), (create_composing_page):
2978 * src/maemo/modest-msg-edit-window.c: (get_transports),
2979 (init_window), (modest_msg_edit_window_finalize),
2980 (modest_msg_edit_window_get_msg_data),
2981 (modest_msg_edit_window_free_msg_data):
2982 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2983 (modest_store_widget_finalize):
2984 * src/maemo/modest-transport-widget.c:
2985 (modest_transport_widget_finalize), (smtp_configuration):
2986 * src/modest-main.c: (send_mail):
2987 * src/widgets/modest-combo-box.h:
2988 * src/widgets/modest-global-settings-dialog-priv.h:
2989 * src/widgets/modest-global-settings-dialog.c:
2990 (modest_global_settings_dialog_finalize):
2991 * src/widgets/modest-msg-edit-window.h:
2992 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2993 as long as the combo box, to prevent use of freed memory for the ID.
2995 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2997 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2998 get_accounts(), to make this clearer. Do not check for the enabled gconf
2999 key, because we do not use this for server accounts (at least, not yet).
3000 This allows us to send email again.
3002 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3004 * src/maemo/modest-platform.c:
3005 (on_modest_conf_update_interval_changed), (modest_platform_init):
3006 Only respond to this particular key change. All these strcmp()s cannot be
3009 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3011 * src/maemo/modest-maemo-global-settings-dialog.c:
3012 (current_connection): Prevent a crash in scratchbox when
3013 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3014 * src/maemo/modest-platform.c:
3015 (on_modest_conf_update_interval_changed), (modest_platform_init):
3016 Get the update interval from gconf and reset it when the gconf key changes.
3018 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3020 * src/modest-protocol-info.c:
3021 * src/modest-protocol-info.h: Adde enum-specific get functions,
3022 instead of using a ModestProtocolType enum parameter.
3024 * src/gnome/modest-account-assistant.c:
3025 * src/gnome/modest-store-widget.c:
3026 * src/gnome/modest-store-widget.h:
3027 * src/gnome/modest-transport-widget.c:
3028 * src/gnome/modest-transport-widget.h:
3029 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3030 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3031 * src/maemo/easysetup/modest-easysetup-wizard.c:
3032 * src/maemo/modest-account-settings-dialog.c:
3033 * src/maemo/modest-account-settings-dialog.h:
3034 * src/maemo/modest-store-widget.c:
3035 * src/maemo/modest-store-widget.h:
3036 * src/maemo/modest-transport-widget.c:
3037 * src/maemo/modest-transport-widget.h:
3038 * src/modest-account-mgr-helpers.c:
3039 * src/modest-account-mgr-helpers.h:
3040 * src/modest-account-mgr.c:
3041 * src/modest-account-mgr.h:
3042 * src/modest-tny-account.c:
3043 * src/modest-tny-folder.c:
3044 * src/widgets/modest-account-view.c:
3045 * src/widgets/modest-retrieve-combo-box.c:
3046 * src/widgets/modest-retrieve-combo-box.h:
3047 * src/widgets/modest-secureauth-combo-box.c:
3048 * src/widgets/modest-serversecurity-combo-box.c:
3049 * src/widgets/modest-serversecurity-combo-box.h:
3050 * tests/check_account-mgr.c:
3051 Use the specific functions, and use the re-renamed enum values for GNOME too.
3053 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3055 * src/modest-pair.h:
3056 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3057 so we can get the second based on the first.
3059 * src/maemo/modest-account-settings-dialog.h:
3060 * src/maemo/modest-account-settings-dialog.c:
3061 Added get_supported_secure_authentication_methods(), though it is mostly
3062 commented-out for now until the necessary API is committed to tinymail.
3063 (modest_account_settings_dialog_set_account_name),
3064 (save_configuration): Request the supported authentication methods from the
3065 server, so we can choose a working method.
3067 * src/modest-tny-account-store.h:
3068 * src/modest-tny-account-store.c:
3069 (modest_tny_account_store_get_session): Rename from
3070 tny_account_store_get_session().
3072 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3074 * src/modest-protocol-info.h: Split the ModestProtocol enum
3075 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3076 There was no need to have these unrelated values in one enum.
3078 * src/: many files: Adapted to changed enum. This makes the code a bit
3079 clearer, and the compiler could catch some errors.
3081 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3083 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3084 Show the detailed internal camel error message when an error happens
3085 during the configuration, so that our testers can give us more clues.
3086 For instance, in projects.maemo.org bug NB#56910 .
3088 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3090 * src/modest-tny-account.c:
3091 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3092 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3094 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3096 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3097 * src/maemo/modest-account-settings-dialog.c:
3098 (modest_account_settings_dialog_set_account_name),
3099 (save_configuration): For the incoming secure authentication checkbox,
3100 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3101 the UI specification. PLAIN does not seem to be supported for most IMAP
3102 servers anyway, and I am not sure what it would mean.
3103 However, we probably need to discover which of the secure-authentication
3104 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3105 * src/modest-account-mgr-helpers.c:
3106 (modest_account_mgr_get_server_account_data):
3108 * src/modest-tny-account.c:
3109 (modest_tny_account_new_from_server_account):
3110 Use tny_account_set_mech() to set secure-authentication methods,
3111 with some special-casing for IMAP, based on my observations of how
3114 * src/modest-account-mgr-helpers.h:
3115 * src/modest-account-mgr.c:
3116 * src/modest-defs.h: Comment that the URI is only used for local folders.
3118 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3120 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3121 parameter const, just to be neat.
3122 * src/modest-text-utils.c: (modest_text_utils_inline):
3123 End g_strconcat() with NULL, as its documentation says. This is almost
3124 certainly the cause of my crash at startup on the device. Interestingly,
3125 valgrind doesn't tell us about these errors.
3127 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3129 * scripts/build-packages: Added more precise comments about how to use
3130 this script, though I still get this error:
3131 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3132 error building tinymail
3134 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3136 * src/maemo/modest-main-window.c: (on_account_update):
3137 Very slight cleanup, hoping to make it simpler to discover what causes
3138 a crash here sometimes.
3140 * src/modest-tny-account.c:
3141 (modest_tny_account_new_from_server_account): Set the port. Added
3142 comments about the options and a TODO comment because I need to find out
3143 how to specify the secure authentication method.
3145 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3147 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3148 changed CFlags paths form modest to libmodest
3150 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3152 * src/modest-account-mgr-helpers.c:
3153 (modest_account_mgr_get_server_account_data),
3154 (modest_account_mgr_free_server_account_data):
3155 * src/modest-account-mgr-helpers.h:
3156 * src/modest-account-mgr.c:
3157 (modest_account_mgr_add_server_account):
3158 * src/modest-defs.h:
3159 * src/modest-tny-account.c:
3160 (modest_tny_account_new_from_server_account):
3161 Determine the options for tny_camel_account_add_option() here,
3162 based on the settings, rather than storing them directly in gconf.
3164 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3166 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3167 Show a more friendly error dialog now that we expect (from the tinymail
3168 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3170 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3172 * src/maemo/modest-main-window.c: (on_account_update): Check that
3173 account_name is not NULL, to prevent a crash at startup that I am
3174 seeing on the N800. I do wonder why it is NULL.
3176 * src/maemo/easysetup/modest-easysetup-wizard.c:
3177 (create_page_user_details):
3178 * src/maemo/modest-account-settings-dialog.c:
3179 (create_page_user_details), (create_page_outgoing):
3180 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3181 (modest_connection_specific_smtp_edit_window_init):
3182 * src/modest-ui-actions.c:
3183 (modest_ui_actions_on_password_requested):
3184 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3185 might do something useful with the on-screen keyboard.
3187 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-main-window.c: (on_account_update):
3190 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3191 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3193 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3195 * src/modest-tny-account-store.c: (on_account_changed):
3196 Correct the signature of this signal handler.
3198 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3200 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3201 Show a HildonNote instead of a GtkDialog for Maemo.
3203 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3205 * src/widgets/modest-account-view.h:
3206 * src/widgets/modest-account-view.c: (on_account_changed),
3207 (on_account_removed). Added a boolean flag, set/unset by
3208 modest_account_view_block_conf_updates(),
3209 modest_account_view_unblock_conf_updates() to prevent unnecessary
3210 updates, but this is not very useful because the gconf notifications are
3211 so delays (maybe only on Maemo Bora).
3212 So auto-updating is turned off, and these functions do an explicit
3213 update when necessary.
3214 However, something else is still doing too much work when adding/removing
3215 accounts, probably in another part of the application.
3217 * src/maemo/modest-account-view-window.c:
3218 (on_delete_button_clicked), (on_edit_button_clicked),
3219 (on_new_button_clicked): Use the new functions.
3221 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3223 * src/modest-account-mgr-helpers.c:
3224 (modest_account_mgr_set_first_account_as_default):
3225 Sort the list of names alphabetically-by-title, so we choose the first one
3227 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3228 alphabetically by the title.
3230 This fixes projects.maemo.org bug NB#56418 .
3232 * src/modest-account-mgr-priv.c:
3233 (_modest_account_mgr_account_from_key):
3234 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3235 avoid a valgrind error, and possible random behaviour.
3237 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3239 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3240 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3241 tinymail documentation to say that this can be expected.
3242 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3243 pretty, and should not happen, but I would prefer to know when it does.
3245 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3247 * configure.ac: When using the older hildon version, probably on Bora,
3248 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3250 * src/widgets/modest-attachment-view.c:
3251 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3254 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3256 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3257 Implemented the prototype. Can be tested with
3258 tests/dbus_api/test_open_message:
3260 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3262 * src/modest-tny-account-store.c:
3263 (modest_tny_account_store_instance_init), (get_password):
3264 * src/modest-ui-actions.c:
3265 (modest_ui_actions_on_password_requested):
3266 Do not store the password in gconf, because this function is called
3267 for non-remembered passwords. Actually use the cached (in the hash map)
3268 password instead of releasing it.
3269 The password will now not be remembered if it is asked via the protected
3270 password dialog, as per the UI spec.
3272 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3274 * src/modest-defs.h:
3275 * src/modest-account-mgr-helpers.h:
3276 * src/modest-account-mgr-helpers.c:
3277 Added modest_server_account_get_username_has_succeeded(),
3278 modest_server_account_set_username_has_succeeded().
3279 (modest_server_account_set_username),
3280 Reset the has-succeeded flag if the username changes.
3282 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3283 * src/maemo/modest-connection-specific-smtp-window.c:
3284 (modest_connection_specific_smtp_window_save_server_accounts):
3285 Use modest_server_account_set_username() instead of using
3286 modest_conf_set_string() directly, so that the has-succeeded flag is always
3289 * src/modest-ui-actions.c:
3290 (modest_ui_actions_on_password_requested): Dim the username entry if
3291 the username has ever worked, as per the UI spec.
3293 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3295 * src/modest-tny-account-store.c: (get_password):
3296 * src/modest-ui-actions.c:
3297 (modest_ui_actions_on_password_requested):
3298 Allow the username to be changed too, though there is more work to
3299 be done on exactly how this behaves.
3301 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3303 * src/modest-account-mgr-helpers.h:
3304 * src/modest-account-mgr-helpers.c:
3305 Added modest_account_mgr_get_display_name(),
3306 modest_server_account_get_username(),
3307 modest_server_account_set_username(),
3308 modest_server_account_set_password(),
3309 modest_server_account_get_hostname() functions so we do not need to
3310 use the conf API directly.
3312 * src/maemo/modest-main-window.c: (connect_signals):
3313 Actually connect ot the ModestAccountStore::request-password signal,
3314 so that we show the dialog when the password is requested by Tinymail,
3315 for isntance if it is empty.
3317 * src/modest-marshal.list:
3318 * src/modest-tny-account-store.c:
3319 (modest_tny_account_store_class_init), (get_password),
3320 (modest_tny_account_store_alert):
3321 * src/modest-tny-account-store.h:
3322 * src/modest-ui-actions.h:
3323 * src/modest-ui-actions.c:
3324 (modest_ui_actions_on_password_requested):
3325 Change the signal parameters, so it is obvious that we are providing
3326 the non human-readable server name, and receiving both the username
3327 and password, though changing of the username is not yet implemented.
3328 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3329 for the GNOME version.
3331 This should fix the projects.maemo.org bug NB#56209, though it does not
3332 work on Bora, because the gconf_client_get() for the password fails
3333 immediately after we save it with gconf_client_set().
3335 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3338 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3339 caused an undefined symbol error:
3340 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3342 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3344 * src/modest-tny-account-store.c:
3345 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3346 using a GError instead of a string message, so we can translate it in
3349 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/modest-address-book.c:
3352 (modest_address_book_check_names):
3353 * src/maemo/modest-msg-view-window.c:
3354 (modest_msg_view_window_clipboard_owner_change):
3355 * src/modest-init.c: (modest_init_init_ui):
3356 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3357 (update_folders_cb), (modest_mail_operation_update_account):
3358 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3359 (modest_ui_actions_on_msg_attachment_clicked),
3360 (modest_ui_actions_on_msg_recpt_activated):
3361 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3362 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3363 (modest_msg_view_search_next):
3364 * src/widgets/modest-recpt-editor.c:
3365 (modest_recpt_editor_on_button_release_event),
3366 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3367 g_message(). At this point we should only be seeing interesting errors on
3368 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3370 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3372 (modest_wizard_dialog_force_title_update):
3373 * src/maemo/easysetup/modest-wizard-dialog.h:
3374 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3375 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3376 can update the title when appropriate. Otherwise the title is wrong if the
3377 pages are added after adding the notebook to the dialog.
3378 This must be a problem in HildonWizardDialog too.
3379 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3381 * src/maemo/easysetup/modest-easysetup-wizard.c:
3382 (create_subsequent_customsetup_pages),
3383 (create_subsequent_easysetup_pages):
3384 Call modest_wizard_dialog_force_title_update() so that the title is
3385 correct even with GTK+ < 2.10.
3386 This fixes projects.maemo.org bug NB#56145 .
3388 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3390 * src/maemo/modest-platform.c:
3391 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3392 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3395 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3397 * src/widgets/modest-window.h:
3398 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3399 and modest_window_save_state(), which invokes it.
3401 * src/widgets/modest-window-mgr.h:
3402 * src/widgets/modest-window-mgr.c:
3403 Added modest_window_mgr_save_state_for_all_windows(), which calls
3404 the save_state vfunc on all registered windows, if implemented.
3406 * src/gnome/modest-msg-edit-window.c:
3407 * src/gnome/modest-msg-view-window.c:
3408 * src/maemo/modest-msg-edit-window.c:
3409 * src/maemo/modest-msg-view-window.c:
3410 * src/maemo/modest-main-window.c:
3411 Specify the existing save_settings functions as implementations of
3412 ModestWindow::save_state_func().
3414 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3415 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3416 enabling hibernation, for instance.
3418 We may need to do the same thing for restoring settings.
3421 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3423 * src/widgets/modest-window-mgr.c:
3424 * src/widgets/modest-window-mgr.h:
3425 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3426 modest_window_mgr_get_hibernation_is_prevented().
3428 * src/maemo/modest-main-window.c:
3429 (on_hildon_program_is_topmost_notify): Prevent hibernation
3430 (possible when the application goes to the background in the WM),
3431 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3433 * src/maemo/easysetup/modest-easysetup-wizard.c:
3434 (modest_easysetup_wizard_dialog_init):
3435 * src/maemo/modest-account-settings-dialog.c:
3436 (modest_account_settings_dialog_init):
3437 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3438 (modest_connection_specific_smtp_edit_window_init):
3439 * src/maemo/modest-connection-specific-smtp-window.c:
3440 (modest_connection_specific_smtp_window_init):
3441 * src/maemo/modest-signature-editor-dialog.c:
3442 (modest_signature_editor_dialog_init):
3443 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3444 prevent hibernation while any of these account settings dialogs are open.
3446 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3448 * src/maemo/Makefile.am:
3449 * src/maemo/modest-osso-state-saving.c:
3450 * src/maemo/modest-osso-state-saving.h: Added
3451 modest_osso_load_state() and modest_osso_save_state() though they do
3452 nothing now. They should iterate through all the open windows and load/save
3454 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3455 save state when closing.
3457 * src/maemo/modest-main-window.c:
3458 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3459 Add a notification handler for the HildonProgram::is-topmost property,
3460 so we can allow hibernation when the application goes into the background.
3461 But we still need to detect when the accounts setup windows are open so
3462 we can stop hibernation when they are open.
3463 To do this, I also added the main window the HildonProgram. This might have
3464 other side-effects/benefits, and should maybe be done for other windows.
3466 * src/maemo/modest-osso-autosave-callbacks.h:
3467 * src/maemo/modest-osso-autosave-callbacks.c:
3468 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3469 though it does not do anything yet, and we might never need this to do
3470 anything. For instance, we already save drafts.
3472 * src/maemo/modest-platform.c: (modest_platform_init):
3473 Specify the libosso auto-save callback.
3475 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3477 * src/maemo/modest-platform.c:
3478 (modest_platform_set_update_interval):
3479 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3480 aparently stays valid between application instances, so we can use this
3481 to remove and reset it later. According to a maemo-developers email from
3484 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3486 * configure.ac: Depend on libalarm for Maemo.
3488 * src/dbus_api/modest-dbus-api.h:
3489 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3490 (on_send_receive), (modest_dbus_req_handler):
3491 Handle a SEND_RECEIVE D-Bus method.
3493 * libmodest-dbus-client/libmodest-dbus-client.c:
3494 (libmodest_dbus_client_send_and_receive):
3495 * libmodest-dbus-client/libmodest-dbus-client.h:
3496 Add C convenience functions for calling the new D-Bus method.
3498 * src/modest-platform.h:
3499 * src/gnome/modest-platform.c:
3500 * src/maemo/modest-platform.c:
3501 Added modest_platform_set_update_interval(), which uses the
3502 alarmd API on Maemo.
3503 (modest_platform_init),
3504 Call modest_platform_set_update_interval(), using a hard-coded
3505 interval for now (until the global settings dialog is implemented),
3506 though I am not sure that this makes sense yet.
3508 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3510 * src/dbus_api/modest-dbus-callbacks.c:
3511 (modest_osso_cb_hw_state_handler):
3512 * src/dbus_api/modest-dbus-callbacks.h:
3513 * src/maemo/modest-platform.c: (modest_platform_init):
3514 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3515 in case this has some effect on the ability for Maemo to ping the
3518 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3520 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3521 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3522 warning. It is probably a logic error, but I need to fix the build.
3524 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3526 * src/modest-account-mgr.h:
3527 * src/modest-account-mgr.c:
3528 (modest_account_mgr_account_names): Add a gboolean enabled_only
3529 parameter, so we can get lists of onlt the enabled accounts.
3531 (modest_account_mgr_add_account),,
3532 (modest_account_mgr_account_with_display_name_exists):
3533 * src/maemo/modest-msg-edit-window.c: (get_transports):
3534 * src/modest-account-mgr-helpers.c:
3535 (modest_account_mgr_set_first_account_as_default):
3536 * src/modest-init.c: (init_default_account_maybe):
3537 * src/modest-tny-account-store.c: (get_accounts):
3538 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3539 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3540 * tests/check_account-mgr.c: (START_TEST):
3541 Provide the extra parameter, as appropriate.
3543 * src/widgets/modest-account-view.c: (update_account_view):
3544 Do not show disabled accounts (meaning that there is no way to
3545 enable/disable accounts in the UI (the feature is not in our UI
3546 specification), so we can use this internally only to mark unfinished
3547 or temporary account data.
3549 * src/maemo/easysetup/modest-easysetup-wizard.c:
3550 (create_account): Add boolean enable parameter, so we can specify FALSE
3551 to create the temporary account.
3552 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3553 (on_before_next): When finishing, when there is a temporary account, just
3555 Also, use a timeout to delay the showing of the dialog until gconf is likely
3556 to return correct information, due to a maemo gconf bug that is fixed in
3557 osso 1.1, but not yet in Bora.
3558 However, the dialog stays on screen after it is destroyed.
3560 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3561 for invalid data when cancelling. Use a hildon note instead of a dialog
3562 to complain about invalid data. Do not show the account-saved note if the
3563 account is disabled (a temporary account that will not really be saved for use
3566 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3568 * src/modest-account-mgr-helpers.h:
3569 * src/modest-account-mgr-helpers.c:
3570 Added modest_account_mgr_unset_default_account(),
3571 Added modest_account_mgr_set_first_account_as_default().
3573 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3574 If it was the default account, unset the default account name.
3576 * src/maemo/modest-account-view-window.c:
3577 (on_delete_button_clicked): If it was the default account,
3578 set the first remaining account as the default instead.
3580 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3581 a NULL account or a NULL default account, to prevent a crash. This should
3582 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3585 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3587 * src/widgets/modest-recpt-editor.c:
3588 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3589 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3590 TODO comment for this. This fixes the build.
3592 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3593 be the best place for it. This will in future update all auto-update accounts,
3594 rather than just the current/default account, when that gconf key exists.
3595 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3596 if there are no accounts, before calling do_send_receive().
3597 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3599 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3600 * src/maemo/modest-main-window-ui.h:
3601 * src/maemo/modest-main-window.c: (on_connection_changed),
3602 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3603 directly, becaue the signal handler does more.
3605 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3607 * src/modest-account-mgr-helpers.c:
3608 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3609 for the case that the account does not exist.
3611 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3612 (equivalent to the modest account name) rather than the tinymail account name
3613 (equivalent to the modest account title - human readable) to get the account data.
3614 Check for null account data to prevent the crash, and add a TODO comment saying that
3615 this needs fixing because it is using the server account name instead of the account name.
3617 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3619 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3620 * src/maemo/modest-account-settings-dialog.c: (show_error),
3622 Use hildon_note_new_information() for informative and error messages,
3623 which seems to be expected for Maemo applications (no documentation that I know of
3624 says this). I am surprised that there is no distinction between info and error
3627 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3629 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3630 it is easy to find where this is used.
3632 * src/maemo/easysetup/modest-easysetup-wizard.c:
3633 (create_page_welcome), (create_page_account_details),
3634 (create_page_user_details), (create_page_complete_easysetup),
3635 (create_page_custom_incoming), (create_page_custom_outgoing),
3636 (create_page_complete_custom):
3637 * src/maemo/modest-account-settings-dialog.c:
3638 (create_page_account_details), (create_page_user_details),
3639 (create_page_incoming), (create_page_outgoing):
3640 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3641 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3642 (modest_connection_specific_smtp_edit_window_init):
3643 * src/maemo/modest-connection-specific-smtp-window.c:
3644 (modest_connection_specific_smtp_window_init):
3645 * src/maemo/modest-signature-editor-dialog.c:
3646 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3647 and scrolling policy as per the Email Application Layout Guide, if I have
3650 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3652 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3653 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3654 which were empty, because these vfuncs have been removed from TnyAccountStore.
3655 This fixes the build.
3657 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3659 * src/maemo/modest-main-window.c:
3660 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3661 showing/hiding it. Added TODO because it probably should not be NULL.
3662 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3663 because unnecessary g_warnings() make degugging difficult.
3665 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/modest-msg-edit-window.c:
3668 (modest_msg_edit_window_select_color),
3669 (modest_msg_edit_window_select_background_color): 2 const corrections and
3670 moving 2 #endifs before closing brackets, to fix the build.
3672 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3674 * src/maemo/easysetup/modest-easysetup-wizard.h:
3675 * src/maemo/easysetup/modest-easysetup-wizard.c:
3676 (modest_easysetup_wizard_dialog_finalize),
3677 (on_button_edit_advanced_settings), (create_page_complete_custom),
3678 (on_response), (create_account):
3679 Implement the Advanced Settings edit button, by saving the account information,
3680 for the Advanded Settings dialog to use directly from gconf, and removing it
3681 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3682 Bug #5533 in the projects.maemo.org bugzilla.
3684 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3686 * src/maemo/modest-msg-view-window.c:
3687 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3688 when opening a message window.
3690 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/easysetup/modest-easysetup-wizard.c:
3693 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3696 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3697 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3698 gconf settings. I probably added more checks than necessary, but that is safer.
3700 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3701 variable to fix the build, but this seems to be used when it is still NULL.
3703 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3705 * src/modest-platform.h:
3706 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3707 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3708 * src/modest-main.c: Implement this function so we can avoid using
3709 maemo-specific API from cross-platform code.
3711 * src/modest-tny-account-store.c:
3712 (get_smtp_specific_transport_account_for_open_connection):
3713 * src/modest-ui-actions.c: (check_for_connection),
3714 (modest_ui_actions_on_item_not_found):
3715 Use modest_platform_connect_and_wait() and put #idefs around other
3716 maemo-specific code, because only maemo currently has a way to
3717 identify connection names.
3719 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3721 * src/modest-tny-account-store.h:
3722 * src/modest-tny-account-store.c:
3723 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3724 the connection-specific SMTP server settings in the configuration.
3726 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3728 * src/maemo/modest-main-window.c: (on_connection_changed),
3730 * src/modest-main.c: (main), (start_ui), (send_mail):
3731 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3732 that is what is intended.
3734 * src/modest-ui-actions.c: (action_send), (action_receive),
3735 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3736 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3737 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3738 SMTP server is used when it is specified.
3740 (modest_ui_actions_on_send_receive):
3741 Check that a connection is open before proceeding.
3742 Receive and then send, instead of vice-versa, as per the specification.
3744 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3746 * src/modest-mail-operation.c:
3747 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3748 though I guess it should be something other than NULL.
3750 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3752 * src/maemo/easysetup/modest-easysetup-wizard.c:
3753 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3754 combo twice, to avoid an g_warning and to make it visible again.
3755 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3756 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3757 (already intended) dereference when detaching, because we then recreate the menu.
3758 But I am not sure why the warning was happening, and it is possible that this is a memory
3761 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3763 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3764 and uri_parse_mailto() utility functions.
3765 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3767 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3769 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3771 * src/dbus_api/modest-dbus-api.h:
3772 * src/dbus_api/modest-dbus-callbacks.c:
3773 Use an idle callback to execute the modest code in the application's own thread.
3774 Remove the helloworld example method.
3775 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3776 parsed, and the open-message method is not implemented because this is not yet implemented in
3778 * libmodest-dbus-client/libmodest-dbus-client.c:
3779 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3780 (libmodest_dbus_client_open_message):
3781 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3783 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3784 body without crashing.
3786 * tests/dbus_api/Makefile.am:
3787 * tests/dbus_api/test_mail_to.c:
3788 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3790 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3792 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3793 Added file to fix the build. Sorry.
3795 * src/dbus_api/Makefile.am:
3796 * src/dbus_api/modest-dbus-api.h:
3797 * src/dbus_api/modest-dbus-callbacks.h:
3798 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3799 (modest_dbus_req_handler):
3800 Put constants in a separate header so it can be reused by the
3801 client library, without duplication
3803 * libmodest-dbus-client/Makefile.am:
3804 * libmodest-dbus-client/libmodest-dbus-client.c:
3805 (libmodest_dbus_client_call_helloworld),
3806 (libmodfest_dbus_client_send_mail),
3807 (libmodfest_dbus_client_mailto),
3808 (libmodfest_dbus_client_open_message):
3809 * libmodest-dbus-client/libmodest-dbus-client.h:
3810 (Partly) Implement a send_mail D-Bus method.
3812 * tests/dbus_api/Makefile.am:
3813 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3814 the send_email D-Bus method.
3816 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3820 * libmodest-dbus-client/Makefile.am:
3821 * libmodest-dbus-client/libmodest-dbus-client.c:
3822 * libmodest-dbus-client/libmodest-dbus-client.h:
3823 * tests/dbus_api/Makefile.am:
3824 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3825 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3827 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3829 * src/maemo/easysetup/modest-easysetup-wizard.c:
3830 (create_page_account_details):
3831 * src/maemo/modest-account-settings-dialog.c:
3832 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3833 widgets, because this might not be the default in future versions of the Maemo GTK+.
3834 However, I can not not get capitalization to work even in a simple test case.
3836 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3838 * src/maemo/easysetup/modest-easysetup-wizard.c:
3839 (create_page_custom_incoming), (create_page_custom_outgoing):
3840 * src/maemo/modest-account-settings-dialog.c:
3841 (create_page_account_details), (create_page_incoming),
3842 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3843 instead of using gtk_check_button_with_label(), so they are aligned like the other
3844 widgets, as per the UI spec.
3846 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3848 * src/maemo/easysetup/modest-easysetup-wizard.c:
3849 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3850 * src/widgets/modest-validating-entry.c:
3851 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3852 Modest prefix instead of an EasySetup prefix.
3854 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3856 * src/widgets/modest-validating-entry.h:
3857 * src/widgets/modest-validating-entry.c: (on_insert_text),
3858 Added easysetup_validating_entry_set_max_func(), used to set a callback
3859 to call when the max number of characters is reached. GtkEntry has a max-length
3860 already but is silent about it.
3862 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3863 (create_page_account_details), (create_page_user_details),
3865 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3866 (create_page_account_details), (create_page_user_details),
3867 (create_page_outgoing):
3868 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3869 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3870 the UI spec, when the user tries to enter more than the max number of characters.
3872 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/easysetup/modest-easysetup-wizard.c:
3875 (create_page_user_details), (create_page_custom_incoming),
3876 (create_page_custom_outgoing):
3877 * src/maemo/modest-account-settings-dialog.c:
3878 (create_page_user_details), (create_page_incoming),
3879 (create_page_outgoing):
3880 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3881 (modest_connection_specific_smtp_edit_window_init):
3882 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3883 not appropriate. Bad Maemo-specific defaults!.
3885 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3888 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3889 (modest_signature_editor_dialog_set_settings):
3890 Disable the label and textview when the checkbox is disabled, and use the
3891 specified (UI spec) default signature text.
3893 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3895 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3896 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3898 * src/modest-defs.h:
3899 * src/modest-account-mgr-helpers.h:
3900 * src/modest-account-mgr-helpers.c:
3901 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3903 * src/maemo/Makefile.am:
3904 * src/maemo/modest-signature-editor-dialog.c:
3905 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3908 * src/maemo/modest-account-settings-dialog.h:
3909 * src/maemo/modest-account-settings-dialog.c:
3910 (modest_account_settings_dialog_finalize), (on_button_signature),
3911 (save_configuration): Use the new dialog when the Edit button is pressed, and
3912 save the changes if necessary, as per the UI spec.
3914 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3916 * src/maemo/Makefile.am:
3917 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3918 based on maemo-develoers email from Dirk.
3920 * src/maemo/easysetup/modest-easysetup-wizard.c:
3921 (create_page_welcome), (create_page_account_details),
3922 (create_page_user_details), (create_page_complete_easysetup),
3923 (create_page_custom_incoming), (create_page_custom_outgoing),
3924 (create_page_complete_custom),
3925 (modest_easysetup_wizard_dialog_init):
3926 * src/maemo/modest-account-settings-dialog.c:
3927 (create_page_account_details), (create_page_user_details),
3928 (create_page_incoming), (create_page_outgoing),
3929 (modest_account_settings_dialog_init):
3930 * src/maemo/modest-connection-specific-smtp-window.c:
3931 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3933 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3935 * src/maemo/easysetup/modest-easysetup-wizard.c:
3936 (create_page_account_details), (create_page_custom_outgoing),
3937 (create_page_complete_custom):
3938 * src/maemo/modest-account-settings-dialog.c:
3939 (create_page_user_details), (create_page_incoming),
3940 (create_page_outgoing):
3941 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3942 (modest_connection_specific_smtp_edit_window_init):
3943 Use the correct (UI spec) port min/max, and use horizontal separators,
3946 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3948 * src/maemo/easysetup/modest-easysetup-wizard.c:
3949 (set_default_custom_servernames):
3950 * src/maemo/modest-account-settings-dialog.c:
3951 (create_page_incoming), (on_combo_outgoing_security_changed),
3952 (on_combo_incoming_security_changed), (create_page_outgoing),
3953 (modest_account_settings_dialog_set_account_name),
3954 (save_configuration):
3955 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3956 (on_combo_security_changed),
3957 (modest_connection_specific_smtp_edit_window_init),
3958 (modest_connection_specific_smtp_edit_window_set_connection),
3959 (modest_connection_specific_smtp_edit_window_get_settings):
3960 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3963 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3966 * src/maemo/easysetup/modest-easysetup-wizard.c:
3967 (create_page_custom_outgoing), (create_page_complete_custom):
3968 * src/maemo/modest-account-settings-dialog.c:
3969 (create_page_user_details), (create_page_outgoing):
3970 * src/maemo/modest-account-view-window.c: (button_box_new):
3971 Use changed logical IDs as per the most recent UI spec:
3972 mcen_bd_emailsetup_edit -> mcen_bd_edit
3973 mcen_bd_emailsetup_delete -> mcen_bd_delete
3974 mcen_bd_emailsetup_close -> mcen_bd_close
3976 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3980 * src/dbus_api/Makefile.am:
3981 * src/dbus_api/modest-dbus-callbacks.c:
3982 * src/dbus_api/modest-dbus-callbacks.h:
3983 * src/maemo/modest-platform.c: (modest_platform_init):
3984 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3986 * tests/Makefile.am:
3987 * tests/dbus_api/Makefile.am:
3988 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3990 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3992 * src/maemo/modest-account-settings-dialog.c:
3993 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3994 Removed unnecessary includes.
3996 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/easysetup/modest-easysetup-wizard.c:
3999 * src/maemo/modest-account-settings-dialog.c:
4000 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4001 * src/widgets/Makefile.am:
4002 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4003 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4004 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4005 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4006 * src/widgets/modest-secureauth-combo-box.c:
4007 * src/widgets/modest-secureauth-combo-box.h:
4008 * src/widgets/modest-serversecurity-combo-box.c:
4009 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4010 made the GObject names more consistent with the rest of the Modest code.
4012 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4014 * src/maemo/easysetup/Makefile.am:
4015 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4016 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4017 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4018 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4019 * src/maemo/easysetup/modest-easysetup-wizard.c:
4020 * src/maemo/easysetup/modest-validating-entry.c:
4021 * src/maemo/easysetup/modest-validating-entry.h:
4022 * src/maemo/modest-account-settings-dialog.c:
4023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4024 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4025 widgets/ because they are used outside of easysetup too. After checking in,
4026 svn will allow me to rename them too.
4028 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4030 * src/gnome/modest-msg-edit-window.c:
4031 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4032 linker error, to fix the build on the GNOME platform.
4033 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4034 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4035 ifdefed out to avoid a warning.
4037 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4039 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4040 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4041 some alternative for GTK+ 2.6.
4043 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4045 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4047 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4048 specified for EmailAccountsDialog in UI spec.
4050 * src/maemo/easysetup/modest-easysetup-wizard.c:
4051 * src/maemo/easysetup/modest-easysetup-wizard.h:
4052 * src/maemo/modest-account-settings-dialog.c:
4053 * src/maemo/modest-account-settings-dialog.h:
4054 Reuse a member window widget for the connection-specific SMTP server accounts,
4055 so we can tell it to create/save the accounts only if we actually save changes.
4057 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4058 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4059 (modest_connection_specific_smtp_edit_window_get_settings):
4060 Return a struct instance for temporarily remembering the entered data.
4062 * src/maemo/modest-connection-specific-smtp-window.h:
4063 * src/maemo/modest-connection-specific-smtp-window.c:
4064 (modest_connection_specific_smtp_window_finalize),
4065 (modest_connection_specific_smtp_window_fill_with_connections),
4067 (modest_connection_specific_smtp_window_save_server_accounts),
4068 (update_model_server_names): Do not actually save data until asked,
4069 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4071 (on_selection_changed),
4072 (modest_connection_specific_smtp_window_init): Disable the edit
4073 button when nothing is selected.
4075 * src/modest-account-mgr-helpers.c:
4076 * src/modest-account-mgr-helpers.h:
4077 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4080 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4082 * src/modest-account-mgr-helpers.h:
4083 * src/modest-account-mgr-helpers.c:
4084 (modest_account_mgr_get_unused_account_name),
4085 (modest_account_mgr_get_unused_account_display_name): Added these
4086 utility functions, to avoid code duplication.
4088 * src/maemo/easysetup/modest-easysetup-wizard.c:
4089 (create_page_account_details), (create_account):
4090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4091 (on_combo_security_changed),
4092 (modest_connection_specific_smtp_edit_window_init),
4093 (modest_connection_specific_smtp_edit_window_save_settings):
4094 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4095 * src/maemo/modest-connection-specific-smtp-window.c:
4096 (modest_connection_specific_smtp_window_finalize),
4097 (modest_connection_specific_smtp_window_fill_with_connections),
4098 (on_button_edit), (modest_connection_specific_smtp_window_init):
4099 * src/maemo/modest-connection-specific-smtp-window.h:
4100 Implementing saving of connection-specific server accounts.
4102 But I need to refactor this so we can save the data for each
4103 possible connection-specific account and only actually create the server accounts
4104 when the easysetup finished, or the OK button is pressed on the account settings
4107 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4110 (on_combo_security_changed):
4111 (modest_connection_specific_smtp_edit_window_init):
4112 Auto-fill the port number as in the account settings.
4114 (modest_connection_specific_smtp_edit_window_set_connection):
4115 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4116 * src/maemo/modest-connection-specific-smtp-window.c:
4117 (fill_with_connections), (on_button_edit),
4118 (modest_connection_specific_smtp_window_init):
4119 Turn the edit window into a dialog to simplify the code, and
4120 set a WM hint as in a GtkDialog, because only a popup can be on top of
4121 another window in Maemo, and popups usually have no WM decoration.
4123 * src/modest-defs.h:
4124 * src/modest-account-mgr-helpers.c:
4125 (modest_account_mgr_set_connection_specific_smtp),
4126 (modest_account_mgr_remove_connection_specific_smtp),
4127 (modest_account_mgr_get_connection_specific_smtp):
4128 * src/modest-account-mgr-helpers.h: Some functions to write the
4129 connection-specific SMTP server information. Not yet used.
4132 * src/widgets/modest-folder-view.c: (text_cell_data):
4133 Fix a warning about an uninitialized variable.
4134 (on_configuration_key_changed): Put an #ifdef around the use
4135 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4137 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4139 * src/maemo/modest-account-settings-dialog.h:
4140 * src/maemo/modest-account-settings-dialog.c:
4141 Added connect_for_modified() utility function to mark the new modified boolean.
4143 (create_page_account_details), (create_page_user_details),
4144 (create_page_incoming), (create_page_outgoing), (on_response),
4145 (modest_account_settings_dialog_init),
4146 (modest_account_settings_dialog_set_account_name):
4147 Only warn about unsaved changes when there are actually unsaved changes.
4149 * src/modest-account-mgr-helpers.c:
4150 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4151 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4152 to get the data from there in future.
4154 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4156 * src/modest-defs.h:
4158 * src/modest-account-mgr-helpers.h:
4159 * src/modest-account-mgr-helpers.c:
4160 Store the security account setting in a single conf key instead of using
4161 the options list, so that the list is left for just the to-be-removed camel hack,
4162 and because gconf_client_set_list() is failing for some reason.
4164 * src/modest-account-mgr.c:
4165 (modest_account_mgr_add_server_account):
4166 * src/maemo/modest-account-settings-dialog.c:
4167 (modest_account_settings_dialog_set_account_name),
4168 (save_configuration): Use the renamed functions.
4171 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4173 * src/widgets/Makefile.am:
4174 * src/widgets/modest-limit-retrieve-combo-box.c:
4175 * src/widgets/modest-limit-retrieve-combo-box.h:
4176 * src/widgets/modest-retrieve-combo-box.c:
4177 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4178 the account settings dialog.
4180 * src/modest-defs.h:
4181 * src/modest-account-mgr-helpers.h:
4182 * src/modest-account-mgr-helpers.c:
4183 (modest_server_account_get_option_secure_auth),
4184 (modest_server_account_set_option_secure_auth):
4185 * src/modest-account-mgr.c:
4186 (modest_account_mgr_add_server_account):
4187 Use the existing AUTH_MECH conf key for the secure-auth setting,
4188 instead of putting it in the list options, because this was actually used already.
4190 * src/maemo/modest-account-settings-dialog.c:
4191 (create_page_account_details),
4192 (modest_account_settings_dialog_set_account_name),
4193 (save_configuration):
4194 * src/maemo/modest-account-settings-dialog.h:
4195 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4196 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4198 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4200 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4201 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4202 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4204 * src/modest-defs.h:
4205 * src/maemo/modest-account-settings-dialog.c:
4206 (create_page_incoming), (on_combo_outgoing_security_changed),
4207 (on_combo_incoming_security_changed), (create_page_outgoing),
4208 (modest_account_settings_dialog_set_account_name),
4209 (save_configuration): Load/Save the port number, and change it when the
4210 security combo changes, to suitable defaults.
4212 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4214 * src/modest-account-mgr.c:
4215 (modest_account_mgr_add_server_account): Set the security and secure-auth
4216 options, and add a comment saying that the other camel-specific options should be
4219 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4221 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4223 * src/modest-tny-account-store.c: (account_list_free),
4224 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4225 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4228 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4230 * src/modest-protocol-info.c:
4231 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4232 is required by our UI spec. Maybe something in our implementation will use this eventually.
4233 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4234 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4235 instead of the previous 0 placeholder.
4237 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4238 secure-auth settings.
4239 * src/modest-account-mgr-helpers.h:
4240 * src/modest-account-mgr-helpers.c:
4241 (modest_server_account_data_get_option_secure_auth),
4242 (modest_server_account_set_option_secure_auth),
4243 (modest_server_account_data_get_option_security),
4244 (modest_server_account_set_option_security): Added this API for getting and setting the security
4245 and secure-auth settings.
4247 * src/maemo/modest-account-settings-dialog.h:
4248 * src/maemo/modest-account-settings-dialog.c:
4249 (modest_account_settings_dialog_finalize), (check_data),
4250 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4251 about changing titles.
4252 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4253 (save_configuration): Save the security and secure-auth settings.
4255 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4256 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4258 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4260 * src/modest-defs.h:
4261 * src/modest-account-mgr.c:
4262 (modest_account_mgr_add_server_account):
4263 Added and used defines for the options key and value pair strings,
4264 that are used so far, though they do not seem to correspond to anything in our
4265 UI specs or ModestProtocol enum.
4267 * src/modest-account-mgr-helpers.h:
4268 * src/modest-account-mgr-helpers.c:
4269 (compare_option_strings_for_name),
4270 (modest_server_account_data_get_option_value),
4271 (modest_server_account_data_get_option_bool),
4272 (modest_account_mgr_get_server_account_option):
4273 Added helper functions for parsing the options GSList.
4275 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4277 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4278 display name is based on the supplied account name.
4279 * src/modest-account-mgr.c:
4280 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4281 with an inefficient, but good-enough, implementation.
4283 * src/maemo/easysetup/modest-easysetup-wizard.c:
4284 (create_page_account_details), (on_before_next), (create_account):
4285 Check for existing display names rather than (non-user-visible) account names, and just
4286 create and set a unique account name at the end.
4288 * src/maemo/modest-account-settings-dialog.c:
4289 (modest_account_settings_dialog_init),
4290 (modest_account_settings_dialog_set_account_name),
4291 (create_page_incoming): Show the display name, instead of the account name.
4292 (on_response): Do some (not all) extra checks, as in the UI spec.
4293 (save_configuration): Save the display name if it was changed.
4295 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4297 * po/en_GB.po: Added needed logical ID and translation.
4298 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4299 (init_view): Made the is-default column clicking work.
4301 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4304 * src/maemo/easysetup/Makefile.am:
4305 * src/maemo/easysetup/modest-easysetup-wizard.c:
4306 (modest_easysetup_wizard_dialog_init):
4307 * src/maemo/easysetup/provider-data-test.keyfile:
4308 * src/maemo/easysetup/provider-data.keyfile:
4309 Moved the provider data file to the new modest-providers-data package and used it from there.
4311 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4313 * src/modest-local-folder-info.c:
4314 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4315 N_() was already used on the static strings, but this just marks it for translation without
4316 using the translation.
4318 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/modest-account-settings-dialog.c:
4321 (create_page_incoming),
4322 (modest_account_settings_dialog_set_account_name):
4323 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4324 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4325 I will do this if nobody else gets there first.
4327 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4329 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4330 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4331 save the security stuff.
4333 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4335 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4336 Set the email address and user fullname, which I now see must be
4339 * src/maemo/modest-account-settings-dialog.h:
4340 * src/maemo/modest-account-settings-dialog.c:
4342 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4343 leave-on-server and authentication.
4344 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4347 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4350 * src/maemo/modest-account-settings-dialog.c:
4351 * src/maemo/modest-account-settings-dialog.h:
4352 Most (but not all) of the widgets are now present as specified by the UI spec.
4353 No changes are yet saved, and some details are not properly shown yet.
4355 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4357 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4359 * src/maemo/Makefile.am:
4360 * src/maemo/modest-account-settings-dialog.c:
4361 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4362 an existing account. Doesn't do much yet.
4364 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4365 Open the accounts settings dialog when Edit is clicked.
4367 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4369 * src/maemo/easysetup/Makefile.am:
4370 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4372 * src/maemo/easysetup/modest-easysetup-wizard.c:
4373 (modest_easysetup_wizard_dialog_init):
4374 Try to get the source directory from the build system,
4375 instead of hard-coding "./" into the source code, when opening our local
4376 copies of the configuration files.
4377 But this still fails when opening the wizard from the Accounts window,
4378 maybe because the working directory seems to change at runtime.
4379 So the wizard will fail the second time unless you copy the files into their
4380 proper locations - see the stdout warnings for the paths.
4382 (create_page_account_details),(on_before_next):
4383 Check for existing non-server accounts instead of server accounts,
4384 so the default account name is useful again, and to prevent trying to
4387 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4388 Show the wizard when New is clicked.
4390 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4391 (init_view): Show the column headers, and show the columns that are
4392 specified in the UI specs. However, something in Maemo's GTK+ prevents
4393 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4394 change the default account. This is despite unsetting the special properties.
4396 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4398 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4399 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4400 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4401 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4402 to make that clearer.
4403 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4405 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4407 * src/maemo/modest-account-view-window.c:
4408 (modest_account_view_window_init),
4409 (modest_account_view_window_new):
4410 Use the same buttons as specified in the
4411 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4412 the existing widgets, which never had a chance of working.
4413 Put the ModestAccountView treeview in a scrolled window.
4414 Do not repeat the initialization in both _init() and _new().
4416 * src/widgets/modest-account-view.c: (update_account_view):
4417 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4418 this widget and window shows no accounts.
4420 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4422 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4424 * src/maemo/easysetup/modest-easysetup-wizard.c:
4425 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4426 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4427 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4430 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4431 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4432 accounts exist yet, as in the UI spec.
4434 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4436 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4438 * src/maemo/Makefile.am:
4439 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4440 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4441 New window for editing connection-specific smtp details.
4442 Not fully implemented.
4444 * src/maemo/modest-connection-specific-smtp-window.c:
4445 (modest_connection_specific_smtp_window_finalize) :
4446 unref the tree model.
4447 (on_button_edit): Show the edit window.
4449 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4451 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4454 * src/maemo/Makefile.am:
4455 * src/maemo/modest-connection-specific-smtp-window.c:
4456 * src/maemo/modest-connection-specific-smtp-window.h:
4457 New window for showing the list of connections, for connection-specific
4458 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4459 * src/maemo/easysetup/modest-easysetup-wizard.c:
4460 (create_page_custom_outgoing): Show the new window when the button is clicked.
4462 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4464 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4465 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4466 * src/maemo/modest-msg-edit-window.c:
4467 (modest_msg_edit_window_insert_image):
4468 * src/modest-conf.c: (modest_conf_key_escape):
4469 * src/modest-mail-operation.c:
4470 (modest_mail_operation_send_new_mail):
4471 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4472 (modest_ui_actions_on_new_account):
4473 * src/widgets/modest-attachment-view.c: (update_filename_request):
4474 * src/widgets/modest-mail-header-view.c:
4475 Corrected warnings that were breaking the build, by commenting out unused variables,
4476 and a function, and by including a header.
4478 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4480 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4481 so we can #ifdef around platform-specific code when necessary.
4482 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4483 to allow this to build for the GNOME platform too.
4485 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4487 * src/maemo/easysetup/modest-easysetup-wizard.c:
4488 Added util_increment_name() and used it in create_page_account_details()
4489 to make sure that the default account name is always a new name.
4491 (modest_easysetup_wizard_dialog_init),
4492 (set_default_custom_servernames): Some minor memory management fixes.
4494 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4498 * src/modest-runtime.c: (init_i18n): Restored the translation
4499 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4500 are defined in config.h, and the translations are installed.
4502 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4503 is defined for translation.
4505 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4507 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4509 * src/maemo/easysetup/modest-easysetup-wizard.c:
4510 (modest_easysetup_wizard_dialog_init):
4511 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4512 Use realistic paths (though they should use $prefix generically) to the
4513 mcc_mapping and provider-data.keyfile files which might work when they
4514 are installed by the future version of the operator-wizard package,
4515 and then fallback to paths in our source code, with an explanatory
4518 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4522 * src/maemo/Makefile.am:
4523 * src/maemo/easysetup/: Added files from the previously-exernal
4524 osso-modest-easysetup.
4525 * src/maemo/modest-main-window-ui.h:
4526 * src/modest-ui-actions.c:
4527 * src/modest-ui-actions.h:
4528 Added modest_ui_actions_on_new_account() as a signal handler for the
4529 New Account menu item. It shows the easysetup wizard.
4530 * po/en_GB.po: Added additional needed logical IDs and translations.