1 2007-06-19 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
4 Initialize the continue_download variable to fix the build, and probably
5 to fix randome behaviour.
7 2007-06-18 Armin Burgmeier <armin@openismus.com>
9 * src/modest-tny-send-queue.h:
10 * src/modest-tny-send-queue.c: Keep track of the status of messages in
11 the queue so we can later show it in the UI. Replaced
12 modest_tny_send_queue_msg_is_being_sent() by
13 modest_tny_send_queue_get_msg_status().
15 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
17 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
18 gpointer. This probably was not harmful, but just to be sure.
20 2007-06-18 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
23 Fix the build, but leave the function broken on Bora, because
24 hildon_uri_action_get_service() does not exist.
25 osso_uri_action_get_service() does not exist either, it seems.
27 2007-06-18 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-tny-account.c:
30 (modest_tny_account_new_from_server_account):
31 Uncommented the url debug output again, because it is useful for
32 debugging, as I said in the comment.
34 2007-06-18 Murray Cumming <murrayc@murrayc.com>
36 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
38 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
39 for Mameo Bora, to fix the build.
41 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
44 Fixed build with hildon < 0.99
46 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
47 Check if the selected account is busy instead of checking all accounts
49 * src/modest-account-mgr-priv.h:
50 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
51 (modest_account_mgr_init), (compare_account_name),
52 (modest_account_mgr_set_account_busy),
53 (modest_account_mgr_account_is_busy):
54 * src/modest-account-mgr.h:
55 Added busy information to the account manager. It possible to
56 set an account to busy or not busy now.
58 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
59 (modest_mail_operation_update_account),
60 (modest_mail_operation_notify_end):
61 Set the account to busy/not busy depending on the operation state.
63 * src/widgets/modest-account-view.c:
64 (modest_account_view_finalize), (get_last_updated_string),
65 (update_account_view), (on_account_busy_changed), (init_view):
66 Show string "Refreshing..." if the account is currently busy.
68 All this fixes projects.maemo.org bug NB#59711
70 2007-06-14 Armin Burgmeier <armin@openismus.com>
72 * src/widgets/modest-attachments-view.h:
73 * src/widgets/modest-attachments-view.c: Added
74 modest_attachments_view_has_attachments() and fixed coordinate
75 transformation in get_att_view_at_coords(). This fixes attachment
78 * src/widgets/modest-msg-view.c: Make use of
79 modest_attachments_view_has_attachments() to decide whether to show
80 attachments in the header.
82 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
84 * src/maemo/modest-connection-specific-smtp-edit-window.c:
85 (on_change), (on_combo_security_changed),
86 (modest_connection_specific_smtp_edit_window_init),
87 (modest_connection_specific_smtp_edit_window_set_connection),
88 (modest_connection_specific_smtp_edit_window_is_dirty):
89 * src/maemo/modest-connection-specific-smtp-edit-window.h:
90 * src/maemo/modest-connection-specific-smtp-window.c:
93 Show an comfirmation dialog for the smpt-edit-window if there are
94 unsaved changes and the user hits cancel.
95 (projects.maemo.org bug NB#60479)
97 2007-06-14 Armin Burgmeier <armin@openismus.com>
99 * src/maemo/easysetup/modest-easysetup-wizard.c:
100 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
101 address" info in banner instead of node, and select all the text as
102 per UI spec. This fixes projects.maemo.org bug NB#60550.
104 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
106 reviewed by: <delete if not using a buddy>
108 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
109 * src/modest-ui-actions.c: (folder_refreshed_cb):
111 2007-06-14 Murray Cumming <murrayc@murrayc.com>
113 * src/widgets/modest-folder-view.c: (filter_row):
114 Explictly filter out the per-account outbox accounts. I don't know why
115 these only sometimes show up, but now they should never show up in the UI.
116 This should fix projects.maemo.org bug NB#60160.
118 2007-06-14 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
121 when the toolbar does not exist yet.
122 * src/modest-widget-memory.c: (save_settings_header_view):
123 Added g_warnings() to help us to discover when we are trying to set
124 an empty columns list in gconf.
126 2007-06-14 Murray Cumming <murrayc@murrayc.com>
130 Added modest_init_get_default_header_view_column_ids().
132 * src/modest-widget-memory.c: (restore_settings_header_view):
133 Use the new function to get defaults, if the gconf key is empty,
134 instead of not creating any columns. This seems to fix the
135 empty right-hand pane problems.
137 * src/widgets/modest-header-view.h: Improved documentation.
139 2007-06-13 Murray Cumming <murrayc@murrayc.com>
141 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
142 Revert the use of the display name as the account name, because this
143 is generally wrong and would break the code that follows.
145 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
147 * src/maemo/easysetup/modest-easysetup-wizard.c:
148 (check_for_supported_auth_methods), (on_before_next),
151 More correct fix for projects.maemo.org bug NB# 58991
152 Do not longer accept AUTH_PASSWORD as secure method and choose
153 correct method when creating the account.
155 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
157 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
158 Fixed projects.maemo.org bug NB# 58991
160 2007-06-13 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-init.c: (modest_init_init_core),
163 (modest_init_local_folders): Fixed compilation errors.
165 2007-06-13 Murray Cumming <murrayc@murrayc.com>
167 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
168 Remove unnecessary lib/include, though it is good in principle when needed.
170 * src/modest-init.c: (modest_init_one_local_folder),
171 (modest_init_local_folders):
172 * src/modest-init.h: Initialize the .modest library for memory cards,
173 instead of just doing nothing for them. This should allow us to create
174 folders there, fixing projects.maemo.org bug NB#59297.
176 2007-06-13 Murray Cumming <murrayc@murrayc.com>
178 * libmodest-dbus-client/libmodest-dbus-client.c:
179 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
180 (libmodest_dbus_client_compose_mail),
181 (libmodest_dbus_client_open_message),
182 (libmodest_dbus_client_send_and_receive),
183 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
185 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
186 (on_idle_open_message), (modest_dbus_req_handler),
187 (search_result_to_message), (modest_dbus_req_filter):
188 * src/modest-search.c: (add_hit), (modest_search_folder),
189 (modest_search_all_accounts): Improved debug messages.
191 * tests/dbus_api/test_open_message.c: (main): Improved comments.
193 * src/modest-tny-account-store.c:
194 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
197 2007-06-13 Murray Cumming <murrayc@murrayc.com>
200 2007-06-12 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-tny-account-store.c: (get_server_accounts):
203 Call modest_tny_local_folders_account_add_merged_outbox_folders()
204 even when there are no accounts, so that the Outbox folder is always
205 visible. This fixes projects.maemo.org bug NB#60158.
207 2007-06-12 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/modest-main-window.c: (create_details_widget):
210 Use the mcen_va_never logical ID.
212 2007-06-12 Murray Cumming <murrayc@murrayc.com>
214 * src/dbus_api/modest-dbus-api.h:
215 * src/dbus_api/modest-dbus-callbacks.c:
216 (on_idle_open_default_inbox), (on_open_default_inbox),
217 (modest_dbus_req_handler):
218 Added a new OpenDefaultInbox method.
220 * libmodest-dbus-client/libmodest-dbus-client.h:
221 * libmodest-dbus-client/libmodest-dbus-client.c:
222 Added libmodest_dbus_client_open_default_inbox() to call the new
223 dbus method. This should be useful to projects.maemo.org bug NB#57214,
224 though it should maybe be used by a new osso-email-interface function.
226 * tests/dbus_api/Makefile.am:
227 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
230 2007-06-12 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
233 NULL, so that the signals get all the keys. This should not actually
234 change any behaviour because we currently update everything when anything
237 2007-06-12 Murray Cumming <murrayc@murrayc.com>
239 * src/widgets/modest-folder-view.c: (text_cell_data),
240 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
241 (find_inbox_iter): If tinymail tells us that the folder is
242 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
243 This causes the inbox to be selected at startup, fixing part of
244 projects.maemo.org bug NB#56305.
246 * src/modest-ui-dimming-rules.c:
247 (modest_ui_dimming_rules_on_tools_smtp_servers):
248 * src/modest-ui-dimming-rules.h: Added a callback function to dim
249 the SMTP servers menu item.
250 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
251 that the SMTP Servers menu item is dimmed when there are no accounts,
252 as a future version of the UI spec will require. This fixes
253 projects.maemo.org bug NB#56305.
255 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
257 * src/maemo/modest-maemo-utils.c:
258 (modest_maemo_utils_get_supported_secure_authentication_methods):
259 Added label to dialog instead of unreadable title
261 * src/maemo/modest-main-window.c: (sync_accounts_cb),
262 (modest_main_window_new):
263 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
266 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
267 * src/modest-account-mgr.h:
268 Added method to avoid code duplication
270 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
271 (modest_ui_actions_on_send_receive):
272 Use modest_account_mgr_has_accounts
274 2007-06-11 Murray Cumming <murrayc@murrayc.com>
276 * src/maemo/easysetup/modest-presets.c:
277 (modest_presets_get_info_server_security): Do not report secure auth
279 * src/modest-protocol-info.c: Use the defines for the gconf key names
280 for secure authentication. This was not working because we were writing
281 Password and reading password, and the check was case sensitive.
282 With this, gmail now works for receiving and sending when created via
285 2007-06-11 Murray Cumming <murrayc@murrayc.com>
287 * src/maemo/easysetup/modest-presets.c:
288 (modest_presets_get_info_server_security): Correct the key name for
289 SecureSmtp, because it seems to be case-sensitive.
290 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
291 Do not try to get the 0th notebook page if there are 0 pages, to
294 2007-06-11 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
297 Prevent use of the new notification feature for now, because it currently
298 shows one dialog for each new email, which is annoying.
300 2007-06-11 Murray Cumming <murrayc@murrayc.com>
302 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
303 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
304 when no country was selected, so that we show the global ones.
305 * src/maemo/easysetup/modest-presets.c:
306 (modest_presets_get_providers): Return only the global providers, not
307 all providers when mmc=0 was requested.
309 2007-06-11 Murray Cumming <murrayc@murrayc.com>
311 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
312 (easysetup_provider_combo_box_fill): Remove debug code that showed the
313 provider ID in the combo.
315 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
316 Do not show the page numbers, because it would be confusing when we add
317 the 2 extra pages for the custom setup, when the user chooses the "Other"
318 provider. This fixes projects.maemo.org bug NB#59028
320 * src/modest-init.c: (modest_init_init_core),
321 (modest_init_local_folders):
323 * src/modest-tny-account.c:
324 (modest_tny_account_new_for_local_folders): Do not create default folders
325 for the memory card. This should fix projects.maemo.org bug NB#59328.
327 2007-06-11 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
330 Free the changed_conf_keys string items. They are already freed in the
331 idle handler if that runs first.
333 2007-06-11 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-ui-actions.c:
336 (modest_ui_actions_on_password_requested): Check that the server name
337 is not NULL, because I just saw a password dialog with (null) as the
340 * src/modest-tny-folder.[h|c]: Added
341 modest_tny_folder_is_memory_card_folder().
342 * src/modest-ui-dimming-rules.c:
343 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
344 menu item for memory cards, as per the UI spec (section 7.4). This should
345 fix projects.maemo.org bug NB#59297.
347 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
349 * src/maemo/modest-main-window.c: (sync_accounts_cb):
350 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
351 is another problem with the code, see Murray's comment at line 772)
353 2007-06-08 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
356 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
357 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
358 (load_from_file), (easysetup_country_combo_box_init),
359 (easysetup_country_combo_box_get_active_country_ids),
360 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
361 instead of just one ID, to avoid duplicate country names in the UI.
363 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
364 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
365 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
366 a single ID, avoiding duplicate providers.
367 * src/maemo/easysetup/modest-easysetup-wizard.c:
368 (on_combo_account_country): Adapt to use a list.
370 2007-06-08 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
373 keys changed in the last X seconds.
375 * src/modest-account-mgr.h:
376 * src/modest-account-mgr.c: (on_timeout_notify_changes),
377 (on_key_change), (modest_account_mgr_class_init),
378 (modest_account_mgr_init), (modest_account_mgr_finalize):
379 As the keys are changed, save them in a GSList* and signal that GSList*
380 further every X seconds, to batch changes, to allow us to do just one
381 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
382 bug NB#56941 and other (UI-blocking) delays when changing account settings.
384 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
385 changed signal signature.
387 * src/modest-conf.c: (modest_conf_set_list),
388 (modest_conf_on_change): Reenable notification.
390 (modest_conf_maemo_fake_on_change): Comment out the hack that
391 notified immediately instead of asynchronously.
393 * src/widgets/modest-account-view.h:
394 * src/widgets/modest-account-view.c:
395 (update_account_view): Select the previously-selected account ID,
396 if possible. This fixes projects.maemo.org bug NB#56933.
398 (on_account_changed), (on_account_removed),
399 (modest_account_view_select_account):
401 Remove the block/unblock functions
402 because they were not useful.
404 * src/maemo/modest-account-view-window.c:
405 (on_delete_button_clicked), (on_edit_button_clicked),
406 (on_new_button_clicked): Remove the use of the non-working block/unblock.
408 2007-06-08 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
411 Improve the error dialog to show Incorrect Account Settings, which seems
412 clearer, and say that the internal error message (to be removed from the
413 dialog later) is often misleading.
414 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
416 * src/modest-tny-account.c:
417 (modest_tny_account_new_from_server_account): Uncomment the printf of the
418 URL because this is so useful for debugging on the device.
420 * src/widgets/modest-serversecurity-combo-box.c:
421 (modest_serversecurity_combo_box_fill): Correct a logical ID.
423 2007-06-08 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-mail-operation.c:
426 (modest_mail_operation_send_new_mail):
427 Added a comment about a nasty but apparently harmless message. Details
428 added to the wiki g_warnings() page.
430 2007-06-08 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
433 (modest_tny_send_queue_class_init):
434 Do not use the priv struct because it is empty, to avoid g_warnings
435 about a non-existant priv struct.
437 * src/modest-tny-account-store.c:
438 (modest_tny_account_store_get_server_account),
439 (modest_tny_account_store_get_transport_account_for_open_connection
440 ): Do not try to get transport server accounts for local folders,
441 because they don't have any. This avoids a g_warning().
443 * src/maemo/modest-main-window.c:
444 (modest_main_window_notify_send_receive_initied),
445 (on_configuration_key_changed):
446 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
448 * src/modest-mail-operation.c:
449 (modest_mail_operation_update_account):
450 * src/modest-tny-account-store.h:
451 * src/modest-tny-account.c:
452 (modest_tny_account_get_special_folder),
453 (modest_tny_account_new_for_local_folders),
454 (modest_tny_account_new_for_per_account_local_outbox_folder):
455 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
456 * src/modest-tny-local-folders-account.c:
457 (add_account_folders_to_merged_folder):
458 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
459 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
460 (modest_ui_actions_on_send):
461 * src/widgets/modest-folder-view.c: (update_model):
462 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
463 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
464 modest_tny_account_store_get_tny_account_by_account() to
465 modest_tny_account_store_get_server_account() to make the code clearer.
467 2007-06-07 Marcus Bauer <marcusb@openismus.com>
469 * src/dbus_api/modest-dbus-api.h:
470 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
471 * src/maemo/modest-msg-edit-window.c:
472 (modest_msg_edit_window_attach_file_noninteractive):
473 added g_warning in case the file to be attached does not exist
474 * tests/dbus_api/test_compose_mail.c: (main):
475 removed obsolete comment, added generic files as test case
477 2007-06-07 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account-store.c: (get_server_accounts):
480 Create the local folders account only once, not once for each outbox, and
481 not only when there are some outboxes.
483 2007-06-07 Murray Cumming <murrayc@murrayc.com>
485 * src/widgets/modest-folder-view.c: (update_model): Comment out some
486 code that is causing a crash at startup. Sergio says that he is fixing this.
488 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
490 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
491 * src/maemo/modest-account-settings-dialog.c:
492 (create_page_outgoing),
493 (modest_account_settings_dialog_set_account_name),
494 (save_configuration):
495 - Fixed handling of the "Use secure authentication" toggle to comply with
496 the ui specification. See also projects.maemo.org bug NB#58400
498 - Restore the Secure connection setting combo correctly when loading
501 * src/maemo/modest-maemo-utils.c:
502 (on_camel_account_get_supported_secure_authentication),
503 (modest_maemo_utils_get_supported_secure_authentication_methods):
504 Fixed a crasher if operation is canceled
506 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
507 (modest_protocol_info_auth_is_secure):
508 * src/modest-protocol-info.h:
510 Added two new methods to determine if a protocol/auth method is secure/encrypted in
511 the sense of the "Use secure authentication" toggle.
513 2007-06-07 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account-store.h:
516 * src/modest-tny-account-store.c:
517 Added modest_tny_account_store_get_local_folders_account().
519 * src/modest-tny-folder.h:
520 * src/modest-tny-folder.c:
521 (modest_tny_folder_get_account):
522 Added this replacement for tny_folder_get_account() which returns
523 the local-folders account for TnyMergeFolders, to avoid the
524 warning about the unimplemented get_account_func() vfunc().
526 (modest_tny_folder_get_rules),
527 * src/modest-ui-actions.c:
528 (modest_ui_actions_on_folder_selection_changed):
529 * src/modest-mail-operation.c:
530 (modest_mail_operation_remove_folder),
531 (modest_mail_operation_xfer_folder),
532 (modest_mail_operation_rename_folder),
533 (modest_mail_operation_get_msg),
534 (modest_mail_operation_get_msgs_full),
535 (modest_mail_operation_remove_msg),
536 (modest_mail_operation_xfer_msgs),
537 (modest_mail_operation_refresh_folder):
538 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
540 2007-06-07 Murray Cumming <murrayc@murrayc.com>
542 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
543 (modest_server_account_set_security):
544 * src/modest-defs.h: Add comments explaining that our
545 UI spec means TLS when it says Normal, so these do not look like errors.
547 * src/modest-tny-account.c:
548 (modest_tny_account_new_from_server_account): Use the new tinymail
549 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
550 for TLS. This should fix projects.maemo.org bug NB#58460.
552 2007-06-06 Murray Cumming <murrayc@murrayc.com>
554 * src/maemo/easysetup/modest-easysetup-wizard.c:
555 (create_account): Correct the position of the gconf sanity check warning.
556 (on_button_edit_advanced_settings): Show the dialog immediately, instead
557 of using the g_idle_add() hack, because this does not seem to be necessary
558 on osso 1.1. It might even work on Maemo Bora if the problems were actually
559 caused by something other than maemo's gconf.
560 This fixes projects.maemo.org bug #59022.
562 2007-06-06 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-account-mgr-helpers.c:
565 (modest_account_mgr_get_default_account): Do not check that the account
566 exists if there is no default account (NULL), to fix a runtime warning.
568 2007-06-06 Murray Cumming <murrayc@murrayc.com>
570 * src/widgets/modest-folder-view.c: (update_model):
571 Do not unref the treemodel before we have finished with it.
572 This prevents a valgrind warning and an occasional crash at startup.
574 2007-06-06 Marcus Bauer <marcusb@openismus.com>
576 * libmodest-dbus-client/libmodest-dbus-client.h:
577 added libmodest_dbus_client_compose_mail()
578 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
580 added functions needed for SendAsMail() functionality
581 * src/maemo/modest-msg-edit-window.c:
582 (modest_msg_edit_window_attach_file_noninteractive):
583 non interactively attaching files to message edit window
584 * src/widgets/modest-msg-edit-window.h:
585 * tests/dbus_api/Makefile.am:
586 added test_compose_mail.c
587 * tests/dbus_api/test_compose_mail.c: (main):
589 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
591 * src/modest-account-view.c:
592 Fixed bug projects.maemo.org bug NB#59307
594 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
596 * src/maemo/easysetup/modest-easysetup-wizard.c:
597 (get_serverport_incoming), (on_before_next), (create_account):
598 * src/maemo/modest-account-settings-dialog.c:
599 (modest_account_settings_dialog_set_account_name):
600 * src/maemo/modest-maemo-utils.c:
601 (on_camel_account_get_supported_secure_authentication_status),
602 (on_camel_account_get_supported_secure_authentication),
603 (on_secure_auth_cancel),
604 (modest_maemo_utils_get_supported_secure_authentication_methods):
606 Implemented security authentication for settings and easysetup.
608 2007-06-05 Murray Cumming <murrayc@murrayc.com>
610 * src/maemo/modest-main-window.c: (create_details_widget):
611 Show the total size for memory card accounts too, instead of showing
612 the name again. Fixes bug projects.maemo.org bug NB#59307.
614 2007-06-05 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-tny-simple-folder-store.c:
618 * src/modest-tny-simple-folder-store.h: Removed.
620 * src/modest-tny-local-folders-account.h
621 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
622 for the local-folders maildir, with an extra TnyMergedFolder containing
623 the folders of the per-account outbox store accounts.
624 * src/modest-tny-account-store.c: (get_server_accounts):
625 Add the outboxes to the special local folders account after creating it.
627 * src/modest-tny-account.c:
628 (modest_tny_account_new_for_local_folders): Create the derived
629 account when creating the main local-folders account.
631 * src/maemo/modest-main-window.c: (create_details_widget),
632 (modest_main_window_set_contents_style):
633 Adapted to the use of the derived account instead of the folder store.
635 * src/modest-ui-actions.c:
636 (modest_ui_actions_on_folder_selection_changed):
637 * src/modest-ui-dimming-rules.c:
638 (modest_ui_dimming_rules_on_new_folder):
639 * src/widgets/modest-folder-view.c: (text_cell_data),
640 (icon_cell_data), (filter_row), (update_model),
641 (get_cmp_rows_type_pos):
644 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
645 Do not get the priv struct, because no priv struct has been set,
646 to avoid a runtime warning.
648 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
649 #ifelse with #else, to fix a warning, to fix the build.
652 2007-06-05 Christian Kellner <ckellner@openismus.com>
654 * libmodest-dbus-client/libmodest-dbus-client.c:
655 Fix small typo in doc (why do you always see them
656 AFTER committing stuff?)
659 2007-06-05 Christian Kellner <ckellner@openismus.com>
661 * libmodest-dbus-client/libmodest-dbus-client.c:
662 (libmodest_dbus_client_search):
663 Initialize hit list with NULL. Also set folder list
664 to "" if NULL was supplied.
667 2007-06-03 Christian Kellner <ckellner@openismus.com>
669 * libmodest-dbus-client/libmodest-dbus-client.c:
670 (modest_search_hit_list_free):
671 Make it save to call it with NULL.
673 * src/dbus_api/modest-dbus-callbacks.c:
674 * src/modest-search.c:
675 Return full ModestSearchHits as the search result list not TnyHeader
676 since can't be around withouth the correspoding TnyFolder.
678 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
680 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
681 Added currently commented code to check for secure auth
683 * src/maemo/modest-account-settings-dialog.c: (on_response),
684 (save_configuration), (show_ok):
685 Fixed projects.maemo.org bugs NB #59248 and #59251
687 * src/maemo/modest-maemo-utils.c:
688 (on_camel_account_get_supported_secure_authentication_status),
689 (on_camel_account_get_supported_secure_authentication),
690 (modest_maemo_utils_get_supported_secure_authentication_methods):
691 * src/maemo/modest-maemo-utils.h:
692 Moved get_supported_secure_authentication() method here to be able
693 to use it from easysetup wizard.
695 * src/modest-pair.c: (on_pair_compare_as_string):
696 Should compare string with first part of pair and not
697 strcmp pairs which will crash.
699 * src/modest-protocol-info.c:
700 (modest_protocol_info_protocol_is_store):
701 * src/modest-protocol-info.h:
702 Added modest_protocol_info_get_auth_protocol_name()
704 2007-06-03 Armin Burgmeier <armin@openismus.com>
706 * src/modest-mail-operation.c:
707 (modest_mail_operation_get_msgs_full): Set priv->account also when
708 only retrieving a single message. This avoids a crash when canceling
711 (modest_mail_operation_notify_end): Do not explicitely remove the
712 operation from the queue but only emit the progress_changed signal.
713 The queue itself listens to that signal to remove the operation when
714 it is finished. This reduces coupling and removes a potential deadlock
715 when modest_mail_operation_notify_end() is called from the queue
716 itself. If that is a problem performance-wise, I would suggest to
717 implement a status-changed signal or something.
719 * src/modest-mail-operation-queue.c: Make sure to never call a
720 function from another file while the queue is locked. This (hopefully)
721 fixes another deadlock when exiting the application while retrieving
724 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
726 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
727 Fixed build if libogs is not available
729 2007-06-03 Christian Kellner <ckellner@openismus.com>
731 * libmodest-dbus-client/libmodest-dbus-client.h:
732 * libmodest-dbus-client/libmodest-dbus-client.c:
733 (libmodest_dbus_client_delete_message):
734 Implement deletion of messages (Client side).
736 (modest_search_hit_free),
737 (modest_search_hit_list_free):
738 Utility functions to free the result hits.
740 * src/dbus_api/modest-dbus-api.h:
741 * src/dbus_api/modest-dbus-callbacks.c:
743 (modest_dbus_req_handler):
744 Implement deletion of messages (Server side).
746 * tests/dbus_api/test_search.c: (main):
749 * tests/dbus_api/Makefile.am:
750 * tests/dbus_api/test_delete_message:
751 Add little test for the message deletion logic
753 2007-06-03 Armin Burgmeier <armin@openismus.com>
755 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
756 when the operation queue was not empty. projects.maemo.org bug
759 2007-06-03 Armin Burgmeier <armin@openismus.com>
761 * src/widgets/modest-account-view.c
762 (on_account_default_toggled): Toggle default account column
763 explicitely instead of waiting for gconf notification (which is
764 currently ignored). This should fix projects.maemo.org bug NB#56910
765 for now. It should probably be removed when gconf notifications are
768 2007-06-03 Christian Kellner <ckellner@openismus.com>
770 * libmodest-dbus-client/libmodest-dbus-client.c:
771 Removed debugging spew.
773 * src/dbus_api/modest-dbus-callbacks.c:
774 Added debugging info.
776 * src/modest-search.c:
777 (modest_search_all_accounts):
778 Use tny_account_store_get_accounts () on the account store
779 to get all accounts which is the way to get all accounts.
781 * tests/dbus_api/test_search.c: (main):
782 Make it possible to supply the search term on the command line.
784 2007-06-03 Christian Kellner <ckellner@openismus.com>
786 * libmodest-dbus-client/libmodest-dbus-client.c:
787 * libmodest-dbus-client/libmodest-dbus-client.h:
788 Implement searching for mesages over raw dbus. (Client side)
790 * src/dbus_api/Makefile.am:
791 * src/dbus_api/modest-dbus-api.h:
792 * src/dbus_api/modest-dbus-callbacks.c:
793 * src/dbus_api/modest-dbus-callbacks.h:
794 Search framework (Server side). Also implement on_idle_open_message().
796 * src/maemo/modest-platform.c: (modest_platform_init):
797 Prepare for raw dbus/osso rpc interaction.
799 * src/modest-search.h:
800 Changed minsize from unspecific guint to guint32.
802 * src/modest-search.c:
804 Added strange hack which magically made tnymail work.
806 (modest_search_folder),
807 (modest_search_account),
808 (modest_search_all_accounts):
809 Implement helper functions to search all accounts, specific account
812 * tests/dbus_api/Makefile.am:
813 * tests/dbus_api/test_open_message.c:
814 Read url to open from commandline.
816 * tests/dbus_api/test_search.c:
817 Implement small test for dbus search stuff
819 2007-06-02 Armin Burgmeier <armin@openismus.com>
821 * src/maemo/modest-account-settings-dialog.c: Changed window title to
822 include account type and account title. This fixes projects.maemo.org
825 * src/maemo/modest-account-view-window.c: Set a title for the window.
827 2007-06-02 Armin Burgmeier <armin@openismus.com>
829 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
830 incoming and outgoing server name based on email address and server
831 types as long as the names have not been edited manually. This fixes
832 projects.maemo.org bug NB#58671.
834 2007-06-02 Armin Burgmeier <armin@openismus.com>
836 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
837 server type cannot be changed in future to the incoming details page
838 when creating an account. This fixes projects.maemo.org bug NB#59029.
840 2007-06-02 Armin Burgmeier <armin@openismus.com>
842 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
843 and assigned max width chars so that they wrap instead of being
844 truncated. Fixes projects.maemo.org bug NB#56126.
846 2007-06-02 Armin Burgmeier <armin@openismus.com>
848 * src/maemo/modest-connection-specific-smtp-window.c: Add an
849 introductory note to the connection specific smtp servers dialog, as
850 section 8.12 of the email UI specification requires. This fixes
851 projects.maemo.org bug NB#59212.
853 2007-06-01 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
856 Check for running mail operations, and offer to cancel them, as per the UI
857 spec. This fixes projects.maemo.org bug NB#59041 .
858 However, I suspect that tinymail may still use the network connection
859 in ways that we cannot detect or cancel. But it should at least adapt to
862 2007-06-01 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-tny-account-store.c: (recreate_all_accounts),
865 (get_cached_accounts), (get_server_accounts): Do more sensible
866 ref-counting of the temporarily-cached outbox accounts list. This seems
867 to fix a crash when entering the password when the password was wrong.
869 2007-06-01 Murray Cumming <murrayc@murrayc.com>
871 * src/gnome/modest-main-window.c: (connect_signals):
872 * src/modest-tny-account-store.c: (get_password),
873 (modest_tny_account_store_alert): Added comments and clues and
874 commented-out code about how we currently fail to deal with connection
875 errors and wrong passwords, and how we should.
877 2007-06-01 Murray Cumming <murrayc@murrayc.com>
879 * src/widgets/modest-retrieve-combo-box.c:
880 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
881 This fixes projects.maemo.org bug NB#58472 .
883 2007-06-01 Murray Cumming <murrayc@murrayc.com>
885 * src/maemo/easysetup/modest-easysetup-wizard.c:
886 (create_page_complete_easysetup):
887 (create_page_complete_custom): Correct the last commit,
888 putting the correct sentences in the correct pages.
890 2007-06-01 Murray Cumming <murrayc@murrayc.com>
892 * src/maemo/easysetup/modest-easysetup-wizard.c:
893 (create_page_complete_custom): Show the second sentence of text
894 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
897 2007-06-01 Murray Cumming <murrayc@murrayc.com>
899 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
900 Set the leave-on-server conf key by default. This fixes
901 projects.maemo.org bug NB#59258 .
903 2007-06-01 Murray Cumming <murrayc@murrayc.com>
905 * src/maemo/modest-account-view-window.c:
906 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
907 logical ID for the confirmation messages. Fixed projects.maemo.org bug
910 2007-06-01 Murray Cumming <murrayc@murrayc.com>
912 * src/maemo/easysetup/modest-easysetup-wizard.c:
913 (create_caption_new_with_asterisk):
914 * src/maemo/modest-account-settings-dialog.c:
915 (create_caption_new_with_asterisk):
916 Uncomment the code to add the asterisk, because they are no longer in the
917 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
918 (update_incoming_server_title): Add an asterisk here too.
920 2007-06-01 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-maemo-global-settings-dialog.c:
923 (current_connection): Check that we are even connected before trying to
924 get the current connection name, to prevent a warning.
926 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
927 Change the comments because tny_maemo_conic_device_connect() is now meant to
929 * src/modest-mail-operation.c:
930 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
931 make sure we have a connection and fail if we can't connect.
933 2007-05-31 Murray Cumming <murrayc@murrayc.com>
935 * src/maemo/modest-main-window.c:
936 (on_account_store_connecting_finished): Do not try to get the
937 connection ID if we are not really connected. I am surprised that
938 this signal handler is called when we are not connected.
940 2007-05-31 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-error.h:
943 * src/modest-ui-actions.c:
944 (modest_ui_actions_get_msgs_full_error_handler):
945 Renamed an enum, added comments, added an enum
946 for retrieve-limit errors.
948 * src/modest-mail-operation.c: (foreach_add_item),
949 (internal_folder_observer_update), (update_account_thread),
950 (modest_mail_operation_get_msgs_full):
951 (modest_mail_operation_update_account),
952 Added comments about how this works, and some code that should
953 (but does not) check the retrieve-limit. See the TODO comment.
955 2007-05-31 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
958 Initialize help_id to fix the build. Warnings are good.
960 2007-05-31 Murray Cumming <murrayc@murrayc.com>
962 * src/widgets/modest-hbox-cell-renderer.c:
963 (modest_hbox_cell_renderer_append):
964 * src/widgets/modest-vbox-cell-renderer.c:
965 (modest_vbox_cell_renderer_append):
966 Fix the last commit by doing an extra ref.
968 2007-05-31 Murray Cumming <murrayc@murrayc.com>
970 * src/widgets/modest-hbox-cell-renderer.c:
971 (modest_hbox_cell_renderer_append):
972 * src/widgets/modest-vbox-cell-renderer.c:
973 (modest_vbox_cell_renderer_append):
974 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
975 to fix the build with Maemo Bora.
976 However, there seems to be a remaining crash, probably due to reference
979 2007-05-30 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-tny-account.c:
982 (modest_tny_account_new_for_local_folders):
983 Use hildon_file_system_info_async_new() to get a better name for
984 the memory card account, setting it as the account name.
985 The timing seems to work, but this is probably
986 not the best place to do this. See the TODO comment.
987 * src/maemo/modest-main-window.c: (create_details_widget):
988 * src/widgets/modest-folder-view.c: (text_cell_data):
989 Use the tny account name instead of hardcoding a name.
991 2007-05-30 Christian Kellner <ckellner@openismus.com>
993 * src/modest-search.c: (modest_search):
994 Correctly set part_search_func even if we have already parsed
995 the query and thus a valid OgsTextSearcher object.
997 2007-05-30 Christian Kellner <ckellner@openismus.com>
1000 Search and check for libogs.
1003 Incooparte the ogs build env.
1005 * src/modest-mime-part-search-stream.c:
1006 * src/modest-mime-part-search-stream.h:
1007 Removed since we do the real searching now in modest-search.c.
1009 * src/modest-search.c:
1010 * src/modest-search.h:
1011 Implement support for ogs. We use that if available and requested
1012 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1013 should now handle the corner case when the search term is spread
1014 across multiple reads.
1015 Also the logic in modest_search () was corrected to search all
1016 requested fields until one is found.
1018 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1022 * src/modest-init.h:
1023 * src/modest-init.c: Made modest_init_local_folders() take a
1024 path and be public so we can iniitialize maildir folders on
1027 * src/modest-local-folder-info.h:
1028 * src/modest-local-folder-info.c:
1029 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1031 * src/modest-tny-account.c:
1032 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1033 still means the standard local-folders path on the local volume.
1035 * src/modest-tny-account-store.c:
1036 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1037 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1038 all accounts when that happens.
1039 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1040 this too, so it shows up in the treeview.
1042 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/modest-maemo-global-settings-dialog.c:
1045 (current_connection):
1046 * src/widgets/modest-global-settings-dialog.c:
1047 (current_connection_default):
1048 Use the enum values instead of 0, 1 and -1,
1049 to make the code clearer.
1051 * src/modest-account-mgr-helpers.c:
1052 (modest_account_mgr_get_connection_specific_smtp): Make this code
1055 * src/modest-runtime.h:
1056 * src/modest-runtime.c:
1057 Added modest_runtime_remove_all_send_queues().
1058 * src/maemo/modest-main-window.c:
1059 (on_account_store_connecting_finished): Recreate the send queues,
1060 using the appropriate transport accounts for this new connection.
1061 Some futher adapting might be needed if the old send queues are not
1062 automatically stopped at this point.
1064 * src/modest-tny-account-store.c: (get_server_accounts):
1065 Create the connection-specific transport accounts, so that they can
1066 be found later by their ID.
1068 * src/modest-tny-account.h:
1069 * src/modest-tny-account.c:
1070 Added modest_tny_account_new_from_server_account_name().
1071 modest_tny_account_new_from_server_account(): Do not create the
1072 send queues here, because they will be
1073 recreated anyway when the connection changes for the first time.
1075 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-local-folder-info.h:
1078 * src/modest-local-folder-info.c:
1079 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1080 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1081 tbox_folder): Take a modest account name instead of a server TnyAccount,
1082 so we can have per-modest-account rather than per-transport-account
1084 We must make sure that we change or recreate the exisitng send queues
1085 when the connection changes for connection-specific transport accounts.
1087 * src/modest-tny-account-store.c:
1088 (create_per_account_local_outbox_folders): Create outboxed per modest
1089 account, not per transport account.
1091 * src/modest-tny-account.h:
1092 * src/modest-tny-account.c:
1093 (modest_tny_account_get_special_folder): For outboxes, get the
1094 parent modest account name. The account is ignored for other folders.
1095 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1096 modest account name rather than a server TnyAccount.
1098 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account.c:
1101 (modest_tny_account_new_from_server_account):
1102 Call modest_runtime_get_send_queue() immediately after creating transport
1103 accounts, so that they start trying to send email from the outbox as soon
1104 as possible at startup. This is probably what we want.
1106 * src/modest-mail-operation.c: (update_account_thread):
1107 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1108 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1109 * src/modest-tny-send-queue.h:
1110 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1111 (modest_ui_actions_on_send):
1112 Added comments about how sending works, though it needs some more work.
1114 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-tny-account.c:
1117 (modest_tny_account_get_special_folder): Add TODO because this fails when
1118 the network is busy.
1119 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1120 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1121 Do not try to show this window when there is no active account. The UI
1122 specs does not tell us what to do in this case.
1124 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1128 * src/maemo/Makefile.am:
1129 * src/widgets/Makefile.am: Some dist fixes.
1131 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1133 * src/maemo/modest-connection-specific-smtp-window.c:
1134 (on_button_edit): Make the code clearer, to prevent a double free.
1136 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-account-settings-dialog.c:
1139 (modest_account_settings_dialog_set_account_name),
1140 Check the connection-specific smtp servers checkbox if there are any.
1142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1143 (modest_connection_specific_smtp_edit_window_init):
1144 Start with a suitable port number.
1146 * src/modest-account-mgr-helpers.h:
1147 * src/modest-account-mgr-helpers.c: Added
1148 modest_account_mgr_get_has_connection_specific_smtp().
1150 (modest_account_mgr_set_connection_specific_smtp),
1151 (modest_account_mgr_remove_connection_specific_smtp),
1152 (modest_account_mgr_get_has_connection_specific_smtp),
1153 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1154 connection-specific smtp server accounts in the account, rather than
1155 the server account conf dir.
1157 This fixes bug projects.maemo.org bug NB#58263 .
1159 * src/modest-tny-account-store.c:
1160 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1161 if there are no server accounts yet, to prevent an infinite loop when there
1162 are no accounts. Document that one must be called before the other.
1164 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-account-mgr-helpers.c:
1167 (modest_account_mgr_get_default_account): Make sure that at least
1168 one account is always the default, if there are any enabled accounts.
1169 This is just a sanity check that shouldn't be necessary.
1171 * src/modest-account-mgr-priv.c:
1172 (_modest_account_mgr_account_from_key): Unescape the conf key to
1173 get the real account name. For instance, this is an issue if a space
1174 was in the account name, which can happen because the account name
1175 is generated from the display name.
1176 (_modest_account_mgr_get_account_keyname): Always escape the
1178 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1179 Unescape the conf keys to get the real account names.
1181 For instance, previously the is-default radio button in the accounts
1182 list was not checked for any accounts at first. This fixes that,
1183 and might fix several similar bugs.
1185 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1188 Removed some debug printfs.
1190 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1192 Modest on-disk outbox directories are now here, for instance:
1193 $HOME/.modest/outboxes/<account-id-1>/outbox
1194 $HOME/.modest/outboxes/<account-id-2>/outbox
1196 $HOME/.modest/local-folders/outbox
1197 so we can have a separate outbox for each account.
1198 But they are shown as one outbox in the GtkTreeView, by using a
1199 TnyMergeFolder in a ModestTnySimpleFolderStore.
1202 * src/modest-tny-simple-folder-store.c:
1203 * src/modest-tny-simple-folder-store.h:
1204 Added ModestTnySimpleFolderStore, used to contain folders from
1205 other folder stores, such as other accounts.
1207 * src/modest-tny-outbox-account.h:
1208 * src/modest-tny-outbox-account.c:
1209 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1210 used for the per-account local outbox folders.
1212 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1213 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1214 only use this (internally) now for the non-outbox local folders.
1216 * src/modest-init.h:
1217 * src/modest-init.c: Added modest_init_one_local_folder(), for
1218 setting up the directory structure for each local folder.
1220 * src/modest-local-folder-info.c:
1221 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1222 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1224 * src/modest-local-folder-info.h:
1225 * src/modest-tny-account-store.c: (on_account_removed),
1226 (on_account_changed), (create_per_account_local_outbox_folders),
1227 (get_server_accounts), (modest_tny_account_store_get_accounts),
1228 (modest_tny_account_store_get_tny_account_by_account),
1229 (modest_tny_folder_store_is_virtual_local_folders):
1231 * src/modest-tny-account.h:
1232 * src/modest-tny-account.c:
1233 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1234 to create an on-disk per-account local outbox folder for each
1236 (create_per_account_local_outbox_folders): Create a local outbox folder
1237 for each transport account.
1238 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1239 for all local folders.
1241 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1242 instead of using g_object_get/set() directly. It is clearer.
1244 (modest_tny_folder_store_get_message_count),
1245 (modest_tny_folder_store_get_local_size
1246 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1247 because we now use these with non-acount folder stores.
1249 (modest_tny_account_get_special_folder),
1250 (modest_tny_account_new_from_server_account),
1251 (modest_tny_account_new_from_account):
1252 (recurse_folders): Adjust to the new outbox system.
1254 * src/modest-tny-folder.h:
1255 * src/modest-tny-folder.c:
1256 (modest_tny_folder_is_local_folder),
1257 (modest_tny_folder_get_local_folder_type),
1258 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1260 * src/widgets/modest-main-window.h:
1261 * src/maemo/modest-main-window.c: (create_details_widget),
1262 (modest_main_window_set_contents_style): Show details for any folder store,
1265 (modest_tny_folder_get_rules):
1266 Remove the const. C does not support constness enough for this.
1268 * src/modest-ui-actions.c:
1269 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1270 make all outboxes appear as one, in the usual local-folders tree node.
1272 (set_active_account_from_tny_account),
1273 (modest_ui_actions_on_folder_selection_changed):
1274 * src/widgets/modest-folder-view.c: (text_cell_data),
1275 (icon_cell_data), (filter_row),
1276 (add_account_folders_to_merged_folder),
1277 (add_account_folders_to_simple_folder_store), (),
1278 (get_cmp_rows_type_pos), (cmp_rows),
1279 (modest_folder_view_set_account_id_of_visible_server_account):
1280 Adjust to the new outbox system, using generic folder stores and folders
1281 in the GtkTreeModel.
1283 2007-05-23 Christian Kellner <ckellner@openismus.com>
1285 * src/modest-mail-operation.c:
1286 (modest_mail_operation_update_account):
1287 Use info->max_size instead of unintialized local var [small
1288 build fix]. (Added TODO to review that change since I don't
1291 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1293 * libmodest-dbus-client/libmodest-dbus-client.c:
1294 (libmodest_dbus_client_compose_mail): function added
1295 * src/dbus_api/modest-dbus-api.h:
1296 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1297 (on_compose_mail): Implementation of the SendAsMail functionality
1299 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1301 * src/modest-account-mgr.c:
1302 (modest_account_mgr_add_server_account): Set the secure-connection
1303 conf key for transport accounts as well as store accounts. I don't know
1304 why the if was there. For instance, this makes sure that we use SSL
1305 for the gmail preset from the easysetup wizard.
1307 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1309 * src/gnome/modest-main-window.c:
1310 (on_account_store_connecting_finished), (connect_signals):
1311 * src/maemo/modest-main-window.c:
1312 (on_account_store_connecting_finished), (connect_signals),
1313 (modest_main_window_new):
1314 Handle TnyAccountStore::connecting-finished instead of
1315 TnyDevice::connection-changed, because we cannot actually perform
1316 operations on accounts until TnyAccountStore has itself responded to
1317 the TnyDevice::connection-changed signal. This prevents a GError from
1319 Do not try to update at startup, because we (at least on scratchbox)
1320 already do an update at startup when the device goes online.
1321 This prevents a GError from tinymail.
1322 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1323 Added TODO about stopping simultaneous operations.
1325 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1328 * src/modest-mail-operation-queue.c:
1329 (modest_mail_operation_queue_remove):
1330 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1331 about where they happened.
1333 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-ui-actions.c:
1336 (modest_ui_actions_on_password_requested): Make sure that the remember
1337 output parameter is always TRUE.
1339 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1342 Show a OK/Cancel dialog if the error is a question, though we still do not
1343 know anything more about what we are asking the user.
1344 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1345 Fix an uninitialized variable (helper). This is a logic error, however.
1347 2007-05-21 Christian Kellner <ckellner@openismus.com>
1349 * src/modest-search.h:
1350 Correct bit shifting in the ModestSearchFlags enum.
1352 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account.c:
1355 (modest_tny_account_new_from_server_account): Do not use the lsub and
1356 check-all hard-coded IMAP options when using POP.
1358 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-tny-account.c:
1361 (modest_tny_account_new_from_server_account):
1362 Use NULL for the secure-auth method for POP when Password auth has been
1363 specified by the user, as we already do for IMAP. "auth=Login" causes
1364 an error from camel or the server.
1366 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1368 * src/maemo/modest-account-settings-dialog.c:
1369 (create_page_account_details),
1370 (modest_account_settings_dialog_set_account_name):
1371 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1372 for the leave-on-server checkbox, rathr than just the checkbox, when
1373 the protocol is not POP.
1375 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1377 * src/widgets/modest-account-view.c:
1378 * src/widgets/modest-account-view.h:
1379 Added modest_account_view_select_account() which will be useful later
1380 to asynchronously re-select the edited account.
1382 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1384 * src/maemo/modest-account-settings-dialog.c:
1385 (modest_account_settings_dialog_set_account_name):
1386 Automatically choose the port numbers based on the secure authentication
1387 methods, if they have not been chosen before.
1388 This fixes projects.maemo.org bug NB#56273 .
1390 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1392 * src/maemo/modest-main-window-ui.h:
1393 * src/modest-ui-actions.c:
1394 * src/modest-ui-actions.h:
1395 Connect the Tools/SMTP Servers menu item to
1396 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1397 SMTP servers dialog, as in the UI specification and saves changes when it
1398 is closed. This fixed projects.maemo.org bug NB#56305 .
1400 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1402 * src/maemo/modest-connection-specific-smtp-window.c:
1403 (modest_connection_specific_smtp_window_init):
1404 Use gtk_window_set_default_size() to make this window big enough, so
1405 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1407 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1410 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1411 (modest_connection_specific_smtp_edit_window_init),
1412 Do not try to connect to a combobox signal before the combobox exists.
1413 This fixes the cras in projects.maemo.org bug NB#56288 .
1414 (modest_connection_specific_smtp_edit_window_get_settings):
1415 Remove the server_account_name parameter which was being checked for NULL
1416 though it was not used.
1418 * src/maemo/modest-connection-specific-smtp-window.c:
1419 (modest_connection_specific_smtp_window_fill_with_connections),
1420 (on_button_edit), (modest_connection_specific_smtp_window_init):
1421 Correct the number of treemodel columns to prevent a warning.
1422 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1423 libconic does not work.
1425 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-tny-account.c:
1428 (modest_tny_account_new_from_server_account):
1429 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1430 SMTP when "None" was chosen by the user. However, with my SMTP server that
1431 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1434 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1437 to explain the memory management issue with the ID in the ModestPair.
1439 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1440 (add_sending_page), (modest_account_assistant_finalize):
1441 * src/gnome/modest-gnome-global-settings-dialog.c:
1442 (create_updating_page), (create_composing_page):
1443 * src/gnome/modest-msg-edit-window.c: (get_transports),
1444 (init_window), (modest_msg_edit_window_finalize),
1445 (modest_msg_edit_window_get_msg_data):
1446 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1447 * src/gnome/modest-transport-widget.c:
1448 (modest_transport_widget_finalize), (smtp_configuration):
1449 * src/maemo/modest-maemo-global-settings-dialog.c:
1450 (create_updating_page), (create_composing_page):
1451 * src/maemo/modest-msg-edit-window.c: (get_transports),
1452 (init_window), (modest_msg_edit_window_finalize),
1453 (modest_msg_edit_window_get_msg_data),
1454 (modest_msg_edit_window_free_msg_data):
1455 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1456 (modest_store_widget_finalize):
1457 * src/maemo/modest-transport-widget.c:
1458 (modest_transport_widget_finalize), (smtp_configuration):
1459 * src/modest-main.c: (send_mail):
1460 * src/widgets/modest-combo-box.h:
1461 * src/widgets/modest-global-settings-dialog-priv.h:
1462 * src/widgets/modest-global-settings-dialog.c:
1463 (modest_global_settings_dialog_finalize):
1464 * src/widgets/modest-msg-edit-window.h:
1465 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1466 as long as the combo box, to prevent use of freed memory for the ID.
1468 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1470 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1471 get_accounts(), to make this clearer. Do not check for the enabled gconf
1472 key, because we do not use this for server accounts (at least, not yet).
1473 This allows us to send email again.
1475 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/modest-platform.c:
1478 (on_modest_conf_update_interval_changed), (modest_platform_init):
1479 Only respond to this particular key change. All these strcmp()s cannot be
1482 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-maemo-global-settings-dialog.c:
1485 (current_connection): Prevent a crash in scratchbox when
1486 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1487 * src/maemo/modest-platform.c:
1488 (on_modest_conf_update_interval_changed), (modest_platform_init):
1489 Get the update interval from gconf and reset it when the gconf key changes.
1491 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-protocol-info.c:
1494 * src/modest-protocol-info.h: Adde enum-specific get functions,
1495 instead of using a ModestProtocolType enum parameter.
1497 * src/gnome/modest-account-assistant.c:
1498 * src/gnome/modest-store-widget.c:
1499 * src/gnome/modest-store-widget.h:
1500 * src/gnome/modest-transport-widget.c:
1501 * src/gnome/modest-transport-widget.h:
1502 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1503 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1504 * src/maemo/easysetup/modest-easysetup-wizard.c:
1505 * src/maemo/modest-account-settings-dialog.c:
1506 * src/maemo/modest-account-settings-dialog.h:
1507 * src/maemo/modest-store-widget.c:
1508 * src/maemo/modest-store-widget.h:
1509 * src/maemo/modest-transport-widget.c:
1510 * src/maemo/modest-transport-widget.h:
1511 * src/modest-account-mgr-helpers.c:
1512 * src/modest-account-mgr-helpers.h:
1513 * src/modest-account-mgr.c:
1514 * src/modest-account-mgr.h:
1515 * src/modest-tny-account.c:
1516 * src/modest-tny-folder.c:
1517 * src/widgets/modest-account-view.c:
1518 * src/widgets/modest-retrieve-combo-box.c:
1519 * src/widgets/modest-retrieve-combo-box.h:
1520 * src/widgets/modest-secureauth-combo-box.c:
1521 * src/widgets/modest-serversecurity-combo-box.c:
1522 * src/widgets/modest-serversecurity-combo-box.h:
1523 * tests/check_account-mgr.c:
1524 Use the specific functions, and use the re-renamed enum values for GNOME too.
1526 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1528 * src/modest-pair.h:
1529 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1530 so we can get the second based on the first.
1532 * src/maemo/modest-account-settings-dialog.h:
1533 * src/maemo/modest-account-settings-dialog.c:
1534 Added get_supported_secure_authentication_methods(), though it is mostly
1535 commented-out for now until the necessary API is committed to tinymail.
1536 (modest_account_settings_dialog_set_account_name),
1537 (save_configuration): Request the supported authentication methods from the
1538 server, so we can choose a working method.
1540 * src/modest-tny-account-store.h:
1541 * src/modest-tny-account-store.c:
1542 (modest_tny_account_store_get_session): Rename from
1543 tny_account_store_get_session().
1545 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1547 * src/modest-protocol-info.h: Split the ModestProtocol enum
1548 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1549 There was no need to have these unrelated values in one enum.
1551 * src/: many files: Adapted to changed enum. This makes the code a bit
1552 clearer, and the compiler could catch some errors.
1554 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1556 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1557 Show the detailed internal camel error message when an error happens
1558 during the configuration, so that our testers can give us more clues.
1559 For instance, in projects.maemo.org bug NB#56910 .
1561 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-tny-account.c:
1564 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1565 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1567 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1570 * src/maemo/modest-account-settings-dialog.c:
1571 (modest_account_settings_dialog_set_account_name),
1572 (save_configuration): For the incoming secure authentication checkbox,
1573 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1574 the UI specification. PLAIN does not seem to be supported for most IMAP
1575 servers anyway, and I am not sure what it would mean.
1576 However, we probably need to discover which of the secure-authentication
1577 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1578 * src/modest-account-mgr-helpers.c:
1579 (modest_account_mgr_get_server_account_data):
1581 * src/modest-tny-account.c:
1582 (modest_tny_account_new_from_server_account):
1583 Use tny_account_set_mech() to set secure-authentication methods,
1584 with some special-casing for IMAP, based on my observations of how
1587 * src/modest-account-mgr-helpers.h:
1588 * src/modest-account-mgr.c:
1589 * src/modest-defs.h: Comment that the URI is only used for local folders.
1591 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1594 parameter const, just to be neat.
1595 * src/modest-text-utils.c: (modest_text_utils_inline):
1596 End g_strconcat() with NULL, as its documentation says. This is almost
1597 certainly the cause of my crash at startup on the device. Interestingly,
1598 valgrind doesn't tell us about these errors.
1600 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1602 * scripts/build-packages: Added more precise comments about how to use
1603 this script, though I still get this error:
1604 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1605 error building tinymail
1607 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1609 * src/maemo/modest-main-window.c: (on_account_update):
1610 Very slight cleanup, hoping to make it simpler to discover what causes
1611 a crash here sometimes.
1613 * src/modest-tny-account.c:
1614 (modest_tny_account_new_from_server_account): Set the port. Added
1615 comments about the options and a TODO comment because I need to find out
1616 how to specify the secure authentication method.
1618 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1620 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1621 changed CFlags paths form modest to libmodest
1623 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-account-mgr-helpers.c:
1626 (modest_account_mgr_get_server_account_data),
1627 (modest_account_mgr_free_server_account_data):
1628 * src/modest-account-mgr-helpers.h:
1629 * src/modest-account-mgr.c:
1630 (modest_account_mgr_add_server_account):
1631 * src/modest-defs.h:
1632 * src/modest-tny-account.c:
1633 (modest_tny_account_new_from_server_account):
1634 Determine the options for tny_camel_account_add_option() here,
1635 based on the settings, rather than storing them directly in gconf.
1637 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1639 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1640 Show a more friendly error dialog now that we expect (from the tinymail
1641 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1643 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/modest-main-window.c: (on_account_update): Check that
1646 account_name is not NULL, to prevent a crash at startup that I am
1647 seeing on the N800. I do wonder why it is NULL.
1649 * src/maemo/easysetup/modest-easysetup-wizard.c:
1650 (create_page_user_details):
1651 * src/maemo/modest-account-settings-dialog.c:
1652 (create_page_user_details), (create_page_outgoing):
1653 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1654 (modest_connection_specific_smtp_edit_window_init):
1655 * src/modest-ui-actions.c:
1656 (modest_ui_actions_on_password_requested):
1657 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1658 might do something useful with the on-screen keyboard.
1660 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1662 * src/maemo/modest-main-window.c: (on_account_update):
1663 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1664 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1666 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1668 * src/modest-tny-account-store.c: (on_account_changed):
1669 Correct the signature of this signal handler.
1671 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1673 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1674 Show a HildonNote instead of a GtkDialog for Maemo.
1676 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1678 * src/widgets/modest-account-view.h:
1679 * src/widgets/modest-account-view.c: (on_account_changed),
1680 (on_account_removed). Added a boolean flag, set/unset by
1681 modest_account_view_block_conf_updates(),
1682 modest_account_view_unblock_conf_updates() to prevent unnecessary
1683 updates, but this is not very useful because the gconf notifications are
1684 so delays (maybe only on Maemo Bora).
1685 So auto-updating is turned off, and these functions do an explicit
1686 update when necessary.
1687 However, something else is still doing too much work when adding/removing
1688 accounts, probably in another part of the application.
1690 * src/maemo/modest-account-view-window.c:
1691 (on_delete_button_clicked), (on_edit_button_clicked),
1692 (on_new_button_clicked): Use the new functions.
1694 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-account-mgr-helpers.c:
1697 (modest_account_mgr_set_first_account_as_default):
1698 Sort the list of names alphabetically-by-title, so we choose the first one
1700 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1701 alphabetically by the title.
1703 This fixes projects.maemo.org bug NB#56418 .
1705 * src/modest-account-mgr-priv.c:
1706 (_modest_account_mgr_account_from_key):
1707 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1708 avoid a valgrind error, and possible random behaviour.
1710 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1713 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1714 tinymail documentation to say that this can be expected.
1715 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1716 pretty, and should not happen, but I would prefer to know when it does.
1718 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1720 * configure.ac: When using the older hildon version, probably on Bora,
1721 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1723 * src/widgets/modest-attachment-view.c:
1724 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1727 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1729 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1730 Implemented the prototype. Can be tested with
1731 tests/dbus_api/test_open_message:
1733 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-tny-account-store.c:
1736 (modest_tny_account_store_instance_init), (get_password):
1737 * src/modest-ui-actions.c:
1738 (modest_ui_actions_on_password_requested):
1739 Do not store the password in gconf, because this function is called
1740 for non-remembered passwords. Actually use the cached (in the hash map)
1741 password instead of releasing it.
1742 The password will now not be remembered if it is asked via the protected
1743 password dialog, as per the UI spec.
1745 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1747 * src/modest-defs.h:
1748 * src/modest-account-mgr-helpers.h:
1749 * src/modest-account-mgr-helpers.c:
1750 Added modest_server_account_get_username_has_succeeded(),
1751 modest_server_account_set_username_has_succeeded().
1752 (modest_server_account_set_username),
1753 Reset the has-succeeded flag if the username changes.
1755 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1756 * src/maemo/modest-connection-specific-smtp-window.c:
1757 (modest_connection_specific_smtp_window_save_server_accounts):
1758 Use modest_server_account_set_username() instead of using
1759 modest_conf_set_string() directly, so that the has-succeeded flag is always
1762 * src/modest-ui-actions.c:
1763 (modest_ui_actions_on_password_requested): Dim the username entry if
1764 the username has ever worked, as per the UI spec.
1766 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-tny-account-store.c: (get_password):
1769 * src/modest-ui-actions.c:
1770 (modest_ui_actions_on_password_requested):
1771 Allow the username to be changed too, though there is more work to
1772 be done on exactly how this behaves.
1774 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1776 * src/modest-account-mgr-helpers.h:
1777 * src/modest-account-mgr-helpers.c:
1778 Added modest_account_mgr_get_display_name(),
1779 modest_server_account_get_username(),
1780 modest_server_account_set_username(),
1781 modest_server_account_set_password(),
1782 modest_server_account_get_hostname() functions so we do not need to
1783 use the conf API directly.
1785 * src/maemo/modest-main-window.c: (connect_signals):
1786 Actually connect ot the ModestAccountStore::request-password signal,
1787 so that we show the dialog when the password is requested by Tinymail,
1788 for isntance if it is empty.
1790 * src/modest-marshal.list:
1791 * src/modest-tny-account-store.c:
1792 (modest_tny_account_store_class_init), (get_password),
1793 (modest_tny_account_store_alert):
1794 * src/modest-tny-account-store.h:
1795 * src/modest-ui-actions.h:
1796 * src/modest-ui-actions.c:
1797 (modest_ui_actions_on_password_requested):
1798 Change the signal parameters, so it is obvious that we are providing
1799 the non human-readable server name, and receiving both the username
1800 and password, though changing of the username is not yet implemented.
1801 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1802 for the GNOME version.
1804 This should fix the projects.maemo.org bug NB#56209, though it does not
1805 work on Bora, because the gconf_client_get() for the password fails
1806 immediately after we save it with gconf_client_set().
1808 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1811 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1812 caused an undefined symbol error:
1813 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1815 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-tny-account-store.c:
1818 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1819 using a GError instead of a string message, so we can translate it in
1822 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1824 * src/maemo/modest-address-book.c:
1825 (modest_address_book_check_names):
1826 * src/maemo/modest-msg-view-window.c:
1827 (modest_msg_view_window_clipboard_owner_change):
1828 * src/modest-init.c: (modest_init_init_ui):
1829 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1830 (update_folders_cb), (modest_mail_operation_update_account):
1831 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1832 (modest_ui_actions_on_msg_attachment_clicked),
1833 (modest_ui_actions_on_msg_recpt_activated):
1834 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1835 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1836 (modest_msg_view_search_next):
1837 * src/widgets/modest-recpt-editor.c:
1838 (modest_recpt_editor_on_button_release_event),
1839 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1840 g_message(). At this point we should only be seeing interesting errors on
1841 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1843 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1845 (modest_wizard_dialog_force_title_update):
1846 * src/maemo/easysetup/modest-wizard-dialog.h:
1847 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1848 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1849 can update the title when appropriate. Otherwise the title is wrong if the
1850 pages are added after adding the notebook to the dialog.
1851 This must be a problem in HildonWizardDialog too.
1852 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1854 * src/maemo/easysetup/modest-easysetup-wizard.c:
1855 (create_subsequent_customsetup_pages),
1856 (create_subsequent_easysetup_pages):
1857 Call modest_wizard_dialog_force_title_update() so that the title is
1858 correct even with GTK+ < 2.10.
1859 This fixes projects.maemo.org bug NB#56145 .
1861 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/modest-platform.c:
1864 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1865 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1868 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1870 * src/widgets/modest-window.h:
1871 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1872 and modest_window_save_state(), which invokes it.
1874 * src/widgets/modest-window-mgr.h:
1875 * src/widgets/modest-window-mgr.c:
1876 Added modest_window_mgr_save_state_for_all_windows(), which calls
1877 the save_state vfunc on all registered windows, if implemented.
1879 * src/gnome/modest-msg-edit-window.c:
1880 * src/gnome/modest-msg-view-window.c:
1881 * src/maemo/modest-msg-edit-window.c:
1882 * src/maemo/modest-msg-view-window.c:
1883 * src/maemo/modest-main-window.c:
1884 Specify the existing save_settings functions as implementations of
1885 ModestWindow::save_state_func().
1887 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1888 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1889 enabling hibernation, for instance.
1891 We may need to do the same thing for restoring settings.
1894 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1896 * src/widgets/modest-window-mgr.c:
1897 * src/widgets/modest-window-mgr.h:
1898 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1899 modest_window_mgr_get_hibernation_is_prevented().
1901 * src/maemo/modest-main-window.c:
1902 (on_hildon_program_is_topmost_notify): Prevent hibernation
1903 (possible when the application goes to the background in the WM),
1904 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1906 * src/maemo/easysetup/modest-easysetup-wizard.c:
1907 (modest_easysetup_wizard_dialog_init):
1908 * src/maemo/modest-account-settings-dialog.c:
1909 (modest_account_settings_dialog_init):
1910 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1911 (modest_connection_specific_smtp_edit_window_init):
1912 * src/maemo/modest-connection-specific-smtp-window.c:
1913 (modest_connection_specific_smtp_window_init):
1914 * src/maemo/modest-signature-editor-dialog.c:
1915 (modest_signature_editor_dialog_init):
1916 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1917 prevent hibernation while any of these account settings dialogs are open.
1919 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/Makefile.am:
1922 * src/maemo/modest-osso-state-saving.c:
1923 * src/maemo/modest-osso-state-saving.h: Added
1924 modest_osso_load_state() and modest_osso_save_state() though they do
1925 nothing now. They should iterate through all the open windows and load/save
1927 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1928 save state when closing.
1930 * src/maemo/modest-main-window.c:
1931 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1932 Add a notification handler for the HildonProgram::is-topmost property,
1933 so we can allow hibernation when the application goes into the background.
1934 But we still need to detect when the accounts setup windows are open so
1935 we can stop hibernation when they are open.
1936 To do this, I also added the main window the HildonProgram. This might have
1937 other side-effects/benefits, and should maybe be done for other windows.
1939 * src/maemo/modest-osso-autosave-callbacks.h:
1940 * src/maemo/modest-osso-autosave-callbacks.c:
1941 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1942 though it does not do anything yet, and we might never need this to do
1943 anything. For instance, we already save drafts.
1945 * src/maemo/modest-platform.c: (modest_platform_init):
1946 Specify the libosso auto-save callback.
1948 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/modest-platform.c:
1951 (modest_platform_set_update_interval):
1952 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1953 aparently stays valid between application instances, so we can use this
1954 to remove and reset it later. According to a maemo-developers email from
1957 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1959 * configure.ac: Depend on libalarm for Maemo.
1961 * src/dbus_api/modest-dbus-api.h:
1962 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1963 (on_send_receive), (modest_dbus_req_handler):
1964 Handle a SEND_RECEIVE D-Bus method.
1966 * libmodest-dbus-client/libmodest-dbus-client.c:
1967 (libmodest_dbus_client_send_and_receive):
1968 * libmodest-dbus-client/libmodest-dbus-client.h:
1969 Add C convenience functions for calling the new D-Bus method.
1971 * src/modest-platform.h:
1972 * src/gnome/modest-platform.c:
1973 * src/maemo/modest-platform.c:
1974 Added modest_platform_set_update_interval(), which uses the
1975 alarmd API on Maemo.
1976 (modest_platform_init),
1977 Call modest_platform_set_update_interval(), using a hard-coded
1978 interval for now (until the global settings dialog is implemented),
1979 though I am not sure that this makes sense yet.
1981 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1983 * src/dbus_api/modest-dbus-callbacks.c:
1984 (modest_osso_cb_hw_state_handler):
1985 * src/dbus_api/modest-dbus-callbacks.h:
1986 * src/maemo/modest-platform.c: (modest_platform_init):
1987 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1988 in case this has some effect on the ability for Maemo to ping the
1991 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1994 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1995 warning. It is probably a logic error, but I need to fix the build.
1997 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-account-mgr.h:
2000 * src/modest-account-mgr.c:
2001 (modest_account_mgr_account_names): Add a gboolean enabled_only
2002 parameter, so we can get lists of onlt the enabled accounts.
2004 (modest_account_mgr_add_account),,
2005 (modest_account_mgr_account_with_display_name_exists):
2006 * src/maemo/modest-msg-edit-window.c: (get_transports):
2007 * src/modest-account-mgr-helpers.c:
2008 (modest_account_mgr_set_first_account_as_default):
2009 * src/modest-init.c: (init_default_account_maybe):
2010 * src/modest-tny-account-store.c: (get_accounts):
2011 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2012 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2013 * tests/check_account-mgr.c: (START_TEST):
2014 Provide the extra parameter, as appropriate.
2016 * src/widgets/modest-account-view.c: (update_account_view):
2017 Do not show disabled accounts (meaning that there is no way to
2018 enable/disable accounts in the UI (the feature is not in our UI
2019 specification), so we can use this internally only to mark unfinished
2020 or temporary account data.
2022 * src/maemo/easysetup/modest-easysetup-wizard.c:
2023 (create_account): Add boolean enable parameter, so we can specify FALSE
2024 to create the temporary account.
2025 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2026 (on_before_next): When finishing, when there is a temporary account, just
2028 Also, use a timeout to delay the showing of the dialog until gconf is likely
2029 to return correct information, due to a maemo gconf bug that is fixed in
2030 osso 1.1, but not yet in Bora.
2031 However, the dialog stays on screen after it is destroyed.
2033 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2034 for invalid data when cancelling. Use a hildon note instead of a dialog
2035 to complain about invalid data. Do not show the account-saved note if the
2036 account is disabled (a temporary account that will not really be saved for use
2039 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-account-mgr-helpers.h:
2042 * src/modest-account-mgr-helpers.c:
2043 Added modest_account_mgr_unset_default_account(),
2044 Added modest_account_mgr_set_first_account_as_default().
2046 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2047 If it was the default account, unset the default account name.
2049 * src/maemo/modest-account-view-window.c:
2050 (on_delete_button_clicked): If it was the default account,
2051 set the first remaining account as the default instead.
2053 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2054 a NULL account or a NULL default account, to prevent a crash. This should
2055 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2058 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2060 * src/widgets/modest-recpt-editor.c:
2061 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2062 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2063 TODO comment for this. This fixes the build.
2065 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2066 be the best place for it. This will in future update all auto-update accounts,
2067 rather than just the current/default account, when that gconf key exists.
2068 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2069 if there are no accounts, before calling do_send_receive().
2070 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2072 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2073 * src/maemo/modest-main-window-ui.h:
2074 * src/maemo/modest-main-window.c: (on_connection_changed),
2075 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2076 directly, becaue the signal handler does more.
2078 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2080 * src/modest-account-mgr-helpers.c:
2081 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2082 for the case that the account does not exist.
2084 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2085 (equivalent to the modest account name) rather than the tinymail account name
2086 (equivalent to the modest account title - human readable) to get the account data.
2087 Check for null account data to prevent the crash, and add a TODO comment saying that
2088 this needs fixing because it is using the server account name instead of the account name.
2090 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2093 * src/maemo/modest-account-settings-dialog.c: (show_error),
2095 Use hildon_note_new_information() for informative and error messages,
2096 which seems to be expected for Maemo applications (no documentation that I know of
2097 says this). I am surprised that there is no distinction between info and error
2100 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2102 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2103 it is easy to find where this is used.
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (create_page_welcome), (create_page_account_details),
2107 (create_page_user_details), (create_page_complete_easysetup),
2108 (create_page_custom_incoming), (create_page_custom_outgoing),
2109 (create_page_complete_custom):
2110 * src/maemo/modest-account-settings-dialog.c:
2111 (create_page_account_details), (create_page_user_details),
2112 (create_page_incoming), (create_page_outgoing):
2113 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2115 (modest_connection_specific_smtp_edit_window_init):
2116 * src/maemo/modest-connection-specific-smtp-window.c:
2117 (modest_connection_specific_smtp_window_init):
2118 * src/maemo/modest-signature-editor-dialog.c:
2119 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2120 and scrolling policy as per the Email Application Layout Guide, if I have
2123 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2126 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2127 which were empty, because these vfuncs have been removed from TnyAccountStore.
2128 This fixes the build.
2130 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2132 * src/maemo/modest-main-window.c:
2133 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2134 showing/hiding it. Added TODO because it probably should not be NULL.
2135 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2136 because unnecessary g_warnings() make degugging difficult.
2138 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-msg-edit-window.c:
2141 (modest_msg_edit_window_select_color),
2142 (modest_msg_edit_window_select_background_color): 2 const corrections and
2143 moving 2 #endifs before closing brackets, to fix the build.
2145 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/easysetup/modest-easysetup-wizard.h:
2148 * src/maemo/easysetup/modest-easysetup-wizard.c:
2149 (modest_easysetup_wizard_dialog_finalize),
2150 (on_button_edit_advanced_settings), (create_page_complete_custom),
2151 (on_response), (create_account):
2152 Implement the Advanced Settings edit button, by saving the account information,
2153 for the Advanded Settings dialog to use directly from gconf, and removing it
2154 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2155 Bug #5533 in the projects.maemo.org bugzilla.
2157 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2159 * src/maemo/modest-msg-view-window.c:
2160 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2161 when opening a message window.
2163 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2165 * src/maemo/easysetup/modest-easysetup-wizard.c:
2166 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2169 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2170 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2171 gconf settings. I probably added more checks than necessary, but that is safer.
2173 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2174 variable to fix the build, but this seems to be used when it is still NULL.
2176 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-platform.h:
2179 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2180 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2181 * src/modest-main.c: Implement this function so we can avoid using
2182 maemo-specific API from cross-platform code.
2184 * src/modest-tny-account-store.c:
2185 (get_smtp_specific_transport_account_for_open_connection):
2186 * src/modest-ui-actions.c: (check_for_connection),
2187 (modest_ui_actions_on_item_not_found):
2188 Use modest_platform_connect_and_wait() and put #idefs around other
2189 maemo-specific code, because only maemo currently has a way to
2190 identify connection names.
2192 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2194 * src/modest-tny-account-store.h:
2195 * src/modest-tny-account-store.c:
2196 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2197 the connection-specific SMTP server settings in the configuration.
2199 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2201 * src/maemo/modest-main-window.c: (on_connection_changed),
2203 * src/modest-main.c: (main), (start_ui), (send_mail):
2204 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2205 that is what is intended.
2207 * src/modest-ui-actions.c: (action_send), (action_receive),
2208 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2209 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2210 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2211 SMTP server is used when it is specified.
2213 (modest_ui_actions_on_send_receive):
2214 Check that a connection is open before proceeding.
2215 Receive and then send, instead of vice-versa, as per the specification.
2217 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2219 * src/modest-mail-operation.c:
2220 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2221 though I guess it should be something other than NULL.
2223 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/easysetup/modest-easysetup-wizard.c:
2226 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2227 combo twice, to avoid an g_warning and to make it visible again.
2228 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2229 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2230 (already intended) dereference when detaching, because we then recreate the menu.
2231 But I am not sure why the warning was happening, and it is possible that this is a memory
2234 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2236 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2237 and uri_parse_mailto() utility functions.
2238 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2240 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2242 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2244 * src/dbus_api/modest-dbus-api.h:
2245 * src/dbus_api/modest-dbus-callbacks.c:
2246 Use an idle callback to execute the modest code in the application's own thread.
2247 Remove the helloworld example method.
2248 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2249 parsed, and the open-message method is not implemented because this is not yet implemented in
2251 * libmodest-dbus-client/libmodest-dbus-client.c:
2252 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2253 (libmodest_dbus_client_open_message):
2254 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2256 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2257 body without crashing.
2259 * tests/dbus_api/Makefile.am:
2260 * tests/dbus_api/test_mail_to.c:
2261 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2263 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2265 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2266 Added file to fix the build. Sorry.
2268 * src/dbus_api/Makefile.am:
2269 * src/dbus_api/modest-dbus-api.h:
2270 * src/dbus_api/modest-dbus-callbacks.h:
2271 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2272 (modest_dbus_req_handler):
2273 Put constants in a separate header so it can be reused by the
2274 client library, without duplication
2276 * libmodest-dbus-client/Makefile.am:
2277 * libmodest-dbus-client/libmodest-dbus-client.c:
2278 (libmodest_dbus_client_call_helloworld),
2279 (libmodfest_dbus_client_send_mail),
2280 (libmodfest_dbus_client_mailto),
2281 (libmodfest_dbus_client_open_message):
2282 * libmodest-dbus-client/libmodest-dbus-client.h:
2283 (Partly) Implement a send_mail D-Bus method.
2285 * tests/dbus_api/Makefile.am:
2286 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2287 the send_email D-Bus method.
2289 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2293 * libmodest-dbus-client/Makefile.am:
2294 * libmodest-dbus-client/libmodest-dbus-client.c:
2295 * libmodest-dbus-client/libmodest-dbus-client.h:
2296 * tests/dbus_api/Makefile.am:
2297 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2298 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2300 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2302 * src/maemo/easysetup/modest-easysetup-wizard.c:
2303 (create_page_account_details):
2304 * src/maemo/modest-account-settings-dialog.c:
2305 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2306 widgets, because this might not be the default in future versions of the Maemo GTK+.
2307 However, I can not not get capitalization to work even in a simple test case.
2309 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/easysetup/modest-easysetup-wizard.c:
2312 (create_page_custom_incoming), (create_page_custom_outgoing):
2313 * src/maemo/modest-account-settings-dialog.c:
2314 (create_page_account_details), (create_page_incoming),
2315 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2316 instead of using gtk_check_button_with_label(), so they are aligned like the other
2317 widgets, as per the UI spec.
2319 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-wizard.c:
2322 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2323 * src/widgets/modest-validating-entry.c:
2324 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2325 Modest prefix instead of an EasySetup prefix.
2327 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2329 * src/widgets/modest-validating-entry.h:
2330 * src/widgets/modest-validating-entry.c: (on_insert_text),
2331 Added easysetup_validating_entry_set_max_func(), used to set a callback
2332 to call when the max number of characters is reached. GtkEntry has a max-length
2333 already but is silent about it.
2335 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2336 (create_page_account_details), (create_page_user_details),
2338 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2339 (create_page_account_details), (create_page_user_details),
2340 (create_page_outgoing):
2341 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2342 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2343 the UI spec, when the user tries to enter more than the max number of characters.
2345 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/easysetup/modest-easysetup-wizard.c:
2348 (create_page_user_details), (create_page_custom_incoming),
2349 (create_page_custom_outgoing):
2350 * src/maemo/modest-account-settings-dialog.c:
2351 (create_page_user_details), (create_page_incoming),
2352 (create_page_outgoing):
2353 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2354 (modest_connection_specific_smtp_edit_window_init):
2355 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2356 not appropriate. Bad Maemo-specific defaults!.
2358 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2360 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2361 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2362 (modest_signature_editor_dialog_set_settings):
2363 Disable the label and textview when the checkbox is disabled, and use the
2364 specified (UI spec) default signature text.
2366 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2369 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2371 * src/modest-defs.h:
2372 * src/modest-account-mgr-helpers.h:
2373 * src/modest-account-mgr-helpers.c:
2374 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2376 * src/maemo/Makefile.am:
2377 * src/maemo/modest-signature-editor-dialog.c:
2378 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2381 * src/maemo/modest-account-settings-dialog.h:
2382 * src/maemo/modest-account-settings-dialog.c:
2383 (modest_account_settings_dialog_finalize), (on_button_signature),
2384 (save_configuration): Use the new dialog when the Edit button is pressed, and
2385 save the changes if necessary, as per the UI spec.
2387 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/Makefile.am:
2390 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2391 based on maemo-develoers email from Dirk.
2393 * src/maemo/easysetup/modest-easysetup-wizard.c:
2394 (create_page_welcome), (create_page_account_details),
2395 (create_page_user_details), (create_page_complete_easysetup),
2396 (create_page_custom_incoming), (create_page_custom_outgoing),
2397 (create_page_complete_custom),
2398 (modest_easysetup_wizard_dialog_init):
2399 * src/maemo/modest-account-settings-dialog.c:
2400 (create_page_account_details), (create_page_user_details),
2401 (create_page_incoming), (create_page_outgoing),
2402 (modest_account_settings_dialog_init):
2403 * src/maemo/modest-connection-specific-smtp-window.c:
2404 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2406 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/easysetup/modest-easysetup-wizard.c:
2409 (create_page_account_details), (create_page_custom_outgoing),
2410 (create_page_complete_custom):
2411 * src/maemo/modest-account-settings-dialog.c:
2412 (create_page_user_details), (create_page_incoming),
2413 (create_page_outgoing):
2414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2415 (modest_connection_specific_smtp_edit_window_init):
2416 Use the correct (UI spec) port min/max, and use horizontal separators,
2419 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2421 * src/maemo/easysetup/modest-easysetup-wizard.c:
2422 (set_default_custom_servernames):
2423 * src/maemo/modest-account-settings-dialog.c:
2424 (create_page_incoming), (on_combo_outgoing_security_changed),
2425 (on_combo_incoming_security_changed), (create_page_outgoing),
2426 (modest_account_settings_dialog_set_account_name),
2427 (save_configuration):
2428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2429 (on_combo_security_changed),
2430 (modest_connection_specific_smtp_edit_window_init),
2431 (modest_connection_specific_smtp_edit_window_set_connection),
2432 (modest_connection_specific_smtp_edit_window_get_settings):
2433 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2436 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/easysetup/modest-easysetup-wizard.c:
2440 (create_page_custom_outgoing), (create_page_complete_custom):
2441 * src/maemo/modest-account-settings-dialog.c:
2442 (create_page_user_details), (create_page_outgoing):
2443 * src/maemo/modest-account-view-window.c: (button_box_new):
2444 Use changed logical IDs as per the most recent UI spec:
2445 mcen_bd_emailsetup_edit -> mcen_bd_edit
2446 mcen_bd_emailsetup_delete -> mcen_bd_delete
2447 mcen_bd_emailsetup_close -> mcen_bd_close
2449 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2453 * src/dbus_api/Makefile.am:
2454 * src/dbus_api/modest-dbus-callbacks.c:
2455 * src/dbus_api/modest-dbus-callbacks.h:
2456 * src/maemo/modest-platform.c: (modest_platform_init):
2457 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2459 * tests/Makefile.am:
2460 * tests/dbus_api/Makefile.am:
2461 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2463 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-account-settings-dialog.c:
2466 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2467 Removed unnecessary includes.
2469 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/easysetup/modest-easysetup-wizard.c:
2472 * src/maemo/modest-account-settings-dialog.c:
2473 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2474 * src/widgets/Makefile.am:
2475 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2476 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2477 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2478 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2479 * src/widgets/modest-secureauth-combo-box.c:
2480 * src/widgets/modest-secureauth-combo-box.h:
2481 * src/widgets/modest-serversecurity-combo-box.c:
2482 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2483 made the GObject names more consistent with the rest of the Modest code.
2485 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2487 * src/maemo/easysetup/Makefile.am:
2488 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2489 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2490 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2491 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2492 * src/maemo/easysetup/modest-easysetup-wizard.c:
2493 * src/maemo/easysetup/modest-validating-entry.c:
2494 * src/maemo/easysetup/modest-validating-entry.h:
2495 * src/maemo/modest-account-settings-dialog.c:
2496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2497 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2498 widgets/ because they are used outside of easysetup too. After checking in,
2499 svn will allow me to rename them too.
2501 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2503 * src/gnome/modest-msg-edit-window.c:
2504 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2505 linker error, to fix the build on the GNOME platform.
2506 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2507 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2508 ifdefed out to avoid a warning.
2510 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2512 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2513 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2514 some alternative for GTK+ 2.6.
2516 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2520 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2521 specified for EmailAccountsDialog in UI spec.
2523 * src/maemo/easysetup/modest-easysetup-wizard.c:
2524 * src/maemo/easysetup/modest-easysetup-wizard.h:
2525 * src/maemo/modest-account-settings-dialog.c:
2526 * src/maemo/modest-account-settings-dialog.h:
2527 Reuse a member window widget for the connection-specific SMTP server accounts,
2528 so we can tell it to create/save the accounts only if we actually save changes.
2530 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2531 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2532 (modest_connection_specific_smtp_edit_window_get_settings):
2533 Return a struct instance for temporarily remembering the entered data.
2535 * src/maemo/modest-connection-specific-smtp-window.h:
2536 * src/maemo/modest-connection-specific-smtp-window.c:
2537 (modest_connection_specific_smtp_window_finalize),
2538 (modest_connection_specific_smtp_window_fill_with_connections),
2540 (modest_connection_specific_smtp_window_save_server_accounts),
2541 (update_model_server_names): Do not actually save data until asked,
2542 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2544 (on_selection_changed),
2545 (modest_connection_specific_smtp_window_init): Disable the edit
2546 button when nothing is selected.
2548 * src/modest-account-mgr-helpers.c:
2549 * src/modest-account-mgr-helpers.h:
2550 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2553 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2555 * src/modest-account-mgr-helpers.h:
2556 * src/modest-account-mgr-helpers.c:
2557 (modest_account_mgr_get_unused_account_name),
2558 (modest_account_mgr_get_unused_account_display_name): Added these
2559 utility functions, to avoid code duplication.
2561 * src/maemo/easysetup/modest-easysetup-wizard.c:
2562 (create_page_account_details), (create_account):
2563 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2564 (on_combo_security_changed),
2565 (modest_connection_specific_smtp_edit_window_init),
2566 (modest_connection_specific_smtp_edit_window_save_settings):
2567 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2568 * src/maemo/modest-connection-specific-smtp-window.c:
2569 (modest_connection_specific_smtp_window_finalize),
2570 (modest_connection_specific_smtp_window_fill_with_connections),
2571 (on_button_edit), (modest_connection_specific_smtp_window_init):
2572 * src/maemo/modest-connection-specific-smtp-window.h:
2573 Implementing saving of connection-specific server accounts.
2575 But I need to refactor this so we can save the data for each
2576 possible connection-specific account and only actually create the server accounts
2577 when the easysetup finished, or the OK button is pressed on the account settings
2580 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2582 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2583 (on_combo_security_changed):
2584 (modest_connection_specific_smtp_edit_window_init):
2585 Auto-fill the port number as in the account settings.
2587 (modest_connection_specific_smtp_edit_window_set_connection):
2588 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2589 * src/maemo/modest-connection-specific-smtp-window.c:
2590 (fill_with_connections), (on_button_edit),
2591 (modest_connection_specific_smtp_window_init):
2592 Turn the edit window into a dialog to simplify the code, and
2593 set a WM hint as in a GtkDialog, because only a popup can be on top of
2594 another window in Maemo, and popups usually have no WM decoration.
2596 * src/modest-defs.h:
2597 * src/modest-account-mgr-helpers.c:
2598 (modest_account_mgr_set_connection_specific_smtp),
2599 (modest_account_mgr_remove_connection_specific_smtp),
2600 (modest_account_mgr_get_connection_specific_smtp):
2601 * src/modest-account-mgr-helpers.h: Some functions to write the
2602 connection-specific SMTP server information. Not yet used.
2605 * src/widgets/modest-folder-view.c: (text_cell_data):
2606 Fix a warning about an uninitialized variable.
2607 (on_configuration_key_changed): Put an #ifdef around the use
2608 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2610 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/modest-account-settings-dialog.h:
2613 * src/maemo/modest-account-settings-dialog.c:
2614 Added connect_for_modified() utility function to mark the new modified boolean.
2616 (create_page_account_details), (create_page_user_details),
2617 (create_page_incoming), (create_page_outgoing), (on_response),
2618 (modest_account_settings_dialog_init),
2619 (modest_account_settings_dialog_set_account_name):
2620 Only warn about unsaved changes when there are actually unsaved changes.
2622 * src/modest-account-mgr-helpers.c:
2623 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2624 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2625 to get the data from there in future.
2627 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-defs.h:
2631 * src/modest-account-mgr-helpers.h:
2632 * src/modest-account-mgr-helpers.c:
2633 Store the security account setting in a single conf key instead of using
2634 the options list, so that the list is left for just the to-be-removed camel hack,
2635 and because gconf_client_set_list() is failing for some reason.
2637 * src/modest-account-mgr.c:
2638 (modest_account_mgr_add_server_account):
2639 * src/maemo/modest-account-settings-dialog.c:
2640 (modest_account_settings_dialog_set_account_name),
2641 (save_configuration): Use the renamed functions.
2644 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2646 * src/widgets/Makefile.am:
2647 * src/widgets/modest-limit-retrieve-combo-box.c:
2648 * src/widgets/modest-limit-retrieve-combo-box.h:
2649 * src/widgets/modest-retrieve-combo-box.c:
2650 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2651 the account settings dialog.
2653 * src/modest-defs.h:
2654 * src/modest-account-mgr-helpers.h:
2655 * src/modest-account-mgr-helpers.c:
2656 (modest_server_account_get_option_secure_auth),
2657 (modest_server_account_set_option_secure_auth):
2658 * src/modest-account-mgr.c:
2659 (modest_account_mgr_add_server_account):
2660 Use the existing AUTH_MECH conf key for the secure-auth setting,
2661 instead of putting it in the list options, because this was actually used already.
2663 * src/maemo/modest-account-settings-dialog.c:
2664 (create_page_account_details),
2665 (modest_account_settings_dialog_set_account_name),
2666 (save_configuration):
2667 * src/maemo/modest-account-settings-dialog.h:
2668 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2669 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2671 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2674 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2675 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2677 * src/modest-defs.h:
2678 * src/maemo/modest-account-settings-dialog.c:
2679 (create_page_incoming), (on_combo_outgoing_security_changed),
2680 (on_combo_incoming_security_changed), (create_page_outgoing),
2681 (modest_account_settings_dialog_set_account_name),
2682 (save_configuration): Load/Save the port number, and change it when the
2683 security combo changes, to suitable defaults.
2685 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-account-mgr.c:
2688 (modest_account_mgr_add_server_account): Set the security and secure-auth
2689 options, and add a comment saying that the other camel-specific options should be
2692 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2694 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2696 * src/modest-tny-account-store.c: (account_list_free),
2697 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2698 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2701 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-protocol-info.c:
2704 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2705 is required by our UI spec. Maybe something in our implementation will use this eventually.
2706 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2707 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2708 instead of the previous 0 placeholder.
2710 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2711 secure-auth settings.
2712 * src/modest-account-mgr-helpers.h:
2713 * src/modest-account-mgr-helpers.c:
2714 (modest_server_account_data_get_option_secure_auth),
2715 (modest_server_account_set_option_secure_auth),
2716 (modest_server_account_data_get_option_security),
2717 (modest_server_account_set_option_security): Added this API for getting and setting the security
2718 and secure-auth settings.
2720 * src/maemo/modest-account-settings-dialog.h:
2721 * src/maemo/modest-account-settings-dialog.c:
2722 (modest_account_settings_dialog_finalize), (check_data),
2723 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2724 about changing titles.
2725 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2726 (save_configuration): Save the security and secure-auth settings.
2728 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2729 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2731 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2733 * src/modest-defs.h:
2734 * src/modest-account-mgr.c:
2735 (modest_account_mgr_add_server_account):
2736 Added and used defines for the options key and value pair strings,
2737 that are used so far, though they do not seem to correspond to anything in our
2738 UI specs or ModestProtocol enum.
2740 * src/modest-account-mgr-helpers.h:
2741 * src/modest-account-mgr-helpers.c:
2742 (compare_option_strings_for_name),
2743 (modest_server_account_data_get_option_value),
2744 (modest_server_account_data_get_option_bool),
2745 (modest_account_mgr_get_server_account_option):
2746 Added helper functions for parsing the options GSList.
2748 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2750 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2751 display name is based on the supplied account name.
2752 * src/modest-account-mgr.c:
2753 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2754 with an inefficient, but good-enough, implementation.
2756 * src/maemo/easysetup/modest-easysetup-wizard.c:
2757 (create_page_account_details), (on_before_next), (create_account):
2758 Check for existing display names rather than (non-user-visible) account names, and just
2759 create and set a unique account name at the end.
2761 * src/maemo/modest-account-settings-dialog.c:
2762 (modest_account_settings_dialog_init),
2763 (modest_account_settings_dialog_set_account_name),
2764 (create_page_incoming): Show the display name, instead of the account name.
2765 (on_response): Do some (not all) extra checks, as in the UI spec.
2766 (save_configuration): Save the display name if it was changed.
2768 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2770 * po/en_GB.po: Added needed logical ID and translation.
2771 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2772 (init_view): Made the is-default column clicking work.
2774 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2777 * src/maemo/easysetup/Makefile.am:
2778 * src/maemo/easysetup/modest-easysetup-wizard.c:
2779 (modest_easysetup_wizard_dialog_init):
2780 * src/maemo/easysetup/provider-data-test.keyfile:
2781 * src/maemo/easysetup/provider-data.keyfile:
2782 Moved the provider data file to the new modest-providers-data package and used it from there.
2784 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2786 * src/modest-local-folder-info.c:
2787 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2788 N_() was already used on the static strings, but this just marks it for translation without
2789 using the translation.
2791 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2793 * src/maemo/modest-account-settings-dialog.c:
2794 (create_page_incoming),
2795 (modest_account_settings_dialog_set_account_name):
2796 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2797 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2798 I will do this if nobody else gets there first.
2800 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2803 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2804 save the security stuff.
2806 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2808 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2809 Set the email address and user fullname, which I now see must be
2812 * src/maemo/modest-account-settings-dialog.h:
2813 * src/maemo/modest-account-settings-dialog.c:
2815 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2816 leave-on-server and authentication.
2817 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2820 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2823 * src/maemo/modest-account-settings-dialog.c:
2824 * src/maemo/modest-account-settings-dialog.h:
2825 Most (but not all) of the widgets are now present as specified by the UI spec.
2826 No changes are yet saved, and some details are not properly shown yet.
2828 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2830 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/Makefile.am:
2833 * src/maemo/modest-account-settings-dialog.c:
2834 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2835 an existing account. Doesn't do much yet.
2837 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2838 Open the accounts settings dialog when Edit is clicked.
2840 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/easysetup/Makefile.am:
2843 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2845 * src/maemo/easysetup/modest-easysetup-wizard.c:
2846 (modest_easysetup_wizard_dialog_init):
2847 Try to get the source directory from the build system,
2848 instead of hard-coding "./" into the source code, when opening our local
2849 copies of the configuration files.
2850 But this still fails when opening the wizard from the Accounts window,
2851 maybe because the working directory seems to change at runtime.
2852 So the wizard will fail the second time unless you copy the files into their
2853 proper locations - see the stdout warnings for the paths.
2855 (create_page_account_details),(on_before_next):
2856 Check for existing non-server accounts instead of server accounts,
2857 so the default account name is useful again, and to prevent trying to
2860 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2861 Show the wizard when New is clicked.
2863 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2864 (init_view): Show the column headers, and show the columns that are
2865 specified in the UI specs. However, something in Maemo's GTK+ prevents
2866 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2867 change the default account. This is despite unsetting the special properties.
2869 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2871 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2872 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2873 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2874 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2875 to make that clearer.
2876 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2878 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/modest-account-view-window.c:
2881 (modest_account_view_window_init),
2882 (modest_account_view_window_new):
2883 Use the same buttons as specified in the
2884 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2885 the existing widgets, which never had a chance of working.
2886 Put the ModestAccountView treeview in a scrolled window.
2887 Do not repeat the initialization in both _init() and _new().
2889 * src/widgets/modest-account-view.c: (update_account_view):
2890 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2891 this widget and window shows no accounts.
2893 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2895 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2897 * src/maemo/easysetup/modest-easysetup-wizard.c:
2898 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2899 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2900 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2903 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2904 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2905 accounts exist yet, as in the UI spec.
2907 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2909 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/Makefile.am:
2912 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2913 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2914 New window for editing connection-specific smtp details.
2915 Not fully implemented.
2917 * src/maemo/modest-connection-specific-smtp-window.c:
2918 (modest_connection_specific_smtp_window_finalize) :
2919 unref the tree model.
2920 (on_button_edit): Show the edit window.
2922 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2924 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2927 * src/maemo/Makefile.am:
2928 * src/maemo/modest-connection-specific-smtp-window.c:
2929 * src/maemo/modest-connection-specific-smtp-window.h:
2930 New window for showing the list of connections, for connection-specific
2931 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2932 * src/maemo/easysetup/modest-easysetup-wizard.c:
2933 (create_page_custom_outgoing): Show the new window when the button is clicked.
2935 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2937 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2938 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2939 * src/maemo/modest-msg-edit-window.c:
2940 (modest_msg_edit_window_insert_image):
2941 * src/modest-conf.c: (modest_conf_key_escape):
2942 * src/modest-mail-operation.c:
2943 (modest_mail_operation_send_new_mail):
2944 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2945 (modest_ui_actions_on_new_account):
2946 * src/widgets/modest-attachment-view.c: (update_filename_request):
2947 * src/widgets/modest-mail-header-view.c:
2948 Corrected warnings that were breaking the build, by commenting out unused variables,
2949 and a function, and by including a header.
2951 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2953 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2954 so we can #ifdef around platform-specific code when necessary.
2955 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2956 to allow this to build for the GNOME platform too.
2958 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2960 * src/maemo/easysetup/modest-easysetup-wizard.c:
2961 Added util_increment_name() and used it in create_page_account_details()
2962 to make sure that the default account name is always a new name.
2964 (modest_easysetup_wizard_dialog_init),
2965 (set_default_custom_servernames): Some minor memory management fixes.
2967 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-runtime.c: (init_i18n): Restored the translation
2972 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2973 are defined in config.h, and the translations are installed.
2975 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2976 is defined for translation.
2978 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2982 * src/maemo/easysetup/modest-easysetup-wizard.c:
2983 (modest_easysetup_wizard_dialog_init):
2984 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2985 Use realistic paths (though they should use $prefix generically) to the
2986 mcc_mapping and provider-data.keyfile files which might work when they
2987 are installed by the future version of the operator-wizard package,
2988 and then fallback to paths in our source code, with an explanatory
2991 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2995 * src/maemo/Makefile.am:
2996 * src/maemo/easysetup/: Added files from the previously-exernal
2997 osso-modest-easysetup.
2998 * src/maemo/modest-main-window-ui.h:
2999 * src/modest-ui-actions.c:
3000 * src/modest-ui-actions.h:
3001 Added modest_ui_actions_on_new_account() as a signal handler for the
3002 New Account menu item. It shows the easysetup wizard.
3003 * po/en_GB.po: Added additional needed logical IDs and translations.
3005 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3006 Apparently ChangeLog is not used for some vague Nokia legal reasons.