1 2007-07-12 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-main-window.c: Make default account appear bold
4 in view, tools/send & receive and toolbar/send & receive SCM menus.
5 This fixes projects.maemo.org bug NB#59010.
7 2007-07-12 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
10 Add a short-cut, by checking if the folder store is an account.
11 This ensures that the Sort menu item and toolbar is dimmed for
12 the local-folders account root item, fixing
13 projects.maemo.org bug NB#62545.
15 2007-07-12 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-tny-account-store.c: (get_password):
18 Show the password dialog (via the signal) only in the mainloop, via
19 an idle handler that we wait for. This could theoretically prevent
20 hangs, though I worry that it could introduce some too.
22 2007-07-12 Murray Cumming <murrayc@murrayc.com>
24 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
25 * src/maemo/modest-platform.c:
26 (modest_platform_connect_and_wait):
27 Take a TnyAccount* parameter and try to set it to online
28 (a TnyCamel-only API), because tinymail sets accounts to offline
29 when the user cancels a password dialog, and doesn't ask again until
30 it has been set to online.
31 However, this is commented out because it causes a hang now.
33 (modest_platform_connect_and_wait_if_network_account):
34 * src/modest-mail-operation.c:
35 (modest_mail_operation_update_account):
36 * src/modest-platform.h:
37 * src/modest-ui-actions.c: (_modest_ui_actions_open),
38 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
40 2007-07-12 Armin Burgmeier <armin@openismus.com>
42 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
44 * src/modest-mail-operation.c:
45 * src/modest-ui-actions.c: Check for already existing folder before
46 querying the server, show error message from camel if the request
47 still fails. This fixes projects.maemo.org bug NB#58701.
49 2007-07-12 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-tny-account-store.h:
52 * src/modest-tny-account-store.c:
53 Added modest_tny_account_store_forget_password_in_memory(),
54 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
55 when creating a new account, so that new passwords will be used, instead of
56 us thinking that it's a second request as a result of a failed password again.
58 2007-07-12 Murray Cumming <murrayc@murrayc.com>
60 * src/dbus_api/modest-dbus-callbacks.c:
61 (on_idle_open_message): If the message is in drafts then open it
62 in an edit window instead of a view window. This fixes
63 projects.maemo.org bug NB#63005.
65 2007-07-12 Murray Cumming <murrayc@murrayc.com>
67 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
68 Avoided a harmless g_warning().
70 2007-07-12 Murray Cumming <murrayc@murrayc.com>
72 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
73 Pass the modest account name, not the TnyAccount display name to
74 modest_msg_view_window_new() so that the reply feature works,
75 fixing projects.maemo.org bug NB#62892.
77 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
78 (modest_msg_view_window_new_with_header_model):
79 * src/maemo/modest-msg-view-window.c:
80 (modest_msg_view_window_new_with_header_model),
81 (modest_msg_view_window_new):
82 * src/modest-ui-actions.c: (reply_forward):
83 * src/widgets/modest-msg-view-window.h:
84 * src/widgets/modest-window.c: (modest_window_set_active_account):
85 Rename an account parameter to modest_account_name to make this clearer.
87 2007-07-11 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-ui-actions.h:
90 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
91 modest_do_message_delete().
92 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
93 Call modest_do_message_delete(), hoping that this would cause messages
94 to be really deleted from search instead of just marked with strike through.
95 Does not seem to help.
97 2007-07-11 Armin Burgmeier <armin@openismus.com>
99 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
100 priv->reselect to FALSE prior to calling
101 modest_folder_view_select_first_inbox_or_local() to prevent endless
102 recursion and thus a crash on startup.
104 2007-07-11 Armin Burgmeier <armin@openismus.com>
106 * src/maemo/modest-account-settings-dialog.h: Include
107 <gtk/gtknotebook.h> to fix the build (at least for me).
109 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
110 Use "New FolderN" as default suggested name if "New folder" already
111 exists, with N being the first free number, though never exceed "New
112 folder99" in which case we just fall back to "New Folder" even though
113 it already exists. This fixes projects.maemo.org bug NB#58663.
115 2007-07-11 Murray Cumming <murrayc@murrayc.com>
117 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
118 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
119 projects.maemo.org bug NB#62778.
121 2007-07-11 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
124 Ignore the wrong (for now) secure-smtp setting in the presets -
125 just default to requiring secure authentication for SMTP, because
128 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
130 * src/widgets/modest-folder-view.c: (filter_row)
131 Do not show drafts folder (see UI specs)
133 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
135 * src/modest-ui-actions.c:
136 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
137 place and also not necessary.
139 * src/widgets/modest-folder-view.c: (filter_row)
140 Guess folder type and hide Sent & Outbox if necessary.
141 Fixed project.maemo.org NB#57328
143 2007-07-11 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-ui-actions.h:
146 * src/modest-ui-actions.c:
147 (modest_ui_actions_on_delete_message):
148 Move some code into a new
149 modest_ui_actions_refresh_message_window_after_delete()
150 function so we can use it from elsewhere.
152 * src/dbus_api/modest-dbus-callbacks.c:
153 (on_idle_delete_message), (on_delete_message): Used an idle
154 handler, as we do for the other D-Bus method handlers.
155 Call modest_ui_actions_refresh_message_window_after_delete()
156 if the deleted message was open in a window. This fixed
157 projects.maemo.org bug NB#62862.
159 2007-07-11 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-main.c: (main): Only show the UI at the start if
162 the showui command line option was given. For instance,
163 run-standalone src/modest showui
164 Otherwise, we wait for the top_application D-Bus method to
165 be sent by hildon-desktop when the application is selected
167 This allows us to run without a UI when osso-global-search
168 uses our D-Bus methods.
170 2007-07-11 Murray Cumming <murrayc@murrayc.com>
172 * src/dbus_api/modest-dbus-api.h: Added a define for a
173 top-application D-Bus method.
174 * src/dbus_api/modest-dbus-callbacks.c:
175 (on_top_application),
176 (modest_dbus_req_handler): Handle the top-application D-Bus
177 method, which might be an undocumented D-Bus signal sent by
178 hildon-desktop when it starts the application from the menu.
179 But I am not sure and I need to test it on the device, because
180 my scratchbox does not have the application in the menu now.
181 This method shows the main window, so that it can be invisible
182 when started, for instance, just for email searching from
185 * src/maemo/modest-main-window.c: (restore_settings),
186 (modest_main_window_new): Do not show the window immediately
187 upon creation. We show it later.
188 * src/modest-widget-memory.c: (save_settings_paned):
189 Try (unsuccessfully) to avoid saving the paned position when
190 it is not even visible.
191 (restore_settings_paned): Do not allow a silly paned position.
192 This seems necessary when not showing the window at first.
194 * tests/dbus_api/Makefile.am:
195 * tests/dbus_api/test_top_application.c: (main): Test for the
198 2007-07-10 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-ui-dimming-rules.c:
201 (modest_ui_dimming_rules_on_new_msg),
202 (modest_ui_dimming_rules_on_reply_msg),
203 (modest_ui_dimming_rules_on_delete_msg),
204 (modest_ui_dimming_rules_on_details),
205 (modest_ui_dimming_rules_on_view_window_move_to),
206 (modest_ui_dimming_rules_on_view_previous),
207 (modest_ui_dimming_rules_on_view_next),
208 (_invalid_folder_for_purge): Added checks before
209 casting the window. This looks like an actual
210 logic error in _invalid_folder_for_purge(), because it
211 tries to use a ModestMainWindow as a message window.
213 2007-07-10 Murray Cumming <murrayc@murrayc.com>
215 * src/maemo/modest-account-settings-dialog.c:
216 (show_error): Use the same implementation as in
217 modest-easysetup-wizard.c:
218 (on_entry_invalid_character): The logical ID contains a %s.
219 Guessed what it should be.
220 (on_entry_max), (check_data), (on_response): Adapt to
221 changed show_error().
222 (create_page_account_details): Really call
223 modest_validating_entry_set_func() on the correct widgets.
224 * src/maemo/easysetup/modest-easysetup-wizard.c:
225 (on_entry_invalid_character): Fix the logical ID here too.
226 (create_page_account_details),
227 (create_page_user_details):
229 modest_validating_entry_set_func() on the correct widgets.
231 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
232 Do not try to use the account if it is NULL.
234 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
236 * src/modest-ui-actions.c: (create_move_to_dialog),
237 (modest_ui_actions_on_main_window_move_to),
238 (modest_ui_actions_on_msg_view_window_move_to):
239 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
240 (filter_row), (modest_folder_view_show_non_move_folders):
241 * src/widgets/modest-folder-view.h:
243 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
244 the Sent folder yet as it does not report the correct folder type.
246 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
248 * src/maemo/modest-msg-edit-window.c: (init_window):
251 2007-07-10 Murray Cumming <murrayc@murrayc.com>
253 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
254 Take a parent widget instead of a parent window, and
255 implement this with hildon_banner_show_information() instead.
256 Non-Maemo builds can just ifdef that there.
257 This fixed projects.maemo.org bug NB#62766.
259 (on_entry_invalid_character): Use show_error() again instead
260 of using hildon directly, and use the _CS() macro to use the correct
262 (create_account), (check_for_supported_auth_methods), (on_entry_max):
263 Pass a widget instead od a window to show_error().
265 2007-07-10 Murray Cumming <murrayc@murrayc.com>
267 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
268 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
269 This allows us to show the server name in the error message, fixing
270 projects.maemo.org bug NB#62904.
271 Also, use the appropriate logical ID message for the account protocol.
273 2007-07-10 Murray Cumming <murrayc@murrayc.com>
275 * src/modest-tny-account-store.c: (on_idle_wrong_password):
276 A compilation fix, though the build wasn't broken for me.
278 2007-07-09 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
281 Do not try to unref a NULL folder store, to avoid a runtime warning.
282 This seems to happen sometimes when changing accounts settings.
284 2007-07-09 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-tny-account-store.c:
287 (modest_tny_account_store_instance_init),
288 (modest_tny_account_store_finalize),
289 (on_account_settings_hide), (on_idle_wrong_password):
290 Use a GHashTable to ensure that we only show one account settings
291 dialog per modest account. This avoids us having a dialog open for
292 both the store and transport accounts, or due to repeated get_password()
293 calls that shouldn't happen anyway.
295 2007-07-09 Murray Cumming <murrayc@murrayc.com>
297 * src/maemo/modest-maemo-utils.c: (on_hide),
298 (modest_maemo_show_dialog_and_forget): Handle the response, because
299 the window is not even hidden by default.
301 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
302 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
303 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
304 which seems to prevent some modality problems.
306 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
307 Ignore user cancellation errors.
309 * src/modest-account-mgr-helpers.h:
310 * src/modest-account-mgr-helpers.c:
311 Added modest_server_account_get_password() and
312 modest_server_account_get_has_password() to avoid direct use of
315 * src/maemo/modest-account-settings-dialog.h:
316 * src/maemo/modest-account-settings-dialog.c:
317 (modest_account_settings_dialog_init): Store the notebook so we can
319 Added modest_account_settings_dialog_switch_to_user_info().
321 * src/modest-tny-account-store.c:
322 (get_password): When the password in the account settings is wrong (we think),
323 show the relevant page of the account settings dialog, in the mainloop.
324 However, we currently get many of these at once because cancel does not
326 (forget_password): Do not forget the password
327 from the account settings, because this causes side-effects when
328 tinymail seems to call it at strange time, maybe because of how we
329 are cancelling get_password().
330 (modest_tny_account_store_alert): Ignore user cancellations.
332 2007-07-09 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/modest-maemo-utils.h:
335 * src/maemo/modest-maemo-utils.c:
336 Added modest_maemo_show_information_note_and_forget() for use instead of
337 gtk_dialog_run() when the response is not needed, to avoid an extra
338 mainloop which could cause a hang.
340 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
341 Use the logical IDs for the error message, though they are not
342 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
343 because gtk_dialog_run() caused a hang here (the window did not close).
344 This fixes projects.maemo.org bug NB#62646.
346 2007-07-09 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-account-mgr-helpers.h:
349 * src/modest-account-mgr-helpers.c:
350 Added modest_account_mgr_get_store_protocol().
352 * src/maemo/modest-account-view-window.c:
353 (on_delete_button_clicked): Show different warning text depending on
354 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
355 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
358 2007-07-09 Murray Cumming <murrayc@murrayc.com>
360 * src/maemo/modest-msg-edit-window.c:
361 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
362 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
364 2007-07-07 Armin Burgmeier <armin@openismus.com>
366 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
367 ckdg_ib_maximum_characters_reached from correct package.
369 * src/modest-ui-actions.c: Show an error message when a folder could
370 not be created. Tinymail does not give us specific error codes about
371 what has gone wrong, so we assume that a folder with that name
372 already exists, though there might be other reasons.
374 2007-07-06 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
377 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
378 give a more exact error message that can be partly translated.
380 2007-07-05 Murray Cumming <murrayc@murrayc.com>
382 * src/maemo/modest-address-book.c:
383 (select_email_addrs_for_contact): Specify a default window size for the
384 select-email-address dialog, so that it is probably big enough for the
385 title. This should fix projects.maemo.org bug NB#62277.
387 2007-07-05 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/easysetup/modest-easysetup-wizard.c:
390 (create_page_complete_easysetup): Use
391 gtk_widget_set_size() request to ensure that the text wraps
394 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
396 * src/maemo/easysetup/modest-easysetup-wizard.c:
397 (on_entry_invalid_character), (create_page_account_details),
398 (create_page_user_details):
399 Use new API of ModestValidatingEntry. But for some reason the banner is
400 not shown. I will have to investigate that further.
402 * src/widgets/modest-validating-entry.c: (on_insert_text),
403 (modest_validating_entry_set_func):
404 * src/widgets/modest-validating-entry.h:
405 Added a new callback function to be able to react to prevented
406 characters whitespaces to e.g show a banner.
408 2007-07-05 Armin Burgmeier <armin@openismus.com>
410 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
411 notification of HildonNumberEditor instead of remembering the port
412 number. Thanks to Johannes for pointing this out.
414 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
416 * src/maemo/easysetup/modest-easysetup-wizard.c:
417 Check if there are any user changes before showing a confirmation
418 dialog (projects.maemo.org NB#60946)
420 2007-07-05 Armin Burgmeier <armin@openismus.com>
422 * src/maemo/modest-account-settings-dialog.c: Remember custom port
423 number at the beginning of the dialog and set the modified flag at the
424 end if the port number has changed. This is necessary because
425 HildonNumberEditor does not support notification when the value has
428 2007-07-05 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-ui-actions.c:
431 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
432 a connection before asking anything else. Correct the check for the destination
433 folder so that it succeeds when online.
434 This fixed projects.maemo.org bug NB#61645.
436 2007-07-05 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
439 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
440 to fix projects.maemo.org bug NB#62439.
442 2007-07-05 Murray Cumming <murrayc@murrayc.com>
444 * src/modest-tny-account.c: (on_connection_status_changed):
445 Really do not use tny_device_force_offline() here. See the previous comment.
447 2007-07-04 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-tny-account.c: (on_connection_status_changed):
450 Do not use tny_device_force_offline() when tinymail says that something
451 went wrong with the connection. It seems to report this unnecessarily.
453 2007-07-04 Murray Cumming <murrayc@murrayc.com>
455 * src/maemo/modest-connection-specific-smtp-window.c:
456 (modest_connection_specific_smtp_window_init):
457 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
458 does not seem to have any effect in osso 1.1 (though it works in
459 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
461 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
463 * src/maemo/modest-connection-specific-smtp-window.c:
464 Fix UI specification problems with projects.meamo.org NB#60479
466 2007-07-04 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
469 clue when this has failed, because the error dialog is not always shown
470 (at least in earlier version).
472 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
473 GError message, because the generic error dialog is not helpful.
475 'This message is not currently available (can't let a new connection go online)'
476 when trying to open an IMAP message.
478 (_modest_ui_actions_open): Offer a connection when some messages would
479 have to be downloaded and we are offline.
481 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
483 * src/widgets/modest-folder-view.c:
484 Don't check for MERGE type anymore as we use the correct type
486 NOTE: For the last two changes you need to update your tinymail copy
487 because of API changes!
489 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
491 * src/modest-tny-local-folders-account.c:
492 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
493 (see projects.maemo.org NB#61580)
495 2007-07-04 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-tny-account.c: (on_connection_status_changed):
498 Commented out the call to modest_platform_connect_and_wait() because this
499 seems to always hang, and I would like to know if this is the only thing
500 that causes a hang when showing the connection dialog.
501 It is not very useful anyway.
503 2007-07-04 Murray Cumming <murrayc@murrayc.com>
505 * src/maemo/modest-msg-view-window.c:
506 (modest_msg_view_window_select_next_message):
508 * src/modest-platform.h:
509 * src/maemo/modest-platform.c:
510 Added modest_platform_connect_and_wait(), which calls
511 tny_maemo_conic_device_connect() always in the main thread, by calling it
512 in an idle handler and waiting for the idle handler to run. It should be
513 in the main thread because it uses GTK+ UI code. It just returns TRUE
514 if the device is already online.
516 There is some nasty code to ensure that subsequent calls to
517 modest_platform_connect_and_wait() just wait for the first one to finish,
518 by checking repeatedly in another idle handler. This is necessary,
519 because other threads (or even the main thread, via another idle handler)
520 can call modest_platform_connect_and_wait() while
521 modest_platform_connect_and_wait() is running.
523 (modest_platform_connect_and_wait_if_network_account),
524 (modest_platform_connect_and_wait_if_network_folderstore):
525 Convenience functions that calls modest_platform_connect_and_wait() if
526 the account or folder might want network access.
528 * src/modest-mail-operation.c:
529 (modest_mail_operation_update_account):
530 * src/modest-ui-actions.c: (download_uncached_messages),
531 (modest_ui_actions_on_rename_folder), (delete_folder),
532 (modest_ui_actions_on_main_window_move_to),
533 (modest_ui_actions_on_msg_view_window_move_to):
534 * src/widgets/modest-folder-view.c:
535 (drag_and_drop_from_folder_view):
536 Offer a connection if we are offline.
538 * src/modest-tny-account.c: (on_connection_status_changed):
539 Document this as only handling errors during network operations in progress,
540 and replace the idle code with a simple call to
541 modest_platform_connect_and_wait(), which does this instead.
543 2007-07-03 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-tny-account.c:
546 (modest_tny_account_get_special_folder): (util_on_idle),
547 Handle the GError so we can see when tny_folder_store_get_folders()
548 fails, as it currently does while something else is connecting.
550 Added util_run_in_main_thread_and_wait()
551 which uses an idlen handler and mainloop to ensure that the function
552 is called in the main thread.
553 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
554 to make sure that we call attempt the connection in the mainloop only,
555 which might solve some hangs.
557 2007-07-03 Murray Cumming <murrayc@murrayc.com>
559 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
560 be found by their display name. This is never useful.
561 * src/modest-tny-account-store.c: (on_account_removed): Find the account
562 by its ID, instead of trying to use its ID as its display name.
564 * src/modest-tny-account-store.h:
565 * src/modest-tny-account.c:
566 (modest_tny_account_get_special_folder): Add a g_warning() when
567 tny_folder_store_get_folders() returns an empty list for the maildir.
569 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
570 Add a g_warning() when this returns NULL, because that it not allowed
573 2007-07-02 Armin Burgmeier <armin@openismus.com>
575 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
576 note when trying to cancel the wizard. This fixes projects.maemo.org
579 2007-07-02 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-tny-account.h:
582 * src/modest-tny-account.c:
583 (modest_tny_account_new_from_server_account),
584 (modest_tny_account_new_from_server_account_name),
585 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
586 because this must now be set before setting the proto. This is usd in
587 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
588 warning in camel_session_get_service() caused by
589 tny_camel_transport_account_prepare().
591 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
594 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
596 * src/maemo/modest-connection-specific-smtp-edit-window.c:
598 (modest_connection_specific_smtp_edit_window_init):
600 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
603 2007-06-29 Murray Cumming <murrayc@murrayc.com>
605 * src/modest-tny-account.c:
606 (modest_tny_account_new_from_server_account):
607 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
608 now uses to request a connection when it needs one, and which it uses
609 to tell us that something is wrong with the connection, so we can force
610 the accounts offline to prevent further problems.
613 * src/modest-init.c: (init_default_settings):
614 * src/modest-mail-operation.c:
615 (modest_mail_operation_update_account):
616 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
617 This should not be necessary anymore. Do not set the conf key that
618 determined this (it was always TRUE and not set anywhere else).
620 * src/modest-ui-actions.h: Remove unused and unimplemented
621 modest_ui_actions_on_online_toggle_toggled().
623 2007-06-29 Murray Cumming <murrayc@murrayc.com
625 * src/maemo/modest-main-window.c: (connect_signals):
626 Don't connect to delete_event twice. Maybe this was harmless.
628 2007-06-29 Murray Cumming <murrayc@murrayc.com
630 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
631 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
632 Debug output to give some more clue when a folder move is not allowed.
634 2007-06-28 Murray Cumming <murrayc@murrayc.com
636 * src/modest-tny-account.c: (on_modest_file_system_info),
637 (modest_tny_account_get_mmc_account_name):
638 Always call the callback, without checking whether the name has changed.
639 * src/widgets/modest-folder-view.c: (strings_are_equal),
640 (on_model_foreach_set_name), (on_get_mmc_account_name),
641 (text_cell_data): Compare the name here, and use the name from
642 the account rather than from the
643 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
644 if the name was changed after the account was added to the model.
645 That's a tinymail bug but not one that I want to fix now.
647 This finally fixes projects.maemo.org bug NB#59301.
649 2007-06-27 Armin Burgmeier <armin@openismus.com>
651 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
654 2007-06-27 Murray Cumming <murrayc@murrayc.com
656 * src/modest-tny-account.h:
657 * src/modest-tny-account.c:
658 Added modest_tny_account_get_mmc_account_name(), to set the memory
659 card name asynchronously for the given account and then notify.
660 (modest_tny_account_new_for_local_folders): Use this new function instead
661 of using hildon_file_system_info_async_new() directly.
663 * src/widgets/modest-folder-view.c: (text_cell_data):
664 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
665 gtk_tree_model_row_changed() when it is available.
667 This should fix projects.maemo.org bug NB#59301.
669 2007-06-27 Murray Cumming <murrayc@murrayc.com
671 * src/modest-mail-operation.c: (update_account_thread),
672 (get_msgs_full_thread): Fix typo failures in the revert
675 2007-06-27 Murray Cumming <murrayc@murrayc.com
677 * src/maemo/modest-maemo-global-settings-dialog.c:
678 (idle_select_default_focus):
679 * src/modest-mail-operation.c: (idle_notify_progress),
680 (idle_notify_progress_once), (set_last_updated_idle),
681 (update_account_thread), (get_msgs_full_thread):
682 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
683 * src/widgets/modest-header-view.c:
684 (idle_notify_headers_count_changed_destroy),
685 (idle_notify_headers_count_changed):
686 Reverted the additions of gdk_threads_enter/leave(), in case this
687 helps with a startup hang on the device.
689 2007-06-26 Armin Burgmeier <armin@openismus.com>
691 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
692 for supported secure authentication methods from server by
693 gtk_dialog_run(), saving CPU time and a potential race condition.
695 2007-06-26 Armin Burgmeier <armin@openismus.com>
697 * src/maemo/modest-maemo-utils.h:
698 * src/maemo/modest-maemo-utils.c: Added a
699 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
700 only error code to tell the calling code when the user canceled the
703 * src/maemo/modest-account-settings-dialog.h:
704 * src/maemo/modest-account-settings-dialog.c:
705 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
706 message if the retrieval of secure authentication methods was canceled
707 by the user. Perform the check before saving anything to configuration
708 to not end up with half-committed configuration changes, do not show
709 a "Saving to configuration failed" note when authentication methods
710 could not be retrieved.
712 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
715 2007-06-26 Murray Cumming <murrayc@murrayc.com>
717 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
718 Only return the first level of folders under accounts, because the
719 osso-global-search UI spec doesn't want the rest.
720 This fixed projects.maemo.org bug NB#61811.
722 2007-06-26 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-tny-account-store.c:
725 * src/modest-tny-account-store.h:
726 Added modest_tny_account_is_memory_card_account().
727 * src/maemo/modest-main-window.c: (create_details_widget):
728 Show the same information items for the memory card as we show for the
729 local-folders, to fix projects.maemo.org bug NB#59307.
731 2007-06-26 Murray Cumming <murrayc@murrayc.com>
733 * src/modest-tny-account-store.c: (get_password):
734 Added some checks for NULL to maybe prevent crashes, though I think
735 it was Philip's last commit that actually prevented the crash here
736 when creating a first new account.
737 But the new account is still not usable (no messages are shown)
738 until a restart of the application.
740 2007-06-26 Murray Cumming <murrayc@murrayc.com>
742 * src/maemo/modest-maemo-global-settings-dialog.c:
743 (idle_select_default_focus):
744 * src/modest-mail-operation.c: (idle_notify_progress),
745 (idle_notify_progress_once), (idle_notify_update_account_queue),
746 (set_last_updated_idle), (update_account_thread),
747 (notify_get_msgs_full), (get_msgs_full_destroyer),
748 (get_msgs_full_thread):
749 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
750 * src/widgets/modest-header-view.c:
751 (idle_notify_headers_count_changed_destroy),
752 (idle_notify_headers_count_changed):
753 Use gdk_threads_enter() and gdk_threads_enter_leave() in
754 all idle handlers, because some other thread could be blocking
755 the GDK lock, so that it can do GUI stuff.
757 2007-06-26 Murray Cumming <murrayc@murrayc.com>
759 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
760 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
761 (on_idle_send_receive), (on_idle_open_default_inbox):
762 * src/maemo/modest-msg-edit-window.c:
763 (modest_msg_edit_window_attach_file_noninteractive):
764 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
765 to prevent a hang. I don't quite understand why these are necessary,
766 beause we should already be in the main loop. I guess something outside
767 of the main loop is taking the lock.
769 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
770 we are really using URIs, and use files that are more likely to exist.
772 2007-06-26 Murray Cumming <murrayc@murrayc.com>
774 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
775 necessary because configure.ac now defines different variables.
777 2007-06-26 Murray Cumming <murrayc@murrayc.com>
779 * libmodest-dbus-client/libmodest-dbus-client.c:
780 * libmodest-dbus-client/libmodest-dbus-client.h:
781 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
782 libmodest_dbus_client_compose_mail() is what things actually use.
784 * src/dbus_api/modest-dbus-api.h:
785 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
786 * tests/dbus_api/Makefile.am:
787 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
790 2007-06-26 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-init.c: (modest_init_local_folders):
793 For memory-card (or other non local-folders) maildir accounts,
794 always create an Archive folder, so that there is somewhere to put
795 messages. This should be less confusing, because the user does not need
796 to guess that the need to create a folder.
798 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
800 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
801 Fixed icon size by using (50, 50) which is the same as defined by
804 2007-06-25 Armin Burgmeier <armin@openismus.com>
806 * src/widgets/modest-window-mgr.c:
808 * configure.ac: Correctly recognize hildon-notify presence and fixed
809 the build without it being installed.
811 2007-06-25 Murray Cumming <murrayc@murrayc.com>
813 * libmodest-dbus-client/libmodest-dbus-client.c:
814 (libmodest_dbus_client_search): Fix the build. Sorry.
815 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
816 (reply_forward_cb): Initialize variables to fix the build.
818 * src/modest-tny-account-store.c:
819 (modest_tny_account_store_get_tny_account_by): Fix the account URI
820 comparison (a silly typo) so that email search results can be opened
821 when there are more than one account.
823 2007-06-25 Murray Cumming <murrayc@murrayc.com>
825 * libmodest-dbus-client/libmodest-dbus-client.c:
826 (libmodest_dbus_client_search),
827 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
828 instead of 1 second, because the search gets folders and messages from
829 the server, which can take a long time. When it times out,
830 osso-global-search will report no results.
832 We need to specify whether we should search only cached information
833 (maybe with a user preference), and the osso-email-search-plugin
834 API should really be improved to allow that option, and to allow results
835 to be delivered asynchronously in batches.
837 2007-06-25 Murray Cumming <murrayc@murrayc.com>
839 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
840 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
841 GTK_ICON_SIZE_DIALOG is probably the wrong size.
843 2007-06-25 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
846 that is an empty string. D-Bus seems to give us these instead of NULL.
848 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
850 * src/dbus_api/modest-dbus-callbacks.c:
851 * src/maemo/easysetup/modest-easysetup-wizard.h:
852 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
854 (modest_connection_specific_smtp_edit_window_init):
855 * src/maemo/modest-maemo-global-settings-dialog.c:
857 * src/maemo/modest-maemo-utils.c:
858 (modest_maemo_utils_setup_images_filechooser):
859 * src/maemo/modest-main-window.c: (create_details_widget):
860 * src/maemo/modest-msg-edit-window.c:
861 (modest_msg_edit_window_attach_file_noninteractive),
862 (modest_msg_edit_window_color_button_change),
863 (modest_msg_edit_window_set_zoom):
864 * src/modest-mail-operation.c: (update_account_thread):
865 * src/modest-tny-account-store.c:
866 * src/modest-tny-account.c:
867 * src/widgets/modest-global-settings-dialog.c:
868 * src/widgets/modest-window.h:
872 2007-06-25 Murray Cumming <murrayc@murrayc.com>
874 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
875 * src/modest-search.c: (modest_search_folder),
876 (modest_search_all_accounts): Actually search only in the specified folder,
877 doing a simple match on the folder ID.
878 * src/modest-search.h: Added a folder field to the ModestSearch struct,
879 and added some documentation.
881 2007-06-22 Armin Burgmeier <armin@openismus.com>
883 * src/maemo/modest-maemo-utils.h:
884 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
885 modest_maemo_utils_get_supported_secure_authentication_methods.
887 * src/maemo/easysetup/modest-easysetup-wizard.c:
888 * src/maemo/modest-account-settings-dialog.c: Show correct error if
889 one occured, not just "Server does not support secure authentication".
891 2007-06-22 Murray Cumming <murrayc@murrayc.com>
893 * src/modest-tny-account-store.c: (get_password):
894 Restored the call to tny_account_set_user() because Philip seems to have
895 stopped this from crashing (by not using the freed string). It still does
896 not work, but now we can test it.
898 2007-06-22 Murray Cumming <murrayc@murrayc.com>
900 * src/maemo/modest-msg-edit-window.c: (init_window):
901 Comment out use of an uninitialzed GtkScrolledWindow variable,
902 to fix the build and stop a crash. Yet again.
904 2007-06-22 Murray Cumming <murrayc@murrayc.com>
906 * src/modest-tny-account-store.c: (get_password):
907 Remove the call to tny_account_set_user() because this actually crashes.
908 As mentioned in the last commit, it is known to not work anyway.
910 2007-06-22 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account-store.c: (get_password):
913 Use tny_account_set_username() to tell tinymail that the username might
914 have changed too. But tinymail ignores this: see projects.maemo.org
916 * src/modest-ui-actions.c:
917 (modest_ui_actions_on_password_requested): Remove the useless attempt to
918 reset the connection when changing the username, and improve the comments.
919 Save the changed username to gconf at least, so it is used when Modest is
922 2007-06-21 Murray Cumming <murrayc@murrayc.com>
924 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
925 Do not use a query, so that we get all folders, including for POP and
926 local-folders. They work as search criteria too.
927 This fixes projects.maemo.org bug NB#57740.
929 2007-06-21 Murray Cumming <murrayc@murrayc.com>
931 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
932 Comment out the use of hildon_notification_set_sound() because it is
933 not declared, to fix the build. Warnings are serious, people.
935 2007-06-21 Armin Burgmeier <armin@openismus.com>
937 * src/maemo/modest-maemo-utils.h:
938 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
939 modest_maemo_utils_get_supported_secure_authentication_methods()
940 to query authentication methods for a specific user. This should fix
941 projects.maemo.org bug NB#61369.
943 * src/maemo/easysetup/modest-easysetup-wizard.c:
944 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
947 2007-06-21 Murray Cumming <murrayc@murrayc.com>
949 * libmodest-dbus-client/libmodest-dbus-client.h:
950 * libmodest-dbus-client/libmodest-dbus-client.c:
951 (modest_dbus_message_iter_get_search_hit),
952 (libmodest_dbus_client_search):
953 Reorganised and commented this.
954 Removed modest_search_hit_free() from the public API because it
957 Added libmodest_dbus_client_get_folders() and
958 modest_folder_result_list_free().
960 * src/dbus_api/modest-dbus-api.h:
961 * src/dbus_api/modest-dbus-callbacks.c:
962 (modest_dbus_req_filter): Commented. Moved most code to
963 on_dbus_method_search() and added on_dbus_method_get_folders().
965 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
966 of the extra D-Bus handler.
968 * tests/dbus_api/Makefile.am:
969 * tests/dbus_api/test_get_folders.c: New test for
970 libmodest_dbus_client_get_folders(). This seems to return an empty list
971 at the moment. That could be the same error that causes the message list
972 to be empty sometimes.
973 This should help with projects.maemo.org bug NB#57740.
975 2007-06-21 Armin Burgmeier <armin@openismus.com>
977 * src/modest-mail-operation.c: Do not call
978 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
979 notify the operation's end after having set the status to CANCELED for
980 the operation queue to listen on. This fixes a deadlock when there
981 were mail operations in the queue during its finalization.
983 * src/modest-singletons.c: Reordered uninitialization of the account
984 manager to happen after the mail operation queue was uninitialized
985 because the mail operation's in the queue might still try to access
986 the account manager (see modest_mail_operation_notify_end()). This
987 fixes a potential crash when terminating the application.
989 2007-06-21 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-search.c:
992 (search_mime_part_and_child_parts): Moved some code here so we
993 can search recursively in child folders.
994 (modest_search_folder): Search in the message as a mime part, instead
995 of just its child mime parts.
996 (read_chunk), (search_mime_part_ogs):
997 Check how many bytes were read, to prevent an endless loop.
998 Searching in message bodies now works. This finishes the fix for
999 projects.maemo.org bug NB#61007.
1001 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1004 Add a g_warning when the item is not a folder.
1006 * src/modest-ui-dimming-rules.c:
1007 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1008 when selected item is not a folder (for instance, an account), because
1009 the UI spec only talks about folders.
1010 I am not sure what the UI spec wants, so this might not totally fix
1011 projects.maemo.org bug NB#60794.
1013 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1015 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1016 (load_from_file): Sort the list. The unsorted list would be more noticeable
1017 in non-English locales.
1019 * src/maemo/modest-msg-edit-window.c:
1020 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1021 warning and fix the build.
1023 * src/maemo/modest-progress-bar-widget.c:
1024 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1025 avoid a g_warning, and probably to avoid a crash.
1027 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1029 * src/modest-search.c: (modest_search_folder): Check for a GError
1030 when calling tny_folder_get_headers(), to show that this is not the cause
1033 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1035 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1036 Actually set the body query instead of the subject query.
1038 * src/modest-search.c: (search_mime_part_ogs),
1039 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1040 which would probably cause it to fail if we got this far.
1042 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1043 to simplify the code.
1044 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1045 be causing search-in-body to fail.
1047 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1049 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1051 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1052 Better debug message when the folder cannot be found.
1053 This should help with fixing projects.maemo.org bug #61287.
1054 * src/modest-search.c: (add_hit): Do not leak the furl string.
1056 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-ui-actions.c:
1059 (modest_ui_actions_on_folder_selection_changed):
1060 Do not special-case TNY_MERGE_FOLDER here, because
1061 modest_tny_folder_get_account() already does that. This fixes
1062 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1063 shown when the Outbox was selected).
1065 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1067 * libmodest-dbus-client/libmodest-dbus-client.c:
1068 (_dbus_iter_get_string_or_null): Initialize the string variable in
1069 case this helps with Dirk's crash.
1071 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1073 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1074 though it is not implemented yet (this function is maybe not even used),
1075 to avoid breaking ABI in future.
1076 * libmodest-dbus-client/libmodest-dbus-client.c:
1077 (get_attachments_string): Moved some code into this generic function.
1078 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1079 sends email. It is maybe not used.
1080 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1081 (on_send_mail): Use attachments.
1083 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1084 * src/maemo/modest-msg-edit-window.c:
1085 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1086 a filename before using it, to fix projects.maemo.org bug NB#58233.
1088 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1091 Initialize the continue_download variable to fix the build, and probably
1092 to fix randome behaviour.
1094 2007-06-18 Armin Burgmeier <armin@openismus.com>
1096 * src/modest-tny-send-queue.h:
1097 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1098 the queue so we can later show it in the UI. Replaced
1099 modest_tny_send_queue_msg_is_being_sent() by
1100 modest_tny_send_queue_get_msg_status().
1102 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1104 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1105 gpointer. This probably was not harmful, but just to be sure.
1107 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1109 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1110 Fix the build, but leave the function broken on Bora, because
1111 hildon_uri_action_get_service() does not exist.
1112 osso_uri_action_get_service() does not exist either, it seems.
1114 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-tny-account.c:
1117 (modest_tny_account_new_from_server_account):
1118 Uncommented the url debug output again, because it is useful for
1119 debugging, as I said in the comment.
1121 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1123 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1125 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1126 for Mameo Bora, to fix the build.
1128 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1131 Fixed build with hildon < 0.99
1133 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1134 Check if the selected account is busy instead of checking all accounts
1136 * src/modest-account-mgr-priv.h:
1137 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1138 (modest_account_mgr_init), (compare_account_name),
1139 (modest_account_mgr_set_account_busy),
1140 (modest_account_mgr_account_is_busy):
1141 * src/modest-account-mgr.h:
1142 Added busy information to the account manager. It possible to
1143 set an account to busy or not busy now.
1145 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1146 (modest_mail_operation_update_account),
1147 (modest_mail_operation_notify_end):
1148 Set the account to busy/not busy depending on the operation state.
1150 * src/widgets/modest-account-view.c:
1151 (modest_account_view_finalize), (get_last_updated_string),
1152 (update_account_view), (on_account_busy_changed), (init_view):
1153 Show string "Refreshing..." if the account is currently busy.
1155 All this fixes projects.maemo.org bug NB#59711
1157 2007-06-14 Armin Burgmeier <armin@openismus.com>
1159 * src/widgets/modest-attachments-view.h:
1160 * src/widgets/modest-attachments-view.c: Added
1161 modest_attachments_view_has_attachments() and fixed coordinate
1162 transformation in get_att_view_at_coords(). This fixes attachment
1165 * src/widgets/modest-msg-view.c: Make use of
1166 modest_attachments_view_has_attachments() to decide whether to show
1167 attachments in the header.
1169 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1171 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1172 (on_change), (on_combo_security_changed),
1173 (modest_connection_specific_smtp_edit_window_init),
1174 (modest_connection_specific_smtp_edit_window_set_connection),
1175 (modest_connection_specific_smtp_edit_window_is_dirty):
1176 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1177 * src/maemo/modest-connection-specific-smtp-window.c:
1180 Show an comfirmation dialog for the smpt-edit-window if there are
1181 unsaved changes and the user hits cancel.
1182 (projects.maemo.org bug NB#60479)
1184 2007-06-14 Armin Burgmeier <armin@openismus.com>
1186 * src/maemo/easysetup/modest-easysetup-wizard.c:
1187 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1188 address" info in banner instead of node, and select all the text as
1189 per UI spec. This fixes projects.maemo.org bug NB#60550.
1191 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1193 reviewed by: <delete if not using a buddy>
1195 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1196 * src/modest-ui-actions.c: (folder_refreshed_cb):
1198 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1200 * src/widgets/modest-folder-view.c: (filter_row):
1201 Explictly filter out the per-account outbox accounts. I don't know why
1202 these only sometimes show up, but now they should never show up in the UI.
1203 This should fix projects.maemo.org bug NB#60160.
1205 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1207 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1208 when the toolbar does not exist yet.
1209 * src/modest-widget-memory.c: (save_settings_header_view):
1210 Added g_warnings() to help us to discover when we are trying to set
1211 an empty columns list in gconf.
1213 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1215 * src/modest-init.h:
1216 * src/modest-init.c:
1217 Added modest_init_get_default_header_view_column_ids().
1219 * src/modest-widget-memory.c: (restore_settings_header_view):
1220 Use the new function to get defaults, if the gconf key is empty,
1221 instead of not creating any columns. This seems to fix the
1222 empty right-hand pane problems.
1224 * src/widgets/modest-header-view.h: Improved documentation.
1226 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1229 Revert the use of the display name as the account name, because this
1230 is generally wrong and would break the code that follows.
1232 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1234 * src/maemo/easysetup/modest-easysetup-wizard.c:
1235 (check_for_supported_auth_methods), (on_before_next),
1238 More correct fix for projects.maemo.org bug NB# 58991
1239 Do not longer accept AUTH_PASSWORD as secure method and choose
1240 correct method when creating the account.
1242 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1244 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1245 Fixed projects.maemo.org bug NB# 58991
1247 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1249 * src/modest-init.c: (modest_init_init_core),
1250 (modest_init_local_folders): Fixed compilation errors.
1252 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1254 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1255 Remove unnecessary lib/include, though it is good in principle when needed.
1257 * src/modest-init.c: (modest_init_one_local_folder),
1258 (modest_init_local_folders):
1259 * src/modest-init.h: Initialize the .modest library for memory cards,
1260 instead of just doing nothing for them. This should allow us to create
1261 folders there, fixing projects.maemo.org bug NB#59297.
1263 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1265 * libmodest-dbus-client/libmodest-dbus-client.c:
1266 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1267 (libmodest_dbus_client_compose_mail),
1268 (libmodest_dbus_client_open_message),
1269 (libmodest_dbus_client_send_and_receive),
1270 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1272 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1273 (on_idle_open_message), (modest_dbus_req_handler),
1274 (search_result_to_message), (modest_dbus_req_filter):
1275 * src/modest-search.c: (add_hit), (modest_search_folder),
1276 (modest_search_all_accounts): Improved debug messages.
1278 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1280 * src/modest-tny-account-store.c:
1281 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1284 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1287 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-tny-account-store.c: (get_server_accounts):
1290 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1291 even when there are no accounts, so that the Outbox folder is always
1292 visible. This fixes projects.maemo.org bug NB#60158.
1294 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1296 * src/maemo/modest-main-window.c: (create_details_widget):
1297 Use the mcen_va_never logical ID.
1299 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1301 * src/dbus_api/modest-dbus-api.h:
1302 * src/dbus_api/modest-dbus-callbacks.c:
1303 (on_idle_open_default_inbox), (on_open_default_inbox),
1304 (modest_dbus_req_handler):
1305 Added a new OpenDefaultInbox method.
1307 * libmodest-dbus-client/libmodest-dbus-client.h:
1308 * libmodest-dbus-client/libmodest-dbus-client.c:
1309 Added libmodest_dbus_client_open_default_inbox() to call the new
1310 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1311 though it should maybe be used by a new osso-email-interface function.
1313 * tests/dbus_api/Makefile.am:
1314 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1317 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1320 NULL, so that the signals get all the keys. This should not actually
1321 change any behaviour because we currently update everything when anything
1324 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1326 * src/widgets/modest-folder-view.c: (text_cell_data),
1327 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1328 (find_inbox_iter): If tinymail tells us that the folder is
1329 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1330 This causes the inbox to be selected at startup, fixing part of
1331 projects.maemo.org bug NB#56305.
1333 * src/modest-ui-dimming-rules.c:
1334 (modest_ui_dimming_rules_on_tools_smtp_servers):
1335 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1336 the SMTP servers menu item.
1337 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1338 that the SMTP Servers menu item is dimmed when there are no accounts,
1339 as a future version of the UI spec will require. This fixes
1340 projects.maemo.org bug NB#56305.
1342 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1344 * src/maemo/modest-maemo-utils.c:
1345 (modest_maemo_utils_get_supported_secure_authentication_methods):
1346 Added label to dialog instead of unreadable title
1348 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1349 (modest_main_window_new):
1350 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1353 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1354 * src/modest-account-mgr.h:
1355 Added method to avoid code duplication
1357 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1358 (modest_ui_actions_on_send_receive):
1359 Use modest_account_mgr_has_accounts
1361 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1363 * src/maemo/easysetup/modest-presets.c:
1364 (modest_presets_get_info_server_security): Do not report secure auth
1366 * src/modest-protocol-info.c: Use the defines for the gconf key names
1367 for secure authentication. This was not working because we were writing
1368 Password and reading password, and the check was case sensitive.
1369 With this, gmail now works for receiving and sending when created via
1372 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1374 * src/maemo/easysetup/modest-presets.c:
1375 (modest_presets_get_info_server_security): Correct the key name for
1376 SecureSmtp, because it seems to be case-sensitive.
1377 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1378 Do not try to get the 0th notebook page if there are 0 pages, to
1379 avoid a g_warning().
1381 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1384 Prevent use of the new notification feature for now, because it currently
1385 shows one dialog for each new email, which is annoying.
1387 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1390 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1391 when no country was selected, so that we show the global ones.
1392 * src/maemo/easysetup/modest-presets.c:
1393 (modest_presets_get_providers): Return only the global providers, not
1394 all providers when mmc=0 was requested.
1396 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1399 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1400 provider ID in the combo.
1402 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1403 Do not show the page numbers, because it would be confusing when we add
1404 the 2 extra pages for the custom setup, when the user chooses the "Other"
1405 provider. This fixes projects.maemo.org bug NB#59028
1407 * src/modest-init.c: (modest_init_init_core),
1408 (modest_init_local_folders):
1409 * src/modest-init.h:
1410 * src/modest-tny-account.c:
1411 (modest_tny_account_new_for_local_folders): Do not create default folders
1412 for the memory card. This should fix projects.maemo.org bug NB#59328.
1414 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1416 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1417 Free the changed_conf_keys string items. They are already freed in the
1418 idle handler if that runs first.
1420 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-ui-actions.c:
1423 (modest_ui_actions_on_password_requested): Check that the server name
1424 is not NULL, because I just saw a password dialog with (null) as the
1427 * src/modest-tny-folder.[h|c]: Added
1428 modest_tny_folder_is_memory_card_folder().
1429 * src/modest-ui-dimming-rules.c:
1430 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1431 menu item for memory cards, as per the UI spec (section 7.4). This should
1432 fix projects.maemo.org bug NB#59297.
1434 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1436 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1437 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1438 is another problem with the code, see Murray's comment at line 772)
1440 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1443 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1444 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1445 (load_from_file), (easysetup_country_combo_box_init),
1446 (easysetup_country_combo_box_get_active_country_ids),
1447 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1448 instead of just one ID, to avoid duplicate country names in the UI.
1450 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1451 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1452 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1453 a single ID, avoiding duplicate providers.
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 (on_combo_account_country): Adapt to use a list.
1457 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1460 keys changed in the last X seconds.
1462 * src/modest-account-mgr.h:
1463 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1464 (on_key_change), (modest_account_mgr_class_init),
1465 (modest_account_mgr_init), (modest_account_mgr_finalize):
1466 As the keys are changed, save them in a GSList* and signal that GSList*
1467 further every X seconds, to batch changes, to allow us to do just one
1468 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1469 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1471 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1472 changed signal signature.
1474 * src/modest-conf.c: (modest_conf_set_list),
1475 (modest_conf_on_change): Reenable notification.
1477 (modest_conf_maemo_fake_on_change): Comment out the hack that
1478 notified immediately instead of asynchronously.
1480 * src/widgets/modest-account-view.h:
1481 * src/widgets/modest-account-view.c:
1482 (update_account_view): Select the previously-selected account ID,
1483 if possible. This fixes projects.maemo.org bug NB#56933.
1485 (on_account_changed), (on_account_removed),
1486 (modest_account_view_select_account):
1488 Remove the block/unblock functions
1489 because they were not useful.
1491 * src/maemo/modest-account-view-window.c:
1492 (on_delete_button_clicked), (on_edit_button_clicked),
1493 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1495 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1497 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1498 Improve the error dialog to show Incorrect Account Settings, which seems
1499 clearer, and say that the internal error message (to be removed from the
1500 dialog later) is often misleading.
1501 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1503 * src/modest-tny-account.c:
1504 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1505 URL because this is so useful for debugging on the device.
1507 * src/widgets/modest-serversecurity-combo-box.c:
1508 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1510 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-mail-operation.c:
1513 (modest_mail_operation_send_new_mail):
1514 Added a comment about a nasty but apparently harmless message. Details
1515 added to the wiki g_warnings() page.
1517 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1520 (modest_tny_send_queue_class_init):
1521 Do not use the priv struct because it is empty, to avoid g_warnings
1522 about a non-existant priv struct.
1524 * src/modest-tny-account-store.c:
1525 (modest_tny_account_store_get_server_account),
1526 (modest_tny_account_store_get_transport_account_for_open_connection
1527 ): Do not try to get transport server accounts for local folders,
1528 because they don't have any. This avoids a g_warning().
1530 * src/maemo/modest-main-window.c:
1531 (modest_main_window_notify_send_receive_initied),
1532 (on_configuration_key_changed):
1533 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1534 * src/modest-defs.h:
1535 * src/modest-mail-operation.c:
1536 (modest_mail_operation_update_account):
1537 * src/modest-tny-account-store.h:
1538 * src/modest-tny-account.c:
1539 (modest_tny_account_get_special_folder),
1540 (modest_tny_account_new_for_local_folders),
1541 (modest_tny_account_new_for_per_account_local_outbox_folder):
1542 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1543 * src/modest-tny-local-folders-account.c:
1544 (add_account_folders_to_merged_folder):
1545 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1546 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1547 (modest_ui_actions_on_send):
1548 * src/widgets/modest-folder-view.c: (update_model):
1549 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1550 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1551 modest_tny_account_store_get_tny_account_by_account() to
1552 modest_tny_account_store_get_server_account() to make the code clearer.
1554 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1556 * src/dbus_api/modest-dbus-api.h:
1557 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1558 * src/maemo/modest-msg-edit-window.c:
1559 (modest_msg_edit_window_attach_file_noninteractive):
1560 added g_warning in case the file to be attached does not exist
1561 * tests/dbus_api/test_compose_mail.c: (main):
1562 removed obsolete comment, added generic files as test case
1564 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1566 * src/modest-tny-account-store.c: (get_server_accounts):
1567 Create the local folders account only once, not once for each outbox, and
1568 not only when there are some outboxes.
1570 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1572 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1573 code that is causing a crash at startup. Sergio says that he is fixing this.
1575 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1577 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1578 * src/maemo/modest-account-settings-dialog.c:
1579 (create_page_outgoing),
1580 (modest_account_settings_dialog_set_account_name),
1581 (save_configuration):
1582 - Fixed handling of the "Use secure authentication" toggle to comply with
1583 the ui specification. See also projects.maemo.org bug NB#58400
1585 - Restore the Secure connection setting combo correctly when loading
1588 * src/maemo/modest-maemo-utils.c:
1589 (on_camel_account_get_supported_secure_authentication),
1590 (modest_maemo_utils_get_supported_secure_authentication_methods):
1591 Fixed a crasher if operation is canceled
1593 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1594 (modest_protocol_info_auth_is_secure):
1595 * src/modest-protocol-info.h:
1597 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1598 the sense of the "Use secure authentication" toggle.
1600 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-tny-account-store.h:
1603 * src/modest-tny-account-store.c:
1604 Added modest_tny_account_store_get_local_folders_account().
1606 * src/modest-tny-folder.h:
1607 * src/modest-tny-folder.c:
1608 (modest_tny_folder_get_account):
1609 Added this replacement for tny_folder_get_account() which returns
1610 the local-folders account for TnyMergeFolders, to avoid the
1611 warning about the unimplemented get_account_func() vfunc().
1613 (modest_tny_folder_get_rules),
1614 * src/modest-ui-actions.c:
1615 (modest_ui_actions_on_folder_selection_changed):
1616 * src/modest-mail-operation.c:
1617 (modest_mail_operation_remove_folder),
1618 (modest_mail_operation_xfer_folder),
1619 (modest_mail_operation_rename_folder),
1620 (modest_mail_operation_get_msg),
1621 (modest_mail_operation_get_msgs_full),
1622 (modest_mail_operation_remove_msg),
1623 (modest_mail_operation_xfer_msgs),
1624 (modest_mail_operation_refresh_folder):
1625 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1627 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1629 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1630 (modest_server_account_set_security):
1631 * src/modest-defs.h: Add comments explaining that our
1632 UI spec means TLS when it says Normal, so these do not look like errors.
1634 * src/modest-tny-account.c:
1635 (modest_tny_account_new_from_server_account): Use the new tinymail
1636 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1637 for TLS. This should fix projects.maemo.org bug NB#58460.
1639 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1641 * src/maemo/easysetup/modest-easysetup-wizard.c:
1642 (create_account): Correct the position of the gconf sanity check warning.
1643 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1644 of using the g_idle_add() hack, because this does not seem to be necessary
1645 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1646 caused by something other than maemo's gconf.
1647 This fixes projects.maemo.org bug #59022.
1649 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-account-mgr-helpers.c:
1652 (modest_account_mgr_get_default_account): Do not check that the account
1653 exists if there is no default account (NULL), to fix a runtime warning.
1655 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1657 * src/widgets/modest-folder-view.c: (update_model):
1658 Do not unref the treemodel before we have finished with it.
1659 This prevents a valgrind warning and an occasional crash at startup.
1661 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1663 * libmodest-dbus-client/libmodest-dbus-client.h:
1664 added libmodest_dbus_client_compose_mail()
1665 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1667 added functions needed for SendAsMail() functionality
1668 * src/maemo/modest-msg-edit-window.c:
1669 (modest_msg_edit_window_attach_file_noninteractive):
1670 non interactively attaching files to message edit window
1671 * src/widgets/modest-msg-edit-window.h:
1672 * tests/dbus_api/Makefile.am:
1673 added test_compose_mail.c
1674 * tests/dbus_api/test_compose_mail.c: (main):
1676 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1678 * src/modest-account-view.c:
1679 Fixed bug projects.maemo.org bug NB#59307
1681 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1683 * src/maemo/easysetup/modest-easysetup-wizard.c:
1684 (get_serverport_incoming), (on_before_next), (create_account):
1685 * src/maemo/modest-account-settings-dialog.c:
1686 (modest_account_settings_dialog_set_account_name):
1687 * src/maemo/modest-maemo-utils.c:
1688 (on_camel_account_get_supported_secure_authentication_status),
1689 (on_camel_account_get_supported_secure_authentication),
1690 (on_secure_auth_cancel),
1691 (modest_maemo_utils_get_supported_secure_authentication_methods):
1693 Implemented security authentication for settings and easysetup.
1695 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1697 * src/maemo/modest-main-window.c: (create_details_widget):
1698 Show the total size for memory card accounts too, instead of showing
1699 the name again. Fixes bug projects.maemo.org bug NB#59307.
1701 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-tny-simple-folder-store.c:
1705 * src/modest-tny-simple-folder-store.h: Removed.
1707 * src/modest-tny-local-folders-account.h
1708 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1709 for the local-folders maildir, with an extra TnyMergedFolder containing
1710 the folders of the per-account outbox store accounts.
1711 * src/modest-tny-account-store.c: (get_server_accounts):
1712 Add the outboxes to the special local folders account after creating it.
1714 * src/modest-tny-account.c:
1715 (modest_tny_account_new_for_local_folders): Create the derived
1716 account when creating the main local-folders account.
1718 * src/maemo/modest-main-window.c: (create_details_widget),
1719 (modest_main_window_set_contents_style):
1720 Adapted to the use of the derived account instead of the folder store.
1722 * src/modest-ui-actions.c:
1723 (modest_ui_actions_on_folder_selection_changed):
1724 * src/modest-ui-dimming-rules.c:
1725 (modest_ui_dimming_rules_on_new_folder):
1726 * src/widgets/modest-folder-view.c: (text_cell_data),
1727 (icon_cell_data), (filter_row), (update_model),
1728 (get_cmp_rows_type_pos):
1731 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1732 Do not get the priv struct, because no priv struct has been set,
1733 to avoid a runtime warning.
1735 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1736 #ifelse with #else, to fix a warning, to fix the build.
1739 2007-06-05 Christian Kellner <ckellner@openismus.com>
1741 * libmodest-dbus-client/libmodest-dbus-client.c:
1742 Fix small typo in doc (why do you always see them
1743 AFTER committing stuff?)
1746 2007-06-05 Christian Kellner <ckellner@openismus.com>
1748 * libmodest-dbus-client/libmodest-dbus-client.c:
1749 (libmodest_dbus_client_search):
1750 Initialize hit list with NULL. Also set folder list
1751 to "" if NULL was supplied.
1754 2007-06-03 Christian Kellner <ckellner@openismus.com>
1756 * libmodest-dbus-client/libmodest-dbus-client.c:
1757 (modest_search_hit_list_free):
1758 Make it save to call it with NULL.
1760 * src/dbus_api/modest-dbus-callbacks.c:
1761 * src/modest-search.c:
1762 Return full ModestSearchHits as the search result list not TnyHeader
1763 since can't be around withouth the correspoding TnyFolder.
1765 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1767 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1768 Added currently commented code to check for secure auth
1770 * src/maemo/modest-account-settings-dialog.c: (on_response),
1771 (save_configuration), (show_ok):
1772 Fixed projects.maemo.org bugs NB #59248 and #59251
1774 * src/maemo/modest-maemo-utils.c:
1775 (on_camel_account_get_supported_secure_authentication_status),
1776 (on_camel_account_get_supported_secure_authentication),
1777 (modest_maemo_utils_get_supported_secure_authentication_methods):
1778 * src/maemo/modest-maemo-utils.h:
1779 Moved get_supported_secure_authentication() method here to be able
1780 to use it from easysetup wizard.
1782 * src/modest-pair.c: (on_pair_compare_as_string):
1783 Should compare string with first part of pair and not
1784 strcmp pairs which will crash.
1786 * src/modest-protocol-info.c:
1787 (modest_protocol_info_protocol_is_store):
1788 * src/modest-protocol-info.h:
1789 Added modest_protocol_info_get_auth_protocol_name()
1791 2007-06-03 Armin Burgmeier <armin@openismus.com>
1793 * src/modest-mail-operation.c:
1794 (modest_mail_operation_get_msgs_full): Set priv->account also when
1795 only retrieving a single message. This avoids a crash when canceling
1798 (modest_mail_operation_notify_end): Do not explicitely remove the
1799 operation from the queue but only emit the progress_changed signal.
1800 The queue itself listens to that signal to remove the operation when
1801 it is finished. This reduces coupling and removes a potential deadlock
1802 when modest_mail_operation_notify_end() is called from the queue
1803 itself. If that is a problem performance-wise, I would suggest to
1804 implement a status-changed signal or something.
1806 * src/modest-mail-operation-queue.c: Make sure to never call a
1807 function from another file while the queue is locked. This (hopefully)
1808 fixes another deadlock when exiting the application while retrieving
1811 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1813 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1814 Fixed build if libogs is not available
1816 2007-06-03 Christian Kellner <ckellner@openismus.com>
1818 * libmodest-dbus-client/libmodest-dbus-client.h:
1819 * libmodest-dbus-client/libmodest-dbus-client.c:
1820 (libmodest_dbus_client_delete_message):
1821 Implement deletion of messages (Client side).
1823 (modest_search_hit_free),
1824 (modest_search_hit_list_free):
1825 Utility functions to free the result hits.
1827 * src/dbus_api/modest-dbus-api.h:
1828 * src/dbus_api/modest-dbus-callbacks.c:
1829 (on_delete_message),
1830 (modest_dbus_req_handler):
1831 Implement deletion of messages (Server side).
1833 * tests/dbus_api/test_search.c: (main):
1836 * tests/dbus_api/Makefile.am:
1837 * tests/dbus_api/test_delete_message:
1838 Add little test for the message deletion logic
1840 2007-06-03 Armin Burgmeier <armin@openismus.com>
1842 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1843 when the operation queue was not empty. projects.maemo.org bug
1846 2007-06-03 Armin Burgmeier <armin@openismus.com>
1848 * src/widgets/modest-account-view.c
1849 (on_account_default_toggled): Toggle default account column
1850 explicitely instead of waiting for gconf notification (which is
1851 currently ignored). This should fix projects.maemo.org bug NB#56910
1852 for now. It should probably be removed when gconf notifications are
1855 2007-06-03 Christian Kellner <ckellner@openismus.com>
1857 * libmodest-dbus-client/libmodest-dbus-client.c:
1858 Removed debugging spew.
1860 * src/dbus_api/modest-dbus-callbacks.c:
1861 Added debugging info.
1863 * src/modest-search.c:
1864 (modest_search_all_accounts):
1865 Use tny_account_store_get_accounts () on the account store
1866 to get all accounts which is the way to get all accounts.
1868 * tests/dbus_api/test_search.c: (main):
1869 Make it possible to supply the search term on the command line.
1871 2007-06-03 Christian Kellner <ckellner@openismus.com>
1873 * libmodest-dbus-client/libmodest-dbus-client.c:
1874 * libmodest-dbus-client/libmodest-dbus-client.h:
1875 Implement searching for mesages over raw dbus. (Client side)
1877 * src/dbus_api/Makefile.am:
1878 * src/dbus_api/modest-dbus-api.h:
1879 * src/dbus_api/modest-dbus-callbacks.c:
1880 * src/dbus_api/modest-dbus-callbacks.h:
1881 Search framework (Server side). Also implement on_idle_open_message().
1883 * src/maemo/modest-platform.c: (modest_platform_init):
1884 Prepare for raw dbus/osso rpc interaction.
1886 * src/modest-search.h:
1887 Changed minsize from unspecific guint to guint32.
1889 * src/modest-search.c:
1891 Added strange hack which magically made tnymail work.
1893 (modest_search_folder),
1894 (modest_search_account),
1895 (modest_search_all_accounts):
1896 Implement helper functions to search all accounts, specific account
1899 * tests/dbus_api/Makefile.am:
1900 * tests/dbus_api/test_open_message.c:
1901 Read url to open from commandline.
1903 * tests/dbus_api/test_search.c:
1904 Implement small test for dbus search stuff
1906 2007-06-02 Armin Burgmeier <armin@openismus.com>
1908 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1909 include account type and account title. This fixes projects.maemo.org
1912 * src/maemo/modest-account-view-window.c: Set a title for the window.
1914 2007-06-02 Armin Burgmeier <armin@openismus.com>
1916 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1917 incoming and outgoing server name based on email address and server
1918 types as long as the names have not been edited manually. This fixes
1919 projects.maemo.org bug NB#58671.
1921 2007-06-02 Armin Burgmeier <armin@openismus.com>
1923 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1924 server type cannot be changed in future to the incoming details page
1925 when creating an account. This fixes projects.maemo.org bug NB#59029.
1927 2007-06-02 Armin Burgmeier <armin@openismus.com>
1929 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1930 and assigned max width chars so that they wrap instead of being
1931 truncated. Fixes projects.maemo.org bug NB#56126.
1933 2007-06-02 Armin Burgmeier <armin@openismus.com>
1935 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1936 introductory note to the connection specific smtp servers dialog, as
1937 section 8.12 of the email UI specification requires. This fixes
1938 projects.maemo.org bug NB#59212.
1940 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1943 Check for running mail operations, and offer to cancel them, as per the UI
1944 spec. This fixes projects.maemo.org bug NB#59041 .
1945 However, I suspect that tinymail may still use the network connection
1946 in ways that we cannot detect or cancel. But it should at least adapt to
1947 changes fairly well.
1949 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1951 * src/modest-tny-account-store.c: (recreate_all_accounts),
1952 (get_cached_accounts), (get_server_accounts): Do more sensible
1953 ref-counting of the temporarily-cached outbox accounts list. This seems
1954 to fix a crash when entering the password when the password was wrong.
1956 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1958 * src/gnome/modest-main-window.c: (connect_signals):
1959 * src/modest-tny-account-store.c: (get_password),
1960 (modest_tny_account_store_alert): Added comments and clues and
1961 commented-out code about how we currently fail to deal with connection
1962 errors and wrong passwords, and how we should.
1964 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1966 * src/widgets/modest-retrieve-combo-box.c:
1967 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1968 This fixes projects.maemo.org bug NB#58472 .
1970 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1972 * src/maemo/easysetup/modest-easysetup-wizard.c:
1973 (create_page_complete_easysetup):
1974 (create_page_complete_custom): Correct the last commit,
1975 putting the correct sentences in the correct pages.
1977 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1979 * src/maemo/easysetup/modest-easysetup-wizard.c:
1980 (create_page_complete_custom): Show the second sentence of text
1981 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1984 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1987 Set the leave-on-server conf key by default. This fixes
1988 projects.maemo.org bug NB#59258 .
1990 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/modest-account-view-window.c:
1993 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1994 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1997 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/easysetup/modest-easysetup-wizard.c:
2000 (create_caption_new_with_asterisk):
2001 * src/maemo/modest-account-settings-dialog.c:
2002 (create_caption_new_with_asterisk):
2003 Uncomment the code to add the asterisk, because they are no longer in the
2004 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2005 (update_incoming_server_title): Add an asterisk here too.
2007 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/modest-maemo-global-settings-dialog.c:
2010 (current_connection): Check that we are even connected before trying to
2011 get the current connection name, to prevent a warning.
2013 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2014 Change the comments because tny_maemo_conic_device_connect() is now meant to
2016 * src/modest-mail-operation.c:
2017 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2018 make sure we have a connection and fail if we can't connect.
2020 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/modest-main-window.c:
2023 (on_account_store_connecting_finished): Do not try to get the
2024 connection ID if we are not really connected. I am surprised that
2025 this signal handler is called when we are not connected.
2027 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-error.h:
2030 * src/modest-ui-actions.c:
2031 (modest_ui_actions_get_msgs_full_error_handler):
2032 Renamed an enum, added comments, added an enum
2033 for retrieve-limit errors.
2035 * src/modest-mail-operation.c: (foreach_add_item),
2036 (internal_folder_observer_update), (update_account_thread),
2037 (modest_mail_operation_get_msgs_full):
2038 (modest_mail_operation_update_account),
2039 Added comments about how this works, and some code that should
2040 (but does not) check the retrieve-limit. See the TODO comment.
2042 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2045 Initialize help_id to fix the build. Warnings are good.
2047 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2049 * src/widgets/modest-hbox-cell-renderer.c:
2050 (modest_hbox_cell_renderer_append):
2051 * src/widgets/modest-vbox-cell-renderer.c:
2052 (modest_vbox_cell_renderer_append):
2053 Fix the last commit by doing an extra ref.
2055 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2057 * src/widgets/modest-hbox-cell-renderer.c:
2058 (modest_hbox_cell_renderer_append):
2059 * src/widgets/modest-vbox-cell-renderer.c:
2060 (modest_vbox_cell_renderer_append):
2061 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2062 to fix the build with Maemo Bora.
2063 However, there seems to be a remaining crash, probably due to reference
2066 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-tny-account.c:
2069 (modest_tny_account_new_for_local_folders):
2070 Use hildon_file_system_info_async_new() to get a better name for
2071 the memory card account, setting it as the account name.
2072 The timing seems to work, but this is probably
2073 not the best place to do this. See the TODO comment.
2074 * src/maemo/modest-main-window.c: (create_details_widget):
2075 * src/widgets/modest-folder-view.c: (text_cell_data):
2076 Use the tny account name instead of hardcoding a name.
2078 2007-05-30 Christian Kellner <ckellner@openismus.com>
2080 * src/modest-search.c: (modest_search):
2081 Correctly set part_search_func even if we have already parsed
2082 the query and thus a valid OgsTextSearcher object.
2084 2007-05-30 Christian Kellner <ckellner@openismus.com>
2087 Search and check for libogs.
2090 Incooparte the ogs build env.
2092 * src/modest-mime-part-search-stream.c:
2093 * src/modest-mime-part-search-stream.h:
2094 Removed since we do the real searching now in modest-search.c.
2096 * src/modest-search.c:
2097 * src/modest-search.h:
2098 Implement support for ogs. We use that if available and requested
2099 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2100 should now handle the corner case when the search term is spread
2101 across multiple reads.
2102 Also the logic in modest_search () was corrected to search all
2103 requested fields until one is found.
2105 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2109 * src/modest-init.h:
2110 * src/modest-init.c: Made modest_init_local_folders() take a
2111 path and be public so we can iniitialize maildir folders on
2114 * src/modest-local-folder-info.h:
2115 * src/modest-local-folder-info.c:
2116 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2118 * src/modest-tny-account.c:
2119 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2120 still means the standard local-folders path on the local volume.
2122 * src/modest-tny-account-store.c:
2123 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2124 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2125 all accounts when that happens.
2126 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2127 this too, so it shows up in the treeview.
2129 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/modest-maemo-global-settings-dialog.c:
2132 (current_connection):
2133 * src/widgets/modest-global-settings-dialog.c:
2134 (current_connection_default):
2135 Use the enum values instead of 0, 1 and -1,
2136 to make the code clearer.
2138 * src/modest-account-mgr-helpers.c:
2139 (modest_account_mgr_get_connection_specific_smtp): Make this code
2142 * src/modest-runtime.h:
2143 * src/modest-runtime.c:
2144 Added modest_runtime_remove_all_send_queues().
2145 * src/maemo/modest-main-window.c:
2146 (on_account_store_connecting_finished): Recreate the send queues,
2147 using the appropriate transport accounts for this new connection.
2148 Some futher adapting might be needed if the old send queues are not
2149 automatically stopped at this point.
2151 * src/modest-tny-account-store.c: (get_server_accounts):
2152 Create the connection-specific transport accounts, so that they can
2153 be found later by their ID.
2155 * src/modest-tny-account.h:
2156 * src/modest-tny-account.c:
2157 Added modest_tny_account_new_from_server_account_name().
2158 modest_tny_account_new_from_server_account(): Do not create the
2159 send queues here, because they will be
2160 recreated anyway when the connection changes for the first time.
2162 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-local-folder-info.h:
2165 * src/modest-local-folder-info.c:
2166 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2167 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2168 tbox_folder): Take a modest account name instead of a server TnyAccount,
2169 so we can have per-modest-account rather than per-transport-account
2171 We must make sure that we change or recreate the exisitng send queues
2172 when the connection changes for connection-specific transport accounts.
2174 * src/modest-tny-account-store.c:
2175 (create_per_account_local_outbox_folders): Create outboxed per modest
2176 account, not per transport account.
2178 * src/modest-tny-account.h:
2179 * src/modest-tny-account.c:
2180 (modest_tny_account_get_special_folder): For outboxes, get the
2181 parent modest account name. The account is ignored for other folders.
2182 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2183 modest account name rather than a server TnyAccount.
2185 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2187 * src/modest-tny-account.c:
2188 (modest_tny_account_new_from_server_account):
2189 Call modest_runtime_get_send_queue() immediately after creating transport
2190 accounts, so that they start trying to send email from the outbox as soon
2191 as possible at startup. This is probably what we want.
2193 * src/modest-mail-operation.c: (update_account_thread):
2194 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2195 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2196 * src/modest-tny-send-queue.h:
2197 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2198 (modest_ui_actions_on_send):
2199 Added comments about how sending works, though it needs some more work.
2201 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2203 * src/modest-tny-account.c:
2204 (modest_tny_account_get_special_folder): Add TODO because this fails when
2205 the network is busy.
2206 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2207 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2208 Do not try to show this window when there is no active account. The UI
2209 specs does not tell us what to do in this case.
2211 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/Makefile.am:
2216 * src/widgets/Makefile.am: Some dist fixes.
2218 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/modest-connection-specific-smtp-window.c:
2221 (on_button_edit): Make the code clearer, to prevent a double free.
2223 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/modest-account-settings-dialog.c:
2226 (modest_account_settings_dialog_set_account_name),
2227 Check the connection-specific smtp servers checkbox if there are any.
2229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2230 (modest_connection_specific_smtp_edit_window_init):
2231 Start with a suitable port number.
2233 * src/modest-account-mgr-helpers.h:
2234 * src/modest-account-mgr-helpers.c: Added
2235 modest_account_mgr_get_has_connection_specific_smtp().
2237 (modest_account_mgr_set_connection_specific_smtp),
2238 (modest_account_mgr_remove_connection_specific_smtp),
2239 (modest_account_mgr_get_has_connection_specific_smtp),
2240 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2241 connection-specific smtp server accounts in the account, rather than
2242 the server account conf dir.
2244 This fixes bug projects.maemo.org bug NB#58263 .
2246 * src/modest-tny-account-store.c:
2247 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2248 if there are no server accounts yet, to prevent an infinite loop when there
2249 are no accounts. Document that one must be called before the other.
2251 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-account-mgr-helpers.c:
2254 (modest_account_mgr_get_default_account): Make sure that at least
2255 one account is always the default, if there are any enabled accounts.
2256 This is just a sanity check that shouldn't be necessary.
2258 * src/modest-account-mgr-priv.c:
2259 (_modest_account_mgr_account_from_key): Unescape the conf key to
2260 get the real account name. For instance, this is an issue if a space
2261 was in the account name, which can happen because the account name
2262 is generated from the display name.
2263 (_modest_account_mgr_get_account_keyname): Always escape the
2265 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2266 Unescape the conf keys to get the real account names.
2268 For instance, previously the is-default radio button in the accounts
2269 list was not checked for any accounts at first. This fixes that,
2270 and might fix several similar bugs.
2272 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2275 Removed some debug printfs.
2277 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2279 Modest on-disk outbox directories are now here, for instance:
2280 $HOME/.modest/outboxes/<account-id-1>/outbox
2281 $HOME/.modest/outboxes/<account-id-2>/outbox
2283 $HOME/.modest/local-folders/outbox
2284 so we can have a separate outbox for each account.
2285 But they are shown as one outbox in the GtkTreeView, by using a
2286 TnyMergeFolder in a ModestTnySimpleFolderStore.
2289 * src/modest-tny-simple-folder-store.c:
2290 * src/modest-tny-simple-folder-store.h:
2291 Added ModestTnySimpleFolderStore, used to contain folders from
2292 other folder stores, such as other accounts.
2294 * src/modest-tny-outbox-account.h:
2295 * src/modest-tny-outbox-account.c:
2296 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2297 used for the per-account local outbox folders.
2299 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2300 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2301 only use this (internally) now for the non-outbox local folders.
2303 * src/modest-init.h:
2304 * src/modest-init.c: Added modest_init_one_local_folder(), for
2305 setting up the directory structure for each local folder.
2307 * src/modest-local-folder-info.c:
2308 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2309 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2311 * src/modest-local-folder-info.h:
2312 * src/modest-tny-account-store.c: (on_account_removed),
2313 (on_account_changed), (create_per_account_local_outbox_folders),
2314 (get_server_accounts), (modest_tny_account_store_get_accounts),
2315 (modest_tny_account_store_get_tny_account_by_account),
2316 (modest_tny_folder_store_is_virtual_local_folders):
2318 * src/modest-tny-account.h:
2319 * src/modest-tny-account.c:
2320 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2321 to create an on-disk per-account local outbox folder for each
2323 (create_per_account_local_outbox_folders): Create a local outbox folder
2324 for each transport account.
2325 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2326 for all local folders.
2328 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2329 instead of using g_object_get/set() directly. It is clearer.
2331 (modest_tny_folder_store_get_message_count),
2332 (modest_tny_folder_store_get_local_size
2333 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2334 because we now use these with non-acount folder stores.
2336 (modest_tny_account_get_special_folder),
2337 (modest_tny_account_new_from_server_account),
2338 (modest_tny_account_new_from_account):
2339 (recurse_folders): Adjust to the new outbox system.
2341 * src/modest-tny-folder.h:
2342 * src/modest-tny-folder.c:
2343 (modest_tny_folder_is_local_folder),
2344 (modest_tny_folder_get_local_folder_type),
2345 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2347 * src/widgets/modest-main-window.h:
2348 * src/maemo/modest-main-window.c: (create_details_widget),
2349 (modest_main_window_set_contents_style): Show details for any folder store,
2352 (modest_tny_folder_get_rules):
2353 Remove the const. C does not support constness enough for this.
2355 * src/modest-ui-actions.c:
2356 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2357 make all outboxes appear as one, in the usual local-folders tree node.
2359 (set_active_account_from_tny_account),
2360 (modest_ui_actions_on_folder_selection_changed):
2361 * src/widgets/modest-folder-view.c: (text_cell_data),
2362 (icon_cell_data), (filter_row),
2363 (add_account_folders_to_merged_folder),
2364 (add_account_folders_to_simple_folder_store), (),
2365 (get_cmp_rows_type_pos), (cmp_rows),
2366 (modest_folder_view_set_account_id_of_visible_server_account):
2367 Adjust to the new outbox system, using generic folder stores and folders
2368 in the GtkTreeModel.
2370 2007-05-23 Christian Kellner <ckellner@openismus.com>
2372 * src/modest-mail-operation.c:
2373 (modest_mail_operation_update_account):
2374 Use info->max_size instead of unintialized local var [small
2375 build fix]. (Added TODO to review that change since I don't
2378 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2380 * libmodest-dbus-client/libmodest-dbus-client.c:
2381 (libmodest_dbus_client_compose_mail): function added
2382 * src/dbus_api/modest-dbus-api.h:
2383 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2384 (on_compose_mail): Implementation of the SendAsMail functionality
2386 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2388 * src/modest-account-mgr.c:
2389 (modest_account_mgr_add_server_account): Set the secure-connection
2390 conf key for transport accounts as well as store accounts. I don't know
2391 why the if was there. For instance, this makes sure that we use SSL
2392 for the gmail preset from the easysetup wizard.
2394 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2396 * src/gnome/modest-main-window.c:
2397 (on_account_store_connecting_finished), (connect_signals):
2398 * src/maemo/modest-main-window.c:
2399 (on_account_store_connecting_finished), (connect_signals),
2400 (modest_main_window_new):
2401 Handle TnyAccountStore::connecting-finished instead of
2402 TnyDevice::connection-changed, because we cannot actually perform
2403 operations on accounts until TnyAccountStore has itself responded to
2404 the TnyDevice::connection-changed signal. This prevents a GError from
2406 Do not try to update at startup, because we (at least on scratchbox)
2407 already do an update at startup when the device goes online.
2408 This prevents a GError from tinymail.
2409 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2410 Added TODO about stopping simultaneous operations.
2412 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2415 * src/modest-mail-operation-queue.c:
2416 (modest_mail_operation_queue_remove):
2417 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2418 about where they happened.
2420 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2422 * src/modest-ui-actions.c:
2423 (modest_ui_actions_on_password_requested): Make sure that the remember
2424 output parameter is always TRUE.
2426 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2429 Show a OK/Cancel dialog if the error is a question, though we still do not
2430 know anything more about what we are asking the user.
2431 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2432 Fix an uninitialized variable (helper). This is a logic error, however.
2434 2007-05-21 Christian Kellner <ckellner@openismus.com>
2436 * src/modest-search.h:
2437 Correct bit shifting in the ModestSearchFlags enum.
2439 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2441 * src/modest-tny-account.c:
2442 (modest_tny_account_new_from_server_account): Do not use the lsub and
2443 check-all hard-coded IMAP options when using POP.
2445 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2447 * src/modest-tny-account.c:
2448 (modest_tny_account_new_from_server_account):
2449 Use NULL for the secure-auth method for POP when Password auth has been
2450 specified by the user, as we already do for IMAP. "auth=Login" causes
2451 an error from camel or the server.
2453 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2455 * src/maemo/modest-account-settings-dialog.c:
2456 (create_page_account_details),
2457 (modest_account_settings_dialog_set_account_name):
2458 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2459 for the leave-on-server checkbox, rathr than just the checkbox, when
2460 the protocol is not POP.
2462 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2464 * src/widgets/modest-account-view.c:
2465 * src/widgets/modest-account-view.h:
2466 Added modest_account_view_select_account() which will be useful later
2467 to asynchronously re-select the edited account.
2469 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/modest-account-settings-dialog.c:
2472 (modest_account_settings_dialog_set_account_name):
2473 Automatically choose the port numbers based on the secure authentication
2474 methods, if they have not been chosen before.
2475 This fixes projects.maemo.org bug NB#56273 .
2477 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2479 * src/maemo/modest-main-window-ui.h:
2480 * src/modest-ui-actions.c:
2481 * src/modest-ui-actions.h:
2482 Connect the Tools/SMTP Servers menu item to
2483 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2484 SMTP servers dialog, as in the UI specification and saves changes when it
2485 is closed. This fixed projects.maemo.org bug NB#56305 .
2487 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2489 * src/maemo/modest-connection-specific-smtp-window.c:
2490 (modest_connection_specific_smtp_window_init):
2491 Use gtk_window_set_default_size() to make this window big enough, so
2492 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2494 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2496 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2498 (modest_connection_specific_smtp_edit_window_init),
2499 Do not try to connect to a combobox signal before the combobox exists.
2500 This fixes the cras in projects.maemo.org bug NB#56288 .
2501 (modest_connection_specific_smtp_edit_window_get_settings):
2502 Remove the server_account_name parameter which was being checked for NULL
2503 though it was not used.
2505 * src/maemo/modest-connection-specific-smtp-window.c:
2506 (modest_connection_specific_smtp_window_fill_with_connections),
2507 (on_button_edit), (modest_connection_specific_smtp_window_init):
2508 Correct the number of treemodel columns to prevent a warning.
2509 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2510 libconic does not work.
2512 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2514 * src/modest-tny-account.c:
2515 (modest_tny_account_new_from_server_account):
2516 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2517 SMTP when "None" was chosen by the user. However, with my SMTP server that
2518 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2521 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2524 to explain the memory management issue with the ID in the ModestPair.
2526 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2527 (add_sending_page), (modest_account_assistant_finalize):
2528 * src/gnome/modest-gnome-global-settings-dialog.c:
2529 (create_updating_page), (create_composing_page):
2530 * src/gnome/modest-msg-edit-window.c: (get_transports),
2531 (init_window), (modest_msg_edit_window_finalize),
2532 (modest_msg_edit_window_get_msg_data):
2533 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2534 * src/gnome/modest-transport-widget.c:
2535 (modest_transport_widget_finalize), (smtp_configuration):
2536 * src/maemo/modest-maemo-global-settings-dialog.c:
2537 (create_updating_page), (create_composing_page):
2538 * src/maemo/modest-msg-edit-window.c: (get_transports),
2539 (init_window), (modest_msg_edit_window_finalize),
2540 (modest_msg_edit_window_get_msg_data),
2541 (modest_msg_edit_window_free_msg_data):
2542 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2543 (modest_store_widget_finalize):
2544 * src/maemo/modest-transport-widget.c:
2545 (modest_transport_widget_finalize), (smtp_configuration):
2546 * src/modest-main.c: (send_mail):
2547 * src/widgets/modest-combo-box.h:
2548 * src/widgets/modest-global-settings-dialog-priv.h:
2549 * src/widgets/modest-global-settings-dialog.c:
2550 (modest_global_settings_dialog_finalize):
2551 * src/widgets/modest-msg-edit-window.h:
2552 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2553 as long as the combo box, to prevent use of freed memory for the ID.
2555 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2557 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2558 get_accounts(), to make this clearer. Do not check for the enabled gconf
2559 key, because we do not use this for server accounts (at least, not yet).
2560 This allows us to send email again.
2562 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2564 * src/maemo/modest-platform.c:
2565 (on_modest_conf_update_interval_changed), (modest_platform_init):
2566 Only respond to this particular key change. All these strcmp()s cannot be
2569 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2571 * src/maemo/modest-maemo-global-settings-dialog.c:
2572 (current_connection): Prevent a crash in scratchbox when
2573 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2574 * src/maemo/modest-platform.c:
2575 (on_modest_conf_update_interval_changed), (modest_platform_init):
2576 Get the update interval from gconf and reset it when the gconf key changes.
2578 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2580 * src/modest-protocol-info.c:
2581 * src/modest-protocol-info.h: Adde enum-specific get functions,
2582 instead of using a ModestProtocolType enum parameter.
2584 * src/gnome/modest-account-assistant.c:
2585 * src/gnome/modest-store-widget.c:
2586 * src/gnome/modest-store-widget.h:
2587 * src/gnome/modest-transport-widget.c:
2588 * src/gnome/modest-transport-widget.h:
2589 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2590 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2591 * src/maemo/easysetup/modest-easysetup-wizard.c:
2592 * src/maemo/modest-account-settings-dialog.c:
2593 * src/maemo/modest-account-settings-dialog.h:
2594 * src/maemo/modest-store-widget.c:
2595 * src/maemo/modest-store-widget.h:
2596 * src/maemo/modest-transport-widget.c:
2597 * src/maemo/modest-transport-widget.h:
2598 * src/modest-account-mgr-helpers.c:
2599 * src/modest-account-mgr-helpers.h:
2600 * src/modest-account-mgr.c:
2601 * src/modest-account-mgr.h:
2602 * src/modest-tny-account.c:
2603 * src/modest-tny-folder.c:
2604 * src/widgets/modest-account-view.c:
2605 * src/widgets/modest-retrieve-combo-box.c:
2606 * src/widgets/modest-retrieve-combo-box.h:
2607 * src/widgets/modest-secureauth-combo-box.c:
2608 * src/widgets/modest-serversecurity-combo-box.c:
2609 * src/widgets/modest-serversecurity-combo-box.h:
2610 * tests/check_account-mgr.c:
2611 Use the specific functions, and use the re-renamed enum values for GNOME too.
2613 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2615 * src/modest-pair.h:
2616 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2617 so we can get the second based on the first.
2619 * src/maemo/modest-account-settings-dialog.h:
2620 * src/maemo/modest-account-settings-dialog.c:
2621 Added get_supported_secure_authentication_methods(), though it is mostly
2622 commented-out for now until the necessary API is committed to tinymail.
2623 (modest_account_settings_dialog_set_account_name),
2624 (save_configuration): Request the supported authentication methods from the
2625 server, so we can choose a working method.
2627 * src/modest-tny-account-store.h:
2628 * src/modest-tny-account-store.c:
2629 (modest_tny_account_store_get_session): Rename from
2630 tny_account_store_get_session().
2632 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2634 * src/modest-protocol-info.h: Split the ModestProtocol enum
2635 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2636 There was no need to have these unrelated values in one enum.
2638 * src/: many files: Adapted to changed enum. This makes the code a bit
2639 clearer, and the compiler could catch some errors.
2641 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2643 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2644 Show the detailed internal camel error message when an error happens
2645 during the configuration, so that our testers can give us more clues.
2646 For instance, in projects.maemo.org bug NB#56910 .
2648 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2650 * src/modest-tny-account.c:
2651 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2652 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2654 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2656 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2657 * src/maemo/modest-account-settings-dialog.c:
2658 (modest_account_settings_dialog_set_account_name),
2659 (save_configuration): For the incoming secure authentication checkbox,
2660 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2661 the UI specification. PLAIN does not seem to be supported for most IMAP
2662 servers anyway, and I am not sure what it would mean.
2663 However, we probably need to discover which of the secure-authentication
2664 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2665 * src/modest-account-mgr-helpers.c:
2666 (modest_account_mgr_get_server_account_data):
2668 * src/modest-tny-account.c:
2669 (modest_tny_account_new_from_server_account):
2670 Use tny_account_set_mech() to set secure-authentication methods,
2671 with some special-casing for IMAP, based on my observations of how
2674 * src/modest-account-mgr-helpers.h:
2675 * src/modest-account-mgr.c:
2676 * src/modest-defs.h: Comment that the URI is only used for local folders.
2678 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2680 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2681 parameter const, just to be neat.
2682 * src/modest-text-utils.c: (modest_text_utils_inline):
2683 End g_strconcat() with NULL, as its documentation says. This is almost
2684 certainly the cause of my crash at startup on the device. Interestingly,
2685 valgrind doesn't tell us about these errors.
2687 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2689 * scripts/build-packages: Added more precise comments about how to use
2690 this script, though I still get this error:
2691 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2692 error building tinymail
2694 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/modest-main-window.c: (on_account_update):
2697 Very slight cleanup, hoping to make it simpler to discover what causes
2698 a crash here sometimes.
2700 * src/modest-tny-account.c:
2701 (modest_tny_account_new_from_server_account): Set the port. Added
2702 comments about the options and a TODO comment because I need to find out
2703 how to specify the secure authentication method.
2705 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2707 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2708 changed CFlags paths form modest to libmodest
2710 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-account-mgr-helpers.c:
2713 (modest_account_mgr_get_server_account_data),
2714 (modest_account_mgr_free_server_account_data):
2715 * src/modest-account-mgr-helpers.h:
2716 * src/modest-account-mgr.c:
2717 (modest_account_mgr_add_server_account):
2718 * src/modest-defs.h:
2719 * src/modest-tny-account.c:
2720 (modest_tny_account_new_from_server_account):
2721 Determine the options for tny_camel_account_add_option() here,
2722 based on the settings, rather than storing them directly in gconf.
2724 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2727 Show a more friendly error dialog now that we expect (from the tinymail
2728 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2730 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/modest-main-window.c: (on_account_update): Check that
2733 account_name is not NULL, to prevent a crash at startup that I am
2734 seeing on the N800. I do wonder why it is NULL.
2736 * src/maemo/easysetup/modest-easysetup-wizard.c:
2737 (create_page_user_details):
2738 * src/maemo/modest-account-settings-dialog.c:
2739 (create_page_user_details), (create_page_outgoing):
2740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2741 (modest_connection_specific_smtp_edit_window_init):
2742 * src/modest-ui-actions.c:
2743 (modest_ui_actions_on_password_requested):
2744 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2745 might do something useful with the on-screen keyboard.
2747 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2749 * src/maemo/modest-main-window.c: (on_account_update):
2750 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2751 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2753 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-tny-account-store.c: (on_account_changed):
2756 Correct the signature of this signal handler.
2758 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2761 Show a HildonNote instead of a GtkDialog for Maemo.
2763 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2765 * src/widgets/modest-account-view.h:
2766 * src/widgets/modest-account-view.c: (on_account_changed),
2767 (on_account_removed). Added a boolean flag, set/unset by
2768 modest_account_view_block_conf_updates(),
2769 modest_account_view_unblock_conf_updates() to prevent unnecessary
2770 updates, but this is not very useful because the gconf notifications are
2771 so delays (maybe only on Maemo Bora).
2772 So auto-updating is turned off, and these functions do an explicit
2773 update when necessary.
2774 However, something else is still doing too much work when adding/removing
2775 accounts, probably in another part of the application.
2777 * src/maemo/modest-account-view-window.c:
2778 (on_delete_button_clicked), (on_edit_button_clicked),
2779 (on_new_button_clicked): Use the new functions.
2781 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2783 * src/modest-account-mgr-helpers.c:
2784 (modest_account_mgr_set_first_account_as_default):
2785 Sort the list of names alphabetically-by-title, so we choose the first one
2787 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2788 alphabetically by the title.
2790 This fixes projects.maemo.org bug NB#56418 .
2792 * src/modest-account-mgr-priv.c:
2793 (_modest_account_mgr_account_from_key):
2794 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2795 avoid a valgrind error, and possible random behaviour.
2797 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2799 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2800 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2801 tinymail documentation to say that this can be expected.
2802 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2803 pretty, and should not happen, but I would prefer to know when it does.
2805 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2807 * configure.ac: When using the older hildon version, probably on Bora,
2808 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2810 * src/widgets/modest-attachment-view.c:
2811 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2814 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2816 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2817 Implemented the prototype. Can be tested with
2818 tests/dbus_api/test_open_message:
2820 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-tny-account-store.c:
2823 (modest_tny_account_store_instance_init), (get_password):
2824 * src/modest-ui-actions.c:
2825 (modest_ui_actions_on_password_requested):
2826 Do not store the password in gconf, because this function is called
2827 for non-remembered passwords. Actually use the cached (in the hash map)
2828 password instead of releasing it.
2829 The password will now not be remembered if it is asked via the protected
2830 password dialog, as per the UI spec.
2832 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2834 * src/modest-defs.h:
2835 * src/modest-account-mgr-helpers.h:
2836 * src/modest-account-mgr-helpers.c:
2837 Added modest_server_account_get_username_has_succeeded(),
2838 modest_server_account_set_username_has_succeeded().
2839 (modest_server_account_set_username),
2840 Reset the has-succeeded flag if the username changes.
2842 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2843 * src/maemo/modest-connection-specific-smtp-window.c:
2844 (modest_connection_specific_smtp_window_save_server_accounts):
2845 Use modest_server_account_set_username() instead of using
2846 modest_conf_set_string() directly, so that the has-succeeded flag is always
2849 * src/modest-ui-actions.c:
2850 (modest_ui_actions_on_password_requested): Dim the username entry if
2851 the username has ever worked, as per the UI spec.
2853 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2855 * src/modest-tny-account-store.c: (get_password):
2856 * src/modest-ui-actions.c:
2857 (modest_ui_actions_on_password_requested):
2858 Allow the username to be changed too, though there is more work to
2859 be done on exactly how this behaves.
2861 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2863 * src/modest-account-mgr-helpers.h:
2864 * src/modest-account-mgr-helpers.c:
2865 Added modest_account_mgr_get_display_name(),
2866 modest_server_account_get_username(),
2867 modest_server_account_set_username(),
2868 modest_server_account_set_password(),
2869 modest_server_account_get_hostname() functions so we do not need to
2870 use the conf API directly.
2872 * src/maemo/modest-main-window.c: (connect_signals):
2873 Actually connect ot the ModestAccountStore::request-password signal,
2874 so that we show the dialog when the password is requested by Tinymail,
2875 for isntance if it is empty.
2877 * src/modest-marshal.list:
2878 * src/modest-tny-account-store.c:
2879 (modest_tny_account_store_class_init), (get_password),
2880 (modest_tny_account_store_alert):
2881 * src/modest-tny-account-store.h:
2882 * src/modest-ui-actions.h:
2883 * src/modest-ui-actions.c:
2884 (modest_ui_actions_on_password_requested):
2885 Change the signal parameters, so it is obvious that we are providing
2886 the non human-readable server name, and receiving both the username
2887 and password, though changing of the username is not yet implemented.
2888 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2889 for the GNOME version.
2891 This should fix the projects.maemo.org bug NB#56209, though it does not
2892 work on Bora, because the gconf_client_get() for the password fails
2893 immediately after we save it with gconf_client_set().
2895 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2898 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2899 caused an undefined symbol error:
2900 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2902 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2904 * src/modest-tny-account-store.c:
2905 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2906 using a GError instead of a string message, so we can translate it in
2909 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/modest-address-book.c:
2912 (modest_address_book_check_names):
2913 * src/maemo/modest-msg-view-window.c:
2914 (modest_msg_view_window_clipboard_owner_change):
2915 * src/modest-init.c: (modest_init_init_ui):
2916 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2917 (update_folders_cb), (modest_mail_operation_update_account):
2918 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2919 (modest_ui_actions_on_msg_attachment_clicked),
2920 (modest_ui_actions_on_msg_recpt_activated):
2921 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2922 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2923 (modest_msg_view_search_next):
2924 * src/widgets/modest-recpt-editor.c:
2925 (modest_recpt_editor_on_button_release_event),
2926 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2927 g_message(). At this point we should only be seeing interesting errors on
2928 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2930 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2932 (modest_wizard_dialog_force_title_update):
2933 * src/maemo/easysetup/modest-wizard-dialog.h:
2934 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2935 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2936 can update the title when appropriate. Otherwise the title is wrong if the
2937 pages are added after adding the notebook to the dialog.
2938 This must be a problem in HildonWizardDialog too.
2939 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2941 * src/maemo/easysetup/modest-easysetup-wizard.c:
2942 (create_subsequent_customsetup_pages),
2943 (create_subsequent_easysetup_pages):
2944 Call modest_wizard_dialog_force_title_update() so that the title is
2945 correct even with GTK+ < 2.10.
2946 This fixes projects.maemo.org bug NB#56145 .
2948 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/modest-platform.c:
2951 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2952 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2955 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2957 * src/widgets/modest-window.h:
2958 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2959 and modest_window_save_state(), which invokes it.
2961 * src/widgets/modest-window-mgr.h:
2962 * src/widgets/modest-window-mgr.c:
2963 Added modest_window_mgr_save_state_for_all_windows(), which calls
2964 the save_state vfunc on all registered windows, if implemented.
2966 * src/gnome/modest-msg-edit-window.c:
2967 * src/gnome/modest-msg-view-window.c:
2968 * src/maemo/modest-msg-edit-window.c:
2969 * src/maemo/modest-msg-view-window.c:
2970 * src/maemo/modest-main-window.c:
2971 Specify the existing save_settings functions as implementations of
2972 ModestWindow::save_state_func().
2974 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2975 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2976 enabling hibernation, for instance.
2978 We may need to do the same thing for restoring settings.
2981 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2983 * src/widgets/modest-window-mgr.c:
2984 * src/widgets/modest-window-mgr.h:
2985 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2986 modest_window_mgr_get_hibernation_is_prevented().
2988 * src/maemo/modest-main-window.c:
2989 (on_hildon_program_is_topmost_notify): Prevent hibernation
2990 (possible when the application goes to the background in the WM),
2991 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2993 * src/maemo/easysetup/modest-easysetup-wizard.c:
2994 (modest_easysetup_wizard_dialog_init):
2995 * src/maemo/modest-account-settings-dialog.c:
2996 (modest_account_settings_dialog_init):
2997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2998 (modest_connection_specific_smtp_edit_window_init):
2999 * src/maemo/modest-connection-specific-smtp-window.c:
3000 (modest_connection_specific_smtp_window_init):
3001 * src/maemo/modest-signature-editor-dialog.c:
3002 (modest_signature_editor_dialog_init):
3003 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3004 prevent hibernation while any of these account settings dialogs are open.
3006 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3008 * src/maemo/Makefile.am:
3009 * src/maemo/modest-osso-state-saving.c:
3010 * src/maemo/modest-osso-state-saving.h: Added
3011 modest_osso_load_state() and modest_osso_save_state() though they do
3012 nothing now. They should iterate through all the open windows and load/save
3014 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3015 save state when closing.
3017 * src/maemo/modest-main-window.c:
3018 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3019 Add a notification handler for the HildonProgram::is-topmost property,
3020 so we can allow hibernation when the application goes into the background.
3021 But we still need to detect when the accounts setup windows are open so
3022 we can stop hibernation when they are open.
3023 To do this, I also added the main window the HildonProgram. This might have
3024 other side-effects/benefits, and should maybe be done for other windows.
3026 * src/maemo/modest-osso-autosave-callbacks.h:
3027 * src/maemo/modest-osso-autosave-callbacks.c:
3028 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3029 though it does not do anything yet, and we might never need this to do
3030 anything. For instance, we already save drafts.
3032 * src/maemo/modest-platform.c: (modest_platform_init):
3033 Specify the libosso auto-save callback.
3035 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3037 * src/maemo/modest-platform.c:
3038 (modest_platform_set_update_interval):
3039 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3040 aparently stays valid between application instances, so we can use this
3041 to remove and reset it later. According to a maemo-developers email from
3044 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3046 * configure.ac: Depend on libalarm for Maemo.
3048 * src/dbus_api/modest-dbus-api.h:
3049 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3050 (on_send_receive), (modest_dbus_req_handler):
3051 Handle a SEND_RECEIVE D-Bus method.
3053 * libmodest-dbus-client/libmodest-dbus-client.c:
3054 (libmodest_dbus_client_send_and_receive):
3055 * libmodest-dbus-client/libmodest-dbus-client.h:
3056 Add C convenience functions for calling the new D-Bus method.
3058 * src/modest-platform.h:
3059 * src/gnome/modest-platform.c:
3060 * src/maemo/modest-platform.c:
3061 Added modest_platform_set_update_interval(), which uses the
3062 alarmd API on Maemo.
3063 (modest_platform_init),
3064 Call modest_platform_set_update_interval(), using a hard-coded
3065 interval for now (until the global settings dialog is implemented),
3066 though I am not sure that this makes sense yet.
3068 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3070 * src/dbus_api/modest-dbus-callbacks.c:
3071 (modest_osso_cb_hw_state_handler):
3072 * src/dbus_api/modest-dbus-callbacks.h:
3073 * src/maemo/modest-platform.c: (modest_platform_init):
3074 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3075 in case this has some effect on the ability for Maemo to ping the
3078 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3080 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3081 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3082 warning. It is probably a logic error, but I need to fix the build.
3084 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3086 * src/modest-account-mgr.h:
3087 * src/modest-account-mgr.c:
3088 (modest_account_mgr_account_names): Add a gboolean enabled_only
3089 parameter, so we can get lists of onlt the enabled accounts.
3091 (modest_account_mgr_add_account),,
3092 (modest_account_mgr_account_with_display_name_exists):
3093 * src/maemo/modest-msg-edit-window.c: (get_transports):
3094 * src/modest-account-mgr-helpers.c:
3095 (modest_account_mgr_set_first_account_as_default):
3096 * src/modest-init.c: (init_default_account_maybe):
3097 * src/modest-tny-account-store.c: (get_accounts):
3098 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3099 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3100 * tests/check_account-mgr.c: (START_TEST):
3101 Provide the extra parameter, as appropriate.
3103 * src/widgets/modest-account-view.c: (update_account_view):
3104 Do not show disabled accounts (meaning that there is no way to
3105 enable/disable accounts in the UI (the feature is not in our UI
3106 specification), so we can use this internally only to mark unfinished
3107 or temporary account data.
3109 * src/maemo/easysetup/modest-easysetup-wizard.c:
3110 (create_account): Add boolean enable parameter, so we can specify FALSE
3111 to create the temporary account.
3112 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3113 (on_before_next): When finishing, when there is a temporary account, just
3115 Also, use a timeout to delay the showing of the dialog until gconf is likely
3116 to return correct information, due to a maemo gconf bug that is fixed in
3117 osso 1.1, but not yet in Bora.
3118 However, the dialog stays on screen after it is destroyed.
3120 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3121 for invalid data when cancelling. Use a hildon note instead of a dialog
3122 to complain about invalid data. Do not show the account-saved note if the
3123 account is disabled (a temporary account that will not really be saved for use
3126 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3128 * src/modest-account-mgr-helpers.h:
3129 * src/modest-account-mgr-helpers.c:
3130 Added modest_account_mgr_unset_default_account(),
3131 Added modest_account_mgr_set_first_account_as_default().
3133 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3134 If it was the default account, unset the default account name.
3136 * src/maemo/modest-account-view-window.c:
3137 (on_delete_button_clicked): If it was the default account,
3138 set the first remaining account as the default instead.
3140 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3141 a NULL account or a NULL default account, to prevent a crash. This should
3142 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3145 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3147 * src/widgets/modest-recpt-editor.c:
3148 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3149 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3150 TODO comment for this. This fixes the build.
3152 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3153 be the best place for it. This will in future update all auto-update accounts,
3154 rather than just the current/default account, when that gconf key exists.
3155 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3156 if there are no accounts, before calling do_send_receive().
3157 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3159 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3160 * src/maemo/modest-main-window-ui.h:
3161 * src/maemo/modest-main-window.c: (on_connection_changed),
3162 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3163 directly, becaue the signal handler does more.
3165 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3167 * src/modest-account-mgr-helpers.c:
3168 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3169 for the case that the account does not exist.
3171 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3172 (equivalent to the modest account name) rather than the tinymail account name
3173 (equivalent to the modest account title - human readable) to get the account data.
3174 Check for null account data to prevent the crash, and add a TODO comment saying that
3175 this needs fixing because it is using the server account name instead of the account name.
3177 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3179 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3180 * src/maemo/modest-account-settings-dialog.c: (show_error),
3182 Use hildon_note_new_information() for informative and error messages,
3183 which seems to be expected for Maemo applications (no documentation that I know of
3184 says this). I am surprised that there is no distinction between info and error
3187 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3190 it is easy to find where this is used.
3192 * src/maemo/easysetup/modest-easysetup-wizard.c:
3193 (create_page_welcome), (create_page_account_details),
3194 (create_page_user_details), (create_page_complete_easysetup),
3195 (create_page_custom_incoming), (create_page_custom_outgoing),
3196 (create_page_complete_custom):
3197 * src/maemo/modest-account-settings-dialog.c:
3198 (create_page_account_details), (create_page_user_details),
3199 (create_page_incoming), (create_page_outgoing):
3200 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3201 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3202 (modest_connection_specific_smtp_edit_window_init):
3203 * src/maemo/modest-connection-specific-smtp-window.c:
3204 (modest_connection_specific_smtp_window_init):
3205 * src/maemo/modest-signature-editor-dialog.c:
3206 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3207 and scrolling policy as per the Email Application Layout Guide, if I have
3210 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3212 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3213 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3214 which were empty, because these vfuncs have been removed from TnyAccountStore.
3215 This fixes the build.
3217 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3219 * src/maemo/modest-main-window.c:
3220 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3221 showing/hiding it. Added TODO because it probably should not be NULL.
3222 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3223 because unnecessary g_warnings() make degugging difficult.
3225 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/modest-msg-edit-window.c:
3228 (modest_msg_edit_window_select_color),
3229 (modest_msg_edit_window_select_background_color): 2 const corrections and
3230 moving 2 #endifs before closing brackets, to fix the build.
3232 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3234 * src/maemo/easysetup/modest-easysetup-wizard.h:
3235 * src/maemo/easysetup/modest-easysetup-wizard.c:
3236 (modest_easysetup_wizard_dialog_finalize),
3237 (on_button_edit_advanced_settings), (create_page_complete_custom),
3238 (on_response), (create_account):
3239 Implement the Advanced Settings edit button, by saving the account information,
3240 for the Advanded Settings dialog to use directly from gconf, and removing it
3241 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3242 Bug #5533 in the projects.maemo.org bugzilla.
3244 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/modest-msg-view-window.c:
3247 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3248 when opening a message window.
3250 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3252 * src/maemo/easysetup/modest-easysetup-wizard.c:
3253 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3256 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3257 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3258 gconf settings. I probably added more checks than necessary, but that is safer.
3260 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3261 variable to fix the build, but this seems to be used when it is still NULL.
3263 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3265 * src/modest-platform.h:
3266 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3267 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3268 * src/modest-main.c: Implement this function so we can avoid using
3269 maemo-specific API from cross-platform code.
3271 * src/modest-tny-account-store.c:
3272 (get_smtp_specific_transport_account_for_open_connection):
3273 * src/modest-ui-actions.c: (check_for_connection),
3274 (modest_ui_actions_on_item_not_found):
3275 Use modest_platform_connect_and_wait() and put #idefs around other
3276 maemo-specific code, because only maemo currently has a way to
3277 identify connection names.
3279 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3281 * src/modest-tny-account-store.h:
3282 * src/modest-tny-account-store.c:
3283 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3284 the connection-specific SMTP server settings in the configuration.
3286 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3288 * src/maemo/modest-main-window.c: (on_connection_changed),
3290 * src/modest-main.c: (main), (start_ui), (send_mail):
3291 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3292 that is what is intended.
3294 * src/modest-ui-actions.c: (action_send), (action_receive),
3295 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3296 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3297 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3298 SMTP server is used when it is specified.
3300 (modest_ui_actions_on_send_receive):
3301 Check that a connection is open before proceeding.
3302 Receive and then send, instead of vice-versa, as per the specification.
3304 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3306 * src/modest-mail-operation.c:
3307 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3308 though I guess it should be something other than NULL.
3310 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3312 * src/maemo/easysetup/modest-easysetup-wizard.c:
3313 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3314 combo twice, to avoid an g_warning and to make it visible again.
3315 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3316 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3317 (already intended) dereference when detaching, because we then recreate the menu.
3318 But I am not sure why the warning was happening, and it is possible that this is a memory
3321 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3323 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3324 and uri_parse_mailto() utility functions.
3325 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3327 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3329 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3331 * src/dbus_api/modest-dbus-api.h:
3332 * src/dbus_api/modest-dbus-callbacks.c:
3333 Use an idle callback to execute the modest code in the application's own thread.
3334 Remove the helloworld example method.
3335 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3336 parsed, and the open-message method is not implemented because this is not yet implemented in
3338 * libmodest-dbus-client/libmodest-dbus-client.c:
3339 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3340 (libmodest_dbus_client_open_message):
3341 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3343 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3344 body without crashing.
3346 * tests/dbus_api/Makefile.am:
3347 * tests/dbus_api/test_mail_to.c:
3348 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3350 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3352 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3353 Added file to fix the build. Sorry.
3355 * src/dbus_api/Makefile.am:
3356 * src/dbus_api/modest-dbus-api.h:
3357 * src/dbus_api/modest-dbus-callbacks.h:
3358 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3359 (modest_dbus_req_handler):
3360 Put constants in a separate header so it can be reused by the
3361 client library, without duplication
3363 * libmodest-dbus-client/Makefile.am:
3364 * libmodest-dbus-client/libmodest-dbus-client.c:
3365 (libmodest_dbus_client_call_helloworld),
3366 (libmodfest_dbus_client_send_mail),
3367 (libmodfest_dbus_client_mailto),
3368 (libmodfest_dbus_client_open_message):
3369 * libmodest-dbus-client/libmodest-dbus-client.h:
3370 (Partly) Implement a send_mail D-Bus method.
3372 * tests/dbus_api/Makefile.am:
3373 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3374 the send_email D-Bus method.
3376 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3380 * libmodest-dbus-client/Makefile.am:
3381 * libmodest-dbus-client/libmodest-dbus-client.c:
3382 * libmodest-dbus-client/libmodest-dbus-client.h:
3383 * tests/dbus_api/Makefile.am:
3384 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3385 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3387 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3389 * src/maemo/easysetup/modest-easysetup-wizard.c:
3390 (create_page_account_details):
3391 * src/maemo/modest-account-settings-dialog.c:
3392 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3393 widgets, because this might not be the default in future versions of the Maemo GTK+.
3394 However, I can not not get capitalization to work even in a simple test case.
3396 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3398 * src/maemo/easysetup/modest-easysetup-wizard.c:
3399 (create_page_custom_incoming), (create_page_custom_outgoing):
3400 * src/maemo/modest-account-settings-dialog.c:
3401 (create_page_account_details), (create_page_incoming),
3402 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3403 instead of using gtk_check_button_with_label(), so they are aligned like the other
3404 widgets, as per the UI spec.
3406 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/easysetup/modest-easysetup-wizard.c:
3409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3410 * src/widgets/modest-validating-entry.c:
3411 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3412 Modest prefix instead of an EasySetup prefix.
3414 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3416 * src/widgets/modest-validating-entry.h:
3417 * src/widgets/modest-validating-entry.c: (on_insert_text),
3418 Added easysetup_validating_entry_set_max_func(), used to set a callback
3419 to call when the max number of characters is reached. GtkEntry has a max-length
3420 already but is silent about it.
3422 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3423 (create_page_account_details), (create_page_user_details),
3425 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3426 (create_page_account_details), (create_page_user_details),
3427 (create_page_outgoing):
3428 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3429 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3430 the UI spec, when the user tries to enter more than the max number of characters.
3432 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/easysetup/modest-easysetup-wizard.c:
3435 (create_page_user_details), (create_page_custom_incoming),
3436 (create_page_custom_outgoing):
3437 * src/maemo/modest-account-settings-dialog.c:
3438 (create_page_user_details), (create_page_incoming),
3439 (create_page_outgoing):
3440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3441 (modest_connection_specific_smtp_edit_window_init):
3442 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3443 not appropriate. Bad Maemo-specific defaults!.
3445 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3447 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3448 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3449 (modest_signature_editor_dialog_set_settings):
3450 Disable the label and textview when the checkbox is disabled, and use the
3451 specified (UI spec) default signature text.
3453 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3456 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3458 * src/modest-defs.h:
3459 * src/modest-account-mgr-helpers.h:
3460 * src/modest-account-mgr-helpers.c:
3461 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3463 * src/maemo/Makefile.am:
3464 * src/maemo/modest-signature-editor-dialog.c:
3465 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3468 * src/maemo/modest-account-settings-dialog.h:
3469 * src/maemo/modest-account-settings-dialog.c:
3470 (modest_account_settings_dialog_finalize), (on_button_signature),
3471 (save_configuration): Use the new dialog when the Edit button is pressed, and
3472 save the changes if necessary, as per the UI spec.
3474 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3476 * src/maemo/Makefile.am:
3477 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3478 based on maemo-develoers email from Dirk.
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 (create_page_welcome), (create_page_account_details),
3482 (create_page_user_details), (create_page_complete_easysetup),
3483 (create_page_custom_incoming), (create_page_custom_outgoing),
3484 (create_page_complete_custom),
3485 (modest_easysetup_wizard_dialog_init):
3486 * src/maemo/modest-account-settings-dialog.c:
3487 (create_page_account_details), (create_page_user_details),
3488 (create_page_incoming), (create_page_outgoing),
3489 (modest_account_settings_dialog_init):
3490 * src/maemo/modest-connection-specific-smtp-window.c:
3491 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3493 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3495 * src/maemo/easysetup/modest-easysetup-wizard.c:
3496 (create_page_account_details), (create_page_custom_outgoing),
3497 (create_page_complete_custom):
3498 * src/maemo/modest-account-settings-dialog.c:
3499 (create_page_user_details), (create_page_incoming),
3500 (create_page_outgoing):
3501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3502 (modest_connection_specific_smtp_edit_window_init):
3503 Use the correct (UI spec) port min/max, and use horizontal separators,
3506 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3508 * src/maemo/easysetup/modest-easysetup-wizard.c:
3509 (set_default_custom_servernames):
3510 * src/maemo/modest-account-settings-dialog.c:
3511 (create_page_incoming), (on_combo_outgoing_security_changed),
3512 (on_combo_incoming_security_changed), (create_page_outgoing),
3513 (modest_account_settings_dialog_set_account_name),
3514 (save_configuration):
3515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3516 (on_combo_security_changed),
3517 (modest_connection_specific_smtp_edit_window_init),
3518 (modest_connection_specific_smtp_edit_window_set_connection),
3519 (modest_connection_specific_smtp_edit_window_get_settings):
3520 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3523 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/easysetup/modest-easysetup-wizard.c:
3527 (create_page_custom_outgoing), (create_page_complete_custom):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (create_page_user_details), (create_page_outgoing):
3530 * src/maemo/modest-account-view-window.c: (button_box_new):
3531 Use changed logical IDs as per the most recent UI spec:
3532 mcen_bd_emailsetup_edit -> mcen_bd_edit
3533 mcen_bd_emailsetup_delete -> mcen_bd_delete
3534 mcen_bd_emailsetup_close -> mcen_bd_close
3536 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3540 * src/dbus_api/Makefile.am:
3541 * src/dbus_api/modest-dbus-callbacks.c:
3542 * src/dbus_api/modest-dbus-callbacks.h:
3543 * src/maemo/modest-platform.c: (modest_platform_init):
3544 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3546 * tests/Makefile.am:
3547 * tests/dbus_api/Makefile.am:
3548 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3550 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3552 * src/maemo/modest-account-settings-dialog.c:
3553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3554 Removed unnecessary includes.
3556 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3558 * src/maemo/easysetup/modest-easysetup-wizard.c:
3559 * src/maemo/modest-account-settings-dialog.c:
3560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3561 * src/widgets/Makefile.am:
3562 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3563 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3564 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3565 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3566 * src/widgets/modest-secureauth-combo-box.c:
3567 * src/widgets/modest-secureauth-combo-box.h:
3568 * src/widgets/modest-serversecurity-combo-box.c:
3569 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3570 made the GObject names more consistent with the rest of the Modest code.
3572 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3574 * src/maemo/easysetup/Makefile.am:
3575 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3576 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3577 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3578 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3579 * src/maemo/easysetup/modest-easysetup-wizard.c:
3580 * src/maemo/easysetup/modest-validating-entry.c:
3581 * src/maemo/easysetup/modest-validating-entry.h:
3582 * src/maemo/modest-account-settings-dialog.c:
3583 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3584 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3585 widgets/ because they are used outside of easysetup too. After checking in,
3586 svn will allow me to rename them too.
3588 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3590 * src/gnome/modest-msg-edit-window.c:
3591 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3592 linker error, to fix the build on the GNOME platform.
3593 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3594 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3595 ifdefed out to avoid a warning.
3597 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3599 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3600 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3601 some alternative for GTK+ 2.6.
3603 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3607 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3608 specified for EmailAccountsDialog in UI spec.
3610 * src/maemo/easysetup/modest-easysetup-wizard.c:
3611 * src/maemo/easysetup/modest-easysetup-wizard.h:
3612 * src/maemo/modest-account-settings-dialog.c:
3613 * src/maemo/modest-account-settings-dialog.h:
3614 Reuse a member window widget for the connection-specific SMTP server accounts,
3615 so we can tell it to create/save the accounts only if we actually save changes.
3617 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3619 (modest_connection_specific_smtp_edit_window_get_settings):
3620 Return a struct instance for temporarily remembering the entered data.
3622 * src/maemo/modest-connection-specific-smtp-window.h:
3623 * src/maemo/modest-connection-specific-smtp-window.c:
3624 (modest_connection_specific_smtp_window_finalize),
3625 (modest_connection_specific_smtp_window_fill_with_connections),
3627 (modest_connection_specific_smtp_window_save_server_accounts),
3628 (update_model_server_names): Do not actually save data until asked,
3629 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3631 (on_selection_changed),
3632 (modest_connection_specific_smtp_window_init): Disable the edit
3633 button when nothing is selected.
3635 * src/modest-account-mgr-helpers.c:
3636 * src/modest-account-mgr-helpers.h:
3637 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3640 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3642 * src/modest-account-mgr-helpers.h:
3643 * src/modest-account-mgr-helpers.c:
3644 (modest_account_mgr_get_unused_account_name),
3645 (modest_account_mgr_get_unused_account_display_name): Added these
3646 utility functions, to avoid code duplication.
3648 * src/maemo/easysetup/modest-easysetup-wizard.c:
3649 (create_page_account_details), (create_account):
3650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3651 (on_combo_security_changed),
3652 (modest_connection_specific_smtp_edit_window_init),
3653 (modest_connection_specific_smtp_edit_window_save_settings):
3654 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3655 * src/maemo/modest-connection-specific-smtp-window.c:
3656 (modest_connection_specific_smtp_window_finalize),
3657 (modest_connection_specific_smtp_window_fill_with_connections),
3658 (on_button_edit), (modest_connection_specific_smtp_window_init):
3659 * src/maemo/modest-connection-specific-smtp-window.h:
3660 Implementing saving of connection-specific server accounts.
3662 But I need to refactor this so we can save the data for each
3663 possible connection-specific account and only actually create the server accounts
3664 when the easysetup finished, or the OK button is pressed on the account settings
3667 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3669 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3670 (on_combo_security_changed):
3671 (modest_connection_specific_smtp_edit_window_init):
3672 Auto-fill the port number as in the account settings.
3674 (modest_connection_specific_smtp_edit_window_set_connection):
3675 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3676 * src/maemo/modest-connection-specific-smtp-window.c:
3677 (fill_with_connections), (on_button_edit),
3678 (modest_connection_specific_smtp_window_init):
3679 Turn the edit window into a dialog to simplify the code, and
3680 set a WM hint as in a GtkDialog, because only a popup can be on top of
3681 another window in Maemo, and popups usually have no WM decoration.
3683 * src/modest-defs.h:
3684 * src/modest-account-mgr-helpers.c:
3685 (modest_account_mgr_set_connection_specific_smtp),
3686 (modest_account_mgr_remove_connection_specific_smtp),
3687 (modest_account_mgr_get_connection_specific_smtp):
3688 * src/modest-account-mgr-helpers.h: Some functions to write the
3689 connection-specific SMTP server information. Not yet used.
3692 * src/widgets/modest-folder-view.c: (text_cell_data):
3693 Fix a warning about an uninitialized variable.
3694 (on_configuration_key_changed): Put an #ifdef around the use
3695 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3697 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3699 * src/maemo/modest-account-settings-dialog.h:
3700 * src/maemo/modest-account-settings-dialog.c:
3701 Added connect_for_modified() utility function to mark the new modified boolean.
3703 (create_page_account_details), (create_page_user_details),
3704 (create_page_incoming), (create_page_outgoing), (on_response),
3705 (modest_account_settings_dialog_init),
3706 (modest_account_settings_dialog_set_account_name):
3707 Only warn about unsaved changes when there are actually unsaved changes.
3709 * src/modest-account-mgr-helpers.c:
3710 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3711 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3712 to get the data from there in future.
3714 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3716 * src/modest-defs.h:
3718 * src/modest-account-mgr-helpers.h:
3719 * src/modest-account-mgr-helpers.c:
3720 Store the security account setting in a single conf key instead of using
3721 the options list, so that the list is left for just the to-be-removed camel hack,
3722 and because gconf_client_set_list() is failing for some reason.
3724 * src/modest-account-mgr.c:
3725 (modest_account_mgr_add_server_account):
3726 * src/maemo/modest-account-settings-dialog.c:
3727 (modest_account_settings_dialog_set_account_name),
3728 (save_configuration): Use the renamed functions.
3731 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3733 * src/widgets/Makefile.am:
3734 * src/widgets/modest-limit-retrieve-combo-box.c:
3735 * src/widgets/modest-limit-retrieve-combo-box.h:
3736 * src/widgets/modest-retrieve-combo-box.c:
3737 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3738 the account settings dialog.
3740 * src/modest-defs.h:
3741 * src/modest-account-mgr-helpers.h:
3742 * src/modest-account-mgr-helpers.c:
3743 (modest_server_account_get_option_secure_auth),
3744 (modest_server_account_set_option_secure_auth):
3745 * src/modest-account-mgr.c:
3746 (modest_account_mgr_add_server_account):
3747 Use the existing AUTH_MECH conf key for the secure-auth setting,
3748 instead of putting it in the list options, because this was actually used already.
3750 * src/maemo/modest-account-settings-dialog.c:
3751 (create_page_account_details),
3752 (modest_account_settings_dialog_set_account_name),
3753 (save_configuration):
3754 * src/maemo/modest-account-settings-dialog.h:
3755 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3756 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3758 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3761 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3762 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3764 * src/modest-defs.h:
3765 * src/maemo/modest-account-settings-dialog.c:
3766 (create_page_incoming), (on_combo_outgoing_security_changed),
3767 (on_combo_incoming_security_changed), (create_page_outgoing),
3768 (modest_account_settings_dialog_set_account_name),
3769 (save_configuration): Load/Save the port number, and change it when the
3770 security combo changes, to suitable defaults.
3772 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3774 * src/modest-account-mgr.c:
3775 (modest_account_mgr_add_server_account): Set the security and secure-auth
3776 options, and add a comment saying that the other camel-specific options should be
3779 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3781 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3783 * src/modest-tny-account-store.c: (account_list_free),
3784 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3785 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3788 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3790 * src/modest-protocol-info.c:
3791 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3792 is required by our UI spec. Maybe something in our implementation will use this eventually.
3793 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3794 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3795 instead of the previous 0 placeholder.
3797 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3798 secure-auth settings.
3799 * src/modest-account-mgr-helpers.h:
3800 * src/modest-account-mgr-helpers.c:
3801 (modest_server_account_data_get_option_secure_auth),
3802 (modest_server_account_set_option_secure_auth),
3803 (modest_server_account_data_get_option_security),
3804 (modest_server_account_set_option_security): Added this API for getting and setting the security
3805 and secure-auth settings.
3807 * src/maemo/modest-account-settings-dialog.h:
3808 * src/maemo/modest-account-settings-dialog.c:
3809 (modest_account_settings_dialog_finalize), (check_data),
3810 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3811 about changing titles.
3812 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3813 (save_configuration): Save the security and secure-auth settings.
3815 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3816 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3818 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3820 * src/modest-defs.h:
3821 * src/modest-account-mgr.c:
3822 (modest_account_mgr_add_server_account):
3823 Added and used defines for the options key and value pair strings,
3824 that are used so far, though they do not seem to correspond to anything in our
3825 UI specs or ModestProtocol enum.
3827 * src/modest-account-mgr-helpers.h:
3828 * src/modest-account-mgr-helpers.c:
3829 (compare_option_strings_for_name),
3830 (modest_server_account_data_get_option_value),
3831 (modest_server_account_data_get_option_bool),
3832 (modest_account_mgr_get_server_account_option):
3833 Added helper functions for parsing the options GSList.
3835 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3837 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3838 display name is based on the supplied account name.
3839 * src/modest-account-mgr.c:
3840 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3841 with an inefficient, but good-enough, implementation.
3843 * src/maemo/easysetup/modest-easysetup-wizard.c:
3844 (create_page_account_details), (on_before_next), (create_account):
3845 Check for existing display names rather than (non-user-visible) account names, and just
3846 create and set a unique account name at the end.
3848 * src/maemo/modest-account-settings-dialog.c:
3849 (modest_account_settings_dialog_init),
3850 (modest_account_settings_dialog_set_account_name),
3851 (create_page_incoming): Show the display name, instead of the account name.
3852 (on_response): Do some (not all) extra checks, as in the UI spec.
3853 (save_configuration): Save the display name if it was changed.
3855 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3857 * po/en_GB.po: Added needed logical ID and translation.
3858 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3859 (init_view): Made the is-default column clicking work.
3861 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3864 * src/maemo/easysetup/Makefile.am:
3865 * src/maemo/easysetup/modest-easysetup-wizard.c:
3866 (modest_easysetup_wizard_dialog_init):
3867 * src/maemo/easysetup/provider-data-test.keyfile:
3868 * src/maemo/easysetup/provider-data.keyfile:
3869 Moved the provider data file to the new modest-providers-data package and used it from there.
3871 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3873 * src/modest-local-folder-info.c:
3874 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3875 N_() was already used on the static strings, but this just marks it for translation without
3876 using the translation.
3878 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3880 * src/maemo/modest-account-settings-dialog.c:
3881 (create_page_incoming),
3882 (modest_account_settings_dialog_set_account_name):
3883 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3884 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3885 I will do this if nobody else gets there first.
3887 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3889 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3890 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3891 save the security stuff.
3893 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3896 Set the email address and user fullname, which I now see must be
3899 * src/maemo/modest-account-settings-dialog.h:
3900 * src/maemo/modest-account-settings-dialog.c:
3902 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3903 leave-on-server and authentication.
3904 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3907 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3910 * src/maemo/modest-account-settings-dialog.c:
3911 * src/maemo/modest-account-settings-dialog.h:
3912 Most (but not all) of the widgets are now present as specified by the UI spec.
3913 No changes are yet saved, and some details are not properly shown yet.
3915 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3917 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3919 * src/maemo/Makefile.am:
3920 * src/maemo/modest-account-settings-dialog.c:
3921 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3922 an existing account. Doesn't do much yet.
3924 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3925 Open the accounts settings dialog when Edit is clicked.
3927 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3929 * src/maemo/easysetup/Makefile.am:
3930 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3932 * src/maemo/easysetup/modest-easysetup-wizard.c:
3933 (modest_easysetup_wizard_dialog_init):
3934 Try to get the source directory from the build system,
3935 instead of hard-coding "./" into the source code, when opening our local
3936 copies of the configuration files.
3937 But this still fails when opening the wizard from the Accounts window,
3938 maybe because the working directory seems to change at runtime.
3939 So the wizard will fail the second time unless you copy the files into their
3940 proper locations - see the stdout warnings for the paths.
3942 (create_page_account_details),(on_before_next):
3943 Check for existing non-server accounts instead of server accounts,
3944 so the default account name is useful again, and to prevent trying to
3947 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3948 Show the wizard when New is clicked.
3950 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3951 (init_view): Show the column headers, and show the columns that are
3952 specified in the UI specs. However, something in Maemo's GTK+ prevents
3953 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3954 change the default account. This is despite unsetting the special properties.
3956 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3958 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3959 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3960 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3961 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3962 to make that clearer.
3963 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3965 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3967 * src/maemo/modest-account-view-window.c:
3968 (modest_account_view_window_init),
3969 (modest_account_view_window_new):
3970 Use the same buttons as specified in the
3971 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3972 the existing widgets, which never had a chance of working.
3973 Put the ModestAccountView treeview in a scrolled window.
3974 Do not repeat the initialization in both _init() and _new().
3976 * src/widgets/modest-account-view.c: (update_account_view):
3977 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3978 this widget and window shows no accounts.
3980 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3982 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/easysetup/modest-easysetup-wizard.c:
3985 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3986 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3987 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3990 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3991 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3992 accounts exist yet, as in the UI spec.
3994 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3996 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/Makefile.am:
3999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4000 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4001 New window for editing connection-specific smtp details.
4002 Not fully implemented.
4004 * src/maemo/modest-connection-specific-smtp-window.c:
4005 (modest_connection_specific_smtp_window_finalize) :
4006 unref the tree model.
4007 (on_button_edit): Show the edit window.
4009 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4011 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4014 * src/maemo/Makefile.am:
4015 * src/maemo/modest-connection-specific-smtp-window.c:
4016 * src/maemo/modest-connection-specific-smtp-window.h:
4017 New window for showing the list of connections, for connection-specific
4018 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4019 * src/maemo/easysetup/modest-easysetup-wizard.c:
4020 (create_page_custom_outgoing): Show the new window when the button is clicked.
4022 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4024 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4025 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4026 * src/maemo/modest-msg-edit-window.c:
4027 (modest_msg_edit_window_insert_image):
4028 * src/modest-conf.c: (modest_conf_key_escape):
4029 * src/modest-mail-operation.c:
4030 (modest_mail_operation_send_new_mail):
4031 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4032 (modest_ui_actions_on_new_account):
4033 * src/widgets/modest-attachment-view.c: (update_filename_request):
4034 * src/widgets/modest-mail-header-view.c:
4035 Corrected warnings that were breaking the build, by commenting out unused variables,
4036 and a function, and by including a header.
4038 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4040 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4041 so we can #ifdef around platform-specific code when necessary.
4042 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4043 to allow this to build for the GNOME platform too.
4045 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4047 * src/maemo/easysetup/modest-easysetup-wizard.c:
4048 Added util_increment_name() and used it in create_page_account_details()
4049 to make sure that the default account name is always a new name.
4051 (modest_easysetup_wizard_dialog_init),
4052 (set_default_custom_servernames): Some minor memory management fixes.
4054 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4058 * src/modest-runtime.c: (init_i18n): Restored the translation
4059 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4060 are defined in config.h, and the translations are installed.
4062 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4063 is defined for translation.
4065 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4067 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4069 * src/maemo/easysetup/modest-easysetup-wizard.c:
4070 (modest_easysetup_wizard_dialog_init):
4071 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4072 Use realistic paths (though they should use $prefix generically) to the
4073 mcc_mapping and provider-data.keyfile files which might work when they
4074 are installed by the future version of the operator-wizard package,
4075 and then fallback to paths in our source code, with an explanatory
4078 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4082 * src/maemo/Makefile.am:
4083 * src/maemo/easysetup/: Added files from the previously-exernal
4084 osso-modest-easysetup.
4085 * src/maemo/modest-main-window-ui.h:
4086 * src/modest-ui-actions.c:
4087 * src/modest-ui-actions.h:
4088 Added modest_ui_actions_on_new_account() as a signal handler for the
4089 New Account menu item. It shows the easysetup wizard.
4090 * po/en_GB.po: Added additional needed logical IDs and translations.