1 2007-09-05 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-utils.c:
4 (on_camel_account_get_supported_secure_authentication),
5 (modest_maemo_utils_get_supported_secure_authentication_methods):
6 Adapted to the changed tinymail signature of the callback, and
7 printf a warning when there is an exception, as a clue.
9 2007-09-03 Armin Burgmeier <armin@openismus.com>
11 * src/maemo/modest-maemo-utils.c: Don't set the temporary account
12 online that checks for supported authentication methods. This fixes
13 projects.maemo.org bug NB#61369.
15 2007-09-03 Murray Cumming <murrayc@murrayc.com>
17 * src/widgets/modest-folder-view.c: (strings_are_equal),
18 (on_model_foreach_set_name), (on_get_mmc_account_name),
19 (text_cell_data): Restored this code that was removed in
20 svn revision 3165 by jfernandez, because this late name-discovery
21 really is necessary sometimes. This is the correct fix to the endless
22 calling of this function:
23 * src/modest-tny-account.c: (on_modest_file_system_info):
24 Don't call tny_account_set_name() when the name is already correct,
25 to avoid unnecessary (endless) updates to the tree model.
27 2007-08-31 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-defs.h: Rename MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST to
30 MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST and make it a global list
31 for use by all accounts that enable the MODEST_ACCOUNT_USE_CONNECTION_SPECIFIC_SMTP
32 boolean, because this is the specified behaviour in the UI spec.
33 * src/modest-account-mgr-helpers.h:
34 * src/modest-account-mgr-helpers.c:
35 (modest_account_mgr_set_connection_specific_smtp),
36 (modest_account_mgr_remove_connection_specific_smtp),
37 (modest_account_mgr_get_connection_specific_smtp): Remove the account_name
39 * src/maemo/modest-connection-specific-smtp-window.h:
40 * src/maemo/modest-connection-specific-smtp-window.c:
41 (modest_connection_specific_smtp_window_finalize),
42 (modest_connection_specific_smtp_window_fill_with_connections),
43 (modest_connection_specific_smtp_window_save_server_accounts):
44 Remove the account_name parameters and member variable.
45 * src/maemo/easysetup/modest-easysetup-wizard.c:
46 (on_button_outgoing_smtp_servers), (create_account):
47 * src/maemo/modest-account-settings-dialog.c:
48 (on_button_outgoing_smtp_servers), (check_data),
49 (modest_account_settings_dialog_set_account_name),
51 * src/maemo/modest-maemo-utils.c: (on_account_online),
52 (modest_maemo_utils_get_supported_secure_authentication_methods):
53 * src/modest-tny-account-store.c:
54 (get_smtp_specific_transport_account_for_open_connection),
55 (insert_account), (add_connection_specific_transport_accounts):
56 * src/modest-ui-actions.c: (on_smtp_servers_window_hide),
57 (modest_ui_actions_on_smtp_servers):
58 Adapt to the changed API.
60 2007-08-29 Armin Burgmeier <armin@openismus.com>
62 * src/modest-protocol-info.h:
63 * src/modest-protocol-info.c: Added
64 modest_protocol_info_get_auth_protocol() to translate an
65 authentication protocol name to the corresponding enum value.
67 * src/maemo/modest-maemo-utils.c: Fixed supported auth protocol list
68 generation using the newly added function.
70 * src/maemo/modest-account-settings-dialog.c: Use the current element
71 when traversing through the list of supported authentication methods,
74 2007-08-29 Murray Cumming <murrayc@murrayc.com>
76 * src/maemo/easysetup/modest-easysetup-wizard.c:
77 (check_first_supported_auth_method), (on_before_next),
79 * src/maemo/modest-account-settings-dialog.c: (check_data):
80 Some cleanup, to make the code clearer.
82 2007-08-29 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
85 Use the mail_ni_ssl_certificate_error ("Secure connection failed")
86 logical ID when the secure authentication method is not supported by
87 the server, as requested by Mox on the wiki, though I hate not
88 giving the user the clue.
90 2007-08-29 Murray Cumming <murrayc@murrayc.com>
92 * src/modest-search.c: (modest_search_all_accounts):
93 * src/modest-platform.h:
94 * src/maemo/modest-platform.c: Moved and renamed
95 check_and_wait_for_account_is_online() to
96 modest_platform_check_and_wait_for_account_is_online() so it
97 can be used in more places.
99 2007-08-29 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
102 Removed the sleep(1) experiment because it does not seem to help,
103 and I should not have checked the experiment in anyway.
104 The problem is maybe in the TnyAccount connected state - I will
105 investigate that instead.
107 2007-08-28 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
110 Added a sleep(1) in case it helps with bug #66769.
112 2007-08-28 Murray Cumming <murrayc@murrayc.com>
114 * src/modest-search.c: (on_timeout_check_account_is_online),
115 (check_and_wait_for_account_is_online):
116 It is OK for local-folder and mmc accounts to be used when they
117 are in the _INIT folder, instead of waiting for them to change
119 For POP and IMAP, wait from them to stop being _INIT, rather than
120 waiting from them to be _CONNECTED, because that seems to be
121 the status that causes the problems.
123 2007-08-28 Murray Cumming <murrayc@murrayc.com>
125 * src/modest-search.c: (check_and_wait_for_account_is_online):
126 Actually pass the account to the timeout callback.
128 2007-08-28 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-search.c: (on_timeout_check_account_is_online):
131 Added some debug output to help me debug a problem on the N800.
132 (check_and_wait_for_account_is_online): Fail immediately if the
134 modest_search_all_accounts(): Try the search even if the account does
135 not seem to be online, because this can work sometimes, and should work
136 with the cache if there is no active libconic connection.
138 2007-08-27 Armin Burgmeier <armin@openismus.com>
140 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
141 observe outbox for added messages to assign them a status. Previously,
142 this was done in modest_tny_send_queue_add(), but the message id might
143 not yet be known at that point. This reduces warnings when sending
144 mail, though I am not sure how this even worked before.
146 2007-08-27 Murray Cumming <murrayc@murrayc.com>
148 * src/maemo/modest-account-settings-dialog.c:
149 (modest_account_settings_dialog_init):
150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
151 (modest_connection_specific_smtp_edit_window_init):
152 * src/maemo/modest-connection-specific-smtp-window.c:
153 (modest_connection_specific_smtp_window_init):
154 * src/maemo/modest-maemo-utils.c:
155 (modest_maemo_utils_get_supported_secure_authentication_methods):
156 * src/maemo/modest-platform.c:
157 (modest_platform_run_folder_name_dialog):
158 * src/maemo/modest-signature-editor-dialog.c:
159 (modest_signature_editor_dialog_init):
160 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
161 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
162 * src/widgets/modest-global-settings-dialog.c:
163 (modest_global_settings_dialog_init):
164 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
166 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
167 GTK_STOCK_EDIT with mcen_bd_edit, and
168 GTK_STOCK_CLOSE with mcen_bd_close,
169 to fix projects.maemo.org bug NB#64995.
170 I strongly believe that Maemo's GTK+ should have the wanted translations
171 instead of duplicating this in each application and complicating the code.
173 2007-08-27 Armin Burgmeier <armin@openismus.com>
175 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
176 recursion when entering text in the subject field.
178 2007-08-27 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
181 which checks every second, 10 times, to wait until the account is online
182 so that we can use it, if the account is in the process of going online.
183 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
184 so that searching works even when the application was not yet started before.
185 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
187 2007-08-24 Armin Burgmeier <armin@openismus.com>
189 * src/modest-widget-memory.c: Always show the default account when the
190 application is started, as stated in the UI spec. This fixes
191 projects.maemo.org bug NB#66630.
193 2007-08-24 Armin Burgmeier <armin@openismus.com>
195 * src/maemo/modest-platform.c:
196 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
197 english text for strings in the rename folder dialog, fixing
198 projects.maemo.org bug NB#66338.
200 2007-08-22 Armin Burgmeier <armin@openismus.com>
202 * src/widgets/modest-account-view.c: Fix for bora by using
203 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
204 latter seems not be used anymore.
206 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
209 * src/maemo/modest-main-window.c: Update menu items when the default
210 account changes so that the current default account is always bolded.
211 This fixes maemo.projects.org bug NB#66173.
213 2007-08-17 Murray Cumming <murrayc@murrayc.com>
215 * src/dbus_api/modest-dbus-callbacks.c:
216 (on_dbus_method_get_folders): Avoid trying to get the account name
217 when there are no accounts, to avoid critical g_warnings, fixing
218 projects.maemo.org bug NB#65574.
220 2007-08-17 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
223 Use modest_account_mgr_get_signature() instead of accessing gconf
224 directly, to slightly simplify the code.
225 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
226 Append the signature also when opening via other applications,
227 fixing projects.maemo.org bug NB#65828.
229 2007-08-17 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
232 Check for NULLs to prevent a crash when opening an email that is
233 an attachment in another email, fixing projects.maemo.org bug
236 2007-08-17 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-ui-dimming-rules.c:
239 (modest_ui_dimming_rules_on_view_window_move_to):
240 Enable the Move To toolbar button for search results, fixing the
241 last part of projects.maemo.org bug NB#63807.
243 2007-08-17 Murray Cumming <murrayc@murrayc.com>
245 * src/dbus_api/modest-dbus-callbacks.c:
246 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
247 because this is called from idle handlers, to fix hangs afte the
249 (find_message_by_url): Added a TODO comment about a crash that
250 happens when tinymail was built with DBC checks.
252 2007-08-16 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-search.c: (modest_search_folder):
255 * src/modest-search.h: Rename ModestSearch::before to start_date
256 and after to end_date, using the same names as the libogs struct
258 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
259 The start_date and end_date were swapped in the check. This
260 fixes date range searches, fixing projects.maemo.org bug NB#63407.
262 2007-08-16 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-account-view-window.c:
265 Added (check_for_active_acount).
266 (on_delete_button_clicked), (on_edit_button_clicked):
267 When an account is doing something (such as refreshing),
268 show the same warning for account deletion as for account
269 editing, to fix projects.maemo.org bug NB#64588.
271 2007-08-16 Murray Cumming <murrayc@murrayc.com>
273 * src/widgets/modest-msg-view-window.h:
274 * src/gnome/modest-msg-view-window.c:
275 * src/maemo/modest-msg-view-window.c:
276 Added modest_msg_view_window_construct().
277 (modest_msg_view_window_new_with_header_model),
278 Added modest_msg_view_window_new_for_search_result),
279 Renamed modest_msg_view_window_new() to
280 modest_msg_view_window_new_for_attachment(),
281 and modest_msg_view_window_is_search_result(),
282 so we can explicitly know that the window is for an
283 attachment or a search result or a message from the list.
285 (modest_msg_view_window_view_attachment):
286 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
287 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
288 Use modest_msg_view_window_new_for_search_result().
290 * src/modest-ui-dimming-rules.c:
291 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
292 for search results, fixing projects.maemo.org bug NB#63811.
294 2007-08-16 Armin Burgmeier <armin@openismus.com>
296 * src/modest-ui-actions.c: Show a banner instead of a dialog when
297 renaming a folder fails, to stay consistent with what happens when
298 creating a folder fails.
300 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
301 slightly country loading from the mmc_mappings file, fixed a memory
304 2007-08-16 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-tny-account-store.c: (volume_path_is_mounted):
307 Check the GnomeVFSVolume activation path instead of the device path,
308 so that the memory card is really really shown in the UI.
310 2007-08-16 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/easysetup/modest-easysetup-wizard.c:
313 (get_entered_account_title), (on_before_next), (entry_is_empty),
315 * src/maemo/modest-account-settings-dialog.c:
316 (get_entered_account_title), (on_button_signature), (check_data),
317 (save_configuration), (entry_is_empty):
318 Strip the account title of whitespace at the start and end before
319 using it or checking it. This means that an all-whitespace title
320 is not allowed, fixing projects.maemo.org bug NB#64977.
322 2007-08-15 Murray Cumming <murrayc@murrayc.com>
324 * src/modest-ui-actions.h:
325 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
326 to modest_run_account_setup_wizard() and made it public.
327 * src/dbus_api/modest-dbus-callbacks.c:
328 (check_and_offer_account_creation), (on_idle_mail_to),
329 (on_idle_compose_mail), (on_idle_open_default_inbox):
330 Offer account creation if necessary, fixing projects.maemo.org
333 2007-08-15 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-ui-actions.c: (run_account_setup_wizard):
336 Return a gboolean to indicate success.
337 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
338 (modest_ui_actions_on_send): When offering account creation, only
339 give up (return) if account creation failed. Otherwise continue
340 with the original request. This fixed projects.maemo.org bug
343 2007-08-15 Murray Cumming <murrayc@murrayc.com>
345 * src/widgets/modest-recpt-editor.c:
346 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
347 to fix projects.maemo.org bug NB#63789.
349 2007-08-15 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
352 (modest_tny_account_store_new): Properly detect the memory card at
353 startup, and add an account for it.
355 2007-08-14 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
358 Commented out the MMC code again because it mistakenly detects
359 the card even when it isn't inserted.
361 2007-08-14 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
364 Renabled the call to add_mmc_account() because I do not believe
365 it could be the cause of the mentioned hang (in scratchbox, where
366 there is no memory card), and because I have tested that it works
369 2007-08-14 Murray Cumming <murrayc@murrayc.com>
371 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
372 Comment out part of the last commit because it apparently causes
375 2007-08-14 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account-store.c: Added the add_mmc_account()
378 function to save some copy/pasting.
379 (modest_tny_account_store_new): If the memory card is mounted,
380 create an account for it at the start, instead of waiting for the
381 user to unmount it and mount it.
383 2007-08-13 Murray Cumming <murrayc@murrayc.com>
385 * src/widgets/modest-account-view.c: (on_account_changed):
386 Do not try to use the human-readable TnyAccount name instead of the
387 ID of the modest account to get the transport account. And unref
388 the transport account. This prevents a g_warning(), and a possible
391 2007-08-13 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/modest-platform.c:
394 (modest_platform_set_update_interval): Handle the new
395 alarmd error to warn when alarmd is not running, as is the case in
396 scratchbox for me now because
397 "Module /usr/lib/alarmd/libretu.so initialization failed"
399 2007-08-13 Murray Cumming <murrayc@murrayc.com>
401 * src/widgets/modest-header-view-render.c:
402 (_modest_header_view_compact_header_cell_data):
403 NULL some strings after freeing them, trying to deal with
404 the double deletion found in projects.maemo.org bug 64183,
405 probably having no effect.
407 2007-08-13 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/modest-account-settings-dialog.c:
410 (create_page_incoming), (create_page_outgoing): Use a define
411 for the min and max port numbers.
413 (check_hildon_number_editor_and_warn_value_not_in_range),
414 (check_data): Do an extra check for an invalid port number, as needed
415 in projects.maemo.org bug #64275, when the number is cleared, but this
416 does not work due to bugs.maemo.org bug #1806.
418 2007-08-13 Murray Cumming <murrayc@murrayc.com>
420 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
421 Comment out the debug warning about the unexpected D-Bus methods.
422 They are just annoying now.
423 * src/maemo/modest-platform.c:
424 (modest_platform_set_update_interval): Correct the D-Bus path, instead
425 of using a file path, though it did not seem to break things before.
426 It might be needed now:
427 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
428 modest is not already running. This is the behaviour of the old client, and
429 Mox says it is what we should do for modest.
430 This closes projects.maemo.org bug NB#64327.
432 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
434 * src/modest-text-utils.c:
435 Fixed invalid jump due to incorrect string/pointer
437 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
440 2007-08-01 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-account-mgr-helpers.h:
443 * src/modest-account-mgr-helpers.c:
444 Added modest_account_mgr_get_first_account_name(),
445 using code from modest_account_mgr_set_first_account_as_default().
447 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
448 (account_number_changed): Call set_at_least_one_account_visible() so that
449 the first account is visible when first added, without the user having to
451 I do wonder how this worked before.
453 2007-08-01 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-tny-account-store.c: (show_password_warning_only),
456 (show_wrong_password), (request_password_and_wait), (get_password),
457 (modest_tny_account_store_alert): Remove the (incomplete anyway)
458 attempts to show UI only in the main context, which used g_idle_add()
459 and mainloops, because tinymail now guarantees that it only calls these
460 callbacks in the mainloop with the gdk lock. This makes everything much
463 2007-08-01 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
466 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
467 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
468 error dialog, instead of ignoring it.
470 2007-08-01 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/modest-msg-view-window.c:
473 (modest_msg_view_window_get_header),
474 (modest_msg_view_window_last_message_selected):
475 Added comments to explain the use of priv->header_model.
476 * src/modest-ui-dimming-rules.c:
477 (modest_ui_dimming_rules_on_open_msg),
478 (modest_ui_dimming_rules_on_mark_as_read_msg),
479 (modest_ui_dimming_rules_on_mark_as_unread_msg),
480 (modest_ui_dimming_rules_on_remove_attachments),
481 (_invalid_attach_selected), (_selected_msg_marked_as):
482 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
483 and changed the parameter to a ModestMainWindow to make it clearer that
484 it never uses any other kind of window.
485 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
486 instead of the selected message.
487 I notice that much of the dimming code and the ModestMsgViewWindow code
488 hard-codes the assumption that the viewed message is always selected in
489 the header view. This does not seem wise or simple.
491 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
492 examine the actual message instead of whatever might be selected
493 in the header view. This stops the delete toolbar button and menu item
494 from being dimmed when opening a message view the search UI,
495 partially fixing projects.maemo.org bug NB#63811.
497 However, when actually deleting, I now get this warning:
498 "tny_header_set_flags: This is a header instance for a new message.
499 Only priority and attachment flags are supported"
501 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
503 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
505 Show account wizard if no accounts are defined while sending
506 (automatic sending after the account wizard finished does not
507 work because it takes some time until the account manager
508 synchronizes everything. (projects.maemo.org NB#62792)
510 2007-07-30 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account-store.c: (on_account_removed),
513 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
514 account is removed from the View menu. We have TnyAccountStore
515 and ModestTnyAccountStore signals that seem very similar, but this
516 seems to work for now.
518 * src/maemo/modest-main-window.c:
519 (on_show_account_action_activated): Prevent dereference
520 of a NULL if the accoutn does not really exist, though that
521 should not happen anymore.
523 This fixes projects.maemo.org bug NB#64606.
525 2007-07-30 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-ui-actions.c: (run_account_setup_wizard),
528 (modest_ui_actions_on_accounts): Revert a change that set these
529 to modal dialogs, freezing the UI when they show secondary dialogs.
530 This fixed projects.maemo.org bug NB#64519.
532 2007-07-27 Murray Cumming <murrayc@murrayc.com>
534 * src/widgets/modest-header-view-render.c:
535 (_modest_header_view_compact_header_cell_data):
536 Some checks and initialization to try to deal with a crash,
537 probably ineffective.
539 2007-07-27 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/modest-maemo-utils.c:
542 (modest_maemo_utils_get_supported_secure_authentication_methods):
543 Make sure that we have a connection, asking the user for one
545 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
546 Check for a connection before showing the wizard, because
547 the wizard needs a connection to check for server capabilities.
549 2007-07-27 Murray Cumming <murrayc@murrayc.com>
551 * src/maemo/modest-account-view-window.c:
552 (on_new_button_clicked): Remember the wizard dialog instance,
553 so we can just present it again if necessary. This prevents
554 multiple windows from appearing if you click again quickly on the
555 New button before the dialog appears, fixing projects.maemo.org
558 2007-07-27 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
561 Offer a connection dialog if there is no connection when
562 starting modest. This should fix projects.maemo.org bug NB#61134.
564 2007-07-27 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
567 Reverted my last commit. I was able to fix the build by doing
568 apt-get install wpeditor0 (replacing other wpeditor packages) and
569 an explicit apt-get install wpeditor-dev to upgrade the -dev
572 2007-07-27 Murray Cumming <murrayc@murrayc.com>
574 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
575 Commented out the use of wp_text_buffer_replace_image()
576 because it does not exist, to break the build. Added a TODO for it.
578 2007-07-26 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-tny-account-store.c: (recreate_all_accounts):
581 Recreate them even if they were NULL before. I guess something
582 else was already creating them before, or this would never
584 (modest_tny_account_store_get_server_account): Make sure that
585 the tny accounts have been created before trying to find one.
586 This allows libmodest_dbus_client_compose_mail() to work
587 when the UI is not yet visible.
588 This is probably useful in other cases too.
590 (get_password): When the password is wrong after it is entered
591 in the protected password dialog, show an info banner (in an
592 idle handler) before showing the protected password dialog
595 2007-07-26 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-ui-actions.h:
598 * src/modest-ui-actions.c: Added
599 modest_do_refresh_current_folder() containing some code from
600 modest_ui_actions_on_send_receive().
601 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
602 Call modest_do_refresh_current_folder() before refreshing the
603 requested account, as in modest_ui_actions_on_send_receive().
604 This is strange, but seems to be necessary to show new mails.
605 Now new emails are finally visible in the UI when downloaded
606 via the automatic update interval, fixing bug NB#57458.
607 This also works because bug NB#57458 has been fixed somehow.
609 2007-07-26 Murray Cumming <murrayc@murrayc.com>
611 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
612 printf more details when we get unhandled D-Bus methods, because
615 * src/modest-mail-operation.c: (update_account_thread):
616 Comment out the tny_camel_pop_store_account_reconnect(), because this
617 is apparently no longer needed, and it did not work before anyway.
618 See the comment in the code.
620 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
621 by checking the header flags. This fixes projects.maemo.org bug
624 2007-07-25 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-maemo-utils.h:
627 * src/maemo/modest-maemo-utils.c: Added
628 modest_maemo_show_information_note_in_main_context_and_forget().
629 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
630 Use the new function to show simple error dialogs in the main
631 context, though question dialogs are still in the current context,
632 which is unfortunately usually not the main context. This should
635 2007-07-25 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account-store.c: (get_password):
638 Never save the entered username and password in gconf,
639 because the UI spec says we should not. This helps
640 slightly with projects.maemo.org bug NB#63671.
642 2007-07-25 Murray Cumming <murrayc@murrayc.com>
644 * src/widgets/modest-msg-edit-window.h:
645 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
646 Moved some code here to make it simpler.
647 (modest_msg_edit_window_attach_file_one): Renamed from
648 modest_msg_edit_window_attach_file_interactive().
649 (modest_msg_edit_window_offer_attach_file): Renamed from
650 modest_msg_edit_window_attach_file() and used
651 modest_msg_edit_window_attach_file_one() instead of
652 copy/pasting the code. The old code for one was not using
653 GnomeVFS. This allows use of smb:// URLs when using send-as
654 from external applications, fixing bug NB#63741.
656 (modest_msg_edit_window_insert_image),
657 (modest_msg_edit_window_add_attachment_clicked):
658 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
659 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
660 Adapted to the new function names.
662 2007-07-25 Murray Cumming <murrayc@murrayc.com>
664 (modest_platform_set_update_interval): Set the alarm recurrence
665 fields so that auto-update does not just happen the first time.
666 This should have fixed projects.maemo.org bug NB#63938.
668 When this happens you can see a printf when the D-Bus method is
670 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
672 However, I do not actually seem to get new POP messages even when
673 clicking the refresh button manually. A restart gets them.
674 This might be a problem in today's tinymail only.
676 2007-07-24 Murray Cumming <murrayc@murrayc.com>
678 * src/maemo/modest-maemo-global-settings-dialog.c:
679 (current_connection):
680 Avoid a crash (probably only in scratchbox) when strcmp()ing a
681 NULL when closing the dialog.
683 2007-07-24 Murray Cumming <murrayc@murrayc.com>
685 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
686 Remove the hacky send/receive that didn't work, and instead
687 refilter the treemodel to make the deleted email really vanish from
688 the UI (though the delete-from-menu code does has commented out
689 the code that does that). This fixes projects.maemo.org bug
692 2007-07-24 Murray Cumming <murrayc@murrayc.com>
694 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
695 Try a couple of tricks to force the treeview to update (
696 poke the folder, and do a send/receive refresh), but the deleted
697 email still appears with a strike-through instead of really being
700 2007-07-23 Murray Cumming <murrayc@murrayc.com>
702 * src/dbus_api/modest-dbus-callbacks.c:
703 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
704 because their ID is not human-readable (see the comment about
705 improvements needed to the osso-email-interface API) and
706 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
708 2007-07-23 Murray Cumming <murrayc@murrayc.com>
710 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
711 (add_folders_to_list), (on_dbus_method_get_folders),
712 (modest_dbus_req_filter):
713 * src/maemo/modest-maemo-utils.c:
714 (on_camel_account_get_supported_secure_authentication):
715 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
716 (on_header_view_focus_in):
717 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
718 * src/modest-formatter.c: (modest_formatter_create_body_part):
719 * src/modest-mail-operation.c: (recurse_folders),
720 (update_account_thread), (get_msgs_full_thread),
721 (modest_mail_operation_get_msgs_full),
722 (modest_mail_operation_xfer_msgs):
723 * src/modest-search.c: (search_mime_part_and_child_parts),
724 (modest_search_account), (modest_search_all_accounts):
725 * src/modest-tny-account.c:
726 (modest_tny_account_get_special_folder), (recurse_folders):
727 * src/modest-tny-local-folders-account.c:
728 (modest_tny_local_folders_account_query_passes):
729 * src/modest-tny-msg.c: (copy_mime_part),
730 (modest_tny_msg_find_body_part_from_mime_part):
731 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
732 (modest_tny_send_queue_try_to_send):
733 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
734 (_modest_ui_actions_open), (download_uncached_messages),
735 (reply_forward), (modest_ui_actions_on_copy),
736 (modest_ui_actions_on_details), (has_retrieved_msgs),
737 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
739 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
740 (_selected_msg_marked_as), (_msg_download_completed),
741 (_selected_msg_sent_in_progress):
742 * src/widgets/modest-attachments-view.c:
743 (modest_attachments_view_set_message):
744 * src/widgets/modest-msg-view.c: (find_cid_image):
745 * tests/check_folder-transfer.c: (find_folders):
746 * tests/check_update-account.c: (func):
747 * tests/dbus_api/test_get_folders.c: (main):
748 Checked all uses of tny_iterator_get_current(), making sure
749 that the object is unreferenced (3 or 4 places did not),
750 and adding checks for NULL.
752 2007-07-23 Murray Cumming <murrayc@murrayc.com>
754 * src/dbus_api/modest-dbus-callbacks.c:
755 (on_idle_open_default_inbox): Make sure that the application UI is
757 * src/maemo/easysetup/modest-easysetup-wizard.c:
758 (on_entry_invalid_character): Show the word whitespace instead
759 of (null) in the banner when whitespace was entered.
760 (show_error): Add a comment that this does not work in
761 Maemo Bora, though we do not know why.
763 2007-07-23 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-tny-account.c:
766 (modest_tny_account_get_special_folder): Use an if instead of
767 an assert for when the parent account name is NULL, because this
768 might be causing a crash in projects.maemo.org bug 63192.
769 * src/modest-mail-operation.c:
770 (modest_mail_operation_send_new_mail_cb),
771 (modest_mail_operation_remove_folder): unref the folder that is
772 returned from modest_tny_account_get_special_folder().
774 2007-07-23 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-ui-actions.c:
777 (modest_ui_actions_on_password_requested):
778 Show mail_ib_login_cancelled info banner when the user cancels
779 the protected password dialog, to fix projects.maemo.org
782 2007-07-23 Murray Cumming <murrayc@murrayc.com>
784 * src/maemo/modest-account-settings-dialog.c:
785 (create_page_outgoing): Put this page in a GtkScrolledWindow,
786 matching the UI mock-up in the UI spec, and allowing access
787 to all widgets even when the on-screen keyboard is active.
789 2007-07-23 Murray Cumming <murrayc@murrayc.com>
791 Reverted this previous commit from Johannes,
792 because the scrollbars are always visible and because
793 I think we only need it on onepage of the account
794 settings, not the account wizard.
795 (I wrote the wrong instructions in the bug.)
797 * src/maemo/easysetup/modest-easysetup-wizard.c:
798 Added scrollbars to account wizard dialog.
799 Fixed projects.maemo.org NB #62744
801 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
803 * src/maemo/easysetup/modest-easysetup-wizard.c:
804 (create_page_user_details):
805 Use auto-cap for name (projects.maemo.org NB#63716)
806 * src/widgets/modest-account-view.c: (on_account_busy_changed):
808 2007-07-22 Armin Burgmeier <armin@openismus.com>
810 * src/maemo/modest-ui-actions.c: Use current account instead of
811 default account for creating viewer windows, so that the viewer
812 window knows to which account the viewed message belongs.
814 * src/maemo/modest-msg-view-window.c: Destroy the window when the
815 corresponding account is deleted. This fixes projects.maemo.org bug
818 2007-07-18 Armin Burgmeier <armin@openismus.com>
820 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
821 the dialog close after entering an invalid port number and clicking
822 OK. This fixes projects.maemo.org bug NB#63602.
824 2007-07-18 Armin Burgmeier <armin@openismus.com>
826 * src/modest-tny-account-store.c:
827 (get_server_accounts): Set parent modest account name for each
828 connection-specific transport account so that special folders of such
829 an account can be looked up. This fixes a crash when changing account
830 settings. This might also be related to projects.maemo.org bug
833 2007-07-16 Armin Burgmeier <armin@openismus.com>
835 * src/modest-ui-actions.c: Added a button to create a folder to the
836 move-to dialog. This fixes projects.maemo.org bug NB#59863.
838 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
840 * src/maemo/easysetup/modest-easysetup-wizard.c:
841 Added scrollbars to account wizard dialog.
842 Fixed projects.maemo.org NB #62744
844 2007-07-16 Murray Cumming <murrayc@murrayc.com>
846 * src/widgets/modest-msg-view.h:
847 * src/widgets/modest-msg-view.c:
848 Added modest_msg_view_get_message_is_empty() but this needs
850 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
851 Check if there is any text in the message yet.
852 But this needs to be implemented properly.
853 (modest_msg_edit_window_toggle_find_toolbar):
854 * src/maemo/modest-msg-view-window.c:
855 (modest_msg_view_window_toggle_find_toolbar):
856 Show a banner warning if there is no text to search, when
857 trying to start a search. This partially fixes
858 projects.maemo.org bug NB#62350.
860 2007-07-13 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-mail-operation.c: (update_account_thread):
863 Initialized num_new_headers to fix the build.
865 2007-07-13 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
868 Ignore modest accounts whose server accounts don't exist in gconf.
869 This prevents us trying to create TnyAccount instances for those
870 server accounts when the server account has been removed from gconf,
871 but the parent modest account has not yet been removed from modest.
872 I don't know why this is only noticeable now. It was probably just
873 a harmeless g_warning() anyway.
875 2007-07-13 Murray Cumming <murrayc@murrayc.com>
877 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
878 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
880 2007-07-12 Armin Burgmeier <armin@openismus.com>
882 * src/maemo/modest-main-window.c: Make default account appear bold
883 in view, tools/send & receive and toolbar/send & receive SCM menus.
884 This fixes projects.maemo.org bug NB#59010.
886 2007-07-12 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
889 Add a short-cut, by checking if the folder store is an account.
890 This ensures that the Sort menu item and toolbar is dimmed for
891 the local-folders account root item, fixing
892 projects.maemo.org bug NB#62545.
894 2007-07-12 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-tny-account-store.c: (get_password):
897 Show the password dialog (via the signal) only in the mainloop, via
898 an idle handler that we wait for. This could theoretically prevent
899 hangs, though I worry that it could introduce some too.
901 2007-07-12 Murray Cumming <murrayc@murrayc.com>
903 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
904 * src/maemo/modest-platform.c:
905 (modest_platform_connect_and_wait):
906 Take a TnyAccount* parameter and try to set it to online
907 (a TnyCamel-only API), because tinymail sets accounts to offline
908 when the user cancels a password dialog, and doesn't ask again until
909 it has been set to online.
910 However, this is commented out because it causes a hang now.
912 (modest_platform_connect_and_wait_if_network_account):
913 * src/modest-mail-operation.c:
914 (modest_mail_operation_update_account):
915 * src/modest-platform.h:
916 * src/modest-ui-actions.c: (_modest_ui_actions_open),
917 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
919 2007-07-12 Armin Burgmeier <armin@openismus.com>
921 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
923 * src/modest-mail-operation.c:
924 * src/modest-ui-actions.c: Check for already existing folder before
925 querying the server, show error message from camel if the request
926 still fails. This fixes projects.maemo.org bug NB#58701.
928 2007-07-12 Murray Cumming <murrayc@murrayc.com>
930 * src/modest-tny-account-store.h:
931 * src/modest-tny-account-store.c:
932 Added modest_tny_account_store_forget_password_in_memory(),
933 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
934 when creating a new account, so that new passwords will be used, instead of
935 us thinking that it's a second request as a result of a failed password again.
937 2007-07-12 Murray Cumming <murrayc@murrayc.com>
939 * src/dbus_api/modest-dbus-callbacks.c:
940 (on_idle_open_message): If the message is in drafts then open it
941 in an edit window instead of a view window. This fixes
942 projects.maemo.org bug NB#63005.
944 2007-07-12 Murray Cumming <murrayc@murrayc.com>
946 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
947 Avoided a harmless g_warning().
949 2007-07-12 Murray Cumming <murrayc@murrayc.com>
951 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
952 Pass the modest account name, not the TnyAccount display name to
953 modest_msg_view_window_new() so that the reply feature works,
954 fixing projects.maemo.org bug NB#62892.
956 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
957 (modest_msg_view_window_new_with_header_model):
958 * src/maemo/modest-msg-view-window.c:
959 (modest_msg_view_window_new_with_header_model),
960 (modest_msg_view_window_new):
961 * src/modest-ui-actions.c: (reply_forward):
962 * src/widgets/modest-msg-view-window.h:
963 * src/widgets/modest-window.c: (modest_window_set_active_account):
964 Rename an account parameter to modest_account_name to make this clearer.
966 2007-07-11 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-ui-actions.h:
969 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
970 modest_do_message_delete().
971 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
972 Call modest_do_message_delete(), hoping that this would cause messages
973 to be really deleted from search instead of just marked with strike through.
974 Does not seem to help.
976 2007-07-11 Armin Burgmeier <armin@openismus.com>
978 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
979 priv->reselect to FALSE prior to calling
980 modest_folder_view_select_first_inbox_or_local() to prevent endless
981 recursion and thus a crash on startup.
983 2007-07-11 Armin Burgmeier <armin@openismus.com>
985 * src/maemo/modest-account-settings-dialog.h: Include
986 <gtk/gtknotebook.h> to fix the build (at least for me).
988 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
989 Use "New FolderN" as default suggested name if "New folder" already
990 exists, with N being the first free number, though never exceed "New
991 folder99" in which case we just fall back to "New Folder" even though
992 it already exists. This fixes projects.maemo.org bug NB#58663.
994 2007-07-11 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
997 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
998 projects.maemo.org bug NB#62778.
1000 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1003 Ignore the wrong (for now) secure-smtp setting in the presets -
1004 just default to requiring secure authentication for SMTP, because
1005 that is most common.
1007 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1009 * src/widgets/modest-folder-view.c: (filter_row)
1010 Do not show drafts folder (see UI specs)
1012 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
1014 * src/modest-ui-actions.c:
1015 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
1016 place and also not necessary.
1018 * src/widgets/modest-folder-view.c: (filter_row)
1019 Guess folder type and hide Sent & Outbox if necessary.
1020 Fixed project.maemo.org NB#57328
1022 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-ui-actions.h:
1025 * src/modest-ui-actions.c:
1026 (modest_ui_actions_on_delete_message):
1027 Move some code into a new
1028 modest_ui_actions_refresh_message_window_after_delete()
1029 function so we can use it from elsewhere.
1031 * src/dbus_api/modest-dbus-callbacks.c:
1032 (on_idle_delete_message), (on_delete_message): Used an idle
1033 handler, as we do for the other D-Bus method handlers.
1034 Call modest_ui_actions_refresh_message_window_after_delete()
1035 if the deleted message was open in a window. This fixed
1036 projects.maemo.org bug NB#62862.
1038 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-main.c: (main): Only show the UI at the start if
1041 the showui command line option was given. For instance,
1042 run-standalone src/modest showui
1043 Otherwise, we wait for the top_application D-Bus method to
1044 be sent by hildon-desktop when the application is selected
1046 This allows us to run without a UI when osso-global-search
1047 uses our D-Bus methods.
1049 2007-07-11 Murray Cumming <murrayc@murrayc.com>
1051 * src/dbus_api/modest-dbus-api.h: Added a define for a
1052 top-application D-Bus method.
1053 * src/dbus_api/modest-dbus-callbacks.c:
1054 (on_top_application),
1055 (modest_dbus_req_handler): Handle the top-application D-Bus
1056 method, which might be an undocumented D-Bus signal sent by
1057 hildon-desktop when it starts the application from the menu.
1058 But I am not sure and I need to test it on the device, because
1059 my scratchbox does not have the application in the menu now.
1060 This method shows the main window, so that it can be invisible
1061 when started, for instance, just for email searching from
1064 * src/maemo/modest-main-window.c: (restore_settings),
1065 (modest_main_window_new): Do not show the window immediately
1066 upon creation. We show it later.
1067 * src/modest-widget-memory.c: (save_settings_paned):
1068 Try (unsuccessfully) to avoid saving the paned position when
1069 it is not even visible.
1070 (restore_settings_paned): Do not allow a silly paned position.
1071 This seems necessary when not showing the window at first.
1073 * tests/dbus_api/Makefile.am:
1074 * tests/dbus_api/test_top_application.c: (main): Test for the
1077 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1079 * src/modest-ui-dimming-rules.c:
1080 (modest_ui_dimming_rules_on_new_msg),
1081 (modest_ui_dimming_rules_on_reply_msg),
1082 (modest_ui_dimming_rules_on_delete_msg),
1083 (modest_ui_dimming_rules_on_details),
1084 (modest_ui_dimming_rules_on_view_window_move_to),
1085 (modest_ui_dimming_rules_on_view_previous),
1086 (modest_ui_dimming_rules_on_view_next),
1087 (_invalid_folder_for_purge): Added checks before
1088 casting the window. This looks like an actual
1089 logic error in _invalid_folder_for_purge(), because it
1090 tries to use a ModestMainWindow as a message window.
1092 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1094 * src/maemo/modest-account-settings-dialog.c:
1095 (show_error): Use the same implementation as in
1096 modest-easysetup-wizard.c:
1097 (on_entry_invalid_character): The logical ID contains a %s.
1098 Guessed what it should be.
1099 (on_entry_max), (check_data), (on_response): Adapt to
1100 changed show_error().
1101 (create_page_account_details): Really call
1102 modest_validating_entry_set_func() on the correct widgets.
1103 * src/maemo/easysetup/modest-easysetup-wizard.c:
1104 (on_entry_invalid_character): Fix the logical ID here too.
1105 (create_page_account_details),
1106 (create_page_user_details):
1108 modest_validating_entry_set_func() on the correct widgets.
1110 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1111 Do not try to use the account if it is NULL.
1113 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1115 * src/modest-ui-actions.c: (create_move_to_dialog),
1116 (modest_ui_actions_on_main_window_move_to),
1117 (modest_ui_actions_on_msg_view_window_move_to):
1118 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1119 (filter_row), (modest_folder_view_show_non_move_folders):
1120 * src/widgets/modest-folder-view.h:
1122 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1123 the Sent folder yet as it does not report the correct folder type.
1125 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1127 * src/maemo/modest-msg-edit-window.c: (init_window):
1130 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1133 Take a parent widget instead of a parent window, and
1134 implement this with hildon_banner_show_information() instead.
1135 Non-Maemo builds can just ifdef that there.
1136 This fixed projects.maemo.org bug NB#62766.
1138 (on_entry_invalid_character): Use show_error() again instead
1139 of using hildon directly, and use the _CS() macro to use the correct
1141 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1142 Pass a widget instead od a window to show_error().
1144 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1147 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1148 This allows us to show the server name in the error message, fixing
1149 projects.maemo.org bug NB#62904.
1150 Also, use the appropriate logical ID message for the account protocol.
1152 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1155 A compilation fix, though the build wasn't broken for me.
1157 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1160 Do not try to unref a NULL folder store, to avoid a runtime warning.
1161 This seems to happen sometimes when changing accounts settings.
1163 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1165 * src/modest-tny-account-store.c:
1166 (modest_tny_account_store_instance_init),
1167 (modest_tny_account_store_finalize),
1168 (on_account_settings_hide), (on_idle_wrong_password):
1169 Use a GHashTable to ensure that we only show one account settings
1170 dialog per modest account. This avoids us having a dialog open for
1171 both the store and transport accounts, or due to repeated get_password()
1172 calls that shouldn't happen anyway.
1174 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/modest-maemo-utils.c: (on_hide),
1177 (modest_maemo_show_dialog_and_forget): Handle the response, because
1178 the window is not even hidden by default.
1180 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1181 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1182 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1183 which seems to prevent some modality problems.
1185 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1186 Ignore user cancellation errors.
1188 * src/modest-account-mgr-helpers.h:
1189 * src/modest-account-mgr-helpers.c:
1190 Added modest_server_account_get_password() and
1191 modest_server_account_get_has_password() to avoid direct use of
1194 * src/maemo/modest-account-settings-dialog.h:
1195 * src/maemo/modest-account-settings-dialog.c:
1196 (modest_account_settings_dialog_init): Store the notebook so we can
1198 Added modest_account_settings_dialog_switch_to_user_info().
1200 * src/modest-tny-account-store.c:
1201 (get_password): When the password in the account settings is wrong (we think),
1202 show the relevant page of the account settings dialog, in the mainloop.
1203 However, we currently get many of these at once because cancel does not
1205 (forget_password): Do not forget the password
1206 from the account settings, because this causes side-effects when
1207 tinymail seems to call it at strange time, maybe because of how we
1208 are cancelling get_password().
1209 (modest_tny_account_store_alert): Ignore user cancellations.
1211 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1213 * src/maemo/modest-maemo-utils.h:
1214 * src/maemo/modest-maemo-utils.c:
1215 Added modest_maemo_show_information_note_and_forget() for use instead of
1216 gtk_dialog_run() when the response is not needed, to avoid an extra
1217 mainloop which could cause a hang.
1219 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1220 Use the logical IDs for the error message, though they are not
1221 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1222 because gtk_dialog_run() caused a hang here (the window did not close).
1223 This fixes projects.maemo.org bug NB#62646.
1225 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1227 * src/modest-account-mgr-helpers.h:
1228 * src/modest-account-mgr-helpers.c:
1229 Added modest_account_mgr_get_store_protocol().
1231 * src/maemo/modest-account-view-window.c:
1232 (on_delete_button_clicked): Show different warning text depending on
1233 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1234 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1237 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1239 * src/maemo/modest-msg-edit-window.c:
1240 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1241 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1243 2007-07-07 Armin Burgmeier <armin@openismus.com>
1245 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1246 ckdg_ib_maximum_characters_reached from correct package.
1248 * src/modest-ui-actions.c: Show an error message when a folder could
1249 not be created. Tinymail does not give us specific error codes about
1250 what has gone wrong, so we assume that a folder with that name
1251 already exists, though there might be other reasons.
1253 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1256 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1257 give a more exact error message that can be partly translated.
1259 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1261 * src/maemo/modest-address-book.c:
1262 (select_email_addrs_for_contact): Specify a default window size for the
1263 select-email-address dialog, so that it is probably big enough for the
1264 title. This should fix projects.maemo.org bug NB#62277.
1266 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1268 * src/maemo/easysetup/modest-easysetup-wizard.c:
1269 (create_page_complete_easysetup): Use
1270 gtk_widget_set_size() request to ensure that the text wraps
1273 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1275 * src/maemo/easysetup/modest-easysetup-wizard.c:
1276 (on_entry_invalid_character), (create_page_account_details),
1277 (create_page_user_details):
1278 Use new API of ModestValidatingEntry. But for some reason the banner is
1279 not shown. I will have to investigate that further.
1281 * src/widgets/modest-validating-entry.c: (on_insert_text),
1282 (modest_validating_entry_set_func):
1283 * src/widgets/modest-validating-entry.h:
1284 Added a new callback function to be able to react to prevented
1285 characters whitespaces to e.g show a banner.
1287 2007-07-05 Armin Burgmeier <armin@openismus.com>
1289 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1290 notification of HildonNumberEditor instead of remembering the port
1291 number. Thanks to Johannes for pointing this out.
1293 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1295 * src/maemo/easysetup/modest-easysetup-wizard.c:
1296 Check if there are any user changes before showing a confirmation
1297 dialog (projects.maemo.org NB#60946)
1299 2007-07-05 Armin Burgmeier <armin@openismus.com>
1301 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1302 number at the beginning of the dialog and set the modified flag at the
1303 end if the port number has changed. This is necessary because
1304 HildonNumberEditor does not support notification when the value has
1307 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-ui-actions.c:
1310 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1311 a connection before asking anything else. Correct the check for the destination
1312 folder so that it succeeds when online.
1313 This fixed projects.maemo.org bug NB#61645.
1315 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1318 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1319 to fix projects.maemo.org bug NB#62439.
1321 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-tny-account.c: (on_connection_status_changed):
1324 Really do not use tny_device_force_offline() here. See the previous comment.
1326 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-tny-account.c: (on_connection_status_changed):
1329 Do not use tny_device_force_offline() when tinymail says that something
1330 went wrong with the connection. It seems to report this unnecessarily.
1332 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/modest-connection-specific-smtp-window.c:
1335 (modest_connection_specific_smtp_window_init):
1336 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1337 does not seem to have any effect in osso 1.1 (though it works in
1338 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1340 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1342 * src/maemo/modest-connection-specific-smtp-window.c:
1343 Fix UI specification problems with projects.meamo.org NB#60479
1345 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1348 clue when this has failed, because the error dialog is not always shown
1349 (at least in earlier version).
1351 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1352 GError message, because the generic error dialog is not helpful.
1354 'This message is not currently available (can't let a new connection go online)'
1355 when trying to open an IMAP message.
1357 (_modest_ui_actions_open): Offer a connection when some messages would
1358 have to be downloaded and we are offline.
1360 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1362 * src/widgets/modest-folder-view.c:
1363 Don't check for MERGE type anymore as we use the correct type
1365 NOTE: For the last two changes you need to update your tinymail copy
1366 because of API changes!
1368 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1370 * src/modest-tny-local-folders-account.c:
1371 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1372 (see projects.maemo.org NB#61580)
1374 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-tny-account.c: (on_connection_status_changed):
1377 Commented out the call to modest_platform_connect_and_wait() because this
1378 seems to always hang, and I would like to know if this is the only thing
1379 that causes a hang when showing the connection dialog.
1380 It is not very useful anyway.
1382 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1384 * src/maemo/modest-msg-view-window.c:
1385 (modest_msg_view_window_select_next_message):
1387 * src/modest-platform.h:
1388 * src/maemo/modest-platform.c:
1389 Added modest_platform_connect_and_wait(), which calls
1390 tny_maemo_conic_device_connect() always in the main thread, by calling it
1391 in an idle handler and waiting for the idle handler to run. It should be
1392 in the main thread because it uses GTK+ UI code. It just returns TRUE
1393 if the device is already online.
1395 There is some nasty code to ensure that subsequent calls to
1396 modest_platform_connect_and_wait() just wait for the first one to finish,
1397 by checking repeatedly in another idle handler. This is necessary,
1398 because other threads (or even the main thread, via another idle handler)
1399 can call modest_platform_connect_and_wait() while
1400 modest_platform_connect_and_wait() is running.
1402 (modest_platform_connect_and_wait_if_network_account),
1403 (modest_platform_connect_and_wait_if_network_folderstore):
1404 Convenience functions that calls modest_platform_connect_and_wait() if
1405 the account or folder might want network access.
1407 * src/modest-mail-operation.c:
1408 (modest_mail_operation_update_account):
1409 * src/modest-ui-actions.c: (download_uncached_messages),
1410 (modest_ui_actions_on_rename_folder), (delete_folder),
1411 (modest_ui_actions_on_main_window_move_to),
1412 (modest_ui_actions_on_msg_view_window_move_to):
1413 * src/widgets/modest-folder-view.c:
1414 (drag_and_drop_from_folder_view):
1415 Offer a connection if we are offline.
1417 * src/modest-tny-account.c: (on_connection_status_changed):
1418 Document this as only handling errors during network operations in progress,
1419 and replace the idle code with a simple call to
1420 modest_platform_connect_and_wait(), which does this instead.
1422 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1424 * src/modest-tny-account.c:
1425 (modest_tny_account_get_special_folder): (util_on_idle),
1426 Handle the GError so we can see when tny_folder_store_get_folders()
1427 fails, as it currently does while something else is connecting.
1429 Added util_run_in_main_thread_and_wait()
1430 which uses an idlen handler and mainloop to ensure that the function
1431 is called in the main thread.
1432 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1433 to make sure that we call attempt the connection in the mainloop only,
1434 which might solve some hangs.
1436 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1438 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1439 be found by their display name. This is never useful.
1440 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1441 by its ID, instead of trying to use its ID as its display name.
1443 * src/modest-tny-account-store.h:
1444 * src/modest-tny-account.c:
1445 (modest_tny_account_get_special_folder): Add a g_warning() when
1446 tny_folder_store_get_folders() returns an empty list for the maildir.
1448 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1449 Add a g_warning() when this returns NULL, because that it not allowed
1452 2007-07-02 Armin Burgmeier <armin@openismus.com>
1454 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1455 note when trying to cancel the wizard. This fixes projects.maemo.org
1458 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-tny-account.h:
1461 * src/modest-tny-account.c:
1462 (modest_tny_account_new_from_server_account),
1463 (modest_tny_account_new_from_server_account_name),
1464 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1465 because this must now be set before setting the proto. This is usd in
1466 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1467 warning in camel_session_get_service() caused by
1468 tny_camel_transport_account_prepare().
1470 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1473 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1475 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1477 (modest_connection_specific_smtp_edit_window_init):
1479 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1480 of "changed" for now
1482 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1484 * src/modest-tny-account.c:
1485 (modest_tny_account_new_from_server_account):
1486 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1487 now uses to request a connection when it needs one, and which it uses
1488 to tell us that something is wrong with the connection, so we can force
1489 the accounts offline to prevent further problems.
1491 * src/modest-defs.h:
1492 * src/modest-init.c: (init_default_settings):
1493 * src/modest-mail-operation.c:
1494 (modest_mail_operation_update_account):
1495 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1496 This should not be necessary anymore. Do not set the conf key that
1497 determined this (it was always TRUE and not set anywhere else).
1499 * src/modest-ui-actions.h: Remove unused and unimplemented
1500 modest_ui_actions_on_online_toggle_toggled().
1502 2007-06-29 Murray Cumming <murrayc@murrayc.com
1504 * src/maemo/modest-main-window.c: (connect_signals):
1505 Don't connect to delete_event twice. Maybe this was harmless.
1507 2007-06-29 Murray Cumming <murrayc@murrayc.com
1509 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1510 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1511 Debug output to give some more clue when a folder move is not allowed.
1513 2007-06-28 Murray Cumming <murrayc@murrayc.com
1515 * src/modest-tny-account.c: (on_modest_file_system_info),
1516 (modest_tny_account_get_mmc_account_name):
1517 Always call the callback, without checking whether the name has changed.
1518 * src/widgets/modest-folder-view.c: (strings_are_equal),
1519 (on_model_foreach_set_name), (on_get_mmc_account_name),
1520 (text_cell_data): Compare the name here, and use the name from
1521 the account rather than from the
1522 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1523 if the name was changed after the account was added to the model.
1524 That's a tinymail bug but not one that I want to fix now.
1526 This finally fixes projects.maemo.org bug NB#59301.
1528 2007-06-27 Armin Burgmeier <armin@openismus.com>
1530 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1533 2007-06-27 Murray Cumming <murrayc@murrayc.com
1535 * src/modest-tny-account.h:
1536 * src/modest-tny-account.c:
1537 Added modest_tny_account_get_mmc_account_name(), to set the memory
1538 card name asynchronously for the given account and then notify.
1539 (modest_tny_account_new_for_local_folders): Use this new function instead
1540 of using hildon_file_system_info_async_new() directly.
1542 * src/widgets/modest-folder-view.c: (text_cell_data):
1543 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1544 gtk_tree_model_row_changed() when it is available.
1546 This should fix projects.maemo.org bug NB#59301.
1548 2007-06-27 Murray Cumming <murrayc@murrayc.com
1550 * src/modest-mail-operation.c: (update_account_thread),
1551 (get_msgs_full_thread): Fix typo failures in the revert
1554 2007-06-27 Murray Cumming <murrayc@murrayc.com
1556 * src/maemo/modest-maemo-global-settings-dialog.c:
1557 (idle_select_default_focus):
1558 * src/modest-mail-operation.c: (idle_notify_progress),
1559 (idle_notify_progress_once), (set_last_updated_idle),
1560 (update_account_thread), (get_msgs_full_thread):
1561 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1562 * src/widgets/modest-header-view.c:
1563 (idle_notify_headers_count_changed_destroy),
1564 (idle_notify_headers_count_changed):
1565 Reverted the additions of gdk_threads_enter/leave(), in case this
1566 helps with a startup hang on the device.
1568 2007-06-26 Armin Burgmeier <armin@openismus.com>
1570 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1571 for supported secure authentication methods from server by
1572 gtk_dialog_run(), saving CPU time and a potential race condition.
1574 2007-06-26 Armin Burgmeier <armin@openismus.com>
1576 * src/maemo/modest-maemo-utils.h:
1577 * src/maemo/modest-maemo-utils.c: Added a
1578 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1579 only error code to tell the calling code when the user canceled the
1582 * src/maemo/modest-account-settings-dialog.h:
1583 * src/maemo/modest-account-settings-dialog.c:
1584 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1585 message if the retrieval of secure authentication methods was canceled
1586 by the user. Perform the check before saving anything to configuration
1587 to not end up with half-committed configuration changes, do not show
1588 a "Saving to configuration failed" note when authentication methods
1589 could not be retrieved.
1591 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1594 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1596 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1597 Only return the first level of folders under accounts, because the
1598 osso-global-search UI spec doesn't want the rest.
1599 This fixed projects.maemo.org bug NB#61811.
1601 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-tny-account-store.c:
1604 * src/modest-tny-account-store.h:
1605 Added modest_tny_account_is_memory_card_account().
1606 * src/maemo/modest-main-window.c: (create_details_widget):
1607 Show the same information items for the memory card as we show for the
1608 local-folders, to fix projects.maemo.org bug NB#59307.
1610 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-tny-account-store.c: (get_password):
1613 Added some checks for NULL to maybe prevent crashes, though I think
1614 it was Philip's last commit that actually prevented the crash here
1615 when creating a first new account.
1616 But the new account is still not usable (no messages are shown)
1617 until a restart of the application.
1619 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1621 * src/maemo/modest-maemo-global-settings-dialog.c:
1622 (idle_select_default_focus):
1623 * src/modest-mail-operation.c: (idle_notify_progress),
1624 (idle_notify_progress_once), (idle_notify_update_account_queue),
1625 (set_last_updated_idle), (update_account_thread),
1626 (notify_get_msgs_full), (get_msgs_full_destroyer),
1627 (get_msgs_full_thread):
1628 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1629 * src/widgets/modest-header-view.c:
1630 (idle_notify_headers_count_changed_destroy),
1631 (idle_notify_headers_count_changed):
1632 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1633 all idle handlers, because some other thread could be blocking
1634 the GDK lock, so that it can do GUI stuff.
1636 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1638 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1639 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1640 (on_idle_send_receive), (on_idle_open_default_inbox):
1641 * src/maemo/modest-msg-edit-window.c:
1642 (modest_msg_edit_window_attach_file_noninteractive):
1643 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1644 to prevent a hang. I don't quite understand why these are necessary,
1645 beause we should already be in the main loop. I guess something outside
1646 of the main loop is taking the lock.
1648 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1649 we are really using URIs, and use files that are more likely to exist.
1651 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1653 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1654 necessary because configure.ac now defines different variables.
1656 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1658 * libmodest-dbus-client/libmodest-dbus-client.c:
1659 * libmodest-dbus-client/libmodest-dbus-client.h:
1660 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1661 libmodest_dbus_client_compose_mail() is what things actually use.
1663 * src/dbus_api/modest-dbus-api.h:
1664 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1665 * tests/dbus_api/Makefile.am:
1666 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1669 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-init.c: (modest_init_local_folders):
1672 For memory-card (or other non local-folders) maildir accounts,
1673 always create an Archive folder, so that there is somewhere to put
1674 messages. This should be less confusing, because the user does not need
1675 to guess that the need to create a folder.
1677 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1679 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1680 Fixed icon size by using (50, 50) which is the same as defined by
1683 2007-06-25 Armin Burgmeier <armin@openismus.com>
1685 * src/widgets/modest-window-mgr.c:
1686 * src/modest-init.c:
1687 * configure.ac: Correctly recognize hildon-notify presence and fixed
1688 the build without it being installed.
1690 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1692 * libmodest-dbus-client/libmodest-dbus-client.c:
1693 (libmodest_dbus_client_search): Fix the build. Sorry.
1694 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1695 (reply_forward_cb): Initialize variables to fix the build.
1697 * src/modest-tny-account-store.c:
1698 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1699 comparison (a silly typo) so that email search results can be opened
1700 when there are more than one account.
1702 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1704 * libmodest-dbus-client/libmodest-dbus-client.c:
1705 (libmodest_dbus_client_search),
1706 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1707 instead of 1 second, because the search gets folders and messages from
1708 the server, which can take a long time. When it times out,
1709 osso-global-search will report no results.
1711 We need to specify whether we should search only cached information
1712 (maybe with a user preference), and the osso-email-search-plugin
1713 API should really be improved to allow that option, and to allow results
1714 to be delivered asynchronously in batches.
1716 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1719 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1720 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1722 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1724 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1725 that is an empty string. D-Bus seems to give us these instead of NULL.
1727 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1729 * src/dbus_api/modest-dbus-callbacks.c:
1730 * src/maemo/easysetup/modest-easysetup-wizard.h:
1731 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1732 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1733 (modest_connection_specific_smtp_edit_window_init):
1734 * src/maemo/modest-maemo-global-settings-dialog.c:
1736 * src/maemo/modest-maemo-utils.c:
1737 (modest_maemo_utils_setup_images_filechooser):
1738 * src/maemo/modest-main-window.c: (create_details_widget):
1739 * src/maemo/modest-msg-edit-window.c:
1740 (modest_msg_edit_window_attach_file_noninteractive),
1741 (modest_msg_edit_window_color_button_change),
1742 (modest_msg_edit_window_set_zoom):
1743 * src/modest-mail-operation.c: (update_account_thread):
1744 * src/modest-tny-account-store.c:
1745 * src/modest-tny-account.c:
1746 * src/widgets/modest-global-settings-dialog.c:
1747 * src/widgets/modest-window.h:
1749 Fixed build on bora!
1751 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1753 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1754 * src/modest-search.c: (modest_search_folder),
1755 (modest_search_all_accounts): Actually search only in the specified folder,
1756 doing a simple match on the folder ID.
1757 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1758 and added some documentation.
1760 2007-06-22 Armin Burgmeier <armin@openismus.com>
1762 * src/maemo/modest-maemo-utils.h:
1763 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1764 modest_maemo_utils_get_supported_secure_authentication_methods.
1766 * src/maemo/easysetup/modest-easysetup-wizard.c:
1767 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1768 one occured, not just "Server does not support secure authentication".
1770 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-tny-account-store.c: (get_password):
1773 Restored the call to tny_account_set_user() because Philip seems to have
1774 stopped this from crashing (by not using the freed string). It still does
1775 not work, but now we can test it.
1777 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1779 * src/maemo/modest-msg-edit-window.c: (init_window):
1780 Comment out use of an uninitialzed GtkScrolledWindow variable,
1781 to fix the build and stop a crash. Yet again.
1783 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1785 * src/modest-tny-account-store.c: (get_password):
1786 Remove the call to tny_account_set_user() because this actually crashes.
1787 As mentioned in the last commit, it is known to not work anyway.
1789 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-tny-account-store.c: (get_password):
1792 Use tny_account_set_username() to tell tinymail that the username might
1793 have changed too. But tinymail ignores this: see projects.maemo.org
1795 * src/modest-ui-actions.c:
1796 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1797 reset the connection when changing the username, and improve the comments.
1798 Save the changed username to gconf at least, so it is used when Modest is
1801 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1803 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1804 Do not use a query, so that we get all folders, including for POP and
1805 local-folders. They work as search criteria too.
1806 This fixes projects.maemo.org bug NB#57740.
1808 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1810 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1811 Comment out the use of hildon_notification_set_sound() because it is
1812 not declared, to fix the build. Warnings are serious, people.
1814 2007-06-21 Armin Burgmeier <armin@openismus.com>
1816 * src/maemo/modest-maemo-utils.h:
1817 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1818 modest_maemo_utils_get_supported_secure_authentication_methods()
1819 to query authentication methods for a specific user. This should fix
1820 projects.maemo.org bug NB#61369.
1822 * src/maemo/easysetup/modest-easysetup-wizard.c:
1823 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1826 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1828 * libmodest-dbus-client/libmodest-dbus-client.h:
1829 * libmodest-dbus-client/libmodest-dbus-client.c:
1830 (modest_dbus_message_iter_get_search_hit),
1831 (libmodest_dbus_client_search):
1832 Reorganised and commented this.
1833 Removed modest_search_hit_free() from the public API because it
1836 Added libmodest_dbus_client_get_folders() and
1837 modest_folder_result_list_free().
1839 * src/dbus_api/modest-dbus-api.h:
1840 * src/dbus_api/modest-dbus-callbacks.c:
1841 (modest_dbus_req_filter): Commented. Moved most code to
1842 on_dbus_method_search() and added on_dbus_method_get_folders().
1844 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1845 of the extra D-Bus handler.
1847 * tests/dbus_api/Makefile.am:
1848 * tests/dbus_api/test_get_folders.c: New test for
1849 libmodest_dbus_client_get_folders(). This seems to return an empty list
1850 at the moment. That could be the same error that causes the message list
1851 to be empty sometimes.
1852 This should help with projects.maemo.org bug NB#57740.
1854 2007-06-21 Armin Burgmeier <armin@openismus.com>
1856 * src/modest-mail-operation.c: Do not call
1857 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1858 notify the operation's end after having set the status to CANCELED for
1859 the operation queue to listen on. This fixes a deadlock when there
1860 were mail operations in the queue during its finalization.
1862 * src/modest-singletons.c: Reordered uninitialization of the account
1863 manager to happen after the mail operation queue was uninitialized
1864 because the mail operation's in the queue might still try to access
1865 the account manager (see modest_mail_operation_notify_end()). This
1866 fixes a potential crash when terminating the application.
1868 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-search.c:
1871 (search_mime_part_and_child_parts): Moved some code here so we
1872 can search recursively in child folders.
1873 (modest_search_folder): Search in the message as a mime part, instead
1874 of just its child mime parts.
1875 (read_chunk), (search_mime_part_ogs):
1876 Check how many bytes were read, to prevent an endless loop.
1877 Searching in message bodies now works. This finishes the fix for
1878 projects.maemo.org bug NB#61007.
1880 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1883 Add a g_warning when the item is not a folder.
1885 * src/modest-ui-dimming-rules.c:
1886 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1887 when selected item is not a folder (for instance, an account), because
1888 the UI spec only talks about folders.
1889 I am not sure what the UI spec wants, so this might not totally fix
1890 projects.maemo.org bug NB#60794.
1892 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1895 (load_from_file): Sort the list. The unsorted list would be more noticeable
1896 in non-English locales.
1898 * src/maemo/modest-msg-edit-window.c:
1899 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1900 warning and fix the build.
1902 * src/maemo/modest-progress-bar-widget.c:
1903 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1904 avoid a g_warning, and probably to avoid a crash.
1906 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1908 * src/modest-search.c: (modest_search_folder): Check for a GError
1909 when calling tny_folder_get_headers(), to show that this is not the cause
1912 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1914 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1915 Actually set the body query instead of the subject query.
1917 * src/modest-search.c: (search_mime_part_ogs),
1918 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1919 which would probably cause it to fail if we got this far.
1921 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1922 to simplify the code.
1923 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1924 be causing search-in-body to fail.
1926 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1928 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1930 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1931 Better debug message when the folder cannot be found.
1932 This should help with fixing projects.maemo.org bug #61287.
1933 * src/modest-search.c: (add_hit): Do not leak the furl string.
1935 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1937 * src/modest-ui-actions.c:
1938 (modest_ui_actions_on_folder_selection_changed):
1939 Do not special-case TNY_MERGE_FOLDER here, because
1940 modest_tny_folder_get_account() already does that. This fixes
1941 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1942 shown when the Outbox was selected).
1944 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1946 * libmodest-dbus-client/libmodest-dbus-client.c:
1947 (_dbus_iter_get_string_or_null): Initialize the string variable in
1948 case this helps with Dirk's crash.
1950 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1952 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1953 though it is not implemented yet (this function is maybe not even used),
1954 to avoid breaking ABI in future.
1955 * libmodest-dbus-client/libmodest-dbus-client.c:
1956 (get_attachments_string): Moved some code into this generic function.
1957 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1958 sends email. It is maybe not used.
1959 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1960 (on_send_mail): Use attachments.
1962 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1963 * src/maemo/modest-msg-edit-window.c:
1964 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1965 a filename before using it, to fix projects.maemo.org bug NB#58233.
1967 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1969 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1970 Initialize the continue_download variable to fix the build, and probably
1971 to fix randome behaviour.
1973 2007-06-18 Armin Burgmeier <armin@openismus.com>
1975 * src/modest-tny-send-queue.h:
1976 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1977 the queue so we can later show it in the UI. Replaced
1978 modest_tny_send_queue_msg_is_being_sent() by
1979 modest_tny_send_queue_get_msg_status().
1981 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1983 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1984 gpointer. This probably was not harmful, but just to be sure.
1986 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1989 Fix the build, but leave the function broken on Bora, because
1990 hildon_uri_action_get_service() does not exist.
1991 osso_uri_action_get_service() does not exist either, it seems.
1993 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-tny-account.c:
1996 (modest_tny_account_new_from_server_account):
1997 Uncommented the url debug output again, because it is useful for
1998 debugging, as I said in the comment.
2000 2007-06-18 Murray Cumming <murrayc@murrayc.com>
2002 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
2004 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
2005 for Mameo Bora, to fix the build.
2007 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
2010 Fixed build with hildon < 0.99
2012 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2013 Check if the selected account is busy instead of checking all accounts
2015 * src/modest-account-mgr-priv.h:
2016 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
2017 (modest_account_mgr_init), (compare_account_name),
2018 (modest_account_mgr_set_account_busy),
2019 (modest_account_mgr_account_is_busy):
2020 * src/modest-account-mgr.h:
2021 Added busy information to the account manager. It possible to
2022 set an account to busy or not busy now.
2024 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
2025 (modest_mail_operation_update_account),
2026 (modest_mail_operation_notify_end):
2027 Set the account to busy/not busy depending on the operation state.
2029 * src/widgets/modest-account-view.c:
2030 (modest_account_view_finalize), (get_last_updated_string),
2031 (update_account_view), (on_account_busy_changed), (init_view):
2032 Show string "Refreshing..." if the account is currently busy.
2034 All this fixes projects.maemo.org bug NB#59711
2036 2007-06-14 Armin Burgmeier <armin@openismus.com>
2038 * src/widgets/modest-attachments-view.h:
2039 * src/widgets/modest-attachments-view.c: Added
2040 modest_attachments_view_has_attachments() and fixed coordinate
2041 transformation in get_att_view_at_coords(). This fixes attachment
2044 * src/widgets/modest-msg-view.c: Make use of
2045 modest_attachments_view_has_attachments() to decide whether to show
2046 attachments in the header.
2048 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
2050 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2051 (on_change), (on_combo_security_changed),
2052 (modest_connection_specific_smtp_edit_window_init),
2053 (modest_connection_specific_smtp_edit_window_set_connection),
2054 (modest_connection_specific_smtp_edit_window_is_dirty):
2055 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2056 * src/maemo/modest-connection-specific-smtp-window.c:
2059 Show an comfirmation dialog for the smpt-edit-window if there are
2060 unsaved changes and the user hits cancel.
2061 (projects.maemo.org bug NB#60479)
2063 2007-06-14 Armin Burgmeier <armin@openismus.com>
2065 * src/maemo/easysetup/modest-easysetup-wizard.c:
2066 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
2067 address" info in banner instead of node, and select all the text as
2068 per UI spec. This fixes projects.maemo.org bug NB#60550.
2070 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
2072 reviewed by: <delete if not using a buddy>
2074 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
2075 * src/modest-ui-actions.c: (folder_refreshed_cb):
2077 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2079 * src/widgets/modest-folder-view.c: (filter_row):
2080 Explictly filter out the per-account outbox accounts. I don't know why
2081 these only sometimes show up, but now they should never show up in the UI.
2082 This should fix projects.maemo.org bug NB#60160.
2084 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2086 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
2087 when the toolbar does not exist yet.
2088 * src/modest-widget-memory.c: (save_settings_header_view):
2089 Added g_warnings() to help us to discover when we are trying to set
2090 an empty columns list in gconf.
2092 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2094 * src/modest-init.h:
2095 * src/modest-init.c:
2096 Added modest_init_get_default_header_view_column_ids().
2098 * src/modest-widget-memory.c: (restore_settings_header_view):
2099 Use the new function to get defaults, if the gconf key is empty,
2100 instead of not creating any columns. This seems to fix the
2101 empty right-hand pane problems.
2103 * src/widgets/modest-header-view.h: Improved documentation.
2105 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2107 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2108 Revert the use of the display name as the account name, because this
2109 is generally wrong and would break the code that follows.
2111 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2113 * src/maemo/easysetup/modest-easysetup-wizard.c:
2114 (check_for_supported_auth_methods), (on_before_next),
2117 More correct fix for projects.maemo.org bug NB# 58991
2118 Do not longer accept AUTH_PASSWORD as secure method and choose
2119 correct method when creating the account.
2121 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2123 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2124 Fixed projects.maemo.org bug NB# 58991
2126 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-init.c: (modest_init_init_core),
2129 (modest_init_local_folders): Fixed compilation errors.
2131 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2133 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2134 Remove unnecessary lib/include, though it is good in principle when needed.
2136 * src/modest-init.c: (modest_init_one_local_folder),
2137 (modest_init_local_folders):
2138 * src/modest-init.h: Initialize the .modest library for memory cards,
2139 instead of just doing nothing for them. This should allow us to create
2140 folders there, fixing projects.maemo.org bug NB#59297.
2142 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2144 * libmodest-dbus-client/libmodest-dbus-client.c:
2145 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2146 (libmodest_dbus_client_compose_mail),
2147 (libmodest_dbus_client_open_message),
2148 (libmodest_dbus_client_send_and_receive),
2149 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2151 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2152 (on_idle_open_message), (modest_dbus_req_handler),
2153 (search_result_to_message), (modest_dbus_req_filter):
2154 * src/modest-search.c: (add_hit), (modest_search_folder),
2155 (modest_search_all_accounts): Improved debug messages.
2157 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2159 * src/modest-tny-account-store.c:
2160 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2163 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2166 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2168 * src/modest-tny-account-store.c: (get_server_accounts):
2169 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2170 even when there are no accounts, so that the Outbox folder is always
2171 visible. This fixes projects.maemo.org bug NB#60158.
2173 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2175 * src/maemo/modest-main-window.c: (create_details_widget):
2176 Use the mcen_va_never logical ID.
2178 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2180 * src/dbus_api/modest-dbus-api.h:
2181 * src/dbus_api/modest-dbus-callbacks.c:
2182 (on_idle_open_default_inbox), (on_open_default_inbox),
2183 (modest_dbus_req_handler):
2184 Added a new OpenDefaultInbox method.
2186 * libmodest-dbus-client/libmodest-dbus-client.h:
2187 * libmodest-dbus-client/libmodest-dbus-client.c:
2188 Added libmodest_dbus_client_open_default_inbox() to call the new
2189 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2190 though it should maybe be used by a new osso-email-interface function.
2192 * tests/dbus_api/Makefile.am:
2193 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2196 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2198 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2199 NULL, so that the signals get all the keys. This should not actually
2200 change any behaviour because we currently update everything when anything
2203 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2205 * src/widgets/modest-folder-view.c: (text_cell_data),
2206 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2207 (find_inbox_iter): If tinymail tells us that the folder is
2208 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2209 This causes the inbox to be selected at startup, fixing part of
2210 projects.maemo.org bug NB#56305.
2212 * src/modest-ui-dimming-rules.c:
2213 (modest_ui_dimming_rules_on_tools_smtp_servers):
2214 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2215 the SMTP servers menu item.
2216 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2217 that the SMTP Servers menu item is dimmed when there are no accounts,
2218 as a future version of the UI spec will require. This fixes
2219 projects.maemo.org bug NB#56305.
2221 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2223 * src/maemo/modest-maemo-utils.c:
2224 (modest_maemo_utils_get_supported_secure_authentication_methods):
2225 Added label to dialog instead of unreadable title
2227 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2228 (modest_main_window_new):
2229 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2232 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2233 * src/modest-account-mgr.h:
2234 Added method to avoid code duplication
2236 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2237 (modest_ui_actions_on_send_receive):
2238 Use modest_account_mgr_has_accounts
2240 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2242 * src/maemo/easysetup/modest-presets.c:
2243 (modest_presets_get_info_server_security): Do not report secure auth
2245 * src/modest-protocol-info.c: Use the defines for the gconf key names
2246 for secure authentication. This was not working because we were writing
2247 Password and reading password, and the check was case sensitive.
2248 With this, gmail now works for receiving and sending when created via
2251 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2253 * src/maemo/easysetup/modest-presets.c:
2254 (modest_presets_get_info_server_security): Correct the key name for
2255 SecureSmtp, because it seems to be case-sensitive.
2256 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2257 Do not try to get the 0th notebook page if there are 0 pages, to
2258 avoid a g_warning().
2260 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2263 Prevent use of the new notification feature for now, because it currently
2264 shows one dialog for each new email, which is annoying.
2266 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2268 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2269 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2270 when no country was selected, so that we show the global ones.
2271 * src/maemo/easysetup/modest-presets.c:
2272 (modest_presets_get_providers): Return only the global providers, not
2273 all providers when mmc=0 was requested.
2275 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2277 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2278 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2279 provider ID in the combo.
2281 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2282 Do not show the page numbers, because it would be confusing when we add
2283 the 2 extra pages for the custom setup, when the user chooses the "Other"
2284 provider. This fixes projects.maemo.org bug NB#59028
2286 * src/modest-init.c: (modest_init_init_core),
2287 (modest_init_local_folders):
2288 * src/modest-init.h:
2289 * src/modest-tny-account.c:
2290 (modest_tny_account_new_for_local_folders): Do not create default folders
2291 for the memory card. This should fix projects.maemo.org bug NB#59328.
2293 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2296 Free the changed_conf_keys string items. They are already freed in the
2297 idle handler if that runs first.
2299 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2301 * src/modest-ui-actions.c:
2302 (modest_ui_actions_on_password_requested): Check that the server name
2303 is not NULL, because I just saw a password dialog with (null) as the
2306 * src/modest-tny-folder.[h|c]: Added
2307 modest_tny_folder_is_memory_card_folder().
2308 * src/modest-ui-dimming-rules.c:
2309 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2310 menu item for memory cards, as per the UI spec (section 7.4). This should
2311 fix projects.maemo.org bug NB#59297.
2313 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2315 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2316 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2317 is another problem with the code, see Murray's comment at line 772)
2319 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2322 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2323 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2324 (load_from_file), (easysetup_country_combo_box_init),
2325 (easysetup_country_combo_box_get_active_country_ids),
2326 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2327 instead of just one ID, to avoid duplicate country names in the UI.
2329 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2330 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2331 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2332 a single ID, avoiding duplicate providers.
2333 * src/maemo/easysetup/modest-easysetup-wizard.c:
2334 (on_combo_account_country): Adapt to use a list.
2336 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2338 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2339 keys changed in the last X seconds.
2341 * src/modest-account-mgr.h:
2342 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2343 (on_key_change), (modest_account_mgr_class_init),
2344 (modest_account_mgr_init), (modest_account_mgr_finalize):
2345 As the keys are changed, save them in a GSList* and signal that GSList*
2346 further every X seconds, to batch changes, to allow us to do just one
2347 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2348 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2350 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2351 changed signal signature.
2353 * src/modest-conf.c: (modest_conf_set_list),
2354 (modest_conf_on_change): Reenable notification.
2356 (modest_conf_maemo_fake_on_change): Comment out the hack that
2357 notified immediately instead of asynchronously.
2359 * src/widgets/modest-account-view.h:
2360 * src/widgets/modest-account-view.c:
2361 (update_account_view): Select the previously-selected account ID,
2362 if possible. This fixes projects.maemo.org bug NB#56933.
2364 (on_account_changed), (on_account_removed),
2365 (modest_account_view_select_account):
2367 Remove the block/unblock functions
2368 because they were not useful.
2370 * src/maemo/modest-account-view-window.c:
2371 (on_delete_button_clicked), (on_edit_button_clicked),
2372 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2374 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2376 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2377 Improve the error dialog to show Incorrect Account Settings, which seems
2378 clearer, and say that the internal error message (to be removed from the
2379 dialog later) is often misleading.
2380 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2382 * src/modest-tny-account.c:
2383 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2384 URL because this is so useful for debugging on the device.
2386 * src/widgets/modest-serversecurity-combo-box.c:
2387 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2389 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-mail-operation.c:
2392 (modest_mail_operation_send_new_mail):
2393 Added a comment about a nasty but apparently harmless message. Details
2394 added to the wiki g_warnings() page.
2396 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2399 (modest_tny_send_queue_class_init):
2400 Do not use the priv struct because it is empty, to avoid g_warnings
2401 about a non-existant priv struct.
2403 * src/modest-tny-account-store.c:
2404 (modest_tny_account_store_get_server_account),
2405 (modest_tny_account_store_get_transport_account_for_open_connection
2406 ): Do not try to get transport server accounts for local folders,
2407 because they don't have any. This avoids a g_warning().
2409 * src/maemo/modest-main-window.c:
2410 (modest_main_window_notify_send_receive_initied),
2411 (on_configuration_key_changed):
2412 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2413 * src/modest-defs.h:
2414 * src/modest-mail-operation.c:
2415 (modest_mail_operation_update_account):
2416 * src/modest-tny-account-store.h:
2417 * src/modest-tny-account.c:
2418 (modest_tny_account_get_special_folder),
2419 (modest_tny_account_new_for_local_folders),
2420 (modest_tny_account_new_for_per_account_local_outbox_folder):
2421 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2422 * src/modest-tny-local-folders-account.c:
2423 (add_account_folders_to_merged_folder):
2424 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2425 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2426 (modest_ui_actions_on_send):
2427 * src/widgets/modest-folder-view.c: (update_model):
2428 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2429 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2430 modest_tny_account_store_get_tny_account_by_account() to
2431 modest_tny_account_store_get_server_account() to make the code clearer.
2433 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2435 * src/dbus_api/modest-dbus-api.h:
2436 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2437 * src/maemo/modest-msg-edit-window.c:
2438 (modest_msg_edit_window_attach_file_noninteractive):
2439 added g_warning in case the file to be attached does not exist
2440 * tests/dbus_api/test_compose_mail.c: (main):
2441 removed obsolete comment, added generic files as test case
2443 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2445 * src/modest-tny-account-store.c: (get_server_accounts):
2446 Create the local folders account only once, not once for each outbox, and
2447 not only when there are some outboxes.
2449 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2451 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2452 code that is causing a crash at startup. Sergio says that he is fixing this.
2454 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2456 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2457 * src/maemo/modest-account-settings-dialog.c:
2458 (create_page_outgoing),
2459 (modest_account_settings_dialog_set_account_name),
2460 (save_configuration):
2461 - Fixed handling of the "Use secure authentication" toggle to comply with
2462 the ui specification. See also projects.maemo.org bug NB#58400
2464 - Restore the Secure connection setting combo correctly when loading
2467 * src/maemo/modest-maemo-utils.c:
2468 (on_camel_account_get_supported_secure_authentication),
2469 (modest_maemo_utils_get_supported_secure_authentication_methods):
2470 Fixed a crasher if operation is canceled
2472 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2473 (modest_protocol_info_auth_is_secure):
2474 * src/modest-protocol-info.h:
2476 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2477 the sense of the "Use secure authentication" toggle.
2479 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2481 * src/modest-tny-account-store.h:
2482 * src/modest-tny-account-store.c:
2483 Added modest_tny_account_store_get_local_folders_account().
2485 * src/modest-tny-folder.h:
2486 * src/modest-tny-folder.c:
2487 (modest_tny_folder_get_account):
2488 Added this replacement for tny_folder_get_account() which returns
2489 the local-folders account for TnyMergeFolders, to avoid the
2490 warning about the unimplemented get_account_func() vfunc().
2492 (modest_tny_folder_get_rules),
2493 * src/modest-ui-actions.c:
2494 (modest_ui_actions_on_folder_selection_changed):
2495 * src/modest-mail-operation.c:
2496 (modest_mail_operation_remove_folder),
2497 (modest_mail_operation_xfer_folder),
2498 (modest_mail_operation_rename_folder),
2499 (modest_mail_operation_get_msg),
2500 (modest_mail_operation_get_msgs_full),
2501 (modest_mail_operation_remove_msg),
2502 (modest_mail_operation_xfer_msgs),
2503 (modest_mail_operation_refresh_folder):
2504 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2506 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2508 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2509 (modest_server_account_set_security):
2510 * src/modest-defs.h: Add comments explaining that our
2511 UI spec means TLS when it says Normal, so these do not look like errors.
2513 * src/modest-tny-account.c:
2514 (modest_tny_account_new_from_server_account): Use the new tinymail
2515 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2516 for TLS. This should fix projects.maemo.org bug NB#58460.
2518 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2520 * src/maemo/easysetup/modest-easysetup-wizard.c:
2521 (create_account): Correct the position of the gconf sanity check warning.
2522 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2523 of using the g_idle_add() hack, because this does not seem to be necessary
2524 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2525 caused by something other than maemo's gconf.
2526 This fixes projects.maemo.org bug #59022.
2528 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2530 * src/modest-account-mgr-helpers.c:
2531 (modest_account_mgr_get_default_account): Do not check that the account
2532 exists if there is no default account (NULL), to fix a runtime warning.
2534 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2536 * src/widgets/modest-folder-view.c: (update_model):
2537 Do not unref the treemodel before we have finished with it.
2538 This prevents a valgrind warning and an occasional crash at startup.
2540 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2542 * libmodest-dbus-client/libmodest-dbus-client.h:
2543 added libmodest_dbus_client_compose_mail()
2544 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2546 added functions needed for SendAsMail() functionality
2547 * src/maemo/modest-msg-edit-window.c:
2548 (modest_msg_edit_window_attach_file_noninteractive):
2549 non interactively attaching files to message edit window
2550 * src/widgets/modest-msg-edit-window.h:
2551 * tests/dbus_api/Makefile.am:
2552 added test_compose_mail.c
2553 * tests/dbus_api/test_compose_mail.c: (main):
2555 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2557 * src/modest-account-view.c:
2558 Fixed bug projects.maemo.org bug NB#59307
2560 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2562 * src/maemo/easysetup/modest-easysetup-wizard.c:
2563 (get_serverport_incoming), (on_before_next), (create_account):
2564 * src/maemo/modest-account-settings-dialog.c:
2565 (modest_account_settings_dialog_set_account_name):
2566 * src/maemo/modest-maemo-utils.c:
2567 (on_camel_account_get_supported_secure_authentication_status),
2568 (on_camel_account_get_supported_secure_authentication),
2569 (on_secure_auth_cancel),
2570 (modest_maemo_utils_get_supported_secure_authentication_methods):
2572 Implemented security authentication for settings and easysetup.
2574 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2576 * src/maemo/modest-main-window.c: (create_details_widget):
2577 Show the total size for memory card accounts too, instead of showing
2578 the name again. Fixes bug projects.maemo.org bug NB#59307.
2580 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2583 * src/modest-tny-simple-folder-store.c:
2584 * src/modest-tny-simple-folder-store.h: Removed.
2586 * src/modest-tny-local-folders-account.h
2587 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2588 for the local-folders maildir, with an extra TnyMergedFolder containing
2589 the folders of the per-account outbox store accounts.
2590 * src/modest-tny-account-store.c: (get_server_accounts):
2591 Add the outboxes to the special local folders account after creating it.
2593 * src/modest-tny-account.c:
2594 (modest_tny_account_new_for_local_folders): Create the derived
2595 account when creating the main local-folders account.
2597 * src/maemo/modest-main-window.c: (create_details_widget),
2598 (modest_main_window_set_contents_style):
2599 Adapted to the use of the derived account instead of the folder store.
2601 * src/modest-ui-actions.c:
2602 (modest_ui_actions_on_folder_selection_changed):
2603 * src/modest-ui-dimming-rules.c:
2604 (modest_ui_dimming_rules_on_new_folder):
2605 * src/widgets/modest-folder-view.c: (text_cell_data),
2606 (icon_cell_data), (filter_row), (update_model),
2607 (get_cmp_rows_type_pos):
2610 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2611 Do not get the priv struct, because no priv struct has been set,
2612 to avoid a runtime warning.
2614 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2615 #ifelse with #else, to fix a warning, to fix the build.
2618 2007-06-05 Christian Kellner <ckellner@openismus.com>
2620 * libmodest-dbus-client/libmodest-dbus-client.c:
2621 Fix small typo in doc (why do you always see them
2622 AFTER committing stuff?)
2625 2007-06-05 Christian Kellner <ckellner@openismus.com>
2627 * libmodest-dbus-client/libmodest-dbus-client.c:
2628 (libmodest_dbus_client_search):
2629 Initialize hit list with NULL. Also set folder list
2630 to "" if NULL was supplied.
2633 2007-06-03 Christian Kellner <ckellner@openismus.com>
2635 * libmodest-dbus-client/libmodest-dbus-client.c:
2636 (modest_search_hit_list_free):
2637 Make it save to call it with NULL.
2639 * src/dbus_api/modest-dbus-callbacks.c:
2640 * src/modest-search.c:
2641 Return full ModestSearchHits as the search result list not TnyHeader
2642 since can't be around withouth the correspoding TnyFolder.
2644 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2646 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2647 Added currently commented code to check for secure auth
2649 * src/maemo/modest-account-settings-dialog.c: (on_response),
2650 (save_configuration), (show_ok):
2651 Fixed projects.maemo.org bugs NB #59248 and #59251
2653 * src/maemo/modest-maemo-utils.c:
2654 (on_camel_account_get_supported_secure_authentication_status),
2655 (on_camel_account_get_supported_secure_authentication),
2656 (modest_maemo_utils_get_supported_secure_authentication_methods):
2657 * src/maemo/modest-maemo-utils.h:
2658 Moved get_supported_secure_authentication() method here to be able
2659 to use it from easysetup wizard.
2661 * src/modest-pair.c: (on_pair_compare_as_string):
2662 Should compare string with first part of pair and not
2663 strcmp pairs which will crash.
2665 * src/modest-protocol-info.c:
2666 (modest_protocol_info_protocol_is_store):
2667 * src/modest-protocol-info.h:
2668 Added modest_protocol_info_get_auth_protocol_name()
2670 2007-06-03 Armin Burgmeier <armin@openismus.com>
2672 * src/modest-mail-operation.c:
2673 (modest_mail_operation_get_msgs_full): Set priv->account also when
2674 only retrieving a single message. This avoids a crash when canceling
2677 (modest_mail_operation_notify_end): Do not explicitely remove the
2678 operation from the queue but only emit the progress_changed signal.
2679 The queue itself listens to that signal to remove the operation when
2680 it is finished. This reduces coupling and removes a potential deadlock
2681 when modest_mail_operation_notify_end() is called from the queue
2682 itself. If that is a problem performance-wise, I would suggest to
2683 implement a status-changed signal or something.
2685 * src/modest-mail-operation-queue.c: Make sure to never call a
2686 function from another file while the queue is locked. This (hopefully)
2687 fixes another deadlock when exiting the application while retrieving
2690 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2692 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2693 Fixed build if libogs is not available
2695 2007-06-03 Christian Kellner <ckellner@openismus.com>
2697 * libmodest-dbus-client/libmodest-dbus-client.h:
2698 * libmodest-dbus-client/libmodest-dbus-client.c:
2699 (libmodest_dbus_client_delete_message):
2700 Implement deletion of messages (Client side).
2702 (modest_search_hit_free),
2703 (modest_search_hit_list_free):
2704 Utility functions to free the result hits.
2706 * src/dbus_api/modest-dbus-api.h:
2707 * src/dbus_api/modest-dbus-callbacks.c:
2708 (on_delete_message),
2709 (modest_dbus_req_handler):
2710 Implement deletion of messages (Server side).
2712 * tests/dbus_api/test_search.c: (main):
2715 * tests/dbus_api/Makefile.am:
2716 * tests/dbus_api/test_delete_message:
2717 Add little test for the message deletion logic
2719 2007-06-03 Armin Burgmeier <armin@openismus.com>
2721 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2722 when the operation queue was not empty. projects.maemo.org bug
2725 2007-06-03 Armin Burgmeier <armin@openismus.com>
2727 * src/widgets/modest-account-view.c
2728 (on_account_default_toggled): Toggle default account column
2729 explicitely instead of waiting for gconf notification (which is
2730 currently ignored). This should fix projects.maemo.org bug NB#56910
2731 for now. It should probably be removed when gconf notifications are
2734 2007-06-03 Christian Kellner <ckellner@openismus.com>
2736 * libmodest-dbus-client/libmodest-dbus-client.c:
2737 Removed debugging spew.
2739 * src/dbus_api/modest-dbus-callbacks.c:
2740 Added debugging info.
2742 * src/modest-search.c:
2743 (modest_search_all_accounts):
2744 Use tny_account_store_get_accounts () on the account store
2745 to get all accounts which is the way to get all accounts.
2747 * tests/dbus_api/test_search.c: (main):
2748 Make it possible to supply the search term on the command line.
2750 2007-06-03 Christian Kellner <ckellner@openismus.com>
2752 * libmodest-dbus-client/libmodest-dbus-client.c:
2753 * libmodest-dbus-client/libmodest-dbus-client.h:
2754 Implement searching for mesages over raw dbus. (Client side)
2756 * src/dbus_api/Makefile.am:
2757 * src/dbus_api/modest-dbus-api.h:
2758 * src/dbus_api/modest-dbus-callbacks.c:
2759 * src/dbus_api/modest-dbus-callbacks.h:
2760 Search framework (Server side). Also implement on_idle_open_message().
2762 * src/maemo/modest-platform.c: (modest_platform_init):
2763 Prepare for raw dbus/osso rpc interaction.
2765 * src/modest-search.h:
2766 Changed minsize from unspecific guint to guint32.
2768 * src/modest-search.c:
2770 Added strange hack which magically made tnymail work.
2772 (modest_search_folder),
2773 (modest_search_account),
2774 (modest_search_all_accounts):
2775 Implement helper functions to search all accounts, specific account
2778 * tests/dbus_api/Makefile.am:
2779 * tests/dbus_api/test_open_message.c:
2780 Read url to open from commandline.
2782 * tests/dbus_api/test_search.c:
2783 Implement small test for dbus search stuff
2785 2007-06-02 Armin Burgmeier <armin@openismus.com>
2787 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2788 include account type and account title. This fixes projects.maemo.org
2791 * src/maemo/modest-account-view-window.c: Set a title for the window.
2793 2007-06-02 Armin Burgmeier <armin@openismus.com>
2795 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2796 incoming and outgoing server name based on email address and server
2797 types as long as the names have not been edited manually. This fixes
2798 projects.maemo.org bug NB#58671.
2800 2007-06-02 Armin Burgmeier <armin@openismus.com>
2802 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2803 server type cannot be changed in future to the incoming details page
2804 when creating an account. This fixes projects.maemo.org bug NB#59029.
2806 2007-06-02 Armin Burgmeier <armin@openismus.com>
2808 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2809 and assigned max width chars so that they wrap instead of being
2810 truncated. Fixes projects.maemo.org bug NB#56126.
2812 2007-06-02 Armin Burgmeier <armin@openismus.com>
2814 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2815 introductory note to the connection specific smtp servers dialog, as
2816 section 8.12 of the email UI specification requires. This fixes
2817 projects.maemo.org bug NB#59212.
2819 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2821 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2822 Check for running mail operations, and offer to cancel them, as per the UI
2823 spec. This fixes projects.maemo.org bug NB#59041 .
2824 However, I suspect that tinymail may still use the network connection
2825 in ways that we cannot detect or cancel. But it should at least adapt to
2826 changes fairly well.
2828 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2830 * src/modest-tny-account-store.c: (recreate_all_accounts),
2831 (get_cached_accounts), (get_server_accounts): Do more sensible
2832 ref-counting of the temporarily-cached outbox accounts list. This seems
2833 to fix a crash when entering the password when the password was wrong.
2835 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2837 * src/gnome/modest-main-window.c: (connect_signals):
2838 * src/modest-tny-account-store.c: (get_password),
2839 (modest_tny_account_store_alert): Added comments and clues and
2840 commented-out code about how we currently fail to deal with connection
2841 errors and wrong passwords, and how we should.
2843 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2845 * src/widgets/modest-retrieve-combo-box.c:
2846 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2847 This fixes projects.maemo.org bug NB#58472 .
2849 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2851 * src/maemo/easysetup/modest-easysetup-wizard.c:
2852 (create_page_complete_easysetup):
2853 (create_page_complete_custom): Correct the last commit,
2854 putting the correct sentences in the correct pages.
2856 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2858 * src/maemo/easysetup/modest-easysetup-wizard.c:
2859 (create_page_complete_custom): Show the second sentence of text
2860 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2863 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2865 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2866 Set the leave-on-server conf key by default. This fixes
2867 projects.maemo.org bug NB#59258 .
2869 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2871 * src/maemo/modest-account-view-window.c:
2872 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2873 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2876 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/easysetup/modest-easysetup-wizard.c:
2879 (create_caption_new_with_asterisk):
2880 * src/maemo/modest-account-settings-dialog.c:
2881 (create_caption_new_with_asterisk):
2882 Uncomment the code to add the asterisk, because they are no longer in the
2883 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2884 (update_incoming_server_title): Add an asterisk here too.
2886 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2888 * src/maemo/modest-maemo-global-settings-dialog.c:
2889 (current_connection): Check that we are even connected before trying to
2890 get the current connection name, to prevent a warning.
2892 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2893 Change the comments because tny_maemo_conic_device_connect() is now meant to
2895 * src/modest-mail-operation.c:
2896 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2897 make sure we have a connection and fail if we can't connect.
2899 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2901 * src/maemo/modest-main-window.c:
2902 (on_account_store_connecting_finished): Do not try to get the
2903 connection ID if we are not really connected. I am surprised that
2904 this signal handler is called when we are not connected.
2906 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2908 * src/modest-error.h:
2909 * src/modest-ui-actions.c:
2910 (modest_ui_actions_get_msgs_full_error_handler):
2911 Renamed an enum, added comments, added an enum
2912 for retrieve-limit errors.
2914 * src/modest-mail-operation.c: (foreach_add_item),
2915 (internal_folder_observer_update), (update_account_thread),
2916 (modest_mail_operation_get_msgs_full):
2917 (modest_mail_operation_update_account),
2918 Added comments about how this works, and some code that should
2919 (but does not) check the retrieve-limit. See the TODO comment.
2921 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2923 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2924 Initialize help_id to fix the build. Warnings are good.
2926 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2928 * src/widgets/modest-hbox-cell-renderer.c:
2929 (modest_hbox_cell_renderer_append):
2930 * src/widgets/modest-vbox-cell-renderer.c:
2931 (modest_vbox_cell_renderer_append):
2932 Fix the last commit by doing an extra ref.
2934 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2936 * src/widgets/modest-hbox-cell-renderer.c:
2937 (modest_hbox_cell_renderer_append):
2938 * src/widgets/modest-vbox-cell-renderer.c:
2939 (modest_vbox_cell_renderer_append):
2940 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2941 to fix the build with Maemo Bora.
2942 However, there seems to be a remaining crash, probably due to reference
2945 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2947 * src/modest-tny-account.c:
2948 (modest_tny_account_new_for_local_folders):
2949 Use hildon_file_system_info_async_new() to get a better name for
2950 the memory card account, setting it as the account name.
2951 The timing seems to work, but this is probably
2952 not the best place to do this. See the TODO comment.
2953 * src/maemo/modest-main-window.c: (create_details_widget):
2954 * src/widgets/modest-folder-view.c: (text_cell_data):
2955 Use the tny account name instead of hardcoding a name.
2957 2007-05-30 Christian Kellner <ckellner@openismus.com>
2959 * src/modest-search.c: (modest_search):
2960 Correctly set part_search_func even if we have already parsed
2961 the query and thus a valid OgsTextSearcher object.
2963 2007-05-30 Christian Kellner <ckellner@openismus.com>
2966 Search and check for libogs.
2969 Incooparte the ogs build env.
2971 * src/modest-mime-part-search-stream.c:
2972 * src/modest-mime-part-search-stream.h:
2973 Removed since we do the real searching now in modest-search.c.
2975 * src/modest-search.c:
2976 * src/modest-search.h:
2977 Implement support for ogs. We use that if available and requested
2978 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2979 should now handle the corner case when the search term is spread
2980 across multiple reads.
2981 Also the logic in modest_search () was corrected to search all
2982 requested fields until one is found.
2984 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2986 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2988 * src/modest-init.h:
2989 * src/modest-init.c: Made modest_init_local_folders() take a
2990 path and be public so we can iniitialize maildir folders on
2993 * src/modest-local-folder-info.h:
2994 * src/modest-local-folder-info.c:
2995 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2997 * src/modest-tny-account.c:
2998 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2999 still means the standard local-folders path on the local volume.
3001 * src/modest-tny-account-store.c:
3002 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
3003 signal so we can detect mount/unmount of the MMC1 card, and do an update of
3004 all accounts when that happens.
3005 (get_server_accounts): If the MMC1 card is mounted, create a store account for
3006 this too, so it shows up in the treeview.
3008 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/modest-maemo-global-settings-dialog.c:
3011 (current_connection):
3012 * src/widgets/modest-global-settings-dialog.c:
3013 (current_connection_default):
3014 Use the enum values instead of 0, 1 and -1,
3015 to make the code clearer.
3017 * src/modest-account-mgr-helpers.c:
3018 (modest_account_mgr_get_connection_specific_smtp): Make this code
3021 * src/modest-runtime.h:
3022 * src/modest-runtime.c:
3023 Added modest_runtime_remove_all_send_queues().
3024 * src/maemo/modest-main-window.c:
3025 (on_account_store_connecting_finished): Recreate the send queues,
3026 using the appropriate transport accounts for this new connection.
3027 Some futher adapting might be needed if the old send queues are not
3028 automatically stopped at this point.
3030 * src/modest-tny-account-store.c: (get_server_accounts):
3031 Create the connection-specific transport accounts, so that they can
3032 be found later by their ID.
3034 * src/modest-tny-account.h:
3035 * src/modest-tny-account.c:
3036 Added modest_tny_account_new_from_server_account_name().
3037 modest_tny_account_new_from_server_account(): Do not create the
3038 send queues here, because they will be
3039 recreated anyway when the connection changes for the first time.
3041 2007-05-28 Murray Cumming <murrayc@murrayc.com>
3043 * src/modest-local-folder-info.h:
3044 * src/modest-local-folder-info.c:
3045 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3046 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3047 tbox_folder): Take a modest account name instead of a server TnyAccount,
3048 so we can have per-modest-account rather than per-transport-account
3050 We must make sure that we change or recreate the exisitng send queues
3051 when the connection changes for connection-specific transport accounts.
3053 * src/modest-tny-account-store.c:
3054 (create_per_account_local_outbox_folders): Create outboxed per modest
3055 account, not per transport account.
3057 * src/modest-tny-account.h:
3058 * src/modest-tny-account.c:
3059 (modest_tny_account_get_special_folder): For outboxes, get the
3060 parent modest account name. The account is ignored for other folders.
3061 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
3062 modest account name rather than a server TnyAccount.
3064 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3066 * src/modest-tny-account.c:
3067 (modest_tny_account_new_from_server_account):
3068 Call modest_runtime_get_send_queue() immediately after creating transport
3069 accounts, so that they start trying to send email from the outbox as soon
3070 as possible at startup. This is probably what we want.
3072 * src/modest-mail-operation.c: (update_account_thread):
3073 * src/modest-runtime.c: (modest_runtime_get_send_queue):
3074 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
3075 * src/modest-tny-send-queue.h:
3076 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
3077 (modest_ui_actions_on_send):
3078 Added comments about how sending works, though it needs some more work.
3080 2007-05-25 Murray Cumming <murrayc@murrayc.com>
3082 * src/modest-tny-account.c:
3083 (modest_tny_account_get_special_folder): Add TODO because this fails when
3084 the network is busy.
3085 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
3086 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
3087 Do not try to show this window when there is no active account. The UI
3088 specs does not tell us what to do in this case.
3090 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3094 * src/maemo/Makefile.am:
3095 * src/widgets/Makefile.am: Some dist fixes.
3097 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/modest-connection-specific-smtp-window.c:
3100 (on_button_edit): Make the code clearer, to prevent a double free.
3102 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/modest-account-settings-dialog.c:
3105 (modest_account_settings_dialog_set_account_name),
3106 Check the connection-specific smtp servers checkbox if there are any.
3108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3109 (modest_connection_specific_smtp_edit_window_init):
3110 Start with a suitable port number.
3112 * src/modest-account-mgr-helpers.h:
3113 * src/modest-account-mgr-helpers.c: Added
3114 modest_account_mgr_get_has_connection_specific_smtp().
3116 (modest_account_mgr_set_connection_specific_smtp),
3117 (modest_account_mgr_remove_connection_specific_smtp),
3118 (modest_account_mgr_get_has_connection_specific_smtp),
3119 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3120 connection-specific smtp server accounts in the account, rather than
3121 the server account conf dir.
3123 This fixes bug projects.maemo.org bug NB#58263 .
3125 * src/modest-tny-account-store.c:
3126 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3127 if there are no server accounts yet, to prevent an infinite loop when there
3128 are no accounts. Document that one must be called before the other.
3130 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3132 * src/modest-account-mgr-helpers.c:
3133 (modest_account_mgr_get_default_account): Make sure that at least
3134 one account is always the default, if there are any enabled accounts.
3135 This is just a sanity check that shouldn't be necessary.
3137 * src/modest-account-mgr-priv.c:
3138 (_modest_account_mgr_account_from_key): Unescape the conf key to
3139 get the real account name. For instance, this is an issue if a space
3140 was in the account name, which can happen because the account name
3141 is generated from the display name.
3142 (_modest_account_mgr_get_account_keyname): Always escape the
3144 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3145 Unescape the conf keys to get the real account names.
3147 For instance, previously the is-default radio button in the accounts
3148 list was not checked for any accounts at first. This fixes that,
3149 and might fix several similar bugs.
3151 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3153 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3154 Removed some debug printfs.
3156 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3158 Modest on-disk outbox directories are now here, for instance:
3159 $HOME/.modest/outboxes/<account-id-1>/outbox
3160 $HOME/.modest/outboxes/<account-id-2>/outbox
3162 $HOME/.modest/local-folders/outbox
3163 so we can have a separate outbox for each account.
3164 But they are shown as one outbox in the GtkTreeView, by using a
3165 TnyMergeFolder in a ModestTnySimpleFolderStore.
3168 * src/modest-tny-simple-folder-store.c:
3169 * src/modest-tny-simple-folder-store.h:
3170 Added ModestTnySimpleFolderStore, used to contain folders from
3171 other folder stores, such as other accounts.
3173 * src/modest-tny-outbox-account.h:
3174 * src/modest-tny-outbox-account.c:
3175 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3176 used for the per-account local outbox folders.
3178 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3179 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3180 only use this (internally) now for the non-outbox local folders.
3182 * src/modest-init.h:
3183 * src/modest-init.c: Added modest_init_one_local_folder(), for
3184 setting up the directory structure for each local folder.
3186 * src/modest-local-folder-info.c:
3187 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3188 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3190 * src/modest-local-folder-info.h:
3191 * src/modest-tny-account-store.c: (on_account_removed),
3192 (on_account_changed), (create_per_account_local_outbox_folders),
3193 (get_server_accounts), (modest_tny_account_store_get_accounts),
3194 (modest_tny_account_store_get_tny_account_by_account),
3195 (modest_tny_folder_store_is_virtual_local_folders):
3197 * src/modest-tny-account.h:
3198 * src/modest-tny-account.c:
3199 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3200 to create an on-disk per-account local outbox folder for each
3202 (create_per_account_local_outbox_folders): Create a local outbox folder
3203 for each transport account.
3204 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3205 for all local folders.
3207 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3208 instead of using g_object_get/set() directly. It is clearer.
3210 (modest_tny_folder_store_get_message_count),
3211 (modest_tny_folder_store_get_local_size
3212 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3213 because we now use these with non-acount folder stores.
3215 (modest_tny_account_get_special_folder),
3216 (modest_tny_account_new_from_server_account),
3217 (modest_tny_account_new_from_account):
3218 (recurse_folders): Adjust to the new outbox system.
3220 * src/modest-tny-folder.h:
3221 * src/modest-tny-folder.c:
3222 (modest_tny_folder_is_local_folder),
3223 (modest_tny_folder_get_local_folder_type),
3224 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3226 * src/widgets/modest-main-window.h:
3227 * src/maemo/modest-main-window.c: (create_details_widget),
3228 (modest_main_window_set_contents_style): Show details for any folder store,
3231 (modest_tny_folder_get_rules):
3232 Remove the const. C does not support constness enough for this.
3234 * src/modest-ui-actions.c:
3235 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3236 make all outboxes appear as one, in the usual local-folders tree node.
3238 (set_active_account_from_tny_account),
3239 (modest_ui_actions_on_folder_selection_changed):
3240 * src/widgets/modest-folder-view.c: (text_cell_data),
3241 (icon_cell_data), (filter_row),
3242 (add_account_folders_to_merged_folder),
3243 (add_account_folders_to_simple_folder_store), (),
3244 (get_cmp_rows_type_pos), (cmp_rows),
3245 (modest_folder_view_set_account_id_of_visible_server_account):
3246 Adjust to the new outbox system, using generic folder stores and folders
3247 in the GtkTreeModel.
3249 2007-05-23 Christian Kellner <ckellner@openismus.com>
3251 * src/modest-mail-operation.c:
3252 (modest_mail_operation_update_account):
3253 Use info->max_size instead of unintialized local var [small
3254 build fix]. (Added TODO to review that change since I don't
3257 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3259 * libmodest-dbus-client/libmodest-dbus-client.c:
3260 (libmodest_dbus_client_compose_mail): function added
3261 * src/dbus_api/modest-dbus-api.h:
3262 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3263 (on_compose_mail): Implementation of the SendAsMail functionality
3265 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3267 * src/modest-account-mgr.c:
3268 (modest_account_mgr_add_server_account): Set the secure-connection
3269 conf key for transport accounts as well as store accounts. I don't know
3270 why the if was there. For instance, this makes sure that we use SSL
3271 for the gmail preset from the easysetup wizard.
3273 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3275 * src/gnome/modest-main-window.c:
3276 (on_account_store_connecting_finished), (connect_signals):
3277 * src/maemo/modest-main-window.c:
3278 (on_account_store_connecting_finished), (connect_signals),
3279 (modest_main_window_new):
3280 Handle TnyAccountStore::connecting-finished instead of
3281 TnyDevice::connection-changed, because we cannot actually perform
3282 operations on accounts until TnyAccountStore has itself responded to
3283 the TnyDevice::connection-changed signal. This prevents a GError from
3285 Do not try to update at startup, because we (at least on scratchbox)
3286 already do an update at startup when the device goes online.
3287 This prevents a GError from tinymail.
3288 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3289 Added TODO about stopping simultaneous operations.
3291 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3293 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3294 * src/modest-mail-operation-queue.c:
3295 (modest_mail_operation_queue_remove):
3296 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3297 about where they happened.
3299 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3301 * src/modest-ui-actions.c:
3302 (modest_ui_actions_on_password_requested): Make sure that the remember
3303 output parameter is always TRUE.
3305 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3307 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3308 Show a OK/Cancel dialog if the error is a question, though we still do not
3309 know anything more about what we are asking the user.
3310 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3311 Fix an uninitialized variable (helper). This is a logic error, however.
3313 2007-05-21 Christian Kellner <ckellner@openismus.com>
3315 * src/modest-search.h:
3316 Correct bit shifting in the ModestSearchFlags enum.
3318 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3320 * src/modest-tny-account.c:
3321 (modest_tny_account_new_from_server_account): Do not use the lsub and
3322 check-all hard-coded IMAP options when using POP.
3324 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3326 * src/modest-tny-account.c:
3327 (modest_tny_account_new_from_server_account):
3328 Use NULL for the secure-auth method for POP when Password auth has been
3329 specified by the user, as we already do for IMAP. "auth=Login" causes
3330 an error from camel or the server.
3332 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3334 * src/maemo/modest-account-settings-dialog.c:
3335 (create_page_account_details),
3336 (modest_account_settings_dialog_set_account_name):
3337 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3338 for the leave-on-server checkbox, rathr than just the checkbox, when
3339 the protocol is not POP.
3341 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3343 * src/widgets/modest-account-view.c:
3344 * src/widgets/modest-account-view.h:
3345 Added modest_account_view_select_account() which will be useful later
3346 to asynchronously re-select the edited account.
3348 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/modest-account-settings-dialog.c:
3351 (modest_account_settings_dialog_set_account_name):
3352 Automatically choose the port numbers based on the secure authentication
3353 methods, if they have not been chosen before.
3354 This fixes projects.maemo.org bug NB#56273 .
3356 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3358 * src/maemo/modest-main-window-ui.h:
3359 * src/modest-ui-actions.c:
3360 * src/modest-ui-actions.h:
3361 Connect the Tools/SMTP Servers menu item to
3362 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3363 SMTP servers dialog, as in the UI specification and saves changes when it
3364 is closed. This fixed projects.maemo.org bug NB#56305 .
3366 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/modest-connection-specific-smtp-window.c:
3369 (modest_connection_specific_smtp_window_init):
3370 Use gtk_window_set_default_size() to make this window big enough, so
3371 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3373 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3375 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3376 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3377 (modest_connection_specific_smtp_edit_window_init),
3378 Do not try to connect to a combobox signal before the combobox exists.
3379 This fixes the cras in projects.maemo.org bug NB#56288 .
3380 (modest_connection_specific_smtp_edit_window_get_settings):
3381 Remove the server_account_name parameter which was being checked for NULL
3382 though it was not used.
3384 * src/maemo/modest-connection-specific-smtp-window.c:
3385 (modest_connection_specific_smtp_window_fill_with_connections),
3386 (on_button_edit), (modest_connection_specific_smtp_window_init):
3387 Correct the number of treemodel columns to prevent a warning.
3388 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3389 libconic does not work.
3391 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3393 * src/modest-tny-account.c:
3394 (modest_tny_account_new_from_server_account):
3395 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3396 SMTP when "None" was chosen by the user. However, with my SMTP server that
3397 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3400 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3402 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3403 to explain the memory management issue with the ID in the ModestPair.
3405 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3406 (add_sending_page), (modest_account_assistant_finalize):
3407 * src/gnome/modest-gnome-global-settings-dialog.c:
3408 (create_updating_page), (create_composing_page):
3409 * src/gnome/modest-msg-edit-window.c: (get_transports),
3410 (init_window), (modest_msg_edit_window_finalize),
3411 (modest_msg_edit_window_get_msg_data):
3412 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3413 * src/gnome/modest-transport-widget.c:
3414 (modest_transport_widget_finalize), (smtp_configuration):
3415 * src/maemo/modest-maemo-global-settings-dialog.c:
3416 (create_updating_page), (create_composing_page):
3417 * src/maemo/modest-msg-edit-window.c: (get_transports),
3418 (init_window), (modest_msg_edit_window_finalize),
3419 (modest_msg_edit_window_get_msg_data),
3420 (modest_msg_edit_window_free_msg_data):
3421 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3422 (modest_store_widget_finalize):
3423 * src/maemo/modest-transport-widget.c:
3424 (modest_transport_widget_finalize), (smtp_configuration):
3425 * src/modest-main.c: (send_mail):
3426 * src/widgets/modest-combo-box.h:
3427 * src/widgets/modest-global-settings-dialog-priv.h:
3428 * src/widgets/modest-global-settings-dialog.c:
3429 (modest_global_settings_dialog_finalize):
3430 * src/widgets/modest-msg-edit-window.h:
3431 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3432 as long as the combo box, to prevent use of freed memory for the ID.
3434 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3436 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3437 get_accounts(), to make this clearer. Do not check for the enabled gconf
3438 key, because we do not use this for server accounts (at least, not yet).
3439 This allows us to send email again.
3441 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3443 * src/maemo/modest-platform.c:
3444 (on_modest_conf_update_interval_changed), (modest_platform_init):
3445 Only respond to this particular key change. All these strcmp()s cannot be
3448 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3450 * src/maemo/modest-maemo-global-settings-dialog.c:
3451 (current_connection): Prevent a crash in scratchbox when
3452 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3453 * src/maemo/modest-platform.c:
3454 (on_modest_conf_update_interval_changed), (modest_platform_init):
3455 Get the update interval from gconf and reset it when the gconf key changes.
3457 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3459 * src/modest-protocol-info.c:
3460 * src/modest-protocol-info.h: Adde enum-specific get functions,
3461 instead of using a ModestProtocolType enum parameter.
3463 * src/gnome/modest-account-assistant.c:
3464 * src/gnome/modest-store-widget.c:
3465 * src/gnome/modest-store-widget.h:
3466 * src/gnome/modest-transport-widget.c:
3467 * src/gnome/modest-transport-widget.h:
3468 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3469 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 * src/maemo/modest-account-settings-dialog.c:
3472 * src/maemo/modest-account-settings-dialog.h:
3473 * src/maemo/modest-store-widget.c:
3474 * src/maemo/modest-store-widget.h:
3475 * src/maemo/modest-transport-widget.c:
3476 * src/maemo/modest-transport-widget.h:
3477 * src/modest-account-mgr-helpers.c:
3478 * src/modest-account-mgr-helpers.h:
3479 * src/modest-account-mgr.c:
3480 * src/modest-account-mgr.h:
3481 * src/modest-tny-account.c:
3482 * src/modest-tny-folder.c:
3483 * src/widgets/modest-account-view.c:
3484 * src/widgets/modest-retrieve-combo-box.c:
3485 * src/widgets/modest-retrieve-combo-box.h:
3486 * src/widgets/modest-secureauth-combo-box.c:
3487 * src/widgets/modest-serversecurity-combo-box.c:
3488 * src/widgets/modest-serversecurity-combo-box.h:
3489 * tests/check_account-mgr.c:
3490 Use the specific functions, and use the re-renamed enum values for GNOME too.
3492 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3494 * src/modest-pair.h:
3495 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3496 so we can get the second based on the first.
3498 * src/maemo/modest-account-settings-dialog.h:
3499 * src/maemo/modest-account-settings-dialog.c:
3500 Added get_supported_secure_authentication_methods(), though it is mostly
3501 commented-out for now until the necessary API is committed to tinymail.
3502 (modest_account_settings_dialog_set_account_name),
3503 (save_configuration): Request the supported authentication methods from the
3504 server, so we can choose a working method.
3506 * src/modest-tny-account-store.h:
3507 * src/modest-tny-account-store.c:
3508 (modest_tny_account_store_get_session): Rename from
3509 tny_account_store_get_session().
3511 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3513 * src/modest-protocol-info.h: Split the ModestProtocol enum
3514 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3515 There was no need to have these unrelated values in one enum.
3517 * src/: many files: Adapted to changed enum. This makes the code a bit
3518 clearer, and the compiler could catch some errors.
3520 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3522 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3523 Show the detailed internal camel error message when an error happens
3524 during the configuration, so that our testers can give us more clues.
3525 For instance, in projects.maemo.org bug NB#56910 .
3527 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3529 * src/modest-tny-account.c:
3530 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3531 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3533 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3535 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3536 * src/maemo/modest-account-settings-dialog.c:
3537 (modest_account_settings_dialog_set_account_name),
3538 (save_configuration): For the incoming secure authentication checkbox,
3539 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3540 the UI specification. PLAIN does not seem to be supported for most IMAP
3541 servers anyway, and I am not sure what it would mean.
3542 However, we probably need to discover which of the secure-authentication
3543 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3544 * src/modest-account-mgr-helpers.c:
3545 (modest_account_mgr_get_server_account_data):
3547 * src/modest-tny-account.c:
3548 (modest_tny_account_new_from_server_account):
3549 Use tny_account_set_mech() to set secure-authentication methods,
3550 with some special-casing for IMAP, based on my observations of how
3553 * src/modest-account-mgr-helpers.h:
3554 * src/modest-account-mgr.c:
3555 * src/modest-defs.h: Comment that the URI is only used for local folders.
3557 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3559 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3560 parameter const, just to be neat.
3561 * src/modest-text-utils.c: (modest_text_utils_inline):
3562 End g_strconcat() with NULL, as its documentation says. This is almost
3563 certainly the cause of my crash at startup on the device. Interestingly,
3564 valgrind doesn't tell us about these errors.
3566 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3568 * scripts/build-packages: Added more precise comments about how to use
3569 this script, though I still get this error:
3570 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3571 error building tinymail
3573 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3575 * src/maemo/modest-main-window.c: (on_account_update):
3576 Very slight cleanup, hoping to make it simpler to discover what causes
3577 a crash here sometimes.
3579 * src/modest-tny-account.c:
3580 (modest_tny_account_new_from_server_account): Set the port. Added
3581 comments about the options and a TODO comment because I need to find out
3582 how to specify the secure authentication method.
3584 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3586 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3587 changed CFlags paths form modest to libmodest
3589 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-account-mgr-helpers.c:
3592 (modest_account_mgr_get_server_account_data),
3593 (modest_account_mgr_free_server_account_data):
3594 * src/modest-account-mgr-helpers.h:
3595 * src/modest-account-mgr.c:
3596 (modest_account_mgr_add_server_account):
3597 * src/modest-defs.h:
3598 * src/modest-tny-account.c:
3599 (modest_tny_account_new_from_server_account):
3600 Determine the options for tny_camel_account_add_option() here,
3601 based on the settings, rather than storing them directly in gconf.
3603 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3605 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3606 Show a more friendly error dialog now that we expect (from the tinymail
3607 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3609 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3611 * src/maemo/modest-main-window.c: (on_account_update): Check that
3612 account_name is not NULL, to prevent a crash at startup that I am
3613 seeing on the N800. I do wonder why it is NULL.
3615 * src/maemo/easysetup/modest-easysetup-wizard.c:
3616 (create_page_user_details):
3617 * src/maemo/modest-account-settings-dialog.c:
3618 (create_page_user_details), (create_page_outgoing):
3619 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3620 (modest_connection_specific_smtp_edit_window_init):
3621 * src/modest-ui-actions.c:
3622 (modest_ui_actions_on_password_requested):
3623 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3624 might do something useful with the on-screen keyboard.
3626 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3628 * src/maemo/modest-main-window.c: (on_account_update):
3629 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3630 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3632 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3634 * src/modest-tny-account-store.c: (on_account_changed):
3635 Correct the signature of this signal handler.
3637 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3639 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3640 Show a HildonNote instead of a GtkDialog for Maemo.
3642 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3644 * src/widgets/modest-account-view.h:
3645 * src/widgets/modest-account-view.c: (on_account_changed),
3646 (on_account_removed). Added a boolean flag, set/unset by
3647 modest_account_view_block_conf_updates(),
3648 modest_account_view_unblock_conf_updates() to prevent unnecessary
3649 updates, but this is not very useful because the gconf notifications are
3650 so delays (maybe only on Maemo Bora).
3651 So auto-updating is turned off, and these functions do an explicit
3652 update when necessary.
3653 However, something else is still doing too much work when adding/removing
3654 accounts, probably in another part of the application.
3656 * src/maemo/modest-account-view-window.c:
3657 (on_delete_button_clicked), (on_edit_button_clicked),
3658 (on_new_button_clicked): Use the new functions.
3660 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3662 * src/modest-account-mgr-helpers.c:
3663 (modest_account_mgr_set_first_account_as_default):
3664 Sort the list of names alphabetically-by-title, so we choose the first one
3666 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3667 alphabetically by the title.
3669 This fixes projects.maemo.org bug NB#56418 .
3671 * src/modest-account-mgr-priv.c:
3672 (_modest_account_mgr_account_from_key):
3673 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3674 avoid a valgrind error, and possible random behaviour.
3676 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3678 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3679 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3680 tinymail documentation to say that this can be expected.
3681 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3682 pretty, and should not happen, but I would prefer to know when it does.
3684 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3686 * configure.ac: When using the older hildon version, probably on Bora,
3687 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3689 * src/widgets/modest-attachment-view.c:
3690 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3693 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3695 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3696 Implemented the prototype. Can be tested with
3697 tests/dbus_api/test_open_message:
3699 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3701 * src/modest-tny-account-store.c:
3702 (modest_tny_account_store_instance_init), (get_password):
3703 * src/modest-ui-actions.c:
3704 (modest_ui_actions_on_password_requested):
3705 Do not store the password in gconf, because this function is called
3706 for non-remembered passwords. Actually use the cached (in the hash map)
3707 password instead of releasing it.
3708 The password will now not be remembered if it is asked via the protected
3709 password dialog, as per the UI spec.
3711 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3713 * src/modest-defs.h:
3714 * src/modest-account-mgr-helpers.h:
3715 * src/modest-account-mgr-helpers.c:
3716 Added modest_server_account_get_username_has_succeeded(),
3717 modest_server_account_set_username_has_succeeded().
3718 (modest_server_account_set_username),
3719 Reset the has-succeeded flag if the username changes.
3721 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3722 * src/maemo/modest-connection-specific-smtp-window.c:
3723 (modest_connection_specific_smtp_window_save_server_accounts):
3724 Use modest_server_account_set_username() instead of using
3725 modest_conf_set_string() directly, so that the has-succeeded flag is always
3728 * src/modest-ui-actions.c:
3729 (modest_ui_actions_on_password_requested): Dim the username entry if
3730 the username has ever worked, as per the UI spec.
3732 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3734 * src/modest-tny-account-store.c: (get_password):
3735 * src/modest-ui-actions.c:
3736 (modest_ui_actions_on_password_requested):
3737 Allow the username to be changed too, though there is more work to
3738 be done on exactly how this behaves.
3740 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3742 * src/modest-account-mgr-helpers.h:
3743 * src/modest-account-mgr-helpers.c:
3744 Added modest_account_mgr_get_display_name(),
3745 modest_server_account_get_username(),
3746 modest_server_account_set_username(),
3747 modest_server_account_set_password(),
3748 modest_server_account_get_hostname() functions so we do not need to
3749 use the conf API directly.
3751 * src/maemo/modest-main-window.c: (connect_signals):
3752 Actually connect ot the ModestAccountStore::request-password signal,
3753 so that we show the dialog when the password is requested by Tinymail,
3754 for isntance if it is empty.
3756 * src/modest-marshal.list:
3757 * src/modest-tny-account-store.c:
3758 (modest_tny_account_store_class_init), (get_password),
3759 (modest_tny_account_store_alert):
3760 * src/modest-tny-account-store.h:
3761 * src/modest-ui-actions.h:
3762 * src/modest-ui-actions.c:
3763 (modest_ui_actions_on_password_requested):
3764 Change the signal parameters, so it is obvious that we are providing
3765 the non human-readable server name, and receiving both the username
3766 and password, though changing of the username is not yet implemented.
3767 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3768 for the GNOME version.
3770 This should fix the projects.maemo.org bug NB#56209, though it does not
3771 work on Bora, because the gconf_client_get() for the password fails
3772 immediately after we save it with gconf_client_set().
3774 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3777 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3778 caused an undefined symbol error:
3779 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3781 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3783 * src/modest-tny-account-store.c:
3784 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3785 using a GError instead of a string message, so we can translate it in
3788 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3790 * src/maemo/modest-address-book.c:
3791 (modest_address_book_check_names):
3792 * src/maemo/modest-msg-view-window.c:
3793 (modest_msg_view_window_clipboard_owner_change):
3794 * src/modest-init.c: (modest_init_init_ui):
3795 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3796 (update_folders_cb), (modest_mail_operation_update_account):
3797 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3798 (modest_ui_actions_on_msg_attachment_clicked),
3799 (modest_ui_actions_on_msg_recpt_activated):
3800 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3801 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3802 (modest_msg_view_search_next):
3803 * src/widgets/modest-recpt-editor.c:
3804 (modest_recpt_editor_on_button_release_event),
3805 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3806 g_message(). At this point we should only be seeing interesting errors on
3807 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3809 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3811 (modest_wizard_dialog_force_title_update):
3812 * src/maemo/easysetup/modest-wizard-dialog.h:
3813 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3814 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3815 can update the title when appropriate. Otherwise the title is wrong if the
3816 pages are added after adding the notebook to the dialog.
3817 This must be a problem in HildonWizardDialog too.
3818 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3820 * src/maemo/easysetup/modest-easysetup-wizard.c:
3821 (create_subsequent_customsetup_pages),
3822 (create_subsequent_easysetup_pages):
3823 Call modest_wizard_dialog_force_title_update() so that the title is
3824 correct even with GTK+ < 2.10.
3825 This fixes projects.maemo.org bug NB#56145 .
3827 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3829 * src/maemo/modest-platform.c:
3830 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3831 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3834 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3836 * src/widgets/modest-window.h:
3837 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3838 and modest_window_save_state(), which invokes it.
3840 * src/widgets/modest-window-mgr.h:
3841 * src/widgets/modest-window-mgr.c:
3842 Added modest_window_mgr_save_state_for_all_windows(), which calls
3843 the save_state vfunc on all registered windows, if implemented.
3845 * src/gnome/modest-msg-edit-window.c:
3846 * src/gnome/modest-msg-view-window.c:
3847 * src/maemo/modest-msg-edit-window.c:
3848 * src/maemo/modest-msg-view-window.c:
3849 * src/maemo/modest-main-window.c:
3850 Specify the existing save_settings functions as implementations of
3851 ModestWindow::save_state_func().
3853 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3854 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3855 enabling hibernation, for instance.
3857 We may need to do the same thing for restoring settings.
3860 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3862 * src/widgets/modest-window-mgr.c:
3863 * src/widgets/modest-window-mgr.h:
3864 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3865 modest_window_mgr_get_hibernation_is_prevented().
3867 * src/maemo/modest-main-window.c:
3868 (on_hildon_program_is_topmost_notify): Prevent hibernation
3869 (possible when the application goes to the background in the WM),
3870 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3872 * src/maemo/easysetup/modest-easysetup-wizard.c:
3873 (modest_easysetup_wizard_dialog_init):
3874 * src/maemo/modest-account-settings-dialog.c:
3875 (modest_account_settings_dialog_init):
3876 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3877 (modest_connection_specific_smtp_edit_window_init):
3878 * src/maemo/modest-connection-specific-smtp-window.c:
3879 (modest_connection_specific_smtp_window_init):
3880 * src/maemo/modest-signature-editor-dialog.c:
3881 (modest_signature_editor_dialog_init):
3882 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3883 prevent hibernation while any of these account settings dialogs are open.
3885 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/Makefile.am:
3888 * src/maemo/modest-osso-state-saving.c:
3889 * src/maemo/modest-osso-state-saving.h: Added
3890 modest_osso_load_state() and modest_osso_save_state() though they do
3891 nothing now. They should iterate through all the open windows and load/save
3893 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3894 save state when closing.
3896 * src/maemo/modest-main-window.c:
3897 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3898 Add a notification handler for the HildonProgram::is-topmost property,
3899 so we can allow hibernation when the application goes into the background.
3900 But we still need to detect when the accounts setup windows are open so
3901 we can stop hibernation when they are open.
3902 To do this, I also added the main window the HildonProgram. This might have
3903 other side-effects/benefits, and should maybe be done for other windows.
3905 * src/maemo/modest-osso-autosave-callbacks.h:
3906 * src/maemo/modest-osso-autosave-callbacks.c:
3907 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3908 though it does not do anything yet, and we might never need this to do
3909 anything. For instance, we already save drafts.
3911 * src/maemo/modest-platform.c: (modest_platform_init):
3912 Specify the libosso auto-save callback.
3914 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3916 * src/maemo/modest-platform.c:
3917 (modest_platform_set_update_interval):
3918 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3919 aparently stays valid between application instances, so we can use this
3920 to remove and reset it later. According to a maemo-developers email from
3923 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3925 * configure.ac: Depend on libalarm for Maemo.
3927 * src/dbus_api/modest-dbus-api.h:
3928 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3929 (on_send_receive), (modest_dbus_req_handler):
3930 Handle a SEND_RECEIVE D-Bus method.
3932 * libmodest-dbus-client/libmodest-dbus-client.c:
3933 (libmodest_dbus_client_send_and_receive):
3934 * libmodest-dbus-client/libmodest-dbus-client.h:
3935 Add C convenience functions for calling the new D-Bus method.
3937 * src/modest-platform.h:
3938 * src/gnome/modest-platform.c:
3939 * src/maemo/modest-platform.c:
3940 Added modest_platform_set_update_interval(), which uses the
3941 alarmd API on Maemo.
3942 (modest_platform_init),
3943 Call modest_platform_set_update_interval(), using a hard-coded
3944 interval for now (until the global settings dialog is implemented),
3945 though I am not sure that this makes sense yet.
3947 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3949 * src/dbus_api/modest-dbus-callbacks.c:
3950 (modest_osso_cb_hw_state_handler):
3951 * src/dbus_api/modest-dbus-callbacks.h:
3952 * src/maemo/modest-platform.c: (modest_platform_init):
3953 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3954 in case this has some effect on the ability for Maemo to ping the
3957 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3959 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3960 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3961 warning. It is probably a logic error, but I need to fix the build.
3963 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3965 * src/modest-account-mgr.h:
3966 * src/modest-account-mgr.c:
3967 (modest_account_mgr_account_names): Add a gboolean enabled_only
3968 parameter, so we can get lists of onlt the enabled accounts.
3970 (modest_account_mgr_add_account),,
3971 (modest_account_mgr_account_with_display_name_exists):
3972 * src/maemo/modest-msg-edit-window.c: (get_transports):
3973 * src/modest-account-mgr-helpers.c:
3974 (modest_account_mgr_set_first_account_as_default):
3975 * src/modest-init.c: (init_default_account_maybe):
3976 * src/modest-tny-account-store.c: (get_accounts):
3977 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3978 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3979 * tests/check_account-mgr.c: (START_TEST):
3980 Provide the extra parameter, as appropriate.
3982 * src/widgets/modest-account-view.c: (update_account_view):
3983 Do not show disabled accounts (meaning that there is no way to
3984 enable/disable accounts in the UI (the feature is not in our UI
3985 specification), so we can use this internally only to mark unfinished
3986 or temporary account data.
3988 * src/maemo/easysetup/modest-easysetup-wizard.c:
3989 (create_account): Add boolean enable parameter, so we can specify FALSE
3990 to create the temporary account.
3991 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3992 (on_before_next): When finishing, when there is a temporary account, just
3994 Also, use a timeout to delay the showing of the dialog until gconf is likely
3995 to return correct information, due to a maemo gconf bug that is fixed in
3996 osso 1.1, but not yet in Bora.
3997 However, the dialog stays on screen after it is destroyed.
3999 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
4000 for invalid data when cancelling. Use a hildon note instead of a dialog
4001 to complain about invalid data. Do not show the account-saved note if the
4002 account is disabled (a temporary account that will not really be saved for use
4005 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4007 * src/modest-account-mgr-helpers.h:
4008 * src/modest-account-mgr-helpers.c:
4009 Added modest_account_mgr_unset_default_account(),
4010 Added modest_account_mgr_set_first_account_as_default().
4012 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
4013 If it was the default account, unset the default account name.
4015 * src/maemo/modest-account-view-window.c:
4016 (on_delete_button_clicked): If it was the default account,
4017 set the first remaining account as the default instead.
4019 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
4020 a NULL account or a NULL default account, to prevent a crash. This should
4021 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
4024 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4026 * src/widgets/modest-recpt-editor.c:
4027 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
4028 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
4029 TODO comment for this. This fixes the build.
4031 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
4032 be the best place for it. This will in future update all auto-update accounts,
4033 rather than just the current/default account, when that gconf key exists.
4034 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
4035 if there are no accounts, before calling do_send_receive().
4036 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
4038 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
4039 * src/maemo/modest-main-window-ui.h:
4040 * src/maemo/modest-main-window.c: (on_connection_changed),
4041 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
4042 directly, becaue the signal handler does more.
4044 2007-04-30 Murray Cumming <murrayc@murrayc.com>
4046 * src/modest-account-mgr-helpers.c:
4047 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
4048 for the case that the account does not exist.
4050 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
4051 (equivalent to the modest account name) rather than the tinymail account name
4052 (equivalent to the modest account title - human readable) to get the account data.
4053 Check for null account data to prevent the crash, and add a TODO comment saying that
4054 this needs fixing because it is using the server account name instead of the account name.
4056 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4058 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
4059 * src/maemo/modest-account-settings-dialog.c: (show_error),
4061 Use hildon_note_new_information() for informative and error messages,
4062 which seems to be expected for Maemo applications (no documentation that I know of
4063 says this). I am surprised that there is no distinction between info and error
4066 2007-04-29 Murray Cumming <murrayc@murrayc.com>
4068 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
4069 it is easy to find where this is used.
4071 * src/maemo/easysetup/modest-easysetup-wizard.c:
4072 (create_page_welcome), (create_page_account_details),
4073 (create_page_user_details), (create_page_complete_easysetup),
4074 (create_page_custom_incoming), (create_page_custom_outgoing),
4075 (create_page_complete_custom):
4076 * src/maemo/modest-account-settings-dialog.c:
4077 (create_page_account_details), (create_page_user_details),
4078 (create_page_incoming), (create_page_outgoing):
4079 * src/maemo/modest-account-view-window.c: (window_vbox_new):
4080 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4081 (modest_connection_specific_smtp_edit_window_init):
4082 * src/maemo/modest-connection-specific-smtp-window.c:
4083 (modest_connection_specific_smtp_window_init):
4084 * src/maemo/modest-signature-editor-dialog.c:
4085 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
4086 and scrolling policy as per the Email Application Layout Guide, if I have
4089 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4091 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4092 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4093 which were empty, because these vfuncs have been removed from TnyAccountStore.
4094 This fixes the build.
4096 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4098 * src/maemo/modest-main-window.c:
4099 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4100 showing/hiding it. Added TODO because it probably should not be NULL.
4101 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4102 because unnecessary g_warnings() make degugging difficult.
4104 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4106 * src/maemo/modest-msg-edit-window.c:
4107 (modest_msg_edit_window_select_color),
4108 (modest_msg_edit_window_select_background_color): 2 const corrections and
4109 moving 2 #endifs before closing brackets, to fix the build.
4111 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4113 * src/maemo/easysetup/modest-easysetup-wizard.h:
4114 * src/maemo/easysetup/modest-easysetup-wizard.c:
4115 (modest_easysetup_wizard_dialog_finalize),
4116 (on_button_edit_advanced_settings), (create_page_complete_custom),
4117 (on_response), (create_account):
4118 Implement the Advanced Settings edit button, by saving the account information,
4119 for the Advanded Settings dialog to use directly from gconf, and removing it
4120 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4121 Bug #5533 in the projects.maemo.org bugzilla.
4123 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4125 * src/maemo/modest-msg-view-window.c:
4126 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4127 when opening a message window.
4129 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4131 * src/maemo/easysetup/modest-easysetup-wizard.c:
4132 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4135 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4136 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4137 gconf settings. I probably added more checks than necessary, but that is safer.
4139 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4140 variable to fix the build, but this seems to be used when it is still NULL.
4142 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4144 * src/modest-platform.h:
4145 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4146 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4147 * src/modest-main.c: Implement this function so we can avoid using
4148 maemo-specific API from cross-platform code.
4150 * src/modest-tny-account-store.c:
4151 (get_smtp_specific_transport_account_for_open_connection):
4152 * src/modest-ui-actions.c: (check_for_connection),
4153 (modest_ui_actions_on_item_not_found):
4154 Use modest_platform_connect_and_wait() and put #idefs around other
4155 maemo-specific code, because only maemo currently has a way to
4156 identify connection names.
4158 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4160 * src/modest-tny-account-store.h:
4161 * src/modest-tny-account-store.c:
4162 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4163 the connection-specific SMTP server settings in the configuration.
4165 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4167 * src/maemo/modest-main-window.c: (on_connection_changed),
4169 * src/modest-main.c: (main), (start_ui), (send_mail):
4170 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4171 that is what is intended.
4173 * src/modest-ui-actions.c: (action_send), (action_receive),
4174 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4175 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4176 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4177 SMTP server is used when it is specified.
4179 (modest_ui_actions_on_send_receive):
4180 Check that a connection is open before proceeding.
4181 Receive and then send, instead of vice-versa, as per the specification.
4183 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4185 * src/modest-mail-operation.c:
4186 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4187 though I guess it should be something other than NULL.
4189 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4191 * src/maemo/easysetup/modest-easysetup-wizard.c:
4192 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4193 combo twice, to avoid an g_warning and to make it visible again.
4194 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4195 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4196 (already intended) dereference when detaching, because we then recreate the menu.
4197 But I am not sure why the warning was happening, and it is possible that this is a memory
4200 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4202 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4203 and uri_parse_mailto() utility functions.
4204 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4206 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4208 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4210 * src/dbus_api/modest-dbus-api.h:
4211 * src/dbus_api/modest-dbus-callbacks.c:
4212 Use an idle callback to execute the modest code in the application's own thread.
4213 Remove the helloworld example method.
4214 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4215 parsed, and the open-message method is not implemented because this is not yet implemented in
4217 * libmodest-dbus-client/libmodest-dbus-client.c:
4218 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4219 (libmodest_dbus_client_open_message):
4220 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4222 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4223 body without crashing.
4225 * tests/dbus_api/Makefile.am:
4226 * tests/dbus_api/test_mail_to.c:
4227 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4229 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4231 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4232 Added file to fix the build. Sorry.
4234 * src/dbus_api/Makefile.am:
4235 * src/dbus_api/modest-dbus-api.h:
4236 * src/dbus_api/modest-dbus-callbacks.h:
4237 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4238 (modest_dbus_req_handler):
4239 Put constants in a separate header so it can be reused by the
4240 client library, without duplication
4242 * libmodest-dbus-client/Makefile.am:
4243 * libmodest-dbus-client/libmodest-dbus-client.c:
4244 (libmodest_dbus_client_call_helloworld),
4245 (libmodfest_dbus_client_send_mail),
4246 (libmodfest_dbus_client_mailto),
4247 (libmodfest_dbus_client_open_message):
4248 * libmodest-dbus-client/libmodest-dbus-client.h:
4249 (Partly) Implement a send_mail D-Bus method.
4251 * tests/dbus_api/Makefile.am:
4252 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4253 the send_email D-Bus method.
4255 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4259 * libmodest-dbus-client/Makefile.am:
4260 * libmodest-dbus-client/libmodest-dbus-client.c:
4261 * libmodest-dbus-client/libmodest-dbus-client.h:
4262 * tests/dbus_api/Makefile.am:
4263 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4264 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4266 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4268 * src/maemo/easysetup/modest-easysetup-wizard.c:
4269 (create_page_account_details):
4270 * src/maemo/modest-account-settings-dialog.c:
4271 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4272 widgets, because this might not be the default in future versions of the Maemo GTK+.
4273 However, I can not not get capitalization to work even in a simple test case.
4275 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4277 * src/maemo/easysetup/modest-easysetup-wizard.c:
4278 (create_page_custom_incoming), (create_page_custom_outgoing):
4279 * src/maemo/modest-account-settings-dialog.c:
4280 (create_page_account_details), (create_page_incoming),
4281 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4282 instead of using gtk_check_button_with_label(), so they are aligned like the other
4283 widgets, as per the UI spec.
4285 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4287 * src/maemo/easysetup/modest-easysetup-wizard.c:
4288 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4289 * src/widgets/modest-validating-entry.c:
4290 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4291 Modest prefix instead of an EasySetup prefix.
4293 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4295 * src/widgets/modest-validating-entry.h:
4296 * src/widgets/modest-validating-entry.c: (on_insert_text),
4297 Added easysetup_validating_entry_set_max_func(), used to set a callback
4298 to call when the max number of characters is reached. GtkEntry has a max-length
4299 already but is silent about it.
4301 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4302 (create_page_account_details), (create_page_user_details),
4304 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4305 (create_page_account_details), (create_page_user_details),
4306 (create_page_outgoing):
4307 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4308 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4309 the UI spec, when the user tries to enter more than the max number of characters.
4311 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4313 * src/maemo/easysetup/modest-easysetup-wizard.c:
4314 (create_page_user_details), (create_page_custom_incoming),
4315 (create_page_custom_outgoing):
4316 * src/maemo/modest-account-settings-dialog.c:
4317 (create_page_user_details), (create_page_incoming),
4318 (create_page_outgoing):
4319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4320 (modest_connection_specific_smtp_edit_window_init):
4321 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4322 not appropriate. Bad Maemo-specific defaults!.
4324 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4326 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4327 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4328 (modest_signature_editor_dialog_set_settings):
4329 Disable the label and textview when the checkbox is disabled, and use the
4330 specified (UI spec) default signature text.
4332 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4334 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4335 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4337 * src/modest-defs.h:
4338 * src/modest-account-mgr-helpers.h:
4339 * src/modest-account-mgr-helpers.c:
4340 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4342 * src/maemo/Makefile.am:
4343 * src/maemo/modest-signature-editor-dialog.c:
4344 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4347 * src/maemo/modest-account-settings-dialog.h:
4348 * src/maemo/modest-account-settings-dialog.c:
4349 (modest_account_settings_dialog_finalize), (on_button_signature),
4350 (save_configuration): Use the new dialog when the Edit button is pressed, and
4351 save the changes if necessary, as per the UI spec.
4353 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4355 * src/maemo/Makefile.am:
4356 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4357 based on maemo-develoers email from Dirk.
4359 * src/maemo/easysetup/modest-easysetup-wizard.c:
4360 (create_page_welcome), (create_page_account_details),
4361 (create_page_user_details), (create_page_complete_easysetup),
4362 (create_page_custom_incoming), (create_page_custom_outgoing),
4363 (create_page_complete_custom),
4364 (modest_easysetup_wizard_dialog_init):
4365 * src/maemo/modest-account-settings-dialog.c:
4366 (create_page_account_details), (create_page_user_details),
4367 (create_page_incoming), (create_page_outgoing),
4368 (modest_account_settings_dialog_init):
4369 * src/maemo/modest-connection-specific-smtp-window.c:
4370 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4372 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4374 * src/maemo/easysetup/modest-easysetup-wizard.c:
4375 (create_page_account_details), (create_page_custom_outgoing),
4376 (create_page_complete_custom):
4377 * src/maemo/modest-account-settings-dialog.c:
4378 (create_page_user_details), (create_page_incoming),
4379 (create_page_outgoing):
4380 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4381 (modest_connection_specific_smtp_edit_window_init):
4382 Use the correct (UI spec) port min/max, and use horizontal separators,
4385 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4387 * src/maemo/easysetup/modest-easysetup-wizard.c:
4388 (set_default_custom_servernames):
4389 * src/maemo/modest-account-settings-dialog.c:
4390 (create_page_incoming), (on_combo_outgoing_security_changed),
4391 (on_combo_incoming_security_changed), (create_page_outgoing),
4392 (modest_account_settings_dialog_set_account_name),
4393 (save_configuration):
4394 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4395 (on_combo_security_changed),
4396 (modest_connection_specific_smtp_edit_window_init),
4397 (modest_connection_specific_smtp_edit_window_set_connection),
4398 (modest_connection_specific_smtp_edit_window_get_settings):
4399 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4402 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4405 * src/maemo/easysetup/modest-easysetup-wizard.c:
4406 (create_page_custom_outgoing), (create_page_complete_custom):
4407 * src/maemo/modest-account-settings-dialog.c:
4408 (create_page_user_details), (create_page_outgoing):
4409 * src/maemo/modest-account-view-window.c: (button_box_new):
4410 Use changed logical IDs as per the most recent UI spec:
4411 mcen_bd_emailsetup_edit -> mcen_bd_edit
4412 mcen_bd_emailsetup_delete -> mcen_bd_delete
4413 mcen_bd_emailsetup_close -> mcen_bd_close
4415 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4419 * src/dbus_api/Makefile.am:
4420 * src/dbus_api/modest-dbus-callbacks.c:
4421 * src/dbus_api/modest-dbus-callbacks.h:
4422 * src/maemo/modest-platform.c: (modest_platform_init):
4423 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4425 * tests/Makefile.am:
4426 * tests/dbus_api/Makefile.am:
4427 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4429 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4431 * src/maemo/modest-account-settings-dialog.c:
4432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4433 Removed unnecessary includes.
4435 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4437 * src/maemo/easysetup/modest-easysetup-wizard.c:
4438 * src/maemo/modest-account-settings-dialog.c:
4439 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4440 * src/widgets/Makefile.am:
4441 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4442 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4443 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4444 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4445 * src/widgets/modest-secureauth-combo-box.c:
4446 * src/widgets/modest-secureauth-combo-box.h:
4447 * src/widgets/modest-serversecurity-combo-box.c:
4448 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4449 made the GObject names more consistent with the rest of the Modest code.
4451 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4453 * src/maemo/easysetup/Makefile.am:
4454 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4455 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4456 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4457 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4458 * src/maemo/easysetup/modest-easysetup-wizard.c:
4459 * src/maemo/easysetup/modest-validating-entry.c:
4460 * src/maemo/easysetup/modest-validating-entry.h:
4461 * src/maemo/modest-account-settings-dialog.c:
4462 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4463 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4464 widgets/ because they are used outside of easysetup too. After checking in,
4465 svn will allow me to rename them too.
4467 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4469 * src/gnome/modest-msg-edit-window.c:
4470 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4471 linker error, to fix the build on the GNOME platform.
4472 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4473 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4474 ifdefed out to avoid a warning.
4476 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4478 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4479 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4480 some alternative for GTK+ 2.6.
4482 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4484 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4486 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4487 specified for EmailAccountsDialog in UI spec.
4489 * src/maemo/easysetup/modest-easysetup-wizard.c:
4490 * src/maemo/easysetup/modest-easysetup-wizard.h:
4491 * src/maemo/modest-account-settings-dialog.c:
4492 * src/maemo/modest-account-settings-dialog.h:
4493 Reuse a member window widget for the connection-specific SMTP server accounts,
4494 so we can tell it to create/save the accounts only if we actually save changes.
4496 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4498 (modest_connection_specific_smtp_edit_window_get_settings):
4499 Return a struct instance for temporarily remembering the entered data.
4501 * src/maemo/modest-connection-specific-smtp-window.h:
4502 * src/maemo/modest-connection-specific-smtp-window.c:
4503 (modest_connection_specific_smtp_window_finalize),
4504 (modest_connection_specific_smtp_window_fill_with_connections),
4506 (modest_connection_specific_smtp_window_save_server_accounts),
4507 (update_model_server_names): Do not actually save data until asked,
4508 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4510 (on_selection_changed),
4511 (modest_connection_specific_smtp_window_init): Disable the edit
4512 button when nothing is selected.
4514 * src/modest-account-mgr-helpers.c:
4515 * src/modest-account-mgr-helpers.h:
4516 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4519 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4521 * src/modest-account-mgr-helpers.h:
4522 * src/modest-account-mgr-helpers.c:
4523 (modest_account_mgr_get_unused_account_name),
4524 (modest_account_mgr_get_unused_account_display_name): Added these
4525 utility functions, to avoid code duplication.
4527 * src/maemo/easysetup/modest-easysetup-wizard.c:
4528 (create_page_account_details), (create_account):
4529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4530 (on_combo_security_changed),
4531 (modest_connection_specific_smtp_edit_window_init),
4532 (modest_connection_specific_smtp_edit_window_save_settings):
4533 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4534 * src/maemo/modest-connection-specific-smtp-window.c:
4535 (modest_connection_specific_smtp_window_finalize),
4536 (modest_connection_specific_smtp_window_fill_with_connections),
4537 (on_button_edit), (modest_connection_specific_smtp_window_init):
4538 * src/maemo/modest-connection-specific-smtp-window.h:
4539 Implementing saving of connection-specific server accounts.
4541 But I need to refactor this so we can save the data for each
4542 possible connection-specific account and only actually create the server accounts
4543 when the easysetup finished, or the OK button is pressed on the account settings
4546 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4548 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4549 (on_combo_security_changed):
4550 (modest_connection_specific_smtp_edit_window_init):
4551 Auto-fill the port number as in the account settings.
4553 (modest_connection_specific_smtp_edit_window_set_connection):
4554 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4555 * src/maemo/modest-connection-specific-smtp-window.c:
4556 (fill_with_connections), (on_button_edit),
4557 (modest_connection_specific_smtp_window_init):
4558 Turn the edit window into a dialog to simplify the code, and
4559 set a WM hint as in a GtkDialog, because only a popup can be on top of
4560 another window in Maemo, and popups usually have no WM decoration.
4562 * src/modest-defs.h:
4563 * src/modest-account-mgr-helpers.c:
4564 (modest_account_mgr_set_connection_specific_smtp),
4565 (modest_account_mgr_remove_connection_specific_smtp),
4566 (modest_account_mgr_get_connection_specific_smtp):
4567 * src/modest-account-mgr-helpers.h: Some functions to write the
4568 connection-specific SMTP server information. Not yet used.
4571 * src/widgets/modest-folder-view.c: (text_cell_data):
4572 Fix a warning about an uninitialized variable.
4573 (on_configuration_key_changed): Put an #ifdef around the use
4574 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4576 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4578 * src/maemo/modest-account-settings-dialog.h:
4579 * src/maemo/modest-account-settings-dialog.c:
4580 Added connect_for_modified() utility function to mark the new modified boolean.
4582 (create_page_account_details), (create_page_user_details),
4583 (create_page_incoming), (create_page_outgoing), (on_response),
4584 (modest_account_settings_dialog_init),
4585 (modest_account_settings_dialog_set_account_name):
4586 Only warn about unsaved changes when there are actually unsaved changes.
4588 * src/modest-account-mgr-helpers.c:
4589 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4590 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4591 to get the data from there in future.
4593 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4595 * src/modest-defs.h:
4597 * src/modest-account-mgr-helpers.h:
4598 * src/modest-account-mgr-helpers.c:
4599 Store the security account setting in a single conf key instead of using
4600 the options list, so that the list is left for just the to-be-removed camel hack,
4601 and because gconf_client_set_list() is failing for some reason.
4603 * src/modest-account-mgr.c:
4604 (modest_account_mgr_add_server_account):
4605 * src/maemo/modest-account-settings-dialog.c:
4606 (modest_account_settings_dialog_set_account_name),
4607 (save_configuration): Use the renamed functions.
4610 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4612 * src/widgets/Makefile.am:
4613 * src/widgets/modest-limit-retrieve-combo-box.c:
4614 * src/widgets/modest-limit-retrieve-combo-box.h:
4615 * src/widgets/modest-retrieve-combo-box.c:
4616 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4617 the account settings dialog.
4619 * src/modest-defs.h:
4620 * src/modest-account-mgr-helpers.h:
4621 * src/modest-account-mgr-helpers.c:
4622 (modest_server_account_get_option_secure_auth),
4623 (modest_server_account_set_option_secure_auth):
4624 * src/modest-account-mgr.c:
4625 (modest_account_mgr_add_server_account):
4626 Use the existing AUTH_MECH conf key for the secure-auth setting,
4627 instead of putting it in the list options, because this was actually used already.
4629 * src/maemo/modest-account-settings-dialog.c:
4630 (create_page_account_details),
4631 (modest_account_settings_dialog_set_account_name),
4632 (save_configuration):
4633 * src/maemo/modest-account-settings-dialog.h:
4634 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4635 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4637 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4639 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4640 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4641 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4643 * src/modest-defs.h:
4644 * src/maemo/modest-account-settings-dialog.c:
4645 (create_page_incoming), (on_combo_outgoing_security_changed),
4646 (on_combo_incoming_security_changed), (create_page_outgoing),
4647 (modest_account_settings_dialog_set_account_name),
4648 (save_configuration): Load/Save the port number, and change it when the
4649 security combo changes, to suitable defaults.
4651 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4653 * src/modest-account-mgr.c:
4654 (modest_account_mgr_add_server_account): Set the security and secure-auth
4655 options, and add a comment saying that the other camel-specific options should be
4658 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4660 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4662 * src/modest-tny-account-store.c: (account_list_free),
4663 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4664 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4667 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4669 * src/modest-protocol-info.c:
4670 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4671 is required by our UI spec. Maybe something in our implementation will use this eventually.
4672 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4673 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4674 instead of the previous 0 placeholder.
4676 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4677 secure-auth settings.
4678 * src/modest-account-mgr-helpers.h:
4679 * src/modest-account-mgr-helpers.c:
4680 (modest_server_account_data_get_option_secure_auth),
4681 (modest_server_account_set_option_secure_auth),
4682 (modest_server_account_data_get_option_security),
4683 (modest_server_account_set_option_security): Added this API for getting and setting the security
4684 and secure-auth settings.
4686 * src/maemo/modest-account-settings-dialog.h:
4687 * src/maemo/modest-account-settings-dialog.c:
4688 (modest_account_settings_dialog_finalize), (check_data),
4689 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4690 about changing titles.
4691 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4692 (save_configuration): Save the security and secure-auth settings.
4694 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4695 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4697 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4699 * src/modest-defs.h:
4700 * src/modest-account-mgr.c:
4701 (modest_account_mgr_add_server_account):
4702 Added and used defines for the options key and value pair strings,
4703 that are used so far, though they do not seem to correspond to anything in our
4704 UI specs or ModestProtocol enum.
4706 * src/modest-account-mgr-helpers.h:
4707 * src/modest-account-mgr-helpers.c:
4708 (compare_option_strings_for_name),
4709 (modest_server_account_data_get_option_value),
4710 (modest_server_account_data_get_option_bool),
4711 (modest_account_mgr_get_server_account_option):
4712 Added helper functions for parsing the options GSList.
4714 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4716 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4717 display name is based on the supplied account name.
4718 * src/modest-account-mgr.c:
4719 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4720 with an inefficient, but good-enough, implementation.
4722 * src/maemo/easysetup/modest-easysetup-wizard.c:
4723 (create_page_account_details), (on_before_next), (create_account):
4724 Check for existing display names rather than (non-user-visible) account names, and just
4725 create and set a unique account name at the end.
4727 * src/maemo/modest-account-settings-dialog.c:
4728 (modest_account_settings_dialog_init),
4729 (modest_account_settings_dialog_set_account_name),
4730 (create_page_incoming): Show the display name, instead of the account name.
4731 (on_response): Do some (not all) extra checks, as in the UI spec.
4732 (save_configuration): Save the display name if it was changed.
4734 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4736 * po/en_GB.po: Added needed logical ID and translation.
4737 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4738 (init_view): Made the is-default column clicking work.
4740 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4743 * src/maemo/easysetup/Makefile.am:
4744 * src/maemo/easysetup/modest-easysetup-wizard.c:
4745 (modest_easysetup_wizard_dialog_init):
4746 * src/maemo/easysetup/provider-data-test.keyfile:
4747 * src/maemo/easysetup/provider-data.keyfile:
4748 Moved the provider data file to the new modest-providers-data package and used it from there.
4750 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4752 * src/modest-local-folder-info.c:
4753 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4754 N_() was already used on the static strings, but this just marks it for translation without
4755 using the translation.
4757 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4759 * src/maemo/modest-account-settings-dialog.c:
4760 (create_page_incoming),
4761 (modest_account_settings_dialog_set_account_name):
4762 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4763 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4764 I will do this if nobody else gets there first.
4766 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4768 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4769 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4770 save the security stuff.
4772 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4774 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4775 Set the email address and user fullname, which I now see must be
4778 * src/maemo/modest-account-settings-dialog.h:
4779 * src/maemo/modest-account-settings-dialog.c:
4781 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4782 leave-on-server and authentication.
4783 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4786 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4789 * src/maemo/modest-account-settings-dialog.c:
4790 * src/maemo/modest-account-settings-dialog.h:
4791 Most (but not all) of the widgets are now present as specified by the UI spec.
4792 No changes are yet saved, and some details are not properly shown yet.
4794 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4796 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4798 * src/maemo/Makefile.am:
4799 * src/maemo/modest-account-settings-dialog.c:
4800 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4801 an existing account. Doesn't do much yet.
4803 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4804 Open the accounts settings dialog when Edit is clicked.
4806 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4808 * src/maemo/easysetup/Makefile.am:
4809 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4811 * src/maemo/easysetup/modest-easysetup-wizard.c:
4812 (modest_easysetup_wizard_dialog_init):
4813 Try to get the source directory from the build system,
4814 instead of hard-coding "./" into the source code, when opening our local
4815 copies of the configuration files.
4816 But this still fails when opening the wizard from the Accounts window,
4817 maybe because the working directory seems to change at runtime.
4818 So the wizard will fail the second time unless you copy the files into their
4819 proper locations - see the stdout warnings for the paths.
4821 (create_page_account_details),(on_before_next):
4822 Check for existing non-server accounts instead of server accounts,
4823 so the default account name is useful again, and to prevent trying to
4826 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4827 Show the wizard when New is clicked.
4829 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4830 (init_view): Show the column headers, and show the columns that are
4831 specified in the UI specs. However, something in Maemo's GTK+ prevents
4832 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4833 change the default account. This is despite unsetting the special properties.
4835 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4837 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4838 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4839 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4840 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4841 to make that clearer.
4842 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4844 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4846 * src/maemo/modest-account-view-window.c:
4847 (modest_account_view_window_init),
4848 (modest_account_view_window_new):
4849 Use the same buttons as specified in the
4850 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4851 the existing widgets, which never had a chance of working.
4852 Put the ModestAccountView treeview in a scrolled window.
4853 Do not repeat the initialization in both _init() and _new().
4855 * src/widgets/modest-account-view.c: (update_account_view):
4856 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4857 this widget and window shows no accounts.
4859 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4861 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4863 * src/maemo/easysetup/modest-easysetup-wizard.c:
4864 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4865 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4866 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4869 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4870 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4871 accounts exist yet, as in the UI spec.
4873 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4875 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4877 * src/maemo/Makefile.am:
4878 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4879 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4880 New window for editing connection-specific smtp details.
4881 Not fully implemented.
4883 * src/maemo/modest-connection-specific-smtp-window.c:
4884 (modest_connection_specific_smtp_window_finalize) :
4885 unref the tree model.
4886 (on_button_edit): Show the edit window.
4888 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4890 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4893 * src/maemo/Makefile.am:
4894 * src/maemo/modest-connection-specific-smtp-window.c:
4895 * src/maemo/modest-connection-specific-smtp-window.h:
4896 New window for showing the list of connections, for connection-specific
4897 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4898 * src/maemo/easysetup/modest-easysetup-wizard.c:
4899 (create_page_custom_outgoing): Show the new window when the button is clicked.
4901 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4903 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4904 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4905 * src/maemo/modest-msg-edit-window.c:
4906 (modest_msg_edit_window_insert_image):
4907 * src/modest-conf.c: (modest_conf_key_escape):
4908 * src/modest-mail-operation.c:
4909 (modest_mail_operation_send_new_mail):
4910 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4911 (modest_ui_actions_on_new_account):
4912 * src/widgets/modest-attachment-view.c: (update_filename_request):
4913 * src/widgets/modest-mail-header-view.c:
4914 Corrected warnings that were breaking the build, by commenting out unused variables,
4915 and a function, and by including a header.
4917 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4919 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4920 so we can #ifdef around platform-specific code when necessary.
4921 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4922 to allow this to build for the GNOME platform too.
4924 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4926 * src/maemo/easysetup/modest-easysetup-wizard.c:
4927 Added util_increment_name() and used it in create_page_account_details()
4928 to make sure that the default account name is always a new name.
4930 (modest_easysetup_wizard_dialog_init),
4931 (set_default_custom_servernames): Some minor memory management fixes.
4933 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4937 * src/modest-runtime.c: (init_i18n): Restored the translation
4938 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4939 are defined in config.h, and the translations are installed.
4941 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4942 is defined for translation.
4944 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4946 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4948 * src/maemo/easysetup/modest-easysetup-wizard.c:
4949 (modest_easysetup_wizard_dialog_init):
4950 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4951 Use realistic paths (though they should use $prefix generically) to the
4952 mcc_mapping and provider-data.keyfile files which might work when they
4953 are installed by the future version of the operator-wizard package,
4954 and then fallback to paths in our source code, with an explanatory
4957 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4961 * src/maemo/Makefile.am:
4962 * src/maemo/easysetup/: Added files from the previously-exernal
4963 osso-modest-easysetup.
4964 * src/maemo/modest-main-window-ui.h:
4965 * src/modest-ui-actions.c:
4966 * src/modest-ui-actions.h:
4967 Added modest_ui_actions_on_new_account() as a signal handler for the
4968 New Account menu item. It shows the easysetup wizard.
4969 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob