git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-platform.c:
   4         (modest_platform_set_update_interval):
   5         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
   6         aparently stays valid between application instances, so we can use this
   7         to remove and reset it later. According to a maemo-developers email from
   8         David Weinehall.
   9
  10 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
  11
  12         * configure.ac: Depend on libalarm for Maemo.
  13
  14         * src/dbus_api/modest-dbus-api.h:
  15         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
  16         (on_send_receive), (modest_dbus_req_handler):
  17         Handle a SEND_RECEIVE D-Bus method.
  18
  19         * libmodest-dbus-client/libmodest-dbus-client.c:
  20         (libmodest_dbus_client_send_and_receive):
  21         * libmodest-dbus-client/libmodest-dbus-client.h:
  22         Add C convenience functions for calling the new D-Bus method.
  23
  24         * src/modest-platform.h:
  25         * src/gnome/modest-platform.c:
  26         * src/maemo/modest-platform.c:
  27         Added modest_platform_set_update_interval(), which uses the
  28         alarmd API on Maemo.
  29         (modest_platform_init),
  30         Call modest_platform_set_update_interval(), using a hard-coded
  31         interval for now (until the global settings dialog is implemented),
  32         though I am not sure that this makes sense yet.
  33
  34 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
  35
  36         * src/dbus_api/modest-dbus-callbacks.c:
  37         (modest_osso_cb_hw_state_handler):
  38         * src/dbus_api/modest-dbus-callbacks.h:
  39         * src/maemo/modest-platform.c: (modest_platform_init):
  40         Registered (empty) callbacks for the osso hardware state D-Bus signals,
  41         in case this has some effect on the ability for Maemo to ping the
  42         application.
  43
  44 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
  45
  46         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
  47         Comment out an if() that checks a gchar for < 0, causing a build-breaking
  48         warning. It is probably a logic error, but I need to fix the build.
  49
  50 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
  51
  52         * src/modest-account-mgr.h:
  53         * src/modest-account-mgr.c:
  54         (modest_account_mgr_account_names): Add a gboolean enabled_only
  55         parameter, so we can get lists of onlt the enabled accounts.
  56
  57         (modest_account_mgr_add_account),,
  58         (modest_account_mgr_account_with_display_name_exists):
  59         * src/maemo/modest-msg-edit-window.c: (get_transports):
  60         * src/modest-account-mgr-helpers.c:
  61         (modest_account_mgr_set_first_account_as_default):
  62         * src/modest-init.c: (init_default_account_maybe):
  63         * src/modest-tny-account-store.c: (get_accounts):
  64         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
  65         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
  66         * tests/check_account-mgr.c: (START_TEST):
  67         Provide the extra parameter, as appropriate.
  68
  69         * src/widgets/modest-account-view.c: (update_account_view):
  70         Do not show disabled accounts (meaning that there is no way to
  71         enable/disable accounts in the UI (the feature is not in our UI
  72         specification), so we can use this internally only to mark unfinished
  73         or temporary account data.
  74
  75         * src/maemo/easysetup/modest-easysetup-wizard.c:
  76         (create_account): Add boolean enable parameter, so we can specify FALSE
  77         to create the temporary account.
  78         (on_button_edit_advanced_settings): Create the temporary account as disabled.
  79         (on_before_next): When finishing, when there is a temporary account, just
  80         set it as enabled.
  81         Also, use a timeout to delay the showing of the dialog until gconf is likely
  82         to return correct information, due to a maemo gconf bug that is fixed in
  83         osso 1.1, but not yet in Bora.
  84         However, the dialog stays on screen after it is destroyed.
  85
  86         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
  87         for invalid data when cancelling. Use a hildon note instead of a dialog
  88         to complain about invalid data. Do not show the account-saved note if the
  89         account is disabled (a temporary account that will not really be saved for use
  90         until later.)
  91
  92 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  93
  94         * src/modest-account-mgr-helpers.h:
  95         * src/modest-account-mgr-helpers.c:
  96         Added modest_account_mgr_unset_default_account(),
  97         Added modest_account_mgr_set_first_account_as_default().
  98
  99         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 100         If it was the default account, unset the default account name.
 101
 102         * src/maemo/modest-account-view-window.c:
 103         (on_delete_button_clicked): If it was the default account,
 104         set the first remaining account as the default instead.
 105
 106         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 107         a NULL account or a NULL default account, to prevent a crash. This should
 108         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 109
 110
 111 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 112
 113         * src/widgets/modest-recpt-editor.c:
 114         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 115         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 116         TODO comment for this. This fixes the build.
 117
 118         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 119         be the best place for it. This will in future update all auto-update accounts,
 120         rather than just the current/default account, when that gconf key exists.
 121         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 122         if there are no accounts, before calling do_send_receive().
 123         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 124
 125         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 126         * src/maemo/modest-main-window-ui.h:
 127         * src/maemo/modest-main-window.c: (on_connection_changed),
 128         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 129         directly, becaue the signal handler does more.
 130
 131 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 132
 133         * src/modest-account-mgr-helpers.c:
 134         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 135         for the case that the account does not exist.
 136
 137         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 138         (equivalent to the modest account name) rather than the tinymail account name
 139         (equivalent to the modest account title - human readable) to get the account data.
 140         Check for null account data to prevent the crash, and add a TODO comment saying that
 141         this needs fixing because it is using the server account name instead of the account name.
 142
 143 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 144
 145         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 146         * src/maemo/modest-account-settings-dialog.c: (show_error),
 147         (show_ok):
 148         Use hildon_note_new_information() for informative and error messages,
 149         which seems to be expected for Maemo applications (no documentation that I know of
 150         says this). I am surprised that there is no distinction between info and error
 151         dialogs.
 152
 153 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 154
 155         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 156         it is easy to find where this is used.
 157
 158         * src/maemo/easysetup/modest-easysetup-wizard.c:
 159         (create_page_welcome), (create_page_account_details),
 160         (create_page_user_details), (create_page_complete_easysetup),
 161         (create_page_custom_incoming), (create_page_custom_outgoing),
 162         (create_page_complete_custom):
 163         * src/maemo/modest-account-settings-dialog.c:
 164         (create_page_account_details), (create_page_user_details),
 165         (create_page_incoming), (create_page_outgoing):
 166         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 167         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 168         (modest_connection_specific_smtp_edit_window_init):
 169         * src/maemo/modest-connection-specific-smtp-window.c:
 170         (modest_connection_specific_smtp_window_init):
 171         * src/maemo/modest-signature-editor-dialog.c:
 172         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 173         and scrolling policy as per the Email Application Layout Guide, if I have
 174         understood it.
 175
 176 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 177
 178         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 179         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 180         which were empty, because these vfuncs have been removed from TnyAccountStore.
 181         This fixes the build.
 182
 183 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/maemo/modest-main-window.c:
 186         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 187         showing/hiding it. Added TODO because it probably should not be NULL.
 188         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 189         because unnecessary g_warnings() make degugging difficult.
 190
 191 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 192
 193         * src/maemo/modest-msg-edit-window.c:
 194         (modest_msg_edit_window_select_color),
 195         (modest_msg_edit_window_select_background_color): 2 const corrections and
 196         moving 2 #endifs before closing brackets, to fix the build.
 197
 198 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 199
 200         * src/maemo/easysetup/modest-easysetup-wizard.h:
 201         * src/maemo/easysetup/modest-easysetup-wizard.c:
 202         (modest_easysetup_wizard_dialog_finalize),
 203         (on_button_edit_advanced_settings), (create_page_complete_custom),
 204         (on_response), (create_account):
 205         Implement the Advanced Settings edit button, by saving the account information,
 206         for the Advanded Settings dialog to use directly from gconf, and removing it
 207         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 208         Bug #5533 in the projects.maemo.org bugzilla.
 209
 210 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 211
 212         * src/maemo/modest-msg-view-window.c:
 213         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 214         when opening a message window.
 215
 216 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/maemo/easysetup/modest-easysetup-wizard.c:
 219         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 220         match the UI spec.
 221
 222         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 223         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 224         gconf settings. I probably added more checks than necessary, but that is safer.
 225
 226         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 227         variable to fix the build, but this seems to be used when it is still NULL.
 228
 229 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 230
 231         * src/modest-platform.h:
 232         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 233         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 234         * src/modest-main.c: Implement this function so we can avoid using
 235         maemo-specific API from cross-platform code.
 236         (main):
 237         * src/modest-tny-account-store.c:
 238         (get_smtp_specific_transport_account_for_open_connection):
 239         * src/modest-ui-actions.c: (check_for_connection),
 240         (modest_ui_actions_on_item_not_found):
 241         Use modest_platform_connect_and_wait() and put #idefs around other
 242         maemo-specific code, because only maemo currently has a way to
 243         identify connection names.
 244
 245 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 246
 247         * src/modest-tny-account-store.h:
 248         * src/modest-tny-account-store.c:
 249         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 250         the connection-specific SMTP server settings in the configuration.
 251
 252         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 253         (on_idle_mail_to):
 254         * src/maemo/modest-main-window.c: (on_connection_changed),
 255         (connect_signals):
 256         * src/modest-main.c: (main), (start_ui), (send_mail):
 257         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 258         that is what is intended.
 259
 260         * src/modest-ui-actions.c: (action_send), (action_receive),
 261         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 262         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 263         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 264         SMTP server is used when it is specified.
 265
 266         (modest_ui_actions_on_send_receive):
 267         Check that a connection is open before proceeding.
 268         Receive and then send, instead of vice-versa, as per the specification.
 269
 270 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 271
 272         * src/modest-mail-operation.c:
 273         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 274         though I guess it should be something other than NULL.
 275
 276 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 277
 278         * src/maemo/easysetup/modest-easysetup-wizard.c:
 279         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 280         combo twice, to avoid an g_warning and to make it visible again.
 281         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 282         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 283         (already intended) dereference when detaching, because we then recreate the menu.
 284         But I am not sure why the warning was happening, and it is possible that this is a memory
 285         leak.
 286
 287 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 288
 289         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 290         and uri_parse_mailto() utility functions.
 291         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 292         the mailto URI.
 293         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 294
 295 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 296
 297         * src/dbus_api/modest-dbus-api.h:
 298         * src/dbus_api/modest-dbus-callbacks.c:
 299         Use an idle callback to execute the modest code in the application's own thread.
 300         Remove the helloworld example method.
 301         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 302         parsed, and the open-message method is not implemented because this is not yet implemented in
 303         modest itself.
 304         * libmodest-dbus-client/libmodest-dbus-client.c:
 305         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 306         (libmodest_dbus_client_open_message):
 307         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 308
 309         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 310         body without crashing.
 311
 312         * tests/dbus_api/Makefile.am:
 313         * tests/dbus_api/test_mail_to.c:
 314         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 315
 316 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 317
 318         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 319         Added file to fix the build. Sorry.
 320
 321         * src/dbus_api/Makefile.am:
 322         * src/dbus_api/modest-dbus-api.h:
 323         * src/dbus_api/modest-dbus-callbacks.h:
 324         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 325         (modest_dbus_req_handler):
 326         Put constants in a separate header so it can be reused by the
 327         client library, without duplication
 328
 329         * libmodest-dbus-client/Makefile.am:
 330         * libmodest-dbus-client/libmodest-dbus-client.c:
 331         (libmodest_dbus_client_call_helloworld),
 332         (libmodfest_dbus_client_send_mail),
 333         (libmodfest_dbus_client_mailto),
 334         (libmodfest_dbus_client_open_message):
 335         * libmodest-dbus-client/libmodest-dbus-client.h:
 336         (Partly) Implement a send_mail D-Bus method.
 337
 338         * tests/dbus_api/Makefile.am:
 339         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 340         the send_email D-Bus method.
 341
 342 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 343
 344         * Makefile.am:
 345         * configure.ac:
 346         * libmodest-dbus-client/Makefile.am:
 347         * libmodest-dbus-client/libmodest-dbus-client.c:
 348         * libmodest-dbus-client/libmodest-dbus-client.h:
 349         * tests/dbus_api/Makefile.am:
 350         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 351         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 352
 353 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 354
 355         * src/maemo/easysetup/modest-easysetup-wizard.c:
 356         (create_page_account_details):
 357         * src/maemo/modest-account-settings-dialog.c:
 358         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 359         widgets, because this might not be the default in future versions of the Maemo GTK+.
 360         However, I can not not get capitalization to work even in a simple test case.
 361
 362 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 363
 364         * src/maemo/easysetup/modest-easysetup-wizard.c:
 365         (create_page_custom_incoming), (create_page_custom_outgoing):
 366         * src/maemo/modest-account-settings-dialog.c:
 367         (create_page_account_details), (create_page_incoming),
 368         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 369         instead of using gtk_check_button_with_label(), so they are aligned like the other
 370         widgets, as per the UI spec.
 371
 372 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 373
 374         * src/maemo/easysetup/modest-easysetup-wizard.c:
 375         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 376         * src/widgets/modest-validating-entry.c:
 377         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 378         Modest prefix instead of an EasySetup prefix.
 379
 380 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 381
 382         * src/widgets/modest-validating-entry.h:
 383         * src/widgets/modest-validating-entry.c: (on_insert_text),
 384         Added easysetup_validating_entry_set_max_func(), used to set a callback
 385         to call when the max number of characters is reached. GtkEntry has a max-length
 386         already but is silent about it.
 387
 388         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 389         (create_page_account_details), (create_page_user_details),
 390         (create_account):
 391         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 392         (create_page_account_details), (create_page_user_details),
 393         (create_page_outgoing):
 394         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 395         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 396         the UI spec, when the user tries to enter more than the max number of characters.
 397
 398 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 399
 400         * src/maemo/easysetup/modest-easysetup-wizard.c:
 401         (create_page_user_details), (create_page_custom_incoming),
 402         (create_page_custom_outgoing):
 403         * src/maemo/modest-account-settings-dialog.c:
 404         (create_page_user_details), (create_page_incoming),
 405         (create_page_outgoing):
 406         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 407         (modest_connection_specific_smtp_edit_window_init):
 408         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 409         not appropriate. Bad Maemo-specific defaults!.
 410
 411 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 412
 413         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 414         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 415         (modest_signature_editor_dialog_set_settings):
 416         Disable the label and textview when the checkbox is disabled, and use the
 417         specified (UI spec) default signature text.
 418
 419 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 420
 421         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 422         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 423
 424         * src/modest-defs.h:
 425         * src/modest-account-mgr-helpers.h:
 426         * src/modest-account-mgr-helpers.c:
 427         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 428
 429         * src/maemo/Makefile.am:
 430         * src/maemo/modest-signature-editor-dialog.c:
 431         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 432         as per the UI spec.
 433
 434         * src/maemo/modest-account-settings-dialog.h:
 435         * src/maemo/modest-account-settings-dialog.c:
 436         (modest_account_settings_dialog_finalize), (on_button_signature),
 437         (save_configuration): Use the new dialog when the Edit button is pressed, and
 438         save the changes if necessary, as per the UI spec.
 439
 440 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 441
 442         * src/maemo/Makefile.am:
 443         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 444         based on maemo-develoers email from Dirk.
 445
 446         * src/maemo/easysetup/modest-easysetup-wizard.c:
 447         (create_page_welcome), (create_page_account_details),
 448         (create_page_user_details), (create_page_complete_easysetup),
 449         (create_page_custom_incoming), (create_page_custom_outgoing),
 450         (create_page_complete_custom),
 451         (modest_easysetup_wizard_dialog_init):
 452         * src/maemo/modest-account-settings-dialog.c:
 453         (create_page_account_details), (create_page_user_details),
 454         (create_page_incoming), (create_page_outgoing),
 455         (modest_account_settings_dialog_init):
 456         * src/maemo/modest-connection-specific-smtp-window.c:
 457         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 458
 459 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 460
 461         * src/maemo/easysetup/modest-easysetup-wizard.c:
 462         (create_page_account_details), (create_page_custom_outgoing),
 463         (create_page_complete_custom):
 464         * src/maemo/modest-account-settings-dialog.c:
 465         (create_page_user_details), (create_page_incoming),
 466         (create_page_outgoing):
 467         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 468         (modest_connection_specific_smtp_edit_window_init):
 469         Use the correct (UI spec) port min/max, and use horizontal separators,
 470         as per the UI spec.
 471
 472 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 473
 474         * src/maemo/easysetup/modest-easysetup-wizard.c:
 475         (set_default_custom_servernames):
 476         * src/maemo/modest-account-settings-dialog.c:
 477         (create_page_incoming), (on_combo_outgoing_security_changed),
 478         (on_combo_incoming_security_changed), (create_page_outgoing),
 479         (modest_account_settings_dialog_set_account_name),
 480         (save_configuration):
 481         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 482         (on_combo_security_changed),
 483         (modest_connection_specific_smtp_edit_window_init),
 484         (modest_connection_specific_smtp_edit_window_set_connection),
 485         (modest_connection_specific_smtp_edit_window_get_settings):
 486         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 487         as per the UI spec.
 488
 489 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 490
 491         * po/en_GB.po:
 492         * src/maemo/easysetup/modest-easysetup-wizard.c:
 493         (create_page_custom_outgoing), (create_page_complete_custom):
 494         * src/maemo/modest-account-settings-dialog.c:
 495         (create_page_user_details), (create_page_outgoing):
 496         * src/maemo/modest-account-view-window.c: (button_box_new):
 497         Use changed logical IDs as per the most recent UI spec:
 498         mcen_bd_emailsetup_edit -> mcen_bd_edit
 499         mcen_bd_emailsetup_delete -> mcen_bd_delete
 500         mcen_bd_emailsetup_close -> mcen_bd_close
 501
 502 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 503
 504         * configure.ac:
 505         * src/Makefile.am:
 506         * src/dbus_api/Makefile.am:
 507         * src/dbus_api/modest-dbus-callbacks.c:
 508         * src/dbus_api/modest-dbus-callbacks.h:
 509         * src/maemo/modest-platform.c: (modest_platform_init):
 510         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 511         method.
 512         * tests/Makefile.am:
 513         * tests/dbus_api/Makefile.am:
 514         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 515
 516 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 517
 518         * src/maemo/modest-account-settings-dialog.c:
 519         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 520         Removed unnecessary includes.
 521
 522 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 523
 524         * src/maemo/easysetup/modest-easysetup-wizard.c:
 525         * src/maemo/modest-account-settings-dialog.c:
 526         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 527         * src/widgets/Makefile.am:
 528         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 529         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 530         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 531         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 532         * src/widgets/modest-secureauth-combo-box.c:
 533         * src/widgets/modest-secureauth-combo-box.h:
 534         * src/widgets/modest-serversecurity-combo-box.c:
 535         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 536         made the GObject names more consistent with the rest of the Modest code.
 537
 538 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 539
 540         * src/maemo/easysetup/Makefile.am:
 541         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 542         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 543         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 544         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 545         * src/maemo/easysetup/modest-easysetup-wizard.c:
 546         * src/maemo/easysetup/modest-validating-entry.c:
 547         * src/maemo/easysetup/modest-validating-entry.h:
 548         * src/maemo/modest-account-settings-dialog.c:
 549         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 550         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 551         widgets/ because they are used outside of easysetup too. After checking in,
 552         svn will allow me to rename them too.
 553
 554 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 555
 556         * src/gnome/modest-msg-edit-window.c:
 557         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 558         linker error, to fix the build on the GNOME platform.
 559         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 560         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 561         ifdefed out to avoid a warning.
 562
 563 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 564
 565         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 566         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 567         some alternative for GTK+ 2.6.
 568
 569 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 570
 571         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 572
 573         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 574         specified for EmailAccountsDialog in UI spec.
 575
 576         * src/maemo/easysetup/modest-easysetup-wizard.c:
 577         * src/maemo/easysetup/modest-easysetup-wizard.h:
 578         * src/maemo/modest-account-settings-dialog.c:
 579         * src/maemo/modest-account-settings-dialog.h:
 580         Reuse a member window widget for the connection-specific SMTP server accounts,
 581         so we can tell it to create/save the accounts only if we actually save changes.
 582
 583         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 584         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 585         (modest_connection_specific_smtp_edit_window_get_settings):
 586         Return a struct instance for temporarily remembering the entered data.
 587
 588         * src/maemo/modest-connection-specific-smtp-window.h:
 589         * src/maemo/modest-connection-specific-smtp-window.c:
 590         (modest_connection_specific_smtp_window_finalize),
 591         (modest_connection_specific_smtp_window_fill_with_connections),
 592         (on_button_edit),
 593         (modest_connection_specific_smtp_window_save_server_accounts),
 594         (update_model_server_names): Do not actually save data until asked,
 595         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 596
 597         (on_selection_changed),
 598         (modest_connection_specific_smtp_window_init): Disable the edit
 599         button when nothing is selected.
 600
 601         * src/modest-account-mgr-helpers.c:
 602         * src/modest-account-mgr-helpers.h:
 603         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 604         elsewhere.
 605
 606 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * src/modest-account-mgr-helpers.h:
 609         * src/modest-account-mgr-helpers.c:
 610         (modest_account_mgr_get_unused_account_name),
 611         (modest_account_mgr_get_unused_account_display_name): Added these
 612         utility functions, to avoid code duplication.
 613
 614         * src/maemo/easysetup/modest-easysetup-wizard.c:
 615         (create_page_account_details), (create_account):
 616         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 617         (on_combo_security_changed),
 618         (modest_connection_specific_smtp_edit_window_init),
 619         (modest_connection_specific_smtp_edit_window_save_settings):
 620         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 621         * src/maemo/modest-connection-specific-smtp-window.c:
 622         (modest_connection_specific_smtp_window_finalize),
 623         (modest_connection_specific_smtp_window_fill_with_connections),
 624         (on_button_edit), (modest_connection_specific_smtp_window_init):
 625         * src/maemo/modest-connection-specific-smtp-window.h:
 626         Implementing saving of connection-specific server accounts.
 627
 628         But I need to refactor this so we can save the data for each
 629         possible connection-specific account and only actually create the server accounts
 630         when the easysetup finished, or the OK button is pressed on the account settings
 631         dialog.
 632
 633 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 634
 635         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 636         (on_combo_security_changed):
 637         (modest_connection_specific_smtp_edit_window_init):
 638         Auto-fill the port number as in the account settings.
 639
 640         (modest_connection_specific_smtp_edit_window_set_connection):
 641         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 642         * src/maemo/modest-connection-specific-smtp-window.c:
 643         (fill_with_connections), (on_button_edit),
 644         (modest_connection_specific_smtp_window_init):
 645         Turn the edit window into a dialog to simplify the code, and
 646         set a WM hint as in a GtkDialog, because only a popup can be on top of
 647         another window in Maemo, and popups usually have no WM decoration.
 648
 649         * src/modest-defs.h:
 650         * src/modest-account-mgr-helpers.c:
 651         (modest_account_mgr_set_connection_specific_smtp),
 652         (modest_account_mgr_remove_connection_specific_smtp),
 653         (modest_account_mgr_get_connection_specific_smtp):
 654         * src/modest-account-mgr-helpers.h: Some functions to write the
 655         connection-specific SMTP server information. Not yet used.
 656
 657
 658         * src/widgets/modest-folder-view.c: (text_cell_data):
 659         Fix a warning about an uninitialized variable.
 660         (on_configuration_key_changed): Put an #ifdef around the use
 661         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 662
 663 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 664
 665         * src/maemo/modest-account-settings-dialog.h:
 666         * src/maemo/modest-account-settings-dialog.c:
 667         Added connect_for_modified() utility function to mark the new modified boolean.
 668
 669         (create_page_account_details), (create_page_user_details),
 670         (create_page_incoming), (create_page_outgoing), (on_response),
 671         (modest_account_settings_dialog_init),
 672         (modest_account_settings_dialog_set_account_name):
 673         Only warn about unsaved changes when there are actually unsaved changes.
 674
 675         * src/modest-account-mgr-helpers.c:
 676         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 677         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 678         to get the data from there in future.
 679
 680 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 681
 682         * src/modest-defs.h:
 683
 684         * src/modest-account-mgr-helpers.h:
 685         * src/modest-account-mgr-helpers.c:
 686         Store the security account setting in a single conf key instead of using
 687         the options list, so that the list is left for just the to-be-removed camel hack,
 688         and because gconf_client_set_list() is failing for some reason.
 689
 690         * src/modest-account-mgr.c:
 691         (modest_account_mgr_add_server_account):
 692         * src/maemo/modest-account-settings-dialog.c:
 693         (modest_account_settings_dialog_set_account_name),
 694         (save_configuration): Use the renamed functions.
 695
 696
 697 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 698
 699         * src/widgets/Makefile.am:
 700         * src/widgets/modest-limit-retrieve-combo-box.c:
 701         * src/widgets/modest-limit-retrieve-combo-box.h:
 702         * src/widgets/modest-retrieve-combo-box.c:
 703         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 704         the account settings dialog.
 705
 706         * src/modest-defs.h:
 707         * src/modest-account-mgr-helpers.h:
 708         * src/modest-account-mgr-helpers.c:
 709         (modest_server_account_get_option_secure_auth),
 710         (modest_server_account_set_option_secure_auth):
 711         * src/modest-account-mgr.c:
 712         (modest_account_mgr_add_server_account):
 713         Use the existing AUTH_MECH conf key for the secure-auth setting,
 714         instead of putting it in the list options, because this was actually used already.
 715
 716         * src/maemo/modest-account-settings-dialog.c:
 717         (create_page_account_details),
 718         (modest_account_settings_dialog_set_account_name),
 719         (save_configuration):
 720         * src/maemo/modest-account-settings-dialog.h:
 721         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 722         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 723
 724 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 725
 726         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 727         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 728         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 729
 730         * src/modest-defs.h:
 731         * src/maemo/modest-account-settings-dialog.c:
 732         (create_page_incoming), (on_combo_outgoing_security_changed),
 733         (on_combo_incoming_security_changed), (create_page_outgoing),
 734         (modest_account_settings_dialog_set_account_name),
 735         (save_configuration): Load/Save the port number, and change it when the
 736         security combo changes, to suitable defaults.
 737
 738 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 739
 740         * src/modest-account-mgr.c:
 741         (modest_account_mgr_add_server_account): Set the security and secure-auth
 742         options, and add a comment saying that the other camel-specific options should be
 743         removed in future.
 744
 745 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 746
 747         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 748         found by valgrind.
 749         * src/modest-tny-account-store.c: (account_list_free),
 750         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 751         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 752         easy to fix.
 753
 754 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 755
 756         * src/modest-protocol-info.c:
 757         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 758         is required by our UI spec. Maybe something in our implementation will use this eventually.
 759         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 760         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 761         instead of the previous 0 placeholder.
 762
 763         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 764         secure-auth settings.
 765         * src/modest-account-mgr-helpers.h:
 766         * src/modest-account-mgr-helpers.c:
 767         (modest_server_account_data_get_option_secure_auth),
 768         (modest_server_account_set_option_secure_auth),
 769         (modest_server_account_data_get_option_security),
 770         (modest_server_account_set_option_security): Added this API for getting and setting the security
 771         and secure-auth settings.
 772
 773         * src/maemo/modest-account-settings-dialog.h:
 774         * src/maemo/modest-account-settings-dialog.c:
 775         (modest_account_settings_dialog_finalize), (check_data),
 776         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 777         about changing titles.
 778         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 779         (save_configuration): Save the security and secure-auth settings.
 780
 781         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 782         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 783
 784 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 785
 786         * src/modest-defs.h:
 787         * src/modest-account-mgr.c:
 788         (modest_account_mgr_add_server_account):
 789         Added and used defines for the options key and value pair strings,
 790         that are used so far, though they do not seem to correspond to anything in our
 791         UI specs or ModestProtocol enum.
 792
 793         * src/modest-account-mgr-helpers.h:
 794         * src/modest-account-mgr-helpers.c:
 795         (compare_option_strings_for_name),
 796         (modest_server_account_data_get_option_value),
 797         (modest_server_account_data_get_option_bool),
 798         (modest_account_mgr_get_server_account_option):
 799         Added helper functions for parsing the options GSList.
 800
 801 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 802
 803         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 804         display name is based on the supplied account name.
 805         * src/modest-account-mgr.c:
 806         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 807         with an inefficient, but good-enough, implementation.
 808
 809         * src/maemo/easysetup/modest-easysetup-wizard.c:
 810         (create_page_account_details), (on_before_next), (create_account):
 811         Check for existing display names rather than (non-user-visible) account names, and just
 812         create and set a unique account name at the end.
 813
 814         * src/maemo/modest-account-settings-dialog.c:
 815         (modest_account_settings_dialog_init),
 816         (modest_account_settings_dialog_set_account_name),
 817         (create_page_incoming): Show the display name, instead of the account name.
 818         (on_response): Do some (not all) extra checks, as in the UI spec.
 819         (save_configuration): Save the display name if it was changed.
 820
 821 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 822
 823         * po/en_GB.po: Added needed logical ID and translation.
 824         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 825         (init_view): Made the is-default column clicking work.
 826
 827 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 828
 829         * configure.ac:
 830         * src/maemo/easysetup/Makefile.am:
 831         * src/maemo/easysetup/modest-easysetup-wizard.c:
 832         (modest_easysetup_wizard_dialog_init):
 833         * src/maemo/easysetup/provider-data-test.keyfile:
 834         * src/maemo/easysetup/provider-data.keyfile:
 835         Moved the provider data file to the new modest-providers-data package and used it from there.
 836
 837 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 838
 839         * src/modest-local-folder-info.c:
 840         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 841         N_() was already used on the static strings, but this just marks it for translation without
 842         using the translation.
 843
 844 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 845
 846         * src/maemo/modest-account-settings-dialog.c:
 847         (create_page_incoming),
 848         (modest_account_settings_dialog_set_account_name):
 849         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 850         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 851         I will do this if nobody else gets there first.
 852
 853 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 854
 855         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 856         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 857         save the security stuff.
 858
 859 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 860
 861         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 862         Set the email address and user fullname, which I now see must be
 863         done separately.
 864
 865         * src/maemo/modest-account-settings-dialog.h:
 866         * src/maemo/modest-account-settings-dialog.c:
 867          (on_response),
 868         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 869         leave-on-server and authentication.
 870         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 871         how to do the rest.
 872
 873 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 874
 875
 876         * src/maemo/modest-account-settings-dialog.c:
 877         * src/maemo/modest-account-settings-dialog.h:
 878         Most (but not all) of the widgets are now present as specified by the UI spec.
 879         No changes are yet saved, and some details are not properly shown yet.
 880
 881         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 882
 883 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 884
 885         * src/maemo/Makefile.am:
 886         * src/maemo/modest-account-settings-dialog.c:
 887         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 888         an existing account. Doesn't do much yet.
 889
 890         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 891         Open the accounts settings dialog when Edit is clicked.
 892
 893 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 894
 895         * src/maemo/easysetup/Makefile.am:
 896         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 897         (load_from_file):
 898         * src/maemo/easysetup/modest-easysetup-wizard.c:
 899         (modest_easysetup_wizard_dialog_init):
 900         Try to get the source directory from the build system,
 901         instead of hard-coding "./" into the source code, when opening our local
 902         copies of the configuration files.
 903         But this still fails when opening the wizard from the Accounts window,
 904         maybe because the working directory seems to change at runtime.
 905         So the wizard will fail the second time unless you copy the files into their
 906         proper locations - see the stdout warnings for the paths.
 907
 908         (create_page_account_details),(on_before_next):
 909         Check for existing non-server accounts instead of server accounts,
 910         so the default account name is useful again, and to prevent trying to
 911         recreate accounts.
 912
 913         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 914         Show the wizard when New is clicked.
 915
 916         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 917         (init_view): Show the column headers, and show the columns that are
 918         specified in the UI specs. However, something in Maemo's GTK+ prevents
 919         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 920         change the default account. This is despite unsetting the special properties.
 921
 922 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 923
 924         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 925         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 926         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 927         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 928         to make that clearer.
 929         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 930
 931 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 932
 933         * src/maemo/modest-account-view-window.c:
 934         (modest_account_view_window_init),
 935         (modest_account_view_window_new):
 936         Use the same buttons as specified in the
 937         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 938         the existing widgets, which never had a chance of working.
 939         Put the ModestAccountView treeview in a scrolled window.
 940         Do not repeat the initialization in both _init() and _new().
 941
 942         * src/widgets/modest-account-view.c: (update_account_view):
 943         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 944         this widget and window shows no accounts.
 945
 946         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 947
 948 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 949
 950         * src/maemo/easysetup/modest-easysetup-wizard.c:
 951         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 952         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 953         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 954         which seems wrong.
 955
 956         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 957         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 958         accounts exist yet, as in the UI spec.
 959
 960         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 961
 962 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 963
 964         * src/maemo/Makefile.am:
 965         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 966         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 967         New window for editing connection-specific smtp details.
 968         Not fully implemented.
 969
 970         * src/maemo/modest-connection-specific-smtp-window.c:
 971         (modest_connection_specific_smtp_window_finalize) :
 972         unref the tree model.
 973         (on_button_edit): Show the edit window.
 974
 975 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 976
 977         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 978         error for me.
 979
 980         * src/maemo/Makefile.am:
 981         * src/maemo/modest-connection-specific-smtp-window.c:
 982         * src/maemo/modest-connection-specific-smtp-window.h:
 983         New window for showing the list of connections, for connection-specific
 984         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 985         * src/maemo/easysetup/modest-easysetup-wizard.c:
 986         (create_page_custom_outgoing): Show the new window when the button is clicked.
 987
 988 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 989
 990         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 991         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 992         * src/maemo/modest-msg-edit-window.c:
 993         (modest_msg_edit_window_insert_image):
 994         * src/modest-conf.c: (modest_conf_key_escape):
 995         * src/modest-mail-operation.c:
 996         (modest_mail_operation_send_new_mail):
 997         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 998         (modest_ui_actions_on_new_account):
 999         * src/widgets/modest-attachment-view.c: (update_filename_request):
1000         * src/widgets/modest-mail-header-view.c:
1001         Corrected warnings that were breaking the build, by commenting out unused variables,
1002         and a function, and by including a header.
1003
1004 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1005
1006         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1007         so we can #ifdef around platform-specific code when necessary.
1008         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1009         to allow this to build for the GNOME platform too.
1010
1011 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1012
1013         * src/maemo/easysetup/modest-easysetup-wizard.c:
1014         Added util_increment_name() and used it in create_page_account_details()
1015         to make sure that the default account name is always a new name.
1016
1017         (modest_easysetup_wizard_dialog_init),
1018         (set_default_custom_servernames): Some minor memory management fixes.
1019
1020 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1021
1022         * Makefile.am:
1023         * configure.ac:
1024         * src/modest-runtime.c: (init_i18n): Restored the translation
1025         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1026         are defined in config.h, and the translations are installed.
1027
1028         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1029         is defined for translation.
1030
1031 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1032
1033         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1034         (load_from_file):
1035         * src/maemo/easysetup/modest-easysetup-wizard.c:
1036         (modest_easysetup_wizard_dialog_init):
1037         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1038         Use realistic paths (though they should use $prefix generically) to the
1039         mcc_mapping and provider-data.keyfile files which might work when they
1040         are installed by the future version of the operator-wizard package,
1041         and then fallback to paths in our source code, with an explanatory
1042         warning.
1043
1044 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1045
1046         * configure.ac:
1047         * src/Makefile.am:
1048         * src/maemo/Makefile.am:
1049         * src/maemo/easysetup/: Added files from the previously-exernal
1050         osso-modest-easysetup.
1051         * src/maemo/modest-main-window-ui.h:
1052         * src/modest-ui-actions.c:
1053         * src/modest-ui-actions.h:
1054         Added modest_ui_actions_on_new_account() as a signal handler for the
1055         New Account menu item. It shows the easysetup wizard.
1056         * po/en_GB.po: Added additional needed logical IDs and translations.
1057
1058 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1059 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1060