1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-global-settings-dialog.c:
4 (current_connection): Check that we are even connected before trying to
5 get the current connection name, to prevent a warning.
7 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
8 Change the comments because tny_maemo_conic_device_connect() is now meant to
10 * src/modest-mail-operation.c:
11 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
12 make sure we have a connection and fail if we can't connect.
14 2007-05-31 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/modest-main-window.c:
17 (on_account_store_connecting_finished): Do not try to get the
18 connection ID if we are not really connected. I am surprised that
19 this signal handler is called when we are not connected.
21 2007-05-31 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-ui-actions.c:
25 (modest_ui_actions_get_msgs_full_error_handler):
26 Renamed an enum, added comments, added an enum
27 for retrieve-limit errors.
29 * src/modest-mail-operation.c: (foreach_add_item),
30 (internal_folder_observer_update), (update_account_thread),
31 (modest_mail_operation_get_msgs_full):
32 (modest_mail_operation_update_account),
33 Added comments about how this works, and some code that should
34 (but does not) check the retrieve-limit. See the TODO comment.
36 2007-05-31 Murray Cumming <murrayc@murrayc.com>
38 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
39 Initialize help_id to fix the build. Warnings are good.
41 2007-05-31 Murray Cumming <murrayc@murrayc.com>
43 * src/widgets/modest-hbox-cell-renderer.c:
44 (modest_hbox_cell_renderer_append):
45 * src/widgets/modest-vbox-cell-renderer.c:
46 (modest_vbox_cell_renderer_append):
47 Fix the last commit by doing an extra ref.
49 2007-05-31 Murray Cumming <murrayc@murrayc.com>
51 * src/widgets/modest-hbox-cell-renderer.c:
52 (modest_hbox_cell_renderer_append):
53 * src/widgets/modest-vbox-cell-renderer.c:
54 (modest_vbox_cell_renderer_append):
55 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
56 to fix the build with Maemo Bora.
57 However, there seems to be a remaining crash, probably due to reference
60 2007-05-30 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-tny-account.c:
63 (modest_tny_account_new_for_local_folders):
64 Use hildon_file_system_info_async_new() to get a better name for
65 the memory card account, setting it as the account name.
66 The timing seems to work, but this is probably
67 not the best place to do this. See the TODO comment.
68 * src/maemo/modest-main-window.c: (create_details_widget):
69 * src/widgets/modest-folder-view.c: (text_cell_data):
70 Use the tny account name instead of hardcoding a name.
72 2007-05-30 Christian Kellner <ckellner@openismus.com>
74 * src/modest-search.c: (modest_search):
75 Correctly set part_search_func even if we have already parsed
76 the query and thus a valid OgsTextSearcher object.
78 2007-05-30 Christian Kellner <ckellner@openismus.com>
81 Search and check for libogs.
84 Incooparte the ogs build env.
86 * src/modest-mime-part-search-stream.c:
87 * src/modest-mime-part-search-stream.h:
88 Removed since we do the real searching now in modest-search.c.
90 * src/modest-search.c:
91 * src/modest-search.h:
92 Implement support for ogs. We use that if available and requested
93 and fall back to modest_text_utils_utf8_strcmp (). The search logic
94 should now handle the corner case when the search term is spread
95 across multiple reads.
96 Also the logic in modest_search () was corrected to search all
97 requested fields until one is found.
99 2007-05-30 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
104 * src/modest-init.c: Made modest_init_local_folders() take a
105 path and be public so we can iniitialize maildir folders on
108 * src/modest-local-folder-info.h:
109 * src/modest-local-folder-info.c:
110 (modest_local_folder_info_get_maildir_path): Add a path parameter.
112 * src/modest-tny-account.c:
113 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
114 still means the standard local-folders path on the local volume.
116 * src/modest-tny-account-store.c:
117 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
118 signal so we can detect mount/unmount of the MMC1 card, and do an update of
119 all accounts when that happens.
120 (get_server_accounts): If the MMC1 card is mounted, create a store account for
121 this too, so it shows up in the treeview.
123 2007-05-28 Murray Cumming <murrayc@murrayc.com>
125 * src/maemo/modest-maemo-global-settings-dialog.c:
126 (current_connection):
127 * src/widgets/modest-global-settings-dialog.c:
128 (current_connection_default):
129 Use the enum values instead of 0, 1 and -1,
130 to make the code clearer.
132 * src/modest-account-mgr-helpers.c:
133 (modest_account_mgr_get_connection_specific_smtp): Make this code
136 * src/modest-runtime.h:
137 * src/modest-runtime.c:
138 Added modest_runtime_remove_all_send_queues().
139 * src/maemo/modest-main-window.c:
140 (on_account_store_connecting_finished): Recreate the send queues,
141 using the appropriate transport accounts for this new connection.
142 Some futher adapting might be needed if the old send queues are not
143 automatically stopped at this point.
145 * src/modest-tny-account-store.c: (get_server_accounts):
146 Create the connection-specific transport accounts, so that they can
147 be found later by their ID.
149 * src/modest-tny-account.h:
150 * src/modest-tny-account.c:
151 Added modest_tny_account_new_from_server_account_name().
152 modest_tny_account_new_from_server_account(): Do not create the
153 send queues here, because they will be
154 recreated anyway when the connection changes for the first time.
156 2007-05-28 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-local-folder-info.h:
159 * src/modest-local-folder-info.c:
160 (modest_per_account_local_outbox_folder_info_get_maildir_path),
161 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
162 tbox_folder): Take a modest account name instead of a server TnyAccount,
163 so we can have per-modest-account rather than per-transport-account
165 We must make sure that we change or recreate the exisitng send queues
166 when the connection changes for connection-specific transport accounts.
168 * src/modest-tny-account-store.c:
169 (create_per_account_local_outbox_folders): Create outboxed per modest
170 account, not per transport account.
172 * src/modest-tny-account.h:
173 * src/modest-tny-account.c:
174 (modest_tny_account_get_special_folder): For outboxes, get the
175 parent modest account name. The account is ignored for other folders.
176 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
177 modest account name rather than a server TnyAccount.
179 2007-05-25 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-tny-account.c:
182 (modest_tny_account_new_from_server_account):
183 Call modest_runtime_get_send_queue() immediately after creating transport
184 accounts, so that they start trying to send email from the outbox as soon
185 as possible at startup. This is probably what we want.
187 * src/modest-mail-operation.c: (update_account_thread):
188 * src/modest-runtime.c: (modest_runtime_get_send_queue):
189 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
190 * src/modest-tny-send-queue.h:
191 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
192 (modest_ui_actions_on_send):
193 Added comments about how sending works, though it needs some more work.
195 2007-05-25 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-tny-account.c:
198 (modest_tny_account_get_special_folder): Add TODO because this fails when
200 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
201 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
202 Do not try to show this window when there is no active account. The UI
203 specs does not tell us what to do in this case.
205 2007-05-24 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/Makefile.am:
210 * src/widgets/Makefile.am: Some dist fixes.
212 2007-05-24 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/modest-connection-specific-smtp-window.c:
215 (on_button_edit): Make the code clearer, to prevent a double free.
217 2007-05-24 Murray Cumming <murrayc@murrayc.com>
219 * src/maemo/modest-account-settings-dialog.c:
220 (modest_account_settings_dialog_set_account_name),
221 Check the connection-specific smtp servers checkbox if there are any.
223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
224 (modest_connection_specific_smtp_edit_window_init):
225 Start with a suitable port number.
227 * src/modest-account-mgr-helpers.h:
228 * src/modest-account-mgr-helpers.c: Added
229 modest_account_mgr_get_has_connection_specific_smtp().
231 (modest_account_mgr_set_connection_specific_smtp),
232 (modest_account_mgr_remove_connection_specific_smtp),
233 (modest_account_mgr_get_has_connection_specific_smtp),
234 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
235 connection-specific smtp server accounts in the account, rather than
236 the server account conf dir.
238 This fixes bug projects.maemo.org bug NB#58263 .
240 * src/modest-tny-account-store.c:
241 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
242 if there are no server accounts yet, to prevent an infinite loop when there
243 are no accounts. Document that one must be called before the other.
245 2007-05-24 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-account-mgr-helpers.c:
248 (modest_account_mgr_get_default_account): Make sure that at least
249 one account is always the default, if there are any enabled accounts.
250 This is just a sanity check that shouldn't be necessary.
252 * src/modest-account-mgr-priv.c:
253 (_modest_account_mgr_account_from_key): Unescape the conf key to
254 get the real account name. For instance, this is an issue if a space
255 was in the account name, which can happen because the account name
256 is generated from the display name.
257 (_modest_account_mgr_get_account_keyname): Always escape the
259 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
260 Unescape the conf keys to get the real account names.
262 For instance, previously the is-default radio button in the accounts
263 list was not checked for any accounts at first. This fixes that,
264 and might fix several similar bugs.
266 2007-05-23 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
269 Removed some debug printfs.
271 2007-05-23 Murray Cumming <murrayc@murrayc.com>
273 Modest on-disk outbox directories are now here, for instance:
274 $HOME/.modest/outboxes/<account-id-1>/outbox
275 $HOME/.modest/outboxes/<account-id-2>/outbox
277 $HOME/.modest/local-folders/outbox
278 so we can have a separate outbox for each account.
279 But they are shown as one outbox in the GtkTreeView, by using a
280 TnyMergeFolder in a ModestTnySimpleFolderStore.
283 * src/modest-tny-simple-folder-store.c:
284 * src/modest-tny-simple-folder-store.h:
285 Added ModestTnySimpleFolderStore, used to contain folders from
286 other folder stores, such as other accounts.
288 * src/modest-tny-outbox-account.h:
289 * src/modest-tny-outbox-account.c:
290 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
291 used for the per-account local outbox folders.
293 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
294 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
295 only use this (internally) now for the non-outbox local folders.
298 * src/modest-init.c: Added modest_init_one_local_folder(), for
299 setting up the directory structure for each local folder.
301 * src/modest-local-folder-info.c:
302 (modest_per_account_local_outbox_folder_info_get_maildir_path),
303 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
305 * src/modest-local-folder-info.h:
306 * src/modest-tny-account-store.c: (on_account_removed),
307 (on_account_changed), (create_per_account_local_outbox_folders),
308 (get_server_accounts), (modest_tny_account_store_get_accounts),
309 (modest_tny_account_store_get_tny_account_by_account),
310 (modest_tny_folder_store_is_virtual_local_folders):
312 * src/modest-tny-account.h:
313 * src/modest-tny-account.c:
314 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
315 to create an on-disk per-account local outbox folder for each
317 (create_per_account_local_outbox_folders): Create a local outbox folder
318 for each transport account.
319 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
320 for all local folders.
322 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
323 instead of using g_object_get/set() directly. It is clearer.
325 (modest_tny_folder_store_get_message_count),
326 (modest_tny_folder_store_get_local_size
327 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
328 because we now use these with non-acount folder stores.
330 (modest_tny_account_get_special_folder),
331 (modest_tny_account_new_from_server_account),
332 (modest_tny_account_new_from_account):
333 (recurse_folders): Adjust to the new outbox system.
335 * src/modest-tny-folder.h:
336 * src/modest-tny-folder.c:
337 (modest_tny_folder_is_local_folder),
338 (modest_tny_folder_get_local_folder_type),
339 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
341 * src/widgets/modest-main-window.h:
342 * src/maemo/modest-main-window.c: (create_details_widget),
343 (modest_main_window_set_contents_style): Show details for any folder store,
346 (modest_tny_folder_get_rules):
347 Remove the const. C does not support constness enough for this.
349 * src/modest-ui-actions.c:
350 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
351 make all outboxes appear as one, in the usual local-folders tree node.
353 (set_active_account_from_tny_account),
354 (modest_ui_actions_on_folder_selection_changed):
355 * src/widgets/modest-folder-view.c: (text_cell_data),
356 (icon_cell_data), (filter_row),
357 (add_account_folders_to_merged_folder),
358 (add_account_folders_to_simple_folder_store), (),
359 (get_cmp_rows_type_pos), (cmp_rows),
360 (modest_folder_view_set_account_id_of_visible_server_account):
361 Adjust to the new outbox system, using generic folder stores and folders
364 2007-05-23 Christian Kellner <ckellner@openismus.com>
366 * src/modest-mail-operation.c:
367 (modest_mail_operation_update_account):
368 Use info->max_size instead of unintialized local var [small
369 build fix]. (Added TODO to review that change since I don't
372 2007-05-23 Marcus Bauer <marcusb@openismus.com>
374 * libmodest-dbus-client/libmodest-dbus-client.c:
375 (libmodest_dbus_client_compose_mail): function added
376 * src/dbus_api/modest-dbus-api.h:
377 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
378 (on_compose_mail): Implementation of the SendAsMail functionality
380 2007-05-22 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-account-mgr.c:
383 (modest_account_mgr_add_server_account): Set the secure-connection
384 conf key for transport accounts as well as store accounts. I don't know
385 why the if was there. For instance, this makes sure that we use SSL
386 for the gmail preset from the easysetup wizard.
388 2007-05-22 Murray Cumming <murrayc@murrayc.com>
390 * src/gnome/modest-main-window.c:
391 (on_account_store_connecting_finished), (connect_signals):
392 * src/maemo/modest-main-window.c:
393 (on_account_store_connecting_finished), (connect_signals),
394 (modest_main_window_new):
395 Handle TnyAccountStore::connecting-finished instead of
396 TnyDevice::connection-changed, because we cannot actually perform
397 operations on accounts until TnyAccountStore has itself responded to
398 the TnyDevice::connection-changed signal. This prevents a GError from
400 Do not try to update at startup, because we (at least on scratchbox)
401 already do an update at startup when the device goes online.
402 This prevents a GError from tinymail.
403 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
404 Added TODO about stopping simultaneous operations.
406 2007-05-21 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
409 * src/modest-mail-operation-queue.c:
410 (modest_mail_operation_queue_remove):
411 * src/modest-tny-account-store.c: When GErrors happen, give more clues
412 about where they happened.
414 2007-05-21 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-ui-actions.c:
417 (modest_ui_actions_on_password_requested): Make sure that the remember
418 output parameter is always TRUE.
420 2007-05-21 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
423 Show a OK/Cancel dialog if the error is a question, though we still do not
424 know anything more about what we are asking the user.
425 * src/widgets/modest-folder-view.c: (on_drag_data_received):
426 Fix an uninitialized variable (helper). This is a logic error, however.
428 2007-05-21 Christian Kellner <ckellner@openismus.com>
430 * src/modest-search.h:
431 Correct bit shifting in the ModestSearchFlags enum.
433 2007-05-21 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-tny-account.c:
436 (modest_tny_account_new_from_server_account): Do not use the lsub and
437 check-all hard-coded IMAP options when using POP.
439 2007-05-21 Murray Cumming <murrayc@murrayc.com>
441 * src/modest-tny-account.c:
442 (modest_tny_account_new_from_server_account):
443 Use NULL for the secure-auth method for POP when Password auth has been
444 specified by the user, as we already do for IMAP. "auth=Login" causes
445 an error from camel or the server.
447 2007-05-17 Murray Cumming <murrayc@murrayc.com>
449 * src/maemo/modest-account-settings-dialog.c:
450 (create_page_account_details),
451 (modest_account_settings_dialog_set_account_name):
452 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
453 for the leave-on-server checkbox, rathr than just the checkbox, when
454 the protocol is not POP.
456 2007-05-17 Murray Cumming <murrayc@murrayc.com>
458 * src/widgets/modest-account-view.c:
459 * src/widgets/modest-account-view.h:
460 Added modest_account_view_select_account() which will be useful later
461 to asynchronously re-select the edited account.
463 2007-05-17 Murray Cumming <murrayc@murrayc.com>
465 * src/maemo/modest-account-settings-dialog.c:
466 (modest_account_settings_dialog_set_account_name):
467 Automatically choose the port numbers based on the secure authentication
468 methods, if they have not been chosen before.
469 This fixes projects.maemo.org bug NB#56273 .
471 2007-05-17 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/modest-main-window-ui.h:
474 * src/modest-ui-actions.c:
475 * src/modest-ui-actions.h:
476 Connect the Tools/SMTP Servers menu item to
477 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
478 SMTP servers dialog, as in the UI specification and saves changes when it
479 is closed. This fixed projects.maemo.org bug NB#56305 .
481 2007-05-17 Murray Cumming <murrayc@murrayc.com>
483 * src/maemo/modest-connection-specific-smtp-window.c:
484 (modest_connection_specific_smtp_window_init):
485 Use gtk_window_set_default_size() to make this window big enough, so
486 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
488 2007-05-17 Murray Cumming <murrayc@murrayc.com>
490 * src/maemo/modest-connection-specific-smtp-edit-window.h:
491 * src/maemo/modest-connection-specific-smtp-edit-window.c:
492 (modest_connection_specific_smtp_edit_window_init),
493 Do not try to connect to a combobox signal before the combobox exists.
494 This fixes the cras in projects.maemo.org bug NB#56288 .
495 (modest_connection_specific_smtp_edit_window_get_settings):
496 Remove the server_account_name parameter which was being checked for NULL
497 though it was not used.
499 * src/maemo/modest-connection-specific-smtp-window.c:
500 (modest_connection_specific_smtp_window_fill_with_connections),
501 (on_button_edit), (modest_connection_specific_smtp_window_init):
502 Correct the number of treemodel columns to prevent a warning.
503 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
504 libconic does not work.
506 2007-05-16 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-tny-account.c:
509 (modest_tny_account_new_from_server_account):
510 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
511 SMTP when "None" was chosen by the user. However, with my SMTP server that
512 does not support ANONYMOUS, the emails do not leave the Outbox and I see
515 2007-05-16 Murray Cumming <murrayc@murrayc.com>
517 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
518 to explain the memory management issue with the ID in the ModestPair.
520 * src/gnome/modest-account-assistant.c: (add_receiving_page),
521 (add_sending_page), (modest_account_assistant_finalize):
522 * src/gnome/modest-gnome-global-settings-dialog.c:
523 (create_updating_page), (create_composing_page):
524 * src/gnome/modest-msg-edit-window.c: (get_transports),
525 (init_window), (modest_msg_edit_window_finalize),
526 (modest_msg_edit_window_get_msg_data):
527 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
528 * src/gnome/modest-transport-widget.c:
529 (modest_transport_widget_finalize), (smtp_configuration):
530 * src/maemo/modest-maemo-global-settings-dialog.c:
531 (create_updating_page), (create_composing_page):
532 * src/maemo/modest-msg-edit-window.c: (get_transports),
533 (init_window), (modest_msg_edit_window_finalize),
534 (modest_msg_edit_window_get_msg_data),
535 (modest_msg_edit_window_free_msg_data):
536 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
537 (modest_store_widget_finalize):
538 * src/maemo/modest-transport-widget.c:
539 (modest_transport_widget_finalize), (smtp_configuration):
540 * src/modest-main.c: (send_mail):
541 * src/widgets/modest-combo-box.h:
542 * src/widgets/modest-global-settings-dialog-priv.h:
543 * src/widgets/modest-global-settings-dialog.c:
544 (modest_global_settings_dialog_finalize):
545 * src/widgets/modest-msg-edit-window.h:
546 Whenever using modest_combo_box_new(), keep the ModestPairList alive
547 as long as the combo box, to prevent use of freed memory for the ID.
549 2007-05-15 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
552 get_accounts(), to make this clearer. Do not check for the enabled gconf
553 key, because we do not use this for server accounts (at least, not yet).
554 This allows us to send email again.
556 2007-05-15 Murray Cumming <murrayc@murrayc.com>
558 * src/maemo/modest-platform.c:
559 (on_modest_conf_update_interval_changed), (modest_platform_init):
560 Only respond to this particular key change. All these strcmp()s cannot be
563 2007-05-15 Murray Cumming <murrayc@murrayc.com>
565 * src/maemo/modest-maemo-global-settings-dialog.c:
566 (current_connection): Prevent a crash in scratchbox when
567 ny_maemo_conic_device_get_current_iap_id() returns NULL.
568 * src/maemo/modest-platform.c:
569 (on_modest_conf_update_interval_changed), (modest_platform_init):
570 Get the update interval from gconf and reset it when the gconf key changes.
572 2007-05-15 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-protocol-info.c:
575 * src/modest-protocol-info.h: Adde enum-specific get functions,
576 instead of using a ModestProtocolType enum parameter.
578 * src/gnome/modest-account-assistant.c:
579 * src/gnome/modest-store-widget.c:
580 * src/gnome/modest-store-widget.h:
581 * src/gnome/modest-transport-widget.c:
582 * src/gnome/modest-transport-widget.h:
583 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
584 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
585 * src/maemo/easysetup/modest-easysetup-wizard.c:
586 * src/maemo/modest-account-settings-dialog.c:
587 * src/maemo/modest-account-settings-dialog.h:
588 * src/maemo/modest-store-widget.c:
589 * src/maemo/modest-store-widget.h:
590 * src/maemo/modest-transport-widget.c:
591 * src/maemo/modest-transport-widget.h:
592 * src/modest-account-mgr-helpers.c:
593 * src/modest-account-mgr-helpers.h:
594 * src/modest-account-mgr.c:
595 * src/modest-account-mgr.h:
596 * src/modest-tny-account.c:
597 * src/modest-tny-folder.c:
598 * src/widgets/modest-account-view.c:
599 * src/widgets/modest-retrieve-combo-box.c:
600 * src/widgets/modest-retrieve-combo-box.h:
601 * src/widgets/modest-secureauth-combo-box.c:
602 * src/widgets/modest-serversecurity-combo-box.c:
603 * src/widgets/modest-serversecurity-combo-box.h:
604 * tests/check_account-mgr.c:
605 Use the specific functions, and use the re-renamed enum values for GNOME too.
607 2007-05-15 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
611 so we can get the second based on the first.
613 * src/maemo/modest-account-settings-dialog.h:
614 * src/maemo/modest-account-settings-dialog.c:
615 Added get_supported_secure_authentication_methods(), though it is mostly
616 commented-out for now until the necessary API is committed to tinymail.
617 (modest_account_settings_dialog_set_account_name),
618 (save_configuration): Request the supported authentication methods from the
619 server, so we can choose a working method.
621 * src/modest-tny-account-store.h:
622 * src/modest-tny-account-store.c:
623 (modest_tny_account_store_get_session): Rename from
624 tny_account_store_get_session().
626 2007-05-14 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-protocol-info.h: Split the ModestProtocol enum
629 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
630 There was no need to have these unrelated values in one enum.
632 * src/: many files: Adapted to changed enum. This makes the code a bit
633 clearer, and the compiler could catch some errors.
635 2007-05-14 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
638 Show the detailed internal camel error message when an error happens
639 during the configuration, so that our testers can give us more clues.
640 For instance, in projects.maemo.org bug NB#56910 .
642 2007-05-14 Murray Cumming <murrayc@murrayc.com>
644 * src/modest-tny-account.c:
645 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
646 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
648 2007-05-14 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
651 * src/maemo/modest-account-settings-dialog.c:
652 (modest_account_settings_dialog_set_account_name),
653 (save_configuration): For the incoming secure authentication checkbox,
654 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
655 the UI specification. PLAIN does not seem to be supported for most IMAP
656 servers anyway, and I am not sure what it would mean.
657 However, we probably need to discover which of the secure-authentication
658 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
659 * src/modest-account-mgr-helpers.c:
660 (modest_account_mgr_get_server_account_data):
662 * src/modest-tny-account.c:
663 (modest_tny_account_new_from_server_account):
664 Use tny_account_set_mech() to set secure-authentication methods,
665 with some special-casing for IMAP, based on my observations of how
668 * src/modest-account-mgr-helpers.h:
669 * src/modest-account-mgr.c:
670 * src/modest-defs.h: Comment that the URI is only used for local folders.
672 2007-05-11 Murray Cumming <murrayc@murrayc.com>
674 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
675 parameter const, just to be neat.
676 * src/modest-text-utils.c: (modest_text_utils_inline):
677 End g_strconcat() with NULL, as its documentation says. This is almost
678 certainly the cause of my crash at startup on the device. Interestingly,
679 valgrind doesn't tell us about these errors.
681 2007-05-11 Murray Cumming <murrayc@murrayc.com>
683 * scripts/build-packages: Added more precise comments about how to use
684 this script, though I still get this error:
685 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
686 error building tinymail
688 2007-05-11 Murray Cumming <murrayc@murrayc.com>
690 * src/maemo/modest-main-window.c: (on_account_update):
691 Very slight cleanup, hoping to make it simpler to discover what causes
692 a crash here sometimes.
694 * src/modest-tny-account.c:
695 (modest_tny_account_new_from_server_account): Set the port. Added
696 comments about the options and a TODO comment because I need to find out
697 how to specify the secure authentication method.
699 2007-05-11 Marcus Bauer <marcusb@openismus.com>
701 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
702 changed CFlags paths form modest to libmodest
704 2007-05-10 Murray Cumming <murrayc@murrayc.com>
706 * src/modest-account-mgr-helpers.c:
707 (modest_account_mgr_get_server_account_data),
708 (modest_account_mgr_free_server_account_data):
709 * src/modest-account-mgr-helpers.h:
710 * src/modest-account-mgr.c:
711 (modest_account_mgr_add_server_account):
713 * src/modest-tny-account.c:
714 (modest_tny_account_new_from_server_account):
715 Determine the options for tny_camel_account_add_option() here,
716 based on the settings, rather than storing them directly in gconf.
718 2007-05-10 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
721 Show a more friendly error dialog now that we expect (from the tinymail
722 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
724 2007-05-10 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-main-window.c: (on_account_update): Check that
727 account_name is not NULL, to prevent a crash at startup that I am
728 seeing on the N800. I do wonder why it is NULL.
730 * src/maemo/easysetup/modest-easysetup-wizard.c:
731 (create_page_user_details):
732 * src/maemo/modest-account-settings-dialog.c:
733 (create_page_user_details), (create_page_outgoing):
734 * src/maemo/modest-connection-specific-smtp-edit-window.c:
735 (modest_connection_specific_smtp_edit_window_init):
736 * src/modest-ui-actions.c:
737 (modest_ui_actions_on_password_requested):
738 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
739 might do something useful with the on-screen keyboard.
741 2007-05-10 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/modest-main-window.c: (on_account_update):
744 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
745 NULL, to avoid lots of warnings. However, it probably should not be NULL.
747 2007-05-09 Murray Cumming <murrayc@murrayc.com>
749 * src/modest-tny-account-store.c: (on_account_changed):
750 Correct the signature of this signal handler.
752 2007-05-09 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
755 Show a HildonNote instead of a GtkDialog for Maemo.
757 2007-05-09 Murray Cumming <murrayc@murrayc.com>
759 * src/widgets/modest-account-view.h:
760 * src/widgets/modest-account-view.c: (on_account_changed),
761 (on_account_removed). Added a boolean flag, set/unset by
762 modest_account_view_block_conf_updates(),
763 modest_account_view_unblock_conf_updates() to prevent unnecessary
764 updates, but this is not very useful because the gconf notifications are
765 so delays (maybe only on Maemo Bora).
766 So auto-updating is turned off, and these functions do an explicit
767 update when necessary.
768 However, something else is still doing too much work when adding/removing
769 accounts, probably in another part of the application.
771 * src/maemo/modest-account-view-window.c:
772 (on_delete_button_clicked), (on_edit_button_clicked),
773 (on_new_button_clicked): Use the new functions.
775 2007-05-09 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-account-mgr-helpers.c:
778 (modest_account_mgr_set_first_account_as_default):
779 Sort the list of names alphabetically-by-title, so we choose the first one
781 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
782 alphabetically by the title.
784 This fixes projects.maemo.org bug NB#56418 .
786 * src/modest-account-mgr-priv.c:
787 (_modest_account_mgr_account_from_key):
788 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
789 avoid a valgrind error, and possible random behaviour.
791 2007-05-09 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
794 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
795 tinymail documentation to say that this can be expected.
796 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
797 pretty, and should not happen, but I would prefer to know when it does.
799 2007-05-09 Murray Cumming <murrayc@murrayc.com>
801 * configure.ac: When using the older hildon version, probably on Bora,
802 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
804 * src/widgets/modest-attachment-view.c:
805 (modest_attachment_view_set_part_default): Initialize variables, to fix the
808 2007-05-09 Marcus Bauer <marcusb@openismus.com>
810 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
811 Implemented the prototype. Can be tested with
812 tests/dbus_api/test_open_message:
814 2007-05-08 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account-store.c:
817 (modest_tny_account_store_instance_init), (get_password):
818 * src/modest-ui-actions.c:
819 (modest_ui_actions_on_password_requested):
820 Do not store the password in gconf, because this function is called
821 for non-remembered passwords. Actually use the cached (in the hash map)
822 password instead of releasing it.
823 The password will now not be remembered if it is asked via the protected
824 password dialog, as per the UI spec.
826 2007-05-08 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-account-mgr-helpers.h:
830 * src/modest-account-mgr-helpers.c:
831 Added modest_server_account_get_username_has_succeeded(),
832 modest_server_account_set_username_has_succeeded().
833 (modest_server_account_set_username),
834 Reset the has-succeeded flag if the username changes.
836 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
837 * src/maemo/modest-connection-specific-smtp-window.c:
838 (modest_connection_specific_smtp_window_save_server_accounts):
839 Use modest_server_account_set_username() instead of using
840 modest_conf_set_string() directly, so that the has-succeeded flag is always
843 * src/modest-ui-actions.c:
844 (modest_ui_actions_on_password_requested): Dim the username entry if
845 the username has ever worked, as per the UI spec.
847 2007-05-08 Murray Cumming <murrayc@murrayc.com>
849 * src/modest-tny-account-store.c: (get_password):
850 * src/modest-ui-actions.c:
851 (modest_ui_actions_on_password_requested):
852 Allow the username to be changed too, though there is more work to
853 be done on exactly how this behaves.
855 2007-05-08 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-account-mgr-helpers.h:
858 * src/modest-account-mgr-helpers.c:
859 Added modest_account_mgr_get_display_name(),
860 modest_server_account_get_username(),
861 modest_server_account_set_username(),
862 modest_server_account_set_password(),
863 modest_server_account_get_hostname() functions so we do not need to
864 use the conf API directly.
866 * src/maemo/modest-main-window.c: (connect_signals):
867 Actually connect ot the ModestAccountStore::request-password signal,
868 so that we show the dialog when the password is requested by Tinymail,
869 for isntance if it is empty.
871 * src/modest-marshal.list:
872 * src/modest-tny-account-store.c:
873 (modest_tny_account_store_class_init), (get_password),
874 (modest_tny_account_store_alert):
875 * src/modest-tny-account-store.h:
876 * src/modest-ui-actions.h:
877 * src/modest-ui-actions.c:
878 (modest_ui_actions_on_password_requested):
879 Change the signal parameters, so it is obvious that we are providing
880 the non human-readable server name, and receiving both the username
881 and password, though changing of the username is not yet implemented.
882 Change the dialog UI to match the Maemo UI specifications, with #idfefing
883 for the GNOME version.
885 This should fix the projects.maemo.org bug NB#56209, though it does not
886 work on Bora, because the gconf_client_get() for the password fails
887 immediately after we save it with gconf_client_set().
889 2007-05-08 Murray Cumming <murrayc@murrayc.com>
892 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
893 caused an undefined symbol error:
894 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
896 2007-05-08 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-tny-account-store.c:
899 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
900 using a GError instead of a string message, so we can translate it in
903 2007-05-08 Murray Cumming <murrayc@murrayc.com>
905 * src/maemo/modest-address-book.c:
906 (modest_address_book_check_names):
907 * src/maemo/modest-msg-view-window.c:
908 (modest_msg_view_window_clipboard_owner_change):
909 * src/modest-init.c: (modest_init_init_ui):
910 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
911 (update_folders_cb), (modest_mail_operation_update_account):
912 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
913 (modest_ui_actions_on_msg_attachment_clicked),
914 (modest_ui_actions_on_msg_recpt_activated):
915 * src/widgets/modest-header-view.c: (drag_data_get_cb):
916 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
917 (modest_msg_view_search_next):
918 * src/widgets/modest-recpt-editor.c:
919 (modest_recpt_editor_on_button_release_event),
920 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
921 g_message(). At this point we should only be seeing interesting errors on
922 stdout. Debugging messages could be #ifdefed-out if they are still useful.
924 2007-05-07 Murray Cumming <murrayc@murrayc.com>
926 (modest_wizard_dialog_force_title_update):
927 * src/maemo/easysetup/modest-wizard-dialog.h:
928 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
929 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
930 can update the title when appropriate. Otherwise the title is wrong if the
931 pages are added after adding the notebook to the dialog.
932 This must be a problem in HildonWizardDialog too.
933 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
935 * src/maemo/easysetup/modest-easysetup-wizard.c:
936 (create_subsequent_customsetup_pages),
937 (create_subsequent_easysetup_pages):
938 Call modest_wizard_dialog_force_title_update() so that the title is
939 correct even with GTK+ < 2.10.
940 This fixes projects.maemo.org bug NB#56145 .
942 2007-05-07 Murray Cumming <murrayc@murrayc.com>
944 * src/maemo/modest-platform.c:
945 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
946 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
949 2007-05-07 Murray Cumming <murrayc@murrayc.com>
951 * src/widgets/modest-window.h:
952 * src/widgets/modest-window.c: Added a save_state_func vfunc,
953 and modest_window_save_state(), which invokes it.
955 * src/widgets/modest-window-mgr.h:
956 * src/widgets/modest-window-mgr.c:
957 Added modest_window_mgr_save_state_for_all_windows(), which calls
958 the save_state vfunc on all registered windows, if implemented.
960 * src/gnome/modest-msg-edit-window.c:
961 * src/gnome/modest-msg-view-window.c:
962 * src/maemo/modest-msg-edit-window.c:
963 * src/maemo/modest-msg-view-window.c:
964 * src/maemo/modest-main-window.c:
965 Specify the existing save_settings functions as implementations of
966 ModestWindow::save_state_func().
968 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
969 Call modest_window_mgr_save_state_for_all_windows(). This happens before
970 enabling hibernation, for instance.
972 We may need to do the same thing for restoring settings.
975 2007-05-07 Murray Cumming <murrayc@murrayc.com>
977 * src/widgets/modest-window-mgr.c:
978 * src/widgets/modest-window-mgr.h:
979 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
980 modest_window_mgr_get_hibernation_is_prevented().
982 * src/maemo/modest-main-window.c:
983 (on_hildon_program_is_topmost_notify): Prevent hibernation
984 (possible when the application goes to the background in the WM),
985 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
987 * src/maemo/easysetup/modest-easysetup-wizard.c:
988 (modest_easysetup_wizard_dialog_init):
989 * src/maemo/modest-account-settings-dialog.c:
990 (modest_account_settings_dialog_init):
991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
992 (modest_connection_specific_smtp_edit_window_init):
993 * src/maemo/modest-connection-specific-smtp-window.c:
994 (modest_connection_specific_smtp_window_init):
995 * src/maemo/modest-signature-editor-dialog.c:
996 (modest_signature_editor_dialog_init):
997 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
998 prevent hibernation while any of these account settings dialogs are open.
1000 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/Makefile.am:
1003 * src/maemo/modest-osso-state-saving.c:
1004 * src/maemo/modest-osso-state-saving.h: Added
1005 modest_osso_load_state() and modest_osso_save_state() though they do
1006 nothing now. They should iterate through all the open windows and load/save
1008 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1009 save state when closing.
1011 * src/maemo/modest-main-window.c:
1012 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1013 Add a notification handler for the HildonProgram::is-topmost property,
1014 so we can allow hibernation when the application goes into the background.
1015 But we still need to detect when the accounts setup windows are open so
1016 we can stop hibernation when they are open.
1017 To do this, I also added the main window the HildonProgram. This might have
1018 other side-effects/benefits, and should maybe be done for other windows.
1020 * src/maemo/modest-osso-autosave-callbacks.h:
1021 * src/maemo/modest-osso-autosave-callbacks.c:
1022 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1023 though it does not do anything yet, and we might never need this to do
1024 anything. For instance, we already save drafts.
1026 * src/maemo/modest-platform.c: (modest_platform_init):
1027 Specify the libosso auto-save callback.
1029 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1031 * src/maemo/modest-platform.c:
1032 (modest_platform_set_update_interval):
1033 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1034 aparently stays valid between application instances, so we can use this
1035 to remove and reset it later. According to a maemo-developers email from
1038 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1040 * configure.ac: Depend on libalarm for Maemo.
1042 * src/dbus_api/modest-dbus-api.h:
1043 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1044 (on_send_receive), (modest_dbus_req_handler):
1045 Handle a SEND_RECEIVE D-Bus method.
1047 * libmodest-dbus-client/libmodest-dbus-client.c:
1048 (libmodest_dbus_client_send_and_receive):
1049 * libmodest-dbus-client/libmodest-dbus-client.h:
1050 Add C convenience functions for calling the new D-Bus method.
1052 * src/modest-platform.h:
1053 * src/gnome/modest-platform.c:
1054 * src/maemo/modest-platform.c:
1055 Added modest_platform_set_update_interval(), which uses the
1056 alarmd API on Maemo.
1057 (modest_platform_init),
1058 Call modest_platform_set_update_interval(), using a hard-coded
1059 interval for now (until the global settings dialog is implemented),
1060 though I am not sure that this makes sense yet.
1062 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1064 * src/dbus_api/modest-dbus-callbacks.c:
1065 (modest_osso_cb_hw_state_handler):
1066 * src/dbus_api/modest-dbus-callbacks.h:
1067 * src/maemo/modest-platform.c: (modest_platform_init):
1068 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1069 in case this has some effect on the ability for Maemo to ping the
1072 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1075 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1076 warning. It is probably a logic error, but I need to fix the build.
1078 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1080 * src/modest-account-mgr.h:
1081 * src/modest-account-mgr.c:
1082 (modest_account_mgr_account_names): Add a gboolean enabled_only
1083 parameter, so we can get lists of onlt the enabled accounts.
1085 (modest_account_mgr_add_account),,
1086 (modest_account_mgr_account_with_display_name_exists):
1087 * src/maemo/modest-msg-edit-window.c: (get_transports):
1088 * src/modest-account-mgr-helpers.c:
1089 (modest_account_mgr_set_first_account_as_default):
1090 * src/modest-init.c: (init_default_account_maybe):
1091 * src/modest-tny-account-store.c: (get_accounts):
1092 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1093 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1094 * tests/check_account-mgr.c: (START_TEST):
1095 Provide the extra parameter, as appropriate.
1097 * src/widgets/modest-account-view.c: (update_account_view):
1098 Do not show disabled accounts (meaning that there is no way to
1099 enable/disable accounts in the UI (the feature is not in our UI
1100 specification), so we can use this internally only to mark unfinished
1101 or temporary account data.
1103 * src/maemo/easysetup/modest-easysetup-wizard.c:
1104 (create_account): Add boolean enable parameter, so we can specify FALSE
1105 to create the temporary account.
1106 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1107 (on_before_next): When finishing, when there is a temporary account, just
1109 Also, use a timeout to delay the showing of the dialog until gconf is likely
1110 to return correct information, due to a maemo gconf bug that is fixed in
1111 osso 1.1, but not yet in Bora.
1112 However, the dialog stays on screen after it is destroyed.
1114 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1115 for invalid data when cancelling. Use a hildon note instead of a dialog
1116 to complain about invalid data. Do not show the account-saved note if the
1117 account is disabled (a temporary account that will not really be saved for use
1120 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1122 * src/modest-account-mgr-helpers.h:
1123 * src/modest-account-mgr-helpers.c:
1124 Added modest_account_mgr_unset_default_account(),
1125 Added modest_account_mgr_set_first_account_as_default().
1127 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1128 If it was the default account, unset the default account name.
1130 * src/maemo/modest-account-view-window.c:
1131 (on_delete_button_clicked): If it was the default account,
1132 set the first remaining account as the default instead.
1134 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1135 a NULL account or a NULL default account, to prevent a crash. This should
1136 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1139 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1141 * src/widgets/modest-recpt-editor.c:
1142 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1143 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1144 TODO comment for this. This fixes the build.
1146 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1147 be the best place for it. This will in future update all auto-update accounts,
1148 rather than just the current/default account, when that gconf key exists.
1149 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1150 if there are no accounts, before calling do_send_receive().
1151 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1153 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1154 * src/maemo/modest-main-window-ui.h:
1155 * src/maemo/modest-main-window.c: (on_connection_changed),
1156 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1157 directly, becaue the signal handler does more.
1159 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-account-mgr-helpers.c:
1162 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1163 for the case that the account does not exist.
1165 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1166 (equivalent to the modest account name) rather than the tinymail account name
1167 (equivalent to the modest account title - human readable) to get the account data.
1168 Check for null account data to prevent the crash, and add a TODO comment saying that
1169 this needs fixing because it is using the server account name instead of the account name.
1171 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1174 * src/maemo/modest-account-settings-dialog.c: (show_error),
1176 Use hildon_note_new_information() for informative and error messages,
1177 which seems to be expected for Maemo applications (no documentation that I know of
1178 says this). I am surprised that there is no distinction between info and error
1181 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1184 it is easy to find where this is used.
1186 * src/maemo/easysetup/modest-easysetup-wizard.c:
1187 (create_page_welcome), (create_page_account_details),
1188 (create_page_user_details), (create_page_complete_easysetup),
1189 (create_page_custom_incoming), (create_page_custom_outgoing),
1190 (create_page_complete_custom):
1191 * src/maemo/modest-account-settings-dialog.c:
1192 (create_page_account_details), (create_page_user_details),
1193 (create_page_incoming), (create_page_outgoing):
1194 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1195 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1196 (modest_connection_specific_smtp_edit_window_init):
1197 * src/maemo/modest-connection-specific-smtp-window.c:
1198 (modest_connection_specific_smtp_window_init):
1199 * src/maemo/modest-signature-editor-dialog.c:
1200 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1201 and scrolling policy as per the Email Application Layout Guide, if I have
1204 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1206 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1207 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1208 which were empty, because these vfuncs have been removed from TnyAccountStore.
1209 This fixes the build.
1211 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1213 * src/maemo/modest-main-window.c:
1214 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1215 showing/hiding it. Added TODO because it probably should not be NULL.
1216 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1217 because unnecessary g_warnings() make degugging difficult.
1219 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1221 * src/maemo/modest-msg-edit-window.c:
1222 (modest_msg_edit_window_select_color),
1223 (modest_msg_edit_window_select_background_color): 2 const corrections and
1224 moving 2 #endifs before closing brackets, to fix the build.
1226 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/easysetup/modest-easysetup-wizard.h:
1229 * src/maemo/easysetup/modest-easysetup-wizard.c:
1230 (modest_easysetup_wizard_dialog_finalize),
1231 (on_button_edit_advanced_settings), (create_page_complete_custom),
1232 (on_response), (create_account):
1233 Implement the Advanced Settings edit button, by saving the account information,
1234 for the Advanded Settings dialog to use directly from gconf, and removing it
1235 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1236 Bug #5533 in the projects.maemo.org bugzilla.
1238 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/modest-msg-view-window.c:
1241 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1242 when opening a message window.
1244 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1246 * src/maemo/easysetup/modest-easysetup-wizard.c:
1247 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1250 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1251 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1252 gconf settings. I probably added more checks than necessary, but that is safer.
1254 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1255 variable to fix the build, but this seems to be used when it is still NULL.
1257 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1259 * src/modest-platform.h:
1260 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1261 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1262 * src/modest-main.c: Implement this function so we can avoid using
1263 maemo-specific API from cross-platform code.
1265 * src/modest-tny-account-store.c:
1266 (get_smtp_specific_transport_account_for_open_connection):
1267 * src/modest-ui-actions.c: (check_for_connection),
1268 (modest_ui_actions_on_item_not_found):
1269 Use modest_platform_connect_and_wait() and put #idefs around other
1270 maemo-specific code, because only maemo currently has a way to
1271 identify connection names.
1273 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1275 * src/modest-tny-account-store.h:
1276 * src/modest-tny-account-store.c:
1277 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1278 the connection-specific SMTP server settings in the configuration.
1280 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1282 * src/maemo/modest-main-window.c: (on_connection_changed),
1284 * src/modest-main.c: (main), (start_ui), (send_mail):
1285 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1286 that is what is intended.
1288 * src/modest-ui-actions.c: (action_send), (action_receive),
1289 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1290 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1291 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1292 SMTP server is used when it is specified.
1294 (modest_ui_actions_on_send_receive):
1295 Check that a connection is open before proceeding.
1296 Receive and then send, instead of vice-versa, as per the specification.
1298 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-mail-operation.c:
1301 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1302 though I guess it should be something other than NULL.
1304 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/easysetup/modest-easysetup-wizard.c:
1307 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1308 combo twice, to avoid an g_warning and to make it visible again.
1309 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1310 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1311 (already intended) dereference when detaching, because we then recreate the menu.
1312 But I am not sure why the warning was happening, and it is possible that this is a memory
1315 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1317 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1318 and uri_parse_mailto() utility functions.
1319 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1321 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1323 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1325 * src/dbus_api/modest-dbus-api.h:
1326 * src/dbus_api/modest-dbus-callbacks.c:
1327 Use an idle callback to execute the modest code in the application's own thread.
1328 Remove the helloworld example method.
1329 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1330 parsed, and the open-message method is not implemented because this is not yet implemented in
1332 * libmodest-dbus-client/libmodest-dbus-client.c:
1333 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1334 (libmodest_dbus_client_open_message):
1335 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1337 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1338 body without crashing.
1340 * tests/dbus_api/Makefile.am:
1341 * tests/dbus_api/test_mail_to.c:
1342 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1344 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1346 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1347 Added file to fix the build. Sorry.
1349 * src/dbus_api/Makefile.am:
1350 * src/dbus_api/modest-dbus-api.h:
1351 * src/dbus_api/modest-dbus-callbacks.h:
1352 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1353 (modest_dbus_req_handler):
1354 Put constants in a separate header so it can be reused by the
1355 client library, without duplication
1357 * libmodest-dbus-client/Makefile.am:
1358 * libmodest-dbus-client/libmodest-dbus-client.c:
1359 (libmodest_dbus_client_call_helloworld),
1360 (libmodfest_dbus_client_send_mail),
1361 (libmodfest_dbus_client_mailto),
1362 (libmodfest_dbus_client_open_message):
1363 * libmodest-dbus-client/libmodest-dbus-client.h:
1364 (Partly) Implement a send_mail D-Bus method.
1366 * tests/dbus_api/Makefile.am:
1367 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1368 the send_email D-Bus method.
1370 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1374 * libmodest-dbus-client/Makefile.am:
1375 * libmodest-dbus-client/libmodest-dbus-client.c:
1376 * libmodest-dbus-client/libmodest-dbus-client.h:
1377 * tests/dbus_api/Makefile.am:
1378 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1379 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1381 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/easysetup/modest-easysetup-wizard.c:
1384 (create_page_account_details):
1385 * src/maemo/modest-account-settings-dialog.c:
1386 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1387 widgets, because this might not be the default in future versions of the Maemo GTK+.
1388 However, I can not not get capitalization to work even in a simple test case.
1390 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1392 * src/maemo/easysetup/modest-easysetup-wizard.c:
1393 (create_page_custom_incoming), (create_page_custom_outgoing):
1394 * src/maemo/modest-account-settings-dialog.c:
1395 (create_page_account_details), (create_page_incoming),
1396 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1397 instead of using gtk_check_button_with_label(), so they are aligned like the other
1398 widgets, as per the UI spec.
1400 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1402 * src/maemo/easysetup/modest-easysetup-wizard.c:
1403 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1404 * src/widgets/modest-validating-entry.c:
1405 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1406 Modest prefix instead of an EasySetup prefix.
1408 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1410 * src/widgets/modest-validating-entry.h:
1411 * src/widgets/modest-validating-entry.c: (on_insert_text),
1412 Added easysetup_validating_entry_set_max_func(), used to set a callback
1413 to call when the max number of characters is reached. GtkEntry has a max-length
1414 already but is silent about it.
1416 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1417 (create_page_account_details), (create_page_user_details),
1419 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1420 (create_page_account_details), (create_page_user_details),
1421 (create_page_outgoing):
1422 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1423 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1424 the UI spec, when the user tries to enter more than the max number of characters.
1426 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/easysetup/modest-easysetup-wizard.c:
1429 (create_page_user_details), (create_page_custom_incoming),
1430 (create_page_custom_outgoing):
1431 * src/maemo/modest-account-settings-dialog.c:
1432 (create_page_user_details), (create_page_incoming),
1433 (create_page_outgoing):
1434 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1435 (modest_connection_specific_smtp_edit_window_init):
1436 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1437 not appropriate. Bad Maemo-specific defaults!.
1439 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1441 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1442 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1443 (modest_signature_editor_dialog_set_settings):
1444 Disable the label and textview when the checkbox is disabled, and use the
1445 specified (UI spec) default signature text.
1447 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1450 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1452 * src/modest-defs.h:
1453 * src/modest-account-mgr-helpers.h:
1454 * src/modest-account-mgr-helpers.c:
1455 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1457 * src/maemo/Makefile.am:
1458 * src/maemo/modest-signature-editor-dialog.c:
1459 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1462 * src/maemo/modest-account-settings-dialog.h:
1463 * src/maemo/modest-account-settings-dialog.c:
1464 (modest_account_settings_dialog_finalize), (on_button_signature),
1465 (save_configuration): Use the new dialog when the Edit button is pressed, and
1466 save the changes if necessary, as per the UI spec.
1468 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/Makefile.am:
1471 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1472 based on maemo-develoers email from Dirk.
1474 * src/maemo/easysetup/modest-easysetup-wizard.c:
1475 (create_page_welcome), (create_page_account_details),
1476 (create_page_user_details), (create_page_complete_easysetup),
1477 (create_page_custom_incoming), (create_page_custom_outgoing),
1478 (create_page_complete_custom),
1479 (modest_easysetup_wizard_dialog_init):
1480 * src/maemo/modest-account-settings-dialog.c:
1481 (create_page_account_details), (create_page_user_details),
1482 (create_page_incoming), (create_page_outgoing),
1483 (modest_account_settings_dialog_init):
1484 * src/maemo/modest-connection-specific-smtp-window.c:
1485 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1487 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/easysetup/modest-easysetup-wizard.c:
1490 (create_page_account_details), (create_page_custom_outgoing),
1491 (create_page_complete_custom):
1492 * src/maemo/modest-account-settings-dialog.c:
1493 (create_page_user_details), (create_page_incoming),
1494 (create_page_outgoing):
1495 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1496 (modest_connection_specific_smtp_edit_window_init):
1497 Use the correct (UI spec) port min/max, and use horizontal separators,
1500 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1502 * src/maemo/easysetup/modest-easysetup-wizard.c:
1503 (set_default_custom_servernames):
1504 * src/maemo/modest-account-settings-dialog.c:
1505 (create_page_incoming), (on_combo_outgoing_security_changed),
1506 (on_combo_incoming_security_changed), (create_page_outgoing),
1507 (modest_account_settings_dialog_set_account_name),
1508 (save_configuration):
1509 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1510 (on_combo_security_changed),
1511 (modest_connection_specific_smtp_edit_window_init),
1512 (modest_connection_specific_smtp_edit_window_set_connection),
1513 (modest_connection_specific_smtp_edit_window_get_settings):
1514 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1517 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/easysetup/modest-easysetup-wizard.c:
1521 (create_page_custom_outgoing), (create_page_complete_custom):
1522 * src/maemo/modest-account-settings-dialog.c:
1523 (create_page_user_details), (create_page_outgoing):
1524 * src/maemo/modest-account-view-window.c: (button_box_new):
1525 Use changed logical IDs as per the most recent UI spec:
1526 mcen_bd_emailsetup_edit -> mcen_bd_edit
1527 mcen_bd_emailsetup_delete -> mcen_bd_delete
1528 mcen_bd_emailsetup_close -> mcen_bd_close
1530 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1534 * src/dbus_api/Makefile.am:
1535 * src/dbus_api/modest-dbus-callbacks.c:
1536 * src/dbus_api/modest-dbus-callbacks.h:
1537 * src/maemo/modest-platform.c: (modest_platform_init):
1538 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1540 * tests/Makefile.am:
1541 * tests/dbus_api/Makefile.am:
1542 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1544 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/modest-account-settings-dialog.c:
1547 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1548 Removed unnecessary includes.
1550 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/easysetup/modest-easysetup-wizard.c:
1553 * src/maemo/modest-account-settings-dialog.c:
1554 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1555 * src/widgets/Makefile.am:
1556 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1557 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1558 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1559 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1560 * src/widgets/modest-secureauth-combo-box.c:
1561 * src/widgets/modest-secureauth-combo-box.h:
1562 * src/widgets/modest-serversecurity-combo-box.c:
1563 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1564 made the GObject names more consistent with the rest of the Modest code.
1566 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/easysetup/Makefile.am:
1569 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1570 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1571 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1572 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1573 * src/maemo/easysetup/modest-easysetup-wizard.c:
1574 * src/maemo/easysetup/modest-validating-entry.c:
1575 * src/maemo/easysetup/modest-validating-entry.h:
1576 * src/maemo/modest-account-settings-dialog.c:
1577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1578 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1579 widgets/ because they are used outside of easysetup too. After checking in,
1580 svn will allow me to rename them too.
1582 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1584 * src/gnome/modest-msg-edit-window.c:
1585 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1586 linker error, to fix the build on the GNOME platform.
1587 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1588 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1589 ifdefed out to avoid a warning.
1591 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1593 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1594 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1595 some alternative for GTK+ 2.6.
1597 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1601 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1602 specified for EmailAccountsDialog in UI spec.
1604 * src/maemo/easysetup/modest-easysetup-wizard.c:
1605 * src/maemo/easysetup/modest-easysetup-wizard.h:
1606 * src/maemo/modest-account-settings-dialog.c:
1607 * src/maemo/modest-account-settings-dialog.h:
1608 Reuse a member window widget for the connection-specific SMTP server accounts,
1609 so we can tell it to create/save the accounts only if we actually save changes.
1611 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1613 (modest_connection_specific_smtp_edit_window_get_settings):
1614 Return a struct instance for temporarily remembering the entered data.
1616 * src/maemo/modest-connection-specific-smtp-window.h:
1617 * src/maemo/modest-connection-specific-smtp-window.c:
1618 (modest_connection_specific_smtp_window_finalize),
1619 (modest_connection_specific_smtp_window_fill_with_connections),
1621 (modest_connection_specific_smtp_window_save_server_accounts),
1622 (update_model_server_names): Do not actually save data until asked,
1623 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1625 (on_selection_changed),
1626 (modest_connection_specific_smtp_window_init): Disable the edit
1627 button when nothing is selected.
1629 * src/modest-account-mgr-helpers.c:
1630 * src/modest-account-mgr-helpers.h:
1631 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1634 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1636 * src/modest-account-mgr-helpers.h:
1637 * src/modest-account-mgr-helpers.c:
1638 (modest_account_mgr_get_unused_account_name),
1639 (modest_account_mgr_get_unused_account_display_name): Added these
1640 utility functions, to avoid code duplication.
1642 * src/maemo/easysetup/modest-easysetup-wizard.c:
1643 (create_page_account_details), (create_account):
1644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1645 (on_combo_security_changed),
1646 (modest_connection_specific_smtp_edit_window_init),
1647 (modest_connection_specific_smtp_edit_window_save_settings):
1648 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1649 * src/maemo/modest-connection-specific-smtp-window.c:
1650 (modest_connection_specific_smtp_window_finalize),
1651 (modest_connection_specific_smtp_window_fill_with_connections),
1652 (on_button_edit), (modest_connection_specific_smtp_window_init):
1653 * src/maemo/modest-connection-specific-smtp-window.h:
1654 Implementing saving of connection-specific server accounts.
1656 But I need to refactor this so we can save the data for each
1657 possible connection-specific account and only actually create the server accounts
1658 when the easysetup finished, or the OK button is pressed on the account settings
1661 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1663 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1664 (on_combo_security_changed):
1665 (modest_connection_specific_smtp_edit_window_init):
1666 Auto-fill the port number as in the account settings.
1668 (modest_connection_specific_smtp_edit_window_set_connection):
1669 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1670 * src/maemo/modest-connection-specific-smtp-window.c:
1671 (fill_with_connections), (on_button_edit),
1672 (modest_connection_specific_smtp_window_init):
1673 Turn the edit window into a dialog to simplify the code, and
1674 set a WM hint as in a GtkDialog, because only a popup can be on top of
1675 another window in Maemo, and popups usually have no WM decoration.
1677 * src/modest-defs.h:
1678 * src/modest-account-mgr-helpers.c:
1679 (modest_account_mgr_set_connection_specific_smtp),
1680 (modest_account_mgr_remove_connection_specific_smtp),
1681 (modest_account_mgr_get_connection_specific_smtp):
1682 * src/modest-account-mgr-helpers.h: Some functions to write the
1683 connection-specific SMTP server information. Not yet used.
1686 * src/widgets/modest-folder-view.c: (text_cell_data):
1687 Fix a warning about an uninitialized variable.
1688 (on_configuration_key_changed): Put an #ifdef around the use
1689 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1691 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1693 * src/maemo/modest-account-settings-dialog.h:
1694 * src/maemo/modest-account-settings-dialog.c:
1695 Added connect_for_modified() utility function to mark the new modified boolean.
1697 (create_page_account_details), (create_page_user_details),
1698 (create_page_incoming), (create_page_outgoing), (on_response),
1699 (modest_account_settings_dialog_init),
1700 (modest_account_settings_dialog_set_account_name):
1701 Only warn about unsaved changes when there are actually unsaved changes.
1703 * src/modest-account-mgr-helpers.c:
1704 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1705 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1706 to get the data from there in future.
1708 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1710 * src/modest-defs.h:
1712 * src/modest-account-mgr-helpers.h:
1713 * src/modest-account-mgr-helpers.c:
1714 Store the security account setting in a single conf key instead of using
1715 the options list, so that the list is left for just the to-be-removed camel hack,
1716 and because gconf_client_set_list() is failing for some reason.
1718 * src/modest-account-mgr.c:
1719 (modest_account_mgr_add_server_account):
1720 * src/maemo/modest-account-settings-dialog.c:
1721 (modest_account_settings_dialog_set_account_name),
1722 (save_configuration): Use the renamed functions.
1725 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1727 * src/widgets/Makefile.am:
1728 * src/widgets/modest-limit-retrieve-combo-box.c:
1729 * src/widgets/modest-limit-retrieve-combo-box.h:
1730 * src/widgets/modest-retrieve-combo-box.c:
1731 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1732 the account settings dialog.
1734 * src/modest-defs.h:
1735 * src/modest-account-mgr-helpers.h:
1736 * src/modest-account-mgr-helpers.c:
1737 (modest_server_account_get_option_secure_auth),
1738 (modest_server_account_set_option_secure_auth):
1739 * src/modest-account-mgr.c:
1740 (modest_account_mgr_add_server_account):
1741 Use the existing AUTH_MECH conf key for the secure-auth setting,
1742 instead of putting it in the list options, because this was actually used already.
1744 * src/maemo/modest-account-settings-dialog.c:
1745 (create_page_account_details),
1746 (modest_account_settings_dialog_set_account_name),
1747 (save_configuration):
1748 * src/maemo/modest-account-settings-dialog.h:
1749 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1750 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1752 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1754 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1755 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1756 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1758 * src/modest-defs.h:
1759 * src/maemo/modest-account-settings-dialog.c:
1760 (create_page_incoming), (on_combo_outgoing_security_changed),
1761 (on_combo_incoming_security_changed), (create_page_outgoing),
1762 (modest_account_settings_dialog_set_account_name),
1763 (save_configuration): Load/Save the port number, and change it when the
1764 security combo changes, to suitable defaults.
1766 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-account-mgr.c:
1769 (modest_account_mgr_add_server_account): Set the security and secure-auth
1770 options, and add a comment saying that the other camel-specific options should be
1773 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1777 * src/modest-tny-account-store.c: (account_list_free),
1778 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1779 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1782 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-protocol-info.c:
1785 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1786 is required by our UI spec. Maybe something in our implementation will use this eventually.
1787 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1788 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1789 instead of the previous 0 placeholder.
1791 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1792 secure-auth settings.
1793 * src/modest-account-mgr-helpers.h:
1794 * src/modest-account-mgr-helpers.c:
1795 (modest_server_account_data_get_option_secure_auth),
1796 (modest_server_account_set_option_secure_auth),
1797 (modest_server_account_data_get_option_security),
1798 (modest_server_account_set_option_security): Added this API for getting and setting the security
1799 and secure-auth settings.
1801 * src/maemo/modest-account-settings-dialog.h:
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (modest_account_settings_dialog_finalize), (check_data),
1804 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1805 about changing titles.
1806 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1807 (save_configuration): Save the security and secure-auth settings.
1809 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1810 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1812 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-defs.h:
1815 * src/modest-account-mgr.c:
1816 (modest_account_mgr_add_server_account):
1817 Added and used defines for the options key and value pair strings,
1818 that are used so far, though they do not seem to correspond to anything in our
1819 UI specs or ModestProtocol enum.
1821 * src/modest-account-mgr-helpers.h:
1822 * src/modest-account-mgr-helpers.c:
1823 (compare_option_strings_for_name),
1824 (modest_server_account_data_get_option_value),
1825 (modest_server_account_data_get_option_bool),
1826 (modest_account_mgr_get_server_account_option):
1827 Added helper functions for parsing the options GSList.
1829 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1831 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1832 display name is based on the supplied account name.
1833 * src/modest-account-mgr.c:
1834 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1835 with an inefficient, but good-enough, implementation.
1837 * src/maemo/easysetup/modest-easysetup-wizard.c:
1838 (create_page_account_details), (on_before_next), (create_account):
1839 Check for existing display names rather than (non-user-visible) account names, and just
1840 create and set a unique account name at the end.
1842 * src/maemo/modest-account-settings-dialog.c:
1843 (modest_account_settings_dialog_init),
1844 (modest_account_settings_dialog_set_account_name),
1845 (create_page_incoming): Show the display name, instead of the account name.
1846 (on_response): Do some (not all) extra checks, as in the UI spec.
1847 (save_configuration): Save the display name if it was changed.
1849 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1851 * po/en_GB.po: Added needed logical ID and translation.
1852 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1853 (init_view): Made the is-default column clicking work.
1855 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/easysetup/Makefile.am:
1859 * src/maemo/easysetup/modest-easysetup-wizard.c:
1860 (modest_easysetup_wizard_dialog_init):
1861 * src/maemo/easysetup/provider-data-test.keyfile:
1862 * src/maemo/easysetup/provider-data.keyfile:
1863 Moved the provider data file to the new modest-providers-data package and used it from there.
1865 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-local-folder-info.c:
1868 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1869 N_() was already used on the static strings, but this just marks it for translation without
1870 using the translation.
1872 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/modest-account-settings-dialog.c:
1875 (create_page_incoming),
1876 (modest_account_settings_dialog_set_account_name):
1877 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1878 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1879 I will do this if nobody else gets there first.
1881 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1884 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1885 save the security stuff.
1887 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1889 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1890 Set the email address and user fullname, which I now see must be
1893 * src/maemo/modest-account-settings-dialog.h:
1894 * src/maemo/modest-account-settings-dialog.c:
1896 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1897 leave-on-server and authentication.
1898 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1901 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/modest-account-settings-dialog.c:
1905 * src/maemo/modest-account-settings-dialog.h:
1906 Most (but not all) of the widgets are now present as specified by the UI spec.
1907 No changes are yet saved, and some details are not properly shown yet.
1909 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1911 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/Makefile.am:
1914 * src/maemo/modest-account-settings-dialog.c:
1915 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1916 an existing account. Doesn't do much yet.
1918 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1919 Open the accounts settings dialog when Edit is clicked.
1921 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/easysetup/Makefile.am:
1924 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1926 * src/maemo/easysetup/modest-easysetup-wizard.c:
1927 (modest_easysetup_wizard_dialog_init):
1928 Try to get the source directory from the build system,
1929 instead of hard-coding "./" into the source code, when opening our local
1930 copies of the configuration files.
1931 But this still fails when opening the wizard from the Accounts window,
1932 maybe because the working directory seems to change at runtime.
1933 So the wizard will fail the second time unless you copy the files into their
1934 proper locations - see the stdout warnings for the paths.
1936 (create_page_account_details),(on_before_next):
1937 Check for existing non-server accounts instead of server accounts,
1938 so the default account name is useful again, and to prevent trying to
1941 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1942 Show the wizard when New is clicked.
1944 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1945 (init_view): Show the column headers, and show the columns that are
1946 specified in the UI specs. However, something in Maemo's GTK+ prevents
1947 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1948 change the default account. This is despite unsetting the special properties.
1950 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1952 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1953 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1954 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1955 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1956 to make that clearer.
1957 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1959 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-account-view-window.c:
1962 (modest_account_view_window_init),
1963 (modest_account_view_window_new):
1964 Use the same buttons as specified in the
1965 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1966 the existing widgets, which never had a chance of working.
1967 Put the ModestAccountView treeview in a scrolled window.
1968 Do not repeat the initialization in both _init() and _new().
1970 * src/widgets/modest-account-view.c: (update_account_view):
1971 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1972 this widget and window shows no accounts.
1974 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1976 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/easysetup/modest-easysetup-wizard.c:
1979 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1980 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1981 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1984 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1985 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1986 accounts exist yet, as in the UI spec.
1988 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1990 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/Makefile.am:
1993 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1994 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1995 New window for editing connection-specific smtp details.
1996 Not fully implemented.
1998 * src/maemo/modest-connection-specific-smtp-window.c:
1999 (modest_connection_specific_smtp_window_finalize) :
2000 unref the tree model.
2001 (on_button_edit): Show the edit window.
2003 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2005 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2008 * src/maemo/Makefile.am:
2009 * src/maemo/modest-connection-specific-smtp-window.c:
2010 * src/maemo/modest-connection-specific-smtp-window.h:
2011 New window for showing the list of connections, for connection-specific
2012 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2013 * src/maemo/easysetup/modest-easysetup-wizard.c:
2014 (create_page_custom_outgoing): Show the new window when the button is clicked.
2016 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2019 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2020 * src/maemo/modest-msg-edit-window.c:
2021 (modest_msg_edit_window_insert_image):
2022 * src/modest-conf.c: (modest_conf_key_escape):
2023 * src/modest-mail-operation.c:
2024 (modest_mail_operation_send_new_mail):
2025 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2026 (modest_ui_actions_on_new_account):
2027 * src/widgets/modest-attachment-view.c: (update_filename_request):
2028 * src/widgets/modest-mail-header-view.c:
2029 Corrected warnings that were breaking the build, by commenting out unused variables,
2030 and a function, and by including a header.
2032 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2034 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2035 so we can #ifdef around platform-specific code when necessary.
2036 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2037 to allow this to build for the GNOME platform too.
2039 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-easysetup-wizard.c:
2042 Added util_increment_name() and used it in create_page_account_details()
2043 to make sure that the default account name is always a new name.
2045 (modest_easysetup_wizard_dialog_init),
2046 (set_default_custom_servernames): Some minor memory management fixes.
2048 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2052 * src/modest-runtime.c: (init_i18n): Restored the translation
2053 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2054 are defined in config.h, and the translations are installed.
2056 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2057 is defined for translation.
2059 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2063 * src/maemo/easysetup/modest-easysetup-wizard.c:
2064 (modest_easysetup_wizard_dialog_init):
2065 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2066 Use realistic paths (though they should use $prefix generically) to the
2067 mcc_mapping and provider-data.keyfile files which might work when they
2068 are installed by the future version of the operator-wizard package,
2069 and then fallback to paths in our source code, with an explanatory
2072 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/Makefile.am:
2077 * src/maemo/easysetup/: Added files from the previously-exernal
2078 osso-modest-easysetup.
2079 * src/maemo/modest-main-window-ui.h:
2080 * src/modest-ui-actions.c:
2081 * src/modest-ui-actions.h:
2082 Added modest_ui_actions_on_new_account() as a signal handler for the
2083 New Account menu item. It shows the easysetup wizard.
2084 * po/en_GB.po: Added additional needed logical IDs and translations.
2086 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2087 Apparently ChangeLog is not used for some vague Nokia legal reasons.