git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-mail-operation.c:
   4         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
   5         though I guess it should be something other than NULL.
   6
   7 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
   8
   9         * src/maemo/easysetup/modest-easysetup-wizard.c:
  10         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
  11         combo twice, to avoid an g_warning and to make it visible again.
  12         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
  13         attached before detaching it, to avoid a g_warning, and add comment about the implicit
  14         (already intended) dereference when detaching, because we then recreate the menu.
  15         But I am not sure why the warning was happening, and it is possible that this is a memory
  16         leak.
  17
  18 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
  19
  20         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
  21         and uri_parse_mailto() utility functions.
  22         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
  23         the mailto URI.
  24         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
  25
  26 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  27
  28         * src/dbus_api/modest-dbus-api.h:
  29         * src/dbus_api/modest-dbus-callbacks.c:
  30         Use an idle callback to execute the modest code in the application's own thread.
  31         Remove the helloworld example method.
  32         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
  33         parsed, and the open-message method is not implemented because this is not yet implemented in
  34         modest itself.
  35         * libmodest-dbus-client/libmodest-dbus-client.c:
  36         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
  37         (libmodest_dbus_client_open_message):
  38         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
  39
  40         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
  41         body without crashing.
  42
  43         * tests/dbus_api/Makefile.am:
  44         * tests/dbus_api/test_mail_to.c:
  45         * tests/dbus_api/test_open_message.c: New tests for the new methods.
  46
  47 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  48
  49         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
  50         Added file to fix the build. Sorry.
  51
  52         * src/dbus_api/Makefile.am:
  53         * src/dbus_api/modest-dbus-api.h:
  54         * src/dbus_api/modest-dbus-callbacks.h:
  55         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
  56         (modest_dbus_req_handler):
  57         Put constants in a separate header so it can be reused by the
  58         client library, without duplication
  59
  60         * libmodest-dbus-client/Makefile.am:
  61         * libmodest-dbus-client/libmodest-dbus-client.c:
  62         (libmodest_dbus_client_call_helloworld),
  63         (libmodfest_dbus_client_send_mail),
  64         (libmodfest_dbus_client_mailto),
  65         (libmodfest_dbus_client_open_message):
  66         * libmodest-dbus-client/libmodest-dbus-client.h:
  67         (Partly) Implement a send_mail D-Bus method.
  68
  69         * tests/dbus_api/Makefile.am:
  70         * tests/dbus_api/test_send_mail.c: (main): Added a test for
  71         the send_email D-Bus method.
  72
  73 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  74
  75         * Makefile.am:
  76         * configure.ac:
  77         * libmodest-dbus-client/Makefile.am:
  78         * libmodest-dbus-client/libmodest-dbus-client.c:
  79         * libmodest-dbus-client/libmodest-dbus-client.h:
  80         * tests/dbus_api/Makefile.am:
  81         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
  82         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
  83
  84 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  85
  86         * src/maemo/easysetup/modest-easysetup-wizard.c:
  87         (create_page_account_details):
  88         * src/maemo/modest-account-settings-dialog.c:
  89         (create_page_account_details): Explicitly set auto-capitalization mode for the title
  90         widgets, because this might not be the default in future versions of the Maemo GTK+.
  91         However, I can not not get capitalization to work even in a simple test case.
  92
  93 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  94
  95         * src/maemo/easysetup/modest-easysetup-wizard.c:
  96         (create_page_custom_incoming), (create_page_custom_outgoing):
  97         * src/maemo/modest-account-settings-dialog.c:
  98         (create_page_account_details), (create_page_incoming),
  99         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 100         instead of using gtk_check_button_with_label(), so they are aligned like the other
 101         widgets, as per the UI spec.
 102
 103 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 104
 105         * src/maemo/easysetup/modest-easysetup-wizard.c:
 106         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 107         * src/widgets/modest-validating-entry.c:
 108         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 109         Modest prefix instead of an EasySetup prefix.
 110
 111 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 112
 113         * src/widgets/modest-validating-entry.h:
 114         * src/widgets/modest-validating-entry.c: (on_insert_text),
 115         Added easysetup_validating_entry_set_max_func(), used to set a callback
 116         to call when the max number of characters is reached. GtkEntry has a max-length
 117         already but is silent about it.
 118
 119         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 120         (create_page_account_details), (create_page_user_details),
 121         (create_account):
 122         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 123         (create_page_account_details), (create_page_user_details),
 124         (create_page_outgoing):
 125         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 126         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 127         the UI spec, when the user tries to enter more than the max number of characters.
 128
 129 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 130
 131         * src/maemo/easysetup/modest-easysetup-wizard.c:
 132         (create_page_user_details), (create_page_custom_incoming),
 133         (create_page_custom_outgoing):
 134         * src/maemo/modest-account-settings-dialog.c:
 135         (create_page_user_details), (create_page_incoming),
 136         (create_page_outgoing):
 137         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 138         (modest_connection_specific_smtp_edit_window_init):
 139         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 140         not appropriate. Bad Maemo-specific defaults!.
 141
 142 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 143
 144         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 145         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 146         (modest_signature_editor_dialog_set_settings):
 147         Disable the label and textview when the checkbox is disabled, and use the
 148         specified (UI spec) default signature text.
 149
 150 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 151
 152         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 153         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 154
 155         * src/modest-defs.h:
 156         * src/modest-account-mgr-helpers.h:
 157         * src/modest-account-mgr-helpers.c:
 158         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 159
 160         * src/maemo/Makefile.am:
 161         * src/maemo/modest-signature-editor-dialog.c:
 162         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 163         as per the UI spec.
 164
 165         * src/maemo/modest-account-settings-dialog.h:
 166         * src/maemo/modest-account-settings-dialog.c:
 167         (modest_account_settings_dialog_finalize), (on_button_signature),
 168         (save_configuration): Use the new dialog when the Edit button is pressed, and
 169         save the changes if necessary, as per the UI spec.
 170
 171 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 172
 173         * src/maemo/Makefile.am:
 174         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 175         based on maemo-develoers email from Dirk.
 176
 177         * src/maemo/easysetup/modest-easysetup-wizard.c:
 178         (create_page_welcome), (create_page_account_details),
 179         (create_page_user_details), (create_page_complete_easysetup),
 180         (create_page_custom_incoming), (create_page_custom_outgoing),
 181         (create_page_complete_custom),
 182         (modest_easysetup_wizard_dialog_init):
 183         * src/maemo/modest-account-settings-dialog.c:
 184         (create_page_account_details), (create_page_user_details),
 185         (create_page_incoming), (create_page_outgoing),
 186         (modest_account_settings_dialog_init):
 187         * src/maemo/modest-connection-specific-smtp-window.c:
 188         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 189
 190 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 191
 192         * src/maemo/easysetup/modest-easysetup-wizard.c:
 193         (create_page_account_details), (create_page_custom_outgoing),
 194         (create_page_complete_custom):
 195         * src/maemo/modest-account-settings-dialog.c:
 196         (create_page_user_details), (create_page_incoming),
 197         (create_page_outgoing):
 198         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 199         (modest_connection_specific_smtp_edit_window_init):
 200         Use the correct (UI spec) port min/max, and use horizontal separators,
 201         as per the UI spec.
 202
 203 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 204
 205         * src/maemo/easysetup/modest-easysetup-wizard.c:
 206         (set_default_custom_servernames):
 207         * src/maemo/modest-account-settings-dialog.c:
 208         (create_page_incoming), (on_combo_outgoing_security_changed),
 209         (on_combo_incoming_security_changed), (create_page_outgoing),
 210         (modest_account_settings_dialog_set_account_name),
 211         (save_configuration):
 212         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 213         (on_combo_security_changed),
 214         (modest_connection_specific_smtp_edit_window_init),
 215         (modest_connection_specific_smtp_edit_window_set_connection),
 216         (modest_connection_specific_smtp_edit_window_get_settings):
 217         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 218         as per the UI spec.
 219
 220 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 221
 222         * po/en_GB.po:
 223         * src/maemo/easysetup/modest-easysetup-wizard.c:
 224         (create_page_custom_outgoing), (create_page_complete_custom):
 225         * src/maemo/modest-account-settings-dialog.c:
 226         (create_page_user_details), (create_page_outgoing):
 227         * src/maemo/modest-account-view-window.c: (button_box_new):
 228         Use changed logical IDs as per the most recent UI spec:
 229         mcen_bd_emailsetup_edit -> mcen_bd_edit
 230         mcen_bd_emailsetup_delete -> mcen_bd_delete
 231         mcen_bd_emailsetup_close -> mcen_bd_close
 232
 233 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 234
 235         * configure.ac:
 236         * src/Makefile.am:
 237         * src/dbus_api/Makefile.am:
 238         * src/dbus_api/modest-dbus-callbacks.c:
 239         * src/dbus_api/modest-dbus-callbacks.h:
 240         * src/maemo/modest-platform.c: (modest_platform_init):
 241         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 242         method.
 243         * tests/Makefile.am:
 244         * tests/dbus_api/Makefile.am:
 245         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 246
 247 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 248
 249         * src/maemo/modest-account-settings-dialog.c:
 250         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 251         Removed unnecessary includes.
 252
 253 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 254
 255         * src/maemo/easysetup/modest-easysetup-wizard.c:
 256         * src/maemo/modest-account-settings-dialog.c:
 257         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 258         * src/widgets/Makefile.am:
 259         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 260         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 261         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 262         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 263         * src/widgets/modest-secureauth-combo-box.c:
 264         * src/widgets/modest-secureauth-combo-box.h:
 265         * src/widgets/modest-serversecurity-combo-box.c:
 266         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 267         made the GObject names more consistent with the rest of the Modest code.
 268
 269 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/maemo/easysetup/Makefile.am:
 272         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 273         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 274         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 275         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 276         * src/maemo/easysetup/modest-easysetup-wizard.c:
 277         * src/maemo/easysetup/modest-validating-entry.c:
 278         * src/maemo/easysetup/modest-validating-entry.h:
 279         * src/maemo/modest-account-settings-dialog.c:
 280         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 281         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 282         widgets/ because they are used outside of easysetup too. After checking in,
 283         svn will allow me to rename them too.
 284
 285 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 286
 287         * src/gnome/modest-msg-edit-window.c:
 288         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 289         linker error, to fix the build on the GNOME platform.
 290         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 291         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 292         ifdefed out to avoid a warning.
 293
 294 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 295
 296         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 297         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 298         some alternative for GTK+ 2.6.
 299
 300 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 301
 302         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 303
 304         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 305         specified for EmailAccountsDialog in UI spec.
 306
 307         * src/maemo/easysetup/modest-easysetup-wizard.c:
 308         * src/maemo/easysetup/modest-easysetup-wizard.h:
 309         * src/maemo/modest-account-settings-dialog.c:
 310         * src/maemo/modest-account-settings-dialog.h:
 311         Reuse a member window widget for the connection-specific SMTP server accounts,
 312         so we can tell it to create/save the accounts only if we actually save changes.
 313
 314         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 315         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 316         (modest_connection_specific_smtp_edit_window_get_settings):
 317         Return a struct instance for temporarily remembering the entered data.
 318
 319         * src/maemo/modest-connection-specific-smtp-window.h:
 320         * src/maemo/modest-connection-specific-smtp-window.c:
 321         (modest_connection_specific_smtp_window_finalize),
 322         (modest_connection_specific_smtp_window_fill_with_connections),
 323         (on_button_edit),
 324         (modest_connection_specific_smtp_window_save_server_accounts),
 325         (update_model_server_names): Do not actually save data until asked,
 326         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 327
 328         (on_selection_changed),
 329         (modest_connection_specific_smtp_window_init): Disable the edit
 330         button when nothing is selected.
 331
 332         * src/modest-account-mgr-helpers.c:
 333         * src/modest-account-mgr-helpers.h:
 334         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 335         elsewhere.
 336
 337 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 338
 339         * src/modest-account-mgr-helpers.h:
 340         * src/modest-account-mgr-helpers.c:
 341         (modest_account_mgr_get_unused_account_name),
 342         (modest_account_mgr_get_unused_account_display_name): Added these
 343         utility functions, to avoid code duplication.
 344
 345         * src/maemo/easysetup/modest-easysetup-wizard.c:
 346         (create_page_account_details), (create_account):
 347         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 348         (on_combo_security_changed),
 349         (modest_connection_specific_smtp_edit_window_init),
 350         (modest_connection_specific_smtp_edit_window_save_settings):
 351         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 352         * src/maemo/modest-connection-specific-smtp-window.c:
 353         (modest_connection_specific_smtp_window_finalize),
 354         (modest_connection_specific_smtp_window_fill_with_connections),
 355         (on_button_edit), (modest_connection_specific_smtp_window_init):
 356         * src/maemo/modest-connection-specific-smtp-window.h:
 357         Implementing saving of connection-specific server accounts.
 358
 359         But I need to refactor this so we can save the data for each
 360         possible connection-specific account and only actually create the server accounts
 361         when the easysetup finished, or the OK button is pressed on the account settings
 362         dialog.
 363
 364 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 365
 366         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 367         (on_combo_security_changed):
 368         (modest_connection_specific_smtp_edit_window_init):
 369         Auto-fill the port number as in the account settings.
 370
 371         (modest_connection_specific_smtp_edit_window_set_connection):
 372         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 373         * src/maemo/modest-connection-specific-smtp-window.c:
 374         (fill_with_connections), (on_button_edit),
 375         (modest_connection_specific_smtp_window_init):
 376         Turn the edit window into a dialog to simplify the code, and
 377         set a WM hint as in a GtkDialog, because only a popup can be on top of
 378         another window in Maemo, and popups usually have no WM decoration.
 379
 380         * src/modest-defs.h:
 381         * src/modest-account-mgr-helpers.c:
 382         (modest_account_mgr_set_connection_specific_smtp),
 383         (modest_account_mgr_remove_connection_specific_smtp),
 384         (modest_account_mgr_get_connection_specific_smtp):
 385         * src/modest-account-mgr-helpers.h: Some functions to write the
 386         connection-specific SMTP server information. Not yet used.
 387
 388
 389         * src/widgets/modest-folder-view.c: (text_cell_data):
 390         Fix a warning about an uninitialized variable.
 391         (on_configuration_key_changed): Put an #ifdef around the use
 392         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 393
 394 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 395
 396         * src/maemo/modest-account-settings-dialog.h:
 397         * src/maemo/modest-account-settings-dialog.c:
 398         Added connect_for_modified() utility function to mark the new modified boolean.
 399
 400         (create_page_account_details), (create_page_user_details),
 401         (create_page_incoming), (create_page_outgoing), (on_response),
 402         (modest_account_settings_dialog_init),
 403         (modest_account_settings_dialog_set_account_name):
 404         Only warn about unsaved changes when there are actually unsaved changes.
 405
 406         * src/modest-account-mgr-helpers.c:
 407         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 408         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 409         to get the data from there in future.
 410
 411 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 412
 413         * src/modest-defs.h:
 414
 415         * src/modest-account-mgr-helpers.h:
 416         * src/modest-account-mgr-helpers.c:
 417         Store the security account setting in a single conf key instead of using
 418         the options list, so that the list is left for just the to-be-removed camel hack,
 419         and because gconf_client_set_list() is failing for some reason.
 420
 421         * src/modest-account-mgr.c:
 422         (modest_account_mgr_add_server_account):
 423         * src/maemo/modest-account-settings-dialog.c:
 424         (modest_account_settings_dialog_set_account_name),
 425         (save_configuration): Use the renamed functions.
 426
 427
 428 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 429
 430         * src/widgets/Makefile.am:
 431         * src/widgets/modest-limit-retrieve-combo-box.c:
 432         * src/widgets/modest-limit-retrieve-combo-box.h:
 433         * src/widgets/modest-retrieve-combo-box.c:
 434         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 435         the account settings dialog.
 436
 437         * src/modest-defs.h:
 438         * src/modest-account-mgr-helpers.h:
 439         * src/modest-account-mgr-helpers.c:
 440         (modest_server_account_get_option_secure_auth),
 441         (modest_server_account_set_option_secure_auth):
 442         * src/modest-account-mgr.c:
 443         (modest_account_mgr_add_server_account):
 444         Use the existing AUTH_MECH conf key for the secure-auth setting,
 445         instead of putting it in the list options, because this was actually used already.
 446
 447         * src/maemo/modest-account-settings-dialog.c:
 448         (create_page_account_details),
 449         (modest_account_settings_dialog_set_account_name),
 450         (save_configuration):
 451         * src/maemo/modest-account-settings-dialog.h:
 452         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 453         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 454
 455 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 456
 457         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 458         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 459         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 460
 461         * src/modest-defs.h:
 462         * src/maemo/modest-account-settings-dialog.c:
 463         (create_page_incoming), (on_combo_outgoing_security_changed),
 464         (on_combo_incoming_security_changed), (create_page_outgoing),
 465         (modest_account_settings_dialog_set_account_name),
 466         (save_configuration): Load/Save the port number, and change it when the
 467         security combo changes, to suitable defaults.
 468
 469 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 470
 471         * src/modest-account-mgr.c:
 472         (modest_account_mgr_add_server_account): Set the security and secure-auth
 473         options, and add a comment saying that the other camel-specific options should be
 474         removed in future.
 475
 476 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 477
 478         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 479         found by valgrind.
 480         * src/modest-tny-account-store.c: (account_list_free),
 481         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 482         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 483         easy to fix.
 484
 485 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 486
 487         * src/modest-protocol-info.c:
 488         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 489         is required by our UI spec. Maybe something in our implementation will use this eventually.
 490         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 491         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 492         instead of the previous 0 placeholder.
 493
 494         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 495         secure-auth settings.
 496         * src/modest-account-mgr-helpers.h:
 497         * src/modest-account-mgr-helpers.c:
 498         (modest_server_account_data_get_option_secure_auth),
 499         (modest_server_account_set_option_secure_auth),
 500         (modest_server_account_data_get_option_security),
 501         (modest_server_account_set_option_security): Added this API for getting and setting the security
 502         and secure-auth settings.
 503
 504         * src/maemo/modest-account-settings-dialog.h:
 505         * src/maemo/modest-account-settings-dialog.c:
 506         (modest_account_settings_dialog_finalize), (check_data),
 507         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 508         about changing titles.
 509         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 510         (save_configuration): Save the security and secure-auth settings.
 511
 512         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 513         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 514
 515 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 516
 517         * src/modest-defs.h:
 518         * src/modest-account-mgr.c:
 519         (modest_account_mgr_add_server_account):
 520         Added and used defines for the options key and value pair strings,
 521         that are used so far, though they do not seem to correspond to anything in our
 522         UI specs or ModestProtocol enum.
 523
 524         * src/modest-account-mgr-helpers.h:
 525         * src/modest-account-mgr-helpers.c:
 526         (compare_option_strings_for_name),
 527         (modest_server_account_data_get_option_value),
 528         (modest_server_account_data_get_option_bool),
 529         (modest_account_mgr_get_server_account_option):
 530         Added helper functions for parsing the options GSList.
 531
 532 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 533
 534         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 535         display name is based on the supplied account name.
 536         * src/modest-account-mgr.c:
 537         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 538         with an inefficient, but good-enough, implementation.
 539
 540         * src/maemo/easysetup/modest-easysetup-wizard.c:
 541         (create_page_account_details), (on_before_next), (create_account):
 542         Check for existing display names rather than (non-user-visible) account names, and just
 543         create and set a unique account name at the end.
 544
 545         * src/maemo/modest-account-settings-dialog.c:
 546         (modest_account_settings_dialog_init),
 547         (modest_account_settings_dialog_set_account_name),
 548         (create_page_incoming): Show the display name, instead of the account name.
 549         (on_response): Do some (not all) extra checks, as in the UI spec.
 550         (save_configuration): Save the display name if it was changed.
 551
 552 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 553
 554         * po/en_GB.po: Added needed logical ID and translation.
 555         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 556         (init_view): Made the is-default column clicking work.
 557
 558 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 559
 560         * configure.ac:
 561         * src/maemo/easysetup/Makefile.am:
 562         * src/maemo/easysetup/modest-easysetup-wizard.c:
 563         (modest_easysetup_wizard_dialog_init):
 564         * src/maemo/easysetup/provider-data-test.keyfile:
 565         * src/maemo/easysetup/provider-data.keyfile:
 566         Moved the provider data file to the new modest-providers-data package and used it from there.
 567
 568 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 569
 570         * src/modest-local-folder-info.c:
 571         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 572         N_() was already used on the static strings, but this just marks it for translation without
 573         using the translation.
 574
 575 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 576
 577         * src/maemo/modest-account-settings-dialog.c:
 578         (create_page_incoming),
 579         (modest_account_settings_dialog_set_account_name):
 580         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 581         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 582         I will do this if nobody else gets there first.
 583
 584 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 585
 586         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 587         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 588         save the security stuff.
 589
 590 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 591
 592         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 593         Set the email address and user fullname, which I now see must be
 594         done separately.
 595
 596         * src/maemo/modest-account-settings-dialog.h:
 597         * src/maemo/modest-account-settings-dialog.c:
 598          (on_response),
 599         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 600         leave-on-server and authentication.
 601         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 602         how to do the rest.
 603
 604 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 605
 606
 607         * src/maemo/modest-account-settings-dialog.c:
 608         * src/maemo/modest-account-settings-dialog.h:
 609         Most (but not all) of the widgets are now present as specified by the UI spec.
 610         No changes are yet saved, and some details are not properly shown yet.
 611
 612         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 613
 614 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 615
 616         * src/maemo/Makefile.am:
 617         * src/maemo/modest-account-settings-dialog.c:
 618         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 619         an existing account. Doesn't do much yet.
 620
 621         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 622         Open the accounts settings dialog when Edit is clicked.
 623
 624 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 625
 626         * src/maemo/easysetup/Makefile.am:
 627         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 628         (load_from_file):
 629         * src/maemo/easysetup/modest-easysetup-wizard.c:
 630         (modest_easysetup_wizard_dialog_init):
 631         Try to get the source directory from the build system,
 632         instead of hard-coding "./" into the source code, when opening our local
 633         copies of the configuration files.
 634         But this still fails when opening the wizard from the Accounts window,
 635         maybe because the working directory seems to change at runtime.
 636         So the wizard will fail the second time unless you copy the files into their
 637         proper locations - see the stdout warnings for the paths.
 638
 639         (create_page_account_details),(on_before_next):
 640         Check for existing non-server accounts instead of server accounts,
 641         so the default account name is useful again, and to prevent trying to
 642         recreate accounts.
 643
 644         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 645         Show the wizard when New is clicked.
 646
 647         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 648         (init_view): Show the column headers, and show the columns that are
 649         specified in the UI specs. However, something in Maemo's GTK+ prevents
 650         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 651         change the default account. This is despite unsetting the special properties.
 652
 653 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 654
 655         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 656         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 657         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 658         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 659         to make that clearer.
 660         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 661
 662 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 663
 664         * src/maemo/modest-account-view-window.c:
 665         (modest_account_view_window_init),
 666         (modest_account_view_window_new):
 667         Use the same buttons as specified in the
 668         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 669         the existing widgets, which never had a chance of working.
 670         Put the ModestAccountView treeview in a scrolled window.
 671         Do not repeat the initialization in both _init() and _new().
 672
 673         * src/widgets/modest-account-view.c: (update_account_view):
 674         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 675         this widget and window shows no accounts.
 676
 677         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 678
 679 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 680
 681         * src/maemo/easysetup/modest-easysetup-wizard.c:
 682         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 683         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 684         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 685         which seems wrong.
 686
 687         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 688         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 689         accounts exist yet, as in the UI spec.
 690
 691         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 692
 693 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 694
 695         * src/maemo/Makefile.am:
 696         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 697         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 698         New window for editing connection-specific smtp details.
 699         Not fully implemented.
 700
 701         * src/maemo/modest-connection-specific-smtp-window.c:
 702         (modest_connection_specific_smtp_window_finalize) :
 703         unref the tree model.
 704         (on_button_edit): Show the edit window.
 705
 706 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 707
 708         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 709         error for me.
 710
 711         * src/maemo/Makefile.am:
 712         * src/maemo/modest-connection-specific-smtp-window.c:
 713         * src/maemo/modest-connection-specific-smtp-window.h:
 714         New window for showing the list of connections, for connection-specific
 715         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 716         * src/maemo/easysetup/modest-easysetup-wizard.c:
 717         (create_page_custom_outgoing): Show the new window when the button is clicked.
 718
 719 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 720
 721         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 722         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 723         * src/maemo/modest-msg-edit-window.c:
 724         (modest_msg_edit_window_insert_image):
 725         * src/modest-conf.c: (modest_conf_key_escape):
 726         * src/modest-mail-operation.c:
 727         (modest_mail_operation_send_new_mail):
 728         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 729         (modest_ui_actions_on_new_account):
 730         * src/widgets/modest-attachment-view.c: (update_filename_request):
 731         * src/widgets/modest-mail-header-view.c:
 732         Corrected warnings that were breaking the build, by commenting out unused variables,
 733         and a function, and by including a header.
 734
 735 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 736
 737         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 738         so we can #ifdef around platform-specific code when necessary.
 739         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 740         to allow this to build for the GNOME platform too.
 741
 742 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 743
 744         * src/maemo/easysetup/modest-easysetup-wizard.c:
 745         Added util_increment_name() and used it in create_page_account_details()
 746         to make sure that the default account name is always a new name.
 747
 748         (modest_easysetup_wizard_dialog_init),
 749         (set_default_custom_servernames): Some minor memory management fixes.
 750
 751 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 752
 753         * Makefile.am:
 754         * configure.ac:
 755         * src/modest-runtime.c: (init_i18n): Restored the translation
 756         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 757         are defined in config.h, and the translations are installed.
 758
 759         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 760         is defined for translation.
 761
 762 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 763
 764         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 765         (load_from_file):
 766         * src/maemo/easysetup/modest-easysetup-wizard.c:
 767         (modest_easysetup_wizard_dialog_init):
 768         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 769         Use realistic paths (though they should use $prefix generically) to the
 770         mcc_mapping and provider-data.keyfile files which might work when they
 771         are installed by the future version of the operator-wizard package,
 772         and then fallback to paths in our source code, with an explanatory
 773         warning.
 774
 775 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 776
 777         * configure.ac:
 778         * src/Makefile.am:
 779         * src/maemo/Makefile.am:
 780         * src/maemo/easysetup/: Added files from the previously-exernal
 781         osso-modest-easysetup.
 782         * src/maemo/modest-main-window-ui.h:
 783         * src/modest-ui-actions.c:
 784         * src/modest-ui-actions.h:
 785         Added modest_ui_actions_on_new_account() as a signal handler for the
 786         New Account menu item. It shows the easysetup wizard.
 787         * po/en_GB.po: Added additional needed logical IDs and translations.
 788
 789 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 790 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 791