1 2007-05-08 Murray Cumming <murrayc@murrayc.com>
4 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
5 caused an undefined symbol error:
6 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
8 2007-05-08 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-account-store.c:
11 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
12 using a GError instead of a string message, so we can translate it in
15 2007-05-08 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-address-book.c:
18 (modest_address_book_check_names):
19 * src/maemo/modest-msg-view-window.c:
20 (modest_msg_view_window_clipboard_owner_change):
21 * src/modest-init.c: (modest_init_init_ui):
22 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
23 (update_folders_cb), (modest_mail_operation_update_account):
24 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
25 (modest_ui_actions_on_msg_attachment_clicked),
26 (modest_ui_actions_on_msg_recpt_activated):
27 * src/widgets/modest-header-view.c: (drag_data_get_cb):
28 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
29 (modest_msg_view_search_next):
30 * src/widgets/modest-recpt-editor.c:
31 (modest_recpt_editor_on_button_release_event),
32 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
33 g_message(). At this point we should only be seeing interesting errors on
34 stdout. Debugging messages could be #ifdefed-out if they are still useful.
36 2007-05-07 Murray Cumming <murrayc@murrayc.com>
38 (modest_wizard_dialog_force_title_update):
39 * src/maemo/easysetup/modest-wizard-dialog.h:
40 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
41 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
42 can update the title when appropriate. Otherwise the title is wrong if the
43 pages are added after adding the notebook to the dialog.
44 This must be a problem in HildonWizardDialog too.
45 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
47 * src/maemo/easysetup/modest-easysetup-wizard.c:
48 (create_subsequent_customsetup_pages),
49 (create_subsequent_easysetup_pages):
50 Call modest_wizard_dialog_force_title_update() so that the title is
51 correct even with GTK+ < 2.10.
52 This fixes projects.maemo.org bug NB#56145 .
54 2007-05-07 Murray Cumming <murrayc@murrayc.com>
56 * src/maemo/modest-platform.c:
57 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
58 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
61 2007-05-07 Murray Cumming <murrayc@murrayc.com>
63 * src/widgets/modest-window.h:
64 * src/widgets/modest-window.c: Added a save_state_func vfunc,
65 and modest_window_save_state(), which invokes it.
67 * src/widgets/modest-window-mgr.h:
68 * src/widgets/modest-window-mgr.c:
69 Added modest_window_mgr_save_state_for_all_windows(), which calls
70 the save_state vfunc on all registered windows, if implemented.
72 * src/gnome/modest-msg-edit-window.c:
73 * src/gnome/modest-msg-view-window.c:
74 * src/maemo/modest-msg-edit-window.c:
75 * src/maemo/modest-msg-view-window.c:
76 * src/maemo/modest-main-window.c:
77 Specify the existing save_settings functions as implementations of
78 ModestWindow::save_state_func().
80 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
81 Call modest_window_mgr_save_state_for_all_windows(). This happens before
82 enabling hibernation, for instance.
84 We may need to do the same thing for restoring settings.
87 2007-05-07 Murray Cumming <murrayc@murrayc.com>
89 * src/widgets/modest-window-mgr.c:
90 * src/widgets/modest-window-mgr.h:
91 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
92 modest_window_mgr_get_hibernation_is_prevented().
94 * src/maemo/modest-main-window.c:
95 (on_hildon_program_is_topmost_notify): Prevent hibernation
96 (possible when the application goes to the background in the WM),
97 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
99 * src/maemo/easysetup/modest-easysetup-wizard.c:
100 (modest_easysetup_wizard_dialog_init):
101 * src/maemo/modest-account-settings-dialog.c:
102 (modest_account_settings_dialog_init):
103 * src/maemo/modest-connection-specific-smtp-edit-window.c:
104 (modest_connection_specific_smtp_edit_window_init):
105 * src/maemo/modest-connection-specific-smtp-window.c:
106 (modest_connection_specific_smtp_window_init):
107 * src/maemo/modest-signature-editor-dialog.c:
108 (modest_signature_editor_dialog_init):
109 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
110 prevent hibernation while any of these account settings dialogs are open.
112 2007-05-04 Murray Cumming <murrayc@murrayc.com>
114 * src/maemo/Makefile.am:
115 * src/maemo/modest-osso-state-saving.c:
116 * src/maemo/modest-osso-state-saving.h: Added
117 modest_osso_load_state() and modest_osso_save_state() though they do
118 nothing now. They should iterate through all the open windows and load/save
120 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
121 save state when closing.
123 * src/maemo/modest-main-window.c:
124 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
125 Add a notification handler for the HildonProgram::is-topmost property,
126 so we can allow hibernation when the application goes into the background.
127 But we still need to detect when the accounts setup windows are open so
128 we can stop hibernation when they are open.
129 To do this, I also added the main window the HildonProgram. This might have
130 other side-effects/benefits, and should maybe be done for other windows.
132 * src/maemo/modest-osso-autosave-callbacks.h:
133 * src/maemo/modest-osso-autosave-callbacks.c:
134 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
135 though it does not do anything yet, and we might never need this to do
136 anything. For instance, we already save drafts.
138 * src/maemo/modest-platform.c: (modest_platform_init):
139 Specify the libosso auto-save callback.
141 2007-05-03 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/modest-platform.c:
144 (modest_platform_set_update_interval):
145 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
146 aparently stays valid between application instances, so we can use this
147 to remove and reset it later. According to a maemo-developers email from
150 2007-05-03 Murray Cumming <murrayc@murrayc.com>
152 * configure.ac: Depend on libalarm for Maemo.
154 * src/dbus_api/modest-dbus-api.h:
155 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
156 (on_send_receive), (modest_dbus_req_handler):
157 Handle a SEND_RECEIVE D-Bus method.
159 * libmodest-dbus-client/libmodest-dbus-client.c:
160 (libmodest_dbus_client_send_and_receive):
161 * libmodest-dbus-client/libmodest-dbus-client.h:
162 Add C convenience functions for calling the new D-Bus method.
164 * src/modest-platform.h:
165 * src/gnome/modest-platform.c:
166 * src/maemo/modest-platform.c:
167 Added modest_platform_set_update_interval(), which uses the
169 (modest_platform_init),
170 Call modest_platform_set_update_interval(), using a hard-coded
171 interval for now (until the global settings dialog is implemented),
172 though I am not sure that this makes sense yet.
174 2007-05-02 Murray Cumming <murrayc@murrayc.com>
176 * src/dbus_api/modest-dbus-callbacks.c:
177 (modest_osso_cb_hw_state_handler):
178 * src/dbus_api/modest-dbus-callbacks.h:
179 * src/maemo/modest-platform.c: (modest_platform_init):
180 Registered (empty) callbacks for the osso hardware state D-Bus signals,
181 in case this has some effect on the ability for Maemo to ping the
184 2007-05-02 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
187 Comment out an if() that checks a gchar for < 0, causing a build-breaking
188 warning. It is probably a logic error, but I need to fix the build.
190 2007-05-02 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-account-mgr.h:
193 * src/modest-account-mgr.c:
194 (modest_account_mgr_account_names): Add a gboolean enabled_only
195 parameter, so we can get lists of onlt the enabled accounts.
197 (modest_account_mgr_add_account),,
198 (modest_account_mgr_account_with_display_name_exists):
199 * src/maemo/modest-msg-edit-window.c: (get_transports):
200 * src/modest-account-mgr-helpers.c:
201 (modest_account_mgr_set_first_account_as_default):
202 * src/modest-init.c: (init_default_account_maybe):
203 * src/modest-tny-account-store.c: (get_accounts):
204 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
205 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
206 * tests/check_account-mgr.c: (START_TEST):
207 Provide the extra parameter, as appropriate.
209 * src/widgets/modest-account-view.c: (update_account_view):
210 Do not show disabled accounts (meaning that there is no way to
211 enable/disable accounts in the UI (the feature is not in our UI
212 specification), so we can use this internally only to mark unfinished
213 or temporary account data.
215 * src/maemo/easysetup/modest-easysetup-wizard.c:
216 (create_account): Add boolean enable parameter, so we can specify FALSE
217 to create the temporary account.
218 (on_button_edit_advanced_settings): Create the temporary account as disabled.
219 (on_before_next): When finishing, when there is a temporary account, just
221 Also, use a timeout to delay the showing of the dialog until gconf is likely
222 to return correct information, due to a maemo gconf bug that is fixed in
223 osso 1.1, but not yet in Bora.
224 However, the dialog stays on screen after it is destroyed.
226 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
227 for invalid data when cancelling. Use a hildon note instead of a dialog
228 to complain about invalid data. Do not show the account-saved note if the
229 account is disabled (a temporary account that will not really be saved for use
232 2007-04-30 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-account-mgr-helpers.h:
235 * src/modest-account-mgr-helpers.c:
236 Added modest_account_mgr_unset_default_account(),
237 Added modest_account_mgr_set_first_account_as_default().
239 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
240 If it was the default account, unset the default account name.
242 * src/maemo/modest-account-view-window.c:
243 (on_delete_button_clicked): If it was the default account,
244 set the first remaining account as the default instead.
246 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
247 a NULL account or a NULL default account, to prevent a crash. This should
248 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
251 2007-04-30 Murray Cumming <murrayc@murrayc.com>
253 * src/widgets/modest-recpt-editor.c:
254 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
255 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
256 TODO comment for this. This fixes the build.
258 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
259 be the best place for it. This will in future update all auto-update accounts,
260 rather than just the current/default account, when that gconf key exists.
261 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
262 if there are no accounts, before calling do_send_receive().
263 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
265 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
266 * src/maemo/modest-main-window-ui.h:
267 * src/maemo/modest-main-window.c: (on_connection_changed),
268 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
269 directly, becaue the signal handler does more.
271 2007-04-30 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-account-mgr-helpers.c:
274 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
275 for the case that the account does not exist.
277 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
278 (equivalent to the modest account name) rather than the tinymail account name
279 (equivalent to the modest account title - human readable) to get the account data.
280 Check for null account data to prevent the crash, and add a TODO comment saying that
281 this needs fixing because it is using the server account name instead of the account name.
283 2007-04-29 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
286 * src/maemo/modest-account-settings-dialog.c: (show_error),
288 Use hildon_note_new_information() for informative and error messages,
289 which seems to be expected for Maemo applications (no documentation that I know of
290 says this). I am surprised that there is no distinction between info and error
293 2007-04-29 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
296 it is easy to find where this is used.
298 * src/maemo/easysetup/modest-easysetup-wizard.c:
299 (create_page_welcome), (create_page_account_details),
300 (create_page_user_details), (create_page_complete_easysetup),
301 (create_page_custom_incoming), (create_page_custom_outgoing),
302 (create_page_complete_custom):
303 * src/maemo/modest-account-settings-dialog.c:
304 (create_page_account_details), (create_page_user_details),
305 (create_page_incoming), (create_page_outgoing):
306 * src/maemo/modest-account-view-window.c: (window_vbox_new):
307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
308 (modest_connection_specific_smtp_edit_window_init):
309 * src/maemo/modest-connection-specific-smtp-window.c:
310 (modest_connection_specific_smtp_window_init):
311 * src/maemo/modest-signature-editor-dialog.c:
312 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
313 and scrolling policy as per the Email Application Layout Guide, if I have
316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
318 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
319 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
320 which were empty, because these vfuncs have been removed from TnyAccountStore.
321 This fixes the build.
323 2007-04-27 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/modest-main-window.c:
326 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
327 showing/hiding it. Added TODO because it probably should not be NULL.
328 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
329 because unnecessary g_warnings() make degugging difficult.
331 2007-04-27 Murray Cumming <murrayc@murrayc.com>
333 * src/maemo/modest-msg-edit-window.c:
334 (modest_msg_edit_window_select_color),
335 (modest_msg_edit_window_select_background_color): 2 const corrections and
336 moving 2 #endifs before closing brackets, to fix the build.
338 2007-04-27 Murray Cumming <murrayc@murrayc.com>
340 * src/maemo/easysetup/modest-easysetup-wizard.h:
341 * src/maemo/easysetup/modest-easysetup-wizard.c:
342 (modest_easysetup_wizard_dialog_finalize),
343 (on_button_edit_advanced_settings), (create_page_complete_custom),
344 (on_response), (create_account):
345 Implement the Advanced Settings edit button, by saving the account information,
346 for the Advanded Settings dialog to use directly from gconf, and removing it
347 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
348 Bug #5533 in the projects.maemo.org bugzilla.
350 2007-04-27 Murray Cumming <murrayc@murrayc.com>
352 * src/maemo/modest-msg-view-window.c:
353 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
354 when opening a message window.
356 2007-04-27 Murray Cumming <murrayc@murrayc.com>
358 * src/maemo/easysetup/modest-easysetup-wizard.c:
359 (create_page_custom_outgoing): Correct the position of the horizontal separator to
362 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
363 before showing/hiding them, to avoid a crash when clicking on folders when there are no
364 gconf settings. I probably added more checks than necessary, but that is safer.
366 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
367 variable to fix the build, but this seems to be used when it is still NULL.
369 2007-04-27 Murray Cumming <murrayc@murrayc.com>
371 * src/modest-platform.h:
372 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
373 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
374 * src/modest-main.c: Implement this function so we can avoid using
375 maemo-specific API from cross-platform code.
377 * src/modest-tny-account-store.c:
378 (get_smtp_specific_transport_account_for_open_connection):
379 * src/modest-ui-actions.c: (check_for_connection),
380 (modest_ui_actions_on_item_not_found):
381 Use modest_platform_connect_and_wait() and put #idefs around other
382 maemo-specific code, because only maemo currently has a way to
383 identify connection names.
385 2007-04-27 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account-store.h:
388 * src/modest-tny-account-store.c:
389 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
390 the connection-specific SMTP server settings in the configuration.
392 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
394 * src/maemo/modest-main-window.c: (on_connection_changed),
396 * src/modest-main.c: (main), (start_ui), (send_mail):
397 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
398 that is what is intended.
400 * src/modest-ui-actions.c: (action_send), (action_receive),
401 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
402 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
403 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
404 SMTP server is used when it is specified.
406 (modest_ui_actions_on_send_receive):
407 Check that a connection is open before proceeding.
408 Receive and then send, instead of vice-versa, as per the specification.
410 2007-04-26 Murray Cumming <murrayc@murrayc.com>
412 * src/modest-mail-operation.c:
413 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
414 though I guess it should be something other than NULL.
416 2007-04-26 Murray Cumming <murrayc@murrayc.com>
418 * src/maemo/easysetup/modest-easysetup-wizard.c:
419 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
420 combo twice, to avoid an g_warning and to make it visible again.
421 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
422 attached before detaching it, to avoid a g_warning, and add comment about the implicit
423 (already intended) dereference when detaching, because we then recreate the menu.
424 But I am not sure why the warning was happening, and it is possible that this is a memory
427 2007-04-25 Murray Cumming <murrayc@murrayc.com>
429 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
430 and uri_parse_mailto() utility functions.
431 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
433 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
435 2007-04-24 Murray Cumming <murrayc@murrayc.com>
437 * src/dbus_api/modest-dbus-api.h:
438 * src/dbus_api/modest-dbus-callbacks.c:
439 Use an idle callback to execute the modest code in the application's own thread.
440 Remove the helloworld example method.
441 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
442 parsed, and the open-message method is not implemented because this is not yet implemented in
444 * libmodest-dbus-client/libmodest-dbus-client.c:
445 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
446 (libmodest_dbus_client_open_message):
447 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
449 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
450 body without crashing.
452 * tests/dbus_api/Makefile.am:
453 * tests/dbus_api/test_mail_to.c:
454 * tests/dbus_api/test_open_message.c: New tests for the new methods.
456 2007-04-24 Murray Cumming <murrayc@murrayc.com>
458 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
459 Added file to fix the build. Sorry.
461 * src/dbus_api/Makefile.am:
462 * src/dbus_api/modest-dbus-api.h:
463 * src/dbus_api/modest-dbus-callbacks.h:
464 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
465 (modest_dbus_req_handler):
466 Put constants in a separate header so it can be reused by the
467 client library, without duplication
469 * libmodest-dbus-client/Makefile.am:
470 * libmodest-dbus-client/libmodest-dbus-client.c:
471 (libmodest_dbus_client_call_helloworld),
472 (libmodfest_dbus_client_send_mail),
473 (libmodfest_dbus_client_mailto),
474 (libmodfest_dbus_client_open_message):
475 * libmodest-dbus-client/libmodest-dbus-client.h:
476 (Partly) Implement a send_mail D-Bus method.
478 * tests/dbus_api/Makefile.am:
479 * tests/dbus_api/test_send_mail.c: (main): Added a test for
480 the send_email D-Bus method.
482 2007-04-24 Murray Cumming <murrayc@murrayc.com>
486 * libmodest-dbus-client/Makefile.am:
487 * libmodest-dbus-client/libmodest-dbus-client.c:
488 * libmodest-dbus-client/libmodest-dbus-client.h:
489 * tests/dbus_api/Makefile.am:
490 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
491 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
493 2007-04-24 Murray Cumming <murrayc@murrayc.com>
495 * src/maemo/easysetup/modest-easysetup-wizard.c:
496 (create_page_account_details):
497 * src/maemo/modest-account-settings-dialog.c:
498 (create_page_account_details): Explicitly set auto-capitalization mode for the title
499 widgets, because this might not be the default in future versions of the Maemo GTK+.
500 However, I can not not get capitalization to work even in a simple test case.
502 2007-04-24 Murray Cumming <murrayc@murrayc.com>
504 * src/maemo/easysetup/modest-easysetup-wizard.c:
505 (create_page_custom_incoming), (create_page_custom_outgoing):
506 * src/maemo/modest-account-settings-dialog.c:
507 (create_page_account_details), (create_page_incoming),
508 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
509 instead of using gtk_check_button_with_label(), so they are aligned like the other
510 widgets, as per the UI spec.
512 2007-04-24 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/easysetup/modest-easysetup-wizard.c:
515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
516 * src/widgets/modest-validating-entry.c:
517 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
518 Modest prefix instead of an EasySetup prefix.
520 2007-04-23 Murray Cumming <murrayc@murrayc.com>
522 * src/widgets/modest-validating-entry.h:
523 * src/widgets/modest-validating-entry.c: (on_insert_text),
524 Added easysetup_validating_entry_set_max_func(), used to set a callback
525 to call when the max number of characters is reached. GtkEntry has a max-length
526 already but is silent about it.
528 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
529 (create_page_account_details), (create_page_user_details),
531 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
532 (create_page_account_details), (create_page_user_details),
533 (create_page_outgoing):
534 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
535 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
536 the UI spec, when the user tries to enter more than the max number of characters.
538 2007-04-23 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/easysetup/modest-easysetup-wizard.c:
541 (create_page_user_details), (create_page_custom_incoming),
542 (create_page_custom_outgoing):
543 * src/maemo/modest-account-settings-dialog.c:
544 (create_page_user_details), (create_page_incoming),
545 (create_page_outgoing):
546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
547 (modest_connection_specific_smtp_edit_window_init):
548 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
549 not appropriate. Bad Maemo-specific defaults!.
551 2007-04-23 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
554 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
555 (modest_signature_editor_dialog_set_settings):
556 Disable the label and textview when the checkbox is disabled, and use the
557 specified (UI spec) default signature text.
559 2007-04-23 Murray Cumming <murrayc@murrayc.com>
561 * src/maemo/modest-connection-specific-smtp-edit-window.c:
562 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
565 * src/modest-account-mgr-helpers.h:
566 * src/modest-account-mgr-helpers.c:
567 Added modest_account_mgr_get/set_signature(), using new gconf keys.
569 * src/maemo/Makefile.am:
570 * src/maemo/modest-signature-editor-dialog.c:
571 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
574 * src/maemo/modest-account-settings-dialog.h:
575 * src/maemo/modest-account-settings-dialog.c:
576 (modest_account_settings_dialog_finalize), (on_button_signature),
577 (save_configuration): Use the new dialog when the Edit button is pressed, and
578 save the changes if necessary, as per the UI spec.
580 2007-04-23 Murray Cumming <murrayc@murrayc.com>
582 * src/maemo/Makefile.am:
583 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
584 based on maemo-develoers email from Dirk.
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 (create_page_welcome), (create_page_account_details),
588 (create_page_user_details), (create_page_complete_easysetup),
589 (create_page_custom_incoming), (create_page_custom_outgoing),
590 (create_page_complete_custom),
591 (modest_easysetup_wizard_dialog_init):
592 * src/maemo/modest-account-settings-dialog.c:
593 (create_page_account_details), (create_page_user_details),
594 (create_page_incoming), (create_page_outgoing),
595 (modest_account_settings_dialog_init):
596 * src/maemo/modest-connection-specific-smtp-window.c:
597 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
599 2007-04-23 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/easysetup/modest-easysetup-wizard.c:
602 (create_page_account_details), (create_page_custom_outgoing),
603 (create_page_complete_custom):
604 * src/maemo/modest-account-settings-dialog.c:
605 (create_page_user_details), (create_page_incoming),
606 (create_page_outgoing):
607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
608 (modest_connection_specific_smtp_edit_window_init):
609 Use the correct (UI spec) port min/max, and use horizontal separators,
612 2007-04-23 Murray Cumming <murrayc@murrayc.com>
614 * src/maemo/easysetup/modest-easysetup-wizard.c:
615 (set_default_custom_servernames):
616 * src/maemo/modest-account-settings-dialog.c:
617 (create_page_incoming), (on_combo_outgoing_security_changed),
618 (on_combo_incoming_security_changed), (create_page_outgoing),
619 (modest_account_settings_dialog_set_account_name),
620 (save_configuration):
621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
622 (on_combo_security_changed),
623 (modest_connection_specific_smtp_edit_window_init),
624 (modest_connection_specific_smtp_edit_window_set_connection),
625 (modest_connection_specific_smtp_edit_window_get_settings):
626 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
629 2007-04-20 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/easysetup/modest-easysetup-wizard.c:
633 (create_page_custom_outgoing), (create_page_complete_custom):
634 * src/maemo/modest-account-settings-dialog.c:
635 (create_page_user_details), (create_page_outgoing):
636 * src/maemo/modest-account-view-window.c: (button_box_new):
637 Use changed logical IDs as per the most recent UI spec:
638 mcen_bd_emailsetup_edit -> mcen_bd_edit
639 mcen_bd_emailsetup_delete -> mcen_bd_delete
640 mcen_bd_emailsetup_close -> mcen_bd_close
642 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
646 * src/dbus_api/Makefile.am:
647 * src/dbus_api/modest-dbus-callbacks.c:
648 * src/dbus_api/modest-dbus-callbacks.h:
649 * src/maemo/modest-platform.c: (modest_platform_init):
650 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
653 * tests/dbus_api/Makefile.am:
654 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
656 2007-04-20 Murray Cumming <murrayc@murrayc.com>
658 * src/maemo/modest-account-settings-dialog.c:
659 * src/maemo/modest-connection-specific-smtp-edit-window.c:
660 Removed unnecessary includes.
662 2007-04-20 Murray Cumming <murrayc@murrayc.com>
664 * src/maemo/easysetup/modest-easysetup-wizard.c:
665 * src/maemo/modest-account-settings-dialog.c:
666 * src/maemo/modest-connection-specific-smtp-edit-window.c:
667 * src/widgets/Makefile.am:
668 * src/widgets/modest-easysetup-secureauth-combo-box.c:
669 * src/widgets/modest-easysetup-secureauth-combo-box.h:
670 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
671 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
672 * src/widgets/modest-secureauth-combo-box.c:
673 * src/widgets/modest-secureauth-combo-box.h:
674 * src/widgets/modest-serversecurity-combo-box.c:
675 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
676 made the GObject names more consistent with the rest of the Modest code.
678 2007-04-20 Murray Cumming <murrayc@murrayc.com>
680 * src/maemo/easysetup/Makefile.am:
681 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
682 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
683 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
684 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
685 * src/maemo/easysetup/modest-easysetup-wizard.c:
686 * src/maemo/easysetup/modest-validating-entry.c:
687 * src/maemo/easysetup/modest-validating-entry.h:
688 * src/maemo/modest-account-settings-dialog.c:
689 * src/maemo/modest-connection-specific-smtp-edit-window.c:
690 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
691 widgets/ because they are used outside of easysetup too. After checking in,
692 svn will allow me to rename them too.
694 2007-04-20 Murray Cumming <murrayc@murrayc.com>
696 * src/gnome/modest-msg-edit-window.c:
697 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
698 linker error, to fix the build on the GNOME platform.
699 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
700 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
701 ifdefed out to avoid a warning.
703 2007-04-20 Murray Cumming <murrayc@murrayc.com>
705 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
706 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
707 some alternative for GTK+ 2.6.
709 2007-04-19 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/modest-address-book.c: Added include to avoid a warning.
713 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
714 specified for EmailAccountsDialog in UI spec.
716 * src/maemo/easysetup/modest-easysetup-wizard.c:
717 * src/maemo/easysetup/modest-easysetup-wizard.h:
718 * src/maemo/modest-account-settings-dialog.c:
719 * src/maemo/modest-account-settings-dialog.h:
720 Reuse a member window widget for the connection-specific SMTP server accounts,
721 so we can tell it to create/save the accounts only if we actually save changes.
723 * src/maemo/modest-connection-specific-smtp-edit-window.h:
724 * src/maemo/modest-connection-specific-smtp-edit-window.c:
725 (modest_connection_specific_smtp_edit_window_get_settings):
726 Return a struct instance for temporarily remembering the entered data.
728 * src/maemo/modest-connection-specific-smtp-window.h:
729 * src/maemo/modest-connection-specific-smtp-window.c:
730 (modest_connection_specific_smtp_window_finalize),
731 (modest_connection_specific_smtp_window_fill_with_connections),
733 (modest_connection_specific_smtp_window_save_server_accounts),
734 (update_model_server_names): Do not actually save data until asked,
735 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
737 (on_selection_changed),
738 (modest_connection_specific_smtp_window_init): Disable the edit
739 button when nothing is selected.
741 * src/modest-account-mgr-helpers.c:
742 * src/modest-account-mgr-helpers.h:
743 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
746 2007-04-19 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-account-mgr-helpers.h:
749 * src/modest-account-mgr-helpers.c:
750 (modest_account_mgr_get_unused_account_name),
751 (modest_account_mgr_get_unused_account_display_name): Added these
752 utility functions, to avoid code duplication.
754 * src/maemo/easysetup/modest-easysetup-wizard.c:
755 (create_page_account_details), (create_account):
756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
757 (on_combo_security_changed),
758 (modest_connection_specific_smtp_edit_window_init),
759 (modest_connection_specific_smtp_edit_window_save_settings):
760 * src/maemo/modest-connection-specific-smtp-edit-window.h:
761 * src/maemo/modest-connection-specific-smtp-window.c:
762 (modest_connection_specific_smtp_window_finalize),
763 (modest_connection_specific_smtp_window_fill_with_connections),
764 (on_button_edit), (modest_connection_specific_smtp_window_init):
765 * src/maemo/modest-connection-specific-smtp-window.h:
766 Implementing saving of connection-specific server accounts.
768 But I need to refactor this so we can save the data for each
769 possible connection-specific account and only actually create the server accounts
770 when the easysetup finished, or the OK button is pressed on the account settings
773 2007-04-18 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/modest-connection-specific-smtp-edit-window.c:
776 (on_combo_security_changed):
777 (modest_connection_specific_smtp_edit_window_init):
778 Auto-fill the port number as in the account settings.
780 (modest_connection_specific_smtp_edit_window_set_connection):
781 * src/maemo/modest-connection-specific-smtp-edit-window.h:
782 * src/maemo/modest-connection-specific-smtp-window.c:
783 (fill_with_connections), (on_button_edit),
784 (modest_connection_specific_smtp_window_init):
785 Turn the edit window into a dialog to simplify the code, and
786 set a WM hint as in a GtkDialog, because only a popup can be on top of
787 another window in Maemo, and popups usually have no WM decoration.
790 * src/modest-account-mgr-helpers.c:
791 (modest_account_mgr_set_connection_specific_smtp),
792 (modest_account_mgr_remove_connection_specific_smtp),
793 (modest_account_mgr_get_connection_specific_smtp):
794 * src/modest-account-mgr-helpers.h: Some functions to write the
795 connection-specific SMTP server information. Not yet used.
798 * src/widgets/modest-folder-view.c: (text_cell_data):
799 Fix a warning about an uninitialized variable.
800 (on_configuration_key_changed): Put an #ifdef around the use
801 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
803 2007-04-18 Murray Cumming <murrayc@murrayc.com>
805 * src/maemo/modest-account-settings-dialog.h:
806 * src/maemo/modest-account-settings-dialog.c:
807 Added connect_for_modified() utility function to mark the new modified boolean.
809 (create_page_account_details), (create_page_user_details),
810 (create_page_incoming), (create_page_outgoing), (on_response),
811 (modest_account_settings_dialog_init),
812 (modest_account_settings_dialog_set_account_name):
813 Only warn about unsaved changes when there are actually unsaved changes.
815 * src/modest-account-mgr-helpers.c:
816 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
817 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
818 to get the data from there in future.
820 2007-04-18 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-account-mgr-helpers.h:
825 * src/modest-account-mgr-helpers.c:
826 Store the security account setting in a single conf key instead of using
827 the options list, so that the list is left for just the to-be-removed camel hack,
828 and because gconf_client_set_list() is failing for some reason.
830 * src/modest-account-mgr.c:
831 (modest_account_mgr_add_server_account):
832 * src/maemo/modest-account-settings-dialog.c:
833 (modest_account_settings_dialog_set_account_name),
834 (save_configuration): Use the renamed functions.
837 2007-04-18 Murray Cumming <murrayc@murrayc.com>
839 * src/widgets/Makefile.am:
840 * src/widgets/modest-limit-retrieve-combo-box.c:
841 * src/widgets/modest-limit-retrieve-combo-box.h:
842 * src/widgets/modest-retrieve-combo-box.c:
843 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
844 the account settings dialog.
847 * src/modest-account-mgr-helpers.h:
848 * src/modest-account-mgr-helpers.c:
849 (modest_server_account_get_option_secure_auth),
850 (modest_server_account_set_option_secure_auth):
851 * src/modest-account-mgr.c:
852 (modest_account_mgr_add_server_account):
853 Use the existing AUTH_MECH conf key for the secure-auth setting,
854 instead of putting it in the list options, because this was actually used already.
856 * src/maemo/modest-account-settings-dialog.c:
857 (create_page_account_details),
858 (modest_account_settings_dialog_set_account_name),
859 (save_configuration):
860 * src/maemo/modest-account-settings-dialog.h:
861 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
862 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
864 2007-04-18 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
867 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
868 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
871 * src/maemo/modest-account-settings-dialog.c:
872 (create_page_incoming), (on_combo_outgoing_security_changed),
873 (on_combo_incoming_security_changed), (create_page_outgoing),
874 (modest_account_settings_dialog_set_account_name),
875 (save_configuration): Load/Save the port number, and change it when the
876 security combo changes, to suitable defaults.
878 2007-04-17 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-account-mgr.c:
881 (modest_account_mgr_add_server_account): Set the security and secure-auth
882 options, and add a comment saying that the other camel-specific options should be
885 2007-04-17 Murray Cumming <murrayc@murrayc.com>
887 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
889 * src/modest-tny-account-store.c: (account_list_free),
890 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
891 cursor->data after unreffing it. But there is some strange stuff there so it might not be
894 2007-04-17 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-protocol-info.c:
897 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
898 is required by our UI spec. Maybe something in our implementation will use this eventually.
899 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
900 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
901 instead of the previous 0 placeholder.
903 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
904 secure-auth settings.
905 * src/modest-account-mgr-helpers.h:
906 * src/modest-account-mgr-helpers.c:
907 (modest_server_account_data_get_option_secure_auth),
908 (modest_server_account_set_option_secure_auth),
909 (modest_server_account_data_get_option_security),
910 (modest_server_account_set_option_security): Added this API for getting and setting the security
911 and secure-auth settings.
913 * src/maemo/modest-account-settings-dialog.h:
914 * src/maemo/modest-account-settings-dialog.c:
915 (modest_account_settings_dialog_finalize), (check_data),
916 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
917 about changing titles.
918 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
919 (save_configuration): Save the security and secure-auth settings.
921 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
922 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
924 2007-04-17 Murray Cumming <murrayc@murrayc.com>
927 * src/modest-account-mgr.c:
928 (modest_account_mgr_add_server_account):
929 Added and used defines for the options key and value pair strings,
930 that are used so far, though they do not seem to correspond to anything in our
931 UI specs or ModestProtocol enum.
933 * src/modest-account-mgr-helpers.h:
934 * src/modest-account-mgr-helpers.c:
935 (compare_option_strings_for_name),
936 (modest_server_account_data_get_option_value),
937 (modest_server_account_data_get_option_bool),
938 (modest_account_mgr_get_server_account_option):
939 Added helper functions for parsing the options GSList.
941 2007-04-16 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
944 display name is based on the supplied account name.
945 * src/modest-account-mgr.c:
946 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
947 with an inefficient, but good-enough, implementation.
949 * src/maemo/easysetup/modest-easysetup-wizard.c:
950 (create_page_account_details), (on_before_next), (create_account):
951 Check for existing display names rather than (non-user-visible) account names, and just
952 create and set a unique account name at the end.
954 * src/maemo/modest-account-settings-dialog.c:
955 (modest_account_settings_dialog_init),
956 (modest_account_settings_dialog_set_account_name),
957 (create_page_incoming): Show the display name, instead of the account name.
958 (on_response): Do some (not all) extra checks, as in the UI spec.
959 (save_configuration): Save the display name if it was changed.
961 2007-04-16 Murray Cumming <murrayc@murrayc.com>
963 * po/en_GB.po: Added needed logical ID and translation.
964 * src/widgets/modest-account-view.c: (on_account_default_toggled),
965 (init_view): Made the is-default column clicking work.
967 2007-04-16 Murray Cumming <murrayc@murrayc.com>
970 * src/maemo/easysetup/Makefile.am:
971 * src/maemo/easysetup/modest-easysetup-wizard.c:
972 (modest_easysetup_wizard_dialog_init):
973 * src/maemo/easysetup/provider-data-test.keyfile:
974 * src/maemo/easysetup/provider-data.keyfile:
975 Moved the provider data file to the new modest-providers-data package and used it from there.
977 2007-04-16 Murray Cumming <murrayc@murrayc.com>
979 * src/modest-local-folder-info.c:
980 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
981 N_() was already used on the static strings, but this just marks it for translation without
982 using the translation.
984 2007-04-06 Murray Cumming <murrayc@murrayc.com>
986 * src/maemo/modest-account-settings-dialog.c:
987 (create_page_incoming),
988 (modest_account_settings_dialog_set_account_name):
989 Added comments about the need for new API in ModestAccountMgr to handle the authentication
990 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
991 I will do this if nobody else gets there first.
993 2007-04-06 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
996 Saved much of the incoming and outgoing data too, though I cannot yet see how to
997 save the security stuff.
999 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1002 Set the email address and user fullname, which I now see must be
1005 * src/maemo/modest-account-settings-dialog.h:
1006 * src/maemo/modest-account-settings-dialog.c:
1008 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1009 leave-on-server and authentication.
1010 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1013 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1016 * src/maemo/modest-account-settings-dialog.c:
1017 * src/maemo/modest-account-settings-dialog.h:
1018 Most (but not all) of the widgets are now present as specified by the UI spec.
1019 No changes are yet saved, and some details are not properly shown yet.
1021 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1023 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/Makefile.am:
1026 * src/maemo/modest-account-settings-dialog.c:
1027 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1028 an existing account. Doesn't do much yet.
1030 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1031 Open the accounts settings dialog when Edit is clicked.
1033 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/easysetup/Makefile.am:
1036 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1038 * src/maemo/easysetup/modest-easysetup-wizard.c:
1039 (modest_easysetup_wizard_dialog_init):
1040 Try to get the source directory from the build system,
1041 instead of hard-coding "./" into the source code, when opening our local
1042 copies of the configuration files.
1043 But this still fails when opening the wizard from the Accounts window,
1044 maybe because the working directory seems to change at runtime.
1045 So the wizard will fail the second time unless you copy the files into their
1046 proper locations - see the stdout warnings for the paths.
1048 (create_page_account_details),(on_before_next):
1049 Check for existing non-server accounts instead of server accounts,
1050 so the default account name is useful again, and to prevent trying to
1053 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1054 Show the wizard when New is clicked.
1056 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1057 (init_view): Show the column headers, and show the columns that are
1058 specified in the UI specs. However, something in Maemo's GTK+ prevents
1059 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1060 change the default account. This is despite unsetting the special properties.
1062 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1064 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1065 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1066 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1067 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1068 to make that clearer.
1069 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1071 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1073 * src/maemo/modest-account-view-window.c:
1074 (modest_account_view_window_init),
1075 (modest_account_view_window_new):
1076 Use the same buttons as specified in the
1077 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1078 the existing widgets, which never had a chance of working.
1079 Put the ModestAccountView treeview in a scrolled window.
1080 Do not repeat the initialization in both _init() and _new().
1082 * src/widgets/modest-account-view.c: (update_account_view):
1083 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1084 this widget and window shows no accounts.
1086 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1088 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1090 * src/maemo/easysetup/modest-easysetup-wizard.c:
1091 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1092 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1093 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1096 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1097 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1098 accounts exist yet, as in the UI spec.
1100 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1102 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1104 * src/maemo/Makefile.am:
1105 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1106 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1107 New window for editing connection-specific smtp details.
1108 Not fully implemented.
1110 * src/maemo/modest-connection-specific-smtp-window.c:
1111 (modest_connection_specific_smtp_window_finalize) :
1112 unref the tree model.
1113 (on_button_edit): Show the edit window.
1115 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1117 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1120 * src/maemo/Makefile.am:
1121 * src/maemo/modest-connection-specific-smtp-window.c:
1122 * src/maemo/modest-connection-specific-smtp-window.h:
1123 New window for showing the list of connections, for connection-specific
1124 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1125 * src/maemo/easysetup/modest-easysetup-wizard.c:
1126 (create_page_custom_outgoing): Show the new window when the button is clicked.
1128 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1130 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1131 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1132 * src/maemo/modest-msg-edit-window.c:
1133 (modest_msg_edit_window_insert_image):
1134 * src/modest-conf.c: (modest_conf_key_escape):
1135 * src/modest-mail-operation.c:
1136 (modest_mail_operation_send_new_mail):
1137 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1138 (modest_ui_actions_on_new_account):
1139 * src/widgets/modest-attachment-view.c: (update_filename_request):
1140 * src/widgets/modest-mail-header-view.c:
1141 Corrected warnings that were breaking the build, by commenting out unused variables,
1142 and a function, and by including a header.
1144 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1146 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1147 so we can #ifdef around platform-specific code when necessary.
1148 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1149 to allow this to build for the GNOME platform too.
1151 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/easysetup/modest-easysetup-wizard.c:
1154 Added util_increment_name() and used it in create_page_account_details()
1155 to make sure that the default account name is always a new name.
1157 (modest_easysetup_wizard_dialog_init),
1158 (set_default_custom_servernames): Some minor memory management fixes.
1160 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-runtime.c: (init_i18n): Restored the translation
1165 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1166 are defined in config.h, and the translations are installed.
1168 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1169 is defined for translation.
1171 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1175 * src/maemo/easysetup/modest-easysetup-wizard.c:
1176 (modest_easysetup_wizard_dialog_init):
1177 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1178 Use realistic paths (though they should use $prefix generically) to the
1179 mcc_mapping and provider-data.keyfile files which might work when they
1180 are installed by the future version of the operator-wizard package,
1181 and then fallback to paths in our source code, with an explanatory
1184 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1188 * src/maemo/Makefile.am:
1189 * src/maemo/easysetup/: Added files from the previously-exernal
1190 osso-modest-easysetup.
1191 * src/maemo/modest-main-window-ui.h:
1192 * src/modest-ui-actions.c:
1193 * src/modest-ui-actions.h:
1194 Added modest_ui_actions_on_new_account() as a signal handler for the
1195 New Account menu item. It shows the easysetup wizard.
1196 * po/en_GB.po: Added additional needed logical IDs and translations.
1198 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1199 Apparently ChangeLog is not used for some vague Nokia legal reasons.