1 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (libmodest_dbus_client_compose_mail): function added
5 * src/dbus_api/modest-dbus-api.h:
6 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
7 (on_compose_mail): Implementation of the SendAsMail functionality
9 2007-05-22 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-account-mgr.c:
12 (modest_account_mgr_add_server_account): Set the secure-connection
13 conf key for transport accounts as well as store accounts. I don't know
14 why the if was there. For instance, this makes sure that we use SSL
15 for the gmail preset from the easysetup wizard.
17 2007-05-22 Murray Cumming <murrayc@murrayc.com>
19 * src/gnome/modest-main-window.c:
20 (on_account_store_connecting_finished), (connect_signals):
21 * src/maemo/modest-main-window.c:
22 (on_account_store_connecting_finished), (connect_signals),
23 (modest_main_window_new):
24 Handle TnyAccountStore::connecting-finished instead of
25 TnyDevice::connection-changed, because we cannot actually perform
26 operations on accounts until TnyAccountStore has itself responded to
27 the TnyDevice::connection-changed signal. This prevents a GError from
29 Do not try to update at startup, because we (at least on scratchbox)
30 already do an update at startup when the device goes online.
31 This prevents a GError from tinymail.
32 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
33 Added TODO about stopping simultaneous operations.
35 2007-05-21 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
38 * src/modest-mail-operation-queue.c:
39 (modest_mail_operation_queue_remove):
40 * src/modest-tny-account-store.c: When GErrors happen, give more clues
41 about where they happened.
43 2007-05-21 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-ui-actions.c:
46 (modest_ui_actions_on_password_requested): Make sure that the remember
47 output parameter is always TRUE.
49 2007-05-21 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
52 Show a OK/Cancel dialog if the error is a question, though we still do not
53 know anything more about what we are asking the user.
54 * src/widgets/modest-folder-view.c: (on_drag_data_received):
55 Fix an uninitialized variable (helper). This is a logic error, however.
57 2007-05-21 Christian Kellner <ckellner@openismus.com>
59 * src/modest-search.h:
60 Correct bit shifting in the ModestSearchFlags enum.
62 2007-05-21 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account.c:
65 (modest_tny_account_new_from_server_account): Do not use the lsub and
66 check-all hard-coded IMAP options when using POP.
68 2007-05-21 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account.c:
71 (modest_tny_account_new_from_server_account):
72 Use NULL for the secure-auth method for POP when Password auth has been
73 specified by the user, as we already do for IMAP. "auth=Login" causes
74 an error from camel or the server.
76 2007-05-17 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-account-settings-dialog.c:
79 (create_page_account_details),
80 (modest_account_settings_dialog_set_account_name):
81 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
82 for the leave-on-server checkbox, rathr than just the checkbox, when
83 the protocol is not POP.
85 2007-05-17 Murray Cumming <murrayc@murrayc.com>
87 * src/widgets/modest-account-view.c:
88 * src/widgets/modest-account-view.h:
89 Added modest_account_view_select_account() which will be useful later
90 to asynchronously re-select the edited account.
92 2007-05-17 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/modest-account-settings-dialog.c:
95 (modest_account_settings_dialog_set_account_name):
96 Automatically choose the port numbers based on the secure authentication
97 methods, if they have not been chosen before.
98 This fixes projects.maemo.org bug NB#56273 .
100 2007-05-17 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-main-window-ui.h:
103 * src/modest-ui-actions.c:
104 * src/modest-ui-actions.h:
105 Connect the Tools/SMTP Servers menu item to
106 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
107 SMTP servers dialog, as in the UI specification and saves changes when it
108 is closed. This fixed projects.maemo.org bug NB#56305 .
110 2007-05-17 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-connection-specific-smtp-window.c:
113 (modest_connection_specific_smtp_window_init):
114 Use gtk_window_set_default_size() to make this window big enough, so
115 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
117 2007-05-17 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-connection-specific-smtp-edit-window.h:
120 * src/maemo/modest-connection-specific-smtp-edit-window.c:
121 (modest_connection_specific_smtp_edit_window_init),
122 Do not try to connect to a combobox signal before the combobox exists.
123 This fixes the cras in projects.maemo.org bug NB#56288 .
124 (modest_connection_specific_smtp_edit_window_get_settings):
125 Remove the server_account_name parameter which was being checked for NULL
126 though it was not used.
128 * src/maemo/modest-connection-specific-smtp-window.c:
129 (modest_connection_specific_smtp_window_fill_with_connections),
130 (on_button_edit), (modest_connection_specific_smtp_window_init):
131 Correct the number of treemodel columns to prevent a warning.
132 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
133 libconic does not work.
135 2007-05-16 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-tny-account.c:
138 (modest_tny_account_new_from_server_account):
139 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
140 SMTP when "None" was chosen by the user. However, with my SMTP server that
141 does not support ANONYMOUS, the emails do not leave the Outbox and I see
144 2007-05-16 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
147 to explain the memory management issue with the ID in the ModestPair.
149 * src/gnome/modest-account-assistant.c: (add_receiving_page),
150 (add_sending_page), (modest_account_assistant_finalize):
151 * src/gnome/modest-gnome-global-settings-dialog.c:
152 (create_updating_page), (create_composing_page):
153 * src/gnome/modest-msg-edit-window.c: (get_transports),
154 (init_window), (modest_msg_edit_window_finalize),
155 (modest_msg_edit_window_get_msg_data):
156 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
157 * src/gnome/modest-transport-widget.c:
158 (modest_transport_widget_finalize), (smtp_configuration):
159 * src/maemo/modest-maemo-global-settings-dialog.c:
160 (create_updating_page), (create_composing_page):
161 * src/maemo/modest-msg-edit-window.c: (get_transports),
162 (init_window), (modest_msg_edit_window_finalize),
163 (modest_msg_edit_window_get_msg_data),
164 (modest_msg_edit_window_free_msg_data):
165 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
166 (modest_store_widget_finalize):
167 * src/maemo/modest-transport-widget.c:
168 (modest_transport_widget_finalize), (smtp_configuration):
169 * src/modest-main.c: (send_mail):
170 * src/widgets/modest-combo-box.h:
171 * src/widgets/modest-global-settings-dialog-priv.h:
172 * src/widgets/modest-global-settings-dialog.c:
173 (modest_global_settings_dialog_finalize):
174 * src/widgets/modest-msg-edit-window.h:
175 Whenever using modest_combo_box_new(), keep the ModestPairList alive
176 as long as the combo box, to prevent use of freed memory for the ID.
178 2007-05-15 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
181 get_accounts(), to make this clearer. Do not check for the enabled gconf
182 key, because we do not use this for server accounts (at least, not yet).
183 This allows us to send email again.
185 2007-05-15 Murray Cumming <murrayc@murrayc.com>
187 * src/maemo/modest-platform.c:
188 (on_modest_conf_update_interval_changed), (modest_platform_init):
189 Only respond to this particular key change. All these strcmp()s cannot be
192 2007-05-15 Murray Cumming <murrayc@murrayc.com>
194 * src/maemo/modest-maemo-global-settings-dialog.c:
195 (current_connection): Prevent a crash in scratchbox when
196 ny_maemo_conic_device_get_current_iap_id() returns NULL.
197 * src/maemo/modest-platform.c:
198 (on_modest_conf_update_interval_changed), (modest_platform_init):
199 Get the update interval from gconf and reset it when the gconf key changes.
201 2007-05-15 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-protocol-info.c:
204 * src/modest-protocol-info.h: Adde enum-specific get functions,
205 instead of using a ModestProtocolType enum parameter.
207 * src/gnome/modest-account-assistant.c:
208 * src/gnome/modest-store-widget.c:
209 * src/gnome/modest-store-widget.h:
210 * src/gnome/modest-transport-widget.c:
211 * src/gnome/modest-transport-widget.h:
212 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
213 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
214 * src/maemo/easysetup/modest-easysetup-wizard.c:
215 * src/maemo/modest-account-settings-dialog.c:
216 * src/maemo/modest-account-settings-dialog.h:
217 * src/maemo/modest-store-widget.c:
218 * src/maemo/modest-store-widget.h:
219 * src/maemo/modest-transport-widget.c:
220 * src/maemo/modest-transport-widget.h:
221 * src/modest-account-mgr-helpers.c:
222 * src/modest-account-mgr-helpers.h:
223 * src/modest-account-mgr.c:
224 * src/modest-account-mgr.h:
225 * src/modest-tny-account.c:
226 * src/modest-tny-folder.c:
227 * src/widgets/modest-account-view.c:
228 * src/widgets/modest-retrieve-combo-box.c:
229 * src/widgets/modest-retrieve-combo-box.h:
230 * src/widgets/modest-secureauth-combo-box.c:
231 * src/widgets/modest-serversecurity-combo-box.c:
232 * src/widgets/modest-serversecurity-combo-box.h:
233 * tests/check_account-mgr.c:
234 Use the specific functions, and use the re-renamed enum values for GNOME too.
236 2007-05-15 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
240 so we can get the second based on the first.
242 * src/maemo/modest-account-settings-dialog.h:
243 * src/maemo/modest-account-settings-dialog.c:
244 Added get_supported_secure_authentication_methods(), though it is mostly
245 commented-out for now until the necessary API is committed to tinymail.
246 (modest_account_settings_dialog_set_account_name),
247 (save_configuration): Request the supported authentication methods from the
248 server, so we can choose a working method.
250 * src/modest-tny-account-store.h:
251 * src/modest-tny-account-store.c:
252 (modest_tny_account_store_get_session): Rename from
253 tny_account_store_get_session().
255 2007-05-14 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-protocol-info.h: Split the ModestProtocol enum
258 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
259 There was no need to have these unrelated values in one enum.
261 * src/: many files: Adapted to changed enum. This makes the code a bit
262 clearer, and the compiler could catch some errors.
264 2007-05-14 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
267 Show the detailed internal camel error message when an error happens
268 during the configuration, so that our testers can give us more clues.
269 For instance, in projects.maemo.org bug NB#56910 .
271 2007-05-14 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account.c:
274 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
275 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
277 2007-05-14 Murray Cumming <murrayc@murrayc.com>
279 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
280 * src/maemo/modest-account-settings-dialog.c:
281 (modest_account_settings_dialog_set_account_name),
282 (save_configuration): For the incoming secure authentication checkbox,
283 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
284 the UI specification. PLAIN does not seem to be supported for most IMAP
285 servers anyway, and I am not sure what it would mean.
286 However, we probably need to discover which of the secure-authentication
287 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
288 * src/modest-account-mgr-helpers.c:
289 (modest_account_mgr_get_server_account_data):
291 * src/modest-tny-account.c:
292 (modest_tny_account_new_from_server_account):
293 Use tny_account_set_mech() to set secure-authentication methods,
294 with some special-casing for IMAP, based on my observations of how
297 * src/modest-account-mgr-helpers.h:
298 * src/modest-account-mgr.c:
299 * src/modest-defs.h: Comment that the URI is only used for local folders.
301 2007-05-11 Murray Cumming <murrayc@murrayc.com>
303 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
304 parameter const, just to be neat.
305 * src/modest-text-utils.c: (modest_text_utils_inline):
306 End g_strconcat() with NULL, as its documentation says. This is almost
307 certainly the cause of my crash at startup on the device. Interestingly,
308 valgrind doesn't tell us about these errors.
310 2007-05-11 Murray Cumming <murrayc@murrayc.com>
312 * scripts/build-packages: Added more precise comments about how to use
313 this script, though I still get this error:
314 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
315 error building tinymail
317 2007-05-11 Murray Cumming <murrayc@murrayc.com>
319 * src/maemo/modest-main-window.c: (on_account_update):
320 Very slight cleanup, hoping to make it simpler to discover what causes
321 a crash here sometimes.
323 * src/modest-tny-account.c:
324 (modest_tny_account_new_from_server_account): Set the port. Added
325 comments about the options and a TODO comment because I need to find out
326 how to specify the secure authentication method.
328 2007-05-11 Marcus Bauer <marcusb@openismus.com>
330 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
331 changed CFlags paths form modest to libmodest
333 2007-05-10 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-account-mgr-helpers.c:
336 (modest_account_mgr_get_server_account_data),
337 (modest_account_mgr_free_server_account_data):
338 * src/modest-account-mgr-helpers.h:
339 * src/modest-account-mgr.c:
340 (modest_account_mgr_add_server_account):
342 * src/modest-tny-account.c:
343 (modest_tny_account_new_from_server_account):
344 Determine the options for tny_camel_account_add_option() here,
345 based on the settings, rather than storing them directly in gconf.
347 2007-05-10 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
350 Show a more friendly error dialog now that we expect (from the tinymail
351 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
353 2007-05-10 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/modest-main-window.c: (on_account_update): Check that
356 account_name is not NULL, to prevent a crash at startup that I am
357 seeing on the N800. I do wonder why it is NULL.
359 * src/maemo/easysetup/modest-easysetup-wizard.c:
360 (create_page_user_details):
361 * src/maemo/modest-account-settings-dialog.c:
362 (create_page_user_details), (create_page_outgoing):
363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
364 (modest_connection_specific_smtp_edit_window_init):
365 * src/modest-ui-actions.c:
366 (modest_ui_actions_on_password_requested):
367 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
368 might do something useful with the on-screen keyboard.
370 2007-05-10 Murray Cumming <murrayc@murrayc.com>
372 * src/maemo/modest-main-window.c: (on_account_update):
373 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
374 NULL, to avoid lots of warnings. However, it probably should not be NULL.
376 2007-05-09 Murray Cumming <murrayc@murrayc.com>
378 * src/modest-tny-account-store.c: (on_account_changed):
379 Correct the signature of this signal handler.
381 2007-05-09 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
384 Show a HildonNote instead of a GtkDialog for Maemo.
386 2007-05-09 Murray Cumming <murrayc@murrayc.com>
388 * src/widgets/modest-account-view.h:
389 * src/widgets/modest-account-view.c: (on_account_changed),
390 (on_account_removed). Added a boolean flag, set/unset by
391 modest_account_view_block_conf_updates(),
392 modest_account_view_unblock_conf_updates() to prevent unnecessary
393 updates, but this is not very useful because the gconf notifications are
394 so delays (maybe only on Maemo Bora).
395 So auto-updating is turned off, and these functions do an explicit
396 update when necessary.
397 However, something else is still doing too much work when adding/removing
398 accounts, probably in another part of the application.
400 * src/maemo/modest-account-view-window.c:
401 (on_delete_button_clicked), (on_edit_button_clicked),
402 (on_new_button_clicked): Use the new functions.
404 2007-05-09 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-account-mgr-helpers.c:
407 (modest_account_mgr_set_first_account_as_default):
408 Sort the list of names alphabetically-by-title, so we choose the first one
410 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
411 alphabetically by the title.
413 This fixes projects.maemo.org bug NB#56418 .
415 * src/modest-account-mgr-priv.c:
416 (_modest_account_mgr_account_from_key):
417 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
418 avoid a valgrind error, and possible random behaviour.
420 2007-05-09 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
423 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
424 tinymail documentation to say that this can be expected.
425 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
426 pretty, and should not happen, but I would prefer to know when it does.
428 2007-05-09 Murray Cumming <murrayc@murrayc.com>
430 * configure.ac: When using the older hildon version, probably on Bora,
431 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
433 * src/widgets/modest-attachment-view.c:
434 (modest_attachment_view_set_part_default): Initialize variables, to fix the
437 2007-05-09 Marcus Bauer <marcusb@openismus.com>
439 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
440 Implemented the prototype. Can be tested with
441 tests/dbus_api/test_open_message:
443 2007-05-08 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-tny-account-store.c:
446 (modest_tny_account_store_instance_init), (get_password):
447 * src/modest-ui-actions.c:
448 (modest_ui_actions_on_password_requested):
449 Do not store the password in gconf, because this function is called
450 for non-remembered passwords. Actually use the cached (in the hash map)
451 password instead of releasing it.
452 The password will now not be remembered if it is asked via the protected
453 password dialog, as per the UI spec.
455 2007-05-08 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-account-mgr-helpers.h:
459 * src/modest-account-mgr-helpers.c:
460 Added modest_server_account_get_username_has_succeeded(),
461 modest_server_account_set_username_has_succeeded().
462 (modest_server_account_set_username),
463 Reset the has-succeeded flag if the username changes.
465 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
466 * src/maemo/modest-connection-specific-smtp-window.c:
467 (modest_connection_specific_smtp_window_save_server_accounts):
468 Use modest_server_account_set_username() instead of using
469 modest_conf_set_string() directly, so that the has-succeeded flag is always
472 * src/modest-ui-actions.c:
473 (modest_ui_actions_on_password_requested): Dim the username entry if
474 the username has ever worked, as per the UI spec.
476 2007-05-08 Murray Cumming <murrayc@murrayc.com>
478 * src/modest-tny-account-store.c: (get_password):
479 * src/modest-ui-actions.c:
480 (modest_ui_actions_on_password_requested):
481 Allow the username to be changed too, though there is more work to
482 be done on exactly how this behaves.
484 2007-05-08 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-account-mgr-helpers.h:
487 * src/modest-account-mgr-helpers.c:
488 Added modest_account_mgr_get_display_name(),
489 modest_server_account_get_username(),
490 modest_server_account_set_username(),
491 modest_server_account_set_password(),
492 modest_server_account_get_hostname() functions so we do not need to
493 use the conf API directly.
495 * src/maemo/modest-main-window.c: (connect_signals):
496 Actually connect ot the ModestAccountStore::request-password signal,
497 so that we show the dialog when the password is requested by Tinymail,
498 for isntance if it is empty.
500 * src/modest-marshal.list:
501 * src/modest-tny-account-store.c:
502 (modest_tny_account_store_class_init), (get_password),
503 (modest_tny_account_store_alert):
504 * src/modest-tny-account-store.h:
505 * src/modest-ui-actions.h:
506 * src/modest-ui-actions.c:
507 (modest_ui_actions_on_password_requested):
508 Change the signal parameters, so it is obvious that we are providing
509 the non human-readable server name, and receiving both the username
510 and password, though changing of the username is not yet implemented.
511 Change the dialog UI to match the Maemo UI specifications, with #idfefing
512 for the GNOME version.
514 This should fix the projects.maemo.org bug NB#56209, though it does not
515 work on Bora, because the gconf_client_get() for the password fails
516 immediately after we save it with gconf_client_set().
518 2007-05-08 Murray Cumming <murrayc@murrayc.com>
521 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
522 caused an undefined symbol error:
523 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
525 2007-05-08 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-tny-account-store.c:
528 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
529 using a GError instead of a string message, so we can translate it in
532 2007-05-08 Murray Cumming <murrayc@murrayc.com>
534 * src/maemo/modest-address-book.c:
535 (modest_address_book_check_names):
536 * src/maemo/modest-msg-view-window.c:
537 (modest_msg_view_window_clipboard_owner_change):
538 * src/modest-init.c: (modest_init_init_ui):
539 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
540 (update_folders_cb), (modest_mail_operation_update_account):
541 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
542 (modest_ui_actions_on_msg_attachment_clicked),
543 (modest_ui_actions_on_msg_recpt_activated):
544 * src/widgets/modest-header-view.c: (drag_data_get_cb):
545 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
546 (modest_msg_view_search_next):
547 * src/widgets/modest-recpt-editor.c:
548 (modest_recpt_editor_on_button_release_event),
549 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
550 g_message(). At this point we should only be seeing interesting errors on
551 stdout. Debugging messages could be #ifdefed-out if they are still useful.
553 2007-05-07 Murray Cumming <murrayc@murrayc.com>
555 (modest_wizard_dialog_force_title_update):
556 * src/maemo/easysetup/modest-wizard-dialog.h:
557 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
558 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
559 can update the title when appropriate. Otherwise the title is wrong if the
560 pages are added after adding the notebook to the dialog.
561 This must be a problem in HildonWizardDialog too.
562 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
564 * src/maemo/easysetup/modest-easysetup-wizard.c:
565 (create_subsequent_customsetup_pages),
566 (create_subsequent_easysetup_pages):
567 Call modest_wizard_dialog_force_title_update() so that the title is
568 correct even with GTK+ < 2.10.
569 This fixes projects.maemo.org bug NB#56145 .
571 2007-05-07 Murray Cumming <murrayc@murrayc.com>
573 * src/maemo/modest-platform.c:
574 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
575 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
578 2007-05-07 Murray Cumming <murrayc@murrayc.com>
580 * src/widgets/modest-window.h:
581 * src/widgets/modest-window.c: Added a save_state_func vfunc,
582 and modest_window_save_state(), which invokes it.
584 * src/widgets/modest-window-mgr.h:
585 * src/widgets/modest-window-mgr.c:
586 Added modest_window_mgr_save_state_for_all_windows(), which calls
587 the save_state vfunc on all registered windows, if implemented.
589 * src/gnome/modest-msg-edit-window.c:
590 * src/gnome/modest-msg-view-window.c:
591 * src/maemo/modest-msg-edit-window.c:
592 * src/maemo/modest-msg-view-window.c:
593 * src/maemo/modest-main-window.c:
594 Specify the existing save_settings functions as implementations of
595 ModestWindow::save_state_func().
597 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
598 Call modest_window_mgr_save_state_for_all_windows(). This happens before
599 enabling hibernation, for instance.
601 We may need to do the same thing for restoring settings.
604 2007-05-07 Murray Cumming <murrayc@murrayc.com>
606 * src/widgets/modest-window-mgr.c:
607 * src/widgets/modest-window-mgr.h:
608 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
609 modest_window_mgr_get_hibernation_is_prevented().
611 * src/maemo/modest-main-window.c:
612 (on_hildon_program_is_topmost_notify): Prevent hibernation
613 (possible when the application goes to the background in the WM),
614 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
616 * src/maemo/easysetup/modest-easysetup-wizard.c:
617 (modest_easysetup_wizard_dialog_init):
618 * src/maemo/modest-account-settings-dialog.c:
619 (modest_account_settings_dialog_init):
620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
621 (modest_connection_specific_smtp_edit_window_init):
622 * src/maemo/modest-connection-specific-smtp-window.c:
623 (modest_connection_specific_smtp_window_init):
624 * src/maemo/modest-signature-editor-dialog.c:
625 (modest_signature_editor_dialog_init):
626 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
627 prevent hibernation while any of these account settings dialogs are open.
629 2007-05-04 Murray Cumming <murrayc@murrayc.com>
631 * src/maemo/Makefile.am:
632 * src/maemo/modest-osso-state-saving.c:
633 * src/maemo/modest-osso-state-saving.h: Added
634 modest_osso_load_state() and modest_osso_save_state() though they do
635 nothing now. They should iterate through all the open windows and load/save
637 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
638 save state when closing.
640 * src/maemo/modest-main-window.c:
641 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
642 Add a notification handler for the HildonProgram::is-topmost property,
643 so we can allow hibernation when the application goes into the background.
644 But we still need to detect when the accounts setup windows are open so
645 we can stop hibernation when they are open.
646 To do this, I also added the main window the HildonProgram. This might have
647 other side-effects/benefits, and should maybe be done for other windows.
649 * src/maemo/modest-osso-autosave-callbacks.h:
650 * src/maemo/modest-osso-autosave-callbacks.c:
651 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
652 though it does not do anything yet, and we might never need this to do
653 anything. For instance, we already save drafts.
655 * src/maemo/modest-platform.c: (modest_platform_init):
656 Specify the libosso auto-save callback.
658 2007-05-03 Murray Cumming <murrayc@murrayc.com>
660 * src/maemo/modest-platform.c:
661 (modest_platform_set_update_interval):
662 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
663 aparently stays valid between application instances, so we can use this
664 to remove and reset it later. According to a maemo-developers email from
667 2007-05-03 Murray Cumming <murrayc@murrayc.com>
669 * configure.ac: Depend on libalarm for Maemo.
671 * src/dbus_api/modest-dbus-api.h:
672 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
673 (on_send_receive), (modest_dbus_req_handler):
674 Handle a SEND_RECEIVE D-Bus method.
676 * libmodest-dbus-client/libmodest-dbus-client.c:
677 (libmodest_dbus_client_send_and_receive):
678 * libmodest-dbus-client/libmodest-dbus-client.h:
679 Add C convenience functions for calling the new D-Bus method.
681 * src/modest-platform.h:
682 * src/gnome/modest-platform.c:
683 * src/maemo/modest-platform.c:
684 Added modest_platform_set_update_interval(), which uses the
686 (modest_platform_init),
687 Call modest_platform_set_update_interval(), using a hard-coded
688 interval for now (until the global settings dialog is implemented),
689 though I am not sure that this makes sense yet.
691 2007-05-02 Murray Cumming <murrayc@murrayc.com>
693 * src/dbus_api/modest-dbus-callbacks.c:
694 (modest_osso_cb_hw_state_handler):
695 * src/dbus_api/modest-dbus-callbacks.h:
696 * src/maemo/modest-platform.c: (modest_platform_init):
697 Registered (empty) callbacks for the osso hardware state D-Bus signals,
698 in case this has some effect on the ability for Maemo to ping the
701 2007-05-02 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
704 Comment out an if() that checks a gchar for < 0, causing a build-breaking
705 warning. It is probably a logic error, but I need to fix the build.
707 2007-05-02 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-account-mgr.h:
710 * src/modest-account-mgr.c:
711 (modest_account_mgr_account_names): Add a gboolean enabled_only
712 parameter, so we can get lists of onlt the enabled accounts.
714 (modest_account_mgr_add_account),,
715 (modest_account_mgr_account_with_display_name_exists):
716 * src/maemo/modest-msg-edit-window.c: (get_transports):
717 * src/modest-account-mgr-helpers.c:
718 (modest_account_mgr_set_first_account_as_default):
719 * src/modest-init.c: (init_default_account_maybe):
720 * src/modest-tny-account-store.c: (get_accounts):
721 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
722 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
723 * tests/check_account-mgr.c: (START_TEST):
724 Provide the extra parameter, as appropriate.
726 * src/widgets/modest-account-view.c: (update_account_view):
727 Do not show disabled accounts (meaning that there is no way to
728 enable/disable accounts in the UI (the feature is not in our UI
729 specification), so we can use this internally only to mark unfinished
730 or temporary account data.
732 * src/maemo/easysetup/modest-easysetup-wizard.c:
733 (create_account): Add boolean enable parameter, so we can specify FALSE
734 to create the temporary account.
735 (on_button_edit_advanced_settings): Create the temporary account as disabled.
736 (on_before_next): When finishing, when there is a temporary account, just
738 Also, use a timeout to delay the showing of the dialog until gconf is likely
739 to return correct information, due to a maemo gconf bug that is fixed in
740 osso 1.1, but not yet in Bora.
741 However, the dialog stays on screen after it is destroyed.
743 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
744 for invalid data when cancelling. Use a hildon note instead of a dialog
745 to complain about invalid data. Do not show the account-saved note if the
746 account is disabled (a temporary account that will not really be saved for use
749 2007-04-30 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-account-mgr-helpers.h:
752 * src/modest-account-mgr-helpers.c:
753 Added modest_account_mgr_unset_default_account(),
754 Added modest_account_mgr_set_first_account_as_default().
756 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
757 If it was the default account, unset the default account name.
759 * src/maemo/modest-account-view-window.c:
760 (on_delete_button_clicked): If it was the default account,
761 set the first remaining account as the default instead.
763 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
764 a NULL account or a NULL default account, to prevent a crash. This should
765 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
768 2007-04-30 Murray Cumming <murrayc@murrayc.com>
770 * src/widgets/modest-recpt-editor.c:
771 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
772 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
773 TODO comment for this. This fixes the build.
775 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
776 be the best place for it. This will in future update all auto-update accounts,
777 rather than just the current/default account, when that gconf key exists.
778 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
779 if there are no accounts, before calling do_send_receive().
780 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
782 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
783 * src/maemo/modest-main-window-ui.h:
784 * src/maemo/modest-main-window.c: (on_connection_changed),
785 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
786 directly, becaue the signal handler does more.
788 2007-04-30 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-account-mgr-helpers.c:
791 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
792 for the case that the account does not exist.
794 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
795 (equivalent to the modest account name) rather than the tinymail account name
796 (equivalent to the modest account title - human readable) to get the account data.
797 Check for null account data to prevent the crash, and add a TODO comment saying that
798 this needs fixing because it is using the server account name instead of the account name.
800 2007-04-29 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
803 * src/maemo/modest-account-settings-dialog.c: (show_error),
805 Use hildon_note_new_information() for informative and error messages,
806 which seems to be expected for Maemo applications (no documentation that I know of
807 says this). I am surprised that there is no distinction between info and error
810 2007-04-29 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
813 it is easy to find where this is used.
815 * src/maemo/easysetup/modest-easysetup-wizard.c:
816 (create_page_welcome), (create_page_account_details),
817 (create_page_user_details), (create_page_complete_easysetup),
818 (create_page_custom_incoming), (create_page_custom_outgoing),
819 (create_page_complete_custom):
820 * src/maemo/modest-account-settings-dialog.c:
821 (create_page_account_details), (create_page_user_details),
822 (create_page_incoming), (create_page_outgoing):
823 * src/maemo/modest-account-view-window.c: (window_vbox_new):
824 * src/maemo/modest-connection-specific-smtp-edit-window.c:
825 (modest_connection_specific_smtp_edit_window_init):
826 * src/maemo/modest-connection-specific-smtp-window.c:
827 (modest_connection_specific_smtp_window_init):
828 * src/maemo/modest-signature-editor-dialog.c:
829 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
830 and scrolling policy as per the Email Application Layout Guide, if I have
833 2007-04-27 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
836 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
837 which were empty, because these vfuncs have been removed from TnyAccountStore.
838 This fixes the build.
840 2007-04-27 Murray Cumming <murrayc@murrayc.com>
842 * src/maemo/modest-main-window.c:
843 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
844 showing/hiding it. Added TODO because it probably should not be NULL.
845 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
846 because unnecessary g_warnings() make degugging difficult.
848 2007-04-27 Murray Cumming <murrayc@murrayc.com>
850 * src/maemo/modest-msg-edit-window.c:
851 (modest_msg_edit_window_select_color),
852 (modest_msg_edit_window_select_background_color): 2 const corrections and
853 moving 2 #endifs before closing brackets, to fix the build.
855 2007-04-27 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/easysetup/modest-easysetup-wizard.h:
858 * src/maemo/easysetup/modest-easysetup-wizard.c:
859 (modest_easysetup_wizard_dialog_finalize),
860 (on_button_edit_advanced_settings), (create_page_complete_custom),
861 (on_response), (create_account):
862 Implement the Advanced Settings edit button, by saving the account information,
863 for the Advanded Settings dialog to use directly from gconf, and removing it
864 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
865 Bug #5533 in the projects.maemo.org bugzilla.
867 2007-04-27 Murray Cumming <murrayc@murrayc.com>
869 * src/maemo/modest-msg-view-window.c:
870 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
871 when opening a message window.
873 2007-04-27 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/easysetup/modest-easysetup-wizard.c:
876 (create_page_custom_outgoing): Correct the position of the horizontal separator to
879 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
880 before showing/hiding them, to avoid a crash when clicking on folders when there are no
881 gconf settings. I probably added more checks than necessary, but that is safer.
883 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
884 variable to fix the build, but this seems to be used when it is still NULL.
886 2007-04-27 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-platform.h:
889 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
890 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
891 * src/modest-main.c: Implement this function so we can avoid using
892 maemo-specific API from cross-platform code.
894 * src/modest-tny-account-store.c:
895 (get_smtp_specific_transport_account_for_open_connection):
896 * src/modest-ui-actions.c: (check_for_connection),
897 (modest_ui_actions_on_item_not_found):
898 Use modest_platform_connect_and_wait() and put #idefs around other
899 maemo-specific code, because only maemo currently has a way to
900 identify connection names.
902 2007-04-27 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-tny-account-store.h:
905 * src/modest-tny-account-store.c:
906 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
907 the connection-specific SMTP server settings in the configuration.
909 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
911 * src/maemo/modest-main-window.c: (on_connection_changed),
913 * src/modest-main.c: (main), (start_ui), (send_mail):
914 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
915 that is what is intended.
917 * src/modest-ui-actions.c: (action_send), (action_receive),
918 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
919 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
920 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
921 SMTP server is used when it is specified.
923 (modest_ui_actions_on_send_receive):
924 Check that a connection is open before proceeding.
925 Receive and then send, instead of vice-versa, as per the specification.
927 2007-04-26 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-mail-operation.c:
930 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
931 though I guess it should be something other than NULL.
933 2007-04-26 Murray Cumming <murrayc@murrayc.com>
935 * src/maemo/easysetup/modest-easysetup-wizard.c:
936 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
937 combo twice, to avoid an g_warning and to make it visible again.
938 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
939 attached before detaching it, to avoid a g_warning, and add comment about the implicit
940 (already intended) dereference when detaching, because we then recreate the menu.
941 But I am not sure why the warning was happening, and it is possible that this is a memory
944 2007-04-25 Murray Cumming <murrayc@murrayc.com>
946 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
947 and uri_parse_mailto() utility functions.
948 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
950 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
952 2007-04-24 Murray Cumming <murrayc@murrayc.com>
954 * src/dbus_api/modest-dbus-api.h:
955 * src/dbus_api/modest-dbus-callbacks.c:
956 Use an idle callback to execute the modest code in the application's own thread.
957 Remove the helloworld example method.
958 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
959 parsed, and the open-message method is not implemented because this is not yet implemented in
961 * libmodest-dbus-client/libmodest-dbus-client.c:
962 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
963 (libmodest_dbus_client_open_message):
964 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
966 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
967 body without crashing.
969 * tests/dbus_api/Makefile.am:
970 * tests/dbus_api/test_mail_to.c:
971 * tests/dbus_api/test_open_message.c: New tests for the new methods.
973 2007-04-24 Murray Cumming <murrayc@murrayc.com>
975 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
976 Added file to fix the build. Sorry.
978 * src/dbus_api/Makefile.am:
979 * src/dbus_api/modest-dbus-api.h:
980 * src/dbus_api/modest-dbus-callbacks.h:
981 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
982 (modest_dbus_req_handler):
983 Put constants in a separate header so it can be reused by the
984 client library, without duplication
986 * libmodest-dbus-client/Makefile.am:
987 * libmodest-dbus-client/libmodest-dbus-client.c:
988 (libmodest_dbus_client_call_helloworld),
989 (libmodfest_dbus_client_send_mail),
990 (libmodfest_dbus_client_mailto),
991 (libmodfest_dbus_client_open_message):
992 * libmodest-dbus-client/libmodest-dbus-client.h:
993 (Partly) Implement a send_mail D-Bus method.
995 * tests/dbus_api/Makefile.am:
996 * tests/dbus_api/test_send_mail.c: (main): Added a test for
997 the send_email D-Bus method.
999 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1003 * libmodest-dbus-client/Makefile.am:
1004 * libmodest-dbus-client/libmodest-dbus-client.c:
1005 * libmodest-dbus-client/libmodest-dbus-client.h:
1006 * tests/dbus_api/Makefile.am:
1007 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1008 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1010 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1012 * src/maemo/easysetup/modest-easysetup-wizard.c:
1013 (create_page_account_details):
1014 * src/maemo/modest-account-settings-dialog.c:
1015 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1016 widgets, because this might not be the default in future versions of the Maemo GTK+.
1017 However, I can not not get capitalization to work even in a simple test case.
1019 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/easysetup/modest-easysetup-wizard.c:
1022 (create_page_custom_incoming), (create_page_custom_outgoing):
1023 * src/maemo/modest-account-settings-dialog.c:
1024 (create_page_account_details), (create_page_incoming),
1025 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1026 instead of using gtk_check_button_with_label(), so they are aligned like the other
1027 widgets, as per the UI spec.
1029 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1031 * src/maemo/easysetup/modest-easysetup-wizard.c:
1032 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1033 * src/widgets/modest-validating-entry.c:
1034 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1035 Modest prefix instead of an EasySetup prefix.
1037 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1039 * src/widgets/modest-validating-entry.h:
1040 * src/widgets/modest-validating-entry.c: (on_insert_text),
1041 Added easysetup_validating_entry_set_max_func(), used to set a callback
1042 to call when the max number of characters is reached. GtkEntry has a max-length
1043 already but is silent about it.
1045 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1046 (create_page_account_details), (create_page_user_details),
1048 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1049 (create_page_account_details), (create_page_user_details),
1050 (create_page_outgoing):
1051 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1052 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1053 the UI spec, when the user tries to enter more than the max number of characters.
1055 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/easysetup/modest-easysetup-wizard.c:
1058 (create_page_user_details), (create_page_custom_incoming),
1059 (create_page_custom_outgoing):
1060 * src/maemo/modest-account-settings-dialog.c:
1061 (create_page_user_details), (create_page_incoming),
1062 (create_page_outgoing):
1063 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1064 (modest_connection_specific_smtp_edit_window_init):
1065 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1066 not appropriate. Bad Maemo-specific defaults!.
1068 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1071 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1072 (modest_signature_editor_dialog_set_settings):
1073 Disable the label and textview when the checkbox is disabled, and use the
1074 specified (UI spec) default signature text.
1076 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1079 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1081 * src/modest-defs.h:
1082 * src/modest-account-mgr-helpers.h:
1083 * src/modest-account-mgr-helpers.c:
1084 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1086 * src/maemo/Makefile.am:
1087 * src/maemo/modest-signature-editor-dialog.c:
1088 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1091 * src/maemo/modest-account-settings-dialog.h:
1092 * src/maemo/modest-account-settings-dialog.c:
1093 (modest_account_settings_dialog_finalize), (on_button_signature),
1094 (save_configuration): Use the new dialog when the Edit button is pressed, and
1095 save the changes if necessary, as per the UI spec.
1097 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/Makefile.am:
1100 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1101 based on maemo-develoers email from Dirk.
1103 * src/maemo/easysetup/modest-easysetup-wizard.c:
1104 (create_page_welcome), (create_page_account_details),
1105 (create_page_user_details), (create_page_complete_easysetup),
1106 (create_page_custom_incoming), (create_page_custom_outgoing),
1107 (create_page_complete_custom),
1108 (modest_easysetup_wizard_dialog_init):
1109 * src/maemo/modest-account-settings-dialog.c:
1110 (create_page_account_details), (create_page_user_details),
1111 (create_page_incoming), (create_page_outgoing),
1112 (modest_account_settings_dialog_init):
1113 * src/maemo/modest-connection-specific-smtp-window.c:
1114 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1116 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/easysetup/modest-easysetup-wizard.c:
1119 (create_page_account_details), (create_page_custom_outgoing),
1120 (create_page_complete_custom):
1121 * src/maemo/modest-account-settings-dialog.c:
1122 (create_page_user_details), (create_page_incoming),
1123 (create_page_outgoing):
1124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1125 (modest_connection_specific_smtp_edit_window_init):
1126 Use the correct (UI spec) port min/max, and use horizontal separators,
1129 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1131 * src/maemo/easysetup/modest-easysetup-wizard.c:
1132 (set_default_custom_servernames):
1133 * src/maemo/modest-account-settings-dialog.c:
1134 (create_page_incoming), (on_combo_outgoing_security_changed),
1135 (on_combo_incoming_security_changed), (create_page_outgoing),
1136 (modest_account_settings_dialog_set_account_name),
1137 (save_configuration):
1138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1139 (on_combo_security_changed),
1140 (modest_connection_specific_smtp_edit_window_init),
1141 (modest_connection_specific_smtp_edit_window_set_connection),
1142 (modest_connection_specific_smtp_edit_window_get_settings):
1143 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1146 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1149 * src/maemo/easysetup/modest-easysetup-wizard.c:
1150 (create_page_custom_outgoing), (create_page_complete_custom):
1151 * src/maemo/modest-account-settings-dialog.c:
1152 (create_page_user_details), (create_page_outgoing):
1153 * src/maemo/modest-account-view-window.c: (button_box_new):
1154 Use changed logical IDs as per the most recent UI spec:
1155 mcen_bd_emailsetup_edit -> mcen_bd_edit
1156 mcen_bd_emailsetup_delete -> mcen_bd_delete
1157 mcen_bd_emailsetup_close -> mcen_bd_close
1159 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1163 * src/dbus_api/Makefile.am:
1164 * src/dbus_api/modest-dbus-callbacks.c:
1165 * src/dbus_api/modest-dbus-callbacks.h:
1166 * src/maemo/modest-platform.c: (modest_platform_init):
1167 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1169 * tests/Makefile.am:
1170 * tests/dbus_api/Makefile.am:
1171 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1173 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1175 * src/maemo/modest-account-settings-dialog.c:
1176 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1177 Removed unnecessary includes.
1179 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/easysetup/modest-easysetup-wizard.c:
1182 * src/maemo/modest-account-settings-dialog.c:
1183 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1184 * src/widgets/Makefile.am:
1185 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1186 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1187 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1188 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1189 * src/widgets/modest-secureauth-combo-box.c:
1190 * src/widgets/modest-secureauth-combo-box.h:
1191 * src/widgets/modest-serversecurity-combo-box.c:
1192 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1193 made the GObject names more consistent with the rest of the Modest code.
1195 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1197 * src/maemo/easysetup/Makefile.am:
1198 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1199 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1200 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1201 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1202 * src/maemo/easysetup/modest-easysetup-wizard.c:
1203 * src/maemo/easysetup/modest-validating-entry.c:
1204 * src/maemo/easysetup/modest-validating-entry.h:
1205 * src/maemo/modest-account-settings-dialog.c:
1206 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1207 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1208 widgets/ because they are used outside of easysetup too. After checking in,
1209 svn will allow me to rename them too.
1211 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1213 * src/gnome/modest-msg-edit-window.c:
1214 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1215 linker error, to fix the build on the GNOME platform.
1216 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1217 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1218 ifdefed out to avoid a warning.
1220 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1222 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1223 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1224 some alternative for GTK+ 2.6.
1226 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1230 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1231 specified for EmailAccountsDialog in UI spec.
1233 * src/maemo/easysetup/modest-easysetup-wizard.c:
1234 * src/maemo/easysetup/modest-easysetup-wizard.h:
1235 * src/maemo/modest-account-settings-dialog.c:
1236 * src/maemo/modest-account-settings-dialog.h:
1237 Reuse a member window widget for the connection-specific SMTP server accounts,
1238 so we can tell it to create/save the accounts only if we actually save changes.
1240 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1241 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1242 (modest_connection_specific_smtp_edit_window_get_settings):
1243 Return a struct instance for temporarily remembering the entered data.
1245 * src/maemo/modest-connection-specific-smtp-window.h:
1246 * src/maemo/modest-connection-specific-smtp-window.c:
1247 (modest_connection_specific_smtp_window_finalize),
1248 (modest_connection_specific_smtp_window_fill_with_connections),
1250 (modest_connection_specific_smtp_window_save_server_accounts),
1251 (update_model_server_names): Do not actually save data until asked,
1252 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1254 (on_selection_changed),
1255 (modest_connection_specific_smtp_window_init): Disable the edit
1256 button when nothing is selected.
1258 * src/modest-account-mgr-helpers.c:
1259 * src/modest-account-mgr-helpers.h:
1260 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1263 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-account-mgr-helpers.h:
1266 * src/modest-account-mgr-helpers.c:
1267 (modest_account_mgr_get_unused_account_name),
1268 (modest_account_mgr_get_unused_account_display_name): Added these
1269 utility functions, to avoid code duplication.
1271 * src/maemo/easysetup/modest-easysetup-wizard.c:
1272 (create_page_account_details), (create_account):
1273 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1274 (on_combo_security_changed),
1275 (modest_connection_specific_smtp_edit_window_init),
1276 (modest_connection_specific_smtp_edit_window_save_settings):
1277 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1278 * src/maemo/modest-connection-specific-smtp-window.c:
1279 (modest_connection_specific_smtp_window_finalize),
1280 (modest_connection_specific_smtp_window_fill_with_connections),
1281 (on_button_edit), (modest_connection_specific_smtp_window_init):
1282 * src/maemo/modest-connection-specific-smtp-window.h:
1283 Implementing saving of connection-specific server accounts.
1285 But I need to refactor this so we can save the data for each
1286 possible connection-specific account and only actually create the server accounts
1287 when the easysetup finished, or the OK button is pressed on the account settings
1290 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1292 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1293 (on_combo_security_changed):
1294 (modest_connection_specific_smtp_edit_window_init):
1295 Auto-fill the port number as in the account settings.
1297 (modest_connection_specific_smtp_edit_window_set_connection):
1298 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1299 * src/maemo/modest-connection-specific-smtp-window.c:
1300 (fill_with_connections), (on_button_edit),
1301 (modest_connection_specific_smtp_window_init):
1302 Turn the edit window into a dialog to simplify the code, and
1303 set a WM hint as in a GtkDialog, because only a popup can be on top of
1304 another window in Maemo, and popups usually have no WM decoration.
1306 * src/modest-defs.h:
1307 * src/modest-account-mgr-helpers.c:
1308 (modest_account_mgr_set_connection_specific_smtp),
1309 (modest_account_mgr_remove_connection_specific_smtp),
1310 (modest_account_mgr_get_connection_specific_smtp):
1311 * src/modest-account-mgr-helpers.h: Some functions to write the
1312 connection-specific SMTP server information. Not yet used.
1315 * src/widgets/modest-folder-view.c: (text_cell_data):
1316 Fix a warning about an uninitialized variable.
1317 (on_configuration_key_changed): Put an #ifdef around the use
1318 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1320 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1322 * src/maemo/modest-account-settings-dialog.h:
1323 * src/maemo/modest-account-settings-dialog.c:
1324 Added connect_for_modified() utility function to mark the new modified boolean.
1326 (create_page_account_details), (create_page_user_details),
1327 (create_page_incoming), (create_page_outgoing), (on_response),
1328 (modest_account_settings_dialog_init),
1329 (modest_account_settings_dialog_set_account_name):
1330 Only warn about unsaved changes when there are actually unsaved changes.
1332 * src/modest-account-mgr-helpers.c:
1333 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1334 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1335 to get the data from there in future.
1337 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-defs.h:
1341 * src/modest-account-mgr-helpers.h:
1342 * src/modest-account-mgr-helpers.c:
1343 Store the security account setting in a single conf key instead of using
1344 the options list, so that the list is left for just the to-be-removed camel hack,
1345 and because gconf_client_set_list() is failing for some reason.
1347 * src/modest-account-mgr.c:
1348 (modest_account_mgr_add_server_account):
1349 * src/maemo/modest-account-settings-dialog.c:
1350 (modest_account_settings_dialog_set_account_name),
1351 (save_configuration): Use the renamed functions.
1354 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1356 * src/widgets/Makefile.am:
1357 * src/widgets/modest-limit-retrieve-combo-box.c:
1358 * src/widgets/modest-limit-retrieve-combo-box.h:
1359 * src/widgets/modest-retrieve-combo-box.c:
1360 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1361 the account settings dialog.
1363 * src/modest-defs.h:
1364 * src/modest-account-mgr-helpers.h:
1365 * src/modest-account-mgr-helpers.c:
1366 (modest_server_account_get_option_secure_auth),
1367 (modest_server_account_set_option_secure_auth):
1368 * src/modest-account-mgr.c:
1369 (modest_account_mgr_add_server_account):
1370 Use the existing AUTH_MECH conf key for the secure-auth setting,
1371 instead of putting it in the list options, because this was actually used already.
1373 * src/maemo/modest-account-settings-dialog.c:
1374 (create_page_account_details),
1375 (modest_account_settings_dialog_set_account_name),
1376 (save_configuration):
1377 * src/maemo/modest-account-settings-dialog.h:
1378 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1379 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1381 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1384 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1385 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1387 * src/modest-defs.h:
1388 * src/maemo/modest-account-settings-dialog.c:
1389 (create_page_incoming), (on_combo_outgoing_security_changed),
1390 (on_combo_incoming_security_changed), (create_page_outgoing),
1391 (modest_account_settings_dialog_set_account_name),
1392 (save_configuration): Load/Save the port number, and change it when the
1393 security combo changes, to suitable defaults.
1395 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1397 * src/modest-account-mgr.c:
1398 (modest_account_mgr_add_server_account): Set the security and secure-auth
1399 options, and add a comment saying that the other camel-specific options should be
1402 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1404 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1406 * src/modest-tny-account-store.c: (account_list_free),
1407 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1408 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1411 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1413 * src/modest-protocol-info.c:
1414 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1415 is required by our UI spec. Maybe something in our implementation will use this eventually.
1416 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1417 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1418 instead of the previous 0 placeholder.
1420 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1421 secure-auth settings.
1422 * src/modest-account-mgr-helpers.h:
1423 * src/modest-account-mgr-helpers.c:
1424 (modest_server_account_data_get_option_secure_auth),
1425 (modest_server_account_set_option_secure_auth),
1426 (modest_server_account_data_get_option_security),
1427 (modest_server_account_set_option_security): Added this API for getting and setting the security
1428 and secure-auth settings.
1430 * src/maemo/modest-account-settings-dialog.h:
1431 * src/maemo/modest-account-settings-dialog.c:
1432 (modest_account_settings_dialog_finalize), (check_data),
1433 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1434 about changing titles.
1435 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1436 (save_configuration): Save the security and secure-auth settings.
1438 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1439 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1441 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-defs.h:
1444 * src/modest-account-mgr.c:
1445 (modest_account_mgr_add_server_account):
1446 Added and used defines for the options key and value pair strings,
1447 that are used so far, though they do not seem to correspond to anything in our
1448 UI specs or ModestProtocol enum.
1450 * src/modest-account-mgr-helpers.h:
1451 * src/modest-account-mgr-helpers.c:
1452 (compare_option_strings_for_name),
1453 (modest_server_account_data_get_option_value),
1454 (modest_server_account_data_get_option_bool),
1455 (modest_account_mgr_get_server_account_option):
1456 Added helper functions for parsing the options GSList.
1458 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1461 display name is based on the supplied account name.
1462 * src/modest-account-mgr.c:
1463 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1464 with an inefficient, but good-enough, implementation.
1466 * src/maemo/easysetup/modest-easysetup-wizard.c:
1467 (create_page_account_details), (on_before_next), (create_account):
1468 Check for existing display names rather than (non-user-visible) account names, and just
1469 create and set a unique account name at the end.
1471 * src/maemo/modest-account-settings-dialog.c:
1472 (modest_account_settings_dialog_init),
1473 (modest_account_settings_dialog_set_account_name),
1474 (create_page_incoming): Show the display name, instead of the account name.
1475 (on_response): Do some (not all) extra checks, as in the UI spec.
1476 (save_configuration): Save the display name if it was changed.
1478 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1480 * po/en_GB.po: Added needed logical ID and translation.
1481 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1482 (init_view): Made the is-default column clicking work.
1484 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1487 * src/maemo/easysetup/Makefile.am:
1488 * src/maemo/easysetup/modest-easysetup-wizard.c:
1489 (modest_easysetup_wizard_dialog_init):
1490 * src/maemo/easysetup/provider-data-test.keyfile:
1491 * src/maemo/easysetup/provider-data.keyfile:
1492 Moved the provider data file to the new modest-providers-data package and used it from there.
1494 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1496 * src/modest-local-folder-info.c:
1497 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1498 N_() was already used on the static strings, but this just marks it for translation without
1499 using the translation.
1501 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1503 * src/maemo/modest-account-settings-dialog.c:
1504 (create_page_incoming),
1505 (modest_account_settings_dialog_set_account_name):
1506 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1507 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1508 I will do this if nobody else gets there first.
1510 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1513 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1514 save the security stuff.
1516 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1518 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1519 Set the email address and user fullname, which I now see must be
1522 * src/maemo/modest-account-settings-dialog.h:
1523 * src/maemo/modest-account-settings-dialog.c:
1525 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1526 leave-on-server and authentication.
1527 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1530 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/modest-account-settings-dialog.c:
1534 * src/maemo/modest-account-settings-dialog.h:
1535 Most (but not all) of the widgets are now present as specified by the UI spec.
1536 No changes are yet saved, and some details are not properly shown yet.
1538 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1540 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1542 * src/maemo/Makefile.am:
1543 * src/maemo/modest-account-settings-dialog.c:
1544 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1545 an existing account. Doesn't do much yet.
1547 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1548 Open the accounts settings dialog when Edit is clicked.
1550 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/easysetup/Makefile.am:
1553 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1555 * src/maemo/easysetup/modest-easysetup-wizard.c:
1556 (modest_easysetup_wizard_dialog_init):
1557 Try to get the source directory from the build system,
1558 instead of hard-coding "./" into the source code, when opening our local
1559 copies of the configuration files.
1560 But this still fails when opening the wizard from the Accounts window,
1561 maybe because the working directory seems to change at runtime.
1562 So the wizard will fail the second time unless you copy the files into their
1563 proper locations - see the stdout warnings for the paths.
1565 (create_page_account_details),(on_before_next):
1566 Check for existing non-server accounts instead of server accounts,
1567 so the default account name is useful again, and to prevent trying to
1570 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1571 Show the wizard when New is clicked.
1573 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1574 (init_view): Show the column headers, and show the columns that are
1575 specified in the UI specs. However, something in Maemo's GTK+ prevents
1576 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1577 change the default account. This is despite unsetting the special properties.
1579 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1581 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1582 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1583 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1584 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1585 to make that clearer.
1586 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1588 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-account-view-window.c:
1591 (modest_account_view_window_init),
1592 (modest_account_view_window_new):
1593 Use the same buttons as specified in the
1594 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1595 the existing widgets, which never had a chance of working.
1596 Put the ModestAccountView treeview in a scrolled window.
1597 Do not repeat the initialization in both _init() and _new().
1599 * src/widgets/modest-account-view.c: (update_account_view):
1600 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1601 this widget and window shows no accounts.
1603 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1605 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1607 * src/maemo/easysetup/modest-easysetup-wizard.c:
1608 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1609 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1610 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1613 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1614 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1615 accounts exist yet, as in the UI spec.
1617 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1619 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1621 * src/maemo/Makefile.am:
1622 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1623 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1624 New window for editing connection-specific smtp details.
1625 Not fully implemented.
1627 * src/maemo/modest-connection-specific-smtp-window.c:
1628 (modest_connection_specific_smtp_window_finalize) :
1629 unref the tree model.
1630 (on_button_edit): Show the edit window.
1632 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1634 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1637 * src/maemo/Makefile.am:
1638 * src/maemo/modest-connection-specific-smtp-window.c:
1639 * src/maemo/modest-connection-specific-smtp-window.h:
1640 New window for showing the list of connections, for connection-specific
1641 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1642 * src/maemo/easysetup/modest-easysetup-wizard.c:
1643 (create_page_custom_outgoing): Show the new window when the button is clicked.
1645 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1648 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1649 * src/maemo/modest-msg-edit-window.c:
1650 (modest_msg_edit_window_insert_image):
1651 * src/modest-conf.c: (modest_conf_key_escape):
1652 * src/modest-mail-operation.c:
1653 (modest_mail_operation_send_new_mail):
1654 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1655 (modest_ui_actions_on_new_account):
1656 * src/widgets/modest-attachment-view.c: (update_filename_request):
1657 * src/widgets/modest-mail-header-view.c:
1658 Corrected warnings that were breaking the build, by commenting out unused variables,
1659 and a function, and by including a header.
1661 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1663 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1664 so we can #ifdef around platform-specific code when necessary.
1665 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1666 to allow this to build for the GNOME platform too.
1668 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/easysetup/modest-easysetup-wizard.c:
1671 Added util_increment_name() and used it in create_page_account_details()
1672 to make sure that the default account name is always a new name.
1674 (modest_easysetup_wizard_dialog_init),
1675 (set_default_custom_servernames): Some minor memory management fixes.
1677 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-runtime.c: (init_i18n): Restored the translation
1682 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1683 are defined in config.h, and the translations are installed.
1685 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1686 is defined for translation.
1688 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1692 * src/maemo/easysetup/modest-easysetup-wizard.c:
1693 (modest_easysetup_wizard_dialog_init):
1694 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1695 Use realistic paths (though they should use $prefix generically) to the
1696 mcc_mapping and provider-data.keyfile files which might work when they
1697 are installed by the future version of the operator-wizard package,
1698 and then fallback to paths in our source code, with an explanatory
1701 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1705 * src/maemo/Makefile.am:
1706 * src/maemo/easysetup/: Added files from the previously-exernal
1707 osso-modest-easysetup.
1708 * src/maemo/modest-main-window-ui.h:
1709 * src/modest-ui-actions.c:
1710 * src/modest-ui-actions.h:
1711 Added modest_ui_actions_on_new_account() as a signal handler for the
1712 New Account menu item. It shows the easysetup wizard.
1713 * po/en_GB.po: Added additional needed logical IDs and translations.
1715 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1716 Apparently ChangeLog is not used for some vague Nokia legal reasons.