1 2007-06-03 Christian Kellner <ckellner@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 (modest_search_hit_list_free):
5 Make it save to call it with NULL.
7 * src/dbus_api/modest-dbus-callbacks.c:
9 Return full ModestSearchHits as the search result list not TnyHeader
10 since can't be around withouth the correspoding TnyFolder.
12 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
14 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
15 Added currently commented code to check for secure auth
17 * src/maemo/modest-account-settings-dialog.c: (on_response),
18 (save_configuration), (show_ok):
19 Fixed projects.maemo.org bugs NB #59248 and #59251
21 * src/maemo/modest-maemo-utils.c:
22 (on_camel_account_get_supported_secure_authentication_status),
23 (on_camel_account_get_supported_secure_authentication),
24 (modest_maemo_utils_get_supported_secure_authentication_methods):
25 * src/maemo/modest-maemo-utils.h:
26 Moved get_supported_secure_authentication() method here to be able
27 to use it from easysetup wizard.
29 * src/modest-pair.c: (on_pair_compare_as_string):
30 Should compare string with first part of pair and not
31 strcmp pairs which will crash.
33 * src/modest-protocol-info.c:
34 (modest_protocol_info_protocol_is_store):
35 * src/modest-protocol-info.h:
36 Added modest_protocol_info_get_auth_protocol_name()
38 2007-06-03 Armin Burgmeier <armin@openismus.com>
40 * src/modest-mail-operation.c:
41 (modest_mail_operation_get_msgs_full): Set priv->account also when
42 only retrieving a single message. This avoids a crash when canceling
45 (modest_mail_operation_notify_end): Do not explicitely remove the
46 operation from the queue but only emit the progress_changed signal.
47 The queue itself listens to that signal to remove the operation when
48 it is finished. This reduces coupling and removes a potential deadlock
49 when modest_mail_operation_notify_end() is called from the queue
50 itself. If that is a problem performance-wise, I would suggest to
51 implement a status-changed signal or something.
53 * src/modest-mail-operation-queue.c: Make sure to never call a
54 function from another file while the queue is locked. This (hopefully)
55 fixes another deadlock when exiting the application while retrieving
58 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
60 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
61 Fixed build if libogs is not available
63 2007-06-03 Christian Kellner <ckellner@openismus.com>
65 * libmodest-dbus-client/libmodest-dbus-client.h:
66 * libmodest-dbus-client/libmodest-dbus-client.c:
67 (libmodest_dbus_client_delete_message):
68 Implement deletion of messages (Client side).
70 (modest_search_hit_free),
71 (modest_search_hit_list_free):
72 Utility functions to free the result hits.
74 * src/dbus_api/modest-dbus-api.h:
75 * src/dbus_api/modest-dbus-callbacks.c:
77 (modest_dbus_req_handler):
78 Implement deletion of messages (Server side).
80 * tests/dbus_api/test_search.c: (main):
83 * tests/dbus_api/Makefile.am:
84 * tests/dbus_api/test_delete_message:
85 Add little test for the message deletion logic
87 2007-06-03 Armin Burgmeier <armin@openismus.com>
89 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
90 when the operation queue was not empty. projects.maemo.org bug
93 2007-06-03 Armin Burgmeier <armin@openismus.com>
95 * src/widgets/modest-account-view.c
96 (on_account_default_toggled): Toggle default account column
97 explicitely instead of waiting for gconf notification (which is
98 currently ignored). This should fix projects.maemo.org bug NB#56910
99 for now. It should probably be removed when gconf notifications are
102 2007-06-03 Christian Kellner <ckellner@openismus.com>
104 * libmodest-dbus-client/libmodest-dbus-client.c:
105 Removed debugging spew.
107 * src/dbus_api/modest-dbus-callbacks.c:
108 Added debugging info.
110 * src/modest-search.c:
111 (modest_search_all_accounts):
112 Use tny_account_store_get_accounts () on the account store
113 to get all accounts which is the way to get all accounts.
115 * tests/dbus_api/test_search.c: (main):
116 Make it possible to supply the search term on the command line.
118 2007-06-03 Christian Kellner <ckellner@openismus.com>
120 * libmodest-dbus-client/libmodest-dbus-client.c:
121 * libmodest-dbus-client/libmodest-dbus-client.h:
122 Implement searching for mesages over raw dbus. (Client side)
124 * src/dbus_api/Makefile.am:
125 * src/dbus_api/modest-dbus-api.h:
126 * src/dbus_api/modest-dbus-callbacks.c:
127 * src/dbus_api/modest-dbus-callbacks.h:
128 Search framework (Server side). Also implement on_idle_open_message().
130 * src/maemo/modest-platform.c: (modest_platform_init):
131 Prepare for raw dbus/osso rpc interaction.
133 * src/modest-search.h:
134 Changed minsize from unspecific guint to guint32.
136 * src/modest-search.c:
138 Added strange hack which magically made tnymail work.
140 (modest_search_folder),
141 (modest_search_account),
142 (modest_search_all_accounts):
143 Implement helper functions to search all accounts, specific account
146 * tests/dbus_api/Makefile.am:
147 * tests/dbus_api/test_open_message.c:
148 Read url to open from commandline.
150 * tests/dbus_api/test_search.c:
151 Implement small test for dbus search stuff
153 2007-06-02 Armin Burgmeier <armin@openismus.com>
155 * src/maemo/modest-account-settings-dialog.c: Changed window title to
156 include account type and account title. This fixes projects.maemo.org
159 * src/maemo/modest-account-view-window.c: Set a title for the window.
161 2007-06-02 Armin Burgmeier <armin@openismus.com>
163 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
164 incoming and outgoing server name based on email address and server
165 types as long as the names have not been edited manually. This fixes
166 projects.maemo.org bug NB#58671.
168 2007-06-02 Armin Burgmeier <armin@openismus.com>
170 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
171 server type cannot be changed in future to the incoming details page
172 when creating an account. This fixes projects.maemo.org bug NB#59029.
174 2007-06-02 Armin Burgmeier <armin@openismus.com>
176 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
177 and assigned max width chars so that they wrap instead of being
178 truncated. Fixes projects.maemo.org bug NB#56126.
180 2007-06-02 Armin Burgmeier <armin@openismus.com>
182 * src/maemo/modest-connection-specific-smtp-window.c: Add an
183 introductory note to the connection specific smtp servers dialog, as
184 section 8.12 of the email UI specification requires. This fixes
185 projects.maemo.org bug NB#59212.
187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
190 Check for running mail operations, and offer to cancel them, as per the UI
191 spec. This fixes projects.maemo.org bug NB#59041 .
192 However, I suspect that tinymail may still use the network connection
193 in ways that we cannot detect or cancel. But it should at least adapt to
196 2007-06-01 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account-store.c: (recreate_all_accounts),
199 (get_cached_accounts), (get_server_accounts): Do more sensible
200 ref-counting of the temporarily-cached outbox accounts list. This seems
201 to fix a crash when entering the password when the password was wrong.
203 2007-06-01 Murray Cumming <murrayc@murrayc.com>
205 * src/gnome/modest-main-window.c: (connect_signals):
206 * src/modest-tny-account-store.c: (get_password),
207 (modest_tny_account_store_alert): Added comments and clues and
208 commented-out code about how we currently fail to deal with connection
209 errors and wrong passwords, and how we should.
211 2007-06-01 Murray Cumming <murrayc@murrayc.com>
213 * src/widgets/modest-retrieve-combo-box.c:
214 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
215 This fixes projects.maemo.org bug NB#58472 .
217 2007-06-01 Murray Cumming <murrayc@murrayc.com>
219 * src/maemo/easysetup/modest-easysetup-wizard.c:
220 (create_page_complete_easysetup):
221 (create_page_complete_custom): Correct the last commit,
222 putting the correct sentences in the correct pages.
224 2007-06-01 Murray Cumming <murrayc@murrayc.com>
226 * src/maemo/easysetup/modest-easysetup-wizard.c:
227 (create_page_complete_custom): Show the second sentence of text
228 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
231 2007-06-01 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
234 Set the leave-on-server conf key by default. This fixes
235 projects.maemo.org bug NB#59258 .
237 2007-06-01 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/modest-account-view-window.c:
240 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
241 logical ID for the confirmation messages. Fixed projects.maemo.org bug
244 2007-06-01 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c:
247 (create_caption_new_with_asterisk):
248 * src/maemo/modest-account-settings-dialog.c:
249 (create_caption_new_with_asterisk):
250 Uncomment the code to add the asterisk, because they are no longer in the
251 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
252 (update_incoming_server_title): Add an asterisk here too.
254 2007-06-01 Murray Cumming <murrayc@murrayc.com>
256 * src/maemo/modest-maemo-global-settings-dialog.c:
257 (current_connection): Check that we are even connected before trying to
258 get the current connection name, to prevent a warning.
260 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
261 Change the comments because tny_maemo_conic_device_connect() is now meant to
263 * src/modest-mail-operation.c:
264 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
265 make sure we have a connection and fail if we can't connect.
267 2007-05-31 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/modest-main-window.c:
270 (on_account_store_connecting_finished): Do not try to get the
271 connection ID if we are not really connected. I am surprised that
272 this signal handler is called when we are not connected.
274 2007-05-31 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-error.h:
277 * src/modest-ui-actions.c:
278 (modest_ui_actions_get_msgs_full_error_handler):
279 Renamed an enum, added comments, added an enum
280 for retrieve-limit errors.
282 * src/modest-mail-operation.c: (foreach_add_item),
283 (internal_folder_observer_update), (update_account_thread),
284 (modest_mail_operation_get_msgs_full):
285 (modest_mail_operation_update_account),
286 Added comments about how this works, and some code that should
287 (but does not) check the retrieve-limit. See the TODO comment.
289 2007-05-31 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
292 Initialize help_id to fix the build. Warnings are good.
294 2007-05-31 Murray Cumming <murrayc@murrayc.com>
296 * src/widgets/modest-hbox-cell-renderer.c:
297 (modest_hbox_cell_renderer_append):
298 * src/widgets/modest-vbox-cell-renderer.c:
299 (modest_vbox_cell_renderer_append):
300 Fix the last commit by doing an extra ref.
302 2007-05-31 Murray Cumming <murrayc@murrayc.com>
304 * src/widgets/modest-hbox-cell-renderer.c:
305 (modest_hbox_cell_renderer_append):
306 * src/widgets/modest-vbox-cell-renderer.c:
307 (modest_vbox_cell_renderer_append):
308 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
309 to fix the build with Maemo Bora.
310 However, there seems to be a remaining crash, probably due to reference
313 2007-05-30 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-tny-account.c:
316 (modest_tny_account_new_for_local_folders):
317 Use hildon_file_system_info_async_new() to get a better name for
318 the memory card account, setting it as the account name.
319 The timing seems to work, but this is probably
320 not the best place to do this. See the TODO comment.
321 * src/maemo/modest-main-window.c: (create_details_widget):
322 * src/widgets/modest-folder-view.c: (text_cell_data):
323 Use the tny account name instead of hardcoding a name.
325 2007-05-30 Christian Kellner <ckellner@openismus.com>
327 * src/modest-search.c: (modest_search):
328 Correctly set part_search_func even if we have already parsed
329 the query and thus a valid OgsTextSearcher object.
331 2007-05-30 Christian Kellner <ckellner@openismus.com>
334 Search and check for libogs.
337 Incooparte the ogs build env.
339 * src/modest-mime-part-search-stream.c:
340 * src/modest-mime-part-search-stream.h:
341 Removed since we do the real searching now in modest-search.c.
343 * src/modest-search.c:
344 * src/modest-search.h:
345 Implement support for ogs. We use that if available and requested
346 and fall back to modest_text_utils_utf8_strcmp (). The search logic
347 should now handle the corner case when the search term is spread
348 across multiple reads.
349 Also the logic in modest_search () was corrected to search all
350 requested fields until one is found.
352 2007-05-30 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
357 * src/modest-init.c: Made modest_init_local_folders() take a
358 path and be public so we can iniitialize maildir folders on
361 * src/modest-local-folder-info.h:
362 * src/modest-local-folder-info.c:
363 (modest_local_folder_info_get_maildir_path): Add a path parameter.
365 * src/modest-tny-account.c:
366 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
367 still means the standard local-folders path on the local volume.
369 * src/modest-tny-account-store.c:
370 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
371 signal so we can detect mount/unmount of the MMC1 card, and do an update of
372 all accounts when that happens.
373 (get_server_accounts): If the MMC1 card is mounted, create a store account for
374 this too, so it shows up in the treeview.
376 2007-05-28 Murray Cumming <murrayc@murrayc.com>
378 * src/maemo/modest-maemo-global-settings-dialog.c:
379 (current_connection):
380 * src/widgets/modest-global-settings-dialog.c:
381 (current_connection_default):
382 Use the enum values instead of 0, 1 and -1,
383 to make the code clearer.
385 * src/modest-account-mgr-helpers.c:
386 (modest_account_mgr_get_connection_specific_smtp): Make this code
389 * src/modest-runtime.h:
390 * src/modest-runtime.c:
391 Added modest_runtime_remove_all_send_queues().
392 * src/maemo/modest-main-window.c:
393 (on_account_store_connecting_finished): Recreate the send queues,
394 using the appropriate transport accounts for this new connection.
395 Some futher adapting might be needed if the old send queues are not
396 automatically stopped at this point.
398 * src/modest-tny-account-store.c: (get_server_accounts):
399 Create the connection-specific transport accounts, so that they can
400 be found later by their ID.
402 * src/modest-tny-account.h:
403 * src/modest-tny-account.c:
404 Added modest_tny_account_new_from_server_account_name().
405 modest_tny_account_new_from_server_account(): Do not create the
406 send queues here, because they will be
407 recreated anyway when the connection changes for the first time.
409 2007-05-28 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-local-folder-info.h:
412 * src/modest-local-folder-info.c:
413 (modest_per_account_local_outbox_folder_info_get_maildir_path),
414 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
415 tbox_folder): Take a modest account name instead of a server TnyAccount,
416 so we can have per-modest-account rather than per-transport-account
418 We must make sure that we change or recreate the exisitng send queues
419 when the connection changes for connection-specific transport accounts.
421 * src/modest-tny-account-store.c:
422 (create_per_account_local_outbox_folders): Create outboxed per modest
423 account, not per transport account.
425 * src/modest-tny-account.h:
426 * src/modest-tny-account.c:
427 (modest_tny_account_get_special_folder): For outboxes, get the
428 parent modest account name. The account is ignored for other folders.
429 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
430 modest account name rather than a server TnyAccount.
432 2007-05-25 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-tny-account.c:
435 (modest_tny_account_new_from_server_account):
436 Call modest_runtime_get_send_queue() immediately after creating transport
437 accounts, so that they start trying to send email from the outbox as soon
438 as possible at startup. This is probably what we want.
440 * src/modest-mail-operation.c: (update_account_thread):
441 * src/modest-runtime.c: (modest_runtime_get_send_queue):
442 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
443 * src/modest-tny-send-queue.h:
444 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
445 (modest_ui_actions_on_send):
446 Added comments about how sending works, though it needs some more work.
448 2007-05-25 Murray Cumming <murrayc@murrayc.com>
450 * src/modest-tny-account.c:
451 (modest_tny_account_get_special_folder): Add TODO because this fails when
453 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
454 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
455 Do not try to show this window when there is no active account. The UI
456 specs does not tell us what to do in this case.
458 2007-05-24 Murray Cumming <murrayc@murrayc.com>
462 * src/maemo/Makefile.am:
463 * src/widgets/Makefile.am: Some dist fixes.
465 2007-05-24 Murray Cumming <murrayc@murrayc.com>
467 * src/maemo/modest-connection-specific-smtp-window.c:
468 (on_button_edit): Make the code clearer, to prevent a double free.
470 2007-05-24 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/modest-account-settings-dialog.c:
473 (modest_account_settings_dialog_set_account_name),
474 Check the connection-specific smtp servers checkbox if there are any.
476 * src/maemo/modest-connection-specific-smtp-edit-window.c:
477 (modest_connection_specific_smtp_edit_window_init):
478 Start with a suitable port number.
480 * src/modest-account-mgr-helpers.h:
481 * src/modest-account-mgr-helpers.c: Added
482 modest_account_mgr_get_has_connection_specific_smtp().
484 (modest_account_mgr_set_connection_specific_smtp),
485 (modest_account_mgr_remove_connection_specific_smtp),
486 (modest_account_mgr_get_has_connection_specific_smtp),
487 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
488 connection-specific smtp server accounts in the account, rather than
489 the server account conf dir.
491 This fixes bug projects.maemo.org bug NB#58263 .
493 * src/modest-tny-account-store.c:
494 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
495 if there are no server accounts yet, to prevent an infinite loop when there
496 are no accounts. Document that one must be called before the other.
498 2007-05-24 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-account-mgr-helpers.c:
501 (modest_account_mgr_get_default_account): Make sure that at least
502 one account is always the default, if there are any enabled accounts.
503 This is just a sanity check that shouldn't be necessary.
505 * src/modest-account-mgr-priv.c:
506 (_modest_account_mgr_account_from_key): Unescape the conf key to
507 get the real account name. For instance, this is an issue if a space
508 was in the account name, which can happen because the account name
509 is generated from the display name.
510 (_modest_account_mgr_get_account_keyname): Always escape the
512 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
513 Unescape the conf keys to get the real account names.
515 For instance, previously the is-default radio button in the accounts
516 list was not checked for any accounts at first. This fixes that,
517 and might fix several similar bugs.
519 2007-05-23 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
522 Removed some debug printfs.
524 2007-05-23 Murray Cumming <murrayc@murrayc.com>
526 Modest on-disk outbox directories are now here, for instance:
527 $HOME/.modest/outboxes/<account-id-1>/outbox
528 $HOME/.modest/outboxes/<account-id-2>/outbox
530 $HOME/.modest/local-folders/outbox
531 so we can have a separate outbox for each account.
532 But they are shown as one outbox in the GtkTreeView, by using a
533 TnyMergeFolder in a ModestTnySimpleFolderStore.
536 * src/modest-tny-simple-folder-store.c:
537 * src/modest-tny-simple-folder-store.h:
538 Added ModestTnySimpleFolderStore, used to contain folders from
539 other folder stores, such as other accounts.
541 * src/modest-tny-outbox-account.h:
542 * src/modest-tny-outbox-account.c:
543 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
544 used for the per-account local outbox folders.
546 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
547 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
548 only use this (internally) now for the non-outbox local folders.
551 * src/modest-init.c: Added modest_init_one_local_folder(), for
552 setting up the directory structure for each local folder.
554 * src/modest-local-folder-info.c:
555 (modest_per_account_local_outbox_folder_info_get_maildir_path),
556 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
558 * src/modest-local-folder-info.h:
559 * src/modest-tny-account-store.c: (on_account_removed),
560 (on_account_changed), (create_per_account_local_outbox_folders),
561 (get_server_accounts), (modest_tny_account_store_get_accounts),
562 (modest_tny_account_store_get_tny_account_by_account),
563 (modest_tny_folder_store_is_virtual_local_folders):
565 * src/modest-tny-account.h:
566 * src/modest-tny-account.c:
567 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
568 to create an on-disk per-account local outbox folder for each
570 (create_per_account_local_outbox_folders): Create a local outbox folder
571 for each transport account.
572 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
573 for all local folders.
575 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
576 instead of using g_object_get/set() directly. It is clearer.
578 (modest_tny_folder_store_get_message_count),
579 (modest_tny_folder_store_get_local_size
580 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
581 because we now use these with non-acount folder stores.
583 (modest_tny_account_get_special_folder),
584 (modest_tny_account_new_from_server_account),
585 (modest_tny_account_new_from_account):
586 (recurse_folders): Adjust to the new outbox system.
588 * src/modest-tny-folder.h:
589 * src/modest-tny-folder.c:
590 (modest_tny_folder_is_local_folder),
591 (modest_tny_folder_get_local_folder_type),
592 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
594 * src/widgets/modest-main-window.h:
595 * src/maemo/modest-main-window.c: (create_details_widget),
596 (modest_main_window_set_contents_style): Show details for any folder store,
599 (modest_tny_folder_get_rules):
600 Remove the const. C does not support constness enough for this.
602 * src/modest-ui-actions.c:
603 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
604 make all outboxes appear as one, in the usual local-folders tree node.
606 (set_active_account_from_tny_account),
607 (modest_ui_actions_on_folder_selection_changed):
608 * src/widgets/modest-folder-view.c: (text_cell_data),
609 (icon_cell_data), (filter_row),
610 (add_account_folders_to_merged_folder),
611 (add_account_folders_to_simple_folder_store), (),
612 (get_cmp_rows_type_pos), (cmp_rows),
613 (modest_folder_view_set_account_id_of_visible_server_account):
614 Adjust to the new outbox system, using generic folder stores and folders
617 2007-05-23 Christian Kellner <ckellner@openismus.com>
619 * src/modest-mail-operation.c:
620 (modest_mail_operation_update_account):
621 Use info->max_size instead of unintialized local var [small
622 build fix]. (Added TODO to review that change since I don't
625 2007-05-23 Marcus Bauer <marcusb@openismus.com>
627 * libmodest-dbus-client/libmodest-dbus-client.c:
628 (libmodest_dbus_client_compose_mail): function added
629 * src/dbus_api/modest-dbus-api.h:
630 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
631 (on_compose_mail): Implementation of the SendAsMail functionality
633 2007-05-22 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-account-mgr.c:
636 (modest_account_mgr_add_server_account): Set the secure-connection
637 conf key for transport accounts as well as store accounts. I don't know
638 why the if was there. For instance, this makes sure that we use SSL
639 for the gmail preset from the easysetup wizard.
641 2007-05-22 Murray Cumming <murrayc@murrayc.com>
643 * src/gnome/modest-main-window.c:
644 (on_account_store_connecting_finished), (connect_signals):
645 * src/maemo/modest-main-window.c:
646 (on_account_store_connecting_finished), (connect_signals),
647 (modest_main_window_new):
648 Handle TnyAccountStore::connecting-finished instead of
649 TnyDevice::connection-changed, because we cannot actually perform
650 operations on accounts until TnyAccountStore has itself responded to
651 the TnyDevice::connection-changed signal. This prevents a GError from
653 Do not try to update at startup, because we (at least on scratchbox)
654 already do an update at startup when the device goes online.
655 This prevents a GError from tinymail.
656 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
657 Added TODO about stopping simultaneous operations.
659 2007-05-21 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
662 * src/modest-mail-operation-queue.c:
663 (modest_mail_operation_queue_remove):
664 * src/modest-tny-account-store.c: When GErrors happen, give more clues
665 about where they happened.
667 2007-05-21 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-ui-actions.c:
670 (modest_ui_actions_on_password_requested): Make sure that the remember
671 output parameter is always TRUE.
673 2007-05-21 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
676 Show a OK/Cancel dialog if the error is a question, though we still do not
677 know anything more about what we are asking the user.
678 * src/widgets/modest-folder-view.c: (on_drag_data_received):
679 Fix an uninitialized variable (helper). This is a logic error, however.
681 2007-05-21 Christian Kellner <ckellner@openismus.com>
683 * src/modest-search.h:
684 Correct bit shifting in the ModestSearchFlags enum.
686 2007-05-21 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-tny-account.c:
689 (modest_tny_account_new_from_server_account): Do not use the lsub and
690 check-all hard-coded IMAP options when using POP.
692 2007-05-21 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account.c:
695 (modest_tny_account_new_from_server_account):
696 Use NULL for the secure-auth method for POP when Password auth has been
697 specified by the user, as we already do for IMAP. "auth=Login" causes
698 an error from camel or the server.
700 2007-05-17 Murray Cumming <murrayc@murrayc.com>
702 * src/maemo/modest-account-settings-dialog.c:
703 (create_page_account_details),
704 (modest_account_settings_dialog_set_account_name):
705 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
706 for the leave-on-server checkbox, rathr than just the checkbox, when
707 the protocol is not POP.
709 2007-05-17 Murray Cumming <murrayc@murrayc.com>
711 * src/widgets/modest-account-view.c:
712 * src/widgets/modest-account-view.h:
713 Added modest_account_view_select_account() which will be useful later
714 to asynchronously re-select the edited account.
716 2007-05-17 Murray Cumming <murrayc@murrayc.com>
718 * src/maemo/modest-account-settings-dialog.c:
719 (modest_account_settings_dialog_set_account_name):
720 Automatically choose the port numbers based on the secure authentication
721 methods, if they have not been chosen before.
722 This fixes projects.maemo.org bug NB#56273 .
724 2007-05-17 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-main-window-ui.h:
727 * src/modest-ui-actions.c:
728 * src/modest-ui-actions.h:
729 Connect the Tools/SMTP Servers menu item to
730 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
731 SMTP servers dialog, as in the UI specification and saves changes when it
732 is closed. This fixed projects.maemo.org bug NB#56305 .
734 2007-05-17 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/modest-connection-specific-smtp-window.c:
737 (modest_connection_specific_smtp_window_init):
738 Use gtk_window_set_default_size() to make this window big enough, so
739 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
741 2007-05-17 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/modest-connection-specific-smtp-edit-window.h:
744 * src/maemo/modest-connection-specific-smtp-edit-window.c:
745 (modest_connection_specific_smtp_edit_window_init),
746 Do not try to connect to a combobox signal before the combobox exists.
747 This fixes the cras in projects.maemo.org bug NB#56288 .
748 (modest_connection_specific_smtp_edit_window_get_settings):
749 Remove the server_account_name parameter which was being checked for NULL
750 though it was not used.
752 * src/maemo/modest-connection-specific-smtp-window.c:
753 (modest_connection_specific_smtp_window_fill_with_connections),
754 (on_button_edit), (modest_connection_specific_smtp_window_init):
755 Correct the number of treemodel columns to prevent a warning.
756 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
757 libconic does not work.
759 2007-05-16 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-tny-account.c:
762 (modest_tny_account_new_from_server_account):
763 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
764 SMTP when "None" was chosen by the user. However, with my SMTP server that
765 does not support ANONYMOUS, the emails do not leave the Outbox and I see
768 2007-05-16 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
771 to explain the memory management issue with the ID in the ModestPair.
773 * src/gnome/modest-account-assistant.c: (add_receiving_page),
774 (add_sending_page), (modest_account_assistant_finalize):
775 * src/gnome/modest-gnome-global-settings-dialog.c:
776 (create_updating_page), (create_composing_page):
777 * src/gnome/modest-msg-edit-window.c: (get_transports),
778 (init_window), (modest_msg_edit_window_finalize),
779 (modest_msg_edit_window_get_msg_data):
780 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
781 * src/gnome/modest-transport-widget.c:
782 (modest_transport_widget_finalize), (smtp_configuration):
783 * src/maemo/modest-maemo-global-settings-dialog.c:
784 (create_updating_page), (create_composing_page):
785 * src/maemo/modest-msg-edit-window.c: (get_transports),
786 (init_window), (modest_msg_edit_window_finalize),
787 (modest_msg_edit_window_get_msg_data),
788 (modest_msg_edit_window_free_msg_data):
789 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
790 (modest_store_widget_finalize):
791 * src/maemo/modest-transport-widget.c:
792 (modest_transport_widget_finalize), (smtp_configuration):
793 * src/modest-main.c: (send_mail):
794 * src/widgets/modest-combo-box.h:
795 * src/widgets/modest-global-settings-dialog-priv.h:
796 * src/widgets/modest-global-settings-dialog.c:
797 (modest_global_settings_dialog_finalize):
798 * src/widgets/modest-msg-edit-window.h:
799 Whenever using modest_combo_box_new(), keep the ModestPairList alive
800 as long as the combo box, to prevent use of freed memory for the ID.
802 2007-05-15 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
805 get_accounts(), to make this clearer. Do not check for the enabled gconf
806 key, because we do not use this for server accounts (at least, not yet).
807 This allows us to send email again.
809 2007-05-15 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/modest-platform.c:
812 (on_modest_conf_update_interval_changed), (modest_platform_init):
813 Only respond to this particular key change. All these strcmp()s cannot be
816 2007-05-15 Murray Cumming <murrayc@murrayc.com>
818 * src/maemo/modest-maemo-global-settings-dialog.c:
819 (current_connection): Prevent a crash in scratchbox when
820 ny_maemo_conic_device_get_current_iap_id() returns NULL.
821 * src/maemo/modest-platform.c:
822 (on_modest_conf_update_interval_changed), (modest_platform_init):
823 Get the update interval from gconf and reset it when the gconf key changes.
825 2007-05-15 Murray Cumming <murrayc@murrayc.com>
827 * src/modest-protocol-info.c:
828 * src/modest-protocol-info.h: Adde enum-specific get functions,
829 instead of using a ModestProtocolType enum parameter.
831 * src/gnome/modest-account-assistant.c:
832 * src/gnome/modest-store-widget.c:
833 * src/gnome/modest-store-widget.h:
834 * src/gnome/modest-transport-widget.c:
835 * src/gnome/modest-transport-widget.h:
836 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
837 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
838 * src/maemo/easysetup/modest-easysetup-wizard.c:
839 * src/maemo/modest-account-settings-dialog.c:
840 * src/maemo/modest-account-settings-dialog.h:
841 * src/maemo/modest-store-widget.c:
842 * src/maemo/modest-store-widget.h:
843 * src/maemo/modest-transport-widget.c:
844 * src/maemo/modest-transport-widget.h:
845 * src/modest-account-mgr-helpers.c:
846 * src/modest-account-mgr-helpers.h:
847 * src/modest-account-mgr.c:
848 * src/modest-account-mgr.h:
849 * src/modest-tny-account.c:
850 * src/modest-tny-folder.c:
851 * src/widgets/modest-account-view.c:
852 * src/widgets/modest-retrieve-combo-box.c:
853 * src/widgets/modest-retrieve-combo-box.h:
854 * src/widgets/modest-secureauth-combo-box.c:
855 * src/widgets/modest-serversecurity-combo-box.c:
856 * src/widgets/modest-serversecurity-combo-box.h:
857 * tests/check_account-mgr.c:
858 Use the specific functions, and use the re-renamed enum values for GNOME too.
860 2007-05-15 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
864 so we can get the second based on the first.
866 * src/maemo/modest-account-settings-dialog.h:
867 * src/maemo/modest-account-settings-dialog.c:
868 Added get_supported_secure_authentication_methods(), though it is mostly
869 commented-out for now until the necessary API is committed to tinymail.
870 (modest_account_settings_dialog_set_account_name),
871 (save_configuration): Request the supported authentication methods from the
872 server, so we can choose a working method.
874 * src/modest-tny-account-store.h:
875 * src/modest-tny-account-store.c:
876 (modest_tny_account_store_get_session): Rename from
877 tny_account_store_get_session().
879 2007-05-14 Murray Cumming <murrayc@murrayc.com>
881 * src/modest-protocol-info.h: Split the ModestProtocol enum
882 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
883 There was no need to have these unrelated values in one enum.
885 * src/: many files: Adapted to changed enum. This makes the code a bit
886 clearer, and the compiler could catch some errors.
888 2007-05-14 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
891 Show the detailed internal camel error message when an error happens
892 during the configuration, so that our testers can give us more clues.
893 For instance, in projects.maemo.org bug NB#56910 .
895 2007-05-14 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-tny-account.c:
898 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
899 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
901 2007-05-14 Murray Cumming <murrayc@murrayc.com>
903 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
904 * src/maemo/modest-account-settings-dialog.c:
905 (modest_account_settings_dialog_set_account_name),
906 (save_configuration): For the incoming secure authentication checkbox,
907 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
908 the UI specification. PLAIN does not seem to be supported for most IMAP
909 servers anyway, and I am not sure what it would mean.
910 However, we probably need to discover which of the secure-authentication
911 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
912 * src/modest-account-mgr-helpers.c:
913 (modest_account_mgr_get_server_account_data):
915 * src/modest-tny-account.c:
916 (modest_tny_account_new_from_server_account):
917 Use tny_account_set_mech() to set secure-authentication methods,
918 with some special-casing for IMAP, based on my observations of how
921 * src/modest-account-mgr-helpers.h:
922 * src/modest-account-mgr.c:
923 * src/modest-defs.h: Comment that the URI is only used for local folders.
925 2007-05-11 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
928 parameter const, just to be neat.
929 * src/modest-text-utils.c: (modest_text_utils_inline):
930 End g_strconcat() with NULL, as its documentation says. This is almost
931 certainly the cause of my crash at startup on the device. Interestingly,
932 valgrind doesn't tell us about these errors.
934 2007-05-11 Murray Cumming <murrayc@murrayc.com>
936 * scripts/build-packages: Added more precise comments about how to use
937 this script, though I still get this error:
938 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
939 error building tinymail
941 2007-05-11 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/modest-main-window.c: (on_account_update):
944 Very slight cleanup, hoping to make it simpler to discover what causes
945 a crash here sometimes.
947 * src/modest-tny-account.c:
948 (modest_tny_account_new_from_server_account): Set the port. Added
949 comments about the options and a TODO comment because I need to find out
950 how to specify the secure authentication method.
952 2007-05-11 Marcus Bauer <marcusb@openismus.com>
954 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
955 changed CFlags paths form modest to libmodest
957 2007-05-10 Murray Cumming <murrayc@murrayc.com>
959 * src/modest-account-mgr-helpers.c:
960 (modest_account_mgr_get_server_account_data),
961 (modest_account_mgr_free_server_account_data):
962 * src/modest-account-mgr-helpers.h:
963 * src/modest-account-mgr.c:
964 (modest_account_mgr_add_server_account):
966 * src/modest-tny-account.c:
967 (modest_tny_account_new_from_server_account):
968 Determine the options for tny_camel_account_add_option() here,
969 based on the settings, rather than storing them directly in gconf.
971 2007-05-10 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
974 Show a more friendly error dialog now that we expect (from the tinymail
975 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
977 2007-05-10 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-main-window.c: (on_account_update): Check that
980 account_name is not NULL, to prevent a crash at startup that I am
981 seeing on the N800. I do wonder why it is NULL.
983 * src/maemo/easysetup/modest-easysetup-wizard.c:
984 (create_page_user_details):
985 * src/maemo/modest-account-settings-dialog.c:
986 (create_page_user_details), (create_page_outgoing):
987 * src/maemo/modest-connection-specific-smtp-edit-window.c:
988 (modest_connection_specific_smtp_edit_window_init):
989 * src/modest-ui-actions.c:
990 (modest_ui_actions_on_password_requested):
991 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
992 might do something useful with the on-screen keyboard.
994 2007-05-10 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/modest-main-window.c: (on_account_update):
997 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
998 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1000 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-tny-account-store.c: (on_account_changed):
1003 Correct the signature of this signal handler.
1005 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1008 Show a HildonNote instead of a GtkDialog for Maemo.
1010 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1012 * src/widgets/modest-account-view.h:
1013 * src/widgets/modest-account-view.c: (on_account_changed),
1014 (on_account_removed). Added a boolean flag, set/unset by
1015 modest_account_view_block_conf_updates(),
1016 modest_account_view_unblock_conf_updates() to prevent unnecessary
1017 updates, but this is not very useful because the gconf notifications are
1018 so delays (maybe only on Maemo Bora).
1019 So auto-updating is turned off, and these functions do an explicit
1020 update when necessary.
1021 However, something else is still doing too much work when adding/removing
1022 accounts, probably in another part of the application.
1024 * src/maemo/modest-account-view-window.c:
1025 (on_delete_button_clicked), (on_edit_button_clicked),
1026 (on_new_button_clicked): Use the new functions.
1028 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-account-mgr-helpers.c:
1031 (modest_account_mgr_set_first_account_as_default):
1032 Sort the list of names alphabetically-by-title, so we choose the first one
1034 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1035 alphabetically by the title.
1037 This fixes projects.maemo.org bug NB#56418 .
1039 * src/modest-account-mgr-priv.c:
1040 (_modest_account_mgr_account_from_key):
1041 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1042 avoid a valgrind error, and possible random behaviour.
1044 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1046 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1047 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1048 tinymail documentation to say that this can be expected.
1049 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1050 pretty, and should not happen, but I would prefer to know when it does.
1052 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1054 * configure.ac: When using the older hildon version, probably on Bora,
1055 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1057 * src/widgets/modest-attachment-view.c:
1058 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1061 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1063 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1064 Implemented the prototype. Can be tested with
1065 tests/dbus_api/test_open_message:
1067 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1069 * src/modest-tny-account-store.c:
1070 (modest_tny_account_store_instance_init), (get_password):
1071 * src/modest-ui-actions.c:
1072 (modest_ui_actions_on_password_requested):
1073 Do not store the password in gconf, because this function is called
1074 for non-remembered passwords. Actually use the cached (in the hash map)
1075 password instead of releasing it.
1076 The password will now not be remembered if it is asked via the protected
1077 password dialog, as per the UI spec.
1079 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-defs.h:
1082 * src/modest-account-mgr-helpers.h:
1083 * src/modest-account-mgr-helpers.c:
1084 Added modest_server_account_get_username_has_succeeded(),
1085 modest_server_account_set_username_has_succeeded().
1086 (modest_server_account_set_username),
1087 Reset the has-succeeded flag if the username changes.
1089 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1090 * src/maemo/modest-connection-specific-smtp-window.c:
1091 (modest_connection_specific_smtp_window_save_server_accounts):
1092 Use modest_server_account_set_username() instead of using
1093 modest_conf_set_string() directly, so that the has-succeeded flag is always
1096 * src/modest-ui-actions.c:
1097 (modest_ui_actions_on_password_requested): Dim the username entry if
1098 the username has ever worked, as per the UI spec.
1100 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-tny-account-store.c: (get_password):
1103 * src/modest-ui-actions.c:
1104 (modest_ui_actions_on_password_requested):
1105 Allow the username to be changed too, though there is more work to
1106 be done on exactly how this behaves.
1108 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-account-mgr-helpers.h:
1111 * src/modest-account-mgr-helpers.c:
1112 Added modest_account_mgr_get_display_name(),
1113 modest_server_account_get_username(),
1114 modest_server_account_set_username(),
1115 modest_server_account_set_password(),
1116 modest_server_account_get_hostname() functions so we do not need to
1117 use the conf API directly.
1119 * src/maemo/modest-main-window.c: (connect_signals):
1120 Actually connect ot the ModestAccountStore::request-password signal,
1121 so that we show the dialog when the password is requested by Tinymail,
1122 for isntance if it is empty.
1124 * src/modest-marshal.list:
1125 * src/modest-tny-account-store.c:
1126 (modest_tny_account_store_class_init), (get_password),
1127 (modest_tny_account_store_alert):
1128 * src/modest-tny-account-store.h:
1129 * src/modest-ui-actions.h:
1130 * src/modest-ui-actions.c:
1131 (modest_ui_actions_on_password_requested):
1132 Change the signal parameters, so it is obvious that we are providing
1133 the non human-readable server name, and receiving both the username
1134 and password, though changing of the username is not yet implemented.
1135 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1136 for the GNOME version.
1138 This should fix the projects.maemo.org bug NB#56209, though it does not
1139 work on Bora, because the gconf_client_get() for the password fails
1140 immediately after we save it with gconf_client_set().
1142 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1145 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1146 caused an undefined symbol error:
1147 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1149 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-tny-account-store.c:
1152 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1153 using a GError instead of a string message, so we can translate it in
1156 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1158 * src/maemo/modest-address-book.c:
1159 (modest_address_book_check_names):
1160 * src/maemo/modest-msg-view-window.c:
1161 (modest_msg_view_window_clipboard_owner_change):
1162 * src/modest-init.c: (modest_init_init_ui):
1163 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1164 (update_folders_cb), (modest_mail_operation_update_account):
1165 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1166 (modest_ui_actions_on_msg_attachment_clicked),
1167 (modest_ui_actions_on_msg_recpt_activated):
1168 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1169 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1170 (modest_msg_view_search_next):
1171 * src/widgets/modest-recpt-editor.c:
1172 (modest_recpt_editor_on_button_release_event),
1173 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1174 g_message(). At this point we should only be seeing interesting errors on
1175 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1177 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1179 (modest_wizard_dialog_force_title_update):
1180 * src/maemo/easysetup/modest-wizard-dialog.h:
1181 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1182 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1183 can update the title when appropriate. Otherwise the title is wrong if the
1184 pages are added after adding the notebook to the dialog.
1185 This must be a problem in HildonWizardDialog too.
1186 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1188 * src/maemo/easysetup/modest-easysetup-wizard.c:
1189 (create_subsequent_customsetup_pages),
1190 (create_subsequent_easysetup_pages):
1191 Call modest_wizard_dialog_force_title_update() so that the title is
1192 correct even with GTK+ < 2.10.
1193 This fixes projects.maemo.org bug NB#56145 .
1195 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1197 * src/maemo/modest-platform.c:
1198 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1199 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1202 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1204 * src/widgets/modest-window.h:
1205 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1206 and modest_window_save_state(), which invokes it.
1208 * src/widgets/modest-window-mgr.h:
1209 * src/widgets/modest-window-mgr.c:
1210 Added modest_window_mgr_save_state_for_all_windows(), which calls
1211 the save_state vfunc on all registered windows, if implemented.
1213 * src/gnome/modest-msg-edit-window.c:
1214 * src/gnome/modest-msg-view-window.c:
1215 * src/maemo/modest-msg-edit-window.c:
1216 * src/maemo/modest-msg-view-window.c:
1217 * src/maemo/modest-main-window.c:
1218 Specify the existing save_settings functions as implementations of
1219 ModestWindow::save_state_func().
1221 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1222 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1223 enabling hibernation, for instance.
1225 We may need to do the same thing for restoring settings.
1228 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1230 * src/widgets/modest-window-mgr.c:
1231 * src/widgets/modest-window-mgr.h:
1232 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1233 modest_window_mgr_get_hibernation_is_prevented().
1235 * src/maemo/modest-main-window.c:
1236 (on_hildon_program_is_topmost_notify): Prevent hibernation
1237 (possible when the application goes to the background in the WM),
1238 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1240 * src/maemo/easysetup/modest-easysetup-wizard.c:
1241 (modest_easysetup_wizard_dialog_init):
1242 * src/maemo/modest-account-settings-dialog.c:
1243 (modest_account_settings_dialog_init):
1244 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1245 (modest_connection_specific_smtp_edit_window_init):
1246 * src/maemo/modest-connection-specific-smtp-window.c:
1247 (modest_connection_specific_smtp_window_init):
1248 * src/maemo/modest-signature-editor-dialog.c:
1249 (modest_signature_editor_dialog_init):
1250 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1251 prevent hibernation while any of these account settings dialogs are open.
1253 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/Makefile.am:
1256 * src/maemo/modest-osso-state-saving.c:
1257 * src/maemo/modest-osso-state-saving.h: Added
1258 modest_osso_load_state() and modest_osso_save_state() though they do
1259 nothing now. They should iterate through all the open windows and load/save
1261 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1262 save state when closing.
1264 * src/maemo/modest-main-window.c:
1265 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1266 Add a notification handler for the HildonProgram::is-topmost property,
1267 so we can allow hibernation when the application goes into the background.
1268 But we still need to detect when the accounts setup windows are open so
1269 we can stop hibernation when they are open.
1270 To do this, I also added the main window the HildonProgram. This might have
1271 other side-effects/benefits, and should maybe be done for other windows.
1273 * src/maemo/modest-osso-autosave-callbacks.h:
1274 * src/maemo/modest-osso-autosave-callbacks.c:
1275 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1276 though it does not do anything yet, and we might never need this to do
1277 anything. For instance, we already save drafts.
1279 * src/maemo/modest-platform.c: (modest_platform_init):
1280 Specify the libosso auto-save callback.
1282 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/modest-platform.c:
1285 (modest_platform_set_update_interval):
1286 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1287 aparently stays valid between application instances, so we can use this
1288 to remove and reset it later. According to a maemo-developers email from
1291 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1293 * configure.ac: Depend on libalarm for Maemo.
1295 * src/dbus_api/modest-dbus-api.h:
1296 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1297 (on_send_receive), (modest_dbus_req_handler):
1298 Handle a SEND_RECEIVE D-Bus method.
1300 * libmodest-dbus-client/libmodest-dbus-client.c:
1301 (libmodest_dbus_client_send_and_receive):
1302 * libmodest-dbus-client/libmodest-dbus-client.h:
1303 Add C convenience functions for calling the new D-Bus method.
1305 * src/modest-platform.h:
1306 * src/gnome/modest-platform.c:
1307 * src/maemo/modest-platform.c:
1308 Added modest_platform_set_update_interval(), which uses the
1309 alarmd API on Maemo.
1310 (modest_platform_init),
1311 Call modest_platform_set_update_interval(), using a hard-coded
1312 interval for now (until the global settings dialog is implemented),
1313 though I am not sure that this makes sense yet.
1315 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1317 * src/dbus_api/modest-dbus-callbacks.c:
1318 (modest_osso_cb_hw_state_handler):
1319 * src/dbus_api/modest-dbus-callbacks.h:
1320 * src/maemo/modest-platform.c: (modest_platform_init):
1321 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1322 in case this has some effect on the ability for Maemo to ping the
1325 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1328 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1329 warning. It is probably a logic error, but I need to fix the build.
1331 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-account-mgr.h:
1334 * src/modest-account-mgr.c:
1335 (modest_account_mgr_account_names): Add a gboolean enabled_only
1336 parameter, so we can get lists of onlt the enabled accounts.
1338 (modest_account_mgr_add_account),,
1339 (modest_account_mgr_account_with_display_name_exists):
1340 * src/maemo/modest-msg-edit-window.c: (get_transports):
1341 * src/modest-account-mgr-helpers.c:
1342 (modest_account_mgr_set_first_account_as_default):
1343 * src/modest-init.c: (init_default_account_maybe):
1344 * src/modest-tny-account-store.c: (get_accounts):
1345 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1346 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1347 * tests/check_account-mgr.c: (START_TEST):
1348 Provide the extra parameter, as appropriate.
1350 * src/widgets/modest-account-view.c: (update_account_view):
1351 Do not show disabled accounts (meaning that there is no way to
1352 enable/disable accounts in the UI (the feature is not in our UI
1353 specification), so we can use this internally only to mark unfinished
1354 or temporary account data.
1356 * src/maemo/easysetup/modest-easysetup-wizard.c:
1357 (create_account): Add boolean enable parameter, so we can specify FALSE
1358 to create the temporary account.
1359 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1360 (on_before_next): When finishing, when there is a temporary account, just
1362 Also, use a timeout to delay the showing of the dialog until gconf is likely
1363 to return correct information, due to a maemo gconf bug that is fixed in
1364 osso 1.1, but not yet in Bora.
1365 However, the dialog stays on screen after it is destroyed.
1367 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1368 for invalid data when cancelling. Use a hildon note instead of a dialog
1369 to complain about invalid data. Do not show the account-saved note if the
1370 account is disabled (a temporary account that will not really be saved for use
1373 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1375 * src/modest-account-mgr-helpers.h:
1376 * src/modest-account-mgr-helpers.c:
1377 Added modest_account_mgr_unset_default_account(),
1378 Added modest_account_mgr_set_first_account_as_default().
1380 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1381 If it was the default account, unset the default account name.
1383 * src/maemo/modest-account-view-window.c:
1384 (on_delete_button_clicked): If it was the default account,
1385 set the first remaining account as the default instead.
1387 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1388 a NULL account or a NULL default account, to prevent a crash. This should
1389 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1392 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1394 * src/widgets/modest-recpt-editor.c:
1395 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1396 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1397 TODO comment for this. This fixes the build.
1399 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1400 be the best place for it. This will in future update all auto-update accounts,
1401 rather than just the current/default account, when that gconf key exists.
1402 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1403 if there are no accounts, before calling do_send_receive().
1404 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1406 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1407 * src/maemo/modest-main-window-ui.h:
1408 * src/maemo/modest-main-window.c: (on_connection_changed),
1409 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1410 directly, becaue the signal handler does more.
1412 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-account-mgr-helpers.c:
1415 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1416 for the case that the account does not exist.
1418 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1419 (equivalent to the modest account name) rather than the tinymail account name
1420 (equivalent to the modest account title - human readable) to get the account data.
1421 Check for null account data to prevent the crash, and add a TODO comment saying that
1422 this needs fixing because it is using the server account name instead of the account name.
1424 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1426 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1427 * src/maemo/modest-account-settings-dialog.c: (show_error),
1429 Use hildon_note_new_information() for informative and error messages,
1430 which seems to be expected for Maemo applications (no documentation that I know of
1431 says this). I am surprised that there is no distinction between info and error
1434 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1437 it is easy to find where this is used.
1439 * src/maemo/easysetup/modest-easysetup-wizard.c:
1440 (create_page_welcome), (create_page_account_details),
1441 (create_page_user_details), (create_page_complete_easysetup),
1442 (create_page_custom_incoming), (create_page_custom_outgoing),
1443 (create_page_complete_custom):
1444 * src/maemo/modest-account-settings-dialog.c:
1445 (create_page_account_details), (create_page_user_details),
1446 (create_page_incoming), (create_page_outgoing):
1447 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1448 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1449 (modest_connection_specific_smtp_edit_window_init):
1450 * src/maemo/modest-connection-specific-smtp-window.c:
1451 (modest_connection_specific_smtp_window_init):
1452 * src/maemo/modest-signature-editor-dialog.c:
1453 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1454 and scrolling policy as per the Email Application Layout Guide, if I have
1457 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1460 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1461 which were empty, because these vfuncs have been removed from TnyAccountStore.
1462 This fixes the build.
1464 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/modest-main-window.c:
1467 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1468 showing/hiding it. Added TODO because it probably should not be NULL.
1469 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1470 because unnecessary g_warnings() make degugging difficult.
1472 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1474 * src/maemo/modest-msg-edit-window.c:
1475 (modest_msg_edit_window_select_color),
1476 (modest_msg_edit_window_select_background_color): 2 const corrections and
1477 moving 2 #endifs before closing brackets, to fix the build.
1479 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1481 * src/maemo/easysetup/modest-easysetup-wizard.h:
1482 * src/maemo/easysetup/modest-easysetup-wizard.c:
1483 (modest_easysetup_wizard_dialog_finalize),
1484 (on_button_edit_advanced_settings), (create_page_complete_custom),
1485 (on_response), (create_account):
1486 Implement the Advanced Settings edit button, by saving the account information,
1487 for the Advanded Settings dialog to use directly from gconf, and removing it
1488 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1489 Bug #5533 in the projects.maemo.org bugzilla.
1491 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/modest-msg-view-window.c:
1494 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1495 when opening a message window.
1497 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/easysetup/modest-easysetup-wizard.c:
1500 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1503 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1504 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1505 gconf settings. I probably added more checks than necessary, but that is safer.
1507 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1508 variable to fix the build, but this seems to be used when it is still NULL.
1510 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-platform.h:
1513 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1514 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1515 * src/modest-main.c: Implement this function so we can avoid using
1516 maemo-specific API from cross-platform code.
1518 * src/modest-tny-account-store.c:
1519 (get_smtp_specific_transport_account_for_open_connection):
1520 * src/modest-ui-actions.c: (check_for_connection),
1521 (modest_ui_actions_on_item_not_found):
1522 Use modest_platform_connect_and_wait() and put #idefs around other
1523 maemo-specific code, because only maemo currently has a way to
1524 identify connection names.
1526 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1528 * src/modest-tny-account-store.h:
1529 * src/modest-tny-account-store.c:
1530 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1531 the connection-specific SMTP server settings in the configuration.
1533 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1535 * src/maemo/modest-main-window.c: (on_connection_changed),
1537 * src/modest-main.c: (main), (start_ui), (send_mail):
1538 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1539 that is what is intended.
1541 * src/modest-ui-actions.c: (action_send), (action_receive),
1542 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1543 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1544 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1545 SMTP server is used when it is specified.
1547 (modest_ui_actions_on_send_receive):
1548 Check that a connection is open before proceeding.
1549 Receive and then send, instead of vice-versa, as per the specification.
1551 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1553 * src/modest-mail-operation.c:
1554 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1555 though I guess it should be something other than NULL.
1557 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/easysetup/modest-easysetup-wizard.c:
1560 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1561 combo twice, to avoid an g_warning and to make it visible again.
1562 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1563 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1564 (already intended) dereference when detaching, because we then recreate the menu.
1565 But I am not sure why the warning was happening, and it is possible that this is a memory
1568 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1570 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1571 and uri_parse_mailto() utility functions.
1572 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1574 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1576 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1578 * src/dbus_api/modest-dbus-api.h:
1579 * src/dbus_api/modest-dbus-callbacks.c:
1580 Use an idle callback to execute the modest code in the application's own thread.
1581 Remove the helloworld example method.
1582 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1583 parsed, and the open-message method is not implemented because this is not yet implemented in
1585 * libmodest-dbus-client/libmodest-dbus-client.c:
1586 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1587 (libmodest_dbus_client_open_message):
1588 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1590 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1591 body without crashing.
1593 * tests/dbus_api/Makefile.am:
1594 * tests/dbus_api/test_mail_to.c:
1595 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1597 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1599 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1600 Added file to fix the build. Sorry.
1602 * src/dbus_api/Makefile.am:
1603 * src/dbus_api/modest-dbus-api.h:
1604 * src/dbus_api/modest-dbus-callbacks.h:
1605 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1606 (modest_dbus_req_handler):
1607 Put constants in a separate header so it can be reused by the
1608 client library, without duplication
1610 * libmodest-dbus-client/Makefile.am:
1611 * libmodest-dbus-client/libmodest-dbus-client.c:
1612 (libmodest_dbus_client_call_helloworld),
1613 (libmodfest_dbus_client_send_mail),
1614 (libmodfest_dbus_client_mailto),
1615 (libmodfest_dbus_client_open_message):
1616 * libmodest-dbus-client/libmodest-dbus-client.h:
1617 (Partly) Implement a send_mail D-Bus method.
1619 * tests/dbus_api/Makefile.am:
1620 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1621 the send_email D-Bus method.
1623 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1627 * libmodest-dbus-client/Makefile.am:
1628 * libmodest-dbus-client/libmodest-dbus-client.c:
1629 * libmodest-dbus-client/libmodest-dbus-client.h:
1630 * tests/dbus_api/Makefile.am:
1631 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1632 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1634 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/easysetup/modest-easysetup-wizard.c:
1637 (create_page_account_details):
1638 * src/maemo/modest-account-settings-dialog.c:
1639 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1640 widgets, because this might not be the default in future versions of the Maemo GTK+.
1641 However, I can not not get capitalization to work even in a simple test case.
1643 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/easysetup/modest-easysetup-wizard.c:
1646 (create_page_custom_incoming), (create_page_custom_outgoing):
1647 * src/maemo/modest-account-settings-dialog.c:
1648 (create_page_account_details), (create_page_incoming),
1649 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1650 instead of using gtk_check_button_with_label(), so they are aligned like the other
1651 widgets, as per the UI spec.
1653 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1655 * src/maemo/easysetup/modest-easysetup-wizard.c:
1656 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1657 * src/widgets/modest-validating-entry.c:
1658 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1659 Modest prefix instead of an EasySetup prefix.
1661 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1663 * src/widgets/modest-validating-entry.h:
1664 * src/widgets/modest-validating-entry.c: (on_insert_text),
1665 Added easysetup_validating_entry_set_max_func(), used to set a callback
1666 to call when the max number of characters is reached. GtkEntry has a max-length
1667 already but is silent about it.
1669 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1670 (create_page_account_details), (create_page_user_details),
1672 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1673 (create_page_account_details), (create_page_user_details),
1674 (create_page_outgoing):
1675 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1676 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1677 the UI spec, when the user tries to enter more than the max number of characters.
1679 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1681 * src/maemo/easysetup/modest-easysetup-wizard.c:
1682 (create_page_user_details), (create_page_custom_incoming),
1683 (create_page_custom_outgoing):
1684 * src/maemo/modest-account-settings-dialog.c:
1685 (create_page_user_details), (create_page_incoming),
1686 (create_page_outgoing):
1687 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1688 (modest_connection_specific_smtp_edit_window_init):
1689 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1690 not appropriate. Bad Maemo-specific defaults!.
1692 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1694 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1695 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1696 (modest_signature_editor_dialog_set_settings):
1697 Disable the label and textview when the checkbox is disabled, and use the
1698 specified (UI spec) default signature text.
1700 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1702 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1703 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1705 * src/modest-defs.h:
1706 * src/modest-account-mgr-helpers.h:
1707 * src/modest-account-mgr-helpers.c:
1708 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1710 * src/maemo/Makefile.am:
1711 * src/maemo/modest-signature-editor-dialog.c:
1712 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1715 * src/maemo/modest-account-settings-dialog.h:
1716 * src/maemo/modest-account-settings-dialog.c:
1717 (modest_account_settings_dialog_finalize), (on_button_signature),
1718 (save_configuration): Use the new dialog when the Edit button is pressed, and
1719 save the changes if necessary, as per the UI spec.
1721 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/Makefile.am:
1724 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1725 based on maemo-develoers email from Dirk.
1727 * src/maemo/easysetup/modest-easysetup-wizard.c:
1728 (create_page_welcome), (create_page_account_details),
1729 (create_page_user_details), (create_page_complete_easysetup),
1730 (create_page_custom_incoming), (create_page_custom_outgoing),
1731 (create_page_complete_custom),
1732 (modest_easysetup_wizard_dialog_init):
1733 * src/maemo/modest-account-settings-dialog.c:
1734 (create_page_account_details), (create_page_user_details),
1735 (create_page_incoming), (create_page_outgoing),
1736 (modest_account_settings_dialog_init):
1737 * src/maemo/modest-connection-specific-smtp-window.c:
1738 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1740 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1742 * src/maemo/easysetup/modest-easysetup-wizard.c:
1743 (create_page_account_details), (create_page_custom_outgoing),
1744 (create_page_complete_custom):
1745 * src/maemo/modest-account-settings-dialog.c:
1746 (create_page_user_details), (create_page_incoming),
1747 (create_page_outgoing):
1748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1749 (modest_connection_specific_smtp_edit_window_init):
1750 Use the correct (UI spec) port min/max, and use horizontal separators,
1753 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1755 * src/maemo/easysetup/modest-easysetup-wizard.c:
1756 (set_default_custom_servernames):
1757 * src/maemo/modest-account-settings-dialog.c:
1758 (create_page_incoming), (on_combo_outgoing_security_changed),
1759 (on_combo_incoming_security_changed), (create_page_outgoing),
1760 (modest_account_settings_dialog_set_account_name),
1761 (save_configuration):
1762 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1763 (on_combo_security_changed),
1764 (modest_connection_specific_smtp_edit_window_init),
1765 (modest_connection_specific_smtp_edit_window_set_connection),
1766 (modest_connection_specific_smtp_edit_window_get_settings):
1767 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1770 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1773 * src/maemo/easysetup/modest-easysetup-wizard.c:
1774 (create_page_custom_outgoing), (create_page_complete_custom):
1775 * src/maemo/modest-account-settings-dialog.c:
1776 (create_page_user_details), (create_page_outgoing):
1777 * src/maemo/modest-account-view-window.c: (button_box_new):
1778 Use changed logical IDs as per the most recent UI spec:
1779 mcen_bd_emailsetup_edit -> mcen_bd_edit
1780 mcen_bd_emailsetup_delete -> mcen_bd_delete
1781 mcen_bd_emailsetup_close -> mcen_bd_close
1783 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1787 * src/dbus_api/Makefile.am:
1788 * src/dbus_api/modest-dbus-callbacks.c:
1789 * src/dbus_api/modest-dbus-callbacks.h:
1790 * src/maemo/modest-platform.c: (modest_platform_init):
1791 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1793 * tests/Makefile.am:
1794 * tests/dbus_api/Makefile.am:
1795 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1797 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/modest-account-settings-dialog.c:
1800 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1801 Removed unnecessary includes.
1803 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1805 * src/maemo/easysetup/modest-easysetup-wizard.c:
1806 * src/maemo/modest-account-settings-dialog.c:
1807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1808 * src/widgets/Makefile.am:
1809 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1810 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1811 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1812 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1813 * src/widgets/modest-secureauth-combo-box.c:
1814 * src/widgets/modest-secureauth-combo-box.h:
1815 * src/widgets/modest-serversecurity-combo-box.c:
1816 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1817 made the GObject names more consistent with the rest of the Modest code.
1819 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/Makefile.am:
1822 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1823 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1824 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1825 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1826 * src/maemo/easysetup/modest-easysetup-wizard.c:
1827 * src/maemo/easysetup/modest-validating-entry.c:
1828 * src/maemo/easysetup/modest-validating-entry.h:
1829 * src/maemo/modest-account-settings-dialog.c:
1830 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1831 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1832 widgets/ because they are used outside of easysetup too. After checking in,
1833 svn will allow me to rename them too.
1835 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1837 * src/gnome/modest-msg-edit-window.c:
1838 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1839 linker error, to fix the build on the GNOME platform.
1840 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1841 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1842 ifdefed out to avoid a warning.
1844 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1846 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1847 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1848 some alternative for GTK+ 2.6.
1850 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1854 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1855 specified for EmailAccountsDialog in UI spec.
1857 * src/maemo/easysetup/modest-easysetup-wizard.c:
1858 * src/maemo/easysetup/modest-easysetup-wizard.h:
1859 * src/maemo/modest-account-settings-dialog.c:
1860 * src/maemo/modest-account-settings-dialog.h:
1861 Reuse a member window widget for the connection-specific SMTP server accounts,
1862 so we can tell it to create/save the accounts only if we actually save changes.
1864 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1865 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1866 (modest_connection_specific_smtp_edit_window_get_settings):
1867 Return a struct instance for temporarily remembering the entered data.
1869 * src/maemo/modest-connection-specific-smtp-window.h:
1870 * src/maemo/modest-connection-specific-smtp-window.c:
1871 (modest_connection_specific_smtp_window_finalize),
1872 (modest_connection_specific_smtp_window_fill_with_connections),
1874 (modest_connection_specific_smtp_window_save_server_accounts),
1875 (update_model_server_names): Do not actually save data until asked,
1876 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1878 (on_selection_changed),
1879 (modest_connection_specific_smtp_window_init): Disable the edit
1880 button when nothing is selected.
1882 * src/modest-account-mgr-helpers.c:
1883 * src/modest-account-mgr-helpers.h:
1884 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1887 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr-helpers.h:
1890 * src/modest-account-mgr-helpers.c:
1891 (modest_account_mgr_get_unused_account_name),
1892 (modest_account_mgr_get_unused_account_display_name): Added these
1893 utility functions, to avoid code duplication.
1895 * src/maemo/easysetup/modest-easysetup-wizard.c:
1896 (create_page_account_details), (create_account):
1897 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1898 (on_combo_security_changed),
1899 (modest_connection_specific_smtp_edit_window_init),
1900 (modest_connection_specific_smtp_edit_window_save_settings):
1901 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1902 * src/maemo/modest-connection-specific-smtp-window.c:
1903 (modest_connection_specific_smtp_window_finalize),
1904 (modest_connection_specific_smtp_window_fill_with_connections),
1905 (on_button_edit), (modest_connection_specific_smtp_window_init):
1906 * src/maemo/modest-connection-specific-smtp-window.h:
1907 Implementing saving of connection-specific server accounts.
1909 But I need to refactor this so we can save the data for each
1910 possible connection-specific account and only actually create the server accounts
1911 when the easysetup finished, or the OK button is pressed on the account settings
1914 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1916 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1917 (on_combo_security_changed):
1918 (modest_connection_specific_smtp_edit_window_init):
1919 Auto-fill the port number as in the account settings.
1921 (modest_connection_specific_smtp_edit_window_set_connection):
1922 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1923 * src/maemo/modest-connection-specific-smtp-window.c:
1924 (fill_with_connections), (on_button_edit),
1925 (modest_connection_specific_smtp_window_init):
1926 Turn the edit window into a dialog to simplify the code, and
1927 set a WM hint as in a GtkDialog, because only a popup can be on top of
1928 another window in Maemo, and popups usually have no WM decoration.
1930 * src/modest-defs.h:
1931 * src/modest-account-mgr-helpers.c:
1932 (modest_account_mgr_set_connection_specific_smtp),
1933 (modest_account_mgr_remove_connection_specific_smtp),
1934 (modest_account_mgr_get_connection_specific_smtp):
1935 * src/modest-account-mgr-helpers.h: Some functions to write the
1936 connection-specific SMTP server information. Not yet used.
1939 * src/widgets/modest-folder-view.c: (text_cell_data):
1940 Fix a warning about an uninitialized variable.
1941 (on_configuration_key_changed): Put an #ifdef around the use
1942 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1944 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1946 * src/maemo/modest-account-settings-dialog.h:
1947 * src/maemo/modest-account-settings-dialog.c:
1948 Added connect_for_modified() utility function to mark the new modified boolean.
1950 (create_page_account_details), (create_page_user_details),
1951 (create_page_incoming), (create_page_outgoing), (on_response),
1952 (modest_account_settings_dialog_init),
1953 (modest_account_settings_dialog_set_account_name):
1954 Only warn about unsaved changes when there are actually unsaved changes.
1956 * src/modest-account-mgr-helpers.c:
1957 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1958 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1959 to get the data from there in future.
1961 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1963 * src/modest-defs.h:
1965 * src/modest-account-mgr-helpers.h:
1966 * src/modest-account-mgr-helpers.c:
1967 Store the security account setting in a single conf key instead of using
1968 the options list, so that the list is left for just the to-be-removed camel hack,
1969 and because gconf_client_set_list() is failing for some reason.
1971 * src/modest-account-mgr.c:
1972 (modest_account_mgr_add_server_account):
1973 * src/maemo/modest-account-settings-dialog.c:
1974 (modest_account_settings_dialog_set_account_name),
1975 (save_configuration): Use the renamed functions.
1978 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1980 * src/widgets/Makefile.am:
1981 * src/widgets/modest-limit-retrieve-combo-box.c:
1982 * src/widgets/modest-limit-retrieve-combo-box.h:
1983 * src/widgets/modest-retrieve-combo-box.c:
1984 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1985 the account settings dialog.
1987 * src/modest-defs.h:
1988 * src/modest-account-mgr-helpers.h:
1989 * src/modest-account-mgr-helpers.c:
1990 (modest_server_account_get_option_secure_auth),
1991 (modest_server_account_set_option_secure_auth):
1992 * src/modest-account-mgr.c:
1993 (modest_account_mgr_add_server_account):
1994 Use the existing AUTH_MECH conf key for the secure-auth setting,
1995 instead of putting it in the list options, because this was actually used already.
1997 * src/maemo/modest-account-settings-dialog.c:
1998 (create_page_account_details),
1999 (modest_account_settings_dialog_set_account_name),
2000 (save_configuration):
2001 * src/maemo/modest-account-settings-dialog.h:
2002 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2003 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2005 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2007 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2008 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2009 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2011 * src/modest-defs.h:
2012 * src/maemo/modest-account-settings-dialog.c:
2013 (create_page_incoming), (on_combo_outgoing_security_changed),
2014 (on_combo_incoming_security_changed), (create_page_outgoing),
2015 (modest_account_settings_dialog_set_account_name),
2016 (save_configuration): Load/Save the port number, and change it when the
2017 security combo changes, to suitable defaults.
2019 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-account-mgr.c:
2022 (modest_account_mgr_add_server_account): Set the security and secure-auth
2023 options, and add a comment saying that the other camel-specific options should be
2026 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2030 * src/modest-tny-account-store.c: (account_list_free),
2031 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2032 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2035 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2037 * src/modest-protocol-info.c:
2038 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2039 is required by our UI spec. Maybe something in our implementation will use this eventually.
2040 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2041 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2042 instead of the previous 0 placeholder.
2044 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2045 secure-auth settings.
2046 * src/modest-account-mgr-helpers.h:
2047 * src/modest-account-mgr-helpers.c:
2048 (modest_server_account_data_get_option_secure_auth),
2049 (modest_server_account_set_option_secure_auth),
2050 (modest_server_account_data_get_option_security),
2051 (modest_server_account_set_option_security): Added this API for getting and setting the security
2052 and secure-auth settings.
2054 * src/maemo/modest-account-settings-dialog.h:
2055 * src/maemo/modest-account-settings-dialog.c:
2056 (modest_account_settings_dialog_finalize), (check_data),
2057 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2058 about changing titles.
2059 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2060 (save_configuration): Save the security and secure-auth settings.
2062 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2063 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2065 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2067 * src/modest-defs.h:
2068 * src/modest-account-mgr.c:
2069 (modest_account_mgr_add_server_account):
2070 Added and used defines for the options key and value pair strings,
2071 that are used so far, though they do not seem to correspond to anything in our
2072 UI specs or ModestProtocol enum.
2074 * src/modest-account-mgr-helpers.h:
2075 * src/modest-account-mgr-helpers.c:
2076 (compare_option_strings_for_name),
2077 (modest_server_account_data_get_option_value),
2078 (modest_server_account_data_get_option_bool),
2079 (modest_account_mgr_get_server_account_option):
2080 Added helper functions for parsing the options GSList.
2082 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2084 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2085 display name is based on the supplied account name.
2086 * src/modest-account-mgr.c:
2087 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2088 with an inefficient, but good-enough, implementation.
2090 * src/maemo/easysetup/modest-easysetup-wizard.c:
2091 (create_page_account_details), (on_before_next), (create_account):
2092 Check for existing display names rather than (non-user-visible) account names, and just
2093 create and set a unique account name at the end.
2095 * src/maemo/modest-account-settings-dialog.c:
2096 (modest_account_settings_dialog_init),
2097 (modest_account_settings_dialog_set_account_name),
2098 (create_page_incoming): Show the display name, instead of the account name.
2099 (on_response): Do some (not all) extra checks, as in the UI spec.
2100 (save_configuration): Save the display name if it was changed.
2102 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2104 * po/en_GB.po: Added needed logical ID and translation.
2105 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2106 (init_view): Made the is-default column clicking work.
2108 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/easysetup/Makefile.am:
2112 * src/maemo/easysetup/modest-easysetup-wizard.c:
2113 (modest_easysetup_wizard_dialog_init):
2114 * src/maemo/easysetup/provider-data-test.keyfile:
2115 * src/maemo/easysetup/provider-data.keyfile:
2116 Moved the provider data file to the new modest-providers-data package and used it from there.
2118 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-local-folder-info.c:
2121 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2122 N_() was already used on the static strings, but this just marks it for translation without
2123 using the translation.
2125 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2127 * src/maemo/modest-account-settings-dialog.c:
2128 (create_page_incoming),
2129 (modest_account_settings_dialog_set_account_name):
2130 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2131 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2132 I will do this if nobody else gets there first.
2134 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2136 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2137 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2138 save the security stuff.
2140 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2142 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2143 Set the email address and user fullname, which I now see must be
2146 * src/maemo/modest-account-settings-dialog.h:
2147 * src/maemo/modest-account-settings-dialog.c:
2149 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2150 leave-on-server and authentication.
2151 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2154 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-account-settings-dialog.c:
2158 * src/maemo/modest-account-settings-dialog.h:
2159 Most (but not all) of the widgets are now present as specified by the UI spec.
2160 No changes are yet saved, and some details are not properly shown yet.
2162 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2164 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/Makefile.am:
2167 * src/maemo/modest-account-settings-dialog.c:
2168 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2169 an existing account. Doesn't do much yet.
2171 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2172 Open the accounts settings dialog when Edit is clicked.
2174 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/easysetup/Makefile.am:
2177 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2179 * src/maemo/easysetup/modest-easysetup-wizard.c:
2180 (modest_easysetup_wizard_dialog_init):
2181 Try to get the source directory from the build system,
2182 instead of hard-coding "./" into the source code, when opening our local
2183 copies of the configuration files.
2184 But this still fails when opening the wizard from the Accounts window,
2185 maybe because the working directory seems to change at runtime.
2186 So the wizard will fail the second time unless you copy the files into their
2187 proper locations - see the stdout warnings for the paths.
2189 (create_page_account_details),(on_before_next):
2190 Check for existing non-server accounts instead of server accounts,
2191 so the default account name is useful again, and to prevent trying to
2194 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2195 Show the wizard when New is clicked.
2197 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2198 (init_view): Show the column headers, and show the columns that are
2199 specified in the UI specs. However, something in Maemo's GTK+ prevents
2200 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2201 change the default account. This is despite unsetting the special properties.
2203 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2205 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2206 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2207 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2208 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2209 to make that clearer.
2210 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2212 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/modest-account-view-window.c:
2215 (modest_account_view_window_init),
2216 (modest_account_view_window_new):
2217 Use the same buttons as specified in the
2218 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2219 the existing widgets, which never had a chance of working.
2220 Put the ModestAccountView treeview in a scrolled window.
2221 Do not repeat the initialization in both _init() and _new().
2223 * src/widgets/modest-account-view.c: (update_account_view):
2224 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2225 this widget and window shows no accounts.
2227 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2229 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2231 * src/maemo/easysetup/modest-easysetup-wizard.c:
2232 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2233 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2234 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2237 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2238 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2239 accounts exist yet, as in the UI spec.
2241 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2243 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/Makefile.am:
2246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2247 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2248 New window for editing connection-specific smtp details.
2249 Not fully implemented.
2251 * src/maemo/modest-connection-specific-smtp-window.c:
2252 (modest_connection_specific_smtp_window_finalize) :
2253 unref the tree model.
2254 (on_button_edit): Show the edit window.
2256 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2258 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2261 * src/maemo/Makefile.am:
2262 * src/maemo/modest-connection-specific-smtp-window.c:
2263 * src/maemo/modest-connection-specific-smtp-window.h:
2264 New window for showing the list of connections, for connection-specific
2265 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2266 * src/maemo/easysetup/modest-easysetup-wizard.c:
2267 (create_page_custom_outgoing): Show the new window when the button is clicked.
2269 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2271 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2272 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2273 * src/maemo/modest-msg-edit-window.c:
2274 (modest_msg_edit_window_insert_image):
2275 * src/modest-conf.c: (modest_conf_key_escape):
2276 * src/modest-mail-operation.c:
2277 (modest_mail_operation_send_new_mail):
2278 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2279 (modest_ui_actions_on_new_account):
2280 * src/widgets/modest-attachment-view.c: (update_filename_request):
2281 * src/widgets/modest-mail-header-view.c:
2282 Corrected warnings that were breaking the build, by commenting out unused variables,
2283 and a function, and by including a header.
2285 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2287 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2288 so we can #ifdef around platform-specific code when necessary.
2289 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2290 to allow this to build for the GNOME platform too.
2292 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/easysetup/modest-easysetup-wizard.c:
2295 Added util_increment_name() and used it in create_page_account_details()
2296 to make sure that the default account name is always a new name.
2298 (modest_easysetup_wizard_dialog_init),
2299 (set_default_custom_servernames): Some minor memory management fixes.
2301 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2305 * src/modest-runtime.c: (init_i18n): Restored the translation
2306 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2307 are defined in config.h, and the translations are installed.
2309 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2310 is defined for translation.
2312 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2314 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2316 * src/maemo/easysetup/modest-easysetup-wizard.c:
2317 (modest_easysetup_wizard_dialog_init):
2318 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2319 Use realistic paths (though they should use $prefix generically) to the
2320 mcc_mapping and provider-data.keyfile files which might work when they
2321 are installed by the future version of the operator-wizard package,
2322 and then fallback to paths in our source code, with an explanatory
2325 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2329 * src/maemo/Makefile.am:
2330 * src/maemo/easysetup/: Added files from the previously-exernal
2331 osso-modest-easysetup.
2332 * src/maemo/modest-main-window-ui.h:
2333 * src/modest-ui-actions.c:
2334 * src/modest-ui-actions.h:
2335 Added modest_ui_actions_on_new_account() as a signal handler for the
2336 New Account menu item. It shows the easysetup wizard.
2337 * po/en_GB.po: Added additional needed logical IDs and translations.
2339 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2340 Apparently ChangeLog is not used for some vague Nokia legal reasons.