1 2007-06-05 Christian Kellner <ckellner@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 Fix small typo in doc (why do you always see them
5 AFTER committing stuff?)
8 2007-06-05 Christian Kellner <ckellner@openismus.com>
10 * libmodest-dbus-client/libmodest-dbus-client.c:
11 (libmodest_dbus_client_search):
12 Initialize hit list with NULL. Also set folder list
13 to "" if NULL was supplied.
16 2007-06-03 Christian Kellner <ckellner@openismus.com>
18 * libmodest-dbus-client/libmodest-dbus-client.c:
19 (modest_search_hit_list_free):
20 Make it save to call it with NULL.
22 * src/dbus_api/modest-dbus-callbacks.c:
23 * src/modest-search.c:
24 Return full ModestSearchHits as the search result list not TnyHeader
25 since can't be around withouth the correspoding TnyFolder.
27 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
29 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
30 Added currently commented code to check for secure auth
32 * src/maemo/modest-account-settings-dialog.c: (on_response),
33 (save_configuration), (show_ok):
34 Fixed projects.maemo.org bugs NB #59248 and #59251
36 * src/maemo/modest-maemo-utils.c:
37 (on_camel_account_get_supported_secure_authentication_status),
38 (on_camel_account_get_supported_secure_authentication),
39 (modest_maemo_utils_get_supported_secure_authentication_methods):
40 * src/maemo/modest-maemo-utils.h:
41 Moved get_supported_secure_authentication() method here to be able
42 to use it from easysetup wizard.
44 * src/modest-pair.c: (on_pair_compare_as_string):
45 Should compare string with first part of pair and not
46 strcmp pairs which will crash.
48 * src/modest-protocol-info.c:
49 (modest_protocol_info_protocol_is_store):
50 * src/modest-protocol-info.h:
51 Added modest_protocol_info_get_auth_protocol_name()
53 2007-06-03 Armin Burgmeier <armin@openismus.com>
55 * src/modest-mail-operation.c:
56 (modest_mail_operation_get_msgs_full): Set priv->account also when
57 only retrieving a single message. This avoids a crash when canceling
60 (modest_mail_operation_notify_end): Do not explicitely remove the
61 operation from the queue but only emit the progress_changed signal.
62 The queue itself listens to that signal to remove the operation when
63 it is finished. This reduces coupling and removes a potential deadlock
64 when modest_mail_operation_notify_end() is called from the queue
65 itself. If that is a problem performance-wise, I would suggest to
66 implement a status-changed signal or something.
68 * src/modest-mail-operation-queue.c: Make sure to never call a
69 function from another file while the queue is locked. This (hopefully)
70 fixes another deadlock when exiting the application while retrieving
73 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
75 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
76 Fixed build if libogs is not available
78 2007-06-03 Christian Kellner <ckellner@openismus.com>
80 * libmodest-dbus-client/libmodest-dbus-client.h:
81 * libmodest-dbus-client/libmodest-dbus-client.c:
82 (libmodest_dbus_client_delete_message):
83 Implement deletion of messages (Client side).
85 (modest_search_hit_free),
86 (modest_search_hit_list_free):
87 Utility functions to free the result hits.
89 * src/dbus_api/modest-dbus-api.h:
90 * src/dbus_api/modest-dbus-callbacks.c:
92 (modest_dbus_req_handler):
93 Implement deletion of messages (Server side).
95 * tests/dbus_api/test_search.c: (main):
98 * tests/dbus_api/Makefile.am:
99 * tests/dbus_api/test_delete_message:
100 Add little test for the message deletion logic
102 2007-06-03 Armin Burgmeier <armin@openismus.com>
104 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
105 when the operation queue was not empty. projects.maemo.org bug
108 2007-06-03 Armin Burgmeier <armin@openismus.com>
110 * src/widgets/modest-account-view.c
111 (on_account_default_toggled): Toggle default account column
112 explicitely instead of waiting for gconf notification (which is
113 currently ignored). This should fix projects.maemo.org bug NB#56910
114 for now. It should probably be removed when gconf notifications are
117 2007-06-03 Christian Kellner <ckellner@openismus.com>
119 * libmodest-dbus-client/libmodest-dbus-client.c:
120 Removed debugging spew.
122 * src/dbus_api/modest-dbus-callbacks.c:
123 Added debugging info.
125 * src/modest-search.c:
126 (modest_search_all_accounts):
127 Use tny_account_store_get_accounts () on the account store
128 to get all accounts which is the way to get all accounts.
130 * tests/dbus_api/test_search.c: (main):
131 Make it possible to supply the search term on the command line.
133 2007-06-03 Christian Kellner <ckellner@openismus.com>
135 * libmodest-dbus-client/libmodest-dbus-client.c:
136 * libmodest-dbus-client/libmodest-dbus-client.h:
137 Implement searching for mesages over raw dbus. (Client side)
139 * src/dbus_api/Makefile.am:
140 * src/dbus_api/modest-dbus-api.h:
141 * src/dbus_api/modest-dbus-callbacks.c:
142 * src/dbus_api/modest-dbus-callbacks.h:
143 Search framework (Server side). Also implement on_idle_open_message().
145 * src/maemo/modest-platform.c: (modest_platform_init):
146 Prepare for raw dbus/osso rpc interaction.
148 * src/modest-search.h:
149 Changed minsize from unspecific guint to guint32.
151 * src/modest-search.c:
153 Added strange hack which magically made tnymail work.
155 (modest_search_folder),
156 (modest_search_account),
157 (modest_search_all_accounts):
158 Implement helper functions to search all accounts, specific account
161 * tests/dbus_api/Makefile.am:
162 * tests/dbus_api/test_open_message.c:
163 Read url to open from commandline.
165 * tests/dbus_api/test_search.c:
166 Implement small test for dbus search stuff
168 2007-06-02 Armin Burgmeier <armin@openismus.com>
170 * src/maemo/modest-account-settings-dialog.c: Changed window title to
171 include account type and account title. This fixes projects.maemo.org
174 * src/maemo/modest-account-view-window.c: Set a title for the window.
176 2007-06-02 Armin Burgmeier <armin@openismus.com>
178 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
179 incoming and outgoing server name based on email address and server
180 types as long as the names have not been edited manually. This fixes
181 projects.maemo.org bug NB#58671.
183 2007-06-02 Armin Burgmeier <armin@openismus.com>
185 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
186 server type cannot be changed in future to the incoming details page
187 when creating an account. This fixes projects.maemo.org bug NB#59029.
189 2007-06-02 Armin Burgmeier <armin@openismus.com>
191 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
192 and assigned max width chars so that they wrap instead of being
193 truncated. Fixes projects.maemo.org bug NB#56126.
195 2007-06-02 Armin Burgmeier <armin@openismus.com>
197 * src/maemo/modest-connection-specific-smtp-window.c: Add an
198 introductory note to the connection specific smtp servers dialog, as
199 section 8.12 of the email UI specification requires. This fixes
200 projects.maemo.org bug NB#59212.
202 2007-06-01 Murray Cumming <murrayc@murrayc.com>
204 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
205 Check for running mail operations, and offer to cancel them, as per the UI
206 spec. This fixes projects.maemo.org bug NB#59041 .
207 However, I suspect that tinymail may still use the network connection
208 in ways that we cannot detect or cancel. But it should at least adapt to
211 2007-06-01 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-tny-account-store.c: (recreate_all_accounts),
214 (get_cached_accounts), (get_server_accounts): Do more sensible
215 ref-counting of the temporarily-cached outbox accounts list. This seems
216 to fix a crash when entering the password when the password was wrong.
218 2007-06-01 Murray Cumming <murrayc@murrayc.com>
220 * src/gnome/modest-main-window.c: (connect_signals):
221 * src/modest-tny-account-store.c: (get_password),
222 (modest_tny_account_store_alert): Added comments and clues and
223 commented-out code about how we currently fail to deal with connection
224 errors and wrong passwords, and how we should.
226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
228 * src/widgets/modest-retrieve-combo-box.c:
229 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
230 This fixes projects.maemo.org bug NB#58472 .
232 2007-06-01 Murray Cumming <murrayc@murrayc.com>
234 * src/maemo/easysetup/modest-easysetup-wizard.c:
235 (create_page_complete_easysetup):
236 (create_page_complete_custom): Correct the last commit,
237 putting the correct sentences in the correct pages.
239 2007-06-01 Murray Cumming <murrayc@murrayc.com>
241 * src/maemo/easysetup/modest-easysetup-wizard.c:
242 (create_page_complete_custom): Show the second sentence of text
243 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
246 2007-06-01 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
249 Set the leave-on-server conf key by default. This fixes
250 projects.maemo.org bug NB#59258 .
252 2007-06-01 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/modest-account-view-window.c:
255 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
256 logical ID for the confirmation messages. Fixed projects.maemo.org bug
259 2007-06-01 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/easysetup/modest-easysetup-wizard.c:
262 (create_caption_new_with_asterisk):
263 * src/maemo/modest-account-settings-dialog.c:
264 (create_caption_new_with_asterisk):
265 Uncomment the code to add the asterisk, because they are no longer in the
266 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
267 (update_incoming_server_title): Add an asterisk here too.
269 2007-06-01 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-maemo-global-settings-dialog.c:
272 (current_connection): Check that we are even connected before trying to
273 get the current connection name, to prevent a warning.
275 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
276 Change the comments because tny_maemo_conic_device_connect() is now meant to
278 * src/modest-mail-operation.c:
279 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
280 make sure we have a connection and fail if we can't connect.
282 2007-05-31 Murray Cumming <murrayc@murrayc.com>
284 * src/maemo/modest-main-window.c:
285 (on_account_store_connecting_finished): Do not try to get the
286 connection ID if we are not really connected. I am surprised that
287 this signal handler is called when we are not connected.
289 2007-05-31 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-error.h:
292 * src/modest-ui-actions.c:
293 (modest_ui_actions_get_msgs_full_error_handler):
294 Renamed an enum, added comments, added an enum
295 for retrieve-limit errors.
297 * src/modest-mail-operation.c: (foreach_add_item),
298 (internal_folder_observer_update), (update_account_thread),
299 (modest_mail_operation_get_msgs_full):
300 (modest_mail_operation_update_account),
301 Added comments about how this works, and some code that should
302 (but does not) check the retrieve-limit. See the TODO comment.
304 2007-05-31 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
307 Initialize help_id to fix the build. Warnings are good.
309 2007-05-31 Murray Cumming <murrayc@murrayc.com>
311 * src/widgets/modest-hbox-cell-renderer.c:
312 (modest_hbox_cell_renderer_append):
313 * src/widgets/modest-vbox-cell-renderer.c:
314 (modest_vbox_cell_renderer_append):
315 Fix the last commit by doing an extra ref.
317 2007-05-31 Murray Cumming <murrayc@murrayc.com>
319 * src/widgets/modest-hbox-cell-renderer.c:
320 (modest_hbox_cell_renderer_append):
321 * src/widgets/modest-vbox-cell-renderer.c:
322 (modest_vbox_cell_renderer_append):
323 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
324 to fix the build with Maemo Bora.
325 However, there seems to be a remaining crash, probably due to reference
328 2007-05-30 Murray Cumming <murrayc@murrayc.com>
330 * src/modest-tny-account.c:
331 (modest_tny_account_new_for_local_folders):
332 Use hildon_file_system_info_async_new() to get a better name for
333 the memory card account, setting it as the account name.
334 The timing seems to work, but this is probably
335 not the best place to do this. See the TODO comment.
336 * src/maemo/modest-main-window.c: (create_details_widget):
337 * src/widgets/modest-folder-view.c: (text_cell_data):
338 Use the tny account name instead of hardcoding a name.
340 2007-05-30 Christian Kellner <ckellner@openismus.com>
342 * src/modest-search.c: (modest_search):
343 Correctly set part_search_func even if we have already parsed
344 the query and thus a valid OgsTextSearcher object.
346 2007-05-30 Christian Kellner <ckellner@openismus.com>
349 Search and check for libogs.
352 Incooparte the ogs build env.
354 * src/modest-mime-part-search-stream.c:
355 * src/modest-mime-part-search-stream.h:
356 Removed since we do the real searching now in modest-search.c.
358 * src/modest-search.c:
359 * src/modest-search.h:
360 Implement support for ogs. We use that if available and requested
361 and fall back to modest_text_utils_utf8_strcmp (). The search logic
362 should now handle the corner case when the search term is spread
363 across multiple reads.
364 Also the logic in modest_search () was corrected to search all
365 requested fields until one is found.
367 2007-05-30 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
372 * src/modest-init.c: Made modest_init_local_folders() take a
373 path and be public so we can iniitialize maildir folders on
376 * src/modest-local-folder-info.h:
377 * src/modest-local-folder-info.c:
378 (modest_local_folder_info_get_maildir_path): Add a path parameter.
380 * src/modest-tny-account.c:
381 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
382 still means the standard local-folders path on the local volume.
384 * src/modest-tny-account-store.c:
385 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
386 signal so we can detect mount/unmount of the MMC1 card, and do an update of
387 all accounts when that happens.
388 (get_server_accounts): If the MMC1 card is mounted, create a store account for
389 this too, so it shows up in the treeview.
391 2007-05-28 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/modest-maemo-global-settings-dialog.c:
394 (current_connection):
395 * src/widgets/modest-global-settings-dialog.c:
396 (current_connection_default):
397 Use the enum values instead of 0, 1 and -1,
398 to make the code clearer.
400 * src/modest-account-mgr-helpers.c:
401 (modest_account_mgr_get_connection_specific_smtp): Make this code
404 * src/modest-runtime.h:
405 * src/modest-runtime.c:
406 Added modest_runtime_remove_all_send_queues().
407 * src/maemo/modest-main-window.c:
408 (on_account_store_connecting_finished): Recreate the send queues,
409 using the appropriate transport accounts for this new connection.
410 Some futher adapting might be needed if the old send queues are not
411 automatically stopped at this point.
413 * src/modest-tny-account-store.c: (get_server_accounts):
414 Create the connection-specific transport accounts, so that they can
415 be found later by their ID.
417 * src/modest-tny-account.h:
418 * src/modest-tny-account.c:
419 Added modest_tny_account_new_from_server_account_name().
420 modest_tny_account_new_from_server_account(): Do not create the
421 send queues here, because they will be
422 recreated anyway when the connection changes for the first time.
424 2007-05-28 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-local-folder-info.h:
427 * src/modest-local-folder-info.c:
428 (modest_per_account_local_outbox_folder_info_get_maildir_path),
429 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
430 tbox_folder): Take a modest account name instead of a server TnyAccount,
431 so we can have per-modest-account rather than per-transport-account
433 We must make sure that we change or recreate the exisitng send queues
434 when the connection changes for connection-specific transport accounts.
436 * src/modest-tny-account-store.c:
437 (create_per_account_local_outbox_folders): Create outboxed per modest
438 account, not per transport account.
440 * src/modest-tny-account.h:
441 * src/modest-tny-account.c:
442 (modest_tny_account_get_special_folder): For outboxes, get the
443 parent modest account name. The account is ignored for other folders.
444 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
445 modest account name rather than a server TnyAccount.
447 2007-05-25 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-tny-account.c:
450 (modest_tny_account_new_from_server_account):
451 Call modest_runtime_get_send_queue() immediately after creating transport
452 accounts, so that they start trying to send email from the outbox as soon
453 as possible at startup. This is probably what we want.
455 * src/modest-mail-operation.c: (update_account_thread):
456 * src/modest-runtime.c: (modest_runtime_get_send_queue):
457 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
458 * src/modest-tny-send-queue.h:
459 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
460 (modest_ui_actions_on_send):
461 Added comments about how sending works, though it needs some more work.
463 2007-05-25 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account.c:
466 (modest_tny_account_get_special_folder): Add TODO because this fails when
468 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
469 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
470 Do not try to show this window when there is no active account. The UI
471 specs does not tell us what to do in this case.
473 2007-05-24 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/Makefile.am:
478 * src/widgets/Makefile.am: Some dist fixes.
480 2007-05-24 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/modest-connection-specific-smtp-window.c:
483 (on_button_edit): Make the code clearer, to prevent a double free.
485 2007-05-24 Murray Cumming <murrayc@murrayc.com>
487 * src/maemo/modest-account-settings-dialog.c:
488 (modest_account_settings_dialog_set_account_name),
489 Check the connection-specific smtp servers checkbox if there are any.
491 * src/maemo/modest-connection-specific-smtp-edit-window.c:
492 (modest_connection_specific_smtp_edit_window_init):
493 Start with a suitable port number.
495 * src/modest-account-mgr-helpers.h:
496 * src/modest-account-mgr-helpers.c: Added
497 modest_account_mgr_get_has_connection_specific_smtp().
499 (modest_account_mgr_set_connection_specific_smtp),
500 (modest_account_mgr_remove_connection_specific_smtp),
501 (modest_account_mgr_get_has_connection_specific_smtp),
502 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
503 connection-specific smtp server accounts in the account, rather than
504 the server account conf dir.
506 This fixes bug projects.maemo.org bug NB#58263 .
508 * src/modest-tny-account-store.c:
509 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
510 if there are no server accounts yet, to prevent an infinite loop when there
511 are no accounts. Document that one must be called before the other.
513 2007-05-24 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-account-mgr-helpers.c:
516 (modest_account_mgr_get_default_account): Make sure that at least
517 one account is always the default, if there are any enabled accounts.
518 This is just a sanity check that shouldn't be necessary.
520 * src/modest-account-mgr-priv.c:
521 (_modest_account_mgr_account_from_key): Unescape the conf key to
522 get the real account name. For instance, this is an issue if a space
523 was in the account name, which can happen because the account name
524 is generated from the display name.
525 (_modest_account_mgr_get_account_keyname): Always escape the
527 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
528 Unescape the conf keys to get the real account names.
530 For instance, previously the is-default radio button in the accounts
531 list was not checked for any accounts at first. This fixes that,
532 and might fix several similar bugs.
534 2007-05-23 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
537 Removed some debug printfs.
539 2007-05-23 Murray Cumming <murrayc@murrayc.com>
541 Modest on-disk outbox directories are now here, for instance:
542 $HOME/.modest/outboxes/<account-id-1>/outbox
543 $HOME/.modest/outboxes/<account-id-2>/outbox
545 $HOME/.modest/local-folders/outbox
546 so we can have a separate outbox for each account.
547 But they are shown as one outbox in the GtkTreeView, by using a
548 TnyMergeFolder in a ModestTnySimpleFolderStore.
551 * src/modest-tny-simple-folder-store.c:
552 * src/modest-tny-simple-folder-store.h:
553 Added ModestTnySimpleFolderStore, used to contain folders from
554 other folder stores, such as other accounts.
556 * src/modest-tny-outbox-account.h:
557 * src/modest-tny-outbox-account.c:
558 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
559 used for the per-account local outbox folders.
561 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
562 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
563 only use this (internally) now for the non-outbox local folders.
566 * src/modest-init.c: Added modest_init_one_local_folder(), for
567 setting up the directory structure for each local folder.
569 * src/modest-local-folder-info.c:
570 (modest_per_account_local_outbox_folder_info_get_maildir_path),
571 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
573 * src/modest-local-folder-info.h:
574 * src/modest-tny-account-store.c: (on_account_removed),
575 (on_account_changed), (create_per_account_local_outbox_folders),
576 (get_server_accounts), (modest_tny_account_store_get_accounts),
577 (modest_tny_account_store_get_tny_account_by_account),
578 (modest_tny_folder_store_is_virtual_local_folders):
580 * src/modest-tny-account.h:
581 * src/modest-tny-account.c:
582 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
583 to create an on-disk per-account local outbox folder for each
585 (create_per_account_local_outbox_folders): Create a local outbox folder
586 for each transport account.
587 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
588 for all local folders.
590 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
591 instead of using g_object_get/set() directly. It is clearer.
593 (modest_tny_folder_store_get_message_count),
594 (modest_tny_folder_store_get_local_size
595 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
596 because we now use these with non-acount folder stores.
598 (modest_tny_account_get_special_folder),
599 (modest_tny_account_new_from_server_account),
600 (modest_tny_account_new_from_account):
601 (recurse_folders): Adjust to the new outbox system.
603 * src/modest-tny-folder.h:
604 * src/modest-tny-folder.c:
605 (modest_tny_folder_is_local_folder),
606 (modest_tny_folder_get_local_folder_type),
607 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
609 * src/widgets/modest-main-window.h:
610 * src/maemo/modest-main-window.c: (create_details_widget),
611 (modest_main_window_set_contents_style): Show details for any folder store,
614 (modest_tny_folder_get_rules):
615 Remove the const. C does not support constness enough for this.
617 * src/modest-ui-actions.c:
618 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
619 make all outboxes appear as one, in the usual local-folders tree node.
621 (set_active_account_from_tny_account),
622 (modest_ui_actions_on_folder_selection_changed):
623 * src/widgets/modest-folder-view.c: (text_cell_data),
624 (icon_cell_data), (filter_row),
625 (add_account_folders_to_merged_folder),
626 (add_account_folders_to_simple_folder_store), (),
627 (get_cmp_rows_type_pos), (cmp_rows),
628 (modest_folder_view_set_account_id_of_visible_server_account):
629 Adjust to the new outbox system, using generic folder stores and folders
632 2007-05-23 Christian Kellner <ckellner@openismus.com>
634 * src/modest-mail-operation.c:
635 (modest_mail_operation_update_account):
636 Use info->max_size instead of unintialized local var [small
637 build fix]. (Added TODO to review that change since I don't
640 2007-05-23 Marcus Bauer <marcusb@openismus.com>
642 * libmodest-dbus-client/libmodest-dbus-client.c:
643 (libmodest_dbus_client_compose_mail): function added
644 * src/dbus_api/modest-dbus-api.h:
645 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
646 (on_compose_mail): Implementation of the SendAsMail functionality
648 2007-05-22 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-account-mgr.c:
651 (modest_account_mgr_add_server_account): Set the secure-connection
652 conf key for transport accounts as well as store accounts. I don't know
653 why the if was there. For instance, this makes sure that we use SSL
654 for the gmail preset from the easysetup wizard.
656 2007-05-22 Murray Cumming <murrayc@murrayc.com>
658 * src/gnome/modest-main-window.c:
659 (on_account_store_connecting_finished), (connect_signals):
660 * src/maemo/modest-main-window.c:
661 (on_account_store_connecting_finished), (connect_signals),
662 (modest_main_window_new):
663 Handle TnyAccountStore::connecting-finished instead of
664 TnyDevice::connection-changed, because we cannot actually perform
665 operations on accounts until TnyAccountStore has itself responded to
666 the TnyDevice::connection-changed signal. This prevents a GError from
668 Do not try to update at startup, because we (at least on scratchbox)
669 already do an update at startup when the device goes online.
670 This prevents a GError from tinymail.
671 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
672 Added TODO about stopping simultaneous operations.
674 2007-05-21 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
677 * src/modest-mail-operation-queue.c:
678 (modest_mail_operation_queue_remove):
679 * src/modest-tny-account-store.c: When GErrors happen, give more clues
680 about where they happened.
682 2007-05-21 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-ui-actions.c:
685 (modest_ui_actions_on_password_requested): Make sure that the remember
686 output parameter is always TRUE.
688 2007-05-21 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
691 Show a OK/Cancel dialog if the error is a question, though we still do not
692 know anything more about what we are asking the user.
693 * src/widgets/modest-folder-view.c: (on_drag_data_received):
694 Fix an uninitialized variable (helper). This is a logic error, however.
696 2007-05-21 Christian Kellner <ckellner@openismus.com>
698 * src/modest-search.h:
699 Correct bit shifting in the ModestSearchFlags enum.
701 2007-05-21 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-tny-account.c:
704 (modest_tny_account_new_from_server_account): Do not use the lsub and
705 check-all hard-coded IMAP options when using POP.
707 2007-05-21 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-account.c:
710 (modest_tny_account_new_from_server_account):
711 Use NULL for the secure-auth method for POP when Password auth has been
712 specified by the user, as we already do for IMAP. "auth=Login" causes
713 an error from camel or the server.
715 2007-05-17 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/modest-account-settings-dialog.c:
718 (create_page_account_details),
719 (modest_account_settings_dialog_set_account_name):
720 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
721 for the leave-on-server checkbox, rathr than just the checkbox, when
722 the protocol is not POP.
724 2007-05-17 Murray Cumming <murrayc@murrayc.com>
726 * src/widgets/modest-account-view.c:
727 * src/widgets/modest-account-view.h:
728 Added modest_account_view_select_account() which will be useful later
729 to asynchronously re-select the edited account.
731 2007-05-17 Murray Cumming <murrayc@murrayc.com>
733 * src/maemo/modest-account-settings-dialog.c:
734 (modest_account_settings_dialog_set_account_name):
735 Automatically choose the port numbers based on the secure authentication
736 methods, if they have not been chosen before.
737 This fixes projects.maemo.org bug NB#56273 .
739 2007-05-17 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/modest-main-window-ui.h:
742 * src/modest-ui-actions.c:
743 * src/modest-ui-actions.h:
744 Connect the Tools/SMTP Servers menu item to
745 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
746 SMTP servers dialog, as in the UI specification and saves changes when it
747 is closed. This fixed projects.maemo.org bug NB#56305 .
749 2007-05-17 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-connection-specific-smtp-window.c:
752 (modest_connection_specific_smtp_window_init):
753 Use gtk_window_set_default_size() to make this window big enough, so
754 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
756 2007-05-17 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/modest-connection-specific-smtp-edit-window.h:
759 * src/maemo/modest-connection-specific-smtp-edit-window.c:
760 (modest_connection_specific_smtp_edit_window_init),
761 Do not try to connect to a combobox signal before the combobox exists.
762 This fixes the cras in projects.maemo.org bug NB#56288 .
763 (modest_connection_specific_smtp_edit_window_get_settings):
764 Remove the server_account_name parameter which was being checked for NULL
765 though it was not used.
767 * src/maemo/modest-connection-specific-smtp-window.c:
768 (modest_connection_specific_smtp_window_fill_with_connections),
769 (on_button_edit), (modest_connection_specific_smtp_window_init):
770 Correct the number of treemodel columns to prevent a warning.
771 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
772 libconic does not work.
774 2007-05-16 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-tny-account.c:
777 (modest_tny_account_new_from_server_account):
778 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
779 SMTP when "None" was chosen by the user. However, with my SMTP server that
780 does not support ANONYMOUS, the emails do not leave the Outbox and I see
783 2007-05-16 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
786 to explain the memory management issue with the ID in the ModestPair.
788 * src/gnome/modest-account-assistant.c: (add_receiving_page),
789 (add_sending_page), (modest_account_assistant_finalize):
790 * src/gnome/modest-gnome-global-settings-dialog.c:
791 (create_updating_page), (create_composing_page):
792 * src/gnome/modest-msg-edit-window.c: (get_transports),
793 (init_window), (modest_msg_edit_window_finalize),
794 (modest_msg_edit_window_get_msg_data):
795 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
796 * src/gnome/modest-transport-widget.c:
797 (modest_transport_widget_finalize), (smtp_configuration):
798 * src/maemo/modest-maemo-global-settings-dialog.c:
799 (create_updating_page), (create_composing_page):
800 * src/maemo/modest-msg-edit-window.c: (get_transports),
801 (init_window), (modest_msg_edit_window_finalize),
802 (modest_msg_edit_window_get_msg_data),
803 (modest_msg_edit_window_free_msg_data):
804 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
805 (modest_store_widget_finalize):
806 * src/maemo/modest-transport-widget.c:
807 (modest_transport_widget_finalize), (smtp_configuration):
808 * src/modest-main.c: (send_mail):
809 * src/widgets/modest-combo-box.h:
810 * src/widgets/modest-global-settings-dialog-priv.h:
811 * src/widgets/modest-global-settings-dialog.c:
812 (modest_global_settings_dialog_finalize):
813 * src/widgets/modest-msg-edit-window.h:
814 Whenever using modest_combo_box_new(), keep the ModestPairList alive
815 as long as the combo box, to prevent use of freed memory for the ID.
817 2007-05-15 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
820 get_accounts(), to make this clearer. Do not check for the enabled gconf
821 key, because we do not use this for server accounts (at least, not yet).
822 This allows us to send email again.
824 2007-05-15 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-platform.c:
827 (on_modest_conf_update_interval_changed), (modest_platform_init):
828 Only respond to this particular key change. All these strcmp()s cannot be
831 2007-05-15 Murray Cumming <murrayc@murrayc.com>
833 * src/maemo/modest-maemo-global-settings-dialog.c:
834 (current_connection): Prevent a crash in scratchbox when
835 ny_maemo_conic_device_get_current_iap_id() returns NULL.
836 * src/maemo/modest-platform.c:
837 (on_modest_conf_update_interval_changed), (modest_platform_init):
838 Get the update interval from gconf and reset it when the gconf key changes.
840 2007-05-15 Murray Cumming <murrayc@murrayc.com>
842 * src/modest-protocol-info.c:
843 * src/modest-protocol-info.h: Adde enum-specific get functions,
844 instead of using a ModestProtocolType enum parameter.
846 * src/gnome/modest-account-assistant.c:
847 * src/gnome/modest-store-widget.c:
848 * src/gnome/modest-store-widget.h:
849 * src/gnome/modest-transport-widget.c:
850 * src/gnome/modest-transport-widget.h:
851 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
852 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
853 * src/maemo/easysetup/modest-easysetup-wizard.c:
854 * src/maemo/modest-account-settings-dialog.c:
855 * src/maemo/modest-account-settings-dialog.h:
856 * src/maemo/modest-store-widget.c:
857 * src/maemo/modest-store-widget.h:
858 * src/maemo/modest-transport-widget.c:
859 * src/maemo/modest-transport-widget.h:
860 * src/modest-account-mgr-helpers.c:
861 * src/modest-account-mgr-helpers.h:
862 * src/modest-account-mgr.c:
863 * src/modest-account-mgr.h:
864 * src/modest-tny-account.c:
865 * src/modest-tny-folder.c:
866 * src/widgets/modest-account-view.c:
867 * src/widgets/modest-retrieve-combo-box.c:
868 * src/widgets/modest-retrieve-combo-box.h:
869 * src/widgets/modest-secureauth-combo-box.c:
870 * src/widgets/modest-serversecurity-combo-box.c:
871 * src/widgets/modest-serversecurity-combo-box.h:
872 * tests/check_account-mgr.c:
873 Use the specific functions, and use the re-renamed enum values for GNOME too.
875 2007-05-15 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
879 so we can get the second based on the first.
881 * src/maemo/modest-account-settings-dialog.h:
882 * src/maemo/modest-account-settings-dialog.c:
883 Added get_supported_secure_authentication_methods(), though it is mostly
884 commented-out for now until the necessary API is committed to tinymail.
885 (modest_account_settings_dialog_set_account_name),
886 (save_configuration): Request the supported authentication methods from the
887 server, so we can choose a working method.
889 * src/modest-tny-account-store.h:
890 * src/modest-tny-account-store.c:
891 (modest_tny_account_store_get_session): Rename from
892 tny_account_store_get_session().
894 2007-05-14 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-protocol-info.h: Split the ModestProtocol enum
897 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
898 There was no need to have these unrelated values in one enum.
900 * src/: many files: Adapted to changed enum. This makes the code a bit
901 clearer, and the compiler could catch some errors.
903 2007-05-14 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
906 Show the detailed internal camel error message when an error happens
907 during the configuration, so that our testers can give us more clues.
908 For instance, in projects.maemo.org bug NB#56910 .
910 2007-05-14 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account.c:
913 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
914 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
916 2007-05-14 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
919 * src/maemo/modest-account-settings-dialog.c:
920 (modest_account_settings_dialog_set_account_name),
921 (save_configuration): For the incoming secure authentication checkbox,
922 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
923 the UI specification. PLAIN does not seem to be supported for most IMAP
924 servers anyway, and I am not sure what it would mean.
925 However, we probably need to discover which of the secure-authentication
926 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
927 * src/modest-account-mgr-helpers.c:
928 (modest_account_mgr_get_server_account_data):
930 * src/modest-tny-account.c:
931 (modest_tny_account_new_from_server_account):
932 Use tny_account_set_mech() to set secure-authentication methods,
933 with some special-casing for IMAP, based on my observations of how
936 * src/modest-account-mgr-helpers.h:
937 * src/modest-account-mgr.c:
938 * src/modest-defs.h: Comment that the URI is only used for local folders.
940 2007-05-11 Murray Cumming <murrayc@murrayc.com>
942 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
943 parameter const, just to be neat.
944 * src/modest-text-utils.c: (modest_text_utils_inline):
945 End g_strconcat() with NULL, as its documentation says. This is almost
946 certainly the cause of my crash at startup on the device. Interestingly,
947 valgrind doesn't tell us about these errors.
949 2007-05-11 Murray Cumming <murrayc@murrayc.com>
951 * scripts/build-packages: Added more precise comments about how to use
952 this script, though I still get this error:
953 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
954 error building tinymail
956 2007-05-11 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/modest-main-window.c: (on_account_update):
959 Very slight cleanup, hoping to make it simpler to discover what causes
960 a crash here sometimes.
962 * src/modest-tny-account.c:
963 (modest_tny_account_new_from_server_account): Set the port. Added
964 comments about the options and a TODO comment because I need to find out
965 how to specify the secure authentication method.
967 2007-05-11 Marcus Bauer <marcusb@openismus.com>
969 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
970 changed CFlags paths form modest to libmodest
972 2007-05-10 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-account-mgr-helpers.c:
975 (modest_account_mgr_get_server_account_data),
976 (modest_account_mgr_free_server_account_data):
977 * src/modest-account-mgr-helpers.h:
978 * src/modest-account-mgr.c:
979 (modest_account_mgr_add_server_account):
981 * src/modest-tny-account.c:
982 (modest_tny_account_new_from_server_account):
983 Determine the options for tny_camel_account_add_option() here,
984 based on the settings, rather than storing them directly in gconf.
986 2007-05-10 Murray Cumming <murrayc@murrayc.com>
988 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
989 Show a more friendly error dialog now that we expect (from the tinymail
990 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
992 2007-05-10 Murray Cumming <murrayc@murrayc.com>
994 * src/maemo/modest-main-window.c: (on_account_update): Check that
995 account_name is not NULL, to prevent a crash at startup that I am
996 seeing on the N800. I do wonder why it is NULL.
998 * src/maemo/easysetup/modest-easysetup-wizard.c:
999 (create_page_user_details):
1000 * src/maemo/modest-account-settings-dialog.c:
1001 (create_page_user_details), (create_page_outgoing):
1002 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1003 (modest_connection_specific_smtp_edit_window_init):
1004 * src/modest-ui-actions.c:
1005 (modest_ui_actions_on_password_requested):
1006 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1007 might do something useful with the on-screen keyboard.
1009 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-main-window.c: (on_account_update):
1012 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1013 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1015 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-tny-account-store.c: (on_account_changed):
1018 Correct the signature of this signal handler.
1020 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1023 Show a HildonNote instead of a GtkDialog for Maemo.
1025 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1027 * src/widgets/modest-account-view.h:
1028 * src/widgets/modest-account-view.c: (on_account_changed),
1029 (on_account_removed). Added a boolean flag, set/unset by
1030 modest_account_view_block_conf_updates(),
1031 modest_account_view_unblock_conf_updates() to prevent unnecessary
1032 updates, but this is not very useful because the gconf notifications are
1033 so delays (maybe only on Maemo Bora).
1034 So auto-updating is turned off, and these functions do an explicit
1035 update when necessary.
1036 However, something else is still doing too much work when adding/removing
1037 accounts, probably in another part of the application.
1039 * src/maemo/modest-account-view-window.c:
1040 (on_delete_button_clicked), (on_edit_button_clicked),
1041 (on_new_button_clicked): Use the new functions.
1043 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-account-mgr-helpers.c:
1046 (modest_account_mgr_set_first_account_as_default):
1047 Sort the list of names alphabetically-by-title, so we choose the first one
1049 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1050 alphabetically by the title.
1052 This fixes projects.maemo.org bug NB#56418 .
1054 * src/modest-account-mgr-priv.c:
1055 (_modest_account_mgr_account_from_key):
1056 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1057 avoid a valgrind error, and possible random behaviour.
1059 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1062 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1063 tinymail documentation to say that this can be expected.
1064 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1065 pretty, and should not happen, but I would prefer to know when it does.
1067 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1069 * configure.ac: When using the older hildon version, probably on Bora,
1070 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1072 * src/widgets/modest-attachment-view.c:
1073 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1076 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1078 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1079 Implemented the prototype. Can be tested with
1080 tests/dbus_api/test_open_message:
1082 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-tny-account-store.c:
1085 (modest_tny_account_store_instance_init), (get_password):
1086 * src/modest-ui-actions.c:
1087 (modest_ui_actions_on_password_requested):
1088 Do not store the password in gconf, because this function is called
1089 for non-remembered passwords. Actually use the cached (in the hash map)
1090 password instead of releasing it.
1091 The password will now not be remembered if it is asked via the protected
1092 password dialog, as per the UI spec.
1094 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1096 * src/modest-defs.h:
1097 * src/modest-account-mgr-helpers.h:
1098 * src/modest-account-mgr-helpers.c:
1099 Added modest_server_account_get_username_has_succeeded(),
1100 modest_server_account_set_username_has_succeeded().
1101 (modest_server_account_set_username),
1102 Reset the has-succeeded flag if the username changes.
1104 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1105 * src/maemo/modest-connection-specific-smtp-window.c:
1106 (modest_connection_specific_smtp_window_save_server_accounts):
1107 Use modest_server_account_set_username() instead of using
1108 modest_conf_set_string() directly, so that the has-succeeded flag is always
1111 * src/modest-ui-actions.c:
1112 (modest_ui_actions_on_password_requested): Dim the username entry if
1113 the username has ever worked, as per the UI spec.
1115 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1117 * src/modest-tny-account-store.c: (get_password):
1118 * src/modest-ui-actions.c:
1119 (modest_ui_actions_on_password_requested):
1120 Allow the username to be changed too, though there is more work to
1121 be done on exactly how this behaves.
1123 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1125 * src/modest-account-mgr-helpers.h:
1126 * src/modest-account-mgr-helpers.c:
1127 Added modest_account_mgr_get_display_name(),
1128 modest_server_account_get_username(),
1129 modest_server_account_set_username(),
1130 modest_server_account_set_password(),
1131 modest_server_account_get_hostname() functions so we do not need to
1132 use the conf API directly.
1134 * src/maemo/modest-main-window.c: (connect_signals):
1135 Actually connect ot the ModestAccountStore::request-password signal,
1136 so that we show the dialog when the password is requested by Tinymail,
1137 for isntance if it is empty.
1139 * src/modest-marshal.list:
1140 * src/modest-tny-account-store.c:
1141 (modest_tny_account_store_class_init), (get_password),
1142 (modest_tny_account_store_alert):
1143 * src/modest-tny-account-store.h:
1144 * src/modest-ui-actions.h:
1145 * src/modest-ui-actions.c:
1146 (modest_ui_actions_on_password_requested):
1147 Change the signal parameters, so it is obvious that we are providing
1148 the non human-readable server name, and receiving both the username
1149 and password, though changing of the username is not yet implemented.
1150 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1151 for the GNOME version.
1153 This should fix the projects.maemo.org bug NB#56209, though it does not
1154 work on Bora, because the gconf_client_get() for the password fails
1155 immediately after we save it with gconf_client_set().
1157 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1160 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1161 caused an undefined symbol error:
1162 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1164 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-tny-account-store.c:
1167 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1168 using a GError instead of a string message, so we can translate it in
1171 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/modest-address-book.c:
1174 (modest_address_book_check_names):
1175 * src/maemo/modest-msg-view-window.c:
1176 (modest_msg_view_window_clipboard_owner_change):
1177 * src/modest-init.c: (modest_init_init_ui):
1178 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1179 (update_folders_cb), (modest_mail_operation_update_account):
1180 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1181 (modest_ui_actions_on_msg_attachment_clicked),
1182 (modest_ui_actions_on_msg_recpt_activated):
1183 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1184 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1185 (modest_msg_view_search_next):
1186 * src/widgets/modest-recpt-editor.c:
1187 (modest_recpt_editor_on_button_release_event),
1188 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1189 g_message(). At this point we should only be seeing interesting errors on
1190 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1192 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1194 (modest_wizard_dialog_force_title_update):
1195 * src/maemo/easysetup/modest-wizard-dialog.h:
1196 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1197 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1198 can update the title when appropriate. Otherwise the title is wrong if the
1199 pages are added after adding the notebook to the dialog.
1200 This must be a problem in HildonWizardDialog too.
1201 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 (create_subsequent_customsetup_pages),
1205 (create_subsequent_easysetup_pages):
1206 Call modest_wizard_dialog_force_title_update() so that the title is
1207 correct even with GTK+ < 2.10.
1208 This fixes projects.maemo.org bug NB#56145 .
1210 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-platform.c:
1213 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1214 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1217 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1219 * src/widgets/modest-window.h:
1220 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1221 and modest_window_save_state(), which invokes it.
1223 * src/widgets/modest-window-mgr.h:
1224 * src/widgets/modest-window-mgr.c:
1225 Added modest_window_mgr_save_state_for_all_windows(), which calls
1226 the save_state vfunc on all registered windows, if implemented.
1228 * src/gnome/modest-msg-edit-window.c:
1229 * src/gnome/modest-msg-view-window.c:
1230 * src/maemo/modest-msg-edit-window.c:
1231 * src/maemo/modest-msg-view-window.c:
1232 * src/maemo/modest-main-window.c:
1233 Specify the existing save_settings functions as implementations of
1234 ModestWindow::save_state_func().
1236 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1237 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1238 enabling hibernation, for instance.
1240 We may need to do the same thing for restoring settings.
1243 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1245 * src/widgets/modest-window-mgr.c:
1246 * src/widgets/modest-window-mgr.h:
1247 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1248 modest_window_mgr_get_hibernation_is_prevented().
1250 * src/maemo/modest-main-window.c:
1251 (on_hildon_program_is_topmost_notify): Prevent hibernation
1252 (possible when the application goes to the background in the WM),
1253 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1255 * src/maemo/easysetup/modest-easysetup-wizard.c:
1256 (modest_easysetup_wizard_dialog_init):
1257 * src/maemo/modest-account-settings-dialog.c:
1258 (modest_account_settings_dialog_init):
1259 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1260 (modest_connection_specific_smtp_edit_window_init):
1261 * src/maemo/modest-connection-specific-smtp-window.c:
1262 (modest_connection_specific_smtp_window_init):
1263 * src/maemo/modest-signature-editor-dialog.c:
1264 (modest_signature_editor_dialog_init):
1265 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1266 prevent hibernation while any of these account settings dialogs are open.
1268 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/Makefile.am:
1271 * src/maemo/modest-osso-state-saving.c:
1272 * src/maemo/modest-osso-state-saving.h: Added
1273 modest_osso_load_state() and modest_osso_save_state() though they do
1274 nothing now. They should iterate through all the open windows and load/save
1276 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1277 save state when closing.
1279 * src/maemo/modest-main-window.c:
1280 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1281 Add a notification handler for the HildonProgram::is-topmost property,
1282 so we can allow hibernation when the application goes into the background.
1283 But we still need to detect when the accounts setup windows are open so
1284 we can stop hibernation when they are open.
1285 To do this, I also added the main window the HildonProgram. This might have
1286 other side-effects/benefits, and should maybe be done for other windows.
1288 * src/maemo/modest-osso-autosave-callbacks.h:
1289 * src/maemo/modest-osso-autosave-callbacks.c:
1290 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1291 though it does not do anything yet, and we might never need this to do
1292 anything. For instance, we already save drafts.
1294 * src/maemo/modest-platform.c: (modest_platform_init):
1295 Specify the libosso auto-save callback.
1297 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-platform.c:
1300 (modest_platform_set_update_interval):
1301 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1302 aparently stays valid between application instances, so we can use this
1303 to remove and reset it later. According to a maemo-developers email from
1306 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1308 * configure.ac: Depend on libalarm for Maemo.
1310 * src/dbus_api/modest-dbus-api.h:
1311 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1312 (on_send_receive), (modest_dbus_req_handler):
1313 Handle a SEND_RECEIVE D-Bus method.
1315 * libmodest-dbus-client/libmodest-dbus-client.c:
1316 (libmodest_dbus_client_send_and_receive):
1317 * libmodest-dbus-client/libmodest-dbus-client.h:
1318 Add C convenience functions for calling the new D-Bus method.
1320 * src/modest-platform.h:
1321 * src/gnome/modest-platform.c:
1322 * src/maemo/modest-platform.c:
1323 Added modest_platform_set_update_interval(), which uses the
1324 alarmd API on Maemo.
1325 (modest_platform_init),
1326 Call modest_platform_set_update_interval(), using a hard-coded
1327 interval for now (until the global settings dialog is implemented),
1328 though I am not sure that this makes sense yet.
1330 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1332 * src/dbus_api/modest-dbus-callbacks.c:
1333 (modest_osso_cb_hw_state_handler):
1334 * src/dbus_api/modest-dbus-callbacks.h:
1335 * src/maemo/modest-platform.c: (modest_platform_init):
1336 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1337 in case this has some effect on the ability for Maemo to ping the
1340 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1343 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1344 warning. It is probably a logic error, but I need to fix the build.
1346 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1348 * src/modest-account-mgr.h:
1349 * src/modest-account-mgr.c:
1350 (modest_account_mgr_account_names): Add a gboolean enabled_only
1351 parameter, so we can get lists of onlt the enabled accounts.
1353 (modest_account_mgr_add_account),,
1354 (modest_account_mgr_account_with_display_name_exists):
1355 * src/maemo/modest-msg-edit-window.c: (get_transports):
1356 * src/modest-account-mgr-helpers.c:
1357 (modest_account_mgr_set_first_account_as_default):
1358 * src/modest-init.c: (init_default_account_maybe):
1359 * src/modest-tny-account-store.c: (get_accounts):
1360 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1361 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1362 * tests/check_account-mgr.c: (START_TEST):
1363 Provide the extra parameter, as appropriate.
1365 * src/widgets/modest-account-view.c: (update_account_view):
1366 Do not show disabled accounts (meaning that there is no way to
1367 enable/disable accounts in the UI (the feature is not in our UI
1368 specification), so we can use this internally only to mark unfinished
1369 or temporary account data.
1371 * src/maemo/easysetup/modest-easysetup-wizard.c:
1372 (create_account): Add boolean enable parameter, so we can specify FALSE
1373 to create the temporary account.
1374 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1375 (on_before_next): When finishing, when there is a temporary account, just
1377 Also, use a timeout to delay the showing of the dialog until gconf is likely
1378 to return correct information, due to a maemo gconf bug that is fixed in
1379 osso 1.1, but not yet in Bora.
1380 However, the dialog stays on screen after it is destroyed.
1382 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1383 for invalid data when cancelling. Use a hildon note instead of a dialog
1384 to complain about invalid data. Do not show the account-saved note if the
1385 account is disabled (a temporary account that will not really be saved for use
1388 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-account-mgr-helpers.h:
1391 * src/modest-account-mgr-helpers.c:
1392 Added modest_account_mgr_unset_default_account(),
1393 Added modest_account_mgr_set_first_account_as_default().
1395 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1396 If it was the default account, unset the default account name.
1398 * src/maemo/modest-account-view-window.c:
1399 (on_delete_button_clicked): If it was the default account,
1400 set the first remaining account as the default instead.
1402 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1403 a NULL account or a NULL default account, to prevent a crash. This should
1404 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1407 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1409 * src/widgets/modest-recpt-editor.c:
1410 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1411 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1412 TODO comment for this. This fixes the build.
1414 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1415 be the best place for it. This will in future update all auto-update accounts,
1416 rather than just the current/default account, when that gconf key exists.
1417 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1418 if there are no accounts, before calling do_send_receive().
1419 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1421 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1422 * src/maemo/modest-main-window-ui.h:
1423 * src/maemo/modest-main-window.c: (on_connection_changed),
1424 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1425 directly, becaue the signal handler does more.
1427 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1429 * src/modest-account-mgr-helpers.c:
1430 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1431 for the case that the account does not exist.
1433 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1434 (equivalent to the modest account name) rather than the tinymail account name
1435 (equivalent to the modest account title - human readable) to get the account data.
1436 Check for null account data to prevent the crash, and add a TODO comment saying that
1437 this needs fixing because it is using the server account name instead of the account name.
1439 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1441 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1442 * src/maemo/modest-account-settings-dialog.c: (show_error),
1444 Use hildon_note_new_information() for informative and error messages,
1445 which seems to be expected for Maemo applications (no documentation that I know of
1446 says this). I am surprised that there is no distinction between info and error
1449 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1452 it is easy to find where this is used.
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 (create_page_welcome), (create_page_account_details),
1456 (create_page_user_details), (create_page_complete_easysetup),
1457 (create_page_custom_incoming), (create_page_custom_outgoing),
1458 (create_page_complete_custom):
1459 * src/maemo/modest-account-settings-dialog.c:
1460 (create_page_account_details), (create_page_user_details),
1461 (create_page_incoming), (create_page_outgoing):
1462 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1463 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1464 (modest_connection_specific_smtp_edit_window_init):
1465 * src/maemo/modest-connection-specific-smtp-window.c:
1466 (modest_connection_specific_smtp_window_init):
1467 * src/maemo/modest-signature-editor-dialog.c:
1468 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1469 and scrolling policy as per the Email Application Layout Guide, if I have
1472 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1474 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1475 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1476 which were empty, because these vfuncs have been removed from TnyAccountStore.
1477 This fixes the build.
1479 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1481 * src/maemo/modest-main-window.c:
1482 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1483 showing/hiding it. Added TODO because it probably should not be NULL.
1484 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1485 because unnecessary g_warnings() make degugging difficult.
1487 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/modest-msg-edit-window.c:
1490 (modest_msg_edit_window_select_color),
1491 (modest_msg_edit_window_select_background_color): 2 const corrections and
1492 moving 2 #endifs before closing brackets, to fix the build.
1494 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1496 * src/maemo/easysetup/modest-easysetup-wizard.h:
1497 * src/maemo/easysetup/modest-easysetup-wizard.c:
1498 (modest_easysetup_wizard_dialog_finalize),
1499 (on_button_edit_advanced_settings), (create_page_complete_custom),
1500 (on_response), (create_account):
1501 Implement the Advanced Settings edit button, by saving the account information,
1502 for the Advanded Settings dialog to use directly from gconf, and removing it
1503 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1504 Bug #5533 in the projects.maemo.org bugzilla.
1506 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1508 * src/maemo/modest-msg-view-window.c:
1509 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1510 when opening a message window.
1512 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/easysetup/modest-easysetup-wizard.c:
1515 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1518 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1519 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1520 gconf settings. I probably added more checks than necessary, but that is safer.
1522 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1523 variable to fix the build, but this seems to be used when it is still NULL.
1525 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1527 * src/modest-platform.h:
1528 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1529 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1530 * src/modest-main.c: Implement this function so we can avoid using
1531 maemo-specific API from cross-platform code.
1533 * src/modest-tny-account-store.c:
1534 (get_smtp_specific_transport_account_for_open_connection):
1535 * src/modest-ui-actions.c: (check_for_connection),
1536 (modest_ui_actions_on_item_not_found):
1537 Use modest_platform_connect_and_wait() and put #idefs around other
1538 maemo-specific code, because only maemo currently has a way to
1539 identify connection names.
1541 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1543 * src/modest-tny-account-store.h:
1544 * src/modest-tny-account-store.c:
1545 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1546 the connection-specific SMTP server settings in the configuration.
1548 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1550 * src/maemo/modest-main-window.c: (on_connection_changed),
1552 * src/modest-main.c: (main), (start_ui), (send_mail):
1553 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1554 that is what is intended.
1556 * src/modest-ui-actions.c: (action_send), (action_receive),
1557 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1558 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1559 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1560 SMTP server is used when it is specified.
1562 (modest_ui_actions_on_send_receive):
1563 Check that a connection is open before proceeding.
1564 Receive and then send, instead of vice-versa, as per the specification.
1566 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1568 * src/modest-mail-operation.c:
1569 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1570 though I guess it should be something other than NULL.
1572 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1574 * src/maemo/easysetup/modest-easysetup-wizard.c:
1575 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1576 combo twice, to avoid an g_warning and to make it visible again.
1577 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1578 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1579 (already intended) dereference when detaching, because we then recreate the menu.
1580 But I am not sure why the warning was happening, and it is possible that this is a memory
1583 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1585 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1586 and uri_parse_mailto() utility functions.
1587 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1589 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1591 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1593 * src/dbus_api/modest-dbus-api.h:
1594 * src/dbus_api/modest-dbus-callbacks.c:
1595 Use an idle callback to execute the modest code in the application's own thread.
1596 Remove the helloworld example method.
1597 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1598 parsed, and the open-message method is not implemented because this is not yet implemented in
1600 * libmodest-dbus-client/libmodest-dbus-client.c:
1601 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1602 (libmodest_dbus_client_open_message):
1603 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1605 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1606 body without crashing.
1608 * tests/dbus_api/Makefile.am:
1609 * tests/dbus_api/test_mail_to.c:
1610 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1612 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1614 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1615 Added file to fix the build. Sorry.
1617 * src/dbus_api/Makefile.am:
1618 * src/dbus_api/modest-dbus-api.h:
1619 * src/dbus_api/modest-dbus-callbacks.h:
1620 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1621 (modest_dbus_req_handler):
1622 Put constants in a separate header so it can be reused by the
1623 client library, without duplication
1625 * libmodest-dbus-client/Makefile.am:
1626 * libmodest-dbus-client/libmodest-dbus-client.c:
1627 (libmodest_dbus_client_call_helloworld),
1628 (libmodfest_dbus_client_send_mail),
1629 (libmodfest_dbus_client_mailto),
1630 (libmodfest_dbus_client_open_message):
1631 * libmodest-dbus-client/libmodest-dbus-client.h:
1632 (Partly) Implement a send_mail D-Bus method.
1634 * tests/dbus_api/Makefile.am:
1635 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1636 the send_email D-Bus method.
1638 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1642 * libmodest-dbus-client/Makefile.am:
1643 * libmodest-dbus-client/libmodest-dbus-client.c:
1644 * libmodest-dbus-client/libmodest-dbus-client.h:
1645 * tests/dbus_api/Makefile.am:
1646 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1647 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1649 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1651 * src/maemo/easysetup/modest-easysetup-wizard.c:
1652 (create_page_account_details):
1653 * src/maemo/modest-account-settings-dialog.c:
1654 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1655 widgets, because this might not be the default in future versions of the Maemo GTK+.
1656 However, I can not not get capitalization to work even in a simple test case.
1658 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/easysetup/modest-easysetup-wizard.c:
1661 (create_page_custom_incoming), (create_page_custom_outgoing):
1662 * src/maemo/modest-account-settings-dialog.c:
1663 (create_page_account_details), (create_page_incoming),
1664 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1665 instead of using gtk_check_button_with_label(), so they are aligned like the other
1666 widgets, as per the UI spec.
1668 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/easysetup/modest-easysetup-wizard.c:
1671 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1672 * src/widgets/modest-validating-entry.c:
1673 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1674 Modest prefix instead of an EasySetup prefix.
1676 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1678 * src/widgets/modest-validating-entry.h:
1679 * src/widgets/modest-validating-entry.c: (on_insert_text),
1680 Added easysetup_validating_entry_set_max_func(), used to set a callback
1681 to call when the max number of characters is reached. GtkEntry has a max-length
1682 already but is silent about it.
1684 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1685 (create_page_account_details), (create_page_user_details),
1687 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1688 (create_page_account_details), (create_page_user_details),
1689 (create_page_outgoing):
1690 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1691 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1692 the UI spec, when the user tries to enter more than the max number of characters.
1694 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/easysetup/modest-easysetup-wizard.c:
1697 (create_page_user_details), (create_page_custom_incoming),
1698 (create_page_custom_outgoing):
1699 * src/maemo/modest-account-settings-dialog.c:
1700 (create_page_user_details), (create_page_incoming),
1701 (create_page_outgoing):
1702 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1703 (modest_connection_specific_smtp_edit_window_init):
1704 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1705 not appropriate. Bad Maemo-specific defaults!.
1707 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1710 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1711 (modest_signature_editor_dialog_set_settings):
1712 Disable the label and textview when the checkbox is disabled, and use the
1713 specified (UI spec) default signature text.
1715 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1717 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1718 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1720 * src/modest-defs.h:
1721 * src/modest-account-mgr-helpers.h:
1722 * src/modest-account-mgr-helpers.c:
1723 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1725 * src/maemo/Makefile.am:
1726 * src/maemo/modest-signature-editor-dialog.c:
1727 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1730 * src/maemo/modest-account-settings-dialog.h:
1731 * src/maemo/modest-account-settings-dialog.c:
1732 (modest_account_settings_dialog_finalize), (on_button_signature),
1733 (save_configuration): Use the new dialog when the Edit button is pressed, and
1734 save the changes if necessary, as per the UI spec.
1736 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1738 * src/maemo/Makefile.am:
1739 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1740 based on maemo-develoers email from Dirk.
1742 * src/maemo/easysetup/modest-easysetup-wizard.c:
1743 (create_page_welcome), (create_page_account_details),
1744 (create_page_user_details), (create_page_complete_easysetup),
1745 (create_page_custom_incoming), (create_page_custom_outgoing),
1746 (create_page_complete_custom),
1747 (modest_easysetup_wizard_dialog_init):
1748 * src/maemo/modest-account-settings-dialog.c:
1749 (create_page_account_details), (create_page_user_details),
1750 (create_page_incoming), (create_page_outgoing),
1751 (modest_account_settings_dialog_init):
1752 * src/maemo/modest-connection-specific-smtp-window.c:
1753 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1755 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1757 * src/maemo/easysetup/modest-easysetup-wizard.c:
1758 (create_page_account_details), (create_page_custom_outgoing),
1759 (create_page_complete_custom):
1760 * src/maemo/modest-account-settings-dialog.c:
1761 (create_page_user_details), (create_page_incoming),
1762 (create_page_outgoing):
1763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1764 (modest_connection_specific_smtp_edit_window_init):
1765 Use the correct (UI spec) port min/max, and use horizontal separators,
1768 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1770 * src/maemo/easysetup/modest-easysetup-wizard.c:
1771 (set_default_custom_servernames):
1772 * src/maemo/modest-account-settings-dialog.c:
1773 (create_page_incoming), (on_combo_outgoing_security_changed),
1774 (on_combo_incoming_security_changed), (create_page_outgoing),
1775 (modest_account_settings_dialog_set_account_name),
1776 (save_configuration):
1777 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1778 (on_combo_security_changed),
1779 (modest_connection_specific_smtp_edit_window_init),
1780 (modest_connection_specific_smtp_edit_window_set_connection),
1781 (modest_connection_specific_smtp_edit_window_get_settings):
1782 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1785 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/easysetup/modest-easysetup-wizard.c:
1789 (create_page_custom_outgoing), (create_page_complete_custom):
1790 * src/maemo/modest-account-settings-dialog.c:
1791 (create_page_user_details), (create_page_outgoing):
1792 * src/maemo/modest-account-view-window.c: (button_box_new):
1793 Use changed logical IDs as per the most recent UI spec:
1794 mcen_bd_emailsetup_edit -> mcen_bd_edit
1795 mcen_bd_emailsetup_delete -> mcen_bd_delete
1796 mcen_bd_emailsetup_close -> mcen_bd_close
1798 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1802 * src/dbus_api/Makefile.am:
1803 * src/dbus_api/modest-dbus-callbacks.c:
1804 * src/dbus_api/modest-dbus-callbacks.h:
1805 * src/maemo/modest-platform.c: (modest_platform_init):
1806 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1808 * tests/Makefile.am:
1809 * tests/dbus_api/Makefile.am:
1810 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1812 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/modest-account-settings-dialog.c:
1815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1816 Removed unnecessary includes.
1818 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1820 * src/maemo/easysetup/modest-easysetup-wizard.c:
1821 * src/maemo/modest-account-settings-dialog.c:
1822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1823 * src/widgets/Makefile.am:
1824 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1825 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1826 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1827 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1828 * src/widgets/modest-secureauth-combo-box.c:
1829 * src/widgets/modest-secureauth-combo-box.h:
1830 * src/widgets/modest-serversecurity-combo-box.c:
1831 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1832 made the GObject names more consistent with the rest of the Modest code.
1834 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/easysetup/Makefile.am:
1837 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1838 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1839 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1840 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1841 * src/maemo/easysetup/modest-easysetup-wizard.c:
1842 * src/maemo/easysetup/modest-validating-entry.c:
1843 * src/maemo/easysetup/modest-validating-entry.h:
1844 * src/maemo/modest-account-settings-dialog.c:
1845 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1846 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1847 widgets/ because they are used outside of easysetup too. After checking in,
1848 svn will allow me to rename them too.
1850 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1852 * src/gnome/modest-msg-edit-window.c:
1853 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1854 linker error, to fix the build on the GNOME platform.
1855 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1856 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1857 ifdefed out to avoid a warning.
1859 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1861 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1862 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1863 some alternative for GTK+ 2.6.
1865 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1867 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1869 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1870 specified for EmailAccountsDialog in UI spec.
1872 * src/maemo/easysetup/modest-easysetup-wizard.c:
1873 * src/maemo/easysetup/modest-easysetup-wizard.h:
1874 * src/maemo/modest-account-settings-dialog.c:
1875 * src/maemo/modest-account-settings-dialog.h:
1876 Reuse a member window widget for the connection-specific SMTP server accounts,
1877 so we can tell it to create/save the accounts only if we actually save changes.
1879 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1880 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1881 (modest_connection_specific_smtp_edit_window_get_settings):
1882 Return a struct instance for temporarily remembering the entered data.
1884 * src/maemo/modest-connection-specific-smtp-window.h:
1885 * src/maemo/modest-connection-specific-smtp-window.c:
1886 (modest_connection_specific_smtp_window_finalize),
1887 (modest_connection_specific_smtp_window_fill_with_connections),
1889 (modest_connection_specific_smtp_window_save_server_accounts),
1890 (update_model_server_names): Do not actually save data until asked,
1891 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1893 (on_selection_changed),
1894 (modest_connection_specific_smtp_window_init): Disable the edit
1895 button when nothing is selected.
1897 * src/modest-account-mgr-helpers.c:
1898 * src/modest-account-mgr-helpers.h:
1899 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1902 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-account-mgr-helpers.h:
1905 * src/modest-account-mgr-helpers.c:
1906 (modest_account_mgr_get_unused_account_name),
1907 (modest_account_mgr_get_unused_account_display_name): Added these
1908 utility functions, to avoid code duplication.
1910 * src/maemo/easysetup/modest-easysetup-wizard.c:
1911 (create_page_account_details), (create_account):
1912 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1913 (on_combo_security_changed),
1914 (modest_connection_specific_smtp_edit_window_init),
1915 (modest_connection_specific_smtp_edit_window_save_settings):
1916 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1917 * src/maemo/modest-connection-specific-smtp-window.c:
1918 (modest_connection_specific_smtp_window_finalize),
1919 (modest_connection_specific_smtp_window_fill_with_connections),
1920 (on_button_edit), (modest_connection_specific_smtp_window_init):
1921 * src/maemo/modest-connection-specific-smtp-window.h:
1922 Implementing saving of connection-specific server accounts.
1924 But I need to refactor this so we can save the data for each
1925 possible connection-specific account and only actually create the server accounts
1926 when the easysetup finished, or the OK button is pressed on the account settings
1929 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1931 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1932 (on_combo_security_changed):
1933 (modest_connection_specific_smtp_edit_window_init):
1934 Auto-fill the port number as in the account settings.
1936 (modest_connection_specific_smtp_edit_window_set_connection):
1937 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1938 * src/maemo/modest-connection-specific-smtp-window.c:
1939 (fill_with_connections), (on_button_edit),
1940 (modest_connection_specific_smtp_window_init):
1941 Turn the edit window into a dialog to simplify the code, and
1942 set a WM hint as in a GtkDialog, because only a popup can be on top of
1943 another window in Maemo, and popups usually have no WM decoration.
1945 * src/modest-defs.h:
1946 * src/modest-account-mgr-helpers.c:
1947 (modest_account_mgr_set_connection_specific_smtp),
1948 (modest_account_mgr_remove_connection_specific_smtp),
1949 (modest_account_mgr_get_connection_specific_smtp):
1950 * src/modest-account-mgr-helpers.h: Some functions to write the
1951 connection-specific SMTP server information. Not yet used.
1954 * src/widgets/modest-folder-view.c: (text_cell_data):
1955 Fix a warning about an uninitialized variable.
1956 (on_configuration_key_changed): Put an #ifdef around the use
1957 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1959 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-account-settings-dialog.h:
1962 * src/maemo/modest-account-settings-dialog.c:
1963 Added connect_for_modified() utility function to mark the new modified boolean.
1965 (create_page_account_details), (create_page_user_details),
1966 (create_page_incoming), (create_page_outgoing), (on_response),
1967 (modest_account_settings_dialog_init),
1968 (modest_account_settings_dialog_set_account_name):
1969 Only warn about unsaved changes when there are actually unsaved changes.
1971 * src/modest-account-mgr-helpers.c:
1972 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1973 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1974 to get the data from there in future.
1976 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1978 * src/modest-defs.h:
1980 * src/modest-account-mgr-helpers.h:
1981 * src/modest-account-mgr-helpers.c:
1982 Store the security account setting in a single conf key instead of using
1983 the options list, so that the list is left for just the to-be-removed camel hack,
1984 and because gconf_client_set_list() is failing for some reason.
1986 * src/modest-account-mgr.c:
1987 (modest_account_mgr_add_server_account):
1988 * src/maemo/modest-account-settings-dialog.c:
1989 (modest_account_settings_dialog_set_account_name),
1990 (save_configuration): Use the renamed functions.
1993 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1995 * src/widgets/Makefile.am:
1996 * src/widgets/modest-limit-retrieve-combo-box.c:
1997 * src/widgets/modest-limit-retrieve-combo-box.h:
1998 * src/widgets/modest-retrieve-combo-box.c:
1999 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2000 the account settings dialog.
2002 * src/modest-defs.h:
2003 * src/modest-account-mgr-helpers.h:
2004 * src/modest-account-mgr-helpers.c:
2005 (modest_server_account_get_option_secure_auth),
2006 (modest_server_account_set_option_secure_auth):
2007 * src/modest-account-mgr.c:
2008 (modest_account_mgr_add_server_account):
2009 Use the existing AUTH_MECH conf key for the secure-auth setting,
2010 instead of putting it in the list options, because this was actually used already.
2012 * src/maemo/modest-account-settings-dialog.c:
2013 (create_page_account_details),
2014 (modest_account_settings_dialog_set_account_name),
2015 (save_configuration):
2016 * src/maemo/modest-account-settings-dialog.h:
2017 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2018 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2020 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2023 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2024 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2026 * src/modest-defs.h:
2027 * src/maemo/modest-account-settings-dialog.c:
2028 (create_page_incoming), (on_combo_outgoing_security_changed),
2029 (on_combo_incoming_security_changed), (create_page_outgoing),
2030 (modest_account_settings_dialog_set_account_name),
2031 (save_configuration): Load/Save the port number, and change it when the
2032 security combo changes, to suitable defaults.
2034 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2036 * src/modest-account-mgr.c:
2037 (modest_account_mgr_add_server_account): Set the security and secure-auth
2038 options, and add a comment saying that the other camel-specific options should be
2041 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2045 * src/modest-tny-account-store.c: (account_list_free),
2046 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2047 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2050 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2052 * src/modest-protocol-info.c:
2053 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2054 is required by our UI spec. Maybe something in our implementation will use this eventually.
2055 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2056 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2057 instead of the previous 0 placeholder.
2059 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2060 secure-auth settings.
2061 * src/modest-account-mgr-helpers.h:
2062 * src/modest-account-mgr-helpers.c:
2063 (modest_server_account_data_get_option_secure_auth),
2064 (modest_server_account_set_option_secure_auth),
2065 (modest_server_account_data_get_option_security),
2066 (modest_server_account_set_option_security): Added this API for getting and setting the security
2067 and secure-auth settings.
2069 * src/maemo/modest-account-settings-dialog.h:
2070 * src/maemo/modest-account-settings-dialog.c:
2071 (modest_account_settings_dialog_finalize), (check_data),
2072 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2073 about changing titles.
2074 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2075 (save_configuration): Save the security and secure-auth settings.
2077 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2078 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2080 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-defs.h:
2083 * src/modest-account-mgr.c:
2084 (modest_account_mgr_add_server_account):
2085 Added and used defines for the options key and value pair strings,
2086 that are used so far, though they do not seem to correspond to anything in our
2087 UI specs or ModestProtocol enum.
2089 * src/modest-account-mgr-helpers.h:
2090 * src/modest-account-mgr-helpers.c:
2091 (compare_option_strings_for_name),
2092 (modest_server_account_data_get_option_value),
2093 (modest_server_account_data_get_option_bool),
2094 (modest_account_mgr_get_server_account_option):
2095 Added helper functions for parsing the options GSList.
2097 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2100 display name is based on the supplied account name.
2101 * src/modest-account-mgr.c:
2102 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2103 with an inefficient, but good-enough, implementation.
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (create_page_account_details), (on_before_next), (create_account):
2107 Check for existing display names rather than (non-user-visible) account names, and just
2108 create and set a unique account name at the end.
2110 * src/maemo/modest-account-settings-dialog.c:
2111 (modest_account_settings_dialog_init),
2112 (modest_account_settings_dialog_set_account_name),
2113 (create_page_incoming): Show the display name, instead of the account name.
2114 (on_response): Do some (not all) extra checks, as in the UI spec.
2115 (save_configuration): Save the display name if it was changed.
2117 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2119 * po/en_GB.po: Added needed logical ID and translation.
2120 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2121 (init_view): Made the is-default column clicking work.
2123 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/easysetup/Makefile.am:
2127 * src/maemo/easysetup/modest-easysetup-wizard.c:
2128 (modest_easysetup_wizard_dialog_init):
2129 * src/maemo/easysetup/provider-data-test.keyfile:
2130 * src/maemo/easysetup/provider-data.keyfile:
2131 Moved the provider data file to the new modest-providers-data package and used it from there.
2133 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2135 * src/modest-local-folder-info.c:
2136 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2137 N_() was already used on the static strings, but this just marks it for translation without
2138 using the translation.
2140 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2142 * src/maemo/modest-account-settings-dialog.c:
2143 (create_page_incoming),
2144 (modest_account_settings_dialog_set_account_name):
2145 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2146 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2147 I will do this if nobody else gets there first.
2149 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2152 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2153 save the security stuff.
2155 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2158 Set the email address and user fullname, which I now see must be
2161 * src/maemo/modest-account-settings-dialog.h:
2162 * src/maemo/modest-account-settings-dialog.c:
2164 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2165 leave-on-server and authentication.
2166 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2169 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-account-settings-dialog.c:
2173 * src/maemo/modest-account-settings-dialog.h:
2174 Most (but not all) of the widgets are now present as specified by the UI spec.
2175 No changes are yet saved, and some details are not properly shown yet.
2177 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2179 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/Makefile.am:
2182 * src/maemo/modest-account-settings-dialog.c:
2183 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2184 an existing account. Doesn't do much yet.
2186 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2187 Open the accounts settings dialog when Edit is clicked.
2189 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2191 * src/maemo/easysetup/Makefile.am:
2192 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2194 * src/maemo/easysetup/modest-easysetup-wizard.c:
2195 (modest_easysetup_wizard_dialog_init):
2196 Try to get the source directory from the build system,
2197 instead of hard-coding "./" into the source code, when opening our local
2198 copies of the configuration files.
2199 But this still fails when opening the wizard from the Accounts window,
2200 maybe because the working directory seems to change at runtime.
2201 So the wizard will fail the second time unless you copy the files into their
2202 proper locations - see the stdout warnings for the paths.
2204 (create_page_account_details),(on_before_next):
2205 Check for existing non-server accounts instead of server accounts,
2206 so the default account name is useful again, and to prevent trying to
2209 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2210 Show the wizard when New is clicked.
2212 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2213 (init_view): Show the column headers, and show the columns that are
2214 specified in the UI specs. However, something in Maemo's GTK+ prevents
2215 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2216 change the default account. This is despite unsetting the special properties.
2218 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2220 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2221 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2222 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2223 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2224 to make that clearer.
2225 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2227 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2229 * src/maemo/modest-account-view-window.c:
2230 (modest_account_view_window_init),
2231 (modest_account_view_window_new):
2232 Use the same buttons as specified in the
2233 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2234 the existing widgets, which never had a chance of working.
2235 Put the ModestAccountView treeview in a scrolled window.
2236 Do not repeat the initialization in both _init() and _new().
2238 * src/widgets/modest-account-view.c: (update_account_view):
2239 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2240 this widget and window shows no accounts.
2242 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2244 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2246 * src/maemo/easysetup/modest-easysetup-wizard.c:
2247 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2248 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2249 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2252 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2253 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2254 accounts exist yet, as in the UI spec.
2256 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2258 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/Makefile.am:
2261 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2262 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2263 New window for editing connection-specific smtp details.
2264 Not fully implemented.
2266 * src/maemo/modest-connection-specific-smtp-window.c:
2267 (modest_connection_specific_smtp_window_finalize) :
2268 unref the tree model.
2269 (on_button_edit): Show the edit window.
2271 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2273 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2276 * src/maemo/Makefile.am:
2277 * src/maemo/modest-connection-specific-smtp-window.c:
2278 * src/maemo/modest-connection-specific-smtp-window.h:
2279 New window for showing the list of connections, for connection-specific
2280 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2281 * src/maemo/easysetup/modest-easysetup-wizard.c:
2282 (create_page_custom_outgoing): Show the new window when the button is clicked.
2284 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2286 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2287 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2288 * src/maemo/modest-msg-edit-window.c:
2289 (modest_msg_edit_window_insert_image):
2290 * src/modest-conf.c: (modest_conf_key_escape):
2291 * src/modest-mail-operation.c:
2292 (modest_mail_operation_send_new_mail):
2293 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2294 (modest_ui_actions_on_new_account):
2295 * src/widgets/modest-attachment-view.c: (update_filename_request):
2296 * src/widgets/modest-mail-header-view.c:
2297 Corrected warnings that were breaking the build, by commenting out unused variables,
2298 and a function, and by including a header.
2300 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2302 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2303 so we can #ifdef around platform-specific code when necessary.
2304 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2305 to allow this to build for the GNOME platform too.
2307 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2309 * src/maemo/easysetup/modest-easysetup-wizard.c:
2310 Added util_increment_name() and used it in create_page_account_details()
2311 to make sure that the default account name is always a new name.
2313 (modest_easysetup_wizard_dialog_init),
2314 (set_default_custom_servernames): Some minor memory management fixes.
2316 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-runtime.c: (init_i18n): Restored the translation
2321 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2322 are defined in config.h, and the translations are installed.
2324 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2325 is defined for translation.
2327 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2329 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2331 * src/maemo/easysetup/modest-easysetup-wizard.c:
2332 (modest_easysetup_wizard_dialog_init):
2333 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2334 Use realistic paths (though they should use $prefix generically) to the
2335 mcc_mapping and provider-data.keyfile files which might work when they
2336 are installed by the future version of the operator-wizard package,
2337 and then fallback to paths in our source code, with an explanatory
2340 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2344 * src/maemo/Makefile.am:
2345 * src/maemo/easysetup/: Added files from the previously-exernal
2346 osso-modest-easysetup.
2347 * src/maemo/modest-main-window-ui.h:
2348 * src/modest-ui-actions.c:
2349 * src/modest-ui-actions.h:
2350 Added modest_ui_actions_on_new_account() as a signal handler for the
2351 New Account menu item. It shows the easysetup wizard.
2352 * po/en_GB.po: Added additional needed logical IDs and translations.
2354 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2355 Apparently ChangeLog is not used for some vague Nokia legal reasons.