1 2007-07-22 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-ui-actions.c: Use current account instead of
4 default account for creating viewer windows, so that the viewer
5 window knows to which account the viewed message belongs.
7 * src/maemo/modest-msg-view-window.c: Destroy the window when the
8 corresponding account is deleted. This fixes projects.maemo.org bug
11 2007-07-18 Armin Burgmeier <armin@openismus.com>
13 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
14 the dialog close after entering an invalid port number and clicking
15 OK. This fixes projects.maemo.org bug NB#63602.
17 2007-07-18 Armin Burgmeier <armin@openismus.com>
19 * src/modest-tny-account-store.c:
20 (get_server_accounts): Set parent modest account name for each
21 connection-specific transport account so that special folders of such
22 an account can be looked up. This fixes a crash when changing account
23 settings. This might also be related to projects.maemo.org bug
26 2007-07-16 Armin Burgmeier <armin@openismus.com>
28 * src/modest-ui-actions.c: Added a button to create a folder to the
29 move-to dialog. This fixes projects.maemo.org bug NB#.
31 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
33 * src/maemo/easysetup/modest-easysetup-wizard.c:
34 Added scrollbars to account wizard dialog.
35 Fixed projects.maemo.org NB #62744
37 2007-07-16 Murray Cumming <murrayc@murrayc.com>
39 * src/widgets/modest-msg-view.h:
40 * src/widgets/modest-msg-view.c:
41 Added modest_msg_view_get_message_is_empty() but this needs
43 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
44 Check if there is any text in the message yet.
45 But this needs to be implemented properly.
46 (modest_msg_edit_window_toggle_find_toolbar):
47 * src/maemo/modest-msg-view-window.c:
48 (modest_msg_view_window_toggle_find_toolbar):
49 Show a banner warning if there is no text to search, when
50 trying to start a search. This partially fixes
51 projects.maemo.org bug NB#62350.
53 2007-07-13 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-mail-operation.c: (update_account_thread):
56 Initialized num_new_headers to fix the build.
58 2007-07-13 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
61 Ignore modest accounts whose server accounts don't exist in gconf.
62 This prevents us trying to create TnyAccount instances for those
63 server accounts when the server account has been removed from gconf,
64 but the parent modest account has not yet been removed from modest.
65 I don't know why this is only noticeable now. It was probably just
66 a harmeless g_warning() anyway.
68 2007-07-13 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
71 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
73 2007-07-12 Armin Burgmeier <armin@openismus.com>
75 * src/maemo/modest-main-window.c: Make default account appear bold
76 in view, tools/send & receive and toolbar/send & receive SCM menus.
77 This fixes projects.maemo.org bug NB#59010.
79 2007-07-12 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
82 Add a short-cut, by checking if the folder store is an account.
83 This ensures that the Sort menu item and toolbar is dimmed for
84 the local-folders account root item, fixing
85 projects.maemo.org bug NB#62545.
87 2007-07-12 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-tny-account-store.c: (get_password):
90 Show the password dialog (via the signal) only in the mainloop, via
91 an idle handler that we wait for. This could theoretically prevent
92 hangs, though I worry that it could introduce some too.
94 2007-07-12 Murray Cumming <murrayc@murrayc.com>
96 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
97 * src/maemo/modest-platform.c:
98 (modest_platform_connect_and_wait):
99 Take a TnyAccount* parameter and try to set it to online
100 (a TnyCamel-only API), because tinymail sets accounts to offline
101 when the user cancels a password dialog, and doesn't ask again until
102 it has been set to online.
103 However, this is commented out because it causes a hang now.
105 (modest_platform_connect_and_wait_if_network_account):
106 * src/modest-mail-operation.c:
107 (modest_mail_operation_update_account):
108 * src/modest-platform.h:
109 * src/modest-ui-actions.c: (_modest_ui_actions_open),
110 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
112 2007-07-12 Armin Burgmeier <armin@openismus.com>
114 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
116 * src/modest-mail-operation.c:
117 * src/modest-ui-actions.c: Check for already existing folder before
118 querying the server, show error message from camel if the request
119 still fails. This fixes projects.maemo.org bug NB#58701.
121 2007-07-12 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-tny-account-store.h:
124 * src/modest-tny-account-store.c:
125 Added modest_tny_account_store_forget_password_in_memory(),
126 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
127 when creating a new account, so that new passwords will be used, instead of
128 us thinking that it's a second request as a result of a failed password again.
130 2007-07-12 Murray Cumming <murrayc@murrayc.com>
132 * src/dbus_api/modest-dbus-callbacks.c:
133 (on_idle_open_message): If the message is in drafts then open it
134 in an edit window instead of a view window. This fixes
135 projects.maemo.org bug NB#63005.
137 2007-07-12 Murray Cumming <murrayc@murrayc.com>
139 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
140 Avoided a harmless g_warning().
142 2007-07-12 Murray Cumming <murrayc@murrayc.com>
144 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
145 Pass the modest account name, not the TnyAccount display name to
146 modest_msg_view_window_new() so that the reply feature works,
147 fixing projects.maemo.org bug NB#62892.
149 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
150 (modest_msg_view_window_new_with_header_model):
151 * src/maemo/modest-msg-view-window.c:
152 (modest_msg_view_window_new_with_header_model),
153 (modest_msg_view_window_new):
154 * src/modest-ui-actions.c: (reply_forward):
155 * src/widgets/modest-msg-view-window.h:
156 * src/widgets/modest-window.c: (modest_window_set_active_account):
157 Rename an account parameter to modest_account_name to make this clearer.
159 2007-07-11 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-ui-actions.h:
162 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
163 modest_do_message_delete().
164 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
165 Call modest_do_message_delete(), hoping that this would cause messages
166 to be really deleted from search instead of just marked with strike through.
167 Does not seem to help.
169 2007-07-11 Armin Burgmeier <armin@openismus.com>
171 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
172 priv->reselect to FALSE prior to calling
173 modest_folder_view_select_first_inbox_or_local() to prevent endless
174 recursion and thus a crash on startup.
176 2007-07-11 Armin Burgmeier <armin@openismus.com>
178 * src/maemo/modest-account-settings-dialog.h: Include
179 <gtk/gtknotebook.h> to fix the build (at least for me).
181 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
182 Use "New FolderN" as default suggested name if "New folder" already
183 exists, with N being the first free number, though never exceed "New
184 folder99" in which case we just fall back to "New Folder" even though
185 it already exists. This fixes projects.maemo.org bug NB#58663.
187 2007-07-11 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
190 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
191 projects.maemo.org bug NB#62778.
193 2007-07-11 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
196 Ignore the wrong (for now) secure-smtp setting in the presets -
197 just default to requiring secure authentication for SMTP, because
200 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
202 * src/widgets/modest-folder-view.c: (filter_row)
203 Do not show drafts folder (see UI specs)
205 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
207 * src/modest-ui-actions.c:
208 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
209 place and also not necessary.
211 * src/widgets/modest-folder-view.c: (filter_row)
212 Guess folder type and hide Sent & Outbox if necessary.
213 Fixed project.maemo.org NB#57328
215 2007-07-11 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-ui-actions.h:
218 * src/modest-ui-actions.c:
219 (modest_ui_actions_on_delete_message):
220 Move some code into a new
221 modest_ui_actions_refresh_message_window_after_delete()
222 function so we can use it from elsewhere.
224 * src/dbus_api/modest-dbus-callbacks.c:
225 (on_idle_delete_message), (on_delete_message): Used an idle
226 handler, as we do for the other D-Bus method handlers.
227 Call modest_ui_actions_refresh_message_window_after_delete()
228 if the deleted message was open in a window. This fixed
229 projects.maemo.org bug NB#62862.
231 2007-07-11 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-main.c: (main): Only show the UI at the start if
234 the showui command line option was given. For instance,
235 run-standalone src/modest showui
236 Otherwise, we wait for the top_application D-Bus method to
237 be sent by hildon-desktop when the application is selected
239 This allows us to run without a UI when osso-global-search
240 uses our D-Bus methods.
242 2007-07-11 Murray Cumming <murrayc@murrayc.com>
244 * src/dbus_api/modest-dbus-api.h: Added a define for a
245 top-application D-Bus method.
246 * src/dbus_api/modest-dbus-callbacks.c:
247 (on_top_application),
248 (modest_dbus_req_handler): Handle the top-application D-Bus
249 method, which might be an undocumented D-Bus signal sent by
250 hildon-desktop when it starts the application from the menu.
251 But I am not sure and I need to test it on the device, because
252 my scratchbox does not have the application in the menu now.
253 This method shows the main window, so that it can be invisible
254 when started, for instance, just for email searching from
257 * src/maemo/modest-main-window.c: (restore_settings),
258 (modest_main_window_new): Do not show the window immediately
259 upon creation. We show it later.
260 * src/modest-widget-memory.c: (save_settings_paned):
261 Try (unsuccessfully) to avoid saving the paned position when
262 it is not even visible.
263 (restore_settings_paned): Do not allow a silly paned position.
264 This seems necessary when not showing the window at first.
266 * tests/dbus_api/Makefile.am:
267 * tests/dbus_api/test_top_application.c: (main): Test for the
270 2007-07-10 Murray Cumming <murrayc@murrayc.com>
272 * src/modest-ui-dimming-rules.c:
273 (modest_ui_dimming_rules_on_new_msg),
274 (modest_ui_dimming_rules_on_reply_msg),
275 (modest_ui_dimming_rules_on_delete_msg),
276 (modest_ui_dimming_rules_on_details),
277 (modest_ui_dimming_rules_on_view_window_move_to),
278 (modest_ui_dimming_rules_on_view_previous),
279 (modest_ui_dimming_rules_on_view_next),
280 (_invalid_folder_for_purge): Added checks before
281 casting the window. This looks like an actual
282 logic error in _invalid_folder_for_purge(), because it
283 tries to use a ModestMainWindow as a message window.
285 2007-07-10 Murray Cumming <murrayc@murrayc.com>
287 * src/maemo/modest-account-settings-dialog.c:
288 (show_error): Use the same implementation as in
289 modest-easysetup-wizard.c:
290 (on_entry_invalid_character): The logical ID contains a %s.
291 Guessed what it should be.
292 (on_entry_max), (check_data), (on_response): Adapt to
293 changed show_error().
294 (create_page_account_details): Really call
295 modest_validating_entry_set_func() on the correct widgets.
296 * src/maemo/easysetup/modest-easysetup-wizard.c:
297 (on_entry_invalid_character): Fix the logical ID here too.
298 (create_page_account_details),
299 (create_page_user_details):
301 modest_validating_entry_set_func() on the correct widgets.
303 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
304 Do not try to use the account if it is NULL.
306 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
308 * src/modest-ui-actions.c: (create_move_to_dialog),
309 (modest_ui_actions_on_main_window_move_to),
310 (modest_ui_actions_on_msg_view_window_move_to):
311 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
312 (filter_row), (modest_folder_view_show_non_move_folders):
313 * src/widgets/modest-folder-view.h:
315 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
316 the Sent folder yet as it does not report the correct folder type.
318 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
320 * src/maemo/modest-msg-edit-window.c: (init_window):
323 2007-07-10 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
326 Take a parent widget instead of a parent window, and
327 implement this with hildon_banner_show_information() instead.
328 Non-Maemo builds can just ifdef that there.
329 This fixed projects.maemo.org bug NB#62766.
331 (on_entry_invalid_character): Use show_error() again instead
332 of using hildon directly, and use the _CS() macro to use the correct
334 (create_account), (check_for_supported_auth_methods), (on_entry_max):
335 Pass a widget instead od a window to show_error().
337 2007-07-10 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
340 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
341 This allows us to show the server name in the error message, fixing
342 projects.maemo.org bug NB#62904.
343 Also, use the appropriate logical ID message for the account protocol.
345 2007-07-10 Murray Cumming <murrayc@murrayc.com>
347 * src/modest-tny-account-store.c: (on_idle_wrong_password):
348 A compilation fix, though the build wasn't broken for me.
350 2007-07-09 Murray Cumming <murrayc@murrayc.com>
352 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
353 Do not try to unref a NULL folder store, to avoid a runtime warning.
354 This seems to happen sometimes when changing accounts settings.
356 2007-07-09 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-tny-account-store.c:
359 (modest_tny_account_store_instance_init),
360 (modest_tny_account_store_finalize),
361 (on_account_settings_hide), (on_idle_wrong_password):
362 Use a GHashTable to ensure that we only show one account settings
363 dialog per modest account. This avoids us having a dialog open for
364 both the store and transport accounts, or due to repeated get_password()
365 calls that shouldn't happen anyway.
367 2007-07-09 Murray Cumming <murrayc@murrayc.com>
369 * src/maemo/modest-maemo-utils.c: (on_hide),
370 (modest_maemo_show_dialog_and_forget): Handle the response, because
371 the window is not even hidden by default.
373 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
374 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
375 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
376 which seems to prevent some modality problems.
378 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
379 Ignore user cancellation errors.
381 * src/modest-account-mgr-helpers.h:
382 * src/modest-account-mgr-helpers.c:
383 Added modest_server_account_get_password() and
384 modest_server_account_get_has_password() to avoid direct use of
387 * src/maemo/modest-account-settings-dialog.h:
388 * src/maemo/modest-account-settings-dialog.c:
389 (modest_account_settings_dialog_init): Store the notebook so we can
391 Added modest_account_settings_dialog_switch_to_user_info().
393 * src/modest-tny-account-store.c:
394 (get_password): When the password in the account settings is wrong (we think),
395 show the relevant page of the account settings dialog, in the mainloop.
396 However, we currently get many of these at once because cancel does not
398 (forget_password): Do not forget the password
399 from the account settings, because this causes side-effects when
400 tinymail seems to call it at strange time, maybe because of how we
401 are cancelling get_password().
402 (modest_tny_account_store_alert): Ignore user cancellations.
404 2007-07-09 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/modest-maemo-utils.h:
407 * src/maemo/modest-maemo-utils.c:
408 Added modest_maemo_show_information_note_and_forget() for use instead of
409 gtk_dialog_run() when the response is not needed, to avoid an extra
410 mainloop which could cause a hang.
412 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
413 Use the logical IDs for the error message, though they are not
414 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
415 because gtk_dialog_run() caused a hang here (the window did not close).
416 This fixes projects.maemo.org bug NB#62646.
418 2007-07-09 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-account-mgr-helpers.h:
421 * src/modest-account-mgr-helpers.c:
422 Added modest_account_mgr_get_store_protocol().
424 * src/maemo/modest-account-view-window.c:
425 (on_delete_button_clicked): Show different warning text depending on
426 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
427 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
430 2007-07-09 Murray Cumming <murrayc@murrayc.com>
432 * src/maemo/modest-msg-edit-window.c:
433 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
434 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
436 2007-07-07 Armin Burgmeier <armin@openismus.com>
438 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
439 ckdg_ib_maximum_characters_reached from correct package.
441 * src/modest-ui-actions.c: Show an error message when a folder could
442 not be created. Tinymail does not give us specific error codes about
443 what has gone wrong, so we assume that a folder with that name
444 already exists, though there might be other reasons.
446 2007-07-06 Murray Cumming <murrayc@murrayc.com>
448 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
449 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
450 give a more exact error message that can be partly translated.
452 2007-07-05 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/modest-address-book.c:
455 (select_email_addrs_for_contact): Specify a default window size for the
456 select-email-address dialog, so that it is probably big enough for the
457 title. This should fix projects.maemo.org bug NB#62277.
459 2007-07-05 Murray Cumming <murrayc@murrayc.com>
461 * src/maemo/easysetup/modest-easysetup-wizard.c:
462 (create_page_complete_easysetup): Use
463 gtk_widget_set_size() request to ensure that the text wraps
466 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
468 * src/maemo/easysetup/modest-easysetup-wizard.c:
469 (on_entry_invalid_character), (create_page_account_details),
470 (create_page_user_details):
471 Use new API of ModestValidatingEntry. But for some reason the banner is
472 not shown. I will have to investigate that further.
474 * src/widgets/modest-validating-entry.c: (on_insert_text),
475 (modest_validating_entry_set_func):
476 * src/widgets/modest-validating-entry.h:
477 Added a new callback function to be able to react to prevented
478 characters whitespaces to e.g show a banner.
480 2007-07-05 Armin Burgmeier <armin@openismus.com>
482 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
483 notification of HildonNumberEditor instead of remembering the port
484 number. Thanks to Johannes for pointing this out.
486 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
488 * src/maemo/easysetup/modest-easysetup-wizard.c:
489 Check if there are any user changes before showing a confirmation
490 dialog (projects.maemo.org NB#60946)
492 2007-07-05 Armin Burgmeier <armin@openismus.com>
494 * src/maemo/modest-account-settings-dialog.c: Remember custom port
495 number at the beginning of the dialog and set the modified flag at the
496 end if the port number has changed. This is necessary because
497 HildonNumberEditor does not support notification when the value has
500 2007-07-05 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-ui-actions.c:
503 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
504 a connection before asking anything else. Correct the check for the destination
505 folder so that it succeeds when online.
506 This fixed projects.maemo.org bug NB#61645.
508 2007-07-05 Murray Cumming <murrayc@murrayc.com>
510 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
511 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
512 to fix projects.maemo.org bug NB#62439.
514 2007-07-05 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-tny-account.c: (on_connection_status_changed):
517 Really do not use tny_device_force_offline() here. See the previous comment.
519 2007-07-04 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-tny-account.c: (on_connection_status_changed):
522 Do not use tny_device_force_offline() when tinymail says that something
523 went wrong with the connection. It seems to report this unnecessarily.
525 2007-07-04 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/modest-connection-specific-smtp-window.c:
528 (modest_connection_specific_smtp_window_init):
529 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
530 does not seem to have any effect in osso 1.1 (though it works in
531 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
533 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
535 * src/maemo/modest-connection-specific-smtp-window.c:
536 Fix UI specification problems with projects.meamo.org NB#60479
538 2007-07-04 Murray Cumming <murrayc@murrayc.com>
540 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
541 clue when this has failed, because the error dialog is not always shown
542 (at least in earlier version).
544 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
545 GError message, because the generic error dialog is not helpful.
547 'This message is not currently available (can't let a new connection go online)'
548 when trying to open an IMAP message.
550 (_modest_ui_actions_open): Offer a connection when some messages would
551 have to be downloaded and we are offline.
553 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
555 * src/widgets/modest-folder-view.c:
556 Don't check for MERGE type anymore as we use the correct type
558 NOTE: For the last two changes you need to update your tinymail copy
559 because of API changes!
561 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
563 * src/modest-tny-local-folders-account.c:
564 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
565 (see projects.maemo.org NB#61580)
567 2007-07-04 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-tny-account.c: (on_connection_status_changed):
570 Commented out the call to modest_platform_connect_and_wait() because this
571 seems to always hang, and I would like to know if this is the only thing
572 that causes a hang when showing the connection dialog.
573 It is not very useful anyway.
575 2007-07-04 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/modest-msg-view-window.c:
578 (modest_msg_view_window_select_next_message):
580 * src/modest-platform.h:
581 * src/maemo/modest-platform.c:
582 Added modest_platform_connect_and_wait(), which calls
583 tny_maemo_conic_device_connect() always in the main thread, by calling it
584 in an idle handler and waiting for the idle handler to run. It should be
585 in the main thread because it uses GTK+ UI code. It just returns TRUE
586 if the device is already online.
588 There is some nasty code to ensure that subsequent calls to
589 modest_platform_connect_and_wait() just wait for the first one to finish,
590 by checking repeatedly in another idle handler. This is necessary,
591 because other threads (or even the main thread, via another idle handler)
592 can call modest_platform_connect_and_wait() while
593 modest_platform_connect_and_wait() is running.
595 (modest_platform_connect_and_wait_if_network_account),
596 (modest_platform_connect_and_wait_if_network_folderstore):
597 Convenience functions that calls modest_platform_connect_and_wait() if
598 the account or folder might want network access.
600 * src/modest-mail-operation.c:
601 (modest_mail_operation_update_account):
602 * src/modest-ui-actions.c: (download_uncached_messages),
603 (modest_ui_actions_on_rename_folder), (delete_folder),
604 (modest_ui_actions_on_main_window_move_to),
605 (modest_ui_actions_on_msg_view_window_move_to):
606 * src/widgets/modest-folder-view.c:
607 (drag_and_drop_from_folder_view):
608 Offer a connection if we are offline.
610 * src/modest-tny-account.c: (on_connection_status_changed):
611 Document this as only handling errors during network operations in progress,
612 and replace the idle code with a simple call to
613 modest_platform_connect_and_wait(), which does this instead.
615 2007-07-03 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-tny-account.c:
618 (modest_tny_account_get_special_folder): (util_on_idle),
619 Handle the GError so we can see when tny_folder_store_get_folders()
620 fails, as it currently does while something else is connecting.
622 Added util_run_in_main_thread_and_wait()
623 which uses an idlen handler and mainloop to ensure that the function
624 is called in the main thread.
625 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
626 to make sure that we call attempt the connection in the mainloop only,
627 which might solve some hangs.
629 2007-07-03 Murray Cumming <murrayc@murrayc.com>
631 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
632 be found by their display name. This is never useful.
633 * src/modest-tny-account-store.c: (on_account_removed): Find the account
634 by its ID, instead of trying to use its ID as its display name.
636 * src/modest-tny-account-store.h:
637 * src/modest-tny-account.c:
638 (modest_tny_account_get_special_folder): Add a g_warning() when
639 tny_folder_store_get_folders() returns an empty list for the maildir.
641 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
642 Add a g_warning() when this returns NULL, because that it not allowed
645 2007-07-02 Armin Burgmeier <armin@openismus.com>
647 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
648 note when trying to cancel the wizard. This fixes projects.maemo.org
651 2007-07-02 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-tny-account.h:
654 * src/modest-tny-account.c:
655 (modest_tny_account_new_from_server_account),
656 (modest_tny_account_new_from_server_account_name),
657 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
658 because this must now be set before setting the proto. This is usd in
659 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
660 warning in camel_session_get_service() caused by
661 tny_camel_transport_account_prepare().
663 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
666 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
668 * src/maemo/modest-connection-specific-smtp-edit-window.c:
670 (modest_connection_specific_smtp_edit_window_init):
672 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
675 2007-06-29 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-tny-account.c:
678 (modest_tny_account_new_from_server_account):
679 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
680 now uses to request a connection when it needs one, and which it uses
681 to tell us that something is wrong with the connection, so we can force
682 the accounts offline to prevent further problems.
685 * src/modest-init.c: (init_default_settings):
686 * src/modest-mail-operation.c:
687 (modest_mail_operation_update_account):
688 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
689 This should not be necessary anymore. Do not set the conf key that
690 determined this (it was always TRUE and not set anywhere else).
692 * src/modest-ui-actions.h: Remove unused and unimplemented
693 modest_ui_actions_on_online_toggle_toggled().
695 2007-06-29 Murray Cumming <murrayc@murrayc.com
697 * src/maemo/modest-main-window.c: (connect_signals):
698 Don't connect to delete_event twice. Maybe this was harmless.
700 2007-06-29 Murray Cumming <murrayc@murrayc.com
702 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
703 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
704 Debug output to give some more clue when a folder move is not allowed.
706 2007-06-28 Murray Cumming <murrayc@murrayc.com
708 * src/modest-tny-account.c: (on_modest_file_system_info),
709 (modest_tny_account_get_mmc_account_name):
710 Always call the callback, without checking whether the name has changed.
711 * src/widgets/modest-folder-view.c: (strings_are_equal),
712 (on_model_foreach_set_name), (on_get_mmc_account_name),
713 (text_cell_data): Compare the name here, and use the name from
714 the account rather than from the
715 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
716 if the name was changed after the account was added to the model.
717 That's a tinymail bug but not one that I want to fix now.
719 This finally fixes projects.maemo.org bug NB#59301.
721 2007-06-27 Armin Burgmeier <armin@openismus.com>
723 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
726 2007-06-27 Murray Cumming <murrayc@murrayc.com
728 * src/modest-tny-account.h:
729 * src/modest-tny-account.c:
730 Added modest_tny_account_get_mmc_account_name(), to set the memory
731 card name asynchronously for the given account and then notify.
732 (modest_tny_account_new_for_local_folders): Use this new function instead
733 of using hildon_file_system_info_async_new() directly.
735 * src/widgets/modest-folder-view.c: (text_cell_data):
736 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
737 gtk_tree_model_row_changed() when it is available.
739 This should fix projects.maemo.org bug NB#59301.
741 2007-06-27 Murray Cumming <murrayc@murrayc.com
743 * src/modest-mail-operation.c: (update_account_thread),
744 (get_msgs_full_thread): Fix typo failures in the revert
747 2007-06-27 Murray Cumming <murrayc@murrayc.com
749 * src/maemo/modest-maemo-global-settings-dialog.c:
750 (idle_select_default_focus):
751 * src/modest-mail-operation.c: (idle_notify_progress),
752 (idle_notify_progress_once), (set_last_updated_idle),
753 (update_account_thread), (get_msgs_full_thread):
754 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
755 * src/widgets/modest-header-view.c:
756 (idle_notify_headers_count_changed_destroy),
757 (idle_notify_headers_count_changed):
758 Reverted the additions of gdk_threads_enter/leave(), in case this
759 helps with a startup hang on the device.
761 2007-06-26 Armin Burgmeier <armin@openismus.com>
763 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
764 for supported secure authentication methods from server by
765 gtk_dialog_run(), saving CPU time and a potential race condition.
767 2007-06-26 Armin Burgmeier <armin@openismus.com>
769 * src/maemo/modest-maemo-utils.h:
770 * src/maemo/modest-maemo-utils.c: Added a
771 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
772 only error code to tell the calling code when the user canceled the
775 * src/maemo/modest-account-settings-dialog.h:
776 * src/maemo/modest-account-settings-dialog.c:
777 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
778 message if the retrieval of secure authentication methods was canceled
779 by the user. Perform the check before saving anything to configuration
780 to not end up with half-committed configuration changes, do not show
781 a "Saving to configuration failed" note when authentication methods
782 could not be retrieved.
784 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
787 2007-06-26 Murray Cumming <murrayc@murrayc.com>
789 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
790 Only return the first level of folders under accounts, because the
791 osso-global-search UI spec doesn't want the rest.
792 This fixed projects.maemo.org bug NB#61811.
794 2007-06-26 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-tny-account-store.c:
797 * src/modest-tny-account-store.h:
798 Added modest_tny_account_is_memory_card_account().
799 * src/maemo/modest-main-window.c: (create_details_widget):
800 Show the same information items for the memory card as we show for the
801 local-folders, to fix projects.maemo.org bug NB#59307.
803 2007-06-26 Murray Cumming <murrayc@murrayc.com>
805 * src/modest-tny-account-store.c: (get_password):
806 Added some checks for NULL to maybe prevent crashes, though I think
807 it was Philip's last commit that actually prevented the crash here
808 when creating a first new account.
809 But the new account is still not usable (no messages are shown)
810 until a restart of the application.
812 2007-06-26 Murray Cumming <murrayc@murrayc.com>
814 * src/maemo/modest-maemo-global-settings-dialog.c:
815 (idle_select_default_focus):
816 * src/modest-mail-operation.c: (idle_notify_progress),
817 (idle_notify_progress_once), (idle_notify_update_account_queue),
818 (set_last_updated_idle), (update_account_thread),
819 (notify_get_msgs_full), (get_msgs_full_destroyer),
820 (get_msgs_full_thread):
821 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
822 * src/widgets/modest-header-view.c:
823 (idle_notify_headers_count_changed_destroy),
824 (idle_notify_headers_count_changed):
825 Use gdk_threads_enter() and gdk_threads_enter_leave() in
826 all idle handlers, because some other thread could be blocking
827 the GDK lock, so that it can do GUI stuff.
829 2007-06-26 Murray Cumming <murrayc@murrayc.com>
831 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
832 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
833 (on_idle_send_receive), (on_idle_open_default_inbox):
834 * src/maemo/modest-msg-edit-window.c:
835 (modest_msg_edit_window_attach_file_noninteractive):
836 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
837 to prevent a hang. I don't quite understand why these are necessary,
838 beause we should already be in the main loop. I guess something outside
839 of the main loop is taking the lock.
841 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
842 we are really using URIs, and use files that are more likely to exist.
844 2007-06-26 Murray Cumming <murrayc@murrayc.com>
846 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
847 necessary because configure.ac now defines different variables.
849 2007-06-26 Murray Cumming <murrayc@murrayc.com>
851 * libmodest-dbus-client/libmodest-dbus-client.c:
852 * libmodest-dbus-client/libmodest-dbus-client.h:
853 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
854 libmodest_dbus_client_compose_mail() is what things actually use.
856 * src/dbus_api/modest-dbus-api.h:
857 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
858 * tests/dbus_api/Makefile.am:
859 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
862 2007-06-26 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-init.c: (modest_init_local_folders):
865 For memory-card (or other non local-folders) maildir accounts,
866 always create an Archive folder, so that there is somewhere to put
867 messages. This should be less confusing, because the user does not need
868 to guess that the need to create a folder.
870 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
872 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
873 Fixed icon size by using (50, 50) which is the same as defined by
876 2007-06-25 Armin Burgmeier <armin@openismus.com>
878 * src/widgets/modest-window-mgr.c:
880 * configure.ac: Correctly recognize hildon-notify presence and fixed
881 the build without it being installed.
883 2007-06-25 Murray Cumming <murrayc@murrayc.com>
885 * libmodest-dbus-client/libmodest-dbus-client.c:
886 (libmodest_dbus_client_search): Fix the build. Sorry.
887 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
888 (reply_forward_cb): Initialize variables to fix the build.
890 * src/modest-tny-account-store.c:
891 (modest_tny_account_store_get_tny_account_by): Fix the account URI
892 comparison (a silly typo) so that email search results can be opened
893 when there are more than one account.
895 2007-06-25 Murray Cumming <murrayc@murrayc.com>
897 * libmodest-dbus-client/libmodest-dbus-client.c:
898 (libmodest_dbus_client_search),
899 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
900 instead of 1 second, because the search gets folders and messages from
901 the server, which can take a long time. When it times out,
902 osso-global-search will report no results.
904 We need to specify whether we should search only cached information
905 (maybe with a user preference), and the osso-email-search-plugin
906 API should really be improved to allow that option, and to allow results
907 to be delivered asynchronously in batches.
909 2007-06-25 Murray Cumming <murrayc@murrayc.com>
911 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
912 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
913 GTK_ICON_SIZE_DIALOG is probably the wrong size.
915 2007-06-25 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
918 that is an empty string. D-Bus seems to give us these instead of NULL.
920 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
922 * src/dbus_api/modest-dbus-callbacks.c:
923 * src/maemo/easysetup/modest-easysetup-wizard.h:
924 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
925 * src/maemo/modest-connection-specific-smtp-edit-window.c:
926 (modest_connection_specific_smtp_edit_window_init):
927 * src/maemo/modest-maemo-global-settings-dialog.c:
929 * src/maemo/modest-maemo-utils.c:
930 (modest_maemo_utils_setup_images_filechooser):
931 * src/maemo/modest-main-window.c: (create_details_widget):
932 * src/maemo/modest-msg-edit-window.c:
933 (modest_msg_edit_window_attach_file_noninteractive),
934 (modest_msg_edit_window_color_button_change),
935 (modest_msg_edit_window_set_zoom):
936 * src/modest-mail-operation.c: (update_account_thread):
937 * src/modest-tny-account-store.c:
938 * src/modest-tny-account.c:
939 * src/widgets/modest-global-settings-dialog.c:
940 * src/widgets/modest-window.h:
944 2007-06-25 Murray Cumming <murrayc@murrayc.com>
946 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
947 * src/modest-search.c: (modest_search_folder),
948 (modest_search_all_accounts): Actually search only in the specified folder,
949 doing a simple match on the folder ID.
950 * src/modest-search.h: Added a folder field to the ModestSearch struct,
951 and added some documentation.
953 2007-06-22 Armin Burgmeier <armin@openismus.com>
955 * src/maemo/modest-maemo-utils.h:
956 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
957 modest_maemo_utils_get_supported_secure_authentication_methods.
959 * src/maemo/easysetup/modest-easysetup-wizard.c:
960 * src/maemo/modest-account-settings-dialog.c: Show correct error if
961 one occured, not just "Server does not support secure authentication".
963 2007-06-22 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-tny-account-store.c: (get_password):
966 Restored the call to tny_account_set_user() because Philip seems to have
967 stopped this from crashing (by not using the freed string). It still does
968 not work, but now we can test it.
970 2007-06-22 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/modest-msg-edit-window.c: (init_window):
973 Comment out use of an uninitialzed GtkScrolledWindow variable,
974 to fix the build and stop a crash. Yet again.
976 2007-06-22 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-tny-account-store.c: (get_password):
979 Remove the call to tny_account_set_user() because this actually crashes.
980 As mentioned in the last commit, it is known to not work anyway.
982 2007-06-22 Murray Cumming <murrayc@murrayc.com>
984 * src/modest-tny-account-store.c: (get_password):
985 Use tny_account_set_username() to tell tinymail that the username might
986 have changed too. But tinymail ignores this: see projects.maemo.org
988 * src/modest-ui-actions.c:
989 (modest_ui_actions_on_password_requested): Remove the useless attempt to
990 reset the connection when changing the username, and improve the comments.
991 Save the changed username to gconf at least, so it is used when Modest is
994 2007-06-21 Murray Cumming <murrayc@murrayc.com>
996 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
997 Do not use a query, so that we get all folders, including for POP and
998 local-folders. They work as search criteria too.
999 This fixes projects.maemo.org bug NB#57740.
1001 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1003 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1004 Comment out the use of hildon_notification_set_sound() because it is
1005 not declared, to fix the build. Warnings are serious, people.
1007 2007-06-21 Armin Burgmeier <armin@openismus.com>
1009 * src/maemo/modest-maemo-utils.h:
1010 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1011 modest_maemo_utils_get_supported_secure_authentication_methods()
1012 to query authentication methods for a specific user. This should fix
1013 projects.maemo.org bug NB#61369.
1015 * src/maemo/easysetup/modest-easysetup-wizard.c:
1016 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1019 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1021 * libmodest-dbus-client/libmodest-dbus-client.h:
1022 * libmodest-dbus-client/libmodest-dbus-client.c:
1023 (modest_dbus_message_iter_get_search_hit),
1024 (libmodest_dbus_client_search):
1025 Reorganised and commented this.
1026 Removed modest_search_hit_free() from the public API because it
1029 Added libmodest_dbus_client_get_folders() and
1030 modest_folder_result_list_free().
1032 * src/dbus_api/modest-dbus-api.h:
1033 * src/dbus_api/modest-dbus-callbacks.c:
1034 (modest_dbus_req_filter): Commented. Moved most code to
1035 on_dbus_method_search() and added on_dbus_method_get_folders().
1037 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1038 of the extra D-Bus handler.
1040 * tests/dbus_api/Makefile.am:
1041 * tests/dbus_api/test_get_folders.c: New test for
1042 libmodest_dbus_client_get_folders(). This seems to return an empty list
1043 at the moment. That could be the same error that causes the message list
1044 to be empty sometimes.
1045 This should help with projects.maemo.org bug NB#57740.
1047 2007-06-21 Armin Burgmeier <armin@openismus.com>
1049 * src/modest-mail-operation.c: Do not call
1050 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1051 notify the operation's end after having set the status to CANCELED for
1052 the operation queue to listen on. This fixes a deadlock when there
1053 were mail operations in the queue during its finalization.
1055 * src/modest-singletons.c: Reordered uninitialization of the account
1056 manager to happen after the mail operation queue was uninitialized
1057 because the mail operation's in the queue might still try to access
1058 the account manager (see modest_mail_operation_notify_end()). This
1059 fixes a potential crash when terminating the application.
1061 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-search.c:
1064 (search_mime_part_and_child_parts): Moved some code here so we
1065 can search recursively in child folders.
1066 (modest_search_folder): Search in the message as a mime part, instead
1067 of just its child mime parts.
1068 (read_chunk), (search_mime_part_ogs):
1069 Check how many bytes were read, to prevent an endless loop.
1070 Searching in message bodies now works. This finishes the fix for
1071 projects.maemo.org bug NB#61007.
1073 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1075 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1076 Add a g_warning when the item is not a folder.
1078 * src/modest-ui-dimming-rules.c:
1079 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1080 when selected item is not a folder (for instance, an account), because
1081 the UI spec only talks about folders.
1082 I am not sure what the UI spec wants, so this might not totally fix
1083 projects.maemo.org bug NB#60794.
1085 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1087 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1088 (load_from_file): Sort the list. The unsorted list would be more noticeable
1089 in non-English locales.
1091 * src/maemo/modest-msg-edit-window.c:
1092 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1093 warning and fix the build.
1095 * src/maemo/modest-progress-bar-widget.c:
1096 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1097 avoid a g_warning, and probably to avoid a crash.
1099 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-search.c: (modest_search_folder): Check for a GError
1102 when calling tny_folder_get_headers(), to show that this is not the cause
1105 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1107 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1108 Actually set the body query instead of the subject query.
1110 * src/modest-search.c: (search_mime_part_ogs),
1111 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1112 which would probably cause it to fail if we got this far.
1114 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1115 to simplify the code.
1116 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1117 be causing search-in-body to fail.
1119 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1121 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1123 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1124 Better debug message when the folder cannot be found.
1125 This should help with fixing projects.maemo.org bug #61287.
1126 * src/modest-search.c: (add_hit): Do not leak the furl string.
1128 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1130 * src/modest-ui-actions.c:
1131 (modest_ui_actions_on_folder_selection_changed):
1132 Do not special-case TNY_MERGE_FOLDER here, because
1133 modest_tny_folder_get_account() already does that. This fixes
1134 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1135 shown when the Outbox was selected).
1137 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1139 * libmodest-dbus-client/libmodest-dbus-client.c:
1140 (_dbus_iter_get_string_or_null): Initialize the string variable in
1141 case this helps with Dirk's crash.
1143 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1145 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1146 though it is not implemented yet (this function is maybe not even used),
1147 to avoid breaking ABI in future.
1148 * libmodest-dbus-client/libmodest-dbus-client.c:
1149 (get_attachments_string): Moved some code into this generic function.
1150 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1151 sends email. It is maybe not used.
1152 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1153 (on_send_mail): Use attachments.
1155 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1156 * src/maemo/modest-msg-edit-window.c:
1157 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1158 a filename before using it, to fix projects.maemo.org bug NB#58233.
1160 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1163 Initialize the continue_download variable to fix the build, and probably
1164 to fix randome behaviour.
1166 2007-06-18 Armin Burgmeier <armin@openismus.com>
1168 * src/modest-tny-send-queue.h:
1169 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1170 the queue so we can later show it in the UI. Replaced
1171 modest_tny_send_queue_msg_is_being_sent() by
1172 modest_tny_send_queue_get_msg_status().
1174 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1176 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1177 gpointer. This probably was not harmful, but just to be sure.
1179 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1182 Fix the build, but leave the function broken on Bora, because
1183 hildon_uri_action_get_service() does not exist.
1184 osso_uri_action_get_service() does not exist either, it seems.
1186 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1188 * src/modest-tny-account.c:
1189 (modest_tny_account_new_from_server_account):
1190 Uncommented the url debug output again, because it is useful for
1191 debugging, as I said in the comment.
1193 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1195 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1197 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1198 for Mameo Bora, to fix the build.
1200 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1203 Fixed build with hildon < 0.99
1205 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1206 Check if the selected account is busy instead of checking all accounts
1208 * src/modest-account-mgr-priv.h:
1209 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1210 (modest_account_mgr_init), (compare_account_name),
1211 (modest_account_mgr_set_account_busy),
1212 (modest_account_mgr_account_is_busy):
1213 * src/modest-account-mgr.h:
1214 Added busy information to the account manager. It possible to
1215 set an account to busy or not busy now.
1217 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1218 (modest_mail_operation_update_account),
1219 (modest_mail_operation_notify_end):
1220 Set the account to busy/not busy depending on the operation state.
1222 * src/widgets/modest-account-view.c:
1223 (modest_account_view_finalize), (get_last_updated_string),
1224 (update_account_view), (on_account_busy_changed), (init_view):
1225 Show string "Refreshing..." if the account is currently busy.
1227 All this fixes projects.maemo.org bug NB#59711
1229 2007-06-14 Armin Burgmeier <armin@openismus.com>
1231 * src/widgets/modest-attachments-view.h:
1232 * src/widgets/modest-attachments-view.c: Added
1233 modest_attachments_view_has_attachments() and fixed coordinate
1234 transformation in get_att_view_at_coords(). This fixes attachment
1237 * src/widgets/modest-msg-view.c: Make use of
1238 modest_attachments_view_has_attachments() to decide whether to show
1239 attachments in the header.
1241 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1244 (on_change), (on_combo_security_changed),
1245 (modest_connection_specific_smtp_edit_window_init),
1246 (modest_connection_specific_smtp_edit_window_set_connection),
1247 (modest_connection_specific_smtp_edit_window_is_dirty):
1248 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1249 * src/maemo/modest-connection-specific-smtp-window.c:
1252 Show an comfirmation dialog for the smpt-edit-window if there are
1253 unsaved changes and the user hits cancel.
1254 (projects.maemo.org bug NB#60479)
1256 2007-06-14 Armin Burgmeier <armin@openismus.com>
1258 * src/maemo/easysetup/modest-easysetup-wizard.c:
1259 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1260 address" info in banner instead of node, and select all the text as
1261 per UI spec. This fixes projects.maemo.org bug NB#60550.
1263 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1265 reviewed by: <delete if not using a buddy>
1267 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1268 * src/modest-ui-actions.c: (folder_refreshed_cb):
1270 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1272 * src/widgets/modest-folder-view.c: (filter_row):
1273 Explictly filter out the per-account outbox accounts. I don't know why
1274 these only sometimes show up, but now they should never show up in the UI.
1275 This should fix projects.maemo.org bug NB#60160.
1277 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1280 when the toolbar does not exist yet.
1281 * src/modest-widget-memory.c: (save_settings_header_view):
1282 Added g_warnings() to help us to discover when we are trying to set
1283 an empty columns list in gconf.
1285 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-init.h:
1288 * src/modest-init.c:
1289 Added modest_init_get_default_header_view_column_ids().
1291 * src/modest-widget-memory.c: (restore_settings_header_view):
1292 Use the new function to get defaults, if the gconf key is empty,
1293 instead of not creating any columns. This seems to fix the
1294 empty right-hand pane problems.
1296 * src/widgets/modest-header-view.h: Improved documentation.
1298 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1300 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1301 Revert the use of the display name as the account name, because this
1302 is generally wrong and would break the code that follows.
1304 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1306 * src/maemo/easysetup/modest-easysetup-wizard.c:
1307 (check_for_supported_auth_methods), (on_before_next),
1310 More correct fix for projects.maemo.org bug NB# 58991
1311 Do not longer accept AUTH_PASSWORD as secure method and choose
1312 correct method when creating the account.
1314 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1316 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1317 Fixed projects.maemo.org bug NB# 58991
1319 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-init.c: (modest_init_init_core),
1322 (modest_init_local_folders): Fixed compilation errors.
1324 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1326 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1327 Remove unnecessary lib/include, though it is good in principle when needed.
1329 * src/modest-init.c: (modest_init_one_local_folder),
1330 (modest_init_local_folders):
1331 * src/modest-init.h: Initialize the .modest library for memory cards,
1332 instead of just doing nothing for them. This should allow us to create
1333 folders there, fixing projects.maemo.org bug NB#59297.
1335 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1337 * libmodest-dbus-client/libmodest-dbus-client.c:
1338 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1339 (libmodest_dbus_client_compose_mail),
1340 (libmodest_dbus_client_open_message),
1341 (libmodest_dbus_client_send_and_receive),
1342 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1344 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1345 (on_idle_open_message), (modest_dbus_req_handler),
1346 (search_result_to_message), (modest_dbus_req_filter):
1347 * src/modest-search.c: (add_hit), (modest_search_folder),
1348 (modest_search_all_accounts): Improved debug messages.
1350 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1352 * src/modest-tny-account-store.c:
1353 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1356 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1359 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account-store.c: (get_server_accounts):
1362 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1363 even when there are no accounts, so that the Outbox folder is always
1364 visible. This fixes projects.maemo.org bug NB#60158.
1366 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1368 * src/maemo/modest-main-window.c: (create_details_widget):
1369 Use the mcen_va_never logical ID.
1371 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1373 * src/dbus_api/modest-dbus-api.h:
1374 * src/dbus_api/modest-dbus-callbacks.c:
1375 (on_idle_open_default_inbox), (on_open_default_inbox),
1376 (modest_dbus_req_handler):
1377 Added a new OpenDefaultInbox method.
1379 * libmodest-dbus-client/libmodest-dbus-client.h:
1380 * libmodest-dbus-client/libmodest-dbus-client.c:
1381 Added libmodest_dbus_client_open_default_inbox() to call the new
1382 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1383 though it should maybe be used by a new osso-email-interface function.
1385 * tests/dbus_api/Makefile.am:
1386 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1389 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1391 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1392 NULL, so that the signals get all the keys. This should not actually
1393 change any behaviour because we currently update everything when anything
1396 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1398 * src/widgets/modest-folder-view.c: (text_cell_data),
1399 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1400 (find_inbox_iter): If tinymail tells us that the folder is
1401 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1402 This causes the inbox to be selected at startup, fixing part of
1403 projects.maemo.org bug NB#56305.
1405 * src/modest-ui-dimming-rules.c:
1406 (modest_ui_dimming_rules_on_tools_smtp_servers):
1407 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1408 the SMTP servers menu item.
1409 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1410 that the SMTP Servers menu item is dimmed when there are no accounts,
1411 as a future version of the UI spec will require. This fixes
1412 projects.maemo.org bug NB#56305.
1414 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1416 * src/maemo/modest-maemo-utils.c:
1417 (modest_maemo_utils_get_supported_secure_authentication_methods):
1418 Added label to dialog instead of unreadable title
1420 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1421 (modest_main_window_new):
1422 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1425 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1426 * src/modest-account-mgr.h:
1427 Added method to avoid code duplication
1429 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1430 (modest_ui_actions_on_send_receive):
1431 Use modest_account_mgr_has_accounts
1433 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1435 * src/maemo/easysetup/modest-presets.c:
1436 (modest_presets_get_info_server_security): Do not report secure auth
1438 * src/modest-protocol-info.c: Use the defines for the gconf key names
1439 for secure authentication. This was not working because we were writing
1440 Password and reading password, and the check was case sensitive.
1441 With this, gmail now works for receiving and sending when created via
1444 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1446 * src/maemo/easysetup/modest-presets.c:
1447 (modest_presets_get_info_server_security): Correct the key name for
1448 SecureSmtp, because it seems to be case-sensitive.
1449 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1450 Do not try to get the 0th notebook page if there are 0 pages, to
1451 avoid a g_warning().
1453 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1456 Prevent use of the new notification feature for now, because it currently
1457 shows one dialog for each new email, which is annoying.
1459 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1461 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1462 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1463 when no country was selected, so that we show the global ones.
1464 * src/maemo/easysetup/modest-presets.c:
1465 (modest_presets_get_providers): Return only the global providers, not
1466 all providers when mmc=0 was requested.
1468 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1471 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1472 provider ID in the combo.
1474 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1475 Do not show the page numbers, because it would be confusing when we add
1476 the 2 extra pages for the custom setup, when the user chooses the "Other"
1477 provider. This fixes projects.maemo.org bug NB#59028
1479 * src/modest-init.c: (modest_init_init_core),
1480 (modest_init_local_folders):
1481 * src/modest-init.h:
1482 * src/modest-tny-account.c:
1483 (modest_tny_account_new_for_local_folders): Do not create default folders
1484 for the memory card. This should fix projects.maemo.org bug NB#59328.
1486 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1489 Free the changed_conf_keys string items. They are already freed in the
1490 idle handler if that runs first.
1492 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1494 * src/modest-ui-actions.c:
1495 (modest_ui_actions_on_password_requested): Check that the server name
1496 is not NULL, because I just saw a password dialog with (null) as the
1499 * src/modest-tny-folder.[h|c]: Added
1500 modest_tny_folder_is_memory_card_folder().
1501 * src/modest-ui-dimming-rules.c:
1502 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1503 menu item for memory cards, as per the UI spec (section 7.4). This should
1504 fix projects.maemo.org bug NB#59297.
1506 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1508 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1509 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1510 is another problem with the code, see Murray's comment at line 772)
1512 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1515 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1516 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1517 (load_from_file), (easysetup_country_combo_box_init),
1518 (easysetup_country_combo_box_get_active_country_ids),
1519 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1520 instead of just one ID, to avoid duplicate country names in the UI.
1522 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1523 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1524 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1525 a single ID, avoiding duplicate providers.
1526 * src/maemo/easysetup/modest-easysetup-wizard.c:
1527 (on_combo_account_country): Adapt to use a list.
1529 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1532 keys changed in the last X seconds.
1534 * src/modest-account-mgr.h:
1535 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1536 (on_key_change), (modest_account_mgr_class_init),
1537 (modest_account_mgr_init), (modest_account_mgr_finalize):
1538 As the keys are changed, save them in a GSList* and signal that GSList*
1539 further every X seconds, to batch changes, to allow us to do just one
1540 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1541 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1543 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1544 changed signal signature.
1546 * src/modest-conf.c: (modest_conf_set_list),
1547 (modest_conf_on_change): Reenable notification.
1549 (modest_conf_maemo_fake_on_change): Comment out the hack that
1550 notified immediately instead of asynchronously.
1552 * src/widgets/modest-account-view.h:
1553 * src/widgets/modest-account-view.c:
1554 (update_account_view): Select the previously-selected account ID,
1555 if possible. This fixes projects.maemo.org bug NB#56933.
1557 (on_account_changed), (on_account_removed),
1558 (modest_account_view_select_account):
1560 Remove the block/unblock functions
1561 because they were not useful.
1563 * src/maemo/modest-account-view-window.c:
1564 (on_delete_button_clicked), (on_edit_button_clicked),
1565 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1567 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1569 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1570 Improve the error dialog to show Incorrect Account Settings, which seems
1571 clearer, and say that the internal error message (to be removed from the
1572 dialog later) is often misleading.
1573 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1575 * src/modest-tny-account.c:
1576 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1577 URL because this is so useful for debugging on the device.
1579 * src/widgets/modest-serversecurity-combo-box.c:
1580 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1582 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1584 * src/modest-mail-operation.c:
1585 (modest_mail_operation_send_new_mail):
1586 Added a comment about a nasty but apparently harmless message. Details
1587 added to the wiki g_warnings() page.
1589 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1591 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1592 (modest_tny_send_queue_class_init):
1593 Do not use the priv struct because it is empty, to avoid g_warnings
1594 about a non-existant priv struct.
1596 * src/modest-tny-account-store.c:
1597 (modest_tny_account_store_get_server_account),
1598 (modest_tny_account_store_get_transport_account_for_open_connection
1599 ): Do not try to get transport server accounts for local folders,
1600 because they don't have any. This avoids a g_warning().
1602 * src/maemo/modest-main-window.c:
1603 (modest_main_window_notify_send_receive_initied),
1604 (on_configuration_key_changed):
1605 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1606 * src/modest-defs.h:
1607 * src/modest-mail-operation.c:
1608 (modest_mail_operation_update_account):
1609 * src/modest-tny-account-store.h:
1610 * src/modest-tny-account.c:
1611 (modest_tny_account_get_special_folder),
1612 (modest_tny_account_new_for_local_folders),
1613 (modest_tny_account_new_for_per_account_local_outbox_folder):
1614 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1615 * src/modest-tny-local-folders-account.c:
1616 (add_account_folders_to_merged_folder):
1617 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1618 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1619 (modest_ui_actions_on_send):
1620 * src/widgets/modest-folder-view.c: (update_model):
1621 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1622 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1623 modest_tny_account_store_get_tny_account_by_account() to
1624 modest_tny_account_store_get_server_account() to make the code clearer.
1626 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1628 * src/dbus_api/modest-dbus-api.h:
1629 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1630 * src/maemo/modest-msg-edit-window.c:
1631 (modest_msg_edit_window_attach_file_noninteractive):
1632 added g_warning in case the file to be attached does not exist
1633 * tests/dbus_api/test_compose_mail.c: (main):
1634 removed obsolete comment, added generic files as test case
1636 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-tny-account-store.c: (get_server_accounts):
1639 Create the local folders account only once, not once for each outbox, and
1640 not only when there are some outboxes.
1642 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1644 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1645 code that is causing a crash at startup. Sergio says that he is fixing this.
1647 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1649 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1650 * src/maemo/modest-account-settings-dialog.c:
1651 (create_page_outgoing),
1652 (modest_account_settings_dialog_set_account_name),
1653 (save_configuration):
1654 - Fixed handling of the "Use secure authentication" toggle to comply with
1655 the ui specification. See also projects.maemo.org bug NB#58400
1657 - Restore the Secure connection setting combo correctly when loading
1660 * src/maemo/modest-maemo-utils.c:
1661 (on_camel_account_get_supported_secure_authentication),
1662 (modest_maemo_utils_get_supported_secure_authentication_methods):
1663 Fixed a crasher if operation is canceled
1665 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1666 (modest_protocol_info_auth_is_secure):
1667 * src/modest-protocol-info.h:
1669 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1670 the sense of the "Use secure authentication" toggle.
1672 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-tny-account-store.h:
1675 * src/modest-tny-account-store.c:
1676 Added modest_tny_account_store_get_local_folders_account().
1678 * src/modest-tny-folder.h:
1679 * src/modest-tny-folder.c:
1680 (modest_tny_folder_get_account):
1681 Added this replacement for tny_folder_get_account() which returns
1682 the local-folders account for TnyMergeFolders, to avoid the
1683 warning about the unimplemented get_account_func() vfunc().
1685 (modest_tny_folder_get_rules),
1686 * src/modest-ui-actions.c:
1687 (modest_ui_actions_on_folder_selection_changed):
1688 * src/modest-mail-operation.c:
1689 (modest_mail_operation_remove_folder),
1690 (modest_mail_operation_xfer_folder),
1691 (modest_mail_operation_rename_folder),
1692 (modest_mail_operation_get_msg),
1693 (modest_mail_operation_get_msgs_full),
1694 (modest_mail_operation_remove_msg),
1695 (modest_mail_operation_xfer_msgs),
1696 (modest_mail_operation_refresh_folder):
1697 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1699 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1701 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1702 (modest_server_account_set_security):
1703 * src/modest-defs.h: Add comments explaining that our
1704 UI spec means TLS when it says Normal, so these do not look like errors.
1706 * src/modest-tny-account.c:
1707 (modest_tny_account_new_from_server_account): Use the new tinymail
1708 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1709 for TLS. This should fix projects.maemo.org bug NB#58460.
1711 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/easysetup/modest-easysetup-wizard.c:
1714 (create_account): Correct the position of the gconf sanity check warning.
1715 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1716 of using the g_idle_add() hack, because this does not seem to be necessary
1717 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1718 caused by something other than maemo's gconf.
1719 This fixes projects.maemo.org bug #59022.
1721 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1723 * src/modest-account-mgr-helpers.c:
1724 (modest_account_mgr_get_default_account): Do not check that the account
1725 exists if there is no default account (NULL), to fix a runtime warning.
1727 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1729 * src/widgets/modest-folder-view.c: (update_model):
1730 Do not unref the treemodel before we have finished with it.
1731 This prevents a valgrind warning and an occasional crash at startup.
1733 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1735 * libmodest-dbus-client/libmodest-dbus-client.h:
1736 added libmodest_dbus_client_compose_mail()
1737 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1739 added functions needed for SendAsMail() functionality
1740 * src/maemo/modest-msg-edit-window.c:
1741 (modest_msg_edit_window_attach_file_noninteractive):
1742 non interactively attaching files to message edit window
1743 * src/widgets/modest-msg-edit-window.h:
1744 * tests/dbus_api/Makefile.am:
1745 added test_compose_mail.c
1746 * tests/dbus_api/test_compose_mail.c: (main):
1748 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1750 * src/modest-account-view.c:
1751 Fixed bug projects.maemo.org bug NB#59307
1753 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1755 * src/maemo/easysetup/modest-easysetup-wizard.c:
1756 (get_serverport_incoming), (on_before_next), (create_account):
1757 * src/maemo/modest-account-settings-dialog.c:
1758 (modest_account_settings_dialog_set_account_name):
1759 * src/maemo/modest-maemo-utils.c:
1760 (on_camel_account_get_supported_secure_authentication_status),
1761 (on_camel_account_get_supported_secure_authentication),
1762 (on_secure_auth_cancel),
1763 (modest_maemo_utils_get_supported_secure_authentication_methods):
1765 Implemented security authentication for settings and easysetup.
1767 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1769 * src/maemo/modest-main-window.c: (create_details_widget):
1770 Show the total size for memory card accounts too, instead of showing
1771 the name again. Fixes bug projects.maemo.org bug NB#59307.
1773 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1776 * src/modest-tny-simple-folder-store.c:
1777 * src/modest-tny-simple-folder-store.h: Removed.
1779 * src/modest-tny-local-folders-account.h
1780 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1781 for the local-folders maildir, with an extra TnyMergedFolder containing
1782 the folders of the per-account outbox store accounts.
1783 * src/modest-tny-account-store.c: (get_server_accounts):
1784 Add the outboxes to the special local folders account after creating it.
1786 * src/modest-tny-account.c:
1787 (modest_tny_account_new_for_local_folders): Create the derived
1788 account when creating the main local-folders account.
1790 * src/maemo/modest-main-window.c: (create_details_widget),
1791 (modest_main_window_set_contents_style):
1792 Adapted to the use of the derived account instead of the folder store.
1794 * src/modest-ui-actions.c:
1795 (modest_ui_actions_on_folder_selection_changed):
1796 * src/modest-ui-dimming-rules.c:
1797 (modest_ui_dimming_rules_on_new_folder):
1798 * src/widgets/modest-folder-view.c: (text_cell_data),
1799 (icon_cell_data), (filter_row), (update_model),
1800 (get_cmp_rows_type_pos):
1803 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1804 Do not get the priv struct, because no priv struct has been set,
1805 to avoid a runtime warning.
1807 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1808 #ifelse with #else, to fix a warning, to fix the build.
1811 2007-06-05 Christian Kellner <ckellner@openismus.com>
1813 * libmodest-dbus-client/libmodest-dbus-client.c:
1814 Fix small typo in doc (why do you always see them
1815 AFTER committing stuff?)
1818 2007-06-05 Christian Kellner <ckellner@openismus.com>
1820 * libmodest-dbus-client/libmodest-dbus-client.c:
1821 (libmodest_dbus_client_search):
1822 Initialize hit list with NULL. Also set folder list
1823 to "" if NULL was supplied.
1826 2007-06-03 Christian Kellner <ckellner@openismus.com>
1828 * libmodest-dbus-client/libmodest-dbus-client.c:
1829 (modest_search_hit_list_free):
1830 Make it save to call it with NULL.
1832 * src/dbus_api/modest-dbus-callbacks.c:
1833 * src/modest-search.c:
1834 Return full ModestSearchHits as the search result list not TnyHeader
1835 since can't be around withouth the correspoding TnyFolder.
1837 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1839 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1840 Added currently commented code to check for secure auth
1842 * src/maemo/modest-account-settings-dialog.c: (on_response),
1843 (save_configuration), (show_ok):
1844 Fixed projects.maemo.org bugs NB #59248 and #59251
1846 * src/maemo/modest-maemo-utils.c:
1847 (on_camel_account_get_supported_secure_authentication_status),
1848 (on_camel_account_get_supported_secure_authentication),
1849 (modest_maemo_utils_get_supported_secure_authentication_methods):
1850 * src/maemo/modest-maemo-utils.h:
1851 Moved get_supported_secure_authentication() method here to be able
1852 to use it from easysetup wizard.
1854 * src/modest-pair.c: (on_pair_compare_as_string):
1855 Should compare string with first part of pair and not
1856 strcmp pairs which will crash.
1858 * src/modest-protocol-info.c:
1859 (modest_protocol_info_protocol_is_store):
1860 * src/modest-protocol-info.h:
1861 Added modest_protocol_info_get_auth_protocol_name()
1863 2007-06-03 Armin Burgmeier <armin@openismus.com>
1865 * src/modest-mail-operation.c:
1866 (modest_mail_operation_get_msgs_full): Set priv->account also when
1867 only retrieving a single message. This avoids a crash when canceling
1870 (modest_mail_operation_notify_end): Do not explicitely remove the
1871 operation from the queue but only emit the progress_changed signal.
1872 The queue itself listens to that signal to remove the operation when
1873 it is finished. This reduces coupling and removes a potential deadlock
1874 when modest_mail_operation_notify_end() is called from the queue
1875 itself. If that is a problem performance-wise, I would suggest to
1876 implement a status-changed signal or something.
1878 * src/modest-mail-operation-queue.c: Make sure to never call a
1879 function from another file while the queue is locked. This (hopefully)
1880 fixes another deadlock when exiting the application while retrieving
1883 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1885 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1886 Fixed build if libogs is not available
1888 2007-06-03 Christian Kellner <ckellner@openismus.com>
1890 * libmodest-dbus-client/libmodest-dbus-client.h:
1891 * libmodest-dbus-client/libmodest-dbus-client.c:
1892 (libmodest_dbus_client_delete_message):
1893 Implement deletion of messages (Client side).
1895 (modest_search_hit_free),
1896 (modest_search_hit_list_free):
1897 Utility functions to free the result hits.
1899 * src/dbus_api/modest-dbus-api.h:
1900 * src/dbus_api/modest-dbus-callbacks.c:
1901 (on_delete_message),
1902 (modest_dbus_req_handler):
1903 Implement deletion of messages (Server side).
1905 * tests/dbus_api/test_search.c: (main):
1908 * tests/dbus_api/Makefile.am:
1909 * tests/dbus_api/test_delete_message:
1910 Add little test for the message deletion logic
1912 2007-06-03 Armin Burgmeier <armin@openismus.com>
1914 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1915 when the operation queue was not empty. projects.maemo.org bug
1918 2007-06-03 Armin Burgmeier <armin@openismus.com>
1920 * src/widgets/modest-account-view.c
1921 (on_account_default_toggled): Toggle default account column
1922 explicitely instead of waiting for gconf notification (which is
1923 currently ignored). This should fix projects.maemo.org bug NB#56910
1924 for now. It should probably be removed when gconf notifications are
1927 2007-06-03 Christian Kellner <ckellner@openismus.com>
1929 * libmodest-dbus-client/libmodest-dbus-client.c:
1930 Removed debugging spew.
1932 * src/dbus_api/modest-dbus-callbacks.c:
1933 Added debugging info.
1935 * src/modest-search.c:
1936 (modest_search_all_accounts):
1937 Use tny_account_store_get_accounts () on the account store
1938 to get all accounts which is the way to get all accounts.
1940 * tests/dbus_api/test_search.c: (main):
1941 Make it possible to supply the search term on the command line.
1943 2007-06-03 Christian Kellner <ckellner@openismus.com>
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 * libmodest-dbus-client/libmodest-dbus-client.h:
1947 Implement searching for mesages over raw dbus. (Client side)
1949 * src/dbus_api/Makefile.am:
1950 * src/dbus_api/modest-dbus-api.h:
1951 * src/dbus_api/modest-dbus-callbacks.c:
1952 * src/dbus_api/modest-dbus-callbacks.h:
1953 Search framework (Server side). Also implement on_idle_open_message().
1955 * src/maemo/modest-platform.c: (modest_platform_init):
1956 Prepare for raw dbus/osso rpc interaction.
1958 * src/modest-search.h:
1959 Changed minsize from unspecific guint to guint32.
1961 * src/modest-search.c:
1963 Added strange hack which magically made tnymail work.
1965 (modest_search_folder),
1966 (modest_search_account),
1967 (modest_search_all_accounts):
1968 Implement helper functions to search all accounts, specific account
1971 * tests/dbus_api/Makefile.am:
1972 * tests/dbus_api/test_open_message.c:
1973 Read url to open from commandline.
1975 * tests/dbus_api/test_search.c:
1976 Implement small test for dbus search stuff
1978 2007-06-02 Armin Burgmeier <armin@openismus.com>
1980 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1981 include account type and account title. This fixes projects.maemo.org
1984 * src/maemo/modest-account-view-window.c: Set a title for the window.
1986 2007-06-02 Armin Burgmeier <armin@openismus.com>
1988 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1989 incoming and outgoing server name based on email address and server
1990 types as long as the names have not been edited manually. This fixes
1991 projects.maemo.org bug NB#58671.
1993 2007-06-02 Armin Burgmeier <armin@openismus.com>
1995 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1996 server type cannot be changed in future to the incoming details page
1997 when creating an account. This fixes projects.maemo.org bug NB#59029.
1999 2007-06-02 Armin Burgmeier <armin@openismus.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2002 and assigned max width chars so that they wrap instead of being
2003 truncated. Fixes projects.maemo.org bug NB#56126.
2005 2007-06-02 Armin Burgmeier <armin@openismus.com>
2007 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2008 introductory note to the connection specific smtp servers dialog, as
2009 section 8.12 of the email UI specification requires. This fixes
2010 projects.maemo.org bug NB#59212.
2012 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2015 Check for running mail operations, and offer to cancel them, as per the UI
2016 spec. This fixes projects.maemo.org bug NB#59041 .
2017 However, I suspect that tinymail may still use the network connection
2018 in ways that we cannot detect or cancel. But it should at least adapt to
2019 changes fairly well.
2021 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2023 * src/modest-tny-account-store.c: (recreate_all_accounts),
2024 (get_cached_accounts), (get_server_accounts): Do more sensible
2025 ref-counting of the temporarily-cached outbox accounts list. This seems
2026 to fix a crash when entering the password when the password was wrong.
2028 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2030 * src/gnome/modest-main-window.c: (connect_signals):
2031 * src/modest-tny-account-store.c: (get_password),
2032 (modest_tny_account_store_alert): Added comments and clues and
2033 commented-out code about how we currently fail to deal with connection
2034 errors and wrong passwords, and how we should.
2036 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2038 * src/widgets/modest-retrieve-combo-box.c:
2039 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2040 This fixes projects.maemo.org bug NB#58472 .
2042 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/easysetup/modest-easysetup-wizard.c:
2045 (create_page_complete_easysetup):
2046 (create_page_complete_custom): Correct the last commit,
2047 putting the correct sentences in the correct pages.
2049 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 (create_page_complete_custom): Show the second sentence of text
2053 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2056 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2058 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2059 Set the leave-on-server conf key by default. This fixes
2060 projects.maemo.org bug NB#59258 .
2062 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/modest-account-view-window.c:
2065 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2066 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/easysetup/modest-easysetup-wizard.c:
2072 (create_caption_new_with_asterisk):
2073 * src/maemo/modest-account-settings-dialog.c:
2074 (create_caption_new_with_asterisk):
2075 Uncomment the code to add the asterisk, because they are no longer in the
2076 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2077 (update_incoming_server_title): Add an asterisk here too.
2079 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/modest-maemo-global-settings-dialog.c:
2082 (current_connection): Check that we are even connected before trying to
2083 get the current connection name, to prevent a warning.
2085 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2086 Change the comments because tny_maemo_conic_device_connect() is now meant to
2088 * src/modest-mail-operation.c:
2089 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2090 make sure we have a connection and fail if we can't connect.
2092 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2094 * src/maemo/modest-main-window.c:
2095 (on_account_store_connecting_finished): Do not try to get the
2096 connection ID if we are not really connected. I am surprised that
2097 this signal handler is called when we are not connected.
2099 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2101 * src/modest-error.h:
2102 * src/modest-ui-actions.c:
2103 (modest_ui_actions_get_msgs_full_error_handler):
2104 Renamed an enum, added comments, added an enum
2105 for retrieve-limit errors.
2107 * src/modest-mail-operation.c: (foreach_add_item),
2108 (internal_folder_observer_update), (update_account_thread),
2109 (modest_mail_operation_get_msgs_full):
2110 (modest_mail_operation_update_account),
2111 Added comments about how this works, and some code that should
2112 (but does not) check the retrieve-limit. See the TODO comment.
2114 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2117 Initialize help_id to fix the build. Warnings are good.
2119 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2121 * src/widgets/modest-hbox-cell-renderer.c:
2122 (modest_hbox_cell_renderer_append):
2123 * src/widgets/modest-vbox-cell-renderer.c:
2124 (modest_vbox_cell_renderer_append):
2125 Fix the last commit by doing an extra ref.
2127 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2129 * src/widgets/modest-hbox-cell-renderer.c:
2130 (modest_hbox_cell_renderer_append):
2131 * src/widgets/modest-vbox-cell-renderer.c:
2132 (modest_vbox_cell_renderer_append):
2133 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2134 to fix the build with Maemo Bora.
2135 However, there seems to be a remaining crash, probably due to reference
2138 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-tny-account.c:
2141 (modest_tny_account_new_for_local_folders):
2142 Use hildon_file_system_info_async_new() to get a better name for
2143 the memory card account, setting it as the account name.
2144 The timing seems to work, but this is probably
2145 not the best place to do this. See the TODO comment.
2146 * src/maemo/modest-main-window.c: (create_details_widget):
2147 * src/widgets/modest-folder-view.c: (text_cell_data):
2148 Use the tny account name instead of hardcoding a name.
2150 2007-05-30 Christian Kellner <ckellner@openismus.com>
2152 * src/modest-search.c: (modest_search):
2153 Correctly set part_search_func even if we have already parsed
2154 the query and thus a valid OgsTextSearcher object.
2156 2007-05-30 Christian Kellner <ckellner@openismus.com>
2159 Search and check for libogs.
2162 Incooparte the ogs build env.
2164 * src/modest-mime-part-search-stream.c:
2165 * src/modest-mime-part-search-stream.h:
2166 Removed since we do the real searching now in modest-search.c.
2168 * src/modest-search.c:
2169 * src/modest-search.h:
2170 Implement support for ogs. We use that if available and requested
2171 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2172 should now handle the corner case when the search term is spread
2173 across multiple reads.
2174 Also the logic in modest_search () was corrected to search all
2175 requested fields until one is found.
2177 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2179 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2181 * src/modest-init.h:
2182 * src/modest-init.c: Made modest_init_local_folders() take a
2183 path and be public so we can iniitialize maildir folders on
2186 * src/modest-local-folder-info.h:
2187 * src/modest-local-folder-info.c:
2188 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2190 * src/modest-tny-account.c:
2191 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2192 still means the standard local-folders path on the local volume.
2194 * src/modest-tny-account-store.c:
2195 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2196 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2197 all accounts when that happens.
2198 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2199 this too, so it shows up in the treeview.
2201 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2203 * src/maemo/modest-maemo-global-settings-dialog.c:
2204 (current_connection):
2205 * src/widgets/modest-global-settings-dialog.c:
2206 (current_connection_default):
2207 Use the enum values instead of 0, 1 and -1,
2208 to make the code clearer.
2210 * src/modest-account-mgr-helpers.c:
2211 (modest_account_mgr_get_connection_specific_smtp): Make this code
2214 * src/modest-runtime.h:
2215 * src/modest-runtime.c:
2216 Added modest_runtime_remove_all_send_queues().
2217 * src/maemo/modest-main-window.c:
2218 (on_account_store_connecting_finished): Recreate the send queues,
2219 using the appropriate transport accounts for this new connection.
2220 Some futher adapting might be needed if the old send queues are not
2221 automatically stopped at this point.
2223 * src/modest-tny-account-store.c: (get_server_accounts):
2224 Create the connection-specific transport accounts, so that they can
2225 be found later by their ID.
2227 * src/modest-tny-account.h:
2228 * src/modest-tny-account.c:
2229 Added modest_tny_account_new_from_server_account_name().
2230 modest_tny_account_new_from_server_account(): Do not create the
2231 send queues here, because they will be
2232 recreated anyway when the connection changes for the first time.
2234 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-local-folder-info.h:
2237 * src/modest-local-folder-info.c:
2238 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2239 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2240 tbox_folder): Take a modest account name instead of a server TnyAccount,
2241 so we can have per-modest-account rather than per-transport-account
2243 We must make sure that we change or recreate the exisitng send queues
2244 when the connection changes for connection-specific transport accounts.
2246 * src/modest-tny-account-store.c:
2247 (create_per_account_local_outbox_folders): Create outboxed per modest
2248 account, not per transport account.
2250 * src/modest-tny-account.h:
2251 * src/modest-tny-account.c:
2252 (modest_tny_account_get_special_folder): For outboxes, get the
2253 parent modest account name. The account is ignored for other folders.
2254 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2255 modest account name rather than a server TnyAccount.
2257 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2259 * src/modest-tny-account.c:
2260 (modest_tny_account_new_from_server_account):
2261 Call modest_runtime_get_send_queue() immediately after creating transport
2262 accounts, so that they start trying to send email from the outbox as soon
2263 as possible at startup. This is probably what we want.
2265 * src/modest-mail-operation.c: (update_account_thread):
2266 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2267 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2268 * src/modest-tny-send-queue.h:
2269 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2270 (modest_ui_actions_on_send):
2271 Added comments about how sending works, though it needs some more work.
2273 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2275 * src/modest-tny-account.c:
2276 (modest_tny_account_get_special_folder): Add TODO because this fails when
2277 the network is busy.
2278 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2279 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2280 Do not try to show this window when there is no active account. The UI
2281 specs does not tell us what to do in this case.
2283 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/Makefile.am:
2288 * src/widgets/Makefile.am: Some dist fixes.
2290 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/modest-connection-specific-smtp-window.c:
2293 (on_button_edit): Make the code clearer, to prevent a double free.
2295 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2297 * src/maemo/modest-account-settings-dialog.c:
2298 (modest_account_settings_dialog_set_account_name),
2299 Check the connection-specific smtp servers checkbox if there are any.
2301 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2302 (modest_connection_specific_smtp_edit_window_init):
2303 Start with a suitable port number.
2305 * src/modest-account-mgr-helpers.h:
2306 * src/modest-account-mgr-helpers.c: Added
2307 modest_account_mgr_get_has_connection_specific_smtp().
2309 (modest_account_mgr_set_connection_specific_smtp),
2310 (modest_account_mgr_remove_connection_specific_smtp),
2311 (modest_account_mgr_get_has_connection_specific_smtp),
2312 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2313 connection-specific smtp server accounts in the account, rather than
2314 the server account conf dir.
2316 This fixes bug projects.maemo.org bug NB#58263 .
2318 * src/modest-tny-account-store.c:
2319 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2320 if there are no server accounts yet, to prevent an infinite loop when there
2321 are no accounts. Document that one must be called before the other.
2323 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2325 * src/modest-account-mgr-helpers.c:
2326 (modest_account_mgr_get_default_account): Make sure that at least
2327 one account is always the default, if there are any enabled accounts.
2328 This is just a sanity check that shouldn't be necessary.
2330 * src/modest-account-mgr-priv.c:
2331 (_modest_account_mgr_account_from_key): Unescape the conf key to
2332 get the real account name. For instance, this is an issue if a space
2333 was in the account name, which can happen because the account name
2334 is generated from the display name.
2335 (_modest_account_mgr_get_account_keyname): Always escape the
2337 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2338 Unescape the conf keys to get the real account names.
2340 For instance, previously the is-default radio button in the accounts
2341 list was not checked for any accounts at first. This fixes that,
2342 and might fix several similar bugs.
2344 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2346 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2347 Removed some debug printfs.
2349 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2351 Modest on-disk outbox directories are now here, for instance:
2352 $HOME/.modest/outboxes/<account-id-1>/outbox
2353 $HOME/.modest/outboxes/<account-id-2>/outbox
2355 $HOME/.modest/local-folders/outbox
2356 so we can have a separate outbox for each account.
2357 But they are shown as one outbox in the GtkTreeView, by using a
2358 TnyMergeFolder in a ModestTnySimpleFolderStore.
2361 * src/modest-tny-simple-folder-store.c:
2362 * src/modest-tny-simple-folder-store.h:
2363 Added ModestTnySimpleFolderStore, used to contain folders from
2364 other folder stores, such as other accounts.
2366 * src/modest-tny-outbox-account.h:
2367 * src/modest-tny-outbox-account.c:
2368 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2369 used for the per-account local outbox folders.
2371 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2372 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2373 only use this (internally) now for the non-outbox local folders.
2375 * src/modest-init.h:
2376 * src/modest-init.c: Added modest_init_one_local_folder(), for
2377 setting up the directory structure for each local folder.
2379 * src/modest-local-folder-info.c:
2380 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2381 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2383 * src/modest-local-folder-info.h:
2384 * src/modest-tny-account-store.c: (on_account_removed),
2385 (on_account_changed), (create_per_account_local_outbox_folders),
2386 (get_server_accounts), (modest_tny_account_store_get_accounts),
2387 (modest_tny_account_store_get_tny_account_by_account),
2388 (modest_tny_folder_store_is_virtual_local_folders):
2390 * src/modest-tny-account.h:
2391 * src/modest-tny-account.c:
2392 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2393 to create an on-disk per-account local outbox folder for each
2395 (create_per_account_local_outbox_folders): Create a local outbox folder
2396 for each transport account.
2397 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2398 for all local folders.
2400 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2401 instead of using g_object_get/set() directly. It is clearer.
2403 (modest_tny_folder_store_get_message_count),
2404 (modest_tny_folder_store_get_local_size
2405 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2406 because we now use these with non-acount folder stores.
2408 (modest_tny_account_get_special_folder),
2409 (modest_tny_account_new_from_server_account),
2410 (modest_tny_account_new_from_account):
2411 (recurse_folders): Adjust to the new outbox system.
2413 * src/modest-tny-folder.h:
2414 * src/modest-tny-folder.c:
2415 (modest_tny_folder_is_local_folder),
2416 (modest_tny_folder_get_local_folder_type),
2417 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2419 * src/widgets/modest-main-window.h:
2420 * src/maemo/modest-main-window.c: (create_details_widget),
2421 (modest_main_window_set_contents_style): Show details for any folder store,
2424 (modest_tny_folder_get_rules):
2425 Remove the const. C does not support constness enough for this.
2427 * src/modest-ui-actions.c:
2428 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2429 make all outboxes appear as one, in the usual local-folders tree node.
2431 (set_active_account_from_tny_account),
2432 (modest_ui_actions_on_folder_selection_changed):
2433 * src/widgets/modest-folder-view.c: (text_cell_data),
2434 (icon_cell_data), (filter_row),
2435 (add_account_folders_to_merged_folder),
2436 (add_account_folders_to_simple_folder_store), (),
2437 (get_cmp_rows_type_pos), (cmp_rows),
2438 (modest_folder_view_set_account_id_of_visible_server_account):
2439 Adjust to the new outbox system, using generic folder stores and folders
2440 in the GtkTreeModel.
2442 2007-05-23 Christian Kellner <ckellner@openismus.com>
2444 * src/modest-mail-operation.c:
2445 (modest_mail_operation_update_account):
2446 Use info->max_size instead of unintialized local var [small
2447 build fix]. (Added TODO to review that change since I don't
2450 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2452 * libmodest-dbus-client/libmodest-dbus-client.c:
2453 (libmodest_dbus_client_compose_mail): function added
2454 * src/dbus_api/modest-dbus-api.h:
2455 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2456 (on_compose_mail): Implementation of the SendAsMail functionality
2458 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2460 * src/modest-account-mgr.c:
2461 (modest_account_mgr_add_server_account): Set the secure-connection
2462 conf key for transport accounts as well as store accounts. I don't know
2463 why the if was there. For instance, this makes sure that we use SSL
2464 for the gmail preset from the easysetup wizard.
2466 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2468 * src/gnome/modest-main-window.c:
2469 (on_account_store_connecting_finished), (connect_signals):
2470 * src/maemo/modest-main-window.c:
2471 (on_account_store_connecting_finished), (connect_signals),
2472 (modest_main_window_new):
2473 Handle TnyAccountStore::connecting-finished instead of
2474 TnyDevice::connection-changed, because we cannot actually perform
2475 operations on accounts until TnyAccountStore has itself responded to
2476 the TnyDevice::connection-changed signal. This prevents a GError from
2478 Do not try to update at startup, because we (at least on scratchbox)
2479 already do an update at startup when the device goes online.
2480 This prevents a GError from tinymail.
2481 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2482 Added TODO about stopping simultaneous operations.
2484 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2486 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2487 * src/modest-mail-operation-queue.c:
2488 (modest_mail_operation_queue_remove):
2489 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2490 about where they happened.
2492 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2494 * src/modest-ui-actions.c:
2495 (modest_ui_actions_on_password_requested): Make sure that the remember
2496 output parameter is always TRUE.
2498 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2501 Show a OK/Cancel dialog if the error is a question, though we still do not
2502 know anything more about what we are asking the user.
2503 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2504 Fix an uninitialized variable (helper). This is a logic error, however.
2506 2007-05-21 Christian Kellner <ckellner@openismus.com>
2508 * src/modest-search.h:
2509 Correct bit shifting in the ModestSearchFlags enum.
2511 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2513 * src/modest-tny-account.c:
2514 (modest_tny_account_new_from_server_account): Do not use the lsub and
2515 check-all hard-coded IMAP options when using POP.
2517 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-tny-account.c:
2520 (modest_tny_account_new_from_server_account):
2521 Use NULL for the secure-auth method for POP when Password auth has been
2522 specified by the user, as we already do for IMAP. "auth=Login" causes
2523 an error from camel or the server.
2525 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2527 * src/maemo/modest-account-settings-dialog.c:
2528 (create_page_account_details),
2529 (modest_account_settings_dialog_set_account_name):
2530 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2531 for the leave-on-server checkbox, rathr than just the checkbox, when
2532 the protocol is not POP.
2534 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2536 * src/widgets/modest-account-view.c:
2537 * src/widgets/modest-account-view.h:
2538 Added modest_account_view_select_account() which will be useful later
2539 to asynchronously re-select the edited account.
2541 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/modest-account-settings-dialog.c:
2544 (modest_account_settings_dialog_set_account_name):
2545 Automatically choose the port numbers based on the secure authentication
2546 methods, if they have not been chosen before.
2547 This fixes projects.maemo.org bug NB#56273 .
2549 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/modest-main-window-ui.h:
2552 * src/modest-ui-actions.c:
2553 * src/modest-ui-actions.h:
2554 Connect the Tools/SMTP Servers menu item to
2555 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2556 SMTP servers dialog, as in the UI specification and saves changes when it
2557 is closed. This fixed projects.maemo.org bug NB#56305 .
2559 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2561 * src/maemo/modest-connection-specific-smtp-window.c:
2562 (modest_connection_specific_smtp_window_init):
2563 Use gtk_window_set_default_size() to make this window big enough, so
2564 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2566 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2568 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2570 (modest_connection_specific_smtp_edit_window_init),
2571 Do not try to connect to a combobox signal before the combobox exists.
2572 This fixes the cras in projects.maemo.org bug NB#56288 .
2573 (modest_connection_specific_smtp_edit_window_get_settings):
2574 Remove the server_account_name parameter which was being checked for NULL
2575 though it was not used.
2577 * src/maemo/modest-connection-specific-smtp-window.c:
2578 (modest_connection_specific_smtp_window_fill_with_connections),
2579 (on_button_edit), (modest_connection_specific_smtp_window_init):
2580 Correct the number of treemodel columns to prevent a warning.
2581 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2582 libconic does not work.
2584 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-tny-account.c:
2587 (modest_tny_account_new_from_server_account):
2588 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2589 SMTP when "None" was chosen by the user. However, with my SMTP server that
2590 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2593 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2596 to explain the memory management issue with the ID in the ModestPair.
2598 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2599 (add_sending_page), (modest_account_assistant_finalize):
2600 * src/gnome/modest-gnome-global-settings-dialog.c:
2601 (create_updating_page), (create_composing_page):
2602 * src/gnome/modest-msg-edit-window.c: (get_transports),
2603 (init_window), (modest_msg_edit_window_finalize),
2604 (modest_msg_edit_window_get_msg_data):
2605 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2606 * src/gnome/modest-transport-widget.c:
2607 (modest_transport_widget_finalize), (smtp_configuration):
2608 * src/maemo/modest-maemo-global-settings-dialog.c:
2609 (create_updating_page), (create_composing_page):
2610 * src/maemo/modest-msg-edit-window.c: (get_transports),
2611 (init_window), (modest_msg_edit_window_finalize),
2612 (modest_msg_edit_window_get_msg_data),
2613 (modest_msg_edit_window_free_msg_data):
2614 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2615 (modest_store_widget_finalize):
2616 * src/maemo/modest-transport-widget.c:
2617 (modest_transport_widget_finalize), (smtp_configuration):
2618 * src/modest-main.c: (send_mail):
2619 * src/widgets/modest-combo-box.h:
2620 * src/widgets/modest-global-settings-dialog-priv.h:
2621 * src/widgets/modest-global-settings-dialog.c:
2622 (modest_global_settings_dialog_finalize):
2623 * src/widgets/modest-msg-edit-window.h:
2624 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2625 as long as the combo box, to prevent use of freed memory for the ID.
2627 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2630 get_accounts(), to make this clearer. Do not check for the enabled gconf
2631 key, because we do not use this for server accounts (at least, not yet).
2632 This allows us to send email again.
2634 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2636 * src/maemo/modest-platform.c:
2637 (on_modest_conf_update_interval_changed), (modest_platform_init):
2638 Only respond to this particular key change. All these strcmp()s cannot be
2641 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-maemo-global-settings-dialog.c:
2644 (current_connection): Prevent a crash in scratchbox when
2645 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2646 * src/maemo/modest-platform.c:
2647 (on_modest_conf_update_interval_changed), (modest_platform_init):
2648 Get the update interval from gconf and reset it when the gconf key changes.
2650 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2652 * src/modest-protocol-info.c:
2653 * src/modest-protocol-info.h: Adde enum-specific get functions,
2654 instead of using a ModestProtocolType enum parameter.
2656 * src/gnome/modest-account-assistant.c:
2657 * src/gnome/modest-store-widget.c:
2658 * src/gnome/modest-store-widget.h:
2659 * src/gnome/modest-transport-widget.c:
2660 * src/gnome/modest-transport-widget.h:
2661 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2662 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2663 * src/maemo/easysetup/modest-easysetup-wizard.c:
2664 * src/maemo/modest-account-settings-dialog.c:
2665 * src/maemo/modest-account-settings-dialog.h:
2666 * src/maemo/modest-store-widget.c:
2667 * src/maemo/modest-store-widget.h:
2668 * src/maemo/modest-transport-widget.c:
2669 * src/maemo/modest-transport-widget.h:
2670 * src/modest-account-mgr-helpers.c:
2671 * src/modest-account-mgr-helpers.h:
2672 * src/modest-account-mgr.c:
2673 * src/modest-account-mgr.h:
2674 * src/modest-tny-account.c:
2675 * src/modest-tny-folder.c:
2676 * src/widgets/modest-account-view.c:
2677 * src/widgets/modest-retrieve-combo-box.c:
2678 * src/widgets/modest-retrieve-combo-box.h:
2679 * src/widgets/modest-secureauth-combo-box.c:
2680 * src/widgets/modest-serversecurity-combo-box.c:
2681 * src/widgets/modest-serversecurity-combo-box.h:
2682 * tests/check_account-mgr.c:
2683 Use the specific functions, and use the re-renamed enum values for GNOME too.
2685 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-pair.h:
2688 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2689 so we can get the second based on the first.
2691 * src/maemo/modest-account-settings-dialog.h:
2692 * src/maemo/modest-account-settings-dialog.c:
2693 Added get_supported_secure_authentication_methods(), though it is mostly
2694 commented-out for now until the necessary API is committed to tinymail.
2695 (modest_account_settings_dialog_set_account_name),
2696 (save_configuration): Request the supported authentication methods from the
2697 server, so we can choose a working method.
2699 * src/modest-tny-account-store.h:
2700 * src/modest-tny-account-store.c:
2701 (modest_tny_account_store_get_session): Rename from
2702 tny_account_store_get_session().
2704 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2706 * src/modest-protocol-info.h: Split the ModestProtocol enum
2707 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2708 There was no need to have these unrelated values in one enum.
2710 * src/: many files: Adapted to changed enum. This makes the code a bit
2711 clearer, and the compiler could catch some errors.
2713 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2715 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2716 Show the detailed internal camel error message when an error happens
2717 during the configuration, so that our testers can give us more clues.
2718 For instance, in projects.maemo.org bug NB#56910 .
2720 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-tny-account.c:
2723 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2724 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2726 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2728 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2729 * src/maemo/modest-account-settings-dialog.c:
2730 (modest_account_settings_dialog_set_account_name),
2731 (save_configuration): For the incoming secure authentication checkbox,
2732 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2733 the UI specification. PLAIN does not seem to be supported for most IMAP
2734 servers anyway, and I am not sure what it would mean.
2735 However, we probably need to discover which of the secure-authentication
2736 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2737 * src/modest-account-mgr-helpers.c:
2738 (modest_account_mgr_get_server_account_data):
2740 * src/modest-tny-account.c:
2741 (modest_tny_account_new_from_server_account):
2742 Use tny_account_set_mech() to set secure-authentication methods,
2743 with some special-casing for IMAP, based on my observations of how
2746 * src/modest-account-mgr-helpers.h:
2747 * src/modest-account-mgr.c:
2748 * src/modest-defs.h: Comment that the URI is only used for local folders.
2750 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2753 parameter const, just to be neat.
2754 * src/modest-text-utils.c: (modest_text_utils_inline):
2755 End g_strconcat() with NULL, as its documentation says. This is almost
2756 certainly the cause of my crash at startup on the device. Interestingly,
2757 valgrind doesn't tell us about these errors.
2759 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2761 * scripts/build-packages: Added more precise comments about how to use
2762 this script, though I still get this error:
2763 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2764 error building tinymail
2766 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/modest-main-window.c: (on_account_update):
2769 Very slight cleanup, hoping to make it simpler to discover what causes
2770 a crash here sometimes.
2772 * src/modest-tny-account.c:
2773 (modest_tny_account_new_from_server_account): Set the port. Added
2774 comments about the options and a TODO comment because I need to find out
2775 how to specify the secure authentication method.
2777 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2779 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2780 changed CFlags paths form modest to libmodest
2782 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2784 * src/modest-account-mgr-helpers.c:
2785 (modest_account_mgr_get_server_account_data),
2786 (modest_account_mgr_free_server_account_data):
2787 * src/modest-account-mgr-helpers.h:
2788 * src/modest-account-mgr.c:
2789 (modest_account_mgr_add_server_account):
2790 * src/modest-defs.h:
2791 * src/modest-tny-account.c:
2792 (modest_tny_account_new_from_server_account):
2793 Determine the options for tny_camel_account_add_option() here,
2794 based on the settings, rather than storing them directly in gconf.
2796 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2798 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2799 Show a more friendly error dialog now that we expect (from the tinymail
2800 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2802 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2804 * src/maemo/modest-main-window.c: (on_account_update): Check that
2805 account_name is not NULL, to prevent a crash at startup that I am
2806 seeing on the N800. I do wonder why it is NULL.
2808 * src/maemo/easysetup/modest-easysetup-wizard.c:
2809 (create_page_user_details):
2810 * src/maemo/modest-account-settings-dialog.c:
2811 (create_page_user_details), (create_page_outgoing):
2812 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2813 (modest_connection_specific_smtp_edit_window_init):
2814 * src/modest-ui-actions.c:
2815 (modest_ui_actions_on_password_requested):
2816 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2817 might do something useful with the on-screen keyboard.
2819 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2821 * src/maemo/modest-main-window.c: (on_account_update):
2822 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2823 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2825 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2827 * src/modest-tny-account-store.c: (on_account_changed):
2828 Correct the signature of this signal handler.
2830 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2832 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2833 Show a HildonNote instead of a GtkDialog for Maemo.
2835 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2837 * src/widgets/modest-account-view.h:
2838 * src/widgets/modest-account-view.c: (on_account_changed),
2839 (on_account_removed). Added a boolean flag, set/unset by
2840 modest_account_view_block_conf_updates(),
2841 modest_account_view_unblock_conf_updates() to prevent unnecessary
2842 updates, but this is not very useful because the gconf notifications are
2843 so delays (maybe only on Maemo Bora).
2844 So auto-updating is turned off, and these functions do an explicit
2845 update when necessary.
2846 However, something else is still doing too much work when adding/removing
2847 accounts, probably in another part of the application.
2849 * src/maemo/modest-account-view-window.c:
2850 (on_delete_button_clicked), (on_edit_button_clicked),
2851 (on_new_button_clicked): Use the new functions.
2853 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2855 * src/modest-account-mgr-helpers.c:
2856 (modest_account_mgr_set_first_account_as_default):
2857 Sort the list of names alphabetically-by-title, so we choose the first one
2859 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2860 alphabetically by the title.
2862 This fixes projects.maemo.org bug NB#56418 .
2864 * src/modest-account-mgr-priv.c:
2865 (_modest_account_mgr_account_from_key):
2866 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2867 avoid a valgrind error, and possible random behaviour.
2869 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2872 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2873 tinymail documentation to say that this can be expected.
2874 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2875 pretty, and should not happen, but I would prefer to know when it does.
2877 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2879 * configure.ac: When using the older hildon version, probably on Bora,
2880 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2882 * src/widgets/modest-attachment-view.c:
2883 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2886 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2888 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2889 Implemented the prototype. Can be tested with
2890 tests/dbus_api/test_open_message:
2892 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2894 * src/modest-tny-account-store.c:
2895 (modest_tny_account_store_instance_init), (get_password):
2896 * src/modest-ui-actions.c:
2897 (modest_ui_actions_on_password_requested):
2898 Do not store the password in gconf, because this function is called
2899 for non-remembered passwords. Actually use the cached (in the hash map)
2900 password instead of releasing it.
2901 The password will now not be remembered if it is asked via the protected
2902 password dialog, as per the UI spec.
2904 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2906 * src/modest-defs.h:
2907 * src/modest-account-mgr-helpers.h:
2908 * src/modest-account-mgr-helpers.c:
2909 Added modest_server_account_get_username_has_succeeded(),
2910 modest_server_account_set_username_has_succeeded().
2911 (modest_server_account_set_username),
2912 Reset the has-succeeded flag if the username changes.
2914 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2915 * src/maemo/modest-connection-specific-smtp-window.c:
2916 (modest_connection_specific_smtp_window_save_server_accounts):
2917 Use modest_server_account_set_username() instead of using
2918 modest_conf_set_string() directly, so that the has-succeeded flag is always
2921 * src/modest-ui-actions.c:
2922 (modest_ui_actions_on_password_requested): Dim the username entry if
2923 the username has ever worked, as per the UI spec.
2925 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2927 * src/modest-tny-account-store.c: (get_password):
2928 * src/modest-ui-actions.c:
2929 (modest_ui_actions_on_password_requested):
2930 Allow the username to be changed too, though there is more work to
2931 be done on exactly how this behaves.
2933 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2935 * src/modest-account-mgr-helpers.h:
2936 * src/modest-account-mgr-helpers.c:
2937 Added modest_account_mgr_get_display_name(),
2938 modest_server_account_get_username(),
2939 modest_server_account_set_username(),
2940 modest_server_account_set_password(),
2941 modest_server_account_get_hostname() functions so we do not need to
2942 use the conf API directly.
2944 * src/maemo/modest-main-window.c: (connect_signals):
2945 Actually connect ot the ModestAccountStore::request-password signal,
2946 so that we show the dialog when the password is requested by Tinymail,
2947 for isntance if it is empty.
2949 * src/modest-marshal.list:
2950 * src/modest-tny-account-store.c:
2951 (modest_tny_account_store_class_init), (get_password),
2952 (modest_tny_account_store_alert):
2953 * src/modest-tny-account-store.h:
2954 * src/modest-ui-actions.h:
2955 * src/modest-ui-actions.c:
2956 (modest_ui_actions_on_password_requested):
2957 Change the signal parameters, so it is obvious that we are providing
2958 the non human-readable server name, and receiving both the username
2959 and password, though changing of the username is not yet implemented.
2960 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2961 for the GNOME version.
2963 This should fix the projects.maemo.org bug NB#56209, though it does not
2964 work on Bora, because the gconf_client_get() for the password fails
2965 immediately after we save it with gconf_client_set().
2967 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2970 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2971 caused an undefined symbol error:
2972 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2974 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2976 * src/modest-tny-account-store.c:
2977 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2978 using a GError instead of a string message, so we can translate it in
2981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/modest-address-book.c:
2984 (modest_address_book_check_names):
2985 * src/maemo/modest-msg-view-window.c:
2986 (modest_msg_view_window_clipboard_owner_change):
2987 * src/modest-init.c: (modest_init_init_ui):
2988 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2989 (update_folders_cb), (modest_mail_operation_update_account):
2990 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2991 (modest_ui_actions_on_msg_attachment_clicked),
2992 (modest_ui_actions_on_msg_recpt_activated):
2993 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2994 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2995 (modest_msg_view_search_next):
2996 * src/widgets/modest-recpt-editor.c:
2997 (modest_recpt_editor_on_button_release_event),
2998 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2999 g_message(). At this point we should only be seeing interesting errors on
3000 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3002 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3004 (modest_wizard_dialog_force_title_update):
3005 * src/maemo/easysetup/modest-wizard-dialog.h:
3006 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3007 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3008 can update the title when appropriate. Otherwise the title is wrong if the
3009 pages are added after adding the notebook to the dialog.
3010 This must be a problem in HildonWizardDialog too.
3011 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3013 * src/maemo/easysetup/modest-easysetup-wizard.c:
3014 (create_subsequent_customsetup_pages),
3015 (create_subsequent_easysetup_pages):
3016 Call modest_wizard_dialog_force_title_update() so that the title is
3017 correct even with GTK+ < 2.10.
3018 This fixes projects.maemo.org bug NB#56145 .
3020 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3022 * src/maemo/modest-platform.c:
3023 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3024 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3027 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3029 * src/widgets/modest-window.h:
3030 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3031 and modest_window_save_state(), which invokes it.
3033 * src/widgets/modest-window-mgr.h:
3034 * src/widgets/modest-window-mgr.c:
3035 Added modest_window_mgr_save_state_for_all_windows(), which calls
3036 the save_state vfunc on all registered windows, if implemented.
3038 * src/gnome/modest-msg-edit-window.c:
3039 * src/gnome/modest-msg-view-window.c:
3040 * src/maemo/modest-msg-edit-window.c:
3041 * src/maemo/modest-msg-view-window.c:
3042 * src/maemo/modest-main-window.c:
3043 Specify the existing save_settings functions as implementations of
3044 ModestWindow::save_state_func().
3046 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3047 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3048 enabling hibernation, for instance.
3050 We may need to do the same thing for restoring settings.
3053 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3055 * src/widgets/modest-window-mgr.c:
3056 * src/widgets/modest-window-mgr.h:
3057 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3058 modest_window_mgr_get_hibernation_is_prevented().
3060 * src/maemo/modest-main-window.c:
3061 (on_hildon_program_is_topmost_notify): Prevent hibernation
3062 (possible when the application goes to the background in the WM),
3063 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3065 * src/maemo/easysetup/modest-easysetup-wizard.c:
3066 (modest_easysetup_wizard_dialog_init):
3067 * src/maemo/modest-account-settings-dialog.c:
3068 (modest_account_settings_dialog_init):
3069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3070 (modest_connection_specific_smtp_edit_window_init):
3071 * src/maemo/modest-connection-specific-smtp-window.c:
3072 (modest_connection_specific_smtp_window_init):
3073 * src/maemo/modest-signature-editor-dialog.c:
3074 (modest_signature_editor_dialog_init):
3075 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3076 prevent hibernation while any of these account settings dialogs are open.
3078 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/Makefile.am:
3081 * src/maemo/modest-osso-state-saving.c:
3082 * src/maemo/modest-osso-state-saving.h: Added
3083 modest_osso_load_state() and modest_osso_save_state() though they do
3084 nothing now. They should iterate through all the open windows and load/save
3086 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3087 save state when closing.
3089 * src/maemo/modest-main-window.c:
3090 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3091 Add a notification handler for the HildonProgram::is-topmost property,
3092 so we can allow hibernation when the application goes into the background.
3093 But we still need to detect when the accounts setup windows are open so
3094 we can stop hibernation when they are open.
3095 To do this, I also added the main window the HildonProgram. This might have
3096 other side-effects/benefits, and should maybe be done for other windows.
3098 * src/maemo/modest-osso-autosave-callbacks.h:
3099 * src/maemo/modest-osso-autosave-callbacks.c:
3100 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3101 though it does not do anything yet, and we might never need this to do
3102 anything. For instance, we already save drafts.
3104 * src/maemo/modest-platform.c: (modest_platform_init):
3105 Specify the libosso auto-save callback.
3107 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/modest-platform.c:
3110 (modest_platform_set_update_interval):
3111 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3112 aparently stays valid between application instances, so we can use this
3113 to remove and reset it later. According to a maemo-developers email from
3116 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3118 * configure.ac: Depend on libalarm for Maemo.
3120 * src/dbus_api/modest-dbus-api.h:
3121 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3122 (on_send_receive), (modest_dbus_req_handler):
3123 Handle a SEND_RECEIVE D-Bus method.
3125 * libmodest-dbus-client/libmodest-dbus-client.c:
3126 (libmodest_dbus_client_send_and_receive):
3127 * libmodest-dbus-client/libmodest-dbus-client.h:
3128 Add C convenience functions for calling the new D-Bus method.
3130 * src/modest-platform.h:
3131 * src/gnome/modest-platform.c:
3132 * src/maemo/modest-platform.c:
3133 Added modest_platform_set_update_interval(), which uses the
3134 alarmd API on Maemo.
3135 (modest_platform_init),
3136 Call modest_platform_set_update_interval(), using a hard-coded
3137 interval for now (until the global settings dialog is implemented),
3138 though I am not sure that this makes sense yet.
3140 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3142 * src/dbus_api/modest-dbus-callbacks.c:
3143 (modest_osso_cb_hw_state_handler):
3144 * src/dbus_api/modest-dbus-callbacks.h:
3145 * src/maemo/modest-platform.c: (modest_platform_init):
3146 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3147 in case this has some effect on the ability for Maemo to ping the
3150 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3152 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3153 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3154 warning. It is probably a logic error, but I need to fix the build.
3156 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3158 * src/modest-account-mgr.h:
3159 * src/modest-account-mgr.c:
3160 (modest_account_mgr_account_names): Add a gboolean enabled_only
3161 parameter, so we can get lists of onlt the enabled accounts.
3163 (modest_account_mgr_add_account),,
3164 (modest_account_mgr_account_with_display_name_exists):
3165 * src/maemo/modest-msg-edit-window.c: (get_transports):
3166 * src/modest-account-mgr-helpers.c:
3167 (modest_account_mgr_set_first_account_as_default):
3168 * src/modest-init.c: (init_default_account_maybe):
3169 * src/modest-tny-account-store.c: (get_accounts):
3170 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3171 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3172 * tests/check_account-mgr.c: (START_TEST):
3173 Provide the extra parameter, as appropriate.
3175 * src/widgets/modest-account-view.c: (update_account_view):
3176 Do not show disabled accounts (meaning that there is no way to
3177 enable/disable accounts in the UI (the feature is not in our UI
3178 specification), so we can use this internally only to mark unfinished
3179 or temporary account data.
3181 * src/maemo/easysetup/modest-easysetup-wizard.c:
3182 (create_account): Add boolean enable parameter, so we can specify FALSE
3183 to create the temporary account.
3184 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3185 (on_before_next): When finishing, when there is a temporary account, just
3187 Also, use a timeout to delay the showing of the dialog until gconf is likely
3188 to return correct information, due to a maemo gconf bug that is fixed in
3189 osso 1.1, but not yet in Bora.
3190 However, the dialog stays on screen after it is destroyed.
3192 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3193 for invalid data when cancelling. Use a hildon note instead of a dialog
3194 to complain about invalid data. Do not show the account-saved note if the
3195 account is disabled (a temporary account that will not really be saved for use
3198 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3200 * src/modest-account-mgr-helpers.h:
3201 * src/modest-account-mgr-helpers.c:
3202 Added modest_account_mgr_unset_default_account(),
3203 Added modest_account_mgr_set_first_account_as_default().
3205 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3206 If it was the default account, unset the default account name.
3208 * src/maemo/modest-account-view-window.c:
3209 (on_delete_button_clicked): If it was the default account,
3210 set the first remaining account as the default instead.
3212 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3213 a NULL account or a NULL default account, to prevent a crash. This should
3214 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3217 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3219 * src/widgets/modest-recpt-editor.c:
3220 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3221 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3222 TODO comment for this. This fixes the build.
3224 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3225 be the best place for it. This will in future update all auto-update accounts,
3226 rather than just the current/default account, when that gconf key exists.
3227 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3228 if there are no accounts, before calling do_send_receive().
3229 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3231 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3232 * src/maemo/modest-main-window-ui.h:
3233 * src/maemo/modest-main-window.c: (on_connection_changed),
3234 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3235 directly, becaue the signal handler does more.
3237 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3239 * src/modest-account-mgr-helpers.c:
3240 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3241 for the case that the account does not exist.
3243 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3244 (equivalent to the modest account name) rather than the tinymail account name
3245 (equivalent to the modest account title - human readable) to get the account data.
3246 Check for null account data to prevent the crash, and add a TODO comment saying that
3247 this needs fixing because it is using the server account name instead of the account name.
3249 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3252 * src/maemo/modest-account-settings-dialog.c: (show_error),
3254 Use hildon_note_new_information() for informative and error messages,
3255 which seems to be expected for Maemo applications (no documentation that I know of
3256 says this). I am surprised that there is no distinction between info and error
3259 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3261 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3262 it is easy to find where this is used.
3264 * src/maemo/easysetup/modest-easysetup-wizard.c:
3265 (create_page_welcome), (create_page_account_details),
3266 (create_page_user_details), (create_page_complete_easysetup),
3267 (create_page_custom_incoming), (create_page_custom_outgoing),
3268 (create_page_complete_custom):
3269 * src/maemo/modest-account-settings-dialog.c:
3270 (create_page_account_details), (create_page_user_details),
3271 (create_page_incoming), (create_page_outgoing):
3272 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3273 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3274 (modest_connection_specific_smtp_edit_window_init):
3275 * src/maemo/modest-connection-specific-smtp-window.c:
3276 (modest_connection_specific_smtp_window_init):
3277 * src/maemo/modest-signature-editor-dialog.c:
3278 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3279 and scrolling policy as per the Email Application Layout Guide, if I have
3282 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3284 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3285 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3286 which were empty, because these vfuncs have been removed from TnyAccountStore.
3287 This fixes the build.
3289 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/modest-main-window.c:
3292 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3293 showing/hiding it. Added TODO because it probably should not be NULL.
3294 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3295 because unnecessary g_warnings() make degugging difficult.
3297 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3299 * src/maemo/modest-msg-edit-window.c:
3300 (modest_msg_edit_window_select_color),
3301 (modest_msg_edit_window_select_background_color): 2 const corrections and
3302 moving 2 #endifs before closing brackets, to fix the build.
3304 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3306 * src/maemo/easysetup/modest-easysetup-wizard.h:
3307 * src/maemo/easysetup/modest-easysetup-wizard.c:
3308 (modest_easysetup_wizard_dialog_finalize),
3309 (on_button_edit_advanced_settings), (create_page_complete_custom),
3310 (on_response), (create_account):
3311 Implement the Advanced Settings edit button, by saving the account information,
3312 for the Advanded Settings dialog to use directly from gconf, and removing it
3313 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3314 Bug #5533 in the projects.maemo.org bugzilla.
3316 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3318 * src/maemo/modest-msg-view-window.c:
3319 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3320 when opening a message window.
3322 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/easysetup/modest-easysetup-wizard.c:
3325 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3328 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3329 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3330 gconf settings. I probably added more checks than necessary, but that is safer.
3332 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3333 variable to fix the build, but this seems to be used when it is still NULL.
3335 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3337 * src/modest-platform.h:
3338 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3339 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3340 * src/modest-main.c: Implement this function so we can avoid using
3341 maemo-specific API from cross-platform code.
3343 * src/modest-tny-account-store.c:
3344 (get_smtp_specific_transport_account_for_open_connection):
3345 * src/modest-ui-actions.c: (check_for_connection),
3346 (modest_ui_actions_on_item_not_found):
3347 Use modest_platform_connect_and_wait() and put #idefs around other
3348 maemo-specific code, because only maemo currently has a way to
3349 identify connection names.
3351 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3353 * src/modest-tny-account-store.h:
3354 * src/modest-tny-account-store.c:
3355 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3356 the connection-specific SMTP server settings in the configuration.
3358 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3360 * src/maemo/modest-main-window.c: (on_connection_changed),
3362 * src/modest-main.c: (main), (start_ui), (send_mail):
3363 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3364 that is what is intended.
3366 * src/modest-ui-actions.c: (action_send), (action_receive),
3367 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3368 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3369 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3370 SMTP server is used when it is specified.
3372 (modest_ui_actions_on_send_receive):
3373 Check that a connection is open before proceeding.
3374 Receive and then send, instead of vice-versa, as per the specification.
3376 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3378 * src/modest-mail-operation.c:
3379 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3380 though I guess it should be something other than NULL.
3382 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3384 * src/maemo/easysetup/modest-easysetup-wizard.c:
3385 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3386 combo twice, to avoid an g_warning and to make it visible again.
3387 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3388 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3389 (already intended) dereference when detaching, because we then recreate the menu.
3390 But I am not sure why the warning was happening, and it is possible that this is a memory
3393 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3395 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3396 and uri_parse_mailto() utility functions.
3397 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3399 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3401 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3403 * src/dbus_api/modest-dbus-api.h:
3404 * src/dbus_api/modest-dbus-callbacks.c:
3405 Use an idle callback to execute the modest code in the application's own thread.
3406 Remove the helloworld example method.
3407 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3408 parsed, and the open-message method is not implemented because this is not yet implemented in
3410 * libmodest-dbus-client/libmodest-dbus-client.c:
3411 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3412 (libmodest_dbus_client_open_message):
3413 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3415 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3416 body without crashing.
3418 * tests/dbus_api/Makefile.am:
3419 * tests/dbus_api/test_mail_to.c:
3420 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3422 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3424 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3425 Added file to fix the build. Sorry.
3427 * src/dbus_api/Makefile.am:
3428 * src/dbus_api/modest-dbus-api.h:
3429 * src/dbus_api/modest-dbus-callbacks.h:
3430 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3431 (modest_dbus_req_handler):
3432 Put constants in a separate header so it can be reused by the
3433 client library, without duplication
3435 * libmodest-dbus-client/Makefile.am:
3436 * libmodest-dbus-client/libmodest-dbus-client.c:
3437 (libmodest_dbus_client_call_helloworld),
3438 (libmodfest_dbus_client_send_mail),
3439 (libmodfest_dbus_client_mailto),
3440 (libmodfest_dbus_client_open_message):
3441 * libmodest-dbus-client/libmodest-dbus-client.h:
3442 (Partly) Implement a send_mail D-Bus method.
3444 * tests/dbus_api/Makefile.am:
3445 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3446 the send_email D-Bus method.
3448 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3452 * libmodest-dbus-client/Makefile.am:
3453 * libmodest-dbus-client/libmodest-dbus-client.c:
3454 * libmodest-dbus-client/libmodest-dbus-client.h:
3455 * tests/dbus_api/Makefile.am:
3456 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3457 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3459 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3461 * src/maemo/easysetup/modest-easysetup-wizard.c:
3462 (create_page_account_details):
3463 * src/maemo/modest-account-settings-dialog.c:
3464 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3465 widgets, because this might not be the default in future versions of the Maemo GTK+.
3466 However, I can not not get capitalization to work even in a simple test case.
3468 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 (create_page_custom_incoming), (create_page_custom_outgoing):
3472 * src/maemo/modest-account-settings-dialog.c:
3473 (create_page_account_details), (create_page_incoming),
3474 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3475 instead of using gtk_check_button_with_label(), so they are aligned like the other
3476 widgets, as per the UI spec.
3478 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3482 * src/widgets/modest-validating-entry.c:
3483 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3484 Modest prefix instead of an EasySetup prefix.
3486 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3488 * src/widgets/modest-validating-entry.h:
3489 * src/widgets/modest-validating-entry.c: (on_insert_text),
3490 Added easysetup_validating_entry_set_max_func(), used to set a callback
3491 to call when the max number of characters is reached. GtkEntry has a max-length
3492 already but is silent about it.
3494 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3495 (create_page_account_details), (create_page_user_details),
3497 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3498 (create_page_account_details), (create_page_user_details),
3499 (create_page_outgoing):
3500 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3501 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3502 the UI spec, when the user tries to enter more than the max number of characters.
3504 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3506 * src/maemo/easysetup/modest-easysetup-wizard.c:
3507 (create_page_user_details), (create_page_custom_incoming),
3508 (create_page_custom_outgoing):
3509 * src/maemo/modest-account-settings-dialog.c:
3510 (create_page_user_details), (create_page_incoming),
3511 (create_page_outgoing):
3512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3513 (modest_connection_specific_smtp_edit_window_init):
3514 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3515 not appropriate. Bad Maemo-specific defaults!.
3517 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3519 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3520 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3521 (modest_signature_editor_dialog_set_settings):
3522 Disable the label and textview when the checkbox is disabled, and use the
3523 specified (UI spec) default signature text.
3525 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3528 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3530 * src/modest-defs.h:
3531 * src/modest-account-mgr-helpers.h:
3532 * src/modest-account-mgr-helpers.c:
3533 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3535 * src/maemo/Makefile.am:
3536 * src/maemo/modest-signature-editor-dialog.c:
3537 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3540 * src/maemo/modest-account-settings-dialog.h:
3541 * src/maemo/modest-account-settings-dialog.c:
3542 (modest_account_settings_dialog_finalize), (on_button_signature),
3543 (save_configuration): Use the new dialog when the Edit button is pressed, and
3544 save the changes if necessary, as per the UI spec.
3546 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/Makefile.am:
3549 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3550 based on maemo-develoers email from Dirk.
3552 * src/maemo/easysetup/modest-easysetup-wizard.c:
3553 (create_page_welcome), (create_page_account_details),
3554 (create_page_user_details), (create_page_complete_easysetup),
3555 (create_page_custom_incoming), (create_page_custom_outgoing),
3556 (create_page_complete_custom),
3557 (modest_easysetup_wizard_dialog_init):
3558 * src/maemo/modest-account-settings-dialog.c:
3559 (create_page_account_details), (create_page_user_details),
3560 (create_page_incoming), (create_page_outgoing),
3561 (modest_account_settings_dialog_init):
3562 * src/maemo/modest-connection-specific-smtp-window.c:
3563 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3565 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3567 * src/maemo/easysetup/modest-easysetup-wizard.c:
3568 (create_page_account_details), (create_page_custom_outgoing),
3569 (create_page_complete_custom):
3570 * src/maemo/modest-account-settings-dialog.c:
3571 (create_page_user_details), (create_page_incoming),
3572 (create_page_outgoing):
3573 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3574 (modest_connection_specific_smtp_edit_window_init):
3575 Use the correct (UI spec) port min/max, and use horizontal separators,
3578 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3580 * src/maemo/easysetup/modest-easysetup-wizard.c:
3581 (set_default_custom_servernames):
3582 * src/maemo/modest-account-settings-dialog.c:
3583 (create_page_incoming), (on_combo_outgoing_security_changed),
3584 (on_combo_incoming_security_changed), (create_page_outgoing),
3585 (modest_account_settings_dialog_set_account_name),
3586 (save_configuration):
3587 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3588 (on_combo_security_changed),
3589 (modest_connection_specific_smtp_edit_window_init),
3590 (modest_connection_specific_smtp_edit_window_set_connection),
3591 (modest_connection_specific_smtp_edit_window_get_settings):
3592 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3595 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3598 * src/maemo/easysetup/modest-easysetup-wizard.c:
3599 (create_page_custom_outgoing), (create_page_complete_custom):
3600 * src/maemo/modest-account-settings-dialog.c:
3601 (create_page_user_details), (create_page_outgoing):
3602 * src/maemo/modest-account-view-window.c: (button_box_new):
3603 Use changed logical IDs as per the most recent UI spec:
3604 mcen_bd_emailsetup_edit -> mcen_bd_edit
3605 mcen_bd_emailsetup_delete -> mcen_bd_delete
3606 mcen_bd_emailsetup_close -> mcen_bd_close
3608 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3612 * src/dbus_api/Makefile.am:
3613 * src/dbus_api/modest-dbus-callbacks.c:
3614 * src/dbus_api/modest-dbus-callbacks.h:
3615 * src/maemo/modest-platform.c: (modest_platform_init):
3616 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3618 * tests/Makefile.am:
3619 * tests/dbus_api/Makefile.am:
3620 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3622 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3624 * src/maemo/modest-account-settings-dialog.c:
3625 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3626 Removed unnecessary includes.
3628 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3630 * src/maemo/easysetup/modest-easysetup-wizard.c:
3631 * src/maemo/modest-account-settings-dialog.c:
3632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3633 * src/widgets/Makefile.am:
3634 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3635 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3636 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3637 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3638 * src/widgets/modest-secureauth-combo-box.c:
3639 * src/widgets/modest-secureauth-combo-box.h:
3640 * src/widgets/modest-serversecurity-combo-box.c:
3641 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3642 made the GObject names more consistent with the rest of the Modest code.
3644 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3646 * src/maemo/easysetup/Makefile.am:
3647 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3648 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3649 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3650 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3651 * src/maemo/easysetup/modest-easysetup-wizard.c:
3652 * src/maemo/easysetup/modest-validating-entry.c:
3653 * src/maemo/easysetup/modest-validating-entry.h:
3654 * src/maemo/modest-account-settings-dialog.c:
3655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3656 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3657 widgets/ because they are used outside of easysetup too. After checking in,
3658 svn will allow me to rename them too.
3660 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3662 * src/gnome/modest-msg-edit-window.c:
3663 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3664 linker error, to fix the build on the GNOME platform.
3665 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3666 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3667 ifdefed out to avoid a warning.
3669 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3671 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3672 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3673 some alternative for GTK+ 2.6.
3675 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3677 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3679 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3680 specified for EmailAccountsDialog in UI spec.
3682 * src/maemo/easysetup/modest-easysetup-wizard.c:
3683 * src/maemo/easysetup/modest-easysetup-wizard.h:
3684 * src/maemo/modest-account-settings-dialog.c:
3685 * src/maemo/modest-account-settings-dialog.h:
3686 Reuse a member window widget for the connection-specific SMTP server accounts,
3687 so we can tell it to create/save the accounts only if we actually save changes.
3689 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3690 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3691 (modest_connection_specific_smtp_edit_window_get_settings):
3692 Return a struct instance for temporarily remembering the entered data.
3694 * src/maemo/modest-connection-specific-smtp-window.h:
3695 * src/maemo/modest-connection-specific-smtp-window.c:
3696 (modest_connection_specific_smtp_window_finalize),
3697 (modest_connection_specific_smtp_window_fill_with_connections),
3699 (modest_connection_specific_smtp_window_save_server_accounts),
3700 (update_model_server_names): Do not actually save data until asked,
3701 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3703 (on_selection_changed),
3704 (modest_connection_specific_smtp_window_init): Disable the edit
3705 button when nothing is selected.
3707 * src/modest-account-mgr-helpers.c:
3708 * src/modest-account-mgr-helpers.h:
3709 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3712 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3714 * src/modest-account-mgr-helpers.h:
3715 * src/modest-account-mgr-helpers.c:
3716 (modest_account_mgr_get_unused_account_name),
3717 (modest_account_mgr_get_unused_account_display_name): Added these
3718 utility functions, to avoid code duplication.
3720 * src/maemo/easysetup/modest-easysetup-wizard.c:
3721 (create_page_account_details), (create_account):
3722 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3723 (on_combo_security_changed),
3724 (modest_connection_specific_smtp_edit_window_init),
3725 (modest_connection_specific_smtp_edit_window_save_settings):
3726 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3727 * src/maemo/modest-connection-specific-smtp-window.c:
3728 (modest_connection_specific_smtp_window_finalize),
3729 (modest_connection_specific_smtp_window_fill_with_connections),
3730 (on_button_edit), (modest_connection_specific_smtp_window_init):
3731 * src/maemo/modest-connection-specific-smtp-window.h:
3732 Implementing saving of connection-specific server accounts.
3734 But I need to refactor this so we can save the data for each
3735 possible connection-specific account and only actually create the server accounts
3736 when the easysetup finished, or the OK button is pressed on the account settings
3739 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3742 (on_combo_security_changed):
3743 (modest_connection_specific_smtp_edit_window_init):
3744 Auto-fill the port number as in the account settings.
3746 (modest_connection_specific_smtp_edit_window_set_connection):
3747 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3748 * src/maemo/modest-connection-specific-smtp-window.c:
3749 (fill_with_connections), (on_button_edit),
3750 (modest_connection_specific_smtp_window_init):
3751 Turn the edit window into a dialog to simplify the code, and
3752 set a WM hint as in a GtkDialog, because only a popup can be on top of
3753 another window in Maemo, and popups usually have no WM decoration.
3755 * src/modest-defs.h:
3756 * src/modest-account-mgr-helpers.c:
3757 (modest_account_mgr_set_connection_specific_smtp),
3758 (modest_account_mgr_remove_connection_specific_smtp),
3759 (modest_account_mgr_get_connection_specific_smtp):
3760 * src/modest-account-mgr-helpers.h: Some functions to write the
3761 connection-specific SMTP server information. Not yet used.
3764 * src/widgets/modest-folder-view.c: (text_cell_data):
3765 Fix a warning about an uninitialized variable.
3766 (on_configuration_key_changed): Put an #ifdef around the use
3767 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3769 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/modest-account-settings-dialog.h:
3772 * src/maemo/modest-account-settings-dialog.c:
3773 Added connect_for_modified() utility function to mark the new modified boolean.
3775 (create_page_account_details), (create_page_user_details),
3776 (create_page_incoming), (create_page_outgoing), (on_response),
3777 (modest_account_settings_dialog_init),
3778 (modest_account_settings_dialog_set_account_name):
3779 Only warn about unsaved changes when there are actually unsaved changes.
3781 * src/modest-account-mgr-helpers.c:
3782 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3783 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3784 to get the data from there in future.
3786 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3788 * src/modest-defs.h:
3790 * src/modest-account-mgr-helpers.h:
3791 * src/modest-account-mgr-helpers.c:
3792 Store the security account setting in a single conf key instead of using
3793 the options list, so that the list is left for just the to-be-removed camel hack,
3794 and because gconf_client_set_list() is failing for some reason.
3796 * src/modest-account-mgr.c:
3797 (modest_account_mgr_add_server_account):
3798 * src/maemo/modest-account-settings-dialog.c:
3799 (modest_account_settings_dialog_set_account_name),
3800 (save_configuration): Use the renamed functions.
3803 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3805 * src/widgets/Makefile.am:
3806 * src/widgets/modest-limit-retrieve-combo-box.c:
3807 * src/widgets/modest-limit-retrieve-combo-box.h:
3808 * src/widgets/modest-retrieve-combo-box.c:
3809 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3810 the account settings dialog.
3812 * src/modest-defs.h:
3813 * src/modest-account-mgr-helpers.h:
3814 * src/modest-account-mgr-helpers.c:
3815 (modest_server_account_get_option_secure_auth),
3816 (modest_server_account_set_option_secure_auth):
3817 * src/modest-account-mgr.c:
3818 (modest_account_mgr_add_server_account):
3819 Use the existing AUTH_MECH conf key for the secure-auth setting,
3820 instead of putting it in the list options, because this was actually used already.
3822 * src/maemo/modest-account-settings-dialog.c:
3823 (create_page_account_details),
3824 (modest_account_settings_dialog_set_account_name),
3825 (save_configuration):
3826 * src/maemo/modest-account-settings-dialog.h:
3827 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3828 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3830 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3832 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3833 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3834 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3836 * src/modest-defs.h:
3837 * src/maemo/modest-account-settings-dialog.c:
3838 (create_page_incoming), (on_combo_outgoing_security_changed),
3839 (on_combo_incoming_security_changed), (create_page_outgoing),
3840 (modest_account_settings_dialog_set_account_name),
3841 (save_configuration): Load/Save the port number, and change it when the
3842 security combo changes, to suitable defaults.
3844 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3846 * src/modest-account-mgr.c:
3847 (modest_account_mgr_add_server_account): Set the security and secure-auth
3848 options, and add a comment saying that the other camel-specific options should be
3851 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3853 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3855 * src/modest-tny-account-store.c: (account_list_free),
3856 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3857 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3860 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3862 * src/modest-protocol-info.c:
3863 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3864 is required by our UI spec. Maybe something in our implementation will use this eventually.
3865 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3866 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3867 instead of the previous 0 placeholder.
3869 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3870 secure-auth settings.
3871 * src/modest-account-mgr-helpers.h:
3872 * src/modest-account-mgr-helpers.c:
3873 (modest_server_account_data_get_option_secure_auth),
3874 (modest_server_account_set_option_secure_auth),
3875 (modest_server_account_data_get_option_security),
3876 (modest_server_account_set_option_security): Added this API for getting and setting the security
3877 and secure-auth settings.
3879 * src/maemo/modest-account-settings-dialog.h:
3880 * src/maemo/modest-account-settings-dialog.c:
3881 (modest_account_settings_dialog_finalize), (check_data),
3882 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3883 about changing titles.
3884 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3885 (save_configuration): Save the security and secure-auth settings.
3887 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3888 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3890 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3892 * src/modest-defs.h:
3893 * src/modest-account-mgr.c:
3894 (modest_account_mgr_add_server_account):
3895 Added and used defines for the options key and value pair strings,
3896 that are used so far, though they do not seem to correspond to anything in our
3897 UI specs or ModestProtocol enum.
3899 * src/modest-account-mgr-helpers.h:
3900 * src/modest-account-mgr-helpers.c:
3901 (compare_option_strings_for_name),
3902 (modest_server_account_data_get_option_value),
3903 (modest_server_account_data_get_option_bool),
3904 (modest_account_mgr_get_server_account_option):
3905 Added helper functions for parsing the options GSList.
3907 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3909 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3910 display name is based on the supplied account name.
3911 * src/modest-account-mgr.c:
3912 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3913 with an inefficient, but good-enough, implementation.
3915 * src/maemo/easysetup/modest-easysetup-wizard.c:
3916 (create_page_account_details), (on_before_next), (create_account):
3917 Check for existing display names rather than (non-user-visible) account names, and just
3918 create and set a unique account name at the end.
3920 * src/maemo/modest-account-settings-dialog.c:
3921 (modest_account_settings_dialog_init),
3922 (modest_account_settings_dialog_set_account_name),
3923 (create_page_incoming): Show the display name, instead of the account name.
3924 (on_response): Do some (not all) extra checks, as in the UI spec.
3925 (save_configuration): Save the display name if it was changed.
3927 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3929 * po/en_GB.po: Added needed logical ID and translation.
3930 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3931 (init_view): Made the is-default column clicking work.
3933 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/easysetup/Makefile.am:
3937 * src/maemo/easysetup/modest-easysetup-wizard.c:
3938 (modest_easysetup_wizard_dialog_init):
3939 * src/maemo/easysetup/provider-data-test.keyfile:
3940 * src/maemo/easysetup/provider-data.keyfile:
3941 Moved the provider data file to the new modest-providers-data package and used it from there.
3943 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3945 * src/modest-local-folder-info.c:
3946 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3947 N_() was already used on the static strings, but this just marks it for translation without
3948 using the translation.
3950 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3952 * src/maemo/modest-account-settings-dialog.c:
3953 (create_page_incoming),
3954 (modest_account_settings_dialog_set_account_name):
3955 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3956 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3957 I will do this if nobody else gets there first.
3959 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3961 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3962 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3963 save the security stuff.
3965 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3967 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3968 Set the email address and user fullname, which I now see must be
3971 * src/maemo/modest-account-settings-dialog.h:
3972 * src/maemo/modest-account-settings-dialog.c:
3974 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3975 leave-on-server and authentication.
3976 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3979 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3982 * src/maemo/modest-account-settings-dialog.c:
3983 * src/maemo/modest-account-settings-dialog.h:
3984 Most (but not all) of the widgets are now present as specified by the UI spec.
3985 No changes are yet saved, and some details are not properly shown yet.
3987 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3989 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3991 * src/maemo/Makefile.am:
3992 * src/maemo/modest-account-settings-dialog.c:
3993 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3994 an existing account. Doesn't do much yet.
3996 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3997 Open the accounts settings dialog when Edit is clicked.
3999 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4001 * src/maemo/easysetup/Makefile.am:
4002 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4004 * src/maemo/easysetup/modest-easysetup-wizard.c:
4005 (modest_easysetup_wizard_dialog_init):
4006 Try to get the source directory from the build system,
4007 instead of hard-coding "./" into the source code, when opening our local
4008 copies of the configuration files.
4009 But this still fails when opening the wizard from the Accounts window,
4010 maybe because the working directory seems to change at runtime.
4011 So the wizard will fail the second time unless you copy the files into their
4012 proper locations - see the stdout warnings for the paths.
4014 (create_page_account_details),(on_before_next):
4015 Check for existing non-server accounts instead of server accounts,
4016 so the default account name is useful again, and to prevent trying to
4019 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4020 Show the wizard when New is clicked.
4022 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4023 (init_view): Show the column headers, and show the columns that are
4024 specified in the UI specs. However, something in Maemo's GTK+ prevents
4025 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4026 change the default account. This is despite unsetting the special properties.
4028 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4030 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4031 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4032 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4033 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4034 to make that clearer.
4035 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4037 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4039 * src/maemo/modest-account-view-window.c:
4040 (modest_account_view_window_init),
4041 (modest_account_view_window_new):
4042 Use the same buttons as specified in the
4043 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4044 the existing widgets, which never had a chance of working.
4045 Put the ModestAccountView treeview in a scrolled window.
4046 Do not repeat the initialization in both _init() and _new().
4048 * src/widgets/modest-account-view.c: (update_account_view):
4049 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4050 this widget and window shows no accounts.
4052 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4054 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4056 * src/maemo/easysetup/modest-easysetup-wizard.c:
4057 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4058 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4059 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4062 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4063 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4064 accounts exist yet, as in the UI spec.
4066 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4068 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4070 * src/maemo/Makefile.am:
4071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4072 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4073 New window for editing connection-specific smtp details.
4074 Not fully implemented.
4076 * src/maemo/modest-connection-specific-smtp-window.c:
4077 (modest_connection_specific_smtp_window_finalize) :
4078 unref the tree model.
4079 (on_button_edit): Show the edit window.
4081 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4083 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4086 * src/maemo/Makefile.am:
4087 * src/maemo/modest-connection-specific-smtp-window.c:
4088 * src/maemo/modest-connection-specific-smtp-window.h:
4089 New window for showing the list of connections, for connection-specific
4090 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4091 * src/maemo/easysetup/modest-easysetup-wizard.c:
4092 (create_page_custom_outgoing): Show the new window when the button is clicked.
4094 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4096 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4097 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4098 * src/maemo/modest-msg-edit-window.c:
4099 (modest_msg_edit_window_insert_image):
4100 * src/modest-conf.c: (modest_conf_key_escape):
4101 * src/modest-mail-operation.c:
4102 (modest_mail_operation_send_new_mail):
4103 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4104 (modest_ui_actions_on_new_account):
4105 * src/widgets/modest-attachment-view.c: (update_filename_request):
4106 * src/widgets/modest-mail-header-view.c:
4107 Corrected warnings that were breaking the build, by commenting out unused variables,
4108 and a function, and by including a header.
4110 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4112 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4113 so we can #ifdef around platform-specific code when necessary.
4114 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4115 to allow this to build for the GNOME platform too.
4117 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4119 * src/maemo/easysetup/modest-easysetup-wizard.c:
4120 Added util_increment_name() and used it in create_page_account_details()
4121 to make sure that the default account name is always a new name.
4123 (modest_easysetup_wizard_dialog_init),
4124 (set_default_custom_servernames): Some minor memory management fixes.
4126 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4130 * src/modest-runtime.c: (init_i18n): Restored the translation
4131 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4132 are defined in config.h, and the translations are installed.
4134 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4135 is defined for translation.
4137 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4139 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4141 * src/maemo/easysetup/modest-easysetup-wizard.c:
4142 (modest_easysetup_wizard_dialog_init):
4143 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4144 Use realistic paths (though they should use $prefix generically) to the
4145 mcc_mapping and provider-data.keyfile files which might work when they
4146 are installed by the future version of the operator-wizard package,
4147 and then fallback to paths in our source code, with an explanatory
4150 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4154 * src/maemo/Makefile.am:
4155 * src/maemo/easysetup/: Added files from the previously-exernal
4156 osso-modest-easysetup.
4157 * src/maemo/modest-main-window-ui.h:
4158 * src/modest-ui-actions.c:
4159 * src/modest-ui-actions.h:
4160 Added modest_ui_actions_on_new_account() as a signal handler for the
4161 New Account menu item. It shows the easysetup wizard.
4162 * po/en_GB.po: Added additional needed logical IDs and translations.