1 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
5 Show account wizard if no accounts are defined while sending
6 (automatic sending after the account wizard finished does not
7 work because it takes some time until the account manager
8 synchronizes everything. (projects.maemo.org NB#62792)
10 2007-07-30 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-tny-account-store.c: (on_account_removed),
13 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
14 account is removed from the View menu. We have TnyAccountStore
15 and ModestTnyAccountStore signals that seem very similar, but this
16 seems to work for now.
18 * src/maemo/modest-main-window.c:
19 (on_show_account_action_activated): Prevent dereference
20 of a NULL if the accoutn does not really exist, though that
21 should not happen anymore.
23 This fixes projects.maemo.org bug NB#64606.
25 2007-07-30 Murray Cumming <murrayc@murrayc.com>
27 * src/modest-ui-actions.c: (run_account_setup_wizard),
28 (modest_ui_actions_on_accounts): Revert a change that set these
29 to modal dialogs, freezing the UI when they show secondary dialogs.
30 This fixed projects.maemo.org bug NB#64519.
32 2007-07-27 Murray Cumming <murrayc@murrayc.com>
34 * src/widgets/modest-header-view-render.c:
35 (_modest_header_view_compact_header_cell_data):
36 Some checks and initialization to try to deal with a crash,
39 2007-07-27 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/modest-maemo-utils.c:
42 (modest_maemo_utils_get_supported_secure_authentication_methods):
43 Make sure that we have a connection, asking the user for one
45 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
46 Check for a connection before showing the wizard, because
47 the wizard needs a connection to check for server capabilities.
49 2007-07-27 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-account-view-window.c:
52 (on_new_button_clicked): Remember the wizard dialog instance,
53 so we can just present it again if necessary. This prevents
54 multiple windows from appearing if you click again quickly on the
55 New button before the dialog appears, fixing projects.maemo.org
58 2007-07-27 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
61 Offer a connection dialog if there is no connection when
62 starting modest. This should fix projects.maemo.org bug NB#61134.
64 2007-07-27 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
67 Reverted my last commit. I was able to fix the build by doing
68 apt-get install wpeditor0 (replacing other wpeditor packages) and
69 an explicit apt-get install wpeditor-dev to upgrade the -dev
72 2007-07-27 Murray Cumming <murrayc@murrayc.com>
74 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
75 Commented out the use of wp_text_buffer_replace_image()
76 because it does not exist, to break the build. Added a TODO for it.
78 2007-07-26 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-tny-account-store.c: (recreate_all_accounts):
81 Recreate them even if they were NULL before. I guess something
82 else was already creating them before, or this would never
84 (modest_tny_account_store_get_server_account): Make sure that
85 the tny accounts have been created before trying to find one.
86 This allows libmodest_dbus_client_compose_mail() to work
87 when the UI is not yet visible.
88 This is probably useful in other cases too.
90 (get_password): When the password is wrong after it is entered
91 in the protected password dialog, show an info banner (in an
92 idle handler) before showing the protected password dialog
95 2007-07-26 Murray Cumming <murrayc@murrayc.com>
97 * src/modest-ui-actions.h:
98 * src/modest-ui-actions.c: Added
99 modest_do_refresh_current_folder() containing some code from
100 modest_ui_actions_on_send_receive().
101 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
102 Call modest_do_refresh_current_folder() before refreshing the
103 requested account, as in modest_ui_actions_on_send_receive().
104 This is strange, but seems to be necessary to show new mails.
105 Now new emails are finally visible in the UI when downloaded
106 via the automatic update interval, fixing bug NB#57458.
107 This also works because bug NB#57458 has been fixed somehow.
109 2007-07-26 Murray Cumming <murrayc@murrayc.com>
111 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
112 printf more details when we get unhandled D-Bus methods, because
115 * src/modest-mail-operation.c: (update_account_thread):
116 Comment out the tny_camel_pop_store_account_reconnect(), because this
117 is apparently no longer needed, and it did not work before anyway.
118 See the comment in the code.
120 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
121 by checking the header flags. This fixes projects.maemo.org bug
124 2007-07-25 Murray Cumming <murrayc@murrayc.com>
126 * src/maemo/modest-maemo-utils.h:
127 * src/maemo/modest-maemo-utils.c: Added
128 modest_maemo_show_information_note_in_main_context_and_forget().
129 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
130 Use the new function to show simple error dialogs in the main
131 context, though question dialogs are still in the current context,
132 which is unfortunately usually not the main context. This should
135 2007-07-25 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-tny-account-store.c: (get_password):
138 Never save the entered username and password in gconf,
139 because the UI spec says we should not. This helps
140 slightly with projects.maemo.org bug NB#63671.
142 2007-07-25 Murray Cumming <murrayc@murrayc.com>
144 * src/widgets/modest-msg-edit-window.h:
145 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
146 Moved some code here to make it simpler.
147 (modest_msg_edit_window_attach_file_one): Renamed from
148 modest_msg_edit_window_attach_file_interactive().
149 (modest_msg_edit_window_offer_attach_file): Renamed from
150 modest_msg_edit_window_attach_file() and used
151 modest_msg_edit_window_attach_file_one() instead of
152 copy/pasting the code. The old code for one was not using
153 GnomeVFS. This allows use of smb:// URLs when using send-as
154 from external applications, fixing bug NB#63741.
156 (modest_msg_edit_window_insert_image),
157 (modest_msg_edit_window_add_attachment_clicked):
158 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
159 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
160 Adapted to the new function names.
162 2007-07-25 Murray Cumming <murrayc@murrayc.com>
164 (modest_platform_set_update_interval): Set the alarm recurrence
165 fields so that auto-update does not just happen the first time.
166 This should have fixed projects.maemo.org bug NB#63938.
168 When this happens you can see a printf when the D-Bus method is
170 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
172 However, I do not actually seem to get new POP messages even when
173 clicking the refresh button manually. A restart gets them.
174 This might be a problem in today's tinymail only.
176 2007-07-24 Murray Cumming <murrayc@murrayc.com>
178 * src/maemo/modest-maemo-global-settings-dialog.c:
179 (current_connection):
180 Avoid a crash (probably only in scratchbox) when strcmp()ing a
181 NULL when closing the dialog.
183 2007-07-24 Murray Cumming <murrayc@murrayc.com>
185 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
186 Remove the hacky send/receive that didn't work, and instead
187 refilter the treemodel to make the deleted email really vanish from
188 the UI (though the delete-from-menu code does has commented out
189 the code that does that). This fixes projects.maemo.org bug
192 2007-07-24 Murray Cumming <murrayc@murrayc.com>
194 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
195 Try a couple of tricks to force the treeview to update (
196 poke the folder, and do a send/receive refresh), but the deleted
197 email still appears with a strike-through instead of really being
200 2007-07-23 Murray Cumming <murrayc@murrayc.com>
202 * src/dbus_api/modest-dbus-callbacks.c:
203 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
204 because their ID is not human-readable (see the comment about
205 improvements needed to the osso-email-interface API) and
206 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
208 2007-07-23 Murray Cumming <murrayc@murrayc.com>
210 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
211 (add_folders_to_list), (on_dbus_method_get_folders),
212 (modest_dbus_req_filter):
213 * src/maemo/modest-maemo-utils.c:
214 (on_camel_account_get_supported_secure_authentication):
215 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
216 (on_header_view_focus_in):
217 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
218 * src/modest-formatter.c: (modest_formatter_create_body_part):
219 * src/modest-mail-operation.c: (recurse_folders),
220 (update_account_thread), (get_msgs_full_thread),
221 (modest_mail_operation_get_msgs_full),
222 (modest_mail_operation_xfer_msgs):
223 * src/modest-search.c: (search_mime_part_and_child_parts),
224 (modest_search_account), (modest_search_all_accounts):
225 * src/modest-tny-account.c:
226 (modest_tny_account_get_special_folder), (recurse_folders):
227 * src/modest-tny-local-folders-account.c:
228 (modest_tny_local_folders_account_query_passes):
229 * src/modest-tny-msg.c: (copy_mime_part),
230 (modest_tny_msg_find_body_part_from_mime_part):
231 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
232 (modest_tny_send_queue_try_to_send):
233 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
234 (_modest_ui_actions_open), (download_uncached_messages),
235 (reply_forward), (modest_ui_actions_on_copy),
236 (modest_ui_actions_on_details), (has_retrieved_msgs),
237 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
239 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
240 (_selected_msg_marked_as), (_msg_download_completed),
241 (_selected_msg_sent_in_progress):
242 * src/widgets/modest-attachments-view.c:
243 (modest_attachments_view_set_message):
244 * src/widgets/modest-msg-view.c: (find_cid_image):
245 * tests/check_folder-transfer.c: (find_folders):
246 * tests/check_update-account.c: (func):
247 * tests/dbus_api/test_get_folders.c: (main):
248 Checked all uses of tny_iterator_get_current(), making sure
249 that the object is unreferenced (3 or 4 places did not),
250 and adding checks for NULL.
252 2007-07-23 Murray Cumming <murrayc@murrayc.com>
254 * src/dbus_api/modest-dbus-callbacks.c:
255 (on_idle_open_default_inbox): Make sure that the application UI is
257 * src/maemo/easysetup/modest-easysetup-wizard.c:
258 (on_entry_invalid_character): Show the word whitespace instead
259 of (null) in the banner when whitespace was entered.
260 (show_error): Add a comment that this does not work in
261 Maemo Bora, though we do not know why.
263 2007-07-23 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-tny-account.c:
266 (modest_tny_account_get_special_folder): Use an if instead of
267 an assert for when the parent account name is NULL, because this
268 might be causing a crash in projects.maemo.org bug 63192.
269 * src/modest-mail-operation.c:
270 (modest_mail_operation_send_new_mail_cb),
271 (modest_mail_operation_remove_folder): unref the folder that is
272 returned from modest_tny_account_get_special_folder().
274 2007-07-23 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-ui-actions.c:
277 (modest_ui_actions_on_password_requested):
278 Show mail_ib_login_cancelled info banner when the user cancels
279 the protected password dialog, to fix projects.maemo.org
282 2007-07-23 Murray Cumming <murrayc@murrayc.com>
284 * src/maemo/modest-account-settings-dialog.c:
285 (create_page_outgoing): Put this page in a GtkScrolledWindow,
286 matching the UI mock-up in the UI spec, and allowing access
287 to all widgets even when the on-screen keyboard is active.
289 2007-07-23 Murray Cumming <murrayc@murrayc.com>
291 Reverted this previous commit from Johannes,
292 because the scrollbars are always visible and because
293 I think we only need it on onepage of the account
294 settings, not the account wizard.
295 (I wrote the wrong instructions in the bug.)
297 * src/maemo/easysetup/modest-easysetup-wizard.c:
298 Added scrollbars to account wizard dialog.
299 Fixed projects.maemo.org NB #62744
301 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
303 * src/maemo/easysetup/modest-easysetup-wizard.c:
304 (create_page_user_details):
305 Use auto-cap for name (projects.maemo.org NB#63716)
306 * src/widgets/modest-account-view.c: (on_account_busy_changed):
308 2007-07-22 Armin Burgmeier <armin@openismus.com>
310 * src/maemo/modest-ui-actions.c: Use current account instead of
311 default account for creating viewer windows, so that the viewer
312 window knows to which account the viewed message belongs.
314 * src/maemo/modest-msg-view-window.c: Destroy the window when the
315 corresponding account is deleted. This fixes projects.maemo.org bug
318 2007-07-18 Armin Burgmeier <armin@openismus.com>
320 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
321 the dialog close after entering an invalid port number and clicking
322 OK. This fixes projects.maemo.org bug NB#63602.
324 2007-07-18 Armin Burgmeier <armin@openismus.com>
326 * src/modest-tny-account-store.c:
327 (get_server_accounts): Set parent modest account name for each
328 connection-specific transport account so that special folders of such
329 an account can be looked up. This fixes a crash when changing account
330 settings. This might also be related to projects.maemo.org bug
333 2007-07-16 Armin Burgmeier <armin@openismus.com>
335 * src/modest-ui-actions.c: Added a button to create a folder to the
336 move-to dialog. This fixes projects.maemo.org bug NB#.
338 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
340 * src/maemo/easysetup/modest-easysetup-wizard.c:
341 Added scrollbars to account wizard dialog.
342 Fixed projects.maemo.org NB #62744
344 2007-07-16 Murray Cumming <murrayc@murrayc.com>
346 * src/widgets/modest-msg-view.h:
347 * src/widgets/modest-msg-view.c:
348 Added modest_msg_view_get_message_is_empty() but this needs
350 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
351 Check if there is any text in the message yet.
352 But this needs to be implemented properly.
353 (modest_msg_edit_window_toggle_find_toolbar):
354 * src/maemo/modest-msg-view-window.c:
355 (modest_msg_view_window_toggle_find_toolbar):
356 Show a banner warning if there is no text to search, when
357 trying to start a search. This partially fixes
358 projects.maemo.org bug NB#62350.
360 2007-07-13 Murray Cumming <murrayc@murrayc.com>
362 * src/modest-mail-operation.c: (update_account_thread):
363 Initialized num_new_headers to fix the build.
365 2007-07-13 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
368 Ignore modest accounts whose server accounts don't exist in gconf.
369 This prevents us trying to create TnyAccount instances for those
370 server accounts when the server account has been removed from gconf,
371 but the parent modest account has not yet been removed from modest.
372 I don't know why this is only noticeable now. It was probably just
373 a harmeless g_warning() anyway.
375 2007-07-13 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
378 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
380 2007-07-12 Armin Burgmeier <armin@openismus.com>
382 * src/maemo/modest-main-window.c: Make default account appear bold
383 in view, tools/send & receive and toolbar/send & receive SCM menus.
384 This fixes projects.maemo.org bug NB#59010.
386 2007-07-12 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
389 Add a short-cut, by checking if the folder store is an account.
390 This ensures that the Sort menu item and toolbar is dimmed for
391 the local-folders account root item, fixing
392 projects.maemo.org bug NB#62545.
394 2007-07-12 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-tny-account-store.c: (get_password):
397 Show the password dialog (via the signal) only in the mainloop, via
398 an idle handler that we wait for. This could theoretically prevent
399 hangs, though I worry that it could introduce some too.
401 2007-07-12 Murray Cumming <murrayc@murrayc.com>
403 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
404 * src/maemo/modest-platform.c:
405 (modest_platform_connect_and_wait):
406 Take a TnyAccount* parameter and try to set it to online
407 (a TnyCamel-only API), because tinymail sets accounts to offline
408 when the user cancels a password dialog, and doesn't ask again until
409 it has been set to online.
410 However, this is commented out because it causes a hang now.
412 (modest_platform_connect_and_wait_if_network_account):
413 * src/modest-mail-operation.c:
414 (modest_mail_operation_update_account):
415 * src/modest-platform.h:
416 * src/modest-ui-actions.c: (_modest_ui_actions_open),
417 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
419 2007-07-12 Armin Burgmeier <armin@openismus.com>
421 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
423 * src/modest-mail-operation.c:
424 * src/modest-ui-actions.c: Check for already existing folder before
425 querying the server, show error message from camel if the request
426 still fails. This fixes projects.maemo.org bug NB#58701.
428 2007-07-12 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-tny-account-store.h:
431 * src/modest-tny-account-store.c:
432 Added modest_tny_account_store_forget_password_in_memory(),
433 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
434 when creating a new account, so that new passwords will be used, instead of
435 us thinking that it's a second request as a result of a failed password again.
437 2007-07-12 Murray Cumming <murrayc@murrayc.com>
439 * src/dbus_api/modest-dbus-callbacks.c:
440 (on_idle_open_message): If the message is in drafts then open it
441 in an edit window instead of a view window. This fixes
442 projects.maemo.org bug NB#63005.
444 2007-07-12 Murray Cumming <murrayc@murrayc.com>
446 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
447 Avoided a harmless g_warning().
449 2007-07-12 Murray Cumming <murrayc@murrayc.com>
451 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
452 Pass the modest account name, not the TnyAccount display name to
453 modest_msg_view_window_new() so that the reply feature works,
454 fixing projects.maemo.org bug NB#62892.
456 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
457 (modest_msg_view_window_new_with_header_model):
458 * src/maemo/modest-msg-view-window.c:
459 (modest_msg_view_window_new_with_header_model),
460 (modest_msg_view_window_new):
461 * src/modest-ui-actions.c: (reply_forward):
462 * src/widgets/modest-msg-view-window.h:
463 * src/widgets/modest-window.c: (modest_window_set_active_account):
464 Rename an account parameter to modest_account_name to make this clearer.
466 2007-07-11 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-ui-actions.h:
469 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
470 modest_do_message_delete().
471 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
472 Call modest_do_message_delete(), hoping that this would cause messages
473 to be really deleted from search instead of just marked with strike through.
474 Does not seem to help.
476 2007-07-11 Armin Burgmeier <armin@openismus.com>
478 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
479 priv->reselect to FALSE prior to calling
480 modest_folder_view_select_first_inbox_or_local() to prevent endless
481 recursion and thus a crash on startup.
483 2007-07-11 Armin Burgmeier <armin@openismus.com>
485 * src/maemo/modest-account-settings-dialog.h: Include
486 <gtk/gtknotebook.h> to fix the build (at least for me).
488 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
489 Use "New FolderN" as default suggested name if "New folder" already
490 exists, with N being the first free number, though never exceed "New
491 folder99" in which case we just fall back to "New Folder" even though
492 it already exists. This fixes projects.maemo.org bug NB#58663.
494 2007-07-11 Murray Cumming <murrayc@murrayc.com>
496 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
497 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
498 projects.maemo.org bug NB#62778.
500 2007-07-11 Murray Cumming <murrayc@murrayc.com>
502 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
503 Ignore the wrong (for now) secure-smtp setting in the presets -
504 just default to requiring secure authentication for SMTP, because
507 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
509 * src/widgets/modest-folder-view.c: (filter_row)
510 Do not show drafts folder (see UI specs)
512 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
514 * src/modest-ui-actions.c:
515 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
516 place and also not necessary.
518 * src/widgets/modest-folder-view.c: (filter_row)
519 Guess folder type and hide Sent & Outbox if necessary.
520 Fixed project.maemo.org NB#57328
522 2007-07-11 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-ui-actions.h:
525 * src/modest-ui-actions.c:
526 (modest_ui_actions_on_delete_message):
527 Move some code into a new
528 modest_ui_actions_refresh_message_window_after_delete()
529 function so we can use it from elsewhere.
531 * src/dbus_api/modest-dbus-callbacks.c:
532 (on_idle_delete_message), (on_delete_message): Used an idle
533 handler, as we do for the other D-Bus method handlers.
534 Call modest_ui_actions_refresh_message_window_after_delete()
535 if the deleted message was open in a window. This fixed
536 projects.maemo.org bug NB#62862.
538 2007-07-11 Murray Cumming <murrayc@murrayc.com>
540 * src/modest-main.c: (main): Only show the UI at the start if
541 the showui command line option was given. For instance,
542 run-standalone src/modest showui
543 Otherwise, we wait for the top_application D-Bus method to
544 be sent by hildon-desktop when the application is selected
546 This allows us to run without a UI when osso-global-search
547 uses our D-Bus methods.
549 2007-07-11 Murray Cumming <murrayc@murrayc.com>
551 * src/dbus_api/modest-dbus-api.h: Added a define for a
552 top-application D-Bus method.
553 * src/dbus_api/modest-dbus-callbacks.c:
554 (on_top_application),
555 (modest_dbus_req_handler): Handle the top-application D-Bus
556 method, which might be an undocumented D-Bus signal sent by
557 hildon-desktop when it starts the application from the menu.
558 But I am not sure and I need to test it on the device, because
559 my scratchbox does not have the application in the menu now.
560 This method shows the main window, so that it can be invisible
561 when started, for instance, just for email searching from
564 * src/maemo/modest-main-window.c: (restore_settings),
565 (modest_main_window_new): Do not show the window immediately
566 upon creation. We show it later.
567 * src/modest-widget-memory.c: (save_settings_paned):
568 Try (unsuccessfully) to avoid saving the paned position when
569 it is not even visible.
570 (restore_settings_paned): Do not allow a silly paned position.
571 This seems necessary when not showing the window at first.
573 * tests/dbus_api/Makefile.am:
574 * tests/dbus_api/test_top_application.c: (main): Test for the
577 2007-07-10 Murray Cumming <murrayc@murrayc.com>
579 * src/modest-ui-dimming-rules.c:
580 (modest_ui_dimming_rules_on_new_msg),
581 (modest_ui_dimming_rules_on_reply_msg),
582 (modest_ui_dimming_rules_on_delete_msg),
583 (modest_ui_dimming_rules_on_details),
584 (modest_ui_dimming_rules_on_view_window_move_to),
585 (modest_ui_dimming_rules_on_view_previous),
586 (modest_ui_dimming_rules_on_view_next),
587 (_invalid_folder_for_purge): Added checks before
588 casting the window. This looks like an actual
589 logic error in _invalid_folder_for_purge(), because it
590 tries to use a ModestMainWindow as a message window.
592 2007-07-10 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/modest-account-settings-dialog.c:
595 (show_error): Use the same implementation as in
596 modest-easysetup-wizard.c:
597 (on_entry_invalid_character): The logical ID contains a %s.
598 Guessed what it should be.
599 (on_entry_max), (check_data), (on_response): Adapt to
600 changed show_error().
601 (create_page_account_details): Really call
602 modest_validating_entry_set_func() on the correct widgets.
603 * src/maemo/easysetup/modest-easysetup-wizard.c:
604 (on_entry_invalid_character): Fix the logical ID here too.
605 (create_page_account_details),
606 (create_page_user_details):
608 modest_validating_entry_set_func() on the correct widgets.
610 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
611 Do not try to use the account if it is NULL.
613 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
615 * src/modest-ui-actions.c: (create_move_to_dialog),
616 (modest_ui_actions_on_main_window_move_to),
617 (modest_ui_actions_on_msg_view_window_move_to):
618 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
619 (filter_row), (modest_folder_view_show_non_move_folders):
620 * src/widgets/modest-folder-view.h:
622 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
623 the Sent folder yet as it does not report the correct folder type.
625 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
627 * src/maemo/modest-msg-edit-window.c: (init_window):
630 2007-07-10 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
633 Take a parent widget instead of a parent window, and
634 implement this with hildon_banner_show_information() instead.
635 Non-Maemo builds can just ifdef that there.
636 This fixed projects.maemo.org bug NB#62766.
638 (on_entry_invalid_character): Use show_error() again instead
639 of using hildon directly, and use the _CS() macro to use the correct
641 (create_account), (check_for_supported_auth_methods), (on_entry_max):
642 Pass a widget instead od a window to show_error().
644 2007-07-10 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
647 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
648 This allows us to show the server name in the error message, fixing
649 projects.maemo.org bug NB#62904.
650 Also, use the appropriate logical ID message for the account protocol.
652 2007-07-10 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-tny-account-store.c: (on_idle_wrong_password):
655 A compilation fix, though the build wasn't broken for me.
657 2007-07-09 Murray Cumming <murrayc@murrayc.com>
659 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
660 Do not try to unref a NULL folder store, to avoid a runtime warning.
661 This seems to happen sometimes when changing accounts settings.
663 2007-07-09 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-tny-account-store.c:
666 (modest_tny_account_store_instance_init),
667 (modest_tny_account_store_finalize),
668 (on_account_settings_hide), (on_idle_wrong_password):
669 Use a GHashTable to ensure that we only show one account settings
670 dialog per modest account. This avoids us having a dialog open for
671 both the store and transport accounts, or due to repeated get_password()
672 calls that shouldn't happen anyway.
674 2007-07-09 Murray Cumming <murrayc@murrayc.com>
676 * src/maemo/modest-maemo-utils.c: (on_hide),
677 (modest_maemo_show_dialog_and_forget): Handle the response, because
678 the window is not even hidden by default.
680 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
681 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
682 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
683 which seems to prevent some modality problems.
685 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
686 Ignore user cancellation errors.
688 * src/modest-account-mgr-helpers.h:
689 * src/modest-account-mgr-helpers.c:
690 Added modest_server_account_get_password() and
691 modest_server_account_get_has_password() to avoid direct use of
694 * src/maemo/modest-account-settings-dialog.h:
695 * src/maemo/modest-account-settings-dialog.c:
696 (modest_account_settings_dialog_init): Store the notebook so we can
698 Added modest_account_settings_dialog_switch_to_user_info().
700 * src/modest-tny-account-store.c:
701 (get_password): When the password in the account settings is wrong (we think),
702 show the relevant page of the account settings dialog, in the mainloop.
703 However, we currently get many of these at once because cancel does not
705 (forget_password): Do not forget the password
706 from the account settings, because this causes side-effects when
707 tinymail seems to call it at strange time, maybe because of how we
708 are cancelling get_password().
709 (modest_tny_account_store_alert): Ignore user cancellations.
711 2007-07-09 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/modest-maemo-utils.h:
714 * src/maemo/modest-maemo-utils.c:
715 Added modest_maemo_show_information_note_and_forget() for use instead of
716 gtk_dialog_run() when the response is not needed, to avoid an extra
717 mainloop which could cause a hang.
719 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
720 Use the logical IDs for the error message, though they are not
721 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
722 because gtk_dialog_run() caused a hang here (the window did not close).
723 This fixes projects.maemo.org bug NB#62646.
725 2007-07-09 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-account-mgr-helpers.h:
728 * src/modest-account-mgr-helpers.c:
729 Added modest_account_mgr_get_store_protocol().
731 * src/maemo/modest-account-view-window.c:
732 (on_delete_button_clicked): Show different warning text depending on
733 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
734 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
737 2007-07-09 Murray Cumming <murrayc@murrayc.com>
739 * src/maemo/modest-msg-edit-window.c:
740 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
741 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
743 2007-07-07 Armin Burgmeier <armin@openismus.com>
745 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
746 ckdg_ib_maximum_characters_reached from correct package.
748 * src/modest-ui-actions.c: Show an error message when a folder could
749 not be created. Tinymail does not give us specific error codes about
750 what has gone wrong, so we assume that a folder with that name
751 already exists, though there might be other reasons.
753 2007-07-06 Murray Cumming <murrayc@murrayc.com>
755 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
756 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
757 give a more exact error message that can be partly translated.
759 2007-07-05 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-address-book.c:
762 (select_email_addrs_for_contact): Specify a default window size for the
763 select-email-address dialog, so that it is probably big enough for the
764 title. This should fix projects.maemo.org bug NB#62277.
766 2007-07-05 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/easysetup/modest-easysetup-wizard.c:
769 (create_page_complete_easysetup): Use
770 gtk_widget_set_size() request to ensure that the text wraps
773 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
775 * src/maemo/easysetup/modest-easysetup-wizard.c:
776 (on_entry_invalid_character), (create_page_account_details),
777 (create_page_user_details):
778 Use new API of ModestValidatingEntry. But for some reason the banner is
779 not shown. I will have to investigate that further.
781 * src/widgets/modest-validating-entry.c: (on_insert_text),
782 (modest_validating_entry_set_func):
783 * src/widgets/modest-validating-entry.h:
784 Added a new callback function to be able to react to prevented
785 characters whitespaces to e.g show a banner.
787 2007-07-05 Armin Burgmeier <armin@openismus.com>
789 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
790 notification of HildonNumberEditor instead of remembering the port
791 number. Thanks to Johannes for pointing this out.
793 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
795 * src/maemo/easysetup/modest-easysetup-wizard.c:
796 Check if there are any user changes before showing a confirmation
797 dialog (projects.maemo.org NB#60946)
799 2007-07-05 Armin Burgmeier <armin@openismus.com>
801 * src/maemo/modest-account-settings-dialog.c: Remember custom port
802 number at the beginning of the dialog and set the modified flag at the
803 end if the port number has changed. This is necessary because
804 HildonNumberEditor does not support notification when the value has
807 2007-07-05 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-ui-actions.c:
810 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
811 a connection before asking anything else. Correct the check for the destination
812 folder so that it succeeds when online.
813 This fixed projects.maemo.org bug NB#61645.
815 2007-07-05 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
818 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
819 to fix projects.maemo.org bug NB#62439.
821 2007-07-05 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account.c: (on_connection_status_changed):
824 Really do not use tny_device_force_offline() here. See the previous comment.
826 2007-07-04 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-tny-account.c: (on_connection_status_changed):
829 Do not use tny_device_force_offline() when tinymail says that something
830 went wrong with the connection. It seems to report this unnecessarily.
832 2007-07-04 Murray Cumming <murrayc@murrayc.com>
834 * src/maemo/modest-connection-specific-smtp-window.c:
835 (modest_connection_specific_smtp_window_init):
836 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
837 does not seem to have any effect in osso 1.1 (though it works in
838 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
840 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
842 * src/maemo/modest-connection-specific-smtp-window.c:
843 Fix UI specification problems with projects.meamo.org NB#60479
845 2007-07-04 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
848 clue when this has failed, because the error dialog is not always shown
849 (at least in earlier version).
851 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
852 GError message, because the generic error dialog is not helpful.
854 'This message is not currently available (can't let a new connection go online)'
855 when trying to open an IMAP message.
857 (_modest_ui_actions_open): Offer a connection when some messages would
858 have to be downloaded and we are offline.
860 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
862 * src/widgets/modest-folder-view.c:
863 Don't check for MERGE type anymore as we use the correct type
865 NOTE: For the last two changes you need to update your tinymail copy
866 because of API changes!
868 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
870 * src/modest-tny-local-folders-account.c:
871 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
872 (see projects.maemo.org NB#61580)
874 2007-07-04 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-tny-account.c: (on_connection_status_changed):
877 Commented out the call to modest_platform_connect_and_wait() because this
878 seems to always hang, and I would like to know if this is the only thing
879 that causes a hang when showing the connection dialog.
880 It is not very useful anyway.
882 2007-07-04 Murray Cumming <murrayc@murrayc.com>
884 * src/maemo/modest-msg-view-window.c:
885 (modest_msg_view_window_select_next_message):
887 * src/modest-platform.h:
888 * src/maemo/modest-platform.c:
889 Added modest_platform_connect_and_wait(), which calls
890 tny_maemo_conic_device_connect() always in the main thread, by calling it
891 in an idle handler and waiting for the idle handler to run. It should be
892 in the main thread because it uses GTK+ UI code. It just returns TRUE
893 if the device is already online.
895 There is some nasty code to ensure that subsequent calls to
896 modest_platform_connect_and_wait() just wait for the first one to finish,
897 by checking repeatedly in another idle handler. This is necessary,
898 because other threads (or even the main thread, via another idle handler)
899 can call modest_platform_connect_and_wait() while
900 modest_platform_connect_and_wait() is running.
902 (modest_platform_connect_and_wait_if_network_account),
903 (modest_platform_connect_and_wait_if_network_folderstore):
904 Convenience functions that calls modest_platform_connect_and_wait() if
905 the account or folder might want network access.
907 * src/modest-mail-operation.c:
908 (modest_mail_operation_update_account):
909 * src/modest-ui-actions.c: (download_uncached_messages),
910 (modest_ui_actions_on_rename_folder), (delete_folder),
911 (modest_ui_actions_on_main_window_move_to),
912 (modest_ui_actions_on_msg_view_window_move_to):
913 * src/widgets/modest-folder-view.c:
914 (drag_and_drop_from_folder_view):
915 Offer a connection if we are offline.
917 * src/modest-tny-account.c: (on_connection_status_changed):
918 Document this as only handling errors during network operations in progress,
919 and replace the idle code with a simple call to
920 modest_platform_connect_and_wait(), which does this instead.
922 2007-07-03 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-tny-account.c:
925 (modest_tny_account_get_special_folder): (util_on_idle),
926 Handle the GError so we can see when tny_folder_store_get_folders()
927 fails, as it currently does while something else is connecting.
929 Added util_run_in_main_thread_and_wait()
930 which uses an idlen handler and mainloop to ensure that the function
931 is called in the main thread.
932 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
933 to make sure that we call attempt the connection in the mainloop only,
934 which might solve some hangs.
936 2007-07-03 Murray Cumming <murrayc@murrayc.com>
938 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
939 be found by their display name. This is never useful.
940 * src/modest-tny-account-store.c: (on_account_removed): Find the account
941 by its ID, instead of trying to use its ID as its display name.
943 * src/modest-tny-account-store.h:
944 * src/modest-tny-account.c:
945 (modest_tny_account_get_special_folder): Add a g_warning() when
946 tny_folder_store_get_folders() returns an empty list for the maildir.
948 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
949 Add a g_warning() when this returns NULL, because that it not allowed
952 2007-07-02 Armin Burgmeier <armin@openismus.com>
954 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
955 note when trying to cancel the wizard. This fixes projects.maemo.org
958 2007-07-02 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-tny-account.h:
961 * src/modest-tny-account.c:
962 (modest_tny_account_new_from_server_account),
963 (modest_tny_account_new_from_server_account_name),
964 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
965 because this must now be set before setting the proto. This is usd in
966 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
967 warning in camel_session_get_service() caused by
968 tny_camel_transport_account_prepare().
970 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
973 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
977 (modest_connection_specific_smtp_edit_window_init):
979 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
982 2007-06-29 Murray Cumming <murrayc@murrayc.com>
984 * src/modest-tny-account.c:
985 (modest_tny_account_new_from_server_account):
986 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
987 now uses to request a connection when it needs one, and which it uses
988 to tell us that something is wrong with the connection, so we can force
989 the accounts offline to prevent further problems.
992 * src/modest-init.c: (init_default_settings):
993 * src/modest-mail-operation.c:
994 (modest_mail_operation_update_account):
995 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
996 This should not be necessary anymore. Do not set the conf key that
997 determined this (it was always TRUE and not set anywhere else).
999 * src/modest-ui-actions.h: Remove unused and unimplemented
1000 modest_ui_actions_on_online_toggle_toggled().
1002 2007-06-29 Murray Cumming <murrayc@murrayc.com
1004 * src/maemo/modest-main-window.c: (connect_signals):
1005 Don't connect to delete_event twice. Maybe this was harmless.
1007 2007-06-29 Murray Cumming <murrayc@murrayc.com
1009 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1010 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1011 Debug output to give some more clue when a folder move is not allowed.
1013 2007-06-28 Murray Cumming <murrayc@murrayc.com
1015 * src/modest-tny-account.c: (on_modest_file_system_info),
1016 (modest_tny_account_get_mmc_account_name):
1017 Always call the callback, without checking whether the name has changed.
1018 * src/widgets/modest-folder-view.c: (strings_are_equal),
1019 (on_model_foreach_set_name), (on_get_mmc_account_name),
1020 (text_cell_data): Compare the name here, and use the name from
1021 the account rather than from the
1022 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1023 if the name was changed after the account was added to the model.
1024 That's a tinymail bug but not one that I want to fix now.
1026 This finally fixes projects.maemo.org bug NB#59301.
1028 2007-06-27 Armin Burgmeier <armin@openismus.com>
1030 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1033 2007-06-27 Murray Cumming <murrayc@murrayc.com
1035 * src/modest-tny-account.h:
1036 * src/modest-tny-account.c:
1037 Added modest_tny_account_get_mmc_account_name(), to set the memory
1038 card name asynchronously for the given account and then notify.
1039 (modest_tny_account_new_for_local_folders): Use this new function instead
1040 of using hildon_file_system_info_async_new() directly.
1042 * src/widgets/modest-folder-view.c: (text_cell_data):
1043 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1044 gtk_tree_model_row_changed() when it is available.
1046 This should fix projects.maemo.org bug NB#59301.
1048 2007-06-27 Murray Cumming <murrayc@murrayc.com
1050 * src/modest-mail-operation.c: (update_account_thread),
1051 (get_msgs_full_thread): Fix typo failures in the revert
1054 2007-06-27 Murray Cumming <murrayc@murrayc.com
1056 * src/maemo/modest-maemo-global-settings-dialog.c:
1057 (idle_select_default_focus):
1058 * src/modest-mail-operation.c: (idle_notify_progress),
1059 (idle_notify_progress_once), (set_last_updated_idle),
1060 (update_account_thread), (get_msgs_full_thread):
1061 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1062 * src/widgets/modest-header-view.c:
1063 (idle_notify_headers_count_changed_destroy),
1064 (idle_notify_headers_count_changed):
1065 Reverted the additions of gdk_threads_enter/leave(), in case this
1066 helps with a startup hang on the device.
1068 2007-06-26 Armin Burgmeier <armin@openismus.com>
1070 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1071 for supported secure authentication methods from server by
1072 gtk_dialog_run(), saving CPU time and a potential race condition.
1074 2007-06-26 Armin Burgmeier <armin@openismus.com>
1076 * src/maemo/modest-maemo-utils.h:
1077 * src/maemo/modest-maemo-utils.c: Added a
1078 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1079 only error code to tell the calling code when the user canceled the
1082 * src/maemo/modest-account-settings-dialog.h:
1083 * src/maemo/modest-account-settings-dialog.c:
1084 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1085 message if the retrieval of secure authentication methods was canceled
1086 by the user. Perform the check before saving anything to configuration
1087 to not end up with half-committed configuration changes, do not show
1088 a "Saving to configuration failed" note when authentication methods
1089 could not be retrieved.
1091 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1094 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1096 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1097 Only return the first level of folders under accounts, because the
1098 osso-global-search UI spec doesn't want the rest.
1099 This fixed projects.maemo.org bug NB#61811.
1101 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1103 * src/modest-tny-account-store.c:
1104 * src/modest-tny-account-store.h:
1105 Added modest_tny_account_is_memory_card_account().
1106 * src/maemo/modest-main-window.c: (create_details_widget):
1107 Show the same information items for the memory card as we show for the
1108 local-folders, to fix projects.maemo.org bug NB#59307.
1110 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1112 * src/modest-tny-account-store.c: (get_password):
1113 Added some checks for NULL to maybe prevent crashes, though I think
1114 it was Philip's last commit that actually prevented the crash here
1115 when creating a first new account.
1116 But the new account is still not usable (no messages are shown)
1117 until a restart of the application.
1119 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1121 * src/maemo/modest-maemo-global-settings-dialog.c:
1122 (idle_select_default_focus):
1123 * src/modest-mail-operation.c: (idle_notify_progress),
1124 (idle_notify_progress_once), (idle_notify_update_account_queue),
1125 (set_last_updated_idle), (update_account_thread),
1126 (notify_get_msgs_full), (get_msgs_full_destroyer),
1127 (get_msgs_full_thread):
1128 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1129 * src/widgets/modest-header-view.c:
1130 (idle_notify_headers_count_changed_destroy),
1131 (idle_notify_headers_count_changed):
1132 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1133 all idle handlers, because some other thread could be blocking
1134 the GDK lock, so that it can do GUI stuff.
1136 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1138 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1139 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1140 (on_idle_send_receive), (on_idle_open_default_inbox):
1141 * src/maemo/modest-msg-edit-window.c:
1142 (modest_msg_edit_window_attach_file_noninteractive):
1143 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1144 to prevent a hang. I don't quite understand why these are necessary,
1145 beause we should already be in the main loop. I guess something outside
1146 of the main loop is taking the lock.
1148 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1149 we are really using URIs, and use files that are more likely to exist.
1151 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1153 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1154 necessary because configure.ac now defines different variables.
1156 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1158 * libmodest-dbus-client/libmodest-dbus-client.c:
1159 * libmodest-dbus-client/libmodest-dbus-client.h:
1160 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1161 libmodest_dbus_client_compose_mail() is what things actually use.
1163 * src/dbus_api/modest-dbus-api.h:
1164 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1165 * tests/dbus_api/Makefile.am:
1166 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1169 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-init.c: (modest_init_local_folders):
1172 For memory-card (or other non local-folders) maildir accounts,
1173 always create an Archive folder, so that there is somewhere to put
1174 messages. This should be less confusing, because the user does not need
1175 to guess that the need to create a folder.
1177 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1179 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1180 Fixed icon size by using (50, 50) which is the same as defined by
1183 2007-06-25 Armin Burgmeier <armin@openismus.com>
1185 * src/widgets/modest-window-mgr.c:
1186 * src/modest-init.c:
1187 * configure.ac: Correctly recognize hildon-notify presence and fixed
1188 the build without it being installed.
1190 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1192 * libmodest-dbus-client/libmodest-dbus-client.c:
1193 (libmodest_dbus_client_search): Fix the build. Sorry.
1194 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1195 (reply_forward_cb): Initialize variables to fix the build.
1197 * src/modest-tny-account-store.c:
1198 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1199 comparison (a silly typo) so that email search results can be opened
1200 when there are more than one account.
1202 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1204 * libmodest-dbus-client/libmodest-dbus-client.c:
1205 (libmodest_dbus_client_search),
1206 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1207 instead of 1 second, because the search gets folders and messages from
1208 the server, which can take a long time. When it times out,
1209 osso-global-search will report no results.
1211 We need to specify whether we should search only cached information
1212 (maybe with a user preference), and the osso-email-search-plugin
1213 API should really be improved to allow that option, and to allow results
1214 to be delivered asynchronously in batches.
1216 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1218 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1219 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1220 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1222 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1225 that is an empty string. D-Bus seems to give us these instead of NULL.
1227 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1229 * src/dbus_api/modest-dbus-callbacks.c:
1230 * src/maemo/easysetup/modest-easysetup-wizard.h:
1231 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1232 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1233 (modest_connection_specific_smtp_edit_window_init):
1234 * src/maemo/modest-maemo-global-settings-dialog.c:
1236 * src/maemo/modest-maemo-utils.c:
1237 (modest_maemo_utils_setup_images_filechooser):
1238 * src/maemo/modest-main-window.c: (create_details_widget):
1239 * src/maemo/modest-msg-edit-window.c:
1240 (modest_msg_edit_window_attach_file_noninteractive),
1241 (modest_msg_edit_window_color_button_change),
1242 (modest_msg_edit_window_set_zoom):
1243 * src/modest-mail-operation.c: (update_account_thread):
1244 * src/modest-tny-account-store.c:
1245 * src/modest-tny-account.c:
1246 * src/widgets/modest-global-settings-dialog.c:
1247 * src/widgets/modest-window.h:
1249 Fixed build on bora!
1251 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1253 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1254 * src/modest-search.c: (modest_search_folder),
1255 (modest_search_all_accounts): Actually search only in the specified folder,
1256 doing a simple match on the folder ID.
1257 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1258 and added some documentation.
1260 2007-06-22 Armin Burgmeier <armin@openismus.com>
1262 * src/maemo/modest-maemo-utils.h:
1263 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1264 modest_maemo_utils_get_supported_secure_authentication_methods.
1266 * src/maemo/easysetup/modest-easysetup-wizard.c:
1267 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1268 one occured, not just "Server does not support secure authentication".
1270 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-tny-account-store.c: (get_password):
1273 Restored the call to tny_account_set_user() because Philip seems to have
1274 stopped this from crashing (by not using the freed string). It still does
1275 not work, but now we can test it.
1277 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-msg-edit-window.c: (init_window):
1280 Comment out use of an uninitialzed GtkScrolledWindow variable,
1281 to fix the build and stop a crash. Yet again.
1283 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-tny-account-store.c: (get_password):
1286 Remove the call to tny_account_set_user() because this actually crashes.
1287 As mentioned in the last commit, it is known to not work anyway.
1289 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1291 * src/modest-tny-account-store.c: (get_password):
1292 Use tny_account_set_username() to tell tinymail that the username might
1293 have changed too. But tinymail ignores this: see projects.maemo.org
1295 * src/modest-ui-actions.c:
1296 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1297 reset the connection when changing the username, and improve the comments.
1298 Save the changed username to gconf at least, so it is used when Modest is
1301 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1303 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1304 Do not use a query, so that we get all folders, including for POP and
1305 local-folders. They work as search criteria too.
1306 This fixes projects.maemo.org bug NB#57740.
1308 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1311 Comment out the use of hildon_notification_set_sound() because it is
1312 not declared, to fix the build. Warnings are serious, people.
1314 2007-06-21 Armin Burgmeier <armin@openismus.com>
1316 * src/maemo/modest-maemo-utils.h:
1317 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1318 modest_maemo_utils_get_supported_secure_authentication_methods()
1319 to query authentication methods for a specific user. This should fix
1320 projects.maemo.org bug NB#61369.
1322 * src/maemo/easysetup/modest-easysetup-wizard.c:
1323 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1326 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1328 * libmodest-dbus-client/libmodest-dbus-client.h:
1329 * libmodest-dbus-client/libmodest-dbus-client.c:
1330 (modest_dbus_message_iter_get_search_hit),
1331 (libmodest_dbus_client_search):
1332 Reorganised and commented this.
1333 Removed modest_search_hit_free() from the public API because it
1336 Added libmodest_dbus_client_get_folders() and
1337 modest_folder_result_list_free().
1339 * src/dbus_api/modest-dbus-api.h:
1340 * src/dbus_api/modest-dbus-callbacks.c:
1341 (modest_dbus_req_filter): Commented. Moved most code to
1342 on_dbus_method_search() and added on_dbus_method_get_folders().
1344 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1345 of the extra D-Bus handler.
1347 * tests/dbus_api/Makefile.am:
1348 * tests/dbus_api/test_get_folders.c: New test for
1349 libmodest_dbus_client_get_folders(). This seems to return an empty list
1350 at the moment. That could be the same error that causes the message list
1351 to be empty sometimes.
1352 This should help with projects.maemo.org bug NB#57740.
1354 2007-06-21 Armin Burgmeier <armin@openismus.com>
1356 * src/modest-mail-operation.c: Do not call
1357 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1358 notify the operation's end after having set the status to CANCELED for
1359 the operation queue to listen on. This fixes a deadlock when there
1360 were mail operations in the queue during its finalization.
1362 * src/modest-singletons.c: Reordered uninitialization of the account
1363 manager to happen after the mail operation queue was uninitialized
1364 because the mail operation's in the queue might still try to access
1365 the account manager (see modest_mail_operation_notify_end()). This
1366 fixes a potential crash when terminating the application.
1368 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1370 * src/modest-search.c:
1371 (search_mime_part_and_child_parts): Moved some code here so we
1372 can search recursively in child folders.
1373 (modest_search_folder): Search in the message as a mime part, instead
1374 of just its child mime parts.
1375 (read_chunk), (search_mime_part_ogs):
1376 Check how many bytes were read, to prevent an endless loop.
1377 Searching in message bodies now works. This finishes the fix for
1378 projects.maemo.org bug NB#61007.
1380 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1382 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1383 Add a g_warning when the item is not a folder.
1385 * src/modest-ui-dimming-rules.c:
1386 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1387 when selected item is not a folder (for instance, an account), because
1388 the UI spec only talks about folders.
1389 I am not sure what the UI spec wants, so this might not totally fix
1390 projects.maemo.org bug NB#60794.
1392 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1395 (load_from_file): Sort the list. The unsorted list would be more noticeable
1396 in non-English locales.
1398 * src/maemo/modest-msg-edit-window.c:
1399 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1400 warning and fix the build.
1402 * src/maemo/modest-progress-bar-widget.c:
1403 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1404 avoid a g_warning, and probably to avoid a crash.
1406 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-search.c: (modest_search_folder): Check for a GError
1409 when calling tny_folder_get_headers(), to show that this is not the cause
1412 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1414 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1415 Actually set the body query instead of the subject query.
1417 * src/modest-search.c: (search_mime_part_ogs),
1418 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1419 which would probably cause it to fail if we got this far.
1421 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1422 to simplify the code.
1423 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1424 be causing search-in-body to fail.
1426 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1428 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1430 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1431 Better debug message when the folder cannot be found.
1432 This should help with fixing projects.maemo.org bug #61287.
1433 * src/modest-search.c: (add_hit): Do not leak the furl string.
1435 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1437 * src/modest-ui-actions.c:
1438 (modest_ui_actions_on_folder_selection_changed):
1439 Do not special-case TNY_MERGE_FOLDER here, because
1440 modest_tny_folder_get_account() already does that. This fixes
1441 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1442 shown when the Outbox was selected).
1444 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1446 * libmodest-dbus-client/libmodest-dbus-client.c:
1447 (_dbus_iter_get_string_or_null): Initialize the string variable in
1448 case this helps with Dirk's crash.
1450 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1452 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1453 though it is not implemented yet (this function is maybe not even used),
1454 to avoid breaking ABI in future.
1455 * libmodest-dbus-client/libmodest-dbus-client.c:
1456 (get_attachments_string): Moved some code into this generic function.
1457 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1458 sends email. It is maybe not used.
1459 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1460 (on_send_mail): Use attachments.
1462 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1463 * src/maemo/modest-msg-edit-window.c:
1464 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1465 a filename before using it, to fix projects.maemo.org bug NB#58233.
1467 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1470 Initialize the continue_download variable to fix the build, and probably
1471 to fix randome behaviour.
1473 2007-06-18 Armin Burgmeier <armin@openismus.com>
1475 * src/modest-tny-send-queue.h:
1476 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1477 the queue so we can later show it in the UI. Replaced
1478 modest_tny_send_queue_msg_is_being_sent() by
1479 modest_tny_send_queue_get_msg_status().
1481 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1483 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1484 gpointer. This probably was not harmful, but just to be sure.
1486 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1488 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1489 Fix the build, but leave the function broken on Bora, because
1490 hildon_uri_action_get_service() does not exist.
1491 osso_uri_action_get_service() does not exist either, it seems.
1493 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-tny-account.c:
1496 (modest_tny_account_new_from_server_account):
1497 Uncommented the url debug output again, because it is useful for
1498 debugging, as I said in the comment.
1500 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1502 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1504 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1505 for Mameo Bora, to fix the build.
1507 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1510 Fixed build with hildon < 0.99
1512 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1513 Check if the selected account is busy instead of checking all accounts
1515 * src/modest-account-mgr-priv.h:
1516 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1517 (modest_account_mgr_init), (compare_account_name),
1518 (modest_account_mgr_set_account_busy),
1519 (modest_account_mgr_account_is_busy):
1520 * src/modest-account-mgr.h:
1521 Added busy information to the account manager. It possible to
1522 set an account to busy or not busy now.
1524 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1525 (modest_mail_operation_update_account),
1526 (modest_mail_operation_notify_end):
1527 Set the account to busy/not busy depending on the operation state.
1529 * src/widgets/modest-account-view.c:
1530 (modest_account_view_finalize), (get_last_updated_string),
1531 (update_account_view), (on_account_busy_changed), (init_view):
1532 Show string "Refreshing..." if the account is currently busy.
1534 All this fixes projects.maemo.org bug NB#59711
1536 2007-06-14 Armin Burgmeier <armin@openismus.com>
1538 * src/widgets/modest-attachments-view.h:
1539 * src/widgets/modest-attachments-view.c: Added
1540 modest_attachments_view_has_attachments() and fixed coordinate
1541 transformation in get_att_view_at_coords(). This fixes attachment
1544 * src/widgets/modest-msg-view.c: Make use of
1545 modest_attachments_view_has_attachments() to decide whether to show
1546 attachments in the header.
1548 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1550 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1551 (on_change), (on_combo_security_changed),
1552 (modest_connection_specific_smtp_edit_window_init),
1553 (modest_connection_specific_smtp_edit_window_set_connection),
1554 (modest_connection_specific_smtp_edit_window_is_dirty):
1555 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1556 * src/maemo/modest-connection-specific-smtp-window.c:
1559 Show an comfirmation dialog for the smpt-edit-window if there are
1560 unsaved changes and the user hits cancel.
1561 (projects.maemo.org bug NB#60479)
1563 2007-06-14 Armin Burgmeier <armin@openismus.com>
1565 * src/maemo/easysetup/modest-easysetup-wizard.c:
1566 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1567 address" info in banner instead of node, and select all the text as
1568 per UI spec. This fixes projects.maemo.org bug NB#60550.
1570 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1572 reviewed by: <delete if not using a buddy>
1574 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1575 * src/modest-ui-actions.c: (folder_refreshed_cb):
1577 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1579 * src/widgets/modest-folder-view.c: (filter_row):
1580 Explictly filter out the per-account outbox accounts. I don't know why
1581 these only sometimes show up, but now they should never show up in the UI.
1582 This should fix projects.maemo.org bug NB#60160.
1584 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1587 when the toolbar does not exist yet.
1588 * src/modest-widget-memory.c: (save_settings_header_view):
1589 Added g_warnings() to help us to discover when we are trying to set
1590 an empty columns list in gconf.
1592 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-init.h:
1595 * src/modest-init.c:
1596 Added modest_init_get_default_header_view_column_ids().
1598 * src/modest-widget-memory.c: (restore_settings_header_view):
1599 Use the new function to get defaults, if the gconf key is empty,
1600 instead of not creating any columns. This seems to fix the
1601 empty right-hand pane problems.
1603 * src/widgets/modest-header-view.h: Improved documentation.
1605 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1607 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1608 Revert the use of the display name as the account name, because this
1609 is generally wrong and would break the code that follows.
1611 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1613 * src/maemo/easysetup/modest-easysetup-wizard.c:
1614 (check_for_supported_auth_methods), (on_before_next),
1617 More correct fix for projects.maemo.org bug NB# 58991
1618 Do not longer accept AUTH_PASSWORD as secure method and choose
1619 correct method when creating the account.
1621 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1623 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1624 Fixed projects.maemo.org bug NB# 58991
1626 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1628 * src/modest-init.c: (modest_init_init_core),
1629 (modest_init_local_folders): Fixed compilation errors.
1631 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1633 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1634 Remove unnecessary lib/include, though it is good in principle when needed.
1636 * src/modest-init.c: (modest_init_one_local_folder),
1637 (modest_init_local_folders):
1638 * src/modest-init.h: Initialize the .modest library for memory cards,
1639 instead of just doing nothing for them. This should allow us to create
1640 folders there, fixing projects.maemo.org bug NB#59297.
1642 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1644 * libmodest-dbus-client/libmodest-dbus-client.c:
1645 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1646 (libmodest_dbus_client_compose_mail),
1647 (libmodest_dbus_client_open_message),
1648 (libmodest_dbus_client_send_and_receive),
1649 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1651 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1652 (on_idle_open_message), (modest_dbus_req_handler),
1653 (search_result_to_message), (modest_dbus_req_filter):
1654 * src/modest-search.c: (add_hit), (modest_search_folder),
1655 (modest_search_all_accounts): Improved debug messages.
1657 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1659 * src/modest-tny-account-store.c:
1660 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1663 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1666 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1668 * src/modest-tny-account-store.c: (get_server_accounts):
1669 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1670 even when there are no accounts, so that the Outbox folder is always
1671 visible. This fixes projects.maemo.org bug NB#60158.
1673 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1675 * src/maemo/modest-main-window.c: (create_details_widget):
1676 Use the mcen_va_never logical ID.
1678 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1680 * src/dbus_api/modest-dbus-api.h:
1681 * src/dbus_api/modest-dbus-callbacks.c:
1682 (on_idle_open_default_inbox), (on_open_default_inbox),
1683 (modest_dbus_req_handler):
1684 Added a new OpenDefaultInbox method.
1686 * libmodest-dbus-client/libmodest-dbus-client.h:
1687 * libmodest-dbus-client/libmodest-dbus-client.c:
1688 Added libmodest_dbus_client_open_default_inbox() to call the new
1689 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1690 though it should maybe be used by a new osso-email-interface function.
1692 * tests/dbus_api/Makefile.am:
1693 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1696 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1698 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1699 NULL, so that the signals get all the keys. This should not actually
1700 change any behaviour because we currently update everything when anything
1703 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1705 * src/widgets/modest-folder-view.c: (text_cell_data),
1706 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1707 (find_inbox_iter): If tinymail tells us that the folder is
1708 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1709 This causes the inbox to be selected at startup, fixing part of
1710 projects.maemo.org bug NB#56305.
1712 * src/modest-ui-dimming-rules.c:
1713 (modest_ui_dimming_rules_on_tools_smtp_servers):
1714 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1715 the SMTP servers menu item.
1716 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1717 that the SMTP Servers menu item is dimmed when there are no accounts,
1718 as a future version of the UI spec will require. This fixes
1719 projects.maemo.org bug NB#56305.
1721 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1723 * src/maemo/modest-maemo-utils.c:
1724 (modest_maemo_utils_get_supported_secure_authentication_methods):
1725 Added label to dialog instead of unreadable title
1727 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1728 (modest_main_window_new):
1729 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1732 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1733 * src/modest-account-mgr.h:
1734 Added method to avoid code duplication
1736 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1737 (modest_ui_actions_on_send_receive):
1738 Use modest_account_mgr_has_accounts
1740 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1742 * src/maemo/easysetup/modest-presets.c:
1743 (modest_presets_get_info_server_security): Do not report secure auth
1745 * src/modest-protocol-info.c: Use the defines for the gconf key names
1746 for secure authentication. This was not working because we were writing
1747 Password and reading password, and the check was case sensitive.
1748 With this, gmail now works for receiving and sending when created via
1751 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/easysetup/modest-presets.c:
1754 (modest_presets_get_info_server_security): Correct the key name for
1755 SecureSmtp, because it seems to be case-sensitive.
1756 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1757 Do not try to get the 0th notebook page if there are 0 pages, to
1758 avoid a g_warning().
1760 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1762 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1763 Prevent use of the new notification feature for now, because it currently
1764 shows one dialog for each new email, which is annoying.
1766 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1769 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1770 when no country was selected, so that we show the global ones.
1771 * src/maemo/easysetup/modest-presets.c:
1772 (modest_presets_get_providers): Return only the global providers, not
1773 all providers when mmc=0 was requested.
1775 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1778 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1779 provider ID in the combo.
1781 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1782 Do not show the page numbers, because it would be confusing when we add
1783 the 2 extra pages for the custom setup, when the user chooses the "Other"
1784 provider. This fixes projects.maemo.org bug NB#59028
1786 * src/modest-init.c: (modest_init_init_core),
1787 (modest_init_local_folders):
1788 * src/modest-init.h:
1789 * src/modest-tny-account.c:
1790 (modest_tny_account_new_for_local_folders): Do not create default folders
1791 for the memory card. This should fix projects.maemo.org bug NB#59328.
1793 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1795 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1796 Free the changed_conf_keys string items. They are already freed in the
1797 idle handler if that runs first.
1799 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-ui-actions.c:
1802 (modest_ui_actions_on_password_requested): Check that the server name
1803 is not NULL, because I just saw a password dialog with (null) as the
1806 * src/modest-tny-folder.[h|c]: Added
1807 modest_tny_folder_is_memory_card_folder().
1808 * src/modest-ui-dimming-rules.c:
1809 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1810 menu item for memory cards, as per the UI spec (section 7.4). This should
1811 fix projects.maemo.org bug NB#59297.
1813 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1815 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1816 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1817 is another problem with the code, see Murray's comment at line 772)
1819 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1822 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1823 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1824 (load_from_file), (easysetup_country_combo_box_init),
1825 (easysetup_country_combo_box_get_active_country_ids),
1826 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1827 instead of just one ID, to avoid duplicate country names in the UI.
1829 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1830 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1831 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1832 a single ID, avoiding duplicate providers.
1833 * src/maemo/easysetup/modest-easysetup-wizard.c:
1834 (on_combo_account_country): Adapt to use a list.
1836 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1838 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1839 keys changed in the last X seconds.
1841 * src/modest-account-mgr.h:
1842 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1843 (on_key_change), (modest_account_mgr_class_init),
1844 (modest_account_mgr_init), (modest_account_mgr_finalize):
1845 As the keys are changed, save them in a GSList* and signal that GSList*
1846 further every X seconds, to batch changes, to allow us to do just one
1847 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1848 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1850 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1851 changed signal signature.
1853 * src/modest-conf.c: (modest_conf_set_list),
1854 (modest_conf_on_change): Reenable notification.
1856 (modest_conf_maemo_fake_on_change): Comment out the hack that
1857 notified immediately instead of asynchronously.
1859 * src/widgets/modest-account-view.h:
1860 * src/widgets/modest-account-view.c:
1861 (update_account_view): Select the previously-selected account ID,
1862 if possible. This fixes projects.maemo.org bug NB#56933.
1864 (on_account_changed), (on_account_removed),
1865 (modest_account_view_select_account):
1867 Remove the block/unblock functions
1868 because they were not useful.
1870 * src/maemo/modest-account-view-window.c:
1871 (on_delete_button_clicked), (on_edit_button_clicked),
1872 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1874 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1876 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1877 Improve the error dialog to show Incorrect Account Settings, which seems
1878 clearer, and say that the internal error message (to be removed from the
1879 dialog later) is often misleading.
1880 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1882 * src/modest-tny-account.c:
1883 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1884 URL because this is so useful for debugging on the device.
1886 * src/widgets/modest-serversecurity-combo-box.c:
1887 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1889 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1891 * src/modest-mail-operation.c:
1892 (modest_mail_operation_send_new_mail):
1893 Added a comment about a nasty but apparently harmless message. Details
1894 added to the wiki g_warnings() page.
1896 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1898 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1899 (modest_tny_send_queue_class_init):
1900 Do not use the priv struct because it is empty, to avoid g_warnings
1901 about a non-existant priv struct.
1903 * src/modest-tny-account-store.c:
1904 (modest_tny_account_store_get_server_account),
1905 (modest_tny_account_store_get_transport_account_for_open_connection
1906 ): Do not try to get transport server accounts for local folders,
1907 because they don't have any. This avoids a g_warning().
1909 * src/maemo/modest-main-window.c:
1910 (modest_main_window_notify_send_receive_initied),
1911 (on_configuration_key_changed):
1912 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1913 * src/modest-defs.h:
1914 * src/modest-mail-operation.c:
1915 (modest_mail_operation_update_account):
1916 * src/modest-tny-account-store.h:
1917 * src/modest-tny-account.c:
1918 (modest_tny_account_get_special_folder),
1919 (modest_tny_account_new_for_local_folders),
1920 (modest_tny_account_new_for_per_account_local_outbox_folder):
1921 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1922 * src/modest-tny-local-folders-account.c:
1923 (add_account_folders_to_merged_folder):
1924 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1925 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1926 (modest_ui_actions_on_send):
1927 * src/widgets/modest-folder-view.c: (update_model):
1928 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1929 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1930 modest_tny_account_store_get_tny_account_by_account() to
1931 modest_tny_account_store_get_server_account() to make the code clearer.
1933 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1935 * src/dbus_api/modest-dbus-api.h:
1936 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1937 * src/maemo/modest-msg-edit-window.c:
1938 (modest_msg_edit_window_attach_file_noninteractive):
1939 added g_warning in case the file to be attached does not exist
1940 * tests/dbus_api/test_compose_mail.c: (main):
1941 removed obsolete comment, added generic files as test case
1943 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-tny-account-store.c: (get_server_accounts):
1946 Create the local folders account only once, not once for each outbox, and
1947 not only when there are some outboxes.
1949 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1951 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1952 code that is causing a crash at startup. Sergio says that he is fixing this.
1954 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1956 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1957 * src/maemo/modest-account-settings-dialog.c:
1958 (create_page_outgoing),
1959 (modest_account_settings_dialog_set_account_name),
1960 (save_configuration):
1961 - Fixed handling of the "Use secure authentication" toggle to comply with
1962 the ui specification. See also projects.maemo.org bug NB#58400
1964 - Restore the Secure connection setting combo correctly when loading
1967 * src/maemo/modest-maemo-utils.c:
1968 (on_camel_account_get_supported_secure_authentication),
1969 (modest_maemo_utils_get_supported_secure_authentication_methods):
1970 Fixed a crasher if operation is canceled
1972 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1973 (modest_protocol_info_auth_is_secure):
1974 * src/modest-protocol-info.h:
1976 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1977 the sense of the "Use secure authentication" toggle.
1979 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-tny-account-store.h:
1982 * src/modest-tny-account-store.c:
1983 Added modest_tny_account_store_get_local_folders_account().
1985 * src/modest-tny-folder.h:
1986 * src/modest-tny-folder.c:
1987 (modest_tny_folder_get_account):
1988 Added this replacement for tny_folder_get_account() which returns
1989 the local-folders account for TnyMergeFolders, to avoid the
1990 warning about the unimplemented get_account_func() vfunc().
1992 (modest_tny_folder_get_rules),
1993 * src/modest-ui-actions.c:
1994 (modest_ui_actions_on_folder_selection_changed):
1995 * src/modest-mail-operation.c:
1996 (modest_mail_operation_remove_folder),
1997 (modest_mail_operation_xfer_folder),
1998 (modest_mail_operation_rename_folder),
1999 (modest_mail_operation_get_msg),
2000 (modest_mail_operation_get_msgs_full),
2001 (modest_mail_operation_remove_msg),
2002 (modest_mail_operation_xfer_msgs),
2003 (modest_mail_operation_refresh_folder):
2004 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2006 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2009 (modest_server_account_set_security):
2010 * src/modest-defs.h: Add comments explaining that our
2011 UI spec means TLS when it says Normal, so these do not look like errors.
2013 * src/modest-tny-account.c:
2014 (modest_tny_account_new_from_server_account): Use the new tinymail
2015 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2016 for TLS. This should fix projects.maemo.org bug NB#58460.
2018 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2020 * src/maemo/easysetup/modest-easysetup-wizard.c:
2021 (create_account): Correct the position of the gconf sanity check warning.
2022 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2023 of using the g_idle_add() hack, because this does not seem to be necessary
2024 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2025 caused by something other than maemo's gconf.
2026 This fixes projects.maemo.org bug #59022.
2028 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-account-mgr-helpers.c:
2031 (modest_account_mgr_get_default_account): Do not check that the account
2032 exists if there is no default account (NULL), to fix a runtime warning.
2034 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2036 * src/widgets/modest-folder-view.c: (update_model):
2037 Do not unref the treemodel before we have finished with it.
2038 This prevents a valgrind warning and an occasional crash at startup.
2040 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2042 * libmodest-dbus-client/libmodest-dbus-client.h:
2043 added libmodest_dbus_client_compose_mail()
2044 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2046 added functions needed for SendAsMail() functionality
2047 * src/maemo/modest-msg-edit-window.c:
2048 (modest_msg_edit_window_attach_file_noninteractive):
2049 non interactively attaching files to message edit window
2050 * src/widgets/modest-msg-edit-window.h:
2051 * tests/dbus_api/Makefile.am:
2052 added test_compose_mail.c
2053 * tests/dbus_api/test_compose_mail.c: (main):
2055 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2057 * src/modest-account-view.c:
2058 Fixed bug projects.maemo.org bug NB#59307
2060 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2062 * src/maemo/easysetup/modest-easysetup-wizard.c:
2063 (get_serverport_incoming), (on_before_next), (create_account):
2064 * src/maemo/modest-account-settings-dialog.c:
2065 (modest_account_settings_dialog_set_account_name):
2066 * src/maemo/modest-maemo-utils.c:
2067 (on_camel_account_get_supported_secure_authentication_status),
2068 (on_camel_account_get_supported_secure_authentication),
2069 (on_secure_auth_cancel),
2070 (modest_maemo_utils_get_supported_secure_authentication_methods):
2072 Implemented security authentication for settings and easysetup.
2074 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/modest-main-window.c: (create_details_widget):
2077 Show the total size for memory card accounts too, instead of showing
2078 the name again. Fixes bug projects.maemo.org bug NB#59307.
2080 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-simple-folder-store.c:
2084 * src/modest-tny-simple-folder-store.h: Removed.
2086 * src/modest-tny-local-folders-account.h
2087 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2088 for the local-folders maildir, with an extra TnyMergedFolder containing
2089 the folders of the per-account outbox store accounts.
2090 * src/modest-tny-account-store.c: (get_server_accounts):
2091 Add the outboxes to the special local folders account after creating it.
2093 * src/modest-tny-account.c:
2094 (modest_tny_account_new_for_local_folders): Create the derived
2095 account when creating the main local-folders account.
2097 * src/maemo/modest-main-window.c: (create_details_widget),
2098 (modest_main_window_set_contents_style):
2099 Adapted to the use of the derived account instead of the folder store.
2101 * src/modest-ui-actions.c:
2102 (modest_ui_actions_on_folder_selection_changed):
2103 * src/modest-ui-dimming-rules.c:
2104 (modest_ui_dimming_rules_on_new_folder):
2105 * src/widgets/modest-folder-view.c: (text_cell_data),
2106 (icon_cell_data), (filter_row), (update_model),
2107 (get_cmp_rows_type_pos):
2110 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2111 Do not get the priv struct, because no priv struct has been set,
2112 to avoid a runtime warning.
2114 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2115 #ifelse with #else, to fix a warning, to fix the build.
2118 2007-06-05 Christian Kellner <ckellner@openismus.com>
2120 * libmodest-dbus-client/libmodest-dbus-client.c:
2121 Fix small typo in doc (why do you always see them
2122 AFTER committing stuff?)
2125 2007-06-05 Christian Kellner <ckellner@openismus.com>
2127 * libmodest-dbus-client/libmodest-dbus-client.c:
2128 (libmodest_dbus_client_search):
2129 Initialize hit list with NULL. Also set folder list
2130 to "" if NULL was supplied.
2133 2007-06-03 Christian Kellner <ckellner@openismus.com>
2135 * libmodest-dbus-client/libmodest-dbus-client.c:
2136 (modest_search_hit_list_free):
2137 Make it save to call it with NULL.
2139 * src/dbus_api/modest-dbus-callbacks.c:
2140 * src/modest-search.c:
2141 Return full ModestSearchHits as the search result list not TnyHeader
2142 since can't be around withouth the correspoding TnyFolder.
2144 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2146 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2147 Added currently commented code to check for secure auth
2149 * src/maemo/modest-account-settings-dialog.c: (on_response),
2150 (save_configuration), (show_ok):
2151 Fixed projects.maemo.org bugs NB #59248 and #59251
2153 * src/maemo/modest-maemo-utils.c:
2154 (on_camel_account_get_supported_secure_authentication_status),
2155 (on_camel_account_get_supported_secure_authentication),
2156 (modest_maemo_utils_get_supported_secure_authentication_methods):
2157 * src/maemo/modest-maemo-utils.h:
2158 Moved get_supported_secure_authentication() method here to be able
2159 to use it from easysetup wizard.
2161 * src/modest-pair.c: (on_pair_compare_as_string):
2162 Should compare string with first part of pair and not
2163 strcmp pairs which will crash.
2165 * src/modest-protocol-info.c:
2166 (modest_protocol_info_protocol_is_store):
2167 * src/modest-protocol-info.h:
2168 Added modest_protocol_info_get_auth_protocol_name()
2170 2007-06-03 Armin Burgmeier <armin@openismus.com>
2172 * src/modest-mail-operation.c:
2173 (modest_mail_operation_get_msgs_full): Set priv->account also when
2174 only retrieving a single message. This avoids a crash when canceling
2177 (modest_mail_operation_notify_end): Do not explicitely remove the
2178 operation from the queue but only emit the progress_changed signal.
2179 The queue itself listens to that signal to remove the operation when
2180 it is finished. This reduces coupling and removes a potential deadlock
2181 when modest_mail_operation_notify_end() is called from the queue
2182 itself. If that is a problem performance-wise, I would suggest to
2183 implement a status-changed signal or something.
2185 * src/modest-mail-operation-queue.c: Make sure to never call a
2186 function from another file while the queue is locked. This (hopefully)
2187 fixes another deadlock when exiting the application while retrieving
2190 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2192 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2193 Fixed build if libogs is not available
2195 2007-06-03 Christian Kellner <ckellner@openismus.com>
2197 * libmodest-dbus-client/libmodest-dbus-client.h:
2198 * libmodest-dbus-client/libmodest-dbus-client.c:
2199 (libmodest_dbus_client_delete_message):
2200 Implement deletion of messages (Client side).
2202 (modest_search_hit_free),
2203 (modest_search_hit_list_free):
2204 Utility functions to free the result hits.
2206 * src/dbus_api/modest-dbus-api.h:
2207 * src/dbus_api/modest-dbus-callbacks.c:
2208 (on_delete_message),
2209 (modest_dbus_req_handler):
2210 Implement deletion of messages (Server side).
2212 * tests/dbus_api/test_search.c: (main):
2215 * tests/dbus_api/Makefile.am:
2216 * tests/dbus_api/test_delete_message:
2217 Add little test for the message deletion logic
2219 2007-06-03 Armin Burgmeier <armin@openismus.com>
2221 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2222 when the operation queue was not empty. projects.maemo.org bug
2225 2007-06-03 Armin Burgmeier <armin@openismus.com>
2227 * src/widgets/modest-account-view.c
2228 (on_account_default_toggled): Toggle default account column
2229 explicitely instead of waiting for gconf notification (which is
2230 currently ignored). This should fix projects.maemo.org bug NB#56910
2231 for now. It should probably be removed when gconf notifications are
2234 2007-06-03 Christian Kellner <ckellner@openismus.com>
2236 * libmodest-dbus-client/libmodest-dbus-client.c:
2237 Removed debugging spew.
2239 * src/dbus_api/modest-dbus-callbacks.c:
2240 Added debugging info.
2242 * src/modest-search.c:
2243 (modest_search_all_accounts):
2244 Use tny_account_store_get_accounts () on the account store
2245 to get all accounts which is the way to get all accounts.
2247 * tests/dbus_api/test_search.c: (main):
2248 Make it possible to supply the search term on the command line.
2250 2007-06-03 Christian Kellner <ckellner@openismus.com>
2252 * libmodest-dbus-client/libmodest-dbus-client.c:
2253 * libmodest-dbus-client/libmodest-dbus-client.h:
2254 Implement searching for mesages over raw dbus. (Client side)
2256 * src/dbus_api/Makefile.am:
2257 * src/dbus_api/modest-dbus-api.h:
2258 * src/dbus_api/modest-dbus-callbacks.c:
2259 * src/dbus_api/modest-dbus-callbacks.h:
2260 Search framework (Server side). Also implement on_idle_open_message().
2262 * src/maemo/modest-platform.c: (modest_platform_init):
2263 Prepare for raw dbus/osso rpc interaction.
2265 * src/modest-search.h:
2266 Changed minsize from unspecific guint to guint32.
2268 * src/modest-search.c:
2270 Added strange hack which magically made tnymail work.
2272 (modest_search_folder),
2273 (modest_search_account),
2274 (modest_search_all_accounts):
2275 Implement helper functions to search all accounts, specific account
2278 * tests/dbus_api/Makefile.am:
2279 * tests/dbus_api/test_open_message.c:
2280 Read url to open from commandline.
2282 * tests/dbus_api/test_search.c:
2283 Implement small test for dbus search stuff
2285 2007-06-02 Armin Burgmeier <armin@openismus.com>
2287 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2288 include account type and account title. This fixes projects.maemo.org
2291 * src/maemo/modest-account-view-window.c: Set a title for the window.
2293 2007-06-02 Armin Burgmeier <armin@openismus.com>
2295 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2296 incoming and outgoing server name based on email address and server
2297 types as long as the names have not been edited manually. This fixes
2298 projects.maemo.org bug NB#58671.
2300 2007-06-02 Armin Burgmeier <armin@openismus.com>
2302 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2303 server type cannot be changed in future to the incoming details page
2304 when creating an account. This fixes projects.maemo.org bug NB#59029.
2306 2007-06-02 Armin Burgmeier <armin@openismus.com>
2308 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2309 and assigned max width chars so that they wrap instead of being
2310 truncated. Fixes projects.maemo.org bug NB#56126.
2312 2007-06-02 Armin Burgmeier <armin@openismus.com>
2314 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2315 introductory note to the connection specific smtp servers dialog, as
2316 section 8.12 of the email UI specification requires. This fixes
2317 projects.maemo.org bug NB#59212.
2319 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2322 Check for running mail operations, and offer to cancel them, as per the UI
2323 spec. This fixes projects.maemo.org bug NB#59041 .
2324 However, I suspect that tinymail may still use the network connection
2325 in ways that we cannot detect or cancel. But it should at least adapt to
2326 changes fairly well.
2328 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2330 * src/modest-tny-account-store.c: (recreate_all_accounts),
2331 (get_cached_accounts), (get_server_accounts): Do more sensible
2332 ref-counting of the temporarily-cached outbox accounts list. This seems
2333 to fix a crash when entering the password when the password was wrong.
2335 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2337 * src/gnome/modest-main-window.c: (connect_signals):
2338 * src/modest-tny-account-store.c: (get_password),
2339 (modest_tny_account_store_alert): Added comments and clues and
2340 commented-out code about how we currently fail to deal with connection
2341 errors and wrong passwords, and how we should.
2343 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2345 * src/widgets/modest-retrieve-combo-box.c:
2346 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2347 This fixes projects.maemo.org bug NB#58472 .
2349 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2351 * src/maemo/easysetup/modest-easysetup-wizard.c:
2352 (create_page_complete_easysetup):
2353 (create_page_complete_custom): Correct the last commit,
2354 putting the correct sentences in the correct pages.
2356 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2358 * src/maemo/easysetup/modest-easysetup-wizard.c:
2359 (create_page_complete_custom): Show the second sentence of text
2360 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2363 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2366 Set the leave-on-server conf key by default. This fixes
2367 projects.maemo.org bug NB#59258 .
2369 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2371 * src/maemo/modest-account-view-window.c:
2372 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2373 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2376 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2378 * src/maemo/easysetup/modest-easysetup-wizard.c:
2379 (create_caption_new_with_asterisk):
2380 * src/maemo/modest-account-settings-dialog.c:
2381 (create_caption_new_with_asterisk):
2382 Uncomment the code to add the asterisk, because they are no longer in the
2383 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2384 (update_incoming_server_title): Add an asterisk here too.
2386 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2388 * src/maemo/modest-maemo-global-settings-dialog.c:
2389 (current_connection): Check that we are even connected before trying to
2390 get the current connection name, to prevent a warning.
2392 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2393 Change the comments because tny_maemo_conic_device_connect() is now meant to
2395 * src/modest-mail-operation.c:
2396 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2397 make sure we have a connection and fail if we can't connect.
2399 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-main-window.c:
2402 (on_account_store_connecting_finished): Do not try to get the
2403 connection ID if we are not really connected. I am surprised that
2404 this signal handler is called when we are not connected.
2406 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-error.h:
2409 * src/modest-ui-actions.c:
2410 (modest_ui_actions_get_msgs_full_error_handler):
2411 Renamed an enum, added comments, added an enum
2412 for retrieve-limit errors.
2414 * src/modest-mail-operation.c: (foreach_add_item),
2415 (internal_folder_observer_update), (update_account_thread),
2416 (modest_mail_operation_get_msgs_full):
2417 (modest_mail_operation_update_account),
2418 Added comments about how this works, and some code that should
2419 (but does not) check the retrieve-limit. See the TODO comment.
2421 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2424 Initialize help_id to fix the build. Warnings are good.
2426 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2428 * src/widgets/modest-hbox-cell-renderer.c:
2429 (modest_hbox_cell_renderer_append):
2430 * src/widgets/modest-vbox-cell-renderer.c:
2431 (modest_vbox_cell_renderer_append):
2432 Fix the last commit by doing an extra ref.
2434 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2436 * src/widgets/modest-hbox-cell-renderer.c:
2437 (modest_hbox_cell_renderer_append):
2438 * src/widgets/modest-vbox-cell-renderer.c:
2439 (modest_vbox_cell_renderer_append):
2440 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2441 to fix the build with Maemo Bora.
2442 However, there seems to be a remaining crash, probably due to reference
2445 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2447 * src/modest-tny-account.c:
2448 (modest_tny_account_new_for_local_folders):
2449 Use hildon_file_system_info_async_new() to get a better name for
2450 the memory card account, setting it as the account name.
2451 The timing seems to work, but this is probably
2452 not the best place to do this. See the TODO comment.
2453 * src/maemo/modest-main-window.c: (create_details_widget):
2454 * src/widgets/modest-folder-view.c: (text_cell_data):
2455 Use the tny account name instead of hardcoding a name.
2457 2007-05-30 Christian Kellner <ckellner@openismus.com>
2459 * src/modest-search.c: (modest_search):
2460 Correctly set part_search_func even if we have already parsed
2461 the query and thus a valid OgsTextSearcher object.
2463 2007-05-30 Christian Kellner <ckellner@openismus.com>
2466 Search and check for libogs.
2469 Incooparte the ogs build env.
2471 * src/modest-mime-part-search-stream.c:
2472 * src/modest-mime-part-search-stream.h:
2473 Removed since we do the real searching now in modest-search.c.
2475 * src/modest-search.c:
2476 * src/modest-search.h:
2477 Implement support for ogs. We use that if available and requested
2478 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2479 should now handle the corner case when the search term is spread
2480 across multiple reads.
2481 Also the logic in modest_search () was corrected to search all
2482 requested fields until one is found.
2484 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2486 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2488 * src/modest-init.h:
2489 * src/modest-init.c: Made modest_init_local_folders() take a
2490 path and be public so we can iniitialize maildir folders on
2493 * src/modest-local-folder-info.h:
2494 * src/modest-local-folder-info.c:
2495 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2497 * src/modest-tny-account.c:
2498 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2499 still means the standard local-folders path on the local volume.
2501 * src/modest-tny-account-store.c:
2502 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2503 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2504 all accounts when that happens.
2505 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2506 this too, so it shows up in the treeview.
2508 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2510 * src/maemo/modest-maemo-global-settings-dialog.c:
2511 (current_connection):
2512 * src/widgets/modest-global-settings-dialog.c:
2513 (current_connection_default):
2514 Use the enum values instead of 0, 1 and -1,
2515 to make the code clearer.
2517 * src/modest-account-mgr-helpers.c:
2518 (modest_account_mgr_get_connection_specific_smtp): Make this code
2521 * src/modest-runtime.h:
2522 * src/modest-runtime.c:
2523 Added modest_runtime_remove_all_send_queues().
2524 * src/maemo/modest-main-window.c:
2525 (on_account_store_connecting_finished): Recreate the send queues,
2526 using the appropriate transport accounts for this new connection.
2527 Some futher adapting might be needed if the old send queues are not
2528 automatically stopped at this point.
2530 * src/modest-tny-account-store.c: (get_server_accounts):
2531 Create the connection-specific transport accounts, so that they can
2532 be found later by their ID.
2534 * src/modest-tny-account.h:
2535 * src/modest-tny-account.c:
2536 Added modest_tny_account_new_from_server_account_name().
2537 modest_tny_account_new_from_server_account(): Do not create the
2538 send queues here, because they will be
2539 recreated anyway when the connection changes for the first time.
2541 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2543 * src/modest-local-folder-info.h:
2544 * src/modest-local-folder-info.c:
2545 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2546 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2547 tbox_folder): Take a modest account name instead of a server TnyAccount,
2548 so we can have per-modest-account rather than per-transport-account
2550 We must make sure that we change or recreate the exisitng send queues
2551 when the connection changes for connection-specific transport accounts.
2553 * src/modest-tny-account-store.c:
2554 (create_per_account_local_outbox_folders): Create outboxed per modest
2555 account, not per transport account.
2557 * src/modest-tny-account.h:
2558 * src/modest-tny-account.c:
2559 (modest_tny_account_get_special_folder): For outboxes, get the
2560 parent modest account name. The account is ignored for other folders.
2561 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2562 modest account name rather than a server TnyAccount.
2564 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2566 * src/modest-tny-account.c:
2567 (modest_tny_account_new_from_server_account):
2568 Call modest_runtime_get_send_queue() immediately after creating transport
2569 accounts, so that they start trying to send email from the outbox as soon
2570 as possible at startup. This is probably what we want.
2572 * src/modest-mail-operation.c: (update_account_thread):
2573 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2574 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2575 * src/modest-tny-send-queue.h:
2576 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2577 (modest_ui_actions_on_send):
2578 Added comments about how sending works, though it needs some more work.
2580 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2582 * src/modest-tny-account.c:
2583 (modest_tny_account_get_special_folder): Add TODO because this fails when
2584 the network is busy.
2585 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2586 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2587 Do not try to show this window when there is no active account. The UI
2588 specs does not tell us what to do in this case.
2590 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2594 * src/maemo/Makefile.am:
2595 * src/widgets/Makefile.am: Some dist fixes.
2597 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2599 * src/maemo/modest-connection-specific-smtp-window.c:
2600 (on_button_edit): Make the code clearer, to prevent a double free.
2602 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2604 * src/maemo/modest-account-settings-dialog.c:
2605 (modest_account_settings_dialog_set_account_name),
2606 Check the connection-specific smtp servers checkbox if there are any.
2608 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2609 (modest_connection_specific_smtp_edit_window_init):
2610 Start with a suitable port number.
2612 * src/modest-account-mgr-helpers.h:
2613 * src/modest-account-mgr-helpers.c: Added
2614 modest_account_mgr_get_has_connection_specific_smtp().
2616 (modest_account_mgr_set_connection_specific_smtp),
2617 (modest_account_mgr_remove_connection_specific_smtp),
2618 (modest_account_mgr_get_has_connection_specific_smtp),
2619 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2620 connection-specific smtp server accounts in the account, rather than
2621 the server account conf dir.
2623 This fixes bug projects.maemo.org bug NB#58263 .
2625 * src/modest-tny-account-store.c:
2626 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2627 if there are no server accounts yet, to prevent an infinite loop when there
2628 are no accounts. Document that one must be called before the other.
2630 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-account-mgr-helpers.c:
2633 (modest_account_mgr_get_default_account): Make sure that at least
2634 one account is always the default, if there are any enabled accounts.
2635 This is just a sanity check that shouldn't be necessary.
2637 * src/modest-account-mgr-priv.c:
2638 (_modest_account_mgr_account_from_key): Unescape the conf key to
2639 get the real account name. For instance, this is an issue if a space
2640 was in the account name, which can happen because the account name
2641 is generated from the display name.
2642 (_modest_account_mgr_get_account_keyname): Always escape the
2644 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2645 Unescape the conf keys to get the real account names.
2647 For instance, previously the is-default radio button in the accounts
2648 list was not checked for any accounts at first. This fixes that,
2649 and might fix several similar bugs.
2651 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2654 Removed some debug printfs.
2656 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2658 Modest on-disk outbox directories are now here, for instance:
2659 $HOME/.modest/outboxes/<account-id-1>/outbox
2660 $HOME/.modest/outboxes/<account-id-2>/outbox
2662 $HOME/.modest/local-folders/outbox
2663 so we can have a separate outbox for each account.
2664 But they are shown as one outbox in the GtkTreeView, by using a
2665 TnyMergeFolder in a ModestTnySimpleFolderStore.
2668 * src/modest-tny-simple-folder-store.c:
2669 * src/modest-tny-simple-folder-store.h:
2670 Added ModestTnySimpleFolderStore, used to contain folders from
2671 other folder stores, such as other accounts.
2673 * src/modest-tny-outbox-account.h:
2674 * src/modest-tny-outbox-account.c:
2675 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2676 used for the per-account local outbox folders.
2678 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2679 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2680 only use this (internally) now for the non-outbox local folders.
2682 * src/modest-init.h:
2683 * src/modest-init.c: Added modest_init_one_local_folder(), for
2684 setting up the directory structure for each local folder.
2686 * src/modest-local-folder-info.c:
2687 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2688 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2690 * src/modest-local-folder-info.h:
2691 * src/modest-tny-account-store.c: (on_account_removed),
2692 (on_account_changed), (create_per_account_local_outbox_folders),
2693 (get_server_accounts), (modest_tny_account_store_get_accounts),
2694 (modest_tny_account_store_get_tny_account_by_account),
2695 (modest_tny_folder_store_is_virtual_local_folders):
2697 * src/modest-tny-account.h:
2698 * src/modest-tny-account.c:
2699 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2700 to create an on-disk per-account local outbox folder for each
2702 (create_per_account_local_outbox_folders): Create a local outbox folder
2703 for each transport account.
2704 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2705 for all local folders.
2707 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2708 instead of using g_object_get/set() directly. It is clearer.
2710 (modest_tny_folder_store_get_message_count),
2711 (modest_tny_folder_store_get_local_size
2712 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2713 because we now use these with non-acount folder stores.
2715 (modest_tny_account_get_special_folder),
2716 (modest_tny_account_new_from_server_account),
2717 (modest_tny_account_new_from_account):
2718 (recurse_folders): Adjust to the new outbox system.
2720 * src/modest-tny-folder.h:
2721 * src/modest-tny-folder.c:
2722 (modest_tny_folder_is_local_folder),
2723 (modest_tny_folder_get_local_folder_type),
2724 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2726 * src/widgets/modest-main-window.h:
2727 * src/maemo/modest-main-window.c: (create_details_widget),
2728 (modest_main_window_set_contents_style): Show details for any folder store,
2731 (modest_tny_folder_get_rules):
2732 Remove the const. C does not support constness enough for this.
2734 * src/modest-ui-actions.c:
2735 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2736 make all outboxes appear as one, in the usual local-folders tree node.
2738 (set_active_account_from_tny_account),
2739 (modest_ui_actions_on_folder_selection_changed):
2740 * src/widgets/modest-folder-view.c: (text_cell_data),
2741 (icon_cell_data), (filter_row),
2742 (add_account_folders_to_merged_folder),
2743 (add_account_folders_to_simple_folder_store), (),
2744 (get_cmp_rows_type_pos), (cmp_rows),
2745 (modest_folder_view_set_account_id_of_visible_server_account):
2746 Adjust to the new outbox system, using generic folder stores and folders
2747 in the GtkTreeModel.
2749 2007-05-23 Christian Kellner <ckellner@openismus.com>
2751 * src/modest-mail-operation.c:
2752 (modest_mail_operation_update_account):
2753 Use info->max_size instead of unintialized local var [small
2754 build fix]. (Added TODO to review that change since I don't
2757 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2759 * libmodest-dbus-client/libmodest-dbus-client.c:
2760 (libmodest_dbus_client_compose_mail): function added
2761 * src/dbus_api/modest-dbus-api.h:
2762 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2763 (on_compose_mail): Implementation of the SendAsMail functionality
2765 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2767 * src/modest-account-mgr.c:
2768 (modest_account_mgr_add_server_account): Set the secure-connection
2769 conf key for transport accounts as well as store accounts. I don't know
2770 why the if was there. For instance, this makes sure that we use SSL
2771 for the gmail preset from the easysetup wizard.
2773 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2775 * src/gnome/modest-main-window.c:
2776 (on_account_store_connecting_finished), (connect_signals):
2777 * src/maemo/modest-main-window.c:
2778 (on_account_store_connecting_finished), (connect_signals),
2779 (modest_main_window_new):
2780 Handle TnyAccountStore::connecting-finished instead of
2781 TnyDevice::connection-changed, because we cannot actually perform
2782 operations on accounts until TnyAccountStore has itself responded to
2783 the TnyDevice::connection-changed signal. This prevents a GError from
2785 Do not try to update at startup, because we (at least on scratchbox)
2786 already do an update at startup when the device goes online.
2787 This prevents a GError from tinymail.
2788 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2789 Added TODO about stopping simultaneous operations.
2791 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2793 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2794 * src/modest-mail-operation-queue.c:
2795 (modest_mail_operation_queue_remove):
2796 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2797 about where they happened.
2799 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2801 * src/modest-ui-actions.c:
2802 (modest_ui_actions_on_password_requested): Make sure that the remember
2803 output parameter is always TRUE.
2805 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2807 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2808 Show a OK/Cancel dialog if the error is a question, though we still do not
2809 know anything more about what we are asking the user.
2810 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2811 Fix an uninitialized variable (helper). This is a logic error, however.
2813 2007-05-21 Christian Kellner <ckellner@openismus.com>
2815 * src/modest-search.h:
2816 Correct bit shifting in the ModestSearchFlags enum.
2818 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2820 * src/modest-tny-account.c:
2821 (modest_tny_account_new_from_server_account): Do not use the lsub and
2822 check-all hard-coded IMAP options when using POP.
2824 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2826 * src/modest-tny-account.c:
2827 (modest_tny_account_new_from_server_account):
2828 Use NULL for the secure-auth method for POP when Password auth has been
2829 specified by the user, as we already do for IMAP. "auth=Login" causes
2830 an error from camel or the server.
2832 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/modest-account-settings-dialog.c:
2835 (create_page_account_details),
2836 (modest_account_settings_dialog_set_account_name):
2837 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2838 for the leave-on-server checkbox, rathr than just the checkbox, when
2839 the protocol is not POP.
2841 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2843 * src/widgets/modest-account-view.c:
2844 * src/widgets/modest-account-view.h:
2845 Added modest_account_view_select_account() which will be useful later
2846 to asynchronously re-select the edited account.
2848 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2850 * src/maemo/modest-account-settings-dialog.c:
2851 (modest_account_settings_dialog_set_account_name):
2852 Automatically choose the port numbers based on the secure authentication
2853 methods, if they have not been chosen before.
2854 This fixes projects.maemo.org bug NB#56273 .
2856 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2858 * src/maemo/modest-main-window-ui.h:
2859 * src/modest-ui-actions.c:
2860 * src/modest-ui-actions.h:
2861 Connect the Tools/SMTP Servers menu item to
2862 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2863 SMTP servers dialog, as in the UI specification and saves changes when it
2864 is closed. This fixed projects.maemo.org bug NB#56305 .
2866 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/modest-connection-specific-smtp-window.c:
2869 (modest_connection_specific_smtp_window_init):
2870 Use gtk_window_set_default_size() to make this window big enough, so
2871 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2873 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2875 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2876 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2877 (modest_connection_specific_smtp_edit_window_init),
2878 Do not try to connect to a combobox signal before the combobox exists.
2879 This fixes the cras in projects.maemo.org bug NB#56288 .
2880 (modest_connection_specific_smtp_edit_window_get_settings):
2881 Remove the server_account_name parameter which was being checked for NULL
2882 though it was not used.
2884 * src/maemo/modest-connection-specific-smtp-window.c:
2885 (modest_connection_specific_smtp_window_fill_with_connections),
2886 (on_button_edit), (modest_connection_specific_smtp_window_init):
2887 Correct the number of treemodel columns to prevent a warning.
2888 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2889 libconic does not work.
2891 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2893 * src/modest-tny-account.c:
2894 (modest_tny_account_new_from_server_account):
2895 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2896 SMTP when "None" was chosen by the user. However, with my SMTP server that
2897 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2900 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2903 to explain the memory management issue with the ID in the ModestPair.
2905 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2906 (add_sending_page), (modest_account_assistant_finalize):
2907 * src/gnome/modest-gnome-global-settings-dialog.c:
2908 (create_updating_page), (create_composing_page):
2909 * src/gnome/modest-msg-edit-window.c: (get_transports),
2910 (init_window), (modest_msg_edit_window_finalize),
2911 (modest_msg_edit_window_get_msg_data):
2912 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2913 * src/gnome/modest-transport-widget.c:
2914 (modest_transport_widget_finalize), (smtp_configuration):
2915 * src/maemo/modest-maemo-global-settings-dialog.c:
2916 (create_updating_page), (create_composing_page):
2917 * src/maemo/modest-msg-edit-window.c: (get_transports),
2918 (init_window), (modest_msg_edit_window_finalize),
2919 (modest_msg_edit_window_get_msg_data),
2920 (modest_msg_edit_window_free_msg_data):
2921 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2922 (modest_store_widget_finalize):
2923 * src/maemo/modest-transport-widget.c:
2924 (modest_transport_widget_finalize), (smtp_configuration):
2925 * src/modest-main.c: (send_mail):
2926 * src/widgets/modest-combo-box.h:
2927 * src/widgets/modest-global-settings-dialog-priv.h:
2928 * src/widgets/modest-global-settings-dialog.c:
2929 (modest_global_settings_dialog_finalize):
2930 * src/widgets/modest-msg-edit-window.h:
2931 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2932 as long as the combo box, to prevent use of freed memory for the ID.
2934 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2936 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2937 get_accounts(), to make this clearer. Do not check for the enabled gconf
2938 key, because we do not use this for server accounts (at least, not yet).
2939 This allows us to send email again.
2941 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2943 * src/maemo/modest-platform.c:
2944 (on_modest_conf_update_interval_changed), (modest_platform_init):
2945 Only respond to this particular key change. All these strcmp()s cannot be
2948 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/modest-maemo-global-settings-dialog.c:
2951 (current_connection): Prevent a crash in scratchbox when
2952 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2953 * src/maemo/modest-platform.c:
2954 (on_modest_conf_update_interval_changed), (modest_platform_init):
2955 Get the update interval from gconf and reset it when the gconf key changes.
2957 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2959 * src/modest-protocol-info.c:
2960 * src/modest-protocol-info.h: Adde enum-specific get functions,
2961 instead of using a ModestProtocolType enum parameter.
2963 * src/gnome/modest-account-assistant.c:
2964 * src/gnome/modest-store-widget.c:
2965 * src/gnome/modest-store-widget.h:
2966 * src/gnome/modest-transport-widget.c:
2967 * src/gnome/modest-transport-widget.h:
2968 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2969 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2970 * src/maemo/easysetup/modest-easysetup-wizard.c:
2971 * src/maemo/modest-account-settings-dialog.c:
2972 * src/maemo/modest-account-settings-dialog.h:
2973 * src/maemo/modest-store-widget.c:
2974 * src/maemo/modest-store-widget.h:
2975 * src/maemo/modest-transport-widget.c:
2976 * src/maemo/modest-transport-widget.h:
2977 * src/modest-account-mgr-helpers.c:
2978 * src/modest-account-mgr-helpers.h:
2979 * src/modest-account-mgr.c:
2980 * src/modest-account-mgr.h:
2981 * src/modest-tny-account.c:
2982 * src/modest-tny-folder.c:
2983 * src/widgets/modest-account-view.c:
2984 * src/widgets/modest-retrieve-combo-box.c:
2985 * src/widgets/modest-retrieve-combo-box.h:
2986 * src/widgets/modest-secureauth-combo-box.c:
2987 * src/widgets/modest-serversecurity-combo-box.c:
2988 * src/widgets/modest-serversecurity-combo-box.h:
2989 * tests/check_account-mgr.c:
2990 Use the specific functions, and use the re-renamed enum values for GNOME too.
2992 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2994 * src/modest-pair.h:
2995 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2996 so we can get the second based on the first.
2998 * src/maemo/modest-account-settings-dialog.h:
2999 * src/maemo/modest-account-settings-dialog.c:
3000 Added get_supported_secure_authentication_methods(), though it is mostly
3001 commented-out for now until the necessary API is committed to tinymail.
3002 (modest_account_settings_dialog_set_account_name),
3003 (save_configuration): Request the supported authentication methods from the
3004 server, so we can choose a working method.
3006 * src/modest-tny-account-store.h:
3007 * src/modest-tny-account-store.c:
3008 (modest_tny_account_store_get_session): Rename from
3009 tny_account_store_get_session().
3011 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3013 * src/modest-protocol-info.h: Split the ModestProtocol enum
3014 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3015 There was no need to have these unrelated values in one enum.
3017 * src/: many files: Adapted to changed enum. This makes the code a bit
3018 clearer, and the compiler could catch some errors.
3020 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3022 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3023 Show the detailed internal camel error message when an error happens
3024 during the configuration, so that our testers can give us more clues.
3025 For instance, in projects.maemo.org bug NB#56910 .
3027 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3029 * src/modest-tny-account.c:
3030 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3031 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3033 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3036 * src/maemo/modest-account-settings-dialog.c:
3037 (modest_account_settings_dialog_set_account_name),
3038 (save_configuration): For the incoming secure authentication checkbox,
3039 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3040 the UI specification. PLAIN does not seem to be supported for most IMAP
3041 servers anyway, and I am not sure what it would mean.
3042 However, we probably need to discover which of the secure-authentication
3043 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3044 * src/modest-account-mgr-helpers.c:
3045 (modest_account_mgr_get_server_account_data):
3047 * src/modest-tny-account.c:
3048 (modest_tny_account_new_from_server_account):
3049 Use tny_account_set_mech() to set secure-authentication methods,
3050 with some special-casing for IMAP, based on my observations of how
3053 * src/modest-account-mgr-helpers.h:
3054 * src/modest-account-mgr.c:
3055 * src/modest-defs.h: Comment that the URI is only used for local folders.
3057 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3059 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3060 parameter const, just to be neat.
3061 * src/modest-text-utils.c: (modest_text_utils_inline):
3062 End g_strconcat() with NULL, as its documentation says. This is almost
3063 certainly the cause of my crash at startup on the device. Interestingly,
3064 valgrind doesn't tell us about these errors.
3066 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3068 * scripts/build-packages: Added more precise comments about how to use
3069 this script, though I still get this error:
3070 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3071 error building tinymail
3073 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3075 * src/maemo/modest-main-window.c: (on_account_update):
3076 Very slight cleanup, hoping to make it simpler to discover what causes
3077 a crash here sometimes.
3079 * src/modest-tny-account.c:
3080 (modest_tny_account_new_from_server_account): Set the port. Added
3081 comments about the options and a TODO comment because I need to find out
3082 how to specify the secure authentication method.
3084 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3086 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3087 changed CFlags paths form modest to libmodest
3089 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3091 * src/modest-account-mgr-helpers.c:
3092 (modest_account_mgr_get_server_account_data),
3093 (modest_account_mgr_free_server_account_data):
3094 * src/modest-account-mgr-helpers.h:
3095 * src/modest-account-mgr.c:
3096 (modest_account_mgr_add_server_account):
3097 * src/modest-defs.h:
3098 * src/modest-tny-account.c:
3099 (modest_tny_account_new_from_server_account):
3100 Determine the options for tny_camel_account_add_option() here,
3101 based on the settings, rather than storing them directly in gconf.
3103 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3105 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3106 Show a more friendly error dialog now that we expect (from the tinymail
3107 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3109 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3111 * src/maemo/modest-main-window.c: (on_account_update): Check that
3112 account_name is not NULL, to prevent a crash at startup that I am
3113 seeing on the N800. I do wonder why it is NULL.
3115 * src/maemo/easysetup/modest-easysetup-wizard.c:
3116 (create_page_user_details):
3117 * src/maemo/modest-account-settings-dialog.c:
3118 (create_page_user_details), (create_page_outgoing):
3119 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3120 (modest_connection_specific_smtp_edit_window_init):
3121 * src/modest-ui-actions.c:
3122 (modest_ui_actions_on_password_requested):
3123 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3124 might do something useful with the on-screen keyboard.
3126 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3128 * src/maemo/modest-main-window.c: (on_account_update):
3129 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3130 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3132 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3134 * src/modest-tny-account-store.c: (on_account_changed):
3135 Correct the signature of this signal handler.
3137 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3139 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3140 Show a HildonNote instead of a GtkDialog for Maemo.
3142 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3144 * src/widgets/modest-account-view.h:
3145 * src/widgets/modest-account-view.c: (on_account_changed),
3146 (on_account_removed). Added a boolean flag, set/unset by
3147 modest_account_view_block_conf_updates(),
3148 modest_account_view_unblock_conf_updates() to prevent unnecessary
3149 updates, but this is not very useful because the gconf notifications are
3150 so delays (maybe only on Maemo Bora).
3151 So auto-updating is turned off, and these functions do an explicit
3152 update when necessary.
3153 However, something else is still doing too much work when adding/removing
3154 accounts, probably in another part of the application.
3156 * src/maemo/modest-account-view-window.c:
3157 (on_delete_button_clicked), (on_edit_button_clicked),
3158 (on_new_button_clicked): Use the new functions.
3160 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3162 * src/modest-account-mgr-helpers.c:
3163 (modest_account_mgr_set_first_account_as_default):
3164 Sort the list of names alphabetically-by-title, so we choose the first one
3166 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3167 alphabetically by the title.
3169 This fixes projects.maemo.org bug NB#56418 .
3171 * src/modest-account-mgr-priv.c:
3172 (_modest_account_mgr_account_from_key):
3173 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3174 avoid a valgrind error, and possible random behaviour.
3176 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3178 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3179 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3180 tinymail documentation to say that this can be expected.
3181 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3182 pretty, and should not happen, but I would prefer to know when it does.
3184 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3186 * configure.ac: When using the older hildon version, probably on Bora,
3187 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3189 * src/widgets/modest-attachment-view.c:
3190 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3193 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3195 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3196 Implemented the prototype. Can be tested with
3197 tests/dbus_api/test_open_message:
3199 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-tny-account-store.c:
3202 (modest_tny_account_store_instance_init), (get_password):
3203 * src/modest-ui-actions.c:
3204 (modest_ui_actions_on_password_requested):
3205 Do not store the password in gconf, because this function is called
3206 for non-remembered passwords. Actually use the cached (in the hash map)
3207 password instead of releasing it.
3208 The password will now not be remembered if it is asked via the protected
3209 password dialog, as per the UI spec.
3211 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3213 * src/modest-defs.h:
3214 * src/modest-account-mgr-helpers.h:
3215 * src/modest-account-mgr-helpers.c:
3216 Added modest_server_account_get_username_has_succeeded(),
3217 modest_server_account_set_username_has_succeeded().
3218 (modest_server_account_set_username),
3219 Reset the has-succeeded flag if the username changes.
3221 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3222 * src/maemo/modest-connection-specific-smtp-window.c:
3223 (modest_connection_specific_smtp_window_save_server_accounts):
3224 Use modest_server_account_set_username() instead of using
3225 modest_conf_set_string() directly, so that the has-succeeded flag is always
3228 * src/modest-ui-actions.c:
3229 (modest_ui_actions_on_password_requested): Dim the username entry if
3230 the username has ever worked, as per the UI spec.
3232 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3234 * src/modest-tny-account-store.c: (get_password):
3235 * src/modest-ui-actions.c:
3236 (modest_ui_actions_on_password_requested):
3237 Allow the username to be changed too, though there is more work to
3238 be done on exactly how this behaves.
3240 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3242 * src/modest-account-mgr-helpers.h:
3243 * src/modest-account-mgr-helpers.c:
3244 Added modest_account_mgr_get_display_name(),
3245 modest_server_account_get_username(),
3246 modest_server_account_set_username(),
3247 modest_server_account_set_password(),
3248 modest_server_account_get_hostname() functions so we do not need to
3249 use the conf API directly.
3251 * src/maemo/modest-main-window.c: (connect_signals):
3252 Actually connect ot the ModestAccountStore::request-password signal,
3253 so that we show the dialog when the password is requested by Tinymail,
3254 for isntance if it is empty.
3256 * src/modest-marshal.list:
3257 * src/modest-tny-account-store.c:
3258 (modest_tny_account_store_class_init), (get_password),
3259 (modest_tny_account_store_alert):
3260 * src/modest-tny-account-store.h:
3261 * src/modest-ui-actions.h:
3262 * src/modest-ui-actions.c:
3263 (modest_ui_actions_on_password_requested):
3264 Change the signal parameters, so it is obvious that we are providing
3265 the non human-readable server name, and receiving both the username
3266 and password, though changing of the username is not yet implemented.
3267 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3268 for the GNOME version.
3270 This should fix the projects.maemo.org bug NB#56209, though it does not
3271 work on Bora, because the gconf_client_get() for the password fails
3272 immediately after we save it with gconf_client_set().
3274 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3277 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3278 caused an undefined symbol error:
3279 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3281 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3283 * src/modest-tny-account-store.c:
3284 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3285 using a GError instead of a string message, so we can translate it in
3288 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3290 * src/maemo/modest-address-book.c:
3291 (modest_address_book_check_names):
3292 * src/maemo/modest-msg-view-window.c:
3293 (modest_msg_view_window_clipboard_owner_change):
3294 * src/modest-init.c: (modest_init_init_ui):
3295 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3296 (update_folders_cb), (modest_mail_operation_update_account):
3297 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3298 (modest_ui_actions_on_msg_attachment_clicked),
3299 (modest_ui_actions_on_msg_recpt_activated):
3300 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3301 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3302 (modest_msg_view_search_next):
3303 * src/widgets/modest-recpt-editor.c:
3304 (modest_recpt_editor_on_button_release_event),
3305 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3306 g_message(). At this point we should only be seeing interesting errors on
3307 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3309 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3311 (modest_wizard_dialog_force_title_update):
3312 * src/maemo/easysetup/modest-wizard-dialog.h:
3313 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3314 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3315 can update the title when appropriate. Otherwise the title is wrong if the
3316 pages are added after adding the notebook to the dialog.
3317 This must be a problem in HildonWizardDialog too.
3318 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3320 * src/maemo/easysetup/modest-easysetup-wizard.c:
3321 (create_subsequent_customsetup_pages),
3322 (create_subsequent_easysetup_pages):
3323 Call modest_wizard_dialog_force_title_update() so that the title is
3324 correct even with GTK+ < 2.10.
3325 This fixes projects.maemo.org bug NB#56145 .
3327 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3329 * src/maemo/modest-platform.c:
3330 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3331 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3334 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3336 * src/widgets/modest-window.h:
3337 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3338 and modest_window_save_state(), which invokes it.
3340 * src/widgets/modest-window-mgr.h:
3341 * src/widgets/modest-window-mgr.c:
3342 Added modest_window_mgr_save_state_for_all_windows(), which calls
3343 the save_state vfunc on all registered windows, if implemented.
3345 * src/gnome/modest-msg-edit-window.c:
3346 * src/gnome/modest-msg-view-window.c:
3347 * src/maemo/modest-msg-edit-window.c:
3348 * src/maemo/modest-msg-view-window.c:
3349 * src/maemo/modest-main-window.c:
3350 Specify the existing save_settings functions as implementations of
3351 ModestWindow::save_state_func().
3353 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3354 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3355 enabling hibernation, for instance.
3357 We may need to do the same thing for restoring settings.
3360 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3362 * src/widgets/modest-window-mgr.c:
3363 * src/widgets/modest-window-mgr.h:
3364 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3365 modest_window_mgr_get_hibernation_is_prevented().
3367 * src/maemo/modest-main-window.c:
3368 (on_hildon_program_is_topmost_notify): Prevent hibernation
3369 (possible when the application goes to the background in the WM),
3370 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3372 * src/maemo/easysetup/modest-easysetup-wizard.c:
3373 (modest_easysetup_wizard_dialog_init):
3374 * src/maemo/modest-account-settings-dialog.c:
3375 (modest_account_settings_dialog_init):
3376 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3377 (modest_connection_specific_smtp_edit_window_init):
3378 * src/maemo/modest-connection-specific-smtp-window.c:
3379 (modest_connection_specific_smtp_window_init):
3380 * src/maemo/modest-signature-editor-dialog.c:
3381 (modest_signature_editor_dialog_init):
3382 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3383 prevent hibernation while any of these account settings dialogs are open.
3385 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3387 * src/maemo/Makefile.am:
3388 * src/maemo/modest-osso-state-saving.c:
3389 * src/maemo/modest-osso-state-saving.h: Added
3390 modest_osso_load_state() and modest_osso_save_state() though they do
3391 nothing now. They should iterate through all the open windows and load/save
3393 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3394 save state when closing.
3396 * src/maemo/modest-main-window.c:
3397 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3398 Add a notification handler for the HildonProgram::is-topmost property,
3399 so we can allow hibernation when the application goes into the background.
3400 But we still need to detect when the accounts setup windows are open so
3401 we can stop hibernation when they are open.
3402 To do this, I also added the main window the HildonProgram. This might have
3403 other side-effects/benefits, and should maybe be done for other windows.
3405 * src/maemo/modest-osso-autosave-callbacks.h:
3406 * src/maemo/modest-osso-autosave-callbacks.c:
3407 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3408 though it does not do anything yet, and we might never need this to do
3409 anything. For instance, we already save drafts.
3411 * src/maemo/modest-platform.c: (modest_platform_init):
3412 Specify the libosso auto-save callback.
3414 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/modest-platform.c:
3417 (modest_platform_set_update_interval):
3418 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3419 aparently stays valid between application instances, so we can use this
3420 to remove and reset it later. According to a maemo-developers email from
3423 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3425 * configure.ac: Depend on libalarm for Maemo.
3427 * src/dbus_api/modest-dbus-api.h:
3428 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3429 (on_send_receive), (modest_dbus_req_handler):
3430 Handle a SEND_RECEIVE D-Bus method.
3432 * libmodest-dbus-client/libmodest-dbus-client.c:
3433 (libmodest_dbus_client_send_and_receive):
3434 * libmodest-dbus-client/libmodest-dbus-client.h:
3435 Add C convenience functions for calling the new D-Bus method.
3437 * src/modest-platform.h:
3438 * src/gnome/modest-platform.c:
3439 * src/maemo/modest-platform.c:
3440 Added modest_platform_set_update_interval(), which uses the
3441 alarmd API on Maemo.
3442 (modest_platform_init),
3443 Call modest_platform_set_update_interval(), using a hard-coded
3444 interval for now (until the global settings dialog is implemented),
3445 though I am not sure that this makes sense yet.
3447 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3449 * src/dbus_api/modest-dbus-callbacks.c:
3450 (modest_osso_cb_hw_state_handler):
3451 * src/dbus_api/modest-dbus-callbacks.h:
3452 * src/maemo/modest-platform.c: (modest_platform_init):
3453 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3454 in case this has some effect on the ability for Maemo to ping the
3457 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3459 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3460 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3461 warning. It is probably a logic error, but I need to fix the build.
3463 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3465 * src/modest-account-mgr.h:
3466 * src/modest-account-mgr.c:
3467 (modest_account_mgr_account_names): Add a gboolean enabled_only
3468 parameter, so we can get lists of onlt the enabled accounts.
3470 (modest_account_mgr_add_account),,
3471 (modest_account_mgr_account_with_display_name_exists):
3472 * src/maemo/modest-msg-edit-window.c: (get_transports):
3473 * src/modest-account-mgr-helpers.c:
3474 (modest_account_mgr_set_first_account_as_default):
3475 * src/modest-init.c: (init_default_account_maybe):
3476 * src/modest-tny-account-store.c: (get_accounts):
3477 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3478 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3479 * tests/check_account-mgr.c: (START_TEST):
3480 Provide the extra parameter, as appropriate.
3482 * src/widgets/modest-account-view.c: (update_account_view):
3483 Do not show disabled accounts (meaning that there is no way to
3484 enable/disable accounts in the UI (the feature is not in our UI
3485 specification), so we can use this internally only to mark unfinished
3486 or temporary account data.
3488 * src/maemo/easysetup/modest-easysetup-wizard.c:
3489 (create_account): Add boolean enable parameter, so we can specify FALSE
3490 to create the temporary account.
3491 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3492 (on_before_next): When finishing, when there is a temporary account, just
3494 Also, use a timeout to delay the showing of the dialog until gconf is likely
3495 to return correct information, due to a maemo gconf bug that is fixed in
3496 osso 1.1, but not yet in Bora.
3497 However, the dialog stays on screen after it is destroyed.
3499 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3500 for invalid data when cancelling. Use a hildon note instead of a dialog
3501 to complain about invalid data. Do not show the account-saved note if the
3502 account is disabled (a temporary account that will not really be saved for use
3505 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3507 * src/modest-account-mgr-helpers.h:
3508 * src/modest-account-mgr-helpers.c:
3509 Added modest_account_mgr_unset_default_account(),
3510 Added modest_account_mgr_set_first_account_as_default().
3512 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3513 If it was the default account, unset the default account name.
3515 * src/maemo/modest-account-view-window.c:
3516 (on_delete_button_clicked): If it was the default account,
3517 set the first remaining account as the default instead.
3519 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3520 a NULL account or a NULL default account, to prevent a crash. This should
3521 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3524 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3526 * src/widgets/modest-recpt-editor.c:
3527 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3528 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3529 TODO comment for this. This fixes the build.
3531 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3532 be the best place for it. This will in future update all auto-update accounts,
3533 rather than just the current/default account, when that gconf key exists.
3534 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3535 if there are no accounts, before calling do_send_receive().
3536 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3538 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3539 * src/maemo/modest-main-window-ui.h:
3540 * src/maemo/modest-main-window.c: (on_connection_changed),
3541 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3542 directly, becaue the signal handler does more.
3544 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3546 * src/modest-account-mgr-helpers.c:
3547 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3548 for the case that the account does not exist.
3550 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3551 (equivalent to the modest account name) rather than the tinymail account name
3552 (equivalent to the modest account title - human readable) to get the account data.
3553 Check for null account data to prevent the crash, and add a TODO comment saying that
3554 this needs fixing because it is using the server account name instead of the account name.
3556 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3558 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3559 * src/maemo/modest-account-settings-dialog.c: (show_error),
3561 Use hildon_note_new_information() for informative and error messages,
3562 which seems to be expected for Maemo applications (no documentation that I know of
3563 says this). I am surprised that there is no distinction between info and error
3566 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3568 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3569 it is easy to find where this is used.
3571 * src/maemo/easysetup/modest-easysetup-wizard.c:
3572 (create_page_welcome), (create_page_account_details),
3573 (create_page_user_details), (create_page_complete_easysetup),
3574 (create_page_custom_incoming), (create_page_custom_outgoing),
3575 (create_page_complete_custom):
3576 * src/maemo/modest-account-settings-dialog.c:
3577 (create_page_account_details), (create_page_user_details),
3578 (create_page_incoming), (create_page_outgoing):
3579 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3580 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3581 (modest_connection_specific_smtp_edit_window_init):
3582 * src/maemo/modest-connection-specific-smtp-window.c:
3583 (modest_connection_specific_smtp_window_init):
3584 * src/maemo/modest-signature-editor-dialog.c:
3585 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3586 and scrolling policy as per the Email Application Layout Guide, if I have
3589 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3592 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3593 which were empty, because these vfuncs have been removed from TnyAccountStore.
3594 This fixes the build.
3596 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3598 * src/maemo/modest-main-window.c:
3599 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3600 showing/hiding it. Added TODO because it probably should not be NULL.
3601 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3602 because unnecessary g_warnings() make degugging difficult.
3604 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3606 * src/maemo/modest-msg-edit-window.c:
3607 (modest_msg_edit_window_select_color),
3608 (modest_msg_edit_window_select_background_color): 2 const corrections and
3609 moving 2 #endifs before closing brackets, to fix the build.
3611 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3613 * src/maemo/easysetup/modest-easysetup-wizard.h:
3614 * src/maemo/easysetup/modest-easysetup-wizard.c:
3615 (modest_easysetup_wizard_dialog_finalize),
3616 (on_button_edit_advanced_settings), (create_page_complete_custom),
3617 (on_response), (create_account):
3618 Implement the Advanced Settings edit button, by saving the account information,
3619 for the Advanded Settings dialog to use directly from gconf, and removing it
3620 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3621 Bug #5533 in the projects.maemo.org bugzilla.
3623 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3625 * src/maemo/modest-msg-view-window.c:
3626 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3627 when opening a message window.
3629 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3631 * src/maemo/easysetup/modest-easysetup-wizard.c:
3632 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3635 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3636 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3637 gconf settings. I probably added more checks than necessary, but that is safer.
3639 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3640 variable to fix the build, but this seems to be used when it is still NULL.
3642 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3644 * src/modest-platform.h:
3645 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3646 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3647 * src/modest-main.c: Implement this function so we can avoid using
3648 maemo-specific API from cross-platform code.
3650 * src/modest-tny-account-store.c:
3651 (get_smtp_specific_transport_account_for_open_connection):
3652 * src/modest-ui-actions.c: (check_for_connection),
3653 (modest_ui_actions_on_item_not_found):
3654 Use modest_platform_connect_and_wait() and put #idefs around other
3655 maemo-specific code, because only maemo currently has a way to
3656 identify connection names.
3658 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3660 * src/modest-tny-account-store.h:
3661 * src/modest-tny-account-store.c:
3662 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3663 the connection-specific SMTP server settings in the configuration.
3665 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3667 * src/maemo/modest-main-window.c: (on_connection_changed),
3669 * src/modest-main.c: (main), (start_ui), (send_mail):
3670 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3671 that is what is intended.
3673 * src/modest-ui-actions.c: (action_send), (action_receive),
3674 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3675 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3676 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3677 SMTP server is used when it is specified.
3679 (modest_ui_actions_on_send_receive):
3680 Check that a connection is open before proceeding.
3681 Receive and then send, instead of vice-versa, as per the specification.
3683 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3685 * src/modest-mail-operation.c:
3686 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3687 though I guess it should be something other than NULL.
3689 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3691 * src/maemo/easysetup/modest-easysetup-wizard.c:
3692 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3693 combo twice, to avoid an g_warning and to make it visible again.
3694 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3695 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3696 (already intended) dereference when detaching, because we then recreate the menu.
3697 But I am not sure why the warning was happening, and it is possible that this is a memory
3700 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3702 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3703 and uri_parse_mailto() utility functions.
3704 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3706 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3708 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3710 * src/dbus_api/modest-dbus-api.h:
3711 * src/dbus_api/modest-dbus-callbacks.c:
3712 Use an idle callback to execute the modest code in the application's own thread.
3713 Remove the helloworld example method.
3714 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3715 parsed, and the open-message method is not implemented because this is not yet implemented in
3717 * libmodest-dbus-client/libmodest-dbus-client.c:
3718 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3719 (libmodest_dbus_client_open_message):
3720 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3722 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3723 body without crashing.
3725 * tests/dbus_api/Makefile.am:
3726 * tests/dbus_api/test_mail_to.c:
3727 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3729 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3731 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3732 Added file to fix the build. Sorry.
3734 * src/dbus_api/Makefile.am:
3735 * src/dbus_api/modest-dbus-api.h:
3736 * src/dbus_api/modest-dbus-callbacks.h:
3737 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3738 (modest_dbus_req_handler):
3739 Put constants in a separate header so it can be reused by the
3740 client library, without duplication
3742 * libmodest-dbus-client/Makefile.am:
3743 * libmodest-dbus-client/libmodest-dbus-client.c:
3744 (libmodest_dbus_client_call_helloworld),
3745 (libmodfest_dbus_client_send_mail),
3746 (libmodfest_dbus_client_mailto),
3747 (libmodfest_dbus_client_open_message):
3748 * libmodest-dbus-client/libmodest-dbus-client.h:
3749 (Partly) Implement a send_mail D-Bus method.
3751 * tests/dbus_api/Makefile.am:
3752 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3753 the send_email D-Bus method.
3755 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3759 * libmodest-dbus-client/Makefile.am:
3760 * libmodest-dbus-client/libmodest-dbus-client.c:
3761 * libmodest-dbus-client/libmodest-dbus-client.h:
3762 * tests/dbus_api/Makefile.am:
3763 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3764 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3766 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3768 * src/maemo/easysetup/modest-easysetup-wizard.c:
3769 (create_page_account_details):
3770 * src/maemo/modest-account-settings-dialog.c:
3771 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3772 widgets, because this might not be the default in future versions of the Maemo GTK+.
3773 However, I can not not get capitalization to work even in a simple test case.
3775 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3777 * src/maemo/easysetup/modest-easysetup-wizard.c:
3778 (create_page_custom_incoming), (create_page_custom_outgoing):
3779 * src/maemo/modest-account-settings-dialog.c:
3780 (create_page_account_details), (create_page_incoming),
3781 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3782 instead of using gtk_check_button_with_label(), so they are aligned like the other
3783 widgets, as per the UI spec.
3785 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3787 * src/maemo/easysetup/modest-easysetup-wizard.c:
3788 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3789 * src/widgets/modest-validating-entry.c:
3790 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3791 Modest prefix instead of an EasySetup prefix.
3793 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3795 * src/widgets/modest-validating-entry.h:
3796 * src/widgets/modest-validating-entry.c: (on_insert_text),
3797 Added easysetup_validating_entry_set_max_func(), used to set a callback
3798 to call when the max number of characters is reached. GtkEntry has a max-length
3799 already but is silent about it.
3801 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3802 (create_page_account_details), (create_page_user_details),
3804 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3805 (create_page_account_details), (create_page_user_details),
3806 (create_page_outgoing):
3807 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3808 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3809 the UI spec, when the user tries to enter more than the max number of characters.
3811 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3813 * src/maemo/easysetup/modest-easysetup-wizard.c:
3814 (create_page_user_details), (create_page_custom_incoming),
3815 (create_page_custom_outgoing):
3816 * src/maemo/modest-account-settings-dialog.c:
3817 (create_page_user_details), (create_page_incoming),
3818 (create_page_outgoing):
3819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3820 (modest_connection_specific_smtp_edit_window_init):
3821 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3822 not appropriate. Bad Maemo-specific defaults!.
3824 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3826 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3827 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3828 (modest_signature_editor_dialog_set_settings):
3829 Disable the label and textview when the checkbox is disabled, and use the
3830 specified (UI spec) default signature text.
3832 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3834 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3835 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3837 * src/modest-defs.h:
3838 * src/modest-account-mgr-helpers.h:
3839 * src/modest-account-mgr-helpers.c:
3840 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3842 * src/maemo/Makefile.am:
3843 * src/maemo/modest-signature-editor-dialog.c:
3844 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3847 * src/maemo/modest-account-settings-dialog.h:
3848 * src/maemo/modest-account-settings-dialog.c:
3849 (modest_account_settings_dialog_finalize), (on_button_signature),
3850 (save_configuration): Use the new dialog when the Edit button is pressed, and
3851 save the changes if necessary, as per the UI spec.
3853 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3855 * src/maemo/Makefile.am:
3856 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3857 based on maemo-develoers email from Dirk.
3859 * src/maemo/easysetup/modest-easysetup-wizard.c:
3860 (create_page_welcome), (create_page_account_details),
3861 (create_page_user_details), (create_page_complete_easysetup),
3862 (create_page_custom_incoming), (create_page_custom_outgoing),
3863 (create_page_complete_custom),
3864 (modest_easysetup_wizard_dialog_init):
3865 * src/maemo/modest-account-settings-dialog.c:
3866 (create_page_account_details), (create_page_user_details),
3867 (create_page_incoming), (create_page_outgoing),
3868 (modest_account_settings_dialog_init):
3869 * src/maemo/modest-connection-specific-smtp-window.c:
3870 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3872 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/easysetup/modest-easysetup-wizard.c:
3875 (create_page_account_details), (create_page_custom_outgoing),
3876 (create_page_complete_custom):
3877 * src/maemo/modest-account-settings-dialog.c:
3878 (create_page_user_details), (create_page_incoming),
3879 (create_page_outgoing):
3880 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3881 (modest_connection_specific_smtp_edit_window_init):
3882 Use the correct (UI spec) port min/max, and use horizontal separators,
3885 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/easysetup/modest-easysetup-wizard.c:
3888 (set_default_custom_servernames):
3889 * src/maemo/modest-account-settings-dialog.c:
3890 (create_page_incoming), (on_combo_outgoing_security_changed),
3891 (on_combo_incoming_security_changed), (create_page_outgoing),
3892 (modest_account_settings_dialog_set_account_name),
3893 (save_configuration):
3894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3895 (on_combo_security_changed),
3896 (modest_connection_specific_smtp_edit_window_init),
3897 (modest_connection_specific_smtp_edit_window_set_connection),
3898 (modest_connection_specific_smtp_edit_window_get_settings):
3899 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3902 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3905 * src/maemo/easysetup/modest-easysetup-wizard.c:
3906 (create_page_custom_outgoing), (create_page_complete_custom):
3907 * src/maemo/modest-account-settings-dialog.c:
3908 (create_page_user_details), (create_page_outgoing):
3909 * src/maemo/modest-account-view-window.c: (button_box_new):
3910 Use changed logical IDs as per the most recent UI spec:
3911 mcen_bd_emailsetup_edit -> mcen_bd_edit
3912 mcen_bd_emailsetup_delete -> mcen_bd_delete
3913 mcen_bd_emailsetup_close -> mcen_bd_close
3915 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3919 * src/dbus_api/Makefile.am:
3920 * src/dbus_api/modest-dbus-callbacks.c:
3921 * src/dbus_api/modest-dbus-callbacks.h:
3922 * src/maemo/modest-platform.c: (modest_platform_init):
3923 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3925 * tests/Makefile.am:
3926 * tests/dbus_api/Makefile.am:
3927 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3929 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3931 * src/maemo/modest-account-settings-dialog.c:
3932 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3933 Removed unnecessary includes.
3935 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3937 * src/maemo/easysetup/modest-easysetup-wizard.c:
3938 * src/maemo/modest-account-settings-dialog.c:
3939 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3940 * src/widgets/Makefile.am:
3941 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3942 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3943 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3944 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3945 * src/widgets/modest-secureauth-combo-box.c:
3946 * src/widgets/modest-secureauth-combo-box.h:
3947 * src/widgets/modest-serversecurity-combo-box.c:
3948 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3949 made the GObject names more consistent with the rest of the Modest code.
3951 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/easysetup/Makefile.am:
3954 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3955 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3956 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3957 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3958 * src/maemo/easysetup/modest-easysetup-wizard.c:
3959 * src/maemo/easysetup/modest-validating-entry.c:
3960 * src/maemo/easysetup/modest-validating-entry.h:
3961 * src/maemo/modest-account-settings-dialog.c:
3962 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3963 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3964 widgets/ because they are used outside of easysetup too. After checking in,
3965 svn will allow me to rename them too.
3967 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3969 * src/gnome/modest-msg-edit-window.c:
3970 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3971 linker error, to fix the build on the GNOME platform.
3972 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3973 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3974 ifdefed out to avoid a warning.
3976 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3978 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3979 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3980 some alternative for GTK+ 2.6.
3982 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3986 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3987 specified for EmailAccountsDialog in UI spec.
3989 * src/maemo/easysetup/modest-easysetup-wizard.c:
3990 * src/maemo/easysetup/modest-easysetup-wizard.h:
3991 * src/maemo/modest-account-settings-dialog.c:
3992 * src/maemo/modest-account-settings-dialog.h:
3993 Reuse a member window widget for the connection-specific SMTP server accounts,
3994 so we can tell it to create/save the accounts only if we actually save changes.
3996 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3998 (modest_connection_specific_smtp_edit_window_get_settings):
3999 Return a struct instance for temporarily remembering the entered data.
4001 * src/maemo/modest-connection-specific-smtp-window.h:
4002 * src/maemo/modest-connection-specific-smtp-window.c:
4003 (modest_connection_specific_smtp_window_finalize),
4004 (modest_connection_specific_smtp_window_fill_with_connections),
4006 (modest_connection_specific_smtp_window_save_server_accounts),
4007 (update_model_server_names): Do not actually save data until asked,
4008 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4010 (on_selection_changed),
4011 (modest_connection_specific_smtp_window_init): Disable the edit
4012 button when nothing is selected.
4014 * src/modest-account-mgr-helpers.c:
4015 * src/modest-account-mgr-helpers.h:
4016 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4019 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4021 * src/modest-account-mgr-helpers.h:
4022 * src/modest-account-mgr-helpers.c:
4023 (modest_account_mgr_get_unused_account_name),
4024 (modest_account_mgr_get_unused_account_display_name): Added these
4025 utility functions, to avoid code duplication.
4027 * src/maemo/easysetup/modest-easysetup-wizard.c:
4028 (create_page_account_details), (create_account):
4029 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4030 (on_combo_security_changed),
4031 (modest_connection_specific_smtp_edit_window_init),
4032 (modest_connection_specific_smtp_edit_window_save_settings):
4033 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4034 * src/maemo/modest-connection-specific-smtp-window.c:
4035 (modest_connection_specific_smtp_window_finalize),
4036 (modest_connection_specific_smtp_window_fill_with_connections),
4037 (on_button_edit), (modest_connection_specific_smtp_window_init):
4038 * src/maemo/modest-connection-specific-smtp-window.h:
4039 Implementing saving of connection-specific server accounts.
4041 But I need to refactor this so we can save the data for each
4042 possible connection-specific account and only actually create the server accounts
4043 when the easysetup finished, or the OK button is pressed on the account settings
4046 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4048 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4049 (on_combo_security_changed):
4050 (modest_connection_specific_smtp_edit_window_init):
4051 Auto-fill the port number as in the account settings.
4053 (modest_connection_specific_smtp_edit_window_set_connection):
4054 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4055 * src/maemo/modest-connection-specific-smtp-window.c:
4056 (fill_with_connections), (on_button_edit),
4057 (modest_connection_specific_smtp_window_init):
4058 Turn the edit window into a dialog to simplify the code, and
4059 set a WM hint as in a GtkDialog, because only a popup can be on top of
4060 another window in Maemo, and popups usually have no WM decoration.
4062 * src/modest-defs.h:
4063 * src/modest-account-mgr-helpers.c:
4064 (modest_account_mgr_set_connection_specific_smtp),
4065 (modest_account_mgr_remove_connection_specific_smtp),
4066 (modest_account_mgr_get_connection_specific_smtp):
4067 * src/modest-account-mgr-helpers.h: Some functions to write the
4068 connection-specific SMTP server information. Not yet used.
4071 * src/widgets/modest-folder-view.c: (text_cell_data):
4072 Fix a warning about an uninitialized variable.
4073 (on_configuration_key_changed): Put an #ifdef around the use
4074 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4076 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4078 * src/maemo/modest-account-settings-dialog.h:
4079 * src/maemo/modest-account-settings-dialog.c:
4080 Added connect_for_modified() utility function to mark the new modified boolean.
4082 (create_page_account_details), (create_page_user_details),
4083 (create_page_incoming), (create_page_outgoing), (on_response),
4084 (modest_account_settings_dialog_init),
4085 (modest_account_settings_dialog_set_account_name):
4086 Only warn about unsaved changes when there are actually unsaved changes.
4088 * src/modest-account-mgr-helpers.c:
4089 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4090 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4091 to get the data from there in future.
4093 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4095 * src/modest-defs.h:
4097 * src/modest-account-mgr-helpers.h:
4098 * src/modest-account-mgr-helpers.c:
4099 Store the security account setting in a single conf key instead of using
4100 the options list, so that the list is left for just the to-be-removed camel hack,
4101 and because gconf_client_set_list() is failing for some reason.
4103 * src/modest-account-mgr.c:
4104 (modest_account_mgr_add_server_account):
4105 * src/maemo/modest-account-settings-dialog.c:
4106 (modest_account_settings_dialog_set_account_name),
4107 (save_configuration): Use the renamed functions.
4110 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4112 * src/widgets/Makefile.am:
4113 * src/widgets/modest-limit-retrieve-combo-box.c:
4114 * src/widgets/modest-limit-retrieve-combo-box.h:
4115 * src/widgets/modest-retrieve-combo-box.c:
4116 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4117 the account settings dialog.
4119 * src/modest-defs.h:
4120 * src/modest-account-mgr-helpers.h:
4121 * src/modest-account-mgr-helpers.c:
4122 (modest_server_account_get_option_secure_auth),
4123 (modest_server_account_set_option_secure_auth):
4124 * src/modest-account-mgr.c:
4125 (modest_account_mgr_add_server_account):
4126 Use the existing AUTH_MECH conf key for the secure-auth setting,
4127 instead of putting it in the list options, because this was actually used already.
4129 * src/maemo/modest-account-settings-dialog.c:
4130 (create_page_account_details),
4131 (modest_account_settings_dialog_set_account_name),
4132 (save_configuration):
4133 * src/maemo/modest-account-settings-dialog.h:
4134 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4135 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4137 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4139 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4140 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4141 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4143 * src/modest-defs.h:
4144 * src/maemo/modest-account-settings-dialog.c:
4145 (create_page_incoming), (on_combo_outgoing_security_changed),
4146 (on_combo_incoming_security_changed), (create_page_outgoing),
4147 (modest_account_settings_dialog_set_account_name),
4148 (save_configuration): Load/Save the port number, and change it when the
4149 security combo changes, to suitable defaults.
4151 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4153 * src/modest-account-mgr.c:
4154 (modest_account_mgr_add_server_account): Set the security and secure-auth
4155 options, and add a comment saying that the other camel-specific options should be
4158 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4160 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4162 * src/modest-tny-account-store.c: (account_list_free),
4163 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4164 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4167 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4169 * src/modest-protocol-info.c:
4170 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4171 is required by our UI spec. Maybe something in our implementation will use this eventually.
4172 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4173 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4174 instead of the previous 0 placeholder.
4176 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4177 secure-auth settings.
4178 * src/modest-account-mgr-helpers.h:
4179 * src/modest-account-mgr-helpers.c:
4180 (modest_server_account_data_get_option_secure_auth),
4181 (modest_server_account_set_option_secure_auth),
4182 (modest_server_account_data_get_option_security),
4183 (modest_server_account_set_option_security): Added this API for getting and setting the security
4184 and secure-auth settings.
4186 * src/maemo/modest-account-settings-dialog.h:
4187 * src/maemo/modest-account-settings-dialog.c:
4188 (modest_account_settings_dialog_finalize), (check_data),
4189 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4190 about changing titles.
4191 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4192 (save_configuration): Save the security and secure-auth settings.
4194 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4195 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4197 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4199 * src/modest-defs.h:
4200 * src/modest-account-mgr.c:
4201 (modest_account_mgr_add_server_account):
4202 Added and used defines for the options key and value pair strings,
4203 that are used so far, though they do not seem to correspond to anything in our
4204 UI specs or ModestProtocol enum.
4206 * src/modest-account-mgr-helpers.h:
4207 * src/modest-account-mgr-helpers.c:
4208 (compare_option_strings_for_name),
4209 (modest_server_account_data_get_option_value),
4210 (modest_server_account_data_get_option_bool),
4211 (modest_account_mgr_get_server_account_option):
4212 Added helper functions for parsing the options GSList.
4214 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4216 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4217 display name is based on the supplied account name.
4218 * src/modest-account-mgr.c:
4219 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4220 with an inefficient, but good-enough, implementation.
4222 * src/maemo/easysetup/modest-easysetup-wizard.c:
4223 (create_page_account_details), (on_before_next), (create_account):
4224 Check for existing display names rather than (non-user-visible) account names, and just
4225 create and set a unique account name at the end.
4227 * src/maemo/modest-account-settings-dialog.c:
4228 (modest_account_settings_dialog_init),
4229 (modest_account_settings_dialog_set_account_name),
4230 (create_page_incoming): Show the display name, instead of the account name.
4231 (on_response): Do some (not all) extra checks, as in the UI spec.
4232 (save_configuration): Save the display name if it was changed.
4234 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4236 * po/en_GB.po: Added needed logical ID and translation.
4237 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4238 (init_view): Made the is-default column clicking work.
4240 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4243 * src/maemo/easysetup/Makefile.am:
4244 * src/maemo/easysetup/modest-easysetup-wizard.c:
4245 (modest_easysetup_wizard_dialog_init):
4246 * src/maemo/easysetup/provider-data-test.keyfile:
4247 * src/maemo/easysetup/provider-data.keyfile:
4248 Moved the provider data file to the new modest-providers-data package and used it from there.
4250 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4252 * src/modest-local-folder-info.c:
4253 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4254 N_() was already used on the static strings, but this just marks it for translation without
4255 using the translation.
4257 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4259 * src/maemo/modest-account-settings-dialog.c:
4260 (create_page_incoming),
4261 (modest_account_settings_dialog_set_account_name):
4262 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4263 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4264 I will do this if nobody else gets there first.
4266 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4268 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4269 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4270 save the security stuff.
4272 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4274 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4275 Set the email address and user fullname, which I now see must be
4278 * src/maemo/modest-account-settings-dialog.h:
4279 * src/maemo/modest-account-settings-dialog.c:
4281 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4282 leave-on-server and authentication.
4283 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4286 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4289 * src/maemo/modest-account-settings-dialog.c:
4290 * src/maemo/modest-account-settings-dialog.h:
4291 Most (but not all) of the widgets are now present as specified by the UI spec.
4292 No changes are yet saved, and some details are not properly shown yet.
4294 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4296 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4298 * src/maemo/Makefile.am:
4299 * src/maemo/modest-account-settings-dialog.c:
4300 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4301 an existing account. Doesn't do much yet.
4303 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4304 Open the accounts settings dialog when Edit is clicked.
4306 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4308 * src/maemo/easysetup/Makefile.am:
4309 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4311 * src/maemo/easysetup/modest-easysetup-wizard.c:
4312 (modest_easysetup_wizard_dialog_init):
4313 Try to get the source directory from the build system,
4314 instead of hard-coding "./" into the source code, when opening our local
4315 copies of the configuration files.
4316 But this still fails when opening the wizard from the Accounts window,
4317 maybe because the working directory seems to change at runtime.
4318 So the wizard will fail the second time unless you copy the files into their
4319 proper locations - see the stdout warnings for the paths.
4321 (create_page_account_details),(on_before_next):
4322 Check for existing non-server accounts instead of server accounts,
4323 so the default account name is useful again, and to prevent trying to
4326 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4327 Show the wizard when New is clicked.
4329 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4330 (init_view): Show the column headers, and show the columns that are
4331 specified in the UI specs. However, something in Maemo's GTK+ prevents
4332 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4333 change the default account. This is despite unsetting the special properties.
4335 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4337 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4338 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4339 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4340 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4341 to make that clearer.
4342 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4344 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4346 * src/maemo/modest-account-view-window.c:
4347 (modest_account_view_window_init),
4348 (modest_account_view_window_new):
4349 Use the same buttons as specified in the
4350 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4351 the existing widgets, which never had a chance of working.
4352 Put the ModestAccountView treeview in a scrolled window.
4353 Do not repeat the initialization in both _init() and _new().
4355 * src/widgets/modest-account-view.c: (update_account_view):
4356 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4357 this widget and window shows no accounts.
4359 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4361 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4363 * src/maemo/easysetup/modest-easysetup-wizard.c:
4364 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4365 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4366 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4369 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4370 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4371 accounts exist yet, as in the UI spec.
4373 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4375 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4377 * src/maemo/Makefile.am:
4378 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4379 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4380 New window for editing connection-specific smtp details.
4381 Not fully implemented.
4383 * src/maemo/modest-connection-specific-smtp-window.c:
4384 (modest_connection_specific_smtp_window_finalize) :
4385 unref the tree model.
4386 (on_button_edit): Show the edit window.
4388 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4390 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4393 * src/maemo/Makefile.am:
4394 * src/maemo/modest-connection-specific-smtp-window.c:
4395 * src/maemo/modest-connection-specific-smtp-window.h:
4396 New window for showing the list of connections, for connection-specific
4397 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4398 * src/maemo/easysetup/modest-easysetup-wizard.c:
4399 (create_page_custom_outgoing): Show the new window when the button is clicked.
4401 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4403 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4404 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4405 * src/maemo/modest-msg-edit-window.c:
4406 (modest_msg_edit_window_insert_image):
4407 * src/modest-conf.c: (modest_conf_key_escape):
4408 * src/modest-mail-operation.c:
4409 (modest_mail_operation_send_new_mail):
4410 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4411 (modest_ui_actions_on_new_account):
4412 * src/widgets/modest-attachment-view.c: (update_filename_request):
4413 * src/widgets/modest-mail-header-view.c:
4414 Corrected warnings that were breaking the build, by commenting out unused variables,
4415 and a function, and by including a header.
4417 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4419 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4420 so we can #ifdef around platform-specific code when necessary.
4421 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4422 to allow this to build for the GNOME platform too.
4424 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4426 * src/maemo/easysetup/modest-easysetup-wizard.c:
4427 Added util_increment_name() and used it in create_page_account_details()
4428 to make sure that the default account name is always a new name.
4430 (modest_easysetup_wizard_dialog_init),
4431 (set_default_custom_servernames): Some minor memory management fixes.
4433 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4437 * src/modest-runtime.c: (init_i18n): Restored the translation
4438 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4439 are defined in config.h, and the translations are installed.
4441 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4442 is defined for translation.
4444 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4446 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4448 * src/maemo/easysetup/modest-easysetup-wizard.c:
4449 (modest_easysetup_wizard_dialog_init):
4450 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4451 Use realistic paths (though they should use $prefix generically) to the
4452 mcc_mapping and provider-data.keyfile files which might work when they
4453 are installed by the future version of the operator-wizard package,
4454 and then fallback to paths in our source code, with an explanatory
4457 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4461 * src/maemo/Makefile.am:
4462 * src/maemo/easysetup/: Added files from the previously-exernal
4463 osso-modest-easysetup.
4464 * src/maemo/modest-main-window-ui.h:
4465 * src/modest-ui-actions.c:
4466 * src/modest-ui-actions.h:
4467 Added modest_ui_actions_on_new_account() as a signal handler for the
4468 New Account menu item. It shows the easysetup wizard.
4469 * po/en_GB.po: Added additional needed logical IDs and translations.