1 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/modest-connection-specific-smtp-edit-window.c:
5 (modest_connection_specific_smtp_edit_window_init):
7 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
10 2007-06-29 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-tny-account.c:
13 (modest_tny_account_new_from_server_account):
14 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
15 now uses to request a connection when it needs one, and which it uses
16 to tell us that something is wrong with the connection, so we can force
17 the accounts offline to prevent further problems.
20 * src/modest-init.c: (init_default_settings):
21 * src/modest-mail-operation.c:
22 (modest_mail_operation_update_account):
23 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
24 This should not be necessary anymore. Do not set the conf key that
25 determined this (it was always TRUE and not set anywhere else).
27 * src/modest-ui-actions.h: Remove unused and unimplemented
28 modest_ui_actions_on_online_toggle_toggled().
30 2007-06-29 Murray Cumming <murrayc@murrayc.com
32 * src/maemo/modest-main-window.c: (connect_signals):
33 Don't connect to delete_event twice. Maybe this was harmless.
35 2007-06-29 Murray Cumming <murrayc@murrayc.com
37 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
38 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
39 Debug output to give some more clue when a folder move is not allowed.
41 2007-06-28 Murray Cumming <murrayc@murrayc.com
43 * src/modest-tny-account.c: (on_modest_file_system_info),
44 (modest_tny_account_get_mmc_account_name):
45 Always call the callback, without checking whether the name has changed.
46 * src/widgets/modest-folder-view.c: (strings_are_equal),
47 (on_model_foreach_set_name), (on_get_mmc_account_name),
48 (text_cell_data): Compare the name here, and use the name from
49 the account rather than from the
50 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
51 if the name was changed after the account was added to the model.
52 That's a tinymail bug but not one that I want to fix now.
54 This finally fixes projects.maemo.org bug NB#59301.
56 2007-06-27 Armin Burgmeier <armin@openismus.com>
58 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
61 2007-06-27 Murray Cumming <murrayc@murrayc.com
63 * src/modest-tny-account.h:
64 * src/modest-tny-account.c:
65 Added modest_tny_account_get_mmc_account_name(), to set the memory
66 card name asynchronously for the given account and then notify.
67 (modest_tny_account_new_for_local_folders): Use this new function instead
68 of using hildon_file_system_info_async_new() directly.
70 * src/widgets/modest-folder-view.c: (text_cell_data):
71 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
72 gtk_tree_model_row_changed() when it is available.
74 This should fix projects.maemo.org bug NB#59301.
76 2007-06-27 Murray Cumming <murrayc@murrayc.com
78 * src/modest-mail-operation.c: (update_account_thread),
79 (get_msgs_full_thread): Fix typo failures in the revert
82 2007-06-27 Murray Cumming <murrayc@murrayc.com
84 * src/maemo/modest-maemo-global-settings-dialog.c:
85 (idle_select_default_focus):
86 * src/modest-mail-operation.c: (idle_notify_progress),
87 (idle_notify_progress_once), (set_last_updated_idle),
88 (update_account_thread), (get_msgs_full_thread):
89 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
90 * src/widgets/modest-header-view.c:
91 (idle_notify_headers_count_changed_destroy),
92 (idle_notify_headers_count_changed):
93 Reverted the additions of gdk_threads_enter/leave(), in case this
94 helps with a startup hang on the device.
96 2007-06-26 Armin Burgmeier <armin@openismus.com>
98 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
99 for supported secure authentication methods from server by
100 gtk_dialog_run(), saving CPU time and a potential race condition.
102 2007-06-26 Armin Burgmeier <armin@openismus.com>
104 * src/maemo/modest-maemo-utils.h:
105 * src/maemo/modest-maemo-utils.c: Added a
106 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
107 only error code to tell the calling code when the user canceled the
110 * src/maemo/modest-account-settings-dialog.h:
111 * src/maemo/modest-account-settings-dialog.c:
112 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
113 message if the retrieval of secure authentication methods was canceled
114 by the user. Perform the check before saving anything to configuration
115 to not end up with half-committed configuration changes, do not show
116 a "Saving to configuration failed" note when authentication methods
117 could not be retrieved.
119 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
122 2007-06-26 Murray Cumming <murrayc@murrayc.com>
124 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
125 Only return the first level of folders under accounts, because the
126 osso-global-search UI spec doesn't want the rest.
127 This fixed projects.maemo.org bug NB#61811.
129 2007-06-26 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-tny-account-store.c:
132 * src/modest-tny-account-store.h:
133 Added modest_tny_account_is_memory_card_account().
134 * src/maemo/modest-main-window.c: (create_details_widget):
135 Show the same information items for the memory card as we show for the
136 local-folders, to fix projects.maemo.org bug NB#59307.
138 2007-06-26 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-tny-account-store.c: (get_password):
141 Added some checks for NULL to maybe prevent crashes, though I think
142 it was Philip's last commit that actually prevented the crash here
143 when creating a first new account.
144 But the new account is still not usable (no messages are shown)
145 until a restart of the application.
147 2007-06-26 Murray Cumming <murrayc@murrayc.com>
149 * src/maemo/modest-maemo-global-settings-dialog.c:
150 (idle_select_default_focus):
151 * src/modest-mail-operation.c: (idle_notify_progress),
152 (idle_notify_progress_once), (idle_notify_update_account_queue),
153 (set_last_updated_idle), (update_account_thread),
154 (notify_get_msgs_full), (get_msgs_full_destroyer),
155 (get_msgs_full_thread):
156 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
157 * src/widgets/modest-header-view.c:
158 (idle_notify_headers_count_changed_destroy),
159 (idle_notify_headers_count_changed):
160 Use gdk_threads_enter() and gdk_threads_enter_leave() in
161 all idle handlers, because some other thread could be blocking
162 the GDK lock, so that it can do GUI stuff.
164 2007-06-26 Murray Cumming <murrayc@murrayc.com>
166 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
167 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
168 (on_idle_send_receive), (on_idle_open_default_inbox):
169 * src/maemo/modest-msg-edit-window.c:
170 (modest_msg_edit_window_attach_file_noninteractive):
171 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
172 to prevent a hang. I don't quite understand why these are necessary,
173 beause we should already be in the main loop. I guess something outside
174 of the main loop is taking the lock.
176 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
177 we are really using URIs, and use files that are more likely to exist.
179 2007-06-26 Murray Cumming <murrayc@murrayc.com>
181 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
182 necessary because configure.ac now defines different variables.
184 2007-06-26 Murray Cumming <murrayc@murrayc.com>
186 * libmodest-dbus-client/libmodest-dbus-client.c:
187 * libmodest-dbus-client/libmodest-dbus-client.h:
188 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
189 libmodest_dbus_client_compose_mail() is what things actually use.
191 * src/dbus_api/modest-dbus-api.h:
192 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
193 * tests/dbus_api/Makefile.am:
194 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
197 2007-06-26 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-init.c: (modest_init_local_folders):
200 For memory-card (or other non local-folders) maildir accounts,
201 always create an Archive folder, so that there is somewhere to put
202 messages. This should be less confusing, because the user does not need
203 to guess that the need to create a folder.
205 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
207 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
208 Fixed icon size by using (50, 50) which is the same as defined by
211 2007-06-25 Armin Burgmeier <armin@openismus.com>
213 * src/widgets/modest-window-mgr.c:
215 * configure.ac: Correctly recognize hildon-notify presence and fixed
216 the build without it being installed.
218 2007-06-25 Murray Cumming <murrayc@murrayc.com>
220 * libmodest-dbus-client/libmodest-dbus-client.c:
221 (libmodest_dbus_client_search): Fix the build. Sorry.
222 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
223 (reply_forward_cb): Initialize variables to fix the build.
225 * src/modest-tny-account-store.c:
226 (modest_tny_account_store_get_tny_account_by): Fix the account URI
227 comparison (a silly typo) so that email search results can be opened
228 when there are more than one account.
230 2007-06-25 Murray Cumming <murrayc@murrayc.com>
232 * libmodest-dbus-client/libmodest-dbus-client.c:
233 (libmodest_dbus_client_search),
234 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
235 instead of 1 second, because the search gets folders and messages from
236 the server, which can take a long time. When it times out,
237 osso-global-search will report no results.
239 We need to specify whether we should search only cached information
240 (maybe with a user preference), and the osso-email-search-plugin
241 API should really be improved to allow that option, and to allow results
242 to be delivered asynchronously in batches.
244 2007-06-25 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
247 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
248 GTK_ICON_SIZE_DIALOG is probably the wrong size.
250 2007-06-25 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
253 that is an empty string. D-Bus seems to give us these instead of NULL.
255 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
257 * src/dbus_api/modest-dbus-callbacks.c:
258 * src/maemo/easysetup/modest-easysetup-wizard.h:
259 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
261 (modest_connection_specific_smtp_edit_window_init):
262 * src/maemo/modest-maemo-global-settings-dialog.c:
264 * src/maemo/modest-maemo-utils.c:
265 (modest_maemo_utils_setup_images_filechooser):
266 * src/maemo/modest-main-window.c: (create_details_widget):
267 * src/maemo/modest-msg-edit-window.c:
268 (modest_msg_edit_window_attach_file_noninteractive),
269 (modest_msg_edit_window_color_button_change),
270 (modest_msg_edit_window_set_zoom):
271 * src/modest-mail-operation.c: (update_account_thread):
272 * src/modest-tny-account-store.c:
273 * src/modest-tny-account.c:
274 * src/widgets/modest-global-settings-dialog.c:
275 * src/widgets/modest-window.h:
279 2007-06-25 Murray Cumming <murrayc@murrayc.com>
281 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
282 * src/modest-search.c: (modest_search_folder),
283 (modest_search_all_accounts): Actually search only in the specified folder,
284 doing a simple match on the folder ID.
285 * src/modest-search.h: Added a folder field to the ModestSearch struct,
286 and added some documentation.
288 2007-06-22 Armin Burgmeier <armin@openismus.com>
290 * src/maemo/modest-maemo-utils.h:
291 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
292 modest_maemo_utils_get_supported_secure_authentication_methods.
294 * src/maemo/easysetup/modest-easysetup-wizard.c:
295 * src/maemo/modest-account-settings-dialog.c: Show correct error if
296 one occured, not just "Server does not support secure authentication".
298 2007-06-22 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-tny-account-store.c: (get_password):
301 Restored the call to tny_account_set_user() because Philip seems to have
302 stopped this from crashing (by not using the freed string). It still does
303 not work, but now we can test it.
305 2007-06-22 Murray Cumming <murrayc@murrayc.com>
307 * src/maemo/modest-msg-edit-window.c: (init_window):
308 Comment out use of an uninitialzed GtkScrolledWindow variable,
309 to fix the build and stop a crash. Yet again.
311 2007-06-22 Murray Cumming <murrayc@murrayc.com>
313 * src/modest-tny-account-store.c: (get_password):
314 Remove the call to tny_account_set_user() because this actually crashes.
315 As mentioned in the last commit, it is known to not work anyway.
317 2007-06-22 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-tny-account-store.c: (get_password):
320 Use tny_account_set_username() to tell tinymail that the username might
321 have changed too. But tinymail ignores this: see projects.maemo.org
323 * src/modest-ui-actions.c:
324 (modest_ui_actions_on_password_requested): Remove the useless attempt to
325 reset the connection when changing the username, and improve the comments.
326 Save the changed username to gconf at least, so it is used when Modest is
329 2007-06-21 Murray Cumming <murrayc@murrayc.com>
331 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
332 Do not use a query, so that we get all folders, including for POP and
333 local-folders. They work as search criteria too.
334 This fixes projects.maemo.org bug NB#57740.
336 2007-06-21 Murray Cumming <murrayc@murrayc.com>
338 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
339 Comment out the use of hildon_notification_set_sound() because it is
340 not declared, to fix the build. Warnings are serious, people.
342 2007-06-21 Armin Burgmeier <armin@openismus.com>
344 * src/maemo/modest-maemo-utils.h:
345 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
346 modest_maemo_utils_get_supported_secure_authentication_methods()
347 to query authentication methods for a specific user. This should fix
348 projects.maemo.org bug NB#61369.
350 * src/maemo/easysetup/modest-easysetup-wizard.c:
351 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
354 2007-06-21 Murray Cumming <murrayc@murrayc.com>
356 * libmodest-dbus-client/libmodest-dbus-client.h:
357 * libmodest-dbus-client/libmodest-dbus-client.c:
358 (modest_dbus_message_iter_get_search_hit),
359 (libmodest_dbus_client_search):
360 Reorganised and commented this.
361 Removed modest_search_hit_free() from the public API because it
364 Added libmodest_dbus_client_get_folders() and
365 modest_folder_result_list_free().
367 * src/dbus_api/modest-dbus-api.h:
368 * src/dbus_api/modest-dbus-callbacks.c:
369 (modest_dbus_req_filter): Commented. Moved most code to
370 on_dbus_method_search() and added on_dbus_method_get_folders().
372 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
373 of the extra D-Bus handler.
375 * tests/dbus_api/Makefile.am:
376 * tests/dbus_api/test_get_folders.c: New test for
377 libmodest_dbus_client_get_folders(). This seems to return an empty list
378 at the moment. That could be the same error that causes the message list
379 to be empty sometimes.
380 This should help with projects.maemo.org bug NB#57740.
382 2007-06-21 Armin Burgmeier <armin@openismus.com>
384 * src/modest-mail-operation.c: Do not call
385 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
386 notify the operation's end after having set the status to CANCELED for
387 the operation queue to listen on. This fixes a deadlock when there
388 were mail operations in the queue during its finalization.
390 * src/modest-singletons.c: Reordered uninitialization of the account
391 manager to happen after the mail operation queue was uninitialized
392 because the mail operation's in the queue might still try to access
393 the account manager (see modest_mail_operation_notify_end()). This
394 fixes a potential crash when terminating the application.
396 2007-06-21 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-search.c:
399 (search_mime_part_and_child_parts): Moved some code here so we
400 can search recursively in child folders.
401 (modest_search_folder): Search in the message as a mime part, instead
402 of just its child mime parts.
403 (read_chunk), (search_mime_part_ogs):
404 Check how many bytes were read, to prevent an endless loop.
405 Searching in message bodies now works. This finishes the fix for
406 projects.maemo.org bug NB#61007.
408 2007-06-20 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
411 Add a g_warning when the item is not a folder.
413 * src/modest-ui-dimming-rules.c:
414 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
415 when selected item is not a folder (for instance, an account), because
416 the UI spec only talks about folders.
417 I am not sure what the UI spec wants, so this might not totally fix
418 projects.maemo.org bug NB#60794.
420 2007-06-20 Murray Cumming <murrayc@murrayc.com>
422 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
423 (load_from_file): Sort the list. The unsorted list would be more noticeable
424 in non-English locales.
426 * src/maemo/modest-msg-edit-window.c:
427 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
428 warning and fix the build.
430 * src/maemo/modest-progress-bar-widget.c:
431 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
432 avoid a g_warning, and probably to avoid a crash.
434 2007-06-20 Murray Cumming <murrayc@murrayc.com>
436 * src/modest-search.c: (modest_search_folder): Check for a GError
437 when calling tny_folder_get_headers(), to show that this is not the cause
440 2007-06-20 Murray Cumming <murrayc@murrayc.com>
442 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
443 Actually set the body query instead of the subject query.
445 * src/modest-search.c: (search_mime_part_ogs),
446 (search_mime_part_strcmp): Remove extra space from the text/* regex,
447 which would probably cause it to fail if we got this far.
449 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
450 to simplify the code.
451 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
452 be causing search-in-body to fail.
454 2007-06-20 Murray Cumming <murrayc@murrayc.com>
456 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
458 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
459 Better debug message when the folder cannot be found.
460 This should help with fixing projects.maemo.org bug #61287.
461 * src/modest-search.c: (add_hit): Do not leak the furl string.
463 2007-06-20 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-ui-actions.c:
466 (modest_ui_actions_on_folder_selection_changed):
467 Do not special-case TNY_MERGE_FOLDER here, because
468 modest_tny_folder_get_account() already does that. This fixes
469 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
470 shown when the Outbox was selected).
472 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
474 * libmodest-dbus-client/libmodest-dbus-client.c:
475 (_dbus_iter_get_string_or_null): Initialize the string variable in
476 case this helps with Dirk's crash.
478 2007-06-19 Murray Cumming <murrayc@murrayc.com>
480 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
481 though it is not implemented yet (this function is maybe not even used),
482 to avoid breaking ABI in future.
483 * libmodest-dbus-client/libmodest-dbus-client.c:
484 (get_attachments_string): Moved some code into this generic function.
485 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
486 sends email. It is maybe not used.
487 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
488 (on_send_mail): Use attachments.
490 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
491 * src/maemo/modest-msg-edit-window.c:
492 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
493 a filename before using it, to fix projects.maemo.org bug NB#58233.
495 2007-06-19 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
498 Initialize the continue_download variable to fix the build, and probably
499 to fix randome behaviour.
501 2007-06-18 Armin Burgmeier <armin@openismus.com>
503 * src/modest-tny-send-queue.h:
504 * src/modest-tny-send-queue.c: Keep track of the status of messages in
505 the queue so we can later show it in the UI. Replaced
506 modest_tny_send_queue_msg_is_being_sent() by
507 modest_tny_send_queue_get_msg_status().
509 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
511 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
512 gpointer. This probably was not harmful, but just to be sure.
514 2007-06-18 Murray Cumming <murrayc@murrayc.com>
516 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
517 Fix the build, but leave the function broken on Bora, because
518 hildon_uri_action_get_service() does not exist.
519 osso_uri_action_get_service() does not exist either, it seems.
521 2007-06-18 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account.c:
524 (modest_tny_account_new_from_server_account):
525 Uncommented the url debug output again, because it is useful for
526 debugging, as I said in the comment.
528 2007-06-18 Murray Cumming <murrayc@murrayc.com>
530 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
532 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
533 for Mameo Bora, to fix the build.
535 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
538 Fixed build with hildon < 0.99
540 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
541 Check if the selected account is busy instead of checking all accounts
543 * src/modest-account-mgr-priv.h:
544 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
545 (modest_account_mgr_init), (compare_account_name),
546 (modest_account_mgr_set_account_busy),
547 (modest_account_mgr_account_is_busy):
548 * src/modest-account-mgr.h:
549 Added busy information to the account manager. It possible to
550 set an account to busy or not busy now.
552 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
553 (modest_mail_operation_update_account),
554 (modest_mail_operation_notify_end):
555 Set the account to busy/not busy depending on the operation state.
557 * src/widgets/modest-account-view.c:
558 (modest_account_view_finalize), (get_last_updated_string),
559 (update_account_view), (on_account_busy_changed), (init_view):
560 Show string "Refreshing..." if the account is currently busy.
562 All this fixes projects.maemo.org bug NB#59711
564 2007-06-14 Armin Burgmeier <armin@openismus.com>
566 * src/widgets/modest-attachments-view.h:
567 * src/widgets/modest-attachments-view.c: Added
568 modest_attachments_view_has_attachments() and fixed coordinate
569 transformation in get_att_view_at_coords(). This fixes attachment
572 * src/widgets/modest-msg-view.c: Make use of
573 modest_attachments_view_has_attachments() to decide whether to show
574 attachments in the header.
576 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
578 * src/maemo/modest-connection-specific-smtp-edit-window.c:
579 (on_change), (on_combo_security_changed),
580 (modest_connection_specific_smtp_edit_window_init),
581 (modest_connection_specific_smtp_edit_window_set_connection),
582 (modest_connection_specific_smtp_edit_window_is_dirty):
583 * src/maemo/modest-connection-specific-smtp-edit-window.h:
584 * src/maemo/modest-connection-specific-smtp-window.c:
587 Show an comfirmation dialog for the smpt-edit-window if there are
588 unsaved changes and the user hits cancel.
589 (projects.maemo.org bug NB#60479)
591 2007-06-14 Armin Burgmeier <armin@openismus.com>
593 * src/maemo/easysetup/modest-easysetup-wizard.c:
594 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
595 address" info in banner instead of node, and select all the text as
596 per UI spec. This fixes projects.maemo.org bug NB#60550.
598 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
600 reviewed by: <delete if not using a buddy>
602 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
603 * src/modest-ui-actions.c: (folder_refreshed_cb):
605 2007-06-14 Murray Cumming <murrayc@murrayc.com>
607 * src/widgets/modest-folder-view.c: (filter_row):
608 Explictly filter out the per-account outbox accounts. I don't know why
609 these only sometimes show up, but now they should never show up in the UI.
610 This should fix projects.maemo.org bug NB#60160.
612 2007-06-14 Murray Cumming <murrayc@murrayc.com>
614 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
615 when the toolbar does not exist yet.
616 * src/modest-widget-memory.c: (save_settings_header_view):
617 Added g_warnings() to help us to discover when we are trying to set
618 an empty columns list in gconf.
620 2007-06-14 Murray Cumming <murrayc@murrayc.com>
624 Added modest_init_get_default_header_view_column_ids().
626 * src/modest-widget-memory.c: (restore_settings_header_view):
627 Use the new function to get defaults, if the gconf key is empty,
628 instead of not creating any columns. This seems to fix the
629 empty right-hand pane problems.
631 * src/widgets/modest-header-view.h: Improved documentation.
633 2007-06-13 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
636 Revert the use of the display name as the account name, because this
637 is generally wrong and would break the code that follows.
639 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
641 * src/maemo/easysetup/modest-easysetup-wizard.c:
642 (check_for_supported_auth_methods), (on_before_next),
645 More correct fix for projects.maemo.org bug NB# 58991
646 Do not longer accept AUTH_PASSWORD as secure method and choose
647 correct method when creating the account.
649 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
651 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
652 Fixed projects.maemo.org bug NB# 58991
654 2007-06-13 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-init.c: (modest_init_init_core),
657 (modest_init_local_folders): Fixed compilation errors.
659 2007-06-13 Murray Cumming <murrayc@murrayc.com>
661 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
662 Remove unnecessary lib/include, though it is good in principle when needed.
664 * src/modest-init.c: (modest_init_one_local_folder),
665 (modest_init_local_folders):
666 * src/modest-init.h: Initialize the .modest library for memory cards,
667 instead of just doing nothing for them. This should allow us to create
668 folders there, fixing projects.maemo.org bug NB#59297.
670 2007-06-13 Murray Cumming <murrayc@murrayc.com>
672 * libmodest-dbus-client/libmodest-dbus-client.c:
673 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
674 (libmodest_dbus_client_compose_mail),
675 (libmodest_dbus_client_open_message),
676 (libmodest_dbus_client_send_and_receive),
677 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
679 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
680 (on_idle_open_message), (modest_dbus_req_handler),
681 (search_result_to_message), (modest_dbus_req_filter):
682 * src/modest-search.c: (add_hit), (modest_search_folder),
683 (modest_search_all_accounts): Improved debug messages.
685 * tests/dbus_api/test_open_message.c: (main): Improved comments.
687 * src/modest-tny-account-store.c:
688 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
691 2007-06-13 Murray Cumming <murrayc@murrayc.com>
694 2007-06-12 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-tny-account-store.c: (get_server_accounts):
697 Call modest_tny_local_folders_account_add_merged_outbox_folders()
698 even when there are no accounts, so that the Outbox folder is always
699 visible. This fixes projects.maemo.org bug NB#60158.
701 2007-06-12 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-main-window.c: (create_details_widget):
704 Use the mcen_va_never logical ID.
706 2007-06-12 Murray Cumming <murrayc@murrayc.com>
708 * src/dbus_api/modest-dbus-api.h:
709 * src/dbus_api/modest-dbus-callbacks.c:
710 (on_idle_open_default_inbox), (on_open_default_inbox),
711 (modest_dbus_req_handler):
712 Added a new OpenDefaultInbox method.
714 * libmodest-dbus-client/libmodest-dbus-client.h:
715 * libmodest-dbus-client/libmodest-dbus-client.c:
716 Added libmodest_dbus_client_open_default_inbox() to call the new
717 dbus method. This should be useful to projects.maemo.org bug NB#57214,
718 though it should maybe be used by a new osso-email-interface function.
720 * tests/dbus_api/Makefile.am:
721 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
724 2007-06-12 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
727 NULL, so that the signals get all the keys. This should not actually
728 change any behaviour because we currently update everything when anything
731 2007-06-12 Murray Cumming <murrayc@murrayc.com>
733 * src/widgets/modest-folder-view.c: (text_cell_data),
734 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
735 (find_inbox_iter): If tinymail tells us that the folder is
736 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
737 This causes the inbox to be selected at startup, fixing part of
738 projects.maemo.org bug NB#56305.
740 * src/modest-ui-dimming-rules.c:
741 (modest_ui_dimming_rules_on_tools_smtp_servers):
742 * src/modest-ui-dimming-rules.h: Added a callback function to dim
743 the SMTP servers menu item.
744 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
745 that the SMTP Servers menu item is dimmed when there are no accounts,
746 as a future version of the UI spec will require. This fixes
747 projects.maemo.org bug NB#56305.
749 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
751 * src/maemo/modest-maemo-utils.c:
752 (modest_maemo_utils_get_supported_secure_authentication_methods):
753 Added label to dialog instead of unreadable title
755 * src/maemo/modest-main-window.c: (sync_accounts_cb),
756 (modest_main_window_new):
757 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
760 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
761 * src/modest-account-mgr.h:
762 Added method to avoid code duplication
764 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
765 (modest_ui_actions_on_send_receive):
766 Use modest_account_mgr_has_accounts
768 2007-06-11 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/easysetup/modest-presets.c:
771 (modest_presets_get_info_server_security): Do not report secure auth
773 * src/modest-protocol-info.c: Use the defines for the gconf key names
774 for secure authentication. This was not working because we were writing
775 Password and reading password, and the check was case sensitive.
776 With this, gmail now works for receiving and sending when created via
779 2007-06-11 Murray Cumming <murrayc@murrayc.com>
781 * src/maemo/easysetup/modest-presets.c:
782 (modest_presets_get_info_server_security): Correct the key name for
783 SecureSmtp, because it seems to be case-sensitive.
784 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
785 Do not try to get the 0th notebook page if there are 0 pages, to
788 2007-06-11 Murray Cumming <murrayc@murrayc.com>
790 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
791 Prevent use of the new notification feature for now, because it currently
792 shows one dialog for each new email, which is annoying.
794 2007-06-11 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
797 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
798 when no country was selected, so that we show the global ones.
799 * src/maemo/easysetup/modest-presets.c:
800 (modest_presets_get_providers): Return only the global providers, not
801 all providers when mmc=0 was requested.
803 2007-06-11 Murray Cumming <murrayc@murrayc.com>
805 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
806 (easysetup_provider_combo_box_fill): Remove debug code that showed the
807 provider ID in the combo.
809 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
810 Do not show the page numbers, because it would be confusing when we add
811 the 2 extra pages for the custom setup, when the user chooses the "Other"
812 provider. This fixes projects.maemo.org bug NB#59028
814 * src/modest-init.c: (modest_init_init_core),
815 (modest_init_local_folders):
817 * src/modest-tny-account.c:
818 (modest_tny_account_new_for_local_folders): Do not create default folders
819 for the memory card. This should fix projects.maemo.org bug NB#59328.
821 2007-06-11 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
824 Free the changed_conf_keys string items. They are already freed in the
825 idle handler if that runs first.
827 2007-06-11 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-ui-actions.c:
830 (modest_ui_actions_on_password_requested): Check that the server name
831 is not NULL, because I just saw a password dialog with (null) as the
834 * src/modest-tny-folder.[h|c]: Added
835 modest_tny_folder_is_memory_card_folder().
836 * src/modest-ui-dimming-rules.c:
837 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
838 menu item for memory cards, as per the UI spec (section 7.4). This should
839 fix projects.maemo.org bug NB#59297.
841 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
843 * src/maemo/modest-main-window.c: (sync_accounts_cb):
844 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
845 is another problem with the code, see Murray's comment at line 772)
847 2007-06-08 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
850 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
851 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
852 (load_from_file), (easysetup_country_combo_box_init),
853 (easysetup_country_combo_box_get_active_country_ids),
854 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
855 instead of just one ID, to avoid duplicate country names in the UI.
857 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
858 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
859 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
860 a single ID, avoiding duplicate providers.
861 * src/maemo/easysetup/modest-easysetup-wizard.c:
862 (on_combo_account_country): Adapt to use a list.
864 2007-06-08 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
867 keys changed in the last X seconds.
869 * src/modest-account-mgr.h:
870 * src/modest-account-mgr.c: (on_timeout_notify_changes),
871 (on_key_change), (modest_account_mgr_class_init),
872 (modest_account_mgr_init), (modest_account_mgr_finalize):
873 As the keys are changed, save them in a GSList* and signal that GSList*
874 further every X seconds, to batch changes, to allow us to do just one
875 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
876 bug NB#56941 and other (UI-blocking) delays when changing account settings.
878 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
879 changed signal signature.
881 * src/modest-conf.c: (modest_conf_set_list),
882 (modest_conf_on_change): Reenable notification.
884 (modest_conf_maemo_fake_on_change): Comment out the hack that
885 notified immediately instead of asynchronously.
887 * src/widgets/modest-account-view.h:
888 * src/widgets/modest-account-view.c:
889 (update_account_view): Select the previously-selected account ID,
890 if possible. This fixes projects.maemo.org bug NB#56933.
892 (on_account_changed), (on_account_removed),
893 (modest_account_view_select_account):
895 Remove the block/unblock functions
896 because they were not useful.
898 * src/maemo/modest-account-view-window.c:
899 (on_delete_button_clicked), (on_edit_button_clicked),
900 (on_new_button_clicked): Remove the use of the non-working block/unblock.
902 2007-06-08 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
905 Improve the error dialog to show Incorrect Account Settings, which seems
906 clearer, and say that the internal error message (to be removed from the
907 dialog later) is often misleading.
908 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
910 * src/modest-tny-account.c:
911 (modest_tny_account_new_from_server_account): Uncomment the printf of the
912 URL because this is so useful for debugging on the device.
914 * src/widgets/modest-serversecurity-combo-box.c:
915 (modest_serversecurity_combo_box_fill): Correct a logical ID.
917 2007-06-08 Murray Cumming <murrayc@murrayc.com>
919 * src/modest-mail-operation.c:
920 (modest_mail_operation_send_new_mail):
921 Added a comment about a nasty but apparently harmless message. Details
922 added to the wiki g_warnings() page.
924 2007-06-08 Murray Cumming <murrayc@murrayc.com>
926 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
927 (modest_tny_send_queue_class_init):
928 Do not use the priv struct because it is empty, to avoid g_warnings
929 about a non-existant priv struct.
931 * src/modest-tny-account-store.c:
932 (modest_tny_account_store_get_server_account),
933 (modest_tny_account_store_get_transport_account_for_open_connection
934 ): Do not try to get transport server accounts for local folders,
935 because they don't have any. This avoids a g_warning().
937 * src/maemo/modest-main-window.c:
938 (modest_main_window_notify_send_receive_initied),
939 (on_configuration_key_changed):
940 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
942 * src/modest-mail-operation.c:
943 (modest_mail_operation_update_account):
944 * src/modest-tny-account-store.h:
945 * src/modest-tny-account.c:
946 (modest_tny_account_get_special_folder),
947 (modest_tny_account_new_for_local_folders),
948 (modest_tny_account_new_for_per_account_local_outbox_folder):
949 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
950 * src/modest-tny-local-folders-account.c:
951 (add_account_folders_to_merged_folder):
952 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
953 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
954 (modest_ui_actions_on_send):
955 * src/widgets/modest-folder-view.c: (update_model):
956 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
957 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
958 modest_tny_account_store_get_tny_account_by_account() to
959 modest_tny_account_store_get_server_account() to make the code clearer.
961 2007-06-07 Marcus Bauer <marcusb@openismus.com>
963 * src/dbus_api/modest-dbus-api.h:
964 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
965 * src/maemo/modest-msg-edit-window.c:
966 (modest_msg_edit_window_attach_file_noninteractive):
967 added g_warning in case the file to be attached does not exist
968 * tests/dbus_api/test_compose_mail.c: (main):
969 removed obsolete comment, added generic files as test case
971 2007-06-07 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-tny-account-store.c: (get_server_accounts):
974 Create the local folders account only once, not once for each outbox, and
975 not only when there are some outboxes.
977 2007-06-07 Murray Cumming <murrayc@murrayc.com>
979 * src/widgets/modest-folder-view.c: (update_model): Comment out some
980 code that is causing a crash at startup. Sergio says that he is fixing this.
982 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
984 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
985 * src/maemo/modest-account-settings-dialog.c:
986 (create_page_outgoing),
987 (modest_account_settings_dialog_set_account_name),
988 (save_configuration):
989 - Fixed handling of the "Use secure authentication" toggle to comply with
990 the ui specification. See also projects.maemo.org bug NB#58400
992 - Restore the Secure connection setting combo correctly when loading
995 * src/maemo/modest-maemo-utils.c:
996 (on_camel_account_get_supported_secure_authentication),
997 (modest_maemo_utils_get_supported_secure_authentication_methods):
998 Fixed a crasher if operation is canceled
1000 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1001 (modest_protocol_info_auth_is_secure):
1002 * src/modest-protocol-info.h:
1004 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1005 the sense of the "Use secure authentication" toggle.
1007 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.h:
1010 * src/modest-tny-account-store.c:
1011 Added modest_tny_account_store_get_local_folders_account().
1013 * src/modest-tny-folder.h:
1014 * src/modest-tny-folder.c:
1015 (modest_tny_folder_get_account):
1016 Added this replacement for tny_folder_get_account() which returns
1017 the local-folders account for TnyMergeFolders, to avoid the
1018 warning about the unimplemented get_account_func() vfunc().
1020 (modest_tny_folder_get_rules),
1021 * src/modest-ui-actions.c:
1022 (modest_ui_actions_on_folder_selection_changed):
1023 * src/modest-mail-operation.c:
1024 (modest_mail_operation_remove_folder),
1025 (modest_mail_operation_xfer_folder),
1026 (modest_mail_operation_rename_folder),
1027 (modest_mail_operation_get_msg),
1028 (modest_mail_operation_get_msgs_full),
1029 (modest_mail_operation_remove_msg),
1030 (modest_mail_operation_xfer_msgs),
1031 (modest_mail_operation_refresh_folder):
1032 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1034 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1036 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1037 (modest_server_account_set_security):
1038 * src/modest-defs.h: Add comments explaining that our
1039 UI spec means TLS when it says Normal, so these do not look like errors.
1041 * src/modest-tny-account.c:
1042 (modest_tny_account_new_from_server_account): Use the new tinymail
1043 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1044 for TLS. This should fix projects.maemo.org bug NB#58460.
1046 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1048 * src/maemo/easysetup/modest-easysetup-wizard.c:
1049 (create_account): Correct the position of the gconf sanity check warning.
1050 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1051 of using the g_idle_add() hack, because this does not seem to be necessary
1052 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1053 caused by something other than maemo's gconf.
1054 This fixes projects.maemo.org bug #59022.
1056 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-account-mgr-helpers.c:
1059 (modest_account_mgr_get_default_account): Do not check that the account
1060 exists if there is no default account (NULL), to fix a runtime warning.
1062 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1064 * src/widgets/modest-folder-view.c: (update_model):
1065 Do not unref the treemodel before we have finished with it.
1066 This prevents a valgrind warning and an occasional crash at startup.
1068 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1070 * libmodest-dbus-client/libmodest-dbus-client.h:
1071 added libmodest_dbus_client_compose_mail()
1072 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1074 added functions needed for SendAsMail() functionality
1075 * src/maemo/modest-msg-edit-window.c:
1076 (modest_msg_edit_window_attach_file_noninteractive):
1077 non interactively attaching files to message edit window
1078 * src/widgets/modest-msg-edit-window.h:
1079 * tests/dbus_api/Makefile.am:
1080 added test_compose_mail.c
1081 * tests/dbus_api/test_compose_mail.c: (main):
1083 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1085 * src/modest-account-view.c:
1086 Fixed bug projects.maemo.org bug NB#59307
1088 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1090 * src/maemo/easysetup/modest-easysetup-wizard.c:
1091 (get_serverport_incoming), (on_before_next), (create_account):
1092 * src/maemo/modest-account-settings-dialog.c:
1093 (modest_account_settings_dialog_set_account_name):
1094 * src/maemo/modest-maemo-utils.c:
1095 (on_camel_account_get_supported_secure_authentication_status),
1096 (on_camel_account_get_supported_secure_authentication),
1097 (on_secure_auth_cancel),
1098 (modest_maemo_utils_get_supported_secure_authentication_methods):
1100 Implemented security authentication for settings and easysetup.
1102 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1104 * src/maemo/modest-main-window.c: (create_details_widget):
1105 Show the total size for memory card accounts too, instead of showing
1106 the name again. Fixes bug projects.maemo.org bug NB#59307.
1108 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1111 * src/modest-tny-simple-folder-store.c:
1112 * src/modest-tny-simple-folder-store.h: Removed.
1114 * src/modest-tny-local-folders-account.h
1115 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1116 for the local-folders maildir, with an extra TnyMergedFolder containing
1117 the folders of the per-account outbox store accounts.
1118 * src/modest-tny-account-store.c: (get_server_accounts):
1119 Add the outboxes to the special local folders account after creating it.
1121 * src/modest-tny-account.c:
1122 (modest_tny_account_new_for_local_folders): Create the derived
1123 account when creating the main local-folders account.
1125 * src/maemo/modest-main-window.c: (create_details_widget),
1126 (modest_main_window_set_contents_style):
1127 Adapted to the use of the derived account instead of the folder store.
1129 * src/modest-ui-actions.c:
1130 (modest_ui_actions_on_folder_selection_changed):
1131 * src/modest-ui-dimming-rules.c:
1132 (modest_ui_dimming_rules_on_new_folder):
1133 * src/widgets/modest-folder-view.c: (text_cell_data),
1134 (icon_cell_data), (filter_row), (update_model),
1135 (get_cmp_rows_type_pos):
1138 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1139 Do not get the priv struct, because no priv struct has been set,
1140 to avoid a runtime warning.
1142 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1143 #ifelse with #else, to fix a warning, to fix the build.
1146 2007-06-05 Christian Kellner <ckellner@openismus.com>
1148 * libmodest-dbus-client/libmodest-dbus-client.c:
1149 Fix small typo in doc (why do you always see them
1150 AFTER committing stuff?)
1153 2007-06-05 Christian Kellner <ckellner@openismus.com>
1155 * libmodest-dbus-client/libmodest-dbus-client.c:
1156 (libmodest_dbus_client_search):
1157 Initialize hit list with NULL. Also set folder list
1158 to "" if NULL was supplied.
1161 2007-06-03 Christian Kellner <ckellner@openismus.com>
1163 * libmodest-dbus-client/libmodest-dbus-client.c:
1164 (modest_search_hit_list_free):
1165 Make it save to call it with NULL.
1167 * src/dbus_api/modest-dbus-callbacks.c:
1168 * src/modest-search.c:
1169 Return full ModestSearchHits as the search result list not TnyHeader
1170 since can't be around withouth the correspoding TnyFolder.
1172 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1174 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1175 Added currently commented code to check for secure auth
1177 * src/maemo/modest-account-settings-dialog.c: (on_response),
1178 (save_configuration), (show_ok):
1179 Fixed projects.maemo.org bugs NB #59248 and #59251
1181 * src/maemo/modest-maemo-utils.c:
1182 (on_camel_account_get_supported_secure_authentication_status),
1183 (on_camel_account_get_supported_secure_authentication),
1184 (modest_maemo_utils_get_supported_secure_authentication_methods):
1185 * src/maemo/modest-maemo-utils.h:
1186 Moved get_supported_secure_authentication() method here to be able
1187 to use it from easysetup wizard.
1189 * src/modest-pair.c: (on_pair_compare_as_string):
1190 Should compare string with first part of pair and not
1191 strcmp pairs which will crash.
1193 * src/modest-protocol-info.c:
1194 (modest_protocol_info_protocol_is_store):
1195 * src/modest-protocol-info.h:
1196 Added modest_protocol_info_get_auth_protocol_name()
1198 2007-06-03 Armin Burgmeier <armin@openismus.com>
1200 * src/modest-mail-operation.c:
1201 (modest_mail_operation_get_msgs_full): Set priv->account also when
1202 only retrieving a single message. This avoids a crash when canceling
1205 (modest_mail_operation_notify_end): Do not explicitely remove the
1206 operation from the queue but only emit the progress_changed signal.
1207 The queue itself listens to that signal to remove the operation when
1208 it is finished. This reduces coupling and removes a potential deadlock
1209 when modest_mail_operation_notify_end() is called from the queue
1210 itself. If that is a problem performance-wise, I would suggest to
1211 implement a status-changed signal or something.
1213 * src/modest-mail-operation-queue.c: Make sure to never call a
1214 function from another file while the queue is locked. This (hopefully)
1215 fixes another deadlock when exiting the application while retrieving
1218 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1220 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1221 Fixed build if libogs is not available
1223 2007-06-03 Christian Kellner <ckellner@openismus.com>
1225 * libmodest-dbus-client/libmodest-dbus-client.h:
1226 * libmodest-dbus-client/libmodest-dbus-client.c:
1227 (libmodest_dbus_client_delete_message):
1228 Implement deletion of messages (Client side).
1230 (modest_search_hit_free),
1231 (modest_search_hit_list_free):
1232 Utility functions to free the result hits.
1234 * src/dbus_api/modest-dbus-api.h:
1235 * src/dbus_api/modest-dbus-callbacks.c:
1236 (on_delete_message),
1237 (modest_dbus_req_handler):
1238 Implement deletion of messages (Server side).
1240 * tests/dbus_api/test_search.c: (main):
1243 * tests/dbus_api/Makefile.am:
1244 * tests/dbus_api/test_delete_message:
1245 Add little test for the message deletion logic
1247 2007-06-03 Armin Burgmeier <armin@openismus.com>
1249 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1250 when the operation queue was not empty. projects.maemo.org bug
1253 2007-06-03 Armin Burgmeier <armin@openismus.com>
1255 * src/widgets/modest-account-view.c
1256 (on_account_default_toggled): Toggle default account column
1257 explicitely instead of waiting for gconf notification (which is
1258 currently ignored). This should fix projects.maemo.org bug NB#56910
1259 for now. It should probably be removed when gconf notifications are
1262 2007-06-03 Christian Kellner <ckellner@openismus.com>
1264 * libmodest-dbus-client/libmodest-dbus-client.c:
1265 Removed debugging spew.
1267 * src/dbus_api/modest-dbus-callbacks.c:
1268 Added debugging info.
1270 * src/modest-search.c:
1271 (modest_search_all_accounts):
1272 Use tny_account_store_get_accounts () on the account store
1273 to get all accounts which is the way to get all accounts.
1275 * tests/dbus_api/test_search.c: (main):
1276 Make it possible to supply the search term on the command line.
1278 2007-06-03 Christian Kellner <ckellner@openismus.com>
1280 * libmodest-dbus-client/libmodest-dbus-client.c:
1281 * libmodest-dbus-client/libmodest-dbus-client.h:
1282 Implement searching for mesages over raw dbus. (Client side)
1284 * src/dbus_api/Makefile.am:
1285 * src/dbus_api/modest-dbus-api.h:
1286 * src/dbus_api/modest-dbus-callbacks.c:
1287 * src/dbus_api/modest-dbus-callbacks.h:
1288 Search framework (Server side). Also implement on_idle_open_message().
1290 * src/maemo/modest-platform.c: (modest_platform_init):
1291 Prepare for raw dbus/osso rpc interaction.
1293 * src/modest-search.h:
1294 Changed minsize from unspecific guint to guint32.
1296 * src/modest-search.c:
1298 Added strange hack which magically made tnymail work.
1300 (modest_search_folder),
1301 (modest_search_account),
1302 (modest_search_all_accounts):
1303 Implement helper functions to search all accounts, specific account
1306 * tests/dbus_api/Makefile.am:
1307 * tests/dbus_api/test_open_message.c:
1308 Read url to open from commandline.
1310 * tests/dbus_api/test_search.c:
1311 Implement small test for dbus search stuff
1313 2007-06-02 Armin Burgmeier <armin@openismus.com>
1315 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1316 include account type and account title. This fixes projects.maemo.org
1319 * src/maemo/modest-account-view-window.c: Set a title for the window.
1321 2007-06-02 Armin Burgmeier <armin@openismus.com>
1323 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1324 incoming and outgoing server name based on email address and server
1325 types as long as the names have not been edited manually. This fixes
1326 projects.maemo.org bug NB#58671.
1328 2007-06-02 Armin Burgmeier <armin@openismus.com>
1330 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1331 server type cannot be changed in future to the incoming details page
1332 when creating an account. This fixes projects.maemo.org bug NB#59029.
1334 2007-06-02 Armin Burgmeier <armin@openismus.com>
1336 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1337 and assigned max width chars so that they wrap instead of being
1338 truncated. Fixes projects.maemo.org bug NB#56126.
1340 2007-06-02 Armin Burgmeier <armin@openismus.com>
1342 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1343 introductory note to the connection specific smtp servers dialog, as
1344 section 8.12 of the email UI specification requires. This fixes
1345 projects.maemo.org bug NB#59212.
1347 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1350 Check for running mail operations, and offer to cancel them, as per the UI
1351 spec. This fixes projects.maemo.org bug NB#59041 .
1352 However, I suspect that tinymail may still use the network connection
1353 in ways that we cannot detect or cancel. But it should at least adapt to
1354 changes fairly well.
1356 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-tny-account-store.c: (recreate_all_accounts),
1359 (get_cached_accounts), (get_server_accounts): Do more sensible
1360 ref-counting of the temporarily-cached outbox accounts list. This seems
1361 to fix a crash when entering the password when the password was wrong.
1363 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1365 * src/gnome/modest-main-window.c: (connect_signals):
1366 * src/modest-tny-account-store.c: (get_password),
1367 (modest_tny_account_store_alert): Added comments and clues and
1368 commented-out code about how we currently fail to deal with connection
1369 errors and wrong passwords, and how we should.
1371 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1373 * src/widgets/modest-retrieve-combo-box.c:
1374 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1375 This fixes projects.maemo.org bug NB#58472 .
1377 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/easysetup/modest-easysetup-wizard.c:
1380 (create_page_complete_easysetup):
1381 (create_page_complete_custom): Correct the last commit,
1382 putting the correct sentences in the correct pages.
1384 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1386 * src/maemo/easysetup/modest-easysetup-wizard.c:
1387 (create_page_complete_custom): Show the second sentence of text
1388 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1391 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1394 Set the leave-on-server conf key by default. This fixes
1395 projects.maemo.org bug NB#59258 .
1397 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1399 * src/maemo/modest-account-view-window.c:
1400 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1401 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1404 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1406 * src/maemo/easysetup/modest-easysetup-wizard.c:
1407 (create_caption_new_with_asterisk):
1408 * src/maemo/modest-account-settings-dialog.c:
1409 (create_caption_new_with_asterisk):
1410 Uncomment the code to add the asterisk, because they are no longer in the
1411 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1412 (update_incoming_server_title): Add an asterisk here too.
1414 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1416 * src/maemo/modest-maemo-global-settings-dialog.c:
1417 (current_connection): Check that we are even connected before trying to
1418 get the current connection name, to prevent a warning.
1420 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1421 Change the comments because tny_maemo_conic_device_connect() is now meant to
1423 * src/modest-mail-operation.c:
1424 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1425 make sure we have a connection and fail if we can't connect.
1427 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/modest-main-window.c:
1430 (on_account_store_connecting_finished): Do not try to get the
1431 connection ID if we are not really connected. I am surprised that
1432 this signal handler is called when we are not connected.
1434 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-error.h:
1437 * src/modest-ui-actions.c:
1438 (modest_ui_actions_get_msgs_full_error_handler):
1439 Renamed an enum, added comments, added an enum
1440 for retrieve-limit errors.
1442 * src/modest-mail-operation.c: (foreach_add_item),
1443 (internal_folder_observer_update), (update_account_thread),
1444 (modest_mail_operation_get_msgs_full):
1445 (modest_mail_operation_update_account),
1446 Added comments about how this works, and some code that should
1447 (but does not) check the retrieve-limit. See the TODO comment.
1449 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1452 Initialize help_id to fix the build. Warnings are good.
1454 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1456 * src/widgets/modest-hbox-cell-renderer.c:
1457 (modest_hbox_cell_renderer_append):
1458 * src/widgets/modest-vbox-cell-renderer.c:
1459 (modest_vbox_cell_renderer_append):
1460 Fix the last commit by doing an extra ref.
1462 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1464 * src/widgets/modest-hbox-cell-renderer.c:
1465 (modest_hbox_cell_renderer_append):
1466 * src/widgets/modest-vbox-cell-renderer.c:
1467 (modest_vbox_cell_renderer_append):
1468 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1469 to fix the build with Maemo Bora.
1470 However, there seems to be a remaining crash, probably due to reference
1473 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-tny-account.c:
1476 (modest_tny_account_new_for_local_folders):
1477 Use hildon_file_system_info_async_new() to get a better name for
1478 the memory card account, setting it as the account name.
1479 The timing seems to work, but this is probably
1480 not the best place to do this. See the TODO comment.
1481 * src/maemo/modest-main-window.c: (create_details_widget):
1482 * src/widgets/modest-folder-view.c: (text_cell_data):
1483 Use the tny account name instead of hardcoding a name.
1485 2007-05-30 Christian Kellner <ckellner@openismus.com>
1487 * src/modest-search.c: (modest_search):
1488 Correctly set part_search_func even if we have already parsed
1489 the query and thus a valid OgsTextSearcher object.
1491 2007-05-30 Christian Kellner <ckellner@openismus.com>
1494 Search and check for libogs.
1497 Incooparte the ogs build env.
1499 * src/modest-mime-part-search-stream.c:
1500 * src/modest-mime-part-search-stream.h:
1501 Removed since we do the real searching now in modest-search.c.
1503 * src/modest-search.c:
1504 * src/modest-search.h:
1505 Implement support for ogs. We use that if available and requested
1506 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1507 should now handle the corner case when the search term is spread
1508 across multiple reads.
1509 Also the logic in modest_search () was corrected to search all
1510 requested fields until one is found.
1512 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1516 * src/modest-init.h:
1517 * src/modest-init.c: Made modest_init_local_folders() take a
1518 path and be public so we can iniitialize maildir folders on
1521 * src/modest-local-folder-info.h:
1522 * src/modest-local-folder-info.c:
1523 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1525 * src/modest-tny-account.c:
1526 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1527 still means the standard local-folders path on the local volume.
1529 * src/modest-tny-account-store.c:
1530 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1531 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1532 all accounts when that happens.
1533 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1534 this too, so it shows up in the treeview.
1536 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1538 * src/maemo/modest-maemo-global-settings-dialog.c:
1539 (current_connection):
1540 * src/widgets/modest-global-settings-dialog.c:
1541 (current_connection_default):
1542 Use the enum values instead of 0, 1 and -1,
1543 to make the code clearer.
1545 * src/modest-account-mgr-helpers.c:
1546 (modest_account_mgr_get_connection_specific_smtp): Make this code
1549 * src/modest-runtime.h:
1550 * src/modest-runtime.c:
1551 Added modest_runtime_remove_all_send_queues().
1552 * src/maemo/modest-main-window.c:
1553 (on_account_store_connecting_finished): Recreate the send queues,
1554 using the appropriate transport accounts for this new connection.
1555 Some futher adapting might be needed if the old send queues are not
1556 automatically stopped at this point.
1558 * src/modest-tny-account-store.c: (get_server_accounts):
1559 Create the connection-specific transport accounts, so that they can
1560 be found later by their ID.
1562 * src/modest-tny-account.h:
1563 * src/modest-tny-account.c:
1564 Added modest_tny_account_new_from_server_account_name().
1565 modest_tny_account_new_from_server_account(): Do not create the
1566 send queues here, because they will be
1567 recreated anyway when the connection changes for the first time.
1569 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-local-folder-info.h:
1572 * src/modest-local-folder-info.c:
1573 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1574 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1575 tbox_folder): Take a modest account name instead of a server TnyAccount,
1576 so we can have per-modest-account rather than per-transport-account
1578 We must make sure that we change or recreate the exisitng send queues
1579 when the connection changes for connection-specific transport accounts.
1581 * src/modest-tny-account-store.c:
1582 (create_per_account_local_outbox_folders): Create outboxed per modest
1583 account, not per transport account.
1585 * src/modest-tny-account.h:
1586 * src/modest-tny-account.c:
1587 (modest_tny_account_get_special_folder): For outboxes, get the
1588 parent modest account name. The account is ignored for other folders.
1589 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1590 modest account name rather than a server TnyAccount.
1592 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-tny-account.c:
1595 (modest_tny_account_new_from_server_account):
1596 Call modest_runtime_get_send_queue() immediately after creating transport
1597 accounts, so that they start trying to send email from the outbox as soon
1598 as possible at startup. This is probably what we want.
1600 * src/modest-mail-operation.c: (update_account_thread):
1601 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1602 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1603 * src/modest-tny-send-queue.h:
1604 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1605 (modest_ui_actions_on_send):
1606 Added comments about how sending works, though it needs some more work.
1608 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1610 * src/modest-tny-account.c:
1611 (modest_tny_account_get_special_folder): Add TODO because this fails when
1612 the network is busy.
1613 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1614 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1615 Do not try to show this window when there is no active account. The UI
1616 specs does not tell us what to do in this case.
1618 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/Makefile.am:
1623 * src/widgets/Makefile.am: Some dist fixes.
1625 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1627 * src/maemo/modest-connection-specific-smtp-window.c:
1628 (on_button_edit): Make the code clearer, to prevent a double free.
1630 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/modest-account-settings-dialog.c:
1633 (modest_account_settings_dialog_set_account_name),
1634 Check the connection-specific smtp servers checkbox if there are any.
1636 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1637 (modest_connection_specific_smtp_edit_window_init):
1638 Start with a suitable port number.
1640 * src/modest-account-mgr-helpers.h:
1641 * src/modest-account-mgr-helpers.c: Added
1642 modest_account_mgr_get_has_connection_specific_smtp().
1644 (modest_account_mgr_set_connection_specific_smtp),
1645 (modest_account_mgr_remove_connection_specific_smtp),
1646 (modest_account_mgr_get_has_connection_specific_smtp),
1647 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1648 connection-specific smtp server accounts in the account, rather than
1649 the server account conf dir.
1651 This fixes bug projects.maemo.org bug NB#58263 .
1653 * src/modest-tny-account-store.c:
1654 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1655 if there are no server accounts yet, to prevent an infinite loop when there
1656 are no accounts. Document that one must be called before the other.
1658 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1660 * src/modest-account-mgr-helpers.c:
1661 (modest_account_mgr_get_default_account): Make sure that at least
1662 one account is always the default, if there are any enabled accounts.
1663 This is just a sanity check that shouldn't be necessary.
1665 * src/modest-account-mgr-priv.c:
1666 (_modest_account_mgr_account_from_key): Unescape the conf key to
1667 get the real account name. For instance, this is an issue if a space
1668 was in the account name, which can happen because the account name
1669 is generated from the display name.
1670 (_modest_account_mgr_get_account_keyname): Always escape the
1672 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1673 Unescape the conf keys to get the real account names.
1675 For instance, previously the is-default radio button in the accounts
1676 list was not checked for any accounts at first. This fixes that,
1677 and might fix several similar bugs.
1679 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1682 Removed some debug printfs.
1684 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1686 Modest on-disk outbox directories are now here, for instance:
1687 $HOME/.modest/outboxes/<account-id-1>/outbox
1688 $HOME/.modest/outboxes/<account-id-2>/outbox
1690 $HOME/.modest/local-folders/outbox
1691 so we can have a separate outbox for each account.
1692 But they are shown as one outbox in the GtkTreeView, by using a
1693 TnyMergeFolder in a ModestTnySimpleFolderStore.
1696 * src/modest-tny-simple-folder-store.c:
1697 * src/modest-tny-simple-folder-store.h:
1698 Added ModestTnySimpleFolderStore, used to contain folders from
1699 other folder stores, such as other accounts.
1701 * src/modest-tny-outbox-account.h:
1702 * src/modest-tny-outbox-account.c:
1703 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1704 used for the per-account local outbox folders.
1706 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1707 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1708 only use this (internally) now for the non-outbox local folders.
1710 * src/modest-init.h:
1711 * src/modest-init.c: Added modest_init_one_local_folder(), for
1712 setting up the directory structure for each local folder.
1714 * src/modest-local-folder-info.c:
1715 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1716 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1718 * src/modest-local-folder-info.h:
1719 * src/modest-tny-account-store.c: (on_account_removed),
1720 (on_account_changed), (create_per_account_local_outbox_folders),
1721 (get_server_accounts), (modest_tny_account_store_get_accounts),
1722 (modest_tny_account_store_get_tny_account_by_account),
1723 (modest_tny_folder_store_is_virtual_local_folders):
1725 * src/modest-tny-account.h:
1726 * src/modest-tny-account.c:
1727 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1728 to create an on-disk per-account local outbox folder for each
1730 (create_per_account_local_outbox_folders): Create a local outbox folder
1731 for each transport account.
1732 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1733 for all local folders.
1735 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1736 instead of using g_object_get/set() directly. It is clearer.
1738 (modest_tny_folder_store_get_message_count),
1739 (modest_tny_folder_store_get_local_size
1740 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1741 because we now use these with non-acount folder stores.
1743 (modest_tny_account_get_special_folder),
1744 (modest_tny_account_new_from_server_account),
1745 (modest_tny_account_new_from_account):
1746 (recurse_folders): Adjust to the new outbox system.
1748 * src/modest-tny-folder.h:
1749 * src/modest-tny-folder.c:
1750 (modest_tny_folder_is_local_folder),
1751 (modest_tny_folder_get_local_folder_type),
1752 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1754 * src/widgets/modest-main-window.h:
1755 * src/maemo/modest-main-window.c: (create_details_widget),
1756 (modest_main_window_set_contents_style): Show details for any folder store,
1759 (modest_tny_folder_get_rules):
1760 Remove the const. C does not support constness enough for this.
1762 * src/modest-ui-actions.c:
1763 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1764 make all outboxes appear as one, in the usual local-folders tree node.
1766 (set_active_account_from_tny_account),
1767 (modest_ui_actions_on_folder_selection_changed):
1768 * src/widgets/modest-folder-view.c: (text_cell_data),
1769 (icon_cell_data), (filter_row),
1770 (add_account_folders_to_merged_folder),
1771 (add_account_folders_to_simple_folder_store), (),
1772 (get_cmp_rows_type_pos), (cmp_rows),
1773 (modest_folder_view_set_account_id_of_visible_server_account):
1774 Adjust to the new outbox system, using generic folder stores and folders
1775 in the GtkTreeModel.
1777 2007-05-23 Christian Kellner <ckellner@openismus.com>
1779 * src/modest-mail-operation.c:
1780 (modest_mail_operation_update_account):
1781 Use info->max_size instead of unintialized local var [small
1782 build fix]. (Added TODO to review that change since I don't
1785 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1787 * libmodest-dbus-client/libmodest-dbus-client.c:
1788 (libmodest_dbus_client_compose_mail): function added
1789 * src/dbus_api/modest-dbus-api.h:
1790 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1791 (on_compose_mail): Implementation of the SendAsMail functionality
1793 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1795 * src/modest-account-mgr.c:
1796 (modest_account_mgr_add_server_account): Set the secure-connection
1797 conf key for transport accounts as well as store accounts. I don't know
1798 why the if was there. For instance, this makes sure that we use SSL
1799 for the gmail preset from the easysetup wizard.
1801 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1803 * src/gnome/modest-main-window.c:
1804 (on_account_store_connecting_finished), (connect_signals):
1805 * src/maemo/modest-main-window.c:
1806 (on_account_store_connecting_finished), (connect_signals),
1807 (modest_main_window_new):
1808 Handle TnyAccountStore::connecting-finished instead of
1809 TnyDevice::connection-changed, because we cannot actually perform
1810 operations on accounts until TnyAccountStore has itself responded to
1811 the TnyDevice::connection-changed signal. This prevents a GError from
1813 Do not try to update at startup, because we (at least on scratchbox)
1814 already do an update at startup when the device goes online.
1815 This prevents a GError from tinymail.
1816 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1817 Added TODO about stopping simultaneous operations.
1819 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1821 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1822 * src/modest-mail-operation-queue.c:
1823 (modest_mail_operation_queue_remove):
1824 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1825 about where they happened.
1827 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1829 * src/modest-ui-actions.c:
1830 (modest_ui_actions_on_password_requested): Make sure that the remember
1831 output parameter is always TRUE.
1833 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1836 Show a OK/Cancel dialog if the error is a question, though we still do not
1837 know anything more about what we are asking the user.
1838 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1839 Fix an uninitialized variable (helper). This is a logic error, however.
1841 2007-05-21 Christian Kellner <ckellner@openismus.com>
1843 * src/modest-search.h:
1844 Correct bit shifting in the ModestSearchFlags enum.
1846 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-tny-account.c:
1849 (modest_tny_account_new_from_server_account): Do not use the lsub and
1850 check-all hard-coded IMAP options when using POP.
1852 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1854 * src/modest-tny-account.c:
1855 (modest_tny_account_new_from_server_account):
1856 Use NULL for the secure-auth method for POP when Password auth has been
1857 specified by the user, as we already do for IMAP. "auth=Login" causes
1858 an error from camel or the server.
1860 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1862 * src/maemo/modest-account-settings-dialog.c:
1863 (create_page_account_details),
1864 (modest_account_settings_dialog_set_account_name):
1865 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1866 for the leave-on-server checkbox, rathr than just the checkbox, when
1867 the protocol is not POP.
1869 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1871 * src/widgets/modest-account-view.c:
1872 * src/widgets/modest-account-view.h:
1873 Added modest_account_view_select_account() which will be useful later
1874 to asynchronously re-select the edited account.
1876 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/modest-account-settings-dialog.c:
1879 (modest_account_settings_dialog_set_account_name):
1880 Automatically choose the port numbers based on the secure authentication
1881 methods, if they have not been chosen before.
1882 This fixes projects.maemo.org bug NB#56273 .
1884 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-main-window-ui.h:
1887 * src/modest-ui-actions.c:
1888 * src/modest-ui-actions.h:
1889 Connect the Tools/SMTP Servers menu item to
1890 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1891 SMTP servers dialog, as in the UI specification and saves changes when it
1892 is closed. This fixed projects.maemo.org bug NB#56305 .
1894 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/modest-connection-specific-smtp-window.c:
1897 (modest_connection_specific_smtp_window_init):
1898 Use gtk_window_set_default_size() to make this window big enough, so
1899 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1901 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1904 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1905 (modest_connection_specific_smtp_edit_window_init),
1906 Do not try to connect to a combobox signal before the combobox exists.
1907 This fixes the cras in projects.maemo.org bug NB#56288 .
1908 (modest_connection_specific_smtp_edit_window_get_settings):
1909 Remove the server_account_name parameter which was being checked for NULL
1910 though it was not used.
1912 * src/maemo/modest-connection-specific-smtp-window.c:
1913 (modest_connection_specific_smtp_window_fill_with_connections),
1914 (on_button_edit), (modest_connection_specific_smtp_window_init):
1915 Correct the number of treemodel columns to prevent a warning.
1916 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1917 libconic does not work.
1919 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-tny-account.c:
1922 (modest_tny_account_new_from_server_account):
1923 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1924 SMTP when "None" was chosen by the user. However, with my SMTP server that
1925 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1928 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1931 to explain the memory management issue with the ID in the ModestPair.
1933 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1934 (add_sending_page), (modest_account_assistant_finalize):
1935 * src/gnome/modest-gnome-global-settings-dialog.c:
1936 (create_updating_page), (create_composing_page):
1937 * src/gnome/modest-msg-edit-window.c: (get_transports),
1938 (init_window), (modest_msg_edit_window_finalize),
1939 (modest_msg_edit_window_get_msg_data):
1940 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1941 * src/gnome/modest-transport-widget.c:
1942 (modest_transport_widget_finalize), (smtp_configuration):
1943 * src/maemo/modest-maemo-global-settings-dialog.c:
1944 (create_updating_page), (create_composing_page):
1945 * src/maemo/modest-msg-edit-window.c: (get_transports),
1946 (init_window), (modest_msg_edit_window_finalize),
1947 (modest_msg_edit_window_get_msg_data),
1948 (modest_msg_edit_window_free_msg_data):
1949 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1950 (modest_store_widget_finalize):
1951 * src/maemo/modest-transport-widget.c:
1952 (modest_transport_widget_finalize), (smtp_configuration):
1953 * src/modest-main.c: (send_mail):
1954 * src/widgets/modest-combo-box.h:
1955 * src/widgets/modest-global-settings-dialog-priv.h:
1956 * src/widgets/modest-global-settings-dialog.c:
1957 (modest_global_settings_dialog_finalize):
1958 * src/widgets/modest-msg-edit-window.h:
1959 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1960 as long as the combo box, to prevent use of freed memory for the ID.
1962 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1964 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1965 get_accounts(), to make this clearer. Do not check for the enabled gconf
1966 key, because we do not use this for server accounts (at least, not yet).
1967 This allows us to send email again.
1969 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/modest-platform.c:
1972 (on_modest_conf_update_interval_changed), (modest_platform_init):
1973 Only respond to this particular key change. All these strcmp()s cannot be
1976 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-maemo-global-settings-dialog.c:
1979 (current_connection): Prevent a crash in scratchbox when
1980 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1981 * src/maemo/modest-platform.c:
1982 (on_modest_conf_update_interval_changed), (modest_platform_init):
1983 Get the update interval from gconf and reset it when the gconf key changes.
1985 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-protocol-info.c:
1988 * src/modest-protocol-info.h: Adde enum-specific get functions,
1989 instead of using a ModestProtocolType enum parameter.
1991 * src/gnome/modest-account-assistant.c:
1992 * src/gnome/modest-store-widget.c:
1993 * src/gnome/modest-store-widget.h:
1994 * src/gnome/modest-transport-widget.c:
1995 * src/gnome/modest-transport-widget.h:
1996 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1997 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1998 * src/maemo/easysetup/modest-easysetup-wizard.c:
1999 * src/maemo/modest-account-settings-dialog.c:
2000 * src/maemo/modest-account-settings-dialog.h:
2001 * src/maemo/modest-store-widget.c:
2002 * src/maemo/modest-store-widget.h:
2003 * src/maemo/modest-transport-widget.c:
2004 * src/maemo/modest-transport-widget.h:
2005 * src/modest-account-mgr-helpers.c:
2006 * src/modest-account-mgr-helpers.h:
2007 * src/modest-account-mgr.c:
2008 * src/modest-account-mgr.h:
2009 * src/modest-tny-account.c:
2010 * src/modest-tny-folder.c:
2011 * src/widgets/modest-account-view.c:
2012 * src/widgets/modest-retrieve-combo-box.c:
2013 * src/widgets/modest-retrieve-combo-box.h:
2014 * src/widgets/modest-secureauth-combo-box.c:
2015 * src/widgets/modest-serversecurity-combo-box.c:
2016 * src/widgets/modest-serversecurity-combo-box.h:
2017 * tests/check_account-mgr.c:
2018 Use the specific functions, and use the re-renamed enum values for GNOME too.
2020 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-pair.h:
2023 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2024 so we can get the second based on the first.
2026 * src/maemo/modest-account-settings-dialog.h:
2027 * src/maemo/modest-account-settings-dialog.c:
2028 Added get_supported_secure_authentication_methods(), though it is mostly
2029 commented-out for now until the necessary API is committed to tinymail.
2030 (modest_account_settings_dialog_set_account_name),
2031 (save_configuration): Request the supported authentication methods from the
2032 server, so we can choose a working method.
2034 * src/modest-tny-account-store.h:
2035 * src/modest-tny-account-store.c:
2036 (modest_tny_account_store_get_session): Rename from
2037 tny_account_store_get_session().
2039 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-protocol-info.h: Split the ModestProtocol enum
2042 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2043 There was no need to have these unrelated values in one enum.
2045 * src/: many files: Adapted to changed enum. This makes the code a bit
2046 clearer, and the compiler could catch some errors.
2048 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2050 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2051 Show the detailed internal camel error message when an error happens
2052 during the configuration, so that our testers can give us more clues.
2053 For instance, in projects.maemo.org bug NB#56910 .
2055 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-tny-account.c:
2058 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2059 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2061 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2064 * src/maemo/modest-account-settings-dialog.c:
2065 (modest_account_settings_dialog_set_account_name),
2066 (save_configuration): For the incoming secure authentication checkbox,
2067 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2068 the UI specification. PLAIN does not seem to be supported for most IMAP
2069 servers anyway, and I am not sure what it would mean.
2070 However, we probably need to discover which of the secure-authentication
2071 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2072 * src/modest-account-mgr-helpers.c:
2073 (modest_account_mgr_get_server_account_data):
2075 * src/modest-tny-account.c:
2076 (modest_tny_account_new_from_server_account):
2077 Use tny_account_set_mech() to set secure-authentication methods,
2078 with some special-casing for IMAP, based on my observations of how
2081 * src/modest-account-mgr-helpers.h:
2082 * src/modest-account-mgr.c:
2083 * src/modest-defs.h: Comment that the URI is only used for local folders.
2085 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2088 parameter const, just to be neat.
2089 * src/modest-text-utils.c: (modest_text_utils_inline):
2090 End g_strconcat() with NULL, as its documentation says. This is almost
2091 certainly the cause of my crash at startup on the device. Interestingly,
2092 valgrind doesn't tell us about these errors.
2094 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2096 * scripts/build-packages: Added more precise comments about how to use
2097 this script, though I still get this error:
2098 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2099 error building tinymail
2101 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2103 * src/maemo/modest-main-window.c: (on_account_update):
2104 Very slight cleanup, hoping to make it simpler to discover what causes
2105 a crash here sometimes.
2107 * src/modest-tny-account.c:
2108 (modest_tny_account_new_from_server_account): Set the port. Added
2109 comments about the options and a TODO comment because I need to find out
2110 how to specify the secure authentication method.
2112 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2114 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2115 changed CFlags paths form modest to libmodest
2117 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2119 * src/modest-account-mgr-helpers.c:
2120 (modest_account_mgr_get_server_account_data),
2121 (modest_account_mgr_free_server_account_data):
2122 * src/modest-account-mgr-helpers.h:
2123 * src/modest-account-mgr.c:
2124 (modest_account_mgr_add_server_account):
2125 * src/modest-defs.h:
2126 * src/modest-tny-account.c:
2127 (modest_tny_account_new_from_server_account):
2128 Determine the options for tny_camel_account_add_option() here,
2129 based on the settings, rather than storing them directly in gconf.
2131 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2134 Show a more friendly error dialog now that we expect (from the tinymail
2135 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2137 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-main-window.c: (on_account_update): Check that
2140 account_name is not NULL, to prevent a crash at startup that I am
2141 seeing on the N800. I do wonder why it is NULL.
2143 * src/maemo/easysetup/modest-easysetup-wizard.c:
2144 (create_page_user_details):
2145 * src/maemo/modest-account-settings-dialog.c:
2146 (create_page_user_details), (create_page_outgoing):
2147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2148 (modest_connection_specific_smtp_edit_window_init):
2149 * src/modest-ui-actions.c:
2150 (modest_ui_actions_on_password_requested):
2151 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2152 might do something useful with the on-screen keyboard.
2154 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2156 * src/maemo/modest-main-window.c: (on_account_update):
2157 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2158 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2160 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2162 * src/modest-tny-account-store.c: (on_account_changed):
2163 Correct the signature of this signal handler.
2165 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2167 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2168 Show a HildonNote instead of a GtkDialog for Maemo.
2170 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2172 * src/widgets/modest-account-view.h:
2173 * src/widgets/modest-account-view.c: (on_account_changed),
2174 (on_account_removed). Added a boolean flag, set/unset by
2175 modest_account_view_block_conf_updates(),
2176 modest_account_view_unblock_conf_updates() to prevent unnecessary
2177 updates, but this is not very useful because the gconf notifications are
2178 so delays (maybe only on Maemo Bora).
2179 So auto-updating is turned off, and these functions do an explicit
2180 update when necessary.
2181 However, something else is still doing too much work when adding/removing
2182 accounts, probably in another part of the application.
2184 * src/maemo/modest-account-view-window.c:
2185 (on_delete_button_clicked), (on_edit_button_clicked),
2186 (on_new_button_clicked): Use the new functions.
2188 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-account-mgr-helpers.c:
2191 (modest_account_mgr_set_first_account_as_default):
2192 Sort the list of names alphabetically-by-title, so we choose the first one
2194 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2195 alphabetically by the title.
2197 This fixes projects.maemo.org bug NB#56418 .
2199 * src/modest-account-mgr-priv.c:
2200 (_modest_account_mgr_account_from_key):
2201 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2202 avoid a valgrind error, and possible random behaviour.
2204 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2206 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2207 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2208 tinymail documentation to say that this can be expected.
2209 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2210 pretty, and should not happen, but I would prefer to know when it does.
2212 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2214 * configure.ac: When using the older hildon version, probably on Bora,
2215 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2217 * src/widgets/modest-attachment-view.c:
2218 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2221 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2223 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2224 Implemented the prototype. Can be tested with
2225 tests/dbus_api/test_open_message:
2227 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2229 * src/modest-tny-account-store.c:
2230 (modest_tny_account_store_instance_init), (get_password):
2231 * src/modest-ui-actions.c:
2232 (modest_ui_actions_on_password_requested):
2233 Do not store the password in gconf, because this function is called
2234 for non-remembered passwords. Actually use the cached (in the hash map)
2235 password instead of releasing it.
2236 The password will now not be remembered if it is asked via the protected
2237 password dialog, as per the UI spec.
2239 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2241 * src/modest-defs.h:
2242 * src/modest-account-mgr-helpers.h:
2243 * src/modest-account-mgr-helpers.c:
2244 Added modest_server_account_get_username_has_succeeded(),
2245 modest_server_account_set_username_has_succeeded().
2246 (modest_server_account_set_username),
2247 Reset the has-succeeded flag if the username changes.
2249 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2250 * src/maemo/modest-connection-specific-smtp-window.c:
2251 (modest_connection_specific_smtp_window_save_server_accounts):
2252 Use modest_server_account_set_username() instead of using
2253 modest_conf_set_string() directly, so that the has-succeeded flag is always
2256 * src/modest-ui-actions.c:
2257 (modest_ui_actions_on_password_requested): Dim the username entry if
2258 the username has ever worked, as per the UI spec.
2260 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2262 * src/modest-tny-account-store.c: (get_password):
2263 * src/modest-ui-actions.c:
2264 (modest_ui_actions_on_password_requested):
2265 Allow the username to be changed too, though there is more work to
2266 be done on exactly how this behaves.
2268 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-account-mgr-helpers.h:
2271 * src/modest-account-mgr-helpers.c:
2272 Added modest_account_mgr_get_display_name(),
2273 modest_server_account_get_username(),
2274 modest_server_account_set_username(),
2275 modest_server_account_set_password(),
2276 modest_server_account_get_hostname() functions so we do not need to
2277 use the conf API directly.
2279 * src/maemo/modest-main-window.c: (connect_signals):
2280 Actually connect ot the ModestAccountStore::request-password signal,
2281 so that we show the dialog when the password is requested by Tinymail,
2282 for isntance if it is empty.
2284 * src/modest-marshal.list:
2285 * src/modest-tny-account-store.c:
2286 (modest_tny_account_store_class_init), (get_password),
2287 (modest_tny_account_store_alert):
2288 * src/modest-tny-account-store.h:
2289 * src/modest-ui-actions.h:
2290 * src/modest-ui-actions.c:
2291 (modest_ui_actions_on_password_requested):
2292 Change the signal parameters, so it is obvious that we are providing
2293 the non human-readable server name, and receiving both the username
2294 and password, though changing of the username is not yet implemented.
2295 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2296 for the GNOME version.
2298 This should fix the projects.maemo.org bug NB#56209, though it does not
2299 work on Bora, because the gconf_client_get() for the password fails
2300 immediately after we save it with gconf_client_set().
2302 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2305 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2306 caused an undefined symbol error:
2307 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2309 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-tny-account-store.c:
2312 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2313 using a GError instead of a string message, so we can translate it in
2316 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/modest-address-book.c:
2319 (modest_address_book_check_names):
2320 * src/maemo/modest-msg-view-window.c:
2321 (modest_msg_view_window_clipboard_owner_change):
2322 * src/modest-init.c: (modest_init_init_ui):
2323 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2324 (update_folders_cb), (modest_mail_operation_update_account):
2325 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2326 (modest_ui_actions_on_msg_attachment_clicked),
2327 (modest_ui_actions_on_msg_recpt_activated):
2328 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2329 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2330 (modest_msg_view_search_next):
2331 * src/widgets/modest-recpt-editor.c:
2332 (modest_recpt_editor_on_button_release_event),
2333 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2334 g_message(). At this point we should only be seeing interesting errors on
2335 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2337 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2339 (modest_wizard_dialog_force_title_update):
2340 * src/maemo/easysetup/modest-wizard-dialog.h:
2341 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2342 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2343 can update the title when appropriate. Otherwise the title is wrong if the
2344 pages are added after adding the notebook to the dialog.
2345 This must be a problem in HildonWizardDialog too.
2346 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2348 * src/maemo/easysetup/modest-easysetup-wizard.c:
2349 (create_subsequent_customsetup_pages),
2350 (create_subsequent_easysetup_pages):
2351 Call modest_wizard_dialog_force_title_update() so that the title is
2352 correct even with GTK+ < 2.10.
2353 This fixes projects.maemo.org bug NB#56145 .
2355 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2357 * src/maemo/modest-platform.c:
2358 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2359 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2362 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2364 * src/widgets/modest-window.h:
2365 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2366 and modest_window_save_state(), which invokes it.
2368 * src/widgets/modest-window-mgr.h:
2369 * src/widgets/modest-window-mgr.c:
2370 Added modest_window_mgr_save_state_for_all_windows(), which calls
2371 the save_state vfunc on all registered windows, if implemented.
2373 * src/gnome/modest-msg-edit-window.c:
2374 * src/gnome/modest-msg-view-window.c:
2375 * src/maemo/modest-msg-edit-window.c:
2376 * src/maemo/modest-msg-view-window.c:
2377 * src/maemo/modest-main-window.c:
2378 Specify the existing save_settings functions as implementations of
2379 ModestWindow::save_state_func().
2381 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2382 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2383 enabling hibernation, for instance.
2385 We may need to do the same thing for restoring settings.
2388 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2390 * src/widgets/modest-window-mgr.c:
2391 * src/widgets/modest-window-mgr.h:
2392 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2393 modest_window_mgr_get_hibernation_is_prevented().
2395 * src/maemo/modest-main-window.c:
2396 (on_hildon_program_is_topmost_notify): Prevent hibernation
2397 (possible when the application goes to the background in the WM),
2398 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2400 * src/maemo/easysetup/modest-easysetup-wizard.c:
2401 (modest_easysetup_wizard_dialog_init):
2402 * src/maemo/modest-account-settings-dialog.c:
2403 (modest_account_settings_dialog_init):
2404 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2405 (modest_connection_specific_smtp_edit_window_init):
2406 * src/maemo/modest-connection-specific-smtp-window.c:
2407 (modest_connection_specific_smtp_window_init):
2408 * src/maemo/modest-signature-editor-dialog.c:
2409 (modest_signature_editor_dialog_init):
2410 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2411 prevent hibernation while any of these account settings dialogs are open.
2413 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/Makefile.am:
2416 * src/maemo/modest-osso-state-saving.c:
2417 * src/maemo/modest-osso-state-saving.h: Added
2418 modest_osso_load_state() and modest_osso_save_state() though they do
2419 nothing now. They should iterate through all the open windows and load/save
2421 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2422 save state when closing.
2424 * src/maemo/modest-main-window.c:
2425 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2426 Add a notification handler for the HildonProgram::is-topmost property,
2427 so we can allow hibernation when the application goes into the background.
2428 But we still need to detect when the accounts setup windows are open so
2429 we can stop hibernation when they are open.
2430 To do this, I also added the main window the HildonProgram. This might have
2431 other side-effects/benefits, and should maybe be done for other windows.
2433 * src/maemo/modest-osso-autosave-callbacks.h:
2434 * src/maemo/modest-osso-autosave-callbacks.c:
2435 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2436 though it does not do anything yet, and we might never need this to do
2437 anything. For instance, we already save drafts.
2439 * src/maemo/modest-platform.c: (modest_platform_init):
2440 Specify the libosso auto-save callback.
2442 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/modest-platform.c:
2445 (modest_platform_set_update_interval):
2446 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2447 aparently stays valid between application instances, so we can use this
2448 to remove and reset it later. According to a maemo-developers email from
2451 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2453 * configure.ac: Depend on libalarm for Maemo.
2455 * src/dbus_api/modest-dbus-api.h:
2456 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2457 (on_send_receive), (modest_dbus_req_handler):
2458 Handle a SEND_RECEIVE D-Bus method.
2460 * libmodest-dbus-client/libmodest-dbus-client.c:
2461 (libmodest_dbus_client_send_and_receive):
2462 * libmodest-dbus-client/libmodest-dbus-client.h:
2463 Add C convenience functions for calling the new D-Bus method.
2465 * src/modest-platform.h:
2466 * src/gnome/modest-platform.c:
2467 * src/maemo/modest-platform.c:
2468 Added modest_platform_set_update_interval(), which uses the
2469 alarmd API on Maemo.
2470 (modest_platform_init),
2471 Call modest_platform_set_update_interval(), using a hard-coded
2472 interval for now (until the global settings dialog is implemented),
2473 though I am not sure that this makes sense yet.
2475 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2477 * src/dbus_api/modest-dbus-callbacks.c:
2478 (modest_osso_cb_hw_state_handler):
2479 * src/dbus_api/modest-dbus-callbacks.h:
2480 * src/maemo/modest-platform.c: (modest_platform_init):
2481 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2482 in case this has some effect on the ability for Maemo to ping the
2485 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2487 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2488 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2489 warning. It is probably a logic error, but I need to fix the build.
2491 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-account-mgr.h:
2494 * src/modest-account-mgr.c:
2495 (modest_account_mgr_account_names): Add a gboolean enabled_only
2496 parameter, so we can get lists of onlt the enabled accounts.
2498 (modest_account_mgr_add_account),,
2499 (modest_account_mgr_account_with_display_name_exists):
2500 * src/maemo/modest-msg-edit-window.c: (get_transports):
2501 * src/modest-account-mgr-helpers.c:
2502 (modest_account_mgr_set_first_account_as_default):
2503 * src/modest-init.c: (init_default_account_maybe):
2504 * src/modest-tny-account-store.c: (get_accounts):
2505 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2506 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2507 * tests/check_account-mgr.c: (START_TEST):
2508 Provide the extra parameter, as appropriate.
2510 * src/widgets/modest-account-view.c: (update_account_view):
2511 Do not show disabled accounts (meaning that there is no way to
2512 enable/disable accounts in the UI (the feature is not in our UI
2513 specification), so we can use this internally only to mark unfinished
2514 or temporary account data.
2516 * src/maemo/easysetup/modest-easysetup-wizard.c:
2517 (create_account): Add boolean enable parameter, so we can specify FALSE
2518 to create the temporary account.
2519 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2520 (on_before_next): When finishing, when there is a temporary account, just
2522 Also, use a timeout to delay the showing of the dialog until gconf is likely
2523 to return correct information, due to a maemo gconf bug that is fixed in
2524 osso 1.1, but not yet in Bora.
2525 However, the dialog stays on screen after it is destroyed.
2527 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2528 for invalid data when cancelling. Use a hildon note instead of a dialog
2529 to complain about invalid data. Do not show the account-saved note if the
2530 account is disabled (a temporary account that will not really be saved for use
2533 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2535 * src/modest-account-mgr-helpers.h:
2536 * src/modest-account-mgr-helpers.c:
2537 Added modest_account_mgr_unset_default_account(),
2538 Added modest_account_mgr_set_first_account_as_default().
2540 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2541 If it was the default account, unset the default account name.
2543 * src/maemo/modest-account-view-window.c:
2544 (on_delete_button_clicked): If it was the default account,
2545 set the first remaining account as the default instead.
2547 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2548 a NULL account or a NULL default account, to prevent a crash. This should
2549 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2552 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2554 * src/widgets/modest-recpt-editor.c:
2555 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2556 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2557 TODO comment for this. This fixes the build.
2559 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2560 be the best place for it. This will in future update all auto-update accounts,
2561 rather than just the current/default account, when that gconf key exists.
2562 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2563 if there are no accounts, before calling do_send_receive().
2564 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2566 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2567 * src/maemo/modest-main-window-ui.h:
2568 * src/maemo/modest-main-window.c: (on_connection_changed),
2569 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2570 directly, becaue the signal handler does more.
2572 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2574 * src/modest-account-mgr-helpers.c:
2575 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2576 for the case that the account does not exist.
2578 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2579 (equivalent to the modest account name) rather than the tinymail account name
2580 (equivalent to the modest account title - human readable) to get the account data.
2581 Check for null account data to prevent the crash, and add a TODO comment saying that
2582 this needs fixing because it is using the server account name instead of the account name.
2584 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2587 * src/maemo/modest-account-settings-dialog.c: (show_error),
2589 Use hildon_note_new_information() for informative and error messages,
2590 which seems to be expected for Maemo applications (no documentation that I know of
2591 says this). I am surprised that there is no distinction between info and error
2594 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2596 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2597 it is easy to find where this is used.
2599 * src/maemo/easysetup/modest-easysetup-wizard.c:
2600 (create_page_welcome), (create_page_account_details),
2601 (create_page_user_details), (create_page_complete_easysetup),
2602 (create_page_custom_incoming), (create_page_custom_outgoing),
2603 (create_page_complete_custom):
2604 * src/maemo/modest-account-settings-dialog.c:
2605 (create_page_account_details), (create_page_user_details),
2606 (create_page_incoming), (create_page_outgoing):
2607 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2608 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2609 (modest_connection_specific_smtp_edit_window_init):
2610 * src/maemo/modest-connection-specific-smtp-window.c:
2611 (modest_connection_specific_smtp_window_init):
2612 * src/maemo/modest-signature-editor-dialog.c:
2613 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2614 and scrolling policy as per the Email Application Layout Guide, if I have
2617 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2619 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2620 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2621 which were empty, because these vfuncs have been removed from TnyAccountStore.
2622 This fixes the build.
2624 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2626 * src/maemo/modest-main-window.c:
2627 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2628 showing/hiding it. Added TODO because it probably should not be NULL.
2629 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2630 because unnecessary g_warnings() make degugging difficult.
2632 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2634 * src/maemo/modest-msg-edit-window.c:
2635 (modest_msg_edit_window_select_color),
2636 (modest_msg_edit_window_select_background_color): 2 const corrections and
2637 moving 2 #endifs before closing brackets, to fix the build.
2639 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2641 * src/maemo/easysetup/modest-easysetup-wizard.h:
2642 * src/maemo/easysetup/modest-easysetup-wizard.c:
2643 (modest_easysetup_wizard_dialog_finalize),
2644 (on_button_edit_advanced_settings), (create_page_complete_custom),
2645 (on_response), (create_account):
2646 Implement the Advanced Settings edit button, by saving the account information,
2647 for the Advanded Settings dialog to use directly from gconf, and removing it
2648 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2649 Bug #5533 in the projects.maemo.org bugzilla.
2651 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2653 * src/maemo/modest-msg-view-window.c:
2654 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2655 when opening a message window.
2657 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2663 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2664 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2665 gconf settings. I probably added more checks than necessary, but that is safer.
2667 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2668 variable to fix the build, but this seems to be used when it is still NULL.
2670 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2672 * src/modest-platform.h:
2673 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2674 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2675 * src/modest-main.c: Implement this function so we can avoid using
2676 maemo-specific API from cross-platform code.
2678 * src/modest-tny-account-store.c:
2679 (get_smtp_specific_transport_account_for_open_connection):
2680 * src/modest-ui-actions.c: (check_for_connection),
2681 (modest_ui_actions_on_item_not_found):
2682 Use modest_platform_connect_and_wait() and put #idefs around other
2683 maemo-specific code, because only maemo currently has a way to
2684 identify connection names.
2686 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2688 * src/modest-tny-account-store.h:
2689 * src/modest-tny-account-store.c:
2690 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2691 the connection-specific SMTP server settings in the configuration.
2693 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2695 * src/maemo/modest-main-window.c: (on_connection_changed),
2697 * src/modest-main.c: (main), (start_ui), (send_mail):
2698 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2699 that is what is intended.
2701 * src/modest-ui-actions.c: (action_send), (action_receive),
2702 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2703 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2704 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2705 SMTP server is used when it is specified.
2707 (modest_ui_actions_on_send_receive):
2708 Check that a connection is open before proceeding.
2709 Receive and then send, instead of vice-versa, as per the specification.
2711 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2713 * src/modest-mail-operation.c:
2714 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2715 though I guess it should be something other than NULL.
2717 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2719 * src/maemo/easysetup/modest-easysetup-wizard.c:
2720 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2721 combo twice, to avoid an g_warning and to make it visible again.
2722 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2723 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2724 (already intended) dereference when detaching, because we then recreate the menu.
2725 But I am not sure why the warning was happening, and it is possible that this is a memory
2728 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2730 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2731 and uri_parse_mailto() utility functions.
2732 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2734 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2736 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2738 * src/dbus_api/modest-dbus-api.h:
2739 * src/dbus_api/modest-dbus-callbacks.c:
2740 Use an idle callback to execute the modest code in the application's own thread.
2741 Remove the helloworld example method.
2742 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2743 parsed, and the open-message method is not implemented because this is not yet implemented in
2745 * libmodest-dbus-client/libmodest-dbus-client.c:
2746 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2747 (libmodest_dbus_client_open_message):
2748 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2750 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2751 body without crashing.
2753 * tests/dbus_api/Makefile.am:
2754 * tests/dbus_api/test_mail_to.c:
2755 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2757 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2759 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2760 Added file to fix the build. Sorry.
2762 * src/dbus_api/Makefile.am:
2763 * src/dbus_api/modest-dbus-api.h:
2764 * src/dbus_api/modest-dbus-callbacks.h:
2765 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2766 (modest_dbus_req_handler):
2767 Put constants in a separate header so it can be reused by the
2768 client library, without duplication
2770 * libmodest-dbus-client/Makefile.am:
2771 * libmodest-dbus-client/libmodest-dbus-client.c:
2772 (libmodest_dbus_client_call_helloworld),
2773 (libmodfest_dbus_client_send_mail),
2774 (libmodfest_dbus_client_mailto),
2775 (libmodfest_dbus_client_open_message):
2776 * libmodest-dbus-client/libmodest-dbus-client.h:
2777 (Partly) Implement a send_mail D-Bus method.
2779 * tests/dbus_api/Makefile.am:
2780 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2781 the send_email D-Bus method.
2783 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2787 * libmodest-dbus-client/Makefile.am:
2788 * libmodest-dbus-client/libmodest-dbus-client.c:
2789 * libmodest-dbus-client/libmodest-dbus-client.h:
2790 * tests/dbus_api/Makefile.am:
2791 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2792 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2794 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/easysetup/modest-easysetup-wizard.c:
2797 (create_page_account_details):
2798 * src/maemo/modest-account-settings-dialog.c:
2799 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2800 widgets, because this might not be the default in future versions of the Maemo GTK+.
2801 However, I can not not get capitalization to work even in a simple test case.
2803 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/easysetup/modest-easysetup-wizard.c:
2806 (create_page_custom_incoming), (create_page_custom_outgoing):
2807 * src/maemo/modest-account-settings-dialog.c:
2808 (create_page_account_details), (create_page_incoming),
2809 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2810 instead of using gtk_check_button_with_label(), so they are aligned like the other
2811 widgets, as per the UI spec.
2813 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2815 * src/maemo/easysetup/modest-easysetup-wizard.c:
2816 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2817 * src/widgets/modest-validating-entry.c:
2818 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2819 Modest prefix instead of an EasySetup prefix.
2821 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2823 * src/widgets/modest-validating-entry.h:
2824 * src/widgets/modest-validating-entry.c: (on_insert_text),
2825 Added easysetup_validating_entry_set_max_func(), used to set a callback
2826 to call when the max number of characters is reached. GtkEntry has a max-length
2827 already but is silent about it.
2829 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2830 (create_page_account_details), (create_page_user_details),
2832 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2833 (create_page_account_details), (create_page_user_details),
2834 (create_page_outgoing):
2835 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2836 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2837 the UI spec, when the user tries to enter more than the max number of characters.
2839 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2841 * src/maemo/easysetup/modest-easysetup-wizard.c:
2842 (create_page_user_details), (create_page_custom_incoming),
2843 (create_page_custom_outgoing):
2844 * src/maemo/modest-account-settings-dialog.c:
2845 (create_page_user_details), (create_page_incoming),
2846 (create_page_outgoing):
2847 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2848 (modest_connection_specific_smtp_edit_window_init):
2849 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2850 not appropriate. Bad Maemo-specific defaults!.
2852 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2855 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2856 (modest_signature_editor_dialog_set_settings):
2857 Disable the label and textview when the checkbox is disabled, and use the
2858 specified (UI spec) default signature text.
2860 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2863 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2865 * src/modest-defs.h:
2866 * src/modest-account-mgr-helpers.h:
2867 * src/modest-account-mgr-helpers.c:
2868 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2870 * src/maemo/Makefile.am:
2871 * src/maemo/modest-signature-editor-dialog.c:
2872 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2875 * src/maemo/modest-account-settings-dialog.h:
2876 * src/maemo/modest-account-settings-dialog.c:
2877 (modest_account_settings_dialog_finalize), (on_button_signature),
2878 (save_configuration): Use the new dialog when the Edit button is pressed, and
2879 save the changes if necessary, as per the UI spec.
2881 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2883 * src/maemo/Makefile.am:
2884 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2885 based on maemo-develoers email from Dirk.
2887 * src/maemo/easysetup/modest-easysetup-wizard.c:
2888 (create_page_welcome), (create_page_account_details),
2889 (create_page_user_details), (create_page_complete_easysetup),
2890 (create_page_custom_incoming), (create_page_custom_outgoing),
2891 (create_page_complete_custom),
2892 (modest_easysetup_wizard_dialog_init):
2893 * src/maemo/modest-account-settings-dialog.c:
2894 (create_page_account_details), (create_page_user_details),
2895 (create_page_incoming), (create_page_outgoing),
2896 (modest_account_settings_dialog_init):
2897 * src/maemo/modest-connection-specific-smtp-window.c:
2898 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2900 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/easysetup/modest-easysetup-wizard.c:
2903 (create_page_account_details), (create_page_custom_outgoing),
2904 (create_page_complete_custom):
2905 * src/maemo/modest-account-settings-dialog.c:
2906 (create_page_user_details), (create_page_incoming),
2907 (create_page_outgoing):
2908 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2909 (modest_connection_specific_smtp_edit_window_init):
2910 Use the correct (UI spec) port min/max, and use horizontal separators,
2913 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2915 * src/maemo/easysetup/modest-easysetup-wizard.c:
2916 (set_default_custom_servernames):
2917 * src/maemo/modest-account-settings-dialog.c:
2918 (create_page_incoming), (on_combo_outgoing_security_changed),
2919 (on_combo_incoming_security_changed), (create_page_outgoing),
2920 (modest_account_settings_dialog_set_account_name),
2921 (save_configuration):
2922 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2923 (on_combo_security_changed),
2924 (modest_connection_specific_smtp_edit_window_init),
2925 (modest_connection_specific_smtp_edit_window_set_connection),
2926 (modest_connection_specific_smtp_edit_window_get_settings):
2927 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2930 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2933 * src/maemo/easysetup/modest-easysetup-wizard.c:
2934 (create_page_custom_outgoing), (create_page_complete_custom):
2935 * src/maemo/modest-account-settings-dialog.c:
2936 (create_page_user_details), (create_page_outgoing):
2937 * src/maemo/modest-account-view-window.c: (button_box_new):
2938 Use changed logical IDs as per the most recent UI spec:
2939 mcen_bd_emailsetup_edit -> mcen_bd_edit
2940 mcen_bd_emailsetup_delete -> mcen_bd_delete
2941 mcen_bd_emailsetup_close -> mcen_bd_close
2943 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2947 * src/dbus_api/Makefile.am:
2948 * src/dbus_api/modest-dbus-callbacks.c:
2949 * src/dbus_api/modest-dbus-callbacks.h:
2950 * src/maemo/modest-platform.c: (modest_platform_init):
2951 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2953 * tests/Makefile.am:
2954 * tests/dbus_api/Makefile.am:
2955 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2957 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2959 * src/maemo/modest-account-settings-dialog.c:
2960 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2961 Removed unnecessary includes.
2963 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2965 * src/maemo/easysetup/modest-easysetup-wizard.c:
2966 * src/maemo/modest-account-settings-dialog.c:
2967 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2968 * src/widgets/Makefile.am:
2969 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2970 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2971 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2972 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2973 * src/widgets/modest-secureauth-combo-box.c:
2974 * src/widgets/modest-secureauth-combo-box.h:
2975 * src/widgets/modest-serversecurity-combo-box.c:
2976 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2977 made the GObject names more consistent with the rest of the Modest code.
2979 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/easysetup/Makefile.am:
2982 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2983 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2984 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2985 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2986 * src/maemo/easysetup/modest-easysetup-wizard.c:
2987 * src/maemo/easysetup/modest-validating-entry.c:
2988 * src/maemo/easysetup/modest-validating-entry.h:
2989 * src/maemo/modest-account-settings-dialog.c:
2990 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2991 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2992 widgets/ because they are used outside of easysetup too. After checking in,
2993 svn will allow me to rename them too.
2995 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2997 * src/gnome/modest-msg-edit-window.c:
2998 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2999 linker error, to fix the build on the GNOME platform.
3000 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3001 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3002 ifdefed out to avoid a warning.
3004 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3006 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3007 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3008 some alternative for GTK+ 2.6.
3010 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3014 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3015 specified for EmailAccountsDialog in UI spec.
3017 * src/maemo/easysetup/modest-easysetup-wizard.c:
3018 * src/maemo/easysetup/modest-easysetup-wizard.h:
3019 * src/maemo/modest-account-settings-dialog.c:
3020 * src/maemo/modest-account-settings-dialog.h:
3021 Reuse a member window widget for the connection-specific SMTP server accounts,
3022 so we can tell it to create/save the accounts only if we actually save changes.
3024 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3025 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3026 (modest_connection_specific_smtp_edit_window_get_settings):
3027 Return a struct instance for temporarily remembering the entered data.
3029 * src/maemo/modest-connection-specific-smtp-window.h:
3030 * src/maemo/modest-connection-specific-smtp-window.c:
3031 (modest_connection_specific_smtp_window_finalize),
3032 (modest_connection_specific_smtp_window_fill_with_connections),
3034 (modest_connection_specific_smtp_window_save_server_accounts),
3035 (update_model_server_names): Do not actually save data until asked,
3036 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3038 (on_selection_changed),
3039 (modest_connection_specific_smtp_window_init): Disable the edit
3040 button when nothing is selected.
3042 * src/modest-account-mgr-helpers.c:
3043 * src/modest-account-mgr-helpers.h:
3044 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3047 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3049 * src/modest-account-mgr-helpers.h:
3050 * src/modest-account-mgr-helpers.c:
3051 (modest_account_mgr_get_unused_account_name),
3052 (modest_account_mgr_get_unused_account_display_name): Added these
3053 utility functions, to avoid code duplication.
3055 * src/maemo/easysetup/modest-easysetup-wizard.c:
3056 (create_page_account_details), (create_account):
3057 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3058 (on_combo_security_changed),
3059 (modest_connection_specific_smtp_edit_window_init),
3060 (modest_connection_specific_smtp_edit_window_save_settings):
3061 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3062 * src/maemo/modest-connection-specific-smtp-window.c:
3063 (modest_connection_specific_smtp_window_finalize),
3064 (modest_connection_specific_smtp_window_fill_with_connections),
3065 (on_button_edit), (modest_connection_specific_smtp_window_init):
3066 * src/maemo/modest-connection-specific-smtp-window.h:
3067 Implementing saving of connection-specific server accounts.
3069 But I need to refactor this so we can save the data for each
3070 possible connection-specific account and only actually create the server accounts
3071 when the easysetup finished, or the OK button is pressed on the account settings
3074 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3077 (on_combo_security_changed):
3078 (modest_connection_specific_smtp_edit_window_init):
3079 Auto-fill the port number as in the account settings.
3081 (modest_connection_specific_smtp_edit_window_set_connection):
3082 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3083 * src/maemo/modest-connection-specific-smtp-window.c:
3084 (fill_with_connections), (on_button_edit),
3085 (modest_connection_specific_smtp_window_init):
3086 Turn the edit window into a dialog to simplify the code, and
3087 set a WM hint as in a GtkDialog, because only a popup can be on top of
3088 another window in Maemo, and popups usually have no WM decoration.
3090 * src/modest-defs.h:
3091 * src/modest-account-mgr-helpers.c:
3092 (modest_account_mgr_set_connection_specific_smtp),
3093 (modest_account_mgr_remove_connection_specific_smtp),
3094 (modest_account_mgr_get_connection_specific_smtp):
3095 * src/modest-account-mgr-helpers.h: Some functions to write the
3096 connection-specific SMTP server information. Not yet used.
3099 * src/widgets/modest-folder-view.c: (text_cell_data):
3100 Fix a warning about an uninitialized variable.
3101 (on_configuration_key_changed): Put an #ifdef around the use
3102 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3104 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/modest-account-settings-dialog.h:
3107 * src/maemo/modest-account-settings-dialog.c:
3108 Added connect_for_modified() utility function to mark the new modified boolean.
3110 (create_page_account_details), (create_page_user_details),
3111 (create_page_incoming), (create_page_outgoing), (on_response),
3112 (modest_account_settings_dialog_init),
3113 (modest_account_settings_dialog_set_account_name):
3114 Only warn about unsaved changes when there are actually unsaved changes.
3116 * src/modest-account-mgr-helpers.c:
3117 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3118 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3119 to get the data from there in future.
3121 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3123 * src/modest-defs.h:
3125 * src/modest-account-mgr-helpers.h:
3126 * src/modest-account-mgr-helpers.c:
3127 Store the security account setting in a single conf key instead of using
3128 the options list, so that the list is left for just the to-be-removed camel hack,
3129 and because gconf_client_set_list() is failing for some reason.
3131 * src/modest-account-mgr.c:
3132 (modest_account_mgr_add_server_account):
3133 * src/maemo/modest-account-settings-dialog.c:
3134 (modest_account_settings_dialog_set_account_name),
3135 (save_configuration): Use the renamed functions.
3138 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3140 * src/widgets/Makefile.am:
3141 * src/widgets/modest-limit-retrieve-combo-box.c:
3142 * src/widgets/modest-limit-retrieve-combo-box.h:
3143 * src/widgets/modest-retrieve-combo-box.c:
3144 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3145 the account settings dialog.
3147 * src/modest-defs.h:
3148 * src/modest-account-mgr-helpers.h:
3149 * src/modest-account-mgr-helpers.c:
3150 (modest_server_account_get_option_secure_auth),
3151 (modest_server_account_set_option_secure_auth):
3152 * src/modest-account-mgr.c:
3153 (modest_account_mgr_add_server_account):
3154 Use the existing AUTH_MECH conf key for the secure-auth setting,
3155 instead of putting it in the list options, because this was actually used already.
3157 * src/maemo/modest-account-settings-dialog.c:
3158 (create_page_account_details),
3159 (modest_account_settings_dialog_set_account_name),
3160 (save_configuration):
3161 * src/maemo/modest-account-settings-dialog.h:
3162 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3163 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3165 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3167 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3168 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3169 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3171 * src/modest-defs.h:
3172 * src/maemo/modest-account-settings-dialog.c:
3173 (create_page_incoming), (on_combo_outgoing_security_changed),
3174 (on_combo_incoming_security_changed), (create_page_outgoing),
3175 (modest_account_settings_dialog_set_account_name),
3176 (save_configuration): Load/Save the port number, and change it when the
3177 security combo changes, to suitable defaults.
3179 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3181 * src/modest-account-mgr.c:
3182 (modest_account_mgr_add_server_account): Set the security and secure-auth
3183 options, and add a comment saying that the other camel-specific options should be
3186 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3190 * src/modest-tny-account-store.c: (account_list_free),
3191 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3192 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3195 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3197 * src/modest-protocol-info.c:
3198 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3199 is required by our UI spec. Maybe something in our implementation will use this eventually.
3200 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3201 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3202 instead of the previous 0 placeholder.
3204 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3205 secure-auth settings.
3206 * src/modest-account-mgr-helpers.h:
3207 * src/modest-account-mgr-helpers.c:
3208 (modest_server_account_data_get_option_secure_auth),
3209 (modest_server_account_set_option_secure_auth),
3210 (modest_server_account_data_get_option_security),
3211 (modest_server_account_set_option_security): Added this API for getting and setting the security
3212 and secure-auth settings.
3214 * src/maemo/modest-account-settings-dialog.h:
3215 * src/maemo/modest-account-settings-dialog.c:
3216 (modest_account_settings_dialog_finalize), (check_data),
3217 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3218 about changing titles.
3219 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3220 (save_configuration): Save the security and secure-auth settings.
3222 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3223 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3225 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3227 * src/modest-defs.h:
3228 * src/modest-account-mgr.c:
3229 (modest_account_mgr_add_server_account):
3230 Added and used defines for the options key and value pair strings,
3231 that are used so far, though they do not seem to correspond to anything in our
3232 UI specs or ModestProtocol enum.
3234 * src/modest-account-mgr-helpers.h:
3235 * src/modest-account-mgr-helpers.c:
3236 (compare_option_strings_for_name),
3237 (modest_server_account_data_get_option_value),
3238 (modest_server_account_data_get_option_bool),
3239 (modest_account_mgr_get_server_account_option):
3240 Added helper functions for parsing the options GSList.
3242 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3244 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3245 display name is based on the supplied account name.
3246 * src/modest-account-mgr.c:
3247 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3248 with an inefficient, but good-enough, implementation.
3250 * src/maemo/easysetup/modest-easysetup-wizard.c:
3251 (create_page_account_details), (on_before_next), (create_account):
3252 Check for existing display names rather than (non-user-visible) account names, and just
3253 create and set a unique account name at the end.
3255 * src/maemo/modest-account-settings-dialog.c:
3256 (modest_account_settings_dialog_init),
3257 (modest_account_settings_dialog_set_account_name),
3258 (create_page_incoming): Show the display name, instead of the account name.
3259 (on_response): Do some (not all) extra checks, as in the UI spec.
3260 (save_configuration): Save the display name if it was changed.
3262 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3264 * po/en_GB.po: Added needed logical ID and translation.
3265 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3266 (init_view): Made the is-default column clicking work.
3268 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3271 * src/maemo/easysetup/Makefile.am:
3272 * src/maemo/easysetup/modest-easysetup-wizard.c:
3273 (modest_easysetup_wizard_dialog_init):
3274 * src/maemo/easysetup/provider-data-test.keyfile:
3275 * src/maemo/easysetup/provider-data.keyfile:
3276 Moved the provider data file to the new modest-providers-data package and used it from there.
3278 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-local-folder-info.c:
3281 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3282 N_() was already used on the static strings, but this just marks it for translation without
3283 using the translation.
3285 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3287 * src/maemo/modest-account-settings-dialog.c:
3288 (create_page_incoming),
3289 (modest_account_settings_dialog_set_account_name):
3290 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3291 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3292 I will do this if nobody else gets there first.
3294 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3297 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3298 save the security stuff.
3300 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3303 Set the email address and user fullname, which I now see must be
3306 * src/maemo/modest-account-settings-dialog.h:
3307 * src/maemo/modest-account-settings-dialog.c:
3309 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3310 leave-on-server and authentication.
3311 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3314 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/modest-account-settings-dialog.c:
3318 * src/maemo/modest-account-settings-dialog.h:
3319 Most (but not all) of the widgets are now present as specified by the UI spec.
3320 No changes are yet saved, and some details are not properly shown yet.
3322 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3324 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3326 * src/maemo/Makefile.am:
3327 * src/maemo/modest-account-settings-dialog.c:
3328 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3329 an existing account. Doesn't do much yet.
3331 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3332 Open the accounts settings dialog when Edit is clicked.
3334 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/easysetup/Makefile.am:
3337 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3339 * src/maemo/easysetup/modest-easysetup-wizard.c:
3340 (modest_easysetup_wizard_dialog_init):
3341 Try to get the source directory from the build system,
3342 instead of hard-coding "./" into the source code, when opening our local
3343 copies of the configuration files.
3344 But this still fails when opening the wizard from the Accounts window,
3345 maybe because the working directory seems to change at runtime.
3346 So the wizard will fail the second time unless you copy the files into their
3347 proper locations - see the stdout warnings for the paths.
3349 (create_page_account_details),(on_before_next):
3350 Check for existing non-server accounts instead of server accounts,
3351 so the default account name is useful again, and to prevent trying to
3354 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3355 Show the wizard when New is clicked.
3357 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3358 (init_view): Show the column headers, and show the columns that are
3359 specified in the UI specs. However, something in Maemo's GTK+ prevents
3360 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3361 change the default account. This is despite unsetting the special properties.
3363 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3365 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3366 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3367 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3368 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3369 to make that clearer.
3370 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3372 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3374 * src/maemo/modest-account-view-window.c:
3375 (modest_account_view_window_init),
3376 (modest_account_view_window_new):
3377 Use the same buttons as specified in the
3378 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3379 the existing widgets, which never had a chance of working.
3380 Put the ModestAccountView treeview in a scrolled window.
3381 Do not repeat the initialization in both _init() and _new().
3383 * src/widgets/modest-account-view.c: (update_account_view):
3384 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3385 this widget and window shows no accounts.
3387 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3389 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3391 * src/maemo/easysetup/modest-easysetup-wizard.c:
3392 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3393 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3394 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3397 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3398 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3399 accounts exist yet, as in the UI spec.
3401 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3403 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3405 * src/maemo/Makefile.am:
3406 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3407 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3408 New window for editing connection-specific smtp details.
3409 Not fully implemented.
3411 * src/maemo/modest-connection-specific-smtp-window.c:
3412 (modest_connection_specific_smtp_window_finalize) :
3413 unref the tree model.
3414 (on_button_edit): Show the edit window.
3416 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3418 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3421 * src/maemo/Makefile.am:
3422 * src/maemo/modest-connection-specific-smtp-window.c:
3423 * src/maemo/modest-connection-specific-smtp-window.h:
3424 New window for showing the list of connections, for connection-specific
3425 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3426 * src/maemo/easysetup/modest-easysetup-wizard.c:
3427 (create_page_custom_outgoing): Show the new window when the button is clicked.
3429 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3432 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3433 * src/maemo/modest-msg-edit-window.c:
3434 (modest_msg_edit_window_insert_image):
3435 * src/modest-conf.c: (modest_conf_key_escape):
3436 * src/modest-mail-operation.c:
3437 (modest_mail_operation_send_new_mail):
3438 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3439 (modest_ui_actions_on_new_account):
3440 * src/widgets/modest-attachment-view.c: (update_filename_request):
3441 * src/widgets/modest-mail-header-view.c:
3442 Corrected warnings that were breaking the build, by commenting out unused variables,
3443 and a function, and by including a header.
3445 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3447 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3448 so we can #ifdef around platform-specific code when necessary.
3449 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3450 to allow this to build for the GNOME platform too.
3452 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/easysetup/modest-easysetup-wizard.c:
3455 Added util_increment_name() and used it in create_page_account_details()
3456 to make sure that the default account name is always a new name.
3458 (modest_easysetup_wizard_dialog_init),
3459 (set_default_custom_servernames): Some minor memory management fixes.
3461 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3465 * src/modest-runtime.c: (init_i18n): Restored the translation
3466 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3467 are defined in config.h, and the translations are installed.
3469 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3470 is defined for translation.
3472 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3474 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3476 * src/maemo/easysetup/modest-easysetup-wizard.c:
3477 (modest_easysetup_wizard_dialog_init):
3478 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3479 Use realistic paths (though they should use $prefix generically) to the
3480 mcc_mapping and provider-data.keyfile files which might work when they
3481 are installed by the future version of the operator-wizard package,
3482 and then fallback to paths in our source code, with an explanatory
3485 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/Makefile.am:
3490 * src/maemo/easysetup/: Added files from the previously-exernal
3491 osso-modest-easysetup.
3492 * src/maemo/modest-main-window-ui.h:
3493 * src/modest-ui-actions.c:
3494 * src/modest-ui-actions.h:
3495 Added modest_ui_actions_on_new_account() as a signal handler for the
3496 New Account menu item. It shows the easysetup wizard.
3497 * po/en_GB.po: Added additional needed logical IDs and translations.