1 2007-06-08 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
4 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
5 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
6 (load_from_file), (easysetup_country_combo_box_init),
7 (easysetup_country_combo_box_get_active_country_ids),
8 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
9 instead of just one ID, to avoid duplicate country names in the UI.
11 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
12 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
13 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
14 a single ID, avoiding duplicate providers.
15 * src/maemo/easysetup/modest-easysetup-wizard.c:
16 (on_combo_account_country): Adapt to use a list.
18 2007-06-08 Murray Cumming <murrayc@murrayc.com>
20 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
21 keys changed in the last X seconds.
23 * src/modest-account-mgr.h:
24 * src/modest-account-mgr.c: (on_timeout_notify_changes),
25 (on_key_change), (modest_account_mgr_class_init),
26 (modest_account_mgr_init), (modest_account_mgr_finalize):
27 As the keys are changed, save them in a GSList* and signal that GSList*
28 further every X seconds, to batch changes, to allow us to do just one
29 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
30 bug NB#56941 and other (UI-blocking) delays when changing account settings.
32 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
33 changed signal signature.
35 * src/modest-conf.c: (modest_conf_set_list),
36 (modest_conf_on_change): Reenable notification.
38 (modest_conf_maemo_fake_on_change): Comment out the hack that
39 notified immediately instead of asynchronously.
41 * src/widgets/modest-account-view.h:
42 * src/widgets/modest-account-view.c:
43 (update_account_view): Select the previously-selected account ID,
44 if possible. This fixes projects.maemo.org bug NB#56933.
46 (on_account_changed), (on_account_removed),
47 (modest_account_view_select_account):
49 Remove the block/unblock functions
50 because they were not useful.
52 * src/maemo/modest-account-view-window.c:
53 (on_delete_button_clicked), (on_edit_button_clicked),
54 (on_new_button_clicked): Remove the use of the non-working block/unblock.
56 2007-06-08 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
59 Improve the error dialog to show Incorrect Account Settings, which seems
60 clearer, and say that the internal error message (to be removed from the
61 dialog later) is often misleading.
62 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
64 * src/modest-tny-account.c:
65 (modest_tny_account_new_from_server_account): Uncomment the printf of the
66 URL because this is so useful for debugging on the device.
68 * src/widgets/modest-serversecurity-combo-box.c:
69 (modest_serversecurity_combo_box_fill): Correct a logical ID.
71 2007-06-08 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-mail-operation.c:
74 (modest_mail_operation_send_new_mail):
75 Added a comment about a nasty but apparently harmless message. Details
76 added to the wiki g_warnings() page.
78 2007-06-08 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
81 (modest_tny_send_queue_class_init):
82 Do not use the priv struct because it is empty, to avoid g_warnings
83 about a non-existant priv struct.
85 * src/modest-tny-account-store.c:
86 (modest_tny_account_store_get_server_account),
87 (modest_tny_account_store_get_transport_account_for_open_connection
88 ): Do not try to get transport server accounts for local folders,
89 because they don't have any. This avoids a g_warning().
91 * src/maemo/modest-main-window.c:
92 (modest_main_window_notify_send_receive_initied),
93 (on_configuration_key_changed):
94 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
96 * src/modest-mail-operation.c:
97 (modest_mail_operation_update_account):
98 * src/modest-tny-account-store.h:
99 * src/modest-tny-account.c:
100 (modest_tny_account_get_special_folder),
101 (modest_tny_account_new_for_local_folders),
102 (modest_tny_account_new_for_per_account_local_outbox_folder):
103 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
104 * src/modest-tny-local-folders-account.c:
105 (add_account_folders_to_merged_folder):
106 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
107 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
108 (modest_ui_actions_on_send):
109 * src/widgets/modest-folder-view.c: (update_model):
110 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
111 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
112 modest_tny_account_store_get_tny_account_by_account() to
113 modest_tny_account_store_get_server_account() to make the code clearer.
115 2007-06-07 Marcus Bauer <marcusb@openismus.com>
117 * src/dbus_api/modest-dbus-api.h:
118 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
119 * src/maemo/modest-msg-edit-window.c:
120 (modest_msg_edit_window_attach_file_noninteractive):
121 added g_warning in case the file to be attached does not exist
122 * tests/dbus_api/test_compose_mail.c: (main):
123 removed obsolete comment, added generic files as test case
125 2007-06-07 Murray Cumming <murrayc@murrayc.com>
127 * src/modest-tny-account-store.c: (get_server_accounts):
128 Create the local folders account only once, not once for each outbox, and
129 not only when there are some outboxes.
131 2007-06-07 Murray Cumming <murrayc@murrayc.com>
133 * src/widgets/modest-folder-view.c: (update_model): Comment out some
134 code that is causing a crash at startup. Sergio says that he is fixing this.
136 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
138 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
139 * src/maemo/modest-account-settings-dialog.c:
140 (create_page_outgoing),
141 (modest_account_settings_dialog_set_account_name),
142 (save_configuration):
143 - Fixed handling of the "Use secure authentication" toggle to comply with
144 the ui specification. See also projects.maemo.org bug NB#58400
146 - Restore the Secure connection setting combo correctly when loading
149 * src/maemo/modest-maemo-utils.c:
150 (on_camel_account_get_supported_secure_authentication),
151 (modest_maemo_utils_get_supported_secure_authentication_methods):
152 Fixed a crasher if operation is canceled
154 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
155 (modest_protocol_info_auth_is_secure):
156 * src/modest-protocol-info.h:
158 Added two new methods to determine if a protocol/auth method is secure/encrypted in
159 the sense of the "Use secure authentication" toggle.
161 2007-06-07 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-tny-account-store.h:
164 * src/modest-tny-account-store.c:
165 Added modest_tny_account_store_get_local_folders_account().
167 * src/modest-tny-folder.h:
168 * src/modest-tny-folder.c:
169 (modest_tny_folder_get_account):
170 Added this replacement for tny_folder_get_account() which returns
171 the local-folders account for TnyMergeFolders, to avoid the
172 warning about the unimplemented get_account_func() vfunc().
174 (modest_tny_folder_get_rules),
175 * src/modest-ui-actions.c:
176 (modest_ui_actions_on_folder_selection_changed):
177 * src/modest-mail-operation.c:
178 (modest_mail_operation_remove_folder),
179 (modest_mail_operation_xfer_folder),
180 (modest_mail_operation_rename_folder),
181 (modest_mail_operation_get_msg),
182 (modest_mail_operation_get_msgs_full),
183 (modest_mail_operation_remove_msg),
184 (modest_mail_operation_xfer_msgs),
185 (modest_mail_operation_refresh_folder):
186 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
188 2007-06-07 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
191 (modest_server_account_set_security):
192 * src/modest-defs.h: Add comments explaining that our
193 UI spec means TLS when it says Normal, so these do not look like errors.
195 * src/modest-tny-account.c:
196 (modest_tny_account_new_from_server_account): Use the new tinymail
197 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
198 for TLS. This should fix projects.maemo.org bug NB#58460.
200 2007-06-06 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/easysetup/modest-easysetup-wizard.c:
203 (create_account): Correct the position of the gconf sanity check warning.
204 (on_button_edit_advanced_settings): Show the dialog immediately, instead
205 of using the g_idle_add() hack, because this does not seem to be necessary
206 on osso 1.1. It might even work on Maemo Bora if the problems were actually
207 caused by something other than maemo's gconf.
208 This fixes projects.maemo.org bug #59022.
210 2007-06-06 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-account-mgr-helpers.c:
213 (modest_account_mgr_get_default_account): Do not check that the account
214 exists if there is no default account (NULL), to fix a runtime warning.
216 2007-06-06 Murray Cumming <murrayc@murrayc.com>
218 * src/widgets/modest-folder-view.c: (update_model):
219 Do not unref the treemodel before we have finished with it.
220 This prevents a valgrind warning and an occasional crash at startup.
222 2007-06-06 Marcus Bauer <marcusb@openismus.com>
224 * libmodest-dbus-client/libmodest-dbus-client.h:
225 added libmodest_dbus_client_compose_mail()
226 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
228 added functions needed for SendAsMail() functionality
229 * src/maemo/modest-msg-edit-window.c:
230 (modest_msg_edit_window_attach_file_noninteractive):
231 non interactively attaching files to message edit window
232 * src/widgets/modest-msg-edit-window.h:
233 * tests/dbus_api/Makefile.am:
234 added test_compose_mail.c
235 * tests/dbus_api/test_compose_mail.c: (main):
237 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
239 * src/modest-account-view.c:
240 Fixed bug projects.maemo.org bug NB#59307
242 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
244 * src/maemo/easysetup/modest-easysetup-wizard.c:
245 (get_serverport_incoming), (on_before_next), (create_account):
246 * src/maemo/modest-account-settings-dialog.c:
247 (modest_account_settings_dialog_set_account_name):
248 * src/maemo/modest-maemo-utils.c:
249 (on_camel_account_get_supported_secure_authentication_status),
250 (on_camel_account_get_supported_secure_authentication),
251 (on_secure_auth_cancel),
252 (modest_maemo_utils_get_supported_secure_authentication_methods):
254 Implemented security authentication for settings and easysetup.
256 2007-06-05 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/modest-main-window.c: (create_details_widget):
259 Show the total size for memory card accounts too, instead of showing
260 the name again. Fixes bug projects.maemo.org bug NB#59307.
262 2007-06-05 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-tny-simple-folder-store.c:
266 * src/modest-tny-simple-folder-store.h: Removed.
268 * src/modest-tny-local-folders-account.h
269 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
270 for the local-folders maildir, with an extra TnyMergedFolder containing
271 the folders of the per-account outbox store accounts.
272 * src/modest-tny-account-store.c: (get_server_accounts):
273 Add the outboxes to the special local folders account after creating it.
275 * src/modest-tny-account.c:
276 (modest_tny_account_new_for_local_folders): Create the derived
277 account when creating the main local-folders account.
279 * src/maemo/modest-main-window.c: (create_details_widget),
280 (modest_main_window_set_contents_style):
281 Adapted to the use of the derived account instead of the folder store.
283 * src/modest-ui-actions.c:
284 (modest_ui_actions_on_folder_selection_changed):
285 * src/modest-ui-dimming-rules.c:
286 (modest_ui_dimming_rules_on_new_folder):
287 * src/widgets/modest-folder-view.c: (text_cell_data),
288 (icon_cell_data), (filter_row), (update_model),
289 (get_cmp_rows_type_pos):
292 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
293 Do not get the priv struct, because no priv struct has been set,
294 to avoid a runtime warning.
296 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
297 #ifelse with #else, to fix a warning, to fix the build.
300 2007-06-05 Christian Kellner <ckellner@openismus.com>
302 * libmodest-dbus-client/libmodest-dbus-client.c:
303 Fix small typo in doc (why do you always see them
304 AFTER committing stuff?)
307 2007-06-05 Christian Kellner <ckellner@openismus.com>
309 * libmodest-dbus-client/libmodest-dbus-client.c:
310 (libmodest_dbus_client_search):
311 Initialize hit list with NULL. Also set folder list
312 to "" if NULL was supplied.
315 2007-06-03 Christian Kellner <ckellner@openismus.com>
317 * libmodest-dbus-client/libmodest-dbus-client.c:
318 (modest_search_hit_list_free):
319 Make it save to call it with NULL.
321 * src/dbus_api/modest-dbus-callbacks.c:
322 * src/modest-search.c:
323 Return full ModestSearchHits as the search result list not TnyHeader
324 since can't be around withouth the correspoding TnyFolder.
326 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
328 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
329 Added currently commented code to check for secure auth
331 * src/maemo/modest-account-settings-dialog.c: (on_response),
332 (save_configuration), (show_ok):
333 Fixed projects.maemo.org bugs NB #59248 and #59251
335 * src/maemo/modest-maemo-utils.c:
336 (on_camel_account_get_supported_secure_authentication_status),
337 (on_camel_account_get_supported_secure_authentication),
338 (modest_maemo_utils_get_supported_secure_authentication_methods):
339 * src/maemo/modest-maemo-utils.h:
340 Moved get_supported_secure_authentication() method here to be able
341 to use it from easysetup wizard.
343 * src/modest-pair.c: (on_pair_compare_as_string):
344 Should compare string with first part of pair and not
345 strcmp pairs which will crash.
347 * src/modest-protocol-info.c:
348 (modest_protocol_info_protocol_is_store):
349 * src/modest-protocol-info.h:
350 Added modest_protocol_info_get_auth_protocol_name()
352 2007-06-03 Armin Burgmeier <armin@openismus.com>
354 * src/modest-mail-operation.c:
355 (modest_mail_operation_get_msgs_full): Set priv->account also when
356 only retrieving a single message. This avoids a crash when canceling
359 (modest_mail_operation_notify_end): Do not explicitely remove the
360 operation from the queue but only emit the progress_changed signal.
361 The queue itself listens to that signal to remove the operation when
362 it is finished. This reduces coupling and removes a potential deadlock
363 when modest_mail_operation_notify_end() is called from the queue
364 itself. If that is a problem performance-wise, I would suggest to
365 implement a status-changed signal or something.
367 * src/modest-mail-operation-queue.c: Make sure to never call a
368 function from another file while the queue is locked. This (hopefully)
369 fixes another deadlock when exiting the application while retrieving
372 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
374 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
375 Fixed build if libogs is not available
377 2007-06-03 Christian Kellner <ckellner@openismus.com>
379 * libmodest-dbus-client/libmodest-dbus-client.h:
380 * libmodest-dbus-client/libmodest-dbus-client.c:
381 (libmodest_dbus_client_delete_message):
382 Implement deletion of messages (Client side).
384 (modest_search_hit_free),
385 (modest_search_hit_list_free):
386 Utility functions to free the result hits.
388 * src/dbus_api/modest-dbus-api.h:
389 * src/dbus_api/modest-dbus-callbacks.c:
391 (modest_dbus_req_handler):
392 Implement deletion of messages (Server side).
394 * tests/dbus_api/test_search.c: (main):
397 * tests/dbus_api/Makefile.am:
398 * tests/dbus_api/test_delete_message:
399 Add little test for the message deletion logic
401 2007-06-03 Armin Burgmeier <armin@openismus.com>
403 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
404 when the operation queue was not empty. projects.maemo.org bug
407 2007-06-03 Armin Burgmeier <armin@openismus.com>
409 * src/widgets/modest-account-view.c
410 (on_account_default_toggled): Toggle default account column
411 explicitely instead of waiting for gconf notification (which is
412 currently ignored). This should fix projects.maemo.org bug NB#56910
413 for now. It should probably be removed when gconf notifications are
416 2007-06-03 Christian Kellner <ckellner@openismus.com>
418 * libmodest-dbus-client/libmodest-dbus-client.c:
419 Removed debugging spew.
421 * src/dbus_api/modest-dbus-callbacks.c:
422 Added debugging info.
424 * src/modest-search.c:
425 (modest_search_all_accounts):
426 Use tny_account_store_get_accounts () on the account store
427 to get all accounts which is the way to get all accounts.
429 * tests/dbus_api/test_search.c: (main):
430 Make it possible to supply the search term on the command line.
432 2007-06-03 Christian Kellner <ckellner@openismus.com>
434 * libmodest-dbus-client/libmodest-dbus-client.c:
435 * libmodest-dbus-client/libmodest-dbus-client.h:
436 Implement searching for mesages over raw dbus. (Client side)
438 * src/dbus_api/Makefile.am:
439 * src/dbus_api/modest-dbus-api.h:
440 * src/dbus_api/modest-dbus-callbacks.c:
441 * src/dbus_api/modest-dbus-callbacks.h:
442 Search framework (Server side). Also implement on_idle_open_message().
444 * src/maemo/modest-platform.c: (modest_platform_init):
445 Prepare for raw dbus/osso rpc interaction.
447 * src/modest-search.h:
448 Changed minsize from unspecific guint to guint32.
450 * src/modest-search.c:
452 Added strange hack which magically made tnymail work.
454 (modest_search_folder),
455 (modest_search_account),
456 (modest_search_all_accounts):
457 Implement helper functions to search all accounts, specific account
460 * tests/dbus_api/Makefile.am:
461 * tests/dbus_api/test_open_message.c:
462 Read url to open from commandline.
464 * tests/dbus_api/test_search.c:
465 Implement small test for dbus search stuff
467 2007-06-02 Armin Burgmeier <armin@openismus.com>
469 * src/maemo/modest-account-settings-dialog.c: Changed window title to
470 include account type and account title. This fixes projects.maemo.org
473 * src/maemo/modest-account-view-window.c: Set a title for the window.
475 2007-06-02 Armin Burgmeier <armin@openismus.com>
477 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
478 incoming and outgoing server name based on email address and server
479 types as long as the names have not been edited manually. This fixes
480 projects.maemo.org bug NB#58671.
482 2007-06-02 Armin Burgmeier <armin@openismus.com>
484 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
485 server type cannot be changed in future to the incoming details page
486 when creating an account. This fixes projects.maemo.org bug NB#59029.
488 2007-06-02 Armin Burgmeier <armin@openismus.com>
490 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
491 and assigned max width chars so that they wrap instead of being
492 truncated. Fixes projects.maemo.org bug NB#56126.
494 2007-06-02 Armin Burgmeier <armin@openismus.com>
496 * src/maemo/modest-connection-specific-smtp-window.c: Add an
497 introductory note to the connection specific smtp servers dialog, as
498 section 8.12 of the email UI specification requires. This fixes
499 projects.maemo.org bug NB#59212.
501 2007-06-01 Murray Cumming <murrayc@murrayc.com>
503 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
504 Check for running mail operations, and offer to cancel them, as per the UI
505 spec. This fixes projects.maemo.org bug NB#59041 .
506 However, I suspect that tinymail may still use the network connection
507 in ways that we cannot detect or cancel. But it should at least adapt to
510 2007-06-01 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account-store.c: (recreate_all_accounts),
513 (get_cached_accounts), (get_server_accounts): Do more sensible
514 ref-counting of the temporarily-cached outbox accounts list. This seems
515 to fix a crash when entering the password when the password was wrong.
517 2007-06-01 Murray Cumming <murrayc@murrayc.com>
519 * src/gnome/modest-main-window.c: (connect_signals):
520 * src/modest-tny-account-store.c: (get_password),
521 (modest_tny_account_store_alert): Added comments and clues and
522 commented-out code about how we currently fail to deal with connection
523 errors and wrong passwords, and how we should.
525 2007-06-01 Murray Cumming <murrayc@murrayc.com>
527 * src/widgets/modest-retrieve-combo-box.c:
528 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
529 This fixes projects.maemo.org bug NB#58472 .
531 2007-06-01 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/easysetup/modest-easysetup-wizard.c:
534 (create_page_complete_easysetup):
535 (create_page_complete_custom): Correct the last commit,
536 putting the correct sentences in the correct pages.
538 2007-06-01 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/easysetup/modest-easysetup-wizard.c:
541 (create_page_complete_custom): Show the second sentence of text
542 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
545 2007-06-01 Murray Cumming <murrayc@murrayc.com>
547 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
548 Set the leave-on-server conf key by default. This fixes
549 projects.maemo.org bug NB#59258 .
551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-account-view-window.c:
554 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
555 logical ID for the confirmation messages. Fixed projects.maemo.org bug
558 2007-06-01 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/easysetup/modest-easysetup-wizard.c:
561 (create_caption_new_with_asterisk):
562 * src/maemo/modest-account-settings-dialog.c:
563 (create_caption_new_with_asterisk):
564 Uncomment the code to add the asterisk, because they are no longer in the
565 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
566 (update_incoming_server_title): Add an asterisk here too.
568 2007-06-01 Murray Cumming <murrayc@murrayc.com>
570 * src/maemo/modest-maemo-global-settings-dialog.c:
571 (current_connection): Check that we are even connected before trying to
572 get the current connection name, to prevent a warning.
574 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
575 Change the comments because tny_maemo_conic_device_connect() is now meant to
577 * src/modest-mail-operation.c:
578 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
579 make sure we have a connection and fail if we can't connect.
581 2007-05-31 Murray Cumming <murrayc@murrayc.com>
583 * src/maemo/modest-main-window.c:
584 (on_account_store_connecting_finished): Do not try to get the
585 connection ID if we are not really connected. I am surprised that
586 this signal handler is called when we are not connected.
588 2007-05-31 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-error.h:
591 * src/modest-ui-actions.c:
592 (modest_ui_actions_get_msgs_full_error_handler):
593 Renamed an enum, added comments, added an enum
594 for retrieve-limit errors.
596 * src/modest-mail-operation.c: (foreach_add_item),
597 (internal_folder_observer_update), (update_account_thread),
598 (modest_mail_operation_get_msgs_full):
599 (modest_mail_operation_update_account),
600 Added comments about how this works, and some code that should
601 (but does not) check the retrieve-limit. See the TODO comment.
603 2007-05-31 Murray Cumming <murrayc@murrayc.com>
605 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
606 Initialize help_id to fix the build. Warnings are good.
608 2007-05-31 Murray Cumming <murrayc@murrayc.com>
610 * src/widgets/modest-hbox-cell-renderer.c:
611 (modest_hbox_cell_renderer_append):
612 * src/widgets/modest-vbox-cell-renderer.c:
613 (modest_vbox_cell_renderer_append):
614 Fix the last commit by doing an extra ref.
616 2007-05-31 Murray Cumming <murrayc@murrayc.com>
618 * src/widgets/modest-hbox-cell-renderer.c:
619 (modest_hbox_cell_renderer_append):
620 * src/widgets/modest-vbox-cell-renderer.c:
621 (modest_vbox_cell_renderer_append):
622 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
623 to fix the build with Maemo Bora.
624 However, there seems to be a remaining crash, probably due to reference
627 2007-05-30 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account.c:
630 (modest_tny_account_new_for_local_folders):
631 Use hildon_file_system_info_async_new() to get a better name for
632 the memory card account, setting it as the account name.
633 The timing seems to work, but this is probably
634 not the best place to do this. See the TODO comment.
635 * src/maemo/modest-main-window.c: (create_details_widget):
636 * src/widgets/modest-folder-view.c: (text_cell_data):
637 Use the tny account name instead of hardcoding a name.
639 2007-05-30 Christian Kellner <ckellner@openismus.com>
641 * src/modest-search.c: (modest_search):
642 Correctly set part_search_func even if we have already parsed
643 the query and thus a valid OgsTextSearcher object.
645 2007-05-30 Christian Kellner <ckellner@openismus.com>
648 Search and check for libogs.
651 Incooparte the ogs build env.
653 * src/modest-mime-part-search-stream.c:
654 * src/modest-mime-part-search-stream.h:
655 Removed since we do the real searching now in modest-search.c.
657 * src/modest-search.c:
658 * src/modest-search.h:
659 Implement support for ogs. We use that if available and requested
660 and fall back to modest_text_utils_utf8_strcmp (). The search logic
661 should now handle the corner case when the search term is spread
662 across multiple reads.
663 Also the logic in modest_search () was corrected to search all
664 requested fields until one is found.
666 2007-05-30 Murray Cumming <murrayc@murrayc.com>
668 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
671 * src/modest-init.c: Made modest_init_local_folders() take a
672 path and be public so we can iniitialize maildir folders on
675 * src/modest-local-folder-info.h:
676 * src/modest-local-folder-info.c:
677 (modest_local_folder_info_get_maildir_path): Add a path parameter.
679 * src/modest-tny-account.c:
680 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
681 still means the standard local-folders path on the local volume.
683 * src/modest-tny-account-store.c:
684 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
685 signal so we can detect mount/unmount of the MMC1 card, and do an update of
686 all accounts when that happens.
687 (get_server_accounts): If the MMC1 card is mounted, create a store account for
688 this too, so it shows up in the treeview.
690 2007-05-28 Murray Cumming <murrayc@murrayc.com>
692 * src/maemo/modest-maemo-global-settings-dialog.c:
693 (current_connection):
694 * src/widgets/modest-global-settings-dialog.c:
695 (current_connection_default):
696 Use the enum values instead of 0, 1 and -1,
697 to make the code clearer.
699 * src/modest-account-mgr-helpers.c:
700 (modest_account_mgr_get_connection_specific_smtp): Make this code
703 * src/modest-runtime.h:
704 * src/modest-runtime.c:
705 Added modest_runtime_remove_all_send_queues().
706 * src/maemo/modest-main-window.c:
707 (on_account_store_connecting_finished): Recreate the send queues,
708 using the appropriate transport accounts for this new connection.
709 Some futher adapting might be needed if the old send queues are not
710 automatically stopped at this point.
712 * src/modest-tny-account-store.c: (get_server_accounts):
713 Create the connection-specific transport accounts, so that they can
714 be found later by their ID.
716 * src/modest-tny-account.h:
717 * src/modest-tny-account.c:
718 Added modest_tny_account_new_from_server_account_name().
719 modest_tny_account_new_from_server_account(): Do not create the
720 send queues here, because they will be
721 recreated anyway when the connection changes for the first time.
723 2007-05-28 Murray Cumming <murrayc@murrayc.com>
725 * src/modest-local-folder-info.h:
726 * src/modest-local-folder-info.c:
727 (modest_per_account_local_outbox_folder_info_get_maildir_path),
728 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
729 tbox_folder): Take a modest account name instead of a server TnyAccount,
730 so we can have per-modest-account rather than per-transport-account
732 We must make sure that we change or recreate the exisitng send queues
733 when the connection changes for connection-specific transport accounts.
735 * src/modest-tny-account-store.c:
736 (create_per_account_local_outbox_folders): Create outboxed per modest
737 account, not per transport account.
739 * src/modest-tny-account.h:
740 * src/modest-tny-account.c:
741 (modest_tny_account_get_special_folder): For outboxes, get the
742 parent modest account name. The account is ignored for other folders.
743 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
744 modest account name rather than a server TnyAccount.
746 2007-05-25 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account.c:
749 (modest_tny_account_new_from_server_account):
750 Call modest_runtime_get_send_queue() immediately after creating transport
751 accounts, so that they start trying to send email from the outbox as soon
752 as possible at startup. This is probably what we want.
754 * src/modest-mail-operation.c: (update_account_thread):
755 * src/modest-runtime.c: (modest_runtime_get_send_queue):
756 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
757 * src/modest-tny-send-queue.h:
758 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
759 (modest_ui_actions_on_send):
760 Added comments about how sending works, though it needs some more work.
762 2007-05-25 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-tny-account.c:
765 (modest_tny_account_get_special_folder): Add TODO because this fails when
767 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
768 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
769 Do not try to show this window when there is no active account. The UI
770 specs does not tell us what to do in this case.
772 2007-05-24 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/Makefile.am:
777 * src/widgets/Makefile.am: Some dist fixes.
779 2007-05-24 Murray Cumming <murrayc@murrayc.com>
781 * src/maemo/modest-connection-specific-smtp-window.c:
782 (on_button_edit): Make the code clearer, to prevent a double free.
784 2007-05-24 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-account-settings-dialog.c:
787 (modest_account_settings_dialog_set_account_name),
788 Check the connection-specific smtp servers checkbox if there are any.
790 * src/maemo/modest-connection-specific-smtp-edit-window.c:
791 (modest_connection_specific_smtp_edit_window_init):
792 Start with a suitable port number.
794 * src/modest-account-mgr-helpers.h:
795 * src/modest-account-mgr-helpers.c: Added
796 modest_account_mgr_get_has_connection_specific_smtp().
798 (modest_account_mgr_set_connection_specific_smtp),
799 (modest_account_mgr_remove_connection_specific_smtp),
800 (modest_account_mgr_get_has_connection_specific_smtp),
801 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
802 connection-specific smtp server accounts in the account, rather than
803 the server account conf dir.
805 This fixes bug projects.maemo.org bug NB#58263 .
807 * src/modest-tny-account-store.c:
808 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
809 if there are no server accounts yet, to prevent an infinite loop when there
810 are no accounts. Document that one must be called before the other.
812 2007-05-24 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-account-mgr-helpers.c:
815 (modest_account_mgr_get_default_account): Make sure that at least
816 one account is always the default, if there are any enabled accounts.
817 This is just a sanity check that shouldn't be necessary.
819 * src/modest-account-mgr-priv.c:
820 (_modest_account_mgr_account_from_key): Unescape the conf key to
821 get the real account name. For instance, this is an issue if a space
822 was in the account name, which can happen because the account name
823 is generated from the display name.
824 (_modest_account_mgr_get_account_keyname): Always escape the
826 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
827 Unescape the conf keys to get the real account names.
829 For instance, previously the is-default radio button in the accounts
830 list was not checked for any accounts at first. This fixes that,
831 and might fix several similar bugs.
833 2007-05-23 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
836 Removed some debug printfs.
838 2007-05-23 Murray Cumming <murrayc@murrayc.com>
840 Modest on-disk outbox directories are now here, for instance:
841 $HOME/.modest/outboxes/<account-id-1>/outbox
842 $HOME/.modest/outboxes/<account-id-2>/outbox
844 $HOME/.modest/local-folders/outbox
845 so we can have a separate outbox for each account.
846 But they are shown as one outbox in the GtkTreeView, by using a
847 TnyMergeFolder in a ModestTnySimpleFolderStore.
850 * src/modest-tny-simple-folder-store.c:
851 * src/modest-tny-simple-folder-store.h:
852 Added ModestTnySimpleFolderStore, used to contain folders from
853 other folder stores, such as other accounts.
855 * src/modest-tny-outbox-account.h:
856 * src/modest-tny-outbox-account.c:
857 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
858 used for the per-account local outbox folders.
860 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
861 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
862 only use this (internally) now for the non-outbox local folders.
865 * src/modest-init.c: Added modest_init_one_local_folder(), for
866 setting up the directory structure for each local folder.
868 * src/modest-local-folder-info.c:
869 (modest_per_account_local_outbox_folder_info_get_maildir_path),
870 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
872 * src/modest-local-folder-info.h:
873 * src/modest-tny-account-store.c: (on_account_removed),
874 (on_account_changed), (create_per_account_local_outbox_folders),
875 (get_server_accounts), (modest_tny_account_store_get_accounts),
876 (modest_tny_account_store_get_tny_account_by_account),
877 (modest_tny_folder_store_is_virtual_local_folders):
879 * src/modest-tny-account.h:
880 * src/modest-tny-account.c:
881 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
882 to create an on-disk per-account local outbox folder for each
884 (create_per_account_local_outbox_folders): Create a local outbox folder
885 for each transport account.
886 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
887 for all local folders.
889 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
890 instead of using g_object_get/set() directly. It is clearer.
892 (modest_tny_folder_store_get_message_count),
893 (modest_tny_folder_store_get_local_size
894 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
895 because we now use these with non-acount folder stores.
897 (modest_tny_account_get_special_folder),
898 (modest_tny_account_new_from_server_account),
899 (modest_tny_account_new_from_account):
900 (recurse_folders): Adjust to the new outbox system.
902 * src/modest-tny-folder.h:
903 * src/modest-tny-folder.c:
904 (modest_tny_folder_is_local_folder),
905 (modest_tny_folder_get_local_folder_type),
906 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
908 * src/widgets/modest-main-window.h:
909 * src/maemo/modest-main-window.c: (create_details_widget),
910 (modest_main_window_set_contents_style): Show details for any folder store,
913 (modest_tny_folder_get_rules):
914 Remove the const. C does not support constness enough for this.
916 * src/modest-ui-actions.c:
917 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
918 make all outboxes appear as one, in the usual local-folders tree node.
920 (set_active_account_from_tny_account),
921 (modest_ui_actions_on_folder_selection_changed):
922 * src/widgets/modest-folder-view.c: (text_cell_data),
923 (icon_cell_data), (filter_row),
924 (add_account_folders_to_merged_folder),
925 (add_account_folders_to_simple_folder_store), (),
926 (get_cmp_rows_type_pos), (cmp_rows),
927 (modest_folder_view_set_account_id_of_visible_server_account):
928 Adjust to the new outbox system, using generic folder stores and folders
931 2007-05-23 Christian Kellner <ckellner@openismus.com>
933 * src/modest-mail-operation.c:
934 (modest_mail_operation_update_account):
935 Use info->max_size instead of unintialized local var [small
936 build fix]. (Added TODO to review that change since I don't
939 2007-05-23 Marcus Bauer <marcusb@openismus.com>
941 * libmodest-dbus-client/libmodest-dbus-client.c:
942 (libmodest_dbus_client_compose_mail): function added
943 * src/dbus_api/modest-dbus-api.h:
944 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
945 (on_compose_mail): Implementation of the SendAsMail functionality
947 2007-05-22 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-account-mgr.c:
950 (modest_account_mgr_add_server_account): Set the secure-connection
951 conf key for transport accounts as well as store accounts. I don't know
952 why the if was there. For instance, this makes sure that we use SSL
953 for the gmail preset from the easysetup wizard.
955 2007-05-22 Murray Cumming <murrayc@murrayc.com>
957 * src/gnome/modest-main-window.c:
958 (on_account_store_connecting_finished), (connect_signals):
959 * src/maemo/modest-main-window.c:
960 (on_account_store_connecting_finished), (connect_signals),
961 (modest_main_window_new):
962 Handle TnyAccountStore::connecting-finished instead of
963 TnyDevice::connection-changed, because we cannot actually perform
964 operations on accounts until TnyAccountStore has itself responded to
965 the TnyDevice::connection-changed signal. This prevents a GError from
967 Do not try to update at startup, because we (at least on scratchbox)
968 already do an update at startup when the device goes online.
969 This prevents a GError from tinymail.
970 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
971 Added TODO about stopping simultaneous operations.
973 2007-05-21 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
976 * src/modest-mail-operation-queue.c:
977 (modest_mail_operation_queue_remove):
978 * src/modest-tny-account-store.c: When GErrors happen, give more clues
979 about where they happened.
981 2007-05-21 Murray Cumming <murrayc@murrayc.com>
983 * src/modest-ui-actions.c:
984 (modest_ui_actions_on_password_requested): Make sure that the remember
985 output parameter is always TRUE.
987 2007-05-21 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
990 Show a OK/Cancel dialog if the error is a question, though we still do not
991 know anything more about what we are asking the user.
992 * src/widgets/modest-folder-view.c: (on_drag_data_received):
993 Fix an uninitialized variable (helper). This is a logic error, however.
995 2007-05-21 Christian Kellner <ckellner@openismus.com>
997 * src/modest-search.h:
998 Correct bit shifting in the ModestSearchFlags enum.
1000 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-tny-account.c:
1003 (modest_tny_account_new_from_server_account): Do not use the lsub and
1004 check-all hard-coded IMAP options when using POP.
1006 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-tny-account.c:
1009 (modest_tny_account_new_from_server_account):
1010 Use NULL for the secure-auth method for POP when Password auth has been
1011 specified by the user, as we already do for IMAP. "auth=Login" causes
1012 an error from camel or the server.
1014 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1016 * src/maemo/modest-account-settings-dialog.c:
1017 (create_page_account_details),
1018 (modest_account_settings_dialog_set_account_name):
1019 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1020 for the leave-on-server checkbox, rathr than just the checkbox, when
1021 the protocol is not POP.
1023 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1025 * src/widgets/modest-account-view.c:
1026 * src/widgets/modest-account-view.h:
1027 Added modest_account_view_select_account() which will be useful later
1028 to asynchronously re-select the edited account.
1030 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/modest-account-settings-dialog.c:
1033 (modest_account_settings_dialog_set_account_name):
1034 Automatically choose the port numbers based on the secure authentication
1035 methods, if they have not been chosen before.
1036 This fixes projects.maemo.org bug NB#56273 .
1038 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/modest-main-window-ui.h:
1041 * src/modest-ui-actions.c:
1042 * src/modest-ui-actions.h:
1043 Connect the Tools/SMTP Servers menu item to
1044 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1045 SMTP servers dialog, as in the UI specification and saves changes when it
1046 is closed. This fixed projects.maemo.org bug NB#56305 .
1048 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1050 * src/maemo/modest-connection-specific-smtp-window.c:
1051 (modest_connection_specific_smtp_window_init):
1052 Use gtk_window_set_default_size() to make this window big enough, so
1053 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1055 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1058 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1059 (modest_connection_specific_smtp_edit_window_init),
1060 Do not try to connect to a combobox signal before the combobox exists.
1061 This fixes the cras in projects.maemo.org bug NB#56288 .
1062 (modest_connection_specific_smtp_edit_window_get_settings):
1063 Remove the server_account_name parameter which was being checked for NULL
1064 though it was not used.
1066 * src/maemo/modest-connection-specific-smtp-window.c:
1067 (modest_connection_specific_smtp_window_fill_with_connections),
1068 (on_button_edit), (modest_connection_specific_smtp_window_init):
1069 Correct the number of treemodel columns to prevent a warning.
1070 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1071 libconic does not work.
1073 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1075 * src/modest-tny-account.c:
1076 (modest_tny_account_new_from_server_account):
1077 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1078 SMTP when "None" was chosen by the user. However, with my SMTP server that
1079 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1082 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1085 to explain the memory management issue with the ID in the ModestPair.
1087 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1088 (add_sending_page), (modest_account_assistant_finalize):
1089 * src/gnome/modest-gnome-global-settings-dialog.c:
1090 (create_updating_page), (create_composing_page):
1091 * src/gnome/modest-msg-edit-window.c: (get_transports),
1092 (init_window), (modest_msg_edit_window_finalize),
1093 (modest_msg_edit_window_get_msg_data):
1094 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1095 * src/gnome/modest-transport-widget.c:
1096 (modest_transport_widget_finalize), (smtp_configuration):
1097 * src/maemo/modest-maemo-global-settings-dialog.c:
1098 (create_updating_page), (create_composing_page):
1099 * src/maemo/modest-msg-edit-window.c: (get_transports),
1100 (init_window), (modest_msg_edit_window_finalize),
1101 (modest_msg_edit_window_get_msg_data),
1102 (modest_msg_edit_window_free_msg_data):
1103 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1104 (modest_store_widget_finalize):
1105 * src/maemo/modest-transport-widget.c:
1106 (modest_transport_widget_finalize), (smtp_configuration):
1107 * src/modest-main.c: (send_mail):
1108 * src/widgets/modest-combo-box.h:
1109 * src/widgets/modest-global-settings-dialog-priv.h:
1110 * src/widgets/modest-global-settings-dialog.c:
1111 (modest_global_settings_dialog_finalize):
1112 * src/widgets/modest-msg-edit-window.h:
1113 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1114 as long as the combo box, to prevent use of freed memory for the ID.
1116 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1119 get_accounts(), to make this clearer. Do not check for the enabled gconf
1120 key, because we do not use this for server accounts (at least, not yet).
1121 This allows us to send email again.
1123 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/modest-platform.c:
1126 (on_modest_conf_update_interval_changed), (modest_platform_init):
1127 Only respond to this particular key change. All these strcmp()s cannot be
1130 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/modest-maemo-global-settings-dialog.c:
1133 (current_connection): Prevent a crash in scratchbox when
1134 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1135 * src/maemo/modest-platform.c:
1136 (on_modest_conf_update_interval_changed), (modest_platform_init):
1137 Get the update interval from gconf and reset it when the gconf key changes.
1139 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-protocol-info.c:
1142 * src/modest-protocol-info.h: Adde enum-specific get functions,
1143 instead of using a ModestProtocolType enum parameter.
1145 * src/gnome/modest-account-assistant.c:
1146 * src/gnome/modest-store-widget.c:
1147 * src/gnome/modest-store-widget.h:
1148 * src/gnome/modest-transport-widget.c:
1149 * src/gnome/modest-transport-widget.h:
1150 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1151 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1152 * src/maemo/easysetup/modest-easysetup-wizard.c:
1153 * src/maemo/modest-account-settings-dialog.c:
1154 * src/maemo/modest-account-settings-dialog.h:
1155 * src/maemo/modest-store-widget.c:
1156 * src/maemo/modest-store-widget.h:
1157 * src/maemo/modest-transport-widget.c:
1158 * src/maemo/modest-transport-widget.h:
1159 * src/modest-account-mgr-helpers.c:
1160 * src/modest-account-mgr-helpers.h:
1161 * src/modest-account-mgr.c:
1162 * src/modest-account-mgr.h:
1163 * src/modest-tny-account.c:
1164 * src/modest-tny-folder.c:
1165 * src/widgets/modest-account-view.c:
1166 * src/widgets/modest-retrieve-combo-box.c:
1167 * src/widgets/modest-retrieve-combo-box.h:
1168 * src/widgets/modest-secureauth-combo-box.c:
1169 * src/widgets/modest-serversecurity-combo-box.c:
1170 * src/widgets/modest-serversecurity-combo-box.h:
1171 * tests/check_account-mgr.c:
1172 Use the specific functions, and use the re-renamed enum values for GNOME too.
1174 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-pair.h:
1177 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1178 so we can get the second based on the first.
1180 * src/maemo/modest-account-settings-dialog.h:
1181 * src/maemo/modest-account-settings-dialog.c:
1182 Added get_supported_secure_authentication_methods(), though it is mostly
1183 commented-out for now until the necessary API is committed to tinymail.
1184 (modest_account_settings_dialog_set_account_name),
1185 (save_configuration): Request the supported authentication methods from the
1186 server, so we can choose a working method.
1188 * src/modest-tny-account-store.h:
1189 * src/modest-tny-account-store.c:
1190 (modest_tny_account_store_get_session): Rename from
1191 tny_account_store_get_session().
1193 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-protocol-info.h: Split the ModestProtocol enum
1196 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1197 There was no need to have these unrelated values in one enum.
1199 * src/: many files: Adapted to changed enum. This makes the code a bit
1200 clearer, and the compiler could catch some errors.
1202 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1205 Show the detailed internal camel error message when an error happens
1206 during the configuration, so that our testers can give us more clues.
1207 For instance, in projects.maemo.org bug NB#56910 .
1209 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1211 * src/modest-tny-account.c:
1212 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1213 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1215 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1217 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1218 * src/maemo/modest-account-settings-dialog.c:
1219 (modest_account_settings_dialog_set_account_name),
1220 (save_configuration): For the incoming secure authentication checkbox,
1221 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1222 the UI specification. PLAIN does not seem to be supported for most IMAP
1223 servers anyway, and I am not sure what it would mean.
1224 However, we probably need to discover which of the secure-authentication
1225 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1226 * src/modest-account-mgr-helpers.c:
1227 (modest_account_mgr_get_server_account_data):
1229 * src/modest-tny-account.c:
1230 (modest_tny_account_new_from_server_account):
1231 Use tny_account_set_mech() to set secure-authentication methods,
1232 with some special-casing for IMAP, based on my observations of how
1235 * src/modest-account-mgr-helpers.h:
1236 * src/modest-account-mgr.c:
1237 * src/modest-defs.h: Comment that the URI is only used for local folders.
1239 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1241 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1242 parameter const, just to be neat.
1243 * src/modest-text-utils.c: (modest_text_utils_inline):
1244 End g_strconcat() with NULL, as its documentation says. This is almost
1245 certainly the cause of my crash at startup on the device. Interestingly,
1246 valgrind doesn't tell us about these errors.
1248 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1250 * scripts/build-packages: Added more precise comments about how to use
1251 this script, though I still get this error:
1252 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1253 error building tinymail
1255 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1257 * src/maemo/modest-main-window.c: (on_account_update):
1258 Very slight cleanup, hoping to make it simpler to discover what causes
1259 a crash here sometimes.
1261 * src/modest-tny-account.c:
1262 (modest_tny_account_new_from_server_account): Set the port. Added
1263 comments about the options and a TODO comment because I need to find out
1264 how to specify the secure authentication method.
1266 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1268 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1269 changed CFlags paths form modest to libmodest
1271 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-account-mgr-helpers.c:
1274 (modest_account_mgr_get_server_account_data),
1275 (modest_account_mgr_free_server_account_data):
1276 * src/modest-account-mgr-helpers.h:
1277 * src/modest-account-mgr.c:
1278 (modest_account_mgr_add_server_account):
1279 * src/modest-defs.h:
1280 * src/modest-tny-account.c:
1281 (modest_tny_account_new_from_server_account):
1282 Determine the options for tny_camel_account_add_option() here,
1283 based on the settings, rather than storing them directly in gconf.
1285 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1288 Show a more friendly error dialog now that we expect (from the tinymail
1289 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1291 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1293 * src/maemo/modest-main-window.c: (on_account_update): Check that
1294 account_name is not NULL, to prevent a crash at startup that I am
1295 seeing on the N800. I do wonder why it is NULL.
1297 * src/maemo/easysetup/modest-easysetup-wizard.c:
1298 (create_page_user_details):
1299 * src/maemo/modest-account-settings-dialog.c:
1300 (create_page_user_details), (create_page_outgoing):
1301 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1302 (modest_connection_specific_smtp_edit_window_init):
1303 * src/modest-ui-actions.c:
1304 (modest_ui_actions_on_password_requested):
1305 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1306 might do something useful with the on-screen keyboard.
1308 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/modest-main-window.c: (on_account_update):
1311 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1312 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1314 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-tny-account-store.c: (on_account_changed):
1317 Correct the signature of this signal handler.
1319 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1322 Show a HildonNote instead of a GtkDialog for Maemo.
1324 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1326 * src/widgets/modest-account-view.h:
1327 * src/widgets/modest-account-view.c: (on_account_changed),
1328 (on_account_removed). Added a boolean flag, set/unset by
1329 modest_account_view_block_conf_updates(),
1330 modest_account_view_unblock_conf_updates() to prevent unnecessary
1331 updates, but this is not very useful because the gconf notifications are
1332 so delays (maybe only on Maemo Bora).
1333 So auto-updating is turned off, and these functions do an explicit
1334 update when necessary.
1335 However, something else is still doing too much work when adding/removing
1336 accounts, probably in another part of the application.
1338 * src/maemo/modest-account-view-window.c:
1339 (on_delete_button_clicked), (on_edit_button_clicked),
1340 (on_new_button_clicked): Use the new functions.
1342 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1344 * src/modest-account-mgr-helpers.c:
1345 (modest_account_mgr_set_first_account_as_default):
1346 Sort the list of names alphabetically-by-title, so we choose the first one
1348 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1349 alphabetically by the title.
1351 This fixes projects.maemo.org bug NB#56418 .
1353 * src/modest-account-mgr-priv.c:
1354 (_modest_account_mgr_account_from_key):
1355 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1356 avoid a valgrind error, and possible random behaviour.
1358 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1361 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1362 tinymail documentation to say that this can be expected.
1363 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1364 pretty, and should not happen, but I would prefer to know when it does.
1366 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1368 * configure.ac: When using the older hildon version, probably on Bora,
1369 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1371 * src/widgets/modest-attachment-view.c:
1372 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1375 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1377 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1378 Implemented the prototype. Can be tested with
1379 tests/dbus_api/test_open_message:
1381 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-tny-account-store.c:
1384 (modest_tny_account_store_instance_init), (get_password):
1385 * src/modest-ui-actions.c:
1386 (modest_ui_actions_on_password_requested):
1387 Do not store the password in gconf, because this function is called
1388 for non-remembered passwords. Actually use the cached (in the hash map)
1389 password instead of releasing it.
1390 The password will now not be remembered if it is asked via the protected
1391 password dialog, as per the UI spec.
1393 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-defs.h:
1396 * src/modest-account-mgr-helpers.h:
1397 * src/modest-account-mgr-helpers.c:
1398 Added modest_server_account_get_username_has_succeeded(),
1399 modest_server_account_set_username_has_succeeded().
1400 (modest_server_account_set_username),
1401 Reset the has-succeeded flag if the username changes.
1403 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1404 * src/maemo/modest-connection-specific-smtp-window.c:
1405 (modest_connection_specific_smtp_window_save_server_accounts):
1406 Use modest_server_account_set_username() instead of using
1407 modest_conf_set_string() directly, so that the has-succeeded flag is always
1410 * src/modest-ui-actions.c:
1411 (modest_ui_actions_on_password_requested): Dim the username entry if
1412 the username has ever worked, as per the UI spec.
1414 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1416 * src/modest-tny-account-store.c: (get_password):
1417 * src/modest-ui-actions.c:
1418 (modest_ui_actions_on_password_requested):
1419 Allow the username to be changed too, though there is more work to
1420 be done on exactly how this behaves.
1422 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1424 * src/modest-account-mgr-helpers.h:
1425 * src/modest-account-mgr-helpers.c:
1426 Added modest_account_mgr_get_display_name(),
1427 modest_server_account_get_username(),
1428 modest_server_account_set_username(),
1429 modest_server_account_set_password(),
1430 modest_server_account_get_hostname() functions so we do not need to
1431 use the conf API directly.
1433 * src/maemo/modest-main-window.c: (connect_signals):
1434 Actually connect ot the ModestAccountStore::request-password signal,
1435 so that we show the dialog when the password is requested by Tinymail,
1436 for isntance if it is empty.
1438 * src/modest-marshal.list:
1439 * src/modest-tny-account-store.c:
1440 (modest_tny_account_store_class_init), (get_password),
1441 (modest_tny_account_store_alert):
1442 * src/modest-tny-account-store.h:
1443 * src/modest-ui-actions.h:
1444 * src/modest-ui-actions.c:
1445 (modest_ui_actions_on_password_requested):
1446 Change the signal parameters, so it is obvious that we are providing
1447 the non human-readable server name, and receiving both the username
1448 and password, though changing of the username is not yet implemented.
1449 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1450 for the GNOME version.
1452 This should fix the projects.maemo.org bug NB#56209, though it does not
1453 work on Bora, because the gconf_client_get() for the password fails
1454 immediately after we save it with gconf_client_set().
1456 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1459 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1460 caused an undefined symbol error:
1461 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1463 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1465 * src/modest-tny-account-store.c:
1466 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1467 using a GError instead of a string message, so we can translate it in
1470 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1472 * src/maemo/modest-address-book.c:
1473 (modest_address_book_check_names):
1474 * src/maemo/modest-msg-view-window.c:
1475 (modest_msg_view_window_clipboard_owner_change):
1476 * src/modest-init.c: (modest_init_init_ui):
1477 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1478 (update_folders_cb), (modest_mail_operation_update_account):
1479 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1480 (modest_ui_actions_on_msg_attachment_clicked),
1481 (modest_ui_actions_on_msg_recpt_activated):
1482 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1483 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1484 (modest_msg_view_search_next):
1485 * src/widgets/modest-recpt-editor.c:
1486 (modest_recpt_editor_on_button_release_event),
1487 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1488 g_message(). At this point we should only be seeing interesting errors on
1489 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1491 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1493 (modest_wizard_dialog_force_title_update):
1494 * src/maemo/easysetup/modest-wizard-dialog.h:
1495 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1496 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1497 can update the title when appropriate. Otherwise the title is wrong if the
1498 pages are added after adding the notebook to the dialog.
1499 This must be a problem in HildonWizardDialog too.
1500 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1502 * src/maemo/easysetup/modest-easysetup-wizard.c:
1503 (create_subsequent_customsetup_pages),
1504 (create_subsequent_easysetup_pages):
1505 Call modest_wizard_dialog_force_title_update() so that the title is
1506 correct even with GTK+ < 2.10.
1507 This fixes projects.maemo.org bug NB#56145 .
1509 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1511 * src/maemo/modest-platform.c:
1512 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1513 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1516 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1518 * src/widgets/modest-window.h:
1519 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1520 and modest_window_save_state(), which invokes it.
1522 * src/widgets/modest-window-mgr.h:
1523 * src/widgets/modest-window-mgr.c:
1524 Added modest_window_mgr_save_state_for_all_windows(), which calls
1525 the save_state vfunc on all registered windows, if implemented.
1527 * src/gnome/modest-msg-edit-window.c:
1528 * src/gnome/modest-msg-view-window.c:
1529 * src/maemo/modest-msg-edit-window.c:
1530 * src/maemo/modest-msg-view-window.c:
1531 * src/maemo/modest-main-window.c:
1532 Specify the existing save_settings functions as implementations of
1533 ModestWindow::save_state_func().
1535 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1536 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1537 enabling hibernation, for instance.
1539 We may need to do the same thing for restoring settings.
1542 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1544 * src/widgets/modest-window-mgr.c:
1545 * src/widgets/modest-window-mgr.h:
1546 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1547 modest_window_mgr_get_hibernation_is_prevented().
1549 * src/maemo/modest-main-window.c:
1550 (on_hildon_program_is_topmost_notify): Prevent hibernation
1551 (possible when the application goes to the background in the WM),
1552 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1554 * src/maemo/easysetup/modest-easysetup-wizard.c:
1555 (modest_easysetup_wizard_dialog_init):
1556 * src/maemo/modest-account-settings-dialog.c:
1557 (modest_account_settings_dialog_init):
1558 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1559 (modest_connection_specific_smtp_edit_window_init):
1560 * src/maemo/modest-connection-specific-smtp-window.c:
1561 (modest_connection_specific_smtp_window_init):
1562 * src/maemo/modest-signature-editor-dialog.c:
1563 (modest_signature_editor_dialog_init):
1564 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1565 prevent hibernation while any of these account settings dialogs are open.
1567 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/Makefile.am:
1570 * src/maemo/modest-osso-state-saving.c:
1571 * src/maemo/modest-osso-state-saving.h: Added
1572 modest_osso_load_state() and modest_osso_save_state() though they do
1573 nothing now. They should iterate through all the open windows and load/save
1575 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1576 save state when closing.
1578 * src/maemo/modest-main-window.c:
1579 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1580 Add a notification handler for the HildonProgram::is-topmost property,
1581 so we can allow hibernation when the application goes into the background.
1582 But we still need to detect when the accounts setup windows are open so
1583 we can stop hibernation when they are open.
1584 To do this, I also added the main window the HildonProgram. This might have
1585 other side-effects/benefits, and should maybe be done for other windows.
1587 * src/maemo/modest-osso-autosave-callbacks.h:
1588 * src/maemo/modest-osso-autosave-callbacks.c:
1589 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1590 though it does not do anything yet, and we might never need this to do
1591 anything. For instance, we already save drafts.
1593 * src/maemo/modest-platform.c: (modest_platform_init):
1594 Specify the libosso auto-save callback.
1596 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-platform.c:
1599 (modest_platform_set_update_interval):
1600 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1601 aparently stays valid between application instances, so we can use this
1602 to remove and reset it later. According to a maemo-developers email from
1605 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1607 * configure.ac: Depend on libalarm for Maemo.
1609 * src/dbus_api/modest-dbus-api.h:
1610 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1611 (on_send_receive), (modest_dbus_req_handler):
1612 Handle a SEND_RECEIVE D-Bus method.
1614 * libmodest-dbus-client/libmodest-dbus-client.c:
1615 (libmodest_dbus_client_send_and_receive):
1616 * libmodest-dbus-client/libmodest-dbus-client.h:
1617 Add C convenience functions for calling the new D-Bus method.
1619 * src/modest-platform.h:
1620 * src/gnome/modest-platform.c:
1621 * src/maemo/modest-platform.c:
1622 Added modest_platform_set_update_interval(), which uses the
1623 alarmd API on Maemo.
1624 (modest_platform_init),
1625 Call modest_platform_set_update_interval(), using a hard-coded
1626 interval for now (until the global settings dialog is implemented),
1627 though I am not sure that this makes sense yet.
1629 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1631 * src/dbus_api/modest-dbus-callbacks.c:
1632 (modest_osso_cb_hw_state_handler):
1633 * src/dbus_api/modest-dbus-callbacks.h:
1634 * src/maemo/modest-platform.c: (modest_platform_init):
1635 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1636 in case this has some effect on the ability for Maemo to ping the
1639 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1641 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1642 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1643 warning. It is probably a logic error, but I need to fix the build.
1645 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-account-mgr.h:
1648 * src/modest-account-mgr.c:
1649 (modest_account_mgr_account_names): Add a gboolean enabled_only
1650 parameter, so we can get lists of onlt the enabled accounts.
1652 (modest_account_mgr_add_account),,
1653 (modest_account_mgr_account_with_display_name_exists):
1654 * src/maemo/modest-msg-edit-window.c: (get_transports):
1655 * src/modest-account-mgr-helpers.c:
1656 (modest_account_mgr_set_first_account_as_default):
1657 * src/modest-init.c: (init_default_account_maybe):
1658 * src/modest-tny-account-store.c: (get_accounts):
1659 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1660 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1661 * tests/check_account-mgr.c: (START_TEST):
1662 Provide the extra parameter, as appropriate.
1664 * src/widgets/modest-account-view.c: (update_account_view):
1665 Do not show disabled accounts (meaning that there is no way to
1666 enable/disable accounts in the UI (the feature is not in our UI
1667 specification), so we can use this internally only to mark unfinished
1668 or temporary account data.
1670 * src/maemo/easysetup/modest-easysetup-wizard.c:
1671 (create_account): Add boolean enable parameter, so we can specify FALSE
1672 to create the temporary account.
1673 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1674 (on_before_next): When finishing, when there is a temporary account, just
1676 Also, use a timeout to delay the showing of the dialog until gconf is likely
1677 to return correct information, due to a maemo gconf bug that is fixed in
1678 osso 1.1, but not yet in Bora.
1679 However, the dialog stays on screen after it is destroyed.
1681 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1682 for invalid data when cancelling. Use a hildon note instead of a dialog
1683 to complain about invalid data. Do not show the account-saved note if the
1684 account is disabled (a temporary account that will not really be saved for use
1687 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1689 * src/modest-account-mgr-helpers.h:
1690 * src/modest-account-mgr-helpers.c:
1691 Added modest_account_mgr_unset_default_account(),
1692 Added modest_account_mgr_set_first_account_as_default().
1694 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1695 If it was the default account, unset the default account name.
1697 * src/maemo/modest-account-view-window.c:
1698 (on_delete_button_clicked): If it was the default account,
1699 set the first remaining account as the default instead.
1701 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1702 a NULL account or a NULL default account, to prevent a crash. This should
1703 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1706 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1708 * src/widgets/modest-recpt-editor.c:
1709 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1710 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1711 TODO comment for this. This fixes the build.
1713 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1714 be the best place for it. This will in future update all auto-update accounts,
1715 rather than just the current/default account, when that gconf key exists.
1716 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1717 if there are no accounts, before calling do_send_receive().
1718 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1720 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1721 * src/maemo/modest-main-window-ui.h:
1722 * src/maemo/modest-main-window.c: (on_connection_changed),
1723 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1724 directly, becaue the signal handler does more.
1726 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-account-mgr-helpers.c:
1729 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1730 for the case that the account does not exist.
1732 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1733 (equivalent to the modest account name) rather than the tinymail account name
1734 (equivalent to the modest account title - human readable) to get the account data.
1735 Check for null account data to prevent the crash, and add a TODO comment saying that
1736 this needs fixing because it is using the server account name instead of the account name.
1738 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1741 * src/maemo/modest-account-settings-dialog.c: (show_error),
1743 Use hildon_note_new_information() for informative and error messages,
1744 which seems to be expected for Maemo applications (no documentation that I know of
1745 says this). I am surprised that there is no distinction between info and error
1748 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1751 it is easy to find where this is used.
1753 * src/maemo/easysetup/modest-easysetup-wizard.c:
1754 (create_page_welcome), (create_page_account_details),
1755 (create_page_user_details), (create_page_complete_easysetup),
1756 (create_page_custom_incoming), (create_page_custom_outgoing),
1757 (create_page_complete_custom):
1758 * src/maemo/modest-account-settings-dialog.c:
1759 (create_page_account_details), (create_page_user_details),
1760 (create_page_incoming), (create_page_outgoing):
1761 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1762 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1763 (modest_connection_specific_smtp_edit_window_init):
1764 * src/maemo/modest-connection-specific-smtp-window.c:
1765 (modest_connection_specific_smtp_window_init):
1766 * src/maemo/modest-signature-editor-dialog.c:
1767 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1768 and scrolling policy as per the Email Application Layout Guide, if I have
1771 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1774 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1775 which were empty, because these vfuncs have been removed from TnyAccountStore.
1776 This fixes the build.
1778 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1780 * src/maemo/modest-main-window.c:
1781 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1782 showing/hiding it. Added TODO because it probably should not be NULL.
1783 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1784 because unnecessary g_warnings() make degugging difficult.
1786 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/modest-msg-edit-window.c:
1789 (modest_msg_edit_window_select_color),
1790 (modest_msg_edit_window_select_background_color): 2 const corrections and
1791 moving 2 #endifs before closing brackets, to fix the build.
1793 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1795 * src/maemo/easysetup/modest-easysetup-wizard.h:
1796 * src/maemo/easysetup/modest-easysetup-wizard.c:
1797 (modest_easysetup_wizard_dialog_finalize),
1798 (on_button_edit_advanced_settings), (create_page_complete_custom),
1799 (on_response), (create_account):
1800 Implement the Advanced Settings edit button, by saving the account information,
1801 for the Advanded Settings dialog to use directly from gconf, and removing it
1802 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1803 Bug #5533 in the projects.maemo.org bugzilla.
1805 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1807 * src/maemo/modest-msg-view-window.c:
1808 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1809 when opening a message window.
1811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/easysetup/modest-easysetup-wizard.c:
1814 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1817 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1818 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1819 gconf settings. I probably added more checks than necessary, but that is safer.
1821 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1822 variable to fix the build, but this seems to be used when it is still NULL.
1824 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-platform.h:
1827 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1828 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1829 * src/modest-main.c: Implement this function so we can avoid using
1830 maemo-specific API from cross-platform code.
1832 * src/modest-tny-account-store.c:
1833 (get_smtp_specific_transport_account_for_open_connection):
1834 * src/modest-ui-actions.c: (check_for_connection),
1835 (modest_ui_actions_on_item_not_found):
1836 Use modest_platform_connect_and_wait() and put #idefs around other
1837 maemo-specific code, because only maemo currently has a way to
1838 identify connection names.
1840 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-tny-account-store.h:
1843 * src/modest-tny-account-store.c:
1844 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1845 the connection-specific SMTP server settings in the configuration.
1847 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1849 * src/maemo/modest-main-window.c: (on_connection_changed),
1851 * src/modest-main.c: (main), (start_ui), (send_mail):
1852 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1853 that is what is intended.
1855 * src/modest-ui-actions.c: (action_send), (action_receive),
1856 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1857 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1858 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1859 SMTP server is used when it is specified.
1861 (modest_ui_actions_on_send_receive):
1862 Check that a connection is open before proceeding.
1863 Receive and then send, instead of vice-versa, as per the specification.
1865 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-mail-operation.c:
1868 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1869 though I guess it should be something other than NULL.
1871 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1873 * src/maemo/easysetup/modest-easysetup-wizard.c:
1874 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1875 combo twice, to avoid an g_warning and to make it visible again.
1876 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1877 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1878 (already intended) dereference when detaching, because we then recreate the menu.
1879 But I am not sure why the warning was happening, and it is possible that this is a memory
1882 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1884 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1885 and uri_parse_mailto() utility functions.
1886 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1888 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1890 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1892 * src/dbus_api/modest-dbus-api.h:
1893 * src/dbus_api/modest-dbus-callbacks.c:
1894 Use an idle callback to execute the modest code in the application's own thread.
1895 Remove the helloworld example method.
1896 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1897 parsed, and the open-message method is not implemented because this is not yet implemented in
1899 * libmodest-dbus-client/libmodest-dbus-client.c:
1900 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1901 (libmodest_dbus_client_open_message):
1902 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1904 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1905 body without crashing.
1907 * tests/dbus_api/Makefile.am:
1908 * tests/dbus_api/test_mail_to.c:
1909 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1911 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1913 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1914 Added file to fix the build. Sorry.
1916 * src/dbus_api/Makefile.am:
1917 * src/dbus_api/modest-dbus-api.h:
1918 * src/dbus_api/modest-dbus-callbacks.h:
1919 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1920 (modest_dbus_req_handler):
1921 Put constants in a separate header so it can be reused by the
1922 client library, without duplication
1924 * libmodest-dbus-client/Makefile.am:
1925 * libmodest-dbus-client/libmodest-dbus-client.c:
1926 (libmodest_dbus_client_call_helloworld),
1927 (libmodfest_dbus_client_send_mail),
1928 (libmodfest_dbus_client_mailto),
1929 (libmodfest_dbus_client_open_message):
1930 * libmodest-dbus-client/libmodest-dbus-client.h:
1931 (Partly) Implement a send_mail D-Bus method.
1933 * tests/dbus_api/Makefile.am:
1934 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1935 the send_email D-Bus method.
1937 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1941 * libmodest-dbus-client/Makefile.am:
1942 * libmodest-dbus-client/libmodest-dbus-client.c:
1943 * libmodest-dbus-client/libmodest-dbus-client.h:
1944 * tests/dbus_api/Makefile.am:
1945 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1946 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1948 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/easysetup/modest-easysetup-wizard.c:
1951 (create_page_account_details):
1952 * src/maemo/modest-account-settings-dialog.c:
1953 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1954 widgets, because this might not be the default in future versions of the Maemo GTK+.
1955 However, I can not not get capitalization to work even in a simple test case.
1957 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/easysetup/modest-easysetup-wizard.c:
1960 (create_page_custom_incoming), (create_page_custom_outgoing):
1961 * src/maemo/modest-account-settings-dialog.c:
1962 (create_page_account_details), (create_page_incoming),
1963 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1964 instead of using gtk_check_button_with_label(), so they are aligned like the other
1965 widgets, as per the UI spec.
1967 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/easysetup/modest-easysetup-wizard.c:
1970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1971 * src/widgets/modest-validating-entry.c:
1972 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1973 Modest prefix instead of an EasySetup prefix.
1975 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1977 * src/widgets/modest-validating-entry.h:
1978 * src/widgets/modest-validating-entry.c: (on_insert_text),
1979 Added easysetup_validating_entry_set_max_func(), used to set a callback
1980 to call when the max number of characters is reached. GtkEntry has a max-length
1981 already but is silent about it.
1983 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1984 (create_page_account_details), (create_page_user_details),
1986 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1987 (create_page_account_details), (create_page_user_details),
1988 (create_page_outgoing):
1989 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1990 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1991 the UI spec, when the user tries to enter more than the max number of characters.
1993 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 (create_page_user_details), (create_page_custom_incoming),
1997 (create_page_custom_outgoing):
1998 * src/maemo/modest-account-settings-dialog.c:
1999 (create_page_user_details), (create_page_incoming),
2000 (create_page_outgoing):
2001 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2002 (modest_connection_specific_smtp_edit_window_init):
2003 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2004 not appropriate. Bad Maemo-specific defaults!.
2006 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2009 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2010 (modest_signature_editor_dialog_set_settings):
2011 Disable the label and textview when the checkbox is disabled, and use the
2012 specified (UI spec) default signature text.
2014 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2017 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2019 * src/modest-defs.h:
2020 * src/modest-account-mgr-helpers.h:
2021 * src/modest-account-mgr-helpers.c:
2022 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2024 * src/maemo/Makefile.am:
2025 * src/maemo/modest-signature-editor-dialog.c:
2026 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2029 * src/maemo/modest-account-settings-dialog.h:
2030 * src/maemo/modest-account-settings-dialog.c:
2031 (modest_account_settings_dialog_finalize), (on_button_signature),
2032 (save_configuration): Use the new dialog when the Edit button is pressed, and
2033 save the changes if necessary, as per the UI spec.
2035 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/Makefile.am:
2038 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2039 based on maemo-develoers email from Dirk.
2041 * src/maemo/easysetup/modest-easysetup-wizard.c:
2042 (create_page_welcome), (create_page_account_details),
2043 (create_page_user_details), (create_page_complete_easysetup),
2044 (create_page_custom_incoming), (create_page_custom_outgoing),
2045 (create_page_complete_custom),
2046 (modest_easysetup_wizard_dialog_init):
2047 * src/maemo/modest-account-settings-dialog.c:
2048 (create_page_account_details), (create_page_user_details),
2049 (create_page_incoming), (create_page_outgoing),
2050 (modest_account_settings_dialog_init):
2051 * src/maemo/modest-connection-specific-smtp-window.c:
2052 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2054 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/easysetup/modest-easysetup-wizard.c:
2057 (create_page_account_details), (create_page_custom_outgoing),
2058 (create_page_complete_custom):
2059 * src/maemo/modest-account-settings-dialog.c:
2060 (create_page_user_details), (create_page_incoming),
2061 (create_page_outgoing):
2062 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2063 (modest_connection_specific_smtp_edit_window_init):
2064 Use the correct (UI spec) port min/max, and use horizontal separators,
2067 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/easysetup/modest-easysetup-wizard.c:
2070 (set_default_custom_servernames):
2071 * src/maemo/modest-account-settings-dialog.c:
2072 (create_page_incoming), (on_combo_outgoing_security_changed),
2073 (on_combo_incoming_security_changed), (create_page_outgoing),
2074 (modest_account_settings_dialog_set_account_name),
2075 (save_configuration):
2076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2077 (on_combo_security_changed),
2078 (modest_connection_specific_smtp_edit_window_init),
2079 (modest_connection_specific_smtp_edit_window_set_connection),
2080 (modest_connection_specific_smtp_edit_window_get_settings):
2081 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2084 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/easysetup/modest-easysetup-wizard.c:
2088 (create_page_custom_outgoing), (create_page_complete_custom):
2089 * src/maemo/modest-account-settings-dialog.c:
2090 (create_page_user_details), (create_page_outgoing):
2091 * src/maemo/modest-account-view-window.c: (button_box_new):
2092 Use changed logical IDs as per the most recent UI spec:
2093 mcen_bd_emailsetup_edit -> mcen_bd_edit
2094 mcen_bd_emailsetup_delete -> mcen_bd_delete
2095 mcen_bd_emailsetup_close -> mcen_bd_close
2097 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2101 * src/dbus_api/Makefile.am:
2102 * src/dbus_api/modest-dbus-callbacks.c:
2103 * src/dbus_api/modest-dbus-callbacks.h:
2104 * src/maemo/modest-platform.c: (modest_platform_init):
2105 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2107 * tests/Makefile.am:
2108 * tests/dbus_api/Makefile.am:
2109 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2111 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2113 * src/maemo/modest-account-settings-dialog.c:
2114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2115 Removed unnecessary includes.
2117 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/easysetup/modest-easysetup-wizard.c:
2120 * src/maemo/modest-account-settings-dialog.c:
2121 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2122 * src/widgets/Makefile.am:
2123 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2124 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2125 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2126 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2127 * src/widgets/modest-secureauth-combo-box.c:
2128 * src/widgets/modest-secureauth-combo-box.h:
2129 * src/widgets/modest-serversecurity-combo-box.c:
2130 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2131 made the GObject names more consistent with the rest of the Modest code.
2133 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/easysetup/Makefile.am:
2136 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2137 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2138 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2139 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2140 * src/maemo/easysetup/modest-easysetup-wizard.c:
2141 * src/maemo/easysetup/modest-validating-entry.c:
2142 * src/maemo/easysetup/modest-validating-entry.h:
2143 * src/maemo/modest-account-settings-dialog.c:
2144 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2145 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2146 widgets/ because they are used outside of easysetup too. After checking in,
2147 svn will allow me to rename them too.
2149 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2151 * src/gnome/modest-msg-edit-window.c:
2152 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2153 linker error, to fix the build on the GNOME platform.
2154 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2155 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2156 ifdefed out to avoid a warning.
2158 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2160 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2161 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2162 some alternative for GTK+ 2.6.
2164 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2168 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2169 specified for EmailAccountsDialog in UI spec.
2171 * src/maemo/easysetup/modest-easysetup-wizard.c:
2172 * src/maemo/easysetup/modest-easysetup-wizard.h:
2173 * src/maemo/modest-account-settings-dialog.c:
2174 * src/maemo/modest-account-settings-dialog.h:
2175 Reuse a member window widget for the connection-specific SMTP server accounts,
2176 so we can tell it to create/save the accounts only if we actually save changes.
2178 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2179 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2180 (modest_connection_specific_smtp_edit_window_get_settings):
2181 Return a struct instance for temporarily remembering the entered data.
2183 * src/maemo/modest-connection-specific-smtp-window.h:
2184 * src/maemo/modest-connection-specific-smtp-window.c:
2185 (modest_connection_specific_smtp_window_finalize),
2186 (modest_connection_specific_smtp_window_fill_with_connections),
2188 (modest_connection_specific_smtp_window_save_server_accounts),
2189 (update_model_server_names): Do not actually save data until asked,
2190 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2192 (on_selection_changed),
2193 (modest_connection_specific_smtp_window_init): Disable the edit
2194 button when nothing is selected.
2196 * src/modest-account-mgr-helpers.c:
2197 * src/modest-account-mgr-helpers.h:
2198 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2201 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2203 * src/modest-account-mgr-helpers.h:
2204 * src/modest-account-mgr-helpers.c:
2205 (modest_account_mgr_get_unused_account_name),
2206 (modest_account_mgr_get_unused_account_display_name): Added these
2207 utility functions, to avoid code duplication.
2209 * src/maemo/easysetup/modest-easysetup-wizard.c:
2210 (create_page_account_details), (create_account):
2211 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2212 (on_combo_security_changed),
2213 (modest_connection_specific_smtp_edit_window_init),
2214 (modest_connection_specific_smtp_edit_window_save_settings):
2215 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2216 * src/maemo/modest-connection-specific-smtp-window.c:
2217 (modest_connection_specific_smtp_window_finalize),
2218 (modest_connection_specific_smtp_window_fill_with_connections),
2219 (on_button_edit), (modest_connection_specific_smtp_window_init):
2220 * src/maemo/modest-connection-specific-smtp-window.h:
2221 Implementing saving of connection-specific server accounts.
2223 But I need to refactor this so we can save the data for each
2224 possible connection-specific account and only actually create the server accounts
2225 when the easysetup finished, or the OK button is pressed on the account settings
2228 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2231 (on_combo_security_changed):
2232 (modest_connection_specific_smtp_edit_window_init):
2233 Auto-fill the port number as in the account settings.
2235 (modest_connection_specific_smtp_edit_window_set_connection):
2236 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2237 * src/maemo/modest-connection-specific-smtp-window.c:
2238 (fill_with_connections), (on_button_edit),
2239 (modest_connection_specific_smtp_window_init):
2240 Turn the edit window into a dialog to simplify the code, and
2241 set a WM hint as in a GtkDialog, because only a popup can be on top of
2242 another window in Maemo, and popups usually have no WM decoration.
2244 * src/modest-defs.h:
2245 * src/modest-account-mgr-helpers.c:
2246 (modest_account_mgr_set_connection_specific_smtp),
2247 (modest_account_mgr_remove_connection_specific_smtp),
2248 (modest_account_mgr_get_connection_specific_smtp):
2249 * src/modest-account-mgr-helpers.h: Some functions to write the
2250 connection-specific SMTP server information. Not yet used.
2253 * src/widgets/modest-folder-view.c: (text_cell_data):
2254 Fix a warning about an uninitialized variable.
2255 (on_configuration_key_changed): Put an #ifdef around the use
2256 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2258 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/modest-account-settings-dialog.h:
2261 * src/maemo/modest-account-settings-dialog.c:
2262 Added connect_for_modified() utility function to mark the new modified boolean.
2264 (create_page_account_details), (create_page_user_details),
2265 (create_page_incoming), (create_page_outgoing), (on_response),
2266 (modest_account_settings_dialog_init),
2267 (modest_account_settings_dialog_set_account_name):
2268 Only warn about unsaved changes when there are actually unsaved changes.
2270 * src/modest-account-mgr-helpers.c:
2271 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2272 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2273 to get the data from there in future.
2275 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-defs.h:
2279 * src/modest-account-mgr-helpers.h:
2280 * src/modest-account-mgr-helpers.c:
2281 Store the security account setting in a single conf key instead of using
2282 the options list, so that the list is left for just the to-be-removed camel hack,
2283 and because gconf_client_set_list() is failing for some reason.
2285 * src/modest-account-mgr.c:
2286 (modest_account_mgr_add_server_account):
2287 * src/maemo/modest-account-settings-dialog.c:
2288 (modest_account_settings_dialog_set_account_name),
2289 (save_configuration): Use the renamed functions.
2292 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2294 * src/widgets/Makefile.am:
2295 * src/widgets/modest-limit-retrieve-combo-box.c:
2296 * src/widgets/modest-limit-retrieve-combo-box.h:
2297 * src/widgets/modest-retrieve-combo-box.c:
2298 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2299 the account settings dialog.
2301 * src/modest-defs.h:
2302 * src/modest-account-mgr-helpers.h:
2303 * src/modest-account-mgr-helpers.c:
2304 (modest_server_account_get_option_secure_auth),
2305 (modest_server_account_set_option_secure_auth):
2306 * src/modest-account-mgr.c:
2307 (modest_account_mgr_add_server_account):
2308 Use the existing AUTH_MECH conf key for the secure-auth setting,
2309 instead of putting it in the list options, because this was actually used already.
2311 * src/maemo/modest-account-settings-dialog.c:
2312 (create_page_account_details),
2313 (modest_account_settings_dialog_set_account_name),
2314 (save_configuration):
2315 * src/maemo/modest-account-settings-dialog.h:
2316 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2317 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2319 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2322 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2323 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2325 * src/modest-defs.h:
2326 * src/maemo/modest-account-settings-dialog.c:
2327 (create_page_incoming), (on_combo_outgoing_security_changed),
2328 (on_combo_incoming_security_changed), (create_page_outgoing),
2329 (modest_account_settings_dialog_set_account_name),
2330 (save_configuration): Load/Save the port number, and change it when the
2331 security combo changes, to suitable defaults.
2333 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2335 * src/modest-account-mgr.c:
2336 (modest_account_mgr_add_server_account): Set the security and secure-auth
2337 options, and add a comment saying that the other camel-specific options should be
2340 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2344 * src/modest-tny-account-store.c: (account_list_free),
2345 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2346 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2349 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2351 * src/modest-protocol-info.c:
2352 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2353 is required by our UI spec. Maybe something in our implementation will use this eventually.
2354 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2355 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2356 instead of the previous 0 placeholder.
2358 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2359 secure-auth settings.
2360 * src/modest-account-mgr-helpers.h:
2361 * src/modest-account-mgr-helpers.c:
2362 (modest_server_account_data_get_option_secure_auth),
2363 (modest_server_account_set_option_secure_auth),
2364 (modest_server_account_data_get_option_security),
2365 (modest_server_account_set_option_security): Added this API for getting and setting the security
2366 and secure-auth settings.
2368 * src/maemo/modest-account-settings-dialog.h:
2369 * src/maemo/modest-account-settings-dialog.c:
2370 (modest_account_settings_dialog_finalize), (check_data),
2371 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2372 about changing titles.
2373 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2374 (save_configuration): Save the security and secure-auth settings.
2376 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2377 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2379 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-defs.h:
2382 * src/modest-account-mgr.c:
2383 (modest_account_mgr_add_server_account):
2384 Added and used defines for the options key and value pair strings,
2385 that are used so far, though they do not seem to correspond to anything in our
2386 UI specs or ModestProtocol enum.
2388 * src/modest-account-mgr-helpers.h:
2389 * src/modest-account-mgr-helpers.c:
2390 (compare_option_strings_for_name),
2391 (modest_server_account_data_get_option_value),
2392 (modest_server_account_data_get_option_bool),
2393 (modest_account_mgr_get_server_account_option):
2394 Added helper functions for parsing the options GSList.
2396 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2399 display name is based on the supplied account name.
2400 * src/modest-account-mgr.c:
2401 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2402 with an inefficient, but good-enough, implementation.
2404 * src/maemo/easysetup/modest-easysetup-wizard.c:
2405 (create_page_account_details), (on_before_next), (create_account):
2406 Check for existing display names rather than (non-user-visible) account names, and just
2407 create and set a unique account name at the end.
2409 * src/maemo/modest-account-settings-dialog.c:
2410 (modest_account_settings_dialog_init),
2411 (modest_account_settings_dialog_set_account_name),
2412 (create_page_incoming): Show the display name, instead of the account name.
2413 (on_response): Do some (not all) extra checks, as in the UI spec.
2414 (save_configuration): Save the display name if it was changed.
2416 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2418 * po/en_GB.po: Added needed logical ID and translation.
2419 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2420 (init_view): Made the is-default column clicking work.
2422 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2425 * src/maemo/easysetup/Makefile.am:
2426 * src/maemo/easysetup/modest-easysetup-wizard.c:
2427 (modest_easysetup_wizard_dialog_init):
2428 * src/maemo/easysetup/provider-data-test.keyfile:
2429 * src/maemo/easysetup/provider-data.keyfile:
2430 Moved the provider data file to the new modest-providers-data package and used it from there.
2432 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-local-folder-info.c:
2435 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2436 N_() was already used on the static strings, but this just marks it for translation without
2437 using the translation.
2439 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2441 * src/maemo/modest-account-settings-dialog.c:
2442 (create_page_incoming),
2443 (modest_account_settings_dialog_set_account_name):
2444 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2445 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2446 I will do this if nobody else gets there first.
2448 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2451 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2452 save the security stuff.
2454 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2456 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2457 Set the email address and user fullname, which I now see must be
2460 * src/maemo/modest-account-settings-dialog.h:
2461 * src/maemo/modest-account-settings-dialog.c:
2463 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2464 leave-on-server and authentication.
2465 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2468 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/modest-account-settings-dialog.c:
2472 * src/maemo/modest-account-settings-dialog.h:
2473 Most (but not all) of the widgets are now present as specified by the UI spec.
2474 No changes are yet saved, and some details are not properly shown yet.
2476 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2478 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2480 * src/maemo/Makefile.am:
2481 * src/maemo/modest-account-settings-dialog.c:
2482 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2483 an existing account. Doesn't do much yet.
2485 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2486 Open the accounts settings dialog when Edit is clicked.
2488 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/easysetup/Makefile.am:
2491 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2493 * src/maemo/easysetup/modest-easysetup-wizard.c:
2494 (modest_easysetup_wizard_dialog_init):
2495 Try to get the source directory from the build system,
2496 instead of hard-coding "./" into the source code, when opening our local
2497 copies of the configuration files.
2498 But this still fails when opening the wizard from the Accounts window,
2499 maybe because the working directory seems to change at runtime.
2500 So the wizard will fail the second time unless you copy the files into their
2501 proper locations - see the stdout warnings for the paths.
2503 (create_page_account_details),(on_before_next):
2504 Check for existing non-server accounts instead of server accounts,
2505 so the default account name is useful again, and to prevent trying to
2508 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2509 Show the wizard when New is clicked.
2511 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2512 (init_view): Show the column headers, and show the columns that are
2513 specified in the UI specs. However, something in Maemo's GTK+ prevents
2514 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2515 change the default account. This is despite unsetting the special properties.
2517 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2519 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2520 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2521 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2522 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2523 to make that clearer.
2524 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2526 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/modest-account-view-window.c:
2529 (modest_account_view_window_init),
2530 (modest_account_view_window_new):
2531 Use the same buttons as specified in the
2532 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2533 the existing widgets, which never had a chance of working.
2534 Put the ModestAccountView treeview in a scrolled window.
2535 Do not repeat the initialization in both _init() and _new().
2537 * src/widgets/modest-account-view.c: (update_account_view):
2538 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2539 this widget and window shows no accounts.
2541 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2543 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2545 * src/maemo/easysetup/modest-easysetup-wizard.c:
2546 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2547 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2548 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2551 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2552 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2553 accounts exist yet, as in the UI spec.
2555 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2557 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2559 * src/maemo/Makefile.am:
2560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2561 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2562 New window for editing connection-specific smtp details.
2563 Not fully implemented.
2565 * src/maemo/modest-connection-specific-smtp-window.c:
2566 (modest_connection_specific_smtp_window_finalize) :
2567 unref the tree model.
2568 (on_button_edit): Show the edit window.
2570 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2572 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2575 * src/maemo/Makefile.am:
2576 * src/maemo/modest-connection-specific-smtp-window.c:
2577 * src/maemo/modest-connection-specific-smtp-window.h:
2578 New window for showing the list of connections, for connection-specific
2579 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2580 * src/maemo/easysetup/modest-easysetup-wizard.c:
2581 (create_page_custom_outgoing): Show the new window when the button is clicked.
2583 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2586 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2587 * src/maemo/modest-msg-edit-window.c:
2588 (modest_msg_edit_window_insert_image):
2589 * src/modest-conf.c: (modest_conf_key_escape):
2590 * src/modest-mail-operation.c:
2591 (modest_mail_operation_send_new_mail):
2592 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2593 (modest_ui_actions_on_new_account):
2594 * src/widgets/modest-attachment-view.c: (update_filename_request):
2595 * src/widgets/modest-mail-header-view.c:
2596 Corrected warnings that were breaking the build, by commenting out unused variables,
2597 and a function, and by including a header.
2599 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2601 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2602 so we can #ifdef around platform-specific code when necessary.
2603 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2604 to allow this to build for the GNOME platform too.
2606 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2608 * src/maemo/easysetup/modest-easysetup-wizard.c:
2609 Added util_increment_name() and used it in create_page_account_details()
2610 to make sure that the default account name is always a new name.
2612 (modest_easysetup_wizard_dialog_init),
2613 (set_default_custom_servernames): Some minor memory management fixes.
2615 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2619 * src/modest-runtime.c: (init_i18n): Restored the translation
2620 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2621 are defined in config.h, and the translations are installed.
2623 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2624 is defined for translation.
2626 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2628 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2630 * src/maemo/easysetup/modest-easysetup-wizard.c:
2631 (modest_easysetup_wizard_dialog_init):
2632 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2633 Use realistic paths (though they should use $prefix generically) to the
2634 mcc_mapping and provider-data.keyfile files which might work when they
2635 are installed by the future version of the operator-wizard package,
2636 and then fallback to paths in our source code, with an explanatory
2639 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/Makefile.am:
2644 * src/maemo/easysetup/: Added files from the previously-exernal
2645 osso-modest-easysetup.
2646 * src/maemo/modest-main-window-ui.h:
2647 * src/modest-ui-actions.c:
2648 * src/modest-ui-actions.h:
2649 Added modest_ui_actions_on_new_account() as a signal handler for the
2650 New Account menu item. It shows the easysetup wizard.
2651 * po/en_GB.po: Added additional needed logical IDs and translations.
2653 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2654 Apparently ChangeLog is not used for some vague Nokia legal reasons.