1 2007-08-27 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c:
4 (modest_account_settings_dialog_init):
5 * src/maemo/modest-connection-specific-smtp-edit-window.c:
6 (modest_connection_specific_smtp_edit_window_init):
7 * src/maemo/modest-connection-specific-smtp-window.c:
8 (modest_connection_specific_smtp_window_init):
9 * src/maemo/modest-maemo-utils.c:
10 (modest_maemo_utils_get_supported_secure_authentication_methods):
11 * src/maemo/modest-platform.c:
12 (modest_platform_run_folder_name_dialog):
13 * src/maemo/modest-signature-editor-dialog.c:
14 (modest_signature_editor_dialog_init):
15 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
16 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
17 * src/widgets/modest-global-settings-dialog.c:
18 (modest_global_settings_dialog_init):
19 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
21 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
22 GTK_STOCK_EDIT with mcen_bd_edit, and
23 GTK_STOCK_CLOSE with mcen_bd_close,
24 to fix projects.maemo.org bug NB#64995.
25 I strongly believe that Maemo's GTK+ should have the wanted translations
26 instead of duplicating this in each application and complicating the code.
28 2007-08-27 Armin Burgmeier <armin@openismus.com>
30 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
31 recursion when entering text in the subject field.
33 2007-08-27 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
36 which checks every second, 10 times, to wait until the account is online
37 so that we can use it, if the account is in the process of going online.
38 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
39 so that searching works even when the application was not yet started before.
40 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
42 2007-08-24 Armin Burgmeier <armin@openismus.com>
44 * src/modest-widget-memory.c: Always show the default account when the
45 application is started, as stated in the UI spec. This fixes
46 projects.maemo.org bug NB#66630.
48 2007-08-24 Armin Burgmeier <armin@openismus.com>
50 * src/maemo/modest-platform.c:
51 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
52 english text for strings in the rename folder dialog, fixing
53 projects.maemo.org bug NB#66338.
55 2007-08-22 Armin Burgmeier <armin@openismus.com>
57 * src/widgets/modest-account-view.c: Fix for bora by using
58 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
59 latter seems not be used anymore.
61 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
64 * src/maemo/modest-main-window.c: Update menu items when the default
65 account changes so that the current default account is always bolded.
66 This fixes maemo.projects.org bug NB#66173.
68 2007-08-17 Murray Cumming <murrayc@murrayc.com>
70 * src/dbus_api/modest-dbus-callbacks.c:
71 (on_dbus_method_get_folders): Avoid trying to get the account name
72 when there are no accounts, to avoid critical g_warnings, fixing
73 projects.maemo.org bug NB#65574.
75 2007-08-17 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
78 Use modest_account_mgr_get_signature() instead of accessing gconf
79 directly, to slightly simplify the code.
80 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
81 Append the signature also when opening via other applications,
82 fixing projects.maemo.org bug NB#65828.
84 2007-08-17 Murray Cumming <murrayc@murrayc.com>
86 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
87 Check for NULLs to prevent a crash when opening an email that is
88 an attachment in another email, fixing projects.maemo.org bug
91 2007-08-17 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-ui-dimming-rules.c:
94 (modest_ui_dimming_rules_on_view_window_move_to):
95 Enable the Move To toolbar button for search results, fixing the
96 last part of projects.maemo.org bug NB#63807.
98 2007-08-17 Murray Cumming <murrayc@murrayc.com>
100 * src/dbus_api/modest-dbus-callbacks.c:
101 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
102 because this is called from idle handlers, to fix hangs afte the
104 (find_message_by_url): Added a TODO comment about a crash that
105 happens when tinymail was built with DBC checks.
107 2007-08-16 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-search.c: (modest_search_folder):
110 * src/modest-search.h: Rename ModestSearch::before to start_date
111 and after to end_date, using the same names as the libogs struct
113 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
114 The start_date and end_date were swapped in the check. This
115 fixes date range searches, fixing projects.maemo.org bug NB#63407.
117 2007-08-16 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-account-view-window.c:
120 Added (check_for_active_acount).
121 (on_delete_button_clicked), (on_edit_button_clicked):
122 When an account is doing something (such as refreshing),
123 show the same warning for account deletion as for account
124 editing, to fix projects.maemo.org bug NB#64588.
126 2007-08-16 Murray Cumming <murrayc@murrayc.com>
128 * src/widgets/modest-msg-view-window.h:
129 * src/gnome/modest-msg-view-window.c:
130 * src/maemo/modest-msg-view-window.c:
131 Added modest_msg_view_window_construct().
132 (modest_msg_view_window_new_with_header_model),
133 Added modest_msg_view_window_new_for_search_result),
134 Renamed modest_msg_view_window_new() to
135 modest_msg_view_window_new_for_attachment(),
136 and modest_msg_view_window_is_search_result(),
137 so we can explicitly know that the window is for an
138 attachment or a search result or a message from the list.
140 (modest_msg_view_window_view_attachment):
141 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
142 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
143 Use modest_msg_view_window_new_for_search_result().
145 * src/modest-ui-dimming-rules.c:
146 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
147 for search results, fixing projects.maemo.org bug NB#63811.
149 2007-08-16 Armin Burgmeier <armin@openismus.com>
151 * src/modest-ui-actions.c: Show a banner instead of a dialog when
152 renaming a folder fails, to stay consistent with what happens when
153 creating a folder fails.
155 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
156 slightly country loading from the mmc_mappings file, fixed a memory
159 2007-08-16 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-tny-account-store.c: (volume_path_is_mounted):
162 Check the GnomeVFSVolume activation path instead of the device path,
163 so that the memory card is really really shown in the UI.
165 2007-08-16 Murray Cumming <murrayc@murrayc.com>
167 * src/maemo/easysetup/modest-easysetup-wizard.c:
168 (get_entered_account_title), (on_before_next), (entry_is_empty),
170 * src/maemo/modest-account-settings-dialog.c:
171 (get_entered_account_title), (on_button_signature), (check_data),
172 (save_configuration), (entry_is_empty):
173 Strip the account title of whitespace at the start and end before
174 using it or checking it. This means that an all-whitespace title
175 is not allowed, fixing projects.maemo.org bug NB#64977.
177 2007-08-15 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-ui-actions.h:
180 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
181 to modest_run_account_setup_wizard() and made it public.
182 * src/dbus_api/modest-dbus-callbacks.c:
183 (check_and_offer_account_creation), (on_idle_mail_to),
184 (on_idle_compose_mail), (on_idle_open_default_inbox):
185 Offer account creation if necessary, fixing projects.maemo.org
188 2007-08-15 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-ui-actions.c: (run_account_setup_wizard):
191 Return a gboolean to indicate success.
192 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
193 (modest_ui_actions_on_send): When offering account creation, only
194 give up (return) if account creation failed. Otherwise continue
195 with the original request. This fixed projects.maemo.org bug
198 2007-08-15 Murray Cumming <murrayc@murrayc.com>
200 * src/widgets/modest-recpt-editor.c:
201 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
202 to fix projects.maemo.org bug NB#63789.
204 2007-08-15 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
207 (modest_tny_account_store_new): Properly detect the memory card at
208 startup, and add an account for it.
210 2007-08-14 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
213 Commented out the MMC code again because it mistakenly detects
214 the card even when it isn't inserted.
216 2007-08-14 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
219 Renabled the call to add_mmc_account() because I do not believe
220 it could be the cause of the mentioned hang (in scratchbox, where
221 there is no memory card), and because I have tested that it works
224 2007-08-14 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
227 Comment out part of the last commit because it apparently causes
230 2007-08-14 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-tny-account-store.c: Added the add_mmc_account()
233 function to save some copy/pasting.
234 (modest_tny_account_store_new): If the memory card is mounted,
235 create an account for it at the start, instead of waiting for the
236 user to unmount it and mount it.
238 2007-08-13 Murray Cumming <murrayc@murrayc.com>
240 * src/widgets/modest-account-view.c: (on_account_changed):
241 Do not try to use the human-readable TnyAccount name instead of the
242 ID of the modest account to get the transport account. And unref
243 the transport account. This prevents a g_warning(), and a possible
246 2007-08-13 Murray Cumming <murrayc@murrayc.com>
248 * src/maemo/modest-platform.c:
249 (modest_platform_set_update_interval): Handle the new
250 alarmd error to warn when alarmd is not running, as is the case in
251 scratchbox for me now because
252 "Module /usr/lib/alarmd/libretu.so initialization failed"
254 2007-08-13 Murray Cumming <murrayc@murrayc.com>
256 * src/widgets/modest-header-view-render.c:
257 (_modest_header_view_compact_header_cell_data):
258 NULL some strings after freeing them, trying to deal with
259 the double deletion found in projects.maemo.org bug 64183,
260 probably having no effect.
262 2007-08-13 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-account-settings-dialog.c:
265 (create_page_incoming), (create_page_outgoing): Use a define
266 for the min and max port numbers.
268 (check_hildon_number_editor_and_warn_value_not_in_range),
269 (check_data): Do an extra check for an invalid port number, as needed
270 in projects.maemo.org bug #64275, when the number is cleared, but this
271 does not work due to bugs.maemo.org bug #1806.
273 2007-08-13 Murray Cumming <murrayc@murrayc.com>
275 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
276 Comment out the debug warning about the unexpected D-Bus methods.
277 They are just annoying now.
278 * src/maemo/modest-platform.c:
279 (modest_platform_set_update_interval): Correct the D-Bus path, instead
280 of using a file path, though it did not seem to break things before.
281 It might be needed now:
282 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
283 modest is not already running. This is the behaviour of the old client, and
284 Mox says it is what we should do for modest.
285 This closes projects.maemo.org bug NB#64327.
287 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
289 * src/modest-text-utils.c:
290 Fixed invalid jump due to incorrect string/pointer
292 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
295 2007-08-01 Murray Cumming <murrayc@murrayc.com>
297 * src/modest-account-mgr-helpers.h:
298 * src/modest-account-mgr-helpers.c:
299 Added modest_account_mgr_get_first_account_name(),
300 using code from modest_account_mgr_set_first_account_as_default().
302 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
303 (account_number_changed): Call set_at_least_one_account_visible() so that
304 the first account is visible when first added, without the user having to
306 I do wonder how this worked before.
308 2007-08-01 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-tny-account-store.c: (show_password_warning_only),
311 (show_wrong_password), (request_password_and_wait), (get_password),
312 (modest_tny_account_store_alert): Remove the (incomplete anyway)
313 attempts to show UI only in the main context, which used g_idle_add()
314 and mainloops, because tinymail now guarantees that it only calls these
315 callbacks in the mainloop with the gdk lock. This makes everything much
318 2007-08-01 Murray Cumming <murrayc@murrayc.com>
320 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
321 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
322 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
323 error dialog, instead of ignoring it.
325 2007-08-01 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/modest-msg-view-window.c:
328 (modest_msg_view_window_get_header),
329 (modest_msg_view_window_last_message_selected):
330 Added comments to explain the use of priv->header_model.
331 * src/modest-ui-dimming-rules.c:
332 (modest_ui_dimming_rules_on_open_msg),
333 (modest_ui_dimming_rules_on_mark_as_read_msg),
334 (modest_ui_dimming_rules_on_mark_as_unread_msg),
335 (modest_ui_dimming_rules_on_remove_attachments),
336 (_invalid_attach_selected), (_selected_msg_marked_as):
337 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
338 and changed the parameter to a ModestMainWindow to make it clearer that
339 it never uses any other kind of window.
340 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
341 instead of the selected message.
342 I notice that much of the dimming code and the ModestMsgViewWindow code
343 hard-codes the assumption that the viewed message is always selected in
344 the header view. This does not seem wise or simple.
346 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
347 examine the actual message instead of whatever might be selected
348 in the header view. This stops the delete toolbar button and menu item
349 from being dimmed when opening a message view the search UI,
350 partially fixing projects.maemo.org bug NB#63811.
352 However, when actually deleting, I now get this warning:
353 "tny_header_set_flags: This is a header instance for a new message.
354 Only priority and attachment flags are supported"
356 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
358 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
360 Show account wizard if no accounts are defined while sending
361 (automatic sending after the account wizard finished does not
362 work because it takes some time until the account manager
363 synchronizes everything. (projects.maemo.org NB#62792)
365 2007-07-30 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account-store.c: (on_account_removed),
368 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
369 account is removed from the View menu. We have TnyAccountStore
370 and ModestTnyAccountStore signals that seem very similar, but this
371 seems to work for now.
373 * src/maemo/modest-main-window.c:
374 (on_show_account_action_activated): Prevent dereference
375 of a NULL if the accoutn does not really exist, though that
376 should not happen anymore.
378 This fixes projects.maemo.org bug NB#64606.
380 2007-07-30 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-ui-actions.c: (run_account_setup_wizard),
383 (modest_ui_actions_on_accounts): Revert a change that set these
384 to modal dialogs, freezing the UI when they show secondary dialogs.
385 This fixed projects.maemo.org bug NB#64519.
387 2007-07-27 Murray Cumming <murrayc@murrayc.com>
389 * src/widgets/modest-header-view-render.c:
390 (_modest_header_view_compact_header_cell_data):
391 Some checks and initialization to try to deal with a crash,
392 probably ineffective.
394 2007-07-27 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-maemo-utils.c:
397 (modest_maemo_utils_get_supported_secure_authentication_methods):
398 Make sure that we have a connection, asking the user for one
400 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
401 Check for a connection before showing the wizard, because
402 the wizard needs a connection to check for server capabilities.
404 2007-07-27 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/modest-account-view-window.c:
407 (on_new_button_clicked): Remember the wizard dialog instance,
408 so we can just present it again if necessary. This prevents
409 multiple windows from appearing if you click again quickly on the
410 New button before the dialog appears, fixing projects.maemo.org
413 2007-07-27 Murray Cumming <murrayc@murrayc.com>
415 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
416 Offer a connection dialog if there is no connection when
417 starting modest. This should fix projects.maemo.org bug NB#61134.
419 2007-07-27 Murray Cumming <murrayc@murrayc.com>
421 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
422 Reverted my last commit. I was able to fix the build by doing
423 apt-get install wpeditor0 (replacing other wpeditor packages) and
424 an explicit apt-get install wpeditor-dev to upgrade the -dev
427 2007-07-27 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
430 Commented out the use of wp_text_buffer_replace_image()
431 because it does not exist, to break the build. Added a TODO for it.
433 2007-07-26 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-tny-account-store.c: (recreate_all_accounts):
436 Recreate them even if they were NULL before. I guess something
437 else was already creating them before, or this would never
439 (modest_tny_account_store_get_server_account): Make sure that
440 the tny accounts have been created before trying to find one.
441 This allows libmodest_dbus_client_compose_mail() to work
442 when the UI is not yet visible.
443 This is probably useful in other cases too.
445 (get_password): When the password is wrong after it is entered
446 in the protected password dialog, show an info banner (in an
447 idle handler) before showing the protected password dialog
450 2007-07-26 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-ui-actions.h:
453 * src/modest-ui-actions.c: Added
454 modest_do_refresh_current_folder() containing some code from
455 modest_ui_actions_on_send_receive().
456 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
457 Call modest_do_refresh_current_folder() before refreshing the
458 requested account, as in modest_ui_actions_on_send_receive().
459 This is strange, but seems to be necessary to show new mails.
460 Now new emails are finally visible in the UI when downloaded
461 via the automatic update interval, fixing bug NB#57458.
462 This also works because bug NB#57458 has been fixed somehow.
464 2007-07-26 Murray Cumming <murrayc@murrayc.com>
466 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
467 printf more details when we get unhandled D-Bus methods, because
470 * src/modest-mail-operation.c: (update_account_thread):
471 Comment out the tny_camel_pop_store_account_reconnect(), because this
472 is apparently no longer needed, and it did not work before anyway.
473 See the comment in the code.
475 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
476 by checking the header flags. This fixes projects.maemo.org bug
479 2007-07-25 Murray Cumming <murrayc@murrayc.com>
481 * src/maemo/modest-maemo-utils.h:
482 * src/maemo/modest-maemo-utils.c: Added
483 modest_maemo_show_information_note_in_main_context_and_forget().
484 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
485 Use the new function to show simple error dialogs in the main
486 context, though question dialogs are still in the current context,
487 which is unfortunately usually not the main context. This should
490 2007-07-25 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-tny-account-store.c: (get_password):
493 Never save the entered username and password in gconf,
494 because the UI spec says we should not. This helps
495 slightly with projects.maemo.org bug NB#63671.
497 2007-07-25 Murray Cumming <murrayc@murrayc.com>
499 * src/widgets/modest-msg-edit-window.h:
500 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
501 Moved some code here to make it simpler.
502 (modest_msg_edit_window_attach_file_one): Renamed from
503 modest_msg_edit_window_attach_file_interactive().
504 (modest_msg_edit_window_offer_attach_file): Renamed from
505 modest_msg_edit_window_attach_file() and used
506 modest_msg_edit_window_attach_file_one() instead of
507 copy/pasting the code. The old code for one was not using
508 GnomeVFS. This allows use of smb:// URLs when using send-as
509 from external applications, fixing bug NB#63741.
511 (modest_msg_edit_window_insert_image),
512 (modest_msg_edit_window_add_attachment_clicked):
513 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
514 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
515 Adapted to the new function names.
517 2007-07-25 Murray Cumming <murrayc@murrayc.com>
519 (modest_platform_set_update_interval): Set the alarm recurrence
520 fields so that auto-update does not just happen the first time.
521 This should have fixed projects.maemo.org bug NB#63938.
523 When this happens you can see a printf when the D-Bus method is
525 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
527 However, I do not actually seem to get new POP messages even when
528 clicking the refresh button manually. A restart gets them.
529 This might be a problem in today's tinymail only.
531 2007-07-24 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/modest-maemo-global-settings-dialog.c:
534 (current_connection):
535 Avoid a crash (probably only in scratchbox) when strcmp()ing a
536 NULL when closing the dialog.
538 2007-07-24 Murray Cumming <murrayc@murrayc.com>
540 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
541 Remove the hacky send/receive that didn't work, and instead
542 refilter the treemodel to make the deleted email really vanish from
543 the UI (though the delete-from-menu code does has commented out
544 the code that does that). This fixes projects.maemo.org bug
547 2007-07-24 Murray Cumming <murrayc@murrayc.com>
549 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
550 Try a couple of tricks to force the treeview to update (
551 poke the folder, and do a send/receive refresh), but the deleted
552 email still appears with a strike-through instead of really being
555 2007-07-23 Murray Cumming <murrayc@murrayc.com>
557 * src/dbus_api/modest-dbus-callbacks.c:
558 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
559 because their ID is not human-readable (see the comment about
560 improvements needed to the osso-email-interface API) and
561 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
563 2007-07-23 Murray Cumming <murrayc@murrayc.com>
565 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
566 (add_folders_to_list), (on_dbus_method_get_folders),
567 (modest_dbus_req_filter):
568 * src/maemo/modest-maemo-utils.c:
569 (on_camel_account_get_supported_secure_authentication):
570 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
571 (on_header_view_focus_in):
572 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
573 * src/modest-formatter.c: (modest_formatter_create_body_part):
574 * src/modest-mail-operation.c: (recurse_folders),
575 (update_account_thread), (get_msgs_full_thread),
576 (modest_mail_operation_get_msgs_full),
577 (modest_mail_operation_xfer_msgs):
578 * src/modest-search.c: (search_mime_part_and_child_parts),
579 (modest_search_account), (modest_search_all_accounts):
580 * src/modest-tny-account.c:
581 (modest_tny_account_get_special_folder), (recurse_folders):
582 * src/modest-tny-local-folders-account.c:
583 (modest_tny_local_folders_account_query_passes):
584 * src/modest-tny-msg.c: (copy_mime_part),
585 (modest_tny_msg_find_body_part_from_mime_part):
586 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
587 (modest_tny_send_queue_try_to_send):
588 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
589 (_modest_ui_actions_open), (download_uncached_messages),
590 (reply_forward), (modest_ui_actions_on_copy),
591 (modest_ui_actions_on_details), (has_retrieved_msgs),
592 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
594 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
595 (_selected_msg_marked_as), (_msg_download_completed),
596 (_selected_msg_sent_in_progress):
597 * src/widgets/modest-attachments-view.c:
598 (modest_attachments_view_set_message):
599 * src/widgets/modest-msg-view.c: (find_cid_image):
600 * tests/check_folder-transfer.c: (find_folders):
601 * tests/check_update-account.c: (func):
602 * tests/dbus_api/test_get_folders.c: (main):
603 Checked all uses of tny_iterator_get_current(), making sure
604 that the object is unreferenced (3 or 4 places did not),
605 and adding checks for NULL.
607 2007-07-23 Murray Cumming <murrayc@murrayc.com>
609 * src/dbus_api/modest-dbus-callbacks.c:
610 (on_idle_open_default_inbox): Make sure that the application UI is
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 (on_entry_invalid_character): Show the word whitespace instead
614 of (null) in the banner when whitespace was entered.
615 (show_error): Add a comment that this does not work in
616 Maemo Bora, though we do not know why.
618 2007-07-23 Murray Cumming <murrayc@murrayc.com>
620 * src/modest-tny-account.c:
621 (modest_tny_account_get_special_folder): Use an if instead of
622 an assert for when the parent account name is NULL, because this
623 might be causing a crash in projects.maemo.org bug 63192.
624 * src/modest-mail-operation.c:
625 (modest_mail_operation_send_new_mail_cb),
626 (modest_mail_operation_remove_folder): unref the folder that is
627 returned from modest_tny_account_get_special_folder().
629 2007-07-23 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-ui-actions.c:
632 (modest_ui_actions_on_password_requested):
633 Show mail_ib_login_cancelled info banner when the user cancels
634 the protected password dialog, to fix projects.maemo.org
637 2007-07-23 Murray Cumming <murrayc@murrayc.com>
639 * src/maemo/modest-account-settings-dialog.c:
640 (create_page_outgoing): Put this page in a GtkScrolledWindow,
641 matching the UI mock-up in the UI spec, and allowing access
642 to all widgets even when the on-screen keyboard is active.
644 2007-07-23 Murray Cumming <murrayc@murrayc.com>
646 Reverted this previous commit from Johannes,
647 because the scrollbars are always visible and because
648 I think we only need it on onepage of the account
649 settings, not the account wizard.
650 (I wrote the wrong instructions in the bug.)
652 * src/maemo/easysetup/modest-easysetup-wizard.c:
653 Added scrollbars to account wizard dialog.
654 Fixed projects.maemo.org NB #62744
656 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
658 * src/maemo/easysetup/modest-easysetup-wizard.c:
659 (create_page_user_details):
660 Use auto-cap for name (projects.maemo.org NB#63716)
661 * src/widgets/modest-account-view.c: (on_account_busy_changed):
663 2007-07-22 Armin Burgmeier <armin@openismus.com>
665 * src/maemo/modest-ui-actions.c: Use current account instead of
666 default account for creating viewer windows, so that the viewer
667 window knows to which account the viewed message belongs.
669 * src/maemo/modest-msg-view-window.c: Destroy the window when the
670 corresponding account is deleted. This fixes projects.maemo.org bug
673 2007-07-18 Armin Burgmeier <armin@openismus.com>
675 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
676 the dialog close after entering an invalid port number and clicking
677 OK. This fixes projects.maemo.org bug NB#63602.
679 2007-07-18 Armin Burgmeier <armin@openismus.com>
681 * src/modest-tny-account-store.c:
682 (get_server_accounts): Set parent modest account name for each
683 connection-specific transport account so that special folders of such
684 an account can be looked up. This fixes a crash when changing account
685 settings. This might also be related to projects.maemo.org bug
688 2007-07-16 Armin Burgmeier <armin@openismus.com>
690 * src/modest-ui-actions.c: Added a button to create a folder to the
691 move-to dialog. This fixes projects.maemo.org bug NB#59863.
693 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
695 * src/maemo/easysetup/modest-easysetup-wizard.c:
696 Added scrollbars to account wizard dialog.
697 Fixed projects.maemo.org NB #62744
699 2007-07-16 Murray Cumming <murrayc@murrayc.com>
701 * src/widgets/modest-msg-view.h:
702 * src/widgets/modest-msg-view.c:
703 Added modest_msg_view_get_message_is_empty() but this needs
705 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
706 Check if there is any text in the message yet.
707 But this needs to be implemented properly.
708 (modest_msg_edit_window_toggle_find_toolbar):
709 * src/maemo/modest-msg-view-window.c:
710 (modest_msg_view_window_toggle_find_toolbar):
711 Show a banner warning if there is no text to search, when
712 trying to start a search. This partially fixes
713 projects.maemo.org bug NB#62350.
715 2007-07-13 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-mail-operation.c: (update_account_thread):
718 Initialized num_new_headers to fix the build.
720 2007-07-13 Murray Cumming <murrayc@murrayc.com>
722 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
723 Ignore modest accounts whose server accounts don't exist in gconf.
724 This prevents us trying to create TnyAccount instances for those
725 server accounts when the server account has been removed from gconf,
726 but the parent modest account has not yet been removed from modest.
727 I don't know why this is only noticeable now. It was probably just
728 a harmeless g_warning() anyway.
730 2007-07-13 Murray Cumming <murrayc@murrayc.com>
732 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
733 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
735 2007-07-12 Armin Burgmeier <armin@openismus.com>
737 * src/maemo/modest-main-window.c: Make default account appear bold
738 in view, tools/send & receive and toolbar/send & receive SCM menus.
739 This fixes projects.maemo.org bug NB#59010.
741 2007-07-12 Murray Cumming <murrayc@murrayc.com>
743 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
744 Add a short-cut, by checking if the folder store is an account.
745 This ensures that the Sort menu item and toolbar is dimmed for
746 the local-folders account root item, fixing
747 projects.maemo.org bug NB#62545.
749 2007-07-12 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-tny-account-store.c: (get_password):
752 Show the password dialog (via the signal) only in the mainloop, via
753 an idle handler that we wait for. This could theoretically prevent
754 hangs, though I worry that it could introduce some too.
756 2007-07-12 Murray Cumming <murrayc@murrayc.com>
758 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
759 * src/maemo/modest-platform.c:
760 (modest_platform_connect_and_wait):
761 Take a TnyAccount* parameter and try to set it to online
762 (a TnyCamel-only API), because tinymail sets accounts to offline
763 when the user cancels a password dialog, and doesn't ask again until
764 it has been set to online.
765 However, this is commented out because it causes a hang now.
767 (modest_platform_connect_and_wait_if_network_account):
768 * src/modest-mail-operation.c:
769 (modest_mail_operation_update_account):
770 * src/modest-platform.h:
771 * src/modest-ui-actions.c: (_modest_ui_actions_open),
772 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
774 2007-07-12 Armin Burgmeier <armin@openismus.com>
776 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
778 * src/modest-mail-operation.c:
779 * src/modest-ui-actions.c: Check for already existing folder before
780 querying the server, show error message from camel if the request
781 still fails. This fixes projects.maemo.org bug NB#58701.
783 2007-07-12 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account-store.h:
786 * src/modest-tny-account-store.c:
787 Added modest_tny_account_store_forget_password_in_memory(),
788 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
789 when creating a new account, so that new passwords will be used, instead of
790 us thinking that it's a second request as a result of a failed password again.
792 2007-07-12 Murray Cumming <murrayc@murrayc.com>
794 * src/dbus_api/modest-dbus-callbacks.c:
795 (on_idle_open_message): If the message is in drafts then open it
796 in an edit window instead of a view window. This fixes
797 projects.maemo.org bug NB#63005.
799 2007-07-12 Murray Cumming <murrayc@murrayc.com>
801 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
802 Avoided a harmless g_warning().
804 2007-07-12 Murray Cumming <murrayc@murrayc.com>
806 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
807 Pass the modest account name, not the TnyAccount display name to
808 modest_msg_view_window_new() so that the reply feature works,
809 fixing projects.maemo.org bug NB#62892.
811 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
812 (modest_msg_view_window_new_with_header_model):
813 * src/maemo/modest-msg-view-window.c:
814 (modest_msg_view_window_new_with_header_model),
815 (modest_msg_view_window_new):
816 * src/modest-ui-actions.c: (reply_forward):
817 * src/widgets/modest-msg-view-window.h:
818 * src/widgets/modest-window.c: (modest_window_set_active_account):
819 Rename an account parameter to modest_account_name to make this clearer.
821 2007-07-11 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-ui-actions.h:
824 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
825 modest_do_message_delete().
826 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
827 Call modest_do_message_delete(), hoping that this would cause messages
828 to be really deleted from search instead of just marked with strike through.
829 Does not seem to help.
831 2007-07-11 Armin Burgmeier <armin@openismus.com>
833 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
834 priv->reselect to FALSE prior to calling
835 modest_folder_view_select_first_inbox_or_local() to prevent endless
836 recursion and thus a crash on startup.
838 2007-07-11 Armin Burgmeier <armin@openismus.com>
840 * src/maemo/modest-account-settings-dialog.h: Include
841 <gtk/gtknotebook.h> to fix the build (at least for me).
843 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
844 Use "New FolderN" as default suggested name if "New folder" already
845 exists, with N being the first free number, though never exceed "New
846 folder99" in which case we just fall back to "New Folder" even though
847 it already exists. This fixes projects.maemo.org bug NB#58663.
849 2007-07-11 Murray Cumming <murrayc@murrayc.com>
851 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
852 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
853 projects.maemo.org bug NB#62778.
855 2007-07-11 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
858 Ignore the wrong (for now) secure-smtp setting in the presets -
859 just default to requiring secure authentication for SMTP, because
862 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
864 * src/widgets/modest-folder-view.c: (filter_row)
865 Do not show drafts folder (see UI specs)
867 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
869 * src/modest-ui-actions.c:
870 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
871 place and also not necessary.
873 * src/widgets/modest-folder-view.c: (filter_row)
874 Guess folder type and hide Sent & Outbox if necessary.
875 Fixed project.maemo.org NB#57328
877 2007-07-11 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-ui-actions.h:
880 * src/modest-ui-actions.c:
881 (modest_ui_actions_on_delete_message):
882 Move some code into a new
883 modest_ui_actions_refresh_message_window_after_delete()
884 function so we can use it from elsewhere.
886 * src/dbus_api/modest-dbus-callbacks.c:
887 (on_idle_delete_message), (on_delete_message): Used an idle
888 handler, as we do for the other D-Bus method handlers.
889 Call modest_ui_actions_refresh_message_window_after_delete()
890 if the deleted message was open in a window. This fixed
891 projects.maemo.org bug NB#62862.
893 2007-07-11 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-main.c: (main): Only show the UI at the start if
896 the showui command line option was given. For instance,
897 run-standalone src/modest showui
898 Otherwise, we wait for the top_application D-Bus method to
899 be sent by hildon-desktop when the application is selected
901 This allows us to run without a UI when osso-global-search
902 uses our D-Bus methods.
904 2007-07-11 Murray Cumming <murrayc@murrayc.com>
906 * src/dbus_api/modest-dbus-api.h: Added a define for a
907 top-application D-Bus method.
908 * src/dbus_api/modest-dbus-callbacks.c:
909 (on_top_application),
910 (modest_dbus_req_handler): Handle the top-application D-Bus
911 method, which might be an undocumented D-Bus signal sent by
912 hildon-desktop when it starts the application from the menu.
913 But I am not sure and I need to test it on the device, because
914 my scratchbox does not have the application in the menu now.
915 This method shows the main window, so that it can be invisible
916 when started, for instance, just for email searching from
919 * src/maemo/modest-main-window.c: (restore_settings),
920 (modest_main_window_new): Do not show the window immediately
921 upon creation. We show it later.
922 * src/modest-widget-memory.c: (save_settings_paned):
923 Try (unsuccessfully) to avoid saving the paned position when
924 it is not even visible.
925 (restore_settings_paned): Do not allow a silly paned position.
926 This seems necessary when not showing the window at first.
928 * tests/dbus_api/Makefile.am:
929 * tests/dbus_api/test_top_application.c: (main): Test for the
932 2007-07-10 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-ui-dimming-rules.c:
935 (modest_ui_dimming_rules_on_new_msg),
936 (modest_ui_dimming_rules_on_reply_msg),
937 (modest_ui_dimming_rules_on_delete_msg),
938 (modest_ui_dimming_rules_on_details),
939 (modest_ui_dimming_rules_on_view_window_move_to),
940 (modest_ui_dimming_rules_on_view_previous),
941 (modest_ui_dimming_rules_on_view_next),
942 (_invalid_folder_for_purge): Added checks before
943 casting the window. This looks like an actual
944 logic error in _invalid_folder_for_purge(), because it
945 tries to use a ModestMainWindow as a message window.
947 2007-07-10 Murray Cumming <murrayc@murrayc.com>
949 * src/maemo/modest-account-settings-dialog.c:
950 (show_error): Use the same implementation as in
951 modest-easysetup-wizard.c:
952 (on_entry_invalid_character): The logical ID contains a %s.
953 Guessed what it should be.
954 (on_entry_max), (check_data), (on_response): Adapt to
955 changed show_error().
956 (create_page_account_details): Really call
957 modest_validating_entry_set_func() on the correct widgets.
958 * src/maemo/easysetup/modest-easysetup-wizard.c:
959 (on_entry_invalid_character): Fix the logical ID here too.
960 (create_page_account_details),
961 (create_page_user_details):
963 modest_validating_entry_set_func() on the correct widgets.
965 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
966 Do not try to use the account if it is NULL.
968 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
970 * src/modest-ui-actions.c: (create_move_to_dialog),
971 (modest_ui_actions_on_main_window_move_to),
972 (modest_ui_actions_on_msg_view_window_move_to):
973 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
974 (filter_row), (modest_folder_view_show_non_move_folders):
975 * src/widgets/modest-folder-view.h:
977 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
978 the Sent folder yet as it does not report the correct folder type.
980 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
982 * src/maemo/modest-msg-edit-window.c: (init_window):
985 2007-07-10 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
988 Take a parent widget instead of a parent window, and
989 implement this with hildon_banner_show_information() instead.
990 Non-Maemo builds can just ifdef that there.
991 This fixed projects.maemo.org bug NB#62766.
993 (on_entry_invalid_character): Use show_error() again instead
994 of using hildon directly, and use the _CS() macro to use the correct
996 (create_account), (check_for_supported_auth_methods), (on_entry_max):
997 Pass a widget instead od a window to show_error().
999 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1001 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1002 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1003 This allows us to show the server name in the error message, fixing
1004 projects.maemo.org bug NB#62904.
1005 Also, use the appropriate logical ID message for the account protocol.
1007 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1010 A compilation fix, though the build wasn't broken for me.
1012 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1015 Do not try to unref a NULL folder store, to avoid a runtime warning.
1016 This seems to happen sometimes when changing accounts settings.
1018 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-tny-account-store.c:
1021 (modest_tny_account_store_instance_init),
1022 (modest_tny_account_store_finalize),
1023 (on_account_settings_hide), (on_idle_wrong_password):
1024 Use a GHashTable to ensure that we only show one account settings
1025 dialog per modest account. This avoids us having a dialog open for
1026 both the store and transport accounts, or due to repeated get_password()
1027 calls that shouldn't happen anyway.
1029 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1031 * src/maemo/modest-maemo-utils.c: (on_hide),
1032 (modest_maemo_show_dialog_and_forget): Handle the response, because
1033 the window is not even hidden by default.
1035 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1036 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1037 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1038 which seems to prevent some modality problems.
1040 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1041 Ignore user cancellation errors.
1043 * src/modest-account-mgr-helpers.h:
1044 * src/modest-account-mgr-helpers.c:
1045 Added modest_server_account_get_password() and
1046 modest_server_account_get_has_password() to avoid direct use of
1049 * src/maemo/modest-account-settings-dialog.h:
1050 * src/maemo/modest-account-settings-dialog.c:
1051 (modest_account_settings_dialog_init): Store the notebook so we can
1053 Added modest_account_settings_dialog_switch_to_user_info().
1055 * src/modest-tny-account-store.c:
1056 (get_password): When the password in the account settings is wrong (we think),
1057 show the relevant page of the account settings dialog, in the mainloop.
1058 However, we currently get many of these at once because cancel does not
1060 (forget_password): Do not forget the password
1061 from the account settings, because this causes side-effects when
1062 tinymail seems to call it at strange time, maybe because of how we
1063 are cancelling get_password().
1064 (modest_tny_account_store_alert): Ignore user cancellations.
1066 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1068 * src/maemo/modest-maemo-utils.h:
1069 * src/maemo/modest-maemo-utils.c:
1070 Added modest_maemo_show_information_note_and_forget() for use instead of
1071 gtk_dialog_run() when the response is not needed, to avoid an extra
1072 mainloop which could cause a hang.
1074 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1075 Use the logical IDs for the error message, though they are not
1076 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1077 because gtk_dialog_run() caused a hang here (the window did not close).
1078 This fixes projects.maemo.org bug NB#62646.
1080 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-account-mgr-helpers.h:
1083 * src/modest-account-mgr-helpers.c:
1084 Added modest_account_mgr_get_store_protocol().
1086 * src/maemo/modest-account-view-window.c:
1087 (on_delete_button_clicked): Show different warning text depending on
1088 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1089 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1092 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1094 * src/maemo/modest-msg-edit-window.c:
1095 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1096 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1098 2007-07-07 Armin Burgmeier <armin@openismus.com>
1100 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1101 ckdg_ib_maximum_characters_reached from correct package.
1103 * src/modest-ui-actions.c: Show an error message when a folder could
1104 not be created. Tinymail does not give us specific error codes about
1105 what has gone wrong, so we assume that a folder with that name
1106 already exists, though there might be other reasons.
1108 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1111 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1112 give a more exact error message that can be partly translated.
1114 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1116 * src/maemo/modest-address-book.c:
1117 (select_email_addrs_for_contact): Specify a default window size for the
1118 select-email-address dialog, so that it is probably big enough for the
1119 title. This should fix projects.maemo.org bug NB#62277.
1121 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1123 * src/maemo/easysetup/modest-easysetup-wizard.c:
1124 (create_page_complete_easysetup): Use
1125 gtk_widget_set_size() request to ensure that the text wraps
1128 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1130 * src/maemo/easysetup/modest-easysetup-wizard.c:
1131 (on_entry_invalid_character), (create_page_account_details),
1132 (create_page_user_details):
1133 Use new API of ModestValidatingEntry. But for some reason the banner is
1134 not shown. I will have to investigate that further.
1136 * src/widgets/modest-validating-entry.c: (on_insert_text),
1137 (modest_validating_entry_set_func):
1138 * src/widgets/modest-validating-entry.h:
1139 Added a new callback function to be able to react to prevented
1140 characters whitespaces to e.g show a banner.
1142 2007-07-05 Armin Burgmeier <armin@openismus.com>
1144 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1145 notification of HildonNumberEditor instead of remembering the port
1146 number. Thanks to Johannes for pointing this out.
1148 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1150 * src/maemo/easysetup/modest-easysetup-wizard.c:
1151 Check if there are any user changes before showing a confirmation
1152 dialog (projects.maemo.org NB#60946)
1154 2007-07-05 Armin Burgmeier <armin@openismus.com>
1156 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1157 number at the beginning of the dialog and set the modified flag at the
1158 end if the port number has changed. This is necessary because
1159 HildonNumberEditor does not support notification when the value has
1162 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-ui-actions.c:
1165 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1166 a connection before asking anything else. Correct the check for the destination
1167 folder so that it succeeds when online.
1168 This fixed projects.maemo.org bug NB#61645.
1170 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1172 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1173 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1174 to fix projects.maemo.org bug NB#62439.
1176 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-tny-account.c: (on_connection_status_changed):
1179 Really do not use tny_device_force_offline() here. See the previous comment.
1181 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-tny-account.c: (on_connection_status_changed):
1184 Do not use tny_device_force_offline() when tinymail says that something
1185 went wrong with the connection. It seems to report this unnecessarily.
1187 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/modest-connection-specific-smtp-window.c:
1190 (modest_connection_specific_smtp_window_init):
1191 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1192 does not seem to have any effect in osso 1.1 (though it works in
1193 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1195 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1197 * src/maemo/modest-connection-specific-smtp-window.c:
1198 Fix UI specification problems with projects.meamo.org NB#60479
1200 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1203 clue when this has failed, because the error dialog is not always shown
1204 (at least in earlier version).
1206 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1207 GError message, because the generic error dialog is not helpful.
1209 'This message is not currently available (can't let a new connection go online)'
1210 when trying to open an IMAP message.
1212 (_modest_ui_actions_open): Offer a connection when some messages would
1213 have to be downloaded and we are offline.
1215 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1217 * src/widgets/modest-folder-view.c:
1218 Don't check for MERGE type anymore as we use the correct type
1220 NOTE: For the last two changes you need to update your tinymail copy
1221 because of API changes!
1223 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1225 * src/modest-tny-local-folders-account.c:
1226 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1227 (see projects.maemo.org NB#61580)
1229 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1231 * src/modest-tny-account.c: (on_connection_status_changed):
1232 Commented out the call to modest_platform_connect_and_wait() because this
1233 seems to always hang, and I would like to know if this is the only thing
1234 that causes a hang when showing the connection dialog.
1235 It is not very useful anyway.
1237 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1239 * src/maemo/modest-msg-view-window.c:
1240 (modest_msg_view_window_select_next_message):
1242 * src/modest-platform.h:
1243 * src/maemo/modest-platform.c:
1244 Added modest_platform_connect_and_wait(), which calls
1245 tny_maemo_conic_device_connect() always in the main thread, by calling it
1246 in an idle handler and waiting for the idle handler to run. It should be
1247 in the main thread because it uses GTK+ UI code. It just returns TRUE
1248 if the device is already online.
1250 There is some nasty code to ensure that subsequent calls to
1251 modest_platform_connect_and_wait() just wait for the first one to finish,
1252 by checking repeatedly in another idle handler. This is necessary,
1253 because other threads (or even the main thread, via another idle handler)
1254 can call modest_platform_connect_and_wait() while
1255 modest_platform_connect_and_wait() is running.
1257 (modest_platform_connect_and_wait_if_network_account),
1258 (modest_platform_connect_and_wait_if_network_folderstore):
1259 Convenience functions that calls modest_platform_connect_and_wait() if
1260 the account or folder might want network access.
1262 * src/modest-mail-operation.c:
1263 (modest_mail_operation_update_account):
1264 * src/modest-ui-actions.c: (download_uncached_messages),
1265 (modest_ui_actions_on_rename_folder), (delete_folder),
1266 (modest_ui_actions_on_main_window_move_to),
1267 (modest_ui_actions_on_msg_view_window_move_to):
1268 * src/widgets/modest-folder-view.c:
1269 (drag_and_drop_from_folder_view):
1270 Offer a connection if we are offline.
1272 * src/modest-tny-account.c: (on_connection_status_changed):
1273 Document this as only handling errors during network operations in progress,
1274 and replace the idle code with a simple call to
1275 modest_platform_connect_and_wait(), which does this instead.
1277 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-tny-account.c:
1280 (modest_tny_account_get_special_folder): (util_on_idle),
1281 Handle the GError so we can see when tny_folder_store_get_folders()
1282 fails, as it currently does while something else is connecting.
1284 Added util_run_in_main_thread_and_wait()
1285 which uses an idlen handler and mainloop to ensure that the function
1286 is called in the main thread.
1287 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1288 to make sure that we call attempt the connection in the mainloop only,
1289 which might solve some hangs.
1291 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1293 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1294 be found by their display name. This is never useful.
1295 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1296 by its ID, instead of trying to use its ID as its display name.
1298 * src/modest-tny-account-store.h:
1299 * src/modest-tny-account.c:
1300 (modest_tny_account_get_special_folder): Add a g_warning() when
1301 tny_folder_store_get_folders() returns an empty list for the maildir.
1303 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1304 Add a g_warning() when this returns NULL, because that it not allowed
1307 2007-07-02 Armin Burgmeier <armin@openismus.com>
1309 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1310 note when trying to cancel the wizard. This fixes projects.maemo.org
1313 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1315 * src/modest-tny-account.h:
1316 * src/modest-tny-account.c:
1317 (modest_tny_account_new_from_server_account),
1318 (modest_tny_account_new_from_server_account_name),
1319 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1320 because this must now be set before setting the proto. This is usd in
1321 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1322 warning in camel_session_get_service() caused by
1323 tny_camel_transport_account_prepare().
1325 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1328 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1330 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1332 (modest_connection_specific_smtp_edit_window_init):
1334 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1335 of "changed" for now
1337 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-tny-account.c:
1340 (modest_tny_account_new_from_server_account):
1341 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1342 now uses to request a connection when it needs one, and which it uses
1343 to tell us that something is wrong with the connection, so we can force
1344 the accounts offline to prevent further problems.
1346 * src/modest-defs.h:
1347 * src/modest-init.c: (init_default_settings):
1348 * src/modest-mail-operation.c:
1349 (modest_mail_operation_update_account):
1350 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1351 This should not be necessary anymore. Do not set the conf key that
1352 determined this (it was always TRUE and not set anywhere else).
1354 * src/modest-ui-actions.h: Remove unused and unimplemented
1355 modest_ui_actions_on_online_toggle_toggled().
1357 2007-06-29 Murray Cumming <murrayc@murrayc.com
1359 * src/maemo/modest-main-window.c: (connect_signals):
1360 Don't connect to delete_event twice. Maybe this was harmless.
1362 2007-06-29 Murray Cumming <murrayc@murrayc.com
1364 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1365 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1366 Debug output to give some more clue when a folder move is not allowed.
1368 2007-06-28 Murray Cumming <murrayc@murrayc.com
1370 * src/modest-tny-account.c: (on_modest_file_system_info),
1371 (modest_tny_account_get_mmc_account_name):
1372 Always call the callback, without checking whether the name has changed.
1373 * src/widgets/modest-folder-view.c: (strings_are_equal),
1374 (on_model_foreach_set_name), (on_get_mmc_account_name),
1375 (text_cell_data): Compare the name here, and use the name from
1376 the account rather than from the
1377 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1378 if the name was changed after the account was added to the model.
1379 That's a tinymail bug but not one that I want to fix now.
1381 This finally fixes projects.maemo.org bug NB#59301.
1383 2007-06-27 Armin Burgmeier <armin@openismus.com>
1385 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1388 2007-06-27 Murray Cumming <murrayc@murrayc.com
1390 * src/modest-tny-account.h:
1391 * src/modest-tny-account.c:
1392 Added modest_tny_account_get_mmc_account_name(), to set the memory
1393 card name asynchronously for the given account and then notify.
1394 (modest_tny_account_new_for_local_folders): Use this new function instead
1395 of using hildon_file_system_info_async_new() directly.
1397 * src/widgets/modest-folder-view.c: (text_cell_data):
1398 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1399 gtk_tree_model_row_changed() when it is available.
1401 This should fix projects.maemo.org bug NB#59301.
1403 2007-06-27 Murray Cumming <murrayc@murrayc.com
1405 * src/modest-mail-operation.c: (update_account_thread),
1406 (get_msgs_full_thread): Fix typo failures in the revert
1409 2007-06-27 Murray Cumming <murrayc@murrayc.com
1411 * src/maemo/modest-maemo-global-settings-dialog.c:
1412 (idle_select_default_focus):
1413 * src/modest-mail-operation.c: (idle_notify_progress),
1414 (idle_notify_progress_once), (set_last_updated_idle),
1415 (update_account_thread), (get_msgs_full_thread):
1416 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1417 * src/widgets/modest-header-view.c:
1418 (idle_notify_headers_count_changed_destroy),
1419 (idle_notify_headers_count_changed):
1420 Reverted the additions of gdk_threads_enter/leave(), in case this
1421 helps with a startup hang on the device.
1423 2007-06-26 Armin Burgmeier <armin@openismus.com>
1425 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1426 for supported secure authentication methods from server by
1427 gtk_dialog_run(), saving CPU time and a potential race condition.
1429 2007-06-26 Armin Burgmeier <armin@openismus.com>
1431 * src/maemo/modest-maemo-utils.h:
1432 * src/maemo/modest-maemo-utils.c: Added a
1433 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1434 only error code to tell the calling code when the user canceled the
1437 * src/maemo/modest-account-settings-dialog.h:
1438 * src/maemo/modest-account-settings-dialog.c:
1439 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1440 message if the retrieval of secure authentication methods was canceled
1441 by the user. Perform the check before saving anything to configuration
1442 to not end up with half-committed configuration changes, do not show
1443 a "Saving to configuration failed" note when authentication methods
1444 could not be retrieved.
1446 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1449 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1451 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1452 Only return the first level of folders under accounts, because the
1453 osso-global-search UI spec doesn't want the rest.
1454 This fixed projects.maemo.org bug NB#61811.
1456 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1458 * src/modest-tny-account-store.c:
1459 * src/modest-tny-account-store.h:
1460 Added modest_tny_account_is_memory_card_account().
1461 * src/maemo/modest-main-window.c: (create_details_widget):
1462 Show the same information items for the memory card as we show for the
1463 local-folders, to fix projects.maemo.org bug NB#59307.
1465 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-tny-account-store.c: (get_password):
1468 Added some checks for NULL to maybe prevent crashes, though I think
1469 it was Philip's last commit that actually prevented the crash here
1470 when creating a first new account.
1471 But the new account is still not usable (no messages are shown)
1472 until a restart of the application.
1474 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/modest-maemo-global-settings-dialog.c:
1477 (idle_select_default_focus):
1478 * src/modest-mail-operation.c: (idle_notify_progress),
1479 (idle_notify_progress_once), (idle_notify_update_account_queue),
1480 (set_last_updated_idle), (update_account_thread),
1481 (notify_get_msgs_full), (get_msgs_full_destroyer),
1482 (get_msgs_full_thread):
1483 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1484 * src/widgets/modest-header-view.c:
1485 (idle_notify_headers_count_changed_destroy),
1486 (idle_notify_headers_count_changed):
1487 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1488 all idle handlers, because some other thread could be blocking
1489 the GDK lock, so that it can do GUI stuff.
1491 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1493 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1494 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1495 (on_idle_send_receive), (on_idle_open_default_inbox):
1496 * src/maemo/modest-msg-edit-window.c:
1497 (modest_msg_edit_window_attach_file_noninteractive):
1498 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1499 to prevent a hang. I don't quite understand why these are necessary,
1500 beause we should already be in the main loop. I guess something outside
1501 of the main loop is taking the lock.
1503 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1504 we are really using URIs, and use files that are more likely to exist.
1506 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1508 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1509 necessary because configure.ac now defines different variables.
1511 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1513 * libmodest-dbus-client/libmodest-dbus-client.c:
1514 * libmodest-dbus-client/libmodest-dbus-client.h:
1515 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1516 libmodest_dbus_client_compose_mail() is what things actually use.
1518 * src/dbus_api/modest-dbus-api.h:
1519 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1520 * tests/dbus_api/Makefile.am:
1521 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1524 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1526 * src/modest-init.c: (modest_init_local_folders):
1527 For memory-card (or other non local-folders) maildir accounts,
1528 always create an Archive folder, so that there is somewhere to put
1529 messages. This should be less confusing, because the user does not need
1530 to guess that the need to create a folder.
1532 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1534 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1535 Fixed icon size by using (50, 50) which is the same as defined by
1538 2007-06-25 Armin Burgmeier <armin@openismus.com>
1540 * src/widgets/modest-window-mgr.c:
1541 * src/modest-init.c:
1542 * configure.ac: Correctly recognize hildon-notify presence and fixed
1543 the build without it being installed.
1545 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1547 * libmodest-dbus-client/libmodest-dbus-client.c:
1548 (libmodest_dbus_client_search): Fix the build. Sorry.
1549 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1550 (reply_forward_cb): Initialize variables to fix the build.
1552 * src/modest-tny-account-store.c:
1553 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1554 comparison (a silly typo) so that email search results can be opened
1555 when there are more than one account.
1557 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1559 * libmodest-dbus-client/libmodest-dbus-client.c:
1560 (libmodest_dbus_client_search),
1561 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1562 instead of 1 second, because the search gets folders and messages from
1563 the server, which can take a long time. When it times out,
1564 osso-global-search will report no results.
1566 We need to specify whether we should search only cached information
1567 (maybe with a user preference), and the osso-email-search-plugin
1568 API should really be improved to allow that option, and to allow results
1569 to be delivered asynchronously in batches.
1571 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1573 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1574 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1575 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1577 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1580 that is an empty string. D-Bus seems to give us these instead of NULL.
1582 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1584 * src/dbus_api/modest-dbus-callbacks.c:
1585 * src/maemo/easysetup/modest-easysetup-wizard.h:
1586 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1587 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1588 (modest_connection_specific_smtp_edit_window_init):
1589 * src/maemo/modest-maemo-global-settings-dialog.c:
1591 * src/maemo/modest-maemo-utils.c:
1592 (modest_maemo_utils_setup_images_filechooser):
1593 * src/maemo/modest-main-window.c: (create_details_widget):
1594 * src/maemo/modest-msg-edit-window.c:
1595 (modest_msg_edit_window_attach_file_noninteractive),
1596 (modest_msg_edit_window_color_button_change),
1597 (modest_msg_edit_window_set_zoom):
1598 * src/modest-mail-operation.c: (update_account_thread):
1599 * src/modest-tny-account-store.c:
1600 * src/modest-tny-account.c:
1601 * src/widgets/modest-global-settings-dialog.c:
1602 * src/widgets/modest-window.h:
1604 Fixed build on bora!
1606 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1608 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1609 * src/modest-search.c: (modest_search_folder),
1610 (modest_search_all_accounts): Actually search only in the specified folder,
1611 doing a simple match on the folder ID.
1612 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1613 and added some documentation.
1615 2007-06-22 Armin Burgmeier <armin@openismus.com>
1617 * src/maemo/modest-maemo-utils.h:
1618 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1619 modest_maemo_utils_get_supported_secure_authentication_methods.
1621 * src/maemo/easysetup/modest-easysetup-wizard.c:
1622 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1623 one occured, not just "Server does not support secure authentication".
1625 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-tny-account-store.c: (get_password):
1628 Restored the call to tny_account_set_user() because Philip seems to have
1629 stopped this from crashing (by not using the freed string). It still does
1630 not work, but now we can test it.
1632 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/modest-msg-edit-window.c: (init_window):
1635 Comment out use of an uninitialzed GtkScrolledWindow variable,
1636 to fix the build and stop a crash. Yet again.
1638 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1640 * src/modest-tny-account-store.c: (get_password):
1641 Remove the call to tny_account_set_user() because this actually crashes.
1642 As mentioned in the last commit, it is known to not work anyway.
1644 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1646 * src/modest-tny-account-store.c: (get_password):
1647 Use tny_account_set_username() to tell tinymail that the username might
1648 have changed too. But tinymail ignores this: see projects.maemo.org
1650 * src/modest-ui-actions.c:
1651 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1652 reset the connection when changing the username, and improve the comments.
1653 Save the changed username to gconf at least, so it is used when Modest is
1656 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1658 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1659 Do not use a query, so that we get all folders, including for POP and
1660 local-folders. They work as search criteria too.
1661 This fixes projects.maemo.org bug NB#57740.
1663 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1665 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1666 Comment out the use of hildon_notification_set_sound() because it is
1667 not declared, to fix the build. Warnings are serious, people.
1669 2007-06-21 Armin Burgmeier <armin@openismus.com>
1671 * src/maemo/modest-maemo-utils.h:
1672 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1673 modest_maemo_utils_get_supported_secure_authentication_methods()
1674 to query authentication methods for a specific user. This should fix
1675 projects.maemo.org bug NB#61369.
1677 * src/maemo/easysetup/modest-easysetup-wizard.c:
1678 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1681 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1683 * libmodest-dbus-client/libmodest-dbus-client.h:
1684 * libmodest-dbus-client/libmodest-dbus-client.c:
1685 (modest_dbus_message_iter_get_search_hit),
1686 (libmodest_dbus_client_search):
1687 Reorganised and commented this.
1688 Removed modest_search_hit_free() from the public API because it
1691 Added libmodest_dbus_client_get_folders() and
1692 modest_folder_result_list_free().
1694 * src/dbus_api/modest-dbus-api.h:
1695 * src/dbus_api/modest-dbus-callbacks.c:
1696 (modest_dbus_req_filter): Commented. Moved most code to
1697 on_dbus_method_search() and added on_dbus_method_get_folders().
1699 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1700 of the extra D-Bus handler.
1702 * tests/dbus_api/Makefile.am:
1703 * tests/dbus_api/test_get_folders.c: New test for
1704 libmodest_dbus_client_get_folders(). This seems to return an empty list
1705 at the moment. That could be the same error that causes the message list
1706 to be empty sometimes.
1707 This should help with projects.maemo.org bug NB#57740.
1709 2007-06-21 Armin Burgmeier <armin@openismus.com>
1711 * src/modest-mail-operation.c: Do not call
1712 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1713 notify the operation's end after having set the status to CANCELED for
1714 the operation queue to listen on. This fixes a deadlock when there
1715 were mail operations in the queue during its finalization.
1717 * src/modest-singletons.c: Reordered uninitialization of the account
1718 manager to happen after the mail operation queue was uninitialized
1719 because the mail operation's in the queue might still try to access
1720 the account manager (see modest_mail_operation_notify_end()). This
1721 fixes a potential crash when terminating the application.
1723 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-search.c:
1726 (search_mime_part_and_child_parts): Moved some code here so we
1727 can search recursively in child folders.
1728 (modest_search_folder): Search in the message as a mime part, instead
1729 of just its child mime parts.
1730 (read_chunk), (search_mime_part_ogs):
1731 Check how many bytes were read, to prevent an endless loop.
1732 Searching in message bodies now works. This finishes the fix for
1733 projects.maemo.org bug NB#61007.
1735 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1738 Add a g_warning when the item is not a folder.
1740 * src/modest-ui-dimming-rules.c:
1741 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1742 when selected item is not a folder (for instance, an account), because
1743 the UI spec only talks about folders.
1744 I am not sure what the UI spec wants, so this might not totally fix
1745 projects.maemo.org bug NB#60794.
1747 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1750 (load_from_file): Sort the list. The unsorted list would be more noticeable
1751 in non-English locales.
1753 * src/maemo/modest-msg-edit-window.c:
1754 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1755 warning and fix the build.
1757 * src/maemo/modest-progress-bar-widget.c:
1758 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1759 avoid a g_warning, and probably to avoid a crash.
1761 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1763 * src/modest-search.c: (modest_search_folder): Check for a GError
1764 when calling tny_folder_get_headers(), to show that this is not the cause
1767 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1769 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1770 Actually set the body query instead of the subject query.
1772 * src/modest-search.c: (search_mime_part_ogs),
1773 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1774 which would probably cause it to fail if we got this far.
1776 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1777 to simplify the code.
1778 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1779 be causing search-in-body to fail.
1781 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1783 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1785 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1786 Better debug message when the folder cannot be found.
1787 This should help with fixing projects.maemo.org bug #61287.
1788 * src/modest-search.c: (add_hit): Do not leak the furl string.
1790 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1792 * src/modest-ui-actions.c:
1793 (modest_ui_actions_on_folder_selection_changed):
1794 Do not special-case TNY_MERGE_FOLDER here, because
1795 modest_tny_folder_get_account() already does that. This fixes
1796 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1797 shown when the Outbox was selected).
1799 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1801 * libmodest-dbus-client/libmodest-dbus-client.c:
1802 (_dbus_iter_get_string_or_null): Initialize the string variable in
1803 case this helps with Dirk's crash.
1805 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1807 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1808 though it is not implemented yet (this function is maybe not even used),
1809 to avoid breaking ABI in future.
1810 * libmodest-dbus-client/libmodest-dbus-client.c:
1811 (get_attachments_string): Moved some code into this generic function.
1812 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1813 sends email. It is maybe not used.
1814 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1815 (on_send_mail): Use attachments.
1817 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1818 * src/maemo/modest-msg-edit-window.c:
1819 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1820 a filename before using it, to fix projects.maemo.org bug NB#58233.
1822 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1825 Initialize the continue_download variable to fix the build, and probably
1826 to fix randome behaviour.
1828 2007-06-18 Armin Burgmeier <armin@openismus.com>
1830 * src/modest-tny-send-queue.h:
1831 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1832 the queue so we can later show it in the UI. Replaced
1833 modest_tny_send_queue_msg_is_being_sent() by
1834 modest_tny_send_queue_get_msg_status().
1836 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1838 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1839 gpointer. This probably was not harmful, but just to be sure.
1841 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1843 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1844 Fix the build, but leave the function broken on Bora, because
1845 hildon_uri_action_get_service() does not exist.
1846 osso_uri_action_get_service() does not exist either, it seems.
1848 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1850 * src/modest-tny-account.c:
1851 (modest_tny_account_new_from_server_account):
1852 Uncommented the url debug output again, because it is useful for
1853 debugging, as I said in the comment.
1855 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1857 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1859 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1860 for Mameo Bora, to fix the build.
1862 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1865 Fixed build with hildon < 0.99
1867 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1868 Check if the selected account is busy instead of checking all accounts
1870 * src/modest-account-mgr-priv.h:
1871 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1872 (modest_account_mgr_init), (compare_account_name),
1873 (modest_account_mgr_set_account_busy),
1874 (modest_account_mgr_account_is_busy):
1875 * src/modest-account-mgr.h:
1876 Added busy information to the account manager. It possible to
1877 set an account to busy or not busy now.
1879 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1880 (modest_mail_operation_update_account),
1881 (modest_mail_operation_notify_end):
1882 Set the account to busy/not busy depending on the operation state.
1884 * src/widgets/modest-account-view.c:
1885 (modest_account_view_finalize), (get_last_updated_string),
1886 (update_account_view), (on_account_busy_changed), (init_view):
1887 Show string "Refreshing..." if the account is currently busy.
1889 All this fixes projects.maemo.org bug NB#59711
1891 2007-06-14 Armin Burgmeier <armin@openismus.com>
1893 * src/widgets/modest-attachments-view.h:
1894 * src/widgets/modest-attachments-view.c: Added
1895 modest_attachments_view_has_attachments() and fixed coordinate
1896 transformation in get_att_view_at_coords(). This fixes attachment
1899 * src/widgets/modest-msg-view.c: Make use of
1900 modest_attachments_view_has_attachments() to decide whether to show
1901 attachments in the header.
1903 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1905 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1906 (on_change), (on_combo_security_changed),
1907 (modest_connection_specific_smtp_edit_window_init),
1908 (modest_connection_specific_smtp_edit_window_set_connection),
1909 (modest_connection_specific_smtp_edit_window_is_dirty):
1910 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1911 * src/maemo/modest-connection-specific-smtp-window.c:
1914 Show an comfirmation dialog for the smpt-edit-window if there are
1915 unsaved changes and the user hits cancel.
1916 (projects.maemo.org bug NB#60479)
1918 2007-06-14 Armin Burgmeier <armin@openismus.com>
1920 * src/maemo/easysetup/modest-easysetup-wizard.c:
1921 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1922 address" info in banner instead of node, and select all the text as
1923 per UI spec. This fixes projects.maemo.org bug NB#60550.
1925 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1927 reviewed by: <delete if not using a buddy>
1929 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1930 * src/modest-ui-actions.c: (folder_refreshed_cb):
1932 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1934 * src/widgets/modest-folder-view.c: (filter_row):
1935 Explictly filter out the per-account outbox accounts. I don't know why
1936 these only sometimes show up, but now they should never show up in the UI.
1937 This should fix projects.maemo.org bug NB#60160.
1939 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1942 when the toolbar does not exist yet.
1943 * src/modest-widget-memory.c: (save_settings_header_view):
1944 Added g_warnings() to help us to discover when we are trying to set
1945 an empty columns list in gconf.
1947 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1949 * src/modest-init.h:
1950 * src/modest-init.c:
1951 Added modest_init_get_default_header_view_column_ids().
1953 * src/modest-widget-memory.c: (restore_settings_header_view):
1954 Use the new function to get defaults, if the gconf key is empty,
1955 instead of not creating any columns. This seems to fix the
1956 empty right-hand pane problems.
1958 * src/widgets/modest-header-view.h: Improved documentation.
1960 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1963 Revert the use of the display name as the account name, because this
1964 is generally wrong and would break the code that follows.
1966 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1968 * src/maemo/easysetup/modest-easysetup-wizard.c:
1969 (check_for_supported_auth_methods), (on_before_next),
1972 More correct fix for projects.maemo.org bug NB# 58991
1973 Do not longer accept AUTH_PASSWORD as secure method and choose
1974 correct method when creating the account.
1976 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1978 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1979 Fixed projects.maemo.org bug NB# 58991
1981 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-init.c: (modest_init_init_core),
1984 (modest_init_local_folders): Fixed compilation errors.
1986 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1988 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1989 Remove unnecessary lib/include, though it is good in principle when needed.
1991 * src/modest-init.c: (modest_init_one_local_folder),
1992 (modest_init_local_folders):
1993 * src/modest-init.h: Initialize the .modest library for memory cards,
1994 instead of just doing nothing for them. This should allow us to create
1995 folders there, fixing projects.maemo.org bug NB#59297.
1997 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1999 * libmodest-dbus-client/libmodest-dbus-client.c:
2000 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2001 (libmodest_dbus_client_compose_mail),
2002 (libmodest_dbus_client_open_message),
2003 (libmodest_dbus_client_send_and_receive),
2004 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2006 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2007 (on_idle_open_message), (modest_dbus_req_handler),
2008 (search_result_to_message), (modest_dbus_req_filter):
2009 * src/modest-search.c: (add_hit), (modest_search_folder),
2010 (modest_search_all_accounts): Improved debug messages.
2012 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2014 * src/modest-tny-account-store.c:
2015 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2018 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2021 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2023 * src/modest-tny-account-store.c: (get_server_accounts):
2024 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2025 even when there are no accounts, so that the Outbox folder is always
2026 visible. This fixes projects.maemo.org bug NB#60158.
2028 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2030 * src/maemo/modest-main-window.c: (create_details_widget):
2031 Use the mcen_va_never logical ID.
2033 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2035 * src/dbus_api/modest-dbus-api.h:
2036 * src/dbus_api/modest-dbus-callbacks.c:
2037 (on_idle_open_default_inbox), (on_open_default_inbox),
2038 (modest_dbus_req_handler):
2039 Added a new OpenDefaultInbox method.
2041 * libmodest-dbus-client/libmodest-dbus-client.h:
2042 * libmodest-dbus-client/libmodest-dbus-client.c:
2043 Added libmodest_dbus_client_open_default_inbox() to call the new
2044 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2045 though it should maybe be used by a new osso-email-interface function.
2047 * tests/dbus_api/Makefile.am:
2048 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2051 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2053 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2054 NULL, so that the signals get all the keys. This should not actually
2055 change any behaviour because we currently update everything when anything
2058 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2060 * src/widgets/modest-folder-view.c: (text_cell_data),
2061 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2062 (find_inbox_iter): If tinymail tells us that the folder is
2063 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2064 This causes the inbox to be selected at startup, fixing part of
2065 projects.maemo.org bug NB#56305.
2067 * src/modest-ui-dimming-rules.c:
2068 (modest_ui_dimming_rules_on_tools_smtp_servers):
2069 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2070 the SMTP servers menu item.
2071 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2072 that the SMTP Servers menu item is dimmed when there are no accounts,
2073 as a future version of the UI spec will require. This fixes
2074 projects.maemo.org bug NB#56305.
2076 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2078 * src/maemo/modest-maemo-utils.c:
2079 (modest_maemo_utils_get_supported_secure_authentication_methods):
2080 Added label to dialog instead of unreadable title
2082 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2083 (modest_main_window_new):
2084 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2087 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2088 * src/modest-account-mgr.h:
2089 Added method to avoid code duplication
2091 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2092 (modest_ui_actions_on_send_receive):
2093 Use modest_account_mgr_has_accounts
2095 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2097 * src/maemo/easysetup/modest-presets.c:
2098 (modest_presets_get_info_server_security): Do not report secure auth
2100 * src/modest-protocol-info.c: Use the defines for the gconf key names
2101 for secure authentication. This was not working because we were writing
2102 Password and reading password, and the check was case sensitive.
2103 With this, gmail now works for receiving and sending when created via
2106 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2108 * src/maemo/easysetup/modest-presets.c:
2109 (modest_presets_get_info_server_security): Correct the key name for
2110 SecureSmtp, because it seems to be case-sensitive.
2111 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2112 Do not try to get the 0th notebook page if there are 0 pages, to
2113 avoid a g_warning().
2115 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2117 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2118 Prevent use of the new notification feature for now, because it currently
2119 shows one dialog for each new email, which is annoying.
2121 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2123 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2124 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2125 when no country was selected, so that we show the global ones.
2126 * src/maemo/easysetup/modest-presets.c:
2127 (modest_presets_get_providers): Return only the global providers, not
2128 all providers when mmc=0 was requested.
2130 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2132 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2133 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2134 provider ID in the combo.
2136 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2137 Do not show the page numbers, because it would be confusing when we add
2138 the 2 extra pages for the custom setup, when the user chooses the "Other"
2139 provider. This fixes projects.maemo.org bug NB#59028
2141 * src/modest-init.c: (modest_init_init_core),
2142 (modest_init_local_folders):
2143 * src/modest-init.h:
2144 * src/modest-tny-account.c:
2145 (modest_tny_account_new_for_local_folders): Do not create default folders
2146 for the memory card. This should fix projects.maemo.org bug NB#59328.
2148 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2151 Free the changed_conf_keys string items. They are already freed in the
2152 idle handler if that runs first.
2154 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2156 * src/modest-ui-actions.c:
2157 (modest_ui_actions_on_password_requested): Check that the server name
2158 is not NULL, because I just saw a password dialog with (null) as the
2161 * src/modest-tny-folder.[h|c]: Added
2162 modest_tny_folder_is_memory_card_folder().
2163 * src/modest-ui-dimming-rules.c:
2164 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2165 menu item for memory cards, as per the UI spec (section 7.4). This should
2166 fix projects.maemo.org bug NB#59297.
2168 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2170 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2171 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2172 is another problem with the code, see Murray's comment at line 772)
2174 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2177 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2178 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2179 (load_from_file), (easysetup_country_combo_box_init),
2180 (easysetup_country_combo_box_get_active_country_ids),
2181 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2182 instead of just one ID, to avoid duplicate country names in the UI.
2184 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2185 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2186 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2187 a single ID, avoiding duplicate providers.
2188 * src/maemo/easysetup/modest-easysetup-wizard.c:
2189 (on_combo_account_country): Adapt to use a list.
2191 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2193 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2194 keys changed in the last X seconds.
2196 * src/modest-account-mgr.h:
2197 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2198 (on_key_change), (modest_account_mgr_class_init),
2199 (modest_account_mgr_init), (modest_account_mgr_finalize):
2200 As the keys are changed, save them in a GSList* and signal that GSList*
2201 further every X seconds, to batch changes, to allow us to do just one
2202 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2203 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2205 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2206 changed signal signature.
2208 * src/modest-conf.c: (modest_conf_set_list),
2209 (modest_conf_on_change): Reenable notification.
2211 (modest_conf_maemo_fake_on_change): Comment out the hack that
2212 notified immediately instead of asynchronously.
2214 * src/widgets/modest-account-view.h:
2215 * src/widgets/modest-account-view.c:
2216 (update_account_view): Select the previously-selected account ID,
2217 if possible. This fixes projects.maemo.org bug NB#56933.
2219 (on_account_changed), (on_account_removed),
2220 (modest_account_view_select_account):
2222 Remove the block/unblock functions
2223 because they were not useful.
2225 * src/maemo/modest-account-view-window.c:
2226 (on_delete_button_clicked), (on_edit_button_clicked),
2227 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2229 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2231 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2232 Improve the error dialog to show Incorrect Account Settings, which seems
2233 clearer, and say that the internal error message (to be removed from the
2234 dialog later) is often misleading.
2235 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2237 * src/modest-tny-account.c:
2238 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2239 URL because this is so useful for debugging on the device.
2241 * src/widgets/modest-serversecurity-combo-box.c:
2242 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2244 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2246 * src/modest-mail-operation.c:
2247 (modest_mail_operation_send_new_mail):
2248 Added a comment about a nasty but apparently harmless message. Details
2249 added to the wiki g_warnings() page.
2251 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2254 (modest_tny_send_queue_class_init):
2255 Do not use the priv struct because it is empty, to avoid g_warnings
2256 about a non-existant priv struct.
2258 * src/modest-tny-account-store.c:
2259 (modest_tny_account_store_get_server_account),
2260 (modest_tny_account_store_get_transport_account_for_open_connection
2261 ): Do not try to get transport server accounts for local folders,
2262 because they don't have any. This avoids a g_warning().
2264 * src/maemo/modest-main-window.c:
2265 (modest_main_window_notify_send_receive_initied),
2266 (on_configuration_key_changed):
2267 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2268 * src/modest-defs.h:
2269 * src/modest-mail-operation.c:
2270 (modest_mail_operation_update_account):
2271 * src/modest-tny-account-store.h:
2272 * src/modest-tny-account.c:
2273 (modest_tny_account_get_special_folder),
2274 (modest_tny_account_new_for_local_folders),
2275 (modest_tny_account_new_for_per_account_local_outbox_folder):
2276 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2277 * src/modest-tny-local-folders-account.c:
2278 (add_account_folders_to_merged_folder):
2279 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2280 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2281 (modest_ui_actions_on_send):
2282 * src/widgets/modest-folder-view.c: (update_model):
2283 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2284 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2285 modest_tny_account_store_get_tny_account_by_account() to
2286 modest_tny_account_store_get_server_account() to make the code clearer.
2288 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2290 * src/dbus_api/modest-dbus-api.h:
2291 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2292 * src/maemo/modest-msg-edit-window.c:
2293 (modest_msg_edit_window_attach_file_noninteractive):
2294 added g_warning in case the file to be attached does not exist
2295 * tests/dbus_api/test_compose_mail.c: (main):
2296 removed obsolete comment, added generic files as test case
2298 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2300 * src/modest-tny-account-store.c: (get_server_accounts):
2301 Create the local folders account only once, not once for each outbox, and
2302 not only when there are some outboxes.
2304 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2306 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2307 code that is causing a crash at startup. Sergio says that he is fixing this.
2309 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2311 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2312 * src/maemo/modest-account-settings-dialog.c:
2313 (create_page_outgoing),
2314 (modest_account_settings_dialog_set_account_name),
2315 (save_configuration):
2316 - Fixed handling of the "Use secure authentication" toggle to comply with
2317 the ui specification. See also projects.maemo.org bug NB#58400
2319 - Restore the Secure connection setting combo correctly when loading
2322 * src/maemo/modest-maemo-utils.c:
2323 (on_camel_account_get_supported_secure_authentication),
2324 (modest_maemo_utils_get_supported_secure_authentication_methods):
2325 Fixed a crasher if operation is canceled
2327 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2328 (modest_protocol_info_auth_is_secure):
2329 * src/modest-protocol-info.h:
2331 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2332 the sense of the "Use secure authentication" toggle.
2334 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2336 * src/modest-tny-account-store.h:
2337 * src/modest-tny-account-store.c:
2338 Added modest_tny_account_store_get_local_folders_account().
2340 * src/modest-tny-folder.h:
2341 * src/modest-tny-folder.c:
2342 (modest_tny_folder_get_account):
2343 Added this replacement for tny_folder_get_account() which returns
2344 the local-folders account for TnyMergeFolders, to avoid the
2345 warning about the unimplemented get_account_func() vfunc().
2347 (modest_tny_folder_get_rules),
2348 * src/modest-ui-actions.c:
2349 (modest_ui_actions_on_folder_selection_changed):
2350 * src/modest-mail-operation.c:
2351 (modest_mail_operation_remove_folder),
2352 (modest_mail_operation_xfer_folder),
2353 (modest_mail_operation_rename_folder),
2354 (modest_mail_operation_get_msg),
2355 (modest_mail_operation_get_msgs_full),
2356 (modest_mail_operation_remove_msg),
2357 (modest_mail_operation_xfer_msgs),
2358 (modest_mail_operation_refresh_folder):
2359 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2361 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2363 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2364 (modest_server_account_set_security):
2365 * src/modest-defs.h: Add comments explaining that our
2366 UI spec means TLS when it says Normal, so these do not look like errors.
2368 * src/modest-tny-account.c:
2369 (modest_tny_account_new_from_server_account): Use the new tinymail
2370 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2371 for TLS. This should fix projects.maemo.org bug NB#58460.
2373 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/easysetup/modest-easysetup-wizard.c:
2376 (create_account): Correct the position of the gconf sanity check warning.
2377 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2378 of using the g_idle_add() hack, because this does not seem to be necessary
2379 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2380 caused by something other than maemo's gconf.
2381 This fixes projects.maemo.org bug #59022.
2383 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2385 * src/modest-account-mgr-helpers.c:
2386 (modest_account_mgr_get_default_account): Do not check that the account
2387 exists if there is no default account (NULL), to fix a runtime warning.
2389 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2391 * src/widgets/modest-folder-view.c: (update_model):
2392 Do not unref the treemodel before we have finished with it.
2393 This prevents a valgrind warning and an occasional crash at startup.
2395 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2397 * libmodest-dbus-client/libmodest-dbus-client.h:
2398 added libmodest_dbus_client_compose_mail()
2399 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2401 added functions needed for SendAsMail() functionality
2402 * src/maemo/modest-msg-edit-window.c:
2403 (modest_msg_edit_window_attach_file_noninteractive):
2404 non interactively attaching files to message edit window
2405 * src/widgets/modest-msg-edit-window.h:
2406 * tests/dbus_api/Makefile.am:
2407 added test_compose_mail.c
2408 * tests/dbus_api/test_compose_mail.c: (main):
2410 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2412 * src/modest-account-view.c:
2413 Fixed bug projects.maemo.org bug NB#59307
2415 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2417 * src/maemo/easysetup/modest-easysetup-wizard.c:
2418 (get_serverport_incoming), (on_before_next), (create_account):
2419 * src/maemo/modest-account-settings-dialog.c:
2420 (modest_account_settings_dialog_set_account_name):
2421 * src/maemo/modest-maemo-utils.c:
2422 (on_camel_account_get_supported_secure_authentication_status),
2423 (on_camel_account_get_supported_secure_authentication),
2424 (on_secure_auth_cancel),
2425 (modest_maemo_utils_get_supported_secure_authentication_methods):
2427 Implemented security authentication for settings and easysetup.
2429 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/modest-main-window.c: (create_details_widget):
2432 Show the total size for memory card accounts too, instead of showing
2433 the name again. Fixes bug projects.maemo.org bug NB#59307.
2435 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2438 * src/modest-tny-simple-folder-store.c:
2439 * src/modest-tny-simple-folder-store.h: Removed.
2441 * src/modest-tny-local-folders-account.h
2442 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2443 for the local-folders maildir, with an extra TnyMergedFolder containing
2444 the folders of the per-account outbox store accounts.
2445 * src/modest-tny-account-store.c: (get_server_accounts):
2446 Add the outboxes to the special local folders account after creating it.
2448 * src/modest-tny-account.c:
2449 (modest_tny_account_new_for_local_folders): Create the derived
2450 account when creating the main local-folders account.
2452 * src/maemo/modest-main-window.c: (create_details_widget),
2453 (modest_main_window_set_contents_style):
2454 Adapted to the use of the derived account instead of the folder store.
2456 * src/modest-ui-actions.c:
2457 (modest_ui_actions_on_folder_selection_changed):
2458 * src/modest-ui-dimming-rules.c:
2459 (modest_ui_dimming_rules_on_new_folder):
2460 * src/widgets/modest-folder-view.c: (text_cell_data),
2461 (icon_cell_data), (filter_row), (update_model),
2462 (get_cmp_rows_type_pos):
2465 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2466 Do not get the priv struct, because no priv struct has been set,
2467 to avoid a runtime warning.
2469 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2470 #ifelse with #else, to fix a warning, to fix the build.
2473 2007-06-05 Christian Kellner <ckellner@openismus.com>
2475 * libmodest-dbus-client/libmodest-dbus-client.c:
2476 Fix small typo in doc (why do you always see them
2477 AFTER committing stuff?)
2480 2007-06-05 Christian Kellner <ckellner@openismus.com>
2482 * libmodest-dbus-client/libmodest-dbus-client.c:
2483 (libmodest_dbus_client_search):
2484 Initialize hit list with NULL. Also set folder list
2485 to "" if NULL was supplied.
2488 2007-06-03 Christian Kellner <ckellner@openismus.com>
2490 * libmodest-dbus-client/libmodest-dbus-client.c:
2491 (modest_search_hit_list_free):
2492 Make it save to call it with NULL.
2494 * src/dbus_api/modest-dbus-callbacks.c:
2495 * src/modest-search.c:
2496 Return full ModestSearchHits as the search result list not TnyHeader
2497 since can't be around withouth the correspoding TnyFolder.
2499 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2501 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2502 Added currently commented code to check for secure auth
2504 * src/maemo/modest-account-settings-dialog.c: (on_response),
2505 (save_configuration), (show_ok):
2506 Fixed projects.maemo.org bugs NB #59248 and #59251
2508 * src/maemo/modest-maemo-utils.c:
2509 (on_camel_account_get_supported_secure_authentication_status),
2510 (on_camel_account_get_supported_secure_authentication),
2511 (modest_maemo_utils_get_supported_secure_authentication_methods):
2512 * src/maemo/modest-maemo-utils.h:
2513 Moved get_supported_secure_authentication() method here to be able
2514 to use it from easysetup wizard.
2516 * src/modest-pair.c: (on_pair_compare_as_string):
2517 Should compare string with first part of pair and not
2518 strcmp pairs which will crash.
2520 * src/modest-protocol-info.c:
2521 (modest_protocol_info_protocol_is_store):
2522 * src/modest-protocol-info.h:
2523 Added modest_protocol_info_get_auth_protocol_name()
2525 2007-06-03 Armin Burgmeier <armin@openismus.com>
2527 * src/modest-mail-operation.c:
2528 (modest_mail_operation_get_msgs_full): Set priv->account also when
2529 only retrieving a single message. This avoids a crash when canceling
2532 (modest_mail_operation_notify_end): Do not explicitely remove the
2533 operation from the queue but only emit the progress_changed signal.
2534 The queue itself listens to that signal to remove the operation when
2535 it is finished. This reduces coupling and removes a potential deadlock
2536 when modest_mail_operation_notify_end() is called from the queue
2537 itself. If that is a problem performance-wise, I would suggest to
2538 implement a status-changed signal or something.
2540 * src/modest-mail-operation-queue.c: Make sure to never call a
2541 function from another file while the queue is locked. This (hopefully)
2542 fixes another deadlock when exiting the application while retrieving
2545 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2547 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2548 Fixed build if libogs is not available
2550 2007-06-03 Christian Kellner <ckellner@openismus.com>
2552 * libmodest-dbus-client/libmodest-dbus-client.h:
2553 * libmodest-dbus-client/libmodest-dbus-client.c:
2554 (libmodest_dbus_client_delete_message):
2555 Implement deletion of messages (Client side).
2557 (modest_search_hit_free),
2558 (modest_search_hit_list_free):
2559 Utility functions to free the result hits.
2561 * src/dbus_api/modest-dbus-api.h:
2562 * src/dbus_api/modest-dbus-callbacks.c:
2563 (on_delete_message),
2564 (modest_dbus_req_handler):
2565 Implement deletion of messages (Server side).
2567 * tests/dbus_api/test_search.c: (main):
2570 * tests/dbus_api/Makefile.am:
2571 * tests/dbus_api/test_delete_message:
2572 Add little test for the message deletion logic
2574 2007-06-03 Armin Burgmeier <armin@openismus.com>
2576 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2577 when the operation queue was not empty. projects.maemo.org bug
2580 2007-06-03 Armin Burgmeier <armin@openismus.com>
2582 * src/widgets/modest-account-view.c
2583 (on_account_default_toggled): Toggle default account column
2584 explicitely instead of waiting for gconf notification (which is
2585 currently ignored). This should fix projects.maemo.org bug NB#56910
2586 for now. It should probably be removed when gconf notifications are
2589 2007-06-03 Christian Kellner <ckellner@openismus.com>
2591 * libmodest-dbus-client/libmodest-dbus-client.c:
2592 Removed debugging spew.
2594 * src/dbus_api/modest-dbus-callbacks.c:
2595 Added debugging info.
2597 * src/modest-search.c:
2598 (modest_search_all_accounts):
2599 Use tny_account_store_get_accounts () on the account store
2600 to get all accounts which is the way to get all accounts.
2602 * tests/dbus_api/test_search.c: (main):
2603 Make it possible to supply the search term on the command line.
2605 2007-06-03 Christian Kellner <ckellner@openismus.com>
2607 * libmodest-dbus-client/libmodest-dbus-client.c:
2608 * libmodest-dbus-client/libmodest-dbus-client.h:
2609 Implement searching for mesages over raw dbus. (Client side)
2611 * src/dbus_api/Makefile.am:
2612 * src/dbus_api/modest-dbus-api.h:
2613 * src/dbus_api/modest-dbus-callbacks.c:
2614 * src/dbus_api/modest-dbus-callbacks.h:
2615 Search framework (Server side). Also implement on_idle_open_message().
2617 * src/maemo/modest-platform.c: (modest_platform_init):
2618 Prepare for raw dbus/osso rpc interaction.
2620 * src/modest-search.h:
2621 Changed minsize from unspecific guint to guint32.
2623 * src/modest-search.c:
2625 Added strange hack which magically made tnymail work.
2627 (modest_search_folder),
2628 (modest_search_account),
2629 (modest_search_all_accounts):
2630 Implement helper functions to search all accounts, specific account
2633 * tests/dbus_api/Makefile.am:
2634 * tests/dbus_api/test_open_message.c:
2635 Read url to open from commandline.
2637 * tests/dbus_api/test_search.c:
2638 Implement small test for dbus search stuff
2640 2007-06-02 Armin Burgmeier <armin@openismus.com>
2642 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2643 include account type and account title. This fixes projects.maemo.org
2646 * src/maemo/modest-account-view-window.c: Set a title for the window.
2648 2007-06-02 Armin Burgmeier <armin@openismus.com>
2650 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2651 incoming and outgoing server name based on email address and server
2652 types as long as the names have not been edited manually. This fixes
2653 projects.maemo.org bug NB#58671.
2655 2007-06-02 Armin Burgmeier <armin@openismus.com>
2657 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2658 server type cannot be changed in future to the incoming details page
2659 when creating an account. This fixes projects.maemo.org bug NB#59029.
2661 2007-06-02 Armin Burgmeier <armin@openismus.com>
2663 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2664 and assigned max width chars so that they wrap instead of being
2665 truncated. Fixes projects.maemo.org bug NB#56126.
2667 2007-06-02 Armin Burgmeier <armin@openismus.com>
2669 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2670 introductory note to the connection specific smtp servers dialog, as
2671 section 8.12 of the email UI specification requires. This fixes
2672 projects.maemo.org bug NB#59212.
2674 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2677 Check for running mail operations, and offer to cancel them, as per the UI
2678 spec. This fixes projects.maemo.org bug NB#59041 .
2679 However, I suspect that tinymail may still use the network connection
2680 in ways that we cannot detect or cancel. But it should at least adapt to
2681 changes fairly well.
2683 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2685 * src/modest-tny-account-store.c: (recreate_all_accounts),
2686 (get_cached_accounts), (get_server_accounts): Do more sensible
2687 ref-counting of the temporarily-cached outbox accounts list. This seems
2688 to fix a crash when entering the password when the password was wrong.
2690 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2692 * src/gnome/modest-main-window.c: (connect_signals):
2693 * src/modest-tny-account-store.c: (get_password),
2694 (modest_tny_account_store_alert): Added comments and clues and
2695 commented-out code about how we currently fail to deal with connection
2696 errors and wrong passwords, and how we should.
2698 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2700 * src/widgets/modest-retrieve-combo-box.c:
2701 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2702 This fixes projects.maemo.org bug NB#58472 .
2704 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/easysetup/modest-easysetup-wizard.c:
2707 (create_page_complete_easysetup):
2708 (create_page_complete_custom): Correct the last commit,
2709 putting the correct sentences in the correct pages.
2711 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2713 * src/maemo/easysetup/modest-easysetup-wizard.c:
2714 (create_page_complete_custom): Show the second sentence of text
2715 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2718 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2720 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2721 Set the leave-on-server conf key by default. This fixes
2722 projects.maemo.org bug NB#59258 .
2724 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/modest-account-view-window.c:
2727 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2728 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2731 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2733 * src/maemo/easysetup/modest-easysetup-wizard.c:
2734 (create_caption_new_with_asterisk):
2735 * src/maemo/modest-account-settings-dialog.c:
2736 (create_caption_new_with_asterisk):
2737 Uncomment the code to add the asterisk, because they are no longer in the
2738 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2739 (update_incoming_server_title): Add an asterisk here too.
2741 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/modest-maemo-global-settings-dialog.c:
2744 (current_connection): Check that we are even connected before trying to
2745 get the current connection name, to prevent a warning.
2747 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2748 Change the comments because tny_maemo_conic_device_connect() is now meant to
2750 * src/modest-mail-operation.c:
2751 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2752 make sure we have a connection and fail if we can't connect.
2754 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2756 * src/maemo/modest-main-window.c:
2757 (on_account_store_connecting_finished): Do not try to get the
2758 connection ID if we are not really connected. I am surprised that
2759 this signal handler is called when we are not connected.
2761 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-error.h:
2764 * src/modest-ui-actions.c:
2765 (modest_ui_actions_get_msgs_full_error_handler):
2766 Renamed an enum, added comments, added an enum
2767 for retrieve-limit errors.
2769 * src/modest-mail-operation.c: (foreach_add_item),
2770 (internal_folder_observer_update), (update_account_thread),
2771 (modest_mail_operation_get_msgs_full):
2772 (modest_mail_operation_update_account),
2773 Added comments about how this works, and some code that should
2774 (but does not) check the retrieve-limit. See the TODO comment.
2776 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2778 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2779 Initialize help_id to fix the build. Warnings are good.
2781 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2783 * src/widgets/modest-hbox-cell-renderer.c:
2784 (modest_hbox_cell_renderer_append):
2785 * src/widgets/modest-vbox-cell-renderer.c:
2786 (modest_vbox_cell_renderer_append):
2787 Fix the last commit by doing an extra ref.
2789 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2791 * src/widgets/modest-hbox-cell-renderer.c:
2792 (modest_hbox_cell_renderer_append):
2793 * src/widgets/modest-vbox-cell-renderer.c:
2794 (modest_vbox_cell_renderer_append):
2795 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2796 to fix the build with Maemo Bora.
2797 However, there seems to be a remaining crash, probably due to reference
2800 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2802 * src/modest-tny-account.c:
2803 (modest_tny_account_new_for_local_folders):
2804 Use hildon_file_system_info_async_new() to get a better name for
2805 the memory card account, setting it as the account name.
2806 The timing seems to work, but this is probably
2807 not the best place to do this. See the TODO comment.
2808 * src/maemo/modest-main-window.c: (create_details_widget):
2809 * src/widgets/modest-folder-view.c: (text_cell_data):
2810 Use the tny account name instead of hardcoding a name.
2812 2007-05-30 Christian Kellner <ckellner@openismus.com>
2814 * src/modest-search.c: (modest_search):
2815 Correctly set part_search_func even if we have already parsed
2816 the query and thus a valid OgsTextSearcher object.
2818 2007-05-30 Christian Kellner <ckellner@openismus.com>
2821 Search and check for libogs.
2824 Incooparte the ogs build env.
2826 * src/modest-mime-part-search-stream.c:
2827 * src/modest-mime-part-search-stream.h:
2828 Removed since we do the real searching now in modest-search.c.
2830 * src/modest-search.c:
2831 * src/modest-search.h:
2832 Implement support for ogs. We use that if available and requested
2833 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2834 should now handle the corner case when the search term is spread
2835 across multiple reads.
2836 Also the logic in modest_search () was corrected to search all
2837 requested fields until one is found.
2839 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2841 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2843 * src/modest-init.h:
2844 * src/modest-init.c: Made modest_init_local_folders() take a
2845 path and be public so we can iniitialize maildir folders on
2848 * src/modest-local-folder-info.h:
2849 * src/modest-local-folder-info.c:
2850 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2852 * src/modest-tny-account.c:
2853 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2854 still means the standard local-folders path on the local volume.
2856 * src/modest-tny-account-store.c:
2857 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2858 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2859 all accounts when that happens.
2860 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2861 this too, so it shows up in the treeview.
2863 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2865 * src/maemo/modest-maemo-global-settings-dialog.c:
2866 (current_connection):
2867 * src/widgets/modest-global-settings-dialog.c:
2868 (current_connection_default):
2869 Use the enum values instead of 0, 1 and -1,
2870 to make the code clearer.
2872 * src/modest-account-mgr-helpers.c:
2873 (modest_account_mgr_get_connection_specific_smtp): Make this code
2876 * src/modest-runtime.h:
2877 * src/modest-runtime.c:
2878 Added modest_runtime_remove_all_send_queues().
2879 * src/maemo/modest-main-window.c:
2880 (on_account_store_connecting_finished): Recreate the send queues,
2881 using the appropriate transport accounts for this new connection.
2882 Some futher adapting might be needed if the old send queues are not
2883 automatically stopped at this point.
2885 * src/modest-tny-account-store.c: (get_server_accounts):
2886 Create the connection-specific transport accounts, so that they can
2887 be found later by their ID.
2889 * src/modest-tny-account.h:
2890 * src/modest-tny-account.c:
2891 Added modest_tny_account_new_from_server_account_name().
2892 modest_tny_account_new_from_server_account(): Do not create the
2893 send queues here, because they will be
2894 recreated anyway when the connection changes for the first time.
2896 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2898 * src/modest-local-folder-info.h:
2899 * src/modest-local-folder-info.c:
2900 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2901 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2902 tbox_folder): Take a modest account name instead of a server TnyAccount,
2903 so we can have per-modest-account rather than per-transport-account
2905 We must make sure that we change or recreate the exisitng send queues
2906 when the connection changes for connection-specific transport accounts.
2908 * src/modest-tny-account-store.c:
2909 (create_per_account_local_outbox_folders): Create outboxed per modest
2910 account, not per transport account.
2912 * src/modest-tny-account.h:
2913 * src/modest-tny-account.c:
2914 (modest_tny_account_get_special_folder): For outboxes, get the
2915 parent modest account name. The account is ignored for other folders.
2916 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2917 modest account name rather than a server TnyAccount.
2919 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2921 * src/modest-tny-account.c:
2922 (modest_tny_account_new_from_server_account):
2923 Call modest_runtime_get_send_queue() immediately after creating transport
2924 accounts, so that they start trying to send email from the outbox as soon
2925 as possible at startup. This is probably what we want.
2927 * src/modest-mail-operation.c: (update_account_thread):
2928 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2929 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2930 * src/modest-tny-send-queue.h:
2931 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2932 (modest_ui_actions_on_send):
2933 Added comments about how sending works, though it needs some more work.
2935 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2937 * src/modest-tny-account.c:
2938 (modest_tny_account_get_special_folder): Add TODO because this fails when
2939 the network is busy.
2940 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2941 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2942 Do not try to show this window when there is no active account. The UI
2943 specs does not tell us what to do in this case.
2945 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2949 * src/maemo/Makefile.am:
2950 * src/widgets/Makefile.am: Some dist fixes.
2952 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2954 * src/maemo/modest-connection-specific-smtp-window.c:
2955 (on_button_edit): Make the code clearer, to prevent a double free.
2957 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2959 * src/maemo/modest-account-settings-dialog.c:
2960 (modest_account_settings_dialog_set_account_name),
2961 Check the connection-specific smtp servers checkbox if there are any.
2963 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2964 (modest_connection_specific_smtp_edit_window_init):
2965 Start with a suitable port number.
2967 * src/modest-account-mgr-helpers.h:
2968 * src/modest-account-mgr-helpers.c: Added
2969 modest_account_mgr_get_has_connection_specific_smtp().
2971 (modest_account_mgr_set_connection_specific_smtp),
2972 (modest_account_mgr_remove_connection_specific_smtp),
2973 (modest_account_mgr_get_has_connection_specific_smtp),
2974 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2975 connection-specific smtp server accounts in the account, rather than
2976 the server account conf dir.
2978 This fixes bug projects.maemo.org bug NB#58263 .
2980 * src/modest-tny-account-store.c:
2981 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2982 if there are no server accounts yet, to prevent an infinite loop when there
2983 are no accounts. Document that one must be called before the other.
2985 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2987 * src/modest-account-mgr-helpers.c:
2988 (modest_account_mgr_get_default_account): Make sure that at least
2989 one account is always the default, if there are any enabled accounts.
2990 This is just a sanity check that shouldn't be necessary.
2992 * src/modest-account-mgr-priv.c:
2993 (_modest_account_mgr_account_from_key): Unescape the conf key to
2994 get the real account name. For instance, this is an issue if a space
2995 was in the account name, which can happen because the account name
2996 is generated from the display name.
2997 (_modest_account_mgr_get_account_keyname): Always escape the
2999 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3000 Unescape the conf keys to get the real account names.
3002 For instance, previously the is-default radio button in the accounts
3003 list was not checked for any accounts at first. This fixes that,
3004 and might fix several similar bugs.
3006 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3008 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3009 Removed some debug printfs.
3011 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3013 Modest on-disk outbox directories are now here, for instance:
3014 $HOME/.modest/outboxes/<account-id-1>/outbox
3015 $HOME/.modest/outboxes/<account-id-2>/outbox
3017 $HOME/.modest/local-folders/outbox
3018 so we can have a separate outbox for each account.
3019 But they are shown as one outbox in the GtkTreeView, by using a
3020 TnyMergeFolder in a ModestTnySimpleFolderStore.
3023 * src/modest-tny-simple-folder-store.c:
3024 * src/modest-tny-simple-folder-store.h:
3025 Added ModestTnySimpleFolderStore, used to contain folders from
3026 other folder stores, such as other accounts.
3028 * src/modest-tny-outbox-account.h:
3029 * src/modest-tny-outbox-account.c:
3030 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3031 used for the per-account local outbox folders.
3033 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3034 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3035 only use this (internally) now for the non-outbox local folders.
3037 * src/modest-init.h:
3038 * src/modest-init.c: Added modest_init_one_local_folder(), for
3039 setting up the directory structure for each local folder.
3041 * src/modest-local-folder-info.c:
3042 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3043 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3045 * src/modest-local-folder-info.h:
3046 * src/modest-tny-account-store.c: (on_account_removed),
3047 (on_account_changed), (create_per_account_local_outbox_folders),
3048 (get_server_accounts), (modest_tny_account_store_get_accounts),
3049 (modest_tny_account_store_get_tny_account_by_account),
3050 (modest_tny_folder_store_is_virtual_local_folders):
3052 * src/modest-tny-account.h:
3053 * src/modest-tny-account.c:
3054 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3055 to create an on-disk per-account local outbox folder for each
3057 (create_per_account_local_outbox_folders): Create a local outbox folder
3058 for each transport account.
3059 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3060 for all local folders.
3062 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3063 instead of using g_object_get/set() directly. It is clearer.
3065 (modest_tny_folder_store_get_message_count),
3066 (modest_tny_folder_store_get_local_size
3067 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3068 because we now use these with non-acount folder stores.
3070 (modest_tny_account_get_special_folder),
3071 (modest_tny_account_new_from_server_account),
3072 (modest_tny_account_new_from_account):
3073 (recurse_folders): Adjust to the new outbox system.
3075 * src/modest-tny-folder.h:
3076 * src/modest-tny-folder.c:
3077 (modest_tny_folder_is_local_folder),
3078 (modest_tny_folder_get_local_folder_type),
3079 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3081 * src/widgets/modest-main-window.h:
3082 * src/maemo/modest-main-window.c: (create_details_widget),
3083 (modest_main_window_set_contents_style): Show details for any folder store,
3086 (modest_tny_folder_get_rules):
3087 Remove the const. C does not support constness enough for this.
3089 * src/modest-ui-actions.c:
3090 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3091 make all outboxes appear as one, in the usual local-folders tree node.
3093 (set_active_account_from_tny_account),
3094 (modest_ui_actions_on_folder_selection_changed):
3095 * src/widgets/modest-folder-view.c: (text_cell_data),
3096 (icon_cell_data), (filter_row),
3097 (add_account_folders_to_merged_folder),
3098 (add_account_folders_to_simple_folder_store), (),
3099 (get_cmp_rows_type_pos), (cmp_rows),
3100 (modest_folder_view_set_account_id_of_visible_server_account):
3101 Adjust to the new outbox system, using generic folder stores and folders
3102 in the GtkTreeModel.
3104 2007-05-23 Christian Kellner <ckellner@openismus.com>
3106 * src/modest-mail-operation.c:
3107 (modest_mail_operation_update_account):
3108 Use info->max_size instead of unintialized local var [small
3109 build fix]. (Added TODO to review that change since I don't
3112 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3114 * libmodest-dbus-client/libmodest-dbus-client.c:
3115 (libmodest_dbus_client_compose_mail): function added
3116 * src/dbus_api/modest-dbus-api.h:
3117 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3118 (on_compose_mail): Implementation of the SendAsMail functionality
3120 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-account-mgr.c:
3123 (modest_account_mgr_add_server_account): Set the secure-connection
3124 conf key for transport accounts as well as store accounts. I don't know
3125 why the if was there. For instance, this makes sure that we use SSL
3126 for the gmail preset from the easysetup wizard.
3128 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3130 * src/gnome/modest-main-window.c:
3131 (on_account_store_connecting_finished), (connect_signals):
3132 * src/maemo/modest-main-window.c:
3133 (on_account_store_connecting_finished), (connect_signals),
3134 (modest_main_window_new):
3135 Handle TnyAccountStore::connecting-finished instead of
3136 TnyDevice::connection-changed, because we cannot actually perform
3137 operations on accounts until TnyAccountStore has itself responded to
3138 the TnyDevice::connection-changed signal. This prevents a GError from
3140 Do not try to update at startup, because we (at least on scratchbox)
3141 already do an update at startup when the device goes online.
3142 This prevents a GError from tinymail.
3143 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3144 Added TODO about stopping simultaneous operations.
3146 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3149 * src/modest-mail-operation-queue.c:
3150 (modest_mail_operation_queue_remove):
3151 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3152 about where they happened.
3154 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3156 * src/modest-ui-actions.c:
3157 (modest_ui_actions_on_password_requested): Make sure that the remember
3158 output parameter is always TRUE.
3160 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3162 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3163 Show a OK/Cancel dialog if the error is a question, though we still do not
3164 know anything more about what we are asking the user.
3165 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3166 Fix an uninitialized variable (helper). This is a logic error, however.
3168 2007-05-21 Christian Kellner <ckellner@openismus.com>
3170 * src/modest-search.h:
3171 Correct bit shifting in the ModestSearchFlags enum.
3173 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3175 * src/modest-tny-account.c:
3176 (modest_tny_account_new_from_server_account): Do not use the lsub and
3177 check-all hard-coded IMAP options when using POP.
3179 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3181 * src/modest-tny-account.c:
3182 (modest_tny_account_new_from_server_account):
3183 Use NULL for the secure-auth method for POP when Password auth has been
3184 specified by the user, as we already do for IMAP. "auth=Login" causes
3185 an error from camel or the server.
3187 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-account-settings-dialog.c:
3190 (create_page_account_details),
3191 (modest_account_settings_dialog_set_account_name):
3192 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3193 for the leave-on-server checkbox, rathr than just the checkbox, when
3194 the protocol is not POP.
3196 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3198 * src/widgets/modest-account-view.c:
3199 * src/widgets/modest-account-view.h:
3200 Added modest_account_view_select_account() which will be useful later
3201 to asynchronously re-select the edited account.
3203 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/modest-account-settings-dialog.c:
3206 (modest_account_settings_dialog_set_account_name):
3207 Automatically choose the port numbers based on the secure authentication
3208 methods, if they have not been chosen before.
3209 This fixes projects.maemo.org bug NB#56273 .
3211 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/modest-main-window-ui.h:
3214 * src/modest-ui-actions.c:
3215 * src/modest-ui-actions.h:
3216 Connect the Tools/SMTP Servers menu item to
3217 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3218 SMTP servers dialog, as in the UI specification and saves changes when it
3219 is closed. This fixed projects.maemo.org bug NB#56305 .
3221 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3223 * src/maemo/modest-connection-specific-smtp-window.c:
3224 (modest_connection_specific_smtp_window_init):
3225 Use gtk_window_set_default_size() to make this window big enough, so
3226 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3228 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3230 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3231 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3232 (modest_connection_specific_smtp_edit_window_init),
3233 Do not try to connect to a combobox signal before the combobox exists.
3234 This fixes the cras in projects.maemo.org bug NB#56288 .
3235 (modest_connection_specific_smtp_edit_window_get_settings):
3236 Remove the server_account_name parameter which was being checked for NULL
3237 though it was not used.
3239 * src/maemo/modest-connection-specific-smtp-window.c:
3240 (modest_connection_specific_smtp_window_fill_with_connections),
3241 (on_button_edit), (modest_connection_specific_smtp_window_init):
3242 Correct the number of treemodel columns to prevent a warning.
3243 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3244 libconic does not work.
3246 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3248 * src/modest-tny-account.c:
3249 (modest_tny_account_new_from_server_account):
3250 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3251 SMTP when "None" was chosen by the user. However, with my SMTP server that
3252 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3255 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3257 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3258 to explain the memory management issue with the ID in the ModestPair.
3260 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3261 (add_sending_page), (modest_account_assistant_finalize):
3262 * src/gnome/modest-gnome-global-settings-dialog.c:
3263 (create_updating_page), (create_composing_page):
3264 * src/gnome/modest-msg-edit-window.c: (get_transports),
3265 (init_window), (modest_msg_edit_window_finalize),
3266 (modest_msg_edit_window_get_msg_data):
3267 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3268 * src/gnome/modest-transport-widget.c:
3269 (modest_transport_widget_finalize), (smtp_configuration):
3270 * src/maemo/modest-maemo-global-settings-dialog.c:
3271 (create_updating_page), (create_composing_page):
3272 * src/maemo/modest-msg-edit-window.c: (get_transports),
3273 (init_window), (modest_msg_edit_window_finalize),
3274 (modest_msg_edit_window_get_msg_data),
3275 (modest_msg_edit_window_free_msg_data):
3276 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3277 (modest_store_widget_finalize):
3278 * src/maemo/modest-transport-widget.c:
3279 (modest_transport_widget_finalize), (smtp_configuration):
3280 * src/modest-main.c: (send_mail):
3281 * src/widgets/modest-combo-box.h:
3282 * src/widgets/modest-global-settings-dialog-priv.h:
3283 * src/widgets/modest-global-settings-dialog.c:
3284 (modest_global_settings_dialog_finalize):
3285 * src/widgets/modest-msg-edit-window.h:
3286 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3287 as long as the combo box, to prevent use of freed memory for the ID.
3289 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3291 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3292 get_accounts(), to make this clearer. Do not check for the enabled gconf
3293 key, because we do not use this for server accounts (at least, not yet).
3294 This allows us to send email again.
3296 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3298 * src/maemo/modest-platform.c:
3299 (on_modest_conf_update_interval_changed), (modest_platform_init):
3300 Only respond to this particular key change. All these strcmp()s cannot be
3303 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3305 * src/maemo/modest-maemo-global-settings-dialog.c:
3306 (current_connection): Prevent a crash in scratchbox when
3307 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3308 * src/maemo/modest-platform.c:
3309 (on_modest_conf_update_interval_changed), (modest_platform_init):
3310 Get the update interval from gconf and reset it when the gconf key changes.
3312 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3314 * src/modest-protocol-info.c:
3315 * src/modest-protocol-info.h: Adde enum-specific get functions,
3316 instead of using a ModestProtocolType enum parameter.
3318 * src/gnome/modest-account-assistant.c:
3319 * src/gnome/modest-store-widget.c:
3320 * src/gnome/modest-store-widget.h:
3321 * src/gnome/modest-transport-widget.c:
3322 * src/gnome/modest-transport-widget.h:
3323 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3324 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3325 * src/maemo/easysetup/modest-easysetup-wizard.c:
3326 * src/maemo/modest-account-settings-dialog.c:
3327 * src/maemo/modest-account-settings-dialog.h:
3328 * src/maemo/modest-store-widget.c:
3329 * src/maemo/modest-store-widget.h:
3330 * src/maemo/modest-transport-widget.c:
3331 * src/maemo/modest-transport-widget.h:
3332 * src/modest-account-mgr-helpers.c:
3333 * src/modest-account-mgr-helpers.h:
3334 * src/modest-account-mgr.c:
3335 * src/modest-account-mgr.h:
3336 * src/modest-tny-account.c:
3337 * src/modest-tny-folder.c:
3338 * src/widgets/modest-account-view.c:
3339 * src/widgets/modest-retrieve-combo-box.c:
3340 * src/widgets/modest-retrieve-combo-box.h:
3341 * src/widgets/modest-secureauth-combo-box.c:
3342 * src/widgets/modest-serversecurity-combo-box.c:
3343 * src/widgets/modest-serversecurity-combo-box.h:
3344 * tests/check_account-mgr.c:
3345 Use the specific functions, and use the re-renamed enum values for GNOME too.
3347 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3349 * src/modest-pair.h:
3350 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3351 so we can get the second based on the first.
3353 * src/maemo/modest-account-settings-dialog.h:
3354 * src/maemo/modest-account-settings-dialog.c:
3355 Added get_supported_secure_authentication_methods(), though it is mostly
3356 commented-out for now until the necessary API is committed to tinymail.
3357 (modest_account_settings_dialog_set_account_name),
3358 (save_configuration): Request the supported authentication methods from the
3359 server, so we can choose a working method.
3361 * src/modest-tny-account-store.h:
3362 * src/modest-tny-account-store.c:
3363 (modest_tny_account_store_get_session): Rename from
3364 tny_account_store_get_session().
3366 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3368 * src/modest-protocol-info.h: Split the ModestProtocol enum
3369 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3370 There was no need to have these unrelated values in one enum.
3372 * src/: many files: Adapted to changed enum. This makes the code a bit
3373 clearer, and the compiler could catch some errors.
3375 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3377 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3378 Show the detailed internal camel error message when an error happens
3379 during the configuration, so that our testers can give us more clues.
3380 For instance, in projects.maemo.org bug NB#56910 .
3382 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3384 * src/modest-tny-account.c:
3385 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3386 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3388 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3390 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3391 * src/maemo/modest-account-settings-dialog.c:
3392 (modest_account_settings_dialog_set_account_name),
3393 (save_configuration): For the incoming secure authentication checkbox,
3394 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3395 the UI specification. PLAIN does not seem to be supported for most IMAP
3396 servers anyway, and I am not sure what it would mean.
3397 However, we probably need to discover which of the secure-authentication
3398 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3399 * src/modest-account-mgr-helpers.c:
3400 (modest_account_mgr_get_server_account_data):
3402 * src/modest-tny-account.c:
3403 (modest_tny_account_new_from_server_account):
3404 Use tny_account_set_mech() to set secure-authentication methods,
3405 with some special-casing for IMAP, based on my observations of how
3408 * src/modest-account-mgr-helpers.h:
3409 * src/modest-account-mgr.c:
3410 * src/modest-defs.h: Comment that the URI is only used for local folders.
3412 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3414 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3415 parameter const, just to be neat.
3416 * src/modest-text-utils.c: (modest_text_utils_inline):
3417 End g_strconcat() with NULL, as its documentation says. This is almost
3418 certainly the cause of my crash at startup on the device. Interestingly,
3419 valgrind doesn't tell us about these errors.
3421 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3423 * scripts/build-packages: Added more precise comments about how to use
3424 this script, though I still get this error:
3425 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3426 error building tinymail
3428 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3430 * src/maemo/modest-main-window.c: (on_account_update):
3431 Very slight cleanup, hoping to make it simpler to discover what causes
3432 a crash here sometimes.
3434 * src/modest-tny-account.c:
3435 (modest_tny_account_new_from_server_account): Set the port. Added
3436 comments about the options and a TODO comment because I need to find out
3437 how to specify the secure authentication method.
3439 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3441 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3442 changed CFlags paths form modest to libmodest
3444 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3446 * src/modest-account-mgr-helpers.c:
3447 (modest_account_mgr_get_server_account_data),
3448 (modest_account_mgr_free_server_account_data):
3449 * src/modest-account-mgr-helpers.h:
3450 * src/modest-account-mgr.c:
3451 (modest_account_mgr_add_server_account):
3452 * src/modest-defs.h:
3453 * src/modest-tny-account.c:
3454 (modest_tny_account_new_from_server_account):
3455 Determine the options for tny_camel_account_add_option() here,
3456 based on the settings, rather than storing them directly in gconf.
3458 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3460 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3461 Show a more friendly error dialog now that we expect (from the tinymail
3462 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3464 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3466 * src/maemo/modest-main-window.c: (on_account_update): Check that
3467 account_name is not NULL, to prevent a crash at startup that I am
3468 seeing on the N800. I do wonder why it is NULL.
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 (create_page_user_details):
3472 * src/maemo/modest-account-settings-dialog.c:
3473 (create_page_user_details), (create_page_outgoing):
3474 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3475 (modest_connection_specific_smtp_edit_window_init):
3476 * src/modest-ui-actions.c:
3477 (modest_ui_actions_on_password_requested):
3478 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3479 might do something useful with the on-screen keyboard.
3481 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/modest-main-window.c: (on_account_update):
3484 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3485 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3487 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3489 * src/modest-tny-account-store.c: (on_account_changed):
3490 Correct the signature of this signal handler.
3492 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3494 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3495 Show a HildonNote instead of a GtkDialog for Maemo.
3497 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3499 * src/widgets/modest-account-view.h:
3500 * src/widgets/modest-account-view.c: (on_account_changed),
3501 (on_account_removed). Added a boolean flag, set/unset by
3502 modest_account_view_block_conf_updates(),
3503 modest_account_view_unblock_conf_updates() to prevent unnecessary
3504 updates, but this is not very useful because the gconf notifications are
3505 so delays (maybe only on Maemo Bora).
3506 So auto-updating is turned off, and these functions do an explicit
3507 update when necessary.
3508 However, something else is still doing too much work when adding/removing
3509 accounts, probably in another part of the application.
3511 * src/maemo/modest-account-view-window.c:
3512 (on_delete_button_clicked), (on_edit_button_clicked),
3513 (on_new_button_clicked): Use the new functions.
3515 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3517 * src/modest-account-mgr-helpers.c:
3518 (modest_account_mgr_set_first_account_as_default):
3519 Sort the list of names alphabetically-by-title, so we choose the first one
3521 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3522 alphabetically by the title.
3524 This fixes projects.maemo.org bug NB#56418 .
3526 * src/modest-account-mgr-priv.c:
3527 (_modest_account_mgr_account_from_key):
3528 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3529 avoid a valgrind error, and possible random behaviour.
3531 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3533 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3534 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3535 tinymail documentation to say that this can be expected.
3536 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3537 pretty, and should not happen, but I would prefer to know when it does.
3539 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3541 * configure.ac: When using the older hildon version, probably on Bora,
3542 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3544 * src/widgets/modest-attachment-view.c:
3545 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3548 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3550 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3551 Implemented the prototype. Can be tested with
3552 tests/dbus_api/test_open_message:
3554 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3556 * src/modest-tny-account-store.c:
3557 (modest_tny_account_store_instance_init), (get_password):
3558 * src/modest-ui-actions.c:
3559 (modest_ui_actions_on_password_requested):
3560 Do not store the password in gconf, because this function is called
3561 for non-remembered passwords. Actually use the cached (in the hash map)
3562 password instead of releasing it.
3563 The password will now not be remembered if it is asked via the protected
3564 password dialog, as per the UI spec.
3566 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3568 * src/modest-defs.h:
3569 * src/modest-account-mgr-helpers.h:
3570 * src/modest-account-mgr-helpers.c:
3571 Added modest_server_account_get_username_has_succeeded(),
3572 modest_server_account_set_username_has_succeeded().
3573 (modest_server_account_set_username),
3574 Reset the has-succeeded flag if the username changes.
3576 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3577 * src/maemo/modest-connection-specific-smtp-window.c:
3578 (modest_connection_specific_smtp_window_save_server_accounts):
3579 Use modest_server_account_set_username() instead of using
3580 modest_conf_set_string() directly, so that the has-succeeded flag is always
3583 * src/modest-ui-actions.c:
3584 (modest_ui_actions_on_password_requested): Dim the username entry if
3585 the username has ever worked, as per the UI spec.
3587 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3589 * src/modest-tny-account-store.c: (get_password):
3590 * src/modest-ui-actions.c:
3591 (modest_ui_actions_on_password_requested):
3592 Allow the username to be changed too, though there is more work to
3593 be done on exactly how this behaves.
3595 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-account-mgr-helpers.h:
3598 * src/modest-account-mgr-helpers.c:
3599 Added modest_account_mgr_get_display_name(),
3600 modest_server_account_get_username(),
3601 modest_server_account_set_username(),
3602 modest_server_account_set_password(),
3603 modest_server_account_get_hostname() functions so we do not need to
3604 use the conf API directly.
3606 * src/maemo/modest-main-window.c: (connect_signals):
3607 Actually connect ot the ModestAccountStore::request-password signal,
3608 so that we show the dialog when the password is requested by Tinymail,
3609 for isntance if it is empty.
3611 * src/modest-marshal.list:
3612 * src/modest-tny-account-store.c:
3613 (modest_tny_account_store_class_init), (get_password),
3614 (modest_tny_account_store_alert):
3615 * src/modest-tny-account-store.h:
3616 * src/modest-ui-actions.h:
3617 * src/modest-ui-actions.c:
3618 (modest_ui_actions_on_password_requested):
3619 Change the signal parameters, so it is obvious that we are providing
3620 the non human-readable server name, and receiving both the username
3621 and password, though changing of the username is not yet implemented.
3622 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3623 for the GNOME version.
3625 This should fix the projects.maemo.org bug NB#56209, though it does not
3626 work on Bora, because the gconf_client_get() for the password fails
3627 immediately after we save it with gconf_client_set().
3629 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3632 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3633 caused an undefined symbol error:
3634 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3636 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3638 * src/modest-tny-account-store.c:
3639 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3640 using a GError instead of a string message, so we can translate it in
3643 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3645 * src/maemo/modest-address-book.c:
3646 (modest_address_book_check_names):
3647 * src/maemo/modest-msg-view-window.c:
3648 (modest_msg_view_window_clipboard_owner_change):
3649 * src/modest-init.c: (modest_init_init_ui):
3650 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3651 (update_folders_cb), (modest_mail_operation_update_account):
3652 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3653 (modest_ui_actions_on_msg_attachment_clicked),
3654 (modest_ui_actions_on_msg_recpt_activated):
3655 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3656 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3657 (modest_msg_view_search_next):
3658 * src/widgets/modest-recpt-editor.c:
3659 (modest_recpt_editor_on_button_release_event),
3660 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3661 g_message(). At this point we should only be seeing interesting errors on
3662 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3664 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3666 (modest_wizard_dialog_force_title_update):
3667 * src/maemo/easysetup/modest-wizard-dialog.h:
3668 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3669 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3670 can update the title when appropriate. Otherwise the title is wrong if the
3671 pages are added after adding the notebook to the dialog.
3672 This must be a problem in HildonWizardDialog too.
3673 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3675 * src/maemo/easysetup/modest-easysetup-wizard.c:
3676 (create_subsequent_customsetup_pages),
3677 (create_subsequent_easysetup_pages):
3678 Call modest_wizard_dialog_force_title_update() so that the title is
3679 correct even with GTK+ < 2.10.
3680 This fixes projects.maemo.org bug NB#56145 .
3682 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3684 * src/maemo/modest-platform.c:
3685 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3686 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3689 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3691 * src/widgets/modest-window.h:
3692 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3693 and modest_window_save_state(), which invokes it.
3695 * src/widgets/modest-window-mgr.h:
3696 * src/widgets/modest-window-mgr.c:
3697 Added modest_window_mgr_save_state_for_all_windows(), which calls
3698 the save_state vfunc on all registered windows, if implemented.
3700 * src/gnome/modest-msg-edit-window.c:
3701 * src/gnome/modest-msg-view-window.c:
3702 * src/maemo/modest-msg-edit-window.c:
3703 * src/maemo/modest-msg-view-window.c:
3704 * src/maemo/modest-main-window.c:
3705 Specify the existing save_settings functions as implementations of
3706 ModestWindow::save_state_func().
3708 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3709 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3710 enabling hibernation, for instance.
3712 We may need to do the same thing for restoring settings.
3715 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3717 * src/widgets/modest-window-mgr.c:
3718 * src/widgets/modest-window-mgr.h:
3719 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3720 modest_window_mgr_get_hibernation_is_prevented().
3722 * src/maemo/modest-main-window.c:
3723 (on_hildon_program_is_topmost_notify): Prevent hibernation
3724 (possible when the application goes to the background in the WM),
3725 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3727 * src/maemo/easysetup/modest-easysetup-wizard.c:
3728 (modest_easysetup_wizard_dialog_init):
3729 * src/maemo/modest-account-settings-dialog.c:
3730 (modest_account_settings_dialog_init):
3731 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3732 (modest_connection_specific_smtp_edit_window_init):
3733 * src/maemo/modest-connection-specific-smtp-window.c:
3734 (modest_connection_specific_smtp_window_init):
3735 * src/maemo/modest-signature-editor-dialog.c:
3736 (modest_signature_editor_dialog_init):
3737 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3738 prevent hibernation while any of these account settings dialogs are open.
3740 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3742 * src/maemo/Makefile.am:
3743 * src/maemo/modest-osso-state-saving.c:
3744 * src/maemo/modest-osso-state-saving.h: Added
3745 modest_osso_load_state() and modest_osso_save_state() though they do
3746 nothing now. They should iterate through all the open windows and load/save
3748 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3749 save state when closing.
3751 * src/maemo/modest-main-window.c:
3752 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3753 Add a notification handler for the HildonProgram::is-topmost property,
3754 so we can allow hibernation when the application goes into the background.
3755 But we still need to detect when the accounts setup windows are open so
3756 we can stop hibernation when they are open.
3757 To do this, I also added the main window the HildonProgram. This might have
3758 other side-effects/benefits, and should maybe be done for other windows.
3760 * src/maemo/modest-osso-autosave-callbacks.h:
3761 * src/maemo/modest-osso-autosave-callbacks.c:
3762 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3763 though it does not do anything yet, and we might never need this to do
3764 anything. For instance, we already save drafts.
3766 * src/maemo/modest-platform.c: (modest_platform_init):
3767 Specify the libosso auto-save callback.
3769 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/modest-platform.c:
3772 (modest_platform_set_update_interval):
3773 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3774 aparently stays valid between application instances, so we can use this
3775 to remove and reset it later. According to a maemo-developers email from
3778 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3780 * configure.ac: Depend on libalarm for Maemo.
3782 * src/dbus_api/modest-dbus-api.h:
3783 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3784 (on_send_receive), (modest_dbus_req_handler):
3785 Handle a SEND_RECEIVE D-Bus method.
3787 * libmodest-dbus-client/libmodest-dbus-client.c:
3788 (libmodest_dbus_client_send_and_receive):
3789 * libmodest-dbus-client/libmodest-dbus-client.h:
3790 Add C convenience functions for calling the new D-Bus method.
3792 * src/modest-platform.h:
3793 * src/gnome/modest-platform.c:
3794 * src/maemo/modest-platform.c:
3795 Added modest_platform_set_update_interval(), which uses the
3796 alarmd API on Maemo.
3797 (modest_platform_init),
3798 Call modest_platform_set_update_interval(), using a hard-coded
3799 interval for now (until the global settings dialog is implemented),
3800 though I am not sure that this makes sense yet.
3802 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3804 * src/dbus_api/modest-dbus-callbacks.c:
3805 (modest_osso_cb_hw_state_handler):
3806 * src/dbus_api/modest-dbus-callbacks.h:
3807 * src/maemo/modest-platform.c: (modest_platform_init):
3808 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3809 in case this has some effect on the ability for Maemo to ping the
3812 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3814 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3815 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3816 warning. It is probably a logic error, but I need to fix the build.
3818 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3820 * src/modest-account-mgr.h:
3821 * src/modest-account-mgr.c:
3822 (modest_account_mgr_account_names): Add a gboolean enabled_only
3823 parameter, so we can get lists of onlt the enabled accounts.
3825 (modest_account_mgr_add_account),,
3826 (modest_account_mgr_account_with_display_name_exists):
3827 * src/maemo/modest-msg-edit-window.c: (get_transports):
3828 * src/modest-account-mgr-helpers.c:
3829 (modest_account_mgr_set_first_account_as_default):
3830 * src/modest-init.c: (init_default_account_maybe):
3831 * src/modest-tny-account-store.c: (get_accounts):
3832 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3833 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3834 * tests/check_account-mgr.c: (START_TEST):
3835 Provide the extra parameter, as appropriate.
3837 * src/widgets/modest-account-view.c: (update_account_view):
3838 Do not show disabled accounts (meaning that there is no way to
3839 enable/disable accounts in the UI (the feature is not in our UI
3840 specification), so we can use this internally only to mark unfinished
3841 or temporary account data.
3843 * src/maemo/easysetup/modest-easysetup-wizard.c:
3844 (create_account): Add boolean enable parameter, so we can specify FALSE
3845 to create the temporary account.
3846 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3847 (on_before_next): When finishing, when there is a temporary account, just
3849 Also, use a timeout to delay the showing of the dialog until gconf is likely
3850 to return correct information, due to a maemo gconf bug that is fixed in
3851 osso 1.1, but not yet in Bora.
3852 However, the dialog stays on screen after it is destroyed.
3854 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3855 for invalid data when cancelling. Use a hildon note instead of a dialog
3856 to complain about invalid data. Do not show the account-saved note if the
3857 account is disabled (a temporary account that will not really be saved for use
3860 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3862 * src/modest-account-mgr-helpers.h:
3863 * src/modest-account-mgr-helpers.c:
3864 Added modest_account_mgr_unset_default_account(),
3865 Added modest_account_mgr_set_first_account_as_default().
3867 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3868 If it was the default account, unset the default account name.
3870 * src/maemo/modest-account-view-window.c:
3871 (on_delete_button_clicked): If it was the default account,
3872 set the first remaining account as the default instead.
3874 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3875 a NULL account or a NULL default account, to prevent a crash. This should
3876 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3879 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3881 * src/widgets/modest-recpt-editor.c:
3882 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3883 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3884 TODO comment for this. This fixes the build.
3886 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3887 be the best place for it. This will in future update all auto-update accounts,
3888 rather than just the current/default account, when that gconf key exists.
3889 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3890 if there are no accounts, before calling do_send_receive().
3891 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3893 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3894 * src/maemo/modest-main-window-ui.h:
3895 * src/maemo/modest-main-window.c: (on_connection_changed),
3896 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3897 directly, becaue the signal handler does more.
3899 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3901 * src/modest-account-mgr-helpers.c:
3902 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3903 for the case that the account does not exist.
3905 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3906 (equivalent to the modest account name) rather than the tinymail account name
3907 (equivalent to the modest account title - human readable) to get the account data.
3908 Check for null account data to prevent the crash, and add a TODO comment saying that
3909 this needs fixing because it is using the server account name instead of the account name.
3911 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3913 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3914 * src/maemo/modest-account-settings-dialog.c: (show_error),
3916 Use hildon_note_new_information() for informative and error messages,
3917 which seems to be expected for Maemo applications (no documentation that I know of
3918 says this). I am surprised that there is no distinction between info and error
3921 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3923 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3924 it is easy to find where this is used.
3926 * src/maemo/easysetup/modest-easysetup-wizard.c:
3927 (create_page_welcome), (create_page_account_details),
3928 (create_page_user_details), (create_page_complete_easysetup),
3929 (create_page_custom_incoming), (create_page_custom_outgoing),
3930 (create_page_complete_custom):
3931 * src/maemo/modest-account-settings-dialog.c:
3932 (create_page_account_details), (create_page_user_details),
3933 (create_page_incoming), (create_page_outgoing):
3934 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3935 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3936 (modest_connection_specific_smtp_edit_window_init):
3937 * src/maemo/modest-connection-specific-smtp-window.c:
3938 (modest_connection_specific_smtp_window_init):
3939 * src/maemo/modest-signature-editor-dialog.c:
3940 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3941 and scrolling policy as per the Email Application Layout Guide, if I have
3944 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3946 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3947 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3948 which were empty, because these vfuncs have been removed from TnyAccountStore.
3949 This fixes the build.
3951 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/modest-main-window.c:
3954 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3955 showing/hiding it. Added TODO because it probably should not be NULL.
3956 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3957 because unnecessary g_warnings() make degugging difficult.
3959 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3961 * src/maemo/modest-msg-edit-window.c:
3962 (modest_msg_edit_window_select_color),
3963 (modest_msg_edit_window_select_background_color): 2 const corrections and
3964 moving 2 #endifs before closing brackets, to fix the build.
3966 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3968 * src/maemo/easysetup/modest-easysetup-wizard.h:
3969 * src/maemo/easysetup/modest-easysetup-wizard.c:
3970 (modest_easysetup_wizard_dialog_finalize),
3971 (on_button_edit_advanced_settings), (create_page_complete_custom),
3972 (on_response), (create_account):
3973 Implement the Advanced Settings edit button, by saving the account information,
3974 for the Advanded Settings dialog to use directly from gconf, and removing it
3975 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3976 Bug #5533 in the projects.maemo.org bugzilla.
3978 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3980 * src/maemo/modest-msg-view-window.c:
3981 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3982 when opening a message window.
3984 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3986 * src/maemo/easysetup/modest-easysetup-wizard.c:
3987 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3990 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3991 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3992 gconf settings. I probably added more checks than necessary, but that is safer.
3994 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3995 variable to fix the build, but this seems to be used when it is still NULL.
3997 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3999 * src/modest-platform.h:
4000 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4001 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4002 * src/modest-main.c: Implement this function so we can avoid using
4003 maemo-specific API from cross-platform code.
4005 * src/modest-tny-account-store.c:
4006 (get_smtp_specific_transport_account_for_open_connection):
4007 * src/modest-ui-actions.c: (check_for_connection),
4008 (modest_ui_actions_on_item_not_found):
4009 Use modest_platform_connect_and_wait() and put #idefs around other
4010 maemo-specific code, because only maemo currently has a way to
4011 identify connection names.
4013 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4015 * src/modest-tny-account-store.h:
4016 * src/modest-tny-account-store.c:
4017 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4018 the connection-specific SMTP server settings in the configuration.
4020 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4022 * src/maemo/modest-main-window.c: (on_connection_changed),
4024 * src/modest-main.c: (main), (start_ui), (send_mail):
4025 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4026 that is what is intended.
4028 * src/modest-ui-actions.c: (action_send), (action_receive),
4029 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4030 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4031 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4032 SMTP server is used when it is specified.
4034 (modest_ui_actions_on_send_receive):
4035 Check that a connection is open before proceeding.
4036 Receive and then send, instead of vice-versa, as per the specification.
4038 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4040 * src/modest-mail-operation.c:
4041 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4042 though I guess it should be something other than NULL.
4044 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4046 * src/maemo/easysetup/modest-easysetup-wizard.c:
4047 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4048 combo twice, to avoid an g_warning and to make it visible again.
4049 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4050 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4051 (already intended) dereference when detaching, because we then recreate the menu.
4052 But I am not sure why the warning was happening, and it is possible that this is a memory
4055 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4057 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4058 and uri_parse_mailto() utility functions.
4059 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4061 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4063 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4065 * src/dbus_api/modest-dbus-api.h:
4066 * src/dbus_api/modest-dbus-callbacks.c:
4067 Use an idle callback to execute the modest code in the application's own thread.
4068 Remove the helloworld example method.
4069 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4070 parsed, and the open-message method is not implemented because this is not yet implemented in
4072 * libmodest-dbus-client/libmodest-dbus-client.c:
4073 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4074 (libmodest_dbus_client_open_message):
4075 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4077 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4078 body without crashing.
4080 * tests/dbus_api/Makefile.am:
4081 * tests/dbus_api/test_mail_to.c:
4082 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4084 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4086 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4087 Added file to fix the build. Sorry.
4089 * src/dbus_api/Makefile.am:
4090 * src/dbus_api/modest-dbus-api.h:
4091 * src/dbus_api/modest-dbus-callbacks.h:
4092 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4093 (modest_dbus_req_handler):
4094 Put constants in a separate header so it can be reused by the
4095 client library, without duplication
4097 * libmodest-dbus-client/Makefile.am:
4098 * libmodest-dbus-client/libmodest-dbus-client.c:
4099 (libmodest_dbus_client_call_helloworld),
4100 (libmodfest_dbus_client_send_mail),
4101 (libmodfest_dbus_client_mailto),
4102 (libmodfest_dbus_client_open_message):
4103 * libmodest-dbus-client/libmodest-dbus-client.h:
4104 (Partly) Implement a send_mail D-Bus method.
4106 * tests/dbus_api/Makefile.am:
4107 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4108 the send_email D-Bus method.
4110 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4114 * libmodest-dbus-client/Makefile.am:
4115 * libmodest-dbus-client/libmodest-dbus-client.c:
4116 * libmodest-dbus-client/libmodest-dbus-client.h:
4117 * tests/dbus_api/Makefile.am:
4118 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4119 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4121 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4123 * src/maemo/easysetup/modest-easysetup-wizard.c:
4124 (create_page_account_details):
4125 * src/maemo/modest-account-settings-dialog.c:
4126 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4127 widgets, because this might not be the default in future versions of the Maemo GTK+.
4128 However, I can not not get capitalization to work even in a simple test case.
4130 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4132 * src/maemo/easysetup/modest-easysetup-wizard.c:
4133 (create_page_custom_incoming), (create_page_custom_outgoing):
4134 * src/maemo/modest-account-settings-dialog.c:
4135 (create_page_account_details), (create_page_incoming),
4136 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4137 instead of using gtk_check_button_with_label(), so they are aligned like the other
4138 widgets, as per the UI spec.
4140 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4142 * src/maemo/easysetup/modest-easysetup-wizard.c:
4143 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4144 * src/widgets/modest-validating-entry.c:
4145 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4146 Modest prefix instead of an EasySetup prefix.
4148 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4150 * src/widgets/modest-validating-entry.h:
4151 * src/widgets/modest-validating-entry.c: (on_insert_text),
4152 Added easysetup_validating_entry_set_max_func(), used to set a callback
4153 to call when the max number of characters is reached. GtkEntry has a max-length
4154 already but is silent about it.
4156 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4157 (create_page_account_details), (create_page_user_details),
4159 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4160 (create_page_account_details), (create_page_user_details),
4161 (create_page_outgoing):
4162 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4163 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4164 the UI spec, when the user tries to enter more than the max number of characters.
4166 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4168 * src/maemo/easysetup/modest-easysetup-wizard.c:
4169 (create_page_user_details), (create_page_custom_incoming),
4170 (create_page_custom_outgoing):
4171 * src/maemo/modest-account-settings-dialog.c:
4172 (create_page_user_details), (create_page_incoming),
4173 (create_page_outgoing):
4174 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4175 (modest_connection_specific_smtp_edit_window_init):
4176 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4177 not appropriate. Bad Maemo-specific defaults!.
4179 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4181 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4182 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4183 (modest_signature_editor_dialog_set_settings):
4184 Disable the label and textview when the checkbox is disabled, and use the
4185 specified (UI spec) default signature text.
4187 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4190 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4192 * src/modest-defs.h:
4193 * src/modest-account-mgr-helpers.h:
4194 * src/modest-account-mgr-helpers.c:
4195 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4197 * src/maemo/Makefile.am:
4198 * src/maemo/modest-signature-editor-dialog.c:
4199 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4202 * src/maemo/modest-account-settings-dialog.h:
4203 * src/maemo/modest-account-settings-dialog.c:
4204 (modest_account_settings_dialog_finalize), (on_button_signature),
4205 (save_configuration): Use the new dialog when the Edit button is pressed, and
4206 save the changes if necessary, as per the UI spec.
4208 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4210 * src/maemo/Makefile.am:
4211 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4212 based on maemo-develoers email from Dirk.
4214 * src/maemo/easysetup/modest-easysetup-wizard.c:
4215 (create_page_welcome), (create_page_account_details),
4216 (create_page_user_details), (create_page_complete_easysetup),
4217 (create_page_custom_incoming), (create_page_custom_outgoing),
4218 (create_page_complete_custom),
4219 (modest_easysetup_wizard_dialog_init):
4220 * src/maemo/modest-account-settings-dialog.c:
4221 (create_page_account_details), (create_page_user_details),
4222 (create_page_incoming), (create_page_outgoing),
4223 (modest_account_settings_dialog_init):
4224 * src/maemo/modest-connection-specific-smtp-window.c:
4225 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4227 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4229 * src/maemo/easysetup/modest-easysetup-wizard.c:
4230 (create_page_account_details), (create_page_custom_outgoing),
4231 (create_page_complete_custom):
4232 * src/maemo/modest-account-settings-dialog.c:
4233 (create_page_user_details), (create_page_incoming),
4234 (create_page_outgoing):
4235 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4236 (modest_connection_specific_smtp_edit_window_init):
4237 Use the correct (UI spec) port min/max, and use horizontal separators,
4240 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4242 * src/maemo/easysetup/modest-easysetup-wizard.c:
4243 (set_default_custom_servernames):
4244 * src/maemo/modest-account-settings-dialog.c:
4245 (create_page_incoming), (on_combo_outgoing_security_changed),
4246 (on_combo_incoming_security_changed), (create_page_outgoing),
4247 (modest_account_settings_dialog_set_account_name),
4248 (save_configuration):
4249 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4250 (on_combo_security_changed),
4251 (modest_connection_specific_smtp_edit_window_init),
4252 (modest_connection_specific_smtp_edit_window_set_connection),
4253 (modest_connection_specific_smtp_edit_window_get_settings):
4254 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4257 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4260 * src/maemo/easysetup/modest-easysetup-wizard.c:
4261 (create_page_custom_outgoing), (create_page_complete_custom):
4262 * src/maemo/modest-account-settings-dialog.c:
4263 (create_page_user_details), (create_page_outgoing):
4264 * src/maemo/modest-account-view-window.c: (button_box_new):
4265 Use changed logical IDs as per the most recent UI spec:
4266 mcen_bd_emailsetup_edit -> mcen_bd_edit
4267 mcen_bd_emailsetup_delete -> mcen_bd_delete
4268 mcen_bd_emailsetup_close -> mcen_bd_close
4270 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4274 * src/dbus_api/Makefile.am:
4275 * src/dbus_api/modest-dbus-callbacks.c:
4276 * src/dbus_api/modest-dbus-callbacks.h:
4277 * src/maemo/modest-platform.c: (modest_platform_init):
4278 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4280 * tests/Makefile.am:
4281 * tests/dbus_api/Makefile.am:
4282 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4284 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4286 * src/maemo/modest-account-settings-dialog.c:
4287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4288 Removed unnecessary includes.
4290 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4292 * src/maemo/easysetup/modest-easysetup-wizard.c:
4293 * src/maemo/modest-account-settings-dialog.c:
4294 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4295 * src/widgets/Makefile.am:
4296 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4297 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4298 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4299 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4300 * src/widgets/modest-secureauth-combo-box.c:
4301 * src/widgets/modest-secureauth-combo-box.h:
4302 * src/widgets/modest-serversecurity-combo-box.c:
4303 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4304 made the GObject names more consistent with the rest of the Modest code.
4306 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4308 * src/maemo/easysetup/Makefile.am:
4309 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4310 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4311 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4312 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4313 * src/maemo/easysetup/modest-easysetup-wizard.c:
4314 * src/maemo/easysetup/modest-validating-entry.c:
4315 * src/maemo/easysetup/modest-validating-entry.h:
4316 * src/maemo/modest-account-settings-dialog.c:
4317 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4318 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4319 widgets/ because they are used outside of easysetup too. After checking in,
4320 svn will allow me to rename them too.
4322 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4324 * src/gnome/modest-msg-edit-window.c:
4325 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4326 linker error, to fix the build on the GNOME platform.
4327 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4328 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4329 ifdefed out to avoid a warning.
4331 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4333 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4334 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4335 some alternative for GTK+ 2.6.
4337 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4339 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4341 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4342 specified for EmailAccountsDialog in UI spec.
4344 * src/maemo/easysetup/modest-easysetup-wizard.c:
4345 * src/maemo/easysetup/modest-easysetup-wizard.h:
4346 * src/maemo/modest-account-settings-dialog.c:
4347 * src/maemo/modest-account-settings-dialog.h:
4348 Reuse a member window widget for the connection-specific SMTP server accounts,
4349 so we can tell it to create/save the accounts only if we actually save changes.
4351 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4353 (modest_connection_specific_smtp_edit_window_get_settings):
4354 Return a struct instance for temporarily remembering the entered data.
4356 * src/maemo/modest-connection-specific-smtp-window.h:
4357 * src/maemo/modest-connection-specific-smtp-window.c:
4358 (modest_connection_specific_smtp_window_finalize),
4359 (modest_connection_specific_smtp_window_fill_with_connections),
4361 (modest_connection_specific_smtp_window_save_server_accounts),
4362 (update_model_server_names): Do not actually save data until asked,
4363 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4365 (on_selection_changed),
4366 (modest_connection_specific_smtp_window_init): Disable the edit
4367 button when nothing is selected.
4369 * src/modest-account-mgr-helpers.c:
4370 * src/modest-account-mgr-helpers.h:
4371 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4374 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4376 * src/modest-account-mgr-helpers.h:
4377 * src/modest-account-mgr-helpers.c:
4378 (modest_account_mgr_get_unused_account_name),
4379 (modest_account_mgr_get_unused_account_display_name): Added these
4380 utility functions, to avoid code duplication.
4382 * src/maemo/easysetup/modest-easysetup-wizard.c:
4383 (create_page_account_details), (create_account):
4384 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4385 (on_combo_security_changed),
4386 (modest_connection_specific_smtp_edit_window_init),
4387 (modest_connection_specific_smtp_edit_window_save_settings):
4388 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4389 * src/maemo/modest-connection-specific-smtp-window.c:
4390 (modest_connection_specific_smtp_window_finalize),
4391 (modest_connection_specific_smtp_window_fill_with_connections),
4392 (on_button_edit), (modest_connection_specific_smtp_window_init):
4393 * src/maemo/modest-connection-specific-smtp-window.h:
4394 Implementing saving of connection-specific server accounts.
4396 But I need to refactor this so we can save the data for each
4397 possible connection-specific account and only actually create the server accounts
4398 when the easysetup finished, or the OK button is pressed on the account settings
4401 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4403 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4404 (on_combo_security_changed):
4405 (modest_connection_specific_smtp_edit_window_init):
4406 Auto-fill the port number as in the account settings.
4408 (modest_connection_specific_smtp_edit_window_set_connection):
4409 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4410 * src/maemo/modest-connection-specific-smtp-window.c:
4411 (fill_with_connections), (on_button_edit),
4412 (modest_connection_specific_smtp_window_init):
4413 Turn the edit window into a dialog to simplify the code, and
4414 set a WM hint as in a GtkDialog, because only a popup can be on top of
4415 another window in Maemo, and popups usually have no WM decoration.
4417 * src/modest-defs.h:
4418 * src/modest-account-mgr-helpers.c:
4419 (modest_account_mgr_set_connection_specific_smtp),
4420 (modest_account_mgr_remove_connection_specific_smtp),
4421 (modest_account_mgr_get_connection_specific_smtp):
4422 * src/modest-account-mgr-helpers.h: Some functions to write the
4423 connection-specific SMTP server information. Not yet used.
4426 * src/widgets/modest-folder-view.c: (text_cell_data):
4427 Fix a warning about an uninitialized variable.
4428 (on_configuration_key_changed): Put an #ifdef around the use
4429 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4431 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4433 * src/maemo/modest-account-settings-dialog.h:
4434 * src/maemo/modest-account-settings-dialog.c:
4435 Added connect_for_modified() utility function to mark the new modified boolean.
4437 (create_page_account_details), (create_page_user_details),
4438 (create_page_incoming), (create_page_outgoing), (on_response),
4439 (modest_account_settings_dialog_init),
4440 (modest_account_settings_dialog_set_account_name):
4441 Only warn about unsaved changes when there are actually unsaved changes.
4443 * src/modest-account-mgr-helpers.c:
4444 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4445 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4446 to get the data from there in future.
4448 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4450 * src/modest-defs.h:
4452 * src/modest-account-mgr-helpers.h:
4453 * src/modest-account-mgr-helpers.c:
4454 Store the security account setting in a single conf key instead of using
4455 the options list, so that the list is left for just the to-be-removed camel hack,
4456 and because gconf_client_set_list() is failing for some reason.
4458 * src/modest-account-mgr.c:
4459 (modest_account_mgr_add_server_account):
4460 * src/maemo/modest-account-settings-dialog.c:
4461 (modest_account_settings_dialog_set_account_name),
4462 (save_configuration): Use the renamed functions.
4465 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4467 * src/widgets/Makefile.am:
4468 * src/widgets/modest-limit-retrieve-combo-box.c:
4469 * src/widgets/modest-limit-retrieve-combo-box.h:
4470 * src/widgets/modest-retrieve-combo-box.c:
4471 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4472 the account settings dialog.
4474 * src/modest-defs.h:
4475 * src/modest-account-mgr-helpers.h:
4476 * src/modest-account-mgr-helpers.c:
4477 (modest_server_account_get_option_secure_auth),
4478 (modest_server_account_set_option_secure_auth):
4479 * src/modest-account-mgr.c:
4480 (modest_account_mgr_add_server_account):
4481 Use the existing AUTH_MECH conf key for the secure-auth setting,
4482 instead of putting it in the list options, because this was actually used already.
4484 * src/maemo/modest-account-settings-dialog.c:
4485 (create_page_account_details),
4486 (modest_account_settings_dialog_set_account_name),
4487 (save_configuration):
4488 * src/maemo/modest-account-settings-dialog.h:
4489 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4490 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4492 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4494 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4495 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4496 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4498 * src/modest-defs.h:
4499 * src/maemo/modest-account-settings-dialog.c:
4500 (create_page_incoming), (on_combo_outgoing_security_changed),
4501 (on_combo_incoming_security_changed), (create_page_outgoing),
4502 (modest_account_settings_dialog_set_account_name),
4503 (save_configuration): Load/Save the port number, and change it when the
4504 security combo changes, to suitable defaults.
4506 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4508 * src/modest-account-mgr.c:
4509 (modest_account_mgr_add_server_account): Set the security and secure-auth
4510 options, and add a comment saying that the other camel-specific options should be
4513 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4515 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4517 * src/modest-tny-account-store.c: (account_list_free),
4518 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4519 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4522 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4524 * src/modest-protocol-info.c:
4525 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4526 is required by our UI spec. Maybe something in our implementation will use this eventually.
4527 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4528 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4529 instead of the previous 0 placeholder.
4531 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4532 secure-auth settings.
4533 * src/modest-account-mgr-helpers.h:
4534 * src/modest-account-mgr-helpers.c:
4535 (modest_server_account_data_get_option_secure_auth),
4536 (modest_server_account_set_option_secure_auth),
4537 (modest_server_account_data_get_option_security),
4538 (modest_server_account_set_option_security): Added this API for getting and setting the security
4539 and secure-auth settings.
4541 * src/maemo/modest-account-settings-dialog.h:
4542 * src/maemo/modest-account-settings-dialog.c:
4543 (modest_account_settings_dialog_finalize), (check_data),
4544 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4545 about changing titles.
4546 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4547 (save_configuration): Save the security and secure-auth settings.
4549 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4550 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4552 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4554 * src/modest-defs.h:
4555 * src/modest-account-mgr.c:
4556 (modest_account_mgr_add_server_account):
4557 Added and used defines for the options key and value pair strings,
4558 that are used so far, though they do not seem to correspond to anything in our
4559 UI specs or ModestProtocol enum.
4561 * src/modest-account-mgr-helpers.h:
4562 * src/modest-account-mgr-helpers.c:
4563 (compare_option_strings_for_name),
4564 (modest_server_account_data_get_option_value),
4565 (modest_server_account_data_get_option_bool),
4566 (modest_account_mgr_get_server_account_option):
4567 Added helper functions for parsing the options GSList.
4569 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4571 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4572 display name is based on the supplied account name.
4573 * src/modest-account-mgr.c:
4574 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4575 with an inefficient, but good-enough, implementation.
4577 * src/maemo/easysetup/modest-easysetup-wizard.c:
4578 (create_page_account_details), (on_before_next), (create_account):
4579 Check for existing display names rather than (non-user-visible) account names, and just
4580 create and set a unique account name at the end.
4582 * src/maemo/modest-account-settings-dialog.c:
4583 (modest_account_settings_dialog_init),
4584 (modest_account_settings_dialog_set_account_name),
4585 (create_page_incoming): Show the display name, instead of the account name.
4586 (on_response): Do some (not all) extra checks, as in the UI spec.
4587 (save_configuration): Save the display name if it was changed.
4589 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4591 * po/en_GB.po: Added needed logical ID and translation.
4592 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4593 (init_view): Made the is-default column clicking work.
4595 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4598 * src/maemo/easysetup/Makefile.am:
4599 * src/maemo/easysetup/modest-easysetup-wizard.c:
4600 (modest_easysetup_wizard_dialog_init):
4601 * src/maemo/easysetup/provider-data-test.keyfile:
4602 * src/maemo/easysetup/provider-data.keyfile:
4603 Moved the provider data file to the new modest-providers-data package and used it from there.
4605 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4607 * src/modest-local-folder-info.c:
4608 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4609 N_() was already used on the static strings, but this just marks it for translation without
4610 using the translation.
4612 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4614 * src/maemo/modest-account-settings-dialog.c:
4615 (create_page_incoming),
4616 (modest_account_settings_dialog_set_account_name):
4617 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4618 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4619 I will do this if nobody else gets there first.
4621 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4623 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4624 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4625 save the security stuff.
4627 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4629 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4630 Set the email address and user fullname, which I now see must be
4633 * src/maemo/modest-account-settings-dialog.h:
4634 * src/maemo/modest-account-settings-dialog.c:
4636 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4637 leave-on-server and authentication.
4638 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4641 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4644 * src/maemo/modest-account-settings-dialog.c:
4645 * src/maemo/modest-account-settings-dialog.h:
4646 Most (but not all) of the widgets are now present as specified by the UI spec.
4647 No changes are yet saved, and some details are not properly shown yet.
4649 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4651 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4653 * src/maemo/Makefile.am:
4654 * src/maemo/modest-account-settings-dialog.c:
4655 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4656 an existing account. Doesn't do much yet.
4658 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4659 Open the accounts settings dialog when Edit is clicked.
4661 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4663 * src/maemo/easysetup/Makefile.am:
4664 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4666 * src/maemo/easysetup/modest-easysetup-wizard.c:
4667 (modest_easysetup_wizard_dialog_init):
4668 Try to get the source directory from the build system,
4669 instead of hard-coding "./" into the source code, when opening our local
4670 copies of the configuration files.
4671 But this still fails when opening the wizard from the Accounts window,
4672 maybe because the working directory seems to change at runtime.
4673 So the wizard will fail the second time unless you copy the files into their
4674 proper locations - see the stdout warnings for the paths.
4676 (create_page_account_details),(on_before_next):
4677 Check for existing non-server accounts instead of server accounts,
4678 so the default account name is useful again, and to prevent trying to
4681 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4682 Show the wizard when New is clicked.
4684 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4685 (init_view): Show the column headers, and show the columns that are
4686 specified in the UI specs. However, something in Maemo's GTK+ prevents
4687 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4688 change the default account. This is despite unsetting the special properties.
4690 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4692 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4693 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4694 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4695 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4696 to make that clearer.
4697 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4699 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4701 * src/maemo/modest-account-view-window.c:
4702 (modest_account_view_window_init),
4703 (modest_account_view_window_new):
4704 Use the same buttons as specified in the
4705 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4706 the existing widgets, which never had a chance of working.
4707 Put the ModestAccountView treeview in a scrolled window.
4708 Do not repeat the initialization in both _init() and _new().
4710 * src/widgets/modest-account-view.c: (update_account_view):
4711 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4712 this widget and window shows no accounts.
4714 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4716 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4718 * src/maemo/easysetup/modest-easysetup-wizard.c:
4719 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4720 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4721 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4724 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4725 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4726 accounts exist yet, as in the UI spec.
4728 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4730 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4732 * src/maemo/Makefile.am:
4733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4734 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4735 New window for editing connection-specific smtp details.
4736 Not fully implemented.
4738 * src/maemo/modest-connection-specific-smtp-window.c:
4739 (modest_connection_specific_smtp_window_finalize) :
4740 unref the tree model.
4741 (on_button_edit): Show the edit window.
4743 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4745 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4748 * src/maemo/Makefile.am:
4749 * src/maemo/modest-connection-specific-smtp-window.c:
4750 * src/maemo/modest-connection-specific-smtp-window.h:
4751 New window for showing the list of connections, for connection-specific
4752 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4753 * src/maemo/easysetup/modest-easysetup-wizard.c:
4754 (create_page_custom_outgoing): Show the new window when the button is clicked.
4756 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4758 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4759 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4760 * src/maemo/modest-msg-edit-window.c:
4761 (modest_msg_edit_window_insert_image):
4762 * src/modest-conf.c: (modest_conf_key_escape):
4763 * src/modest-mail-operation.c:
4764 (modest_mail_operation_send_new_mail):
4765 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4766 (modest_ui_actions_on_new_account):
4767 * src/widgets/modest-attachment-view.c: (update_filename_request):
4768 * src/widgets/modest-mail-header-view.c:
4769 Corrected warnings that were breaking the build, by commenting out unused variables,
4770 and a function, and by including a header.
4772 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4774 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4775 so we can #ifdef around platform-specific code when necessary.
4776 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4777 to allow this to build for the GNOME platform too.
4779 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4781 * src/maemo/easysetup/modest-easysetup-wizard.c:
4782 Added util_increment_name() and used it in create_page_account_details()
4783 to make sure that the default account name is always a new name.
4785 (modest_easysetup_wizard_dialog_init),
4786 (set_default_custom_servernames): Some minor memory management fixes.
4788 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4792 * src/modest-runtime.c: (init_i18n): Restored the translation
4793 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4794 are defined in config.h, and the translations are installed.
4796 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4797 is defined for translation.
4799 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4801 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4803 * src/maemo/easysetup/modest-easysetup-wizard.c:
4804 (modest_easysetup_wizard_dialog_init):
4805 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4806 Use realistic paths (though they should use $prefix generically) to the
4807 mcc_mapping and provider-data.keyfile files which might work when they
4808 are installed by the future version of the operator-wizard package,
4809 and then fallback to paths in our source code, with an explanatory
4812 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4816 * src/maemo/Makefile.am:
4817 * src/maemo/easysetup/: Added files from the previously-exernal
4818 osso-modest-easysetup.
4819 * src/maemo/modest-main-window-ui.h:
4820 * src/modest-ui-actions.c:
4821 * src/modest-ui-actions.h:
4822 Added modest_ui_actions_on_new_account() as a signal handler for the
4823 New Account menu item. It shows the easysetup wizard.
4824 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob