1 2007-07-04 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-connection-specific-smtp-window.c:
4 (modest_connection_specific_smtp_window_init):
5 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
6 does not seem to have any effect in osso 1.1 (though it works in
7 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
9 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
11 * src/maemo/modest-connection-specific-smtp-window.c:
12 Fix UI specification problems with projects.meamo.org NB#60479
14 2007-07-04 Murray Cumming <murrayc@murrayc.com>
16 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
17 clue when this has failed, because the error dialog is not always shown
18 (at least in earlier version).
20 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
21 GError message, because the generic error dialog is not helpful.
23 'This message is not currently available (can't let a new connection go online)'
24 when trying to open an IMAP message.
26 (_modest_ui_actions_open): Offer a connection when some messages would
27 have to be downloaded and we are offline.
29 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
31 * src/widgets/modest-folder-view.c:
32 Don't check for MERGE type anymore as we use the correct type
34 NOTE: For the last two changes you need to update your tinymail copy
35 because of API changes!
37 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
39 * src/modest-tny-local-folders-account.c:
40 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
41 (see projects.maemo.org NB#61580)
43 2007-07-04 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-tny-account.c: (on_connection_status_changed):
46 Commented out the call to modest_platform_connect_and_wait() because this
47 seems to always hang, and I would like to know if this is the only thing
48 that causes a hang when showing the connection dialog.
49 It is not very useful anyway.
51 2007-07-04 Murray Cumming <murrayc@murrayc.com>
53 * src/maemo/modest-msg-view-window.c:
54 (modest_msg_view_window_select_next_message):
56 * src/modest-platform.h:
57 * src/maemo/modest-platform.c:
58 Added modest_platform_connect_and_wait(), which calls
59 tny_maemo_conic_device_connect() always in the main thread, by calling it
60 in an idle handler and waiting for the idle handler to run. It should be
61 in the main thread because it uses GTK+ UI code. It just returns TRUE
62 if the device is already online.
64 There is some nasty code to ensure that subsequent calls to
65 modest_platform_connect_and_wait() just wait for the first one to finish,
66 by checking repeatedly in another idle handler. This is necessary,
67 because other threads (or even the main thread, via another idle handler)
68 can call modest_platform_connect_and_wait() while
69 modest_platform_connect_and_wait() is running.
71 (modest_platform_connect_and_wait_if_network_account),
72 (modest_platform_connect_and_wait_if_network_folderstore):
73 Convenience functions that calls modest_platform_connect_and_wait() if
74 the account or folder might want network access.
76 * src/modest-mail-operation.c:
77 (modest_mail_operation_update_account):
78 * src/modest-ui-actions.c: (download_uncached_messages),
79 (modest_ui_actions_on_rename_folder), (delete_folder),
80 (modest_ui_actions_on_main_window_move_to),
81 (modest_ui_actions_on_msg_view_window_move_to):
82 * src/widgets/modest-folder-view.c:
83 (drag_and_drop_from_folder_view):
84 Offer a connection if we are offline.
86 * src/modest-tny-account.c: (on_connection_status_changed):
87 Document this as only handling errors during network operations in progress,
88 and replace the idle code with a simple call to
89 modest_platform_connect_and_wait(), which does this instead.
91 2007-07-03 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-tny-account.c:
94 (modest_tny_account_get_special_folder): (util_on_idle),
95 Handle the GError so we can see when tny_folder_store_get_folders()
96 fails, as it currently does while something else is connecting.
98 Added util_run_in_main_thread_and_wait()
99 which uses an idlen handler and mainloop to ensure that the function
100 is called in the main thread.
101 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
102 to make sure that we call attempt the connection in the mainloop only,
103 which might solve some hangs.
105 2007-07-03 Murray Cumming <murrayc@murrayc.com>
107 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
108 be found by their display name. This is never useful.
109 * src/modest-tny-account-store.c: (on_account_removed): Find the account
110 by its ID, instead of trying to use its ID as its display name.
112 * src/modest-tny-account-store.h:
113 * src/modest-tny-account.c:
114 (modest_tny_account_get_special_folder): Add a g_warning() when
115 tny_folder_store_get_folders() returns an empty list for the maildir.
117 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
118 Add a g_warning() when this returns NULL, because that it not allowed
121 2007-07-02 Armin Burgmeier <armin@openismus.com>
123 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
124 note when trying to cancel the wizard. This fixes projects.maemo.org
127 2007-07-02 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-tny-account.h:
130 * src/modest-tny-account.c:
131 (modest_tny_account_new_from_server_account),
132 (modest_tny_account_new_from_server_account_name),
133 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
134 because this must now be set before setting the proto. This is usd in
135 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
136 warning in camel_session_get_service() caused by
137 tny_camel_transport_account_prepare().
139 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
142 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
144 * src/maemo/modest-connection-specific-smtp-edit-window.c:
146 (modest_connection_specific_smtp_edit_window_init):
148 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
151 2007-06-29 Murray Cumming <murrayc@murrayc.com>
153 * src/modest-tny-account.c:
154 (modest_tny_account_new_from_server_account):
155 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
156 now uses to request a connection when it needs one, and which it uses
157 to tell us that something is wrong with the connection, so we can force
158 the accounts offline to prevent further problems.
161 * src/modest-init.c: (init_default_settings):
162 * src/modest-mail-operation.c:
163 (modest_mail_operation_update_account):
164 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
165 This should not be necessary anymore. Do not set the conf key that
166 determined this (it was always TRUE and not set anywhere else).
168 * src/modest-ui-actions.h: Remove unused and unimplemented
169 modest_ui_actions_on_online_toggle_toggled().
171 2007-06-29 Murray Cumming <murrayc@murrayc.com
173 * src/maemo/modest-main-window.c: (connect_signals):
174 Don't connect to delete_event twice. Maybe this was harmless.
176 2007-06-29 Murray Cumming <murrayc@murrayc.com
178 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
179 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
180 Debug output to give some more clue when a folder move is not allowed.
182 2007-06-28 Murray Cumming <murrayc@murrayc.com
184 * src/modest-tny-account.c: (on_modest_file_system_info),
185 (modest_tny_account_get_mmc_account_name):
186 Always call the callback, without checking whether the name has changed.
187 * src/widgets/modest-folder-view.c: (strings_are_equal),
188 (on_model_foreach_set_name), (on_get_mmc_account_name),
189 (text_cell_data): Compare the name here, and use the name from
190 the account rather than from the
191 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
192 if the name was changed after the account was added to the model.
193 That's a tinymail bug but not one that I want to fix now.
195 This finally fixes projects.maemo.org bug NB#59301.
197 2007-06-27 Armin Burgmeier <armin@openismus.com>
199 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
202 2007-06-27 Murray Cumming <murrayc@murrayc.com
204 * src/modest-tny-account.h:
205 * src/modest-tny-account.c:
206 Added modest_tny_account_get_mmc_account_name(), to set the memory
207 card name asynchronously for the given account and then notify.
208 (modest_tny_account_new_for_local_folders): Use this new function instead
209 of using hildon_file_system_info_async_new() directly.
211 * src/widgets/modest-folder-view.c: (text_cell_data):
212 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
213 gtk_tree_model_row_changed() when it is available.
215 This should fix projects.maemo.org bug NB#59301.
217 2007-06-27 Murray Cumming <murrayc@murrayc.com
219 * src/modest-mail-operation.c: (update_account_thread),
220 (get_msgs_full_thread): Fix typo failures in the revert
223 2007-06-27 Murray Cumming <murrayc@murrayc.com
225 * src/maemo/modest-maemo-global-settings-dialog.c:
226 (idle_select_default_focus):
227 * src/modest-mail-operation.c: (idle_notify_progress),
228 (idle_notify_progress_once), (set_last_updated_idle),
229 (update_account_thread), (get_msgs_full_thread):
230 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
231 * src/widgets/modest-header-view.c:
232 (idle_notify_headers_count_changed_destroy),
233 (idle_notify_headers_count_changed):
234 Reverted the additions of gdk_threads_enter/leave(), in case this
235 helps with a startup hang on the device.
237 2007-06-26 Armin Burgmeier <armin@openismus.com>
239 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
240 for supported secure authentication methods from server by
241 gtk_dialog_run(), saving CPU time and a potential race condition.
243 2007-06-26 Armin Burgmeier <armin@openismus.com>
245 * src/maemo/modest-maemo-utils.h:
246 * src/maemo/modest-maemo-utils.c: Added a
247 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
248 only error code to tell the calling code when the user canceled the
251 * src/maemo/modest-account-settings-dialog.h:
252 * src/maemo/modest-account-settings-dialog.c:
253 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
254 message if the retrieval of secure authentication methods was canceled
255 by the user. Perform the check before saving anything to configuration
256 to not end up with half-committed configuration changes, do not show
257 a "Saving to configuration failed" note when authentication methods
258 could not be retrieved.
260 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
263 2007-06-26 Murray Cumming <murrayc@murrayc.com>
265 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
266 Only return the first level of folders under accounts, because the
267 osso-global-search UI spec doesn't want the rest.
268 This fixed projects.maemo.org bug NB#61811.
270 2007-06-26 Murray Cumming <murrayc@murrayc.com>
272 * src/modest-tny-account-store.c:
273 * src/modest-tny-account-store.h:
274 Added modest_tny_account_is_memory_card_account().
275 * src/maemo/modest-main-window.c: (create_details_widget):
276 Show the same information items for the memory card as we show for the
277 local-folders, to fix projects.maemo.org bug NB#59307.
279 2007-06-26 Murray Cumming <murrayc@murrayc.com>
281 * src/modest-tny-account-store.c: (get_password):
282 Added some checks for NULL to maybe prevent crashes, though I think
283 it was Philip's last commit that actually prevented the crash here
284 when creating a first new account.
285 But the new account is still not usable (no messages are shown)
286 until a restart of the application.
288 2007-06-26 Murray Cumming <murrayc@murrayc.com>
290 * src/maemo/modest-maemo-global-settings-dialog.c:
291 (idle_select_default_focus):
292 * src/modest-mail-operation.c: (idle_notify_progress),
293 (idle_notify_progress_once), (idle_notify_update_account_queue),
294 (set_last_updated_idle), (update_account_thread),
295 (notify_get_msgs_full), (get_msgs_full_destroyer),
296 (get_msgs_full_thread):
297 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
298 * src/widgets/modest-header-view.c:
299 (idle_notify_headers_count_changed_destroy),
300 (idle_notify_headers_count_changed):
301 Use gdk_threads_enter() and gdk_threads_enter_leave() in
302 all idle handlers, because some other thread could be blocking
303 the GDK lock, so that it can do GUI stuff.
305 2007-06-26 Murray Cumming <murrayc@murrayc.com>
307 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
308 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
309 (on_idle_send_receive), (on_idle_open_default_inbox):
310 * src/maemo/modest-msg-edit-window.c:
311 (modest_msg_edit_window_attach_file_noninteractive):
312 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
313 to prevent a hang. I don't quite understand why these are necessary,
314 beause we should already be in the main loop. I guess something outside
315 of the main loop is taking the lock.
317 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
318 we are really using URIs, and use files that are more likely to exist.
320 2007-06-26 Murray Cumming <murrayc@murrayc.com>
322 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
323 necessary because configure.ac now defines different variables.
325 2007-06-26 Murray Cumming <murrayc@murrayc.com>
327 * libmodest-dbus-client/libmodest-dbus-client.c:
328 * libmodest-dbus-client/libmodest-dbus-client.h:
329 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
330 libmodest_dbus_client_compose_mail() is what things actually use.
332 * src/dbus_api/modest-dbus-api.h:
333 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
334 * tests/dbus_api/Makefile.am:
335 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
338 2007-06-26 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-init.c: (modest_init_local_folders):
341 For memory-card (or other non local-folders) maildir accounts,
342 always create an Archive folder, so that there is somewhere to put
343 messages. This should be less confusing, because the user does not need
344 to guess that the need to create a folder.
346 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
348 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
349 Fixed icon size by using (50, 50) which is the same as defined by
352 2007-06-25 Armin Burgmeier <armin@openismus.com>
354 * src/widgets/modest-window-mgr.c:
356 * configure.ac: Correctly recognize hildon-notify presence and fixed
357 the build without it being installed.
359 2007-06-25 Murray Cumming <murrayc@murrayc.com>
361 * libmodest-dbus-client/libmodest-dbus-client.c:
362 (libmodest_dbus_client_search): Fix the build. Sorry.
363 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
364 (reply_forward_cb): Initialize variables to fix the build.
366 * src/modest-tny-account-store.c:
367 (modest_tny_account_store_get_tny_account_by): Fix the account URI
368 comparison (a silly typo) so that email search results can be opened
369 when there are more than one account.
371 2007-06-25 Murray Cumming <murrayc@murrayc.com>
373 * libmodest-dbus-client/libmodest-dbus-client.c:
374 (libmodest_dbus_client_search),
375 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
376 instead of 1 second, because the search gets folders and messages from
377 the server, which can take a long time. When it times out,
378 osso-global-search will report no results.
380 We need to specify whether we should search only cached information
381 (maybe with a user preference), and the osso-email-search-plugin
382 API should really be improved to allow that option, and to allow results
383 to be delivered asynchronously in batches.
385 2007-06-25 Murray Cumming <murrayc@murrayc.com>
387 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
388 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
389 GTK_ICON_SIZE_DIALOG is probably the wrong size.
391 2007-06-25 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
394 that is an empty string. D-Bus seems to give us these instead of NULL.
396 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
398 * src/dbus_api/modest-dbus-callbacks.c:
399 * src/maemo/easysetup/modest-easysetup-wizard.h:
400 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
401 * src/maemo/modest-connection-specific-smtp-edit-window.c:
402 (modest_connection_specific_smtp_edit_window_init):
403 * src/maemo/modest-maemo-global-settings-dialog.c:
405 * src/maemo/modest-maemo-utils.c:
406 (modest_maemo_utils_setup_images_filechooser):
407 * src/maemo/modest-main-window.c: (create_details_widget):
408 * src/maemo/modest-msg-edit-window.c:
409 (modest_msg_edit_window_attach_file_noninteractive),
410 (modest_msg_edit_window_color_button_change),
411 (modest_msg_edit_window_set_zoom):
412 * src/modest-mail-operation.c: (update_account_thread):
413 * src/modest-tny-account-store.c:
414 * src/modest-tny-account.c:
415 * src/widgets/modest-global-settings-dialog.c:
416 * src/widgets/modest-window.h:
420 2007-06-25 Murray Cumming <murrayc@murrayc.com>
422 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
423 * src/modest-search.c: (modest_search_folder),
424 (modest_search_all_accounts): Actually search only in the specified folder,
425 doing a simple match on the folder ID.
426 * src/modest-search.h: Added a folder field to the ModestSearch struct,
427 and added some documentation.
429 2007-06-22 Armin Burgmeier <armin@openismus.com>
431 * src/maemo/modest-maemo-utils.h:
432 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
433 modest_maemo_utils_get_supported_secure_authentication_methods.
435 * src/maemo/easysetup/modest-easysetup-wizard.c:
436 * src/maemo/modest-account-settings-dialog.c: Show correct error if
437 one occured, not just "Server does not support secure authentication".
439 2007-06-22 Murray Cumming <murrayc@murrayc.com>
441 * src/modest-tny-account-store.c: (get_password):
442 Restored the call to tny_account_set_user() because Philip seems to have
443 stopped this from crashing (by not using the freed string). It still does
444 not work, but now we can test it.
446 2007-06-22 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-msg-edit-window.c: (init_window):
449 Comment out use of an uninitialzed GtkScrolledWindow variable,
450 to fix the build and stop a crash. Yet again.
452 2007-06-22 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-tny-account-store.c: (get_password):
455 Remove the call to tny_account_set_user() because this actually crashes.
456 As mentioned in the last commit, it is known to not work anyway.
458 2007-06-22 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c: (get_password):
461 Use tny_account_set_username() to tell tinymail that the username might
462 have changed too. But tinymail ignores this: see projects.maemo.org
464 * src/modest-ui-actions.c:
465 (modest_ui_actions_on_password_requested): Remove the useless attempt to
466 reset the connection when changing the username, and improve the comments.
467 Save the changed username to gconf at least, so it is used when Modest is
470 2007-06-21 Murray Cumming <murrayc@murrayc.com>
472 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
473 Do not use a query, so that we get all folders, including for POP and
474 local-folders. They work as search criteria too.
475 This fixes projects.maemo.org bug NB#57740.
477 2007-06-21 Murray Cumming <murrayc@murrayc.com>
479 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
480 Comment out the use of hildon_notification_set_sound() because it is
481 not declared, to fix the build. Warnings are serious, people.
483 2007-06-21 Armin Burgmeier <armin@openismus.com>
485 * src/maemo/modest-maemo-utils.h:
486 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
487 modest_maemo_utils_get_supported_secure_authentication_methods()
488 to query authentication methods for a specific user. This should fix
489 projects.maemo.org bug NB#61369.
491 * src/maemo/easysetup/modest-easysetup-wizard.c:
492 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
495 2007-06-21 Murray Cumming <murrayc@murrayc.com>
497 * libmodest-dbus-client/libmodest-dbus-client.h:
498 * libmodest-dbus-client/libmodest-dbus-client.c:
499 (modest_dbus_message_iter_get_search_hit),
500 (libmodest_dbus_client_search):
501 Reorganised and commented this.
502 Removed modest_search_hit_free() from the public API because it
505 Added libmodest_dbus_client_get_folders() and
506 modest_folder_result_list_free().
508 * src/dbus_api/modest-dbus-api.h:
509 * src/dbus_api/modest-dbus-callbacks.c:
510 (modest_dbus_req_filter): Commented. Moved most code to
511 on_dbus_method_search() and added on_dbus_method_get_folders().
513 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
514 of the extra D-Bus handler.
516 * tests/dbus_api/Makefile.am:
517 * tests/dbus_api/test_get_folders.c: New test for
518 libmodest_dbus_client_get_folders(). This seems to return an empty list
519 at the moment. That could be the same error that causes the message list
520 to be empty sometimes.
521 This should help with projects.maemo.org bug NB#57740.
523 2007-06-21 Armin Burgmeier <armin@openismus.com>
525 * src/modest-mail-operation.c: Do not call
526 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
527 notify the operation's end after having set the status to CANCELED for
528 the operation queue to listen on. This fixes a deadlock when there
529 were mail operations in the queue during its finalization.
531 * src/modest-singletons.c: Reordered uninitialization of the account
532 manager to happen after the mail operation queue was uninitialized
533 because the mail operation's in the queue might still try to access
534 the account manager (see modest_mail_operation_notify_end()). This
535 fixes a potential crash when terminating the application.
537 2007-06-21 Murray Cumming <murrayc@murrayc.com>
539 * src/modest-search.c:
540 (search_mime_part_and_child_parts): Moved some code here so we
541 can search recursively in child folders.
542 (modest_search_folder): Search in the message as a mime part, instead
543 of just its child mime parts.
544 (read_chunk), (search_mime_part_ogs):
545 Check how many bytes were read, to prevent an endless loop.
546 Searching in message bodies now works. This finishes the fix for
547 projects.maemo.org bug NB#61007.
549 2007-06-20 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
552 Add a g_warning when the item is not a folder.
554 * src/modest-ui-dimming-rules.c:
555 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
556 when selected item is not a folder (for instance, an account), because
557 the UI spec only talks about folders.
558 I am not sure what the UI spec wants, so this might not totally fix
559 projects.maemo.org bug NB#60794.
561 2007-06-20 Murray Cumming <murrayc@murrayc.com>
563 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
564 (load_from_file): Sort the list. The unsorted list would be more noticeable
565 in non-English locales.
567 * src/maemo/modest-msg-edit-window.c:
568 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
569 warning and fix the build.
571 * src/maemo/modest-progress-bar-widget.c:
572 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
573 avoid a g_warning, and probably to avoid a crash.
575 2007-06-20 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-search.c: (modest_search_folder): Check for a GError
578 when calling tny_folder_get_headers(), to show that this is not the cause
581 2007-06-20 Murray Cumming <murrayc@murrayc.com>
583 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
584 Actually set the body query instead of the subject query.
586 * src/modest-search.c: (search_mime_part_ogs),
587 (search_mime_part_strcmp): Remove extra space from the text/* regex,
588 which would probably cause it to fail if we got this far.
590 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
591 to simplify the code.
592 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
593 be causing search-in-body to fail.
595 2007-06-20 Murray Cumming <murrayc@murrayc.com>
597 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
599 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
600 Better debug message when the folder cannot be found.
601 This should help with fixing projects.maemo.org bug #61287.
602 * src/modest-search.c: (add_hit): Do not leak the furl string.
604 2007-06-20 Murray Cumming <murrayc@murrayc.com>
606 * src/modest-ui-actions.c:
607 (modest_ui_actions_on_folder_selection_changed):
608 Do not special-case TNY_MERGE_FOLDER here, because
609 modest_tny_folder_get_account() already does that. This fixes
610 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
611 shown when the Outbox was selected).
613 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
615 * libmodest-dbus-client/libmodest-dbus-client.c:
616 (_dbus_iter_get_string_or_null): Initialize the string variable in
617 case this helps with Dirk's crash.
619 2007-06-19 Murray Cumming <murrayc@murrayc.com>
621 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
622 though it is not implemented yet (this function is maybe not even used),
623 to avoid breaking ABI in future.
624 * libmodest-dbus-client/libmodest-dbus-client.c:
625 (get_attachments_string): Moved some code into this generic function.
626 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
627 sends email. It is maybe not used.
628 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
629 (on_send_mail): Use attachments.
631 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
632 * src/maemo/modest-msg-edit-window.c:
633 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
634 a filename before using it, to fix projects.maemo.org bug NB#58233.
636 2007-06-19 Murray Cumming <murrayc@murrayc.com>
638 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
639 Initialize the continue_download variable to fix the build, and probably
640 to fix randome behaviour.
642 2007-06-18 Armin Burgmeier <armin@openismus.com>
644 * src/modest-tny-send-queue.h:
645 * src/modest-tny-send-queue.c: Keep track of the status of messages in
646 the queue so we can later show it in the UI. Replaced
647 modest_tny_send_queue_msg_is_being_sent() by
648 modest_tny_send_queue_get_msg_status().
650 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
652 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
653 gpointer. This probably was not harmful, but just to be sure.
655 2007-06-18 Murray Cumming <murrayc@murrayc.com>
657 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
658 Fix the build, but leave the function broken on Bora, because
659 hildon_uri_action_get_service() does not exist.
660 osso_uri_action_get_service() does not exist either, it seems.
662 2007-06-18 Murray Cumming <murrayc@murrayc.com>
664 * src/modest-tny-account.c:
665 (modest_tny_account_new_from_server_account):
666 Uncommented the url debug output again, because it is useful for
667 debugging, as I said in the comment.
669 2007-06-18 Murray Cumming <murrayc@murrayc.com>
671 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
673 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
674 for Mameo Bora, to fix the build.
676 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
679 Fixed build with hildon < 0.99
681 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
682 Check if the selected account is busy instead of checking all accounts
684 * src/modest-account-mgr-priv.h:
685 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
686 (modest_account_mgr_init), (compare_account_name),
687 (modest_account_mgr_set_account_busy),
688 (modest_account_mgr_account_is_busy):
689 * src/modest-account-mgr.h:
690 Added busy information to the account manager. It possible to
691 set an account to busy or not busy now.
693 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
694 (modest_mail_operation_update_account),
695 (modest_mail_operation_notify_end):
696 Set the account to busy/not busy depending on the operation state.
698 * src/widgets/modest-account-view.c:
699 (modest_account_view_finalize), (get_last_updated_string),
700 (update_account_view), (on_account_busy_changed), (init_view):
701 Show string "Refreshing..." if the account is currently busy.
703 All this fixes projects.maemo.org bug NB#59711
705 2007-06-14 Armin Burgmeier <armin@openismus.com>
707 * src/widgets/modest-attachments-view.h:
708 * src/widgets/modest-attachments-view.c: Added
709 modest_attachments_view_has_attachments() and fixed coordinate
710 transformation in get_att_view_at_coords(). This fixes attachment
713 * src/widgets/modest-msg-view.c: Make use of
714 modest_attachments_view_has_attachments() to decide whether to show
715 attachments in the header.
717 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
719 * src/maemo/modest-connection-specific-smtp-edit-window.c:
720 (on_change), (on_combo_security_changed),
721 (modest_connection_specific_smtp_edit_window_init),
722 (modest_connection_specific_smtp_edit_window_set_connection),
723 (modest_connection_specific_smtp_edit_window_is_dirty):
724 * src/maemo/modest-connection-specific-smtp-edit-window.h:
725 * src/maemo/modest-connection-specific-smtp-window.c:
728 Show an comfirmation dialog for the smpt-edit-window if there are
729 unsaved changes and the user hits cancel.
730 (projects.maemo.org bug NB#60479)
732 2007-06-14 Armin Burgmeier <armin@openismus.com>
734 * src/maemo/easysetup/modest-easysetup-wizard.c:
735 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
736 address" info in banner instead of node, and select all the text as
737 per UI spec. This fixes projects.maemo.org bug NB#60550.
739 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
741 reviewed by: <delete if not using a buddy>
743 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
744 * src/modest-ui-actions.c: (folder_refreshed_cb):
746 2007-06-14 Murray Cumming <murrayc@murrayc.com>
748 * src/widgets/modest-folder-view.c: (filter_row):
749 Explictly filter out the per-account outbox accounts. I don't know why
750 these only sometimes show up, but now they should never show up in the UI.
751 This should fix projects.maemo.org bug NB#60160.
753 2007-06-14 Murray Cumming <murrayc@murrayc.com>
755 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
756 when the toolbar does not exist yet.
757 * src/modest-widget-memory.c: (save_settings_header_view):
758 Added g_warnings() to help us to discover when we are trying to set
759 an empty columns list in gconf.
761 2007-06-14 Murray Cumming <murrayc@murrayc.com>
765 Added modest_init_get_default_header_view_column_ids().
767 * src/modest-widget-memory.c: (restore_settings_header_view):
768 Use the new function to get defaults, if the gconf key is empty,
769 instead of not creating any columns. This seems to fix the
770 empty right-hand pane problems.
772 * src/widgets/modest-header-view.h: Improved documentation.
774 2007-06-13 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
777 Revert the use of the display name as the account name, because this
778 is generally wrong and would break the code that follows.
780 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
782 * src/maemo/easysetup/modest-easysetup-wizard.c:
783 (check_for_supported_auth_methods), (on_before_next),
786 More correct fix for projects.maemo.org bug NB# 58991
787 Do not longer accept AUTH_PASSWORD as secure method and choose
788 correct method when creating the account.
790 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
792 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
793 Fixed projects.maemo.org bug NB# 58991
795 2007-06-13 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-init.c: (modest_init_init_core),
798 (modest_init_local_folders): Fixed compilation errors.
800 2007-06-13 Murray Cumming <murrayc@murrayc.com>
802 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
803 Remove unnecessary lib/include, though it is good in principle when needed.
805 * src/modest-init.c: (modest_init_one_local_folder),
806 (modest_init_local_folders):
807 * src/modest-init.h: Initialize the .modest library for memory cards,
808 instead of just doing nothing for them. This should allow us to create
809 folders there, fixing projects.maemo.org bug NB#59297.
811 2007-06-13 Murray Cumming <murrayc@murrayc.com>
813 * libmodest-dbus-client/libmodest-dbus-client.c:
814 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
815 (libmodest_dbus_client_compose_mail),
816 (libmodest_dbus_client_open_message),
817 (libmodest_dbus_client_send_and_receive),
818 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
820 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
821 (on_idle_open_message), (modest_dbus_req_handler),
822 (search_result_to_message), (modest_dbus_req_filter):
823 * src/modest-search.c: (add_hit), (modest_search_folder),
824 (modest_search_all_accounts): Improved debug messages.
826 * tests/dbus_api/test_open_message.c: (main): Improved comments.
828 * src/modest-tny-account-store.c:
829 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
832 2007-06-13 Murray Cumming <murrayc@murrayc.com>
835 2007-06-12 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-tny-account-store.c: (get_server_accounts):
838 Call modest_tny_local_folders_account_add_merged_outbox_folders()
839 even when there are no accounts, so that the Outbox folder is always
840 visible. This fixes projects.maemo.org bug NB#60158.
842 2007-06-12 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/modest-main-window.c: (create_details_widget):
845 Use the mcen_va_never logical ID.
847 2007-06-12 Murray Cumming <murrayc@murrayc.com>
849 * src/dbus_api/modest-dbus-api.h:
850 * src/dbus_api/modest-dbus-callbacks.c:
851 (on_idle_open_default_inbox), (on_open_default_inbox),
852 (modest_dbus_req_handler):
853 Added a new OpenDefaultInbox method.
855 * libmodest-dbus-client/libmodest-dbus-client.h:
856 * libmodest-dbus-client/libmodest-dbus-client.c:
857 Added libmodest_dbus_client_open_default_inbox() to call the new
858 dbus method. This should be useful to projects.maemo.org bug NB#57214,
859 though it should maybe be used by a new osso-email-interface function.
861 * tests/dbus_api/Makefile.am:
862 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
865 2007-06-12 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
868 NULL, so that the signals get all the keys. This should not actually
869 change any behaviour because we currently update everything when anything
872 2007-06-12 Murray Cumming <murrayc@murrayc.com>
874 * src/widgets/modest-folder-view.c: (text_cell_data),
875 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
876 (find_inbox_iter): If tinymail tells us that the folder is
877 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
878 This causes the inbox to be selected at startup, fixing part of
879 projects.maemo.org bug NB#56305.
881 * src/modest-ui-dimming-rules.c:
882 (modest_ui_dimming_rules_on_tools_smtp_servers):
883 * src/modest-ui-dimming-rules.h: Added a callback function to dim
884 the SMTP servers menu item.
885 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
886 that the SMTP Servers menu item is dimmed when there are no accounts,
887 as a future version of the UI spec will require. This fixes
888 projects.maemo.org bug NB#56305.
890 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
892 * src/maemo/modest-maemo-utils.c:
893 (modest_maemo_utils_get_supported_secure_authentication_methods):
894 Added label to dialog instead of unreadable title
896 * src/maemo/modest-main-window.c: (sync_accounts_cb),
897 (modest_main_window_new):
898 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
901 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
902 * src/modest-account-mgr.h:
903 Added method to avoid code duplication
905 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
906 (modest_ui_actions_on_send_receive):
907 Use modest_account_mgr_has_accounts
909 2007-06-11 Murray Cumming <murrayc@murrayc.com>
911 * src/maemo/easysetup/modest-presets.c:
912 (modest_presets_get_info_server_security): Do not report secure auth
914 * src/modest-protocol-info.c: Use the defines for the gconf key names
915 for secure authentication. This was not working because we were writing
916 Password and reading password, and the check was case sensitive.
917 With this, gmail now works for receiving and sending when created via
920 2007-06-11 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/easysetup/modest-presets.c:
923 (modest_presets_get_info_server_security): Correct the key name for
924 SecureSmtp, because it seems to be case-sensitive.
925 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
926 Do not try to get the 0th notebook page if there are 0 pages, to
929 2007-06-11 Murray Cumming <murrayc@murrayc.com>
931 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
932 Prevent use of the new notification feature for now, because it currently
933 shows one dialog for each new email, which is annoying.
935 2007-06-11 Murray Cumming <murrayc@murrayc.com>
937 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
938 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
939 when no country was selected, so that we show the global ones.
940 * src/maemo/easysetup/modest-presets.c:
941 (modest_presets_get_providers): Return only the global providers, not
942 all providers when mmc=0 was requested.
944 2007-06-11 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
947 (easysetup_provider_combo_box_fill): Remove debug code that showed the
948 provider ID in the combo.
950 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
951 Do not show the page numbers, because it would be confusing when we add
952 the 2 extra pages for the custom setup, when the user chooses the "Other"
953 provider. This fixes projects.maemo.org bug NB#59028
955 * src/modest-init.c: (modest_init_init_core),
956 (modest_init_local_folders):
958 * src/modest-tny-account.c:
959 (modest_tny_account_new_for_local_folders): Do not create default folders
960 for the memory card. This should fix projects.maemo.org bug NB#59328.
962 2007-06-11 Murray Cumming <murrayc@murrayc.com>
964 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
965 Free the changed_conf_keys string items. They are already freed in the
966 idle handler if that runs first.
968 2007-06-11 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-ui-actions.c:
971 (modest_ui_actions_on_password_requested): Check that the server name
972 is not NULL, because I just saw a password dialog with (null) as the
975 * src/modest-tny-folder.[h|c]: Added
976 modest_tny_folder_is_memory_card_folder().
977 * src/modest-ui-dimming-rules.c:
978 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
979 menu item for memory cards, as per the UI spec (section 7.4). This should
980 fix projects.maemo.org bug NB#59297.
982 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
984 * src/maemo/modest-main-window.c: (sync_accounts_cb):
985 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
986 is another problem with the code, see Murray's comment at line 772)
988 2007-06-08 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
991 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
992 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
993 (load_from_file), (easysetup_country_combo_box_init),
994 (easysetup_country_combo_box_get_active_country_ids),
995 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
996 instead of just one ID, to avoid duplicate country names in the UI.
998 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
999 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1000 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1001 a single ID, avoiding duplicate providers.
1002 * src/maemo/easysetup/modest-easysetup-wizard.c:
1003 (on_combo_account_country): Adapt to use a list.
1005 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1008 keys changed in the last X seconds.
1010 * src/modest-account-mgr.h:
1011 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1012 (on_key_change), (modest_account_mgr_class_init),
1013 (modest_account_mgr_init), (modest_account_mgr_finalize):
1014 As the keys are changed, save them in a GSList* and signal that GSList*
1015 further every X seconds, to batch changes, to allow us to do just one
1016 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1017 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1019 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1020 changed signal signature.
1022 * src/modest-conf.c: (modest_conf_set_list),
1023 (modest_conf_on_change): Reenable notification.
1025 (modest_conf_maemo_fake_on_change): Comment out the hack that
1026 notified immediately instead of asynchronously.
1028 * src/widgets/modest-account-view.h:
1029 * src/widgets/modest-account-view.c:
1030 (update_account_view): Select the previously-selected account ID,
1031 if possible. This fixes projects.maemo.org bug NB#56933.
1033 (on_account_changed), (on_account_removed),
1034 (modest_account_view_select_account):
1036 Remove the block/unblock functions
1037 because they were not useful.
1039 * src/maemo/modest-account-view-window.c:
1040 (on_delete_button_clicked), (on_edit_button_clicked),
1041 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1043 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1046 Improve the error dialog to show Incorrect Account Settings, which seems
1047 clearer, and say that the internal error message (to be removed from the
1048 dialog later) is often misleading.
1049 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1051 * src/modest-tny-account.c:
1052 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1053 URL because this is so useful for debugging on the device.
1055 * src/widgets/modest-serversecurity-combo-box.c:
1056 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1058 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1060 * src/modest-mail-operation.c:
1061 (modest_mail_operation_send_new_mail):
1062 Added a comment about a nasty but apparently harmless message. Details
1063 added to the wiki g_warnings() page.
1065 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1068 (modest_tny_send_queue_class_init):
1069 Do not use the priv struct because it is empty, to avoid g_warnings
1070 about a non-existant priv struct.
1072 * src/modest-tny-account-store.c:
1073 (modest_tny_account_store_get_server_account),
1074 (modest_tny_account_store_get_transport_account_for_open_connection
1075 ): Do not try to get transport server accounts for local folders,
1076 because they don't have any. This avoids a g_warning().
1078 * src/maemo/modest-main-window.c:
1079 (modest_main_window_notify_send_receive_initied),
1080 (on_configuration_key_changed):
1081 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1082 * src/modest-defs.h:
1083 * src/modest-mail-operation.c:
1084 (modest_mail_operation_update_account):
1085 * src/modest-tny-account-store.h:
1086 * src/modest-tny-account.c:
1087 (modest_tny_account_get_special_folder),
1088 (modest_tny_account_new_for_local_folders),
1089 (modest_tny_account_new_for_per_account_local_outbox_folder):
1090 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1091 * src/modest-tny-local-folders-account.c:
1092 (add_account_folders_to_merged_folder):
1093 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1094 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1095 (modest_ui_actions_on_send):
1096 * src/widgets/modest-folder-view.c: (update_model):
1097 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1098 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1099 modest_tny_account_store_get_tny_account_by_account() to
1100 modest_tny_account_store_get_server_account() to make the code clearer.
1102 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1104 * src/dbus_api/modest-dbus-api.h:
1105 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1106 * src/maemo/modest-msg-edit-window.c:
1107 (modest_msg_edit_window_attach_file_noninteractive):
1108 added g_warning in case the file to be attached does not exist
1109 * tests/dbus_api/test_compose_mail.c: (main):
1110 removed obsolete comment, added generic files as test case
1112 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1114 * src/modest-tny-account-store.c: (get_server_accounts):
1115 Create the local folders account only once, not once for each outbox, and
1116 not only when there are some outboxes.
1118 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1120 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1121 code that is causing a crash at startup. Sergio says that he is fixing this.
1123 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1125 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1126 * src/maemo/modest-account-settings-dialog.c:
1127 (create_page_outgoing),
1128 (modest_account_settings_dialog_set_account_name),
1129 (save_configuration):
1130 - Fixed handling of the "Use secure authentication" toggle to comply with
1131 the ui specification. See also projects.maemo.org bug NB#58400
1133 - Restore the Secure connection setting combo correctly when loading
1136 * src/maemo/modest-maemo-utils.c:
1137 (on_camel_account_get_supported_secure_authentication),
1138 (modest_maemo_utils_get_supported_secure_authentication_methods):
1139 Fixed a crasher if operation is canceled
1141 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1142 (modest_protocol_info_auth_is_secure):
1143 * src/modest-protocol-info.h:
1145 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1146 the sense of the "Use secure authentication" toggle.
1148 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1150 * src/modest-tny-account-store.h:
1151 * src/modest-tny-account-store.c:
1152 Added modest_tny_account_store_get_local_folders_account().
1154 * src/modest-tny-folder.h:
1155 * src/modest-tny-folder.c:
1156 (modest_tny_folder_get_account):
1157 Added this replacement for tny_folder_get_account() which returns
1158 the local-folders account for TnyMergeFolders, to avoid the
1159 warning about the unimplemented get_account_func() vfunc().
1161 (modest_tny_folder_get_rules),
1162 * src/modest-ui-actions.c:
1163 (modest_ui_actions_on_folder_selection_changed):
1164 * src/modest-mail-operation.c:
1165 (modest_mail_operation_remove_folder),
1166 (modest_mail_operation_xfer_folder),
1167 (modest_mail_operation_rename_folder),
1168 (modest_mail_operation_get_msg),
1169 (modest_mail_operation_get_msgs_full),
1170 (modest_mail_operation_remove_msg),
1171 (modest_mail_operation_xfer_msgs),
1172 (modest_mail_operation_refresh_folder):
1173 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1175 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1178 (modest_server_account_set_security):
1179 * src/modest-defs.h: Add comments explaining that our
1180 UI spec means TLS when it says Normal, so these do not look like errors.
1182 * src/modest-tny-account.c:
1183 (modest_tny_account_new_from_server_account): Use the new tinymail
1184 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1185 for TLS. This should fix projects.maemo.org bug NB#58460.
1187 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 (create_account): Correct the position of the gconf sanity check warning.
1191 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1192 of using the g_idle_add() hack, because this does not seem to be necessary
1193 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1194 caused by something other than maemo's gconf.
1195 This fixes projects.maemo.org bug #59022.
1197 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1199 * src/modest-account-mgr-helpers.c:
1200 (modest_account_mgr_get_default_account): Do not check that the account
1201 exists if there is no default account (NULL), to fix a runtime warning.
1203 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1205 * src/widgets/modest-folder-view.c: (update_model):
1206 Do not unref the treemodel before we have finished with it.
1207 This prevents a valgrind warning and an occasional crash at startup.
1209 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1211 * libmodest-dbus-client/libmodest-dbus-client.h:
1212 added libmodest_dbus_client_compose_mail()
1213 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1215 added functions needed for SendAsMail() functionality
1216 * src/maemo/modest-msg-edit-window.c:
1217 (modest_msg_edit_window_attach_file_noninteractive):
1218 non interactively attaching files to message edit window
1219 * src/widgets/modest-msg-edit-window.h:
1220 * tests/dbus_api/Makefile.am:
1221 added test_compose_mail.c
1222 * tests/dbus_api/test_compose_mail.c: (main):
1224 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1226 * src/modest-account-view.c:
1227 Fixed bug projects.maemo.org bug NB#59307
1229 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1231 * src/maemo/easysetup/modest-easysetup-wizard.c:
1232 (get_serverport_incoming), (on_before_next), (create_account):
1233 * src/maemo/modest-account-settings-dialog.c:
1234 (modest_account_settings_dialog_set_account_name):
1235 * src/maemo/modest-maemo-utils.c:
1236 (on_camel_account_get_supported_secure_authentication_status),
1237 (on_camel_account_get_supported_secure_authentication),
1238 (on_secure_auth_cancel),
1239 (modest_maemo_utils_get_supported_secure_authentication_methods):
1241 Implemented security authentication for settings and easysetup.
1243 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1245 * src/maemo/modest-main-window.c: (create_details_widget):
1246 Show the total size for memory card accounts too, instead of showing
1247 the name again. Fixes bug projects.maemo.org bug NB#59307.
1249 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-tny-simple-folder-store.c:
1253 * src/modest-tny-simple-folder-store.h: Removed.
1255 * src/modest-tny-local-folders-account.h
1256 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1257 for the local-folders maildir, with an extra TnyMergedFolder containing
1258 the folders of the per-account outbox store accounts.
1259 * src/modest-tny-account-store.c: (get_server_accounts):
1260 Add the outboxes to the special local folders account after creating it.
1262 * src/modest-tny-account.c:
1263 (modest_tny_account_new_for_local_folders): Create the derived
1264 account when creating the main local-folders account.
1266 * src/maemo/modest-main-window.c: (create_details_widget),
1267 (modest_main_window_set_contents_style):
1268 Adapted to the use of the derived account instead of the folder store.
1270 * src/modest-ui-actions.c:
1271 (modest_ui_actions_on_folder_selection_changed):
1272 * src/modest-ui-dimming-rules.c:
1273 (modest_ui_dimming_rules_on_new_folder):
1274 * src/widgets/modest-folder-view.c: (text_cell_data),
1275 (icon_cell_data), (filter_row), (update_model),
1276 (get_cmp_rows_type_pos):
1279 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1280 Do not get the priv struct, because no priv struct has been set,
1281 to avoid a runtime warning.
1283 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1284 #ifelse with #else, to fix a warning, to fix the build.
1287 2007-06-05 Christian Kellner <ckellner@openismus.com>
1289 * libmodest-dbus-client/libmodest-dbus-client.c:
1290 Fix small typo in doc (why do you always see them
1291 AFTER committing stuff?)
1294 2007-06-05 Christian Kellner <ckellner@openismus.com>
1296 * libmodest-dbus-client/libmodest-dbus-client.c:
1297 (libmodest_dbus_client_search):
1298 Initialize hit list with NULL. Also set folder list
1299 to "" if NULL was supplied.
1302 2007-06-03 Christian Kellner <ckellner@openismus.com>
1304 * libmodest-dbus-client/libmodest-dbus-client.c:
1305 (modest_search_hit_list_free):
1306 Make it save to call it with NULL.
1308 * src/dbus_api/modest-dbus-callbacks.c:
1309 * src/modest-search.c:
1310 Return full ModestSearchHits as the search result list not TnyHeader
1311 since can't be around withouth the correspoding TnyFolder.
1313 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1315 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1316 Added currently commented code to check for secure auth
1318 * src/maemo/modest-account-settings-dialog.c: (on_response),
1319 (save_configuration), (show_ok):
1320 Fixed projects.maemo.org bugs NB #59248 and #59251
1322 * src/maemo/modest-maemo-utils.c:
1323 (on_camel_account_get_supported_secure_authentication_status),
1324 (on_camel_account_get_supported_secure_authentication),
1325 (modest_maemo_utils_get_supported_secure_authentication_methods):
1326 * src/maemo/modest-maemo-utils.h:
1327 Moved get_supported_secure_authentication() method here to be able
1328 to use it from easysetup wizard.
1330 * src/modest-pair.c: (on_pair_compare_as_string):
1331 Should compare string with first part of pair and not
1332 strcmp pairs which will crash.
1334 * src/modest-protocol-info.c:
1335 (modest_protocol_info_protocol_is_store):
1336 * src/modest-protocol-info.h:
1337 Added modest_protocol_info_get_auth_protocol_name()
1339 2007-06-03 Armin Burgmeier <armin@openismus.com>
1341 * src/modest-mail-operation.c:
1342 (modest_mail_operation_get_msgs_full): Set priv->account also when
1343 only retrieving a single message. This avoids a crash when canceling
1346 (modest_mail_operation_notify_end): Do not explicitely remove the
1347 operation from the queue but only emit the progress_changed signal.
1348 The queue itself listens to that signal to remove the operation when
1349 it is finished. This reduces coupling and removes a potential deadlock
1350 when modest_mail_operation_notify_end() is called from the queue
1351 itself. If that is a problem performance-wise, I would suggest to
1352 implement a status-changed signal or something.
1354 * src/modest-mail-operation-queue.c: Make sure to never call a
1355 function from another file while the queue is locked. This (hopefully)
1356 fixes another deadlock when exiting the application while retrieving
1359 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1361 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1362 Fixed build if libogs is not available
1364 2007-06-03 Christian Kellner <ckellner@openismus.com>
1366 * libmodest-dbus-client/libmodest-dbus-client.h:
1367 * libmodest-dbus-client/libmodest-dbus-client.c:
1368 (libmodest_dbus_client_delete_message):
1369 Implement deletion of messages (Client side).
1371 (modest_search_hit_free),
1372 (modest_search_hit_list_free):
1373 Utility functions to free the result hits.
1375 * src/dbus_api/modest-dbus-api.h:
1376 * src/dbus_api/modest-dbus-callbacks.c:
1377 (on_delete_message),
1378 (modest_dbus_req_handler):
1379 Implement deletion of messages (Server side).
1381 * tests/dbus_api/test_search.c: (main):
1384 * tests/dbus_api/Makefile.am:
1385 * tests/dbus_api/test_delete_message:
1386 Add little test for the message deletion logic
1388 2007-06-03 Armin Burgmeier <armin@openismus.com>
1390 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1391 when the operation queue was not empty. projects.maemo.org bug
1394 2007-06-03 Armin Burgmeier <armin@openismus.com>
1396 * src/widgets/modest-account-view.c
1397 (on_account_default_toggled): Toggle default account column
1398 explicitely instead of waiting for gconf notification (which is
1399 currently ignored). This should fix projects.maemo.org bug NB#56910
1400 for now. It should probably be removed when gconf notifications are
1403 2007-06-03 Christian Kellner <ckellner@openismus.com>
1405 * libmodest-dbus-client/libmodest-dbus-client.c:
1406 Removed debugging spew.
1408 * src/dbus_api/modest-dbus-callbacks.c:
1409 Added debugging info.
1411 * src/modest-search.c:
1412 (modest_search_all_accounts):
1413 Use tny_account_store_get_accounts () on the account store
1414 to get all accounts which is the way to get all accounts.
1416 * tests/dbus_api/test_search.c: (main):
1417 Make it possible to supply the search term on the command line.
1419 2007-06-03 Christian Kellner <ckellner@openismus.com>
1421 * libmodest-dbus-client/libmodest-dbus-client.c:
1422 * libmodest-dbus-client/libmodest-dbus-client.h:
1423 Implement searching for mesages over raw dbus. (Client side)
1425 * src/dbus_api/Makefile.am:
1426 * src/dbus_api/modest-dbus-api.h:
1427 * src/dbus_api/modest-dbus-callbacks.c:
1428 * src/dbus_api/modest-dbus-callbacks.h:
1429 Search framework (Server side). Also implement on_idle_open_message().
1431 * src/maemo/modest-platform.c: (modest_platform_init):
1432 Prepare for raw dbus/osso rpc interaction.
1434 * src/modest-search.h:
1435 Changed minsize from unspecific guint to guint32.
1437 * src/modest-search.c:
1439 Added strange hack which magically made tnymail work.
1441 (modest_search_folder),
1442 (modest_search_account),
1443 (modest_search_all_accounts):
1444 Implement helper functions to search all accounts, specific account
1447 * tests/dbus_api/Makefile.am:
1448 * tests/dbus_api/test_open_message.c:
1449 Read url to open from commandline.
1451 * tests/dbus_api/test_search.c:
1452 Implement small test for dbus search stuff
1454 2007-06-02 Armin Burgmeier <armin@openismus.com>
1456 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1457 include account type and account title. This fixes projects.maemo.org
1460 * src/maemo/modest-account-view-window.c: Set a title for the window.
1462 2007-06-02 Armin Burgmeier <armin@openismus.com>
1464 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1465 incoming and outgoing server name based on email address and server
1466 types as long as the names have not been edited manually. This fixes
1467 projects.maemo.org bug NB#58671.
1469 2007-06-02 Armin Burgmeier <armin@openismus.com>
1471 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1472 server type cannot be changed in future to the incoming details page
1473 when creating an account. This fixes projects.maemo.org bug NB#59029.
1475 2007-06-02 Armin Burgmeier <armin@openismus.com>
1477 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1478 and assigned max width chars so that they wrap instead of being
1479 truncated. Fixes projects.maemo.org bug NB#56126.
1481 2007-06-02 Armin Burgmeier <armin@openismus.com>
1483 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1484 introductory note to the connection specific smtp servers dialog, as
1485 section 8.12 of the email UI specification requires. This fixes
1486 projects.maemo.org bug NB#59212.
1488 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1490 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1491 Check for running mail operations, and offer to cancel them, as per the UI
1492 spec. This fixes projects.maemo.org bug NB#59041 .
1493 However, I suspect that tinymail may still use the network connection
1494 in ways that we cannot detect or cancel. But it should at least adapt to
1495 changes fairly well.
1497 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1499 * src/modest-tny-account-store.c: (recreate_all_accounts),
1500 (get_cached_accounts), (get_server_accounts): Do more sensible
1501 ref-counting of the temporarily-cached outbox accounts list. This seems
1502 to fix a crash when entering the password when the password was wrong.
1504 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1506 * src/gnome/modest-main-window.c: (connect_signals):
1507 * src/modest-tny-account-store.c: (get_password),
1508 (modest_tny_account_store_alert): Added comments and clues and
1509 commented-out code about how we currently fail to deal with connection
1510 errors and wrong passwords, and how we should.
1512 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1514 * src/widgets/modest-retrieve-combo-box.c:
1515 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1516 This fixes projects.maemo.org bug NB#58472 .
1518 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/easysetup/modest-easysetup-wizard.c:
1521 (create_page_complete_easysetup):
1522 (create_page_complete_custom): Correct the last commit,
1523 putting the correct sentences in the correct pages.
1525 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/easysetup/modest-easysetup-wizard.c:
1528 (create_page_complete_custom): Show the second sentence of text
1529 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1532 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1535 Set the leave-on-server conf key by default. This fixes
1536 projects.maemo.org bug NB#59258 .
1538 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/modest-account-view-window.c:
1541 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1542 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1545 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1547 * src/maemo/easysetup/modest-easysetup-wizard.c:
1548 (create_caption_new_with_asterisk):
1549 * src/maemo/modest-account-settings-dialog.c:
1550 (create_caption_new_with_asterisk):
1551 Uncomment the code to add the asterisk, because they are no longer in the
1552 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1553 (update_incoming_server_title): Add an asterisk here too.
1555 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1557 * src/maemo/modest-maemo-global-settings-dialog.c:
1558 (current_connection): Check that we are even connected before trying to
1559 get the current connection name, to prevent a warning.
1561 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1562 Change the comments because tny_maemo_conic_device_connect() is now meant to
1564 * src/modest-mail-operation.c:
1565 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1566 make sure we have a connection and fail if we can't connect.
1568 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/modest-main-window.c:
1571 (on_account_store_connecting_finished): Do not try to get the
1572 connection ID if we are not really connected. I am surprised that
1573 this signal handler is called when we are not connected.
1575 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-error.h:
1578 * src/modest-ui-actions.c:
1579 (modest_ui_actions_get_msgs_full_error_handler):
1580 Renamed an enum, added comments, added an enum
1581 for retrieve-limit errors.
1583 * src/modest-mail-operation.c: (foreach_add_item),
1584 (internal_folder_observer_update), (update_account_thread),
1585 (modest_mail_operation_get_msgs_full):
1586 (modest_mail_operation_update_account),
1587 Added comments about how this works, and some code that should
1588 (but does not) check the retrieve-limit. See the TODO comment.
1590 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1593 Initialize help_id to fix the build. Warnings are good.
1595 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1597 * src/widgets/modest-hbox-cell-renderer.c:
1598 (modest_hbox_cell_renderer_append):
1599 * src/widgets/modest-vbox-cell-renderer.c:
1600 (modest_vbox_cell_renderer_append):
1601 Fix the last commit by doing an extra ref.
1603 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1605 * src/widgets/modest-hbox-cell-renderer.c:
1606 (modest_hbox_cell_renderer_append):
1607 * src/widgets/modest-vbox-cell-renderer.c:
1608 (modest_vbox_cell_renderer_append):
1609 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1610 to fix the build with Maemo Bora.
1611 However, there seems to be a remaining crash, probably due to reference
1614 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1616 * src/modest-tny-account.c:
1617 (modest_tny_account_new_for_local_folders):
1618 Use hildon_file_system_info_async_new() to get a better name for
1619 the memory card account, setting it as the account name.
1620 The timing seems to work, but this is probably
1621 not the best place to do this. See the TODO comment.
1622 * src/maemo/modest-main-window.c: (create_details_widget):
1623 * src/widgets/modest-folder-view.c: (text_cell_data):
1624 Use the tny account name instead of hardcoding a name.
1626 2007-05-30 Christian Kellner <ckellner@openismus.com>
1628 * src/modest-search.c: (modest_search):
1629 Correctly set part_search_func even if we have already parsed
1630 the query and thus a valid OgsTextSearcher object.
1632 2007-05-30 Christian Kellner <ckellner@openismus.com>
1635 Search and check for libogs.
1638 Incooparte the ogs build env.
1640 * src/modest-mime-part-search-stream.c:
1641 * src/modest-mime-part-search-stream.h:
1642 Removed since we do the real searching now in modest-search.c.
1644 * src/modest-search.c:
1645 * src/modest-search.h:
1646 Implement support for ogs. We use that if available and requested
1647 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1648 should now handle the corner case when the search term is spread
1649 across multiple reads.
1650 Also the logic in modest_search () was corrected to search all
1651 requested fields until one is found.
1653 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1655 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1657 * src/modest-init.h:
1658 * src/modest-init.c: Made modest_init_local_folders() take a
1659 path and be public so we can iniitialize maildir folders on
1662 * src/modest-local-folder-info.h:
1663 * src/modest-local-folder-info.c:
1664 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1666 * src/modest-tny-account.c:
1667 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1668 still means the standard local-folders path on the local volume.
1670 * src/modest-tny-account-store.c:
1671 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1672 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1673 all accounts when that happens.
1674 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1675 this too, so it shows up in the treeview.
1677 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/modest-maemo-global-settings-dialog.c:
1680 (current_connection):
1681 * src/widgets/modest-global-settings-dialog.c:
1682 (current_connection_default):
1683 Use the enum values instead of 0, 1 and -1,
1684 to make the code clearer.
1686 * src/modest-account-mgr-helpers.c:
1687 (modest_account_mgr_get_connection_specific_smtp): Make this code
1690 * src/modest-runtime.h:
1691 * src/modest-runtime.c:
1692 Added modest_runtime_remove_all_send_queues().
1693 * src/maemo/modest-main-window.c:
1694 (on_account_store_connecting_finished): Recreate the send queues,
1695 using the appropriate transport accounts for this new connection.
1696 Some futher adapting might be needed if the old send queues are not
1697 automatically stopped at this point.
1699 * src/modest-tny-account-store.c: (get_server_accounts):
1700 Create the connection-specific transport accounts, so that they can
1701 be found later by their ID.
1703 * src/modest-tny-account.h:
1704 * src/modest-tny-account.c:
1705 Added modest_tny_account_new_from_server_account_name().
1706 modest_tny_account_new_from_server_account(): Do not create the
1707 send queues here, because they will be
1708 recreated anyway when the connection changes for the first time.
1710 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-local-folder-info.h:
1713 * src/modest-local-folder-info.c:
1714 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1715 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1716 tbox_folder): Take a modest account name instead of a server TnyAccount,
1717 so we can have per-modest-account rather than per-transport-account
1719 We must make sure that we change or recreate the exisitng send queues
1720 when the connection changes for connection-specific transport accounts.
1722 * src/modest-tny-account-store.c:
1723 (create_per_account_local_outbox_folders): Create outboxed per modest
1724 account, not per transport account.
1726 * src/modest-tny-account.h:
1727 * src/modest-tny-account.c:
1728 (modest_tny_account_get_special_folder): For outboxes, get the
1729 parent modest account name. The account is ignored for other folders.
1730 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1731 modest account name rather than a server TnyAccount.
1733 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-tny-account.c:
1736 (modest_tny_account_new_from_server_account):
1737 Call modest_runtime_get_send_queue() immediately after creating transport
1738 accounts, so that they start trying to send email from the outbox as soon
1739 as possible at startup. This is probably what we want.
1741 * src/modest-mail-operation.c: (update_account_thread):
1742 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1743 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1744 * src/modest-tny-send-queue.h:
1745 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1746 (modest_ui_actions_on_send):
1747 Added comments about how sending works, though it needs some more work.
1749 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1751 * src/modest-tny-account.c:
1752 (modest_tny_account_get_special_folder): Add TODO because this fails when
1753 the network is busy.
1754 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1755 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1756 Do not try to show this window when there is no active account. The UI
1757 specs does not tell us what to do in this case.
1759 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1763 * src/maemo/Makefile.am:
1764 * src/widgets/Makefile.am: Some dist fixes.
1766 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/modest-connection-specific-smtp-window.c:
1769 (on_button_edit): Make the code clearer, to prevent a double free.
1771 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1773 * src/maemo/modest-account-settings-dialog.c:
1774 (modest_account_settings_dialog_set_account_name),
1775 Check the connection-specific smtp servers checkbox if there are any.
1777 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1778 (modest_connection_specific_smtp_edit_window_init):
1779 Start with a suitable port number.
1781 * src/modest-account-mgr-helpers.h:
1782 * src/modest-account-mgr-helpers.c: Added
1783 modest_account_mgr_get_has_connection_specific_smtp().
1785 (modest_account_mgr_set_connection_specific_smtp),
1786 (modest_account_mgr_remove_connection_specific_smtp),
1787 (modest_account_mgr_get_has_connection_specific_smtp),
1788 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1789 connection-specific smtp server accounts in the account, rather than
1790 the server account conf dir.
1792 This fixes bug projects.maemo.org bug NB#58263 .
1794 * src/modest-tny-account-store.c:
1795 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1796 if there are no server accounts yet, to prevent an infinite loop when there
1797 are no accounts. Document that one must be called before the other.
1799 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-account-mgr-helpers.c:
1802 (modest_account_mgr_get_default_account): Make sure that at least
1803 one account is always the default, if there are any enabled accounts.
1804 This is just a sanity check that shouldn't be necessary.
1806 * src/modest-account-mgr-priv.c:
1807 (_modest_account_mgr_account_from_key): Unescape the conf key to
1808 get the real account name. For instance, this is an issue if a space
1809 was in the account name, which can happen because the account name
1810 is generated from the display name.
1811 (_modest_account_mgr_get_account_keyname): Always escape the
1813 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1814 Unescape the conf keys to get the real account names.
1816 For instance, previously the is-default radio button in the accounts
1817 list was not checked for any accounts at first. This fixes that,
1818 and might fix several similar bugs.
1820 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1822 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1823 Removed some debug printfs.
1825 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1827 Modest on-disk outbox directories are now here, for instance:
1828 $HOME/.modest/outboxes/<account-id-1>/outbox
1829 $HOME/.modest/outboxes/<account-id-2>/outbox
1831 $HOME/.modest/local-folders/outbox
1832 so we can have a separate outbox for each account.
1833 But they are shown as one outbox in the GtkTreeView, by using a
1834 TnyMergeFolder in a ModestTnySimpleFolderStore.
1837 * src/modest-tny-simple-folder-store.c:
1838 * src/modest-tny-simple-folder-store.h:
1839 Added ModestTnySimpleFolderStore, used to contain folders from
1840 other folder stores, such as other accounts.
1842 * src/modest-tny-outbox-account.h:
1843 * src/modest-tny-outbox-account.c:
1844 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1845 used for the per-account local outbox folders.
1847 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1848 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1849 only use this (internally) now for the non-outbox local folders.
1851 * src/modest-init.h:
1852 * src/modest-init.c: Added modest_init_one_local_folder(), for
1853 setting up the directory structure for each local folder.
1855 * src/modest-local-folder-info.c:
1856 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1857 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1859 * src/modest-local-folder-info.h:
1860 * src/modest-tny-account-store.c: (on_account_removed),
1861 (on_account_changed), (create_per_account_local_outbox_folders),
1862 (get_server_accounts), (modest_tny_account_store_get_accounts),
1863 (modest_tny_account_store_get_tny_account_by_account),
1864 (modest_tny_folder_store_is_virtual_local_folders):
1866 * src/modest-tny-account.h:
1867 * src/modest-tny-account.c:
1868 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1869 to create an on-disk per-account local outbox folder for each
1871 (create_per_account_local_outbox_folders): Create a local outbox folder
1872 for each transport account.
1873 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1874 for all local folders.
1876 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1877 instead of using g_object_get/set() directly. It is clearer.
1879 (modest_tny_folder_store_get_message_count),
1880 (modest_tny_folder_store_get_local_size
1881 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1882 because we now use these with non-acount folder stores.
1884 (modest_tny_account_get_special_folder),
1885 (modest_tny_account_new_from_server_account),
1886 (modest_tny_account_new_from_account):
1887 (recurse_folders): Adjust to the new outbox system.
1889 * src/modest-tny-folder.h:
1890 * src/modest-tny-folder.c:
1891 (modest_tny_folder_is_local_folder),
1892 (modest_tny_folder_get_local_folder_type),
1893 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1895 * src/widgets/modest-main-window.h:
1896 * src/maemo/modest-main-window.c: (create_details_widget),
1897 (modest_main_window_set_contents_style): Show details for any folder store,
1900 (modest_tny_folder_get_rules):
1901 Remove the const. C does not support constness enough for this.
1903 * src/modest-ui-actions.c:
1904 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1905 make all outboxes appear as one, in the usual local-folders tree node.
1907 (set_active_account_from_tny_account),
1908 (modest_ui_actions_on_folder_selection_changed):
1909 * src/widgets/modest-folder-view.c: (text_cell_data),
1910 (icon_cell_data), (filter_row),
1911 (add_account_folders_to_merged_folder),
1912 (add_account_folders_to_simple_folder_store), (),
1913 (get_cmp_rows_type_pos), (cmp_rows),
1914 (modest_folder_view_set_account_id_of_visible_server_account):
1915 Adjust to the new outbox system, using generic folder stores and folders
1916 in the GtkTreeModel.
1918 2007-05-23 Christian Kellner <ckellner@openismus.com>
1920 * src/modest-mail-operation.c:
1921 (modest_mail_operation_update_account):
1922 Use info->max_size instead of unintialized local var [small
1923 build fix]. (Added TODO to review that change since I don't
1926 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1928 * libmodest-dbus-client/libmodest-dbus-client.c:
1929 (libmodest_dbus_client_compose_mail): function added
1930 * src/dbus_api/modest-dbus-api.h:
1931 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1932 (on_compose_mail): Implementation of the SendAsMail functionality
1934 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-account-mgr.c:
1937 (modest_account_mgr_add_server_account): Set the secure-connection
1938 conf key for transport accounts as well as store accounts. I don't know
1939 why the if was there. For instance, this makes sure that we use SSL
1940 for the gmail preset from the easysetup wizard.
1942 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1944 * src/gnome/modest-main-window.c:
1945 (on_account_store_connecting_finished), (connect_signals):
1946 * src/maemo/modest-main-window.c:
1947 (on_account_store_connecting_finished), (connect_signals),
1948 (modest_main_window_new):
1949 Handle TnyAccountStore::connecting-finished instead of
1950 TnyDevice::connection-changed, because we cannot actually perform
1951 operations on accounts until TnyAccountStore has itself responded to
1952 the TnyDevice::connection-changed signal. This prevents a GError from
1954 Do not try to update at startup, because we (at least on scratchbox)
1955 already do an update at startup when the device goes online.
1956 This prevents a GError from tinymail.
1957 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1958 Added TODO about stopping simultaneous operations.
1960 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1962 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1963 * src/modest-mail-operation-queue.c:
1964 (modest_mail_operation_queue_remove):
1965 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1966 about where they happened.
1968 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-ui-actions.c:
1971 (modest_ui_actions_on_password_requested): Make sure that the remember
1972 output parameter is always TRUE.
1974 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1977 Show a OK/Cancel dialog if the error is a question, though we still do not
1978 know anything more about what we are asking the user.
1979 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1980 Fix an uninitialized variable (helper). This is a logic error, however.
1982 2007-05-21 Christian Kellner <ckellner@openismus.com>
1984 * src/modest-search.h:
1985 Correct bit shifting in the ModestSearchFlags enum.
1987 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1989 * src/modest-tny-account.c:
1990 (modest_tny_account_new_from_server_account): Do not use the lsub and
1991 check-all hard-coded IMAP options when using POP.
1993 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-tny-account.c:
1996 (modest_tny_account_new_from_server_account):
1997 Use NULL for the secure-auth method for POP when Password auth has been
1998 specified by the user, as we already do for IMAP. "auth=Login" causes
1999 an error from camel or the server.
2001 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/modest-account-settings-dialog.c:
2004 (create_page_account_details),
2005 (modest_account_settings_dialog_set_account_name):
2006 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2007 for the leave-on-server checkbox, rathr than just the checkbox, when
2008 the protocol is not POP.
2010 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2012 * src/widgets/modest-account-view.c:
2013 * src/widgets/modest-account-view.h:
2014 Added modest_account_view_select_account() which will be useful later
2015 to asynchronously re-select the edited account.
2017 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-account-settings-dialog.c:
2020 (modest_account_settings_dialog_set_account_name):
2021 Automatically choose the port numbers based on the secure authentication
2022 methods, if they have not been chosen before.
2023 This fixes projects.maemo.org bug NB#56273 .
2025 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2027 * src/maemo/modest-main-window-ui.h:
2028 * src/modest-ui-actions.c:
2029 * src/modest-ui-actions.h:
2030 Connect the Tools/SMTP Servers menu item to
2031 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2032 SMTP servers dialog, as in the UI specification and saves changes when it
2033 is closed. This fixed projects.maemo.org bug NB#56305 .
2035 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/modest-connection-specific-smtp-window.c:
2038 (modest_connection_specific_smtp_window_init):
2039 Use gtk_window_set_default_size() to make this window big enough, so
2040 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2042 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2045 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2046 (modest_connection_specific_smtp_edit_window_init),
2047 Do not try to connect to a combobox signal before the combobox exists.
2048 This fixes the cras in projects.maemo.org bug NB#56288 .
2049 (modest_connection_specific_smtp_edit_window_get_settings):
2050 Remove the server_account_name parameter which was being checked for NULL
2051 though it was not used.
2053 * src/maemo/modest-connection-specific-smtp-window.c:
2054 (modest_connection_specific_smtp_window_fill_with_connections),
2055 (on_button_edit), (modest_connection_specific_smtp_window_init):
2056 Correct the number of treemodel columns to prevent a warning.
2057 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2058 libconic does not work.
2060 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-tny-account.c:
2063 (modest_tny_account_new_from_server_account):
2064 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2065 SMTP when "None" was chosen by the user. However, with my SMTP server that
2066 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2069 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2071 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2072 to explain the memory management issue with the ID in the ModestPair.
2074 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2075 (add_sending_page), (modest_account_assistant_finalize):
2076 * src/gnome/modest-gnome-global-settings-dialog.c:
2077 (create_updating_page), (create_composing_page):
2078 * src/gnome/modest-msg-edit-window.c: (get_transports),
2079 (init_window), (modest_msg_edit_window_finalize),
2080 (modest_msg_edit_window_get_msg_data):
2081 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2082 * src/gnome/modest-transport-widget.c:
2083 (modest_transport_widget_finalize), (smtp_configuration):
2084 * src/maemo/modest-maemo-global-settings-dialog.c:
2085 (create_updating_page), (create_composing_page):
2086 * src/maemo/modest-msg-edit-window.c: (get_transports),
2087 (init_window), (modest_msg_edit_window_finalize),
2088 (modest_msg_edit_window_get_msg_data),
2089 (modest_msg_edit_window_free_msg_data):
2090 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2091 (modest_store_widget_finalize):
2092 * src/maemo/modest-transport-widget.c:
2093 (modest_transport_widget_finalize), (smtp_configuration):
2094 * src/modest-main.c: (send_mail):
2095 * src/widgets/modest-combo-box.h:
2096 * src/widgets/modest-global-settings-dialog-priv.h:
2097 * src/widgets/modest-global-settings-dialog.c:
2098 (modest_global_settings_dialog_finalize):
2099 * src/widgets/modest-msg-edit-window.h:
2100 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2101 as long as the combo box, to prevent use of freed memory for the ID.
2103 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2105 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2106 get_accounts(), to make this clearer. Do not check for the enabled gconf
2107 key, because we do not use this for server accounts (at least, not yet).
2108 This allows us to send email again.
2110 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2112 * src/maemo/modest-platform.c:
2113 (on_modest_conf_update_interval_changed), (modest_platform_init):
2114 Only respond to this particular key change. All these strcmp()s cannot be
2117 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/modest-maemo-global-settings-dialog.c:
2120 (current_connection): Prevent a crash in scratchbox when
2121 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2122 * src/maemo/modest-platform.c:
2123 (on_modest_conf_update_interval_changed), (modest_platform_init):
2124 Get the update interval from gconf and reset it when the gconf key changes.
2126 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-protocol-info.c:
2129 * src/modest-protocol-info.h: Adde enum-specific get functions,
2130 instead of using a ModestProtocolType enum parameter.
2132 * src/gnome/modest-account-assistant.c:
2133 * src/gnome/modest-store-widget.c:
2134 * src/gnome/modest-store-widget.h:
2135 * src/gnome/modest-transport-widget.c:
2136 * src/gnome/modest-transport-widget.h:
2137 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2138 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2139 * src/maemo/easysetup/modest-easysetup-wizard.c:
2140 * src/maemo/modest-account-settings-dialog.c:
2141 * src/maemo/modest-account-settings-dialog.h:
2142 * src/maemo/modest-store-widget.c:
2143 * src/maemo/modest-store-widget.h:
2144 * src/maemo/modest-transport-widget.c:
2145 * src/maemo/modest-transport-widget.h:
2146 * src/modest-account-mgr-helpers.c:
2147 * src/modest-account-mgr-helpers.h:
2148 * src/modest-account-mgr.c:
2149 * src/modest-account-mgr.h:
2150 * src/modest-tny-account.c:
2151 * src/modest-tny-folder.c:
2152 * src/widgets/modest-account-view.c:
2153 * src/widgets/modest-retrieve-combo-box.c:
2154 * src/widgets/modest-retrieve-combo-box.h:
2155 * src/widgets/modest-secureauth-combo-box.c:
2156 * src/widgets/modest-serversecurity-combo-box.c:
2157 * src/widgets/modest-serversecurity-combo-box.h:
2158 * tests/check_account-mgr.c:
2159 Use the specific functions, and use the re-renamed enum values for GNOME too.
2161 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2163 * src/modest-pair.h:
2164 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2165 so we can get the second based on the first.
2167 * src/maemo/modest-account-settings-dialog.h:
2168 * src/maemo/modest-account-settings-dialog.c:
2169 Added get_supported_secure_authentication_methods(), though it is mostly
2170 commented-out for now until the necessary API is committed to tinymail.
2171 (modest_account_settings_dialog_set_account_name),
2172 (save_configuration): Request the supported authentication methods from the
2173 server, so we can choose a working method.
2175 * src/modest-tny-account-store.h:
2176 * src/modest-tny-account-store.c:
2177 (modest_tny_account_store_get_session): Rename from
2178 tny_account_store_get_session().
2180 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2182 * src/modest-protocol-info.h: Split the ModestProtocol enum
2183 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2184 There was no need to have these unrelated values in one enum.
2186 * src/: many files: Adapted to changed enum. This makes the code a bit
2187 clearer, and the compiler could catch some errors.
2189 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2191 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2192 Show the detailed internal camel error message when an error happens
2193 during the configuration, so that our testers can give us more clues.
2194 For instance, in projects.maemo.org bug NB#56910 .
2196 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2198 * src/modest-tny-account.c:
2199 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2200 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2202 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2204 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2205 * src/maemo/modest-account-settings-dialog.c:
2206 (modest_account_settings_dialog_set_account_name),
2207 (save_configuration): For the incoming secure authentication checkbox,
2208 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2209 the UI specification. PLAIN does not seem to be supported for most IMAP
2210 servers anyway, and I am not sure what it would mean.
2211 However, we probably need to discover which of the secure-authentication
2212 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2213 * src/modest-account-mgr-helpers.c:
2214 (modest_account_mgr_get_server_account_data):
2216 * src/modest-tny-account.c:
2217 (modest_tny_account_new_from_server_account):
2218 Use tny_account_set_mech() to set secure-authentication methods,
2219 with some special-casing for IMAP, based on my observations of how
2222 * src/modest-account-mgr-helpers.h:
2223 * src/modest-account-mgr.c:
2224 * src/modest-defs.h: Comment that the URI is only used for local folders.
2226 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2229 parameter const, just to be neat.
2230 * src/modest-text-utils.c: (modest_text_utils_inline):
2231 End g_strconcat() with NULL, as its documentation says. This is almost
2232 certainly the cause of my crash at startup on the device. Interestingly,
2233 valgrind doesn't tell us about these errors.
2235 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2237 * scripts/build-packages: Added more precise comments about how to use
2238 this script, though I still get this error:
2239 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2240 error building tinymail
2242 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/modest-main-window.c: (on_account_update):
2245 Very slight cleanup, hoping to make it simpler to discover what causes
2246 a crash here sometimes.
2248 * src/modest-tny-account.c:
2249 (modest_tny_account_new_from_server_account): Set the port. Added
2250 comments about the options and a TODO comment because I need to find out
2251 how to specify the secure authentication method.
2253 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2255 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2256 changed CFlags paths form modest to libmodest
2258 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2260 * src/modest-account-mgr-helpers.c:
2261 (modest_account_mgr_get_server_account_data),
2262 (modest_account_mgr_free_server_account_data):
2263 * src/modest-account-mgr-helpers.h:
2264 * src/modest-account-mgr.c:
2265 (modest_account_mgr_add_server_account):
2266 * src/modest-defs.h:
2267 * src/modest-tny-account.c:
2268 (modest_tny_account_new_from_server_account):
2269 Determine the options for tny_camel_account_add_option() here,
2270 based on the settings, rather than storing them directly in gconf.
2272 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2275 Show a more friendly error dialog now that we expect (from the tinymail
2276 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2278 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2280 * src/maemo/modest-main-window.c: (on_account_update): Check that
2281 account_name is not NULL, to prevent a crash at startup that I am
2282 seeing on the N800. I do wonder why it is NULL.
2284 * src/maemo/easysetup/modest-easysetup-wizard.c:
2285 (create_page_user_details):
2286 * src/maemo/modest-account-settings-dialog.c:
2287 (create_page_user_details), (create_page_outgoing):
2288 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2289 (modest_connection_specific_smtp_edit_window_init):
2290 * src/modest-ui-actions.c:
2291 (modest_ui_actions_on_password_requested):
2292 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2293 might do something useful with the on-screen keyboard.
2295 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2297 * src/maemo/modest-main-window.c: (on_account_update):
2298 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2299 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2301 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-tny-account-store.c: (on_account_changed):
2304 Correct the signature of this signal handler.
2306 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2308 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2309 Show a HildonNote instead of a GtkDialog for Maemo.
2311 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2313 * src/widgets/modest-account-view.h:
2314 * src/widgets/modest-account-view.c: (on_account_changed),
2315 (on_account_removed). Added a boolean flag, set/unset by
2316 modest_account_view_block_conf_updates(),
2317 modest_account_view_unblock_conf_updates() to prevent unnecessary
2318 updates, but this is not very useful because the gconf notifications are
2319 so delays (maybe only on Maemo Bora).
2320 So auto-updating is turned off, and these functions do an explicit
2321 update when necessary.
2322 However, something else is still doing too much work when adding/removing
2323 accounts, probably in another part of the application.
2325 * src/maemo/modest-account-view-window.c:
2326 (on_delete_button_clicked), (on_edit_button_clicked),
2327 (on_new_button_clicked): Use the new functions.
2329 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-account-mgr-helpers.c:
2332 (modest_account_mgr_set_first_account_as_default):
2333 Sort the list of names alphabetically-by-title, so we choose the first one
2335 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2336 alphabetically by the title.
2338 This fixes projects.maemo.org bug NB#56418 .
2340 * src/modest-account-mgr-priv.c:
2341 (_modest_account_mgr_account_from_key):
2342 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2343 avoid a valgrind error, and possible random behaviour.
2345 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2347 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2348 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2349 tinymail documentation to say that this can be expected.
2350 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2351 pretty, and should not happen, but I would prefer to know when it does.
2353 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2355 * configure.ac: When using the older hildon version, probably on Bora,
2356 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2358 * src/widgets/modest-attachment-view.c:
2359 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2362 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2364 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2365 Implemented the prototype. Can be tested with
2366 tests/dbus_api/test_open_message:
2368 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-tny-account-store.c:
2371 (modest_tny_account_store_instance_init), (get_password):
2372 * src/modest-ui-actions.c:
2373 (modest_ui_actions_on_password_requested):
2374 Do not store the password in gconf, because this function is called
2375 for non-remembered passwords. Actually use the cached (in the hash map)
2376 password instead of releasing it.
2377 The password will now not be remembered if it is asked via the protected
2378 password dialog, as per the UI spec.
2380 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2382 * src/modest-defs.h:
2383 * src/modest-account-mgr-helpers.h:
2384 * src/modest-account-mgr-helpers.c:
2385 Added modest_server_account_get_username_has_succeeded(),
2386 modest_server_account_set_username_has_succeeded().
2387 (modest_server_account_set_username),
2388 Reset the has-succeeded flag if the username changes.
2390 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2391 * src/maemo/modest-connection-specific-smtp-window.c:
2392 (modest_connection_specific_smtp_window_save_server_accounts):
2393 Use modest_server_account_set_username() instead of using
2394 modest_conf_set_string() directly, so that the has-succeeded flag is always
2397 * src/modest-ui-actions.c:
2398 (modest_ui_actions_on_password_requested): Dim the username entry if
2399 the username has ever worked, as per the UI spec.
2401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-tny-account-store.c: (get_password):
2404 * src/modest-ui-actions.c:
2405 (modest_ui_actions_on_password_requested):
2406 Allow the username to be changed too, though there is more work to
2407 be done on exactly how this behaves.
2409 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2411 * src/modest-account-mgr-helpers.h:
2412 * src/modest-account-mgr-helpers.c:
2413 Added modest_account_mgr_get_display_name(),
2414 modest_server_account_get_username(),
2415 modest_server_account_set_username(),
2416 modest_server_account_set_password(),
2417 modest_server_account_get_hostname() functions so we do not need to
2418 use the conf API directly.
2420 * src/maemo/modest-main-window.c: (connect_signals):
2421 Actually connect ot the ModestAccountStore::request-password signal,
2422 so that we show the dialog when the password is requested by Tinymail,
2423 for isntance if it is empty.
2425 * src/modest-marshal.list:
2426 * src/modest-tny-account-store.c:
2427 (modest_tny_account_store_class_init), (get_password),
2428 (modest_tny_account_store_alert):
2429 * src/modest-tny-account-store.h:
2430 * src/modest-ui-actions.h:
2431 * src/modest-ui-actions.c:
2432 (modest_ui_actions_on_password_requested):
2433 Change the signal parameters, so it is obvious that we are providing
2434 the non human-readable server name, and receiving both the username
2435 and password, though changing of the username is not yet implemented.
2436 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2437 for the GNOME version.
2439 This should fix the projects.maemo.org bug NB#56209, though it does not
2440 work on Bora, because the gconf_client_get() for the password fails
2441 immediately after we save it with gconf_client_set().
2443 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2446 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2447 caused an undefined symbol error:
2448 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2450 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2452 * src/modest-tny-account-store.c:
2453 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2454 using a GError instead of a string message, so we can translate it in
2457 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2459 * src/maemo/modest-address-book.c:
2460 (modest_address_book_check_names):
2461 * src/maemo/modest-msg-view-window.c:
2462 (modest_msg_view_window_clipboard_owner_change):
2463 * src/modest-init.c: (modest_init_init_ui):
2464 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2465 (update_folders_cb), (modest_mail_operation_update_account):
2466 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2467 (modest_ui_actions_on_msg_attachment_clicked),
2468 (modest_ui_actions_on_msg_recpt_activated):
2469 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2470 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2471 (modest_msg_view_search_next):
2472 * src/widgets/modest-recpt-editor.c:
2473 (modest_recpt_editor_on_button_release_event),
2474 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2475 g_message(). At this point we should only be seeing interesting errors on
2476 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2478 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2480 (modest_wizard_dialog_force_title_update):
2481 * src/maemo/easysetup/modest-wizard-dialog.h:
2482 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2483 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2484 can update the title when appropriate. Otherwise the title is wrong if the
2485 pages are added after adding the notebook to the dialog.
2486 This must be a problem in HildonWizardDialog too.
2487 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2489 * src/maemo/easysetup/modest-easysetup-wizard.c:
2490 (create_subsequent_customsetup_pages),
2491 (create_subsequent_easysetup_pages):
2492 Call modest_wizard_dialog_force_title_update() so that the title is
2493 correct even with GTK+ < 2.10.
2494 This fixes projects.maemo.org bug NB#56145 .
2496 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2498 * src/maemo/modest-platform.c:
2499 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2500 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2503 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2505 * src/widgets/modest-window.h:
2506 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2507 and modest_window_save_state(), which invokes it.
2509 * src/widgets/modest-window-mgr.h:
2510 * src/widgets/modest-window-mgr.c:
2511 Added modest_window_mgr_save_state_for_all_windows(), which calls
2512 the save_state vfunc on all registered windows, if implemented.
2514 * src/gnome/modest-msg-edit-window.c:
2515 * src/gnome/modest-msg-view-window.c:
2516 * src/maemo/modest-msg-edit-window.c:
2517 * src/maemo/modest-msg-view-window.c:
2518 * src/maemo/modest-main-window.c:
2519 Specify the existing save_settings functions as implementations of
2520 ModestWindow::save_state_func().
2522 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2523 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2524 enabling hibernation, for instance.
2526 We may need to do the same thing for restoring settings.
2529 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2531 * src/widgets/modest-window-mgr.c:
2532 * src/widgets/modest-window-mgr.h:
2533 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2534 modest_window_mgr_get_hibernation_is_prevented().
2536 * src/maemo/modest-main-window.c:
2537 (on_hildon_program_is_topmost_notify): Prevent hibernation
2538 (possible when the application goes to the background in the WM),
2539 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2541 * src/maemo/easysetup/modest-easysetup-wizard.c:
2542 (modest_easysetup_wizard_dialog_init):
2543 * src/maemo/modest-account-settings-dialog.c:
2544 (modest_account_settings_dialog_init):
2545 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2546 (modest_connection_specific_smtp_edit_window_init):
2547 * src/maemo/modest-connection-specific-smtp-window.c:
2548 (modest_connection_specific_smtp_window_init):
2549 * src/maemo/modest-signature-editor-dialog.c:
2550 (modest_signature_editor_dialog_init):
2551 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2552 prevent hibernation while any of these account settings dialogs are open.
2554 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/Makefile.am:
2557 * src/maemo/modest-osso-state-saving.c:
2558 * src/maemo/modest-osso-state-saving.h: Added
2559 modest_osso_load_state() and modest_osso_save_state() though they do
2560 nothing now. They should iterate through all the open windows and load/save
2562 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2563 save state when closing.
2565 * src/maemo/modest-main-window.c:
2566 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2567 Add a notification handler for the HildonProgram::is-topmost property,
2568 so we can allow hibernation when the application goes into the background.
2569 But we still need to detect when the accounts setup windows are open so
2570 we can stop hibernation when they are open.
2571 To do this, I also added the main window the HildonProgram. This might have
2572 other side-effects/benefits, and should maybe be done for other windows.
2574 * src/maemo/modest-osso-autosave-callbacks.h:
2575 * src/maemo/modest-osso-autosave-callbacks.c:
2576 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2577 though it does not do anything yet, and we might never need this to do
2578 anything. For instance, we already save drafts.
2580 * src/maemo/modest-platform.c: (modest_platform_init):
2581 Specify the libosso auto-save callback.
2583 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/modest-platform.c:
2586 (modest_platform_set_update_interval):
2587 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2588 aparently stays valid between application instances, so we can use this
2589 to remove and reset it later. According to a maemo-developers email from
2592 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2594 * configure.ac: Depend on libalarm for Maemo.
2596 * src/dbus_api/modest-dbus-api.h:
2597 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2598 (on_send_receive), (modest_dbus_req_handler):
2599 Handle a SEND_RECEIVE D-Bus method.
2601 * libmodest-dbus-client/libmodest-dbus-client.c:
2602 (libmodest_dbus_client_send_and_receive):
2603 * libmodest-dbus-client/libmodest-dbus-client.h:
2604 Add C convenience functions for calling the new D-Bus method.
2606 * src/modest-platform.h:
2607 * src/gnome/modest-platform.c:
2608 * src/maemo/modest-platform.c:
2609 Added modest_platform_set_update_interval(), which uses the
2610 alarmd API on Maemo.
2611 (modest_platform_init),
2612 Call modest_platform_set_update_interval(), using a hard-coded
2613 interval for now (until the global settings dialog is implemented),
2614 though I am not sure that this makes sense yet.
2616 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2618 * src/dbus_api/modest-dbus-callbacks.c:
2619 (modest_osso_cb_hw_state_handler):
2620 * src/dbus_api/modest-dbus-callbacks.h:
2621 * src/maemo/modest-platform.c: (modest_platform_init):
2622 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2623 in case this has some effect on the ability for Maemo to ping the
2626 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2628 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2629 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2630 warning. It is probably a logic error, but I need to fix the build.
2632 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2634 * src/modest-account-mgr.h:
2635 * src/modest-account-mgr.c:
2636 (modest_account_mgr_account_names): Add a gboolean enabled_only
2637 parameter, so we can get lists of onlt the enabled accounts.
2639 (modest_account_mgr_add_account),,
2640 (modest_account_mgr_account_with_display_name_exists):
2641 * src/maemo/modest-msg-edit-window.c: (get_transports):
2642 * src/modest-account-mgr-helpers.c:
2643 (modest_account_mgr_set_first_account_as_default):
2644 * src/modest-init.c: (init_default_account_maybe):
2645 * src/modest-tny-account-store.c: (get_accounts):
2646 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2647 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2648 * tests/check_account-mgr.c: (START_TEST):
2649 Provide the extra parameter, as appropriate.
2651 * src/widgets/modest-account-view.c: (update_account_view):
2652 Do not show disabled accounts (meaning that there is no way to
2653 enable/disable accounts in the UI (the feature is not in our UI
2654 specification), so we can use this internally only to mark unfinished
2655 or temporary account data.
2657 * src/maemo/easysetup/modest-easysetup-wizard.c:
2658 (create_account): Add boolean enable parameter, so we can specify FALSE
2659 to create the temporary account.
2660 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2661 (on_before_next): When finishing, when there is a temporary account, just
2663 Also, use a timeout to delay the showing of the dialog until gconf is likely
2664 to return correct information, due to a maemo gconf bug that is fixed in
2665 osso 1.1, but not yet in Bora.
2666 However, the dialog stays on screen after it is destroyed.
2668 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2669 for invalid data when cancelling. Use a hildon note instead of a dialog
2670 to complain about invalid data. Do not show the account-saved note if the
2671 account is disabled (a temporary account that will not really be saved for use
2674 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2676 * src/modest-account-mgr-helpers.h:
2677 * src/modest-account-mgr-helpers.c:
2678 Added modest_account_mgr_unset_default_account(),
2679 Added modest_account_mgr_set_first_account_as_default().
2681 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2682 If it was the default account, unset the default account name.
2684 * src/maemo/modest-account-view-window.c:
2685 (on_delete_button_clicked): If it was the default account,
2686 set the first remaining account as the default instead.
2688 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2689 a NULL account or a NULL default account, to prevent a crash. This should
2690 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2693 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2695 * src/widgets/modest-recpt-editor.c:
2696 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2697 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2698 TODO comment for this. This fixes the build.
2700 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2701 be the best place for it. This will in future update all auto-update accounts,
2702 rather than just the current/default account, when that gconf key exists.
2703 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2704 if there are no accounts, before calling do_send_receive().
2705 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2707 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2708 * src/maemo/modest-main-window-ui.h:
2709 * src/maemo/modest-main-window.c: (on_connection_changed),
2710 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2711 directly, becaue the signal handler does more.
2713 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2715 * src/modest-account-mgr-helpers.c:
2716 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2717 for the case that the account does not exist.
2719 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2720 (equivalent to the modest account name) rather than the tinymail account name
2721 (equivalent to the modest account title - human readable) to get the account data.
2722 Check for null account data to prevent the crash, and add a TODO comment saying that
2723 this needs fixing because it is using the server account name instead of the account name.
2725 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2728 * src/maemo/modest-account-settings-dialog.c: (show_error),
2730 Use hildon_note_new_information() for informative and error messages,
2731 which seems to be expected for Maemo applications (no documentation that I know of
2732 says this). I am surprised that there is no distinction between info and error
2735 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2737 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2738 it is easy to find where this is used.
2740 * src/maemo/easysetup/modest-easysetup-wizard.c:
2741 (create_page_welcome), (create_page_account_details),
2742 (create_page_user_details), (create_page_complete_easysetup),
2743 (create_page_custom_incoming), (create_page_custom_outgoing),
2744 (create_page_complete_custom):
2745 * src/maemo/modest-account-settings-dialog.c:
2746 (create_page_account_details), (create_page_user_details),
2747 (create_page_incoming), (create_page_outgoing):
2748 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2749 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2750 (modest_connection_specific_smtp_edit_window_init):
2751 * src/maemo/modest-connection-specific-smtp-window.c:
2752 (modest_connection_specific_smtp_window_init):
2753 * src/maemo/modest-signature-editor-dialog.c:
2754 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2755 and scrolling policy as per the Email Application Layout Guide, if I have
2758 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2761 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2762 which were empty, because these vfuncs have been removed from TnyAccountStore.
2763 This fixes the build.
2765 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/modest-main-window.c:
2768 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2769 showing/hiding it. Added TODO because it probably should not be NULL.
2770 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2771 because unnecessary g_warnings() make degugging difficult.
2773 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2775 * src/maemo/modest-msg-edit-window.c:
2776 (modest_msg_edit_window_select_color),
2777 (modest_msg_edit_window_select_background_color): 2 const corrections and
2778 moving 2 #endifs before closing brackets, to fix the build.
2780 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/easysetup/modest-easysetup-wizard.h:
2783 * src/maemo/easysetup/modest-easysetup-wizard.c:
2784 (modest_easysetup_wizard_dialog_finalize),
2785 (on_button_edit_advanced_settings), (create_page_complete_custom),
2786 (on_response), (create_account):
2787 Implement the Advanced Settings edit button, by saving the account information,
2788 for the Advanded Settings dialog to use directly from gconf, and removing it
2789 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2790 Bug #5533 in the projects.maemo.org bugzilla.
2792 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2794 * src/maemo/modest-msg-view-window.c:
2795 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2796 when opening a message window.
2798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2800 * src/maemo/easysetup/modest-easysetup-wizard.c:
2801 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2804 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2805 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2806 gconf settings. I probably added more checks than necessary, but that is safer.
2808 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2809 variable to fix the build, but this seems to be used when it is still NULL.
2811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2813 * src/modest-platform.h:
2814 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2815 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2816 * src/modest-main.c: Implement this function so we can avoid using
2817 maemo-specific API from cross-platform code.
2819 * src/modest-tny-account-store.c:
2820 (get_smtp_specific_transport_account_for_open_connection):
2821 * src/modest-ui-actions.c: (check_for_connection),
2822 (modest_ui_actions_on_item_not_found):
2823 Use modest_platform_connect_and_wait() and put #idefs around other
2824 maemo-specific code, because only maemo currently has a way to
2825 identify connection names.
2827 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2829 * src/modest-tny-account-store.h:
2830 * src/modest-tny-account-store.c:
2831 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2832 the connection-specific SMTP server settings in the configuration.
2834 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2836 * src/maemo/modest-main-window.c: (on_connection_changed),
2838 * src/modest-main.c: (main), (start_ui), (send_mail):
2839 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2840 that is what is intended.
2842 * src/modest-ui-actions.c: (action_send), (action_receive),
2843 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2844 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2845 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2846 SMTP server is used when it is specified.
2848 (modest_ui_actions_on_send_receive):
2849 Check that a connection is open before proceeding.
2850 Receive and then send, instead of vice-versa, as per the specification.
2852 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-mail-operation.c:
2855 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2856 though I guess it should be something other than NULL.
2858 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/easysetup/modest-easysetup-wizard.c:
2861 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2862 combo twice, to avoid an g_warning and to make it visible again.
2863 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2864 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2865 (already intended) dereference when detaching, because we then recreate the menu.
2866 But I am not sure why the warning was happening, and it is possible that this is a memory
2869 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2871 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2872 and uri_parse_mailto() utility functions.
2873 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2875 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2877 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2879 * src/dbus_api/modest-dbus-api.h:
2880 * src/dbus_api/modest-dbus-callbacks.c:
2881 Use an idle callback to execute the modest code in the application's own thread.
2882 Remove the helloworld example method.
2883 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2884 parsed, and the open-message method is not implemented because this is not yet implemented in
2886 * libmodest-dbus-client/libmodest-dbus-client.c:
2887 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2888 (libmodest_dbus_client_open_message):
2889 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2891 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2892 body without crashing.
2894 * tests/dbus_api/Makefile.am:
2895 * tests/dbus_api/test_mail_to.c:
2896 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2898 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2900 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2901 Added file to fix the build. Sorry.
2903 * src/dbus_api/Makefile.am:
2904 * src/dbus_api/modest-dbus-api.h:
2905 * src/dbus_api/modest-dbus-callbacks.h:
2906 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2907 (modest_dbus_req_handler):
2908 Put constants in a separate header so it can be reused by the
2909 client library, without duplication
2911 * libmodest-dbus-client/Makefile.am:
2912 * libmodest-dbus-client/libmodest-dbus-client.c:
2913 (libmodest_dbus_client_call_helloworld),
2914 (libmodfest_dbus_client_send_mail),
2915 (libmodfest_dbus_client_mailto),
2916 (libmodfest_dbus_client_open_message):
2917 * libmodest-dbus-client/libmodest-dbus-client.h:
2918 (Partly) Implement a send_mail D-Bus method.
2920 * tests/dbus_api/Makefile.am:
2921 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2922 the send_email D-Bus method.
2924 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2928 * libmodest-dbus-client/Makefile.am:
2929 * libmodest-dbus-client/libmodest-dbus-client.c:
2930 * libmodest-dbus-client/libmodest-dbus-client.h:
2931 * tests/dbus_api/Makefile.am:
2932 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2933 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2935 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2937 * src/maemo/easysetup/modest-easysetup-wizard.c:
2938 (create_page_account_details):
2939 * src/maemo/modest-account-settings-dialog.c:
2940 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2941 widgets, because this might not be the default in future versions of the Maemo GTK+.
2942 However, I can not not get capitalization to work even in a simple test case.
2944 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2946 * src/maemo/easysetup/modest-easysetup-wizard.c:
2947 (create_page_custom_incoming), (create_page_custom_outgoing):
2948 * src/maemo/modest-account-settings-dialog.c:
2949 (create_page_account_details), (create_page_incoming),
2950 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2951 instead of using gtk_check_button_with_label(), so they are aligned like the other
2952 widgets, as per the UI spec.
2954 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2956 * src/maemo/easysetup/modest-easysetup-wizard.c:
2957 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2958 * src/widgets/modest-validating-entry.c:
2959 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2960 Modest prefix instead of an EasySetup prefix.
2962 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2964 * src/widgets/modest-validating-entry.h:
2965 * src/widgets/modest-validating-entry.c: (on_insert_text),
2966 Added easysetup_validating_entry_set_max_func(), used to set a callback
2967 to call when the max number of characters is reached. GtkEntry has a max-length
2968 already but is silent about it.
2970 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2971 (create_page_account_details), (create_page_user_details),
2973 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2974 (create_page_account_details), (create_page_user_details),
2975 (create_page_outgoing):
2976 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2977 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2978 the UI spec, when the user tries to enter more than the max number of characters.
2980 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/easysetup/modest-easysetup-wizard.c:
2983 (create_page_user_details), (create_page_custom_incoming),
2984 (create_page_custom_outgoing):
2985 * src/maemo/modest-account-settings-dialog.c:
2986 (create_page_user_details), (create_page_incoming),
2987 (create_page_outgoing):
2988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2989 (modest_connection_specific_smtp_edit_window_init):
2990 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2991 not appropriate. Bad Maemo-specific defaults!.
2993 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2995 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2996 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2997 (modest_signature_editor_dialog_set_settings):
2998 Disable the label and textview when the checkbox is disabled, and use the
2999 specified (UI spec) default signature text.
3001 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3003 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3004 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3006 * src/modest-defs.h:
3007 * src/modest-account-mgr-helpers.h:
3008 * src/modest-account-mgr-helpers.c:
3009 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3011 * src/maemo/Makefile.am:
3012 * src/maemo/modest-signature-editor-dialog.c:
3013 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3016 * src/maemo/modest-account-settings-dialog.h:
3017 * src/maemo/modest-account-settings-dialog.c:
3018 (modest_account_settings_dialog_finalize), (on_button_signature),
3019 (save_configuration): Use the new dialog when the Edit button is pressed, and
3020 save the changes if necessary, as per the UI spec.
3022 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3024 * src/maemo/Makefile.am:
3025 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3026 based on maemo-develoers email from Dirk.
3028 * src/maemo/easysetup/modest-easysetup-wizard.c:
3029 (create_page_welcome), (create_page_account_details),
3030 (create_page_user_details), (create_page_complete_easysetup),
3031 (create_page_custom_incoming), (create_page_custom_outgoing),
3032 (create_page_complete_custom),
3033 (modest_easysetup_wizard_dialog_init):
3034 * src/maemo/modest-account-settings-dialog.c:
3035 (create_page_account_details), (create_page_user_details),
3036 (create_page_incoming), (create_page_outgoing),
3037 (modest_account_settings_dialog_init):
3038 * src/maemo/modest-connection-specific-smtp-window.c:
3039 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3043 * src/maemo/easysetup/modest-easysetup-wizard.c:
3044 (create_page_account_details), (create_page_custom_outgoing),
3045 (create_page_complete_custom):
3046 * src/maemo/modest-account-settings-dialog.c:
3047 (create_page_user_details), (create_page_incoming),
3048 (create_page_outgoing):
3049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3050 (modest_connection_specific_smtp_edit_window_init):
3051 Use the correct (UI spec) port min/max, and use horizontal separators,
3054 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3056 * src/maemo/easysetup/modest-easysetup-wizard.c:
3057 (set_default_custom_servernames):
3058 * src/maemo/modest-account-settings-dialog.c:
3059 (create_page_incoming), (on_combo_outgoing_security_changed),
3060 (on_combo_incoming_security_changed), (create_page_outgoing),
3061 (modest_account_settings_dialog_set_account_name),
3062 (save_configuration):
3063 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3064 (on_combo_security_changed),
3065 (modest_connection_specific_smtp_edit_window_init),
3066 (modest_connection_specific_smtp_edit_window_set_connection),
3067 (modest_connection_specific_smtp_edit_window_get_settings):
3068 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3071 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3074 * src/maemo/easysetup/modest-easysetup-wizard.c:
3075 (create_page_custom_outgoing), (create_page_complete_custom):
3076 * src/maemo/modest-account-settings-dialog.c:
3077 (create_page_user_details), (create_page_outgoing):
3078 * src/maemo/modest-account-view-window.c: (button_box_new):
3079 Use changed logical IDs as per the most recent UI spec:
3080 mcen_bd_emailsetup_edit -> mcen_bd_edit
3081 mcen_bd_emailsetup_delete -> mcen_bd_delete
3082 mcen_bd_emailsetup_close -> mcen_bd_close
3084 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3088 * src/dbus_api/Makefile.am:
3089 * src/dbus_api/modest-dbus-callbacks.c:
3090 * src/dbus_api/modest-dbus-callbacks.h:
3091 * src/maemo/modest-platform.c: (modest_platform_init):
3092 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3094 * tests/Makefile.am:
3095 * tests/dbus_api/Makefile.am:
3096 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3098 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3100 * src/maemo/modest-account-settings-dialog.c:
3101 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3102 Removed unnecessary includes.
3104 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/easysetup/modest-easysetup-wizard.c:
3107 * src/maemo/modest-account-settings-dialog.c:
3108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3109 * src/widgets/Makefile.am:
3110 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3111 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3112 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3113 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3114 * src/widgets/modest-secureauth-combo-box.c:
3115 * src/widgets/modest-secureauth-combo-box.h:
3116 * src/widgets/modest-serversecurity-combo-box.c:
3117 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3118 made the GObject names more consistent with the rest of the Modest code.
3120 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/easysetup/Makefile.am:
3123 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3124 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3125 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3126 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3127 * src/maemo/easysetup/modest-easysetup-wizard.c:
3128 * src/maemo/easysetup/modest-validating-entry.c:
3129 * src/maemo/easysetup/modest-validating-entry.h:
3130 * src/maemo/modest-account-settings-dialog.c:
3131 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3132 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3133 widgets/ because they are used outside of easysetup too. After checking in,
3134 svn will allow me to rename them too.
3136 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3138 * src/gnome/modest-msg-edit-window.c:
3139 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3140 linker error, to fix the build on the GNOME platform.
3141 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3142 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3143 ifdefed out to avoid a warning.
3145 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3147 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3148 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3149 some alternative for GTK+ 2.6.
3151 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3155 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3156 specified for EmailAccountsDialog in UI spec.
3158 * src/maemo/easysetup/modest-easysetup-wizard.c:
3159 * src/maemo/easysetup/modest-easysetup-wizard.h:
3160 * src/maemo/modest-account-settings-dialog.c:
3161 * src/maemo/modest-account-settings-dialog.h:
3162 Reuse a member window widget for the connection-specific SMTP server accounts,
3163 so we can tell it to create/save the accounts only if we actually save changes.
3165 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3167 (modest_connection_specific_smtp_edit_window_get_settings):
3168 Return a struct instance for temporarily remembering the entered data.
3170 * src/maemo/modest-connection-specific-smtp-window.h:
3171 * src/maemo/modest-connection-specific-smtp-window.c:
3172 (modest_connection_specific_smtp_window_finalize),
3173 (modest_connection_specific_smtp_window_fill_with_connections),
3175 (modest_connection_specific_smtp_window_save_server_accounts),
3176 (update_model_server_names): Do not actually save data until asked,
3177 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3179 (on_selection_changed),
3180 (modest_connection_specific_smtp_window_init): Disable the edit
3181 button when nothing is selected.
3183 * src/modest-account-mgr-helpers.c:
3184 * src/modest-account-mgr-helpers.h:
3185 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3188 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3190 * src/modest-account-mgr-helpers.h:
3191 * src/modest-account-mgr-helpers.c:
3192 (modest_account_mgr_get_unused_account_name),
3193 (modest_account_mgr_get_unused_account_display_name): Added these
3194 utility functions, to avoid code duplication.
3196 * src/maemo/easysetup/modest-easysetup-wizard.c:
3197 (create_page_account_details), (create_account):
3198 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3199 (on_combo_security_changed),
3200 (modest_connection_specific_smtp_edit_window_init),
3201 (modest_connection_specific_smtp_edit_window_save_settings):
3202 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3203 * src/maemo/modest-connection-specific-smtp-window.c:
3204 (modest_connection_specific_smtp_window_finalize),
3205 (modest_connection_specific_smtp_window_fill_with_connections),
3206 (on_button_edit), (modest_connection_specific_smtp_window_init):
3207 * src/maemo/modest-connection-specific-smtp-window.h:
3208 Implementing saving of connection-specific server accounts.
3210 But I need to refactor this so we can save the data for each
3211 possible connection-specific account and only actually create the server accounts
3212 when the easysetup finished, or the OK button is pressed on the account settings
3215 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3218 (on_combo_security_changed):
3219 (modest_connection_specific_smtp_edit_window_init):
3220 Auto-fill the port number as in the account settings.
3222 (modest_connection_specific_smtp_edit_window_set_connection):
3223 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3224 * src/maemo/modest-connection-specific-smtp-window.c:
3225 (fill_with_connections), (on_button_edit),
3226 (modest_connection_specific_smtp_window_init):
3227 Turn the edit window into a dialog to simplify the code, and
3228 set a WM hint as in a GtkDialog, because only a popup can be on top of
3229 another window in Maemo, and popups usually have no WM decoration.
3231 * src/modest-defs.h:
3232 * src/modest-account-mgr-helpers.c:
3233 (modest_account_mgr_set_connection_specific_smtp),
3234 (modest_account_mgr_remove_connection_specific_smtp),
3235 (modest_account_mgr_get_connection_specific_smtp):
3236 * src/modest-account-mgr-helpers.h: Some functions to write the
3237 connection-specific SMTP server information. Not yet used.
3240 * src/widgets/modest-folder-view.c: (text_cell_data):
3241 Fix a warning about an uninitialized variable.
3242 (on_configuration_key_changed): Put an #ifdef around the use
3243 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3245 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3247 * src/maemo/modest-account-settings-dialog.h:
3248 * src/maemo/modest-account-settings-dialog.c:
3249 Added connect_for_modified() utility function to mark the new modified boolean.
3251 (create_page_account_details), (create_page_user_details),
3252 (create_page_incoming), (create_page_outgoing), (on_response),
3253 (modest_account_settings_dialog_init),
3254 (modest_account_settings_dialog_set_account_name):
3255 Only warn about unsaved changes when there are actually unsaved changes.
3257 * src/modest-account-mgr-helpers.c:
3258 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3259 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3260 to get the data from there in future.
3262 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3264 * src/modest-defs.h:
3266 * src/modest-account-mgr-helpers.h:
3267 * src/modest-account-mgr-helpers.c:
3268 Store the security account setting in a single conf key instead of using
3269 the options list, so that the list is left for just the to-be-removed camel hack,
3270 and because gconf_client_set_list() is failing for some reason.
3272 * src/modest-account-mgr.c:
3273 (modest_account_mgr_add_server_account):
3274 * src/maemo/modest-account-settings-dialog.c:
3275 (modest_account_settings_dialog_set_account_name),
3276 (save_configuration): Use the renamed functions.
3279 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3281 * src/widgets/Makefile.am:
3282 * src/widgets/modest-limit-retrieve-combo-box.c:
3283 * src/widgets/modest-limit-retrieve-combo-box.h:
3284 * src/widgets/modest-retrieve-combo-box.c:
3285 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3286 the account settings dialog.
3288 * src/modest-defs.h:
3289 * src/modest-account-mgr-helpers.h:
3290 * src/modest-account-mgr-helpers.c:
3291 (modest_server_account_get_option_secure_auth),
3292 (modest_server_account_set_option_secure_auth):
3293 * src/modest-account-mgr.c:
3294 (modest_account_mgr_add_server_account):
3295 Use the existing AUTH_MECH conf key for the secure-auth setting,
3296 instead of putting it in the list options, because this was actually used already.
3298 * src/maemo/modest-account-settings-dialog.c:
3299 (create_page_account_details),
3300 (modest_account_settings_dialog_set_account_name),
3301 (save_configuration):
3302 * src/maemo/modest-account-settings-dialog.h:
3303 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3304 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3306 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3309 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3310 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3312 * src/modest-defs.h:
3313 * src/maemo/modest-account-settings-dialog.c:
3314 (create_page_incoming), (on_combo_outgoing_security_changed),
3315 (on_combo_incoming_security_changed), (create_page_outgoing),
3316 (modest_account_settings_dialog_set_account_name),
3317 (save_configuration): Load/Save the port number, and change it when the
3318 security combo changes, to suitable defaults.
3320 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3322 * src/modest-account-mgr.c:
3323 (modest_account_mgr_add_server_account): Set the security and secure-auth
3324 options, and add a comment saying that the other camel-specific options should be
3327 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3329 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3331 * src/modest-tny-account-store.c: (account_list_free),
3332 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3333 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3336 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3338 * src/modest-protocol-info.c:
3339 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3340 is required by our UI spec. Maybe something in our implementation will use this eventually.
3341 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3342 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3343 instead of the previous 0 placeholder.
3345 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3346 secure-auth settings.
3347 * src/modest-account-mgr-helpers.h:
3348 * src/modest-account-mgr-helpers.c:
3349 (modest_server_account_data_get_option_secure_auth),
3350 (modest_server_account_set_option_secure_auth),
3351 (modest_server_account_data_get_option_security),
3352 (modest_server_account_set_option_security): Added this API for getting and setting the security
3353 and secure-auth settings.
3355 * src/maemo/modest-account-settings-dialog.h:
3356 * src/maemo/modest-account-settings-dialog.c:
3357 (modest_account_settings_dialog_finalize), (check_data),
3358 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3359 about changing titles.
3360 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3361 (save_configuration): Save the security and secure-auth settings.
3363 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3364 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3366 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3368 * src/modest-defs.h:
3369 * src/modest-account-mgr.c:
3370 (modest_account_mgr_add_server_account):
3371 Added and used defines for the options key and value pair strings,
3372 that are used so far, though they do not seem to correspond to anything in our
3373 UI specs or ModestProtocol enum.
3375 * src/modest-account-mgr-helpers.h:
3376 * src/modest-account-mgr-helpers.c:
3377 (compare_option_strings_for_name),
3378 (modest_server_account_data_get_option_value),
3379 (modest_server_account_data_get_option_bool),
3380 (modest_account_mgr_get_server_account_option):
3381 Added helper functions for parsing the options GSList.
3383 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3386 display name is based on the supplied account name.
3387 * src/modest-account-mgr.c:
3388 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3389 with an inefficient, but good-enough, implementation.
3391 * src/maemo/easysetup/modest-easysetup-wizard.c:
3392 (create_page_account_details), (on_before_next), (create_account):
3393 Check for existing display names rather than (non-user-visible) account names, and just
3394 create and set a unique account name at the end.
3396 * src/maemo/modest-account-settings-dialog.c:
3397 (modest_account_settings_dialog_init),
3398 (modest_account_settings_dialog_set_account_name),
3399 (create_page_incoming): Show the display name, instead of the account name.
3400 (on_response): Do some (not all) extra checks, as in the UI spec.
3401 (save_configuration): Save the display name if it was changed.
3403 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3405 * po/en_GB.po: Added needed logical ID and translation.
3406 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3407 (init_view): Made the is-default column clicking work.
3409 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/easysetup/Makefile.am:
3413 * src/maemo/easysetup/modest-easysetup-wizard.c:
3414 (modest_easysetup_wizard_dialog_init):
3415 * src/maemo/easysetup/provider-data-test.keyfile:
3416 * src/maemo/easysetup/provider-data.keyfile:
3417 Moved the provider data file to the new modest-providers-data package and used it from there.
3419 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3421 * src/modest-local-folder-info.c:
3422 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3423 N_() was already used on the static strings, but this just marks it for translation without
3424 using the translation.
3426 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3428 * src/maemo/modest-account-settings-dialog.c:
3429 (create_page_incoming),
3430 (modest_account_settings_dialog_set_account_name):
3431 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3432 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3433 I will do this if nobody else gets there first.
3435 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3437 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3438 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3439 save the security stuff.
3441 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3443 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3444 Set the email address and user fullname, which I now see must be
3447 * src/maemo/modest-account-settings-dialog.h:
3448 * src/maemo/modest-account-settings-dialog.c:
3450 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3451 leave-on-server and authentication.
3452 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3455 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3458 * src/maemo/modest-account-settings-dialog.c:
3459 * src/maemo/modest-account-settings-dialog.h:
3460 Most (but not all) of the widgets are now present as specified by the UI spec.
3461 No changes are yet saved, and some details are not properly shown yet.
3463 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3465 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3467 * src/maemo/Makefile.am:
3468 * src/maemo/modest-account-settings-dialog.c:
3469 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3470 an existing account. Doesn't do much yet.
3472 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3473 Open the accounts settings dialog when Edit is clicked.
3475 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3477 * src/maemo/easysetup/Makefile.am:
3478 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 (modest_easysetup_wizard_dialog_init):
3482 Try to get the source directory from the build system,
3483 instead of hard-coding "./" into the source code, when opening our local
3484 copies of the configuration files.
3485 But this still fails when opening the wizard from the Accounts window,
3486 maybe because the working directory seems to change at runtime.
3487 So the wizard will fail the second time unless you copy the files into their
3488 proper locations - see the stdout warnings for the paths.
3490 (create_page_account_details),(on_before_next):
3491 Check for existing non-server accounts instead of server accounts,
3492 so the default account name is useful again, and to prevent trying to
3495 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3496 Show the wizard when New is clicked.
3498 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3499 (init_view): Show the column headers, and show the columns that are
3500 specified in the UI specs. However, something in Maemo's GTK+ prevents
3501 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3502 change the default account. This is despite unsetting the special properties.
3504 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3506 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3507 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3508 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3509 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3510 to make that clearer.
3511 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3513 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3515 * src/maemo/modest-account-view-window.c:
3516 (modest_account_view_window_init),
3517 (modest_account_view_window_new):
3518 Use the same buttons as specified in the
3519 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3520 the existing widgets, which never had a chance of working.
3521 Put the ModestAccountView treeview in a scrolled window.
3522 Do not repeat the initialization in both _init() and _new().
3524 * src/widgets/modest-account-view.c: (update_account_view):
3525 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3526 this widget and window shows no accounts.
3528 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3530 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3532 * src/maemo/easysetup/modest-easysetup-wizard.c:
3533 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3534 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3535 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3538 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3539 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3540 accounts exist yet, as in the UI spec.
3542 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3544 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3546 * src/maemo/Makefile.am:
3547 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3549 New window for editing connection-specific smtp details.
3550 Not fully implemented.
3552 * src/maemo/modest-connection-specific-smtp-window.c:
3553 (modest_connection_specific_smtp_window_finalize) :
3554 unref the tree model.
3555 (on_button_edit): Show the edit window.
3557 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3559 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3562 * src/maemo/Makefile.am:
3563 * src/maemo/modest-connection-specific-smtp-window.c:
3564 * src/maemo/modest-connection-specific-smtp-window.h:
3565 New window for showing the list of connections, for connection-specific
3566 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3567 * src/maemo/easysetup/modest-easysetup-wizard.c:
3568 (create_page_custom_outgoing): Show the new window when the button is clicked.
3570 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3572 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3573 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3574 * src/maemo/modest-msg-edit-window.c:
3575 (modest_msg_edit_window_insert_image):
3576 * src/modest-conf.c: (modest_conf_key_escape):
3577 * src/modest-mail-operation.c:
3578 (modest_mail_operation_send_new_mail):
3579 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3580 (modest_ui_actions_on_new_account):
3581 * src/widgets/modest-attachment-view.c: (update_filename_request):
3582 * src/widgets/modest-mail-header-view.c:
3583 Corrected warnings that were breaking the build, by commenting out unused variables,
3584 and a function, and by including a header.
3586 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3588 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3589 so we can #ifdef around platform-specific code when necessary.
3590 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3591 to allow this to build for the GNOME platform too.
3593 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3595 * src/maemo/easysetup/modest-easysetup-wizard.c:
3596 Added util_increment_name() and used it in create_page_account_details()
3597 to make sure that the default account name is always a new name.
3599 (modest_easysetup_wizard_dialog_init),
3600 (set_default_custom_servernames): Some minor memory management fixes.
3602 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3606 * src/modest-runtime.c: (init_i18n): Restored the translation
3607 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3608 are defined in config.h, and the translations are installed.
3610 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3611 is defined for translation.
3613 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3615 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3617 * src/maemo/easysetup/modest-easysetup-wizard.c:
3618 (modest_easysetup_wizard_dialog_init):
3619 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3620 Use realistic paths (though they should use $prefix generically) to the
3621 mcc_mapping and provider-data.keyfile files which might work when they
3622 are installed by the future version of the operator-wizard package,
3623 and then fallback to paths in our source code, with an explanatory
3626 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3630 * src/maemo/Makefile.am:
3631 * src/maemo/easysetup/: Added files from the previously-exernal
3632 osso-modest-easysetup.
3633 * src/maemo/modest-main-window-ui.h:
3634 * src/modest-ui-actions.c:
3635 * src/modest-ui-actions.h:
3636 Added modest_ui_actions_on_new_account() as a signal handler for the
3637 New Account menu item. It shows the easysetup wizard.
3638 * po/en_GB.po: Added additional needed logical IDs and translations.