1 2007-07-24 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
4 Remove the hacky send/receive that didn't work, and instead
5 refilter the treemodel to make the deleted email really vanish from
6 the UI (though the delete-from-menu code does has commented out
7 the code that does that). This fixes projects.maemo.org bug
10 2007-07-24 Murray Cumming <murrayc@murrayc.com>
12 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
13 Try a couple of tricks to force the treeview to update (
14 poke the folder, and do a send/receive refresh), but the deleted
15 email still appears with a strike-through instead of really being
18 2007-07-23 Murray Cumming <murrayc@murrayc.com>
20 * src/dbus_api/modest-dbus-callbacks.c:
21 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
22 because their ID is not human-readable (see the comment about
23 improvements needed to the osso-email-interface API) and
24 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
26 2007-07-23 Murray Cumming <murrayc@murrayc.com>
28 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
29 (add_folders_to_list), (on_dbus_method_get_folders),
30 (modest_dbus_req_filter):
31 * src/maemo/modest-maemo-utils.c:
32 (on_camel_account_get_supported_secure_authentication):
33 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
34 (on_header_view_focus_in):
35 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
36 * src/modest-formatter.c: (modest_formatter_create_body_part):
37 * src/modest-mail-operation.c: (recurse_folders),
38 (update_account_thread), (get_msgs_full_thread),
39 (modest_mail_operation_get_msgs_full),
40 (modest_mail_operation_xfer_msgs):
41 * src/modest-search.c: (search_mime_part_and_child_parts),
42 (modest_search_account), (modest_search_all_accounts):
43 * src/modest-tny-account.c:
44 (modest_tny_account_get_special_folder), (recurse_folders):
45 * src/modest-tny-local-folders-account.c:
46 (modest_tny_local_folders_account_query_passes):
47 * src/modest-tny-msg.c: (copy_mime_part),
48 (modest_tny_msg_find_body_part_from_mime_part):
49 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
50 (modest_tny_send_queue_try_to_send):
51 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
52 (_modest_ui_actions_open), (download_uncached_messages),
53 (reply_forward), (modest_ui_actions_on_copy),
54 (modest_ui_actions_on_details), (has_retrieved_msgs),
55 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
57 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
58 (_selected_msg_marked_as), (_msg_download_completed),
59 (_selected_msg_sent_in_progress):
60 * src/widgets/modest-attachments-view.c:
61 (modest_attachments_view_set_message):
62 * src/widgets/modest-msg-view.c: (find_cid_image):
63 * tests/check_folder-transfer.c: (find_folders):
64 * tests/check_update-account.c: (func):
65 * tests/dbus_api/test_get_folders.c: (main):
66 Checked all uses of tny_iterator_get_current(), making sure
67 that the object is unreferenced (3 or 4 places did not),
68 and adding checks for NULL.
70 2007-07-23 Murray Cumming <murrayc@murrayc.com>
72 * src/dbus_api/modest-dbus-callbacks.c:
73 (on_idle_open_default_inbox): Make sure that the application UI is
75 * src/maemo/easysetup/modest-easysetup-wizard.c:
76 (on_entry_invalid_character): Show the word whitespace instead
77 of (null) in the banner when whitespace was entered.
78 (show_error): Add a comment that this does not work in
79 Maemo Bora, though we do not know why.
81 2007-07-23 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-tny-account.c:
84 (modest_tny_account_get_special_folder): Use an if instead of
85 an assert for when the parent account name is NULL, because this
86 might be causing a crash in projects.maemo.org bug 63192.
87 * src/modest-mail-operation.c:
88 (modest_mail_operation_send_new_mail_cb),
89 (modest_mail_operation_remove_folder): unref the folder that is
90 returned from modest_tny_account_get_special_folder().
92 2007-07-23 Murray Cumming <murrayc@murrayc.com>
94 * src/modest-ui-actions.c:
95 (modest_ui_actions_on_password_requested):
96 Show mail_ib_login_cancelled info banner when the user cancels
97 the protected password dialog, to fix projects.maemo.org
100 2007-07-23 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-account-settings-dialog.c:
103 (create_page_outgoing): Put this page in a GtkScrolledWindow,
104 matching the UI mock-up in the UI spec, and allowing access
105 to all widgets even when the on-screen keyboard is active.
107 2007-07-23 Murray Cumming <murrayc@murrayc.com>
109 Reverted this previous commit from Johannes,
110 because the scrollbars are always visible and because
111 I think we only need it on onepage of the account
112 settings, not the account wizard.
113 (I wrote the wrong instructions in the bug.)
115 * src/maemo/easysetup/modest-easysetup-wizard.c:
116 Added scrollbars to account wizard dialog.
117 Fixed projects.maemo.org NB #62744
119 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
121 * src/maemo/easysetup/modest-easysetup-wizard.c:
122 (create_page_user_details):
123 Use auto-cap for name (projects.maemo.org NB#63716)
124 * src/widgets/modest-account-view.c: (on_account_busy_changed):
126 2007-07-22 Armin Burgmeier <armin@openismus.com>
128 * src/maemo/modest-ui-actions.c: Use current account instead of
129 default account for creating viewer windows, so that the viewer
130 window knows to which account the viewed message belongs.
132 * src/maemo/modest-msg-view-window.c: Destroy the window when the
133 corresponding account is deleted. This fixes projects.maemo.org bug
136 2007-07-18 Armin Burgmeier <armin@openismus.com>
138 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
139 the dialog close after entering an invalid port number and clicking
140 OK. This fixes projects.maemo.org bug NB#63602.
142 2007-07-18 Armin Burgmeier <armin@openismus.com>
144 * src/modest-tny-account-store.c:
145 (get_server_accounts): Set parent modest account name for each
146 connection-specific transport account so that special folders of such
147 an account can be looked up. This fixes a crash when changing account
148 settings. This might also be related to projects.maemo.org bug
151 2007-07-16 Armin Burgmeier <armin@openismus.com>
153 * src/modest-ui-actions.c: Added a button to create a folder to the
154 move-to dialog. This fixes projects.maemo.org bug NB#.
156 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
158 * src/maemo/easysetup/modest-easysetup-wizard.c:
159 Added scrollbars to account wizard dialog.
160 Fixed projects.maemo.org NB #62744
162 2007-07-16 Murray Cumming <murrayc@murrayc.com>
164 * src/widgets/modest-msg-view.h:
165 * src/widgets/modest-msg-view.c:
166 Added modest_msg_view_get_message_is_empty() but this needs
168 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
169 Check if there is any text in the message yet.
170 But this needs to be implemented properly.
171 (modest_msg_edit_window_toggle_find_toolbar):
172 * src/maemo/modest-msg-view-window.c:
173 (modest_msg_view_window_toggle_find_toolbar):
174 Show a banner warning if there is no text to search, when
175 trying to start a search. This partially fixes
176 projects.maemo.org bug NB#62350.
178 2007-07-13 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-mail-operation.c: (update_account_thread):
181 Initialized num_new_headers to fix the build.
183 2007-07-13 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
186 Ignore modest accounts whose server accounts don't exist in gconf.
187 This prevents us trying to create TnyAccount instances for those
188 server accounts when the server account has been removed from gconf,
189 but the parent modest account has not yet been removed from modest.
190 I don't know why this is only noticeable now. It was probably just
191 a harmeless g_warning() anyway.
193 2007-07-13 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
196 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
198 2007-07-12 Armin Burgmeier <armin@openismus.com>
200 * src/maemo/modest-main-window.c: Make default account appear bold
201 in view, tools/send & receive and toolbar/send & receive SCM menus.
202 This fixes projects.maemo.org bug NB#59010.
204 2007-07-12 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
207 Add a short-cut, by checking if the folder store is an account.
208 This ensures that the Sort menu item and toolbar is dimmed for
209 the local-folders account root item, fixing
210 projects.maemo.org bug NB#62545.
212 2007-07-12 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account-store.c: (get_password):
215 Show the password dialog (via the signal) only in the mainloop, via
216 an idle handler that we wait for. This could theoretically prevent
217 hangs, though I worry that it could introduce some too.
219 2007-07-12 Murray Cumming <murrayc@murrayc.com>
221 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
222 * src/maemo/modest-platform.c:
223 (modest_platform_connect_and_wait):
224 Take a TnyAccount* parameter and try to set it to online
225 (a TnyCamel-only API), because tinymail sets accounts to offline
226 when the user cancels a password dialog, and doesn't ask again until
227 it has been set to online.
228 However, this is commented out because it causes a hang now.
230 (modest_platform_connect_and_wait_if_network_account):
231 * src/modest-mail-operation.c:
232 (modest_mail_operation_update_account):
233 * src/modest-platform.h:
234 * src/modest-ui-actions.c: (_modest_ui_actions_open),
235 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
237 2007-07-12 Armin Burgmeier <armin@openismus.com>
239 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
241 * src/modest-mail-operation.c:
242 * src/modest-ui-actions.c: Check for already existing folder before
243 querying the server, show error message from camel if the request
244 still fails. This fixes projects.maemo.org bug NB#58701.
246 2007-07-12 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-tny-account-store.h:
249 * src/modest-tny-account-store.c:
250 Added modest_tny_account_store_forget_password_in_memory(),
251 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
252 when creating a new account, so that new passwords will be used, instead of
253 us thinking that it's a second request as a result of a failed password again.
255 2007-07-12 Murray Cumming <murrayc@murrayc.com>
257 * src/dbus_api/modest-dbus-callbacks.c:
258 (on_idle_open_message): If the message is in drafts then open it
259 in an edit window instead of a view window. This fixes
260 projects.maemo.org bug NB#63005.
262 2007-07-12 Murray Cumming <murrayc@murrayc.com>
264 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
265 Avoided a harmless g_warning().
267 2007-07-12 Murray Cumming <murrayc@murrayc.com>
269 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
270 Pass the modest account name, not the TnyAccount display name to
271 modest_msg_view_window_new() so that the reply feature works,
272 fixing projects.maemo.org bug NB#62892.
274 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
275 (modest_msg_view_window_new_with_header_model):
276 * src/maemo/modest-msg-view-window.c:
277 (modest_msg_view_window_new_with_header_model),
278 (modest_msg_view_window_new):
279 * src/modest-ui-actions.c: (reply_forward):
280 * src/widgets/modest-msg-view-window.h:
281 * src/widgets/modest-window.c: (modest_window_set_active_account):
282 Rename an account parameter to modest_account_name to make this clearer.
284 2007-07-11 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-ui-actions.h:
287 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
288 modest_do_message_delete().
289 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
290 Call modest_do_message_delete(), hoping that this would cause messages
291 to be really deleted from search instead of just marked with strike through.
292 Does not seem to help.
294 2007-07-11 Armin Burgmeier <armin@openismus.com>
296 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
297 priv->reselect to FALSE prior to calling
298 modest_folder_view_select_first_inbox_or_local() to prevent endless
299 recursion and thus a crash on startup.
301 2007-07-11 Armin Burgmeier <armin@openismus.com>
303 * src/maemo/modest-account-settings-dialog.h: Include
304 <gtk/gtknotebook.h> to fix the build (at least for me).
306 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
307 Use "New FolderN" as default suggested name if "New folder" already
308 exists, with N being the first free number, though never exceed "New
309 folder99" in which case we just fall back to "New Folder" even though
310 it already exists. This fixes projects.maemo.org bug NB#58663.
312 2007-07-11 Murray Cumming <murrayc@murrayc.com>
314 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
315 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
316 projects.maemo.org bug NB#62778.
318 2007-07-11 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
321 Ignore the wrong (for now) secure-smtp setting in the presets -
322 just default to requiring secure authentication for SMTP, because
325 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
327 * src/widgets/modest-folder-view.c: (filter_row)
328 Do not show drafts folder (see UI specs)
330 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
332 * src/modest-ui-actions.c:
333 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
334 place and also not necessary.
336 * src/widgets/modest-folder-view.c: (filter_row)
337 Guess folder type and hide Sent & Outbox if necessary.
338 Fixed project.maemo.org NB#57328
340 2007-07-11 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-ui-actions.h:
343 * src/modest-ui-actions.c:
344 (modest_ui_actions_on_delete_message):
345 Move some code into a new
346 modest_ui_actions_refresh_message_window_after_delete()
347 function so we can use it from elsewhere.
349 * src/dbus_api/modest-dbus-callbacks.c:
350 (on_idle_delete_message), (on_delete_message): Used an idle
351 handler, as we do for the other D-Bus method handlers.
352 Call modest_ui_actions_refresh_message_window_after_delete()
353 if the deleted message was open in a window. This fixed
354 projects.maemo.org bug NB#62862.
356 2007-07-11 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-main.c: (main): Only show the UI at the start if
359 the showui command line option was given. For instance,
360 run-standalone src/modest showui
361 Otherwise, we wait for the top_application D-Bus method to
362 be sent by hildon-desktop when the application is selected
364 This allows us to run without a UI when osso-global-search
365 uses our D-Bus methods.
367 2007-07-11 Murray Cumming <murrayc@murrayc.com>
369 * src/dbus_api/modest-dbus-api.h: Added a define for a
370 top-application D-Bus method.
371 * src/dbus_api/modest-dbus-callbacks.c:
372 (on_top_application),
373 (modest_dbus_req_handler): Handle the top-application D-Bus
374 method, which might be an undocumented D-Bus signal sent by
375 hildon-desktop when it starts the application from the menu.
376 But I am not sure and I need to test it on the device, because
377 my scratchbox does not have the application in the menu now.
378 This method shows the main window, so that it can be invisible
379 when started, for instance, just for email searching from
382 * src/maemo/modest-main-window.c: (restore_settings),
383 (modest_main_window_new): Do not show the window immediately
384 upon creation. We show it later.
385 * src/modest-widget-memory.c: (save_settings_paned):
386 Try (unsuccessfully) to avoid saving the paned position when
387 it is not even visible.
388 (restore_settings_paned): Do not allow a silly paned position.
389 This seems necessary when not showing the window at first.
391 * tests/dbus_api/Makefile.am:
392 * tests/dbus_api/test_top_application.c: (main): Test for the
395 2007-07-10 Murray Cumming <murrayc@murrayc.com>
397 * src/modest-ui-dimming-rules.c:
398 (modest_ui_dimming_rules_on_new_msg),
399 (modest_ui_dimming_rules_on_reply_msg),
400 (modest_ui_dimming_rules_on_delete_msg),
401 (modest_ui_dimming_rules_on_details),
402 (modest_ui_dimming_rules_on_view_window_move_to),
403 (modest_ui_dimming_rules_on_view_previous),
404 (modest_ui_dimming_rules_on_view_next),
405 (_invalid_folder_for_purge): Added checks before
406 casting the window. This looks like an actual
407 logic error in _invalid_folder_for_purge(), because it
408 tries to use a ModestMainWindow as a message window.
410 2007-07-10 Murray Cumming <murrayc@murrayc.com>
412 * src/maemo/modest-account-settings-dialog.c:
413 (show_error): Use the same implementation as in
414 modest-easysetup-wizard.c:
415 (on_entry_invalid_character): The logical ID contains a %s.
416 Guessed what it should be.
417 (on_entry_max), (check_data), (on_response): Adapt to
418 changed show_error().
419 (create_page_account_details): Really call
420 modest_validating_entry_set_func() on the correct widgets.
421 * src/maemo/easysetup/modest-easysetup-wizard.c:
422 (on_entry_invalid_character): Fix the logical ID here too.
423 (create_page_account_details),
424 (create_page_user_details):
426 modest_validating_entry_set_func() on the correct widgets.
428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
429 Do not try to use the account if it is NULL.
431 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
433 * src/modest-ui-actions.c: (create_move_to_dialog),
434 (modest_ui_actions_on_main_window_move_to),
435 (modest_ui_actions_on_msg_view_window_move_to):
436 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
437 (filter_row), (modest_folder_view_show_non_move_folders):
438 * src/widgets/modest-folder-view.h:
440 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
441 the Sent folder yet as it does not report the correct folder type.
443 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
445 * src/maemo/modest-msg-edit-window.c: (init_window):
448 2007-07-10 Murray Cumming <murrayc@murrayc.com>
450 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
451 Take a parent widget instead of a parent window, and
452 implement this with hildon_banner_show_information() instead.
453 Non-Maemo builds can just ifdef that there.
454 This fixed projects.maemo.org bug NB#62766.
456 (on_entry_invalid_character): Use show_error() again instead
457 of using hildon directly, and use the _CS() macro to use the correct
459 (create_account), (check_for_supported_auth_methods), (on_entry_max):
460 Pass a widget instead od a window to show_error().
462 2007-07-10 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
465 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
466 This allows us to show the server name in the error message, fixing
467 projects.maemo.org bug NB#62904.
468 Also, use the appropriate logical ID message for the account protocol.
470 2007-07-10 Murray Cumming <murrayc@murrayc.com>
472 * src/modest-tny-account-store.c: (on_idle_wrong_password):
473 A compilation fix, though the build wasn't broken for me.
475 2007-07-09 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
478 Do not try to unref a NULL folder store, to avoid a runtime warning.
479 This seems to happen sometimes when changing accounts settings.
481 2007-07-09 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-tny-account-store.c:
484 (modest_tny_account_store_instance_init),
485 (modest_tny_account_store_finalize),
486 (on_account_settings_hide), (on_idle_wrong_password):
487 Use a GHashTable to ensure that we only show one account settings
488 dialog per modest account. This avoids us having a dialog open for
489 both the store and transport accounts, or due to repeated get_password()
490 calls that shouldn't happen anyway.
492 2007-07-09 Murray Cumming <murrayc@murrayc.com>
494 * src/maemo/modest-maemo-utils.c: (on_hide),
495 (modest_maemo_show_dialog_and_forget): Handle the response, because
496 the window is not even hidden by default.
498 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
499 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
500 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
501 which seems to prevent some modality problems.
503 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
504 Ignore user cancellation errors.
506 * src/modest-account-mgr-helpers.h:
507 * src/modest-account-mgr-helpers.c:
508 Added modest_server_account_get_password() and
509 modest_server_account_get_has_password() to avoid direct use of
512 * src/maemo/modest-account-settings-dialog.h:
513 * src/maemo/modest-account-settings-dialog.c:
514 (modest_account_settings_dialog_init): Store the notebook so we can
516 Added modest_account_settings_dialog_switch_to_user_info().
518 * src/modest-tny-account-store.c:
519 (get_password): When the password in the account settings is wrong (we think),
520 show the relevant page of the account settings dialog, in the mainloop.
521 However, we currently get many of these at once because cancel does not
523 (forget_password): Do not forget the password
524 from the account settings, because this causes side-effects when
525 tinymail seems to call it at strange time, maybe because of how we
526 are cancelling get_password().
527 (modest_tny_account_store_alert): Ignore user cancellations.
529 2007-07-09 Murray Cumming <murrayc@murrayc.com>
531 * src/maemo/modest-maemo-utils.h:
532 * src/maemo/modest-maemo-utils.c:
533 Added modest_maemo_show_information_note_and_forget() for use instead of
534 gtk_dialog_run() when the response is not needed, to avoid an extra
535 mainloop which could cause a hang.
537 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
538 Use the logical IDs for the error message, though they are not
539 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
540 because gtk_dialog_run() caused a hang here (the window did not close).
541 This fixes projects.maemo.org bug NB#62646.
543 2007-07-09 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-account-mgr-helpers.h:
546 * src/modest-account-mgr-helpers.c:
547 Added modest_account_mgr_get_store_protocol().
549 * src/maemo/modest-account-view-window.c:
550 (on_delete_button_clicked): Show different warning text depending on
551 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
552 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
555 2007-07-09 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-msg-edit-window.c:
558 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
559 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
561 2007-07-07 Armin Burgmeier <armin@openismus.com>
563 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
564 ckdg_ib_maximum_characters_reached from correct package.
566 * src/modest-ui-actions.c: Show an error message when a folder could
567 not be created. Tinymail does not give us specific error codes about
568 what has gone wrong, so we assume that a folder with that name
569 already exists, though there might be other reasons.
571 2007-07-06 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
574 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
575 give a more exact error message that can be partly translated.
577 2007-07-05 Murray Cumming <murrayc@murrayc.com>
579 * src/maemo/modest-address-book.c:
580 (select_email_addrs_for_contact): Specify a default window size for the
581 select-email-address dialog, so that it is probably big enough for the
582 title. This should fix projects.maemo.org bug NB#62277.
584 2007-07-05 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 (create_page_complete_easysetup): Use
588 gtk_widget_set_size() request to ensure that the text wraps
591 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
593 * src/maemo/easysetup/modest-easysetup-wizard.c:
594 (on_entry_invalid_character), (create_page_account_details),
595 (create_page_user_details):
596 Use new API of ModestValidatingEntry. But for some reason the banner is
597 not shown. I will have to investigate that further.
599 * src/widgets/modest-validating-entry.c: (on_insert_text),
600 (modest_validating_entry_set_func):
601 * src/widgets/modest-validating-entry.h:
602 Added a new callback function to be able to react to prevented
603 characters whitespaces to e.g show a banner.
605 2007-07-05 Armin Burgmeier <armin@openismus.com>
607 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
608 notification of HildonNumberEditor instead of remembering the port
609 number. Thanks to Johannes for pointing this out.
611 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
613 * src/maemo/easysetup/modest-easysetup-wizard.c:
614 Check if there are any user changes before showing a confirmation
615 dialog (projects.maemo.org NB#60946)
617 2007-07-05 Armin Burgmeier <armin@openismus.com>
619 * src/maemo/modest-account-settings-dialog.c: Remember custom port
620 number at the beginning of the dialog and set the modified flag at the
621 end if the port number has changed. This is necessary because
622 HildonNumberEditor does not support notification when the value has
625 2007-07-05 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-ui-actions.c:
628 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
629 a connection before asking anything else. Correct the check for the destination
630 folder so that it succeeds when online.
631 This fixed projects.maemo.org bug NB#61645.
633 2007-07-05 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
636 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
637 to fix projects.maemo.org bug NB#62439.
639 2007-07-05 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-tny-account.c: (on_connection_status_changed):
642 Really do not use tny_device_force_offline() here. See the previous comment.
644 2007-07-04 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-tny-account.c: (on_connection_status_changed):
647 Do not use tny_device_force_offline() when tinymail says that something
648 went wrong with the connection. It seems to report this unnecessarily.
650 2007-07-04 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/modest-connection-specific-smtp-window.c:
653 (modest_connection_specific_smtp_window_init):
654 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
655 does not seem to have any effect in osso 1.1 (though it works in
656 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
658 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
660 * src/maemo/modest-connection-specific-smtp-window.c:
661 Fix UI specification problems with projects.meamo.org NB#60479
663 2007-07-04 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
666 clue when this has failed, because the error dialog is not always shown
667 (at least in earlier version).
669 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
670 GError message, because the generic error dialog is not helpful.
672 'This message is not currently available (can't let a new connection go online)'
673 when trying to open an IMAP message.
675 (_modest_ui_actions_open): Offer a connection when some messages would
676 have to be downloaded and we are offline.
678 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
680 * src/widgets/modest-folder-view.c:
681 Don't check for MERGE type anymore as we use the correct type
683 NOTE: For the last two changes you need to update your tinymail copy
684 because of API changes!
686 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
688 * src/modest-tny-local-folders-account.c:
689 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
690 (see projects.maemo.org NB#61580)
692 2007-07-04 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account.c: (on_connection_status_changed):
695 Commented out the call to modest_platform_connect_and_wait() because this
696 seems to always hang, and I would like to know if this is the only thing
697 that causes a hang when showing the connection dialog.
698 It is not very useful anyway.
700 2007-07-04 Murray Cumming <murrayc@murrayc.com>
702 * src/maemo/modest-msg-view-window.c:
703 (modest_msg_view_window_select_next_message):
705 * src/modest-platform.h:
706 * src/maemo/modest-platform.c:
707 Added modest_platform_connect_and_wait(), which calls
708 tny_maemo_conic_device_connect() always in the main thread, by calling it
709 in an idle handler and waiting for the idle handler to run. It should be
710 in the main thread because it uses GTK+ UI code. It just returns TRUE
711 if the device is already online.
713 There is some nasty code to ensure that subsequent calls to
714 modest_platform_connect_and_wait() just wait for the first one to finish,
715 by checking repeatedly in another idle handler. This is necessary,
716 because other threads (or even the main thread, via another idle handler)
717 can call modest_platform_connect_and_wait() while
718 modest_platform_connect_and_wait() is running.
720 (modest_platform_connect_and_wait_if_network_account),
721 (modest_platform_connect_and_wait_if_network_folderstore):
722 Convenience functions that calls modest_platform_connect_and_wait() if
723 the account or folder might want network access.
725 * src/modest-mail-operation.c:
726 (modest_mail_operation_update_account):
727 * src/modest-ui-actions.c: (download_uncached_messages),
728 (modest_ui_actions_on_rename_folder), (delete_folder),
729 (modest_ui_actions_on_main_window_move_to),
730 (modest_ui_actions_on_msg_view_window_move_to):
731 * src/widgets/modest-folder-view.c:
732 (drag_and_drop_from_folder_view):
733 Offer a connection if we are offline.
735 * src/modest-tny-account.c: (on_connection_status_changed):
736 Document this as only handling errors during network operations in progress,
737 and replace the idle code with a simple call to
738 modest_platform_connect_and_wait(), which does this instead.
740 2007-07-03 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-tny-account.c:
743 (modest_tny_account_get_special_folder): (util_on_idle),
744 Handle the GError so we can see when tny_folder_store_get_folders()
745 fails, as it currently does while something else is connecting.
747 Added util_run_in_main_thread_and_wait()
748 which uses an idlen handler and mainloop to ensure that the function
749 is called in the main thread.
750 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
751 to make sure that we call attempt the connection in the mainloop only,
752 which might solve some hangs.
754 2007-07-03 Murray Cumming <murrayc@murrayc.com>
756 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
757 be found by their display name. This is never useful.
758 * src/modest-tny-account-store.c: (on_account_removed): Find the account
759 by its ID, instead of trying to use its ID as its display name.
761 * src/modest-tny-account-store.h:
762 * src/modest-tny-account.c:
763 (modest_tny_account_get_special_folder): Add a g_warning() when
764 tny_folder_store_get_folders() returns an empty list for the maildir.
766 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
767 Add a g_warning() when this returns NULL, because that it not allowed
770 2007-07-02 Armin Burgmeier <armin@openismus.com>
772 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
773 note when trying to cancel the wizard. This fixes projects.maemo.org
776 2007-07-02 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-tny-account.h:
779 * src/modest-tny-account.c:
780 (modest_tny_account_new_from_server_account),
781 (modest_tny_account_new_from_server_account_name),
782 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
783 because this must now be set before setting the proto. This is usd in
784 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
785 warning in camel_session_get_service() caused by
786 tny_camel_transport_account_prepare().
788 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
791 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
793 * src/maemo/modest-connection-specific-smtp-edit-window.c:
795 (modest_connection_specific_smtp_edit_window_init):
797 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
800 2007-06-29 Murray Cumming <murrayc@murrayc.com>
802 * src/modest-tny-account.c:
803 (modest_tny_account_new_from_server_account):
804 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
805 now uses to request a connection when it needs one, and which it uses
806 to tell us that something is wrong with the connection, so we can force
807 the accounts offline to prevent further problems.
810 * src/modest-init.c: (init_default_settings):
811 * src/modest-mail-operation.c:
812 (modest_mail_operation_update_account):
813 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
814 This should not be necessary anymore. Do not set the conf key that
815 determined this (it was always TRUE and not set anywhere else).
817 * src/modest-ui-actions.h: Remove unused and unimplemented
818 modest_ui_actions_on_online_toggle_toggled().
820 2007-06-29 Murray Cumming <murrayc@murrayc.com
822 * src/maemo/modest-main-window.c: (connect_signals):
823 Don't connect to delete_event twice. Maybe this was harmless.
825 2007-06-29 Murray Cumming <murrayc@murrayc.com
827 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
828 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
829 Debug output to give some more clue when a folder move is not allowed.
831 2007-06-28 Murray Cumming <murrayc@murrayc.com
833 * src/modest-tny-account.c: (on_modest_file_system_info),
834 (modest_tny_account_get_mmc_account_name):
835 Always call the callback, without checking whether the name has changed.
836 * src/widgets/modest-folder-view.c: (strings_are_equal),
837 (on_model_foreach_set_name), (on_get_mmc_account_name),
838 (text_cell_data): Compare the name here, and use the name from
839 the account rather than from the
840 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
841 if the name was changed after the account was added to the model.
842 That's a tinymail bug but not one that I want to fix now.
844 This finally fixes projects.maemo.org bug NB#59301.
846 2007-06-27 Armin Burgmeier <armin@openismus.com>
848 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
851 2007-06-27 Murray Cumming <murrayc@murrayc.com
853 * src/modest-tny-account.h:
854 * src/modest-tny-account.c:
855 Added modest_tny_account_get_mmc_account_name(), to set the memory
856 card name asynchronously for the given account and then notify.
857 (modest_tny_account_new_for_local_folders): Use this new function instead
858 of using hildon_file_system_info_async_new() directly.
860 * src/widgets/modest-folder-view.c: (text_cell_data):
861 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
862 gtk_tree_model_row_changed() when it is available.
864 This should fix projects.maemo.org bug NB#59301.
866 2007-06-27 Murray Cumming <murrayc@murrayc.com
868 * src/modest-mail-operation.c: (update_account_thread),
869 (get_msgs_full_thread): Fix typo failures in the revert
872 2007-06-27 Murray Cumming <murrayc@murrayc.com
874 * src/maemo/modest-maemo-global-settings-dialog.c:
875 (idle_select_default_focus):
876 * src/modest-mail-operation.c: (idle_notify_progress),
877 (idle_notify_progress_once), (set_last_updated_idle),
878 (update_account_thread), (get_msgs_full_thread):
879 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
880 * src/widgets/modest-header-view.c:
881 (idle_notify_headers_count_changed_destroy),
882 (idle_notify_headers_count_changed):
883 Reverted the additions of gdk_threads_enter/leave(), in case this
884 helps with a startup hang on the device.
886 2007-06-26 Armin Burgmeier <armin@openismus.com>
888 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
889 for supported secure authentication methods from server by
890 gtk_dialog_run(), saving CPU time and a potential race condition.
892 2007-06-26 Armin Burgmeier <armin@openismus.com>
894 * src/maemo/modest-maemo-utils.h:
895 * src/maemo/modest-maemo-utils.c: Added a
896 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
897 only error code to tell the calling code when the user canceled the
900 * src/maemo/modest-account-settings-dialog.h:
901 * src/maemo/modest-account-settings-dialog.c:
902 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
903 message if the retrieval of secure authentication methods was canceled
904 by the user. Perform the check before saving anything to configuration
905 to not end up with half-committed configuration changes, do not show
906 a "Saving to configuration failed" note when authentication methods
907 could not be retrieved.
909 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
912 2007-06-26 Murray Cumming <murrayc@murrayc.com>
914 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
915 Only return the first level of folders under accounts, because the
916 osso-global-search UI spec doesn't want the rest.
917 This fixed projects.maemo.org bug NB#61811.
919 2007-06-26 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-tny-account-store.c:
922 * src/modest-tny-account-store.h:
923 Added modest_tny_account_is_memory_card_account().
924 * src/maemo/modest-main-window.c: (create_details_widget):
925 Show the same information items for the memory card as we show for the
926 local-folders, to fix projects.maemo.org bug NB#59307.
928 2007-06-26 Murray Cumming <murrayc@murrayc.com>
930 * src/modest-tny-account-store.c: (get_password):
931 Added some checks for NULL to maybe prevent crashes, though I think
932 it was Philip's last commit that actually prevented the crash here
933 when creating a first new account.
934 But the new account is still not usable (no messages are shown)
935 until a restart of the application.
937 2007-06-26 Murray Cumming <murrayc@murrayc.com>
939 * src/maemo/modest-maemo-global-settings-dialog.c:
940 (idle_select_default_focus):
941 * src/modest-mail-operation.c: (idle_notify_progress),
942 (idle_notify_progress_once), (idle_notify_update_account_queue),
943 (set_last_updated_idle), (update_account_thread),
944 (notify_get_msgs_full), (get_msgs_full_destroyer),
945 (get_msgs_full_thread):
946 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
947 * src/widgets/modest-header-view.c:
948 (idle_notify_headers_count_changed_destroy),
949 (idle_notify_headers_count_changed):
950 Use gdk_threads_enter() and gdk_threads_enter_leave() in
951 all idle handlers, because some other thread could be blocking
952 the GDK lock, so that it can do GUI stuff.
954 2007-06-26 Murray Cumming <murrayc@murrayc.com>
956 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
957 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
958 (on_idle_send_receive), (on_idle_open_default_inbox):
959 * src/maemo/modest-msg-edit-window.c:
960 (modest_msg_edit_window_attach_file_noninteractive):
961 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
962 to prevent a hang. I don't quite understand why these are necessary,
963 beause we should already be in the main loop. I guess something outside
964 of the main loop is taking the lock.
966 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
967 we are really using URIs, and use files that are more likely to exist.
969 2007-06-26 Murray Cumming <murrayc@murrayc.com>
971 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
972 necessary because configure.ac now defines different variables.
974 2007-06-26 Murray Cumming <murrayc@murrayc.com>
976 * libmodest-dbus-client/libmodest-dbus-client.c:
977 * libmodest-dbus-client/libmodest-dbus-client.h:
978 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
979 libmodest_dbus_client_compose_mail() is what things actually use.
981 * src/dbus_api/modest-dbus-api.h:
982 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
983 * tests/dbus_api/Makefile.am:
984 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
987 2007-06-26 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-init.c: (modest_init_local_folders):
990 For memory-card (or other non local-folders) maildir accounts,
991 always create an Archive folder, so that there is somewhere to put
992 messages. This should be less confusing, because the user does not need
993 to guess that the need to create a folder.
995 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
997 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
998 Fixed icon size by using (50, 50) which is the same as defined by
1001 2007-06-25 Armin Burgmeier <armin@openismus.com>
1003 * src/widgets/modest-window-mgr.c:
1004 * src/modest-init.c:
1005 * configure.ac: Correctly recognize hildon-notify presence and fixed
1006 the build without it being installed.
1008 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1010 * libmodest-dbus-client/libmodest-dbus-client.c:
1011 (libmodest_dbus_client_search): Fix the build. Sorry.
1012 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1013 (reply_forward_cb): Initialize variables to fix the build.
1015 * src/modest-tny-account-store.c:
1016 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1017 comparison (a silly typo) so that email search results can be opened
1018 when there are more than one account.
1020 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1022 * libmodest-dbus-client/libmodest-dbus-client.c:
1023 (libmodest_dbus_client_search),
1024 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1025 instead of 1 second, because the search gets folders and messages from
1026 the server, which can take a long time. When it times out,
1027 osso-global-search will report no results.
1029 We need to specify whether we should search only cached information
1030 (maybe with a user preference), and the osso-email-search-plugin
1031 API should really be improved to allow that option, and to allow results
1032 to be delivered asynchronously in batches.
1034 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1036 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1037 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1038 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1040 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1043 that is an empty string. D-Bus seems to give us these instead of NULL.
1045 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1047 * src/dbus_api/modest-dbus-callbacks.c:
1048 * src/maemo/easysetup/modest-easysetup-wizard.h:
1049 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1050 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1051 (modest_connection_specific_smtp_edit_window_init):
1052 * src/maemo/modest-maemo-global-settings-dialog.c:
1054 * src/maemo/modest-maemo-utils.c:
1055 (modest_maemo_utils_setup_images_filechooser):
1056 * src/maemo/modest-main-window.c: (create_details_widget):
1057 * src/maemo/modest-msg-edit-window.c:
1058 (modest_msg_edit_window_attach_file_noninteractive),
1059 (modest_msg_edit_window_color_button_change),
1060 (modest_msg_edit_window_set_zoom):
1061 * src/modest-mail-operation.c: (update_account_thread):
1062 * src/modest-tny-account-store.c:
1063 * src/modest-tny-account.c:
1064 * src/widgets/modest-global-settings-dialog.c:
1065 * src/widgets/modest-window.h:
1067 Fixed build on bora!
1069 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1071 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1072 * src/modest-search.c: (modest_search_folder),
1073 (modest_search_all_accounts): Actually search only in the specified folder,
1074 doing a simple match on the folder ID.
1075 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1076 and added some documentation.
1078 2007-06-22 Armin Burgmeier <armin@openismus.com>
1080 * src/maemo/modest-maemo-utils.h:
1081 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1082 modest_maemo_utils_get_supported_secure_authentication_methods.
1084 * src/maemo/easysetup/modest-easysetup-wizard.c:
1085 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1086 one occured, not just "Server does not support secure authentication".
1088 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-tny-account-store.c: (get_password):
1091 Restored the call to tny_account_set_user() because Philip seems to have
1092 stopped this from crashing (by not using the freed string). It still does
1093 not work, but now we can test it.
1095 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/modest-msg-edit-window.c: (init_window):
1098 Comment out use of an uninitialzed GtkScrolledWindow variable,
1099 to fix the build and stop a crash. Yet again.
1101 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1103 * src/modest-tny-account-store.c: (get_password):
1104 Remove the call to tny_account_set_user() because this actually crashes.
1105 As mentioned in the last commit, it is known to not work anyway.
1107 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1109 * src/modest-tny-account-store.c: (get_password):
1110 Use tny_account_set_username() to tell tinymail that the username might
1111 have changed too. But tinymail ignores this: see projects.maemo.org
1113 * src/modest-ui-actions.c:
1114 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1115 reset the connection when changing the username, and improve the comments.
1116 Save the changed username to gconf at least, so it is used when Modest is
1119 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1121 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1122 Do not use a query, so that we get all folders, including for POP and
1123 local-folders. They work as search criteria too.
1124 This fixes projects.maemo.org bug NB#57740.
1126 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1128 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1129 Comment out the use of hildon_notification_set_sound() because it is
1130 not declared, to fix the build. Warnings are serious, people.
1132 2007-06-21 Armin Burgmeier <armin@openismus.com>
1134 * src/maemo/modest-maemo-utils.h:
1135 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1136 modest_maemo_utils_get_supported_secure_authentication_methods()
1137 to query authentication methods for a specific user. This should fix
1138 projects.maemo.org bug NB#61369.
1140 * src/maemo/easysetup/modest-easysetup-wizard.c:
1141 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1144 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1146 * libmodest-dbus-client/libmodest-dbus-client.h:
1147 * libmodest-dbus-client/libmodest-dbus-client.c:
1148 (modest_dbus_message_iter_get_search_hit),
1149 (libmodest_dbus_client_search):
1150 Reorganised and commented this.
1151 Removed modest_search_hit_free() from the public API because it
1154 Added libmodest_dbus_client_get_folders() and
1155 modest_folder_result_list_free().
1157 * src/dbus_api/modest-dbus-api.h:
1158 * src/dbus_api/modest-dbus-callbacks.c:
1159 (modest_dbus_req_filter): Commented. Moved most code to
1160 on_dbus_method_search() and added on_dbus_method_get_folders().
1162 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1163 of the extra D-Bus handler.
1165 * tests/dbus_api/Makefile.am:
1166 * tests/dbus_api/test_get_folders.c: New test for
1167 libmodest_dbus_client_get_folders(). This seems to return an empty list
1168 at the moment. That could be the same error that causes the message list
1169 to be empty sometimes.
1170 This should help with projects.maemo.org bug NB#57740.
1172 2007-06-21 Armin Burgmeier <armin@openismus.com>
1174 * src/modest-mail-operation.c: Do not call
1175 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1176 notify the operation's end after having set the status to CANCELED for
1177 the operation queue to listen on. This fixes a deadlock when there
1178 were mail operations in the queue during its finalization.
1180 * src/modest-singletons.c: Reordered uninitialization of the account
1181 manager to happen after the mail operation queue was uninitialized
1182 because the mail operation's in the queue might still try to access
1183 the account manager (see modest_mail_operation_notify_end()). This
1184 fixes a potential crash when terminating the application.
1186 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1188 * src/modest-search.c:
1189 (search_mime_part_and_child_parts): Moved some code here so we
1190 can search recursively in child folders.
1191 (modest_search_folder): Search in the message as a mime part, instead
1192 of just its child mime parts.
1193 (read_chunk), (search_mime_part_ogs):
1194 Check how many bytes were read, to prevent an endless loop.
1195 Searching in message bodies now works. This finishes the fix for
1196 projects.maemo.org bug NB#61007.
1198 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1200 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1201 Add a g_warning when the item is not a folder.
1203 * src/modest-ui-dimming-rules.c:
1204 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1205 when selected item is not a folder (for instance, an account), because
1206 the UI spec only talks about folders.
1207 I am not sure what the UI spec wants, so this might not totally fix
1208 projects.maemo.org bug NB#60794.
1210 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1213 (load_from_file): Sort the list. The unsorted list would be more noticeable
1214 in non-English locales.
1216 * src/maemo/modest-msg-edit-window.c:
1217 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1218 warning and fix the build.
1220 * src/maemo/modest-progress-bar-widget.c:
1221 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1222 avoid a g_warning, and probably to avoid a crash.
1224 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1226 * src/modest-search.c: (modest_search_folder): Check for a GError
1227 when calling tny_folder_get_headers(), to show that this is not the cause
1230 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1232 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1233 Actually set the body query instead of the subject query.
1235 * src/modest-search.c: (search_mime_part_ogs),
1236 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1237 which would probably cause it to fail if we got this far.
1239 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1240 to simplify the code.
1241 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1242 be causing search-in-body to fail.
1244 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1246 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1248 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1249 Better debug message when the folder cannot be found.
1250 This should help with fixing projects.maemo.org bug #61287.
1251 * src/modest-search.c: (add_hit): Do not leak the furl string.
1253 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-ui-actions.c:
1256 (modest_ui_actions_on_folder_selection_changed):
1257 Do not special-case TNY_MERGE_FOLDER here, because
1258 modest_tny_folder_get_account() already does that. This fixes
1259 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1260 shown when the Outbox was selected).
1262 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1264 * libmodest-dbus-client/libmodest-dbus-client.c:
1265 (_dbus_iter_get_string_or_null): Initialize the string variable in
1266 case this helps with Dirk's crash.
1268 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1270 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1271 though it is not implemented yet (this function is maybe not even used),
1272 to avoid breaking ABI in future.
1273 * libmodest-dbus-client/libmodest-dbus-client.c:
1274 (get_attachments_string): Moved some code into this generic function.
1275 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1276 sends email. It is maybe not used.
1277 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1278 (on_send_mail): Use attachments.
1280 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1281 * src/maemo/modest-msg-edit-window.c:
1282 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1283 a filename before using it, to fix projects.maemo.org bug NB#58233.
1285 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1288 Initialize the continue_download variable to fix the build, and probably
1289 to fix randome behaviour.
1291 2007-06-18 Armin Burgmeier <armin@openismus.com>
1293 * src/modest-tny-send-queue.h:
1294 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1295 the queue so we can later show it in the UI. Replaced
1296 modest_tny_send_queue_msg_is_being_sent() by
1297 modest_tny_send_queue_get_msg_status().
1299 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1301 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1302 gpointer. This probably was not harmful, but just to be sure.
1304 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1307 Fix the build, but leave the function broken on Bora, because
1308 hildon_uri_action_get_service() does not exist.
1309 osso_uri_action_get_service() does not exist either, it seems.
1311 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-tny-account.c:
1314 (modest_tny_account_new_from_server_account):
1315 Uncommented the url debug output again, because it is useful for
1316 debugging, as I said in the comment.
1318 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1320 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1322 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1323 for Mameo Bora, to fix the build.
1325 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1328 Fixed build with hildon < 0.99
1330 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1331 Check if the selected account is busy instead of checking all accounts
1333 * src/modest-account-mgr-priv.h:
1334 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1335 (modest_account_mgr_init), (compare_account_name),
1336 (modest_account_mgr_set_account_busy),
1337 (modest_account_mgr_account_is_busy):
1338 * src/modest-account-mgr.h:
1339 Added busy information to the account manager. It possible to
1340 set an account to busy or not busy now.
1342 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1343 (modest_mail_operation_update_account),
1344 (modest_mail_operation_notify_end):
1345 Set the account to busy/not busy depending on the operation state.
1347 * src/widgets/modest-account-view.c:
1348 (modest_account_view_finalize), (get_last_updated_string),
1349 (update_account_view), (on_account_busy_changed), (init_view):
1350 Show string "Refreshing..." if the account is currently busy.
1352 All this fixes projects.maemo.org bug NB#59711
1354 2007-06-14 Armin Burgmeier <armin@openismus.com>
1356 * src/widgets/modest-attachments-view.h:
1357 * src/widgets/modest-attachments-view.c: Added
1358 modest_attachments_view_has_attachments() and fixed coordinate
1359 transformation in get_att_view_at_coords(). This fixes attachment
1362 * src/widgets/modest-msg-view.c: Make use of
1363 modest_attachments_view_has_attachments() to decide whether to show
1364 attachments in the header.
1366 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1369 (on_change), (on_combo_security_changed),
1370 (modest_connection_specific_smtp_edit_window_init),
1371 (modest_connection_specific_smtp_edit_window_set_connection),
1372 (modest_connection_specific_smtp_edit_window_is_dirty):
1373 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1374 * src/maemo/modest-connection-specific-smtp-window.c:
1377 Show an comfirmation dialog for the smpt-edit-window if there are
1378 unsaved changes and the user hits cancel.
1379 (projects.maemo.org bug NB#60479)
1381 2007-06-14 Armin Burgmeier <armin@openismus.com>
1383 * src/maemo/easysetup/modest-easysetup-wizard.c:
1384 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1385 address" info in banner instead of node, and select all the text as
1386 per UI spec. This fixes projects.maemo.org bug NB#60550.
1388 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1390 reviewed by: <delete if not using a buddy>
1392 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1393 * src/modest-ui-actions.c: (folder_refreshed_cb):
1395 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1397 * src/widgets/modest-folder-view.c: (filter_row):
1398 Explictly filter out the per-account outbox accounts. I don't know why
1399 these only sometimes show up, but now they should never show up in the UI.
1400 This should fix projects.maemo.org bug NB#60160.
1402 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1404 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1405 when the toolbar does not exist yet.
1406 * src/modest-widget-memory.c: (save_settings_header_view):
1407 Added g_warnings() to help us to discover when we are trying to set
1408 an empty columns list in gconf.
1410 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-init.h:
1413 * src/modest-init.c:
1414 Added modest_init_get_default_header_view_column_ids().
1416 * src/modest-widget-memory.c: (restore_settings_header_view):
1417 Use the new function to get defaults, if the gconf key is empty,
1418 instead of not creating any columns. This seems to fix the
1419 empty right-hand pane problems.
1421 * src/widgets/modest-header-view.h: Improved documentation.
1423 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1426 Revert the use of the display name as the account name, because this
1427 is generally wrong and would break the code that follows.
1429 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1431 * src/maemo/easysetup/modest-easysetup-wizard.c:
1432 (check_for_supported_auth_methods), (on_before_next),
1435 More correct fix for projects.maemo.org bug NB# 58991
1436 Do not longer accept AUTH_PASSWORD as secure method and choose
1437 correct method when creating the account.
1439 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1441 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1442 Fixed projects.maemo.org bug NB# 58991
1444 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1446 * src/modest-init.c: (modest_init_init_core),
1447 (modest_init_local_folders): Fixed compilation errors.
1449 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1451 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1452 Remove unnecessary lib/include, though it is good in principle when needed.
1454 * src/modest-init.c: (modest_init_one_local_folder),
1455 (modest_init_local_folders):
1456 * src/modest-init.h: Initialize the .modest library for memory cards,
1457 instead of just doing nothing for them. This should allow us to create
1458 folders there, fixing projects.maemo.org bug NB#59297.
1460 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1462 * libmodest-dbus-client/libmodest-dbus-client.c:
1463 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1464 (libmodest_dbus_client_compose_mail),
1465 (libmodest_dbus_client_open_message),
1466 (libmodest_dbus_client_send_and_receive),
1467 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1469 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1470 (on_idle_open_message), (modest_dbus_req_handler),
1471 (search_result_to_message), (modest_dbus_req_filter):
1472 * src/modest-search.c: (add_hit), (modest_search_folder),
1473 (modest_search_all_accounts): Improved debug messages.
1475 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1477 * src/modest-tny-account-store.c:
1478 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1481 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1484 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1486 * src/modest-tny-account-store.c: (get_server_accounts):
1487 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1488 even when there are no accounts, so that the Outbox folder is always
1489 visible. This fixes projects.maemo.org bug NB#60158.
1491 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/modest-main-window.c: (create_details_widget):
1494 Use the mcen_va_never logical ID.
1496 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1498 * src/dbus_api/modest-dbus-api.h:
1499 * src/dbus_api/modest-dbus-callbacks.c:
1500 (on_idle_open_default_inbox), (on_open_default_inbox),
1501 (modest_dbus_req_handler):
1502 Added a new OpenDefaultInbox method.
1504 * libmodest-dbus-client/libmodest-dbus-client.h:
1505 * libmodest-dbus-client/libmodest-dbus-client.c:
1506 Added libmodest_dbus_client_open_default_inbox() to call the new
1507 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1508 though it should maybe be used by a new osso-email-interface function.
1510 * tests/dbus_api/Makefile.am:
1511 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1514 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1516 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1517 NULL, so that the signals get all the keys. This should not actually
1518 change any behaviour because we currently update everything when anything
1521 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1523 * src/widgets/modest-folder-view.c: (text_cell_data),
1524 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1525 (find_inbox_iter): If tinymail tells us that the folder is
1526 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1527 This causes the inbox to be selected at startup, fixing part of
1528 projects.maemo.org bug NB#56305.
1530 * src/modest-ui-dimming-rules.c:
1531 (modest_ui_dimming_rules_on_tools_smtp_servers):
1532 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1533 the SMTP servers menu item.
1534 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1535 that the SMTP Servers menu item is dimmed when there are no accounts,
1536 as a future version of the UI spec will require. This fixes
1537 projects.maemo.org bug NB#56305.
1539 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1541 * src/maemo/modest-maemo-utils.c:
1542 (modest_maemo_utils_get_supported_secure_authentication_methods):
1543 Added label to dialog instead of unreadable title
1545 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1546 (modest_main_window_new):
1547 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1550 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1551 * src/modest-account-mgr.h:
1552 Added method to avoid code duplication
1554 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1555 (modest_ui_actions_on_send_receive):
1556 Use modest_account_mgr_has_accounts
1558 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1560 * src/maemo/easysetup/modest-presets.c:
1561 (modest_presets_get_info_server_security): Do not report secure auth
1563 * src/modest-protocol-info.c: Use the defines for the gconf key names
1564 for secure authentication. This was not working because we were writing
1565 Password and reading password, and the check was case sensitive.
1566 With this, gmail now works for receiving and sending when created via
1569 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/easysetup/modest-presets.c:
1572 (modest_presets_get_info_server_security): Correct the key name for
1573 SecureSmtp, because it seems to be case-sensitive.
1574 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1575 Do not try to get the 0th notebook page if there are 0 pages, to
1576 avoid a g_warning().
1578 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1581 Prevent use of the new notification feature for now, because it currently
1582 shows one dialog for each new email, which is annoying.
1584 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1587 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1588 when no country was selected, so that we show the global ones.
1589 * src/maemo/easysetup/modest-presets.c:
1590 (modest_presets_get_providers): Return only the global providers, not
1591 all providers when mmc=0 was requested.
1593 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1596 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1597 provider ID in the combo.
1599 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1600 Do not show the page numbers, because it would be confusing when we add
1601 the 2 extra pages for the custom setup, when the user chooses the "Other"
1602 provider. This fixes projects.maemo.org bug NB#59028
1604 * src/modest-init.c: (modest_init_init_core),
1605 (modest_init_local_folders):
1606 * src/modest-init.h:
1607 * src/modest-tny-account.c:
1608 (modest_tny_account_new_for_local_folders): Do not create default folders
1609 for the memory card. This should fix projects.maemo.org bug NB#59328.
1611 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1614 Free the changed_conf_keys string items. They are already freed in the
1615 idle handler if that runs first.
1617 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-ui-actions.c:
1620 (modest_ui_actions_on_password_requested): Check that the server name
1621 is not NULL, because I just saw a password dialog with (null) as the
1624 * src/modest-tny-folder.[h|c]: Added
1625 modest_tny_folder_is_memory_card_folder().
1626 * src/modest-ui-dimming-rules.c:
1627 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1628 menu item for memory cards, as per the UI spec (section 7.4). This should
1629 fix projects.maemo.org bug NB#59297.
1631 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1633 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1634 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1635 is another problem with the code, see Murray's comment at line 772)
1637 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1639 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1640 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1641 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1642 (load_from_file), (easysetup_country_combo_box_init),
1643 (easysetup_country_combo_box_get_active_country_ids),
1644 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1645 instead of just one ID, to avoid duplicate country names in the UI.
1647 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1648 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1649 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1650 a single ID, avoiding duplicate providers.
1651 * src/maemo/easysetup/modest-easysetup-wizard.c:
1652 (on_combo_account_country): Adapt to use a list.
1654 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1656 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1657 keys changed in the last X seconds.
1659 * src/modest-account-mgr.h:
1660 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1661 (on_key_change), (modest_account_mgr_class_init),
1662 (modest_account_mgr_init), (modest_account_mgr_finalize):
1663 As the keys are changed, save them in a GSList* and signal that GSList*
1664 further every X seconds, to batch changes, to allow us to do just one
1665 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1666 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1668 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1669 changed signal signature.
1671 * src/modest-conf.c: (modest_conf_set_list),
1672 (modest_conf_on_change): Reenable notification.
1674 (modest_conf_maemo_fake_on_change): Comment out the hack that
1675 notified immediately instead of asynchronously.
1677 * src/widgets/modest-account-view.h:
1678 * src/widgets/modest-account-view.c:
1679 (update_account_view): Select the previously-selected account ID,
1680 if possible. This fixes projects.maemo.org bug NB#56933.
1682 (on_account_changed), (on_account_removed),
1683 (modest_account_view_select_account):
1685 Remove the block/unblock functions
1686 because they were not useful.
1688 * src/maemo/modest-account-view-window.c:
1689 (on_delete_button_clicked), (on_edit_button_clicked),
1690 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1692 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1694 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1695 Improve the error dialog to show Incorrect Account Settings, which seems
1696 clearer, and say that the internal error message (to be removed from the
1697 dialog later) is often misleading.
1698 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1700 * src/modest-tny-account.c:
1701 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1702 URL because this is so useful for debugging on the device.
1704 * src/widgets/modest-serversecurity-combo-box.c:
1705 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1707 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-mail-operation.c:
1710 (modest_mail_operation_send_new_mail):
1711 Added a comment about a nasty but apparently harmless message. Details
1712 added to the wiki g_warnings() page.
1714 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1716 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1717 (modest_tny_send_queue_class_init):
1718 Do not use the priv struct because it is empty, to avoid g_warnings
1719 about a non-existant priv struct.
1721 * src/modest-tny-account-store.c:
1722 (modest_tny_account_store_get_server_account),
1723 (modest_tny_account_store_get_transport_account_for_open_connection
1724 ): Do not try to get transport server accounts for local folders,
1725 because they don't have any. This avoids a g_warning().
1727 * src/maemo/modest-main-window.c:
1728 (modest_main_window_notify_send_receive_initied),
1729 (on_configuration_key_changed):
1730 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1731 * src/modest-defs.h:
1732 * src/modest-mail-operation.c:
1733 (modest_mail_operation_update_account):
1734 * src/modest-tny-account-store.h:
1735 * src/modest-tny-account.c:
1736 (modest_tny_account_get_special_folder),
1737 (modest_tny_account_new_for_local_folders),
1738 (modest_tny_account_new_for_per_account_local_outbox_folder):
1739 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1740 * src/modest-tny-local-folders-account.c:
1741 (add_account_folders_to_merged_folder):
1742 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1743 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1744 (modest_ui_actions_on_send):
1745 * src/widgets/modest-folder-view.c: (update_model):
1746 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1747 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1748 modest_tny_account_store_get_tny_account_by_account() to
1749 modest_tny_account_store_get_server_account() to make the code clearer.
1751 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1753 * src/dbus_api/modest-dbus-api.h:
1754 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1755 * src/maemo/modest-msg-edit-window.c:
1756 (modest_msg_edit_window_attach_file_noninteractive):
1757 added g_warning in case the file to be attached does not exist
1758 * tests/dbus_api/test_compose_mail.c: (main):
1759 removed obsolete comment, added generic files as test case
1761 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1763 * src/modest-tny-account-store.c: (get_server_accounts):
1764 Create the local folders account only once, not once for each outbox, and
1765 not only when there are some outboxes.
1767 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1769 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1770 code that is causing a crash at startup. Sergio says that he is fixing this.
1772 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1774 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1775 * src/maemo/modest-account-settings-dialog.c:
1776 (create_page_outgoing),
1777 (modest_account_settings_dialog_set_account_name),
1778 (save_configuration):
1779 - Fixed handling of the "Use secure authentication" toggle to comply with
1780 the ui specification. See also projects.maemo.org bug NB#58400
1782 - Restore the Secure connection setting combo correctly when loading
1785 * src/maemo/modest-maemo-utils.c:
1786 (on_camel_account_get_supported_secure_authentication),
1787 (modest_maemo_utils_get_supported_secure_authentication_methods):
1788 Fixed a crasher if operation is canceled
1790 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1791 (modest_protocol_info_auth_is_secure):
1792 * src/modest-protocol-info.h:
1794 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1795 the sense of the "Use secure authentication" toggle.
1797 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-tny-account-store.h:
1800 * src/modest-tny-account-store.c:
1801 Added modest_tny_account_store_get_local_folders_account().
1803 * src/modest-tny-folder.h:
1804 * src/modest-tny-folder.c:
1805 (modest_tny_folder_get_account):
1806 Added this replacement for tny_folder_get_account() which returns
1807 the local-folders account for TnyMergeFolders, to avoid the
1808 warning about the unimplemented get_account_func() vfunc().
1810 (modest_tny_folder_get_rules),
1811 * src/modest-ui-actions.c:
1812 (modest_ui_actions_on_folder_selection_changed):
1813 * src/modest-mail-operation.c:
1814 (modest_mail_operation_remove_folder),
1815 (modest_mail_operation_xfer_folder),
1816 (modest_mail_operation_rename_folder),
1817 (modest_mail_operation_get_msg),
1818 (modest_mail_operation_get_msgs_full),
1819 (modest_mail_operation_remove_msg),
1820 (modest_mail_operation_xfer_msgs),
1821 (modest_mail_operation_refresh_folder):
1822 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1824 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1827 (modest_server_account_set_security):
1828 * src/modest-defs.h: Add comments explaining that our
1829 UI spec means TLS when it says Normal, so these do not look like errors.
1831 * src/modest-tny-account.c:
1832 (modest_tny_account_new_from_server_account): Use the new tinymail
1833 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1834 for TLS. This should fix projects.maemo.org bug NB#58460.
1836 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1838 * src/maemo/easysetup/modest-easysetup-wizard.c:
1839 (create_account): Correct the position of the gconf sanity check warning.
1840 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1841 of using the g_idle_add() hack, because this does not seem to be necessary
1842 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1843 caused by something other than maemo's gconf.
1844 This fixes projects.maemo.org bug #59022.
1846 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-account-mgr-helpers.c:
1849 (modest_account_mgr_get_default_account): Do not check that the account
1850 exists if there is no default account (NULL), to fix a runtime warning.
1852 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1854 * src/widgets/modest-folder-view.c: (update_model):
1855 Do not unref the treemodel before we have finished with it.
1856 This prevents a valgrind warning and an occasional crash at startup.
1858 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1860 * libmodest-dbus-client/libmodest-dbus-client.h:
1861 added libmodest_dbus_client_compose_mail()
1862 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1864 added functions needed for SendAsMail() functionality
1865 * src/maemo/modest-msg-edit-window.c:
1866 (modest_msg_edit_window_attach_file_noninteractive):
1867 non interactively attaching files to message edit window
1868 * src/widgets/modest-msg-edit-window.h:
1869 * tests/dbus_api/Makefile.am:
1870 added test_compose_mail.c
1871 * tests/dbus_api/test_compose_mail.c: (main):
1873 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1875 * src/modest-account-view.c:
1876 Fixed bug projects.maemo.org bug NB#59307
1878 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1880 * src/maemo/easysetup/modest-easysetup-wizard.c:
1881 (get_serverport_incoming), (on_before_next), (create_account):
1882 * src/maemo/modest-account-settings-dialog.c:
1883 (modest_account_settings_dialog_set_account_name):
1884 * src/maemo/modest-maemo-utils.c:
1885 (on_camel_account_get_supported_secure_authentication_status),
1886 (on_camel_account_get_supported_secure_authentication),
1887 (on_secure_auth_cancel),
1888 (modest_maemo_utils_get_supported_secure_authentication_methods):
1890 Implemented security authentication for settings and easysetup.
1892 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-main-window.c: (create_details_widget):
1895 Show the total size for memory card accounts too, instead of showing
1896 the name again. Fixes bug projects.maemo.org bug NB#59307.
1898 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-tny-simple-folder-store.c:
1902 * src/modest-tny-simple-folder-store.h: Removed.
1904 * src/modest-tny-local-folders-account.h
1905 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1906 for the local-folders maildir, with an extra TnyMergedFolder containing
1907 the folders of the per-account outbox store accounts.
1908 * src/modest-tny-account-store.c: (get_server_accounts):
1909 Add the outboxes to the special local folders account after creating it.
1911 * src/modest-tny-account.c:
1912 (modest_tny_account_new_for_local_folders): Create the derived
1913 account when creating the main local-folders account.
1915 * src/maemo/modest-main-window.c: (create_details_widget),
1916 (modest_main_window_set_contents_style):
1917 Adapted to the use of the derived account instead of the folder store.
1919 * src/modest-ui-actions.c:
1920 (modest_ui_actions_on_folder_selection_changed):
1921 * src/modest-ui-dimming-rules.c:
1922 (modest_ui_dimming_rules_on_new_folder):
1923 * src/widgets/modest-folder-view.c: (text_cell_data),
1924 (icon_cell_data), (filter_row), (update_model),
1925 (get_cmp_rows_type_pos):
1928 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1929 Do not get the priv struct, because no priv struct has been set,
1930 to avoid a runtime warning.
1932 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1933 #ifelse with #else, to fix a warning, to fix the build.
1936 2007-06-05 Christian Kellner <ckellner@openismus.com>
1938 * libmodest-dbus-client/libmodest-dbus-client.c:
1939 Fix small typo in doc (why do you always see them
1940 AFTER committing stuff?)
1943 2007-06-05 Christian Kellner <ckellner@openismus.com>
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 (libmodest_dbus_client_search):
1947 Initialize hit list with NULL. Also set folder list
1948 to "" if NULL was supplied.
1951 2007-06-03 Christian Kellner <ckellner@openismus.com>
1953 * libmodest-dbus-client/libmodest-dbus-client.c:
1954 (modest_search_hit_list_free):
1955 Make it save to call it with NULL.
1957 * src/dbus_api/modest-dbus-callbacks.c:
1958 * src/modest-search.c:
1959 Return full ModestSearchHits as the search result list not TnyHeader
1960 since can't be around withouth the correspoding TnyFolder.
1962 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1964 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1965 Added currently commented code to check for secure auth
1967 * src/maemo/modest-account-settings-dialog.c: (on_response),
1968 (save_configuration), (show_ok):
1969 Fixed projects.maemo.org bugs NB #59248 and #59251
1971 * src/maemo/modest-maemo-utils.c:
1972 (on_camel_account_get_supported_secure_authentication_status),
1973 (on_camel_account_get_supported_secure_authentication),
1974 (modest_maemo_utils_get_supported_secure_authentication_methods):
1975 * src/maemo/modest-maemo-utils.h:
1976 Moved get_supported_secure_authentication() method here to be able
1977 to use it from easysetup wizard.
1979 * src/modest-pair.c: (on_pair_compare_as_string):
1980 Should compare string with first part of pair and not
1981 strcmp pairs which will crash.
1983 * src/modest-protocol-info.c:
1984 (modest_protocol_info_protocol_is_store):
1985 * src/modest-protocol-info.h:
1986 Added modest_protocol_info_get_auth_protocol_name()
1988 2007-06-03 Armin Burgmeier <armin@openismus.com>
1990 * src/modest-mail-operation.c:
1991 (modest_mail_operation_get_msgs_full): Set priv->account also when
1992 only retrieving a single message. This avoids a crash when canceling
1995 (modest_mail_operation_notify_end): Do not explicitely remove the
1996 operation from the queue but only emit the progress_changed signal.
1997 The queue itself listens to that signal to remove the operation when
1998 it is finished. This reduces coupling and removes a potential deadlock
1999 when modest_mail_operation_notify_end() is called from the queue
2000 itself. If that is a problem performance-wise, I would suggest to
2001 implement a status-changed signal or something.
2003 * src/modest-mail-operation-queue.c: Make sure to never call a
2004 function from another file while the queue is locked. This (hopefully)
2005 fixes another deadlock when exiting the application while retrieving
2008 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2010 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2011 Fixed build if libogs is not available
2013 2007-06-03 Christian Kellner <ckellner@openismus.com>
2015 * libmodest-dbus-client/libmodest-dbus-client.h:
2016 * libmodest-dbus-client/libmodest-dbus-client.c:
2017 (libmodest_dbus_client_delete_message):
2018 Implement deletion of messages (Client side).
2020 (modest_search_hit_free),
2021 (modest_search_hit_list_free):
2022 Utility functions to free the result hits.
2024 * src/dbus_api/modest-dbus-api.h:
2025 * src/dbus_api/modest-dbus-callbacks.c:
2026 (on_delete_message),
2027 (modest_dbus_req_handler):
2028 Implement deletion of messages (Server side).
2030 * tests/dbus_api/test_search.c: (main):
2033 * tests/dbus_api/Makefile.am:
2034 * tests/dbus_api/test_delete_message:
2035 Add little test for the message deletion logic
2037 2007-06-03 Armin Burgmeier <armin@openismus.com>
2039 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2040 when the operation queue was not empty. projects.maemo.org bug
2043 2007-06-03 Armin Burgmeier <armin@openismus.com>
2045 * src/widgets/modest-account-view.c
2046 (on_account_default_toggled): Toggle default account column
2047 explicitely instead of waiting for gconf notification (which is
2048 currently ignored). This should fix projects.maemo.org bug NB#56910
2049 for now. It should probably be removed when gconf notifications are
2052 2007-06-03 Christian Kellner <ckellner@openismus.com>
2054 * libmodest-dbus-client/libmodest-dbus-client.c:
2055 Removed debugging spew.
2057 * src/dbus_api/modest-dbus-callbacks.c:
2058 Added debugging info.
2060 * src/modest-search.c:
2061 (modest_search_all_accounts):
2062 Use tny_account_store_get_accounts () on the account store
2063 to get all accounts which is the way to get all accounts.
2065 * tests/dbus_api/test_search.c: (main):
2066 Make it possible to supply the search term on the command line.
2068 2007-06-03 Christian Kellner <ckellner@openismus.com>
2070 * libmodest-dbus-client/libmodest-dbus-client.c:
2071 * libmodest-dbus-client/libmodest-dbus-client.h:
2072 Implement searching for mesages over raw dbus. (Client side)
2074 * src/dbus_api/Makefile.am:
2075 * src/dbus_api/modest-dbus-api.h:
2076 * src/dbus_api/modest-dbus-callbacks.c:
2077 * src/dbus_api/modest-dbus-callbacks.h:
2078 Search framework (Server side). Also implement on_idle_open_message().
2080 * src/maemo/modest-platform.c: (modest_platform_init):
2081 Prepare for raw dbus/osso rpc interaction.
2083 * src/modest-search.h:
2084 Changed minsize from unspecific guint to guint32.
2086 * src/modest-search.c:
2088 Added strange hack which magically made tnymail work.
2090 (modest_search_folder),
2091 (modest_search_account),
2092 (modest_search_all_accounts):
2093 Implement helper functions to search all accounts, specific account
2096 * tests/dbus_api/Makefile.am:
2097 * tests/dbus_api/test_open_message.c:
2098 Read url to open from commandline.
2100 * tests/dbus_api/test_search.c:
2101 Implement small test for dbus search stuff
2103 2007-06-02 Armin Burgmeier <armin@openismus.com>
2105 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2106 include account type and account title. This fixes projects.maemo.org
2109 * src/maemo/modest-account-view-window.c: Set a title for the window.
2111 2007-06-02 Armin Burgmeier <armin@openismus.com>
2113 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2114 incoming and outgoing server name based on email address and server
2115 types as long as the names have not been edited manually. This fixes
2116 projects.maemo.org bug NB#58671.
2118 2007-06-02 Armin Burgmeier <armin@openismus.com>
2120 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2121 server type cannot be changed in future to the incoming details page
2122 when creating an account. This fixes projects.maemo.org bug NB#59029.
2124 2007-06-02 Armin Burgmeier <armin@openismus.com>
2126 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2127 and assigned max width chars so that they wrap instead of being
2128 truncated. Fixes projects.maemo.org bug NB#56126.
2130 2007-06-02 Armin Burgmeier <armin@openismus.com>
2132 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2133 introductory note to the connection specific smtp servers dialog, as
2134 section 8.12 of the email UI specification requires. This fixes
2135 projects.maemo.org bug NB#59212.
2137 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2140 Check for running mail operations, and offer to cancel them, as per the UI
2141 spec. This fixes projects.maemo.org bug NB#59041 .
2142 However, I suspect that tinymail may still use the network connection
2143 in ways that we cannot detect or cancel. But it should at least adapt to
2144 changes fairly well.
2146 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account-store.c: (recreate_all_accounts),
2149 (get_cached_accounts), (get_server_accounts): Do more sensible
2150 ref-counting of the temporarily-cached outbox accounts list. This seems
2151 to fix a crash when entering the password when the password was wrong.
2153 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2155 * src/gnome/modest-main-window.c: (connect_signals):
2156 * src/modest-tny-account-store.c: (get_password),
2157 (modest_tny_account_store_alert): Added comments and clues and
2158 commented-out code about how we currently fail to deal with connection
2159 errors and wrong passwords, and how we should.
2161 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2163 * src/widgets/modest-retrieve-combo-box.c:
2164 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2165 This fixes projects.maemo.org bug NB#58472 .
2167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2169 * src/maemo/easysetup/modest-easysetup-wizard.c:
2170 (create_page_complete_easysetup):
2171 (create_page_complete_custom): Correct the last commit,
2172 putting the correct sentences in the correct pages.
2174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/easysetup/modest-easysetup-wizard.c:
2177 (create_page_complete_custom): Show the second sentence of text
2178 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2181 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2184 Set the leave-on-server conf key by default. This fixes
2185 projects.maemo.org bug NB#59258 .
2187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2189 * src/maemo/modest-account-view-window.c:
2190 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2191 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/easysetup/modest-easysetup-wizard.c:
2197 (create_caption_new_with_asterisk):
2198 * src/maemo/modest-account-settings-dialog.c:
2199 (create_caption_new_with_asterisk):
2200 Uncomment the code to add the asterisk, because they are no longer in the
2201 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2202 (update_incoming_server_title): Add an asterisk here too.
2204 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/modest-maemo-global-settings-dialog.c:
2207 (current_connection): Check that we are even connected before trying to
2208 get the current connection name, to prevent a warning.
2210 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2211 Change the comments because tny_maemo_conic_device_connect() is now meant to
2213 * src/modest-mail-operation.c:
2214 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2215 make sure we have a connection and fail if we can't connect.
2217 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/modest-main-window.c:
2220 (on_account_store_connecting_finished): Do not try to get the
2221 connection ID if we are not really connected. I am surprised that
2222 this signal handler is called when we are not connected.
2224 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2226 * src/modest-error.h:
2227 * src/modest-ui-actions.c:
2228 (modest_ui_actions_get_msgs_full_error_handler):
2229 Renamed an enum, added comments, added an enum
2230 for retrieve-limit errors.
2232 * src/modest-mail-operation.c: (foreach_add_item),
2233 (internal_folder_observer_update), (update_account_thread),
2234 (modest_mail_operation_get_msgs_full):
2235 (modest_mail_operation_update_account),
2236 Added comments about how this works, and some code that should
2237 (but does not) check the retrieve-limit. See the TODO comment.
2239 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2241 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2242 Initialize help_id to fix the build. Warnings are good.
2244 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2246 * src/widgets/modest-hbox-cell-renderer.c:
2247 (modest_hbox_cell_renderer_append):
2248 * src/widgets/modest-vbox-cell-renderer.c:
2249 (modest_vbox_cell_renderer_append):
2250 Fix the last commit by doing an extra ref.
2252 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2254 * src/widgets/modest-hbox-cell-renderer.c:
2255 (modest_hbox_cell_renderer_append):
2256 * src/widgets/modest-vbox-cell-renderer.c:
2257 (modest_vbox_cell_renderer_append):
2258 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2259 to fix the build with Maemo Bora.
2260 However, there seems to be a remaining crash, probably due to reference
2263 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-tny-account.c:
2266 (modest_tny_account_new_for_local_folders):
2267 Use hildon_file_system_info_async_new() to get a better name for
2268 the memory card account, setting it as the account name.
2269 The timing seems to work, but this is probably
2270 not the best place to do this. See the TODO comment.
2271 * src/maemo/modest-main-window.c: (create_details_widget):
2272 * src/widgets/modest-folder-view.c: (text_cell_data):
2273 Use the tny account name instead of hardcoding a name.
2275 2007-05-30 Christian Kellner <ckellner@openismus.com>
2277 * src/modest-search.c: (modest_search):
2278 Correctly set part_search_func even if we have already parsed
2279 the query and thus a valid OgsTextSearcher object.
2281 2007-05-30 Christian Kellner <ckellner@openismus.com>
2284 Search and check for libogs.
2287 Incooparte the ogs build env.
2289 * src/modest-mime-part-search-stream.c:
2290 * src/modest-mime-part-search-stream.h:
2291 Removed since we do the real searching now in modest-search.c.
2293 * src/modest-search.c:
2294 * src/modest-search.h:
2295 Implement support for ogs. We use that if available and requested
2296 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2297 should now handle the corner case when the search term is spread
2298 across multiple reads.
2299 Also the logic in modest_search () was corrected to search all
2300 requested fields until one is found.
2302 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2304 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2306 * src/modest-init.h:
2307 * src/modest-init.c: Made modest_init_local_folders() take a
2308 path and be public so we can iniitialize maildir folders on
2311 * src/modest-local-folder-info.h:
2312 * src/modest-local-folder-info.c:
2313 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2315 * src/modest-tny-account.c:
2316 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2317 still means the standard local-folders path on the local volume.
2319 * src/modest-tny-account-store.c:
2320 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2321 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2322 all accounts when that happens.
2323 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2324 this too, so it shows up in the treeview.
2326 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-maemo-global-settings-dialog.c:
2329 (current_connection):
2330 * src/widgets/modest-global-settings-dialog.c:
2331 (current_connection_default):
2332 Use the enum values instead of 0, 1 and -1,
2333 to make the code clearer.
2335 * src/modest-account-mgr-helpers.c:
2336 (modest_account_mgr_get_connection_specific_smtp): Make this code
2339 * src/modest-runtime.h:
2340 * src/modest-runtime.c:
2341 Added modest_runtime_remove_all_send_queues().
2342 * src/maemo/modest-main-window.c:
2343 (on_account_store_connecting_finished): Recreate the send queues,
2344 using the appropriate transport accounts for this new connection.
2345 Some futher adapting might be needed if the old send queues are not
2346 automatically stopped at this point.
2348 * src/modest-tny-account-store.c: (get_server_accounts):
2349 Create the connection-specific transport accounts, so that they can
2350 be found later by their ID.
2352 * src/modest-tny-account.h:
2353 * src/modest-tny-account.c:
2354 Added modest_tny_account_new_from_server_account_name().
2355 modest_tny_account_new_from_server_account(): Do not create the
2356 send queues here, because they will be
2357 recreated anyway when the connection changes for the first time.
2359 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2361 * src/modest-local-folder-info.h:
2362 * src/modest-local-folder-info.c:
2363 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2364 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2365 tbox_folder): Take a modest account name instead of a server TnyAccount,
2366 so we can have per-modest-account rather than per-transport-account
2368 We must make sure that we change or recreate the exisitng send queues
2369 when the connection changes for connection-specific transport accounts.
2371 * src/modest-tny-account-store.c:
2372 (create_per_account_local_outbox_folders): Create outboxed per modest
2373 account, not per transport account.
2375 * src/modest-tny-account.h:
2376 * src/modest-tny-account.c:
2377 (modest_tny_account_get_special_folder): For outboxes, get the
2378 parent modest account name. The account is ignored for other folders.
2379 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2380 modest account name rather than a server TnyAccount.
2382 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-tny-account.c:
2385 (modest_tny_account_new_from_server_account):
2386 Call modest_runtime_get_send_queue() immediately after creating transport
2387 accounts, so that they start trying to send email from the outbox as soon
2388 as possible at startup. This is probably what we want.
2390 * src/modest-mail-operation.c: (update_account_thread):
2391 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2392 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2393 * src/modest-tny-send-queue.h:
2394 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2395 (modest_ui_actions_on_send):
2396 Added comments about how sending works, though it needs some more work.
2398 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2400 * src/modest-tny-account.c:
2401 (modest_tny_account_get_special_folder): Add TODO because this fails when
2402 the network is busy.
2403 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2404 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2405 Do not try to show this window when there is no active account. The UI
2406 specs does not tell us what to do in this case.
2408 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2412 * src/maemo/Makefile.am:
2413 * src/widgets/Makefile.am: Some dist fixes.
2415 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2417 * src/maemo/modest-connection-specific-smtp-window.c:
2418 (on_button_edit): Make the code clearer, to prevent a double free.
2420 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2422 * src/maemo/modest-account-settings-dialog.c:
2423 (modest_account_settings_dialog_set_account_name),
2424 Check the connection-specific smtp servers checkbox if there are any.
2426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2427 (modest_connection_specific_smtp_edit_window_init):
2428 Start with a suitable port number.
2430 * src/modest-account-mgr-helpers.h:
2431 * src/modest-account-mgr-helpers.c: Added
2432 modest_account_mgr_get_has_connection_specific_smtp().
2434 (modest_account_mgr_set_connection_specific_smtp),
2435 (modest_account_mgr_remove_connection_specific_smtp),
2436 (modest_account_mgr_get_has_connection_specific_smtp),
2437 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2438 connection-specific smtp server accounts in the account, rather than
2439 the server account conf dir.
2441 This fixes bug projects.maemo.org bug NB#58263 .
2443 * src/modest-tny-account-store.c:
2444 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2445 if there are no server accounts yet, to prevent an infinite loop when there
2446 are no accounts. Document that one must be called before the other.
2448 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2450 * src/modest-account-mgr-helpers.c:
2451 (modest_account_mgr_get_default_account): Make sure that at least
2452 one account is always the default, if there are any enabled accounts.
2453 This is just a sanity check that shouldn't be necessary.
2455 * src/modest-account-mgr-priv.c:
2456 (_modest_account_mgr_account_from_key): Unescape the conf key to
2457 get the real account name. For instance, this is an issue if a space
2458 was in the account name, which can happen because the account name
2459 is generated from the display name.
2460 (_modest_account_mgr_get_account_keyname): Always escape the
2462 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2463 Unescape the conf keys to get the real account names.
2465 For instance, previously the is-default radio button in the accounts
2466 list was not checked for any accounts at first. This fixes that,
2467 and might fix several similar bugs.
2469 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2471 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2472 Removed some debug printfs.
2474 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2476 Modest on-disk outbox directories are now here, for instance:
2477 $HOME/.modest/outboxes/<account-id-1>/outbox
2478 $HOME/.modest/outboxes/<account-id-2>/outbox
2480 $HOME/.modest/local-folders/outbox
2481 so we can have a separate outbox for each account.
2482 But they are shown as one outbox in the GtkTreeView, by using a
2483 TnyMergeFolder in a ModestTnySimpleFolderStore.
2486 * src/modest-tny-simple-folder-store.c:
2487 * src/modest-tny-simple-folder-store.h:
2488 Added ModestTnySimpleFolderStore, used to contain folders from
2489 other folder stores, such as other accounts.
2491 * src/modest-tny-outbox-account.h:
2492 * src/modest-tny-outbox-account.c:
2493 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2494 used for the per-account local outbox folders.
2496 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2497 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2498 only use this (internally) now for the non-outbox local folders.
2500 * src/modest-init.h:
2501 * src/modest-init.c: Added modest_init_one_local_folder(), for
2502 setting up the directory structure for each local folder.
2504 * src/modest-local-folder-info.c:
2505 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2506 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2508 * src/modest-local-folder-info.h:
2509 * src/modest-tny-account-store.c: (on_account_removed),
2510 (on_account_changed), (create_per_account_local_outbox_folders),
2511 (get_server_accounts), (modest_tny_account_store_get_accounts),
2512 (modest_tny_account_store_get_tny_account_by_account),
2513 (modest_tny_folder_store_is_virtual_local_folders):
2515 * src/modest-tny-account.h:
2516 * src/modest-tny-account.c:
2517 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2518 to create an on-disk per-account local outbox folder for each
2520 (create_per_account_local_outbox_folders): Create a local outbox folder
2521 for each transport account.
2522 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2523 for all local folders.
2525 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2526 instead of using g_object_get/set() directly. It is clearer.
2528 (modest_tny_folder_store_get_message_count),
2529 (modest_tny_folder_store_get_local_size
2530 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2531 because we now use these with non-acount folder stores.
2533 (modest_tny_account_get_special_folder),
2534 (modest_tny_account_new_from_server_account),
2535 (modest_tny_account_new_from_account):
2536 (recurse_folders): Adjust to the new outbox system.
2538 * src/modest-tny-folder.h:
2539 * src/modest-tny-folder.c:
2540 (modest_tny_folder_is_local_folder),
2541 (modest_tny_folder_get_local_folder_type),
2542 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2544 * src/widgets/modest-main-window.h:
2545 * src/maemo/modest-main-window.c: (create_details_widget),
2546 (modest_main_window_set_contents_style): Show details for any folder store,
2549 (modest_tny_folder_get_rules):
2550 Remove the const. C does not support constness enough for this.
2552 * src/modest-ui-actions.c:
2553 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2554 make all outboxes appear as one, in the usual local-folders tree node.
2556 (set_active_account_from_tny_account),
2557 (modest_ui_actions_on_folder_selection_changed):
2558 * src/widgets/modest-folder-view.c: (text_cell_data),
2559 (icon_cell_data), (filter_row),
2560 (add_account_folders_to_merged_folder),
2561 (add_account_folders_to_simple_folder_store), (),
2562 (get_cmp_rows_type_pos), (cmp_rows),
2563 (modest_folder_view_set_account_id_of_visible_server_account):
2564 Adjust to the new outbox system, using generic folder stores and folders
2565 in the GtkTreeModel.
2567 2007-05-23 Christian Kellner <ckellner@openismus.com>
2569 * src/modest-mail-operation.c:
2570 (modest_mail_operation_update_account):
2571 Use info->max_size instead of unintialized local var [small
2572 build fix]. (Added TODO to review that change since I don't
2575 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2577 * libmodest-dbus-client/libmodest-dbus-client.c:
2578 (libmodest_dbus_client_compose_mail): function added
2579 * src/dbus_api/modest-dbus-api.h:
2580 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2581 (on_compose_mail): Implementation of the SendAsMail functionality
2583 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2585 * src/modest-account-mgr.c:
2586 (modest_account_mgr_add_server_account): Set the secure-connection
2587 conf key for transport accounts as well as store accounts. I don't know
2588 why the if was there. For instance, this makes sure that we use SSL
2589 for the gmail preset from the easysetup wizard.
2591 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2593 * src/gnome/modest-main-window.c:
2594 (on_account_store_connecting_finished), (connect_signals):
2595 * src/maemo/modest-main-window.c:
2596 (on_account_store_connecting_finished), (connect_signals),
2597 (modest_main_window_new):
2598 Handle TnyAccountStore::connecting-finished instead of
2599 TnyDevice::connection-changed, because we cannot actually perform
2600 operations on accounts until TnyAccountStore has itself responded to
2601 the TnyDevice::connection-changed signal. This prevents a GError from
2603 Do not try to update at startup, because we (at least on scratchbox)
2604 already do an update at startup when the device goes online.
2605 This prevents a GError from tinymail.
2606 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2607 Added TODO about stopping simultaneous operations.
2609 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2611 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2612 * src/modest-mail-operation-queue.c:
2613 (modest_mail_operation_queue_remove):
2614 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2615 about where they happened.
2617 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2619 * src/modest-ui-actions.c:
2620 (modest_ui_actions_on_password_requested): Make sure that the remember
2621 output parameter is always TRUE.
2623 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2625 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2626 Show a OK/Cancel dialog if the error is a question, though we still do not
2627 know anything more about what we are asking the user.
2628 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2629 Fix an uninitialized variable (helper). This is a logic error, however.
2631 2007-05-21 Christian Kellner <ckellner@openismus.com>
2633 * src/modest-search.h:
2634 Correct bit shifting in the ModestSearchFlags enum.
2636 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2638 * src/modest-tny-account.c:
2639 (modest_tny_account_new_from_server_account): Do not use the lsub and
2640 check-all hard-coded IMAP options when using POP.
2642 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2644 * src/modest-tny-account.c:
2645 (modest_tny_account_new_from_server_account):
2646 Use NULL for the secure-auth method for POP when Password auth has been
2647 specified by the user, as we already do for IMAP. "auth=Login" causes
2648 an error from camel or the server.
2650 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2652 * src/maemo/modest-account-settings-dialog.c:
2653 (create_page_account_details),
2654 (modest_account_settings_dialog_set_account_name):
2655 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2656 for the leave-on-server checkbox, rathr than just the checkbox, when
2657 the protocol is not POP.
2659 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2661 * src/widgets/modest-account-view.c:
2662 * src/widgets/modest-account-view.h:
2663 Added modest_account_view_select_account() which will be useful later
2664 to asynchronously re-select the edited account.
2666 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-account-settings-dialog.c:
2669 (modest_account_settings_dialog_set_account_name):
2670 Automatically choose the port numbers based on the secure authentication
2671 methods, if they have not been chosen before.
2672 This fixes projects.maemo.org bug NB#56273 .
2674 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/modest-main-window-ui.h:
2677 * src/modest-ui-actions.c:
2678 * src/modest-ui-actions.h:
2679 Connect the Tools/SMTP Servers menu item to
2680 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2681 SMTP servers dialog, as in the UI specification and saves changes when it
2682 is closed. This fixed projects.maemo.org bug NB#56305 .
2684 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2686 * src/maemo/modest-connection-specific-smtp-window.c:
2687 (modest_connection_specific_smtp_window_init):
2688 Use gtk_window_set_default_size() to make this window big enough, so
2689 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2691 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2693 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2694 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2695 (modest_connection_specific_smtp_edit_window_init),
2696 Do not try to connect to a combobox signal before the combobox exists.
2697 This fixes the cras in projects.maemo.org bug NB#56288 .
2698 (modest_connection_specific_smtp_edit_window_get_settings):
2699 Remove the server_account_name parameter which was being checked for NULL
2700 though it was not used.
2702 * src/maemo/modest-connection-specific-smtp-window.c:
2703 (modest_connection_specific_smtp_window_fill_with_connections),
2704 (on_button_edit), (modest_connection_specific_smtp_window_init):
2705 Correct the number of treemodel columns to prevent a warning.
2706 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2707 libconic does not work.
2709 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2711 * src/modest-tny-account.c:
2712 (modest_tny_account_new_from_server_account):
2713 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2714 SMTP when "None" was chosen by the user. However, with my SMTP server that
2715 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2718 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2720 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2721 to explain the memory management issue with the ID in the ModestPair.
2723 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2724 (add_sending_page), (modest_account_assistant_finalize):
2725 * src/gnome/modest-gnome-global-settings-dialog.c:
2726 (create_updating_page), (create_composing_page):
2727 * src/gnome/modest-msg-edit-window.c: (get_transports),
2728 (init_window), (modest_msg_edit_window_finalize),
2729 (modest_msg_edit_window_get_msg_data):
2730 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2731 * src/gnome/modest-transport-widget.c:
2732 (modest_transport_widget_finalize), (smtp_configuration):
2733 * src/maemo/modest-maemo-global-settings-dialog.c:
2734 (create_updating_page), (create_composing_page):
2735 * src/maemo/modest-msg-edit-window.c: (get_transports),
2736 (init_window), (modest_msg_edit_window_finalize),
2737 (modest_msg_edit_window_get_msg_data),
2738 (modest_msg_edit_window_free_msg_data):
2739 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2740 (modest_store_widget_finalize):
2741 * src/maemo/modest-transport-widget.c:
2742 (modest_transport_widget_finalize), (smtp_configuration):
2743 * src/modest-main.c: (send_mail):
2744 * src/widgets/modest-combo-box.h:
2745 * src/widgets/modest-global-settings-dialog-priv.h:
2746 * src/widgets/modest-global-settings-dialog.c:
2747 (modest_global_settings_dialog_finalize):
2748 * src/widgets/modest-msg-edit-window.h:
2749 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2750 as long as the combo box, to prevent use of freed memory for the ID.
2752 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2754 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2755 get_accounts(), to make this clearer. Do not check for the enabled gconf
2756 key, because we do not use this for server accounts (at least, not yet).
2757 This allows us to send email again.
2759 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2761 * src/maemo/modest-platform.c:
2762 (on_modest_conf_update_interval_changed), (modest_platform_init):
2763 Only respond to this particular key change. All these strcmp()s cannot be
2766 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/modest-maemo-global-settings-dialog.c:
2769 (current_connection): Prevent a crash in scratchbox when
2770 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2771 * src/maemo/modest-platform.c:
2772 (on_modest_conf_update_interval_changed), (modest_platform_init):
2773 Get the update interval from gconf and reset it when the gconf key changes.
2775 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2777 * src/modest-protocol-info.c:
2778 * src/modest-protocol-info.h: Adde enum-specific get functions,
2779 instead of using a ModestProtocolType enum parameter.
2781 * src/gnome/modest-account-assistant.c:
2782 * src/gnome/modest-store-widget.c:
2783 * src/gnome/modest-store-widget.h:
2784 * src/gnome/modest-transport-widget.c:
2785 * src/gnome/modest-transport-widget.h:
2786 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2787 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2788 * src/maemo/easysetup/modest-easysetup-wizard.c:
2789 * src/maemo/modest-account-settings-dialog.c:
2790 * src/maemo/modest-account-settings-dialog.h:
2791 * src/maemo/modest-store-widget.c:
2792 * src/maemo/modest-store-widget.h:
2793 * src/maemo/modest-transport-widget.c:
2794 * src/maemo/modest-transport-widget.h:
2795 * src/modest-account-mgr-helpers.c:
2796 * src/modest-account-mgr-helpers.h:
2797 * src/modest-account-mgr.c:
2798 * src/modest-account-mgr.h:
2799 * src/modest-tny-account.c:
2800 * src/modest-tny-folder.c:
2801 * src/widgets/modest-account-view.c:
2802 * src/widgets/modest-retrieve-combo-box.c:
2803 * src/widgets/modest-retrieve-combo-box.h:
2804 * src/widgets/modest-secureauth-combo-box.c:
2805 * src/widgets/modest-serversecurity-combo-box.c:
2806 * src/widgets/modest-serversecurity-combo-box.h:
2807 * tests/check_account-mgr.c:
2808 Use the specific functions, and use the re-renamed enum values for GNOME too.
2810 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2812 * src/modest-pair.h:
2813 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2814 so we can get the second based on the first.
2816 * src/maemo/modest-account-settings-dialog.h:
2817 * src/maemo/modest-account-settings-dialog.c:
2818 Added get_supported_secure_authentication_methods(), though it is mostly
2819 commented-out for now until the necessary API is committed to tinymail.
2820 (modest_account_settings_dialog_set_account_name),
2821 (save_configuration): Request the supported authentication methods from the
2822 server, so we can choose a working method.
2824 * src/modest-tny-account-store.h:
2825 * src/modest-tny-account-store.c:
2826 (modest_tny_account_store_get_session): Rename from
2827 tny_account_store_get_session().
2829 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2831 * src/modest-protocol-info.h: Split the ModestProtocol enum
2832 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2833 There was no need to have these unrelated values in one enum.
2835 * src/: many files: Adapted to changed enum. This makes the code a bit
2836 clearer, and the compiler could catch some errors.
2838 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2840 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2841 Show the detailed internal camel error message when an error happens
2842 during the configuration, so that our testers can give us more clues.
2843 For instance, in projects.maemo.org bug NB#56910 .
2845 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2847 * src/modest-tny-account.c:
2848 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2849 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2851 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2853 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2854 * src/maemo/modest-account-settings-dialog.c:
2855 (modest_account_settings_dialog_set_account_name),
2856 (save_configuration): For the incoming secure authentication checkbox,
2857 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2858 the UI specification. PLAIN does not seem to be supported for most IMAP
2859 servers anyway, and I am not sure what it would mean.
2860 However, we probably need to discover which of the secure-authentication
2861 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2862 * src/modest-account-mgr-helpers.c:
2863 (modest_account_mgr_get_server_account_data):
2865 * src/modest-tny-account.c:
2866 (modest_tny_account_new_from_server_account):
2867 Use tny_account_set_mech() to set secure-authentication methods,
2868 with some special-casing for IMAP, based on my observations of how
2871 * src/modest-account-mgr-helpers.h:
2872 * src/modest-account-mgr.c:
2873 * src/modest-defs.h: Comment that the URI is only used for local folders.
2875 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2878 parameter const, just to be neat.
2879 * src/modest-text-utils.c: (modest_text_utils_inline):
2880 End g_strconcat() with NULL, as its documentation says. This is almost
2881 certainly the cause of my crash at startup on the device. Interestingly,
2882 valgrind doesn't tell us about these errors.
2884 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2886 * scripts/build-packages: Added more precise comments about how to use
2887 this script, though I still get this error:
2888 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2889 error building tinymail
2891 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/modest-main-window.c: (on_account_update):
2894 Very slight cleanup, hoping to make it simpler to discover what causes
2895 a crash here sometimes.
2897 * src/modest-tny-account.c:
2898 (modest_tny_account_new_from_server_account): Set the port. Added
2899 comments about the options and a TODO comment because I need to find out
2900 how to specify the secure authentication method.
2902 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2904 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2905 changed CFlags paths form modest to libmodest
2907 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2909 * src/modest-account-mgr-helpers.c:
2910 (modest_account_mgr_get_server_account_data),
2911 (modest_account_mgr_free_server_account_data):
2912 * src/modest-account-mgr-helpers.h:
2913 * src/modest-account-mgr.c:
2914 (modest_account_mgr_add_server_account):
2915 * src/modest-defs.h:
2916 * src/modest-tny-account.c:
2917 (modest_tny_account_new_from_server_account):
2918 Determine the options for tny_camel_account_add_option() here,
2919 based on the settings, rather than storing them directly in gconf.
2921 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2923 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2924 Show a more friendly error dialog now that we expect (from the tinymail
2925 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2927 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/modest-main-window.c: (on_account_update): Check that
2930 account_name is not NULL, to prevent a crash at startup that I am
2931 seeing on the N800. I do wonder why it is NULL.
2933 * src/maemo/easysetup/modest-easysetup-wizard.c:
2934 (create_page_user_details):
2935 * src/maemo/modest-account-settings-dialog.c:
2936 (create_page_user_details), (create_page_outgoing):
2937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2938 (modest_connection_specific_smtp_edit_window_init):
2939 * src/modest-ui-actions.c:
2940 (modest_ui_actions_on_password_requested):
2941 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2942 might do something useful with the on-screen keyboard.
2944 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2946 * src/maemo/modest-main-window.c: (on_account_update):
2947 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2948 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2950 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2952 * src/modest-tny-account-store.c: (on_account_changed):
2953 Correct the signature of this signal handler.
2955 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2957 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2958 Show a HildonNote instead of a GtkDialog for Maemo.
2960 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2962 * src/widgets/modest-account-view.h:
2963 * src/widgets/modest-account-view.c: (on_account_changed),
2964 (on_account_removed). Added a boolean flag, set/unset by
2965 modest_account_view_block_conf_updates(),
2966 modest_account_view_unblock_conf_updates() to prevent unnecessary
2967 updates, but this is not very useful because the gconf notifications are
2968 so delays (maybe only on Maemo Bora).
2969 So auto-updating is turned off, and these functions do an explicit
2970 update when necessary.
2971 However, something else is still doing too much work when adding/removing
2972 accounts, probably in another part of the application.
2974 * src/maemo/modest-account-view-window.c:
2975 (on_delete_button_clicked), (on_edit_button_clicked),
2976 (on_new_button_clicked): Use the new functions.
2978 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2980 * src/modest-account-mgr-helpers.c:
2981 (modest_account_mgr_set_first_account_as_default):
2982 Sort the list of names alphabetically-by-title, so we choose the first one
2984 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2985 alphabetically by the title.
2987 This fixes projects.maemo.org bug NB#56418 .
2989 * src/modest-account-mgr-priv.c:
2990 (_modest_account_mgr_account_from_key):
2991 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2992 avoid a valgrind error, and possible random behaviour.
2994 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2996 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2997 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2998 tinymail documentation to say that this can be expected.
2999 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3000 pretty, and should not happen, but I would prefer to know when it does.
3002 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3004 * configure.ac: When using the older hildon version, probably on Bora,
3005 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3007 * src/widgets/modest-attachment-view.c:
3008 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3011 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3013 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3014 Implemented the prototype. Can be tested with
3015 tests/dbus_api/test_open_message:
3017 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3019 * src/modest-tny-account-store.c:
3020 (modest_tny_account_store_instance_init), (get_password):
3021 * src/modest-ui-actions.c:
3022 (modest_ui_actions_on_password_requested):
3023 Do not store the password in gconf, because this function is called
3024 for non-remembered passwords. Actually use the cached (in the hash map)
3025 password instead of releasing it.
3026 The password will now not be remembered if it is asked via the protected
3027 password dialog, as per the UI spec.
3029 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3031 * src/modest-defs.h:
3032 * src/modest-account-mgr-helpers.h:
3033 * src/modest-account-mgr-helpers.c:
3034 Added modest_server_account_get_username_has_succeeded(),
3035 modest_server_account_set_username_has_succeeded().
3036 (modest_server_account_set_username),
3037 Reset the has-succeeded flag if the username changes.
3039 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3040 * src/maemo/modest-connection-specific-smtp-window.c:
3041 (modest_connection_specific_smtp_window_save_server_accounts):
3042 Use modest_server_account_set_username() instead of using
3043 modest_conf_set_string() directly, so that the has-succeeded flag is always
3046 * src/modest-ui-actions.c:
3047 (modest_ui_actions_on_password_requested): Dim the username entry if
3048 the username has ever worked, as per the UI spec.
3050 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3052 * src/modest-tny-account-store.c: (get_password):
3053 * src/modest-ui-actions.c:
3054 (modest_ui_actions_on_password_requested):
3055 Allow the username to be changed too, though there is more work to
3056 be done on exactly how this behaves.
3058 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-account-mgr-helpers.h:
3061 * src/modest-account-mgr-helpers.c:
3062 Added modest_account_mgr_get_display_name(),
3063 modest_server_account_get_username(),
3064 modest_server_account_set_username(),
3065 modest_server_account_set_password(),
3066 modest_server_account_get_hostname() functions so we do not need to
3067 use the conf API directly.
3069 * src/maemo/modest-main-window.c: (connect_signals):
3070 Actually connect ot the ModestAccountStore::request-password signal,
3071 so that we show the dialog when the password is requested by Tinymail,
3072 for isntance if it is empty.
3074 * src/modest-marshal.list:
3075 * src/modest-tny-account-store.c:
3076 (modest_tny_account_store_class_init), (get_password),
3077 (modest_tny_account_store_alert):
3078 * src/modest-tny-account-store.h:
3079 * src/modest-ui-actions.h:
3080 * src/modest-ui-actions.c:
3081 (modest_ui_actions_on_password_requested):
3082 Change the signal parameters, so it is obvious that we are providing
3083 the non human-readable server name, and receiving both the username
3084 and password, though changing of the username is not yet implemented.
3085 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3086 for the GNOME version.
3088 This should fix the projects.maemo.org bug NB#56209, though it does not
3089 work on Bora, because the gconf_client_get() for the password fails
3090 immediately after we save it with gconf_client_set().
3092 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3095 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3096 caused an undefined symbol error:
3097 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3101 * src/modest-tny-account-store.c:
3102 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3103 using a GError instead of a string message, so we can translate it in
3106 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3108 * src/maemo/modest-address-book.c:
3109 (modest_address_book_check_names):
3110 * src/maemo/modest-msg-view-window.c:
3111 (modest_msg_view_window_clipboard_owner_change):
3112 * src/modest-init.c: (modest_init_init_ui):
3113 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3114 (update_folders_cb), (modest_mail_operation_update_account):
3115 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3116 (modest_ui_actions_on_msg_attachment_clicked),
3117 (modest_ui_actions_on_msg_recpt_activated):
3118 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3119 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3120 (modest_msg_view_search_next):
3121 * src/widgets/modest-recpt-editor.c:
3122 (modest_recpt_editor_on_button_release_event),
3123 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3124 g_message(). At this point we should only be seeing interesting errors on
3125 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3127 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3129 (modest_wizard_dialog_force_title_update):
3130 * src/maemo/easysetup/modest-wizard-dialog.h:
3131 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3132 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3133 can update the title when appropriate. Otherwise the title is wrong if the
3134 pages are added after adding the notebook to the dialog.
3135 This must be a problem in HildonWizardDialog too.
3136 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3138 * src/maemo/easysetup/modest-easysetup-wizard.c:
3139 (create_subsequent_customsetup_pages),
3140 (create_subsequent_easysetup_pages):
3141 Call modest_wizard_dialog_force_title_update() so that the title is
3142 correct even with GTK+ < 2.10.
3143 This fixes projects.maemo.org bug NB#56145 .
3145 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3147 * src/maemo/modest-platform.c:
3148 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3149 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3152 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3154 * src/widgets/modest-window.h:
3155 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3156 and modest_window_save_state(), which invokes it.
3158 * src/widgets/modest-window-mgr.h:
3159 * src/widgets/modest-window-mgr.c:
3160 Added modest_window_mgr_save_state_for_all_windows(), which calls
3161 the save_state vfunc on all registered windows, if implemented.
3163 * src/gnome/modest-msg-edit-window.c:
3164 * src/gnome/modest-msg-view-window.c:
3165 * src/maemo/modest-msg-edit-window.c:
3166 * src/maemo/modest-msg-view-window.c:
3167 * src/maemo/modest-main-window.c:
3168 Specify the existing save_settings functions as implementations of
3169 ModestWindow::save_state_func().
3171 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3172 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3173 enabling hibernation, for instance.
3175 We may need to do the same thing for restoring settings.
3178 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3180 * src/widgets/modest-window-mgr.c:
3181 * src/widgets/modest-window-mgr.h:
3182 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3183 modest_window_mgr_get_hibernation_is_prevented().
3185 * src/maemo/modest-main-window.c:
3186 (on_hildon_program_is_topmost_notify): Prevent hibernation
3187 (possible when the application goes to the background in the WM),
3188 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3190 * src/maemo/easysetup/modest-easysetup-wizard.c:
3191 (modest_easysetup_wizard_dialog_init):
3192 * src/maemo/modest-account-settings-dialog.c:
3193 (modest_account_settings_dialog_init):
3194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3195 (modest_connection_specific_smtp_edit_window_init):
3196 * src/maemo/modest-connection-specific-smtp-window.c:
3197 (modest_connection_specific_smtp_window_init):
3198 * src/maemo/modest-signature-editor-dialog.c:
3199 (modest_signature_editor_dialog_init):
3200 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3201 prevent hibernation while any of these account settings dialogs are open.
3203 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/Makefile.am:
3206 * src/maemo/modest-osso-state-saving.c:
3207 * src/maemo/modest-osso-state-saving.h: Added
3208 modest_osso_load_state() and modest_osso_save_state() though they do
3209 nothing now. They should iterate through all the open windows and load/save
3211 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3212 save state when closing.
3214 * src/maemo/modest-main-window.c:
3215 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3216 Add a notification handler for the HildonProgram::is-topmost property,
3217 so we can allow hibernation when the application goes into the background.
3218 But we still need to detect when the accounts setup windows are open so
3219 we can stop hibernation when they are open.
3220 To do this, I also added the main window the HildonProgram. This might have
3221 other side-effects/benefits, and should maybe be done for other windows.
3223 * src/maemo/modest-osso-autosave-callbacks.h:
3224 * src/maemo/modest-osso-autosave-callbacks.c:
3225 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3226 though it does not do anything yet, and we might never need this to do
3227 anything. For instance, we already save drafts.
3229 * src/maemo/modest-platform.c: (modest_platform_init):
3230 Specify the libosso auto-save callback.
3232 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3234 * src/maemo/modest-platform.c:
3235 (modest_platform_set_update_interval):
3236 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3237 aparently stays valid between application instances, so we can use this
3238 to remove and reset it later. According to a maemo-developers email from
3241 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3243 * configure.ac: Depend on libalarm for Maemo.
3245 * src/dbus_api/modest-dbus-api.h:
3246 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3247 (on_send_receive), (modest_dbus_req_handler):
3248 Handle a SEND_RECEIVE D-Bus method.
3250 * libmodest-dbus-client/libmodest-dbus-client.c:
3251 (libmodest_dbus_client_send_and_receive):
3252 * libmodest-dbus-client/libmodest-dbus-client.h:
3253 Add C convenience functions for calling the new D-Bus method.
3255 * src/modest-platform.h:
3256 * src/gnome/modest-platform.c:
3257 * src/maemo/modest-platform.c:
3258 Added modest_platform_set_update_interval(), which uses the
3259 alarmd API on Maemo.
3260 (modest_platform_init),
3261 Call modest_platform_set_update_interval(), using a hard-coded
3262 interval for now (until the global settings dialog is implemented),
3263 though I am not sure that this makes sense yet.
3265 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3267 * src/dbus_api/modest-dbus-callbacks.c:
3268 (modest_osso_cb_hw_state_handler):
3269 * src/dbus_api/modest-dbus-callbacks.h:
3270 * src/maemo/modest-platform.c: (modest_platform_init):
3271 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3272 in case this has some effect on the ability for Maemo to ping the
3275 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3277 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3278 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3279 warning. It is probably a logic error, but I need to fix the build.
3281 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3283 * src/modest-account-mgr.h:
3284 * src/modest-account-mgr.c:
3285 (modest_account_mgr_account_names): Add a gboolean enabled_only
3286 parameter, so we can get lists of onlt the enabled accounts.
3288 (modest_account_mgr_add_account),,
3289 (modest_account_mgr_account_with_display_name_exists):
3290 * src/maemo/modest-msg-edit-window.c: (get_transports):
3291 * src/modest-account-mgr-helpers.c:
3292 (modest_account_mgr_set_first_account_as_default):
3293 * src/modest-init.c: (init_default_account_maybe):
3294 * src/modest-tny-account-store.c: (get_accounts):
3295 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3296 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3297 * tests/check_account-mgr.c: (START_TEST):
3298 Provide the extra parameter, as appropriate.
3300 * src/widgets/modest-account-view.c: (update_account_view):
3301 Do not show disabled accounts (meaning that there is no way to
3302 enable/disable accounts in the UI (the feature is not in our UI
3303 specification), so we can use this internally only to mark unfinished
3304 or temporary account data.
3306 * src/maemo/easysetup/modest-easysetup-wizard.c:
3307 (create_account): Add boolean enable parameter, so we can specify FALSE
3308 to create the temporary account.
3309 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3310 (on_before_next): When finishing, when there is a temporary account, just
3312 Also, use a timeout to delay the showing of the dialog until gconf is likely
3313 to return correct information, due to a maemo gconf bug that is fixed in
3314 osso 1.1, but not yet in Bora.
3315 However, the dialog stays on screen after it is destroyed.
3317 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3318 for invalid data when cancelling. Use a hildon note instead of a dialog
3319 to complain about invalid data. Do not show the account-saved note if the
3320 account is disabled (a temporary account that will not really be saved for use
3323 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3325 * src/modest-account-mgr-helpers.h:
3326 * src/modest-account-mgr-helpers.c:
3327 Added modest_account_mgr_unset_default_account(),
3328 Added modest_account_mgr_set_first_account_as_default().
3330 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3331 If it was the default account, unset the default account name.
3333 * src/maemo/modest-account-view-window.c:
3334 (on_delete_button_clicked): If it was the default account,
3335 set the first remaining account as the default instead.
3337 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3338 a NULL account or a NULL default account, to prevent a crash. This should
3339 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3342 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3344 * src/widgets/modest-recpt-editor.c:
3345 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3346 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3347 TODO comment for this. This fixes the build.
3349 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3350 be the best place for it. This will in future update all auto-update accounts,
3351 rather than just the current/default account, when that gconf key exists.
3352 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3353 if there are no accounts, before calling do_send_receive().
3354 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3356 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3357 * src/maemo/modest-main-window-ui.h:
3358 * src/maemo/modest-main-window.c: (on_connection_changed),
3359 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3360 directly, becaue the signal handler does more.
3362 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3364 * src/modest-account-mgr-helpers.c:
3365 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3366 for the case that the account does not exist.
3368 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3369 (equivalent to the modest account name) rather than the tinymail account name
3370 (equivalent to the modest account title - human readable) to get the account data.
3371 Check for null account data to prevent the crash, and add a TODO comment saying that
3372 this needs fixing because it is using the server account name instead of the account name.
3374 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3376 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3377 * src/maemo/modest-account-settings-dialog.c: (show_error),
3379 Use hildon_note_new_information() for informative and error messages,
3380 which seems to be expected for Maemo applications (no documentation that I know of
3381 says this). I am surprised that there is no distinction between info and error
3384 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3386 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3387 it is easy to find where this is used.
3389 * src/maemo/easysetup/modest-easysetup-wizard.c:
3390 (create_page_welcome), (create_page_account_details),
3391 (create_page_user_details), (create_page_complete_easysetup),
3392 (create_page_custom_incoming), (create_page_custom_outgoing),
3393 (create_page_complete_custom):
3394 * src/maemo/modest-account-settings-dialog.c:
3395 (create_page_account_details), (create_page_user_details),
3396 (create_page_incoming), (create_page_outgoing):
3397 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3398 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3399 (modest_connection_specific_smtp_edit_window_init):
3400 * src/maemo/modest-connection-specific-smtp-window.c:
3401 (modest_connection_specific_smtp_window_init):
3402 * src/maemo/modest-signature-editor-dialog.c:
3403 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3404 and scrolling policy as per the Email Application Layout Guide, if I have
3407 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3409 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3410 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3411 which were empty, because these vfuncs have been removed from TnyAccountStore.
3412 This fixes the build.
3414 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/modest-main-window.c:
3417 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3418 showing/hiding it. Added TODO because it probably should not be NULL.
3419 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3420 because unnecessary g_warnings() make degugging difficult.
3422 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/modest-msg-edit-window.c:
3425 (modest_msg_edit_window_select_color),
3426 (modest_msg_edit_window_select_background_color): 2 const corrections and
3427 moving 2 #endifs before closing brackets, to fix the build.
3429 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/easysetup/modest-easysetup-wizard.h:
3432 * src/maemo/easysetup/modest-easysetup-wizard.c:
3433 (modest_easysetup_wizard_dialog_finalize),
3434 (on_button_edit_advanced_settings), (create_page_complete_custom),
3435 (on_response), (create_account):
3436 Implement the Advanced Settings edit button, by saving the account information,
3437 for the Advanded Settings dialog to use directly from gconf, and removing it
3438 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3439 Bug #5533 in the projects.maemo.org bugzilla.
3441 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3443 * src/maemo/modest-msg-view-window.c:
3444 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3445 when opening a message window.
3447 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/easysetup/modest-easysetup-wizard.c:
3450 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3453 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3454 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3455 gconf settings. I probably added more checks than necessary, but that is safer.
3457 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3458 variable to fix the build, but this seems to be used when it is still NULL.
3460 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3462 * src/modest-platform.h:
3463 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3464 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3465 * src/modest-main.c: Implement this function so we can avoid using
3466 maemo-specific API from cross-platform code.
3468 * src/modest-tny-account-store.c:
3469 (get_smtp_specific_transport_account_for_open_connection):
3470 * src/modest-ui-actions.c: (check_for_connection),
3471 (modest_ui_actions_on_item_not_found):
3472 Use modest_platform_connect_and_wait() and put #idefs around other
3473 maemo-specific code, because only maemo currently has a way to
3474 identify connection names.
3476 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3478 * src/modest-tny-account-store.h:
3479 * src/modest-tny-account-store.c:
3480 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3481 the connection-specific SMTP server settings in the configuration.
3483 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3485 * src/maemo/modest-main-window.c: (on_connection_changed),
3487 * src/modest-main.c: (main), (start_ui), (send_mail):
3488 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3489 that is what is intended.
3491 * src/modest-ui-actions.c: (action_send), (action_receive),
3492 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3493 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3494 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3495 SMTP server is used when it is specified.
3497 (modest_ui_actions_on_send_receive):
3498 Check that a connection is open before proceeding.
3499 Receive and then send, instead of vice-versa, as per the specification.
3501 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3503 * src/modest-mail-operation.c:
3504 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3505 though I guess it should be something other than NULL.
3507 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3509 * src/maemo/easysetup/modest-easysetup-wizard.c:
3510 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3511 combo twice, to avoid an g_warning and to make it visible again.
3512 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3513 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3514 (already intended) dereference when detaching, because we then recreate the menu.
3515 But I am not sure why the warning was happening, and it is possible that this is a memory
3518 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3520 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3521 and uri_parse_mailto() utility functions.
3522 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3524 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3526 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3528 * src/dbus_api/modest-dbus-api.h:
3529 * src/dbus_api/modest-dbus-callbacks.c:
3530 Use an idle callback to execute the modest code in the application's own thread.
3531 Remove the helloworld example method.
3532 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3533 parsed, and the open-message method is not implemented because this is not yet implemented in
3535 * libmodest-dbus-client/libmodest-dbus-client.c:
3536 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3537 (libmodest_dbus_client_open_message):
3538 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3540 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3541 body without crashing.
3543 * tests/dbus_api/Makefile.am:
3544 * tests/dbus_api/test_mail_to.c:
3545 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3547 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3549 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3550 Added file to fix the build. Sorry.
3552 * src/dbus_api/Makefile.am:
3553 * src/dbus_api/modest-dbus-api.h:
3554 * src/dbus_api/modest-dbus-callbacks.h:
3555 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3556 (modest_dbus_req_handler):
3557 Put constants in a separate header so it can be reused by the
3558 client library, without duplication
3560 * libmodest-dbus-client/Makefile.am:
3561 * libmodest-dbus-client/libmodest-dbus-client.c:
3562 (libmodest_dbus_client_call_helloworld),
3563 (libmodfest_dbus_client_send_mail),
3564 (libmodfest_dbus_client_mailto),
3565 (libmodfest_dbus_client_open_message):
3566 * libmodest-dbus-client/libmodest-dbus-client.h:
3567 (Partly) Implement a send_mail D-Bus method.
3569 * tests/dbus_api/Makefile.am:
3570 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3571 the send_email D-Bus method.
3573 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3577 * libmodest-dbus-client/Makefile.am:
3578 * libmodest-dbus-client/libmodest-dbus-client.c:
3579 * libmodest-dbus-client/libmodest-dbus-client.h:
3580 * tests/dbus_api/Makefile.am:
3581 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3582 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3584 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3586 * src/maemo/easysetup/modest-easysetup-wizard.c:
3587 (create_page_account_details):
3588 * src/maemo/modest-account-settings-dialog.c:
3589 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3590 widgets, because this might not be the default in future versions of the Maemo GTK+.
3591 However, I can not not get capitalization to work even in a simple test case.
3593 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3595 * src/maemo/easysetup/modest-easysetup-wizard.c:
3596 (create_page_custom_incoming), (create_page_custom_outgoing):
3597 * src/maemo/modest-account-settings-dialog.c:
3598 (create_page_account_details), (create_page_incoming),
3599 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3600 instead of using gtk_check_button_with_label(), so they are aligned like the other
3601 widgets, as per the UI spec.
3603 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/easysetup/modest-easysetup-wizard.c:
3606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3607 * src/widgets/modest-validating-entry.c:
3608 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3609 Modest prefix instead of an EasySetup prefix.
3611 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3613 * src/widgets/modest-validating-entry.h:
3614 * src/widgets/modest-validating-entry.c: (on_insert_text),
3615 Added easysetup_validating_entry_set_max_func(), used to set a callback
3616 to call when the max number of characters is reached. GtkEntry has a max-length
3617 already but is silent about it.
3619 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3620 (create_page_account_details), (create_page_user_details),
3622 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3623 (create_page_account_details), (create_page_user_details),
3624 (create_page_outgoing):
3625 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3626 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3627 the UI spec, when the user tries to enter more than the max number of characters.
3629 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3631 * src/maemo/easysetup/modest-easysetup-wizard.c:
3632 (create_page_user_details), (create_page_custom_incoming),
3633 (create_page_custom_outgoing):
3634 * src/maemo/modest-account-settings-dialog.c:
3635 (create_page_user_details), (create_page_incoming),
3636 (create_page_outgoing):
3637 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3638 (modest_connection_specific_smtp_edit_window_init):
3639 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3640 not appropriate. Bad Maemo-specific defaults!.
3642 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3644 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3645 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3646 (modest_signature_editor_dialog_set_settings):
3647 Disable the label and textview when the checkbox is disabled, and use the
3648 specified (UI spec) default signature text.
3650 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3653 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3655 * src/modest-defs.h:
3656 * src/modest-account-mgr-helpers.h:
3657 * src/modest-account-mgr-helpers.c:
3658 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3660 * src/maemo/Makefile.am:
3661 * src/maemo/modest-signature-editor-dialog.c:
3662 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3665 * src/maemo/modest-account-settings-dialog.h:
3666 * src/maemo/modest-account-settings-dialog.c:
3667 (modest_account_settings_dialog_finalize), (on_button_signature),
3668 (save_configuration): Use the new dialog when the Edit button is pressed, and
3669 save the changes if necessary, as per the UI spec.
3671 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3673 * src/maemo/Makefile.am:
3674 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3675 based on maemo-develoers email from Dirk.
3677 * src/maemo/easysetup/modest-easysetup-wizard.c:
3678 (create_page_welcome), (create_page_account_details),
3679 (create_page_user_details), (create_page_complete_easysetup),
3680 (create_page_custom_incoming), (create_page_custom_outgoing),
3681 (create_page_complete_custom),
3682 (modest_easysetup_wizard_dialog_init):
3683 * src/maemo/modest-account-settings-dialog.c:
3684 (create_page_account_details), (create_page_user_details),
3685 (create_page_incoming), (create_page_outgoing),
3686 (modest_account_settings_dialog_init):
3687 * src/maemo/modest-connection-specific-smtp-window.c:
3688 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3690 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3692 * src/maemo/easysetup/modest-easysetup-wizard.c:
3693 (create_page_account_details), (create_page_custom_outgoing),
3694 (create_page_complete_custom):
3695 * src/maemo/modest-account-settings-dialog.c:
3696 (create_page_user_details), (create_page_incoming),
3697 (create_page_outgoing):
3698 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3699 (modest_connection_specific_smtp_edit_window_init):
3700 Use the correct (UI spec) port min/max, and use horizontal separators,
3703 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3705 * src/maemo/easysetup/modest-easysetup-wizard.c:
3706 (set_default_custom_servernames):
3707 * src/maemo/modest-account-settings-dialog.c:
3708 (create_page_incoming), (on_combo_outgoing_security_changed),
3709 (on_combo_incoming_security_changed), (create_page_outgoing),
3710 (modest_account_settings_dialog_set_account_name),
3711 (save_configuration):
3712 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3713 (on_combo_security_changed),
3714 (modest_connection_specific_smtp_edit_window_init),
3715 (modest_connection_specific_smtp_edit_window_set_connection),
3716 (modest_connection_specific_smtp_edit_window_get_settings):
3717 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3720 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3723 * src/maemo/easysetup/modest-easysetup-wizard.c:
3724 (create_page_custom_outgoing), (create_page_complete_custom):
3725 * src/maemo/modest-account-settings-dialog.c:
3726 (create_page_user_details), (create_page_outgoing):
3727 * src/maemo/modest-account-view-window.c: (button_box_new):
3728 Use changed logical IDs as per the most recent UI spec:
3729 mcen_bd_emailsetup_edit -> mcen_bd_edit
3730 mcen_bd_emailsetup_delete -> mcen_bd_delete
3731 mcen_bd_emailsetup_close -> mcen_bd_close
3733 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3737 * src/dbus_api/Makefile.am:
3738 * src/dbus_api/modest-dbus-callbacks.c:
3739 * src/dbus_api/modest-dbus-callbacks.h:
3740 * src/maemo/modest-platform.c: (modest_platform_init):
3741 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3743 * tests/Makefile.am:
3744 * tests/dbus_api/Makefile.am:
3745 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3747 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3749 * src/maemo/modest-account-settings-dialog.c:
3750 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3751 Removed unnecessary includes.
3753 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3755 * src/maemo/easysetup/modest-easysetup-wizard.c:
3756 * src/maemo/modest-account-settings-dialog.c:
3757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3758 * src/widgets/Makefile.am:
3759 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3760 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3761 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3762 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3763 * src/widgets/modest-secureauth-combo-box.c:
3764 * src/widgets/modest-secureauth-combo-box.h:
3765 * src/widgets/modest-serversecurity-combo-box.c:
3766 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3767 made the GObject names more consistent with the rest of the Modest code.
3769 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/easysetup/Makefile.am:
3772 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3773 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3774 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3775 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3776 * src/maemo/easysetup/modest-easysetup-wizard.c:
3777 * src/maemo/easysetup/modest-validating-entry.c:
3778 * src/maemo/easysetup/modest-validating-entry.h:
3779 * src/maemo/modest-account-settings-dialog.c:
3780 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3781 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3782 widgets/ because they are used outside of easysetup too. After checking in,
3783 svn will allow me to rename them too.
3785 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3787 * src/gnome/modest-msg-edit-window.c:
3788 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3789 linker error, to fix the build on the GNOME platform.
3790 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3791 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3792 ifdefed out to avoid a warning.
3794 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3796 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3797 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3798 some alternative for GTK+ 2.6.
3800 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3802 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3804 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3805 specified for EmailAccountsDialog in UI spec.
3807 * src/maemo/easysetup/modest-easysetup-wizard.c:
3808 * src/maemo/easysetup/modest-easysetup-wizard.h:
3809 * src/maemo/modest-account-settings-dialog.c:
3810 * src/maemo/modest-account-settings-dialog.h:
3811 Reuse a member window widget for the connection-specific SMTP server accounts,
3812 so we can tell it to create/save the accounts only if we actually save changes.
3814 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3816 (modest_connection_specific_smtp_edit_window_get_settings):
3817 Return a struct instance for temporarily remembering the entered data.
3819 * src/maemo/modest-connection-specific-smtp-window.h:
3820 * src/maemo/modest-connection-specific-smtp-window.c:
3821 (modest_connection_specific_smtp_window_finalize),
3822 (modest_connection_specific_smtp_window_fill_with_connections),
3824 (modest_connection_specific_smtp_window_save_server_accounts),
3825 (update_model_server_names): Do not actually save data until asked,
3826 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3828 (on_selection_changed),
3829 (modest_connection_specific_smtp_window_init): Disable the edit
3830 button when nothing is selected.
3832 * src/modest-account-mgr-helpers.c:
3833 * src/modest-account-mgr-helpers.h:
3834 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3837 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3839 * src/modest-account-mgr-helpers.h:
3840 * src/modest-account-mgr-helpers.c:
3841 (modest_account_mgr_get_unused_account_name),
3842 (modest_account_mgr_get_unused_account_display_name): Added these
3843 utility functions, to avoid code duplication.
3845 * src/maemo/easysetup/modest-easysetup-wizard.c:
3846 (create_page_account_details), (create_account):
3847 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3848 (on_combo_security_changed),
3849 (modest_connection_specific_smtp_edit_window_init),
3850 (modest_connection_specific_smtp_edit_window_save_settings):
3851 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3852 * src/maemo/modest-connection-specific-smtp-window.c:
3853 (modest_connection_specific_smtp_window_finalize),
3854 (modest_connection_specific_smtp_window_fill_with_connections),
3855 (on_button_edit), (modest_connection_specific_smtp_window_init):
3856 * src/maemo/modest-connection-specific-smtp-window.h:
3857 Implementing saving of connection-specific server accounts.
3859 But I need to refactor this so we can save the data for each
3860 possible connection-specific account and only actually create the server accounts
3861 when the easysetup finished, or the OK button is pressed on the account settings
3864 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3867 (on_combo_security_changed):
3868 (modest_connection_specific_smtp_edit_window_init):
3869 Auto-fill the port number as in the account settings.
3871 (modest_connection_specific_smtp_edit_window_set_connection):
3872 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3873 * src/maemo/modest-connection-specific-smtp-window.c:
3874 (fill_with_connections), (on_button_edit),
3875 (modest_connection_specific_smtp_window_init):
3876 Turn the edit window into a dialog to simplify the code, and
3877 set a WM hint as in a GtkDialog, because only a popup can be on top of
3878 another window in Maemo, and popups usually have no WM decoration.
3880 * src/modest-defs.h:
3881 * src/modest-account-mgr-helpers.c:
3882 (modest_account_mgr_set_connection_specific_smtp),
3883 (modest_account_mgr_remove_connection_specific_smtp),
3884 (modest_account_mgr_get_connection_specific_smtp):
3885 * src/modest-account-mgr-helpers.h: Some functions to write the
3886 connection-specific SMTP server information. Not yet used.
3889 * src/widgets/modest-folder-view.c: (text_cell_data):
3890 Fix a warning about an uninitialized variable.
3891 (on_configuration_key_changed): Put an #ifdef around the use
3892 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3894 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3896 * src/maemo/modest-account-settings-dialog.h:
3897 * src/maemo/modest-account-settings-dialog.c:
3898 Added connect_for_modified() utility function to mark the new modified boolean.
3900 (create_page_account_details), (create_page_user_details),
3901 (create_page_incoming), (create_page_outgoing), (on_response),
3902 (modest_account_settings_dialog_init),
3903 (modest_account_settings_dialog_set_account_name):
3904 Only warn about unsaved changes when there are actually unsaved changes.
3906 * src/modest-account-mgr-helpers.c:
3907 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3908 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3909 to get the data from there in future.
3911 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3913 * src/modest-defs.h:
3915 * src/modest-account-mgr-helpers.h:
3916 * src/modest-account-mgr-helpers.c:
3917 Store the security account setting in a single conf key instead of using
3918 the options list, so that the list is left for just the to-be-removed camel hack,
3919 and because gconf_client_set_list() is failing for some reason.
3921 * src/modest-account-mgr.c:
3922 (modest_account_mgr_add_server_account):
3923 * src/maemo/modest-account-settings-dialog.c:
3924 (modest_account_settings_dialog_set_account_name),
3925 (save_configuration): Use the renamed functions.
3928 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3930 * src/widgets/Makefile.am:
3931 * src/widgets/modest-limit-retrieve-combo-box.c:
3932 * src/widgets/modest-limit-retrieve-combo-box.h:
3933 * src/widgets/modest-retrieve-combo-box.c:
3934 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3935 the account settings dialog.
3937 * src/modest-defs.h:
3938 * src/modest-account-mgr-helpers.h:
3939 * src/modest-account-mgr-helpers.c:
3940 (modest_server_account_get_option_secure_auth),
3941 (modest_server_account_set_option_secure_auth):
3942 * src/modest-account-mgr.c:
3943 (modest_account_mgr_add_server_account):
3944 Use the existing AUTH_MECH conf key for the secure-auth setting,
3945 instead of putting it in the list options, because this was actually used already.
3947 * src/maemo/modest-account-settings-dialog.c:
3948 (create_page_account_details),
3949 (modest_account_settings_dialog_set_account_name),
3950 (save_configuration):
3951 * src/maemo/modest-account-settings-dialog.h:
3952 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3953 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3955 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3957 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3958 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3959 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3961 * src/modest-defs.h:
3962 * src/maemo/modest-account-settings-dialog.c:
3963 (create_page_incoming), (on_combo_outgoing_security_changed),
3964 (on_combo_incoming_security_changed), (create_page_outgoing),
3965 (modest_account_settings_dialog_set_account_name),
3966 (save_configuration): Load/Save the port number, and change it when the
3967 security combo changes, to suitable defaults.
3969 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3971 * src/modest-account-mgr.c:
3972 (modest_account_mgr_add_server_account): Set the security and secure-auth
3973 options, and add a comment saying that the other camel-specific options should be
3976 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3978 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3980 * src/modest-tny-account-store.c: (account_list_free),
3981 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3982 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3985 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3987 * src/modest-protocol-info.c:
3988 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3989 is required by our UI spec. Maybe something in our implementation will use this eventually.
3990 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3991 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3992 instead of the previous 0 placeholder.
3994 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3995 secure-auth settings.
3996 * src/modest-account-mgr-helpers.h:
3997 * src/modest-account-mgr-helpers.c:
3998 (modest_server_account_data_get_option_secure_auth),
3999 (modest_server_account_set_option_secure_auth),
4000 (modest_server_account_data_get_option_security),
4001 (modest_server_account_set_option_security): Added this API for getting and setting the security
4002 and secure-auth settings.
4004 * src/maemo/modest-account-settings-dialog.h:
4005 * src/maemo/modest-account-settings-dialog.c:
4006 (modest_account_settings_dialog_finalize), (check_data),
4007 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4008 about changing titles.
4009 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4010 (save_configuration): Save the security and secure-auth settings.
4012 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4013 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4015 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4017 * src/modest-defs.h:
4018 * src/modest-account-mgr.c:
4019 (modest_account_mgr_add_server_account):
4020 Added and used defines for the options key and value pair strings,
4021 that are used so far, though they do not seem to correspond to anything in our
4022 UI specs or ModestProtocol enum.
4024 * src/modest-account-mgr-helpers.h:
4025 * src/modest-account-mgr-helpers.c:
4026 (compare_option_strings_for_name),
4027 (modest_server_account_data_get_option_value),
4028 (modest_server_account_data_get_option_bool),
4029 (modest_account_mgr_get_server_account_option):
4030 Added helper functions for parsing the options GSList.
4032 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4034 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4035 display name is based on the supplied account name.
4036 * src/modest-account-mgr.c:
4037 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4038 with an inefficient, but good-enough, implementation.
4040 * src/maemo/easysetup/modest-easysetup-wizard.c:
4041 (create_page_account_details), (on_before_next), (create_account):
4042 Check for existing display names rather than (non-user-visible) account names, and just
4043 create and set a unique account name at the end.
4045 * src/maemo/modest-account-settings-dialog.c:
4046 (modest_account_settings_dialog_init),
4047 (modest_account_settings_dialog_set_account_name),
4048 (create_page_incoming): Show the display name, instead of the account name.
4049 (on_response): Do some (not all) extra checks, as in the UI spec.
4050 (save_configuration): Save the display name if it was changed.
4052 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4054 * po/en_GB.po: Added needed logical ID and translation.
4055 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4056 (init_view): Made the is-default column clicking work.
4058 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4061 * src/maemo/easysetup/Makefile.am:
4062 * src/maemo/easysetup/modest-easysetup-wizard.c:
4063 (modest_easysetup_wizard_dialog_init):
4064 * src/maemo/easysetup/provider-data-test.keyfile:
4065 * src/maemo/easysetup/provider-data.keyfile:
4066 Moved the provider data file to the new modest-providers-data package and used it from there.
4068 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4070 * src/modest-local-folder-info.c:
4071 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4072 N_() was already used on the static strings, but this just marks it for translation without
4073 using the translation.
4075 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4077 * src/maemo/modest-account-settings-dialog.c:
4078 (create_page_incoming),
4079 (modest_account_settings_dialog_set_account_name):
4080 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4081 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4082 I will do this if nobody else gets there first.
4084 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4086 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4087 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4088 save the security stuff.
4090 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4092 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4093 Set the email address and user fullname, which I now see must be
4096 * src/maemo/modest-account-settings-dialog.h:
4097 * src/maemo/modest-account-settings-dialog.c:
4099 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4100 leave-on-server and authentication.
4101 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4104 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4107 * src/maemo/modest-account-settings-dialog.c:
4108 * src/maemo/modest-account-settings-dialog.h:
4109 Most (but not all) of the widgets are now present as specified by the UI spec.
4110 No changes are yet saved, and some details are not properly shown yet.
4112 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4114 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4116 * src/maemo/Makefile.am:
4117 * src/maemo/modest-account-settings-dialog.c:
4118 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4119 an existing account. Doesn't do much yet.
4121 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4122 Open the accounts settings dialog when Edit is clicked.
4124 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4126 * src/maemo/easysetup/Makefile.am:
4127 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4129 * src/maemo/easysetup/modest-easysetup-wizard.c:
4130 (modest_easysetup_wizard_dialog_init):
4131 Try to get the source directory from the build system,
4132 instead of hard-coding "./" into the source code, when opening our local
4133 copies of the configuration files.
4134 But this still fails when opening the wizard from the Accounts window,
4135 maybe because the working directory seems to change at runtime.
4136 So the wizard will fail the second time unless you copy the files into their
4137 proper locations - see the stdout warnings for the paths.
4139 (create_page_account_details),(on_before_next):
4140 Check for existing non-server accounts instead of server accounts,
4141 so the default account name is useful again, and to prevent trying to
4144 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4145 Show the wizard when New is clicked.
4147 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4148 (init_view): Show the column headers, and show the columns that are
4149 specified in the UI specs. However, something in Maemo's GTK+ prevents
4150 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4151 change the default account. This is despite unsetting the special properties.
4153 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4155 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4156 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4157 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4158 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4159 to make that clearer.
4160 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4162 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4164 * src/maemo/modest-account-view-window.c:
4165 (modest_account_view_window_init),
4166 (modest_account_view_window_new):
4167 Use the same buttons as specified in the
4168 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4169 the existing widgets, which never had a chance of working.
4170 Put the ModestAccountView treeview in a scrolled window.
4171 Do not repeat the initialization in both _init() and _new().
4173 * src/widgets/modest-account-view.c: (update_account_view):
4174 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4175 this widget and window shows no accounts.
4177 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4179 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4181 * src/maemo/easysetup/modest-easysetup-wizard.c:
4182 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4183 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4184 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4187 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4188 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4189 accounts exist yet, as in the UI spec.
4191 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4193 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/Makefile.am:
4196 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4197 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4198 New window for editing connection-specific smtp details.
4199 Not fully implemented.
4201 * src/maemo/modest-connection-specific-smtp-window.c:
4202 (modest_connection_specific_smtp_window_finalize) :
4203 unref the tree model.
4204 (on_button_edit): Show the edit window.
4206 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4208 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4211 * src/maemo/Makefile.am:
4212 * src/maemo/modest-connection-specific-smtp-window.c:
4213 * src/maemo/modest-connection-specific-smtp-window.h:
4214 New window for showing the list of connections, for connection-specific
4215 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4216 * src/maemo/easysetup/modest-easysetup-wizard.c:
4217 (create_page_custom_outgoing): Show the new window when the button is clicked.
4219 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4221 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4222 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4223 * src/maemo/modest-msg-edit-window.c:
4224 (modest_msg_edit_window_insert_image):
4225 * src/modest-conf.c: (modest_conf_key_escape):
4226 * src/modest-mail-operation.c:
4227 (modest_mail_operation_send_new_mail):
4228 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4229 (modest_ui_actions_on_new_account):
4230 * src/widgets/modest-attachment-view.c: (update_filename_request):
4231 * src/widgets/modest-mail-header-view.c:
4232 Corrected warnings that were breaking the build, by commenting out unused variables,
4233 and a function, and by including a header.
4235 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4237 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4238 so we can #ifdef around platform-specific code when necessary.
4239 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4240 to allow this to build for the GNOME platform too.
4242 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4244 * src/maemo/easysetup/modest-easysetup-wizard.c:
4245 Added util_increment_name() and used it in create_page_account_details()
4246 to make sure that the default account name is always a new name.
4248 (modest_easysetup_wizard_dialog_init),
4249 (set_default_custom_servernames): Some minor memory management fixes.
4251 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4255 * src/modest-runtime.c: (init_i18n): Restored the translation
4256 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4257 are defined in config.h, and the translations are installed.
4259 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4260 is defined for translation.
4262 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4264 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4266 * src/maemo/easysetup/modest-easysetup-wizard.c:
4267 (modest_easysetup_wizard_dialog_init):
4268 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4269 Use realistic paths (though they should use $prefix generically) to the
4270 mcc_mapping and provider-data.keyfile files which might work when they
4271 are installed by the future version of the operator-wizard package,
4272 and then fallback to paths in our source code, with an explanatory
4275 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4279 * src/maemo/Makefile.am:
4280 * src/maemo/easysetup/: Added files from the previously-exernal
4281 osso-modest-easysetup.
4282 * src/maemo/modest-main-window-ui.h:
4283 * src/modest-ui-actions.c:
4284 * src/modest-ui-actions.h:
4285 Added modest_ui_actions_on_new_account() as a signal handler for the
4286 New Account menu item. It shows the easysetup wizard.
4287 * po/en_GB.po: Added additional needed logical IDs and translations.