1 2007-08-29 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: (modest_search_all_accounts):
4 * src/modest-platform.h:
5 * src/maemo/modest-platform.c: Moved and renamed
6 check_and_wait_for_account_is_online() to
7 modest_platform_check_and_wait_for_account_is_online() so it
8 can be used in more places.
10 2007-08-29 Murray Cumming <murrayc@murrayc.com>
12 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
13 Removed the sleep(1) experiment because it does not seem to help,
14 and I should not have checked the experiment in anyway.
15 The problem is maybe in the TnyAccount connected state - I will
16 investigate that instead.
18 2007-08-28 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
21 Added a sleep(1) in case it helps with bug #66769.
23 2007-08-28 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-search.c: (on_timeout_check_account_is_online),
26 (check_and_wait_for_account_is_online):
27 It is OK for local-folder and mmc accounts to be used when they
28 are in the _INIT folder, instead of waiting for them to change
30 For POP and IMAP, wait from them to stop being _INIT, rather than
31 waiting from them to be _CONNECTED, because that seems to be
32 the status that causes the problems.
34 2007-08-28 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-search.c: (check_and_wait_for_account_is_online):
37 Actually pass the account to the timeout callback.
39 2007-08-28 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-search.c: (on_timeout_check_account_is_online):
42 Added some debug output to help me debug a problem on the N800.
43 (check_and_wait_for_account_is_online): Fail immediately if the
45 modest_search_all_accounts(): Try the search even if the account does
46 not seem to be online, because this can work sometimes, and should work
47 with the cache if there is no active libconic connection.
49 2007-08-27 Armin Burgmeier <armin@openismus.com>
51 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
52 observe outbox for added messages to assign them a status. Previously,
53 this was done in modest_tny_send_queue_add(), but the message id might
54 not yet be known at that point. This reduces warnings when sending
55 mail, though I am not sure how this even worked before.
57 2007-08-27 Murray Cumming <murrayc@murrayc.com>
59 * src/maemo/modest-account-settings-dialog.c:
60 (modest_account_settings_dialog_init):
61 * src/maemo/modest-connection-specific-smtp-edit-window.c:
62 (modest_connection_specific_smtp_edit_window_init):
63 * src/maemo/modest-connection-specific-smtp-window.c:
64 (modest_connection_specific_smtp_window_init):
65 * src/maemo/modest-maemo-utils.c:
66 (modest_maemo_utils_get_supported_secure_authentication_methods):
67 * src/maemo/modest-platform.c:
68 (modest_platform_run_folder_name_dialog):
69 * src/maemo/modest-signature-editor-dialog.c:
70 (modest_signature_editor_dialog_init):
71 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
72 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
73 * src/widgets/modest-global-settings-dialog.c:
74 (modest_global_settings_dialog_init):
75 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
77 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
78 GTK_STOCK_EDIT with mcen_bd_edit, and
79 GTK_STOCK_CLOSE with mcen_bd_close,
80 to fix projects.maemo.org bug NB#64995.
81 I strongly believe that Maemo's GTK+ should have the wanted translations
82 instead of duplicating this in each application and complicating the code.
84 2007-08-27 Armin Burgmeier <armin@openismus.com>
86 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
87 recursion when entering text in the subject field.
89 2007-08-27 Murray Cumming <murrayc@murrayc.com>
91 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
92 which checks every second, 10 times, to wait until the account is online
93 so that we can use it, if the account is in the process of going online.
94 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
95 so that searching works even when the application was not yet started before.
96 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
98 2007-08-24 Armin Burgmeier <armin@openismus.com>
100 * src/modest-widget-memory.c: Always show the default account when the
101 application is started, as stated in the UI spec. This fixes
102 projects.maemo.org bug NB#66630.
104 2007-08-24 Armin Burgmeier <armin@openismus.com>
106 * src/maemo/modest-platform.c:
107 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
108 english text for strings in the rename folder dialog, fixing
109 projects.maemo.org bug NB#66338.
111 2007-08-22 Armin Burgmeier <armin@openismus.com>
113 * src/widgets/modest-account-view.c: Fix for bora by using
114 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
115 latter seems not be used anymore.
117 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
120 * src/maemo/modest-main-window.c: Update menu items when the default
121 account changes so that the current default account is always bolded.
122 This fixes maemo.projects.org bug NB#66173.
124 2007-08-17 Murray Cumming <murrayc@murrayc.com>
126 * src/dbus_api/modest-dbus-callbacks.c:
127 (on_dbus_method_get_folders): Avoid trying to get the account name
128 when there are no accounts, to avoid critical g_warnings, fixing
129 projects.maemo.org bug NB#65574.
131 2007-08-17 Murray Cumming <murrayc@murrayc.com>
133 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
134 Use modest_account_mgr_get_signature() instead of accessing gconf
135 directly, to slightly simplify the code.
136 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
137 Append the signature also when opening via other applications,
138 fixing projects.maemo.org bug NB#65828.
140 2007-08-17 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
143 Check for NULLs to prevent a crash when opening an email that is
144 an attachment in another email, fixing projects.maemo.org bug
147 2007-08-17 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-ui-dimming-rules.c:
150 (modest_ui_dimming_rules_on_view_window_move_to):
151 Enable the Move To toolbar button for search results, fixing the
152 last part of projects.maemo.org bug NB#63807.
154 2007-08-17 Murray Cumming <murrayc@murrayc.com>
156 * src/dbus_api/modest-dbus-callbacks.c:
157 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
158 because this is called from idle handlers, to fix hangs afte the
160 (find_message_by_url): Added a TODO comment about a crash that
161 happens when tinymail was built with DBC checks.
163 2007-08-16 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-search.c: (modest_search_folder):
166 * src/modest-search.h: Rename ModestSearch::before to start_date
167 and after to end_date, using the same names as the libogs struct
169 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
170 The start_date and end_date were swapped in the check. This
171 fixes date range searches, fixing projects.maemo.org bug NB#63407.
173 2007-08-16 Murray Cumming <murrayc@murrayc.com>
175 * src/maemo/modest-account-view-window.c:
176 Added (check_for_active_acount).
177 (on_delete_button_clicked), (on_edit_button_clicked):
178 When an account is doing something (such as refreshing),
179 show the same warning for account deletion as for account
180 editing, to fix projects.maemo.org bug NB#64588.
182 2007-08-16 Murray Cumming <murrayc@murrayc.com>
184 * src/widgets/modest-msg-view-window.h:
185 * src/gnome/modest-msg-view-window.c:
186 * src/maemo/modest-msg-view-window.c:
187 Added modest_msg_view_window_construct().
188 (modest_msg_view_window_new_with_header_model),
189 Added modest_msg_view_window_new_for_search_result),
190 Renamed modest_msg_view_window_new() to
191 modest_msg_view_window_new_for_attachment(),
192 and modest_msg_view_window_is_search_result(),
193 so we can explicitly know that the window is for an
194 attachment or a search result or a message from the list.
196 (modest_msg_view_window_view_attachment):
197 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
198 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
199 Use modest_msg_view_window_new_for_search_result().
201 * src/modest-ui-dimming-rules.c:
202 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
203 for search results, fixing projects.maemo.org bug NB#63811.
205 2007-08-16 Armin Burgmeier <armin@openismus.com>
207 * src/modest-ui-actions.c: Show a banner instead of a dialog when
208 renaming a folder fails, to stay consistent with what happens when
209 creating a folder fails.
211 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
212 slightly country loading from the mmc_mappings file, fixed a memory
215 2007-08-16 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-tny-account-store.c: (volume_path_is_mounted):
218 Check the GnomeVFSVolume activation path instead of the device path,
219 so that the memory card is really really shown in the UI.
221 2007-08-16 Murray Cumming <murrayc@murrayc.com>
223 * src/maemo/easysetup/modest-easysetup-wizard.c:
224 (get_entered_account_title), (on_before_next), (entry_is_empty),
226 * src/maemo/modest-account-settings-dialog.c:
227 (get_entered_account_title), (on_button_signature), (check_data),
228 (save_configuration), (entry_is_empty):
229 Strip the account title of whitespace at the start and end before
230 using it or checking it. This means that an all-whitespace title
231 is not allowed, fixing projects.maemo.org bug NB#64977.
233 2007-08-15 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-ui-actions.h:
236 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
237 to modest_run_account_setup_wizard() and made it public.
238 * src/dbus_api/modest-dbus-callbacks.c:
239 (check_and_offer_account_creation), (on_idle_mail_to),
240 (on_idle_compose_mail), (on_idle_open_default_inbox):
241 Offer account creation if necessary, fixing projects.maemo.org
244 2007-08-15 Murray Cumming <murrayc@murrayc.com>
246 * src/modest-ui-actions.c: (run_account_setup_wizard):
247 Return a gboolean to indicate success.
248 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
249 (modest_ui_actions_on_send): When offering account creation, only
250 give up (return) if account creation failed. Otherwise continue
251 with the original request. This fixed projects.maemo.org bug
254 2007-08-15 Murray Cumming <murrayc@murrayc.com>
256 * src/widgets/modest-recpt-editor.c:
257 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
258 to fix projects.maemo.org bug NB#63789.
260 2007-08-15 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
263 (modest_tny_account_store_new): Properly detect the memory card at
264 startup, and add an account for it.
266 2007-08-14 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
269 Commented out the MMC code again because it mistakenly detects
270 the card even when it isn't inserted.
272 2007-08-14 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
275 Renabled the call to add_mmc_account() because I do not believe
276 it could be the cause of the mentioned hang (in scratchbox, where
277 there is no memory card), and because I have tested that it works
280 2007-08-14 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
283 Comment out part of the last commit because it apparently causes
286 2007-08-14 Murray Cumming <murrayc@murrayc.com>
288 * src/modest-tny-account-store.c: Added the add_mmc_account()
289 function to save some copy/pasting.
290 (modest_tny_account_store_new): If the memory card is mounted,
291 create an account for it at the start, instead of waiting for the
292 user to unmount it and mount it.
294 2007-08-13 Murray Cumming <murrayc@murrayc.com>
296 * src/widgets/modest-account-view.c: (on_account_changed):
297 Do not try to use the human-readable TnyAccount name instead of the
298 ID of the modest account to get the transport account. And unref
299 the transport account. This prevents a g_warning(), and a possible
302 2007-08-13 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/modest-platform.c:
305 (modest_platform_set_update_interval): Handle the new
306 alarmd error to warn when alarmd is not running, as is the case in
307 scratchbox for me now because
308 "Module /usr/lib/alarmd/libretu.so initialization failed"
310 2007-08-13 Murray Cumming <murrayc@murrayc.com>
312 * src/widgets/modest-header-view-render.c:
313 (_modest_header_view_compact_header_cell_data):
314 NULL some strings after freeing them, trying to deal with
315 the double deletion found in projects.maemo.org bug 64183,
316 probably having no effect.
318 2007-08-13 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/modest-account-settings-dialog.c:
321 (create_page_incoming), (create_page_outgoing): Use a define
322 for the min and max port numbers.
324 (check_hildon_number_editor_and_warn_value_not_in_range),
325 (check_data): Do an extra check for an invalid port number, as needed
326 in projects.maemo.org bug #64275, when the number is cleared, but this
327 does not work due to bugs.maemo.org bug #1806.
329 2007-08-13 Murray Cumming <murrayc@murrayc.com>
331 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
332 Comment out the debug warning about the unexpected D-Bus methods.
333 They are just annoying now.
334 * src/maemo/modest-platform.c:
335 (modest_platform_set_update_interval): Correct the D-Bus path, instead
336 of using a file path, though it did not seem to break things before.
337 It might be needed now:
338 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
339 modest is not already running. This is the behaviour of the old client, and
340 Mox says it is what we should do for modest.
341 This closes projects.maemo.org bug NB#64327.
343 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
345 * src/modest-text-utils.c:
346 Fixed invalid jump due to incorrect string/pointer
348 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
351 2007-08-01 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-account-mgr-helpers.h:
354 * src/modest-account-mgr-helpers.c:
355 Added modest_account_mgr_get_first_account_name(),
356 using code from modest_account_mgr_set_first_account_as_default().
358 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
359 (account_number_changed): Call set_at_least_one_account_visible() so that
360 the first account is visible when first added, without the user having to
362 I do wonder how this worked before.
364 2007-08-01 Murray Cumming <murrayc@murrayc.com>
366 * src/modest-tny-account-store.c: (show_password_warning_only),
367 (show_wrong_password), (request_password_and_wait), (get_password),
368 (modest_tny_account_store_alert): Remove the (incomplete anyway)
369 attempts to show UI only in the main context, which used g_idle_add()
370 and mainloops, because tinymail now guarantees that it only calls these
371 callbacks in the mainloop with the gdk lock. This makes everything much
374 2007-08-01 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
377 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
378 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
379 error dialog, instead of ignoring it.
381 2007-08-01 Murray Cumming <murrayc@murrayc.com>
383 * src/maemo/modest-msg-view-window.c:
384 (modest_msg_view_window_get_header),
385 (modest_msg_view_window_last_message_selected):
386 Added comments to explain the use of priv->header_model.
387 * src/modest-ui-dimming-rules.c:
388 (modest_ui_dimming_rules_on_open_msg),
389 (modest_ui_dimming_rules_on_mark_as_read_msg),
390 (modest_ui_dimming_rules_on_mark_as_unread_msg),
391 (modest_ui_dimming_rules_on_remove_attachments),
392 (_invalid_attach_selected), (_selected_msg_marked_as):
393 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
394 and changed the parameter to a ModestMainWindow to make it clearer that
395 it never uses any other kind of window.
396 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
397 instead of the selected message.
398 I notice that much of the dimming code and the ModestMsgViewWindow code
399 hard-codes the assumption that the viewed message is always selected in
400 the header view. This does not seem wise or simple.
402 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
403 examine the actual message instead of whatever might be selected
404 in the header view. This stops the delete toolbar button and menu item
405 from being dimmed when opening a message view the search UI,
406 partially fixing projects.maemo.org bug NB#63811.
408 However, when actually deleting, I now get this warning:
409 "tny_header_set_flags: This is a header instance for a new message.
410 Only priority and attachment flags are supported"
412 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
414 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
416 Show account wizard if no accounts are defined while sending
417 (automatic sending after the account wizard finished does not
418 work because it takes some time until the account manager
419 synchronizes everything. (projects.maemo.org NB#62792)
421 2007-07-30 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-tny-account-store.c: (on_account_removed),
424 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
425 account is removed from the View menu. We have TnyAccountStore
426 and ModestTnyAccountStore signals that seem very similar, but this
427 seems to work for now.
429 * src/maemo/modest-main-window.c:
430 (on_show_account_action_activated): Prevent dereference
431 of a NULL if the accoutn does not really exist, though that
432 should not happen anymore.
434 This fixes projects.maemo.org bug NB#64606.
436 2007-07-30 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-ui-actions.c: (run_account_setup_wizard),
439 (modest_ui_actions_on_accounts): Revert a change that set these
440 to modal dialogs, freezing the UI when they show secondary dialogs.
441 This fixed projects.maemo.org bug NB#64519.
443 2007-07-27 Murray Cumming <murrayc@murrayc.com>
445 * src/widgets/modest-header-view-render.c:
446 (_modest_header_view_compact_header_cell_data):
447 Some checks and initialization to try to deal with a crash,
448 probably ineffective.
450 2007-07-27 Murray Cumming <murrayc@murrayc.com>
452 * src/maemo/modest-maemo-utils.c:
453 (modest_maemo_utils_get_supported_secure_authentication_methods):
454 Make sure that we have a connection, asking the user for one
456 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
457 Check for a connection before showing the wizard, because
458 the wizard needs a connection to check for server capabilities.
460 2007-07-27 Murray Cumming <murrayc@murrayc.com>
462 * src/maemo/modest-account-view-window.c:
463 (on_new_button_clicked): Remember the wizard dialog instance,
464 so we can just present it again if necessary. This prevents
465 multiple windows from appearing if you click again quickly on the
466 New button before the dialog appears, fixing projects.maemo.org
469 2007-07-27 Murray Cumming <murrayc@murrayc.com>
471 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
472 Offer a connection dialog if there is no connection when
473 starting modest. This should fix projects.maemo.org bug NB#61134.
475 2007-07-27 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
478 Reverted my last commit. I was able to fix the build by doing
479 apt-get install wpeditor0 (replacing other wpeditor packages) and
480 an explicit apt-get install wpeditor-dev to upgrade the -dev
483 2007-07-27 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
486 Commented out the use of wp_text_buffer_replace_image()
487 because it does not exist, to break the build. Added a TODO for it.
489 2007-07-26 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-tny-account-store.c: (recreate_all_accounts):
492 Recreate them even if they were NULL before. I guess something
493 else was already creating them before, or this would never
495 (modest_tny_account_store_get_server_account): Make sure that
496 the tny accounts have been created before trying to find one.
497 This allows libmodest_dbus_client_compose_mail() to work
498 when the UI is not yet visible.
499 This is probably useful in other cases too.
501 (get_password): When the password is wrong after it is entered
502 in the protected password dialog, show an info banner (in an
503 idle handler) before showing the protected password dialog
506 2007-07-26 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-ui-actions.h:
509 * src/modest-ui-actions.c: Added
510 modest_do_refresh_current_folder() containing some code from
511 modest_ui_actions_on_send_receive().
512 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
513 Call modest_do_refresh_current_folder() before refreshing the
514 requested account, as in modest_ui_actions_on_send_receive().
515 This is strange, but seems to be necessary to show new mails.
516 Now new emails are finally visible in the UI when downloaded
517 via the automatic update interval, fixing bug NB#57458.
518 This also works because bug NB#57458 has been fixed somehow.
520 2007-07-26 Murray Cumming <murrayc@murrayc.com>
522 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
523 printf more details when we get unhandled D-Bus methods, because
526 * src/modest-mail-operation.c: (update_account_thread):
527 Comment out the tny_camel_pop_store_account_reconnect(), because this
528 is apparently no longer needed, and it did not work before anyway.
529 See the comment in the code.
531 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
532 by checking the header flags. This fixes projects.maemo.org bug
535 2007-07-25 Murray Cumming <murrayc@murrayc.com>
537 * src/maemo/modest-maemo-utils.h:
538 * src/maemo/modest-maemo-utils.c: Added
539 modest_maemo_show_information_note_in_main_context_and_forget().
540 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
541 Use the new function to show simple error dialogs in the main
542 context, though question dialogs are still in the current context,
543 which is unfortunately usually not the main context. This should
546 2007-07-25 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-tny-account-store.c: (get_password):
549 Never save the entered username and password in gconf,
550 because the UI spec says we should not. This helps
551 slightly with projects.maemo.org bug NB#63671.
553 2007-07-25 Murray Cumming <murrayc@murrayc.com>
555 * src/widgets/modest-msg-edit-window.h:
556 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
557 Moved some code here to make it simpler.
558 (modest_msg_edit_window_attach_file_one): Renamed from
559 modest_msg_edit_window_attach_file_interactive().
560 (modest_msg_edit_window_offer_attach_file): Renamed from
561 modest_msg_edit_window_attach_file() and used
562 modest_msg_edit_window_attach_file_one() instead of
563 copy/pasting the code. The old code for one was not using
564 GnomeVFS. This allows use of smb:// URLs when using send-as
565 from external applications, fixing bug NB#63741.
567 (modest_msg_edit_window_insert_image),
568 (modest_msg_edit_window_add_attachment_clicked):
569 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
570 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
571 Adapted to the new function names.
573 2007-07-25 Murray Cumming <murrayc@murrayc.com>
575 (modest_platform_set_update_interval): Set the alarm recurrence
576 fields so that auto-update does not just happen the first time.
577 This should have fixed projects.maemo.org bug NB#63938.
579 When this happens you can see a printf when the D-Bus method is
581 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
583 However, I do not actually seem to get new POP messages even when
584 clicking the refresh button manually. A restart gets them.
585 This might be a problem in today's tinymail only.
587 2007-07-24 Murray Cumming <murrayc@murrayc.com>
589 * src/maemo/modest-maemo-global-settings-dialog.c:
590 (current_connection):
591 Avoid a crash (probably only in scratchbox) when strcmp()ing a
592 NULL when closing the dialog.
594 2007-07-24 Murray Cumming <murrayc@murrayc.com>
596 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
597 Remove the hacky send/receive that didn't work, and instead
598 refilter the treemodel to make the deleted email really vanish from
599 the UI (though the delete-from-menu code does has commented out
600 the code that does that). This fixes projects.maemo.org bug
603 2007-07-24 Murray Cumming <murrayc@murrayc.com>
605 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
606 Try a couple of tricks to force the treeview to update (
607 poke the folder, and do a send/receive refresh), but the deleted
608 email still appears with a strike-through instead of really being
611 2007-07-23 Murray Cumming <murrayc@murrayc.com>
613 * src/dbus_api/modest-dbus-callbacks.c:
614 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
615 because their ID is not human-readable (see the comment about
616 improvements needed to the osso-email-interface API) and
617 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
619 2007-07-23 Murray Cumming <murrayc@murrayc.com>
621 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
622 (add_folders_to_list), (on_dbus_method_get_folders),
623 (modest_dbus_req_filter):
624 * src/maemo/modest-maemo-utils.c:
625 (on_camel_account_get_supported_secure_authentication):
626 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
627 (on_header_view_focus_in):
628 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
629 * src/modest-formatter.c: (modest_formatter_create_body_part):
630 * src/modest-mail-operation.c: (recurse_folders),
631 (update_account_thread), (get_msgs_full_thread),
632 (modest_mail_operation_get_msgs_full),
633 (modest_mail_operation_xfer_msgs):
634 * src/modest-search.c: (search_mime_part_and_child_parts),
635 (modest_search_account), (modest_search_all_accounts):
636 * src/modest-tny-account.c:
637 (modest_tny_account_get_special_folder), (recurse_folders):
638 * src/modest-tny-local-folders-account.c:
639 (modest_tny_local_folders_account_query_passes):
640 * src/modest-tny-msg.c: (copy_mime_part),
641 (modest_tny_msg_find_body_part_from_mime_part):
642 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
643 (modest_tny_send_queue_try_to_send):
644 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
645 (_modest_ui_actions_open), (download_uncached_messages),
646 (reply_forward), (modest_ui_actions_on_copy),
647 (modest_ui_actions_on_details), (has_retrieved_msgs),
648 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
650 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
651 (_selected_msg_marked_as), (_msg_download_completed),
652 (_selected_msg_sent_in_progress):
653 * src/widgets/modest-attachments-view.c:
654 (modest_attachments_view_set_message):
655 * src/widgets/modest-msg-view.c: (find_cid_image):
656 * tests/check_folder-transfer.c: (find_folders):
657 * tests/check_update-account.c: (func):
658 * tests/dbus_api/test_get_folders.c: (main):
659 Checked all uses of tny_iterator_get_current(), making sure
660 that the object is unreferenced (3 or 4 places did not),
661 and adding checks for NULL.
663 2007-07-23 Murray Cumming <murrayc@murrayc.com>
665 * src/dbus_api/modest-dbus-callbacks.c:
666 (on_idle_open_default_inbox): Make sure that the application UI is
668 * src/maemo/easysetup/modest-easysetup-wizard.c:
669 (on_entry_invalid_character): Show the word whitespace instead
670 of (null) in the banner when whitespace was entered.
671 (show_error): Add a comment that this does not work in
672 Maemo Bora, though we do not know why.
674 2007-07-23 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-tny-account.c:
677 (modest_tny_account_get_special_folder): Use an if instead of
678 an assert for when the parent account name is NULL, because this
679 might be causing a crash in projects.maemo.org bug 63192.
680 * src/modest-mail-operation.c:
681 (modest_mail_operation_send_new_mail_cb),
682 (modest_mail_operation_remove_folder): unref the folder that is
683 returned from modest_tny_account_get_special_folder().
685 2007-07-23 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-ui-actions.c:
688 (modest_ui_actions_on_password_requested):
689 Show mail_ib_login_cancelled info banner when the user cancels
690 the protected password dialog, to fix projects.maemo.org
693 2007-07-23 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/modest-account-settings-dialog.c:
696 (create_page_outgoing): Put this page in a GtkScrolledWindow,
697 matching the UI mock-up in the UI spec, and allowing access
698 to all widgets even when the on-screen keyboard is active.
700 2007-07-23 Murray Cumming <murrayc@murrayc.com>
702 Reverted this previous commit from Johannes,
703 because the scrollbars are always visible and because
704 I think we only need it on onepage of the account
705 settings, not the account wizard.
706 (I wrote the wrong instructions in the bug.)
708 * src/maemo/easysetup/modest-easysetup-wizard.c:
709 Added scrollbars to account wizard dialog.
710 Fixed projects.maemo.org NB #62744
712 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
714 * src/maemo/easysetup/modest-easysetup-wizard.c:
715 (create_page_user_details):
716 Use auto-cap for name (projects.maemo.org NB#63716)
717 * src/widgets/modest-account-view.c: (on_account_busy_changed):
719 2007-07-22 Armin Burgmeier <armin@openismus.com>
721 * src/maemo/modest-ui-actions.c: Use current account instead of
722 default account for creating viewer windows, so that the viewer
723 window knows to which account the viewed message belongs.
725 * src/maemo/modest-msg-view-window.c: Destroy the window when the
726 corresponding account is deleted. This fixes projects.maemo.org bug
729 2007-07-18 Armin Burgmeier <armin@openismus.com>
731 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
732 the dialog close after entering an invalid port number and clicking
733 OK. This fixes projects.maemo.org bug NB#63602.
735 2007-07-18 Armin Burgmeier <armin@openismus.com>
737 * src/modest-tny-account-store.c:
738 (get_server_accounts): Set parent modest account name for each
739 connection-specific transport account so that special folders of such
740 an account can be looked up. This fixes a crash when changing account
741 settings. This might also be related to projects.maemo.org bug
744 2007-07-16 Armin Burgmeier <armin@openismus.com>
746 * src/modest-ui-actions.c: Added a button to create a folder to the
747 move-to dialog. This fixes projects.maemo.org bug NB#59863.
749 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c:
752 Added scrollbars to account wizard dialog.
753 Fixed projects.maemo.org NB #62744
755 2007-07-16 Murray Cumming <murrayc@murrayc.com>
757 * src/widgets/modest-msg-view.h:
758 * src/widgets/modest-msg-view.c:
759 Added modest_msg_view_get_message_is_empty() but this needs
761 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
762 Check if there is any text in the message yet.
763 But this needs to be implemented properly.
764 (modest_msg_edit_window_toggle_find_toolbar):
765 * src/maemo/modest-msg-view-window.c:
766 (modest_msg_view_window_toggle_find_toolbar):
767 Show a banner warning if there is no text to search, when
768 trying to start a search. This partially fixes
769 projects.maemo.org bug NB#62350.
771 2007-07-13 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-mail-operation.c: (update_account_thread):
774 Initialized num_new_headers to fix the build.
776 2007-07-13 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
779 Ignore modest accounts whose server accounts don't exist in gconf.
780 This prevents us trying to create TnyAccount instances for those
781 server accounts when the server account has been removed from gconf,
782 but the parent modest account has not yet been removed from modest.
783 I don't know why this is only noticeable now. It was probably just
784 a harmeless g_warning() anyway.
786 2007-07-13 Murray Cumming <murrayc@murrayc.com>
788 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
789 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
791 2007-07-12 Armin Burgmeier <armin@openismus.com>
793 * src/maemo/modest-main-window.c: Make default account appear bold
794 in view, tools/send & receive and toolbar/send & receive SCM menus.
795 This fixes projects.maemo.org bug NB#59010.
797 2007-07-12 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
800 Add a short-cut, by checking if the folder store is an account.
801 This ensures that the Sort menu item and toolbar is dimmed for
802 the local-folders account root item, fixing
803 projects.maemo.org bug NB#62545.
805 2007-07-12 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-tny-account-store.c: (get_password):
808 Show the password dialog (via the signal) only in the mainloop, via
809 an idle handler that we wait for. This could theoretically prevent
810 hangs, though I worry that it could introduce some too.
812 2007-07-12 Murray Cumming <murrayc@murrayc.com>
814 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
815 * src/maemo/modest-platform.c:
816 (modest_platform_connect_and_wait):
817 Take a TnyAccount* parameter and try to set it to online
818 (a TnyCamel-only API), because tinymail sets accounts to offline
819 when the user cancels a password dialog, and doesn't ask again until
820 it has been set to online.
821 However, this is commented out because it causes a hang now.
823 (modest_platform_connect_and_wait_if_network_account):
824 * src/modest-mail-operation.c:
825 (modest_mail_operation_update_account):
826 * src/modest-platform.h:
827 * src/modest-ui-actions.c: (_modest_ui_actions_open),
828 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
830 2007-07-12 Armin Burgmeier <armin@openismus.com>
832 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
834 * src/modest-mail-operation.c:
835 * src/modest-ui-actions.c: Check for already existing folder before
836 querying the server, show error message from camel if the request
837 still fails. This fixes projects.maemo.org bug NB#58701.
839 2007-07-12 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-tny-account-store.h:
842 * src/modest-tny-account-store.c:
843 Added modest_tny_account_store_forget_password_in_memory(),
844 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
845 when creating a new account, so that new passwords will be used, instead of
846 us thinking that it's a second request as a result of a failed password again.
848 2007-07-12 Murray Cumming <murrayc@murrayc.com>
850 * src/dbus_api/modest-dbus-callbacks.c:
851 (on_idle_open_message): If the message is in drafts then open it
852 in an edit window instead of a view window. This fixes
853 projects.maemo.org bug NB#63005.
855 2007-07-12 Murray Cumming <murrayc@murrayc.com>
857 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
858 Avoided a harmless g_warning().
860 2007-07-12 Murray Cumming <murrayc@murrayc.com>
862 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
863 Pass the modest account name, not the TnyAccount display name to
864 modest_msg_view_window_new() so that the reply feature works,
865 fixing projects.maemo.org bug NB#62892.
867 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
868 (modest_msg_view_window_new_with_header_model):
869 * src/maemo/modest-msg-view-window.c:
870 (modest_msg_view_window_new_with_header_model),
871 (modest_msg_view_window_new):
872 * src/modest-ui-actions.c: (reply_forward):
873 * src/widgets/modest-msg-view-window.h:
874 * src/widgets/modest-window.c: (modest_window_set_active_account):
875 Rename an account parameter to modest_account_name to make this clearer.
877 2007-07-11 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-ui-actions.h:
880 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
881 modest_do_message_delete().
882 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
883 Call modest_do_message_delete(), hoping that this would cause messages
884 to be really deleted from search instead of just marked with strike through.
885 Does not seem to help.
887 2007-07-11 Armin Burgmeier <armin@openismus.com>
889 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
890 priv->reselect to FALSE prior to calling
891 modest_folder_view_select_first_inbox_or_local() to prevent endless
892 recursion and thus a crash on startup.
894 2007-07-11 Armin Burgmeier <armin@openismus.com>
896 * src/maemo/modest-account-settings-dialog.h: Include
897 <gtk/gtknotebook.h> to fix the build (at least for me).
899 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
900 Use "New FolderN" as default suggested name if "New folder" already
901 exists, with N being the first free number, though never exceed "New
902 folder99" in which case we just fall back to "New Folder" even though
903 it already exists. This fixes projects.maemo.org bug NB#58663.
905 2007-07-11 Murray Cumming <murrayc@murrayc.com>
907 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
908 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
909 projects.maemo.org bug NB#62778.
911 2007-07-11 Murray Cumming <murrayc@murrayc.com>
913 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
914 Ignore the wrong (for now) secure-smtp setting in the presets -
915 just default to requiring secure authentication for SMTP, because
918 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
920 * src/widgets/modest-folder-view.c: (filter_row)
921 Do not show drafts folder (see UI specs)
923 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
925 * src/modest-ui-actions.c:
926 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
927 place and also not necessary.
929 * src/widgets/modest-folder-view.c: (filter_row)
930 Guess folder type and hide Sent & Outbox if necessary.
931 Fixed project.maemo.org NB#57328
933 2007-07-11 Murray Cumming <murrayc@murrayc.com>
935 * src/modest-ui-actions.h:
936 * src/modest-ui-actions.c:
937 (modest_ui_actions_on_delete_message):
938 Move some code into a new
939 modest_ui_actions_refresh_message_window_after_delete()
940 function so we can use it from elsewhere.
942 * src/dbus_api/modest-dbus-callbacks.c:
943 (on_idle_delete_message), (on_delete_message): Used an idle
944 handler, as we do for the other D-Bus method handlers.
945 Call modest_ui_actions_refresh_message_window_after_delete()
946 if the deleted message was open in a window. This fixed
947 projects.maemo.org bug NB#62862.
949 2007-07-11 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-main.c: (main): Only show the UI at the start if
952 the showui command line option was given. For instance,
953 run-standalone src/modest showui
954 Otherwise, we wait for the top_application D-Bus method to
955 be sent by hildon-desktop when the application is selected
957 This allows us to run without a UI when osso-global-search
958 uses our D-Bus methods.
960 2007-07-11 Murray Cumming <murrayc@murrayc.com>
962 * src/dbus_api/modest-dbus-api.h: Added a define for a
963 top-application D-Bus method.
964 * src/dbus_api/modest-dbus-callbacks.c:
965 (on_top_application),
966 (modest_dbus_req_handler): Handle the top-application D-Bus
967 method, which might be an undocumented D-Bus signal sent by
968 hildon-desktop when it starts the application from the menu.
969 But I am not sure and I need to test it on the device, because
970 my scratchbox does not have the application in the menu now.
971 This method shows the main window, so that it can be invisible
972 when started, for instance, just for email searching from
975 * src/maemo/modest-main-window.c: (restore_settings),
976 (modest_main_window_new): Do not show the window immediately
977 upon creation. We show it later.
978 * src/modest-widget-memory.c: (save_settings_paned):
979 Try (unsuccessfully) to avoid saving the paned position when
980 it is not even visible.
981 (restore_settings_paned): Do not allow a silly paned position.
982 This seems necessary when not showing the window at first.
984 * tests/dbus_api/Makefile.am:
985 * tests/dbus_api/test_top_application.c: (main): Test for the
988 2007-07-10 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-ui-dimming-rules.c:
991 (modest_ui_dimming_rules_on_new_msg),
992 (modest_ui_dimming_rules_on_reply_msg),
993 (modest_ui_dimming_rules_on_delete_msg),
994 (modest_ui_dimming_rules_on_details),
995 (modest_ui_dimming_rules_on_view_window_move_to),
996 (modest_ui_dimming_rules_on_view_previous),
997 (modest_ui_dimming_rules_on_view_next),
998 (_invalid_folder_for_purge): Added checks before
999 casting the window. This looks like an actual
1000 logic error in _invalid_folder_for_purge(), because it
1001 tries to use a ModestMainWindow as a message window.
1003 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1005 * src/maemo/modest-account-settings-dialog.c:
1006 (show_error): Use the same implementation as in
1007 modest-easysetup-wizard.c:
1008 (on_entry_invalid_character): The logical ID contains a %s.
1009 Guessed what it should be.
1010 (on_entry_max), (check_data), (on_response): Adapt to
1011 changed show_error().
1012 (create_page_account_details): Really call
1013 modest_validating_entry_set_func() on the correct widgets.
1014 * src/maemo/easysetup/modest-easysetup-wizard.c:
1015 (on_entry_invalid_character): Fix the logical ID here too.
1016 (create_page_account_details),
1017 (create_page_user_details):
1019 modest_validating_entry_set_func() on the correct widgets.
1021 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1022 Do not try to use the account if it is NULL.
1024 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1026 * src/modest-ui-actions.c: (create_move_to_dialog),
1027 (modest_ui_actions_on_main_window_move_to),
1028 (modest_ui_actions_on_msg_view_window_move_to):
1029 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1030 (filter_row), (modest_folder_view_show_non_move_folders):
1031 * src/widgets/modest-folder-view.h:
1033 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1034 the Sent folder yet as it does not report the correct folder type.
1036 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1038 * src/maemo/modest-msg-edit-window.c: (init_window):
1041 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1043 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1044 Take a parent widget instead of a parent window, and
1045 implement this with hildon_banner_show_information() instead.
1046 Non-Maemo builds can just ifdef that there.
1047 This fixed projects.maemo.org bug NB#62766.
1049 (on_entry_invalid_character): Use show_error() again instead
1050 of using hildon directly, and use the _CS() macro to use the correct
1052 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1053 Pass a widget instead od a window to show_error().
1055 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1057 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1058 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1059 This allows us to show the server name in the error message, fixing
1060 projects.maemo.org bug NB#62904.
1061 Also, use the appropriate logical ID message for the account protocol.
1063 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1066 A compilation fix, though the build wasn't broken for me.
1068 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1071 Do not try to unref a NULL folder store, to avoid a runtime warning.
1072 This seems to happen sometimes when changing accounts settings.
1074 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-tny-account-store.c:
1077 (modest_tny_account_store_instance_init),
1078 (modest_tny_account_store_finalize),
1079 (on_account_settings_hide), (on_idle_wrong_password):
1080 Use a GHashTable to ensure that we only show one account settings
1081 dialog per modest account. This avoids us having a dialog open for
1082 both the store and transport accounts, or due to repeated get_password()
1083 calls that shouldn't happen anyway.
1085 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1087 * src/maemo/modest-maemo-utils.c: (on_hide),
1088 (modest_maemo_show_dialog_and_forget): Handle the response, because
1089 the window is not even hidden by default.
1091 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1092 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1093 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1094 which seems to prevent some modality problems.
1096 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1097 Ignore user cancellation errors.
1099 * src/modest-account-mgr-helpers.h:
1100 * src/modest-account-mgr-helpers.c:
1101 Added modest_server_account_get_password() and
1102 modest_server_account_get_has_password() to avoid direct use of
1105 * src/maemo/modest-account-settings-dialog.h:
1106 * src/maemo/modest-account-settings-dialog.c:
1107 (modest_account_settings_dialog_init): Store the notebook so we can
1109 Added modest_account_settings_dialog_switch_to_user_info().
1111 * src/modest-tny-account-store.c:
1112 (get_password): When the password in the account settings is wrong (we think),
1113 show the relevant page of the account settings dialog, in the mainloop.
1114 However, we currently get many of these at once because cancel does not
1116 (forget_password): Do not forget the password
1117 from the account settings, because this causes side-effects when
1118 tinymail seems to call it at strange time, maybe because of how we
1119 are cancelling get_password().
1120 (modest_tny_account_store_alert): Ignore user cancellations.
1122 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/modest-maemo-utils.h:
1125 * src/maemo/modest-maemo-utils.c:
1126 Added modest_maemo_show_information_note_and_forget() for use instead of
1127 gtk_dialog_run() when the response is not needed, to avoid an extra
1128 mainloop which could cause a hang.
1130 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1131 Use the logical IDs for the error message, though they are not
1132 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1133 because gtk_dialog_run() caused a hang here (the window did not close).
1134 This fixes projects.maemo.org bug NB#62646.
1136 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-account-mgr-helpers.h:
1139 * src/modest-account-mgr-helpers.c:
1140 Added modest_account_mgr_get_store_protocol().
1142 * src/maemo/modest-account-view-window.c:
1143 (on_delete_button_clicked): Show different warning text depending on
1144 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1145 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1148 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-msg-edit-window.c:
1151 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1152 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1154 2007-07-07 Armin Burgmeier <armin@openismus.com>
1156 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1157 ckdg_ib_maximum_characters_reached from correct package.
1159 * src/modest-ui-actions.c: Show an error message when a folder could
1160 not be created. Tinymail does not give us specific error codes about
1161 what has gone wrong, so we assume that a folder with that name
1162 already exists, though there might be other reasons.
1164 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1167 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1168 give a more exact error message that can be partly translated.
1170 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1172 * src/maemo/modest-address-book.c:
1173 (select_email_addrs_for_contact): Specify a default window size for the
1174 select-email-address dialog, so that it is probably big enough for the
1175 title. This should fix projects.maemo.org bug NB#62277.
1177 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1179 * src/maemo/easysetup/modest-easysetup-wizard.c:
1180 (create_page_complete_easysetup): Use
1181 gtk_widget_set_size() request to ensure that the text wraps
1184 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1186 * src/maemo/easysetup/modest-easysetup-wizard.c:
1187 (on_entry_invalid_character), (create_page_account_details),
1188 (create_page_user_details):
1189 Use new API of ModestValidatingEntry. But for some reason the banner is
1190 not shown. I will have to investigate that further.
1192 * src/widgets/modest-validating-entry.c: (on_insert_text),
1193 (modest_validating_entry_set_func):
1194 * src/widgets/modest-validating-entry.h:
1195 Added a new callback function to be able to react to prevented
1196 characters whitespaces to e.g show a banner.
1198 2007-07-05 Armin Burgmeier <armin@openismus.com>
1200 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1201 notification of HildonNumberEditor instead of remembering the port
1202 number. Thanks to Johannes for pointing this out.
1204 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1206 * src/maemo/easysetup/modest-easysetup-wizard.c:
1207 Check if there are any user changes before showing a confirmation
1208 dialog (projects.maemo.org NB#60946)
1210 2007-07-05 Armin Burgmeier <armin@openismus.com>
1212 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1213 number at the beginning of the dialog and set the modified flag at the
1214 end if the port number has changed. This is necessary because
1215 HildonNumberEditor does not support notification when the value has
1218 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-ui-actions.c:
1221 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1222 a connection before asking anything else. Correct the check for the destination
1223 folder so that it succeeds when online.
1224 This fixed projects.maemo.org bug NB#61645.
1226 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1229 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1230 to fix projects.maemo.org bug NB#62439.
1232 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1234 * src/modest-tny-account.c: (on_connection_status_changed):
1235 Really do not use tny_device_force_offline() here. See the previous comment.
1237 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-tny-account.c: (on_connection_status_changed):
1240 Do not use tny_device_force_offline() when tinymail says that something
1241 went wrong with the connection. It seems to report this unnecessarily.
1243 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1245 * src/maemo/modest-connection-specific-smtp-window.c:
1246 (modest_connection_specific_smtp_window_init):
1247 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1248 does not seem to have any effect in osso 1.1 (though it works in
1249 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1251 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1253 * src/maemo/modest-connection-specific-smtp-window.c:
1254 Fix UI specification problems with projects.meamo.org NB#60479
1256 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1259 clue when this has failed, because the error dialog is not always shown
1260 (at least in earlier version).
1262 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1263 GError message, because the generic error dialog is not helpful.
1265 'This message is not currently available (can't let a new connection go online)'
1266 when trying to open an IMAP message.
1268 (_modest_ui_actions_open): Offer a connection when some messages would
1269 have to be downloaded and we are offline.
1271 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1273 * src/widgets/modest-folder-view.c:
1274 Don't check for MERGE type anymore as we use the correct type
1276 NOTE: For the last two changes you need to update your tinymail copy
1277 because of API changes!
1279 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1281 * src/modest-tny-local-folders-account.c:
1282 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1283 (see projects.maemo.org NB#61580)
1285 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-tny-account.c: (on_connection_status_changed):
1288 Commented out the call to modest_platform_connect_and_wait() because this
1289 seems to always hang, and I would like to know if this is the only thing
1290 that causes a hang when showing the connection dialog.
1291 It is not very useful anyway.
1293 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1295 * src/maemo/modest-msg-view-window.c:
1296 (modest_msg_view_window_select_next_message):
1298 * src/modest-platform.h:
1299 * src/maemo/modest-platform.c:
1300 Added modest_platform_connect_and_wait(), which calls
1301 tny_maemo_conic_device_connect() always in the main thread, by calling it
1302 in an idle handler and waiting for the idle handler to run. It should be
1303 in the main thread because it uses GTK+ UI code. It just returns TRUE
1304 if the device is already online.
1306 There is some nasty code to ensure that subsequent calls to
1307 modest_platform_connect_and_wait() just wait for the first one to finish,
1308 by checking repeatedly in another idle handler. This is necessary,
1309 because other threads (or even the main thread, via another idle handler)
1310 can call modest_platform_connect_and_wait() while
1311 modest_platform_connect_and_wait() is running.
1313 (modest_platform_connect_and_wait_if_network_account),
1314 (modest_platform_connect_and_wait_if_network_folderstore):
1315 Convenience functions that calls modest_platform_connect_and_wait() if
1316 the account or folder might want network access.
1318 * src/modest-mail-operation.c:
1319 (modest_mail_operation_update_account):
1320 * src/modest-ui-actions.c: (download_uncached_messages),
1321 (modest_ui_actions_on_rename_folder), (delete_folder),
1322 (modest_ui_actions_on_main_window_move_to),
1323 (modest_ui_actions_on_msg_view_window_move_to):
1324 * src/widgets/modest-folder-view.c:
1325 (drag_and_drop_from_folder_view):
1326 Offer a connection if we are offline.
1328 * src/modest-tny-account.c: (on_connection_status_changed):
1329 Document this as only handling errors during network operations in progress,
1330 and replace the idle code with a simple call to
1331 modest_platform_connect_and_wait(), which does this instead.
1333 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-tny-account.c:
1336 (modest_tny_account_get_special_folder): (util_on_idle),
1337 Handle the GError so we can see when tny_folder_store_get_folders()
1338 fails, as it currently does while something else is connecting.
1340 Added util_run_in_main_thread_and_wait()
1341 which uses an idlen handler and mainloop to ensure that the function
1342 is called in the main thread.
1343 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1344 to make sure that we call attempt the connection in the mainloop only,
1345 which might solve some hangs.
1347 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1349 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1350 be found by their display name. This is never useful.
1351 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1352 by its ID, instead of trying to use its ID as its display name.
1354 * src/modest-tny-account-store.h:
1355 * src/modest-tny-account.c:
1356 (modest_tny_account_get_special_folder): Add a g_warning() when
1357 tny_folder_store_get_folders() returns an empty list for the maildir.
1359 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1360 Add a g_warning() when this returns NULL, because that it not allowed
1363 2007-07-02 Armin Burgmeier <armin@openismus.com>
1365 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1366 note when trying to cancel the wizard. This fixes projects.maemo.org
1369 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1371 * src/modest-tny-account.h:
1372 * src/modest-tny-account.c:
1373 (modest_tny_account_new_from_server_account),
1374 (modest_tny_account_new_from_server_account_name),
1375 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1376 because this must now be set before setting the proto. This is usd in
1377 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1378 warning in camel_session_get_service() caused by
1379 tny_camel_transport_account_prepare().
1381 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1384 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1388 (modest_connection_specific_smtp_edit_window_init):
1390 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1391 of "changed" for now
1393 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account.c:
1396 (modest_tny_account_new_from_server_account):
1397 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1398 now uses to request a connection when it needs one, and which it uses
1399 to tell us that something is wrong with the connection, so we can force
1400 the accounts offline to prevent further problems.
1402 * src/modest-defs.h:
1403 * src/modest-init.c: (init_default_settings):
1404 * src/modest-mail-operation.c:
1405 (modest_mail_operation_update_account):
1406 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1407 This should not be necessary anymore. Do not set the conf key that
1408 determined this (it was always TRUE and not set anywhere else).
1410 * src/modest-ui-actions.h: Remove unused and unimplemented
1411 modest_ui_actions_on_online_toggle_toggled().
1413 2007-06-29 Murray Cumming <murrayc@murrayc.com
1415 * src/maemo/modest-main-window.c: (connect_signals):
1416 Don't connect to delete_event twice. Maybe this was harmless.
1418 2007-06-29 Murray Cumming <murrayc@murrayc.com
1420 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1421 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1422 Debug output to give some more clue when a folder move is not allowed.
1424 2007-06-28 Murray Cumming <murrayc@murrayc.com
1426 * src/modest-tny-account.c: (on_modest_file_system_info),
1427 (modest_tny_account_get_mmc_account_name):
1428 Always call the callback, without checking whether the name has changed.
1429 * src/widgets/modest-folder-view.c: (strings_are_equal),
1430 (on_model_foreach_set_name), (on_get_mmc_account_name),
1431 (text_cell_data): Compare the name here, and use the name from
1432 the account rather than from the
1433 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1434 if the name was changed after the account was added to the model.
1435 That's a tinymail bug but not one that I want to fix now.
1437 This finally fixes projects.maemo.org bug NB#59301.
1439 2007-06-27 Armin Burgmeier <armin@openismus.com>
1441 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1444 2007-06-27 Murray Cumming <murrayc@murrayc.com
1446 * src/modest-tny-account.h:
1447 * src/modest-tny-account.c:
1448 Added modest_tny_account_get_mmc_account_name(), to set the memory
1449 card name asynchronously for the given account and then notify.
1450 (modest_tny_account_new_for_local_folders): Use this new function instead
1451 of using hildon_file_system_info_async_new() directly.
1453 * src/widgets/modest-folder-view.c: (text_cell_data):
1454 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1455 gtk_tree_model_row_changed() when it is available.
1457 This should fix projects.maemo.org bug NB#59301.
1459 2007-06-27 Murray Cumming <murrayc@murrayc.com
1461 * src/modest-mail-operation.c: (update_account_thread),
1462 (get_msgs_full_thread): Fix typo failures in the revert
1465 2007-06-27 Murray Cumming <murrayc@murrayc.com
1467 * src/maemo/modest-maemo-global-settings-dialog.c:
1468 (idle_select_default_focus):
1469 * src/modest-mail-operation.c: (idle_notify_progress),
1470 (idle_notify_progress_once), (set_last_updated_idle),
1471 (update_account_thread), (get_msgs_full_thread):
1472 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1473 * src/widgets/modest-header-view.c:
1474 (idle_notify_headers_count_changed_destroy),
1475 (idle_notify_headers_count_changed):
1476 Reverted the additions of gdk_threads_enter/leave(), in case this
1477 helps with a startup hang on the device.
1479 2007-06-26 Armin Burgmeier <armin@openismus.com>
1481 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1482 for supported secure authentication methods from server by
1483 gtk_dialog_run(), saving CPU time and a potential race condition.
1485 2007-06-26 Armin Burgmeier <armin@openismus.com>
1487 * src/maemo/modest-maemo-utils.h:
1488 * src/maemo/modest-maemo-utils.c: Added a
1489 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1490 only error code to tell the calling code when the user canceled the
1493 * src/maemo/modest-account-settings-dialog.h:
1494 * src/maemo/modest-account-settings-dialog.c:
1495 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1496 message if the retrieval of secure authentication methods was canceled
1497 by the user. Perform the check before saving anything to configuration
1498 to not end up with half-committed configuration changes, do not show
1499 a "Saving to configuration failed" note when authentication methods
1500 could not be retrieved.
1502 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1505 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1507 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1508 Only return the first level of folders under accounts, because the
1509 osso-global-search UI spec doesn't want the rest.
1510 This fixed projects.maemo.org bug NB#61811.
1512 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-tny-account-store.c:
1515 * src/modest-tny-account-store.h:
1516 Added modest_tny_account_is_memory_card_account().
1517 * src/maemo/modest-main-window.c: (create_details_widget):
1518 Show the same information items for the memory card as we show for the
1519 local-folders, to fix projects.maemo.org bug NB#59307.
1521 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-tny-account-store.c: (get_password):
1524 Added some checks for NULL to maybe prevent crashes, though I think
1525 it was Philip's last commit that actually prevented the crash here
1526 when creating a first new account.
1527 But the new account is still not usable (no messages are shown)
1528 until a restart of the application.
1530 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/modest-maemo-global-settings-dialog.c:
1533 (idle_select_default_focus):
1534 * src/modest-mail-operation.c: (idle_notify_progress),
1535 (idle_notify_progress_once), (idle_notify_update_account_queue),
1536 (set_last_updated_idle), (update_account_thread),
1537 (notify_get_msgs_full), (get_msgs_full_destroyer),
1538 (get_msgs_full_thread):
1539 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1540 * src/widgets/modest-header-view.c:
1541 (idle_notify_headers_count_changed_destroy),
1542 (idle_notify_headers_count_changed):
1543 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1544 all idle handlers, because some other thread could be blocking
1545 the GDK lock, so that it can do GUI stuff.
1547 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1549 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1550 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1551 (on_idle_send_receive), (on_idle_open_default_inbox):
1552 * src/maemo/modest-msg-edit-window.c:
1553 (modest_msg_edit_window_attach_file_noninteractive):
1554 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1555 to prevent a hang. I don't quite understand why these are necessary,
1556 beause we should already be in the main loop. I guess something outside
1557 of the main loop is taking the lock.
1559 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1560 we are really using URIs, and use files that are more likely to exist.
1562 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1564 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1565 necessary because configure.ac now defines different variables.
1567 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1569 * libmodest-dbus-client/libmodest-dbus-client.c:
1570 * libmodest-dbus-client/libmodest-dbus-client.h:
1571 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1572 libmodest_dbus_client_compose_mail() is what things actually use.
1574 * src/dbus_api/modest-dbus-api.h:
1575 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1576 * tests/dbus_api/Makefile.am:
1577 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1580 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1582 * src/modest-init.c: (modest_init_local_folders):
1583 For memory-card (or other non local-folders) maildir accounts,
1584 always create an Archive folder, so that there is somewhere to put
1585 messages. This should be less confusing, because the user does not need
1586 to guess that the need to create a folder.
1588 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1590 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1591 Fixed icon size by using (50, 50) which is the same as defined by
1594 2007-06-25 Armin Burgmeier <armin@openismus.com>
1596 * src/widgets/modest-window-mgr.c:
1597 * src/modest-init.c:
1598 * configure.ac: Correctly recognize hildon-notify presence and fixed
1599 the build without it being installed.
1601 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1603 * libmodest-dbus-client/libmodest-dbus-client.c:
1604 (libmodest_dbus_client_search): Fix the build. Sorry.
1605 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1606 (reply_forward_cb): Initialize variables to fix the build.
1608 * src/modest-tny-account-store.c:
1609 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1610 comparison (a silly typo) so that email search results can be opened
1611 when there are more than one account.
1613 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1615 * libmodest-dbus-client/libmodest-dbus-client.c:
1616 (libmodest_dbus_client_search),
1617 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1618 instead of 1 second, because the search gets folders and messages from
1619 the server, which can take a long time. When it times out,
1620 osso-global-search will report no results.
1622 We need to specify whether we should search only cached information
1623 (maybe with a user preference), and the osso-email-search-plugin
1624 API should really be improved to allow that option, and to allow results
1625 to be delivered asynchronously in batches.
1627 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1630 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1631 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1633 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1635 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1636 that is an empty string. D-Bus seems to give us these instead of NULL.
1638 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1640 * src/dbus_api/modest-dbus-callbacks.c:
1641 * src/maemo/easysetup/modest-easysetup-wizard.h:
1642 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1644 (modest_connection_specific_smtp_edit_window_init):
1645 * src/maemo/modest-maemo-global-settings-dialog.c:
1647 * src/maemo/modest-maemo-utils.c:
1648 (modest_maemo_utils_setup_images_filechooser):
1649 * src/maemo/modest-main-window.c: (create_details_widget):
1650 * src/maemo/modest-msg-edit-window.c:
1651 (modest_msg_edit_window_attach_file_noninteractive),
1652 (modest_msg_edit_window_color_button_change),
1653 (modest_msg_edit_window_set_zoom):
1654 * src/modest-mail-operation.c: (update_account_thread):
1655 * src/modest-tny-account-store.c:
1656 * src/modest-tny-account.c:
1657 * src/widgets/modest-global-settings-dialog.c:
1658 * src/widgets/modest-window.h:
1660 Fixed build on bora!
1662 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1664 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1665 * src/modest-search.c: (modest_search_folder),
1666 (modest_search_all_accounts): Actually search only in the specified folder,
1667 doing a simple match on the folder ID.
1668 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1669 and added some documentation.
1671 2007-06-22 Armin Burgmeier <armin@openismus.com>
1673 * src/maemo/modest-maemo-utils.h:
1674 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1675 modest_maemo_utils_get_supported_secure_authentication_methods.
1677 * src/maemo/easysetup/modest-easysetup-wizard.c:
1678 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1679 one occured, not just "Server does not support secure authentication".
1681 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1683 * src/modest-tny-account-store.c: (get_password):
1684 Restored the call to tny_account_set_user() because Philip seems to have
1685 stopped this from crashing (by not using the freed string). It still does
1686 not work, but now we can test it.
1688 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/modest-msg-edit-window.c: (init_window):
1691 Comment out use of an uninitialzed GtkScrolledWindow variable,
1692 to fix the build and stop a crash. Yet again.
1694 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-tny-account-store.c: (get_password):
1697 Remove the call to tny_account_set_user() because this actually crashes.
1698 As mentioned in the last commit, it is known to not work anyway.
1700 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1702 * src/modest-tny-account-store.c: (get_password):
1703 Use tny_account_set_username() to tell tinymail that the username might
1704 have changed too. But tinymail ignores this: see projects.maemo.org
1706 * src/modest-ui-actions.c:
1707 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1708 reset the connection when changing the username, and improve the comments.
1709 Save the changed username to gconf at least, so it is used when Modest is
1712 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1714 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1715 Do not use a query, so that we get all folders, including for POP and
1716 local-folders. They work as search criteria too.
1717 This fixes projects.maemo.org bug NB#57740.
1719 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1721 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1722 Comment out the use of hildon_notification_set_sound() because it is
1723 not declared, to fix the build. Warnings are serious, people.
1725 2007-06-21 Armin Burgmeier <armin@openismus.com>
1727 * src/maemo/modest-maemo-utils.h:
1728 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1729 modest_maemo_utils_get_supported_secure_authentication_methods()
1730 to query authentication methods for a specific user. This should fix
1731 projects.maemo.org bug NB#61369.
1733 * src/maemo/easysetup/modest-easysetup-wizard.c:
1734 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1737 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1739 * libmodest-dbus-client/libmodest-dbus-client.h:
1740 * libmodest-dbus-client/libmodest-dbus-client.c:
1741 (modest_dbus_message_iter_get_search_hit),
1742 (libmodest_dbus_client_search):
1743 Reorganised and commented this.
1744 Removed modest_search_hit_free() from the public API because it
1747 Added libmodest_dbus_client_get_folders() and
1748 modest_folder_result_list_free().
1750 * src/dbus_api/modest-dbus-api.h:
1751 * src/dbus_api/modest-dbus-callbacks.c:
1752 (modest_dbus_req_filter): Commented. Moved most code to
1753 on_dbus_method_search() and added on_dbus_method_get_folders().
1755 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1756 of the extra D-Bus handler.
1758 * tests/dbus_api/Makefile.am:
1759 * tests/dbus_api/test_get_folders.c: New test for
1760 libmodest_dbus_client_get_folders(). This seems to return an empty list
1761 at the moment. That could be the same error that causes the message list
1762 to be empty sometimes.
1763 This should help with projects.maemo.org bug NB#57740.
1765 2007-06-21 Armin Burgmeier <armin@openismus.com>
1767 * src/modest-mail-operation.c: Do not call
1768 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1769 notify the operation's end after having set the status to CANCELED for
1770 the operation queue to listen on. This fixes a deadlock when there
1771 were mail operations in the queue during its finalization.
1773 * src/modest-singletons.c: Reordered uninitialization of the account
1774 manager to happen after the mail operation queue was uninitialized
1775 because the mail operation's in the queue might still try to access
1776 the account manager (see modest_mail_operation_notify_end()). This
1777 fixes a potential crash when terminating the application.
1779 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-search.c:
1782 (search_mime_part_and_child_parts): Moved some code here so we
1783 can search recursively in child folders.
1784 (modest_search_folder): Search in the message as a mime part, instead
1785 of just its child mime parts.
1786 (read_chunk), (search_mime_part_ogs):
1787 Check how many bytes were read, to prevent an endless loop.
1788 Searching in message bodies now works. This finishes the fix for
1789 projects.maemo.org bug NB#61007.
1791 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1794 Add a g_warning when the item is not a folder.
1796 * src/modest-ui-dimming-rules.c:
1797 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1798 when selected item is not a folder (for instance, an account), because
1799 the UI spec only talks about folders.
1800 I am not sure what the UI spec wants, so this might not totally fix
1801 projects.maemo.org bug NB#60794.
1803 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1805 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1806 (load_from_file): Sort the list. The unsorted list would be more noticeable
1807 in non-English locales.
1809 * src/maemo/modest-msg-edit-window.c:
1810 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1811 warning and fix the build.
1813 * src/maemo/modest-progress-bar-widget.c:
1814 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1815 avoid a g_warning, and probably to avoid a crash.
1817 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-search.c: (modest_search_folder): Check for a GError
1820 when calling tny_folder_get_headers(), to show that this is not the cause
1823 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1825 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1826 Actually set the body query instead of the subject query.
1828 * src/modest-search.c: (search_mime_part_ogs),
1829 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1830 which would probably cause it to fail if we got this far.
1832 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1833 to simplify the code.
1834 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1835 be causing search-in-body to fail.
1837 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1839 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1841 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1842 Better debug message when the folder cannot be found.
1843 This should help with fixing projects.maemo.org bug #61287.
1844 * src/modest-search.c: (add_hit): Do not leak the furl string.
1846 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-ui-actions.c:
1849 (modest_ui_actions_on_folder_selection_changed):
1850 Do not special-case TNY_MERGE_FOLDER here, because
1851 modest_tny_folder_get_account() already does that. This fixes
1852 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1853 shown when the Outbox was selected).
1855 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1857 * libmodest-dbus-client/libmodest-dbus-client.c:
1858 (_dbus_iter_get_string_or_null): Initialize the string variable in
1859 case this helps with Dirk's crash.
1861 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1863 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1864 though it is not implemented yet (this function is maybe not even used),
1865 to avoid breaking ABI in future.
1866 * libmodest-dbus-client/libmodest-dbus-client.c:
1867 (get_attachments_string): Moved some code into this generic function.
1868 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1869 sends email. It is maybe not used.
1870 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1871 (on_send_mail): Use attachments.
1873 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1874 * src/maemo/modest-msg-edit-window.c:
1875 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1876 a filename before using it, to fix projects.maemo.org bug NB#58233.
1878 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1880 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1881 Initialize the continue_download variable to fix the build, and probably
1882 to fix randome behaviour.
1884 2007-06-18 Armin Burgmeier <armin@openismus.com>
1886 * src/modest-tny-send-queue.h:
1887 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1888 the queue so we can later show it in the UI. Replaced
1889 modest_tny_send_queue_msg_is_being_sent() by
1890 modest_tny_send_queue_get_msg_status().
1892 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1894 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1895 gpointer. This probably was not harmful, but just to be sure.
1897 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1900 Fix the build, but leave the function broken on Bora, because
1901 hildon_uri_action_get_service() does not exist.
1902 osso_uri_action_get_service() does not exist either, it seems.
1904 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1906 * src/modest-tny-account.c:
1907 (modest_tny_account_new_from_server_account):
1908 Uncommented the url debug output again, because it is useful for
1909 debugging, as I said in the comment.
1911 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1913 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1915 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1916 for Mameo Bora, to fix the build.
1918 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1921 Fixed build with hildon < 0.99
1923 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1924 Check if the selected account is busy instead of checking all accounts
1926 * src/modest-account-mgr-priv.h:
1927 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1928 (modest_account_mgr_init), (compare_account_name),
1929 (modest_account_mgr_set_account_busy),
1930 (modest_account_mgr_account_is_busy):
1931 * src/modest-account-mgr.h:
1932 Added busy information to the account manager. It possible to
1933 set an account to busy or not busy now.
1935 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1936 (modest_mail_operation_update_account),
1937 (modest_mail_operation_notify_end):
1938 Set the account to busy/not busy depending on the operation state.
1940 * src/widgets/modest-account-view.c:
1941 (modest_account_view_finalize), (get_last_updated_string),
1942 (update_account_view), (on_account_busy_changed), (init_view):
1943 Show string "Refreshing..." if the account is currently busy.
1945 All this fixes projects.maemo.org bug NB#59711
1947 2007-06-14 Armin Burgmeier <armin@openismus.com>
1949 * src/widgets/modest-attachments-view.h:
1950 * src/widgets/modest-attachments-view.c: Added
1951 modest_attachments_view_has_attachments() and fixed coordinate
1952 transformation in get_att_view_at_coords(). This fixes attachment
1955 * src/widgets/modest-msg-view.c: Make use of
1956 modest_attachments_view_has_attachments() to decide whether to show
1957 attachments in the header.
1959 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1961 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1962 (on_change), (on_combo_security_changed),
1963 (modest_connection_specific_smtp_edit_window_init),
1964 (modest_connection_specific_smtp_edit_window_set_connection),
1965 (modest_connection_specific_smtp_edit_window_is_dirty):
1966 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1967 * src/maemo/modest-connection-specific-smtp-window.c:
1970 Show an comfirmation dialog for the smpt-edit-window if there are
1971 unsaved changes and the user hits cancel.
1972 (projects.maemo.org bug NB#60479)
1974 2007-06-14 Armin Burgmeier <armin@openismus.com>
1976 * src/maemo/easysetup/modest-easysetup-wizard.c:
1977 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1978 address" info in banner instead of node, and select all the text as
1979 per UI spec. This fixes projects.maemo.org bug NB#60550.
1981 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1983 reviewed by: <delete if not using a buddy>
1985 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1986 * src/modest-ui-actions.c: (folder_refreshed_cb):
1988 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1990 * src/widgets/modest-folder-view.c: (filter_row):
1991 Explictly filter out the per-account outbox accounts. I don't know why
1992 these only sometimes show up, but now they should never show up in the UI.
1993 This should fix projects.maemo.org bug NB#60160.
1995 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1997 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1998 when the toolbar does not exist yet.
1999 * src/modest-widget-memory.c: (save_settings_header_view):
2000 Added g_warnings() to help us to discover when we are trying to set
2001 an empty columns list in gconf.
2003 2007-06-14 Murray Cumming <murrayc@murrayc.com>
2005 * src/modest-init.h:
2006 * src/modest-init.c:
2007 Added modest_init_get_default_header_view_column_ids().
2009 * src/modest-widget-memory.c: (restore_settings_header_view):
2010 Use the new function to get defaults, if the gconf key is empty,
2011 instead of not creating any columns. This seems to fix the
2012 empty right-hand pane problems.
2014 * src/widgets/modest-header-view.h: Improved documentation.
2016 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2019 Revert the use of the display name as the account name, because this
2020 is generally wrong and would break the code that follows.
2022 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2024 * src/maemo/easysetup/modest-easysetup-wizard.c:
2025 (check_for_supported_auth_methods), (on_before_next),
2028 More correct fix for projects.maemo.org bug NB# 58991
2029 Do not longer accept AUTH_PASSWORD as secure method and choose
2030 correct method when creating the account.
2032 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2034 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2035 Fixed projects.maemo.org bug NB# 58991
2037 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2039 * src/modest-init.c: (modest_init_init_core),
2040 (modest_init_local_folders): Fixed compilation errors.
2042 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2044 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2045 Remove unnecessary lib/include, though it is good in principle when needed.
2047 * src/modest-init.c: (modest_init_one_local_folder),
2048 (modest_init_local_folders):
2049 * src/modest-init.h: Initialize the .modest library for memory cards,
2050 instead of just doing nothing for them. This should allow us to create
2051 folders there, fixing projects.maemo.org bug NB#59297.
2053 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2055 * libmodest-dbus-client/libmodest-dbus-client.c:
2056 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2057 (libmodest_dbus_client_compose_mail),
2058 (libmodest_dbus_client_open_message),
2059 (libmodest_dbus_client_send_and_receive),
2060 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2062 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2063 (on_idle_open_message), (modest_dbus_req_handler),
2064 (search_result_to_message), (modest_dbus_req_filter):
2065 * src/modest-search.c: (add_hit), (modest_search_folder),
2066 (modest_search_all_accounts): Improved debug messages.
2068 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2070 * src/modest-tny-account-store.c:
2071 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2074 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2077 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2079 * src/modest-tny-account-store.c: (get_server_accounts):
2080 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2081 even when there are no accounts, so that the Outbox folder is always
2082 visible. This fixes projects.maemo.org bug NB#60158.
2084 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2086 * src/maemo/modest-main-window.c: (create_details_widget):
2087 Use the mcen_va_never logical ID.
2089 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2091 * src/dbus_api/modest-dbus-api.h:
2092 * src/dbus_api/modest-dbus-callbacks.c:
2093 (on_idle_open_default_inbox), (on_open_default_inbox),
2094 (modest_dbus_req_handler):
2095 Added a new OpenDefaultInbox method.
2097 * libmodest-dbus-client/libmodest-dbus-client.h:
2098 * libmodest-dbus-client/libmodest-dbus-client.c:
2099 Added libmodest_dbus_client_open_default_inbox() to call the new
2100 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2101 though it should maybe be used by a new osso-email-interface function.
2103 * tests/dbus_api/Makefile.am:
2104 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2107 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2110 NULL, so that the signals get all the keys. This should not actually
2111 change any behaviour because we currently update everything when anything
2114 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2116 * src/widgets/modest-folder-view.c: (text_cell_data),
2117 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2118 (find_inbox_iter): If tinymail tells us that the folder is
2119 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2120 This causes the inbox to be selected at startup, fixing part of
2121 projects.maemo.org bug NB#56305.
2123 * src/modest-ui-dimming-rules.c:
2124 (modest_ui_dimming_rules_on_tools_smtp_servers):
2125 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2126 the SMTP servers menu item.
2127 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2128 that the SMTP Servers menu item is dimmed when there are no accounts,
2129 as a future version of the UI spec will require. This fixes
2130 projects.maemo.org bug NB#56305.
2132 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2134 * src/maemo/modest-maemo-utils.c:
2135 (modest_maemo_utils_get_supported_secure_authentication_methods):
2136 Added label to dialog instead of unreadable title
2138 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2139 (modest_main_window_new):
2140 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2143 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2144 * src/modest-account-mgr.h:
2145 Added method to avoid code duplication
2147 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2148 (modest_ui_actions_on_send_receive):
2149 Use modest_account_mgr_has_accounts
2151 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2153 * src/maemo/easysetup/modest-presets.c:
2154 (modest_presets_get_info_server_security): Do not report secure auth
2156 * src/modest-protocol-info.c: Use the defines for the gconf key names
2157 for secure authentication. This was not working because we were writing
2158 Password and reading password, and the check was case sensitive.
2159 With this, gmail now works for receiving and sending when created via
2162 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2164 * src/maemo/easysetup/modest-presets.c:
2165 (modest_presets_get_info_server_security): Correct the key name for
2166 SecureSmtp, because it seems to be case-sensitive.
2167 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2168 Do not try to get the 0th notebook page if there are 0 pages, to
2169 avoid a g_warning().
2171 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2173 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2174 Prevent use of the new notification feature for now, because it currently
2175 shows one dialog for each new email, which is annoying.
2177 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2180 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2181 when no country was selected, so that we show the global ones.
2182 * src/maemo/easysetup/modest-presets.c:
2183 (modest_presets_get_providers): Return only the global providers, not
2184 all providers when mmc=0 was requested.
2186 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2189 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2190 provider ID in the combo.
2192 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2193 Do not show the page numbers, because it would be confusing when we add
2194 the 2 extra pages for the custom setup, when the user chooses the "Other"
2195 provider. This fixes projects.maemo.org bug NB#59028
2197 * src/modest-init.c: (modest_init_init_core),
2198 (modest_init_local_folders):
2199 * src/modest-init.h:
2200 * src/modest-tny-account.c:
2201 (modest_tny_account_new_for_local_folders): Do not create default folders
2202 for the memory card. This should fix projects.maemo.org bug NB#59328.
2204 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2206 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2207 Free the changed_conf_keys string items. They are already freed in the
2208 idle handler if that runs first.
2210 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2212 * src/modest-ui-actions.c:
2213 (modest_ui_actions_on_password_requested): Check that the server name
2214 is not NULL, because I just saw a password dialog with (null) as the
2217 * src/modest-tny-folder.[h|c]: Added
2218 modest_tny_folder_is_memory_card_folder().
2219 * src/modest-ui-dimming-rules.c:
2220 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2221 menu item for memory cards, as per the UI spec (section 7.4). This should
2222 fix projects.maemo.org bug NB#59297.
2224 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2226 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2227 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2228 is another problem with the code, see Murray's comment at line 772)
2230 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2232 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2233 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2234 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2235 (load_from_file), (easysetup_country_combo_box_init),
2236 (easysetup_country_combo_box_get_active_country_ids),
2237 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2238 instead of just one ID, to avoid duplicate country names in the UI.
2240 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2241 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2242 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2243 a single ID, avoiding duplicate providers.
2244 * src/maemo/easysetup/modest-easysetup-wizard.c:
2245 (on_combo_account_country): Adapt to use a list.
2247 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2249 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2250 keys changed in the last X seconds.
2252 * src/modest-account-mgr.h:
2253 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2254 (on_key_change), (modest_account_mgr_class_init),
2255 (modest_account_mgr_init), (modest_account_mgr_finalize):
2256 As the keys are changed, save them in a GSList* and signal that GSList*
2257 further every X seconds, to batch changes, to allow us to do just one
2258 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2259 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2261 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2262 changed signal signature.
2264 * src/modest-conf.c: (modest_conf_set_list),
2265 (modest_conf_on_change): Reenable notification.
2267 (modest_conf_maemo_fake_on_change): Comment out the hack that
2268 notified immediately instead of asynchronously.
2270 * src/widgets/modest-account-view.h:
2271 * src/widgets/modest-account-view.c:
2272 (update_account_view): Select the previously-selected account ID,
2273 if possible. This fixes projects.maemo.org bug NB#56933.
2275 (on_account_changed), (on_account_removed),
2276 (modest_account_view_select_account):
2278 Remove the block/unblock functions
2279 because they were not useful.
2281 * src/maemo/modest-account-view-window.c:
2282 (on_delete_button_clicked), (on_edit_button_clicked),
2283 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2285 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2288 Improve the error dialog to show Incorrect Account Settings, which seems
2289 clearer, and say that the internal error message (to be removed from the
2290 dialog later) is often misleading.
2291 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2293 * src/modest-tny-account.c:
2294 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2295 URL because this is so useful for debugging on the device.
2297 * src/widgets/modest-serversecurity-combo-box.c:
2298 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2300 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-mail-operation.c:
2303 (modest_mail_operation_send_new_mail):
2304 Added a comment about a nasty but apparently harmless message. Details
2305 added to the wiki g_warnings() page.
2307 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2310 (modest_tny_send_queue_class_init):
2311 Do not use the priv struct because it is empty, to avoid g_warnings
2312 about a non-existant priv struct.
2314 * src/modest-tny-account-store.c:
2315 (modest_tny_account_store_get_server_account),
2316 (modest_tny_account_store_get_transport_account_for_open_connection
2317 ): Do not try to get transport server accounts for local folders,
2318 because they don't have any. This avoids a g_warning().
2320 * src/maemo/modest-main-window.c:
2321 (modest_main_window_notify_send_receive_initied),
2322 (on_configuration_key_changed):
2323 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2324 * src/modest-defs.h:
2325 * src/modest-mail-operation.c:
2326 (modest_mail_operation_update_account):
2327 * src/modest-tny-account-store.h:
2328 * src/modest-tny-account.c:
2329 (modest_tny_account_get_special_folder),
2330 (modest_tny_account_new_for_local_folders),
2331 (modest_tny_account_new_for_per_account_local_outbox_folder):
2332 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2333 * src/modest-tny-local-folders-account.c:
2334 (add_account_folders_to_merged_folder):
2335 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2336 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2337 (modest_ui_actions_on_send):
2338 * src/widgets/modest-folder-view.c: (update_model):
2339 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2340 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2341 modest_tny_account_store_get_tny_account_by_account() to
2342 modest_tny_account_store_get_server_account() to make the code clearer.
2344 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2346 * src/dbus_api/modest-dbus-api.h:
2347 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2348 * src/maemo/modest-msg-edit-window.c:
2349 (modest_msg_edit_window_attach_file_noninteractive):
2350 added g_warning in case the file to be attached does not exist
2351 * tests/dbus_api/test_compose_mail.c: (main):
2352 removed obsolete comment, added generic files as test case
2354 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2356 * src/modest-tny-account-store.c: (get_server_accounts):
2357 Create the local folders account only once, not once for each outbox, and
2358 not only when there are some outboxes.
2360 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2362 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2363 code that is causing a crash at startup. Sergio says that he is fixing this.
2365 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2367 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2368 * src/maemo/modest-account-settings-dialog.c:
2369 (create_page_outgoing),
2370 (modest_account_settings_dialog_set_account_name),
2371 (save_configuration):
2372 - Fixed handling of the "Use secure authentication" toggle to comply with
2373 the ui specification. See also projects.maemo.org bug NB#58400
2375 - Restore the Secure connection setting combo correctly when loading
2378 * src/maemo/modest-maemo-utils.c:
2379 (on_camel_account_get_supported_secure_authentication),
2380 (modest_maemo_utils_get_supported_secure_authentication_methods):
2381 Fixed a crasher if operation is canceled
2383 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2384 (modest_protocol_info_auth_is_secure):
2385 * src/modest-protocol-info.h:
2387 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2388 the sense of the "Use secure authentication" toggle.
2390 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-tny-account-store.h:
2393 * src/modest-tny-account-store.c:
2394 Added modest_tny_account_store_get_local_folders_account().
2396 * src/modest-tny-folder.h:
2397 * src/modest-tny-folder.c:
2398 (modest_tny_folder_get_account):
2399 Added this replacement for tny_folder_get_account() which returns
2400 the local-folders account for TnyMergeFolders, to avoid the
2401 warning about the unimplemented get_account_func() vfunc().
2403 (modest_tny_folder_get_rules),
2404 * src/modest-ui-actions.c:
2405 (modest_ui_actions_on_folder_selection_changed):
2406 * src/modest-mail-operation.c:
2407 (modest_mail_operation_remove_folder),
2408 (modest_mail_operation_xfer_folder),
2409 (modest_mail_operation_rename_folder),
2410 (modest_mail_operation_get_msg),
2411 (modest_mail_operation_get_msgs_full),
2412 (modest_mail_operation_remove_msg),
2413 (modest_mail_operation_xfer_msgs),
2414 (modest_mail_operation_refresh_folder):
2415 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2417 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2419 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2420 (modest_server_account_set_security):
2421 * src/modest-defs.h: Add comments explaining that our
2422 UI spec means TLS when it says Normal, so these do not look like errors.
2424 * src/modest-tny-account.c:
2425 (modest_tny_account_new_from_server_account): Use the new tinymail
2426 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2427 for TLS. This should fix projects.maemo.org bug NB#58460.
2429 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/easysetup/modest-easysetup-wizard.c:
2432 (create_account): Correct the position of the gconf sanity check warning.
2433 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2434 of using the g_idle_add() hack, because this does not seem to be necessary
2435 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2436 caused by something other than maemo's gconf.
2437 This fixes projects.maemo.org bug #59022.
2439 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2441 * src/modest-account-mgr-helpers.c:
2442 (modest_account_mgr_get_default_account): Do not check that the account
2443 exists if there is no default account (NULL), to fix a runtime warning.
2445 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2447 * src/widgets/modest-folder-view.c: (update_model):
2448 Do not unref the treemodel before we have finished with it.
2449 This prevents a valgrind warning and an occasional crash at startup.
2451 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2453 * libmodest-dbus-client/libmodest-dbus-client.h:
2454 added libmodest_dbus_client_compose_mail()
2455 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2457 added functions needed for SendAsMail() functionality
2458 * src/maemo/modest-msg-edit-window.c:
2459 (modest_msg_edit_window_attach_file_noninteractive):
2460 non interactively attaching files to message edit window
2461 * src/widgets/modest-msg-edit-window.h:
2462 * tests/dbus_api/Makefile.am:
2463 added test_compose_mail.c
2464 * tests/dbus_api/test_compose_mail.c: (main):
2466 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2468 * src/modest-account-view.c:
2469 Fixed bug projects.maemo.org bug NB#59307
2471 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2473 * src/maemo/easysetup/modest-easysetup-wizard.c:
2474 (get_serverport_incoming), (on_before_next), (create_account):
2475 * src/maemo/modest-account-settings-dialog.c:
2476 (modest_account_settings_dialog_set_account_name):
2477 * src/maemo/modest-maemo-utils.c:
2478 (on_camel_account_get_supported_secure_authentication_status),
2479 (on_camel_account_get_supported_secure_authentication),
2480 (on_secure_auth_cancel),
2481 (modest_maemo_utils_get_supported_secure_authentication_methods):
2483 Implemented security authentication for settings and easysetup.
2485 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2487 * src/maemo/modest-main-window.c: (create_details_widget):
2488 Show the total size for memory card accounts too, instead of showing
2489 the name again. Fixes bug projects.maemo.org bug NB#59307.
2491 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2494 * src/modest-tny-simple-folder-store.c:
2495 * src/modest-tny-simple-folder-store.h: Removed.
2497 * src/modest-tny-local-folders-account.h
2498 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2499 for the local-folders maildir, with an extra TnyMergedFolder containing
2500 the folders of the per-account outbox store accounts.
2501 * src/modest-tny-account-store.c: (get_server_accounts):
2502 Add the outboxes to the special local folders account after creating it.
2504 * src/modest-tny-account.c:
2505 (modest_tny_account_new_for_local_folders): Create the derived
2506 account when creating the main local-folders account.
2508 * src/maemo/modest-main-window.c: (create_details_widget),
2509 (modest_main_window_set_contents_style):
2510 Adapted to the use of the derived account instead of the folder store.
2512 * src/modest-ui-actions.c:
2513 (modest_ui_actions_on_folder_selection_changed):
2514 * src/modest-ui-dimming-rules.c:
2515 (modest_ui_dimming_rules_on_new_folder):
2516 * src/widgets/modest-folder-view.c: (text_cell_data),
2517 (icon_cell_data), (filter_row), (update_model),
2518 (get_cmp_rows_type_pos):
2521 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2522 Do not get the priv struct, because no priv struct has been set,
2523 to avoid a runtime warning.
2525 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2526 #ifelse with #else, to fix a warning, to fix the build.
2529 2007-06-05 Christian Kellner <ckellner@openismus.com>
2531 * libmodest-dbus-client/libmodest-dbus-client.c:
2532 Fix small typo in doc (why do you always see them
2533 AFTER committing stuff?)
2536 2007-06-05 Christian Kellner <ckellner@openismus.com>
2538 * libmodest-dbus-client/libmodest-dbus-client.c:
2539 (libmodest_dbus_client_search):
2540 Initialize hit list with NULL. Also set folder list
2541 to "" if NULL was supplied.
2544 2007-06-03 Christian Kellner <ckellner@openismus.com>
2546 * libmodest-dbus-client/libmodest-dbus-client.c:
2547 (modest_search_hit_list_free):
2548 Make it save to call it with NULL.
2550 * src/dbus_api/modest-dbus-callbacks.c:
2551 * src/modest-search.c:
2552 Return full ModestSearchHits as the search result list not TnyHeader
2553 since can't be around withouth the correspoding TnyFolder.
2555 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2557 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2558 Added currently commented code to check for secure auth
2560 * src/maemo/modest-account-settings-dialog.c: (on_response),
2561 (save_configuration), (show_ok):
2562 Fixed projects.maemo.org bugs NB #59248 and #59251
2564 * src/maemo/modest-maemo-utils.c:
2565 (on_camel_account_get_supported_secure_authentication_status),
2566 (on_camel_account_get_supported_secure_authentication),
2567 (modest_maemo_utils_get_supported_secure_authentication_methods):
2568 * src/maemo/modest-maemo-utils.h:
2569 Moved get_supported_secure_authentication() method here to be able
2570 to use it from easysetup wizard.
2572 * src/modest-pair.c: (on_pair_compare_as_string):
2573 Should compare string with first part of pair and not
2574 strcmp pairs which will crash.
2576 * src/modest-protocol-info.c:
2577 (modest_protocol_info_protocol_is_store):
2578 * src/modest-protocol-info.h:
2579 Added modest_protocol_info_get_auth_protocol_name()
2581 2007-06-03 Armin Burgmeier <armin@openismus.com>
2583 * src/modest-mail-operation.c:
2584 (modest_mail_operation_get_msgs_full): Set priv->account also when
2585 only retrieving a single message. This avoids a crash when canceling
2588 (modest_mail_operation_notify_end): Do not explicitely remove the
2589 operation from the queue but only emit the progress_changed signal.
2590 The queue itself listens to that signal to remove the operation when
2591 it is finished. This reduces coupling and removes a potential deadlock
2592 when modest_mail_operation_notify_end() is called from the queue
2593 itself. If that is a problem performance-wise, I would suggest to
2594 implement a status-changed signal or something.
2596 * src/modest-mail-operation-queue.c: Make sure to never call a
2597 function from another file while the queue is locked. This (hopefully)
2598 fixes another deadlock when exiting the application while retrieving
2601 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2603 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2604 Fixed build if libogs is not available
2606 2007-06-03 Christian Kellner <ckellner@openismus.com>
2608 * libmodest-dbus-client/libmodest-dbus-client.h:
2609 * libmodest-dbus-client/libmodest-dbus-client.c:
2610 (libmodest_dbus_client_delete_message):
2611 Implement deletion of messages (Client side).
2613 (modest_search_hit_free),
2614 (modest_search_hit_list_free):
2615 Utility functions to free the result hits.
2617 * src/dbus_api/modest-dbus-api.h:
2618 * src/dbus_api/modest-dbus-callbacks.c:
2619 (on_delete_message),
2620 (modest_dbus_req_handler):
2621 Implement deletion of messages (Server side).
2623 * tests/dbus_api/test_search.c: (main):
2626 * tests/dbus_api/Makefile.am:
2627 * tests/dbus_api/test_delete_message:
2628 Add little test for the message deletion logic
2630 2007-06-03 Armin Burgmeier <armin@openismus.com>
2632 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2633 when the operation queue was not empty. projects.maemo.org bug
2636 2007-06-03 Armin Burgmeier <armin@openismus.com>
2638 * src/widgets/modest-account-view.c
2639 (on_account_default_toggled): Toggle default account column
2640 explicitely instead of waiting for gconf notification (which is
2641 currently ignored). This should fix projects.maemo.org bug NB#56910
2642 for now. It should probably be removed when gconf notifications are
2645 2007-06-03 Christian Kellner <ckellner@openismus.com>
2647 * libmodest-dbus-client/libmodest-dbus-client.c:
2648 Removed debugging spew.
2650 * src/dbus_api/modest-dbus-callbacks.c:
2651 Added debugging info.
2653 * src/modest-search.c:
2654 (modest_search_all_accounts):
2655 Use tny_account_store_get_accounts () on the account store
2656 to get all accounts which is the way to get all accounts.
2658 * tests/dbus_api/test_search.c: (main):
2659 Make it possible to supply the search term on the command line.
2661 2007-06-03 Christian Kellner <ckellner@openismus.com>
2663 * libmodest-dbus-client/libmodest-dbus-client.c:
2664 * libmodest-dbus-client/libmodest-dbus-client.h:
2665 Implement searching for mesages over raw dbus. (Client side)
2667 * src/dbus_api/Makefile.am:
2668 * src/dbus_api/modest-dbus-api.h:
2669 * src/dbus_api/modest-dbus-callbacks.c:
2670 * src/dbus_api/modest-dbus-callbacks.h:
2671 Search framework (Server side). Also implement on_idle_open_message().
2673 * src/maemo/modest-platform.c: (modest_platform_init):
2674 Prepare for raw dbus/osso rpc interaction.
2676 * src/modest-search.h:
2677 Changed minsize from unspecific guint to guint32.
2679 * src/modest-search.c:
2681 Added strange hack which magically made tnymail work.
2683 (modest_search_folder),
2684 (modest_search_account),
2685 (modest_search_all_accounts):
2686 Implement helper functions to search all accounts, specific account
2689 * tests/dbus_api/Makefile.am:
2690 * tests/dbus_api/test_open_message.c:
2691 Read url to open from commandline.
2693 * tests/dbus_api/test_search.c:
2694 Implement small test for dbus search stuff
2696 2007-06-02 Armin Burgmeier <armin@openismus.com>
2698 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2699 include account type and account title. This fixes projects.maemo.org
2702 * src/maemo/modest-account-view-window.c: Set a title for the window.
2704 2007-06-02 Armin Burgmeier <armin@openismus.com>
2706 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2707 incoming and outgoing server name based on email address and server
2708 types as long as the names have not been edited manually. This fixes
2709 projects.maemo.org bug NB#58671.
2711 2007-06-02 Armin Burgmeier <armin@openismus.com>
2713 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2714 server type cannot be changed in future to the incoming details page
2715 when creating an account. This fixes projects.maemo.org bug NB#59029.
2717 2007-06-02 Armin Burgmeier <armin@openismus.com>
2719 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2720 and assigned max width chars so that they wrap instead of being
2721 truncated. Fixes projects.maemo.org bug NB#56126.
2723 2007-06-02 Armin Burgmeier <armin@openismus.com>
2725 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2726 introductory note to the connection specific smtp servers dialog, as
2727 section 8.12 of the email UI specification requires. This fixes
2728 projects.maemo.org bug NB#59212.
2730 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2733 Check for running mail operations, and offer to cancel them, as per the UI
2734 spec. This fixes projects.maemo.org bug NB#59041 .
2735 However, I suspect that tinymail may still use the network connection
2736 in ways that we cannot detect or cancel. But it should at least adapt to
2737 changes fairly well.
2739 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-tny-account-store.c: (recreate_all_accounts),
2742 (get_cached_accounts), (get_server_accounts): Do more sensible
2743 ref-counting of the temporarily-cached outbox accounts list. This seems
2744 to fix a crash when entering the password when the password was wrong.
2746 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2748 * src/gnome/modest-main-window.c: (connect_signals):
2749 * src/modest-tny-account-store.c: (get_password),
2750 (modest_tny_account_store_alert): Added comments and clues and
2751 commented-out code about how we currently fail to deal with connection
2752 errors and wrong passwords, and how we should.
2754 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2756 * src/widgets/modest-retrieve-combo-box.c:
2757 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2758 This fixes projects.maemo.org bug NB#58472 .
2760 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/easysetup/modest-easysetup-wizard.c:
2763 (create_page_complete_easysetup):
2764 (create_page_complete_custom): Correct the last commit,
2765 putting the correct sentences in the correct pages.
2767 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/easysetup/modest-easysetup-wizard.c:
2770 (create_page_complete_custom): Show the second sentence of text
2771 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2774 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2776 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2777 Set the leave-on-server conf key by default. This fixes
2778 projects.maemo.org bug NB#59258 .
2780 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/modest-account-view-window.c:
2783 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2784 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2787 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2789 * src/maemo/easysetup/modest-easysetup-wizard.c:
2790 (create_caption_new_with_asterisk):
2791 * src/maemo/modest-account-settings-dialog.c:
2792 (create_caption_new_with_asterisk):
2793 Uncomment the code to add the asterisk, because they are no longer in the
2794 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2795 (update_incoming_server_title): Add an asterisk here too.
2797 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/modest-maemo-global-settings-dialog.c:
2800 (current_connection): Check that we are even connected before trying to
2801 get the current connection name, to prevent a warning.
2803 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2804 Change the comments because tny_maemo_conic_device_connect() is now meant to
2806 * src/modest-mail-operation.c:
2807 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2808 make sure we have a connection and fail if we can't connect.
2810 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/modest-main-window.c:
2813 (on_account_store_connecting_finished): Do not try to get the
2814 connection ID if we are not really connected. I am surprised that
2815 this signal handler is called when we are not connected.
2817 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2819 * src/modest-error.h:
2820 * src/modest-ui-actions.c:
2821 (modest_ui_actions_get_msgs_full_error_handler):
2822 Renamed an enum, added comments, added an enum
2823 for retrieve-limit errors.
2825 * src/modest-mail-operation.c: (foreach_add_item),
2826 (internal_folder_observer_update), (update_account_thread),
2827 (modest_mail_operation_get_msgs_full):
2828 (modest_mail_operation_update_account),
2829 Added comments about how this works, and some code that should
2830 (but does not) check the retrieve-limit. See the TODO comment.
2832 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2834 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2835 Initialize help_id to fix the build. Warnings are good.
2837 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2839 * src/widgets/modest-hbox-cell-renderer.c:
2840 (modest_hbox_cell_renderer_append):
2841 * src/widgets/modest-vbox-cell-renderer.c:
2842 (modest_vbox_cell_renderer_append):
2843 Fix the last commit by doing an extra ref.
2845 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2847 * src/widgets/modest-hbox-cell-renderer.c:
2848 (modest_hbox_cell_renderer_append):
2849 * src/widgets/modest-vbox-cell-renderer.c:
2850 (modest_vbox_cell_renderer_append):
2851 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2852 to fix the build with Maemo Bora.
2853 However, there seems to be a remaining crash, probably due to reference
2856 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2858 * src/modest-tny-account.c:
2859 (modest_tny_account_new_for_local_folders):
2860 Use hildon_file_system_info_async_new() to get a better name for
2861 the memory card account, setting it as the account name.
2862 The timing seems to work, but this is probably
2863 not the best place to do this. See the TODO comment.
2864 * src/maemo/modest-main-window.c: (create_details_widget):
2865 * src/widgets/modest-folder-view.c: (text_cell_data):
2866 Use the tny account name instead of hardcoding a name.
2868 2007-05-30 Christian Kellner <ckellner@openismus.com>
2870 * src/modest-search.c: (modest_search):
2871 Correctly set part_search_func even if we have already parsed
2872 the query and thus a valid OgsTextSearcher object.
2874 2007-05-30 Christian Kellner <ckellner@openismus.com>
2877 Search and check for libogs.
2880 Incooparte the ogs build env.
2882 * src/modest-mime-part-search-stream.c:
2883 * src/modest-mime-part-search-stream.h:
2884 Removed since we do the real searching now in modest-search.c.
2886 * src/modest-search.c:
2887 * src/modest-search.h:
2888 Implement support for ogs. We use that if available and requested
2889 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2890 should now handle the corner case when the search term is spread
2891 across multiple reads.
2892 Also the logic in modest_search () was corrected to search all
2893 requested fields until one is found.
2895 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2897 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2899 * src/modest-init.h:
2900 * src/modest-init.c: Made modest_init_local_folders() take a
2901 path and be public so we can iniitialize maildir folders on
2904 * src/modest-local-folder-info.h:
2905 * src/modest-local-folder-info.c:
2906 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2908 * src/modest-tny-account.c:
2909 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2910 still means the standard local-folders path on the local volume.
2912 * src/modest-tny-account-store.c:
2913 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2914 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2915 all accounts when that happens.
2916 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2917 this too, so it shows up in the treeview.
2919 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2921 * src/maemo/modest-maemo-global-settings-dialog.c:
2922 (current_connection):
2923 * src/widgets/modest-global-settings-dialog.c:
2924 (current_connection_default):
2925 Use the enum values instead of 0, 1 and -1,
2926 to make the code clearer.
2928 * src/modest-account-mgr-helpers.c:
2929 (modest_account_mgr_get_connection_specific_smtp): Make this code
2932 * src/modest-runtime.h:
2933 * src/modest-runtime.c:
2934 Added modest_runtime_remove_all_send_queues().
2935 * src/maemo/modest-main-window.c:
2936 (on_account_store_connecting_finished): Recreate the send queues,
2937 using the appropriate transport accounts for this new connection.
2938 Some futher adapting might be needed if the old send queues are not
2939 automatically stopped at this point.
2941 * src/modest-tny-account-store.c: (get_server_accounts):
2942 Create the connection-specific transport accounts, so that they can
2943 be found later by their ID.
2945 * src/modest-tny-account.h:
2946 * src/modest-tny-account.c:
2947 Added modest_tny_account_new_from_server_account_name().
2948 modest_tny_account_new_from_server_account(): Do not create the
2949 send queues here, because they will be
2950 recreated anyway when the connection changes for the first time.
2952 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2954 * src/modest-local-folder-info.h:
2955 * src/modest-local-folder-info.c:
2956 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2957 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2958 tbox_folder): Take a modest account name instead of a server TnyAccount,
2959 so we can have per-modest-account rather than per-transport-account
2961 We must make sure that we change or recreate the exisitng send queues
2962 when the connection changes for connection-specific transport accounts.
2964 * src/modest-tny-account-store.c:
2965 (create_per_account_local_outbox_folders): Create outboxed per modest
2966 account, not per transport account.
2968 * src/modest-tny-account.h:
2969 * src/modest-tny-account.c:
2970 (modest_tny_account_get_special_folder): For outboxes, get the
2971 parent modest account name. The account is ignored for other folders.
2972 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2973 modest account name rather than a server TnyAccount.
2975 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2977 * src/modest-tny-account.c:
2978 (modest_tny_account_new_from_server_account):
2979 Call modest_runtime_get_send_queue() immediately after creating transport
2980 accounts, so that they start trying to send email from the outbox as soon
2981 as possible at startup. This is probably what we want.
2983 * src/modest-mail-operation.c: (update_account_thread):
2984 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2985 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2986 * src/modest-tny-send-queue.h:
2987 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2988 (modest_ui_actions_on_send):
2989 Added comments about how sending works, though it needs some more work.
2991 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2993 * src/modest-tny-account.c:
2994 (modest_tny_account_get_special_folder): Add TODO because this fails when
2995 the network is busy.
2996 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2997 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2998 Do not try to show this window when there is no active account. The UI
2999 specs does not tell us what to do in this case.
3001 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3005 * src/maemo/Makefile.am:
3006 * src/widgets/Makefile.am: Some dist fixes.
3008 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/modest-connection-specific-smtp-window.c:
3011 (on_button_edit): Make the code clearer, to prevent a double free.
3013 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3015 * src/maemo/modest-account-settings-dialog.c:
3016 (modest_account_settings_dialog_set_account_name),
3017 Check the connection-specific smtp servers checkbox if there are any.
3019 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3020 (modest_connection_specific_smtp_edit_window_init):
3021 Start with a suitable port number.
3023 * src/modest-account-mgr-helpers.h:
3024 * src/modest-account-mgr-helpers.c: Added
3025 modest_account_mgr_get_has_connection_specific_smtp().
3027 (modest_account_mgr_set_connection_specific_smtp),
3028 (modest_account_mgr_remove_connection_specific_smtp),
3029 (modest_account_mgr_get_has_connection_specific_smtp),
3030 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3031 connection-specific smtp server accounts in the account, rather than
3032 the server account conf dir.
3034 This fixes bug projects.maemo.org bug NB#58263 .
3036 * src/modest-tny-account-store.c:
3037 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3038 if there are no server accounts yet, to prevent an infinite loop when there
3039 are no accounts. Document that one must be called before the other.
3041 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3043 * src/modest-account-mgr-helpers.c:
3044 (modest_account_mgr_get_default_account): Make sure that at least
3045 one account is always the default, if there are any enabled accounts.
3046 This is just a sanity check that shouldn't be necessary.
3048 * src/modest-account-mgr-priv.c:
3049 (_modest_account_mgr_account_from_key): Unescape the conf key to
3050 get the real account name. For instance, this is an issue if a space
3051 was in the account name, which can happen because the account name
3052 is generated from the display name.
3053 (_modest_account_mgr_get_account_keyname): Always escape the
3055 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3056 Unescape the conf keys to get the real account names.
3058 For instance, previously the is-default radio button in the accounts
3059 list was not checked for any accounts at first. This fixes that,
3060 and might fix several similar bugs.
3062 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3064 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3065 Removed some debug printfs.
3067 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3069 Modest on-disk outbox directories are now here, for instance:
3070 $HOME/.modest/outboxes/<account-id-1>/outbox
3071 $HOME/.modest/outboxes/<account-id-2>/outbox
3073 $HOME/.modest/local-folders/outbox
3074 so we can have a separate outbox for each account.
3075 But they are shown as one outbox in the GtkTreeView, by using a
3076 TnyMergeFolder in a ModestTnySimpleFolderStore.
3079 * src/modest-tny-simple-folder-store.c:
3080 * src/modest-tny-simple-folder-store.h:
3081 Added ModestTnySimpleFolderStore, used to contain folders from
3082 other folder stores, such as other accounts.
3084 * src/modest-tny-outbox-account.h:
3085 * src/modest-tny-outbox-account.c:
3086 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3087 used for the per-account local outbox folders.
3089 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3090 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3091 only use this (internally) now for the non-outbox local folders.
3093 * src/modest-init.h:
3094 * src/modest-init.c: Added modest_init_one_local_folder(), for
3095 setting up the directory structure for each local folder.
3097 * src/modest-local-folder-info.c:
3098 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3099 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3101 * src/modest-local-folder-info.h:
3102 * src/modest-tny-account-store.c: (on_account_removed),
3103 (on_account_changed), (create_per_account_local_outbox_folders),
3104 (get_server_accounts), (modest_tny_account_store_get_accounts),
3105 (modest_tny_account_store_get_tny_account_by_account),
3106 (modest_tny_folder_store_is_virtual_local_folders):
3108 * src/modest-tny-account.h:
3109 * src/modest-tny-account.c:
3110 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3111 to create an on-disk per-account local outbox folder for each
3113 (create_per_account_local_outbox_folders): Create a local outbox folder
3114 for each transport account.
3115 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3116 for all local folders.
3118 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3119 instead of using g_object_get/set() directly. It is clearer.
3121 (modest_tny_folder_store_get_message_count),
3122 (modest_tny_folder_store_get_local_size
3123 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3124 because we now use these with non-acount folder stores.
3126 (modest_tny_account_get_special_folder),
3127 (modest_tny_account_new_from_server_account),
3128 (modest_tny_account_new_from_account):
3129 (recurse_folders): Adjust to the new outbox system.
3131 * src/modest-tny-folder.h:
3132 * src/modest-tny-folder.c:
3133 (modest_tny_folder_is_local_folder),
3134 (modest_tny_folder_get_local_folder_type),
3135 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3137 * src/widgets/modest-main-window.h:
3138 * src/maemo/modest-main-window.c: (create_details_widget),
3139 (modest_main_window_set_contents_style): Show details for any folder store,
3142 (modest_tny_folder_get_rules):
3143 Remove the const. C does not support constness enough for this.
3145 * src/modest-ui-actions.c:
3146 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3147 make all outboxes appear as one, in the usual local-folders tree node.
3149 (set_active_account_from_tny_account),
3150 (modest_ui_actions_on_folder_selection_changed):
3151 * src/widgets/modest-folder-view.c: (text_cell_data),
3152 (icon_cell_data), (filter_row),
3153 (add_account_folders_to_merged_folder),
3154 (add_account_folders_to_simple_folder_store), (),
3155 (get_cmp_rows_type_pos), (cmp_rows),
3156 (modest_folder_view_set_account_id_of_visible_server_account):
3157 Adjust to the new outbox system, using generic folder stores and folders
3158 in the GtkTreeModel.
3160 2007-05-23 Christian Kellner <ckellner@openismus.com>
3162 * src/modest-mail-operation.c:
3163 (modest_mail_operation_update_account):
3164 Use info->max_size instead of unintialized local var [small
3165 build fix]. (Added TODO to review that change since I don't
3168 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3170 * libmodest-dbus-client/libmodest-dbus-client.c:
3171 (libmodest_dbus_client_compose_mail): function added
3172 * src/dbus_api/modest-dbus-api.h:
3173 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3174 (on_compose_mail): Implementation of the SendAsMail functionality
3176 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3178 * src/modest-account-mgr.c:
3179 (modest_account_mgr_add_server_account): Set the secure-connection
3180 conf key for transport accounts as well as store accounts. I don't know
3181 why the if was there. For instance, this makes sure that we use SSL
3182 for the gmail preset from the easysetup wizard.
3184 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3186 * src/gnome/modest-main-window.c:
3187 (on_account_store_connecting_finished), (connect_signals):
3188 * src/maemo/modest-main-window.c:
3189 (on_account_store_connecting_finished), (connect_signals),
3190 (modest_main_window_new):
3191 Handle TnyAccountStore::connecting-finished instead of
3192 TnyDevice::connection-changed, because we cannot actually perform
3193 operations on accounts until TnyAccountStore has itself responded to
3194 the TnyDevice::connection-changed signal. This prevents a GError from
3196 Do not try to update at startup, because we (at least on scratchbox)
3197 already do an update at startup when the device goes online.
3198 This prevents a GError from tinymail.
3199 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3200 Added TODO about stopping simultaneous operations.
3202 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3204 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3205 * src/modest-mail-operation-queue.c:
3206 (modest_mail_operation_queue_remove):
3207 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3208 about where they happened.
3210 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3212 * src/modest-ui-actions.c:
3213 (modest_ui_actions_on_password_requested): Make sure that the remember
3214 output parameter is always TRUE.
3216 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3218 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3219 Show a OK/Cancel dialog if the error is a question, though we still do not
3220 know anything more about what we are asking the user.
3221 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3222 Fix an uninitialized variable (helper). This is a logic error, however.
3224 2007-05-21 Christian Kellner <ckellner@openismus.com>
3226 * src/modest-search.h:
3227 Correct bit shifting in the ModestSearchFlags enum.
3229 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3231 * src/modest-tny-account.c:
3232 (modest_tny_account_new_from_server_account): Do not use the lsub and
3233 check-all hard-coded IMAP options when using POP.
3235 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3237 * src/modest-tny-account.c:
3238 (modest_tny_account_new_from_server_account):
3239 Use NULL for the secure-auth method for POP when Password auth has been
3240 specified by the user, as we already do for IMAP. "auth=Login" causes
3241 an error from camel or the server.
3243 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3245 * src/maemo/modest-account-settings-dialog.c:
3246 (create_page_account_details),
3247 (modest_account_settings_dialog_set_account_name):
3248 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3249 for the leave-on-server checkbox, rathr than just the checkbox, when
3250 the protocol is not POP.
3252 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3254 * src/widgets/modest-account-view.c:
3255 * src/widgets/modest-account-view.h:
3256 Added modest_account_view_select_account() which will be useful later
3257 to asynchronously re-select the edited account.
3259 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3261 * src/maemo/modest-account-settings-dialog.c:
3262 (modest_account_settings_dialog_set_account_name):
3263 Automatically choose the port numbers based on the secure authentication
3264 methods, if they have not been chosen before.
3265 This fixes projects.maemo.org bug NB#56273 .
3267 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3269 * src/maemo/modest-main-window-ui.h:
3270 * src/modest-ui-actions.c:
3271 * src/modest-ui-actions.h:
3272 Connect the Tools/SMTP Servers menu item to
3273 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3274 SMTP servers dialog, as in the UI specification and saves changes when it
3275 is closed. This fixed projects.maemo.org bug NB#56305 .
3277 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3279 * src/maemo/modest-connection-specific-smtp-window.c:
3280 (modest_connection_specific_smtp_window_init):
3281 Use gtk_window_set_default_size() to make this window big enough, so
3282 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3284 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3286 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3288 (modest_connection_specific_smtp_edit_window_init),
3289 Do not try to connect to a combobox signal before the combobox exists.
3290 This fixes the cras in projects.maemo.org bug NB#56288 .
3291 (modest_connection_specific_smtp_edit_window_get_settings):
3292 Remove the server_account_name parameter which was being checked for NULL
3293 though it was not used.
3295 * src/maemo/modest-connection-specific-smtp-window.c:
3296 (modest_connection_specific_smtp_window_fill_with_connections),
3297 (on_button_edit), (modest_connection_specific_smtp_window_init):
3298 Correct the number of treemodel columns to prevent a warning.
3299 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3300 libconic does not work.
3302 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3304 * src/modest-tny-account.c:
3305 (modest_tny_account_new_from_server_account):
3306 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3307 SMTP when "None" was chosen by the user. However, with my SMTP server that
3308 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3311 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3313 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3314 to explain the memory management issue with the ID in the ModestPair.
3316 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3317 (add_sending_page), (modest_account_assistant_finalize):
3318 * src/gnome/modest-gnome-global-settings-dialog.c:
3319 (create_updating_page), (create_composing_page):
3320 * src/gnome/modest-msg-edit-window.c: (get_transports),
3321 (init_window), (modest_msg_edit_window_finalize),
3322 (modest_msg_edit_window_get_msg_data):
3323 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3324 * src/gnome/modest-transport-widget.c:
3325 (modest_transport_widget_finalize), (smtp_configuration):
3326 * src/maemo/modest-maemo-global-settings-dialog.c:
3327 (create_updating_page), (create_composing_page):
3328 * src/maemo/modest-msg-edit-window.c: (get_transports),
3329 (init_window), (modest_msg_edit_window_finalize),
3330 (modest_msg_edit_window_get_msg_data),
3331 (modest_msg_edit_window_free_msg_data):
3332 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3333 (modest_store_widget_finalize):
3334 * src/maemo/modest-transport-widget.c:
3335 (modest_transport_widget_finalize), (smtp_configuration):
3336 * src/modest-main.c: (send_mail):
3337 * src/widgets/modest-combo-box.h:
3338 * src/widgets/modest-global-settings-dialog-priv.h:
3339 * src/widgets/modest-global-settings-dialog.c:
3340 (modest_global_settings_dialog_finalize):
3341 * src/widgets/modest-msg-edit-window.h:
3342 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3343 as long as the combo box, to prevent use of freed memory for the ID.
3345 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3347 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3348 get_accounts(), to make this clearer. Do not check for the enabled gconf
3349 key, because we do not use this for server accounts (at least, not yet).
3350 This allows us to send email again.
3352 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3354 * src/maemo/modest-platform.c:
3355 (on_modest_conf_update_interval_changed), (modest_platform_init):
3356 Only respond to this particular key change. All these strcmp()s cannot be
3359 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3361 * src/maemo/modest-maemo-global-settings-dialog.c:
3362 (current_connection): Prevent a crash in scratchbox when
3363 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3364 * src/maemo/modest-platform.c:
3365 (on_modest_conf_update_interval_changed), (modest_platform_init):
3366 Get the update interval from gconf and reset it when the gconf key changes.
3368 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3370 * src/modest-protocol-info.c:
3371 * src/modest-protocol-info.h: Adde enum-specific get functions,
3372 instead of using a ModestProtocolType enum parameter.
3374 * src/gnome/modest-account-assistant.c:
3375 * src/gnome/modest-store-widget.c:
3376 * src/gnome/modest-store-widget.h:
3377 * src/gnome/modest-transport-widget.c:
3378 * src/gnome/modest-transport-widget.h:
3379 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3380 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3381 * src/maemo/easysetup/modest-easysetup-wizard.c:
3382 * src/maemo/modest-account-settings-dialog.c:
3383 * src/maemo/modest-account-settings-dialog.h:
3384 * src/maemo/modest-store-widget.c:
3385 * src/maemo/modest-store-widget.h:
3386 * src/maemo/modest-transport-widget.c:
3387 * src/maemo/modest-transport-widget.h:
3388 * src/modest-account-mgr-helpers.c:
3389 * src/modest-account-mgr-helpers.h:
3390 * src/modest-account-mgr.c:
3391 * src/modest-account-mgr.h:
3392 * src/modest-tny-account.c:
3393 * src/modest-tny-folder.c:
3394 * src/widgets/modest-account-view.c:
3395 * src/widgets/modest-retrieve-combo-box.c:
3396 * src/widgets/modest-retrieve-combo-box.h:
3397 * src/widgets/modest-secureauth-combo-box.c:
3398 * src/widgets/modest-serversecurity-combo-box.c:
3399 * src/widgets/modest-serversecurity-combo-box.h:
3400 * tests/check_account-mgr.c:
3401 Use the specific functions, and use the re-renamed enum values for GNOME too.
3403 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3405 * src/modest-pair.h:
3406 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3407 so we can get the second based on the first.
3409 * src/maemo/modest-account-settings-dialog.h:
3410 * src/maemo/modest-account-settings-dialog.c:
3411 Added get_supported_secure_authentication_methods(), though it is mostly
3412 commented-out for now until the necessary API is committed to tinymail.
3413 (modest_account_settings_dialog_set_account_name),
3414 (save_configuration): Request the supported authentication methods from the
3415 server, so we can choose a working method.
3417 * src/modest-tny-account-store.h:
3418 * src/modest-tny-account-store.c:
3419 (modest_tny_account_store_get_session): Rename from
3420 tny_account_store_get_session().
3422 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3424 * src/modest-protocol-info.h: Split the ModestProtocol enum
3425 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3426 There was no need to have these unrelated values in one enum.
3428 * src/: many files: Adapted to changed enum. This makes the code a bit
3429 clearer, and the compiler could catch some errors.
3431 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3434 Show the detailed internal camel error message when an error happens
3435 during the configuration, so that our testers can give us more clues.
3436 For instance, in projects.maemo.org bug NB#56910 .
3438 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3440 * src/modest-tny-account.c:
3441 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3442 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3444 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3446 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3447 * src/maemo/modest-account-settings-dialog.c:
3448 (modest_account_settings_dialog_set_account_name),
3449 (save_configuration): For the incoming secure authentication checkbox,
3450 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3451 the UI specification. PLAIN does not seem to be supported for most IMAP
3452 servers anyway, and I am not sure what it would mean.
3453 However, we probably need to discover which of the secure-authentication
3454 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3455 * src/modest-account-mgr-helpers.c:
3456 (modest_account_mgr_get_server_account_data):
3458 * src/modest-tny-account.c:
3459 (modest_tny_account_new_from_server_account):
3460 Use tny_account_set_mech() to set secure-authentication methods,
3461 with some special-casing for IMAP, based on my observations of how
3464 * src/modest-account-mgr-helpers.h:
3465 * src/modest-account-mgr.c:
3466 * src/modest-defs.h: Comment that the URI is only used for local folders.
3468 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3471 parameter const, just to be neat.
3472 * src/modest-text-utils.c: (modest_text_utils_inline):
3473 End g_strconcat() with NULL, as its documentation says. This is almost
3474 certainly the cause of my crash at startup on the device. Interestingly,
3475 valgrind doesn't tell us about these errors.
3477 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3479 * scripts/build-packages: Added more precise comments about how to use
3480 this script, though I still get this error:
3481 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3482 error building tinymail
3484 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3486 * src/maemo/modest-main-window.c: (on_account_update):
3487 Very slight cleanup, hoping to make it simpler to discover what causes
3488 a crash here sometimes.
3490 * src/modest-tny-account.c:
3491 (modest_tny_account_new_from_server_account): Set the port. Added
3492 comments about the options and a TODO comment because I need to find out
3493 how to specify the secure authentication method.
3495 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3497 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3498 changed CFlags paths form modest to libmodest
3500 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3502 * src/modest-account-mgr-helpers.c:
3503 (modest_account_mgr_get_server_account_data),
3504 (modest_account_mgr_free_server_account_data):
3505 * src/modest-account-mgr-helpers.h:
3506 * src/modest-account-mgr.c:
3507 (modest_account_mgr_add_server_account):
3508 * src/modest-defs.h:
3509 * src/modest-tny-account.c:
3510 (modest_tny_account_new_from_server_account):
3511 Determine the options for tny_camel_account_add_option() here,
3512 based on the settings, rather than storing them directly in gconf.
3514 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3516 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3517 Show a more friendly error dialog now that we expect (from the tinymail
3518 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3520 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3522 * src/maemo/modest-main-window.c: (on_account_update): Check that
3523 account_name is not NULL, to prevent a crash at startup that I am
3524 seeing on the N800. I do wonder why it is NULL.
3526 * src/maemo/easysetup/modest-easysetup-wizard.c:
3527 (create_page_user_details):
3528 * src/maemo/modest-account-settings-dialog.c:
3529 (create_page_user_details), (create_page_outgoing):
3530 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3531 (modest_connection_specific_smtp_edit_window_init):
3532 * src/modest-ui-actions.c:
3533 (modest_ui_actions_on_password_requested):
3534 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3535 might do something useful with the on-screen keyboard.
3537 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3539 * src/maemo/modest-main-window.c: (on_account_update):
3540 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3541 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3543 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3545 * src/modest-tny-account-store.c: (on_account_changed):
3546 Correct the signature of this signal handler.
3548 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3550 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3551 Show a HildonNote instead of a GtkDialog for Maemo.
3553 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3555 * src/widgets/modest-account-view.h:
3556 * src/widgets/modest-account-view.c: (on_account_changed),
3557 (on_account_removed). Added a boolean flag, set/unset by
3558 modest_account_view_block_conf_updates(),
3559 modest_account_view_unblock_conf_updates() to prevent unnecessary
3560 updates, but this is not very useful because the gconf notifications are
3561 so delays (maybe only on Maemo Bora).
3562 So auto-updating is turned off, and these functions do an explicit
3563 update when necessary.
3564 However, something else is still doing too much work when adding/removing
3565 accounts, probably in another part of the application.
3567 * src/maemo/modest-account-view-window.c:
3568 (on_delete_button_clicked), (on_edit_button_clicked),
3569 (on_new_button_clicked): Use the new functions.
3571 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3573 * src/modest-account-mgr-helpers.c:
3574 (modest_account_mgr_set_first_account_as_default):
3575 Sort the list of names alphabetically-by-title, so we choose the first one
3577 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3578 alphabetically by the title.
3580 This fixes projects.maemo.org bug NB#56418 .
3582 * src/modest-account-mgr-priv.c:
3583 (_modest_account_mgr_account_from_key):
3584 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3585 avoid a valgrind error, and possible random behaviour.
3587 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3589 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3590 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3591 tinymail documentation to say that this can be expected.
3592 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3593 pretty, and should not happen, but I would prefer to know when it does.
3595 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3597 * configure.ac: When using the older hildon version, probably on Bora,
3598 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3600 * src/widgets/modest-attachment-view.c:
3601 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3604 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3606 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3607 Implemented the prototype. Can be tested with
3608 tests/dbus_api/test_open_message:
3610 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3612 * src/modest-tny-account-store.c:
3613 (modest_tny_account_store_instance_init), (get_password):
3614 * src/modest-ui-actions.c:
3615 (modest_ui_actions_on_password_requested):
3616 Do not store the password in gconf, because this function is called
3617 for non-remembered passwords. Actually use the cached (in the hash map)
3618 password instead of releasing it.
3619 The password will now not be remembered if it is asked via the protected
3620 password dialog, as per the UI spec.
3622 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3624 * src/modest-defs.h:
3625 * src/modest-account-mgr-helpers.h:
3626 * src/modest-account-mgr-helpers.c:
3627 Added modest_server_account_get_username_has_succeeded(),
3628 modest_server_account_set_username_has_succeeded().
3629 (modest_server_account_set_username),
3630 Reset the has-succeeded flag if the username changes.
3632 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3633 * src/maemo/modest-connection-specific-smtp-window.c:
3634 (modest_connection_specific_smtp_window_save_server_accounts):
3635 Use modest_server_account_set_username() instead of using
3636 modest_conf_set_string() directly, so that the has-succeeded flag is always
3639 * src/modest-ui-actions.c:
3640 (modest_ui_actions_on_password_requested): Dim the username entry if
3641 the username has ever worked, as per the UI spec.
3643 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3645 * src/modest-tny-account-store.c: (get_password):
3646 * src/modest-ui-actions.c:
3647 (modest_ui_actions_on_password_requested):
3648 Allow the username to be changed too, though there is more work to
3649 be done on exactly how this behaves.
3651 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3653 * src/modest-account-mgr-helpers.h:
3654 * src/modest-account-mgr-helpers.c:
3655 Added modest_account_mgr_get_display_name(),
3656 modest_server_account_get_username(),
3657 modest_server_account_set_username(),
3658 modest_server_account_set_password(),
3659 modest_server_account_get_hostname() functions so we do not need to
3660 use the conf API directly.
3662 * src/maemo/modest-main-window.c: (connect_signals):
3663 Actually connect ot the ModestAccountStore::request-password signal,
3664 so that we show the dialog when the password is requested by Tinymail,
3665 for isntance if it is empty.
3667 * src/modest-marshal.list:
3668 * src/modest-tny-account-store.c:
3669 (modest_tny_account_store_class_init), (get_password),
3670 (modest_tny_account_store_alert):
3671 * src/modest-tny-account-store.h:
3672 * src/modest-ui-actions.h:
3673 * src/modest-ui-actions.c:
3674 (modest_ui_actions_on_password_requested):
3675 Change the signal parameters, so it is obvious that we are providing
3676 the non human-readable server name, and receiving both the username
3677 and password, though changing of the username is not yet implemented.
3678 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3679 for the GNOME version.
3681 This should fix the projects.maemo.org bug NB#56209, though it does not
3682 work on Bora, because the gconf_client_get() for the password fails
3683 immediately after we save it with gconf_client_set().
3685 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3688 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3689 caused an undefined symbol error:
3690 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3692 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3694 * src/modest-tny-account-store.c:
3695 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3696 using a GError instead of a string message, so we can translate it in
3699 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3701 * src/maemo/modest-address-book.c:
3702 (modest_address_book_check_names):
3703 * src/maemo/modest-msg-view-window.c:
3704 (modest_msg_view_window_clipboard_owner_change):
3705 * src/modest-init.c: (modest_init_init_ui):
3706 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3707 (update_folders_cb), (modest_mail_operation_update_account):
3708 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3709 (modest_ui_actions_on_msg_attachment_clicked),
3710 (modest_ui_actions_on_msg_recpt_activated):
3711 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3712 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3713 (modest_msg_view_search_next):
3714 * src/widgets/modest-recpt-editor.c:
3715 (modest_recpt_editor_on_button_release_event),
3716 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3717 g_message(). At this point we should only be seeing interesting errors on
3718 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3720 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3722 (modest_wizard_dialog_force_title_update):
3723 * src/maemo/easysetup/modest-wizard-dialog.h:
3724 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3725 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3726 can update the title when appropriate. Otherwise the title is wrong if the
3727 pages are added after adding the notebook to the dialog.
3728 This must be a problem in HildonWizardDialog too.
3729 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3731 * src/maemo/easysetup/modest-easysetup-wizard.c:
3732 (create_subsequent_customsetup_pages),
3733 (create_subsequent_easysetup_pages):
3734 Call modest_wizard_dialog_force_title_update() so that the title is
3735 correct even with GTK+ < 2.10.
3736 This fixes projects.maemo.org bug NB#56145 .
3738 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3740 * src/maemo/modest-platform.c:
3741 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3742 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3745 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3747 * src/widgets/modest-window.h:
3748 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3749 and modest_window_save_state(), which invokes it.
3751 * src/widgets/modest-window-mgr.h:
3752 * src/widgets/modest-window-mgr.c:
3753 Added modest_window_mgr_save_state_for_all_windows(), which calls
3754 the save_state vfunc on all registered windows, if implemented.
3756 * src/gnome/modest-msg-edit-window.c:
3757 * src/gnome/modest-msg-view-window.c:
3758 * src/maemo/modest-msg-edit-window.c:
3759 * src/maemo/modest-msg-view-window.c:
3760 * src/maemo/modest-main-window.c:
3761 Specify the existing save_settings functions as implementations of
3762 ModestWindow::save_state_func().
3764 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3765 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3766 enabling hibernation, for instance.
3768 We may need to do the same thing for restoring settings.
3771 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3773 * src/widgets/modest-window-mgr.c:
3774 * src/widgets/modest-window-mgr.h:
3775 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3776 modest_window_mgr_get_hibernation_is_prevented().
3778 * src/maemo/modest-main-window.c:
3779 (on_hildon_program_is_topmost_notify): Prevent hibernation
3780 (possible when the application goes to the background in the WM),
3781 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3783 * src/maemo/easysetup/modest-easysetup-wizard.c:
3784 (modest_easysetup_wizard_dialog_init):
3785 * src/maemo/modest-account-settings-dialog.c:
3786 (modest_account_settings_dialog_init):
3787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3788 (modest_connection_specific_smtp_edit_window_init):
3789 * src/maemo/modest-connection-specific-smtp-window.c:
3790 (modest_connection_specific_smtp_window_init):
3791 * src/maemo/modest-signature-editor-dialog.c:
3792 (modest_signature_editor_dialog_init):
3793 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3794 prevent hibernation while any of these account settings dialogs are open.
3796 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3798 * src/maemo/Makefile.am:
3799 * src/maemo/modest-osso-state-saving.c:
3800 * src/maemo/modest-osso-state-saving.h: Added
3801 modest_osso_load_state() and modest_osso_save_state() though they do
3802 nothing now. They should iterate through all the open windows and load/save
3804 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3805 save state when closing.
3807 * src/maemo/modest-main-window.c:
3808 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3809 Add a notification handler for the HildonProgram::is-topmost property,
3810 so we can allow hibernation when the application goes into the background.
3811 But we still need to detect when the accounts setup windows are open so
3812 we can stop hibernation when they are open.
3813 To do this, I also added the main window the HildonProgram. This might have
3814 other side-effects/benefits, and should maybe be done for other windows.
3816 * src/maemo/modest-osso-autosave-callbacks.h:
3817 * src/maemo/modest-osso-autosave-callbacks.c:
3818 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3819 though it does not do anything yet, and we might never need this to do
3820 anything. For instance, we already save drafts.
3822 * src/maemo/modest-platform.c: (modest_platform_init):
3823 Specify the libosso auto-save callback.
3825 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3827 * src/maemo/modest-platform.c:
3828 (modest_platform_set_update_interval):
3829 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3830 aparently stays valid between application instances, so we can use this
3831 to remove and reset it later. According to a maemo-developers email from
3834 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3836 * configure.ac: Depend on libalarm for Maemo.
3838 * src/dbus_api/modest-dbus-api.h:
3839 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3840 (on_send_receive), (modest_dbus_req_handler):
3841 Handle a SEND_RECEIVE D-Bus method.
3843 * libmodest-dbus-client/libmodest-dbus-client.c:
3844 (libmodest_dbus_client_send_and_receive):
3845 * libmodest-dbus-client/libmodest-dbus-client.h:
3846 Add C convenience functions for calling the new D-Bus method.
3848 * src/modest-platform.h:
3849 * src/gnome/modest-platform.c:
3850 * src/maemo/modest-platform.c:
3851 Added modest_platform_set_update_interval(), which uses the
3852 alarmd API on Maemo.
3853 (modest_platform_init),
3854 Call modest_platform_set_update_interval(), using a hard-coded
3855 interval for now (until the global settings dialog is implemented),
3856 though I am not sure that this makes sense yet.
3858 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3860 * src/dbus_api/modest-dbus-callbacks.c:
3861 (modest_osso_cb_hw_state_handler):
3862 * src/dbus_api/modest-dbus-callbacks.h:
3863 * src/maemo/modest-platform.c: (modest_platform_init):
3864 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3865 in case this has some effect on the ability for Maemo to ping the
3868 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3870 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3871 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3872 warning. It is probably a logic error, but I need to fix the build.
3874 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3876 * src/modest-account-mgr.h:
3877 * src/modest-account-mgr.c:
3878 (modest_account_mgr_account_names): Add a gboolean enabled_only
3879 parameter, so we can get lists of onlt the enabled accounts.
3881 (modest_account_mgr_add_account),,
3882 (modest_account_mgr_account_with_display_name_exists):
3883 * src/maemo/modest-msg-edit-window.c: (get_transports):
3884 * src/modest-account-mgr-helpers.c:
3885 (modest_account_mgr_set_first_account_as_default):
3886 * src/modest-init.c: (init_default_account_maybe):
3887 * src/modest-tny-account-store.c: (get_accounts):
3888 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3889 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3890 * tests/check_account-mgr.c: (START_TEST):
3891 Provide the extra parameter, as appropriate.
3893 * src/widgets/modest-account-view.c: (update_account_view):
3894 Do not show disabled accounts (meaning that there is no way to
3895 enable/disable accounts in the UI (the feature is not in our UI
3896 specification), so we can use this internally only to mark unfinished
3897 or temporary account data.
3899 * src/maemo/easysetup/modest-easysetup-wizard.c:
3900 (create_account): Add boolean enable parameter, so we can specify FALSE
3901 to create the temporary account.
3902 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3903 (on_before_next): When finishing, when there is a temporary account, just
3905 Also, use a timeout to delay the showing of the dialog until gconf is likely
3906 to return correct information, due to a maemo gconf bug that is fixed in
3907 osso 1.1, but not yet in Bora.
3908 However, the dialog stays on screen after it is destroyed.
3910 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3911 for invalid data when cancelling. Use a hildon note instead of a dialog
3912 to complain about invalid data. Do not show the account-saved note if the
3913 account is disabled (a temporary account that will not really be saved for use
3916 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3918 * src/modest-account-mgr-helpers.h:
3919 * src/modest-account-mgr-helpers.c:
3920 Added modest_account_mgr_unset_default_account(),
3921 Added modest_account_mgr_set_first_account_as_default().
3923 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3924 If it was the default account, unset the default account name.
3926 * src/maemo/modest-account-view-window.c:
3927 (on_delete_button_clicked): If it was the default account,
3928 set the first remaining account as the default instead.
3930 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3931 a NULL account or a NULL default account, to prevent a crash. This should
3932 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3935 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3937 * src/widgets/modest-recpt-editor.c:
3938 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3939 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3940 TODO comment for this. This fixes the build.
3942 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3943 be the best place for it. This will in future update all auto-update accounts,
3944 rather than just the current/default account, when that gconf key exists.
3945 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3946 if there are no accounts, before calling do_send_receive().
3947 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3949 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3950 * src/maemo/modest-main-window-ui.h:
3951 * src/maemo/modest-main-window.c: (on_connection_changed),
3952 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3953 directly, becaue the signal handler does more.
3955 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3957 * src/modest-account-mgr-helpers.c:
3958 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3959 for the case that the account does not exist.
3961 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3962 (equivalent to the modest account name) rather than the tinymail account name
3963 (equivalent to the modest account title - human readable) to get the account data.
3964 Check for null account data to prevent the crash, and add a TODO comment saying that
3965 this needs fixing because it is using the server account name instead of the account name.
3967 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3969 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3970 * src/maemo/modest-account-settings-dialog.c: (show_error),
3972 Use hildon_note_new_information() for informative and error messages,
3973 which seems to be expected for Maemo applications (no documentation that I know of
3974 says this). I am surprised that there is no distinction between info and error
3977 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3979 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3980 it is easy to find where this is used.
3982 * src/maemo/easysetup/modest-easysetup-wizard.c:
3983 (create_page_welcome), (create_page_account_details),
3984 (create_page_user_details), (create_page_complete_easysetup),
3985 (create_page_custom_incoming), (create_page_custom_outgoing),
3986 (create_page_complete_custom):
3987 * src/maemo/modest-account-settings-dialog.c:
3988 (create_page_account_details), (create_page_user_details),
3989 (create_page_incoming), (create_page_outgoing):
3990 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3991 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3992 (modest_connection_specific_smtp_edit_window_init):
3993 * src/maemo/modest-connection-specific-smtp-window.c:
3994 (modest_connection_specific_smtp_window_init):
3995 * src/maemo/modest-signature-editor-dialog.c:
3996 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3997 and scrolling policy as per the Email Application Layout Guide, if I have
4000 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4002 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
4003 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
4004 which were empty, because these vfuncs have been removed from TnyAccountStore.
4005 This fixes the build.
4007 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4009 * src/maemo/modest-main-window.c:
4010 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
4011 showing/hiding it. Added TODO because it probably should not be NULL.
4012 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
4013 because unnecessary g_warnings() make degugging difficult.
4015 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/modest-msg-edit-window.c:
4018 (modest_msg_edit_window_select_color),
4019 (modest_msg_edit_window_select_background_color): 2 const corrections and
4020 moving 2 #endifs before closing brackets, to fix the build.
4022 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4024 * src/maemo/easysetup/modest-easysetup-wizard.h:
4025 * src/maemo/easysetup/modest-easysetup-wizard.c:
4026 (modest_easysetup_wizard_dialog_finalize),
4027 (on_button_edit_advanced_settings), (create_page_complete_custom),
4028 (on_response), (create_account):
4029 Implement the Advanced Settings edit button, by saving the account information,
4030 for the Advanded Settings dialog to use directly from gconf, and removing it
4031 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4032 Bug #5533 in the projects.maemo.org bugzilla.
4034 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4036 * src/maemo/modest-msg-view-window.c:
4037 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4038 when opening a message window.
4040 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4042 * src/maemo/easysetup/modest-easysetup-wizard.c:
4043 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4046 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4047 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4048 gconf settings. I probably added more checks than necessary, but that is safer.
4050 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4051 variable to fix the build, but this seems to be used when it is still NULL.
4053 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4055 * src/modest-platform.h:
4056 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4057 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4058 * src/modest-main.c: Implement this function so we can avoid using
4059 maemo-specific API from cross-platform code.
4061 * src/modest-tny-account-store.c:
4062 (get_smtp_specific_transport_account_for_open_connection):
4063 * src/modest-ui-actions.c: (check_for_connection),
4064 (modest_ui_actions_on_item_not_found):
4065 Use modest_platform_connect_and_wait() and put #idefs around other
4066 maemo-specific code, because only maemo currently has a way to
4067 identify connection names.
4069 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4071 * src/modest-tny-account-store.h:
4072 * src/modest-tny-account-store.c:
4073 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4074 the connection-specific SMTP server settings in the configuration.
4076 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4078 * src/maemo/modest-main-window.c: (on_connection_changed),
4080 * src/modest-main.c: (main), (start_ui), (send_mail):
4081 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4082 that is what is intended.
4084 * src/modest-ui-actions.c: (action_send), (action_receive),
4085 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4086 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4087 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4088 SMTP server is used when it is specified.
4090 (modest_ui_actions_on_send_receive):
4091 Check that a connection is open before proceeding.
4092 Receive and then send, instead of vice-versa, as per the specification.
4094 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4096 * src/modest-mail-operation.c:
4097 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4098 though I guess it should be something other than NULL.
4100 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4102 * src/maemo/easysetup/modest-easysetup-wizard.c:
4103 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4104 combo twice, to avoid an g_warning and to make it visible again.
4105 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4106 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4107 (already intended) dereference when detaching, because we then recreate the menu.
4108 But I am not sure why the warning was happening, and it is possible that this is a memory
4111 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4113 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4114 and uri_parse_mailto() utility functions.
4115 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4117 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4119 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4121 * src/dbus_api/modest-dbus-api.h:
4122 * src/dbus_api/modest-dbus-callbacks.c:
4123 Use an idle callback to execute the modest code in the application's own thread.
4124 Remove the helloworld example method.
4125 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4126 parsed, and the open-message method is not implemented because this is not yet implemented in
4128 * libmodest-dbus-client/libmodest-dbus-client.c:
4129 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4130 (libmodest_dbus_client_open_message):
4131 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4133 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4134 body without crashing.
4136 * tests/dbus_api/Makefile.am:
4137 * tests/dbus_api/test_mail_to.c:
4138 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4140 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4142 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4143 Added file to fix the build. Sorry.
4145 * src/dbus_api/Makefile.am:
4146 * src/dbus_api/modest-dbus-api.h:
4147 * src/dbus_api/modest-dbus-callbacks.h:
4148 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4149 (modest_dbus_req_handler):
4150 Put constants in a separate header so it can be reused by the
4151 client library, without duplication
4153 * libmodest-dbus-client/Makefile.am:
4154 * libmodest-dbus-client/libmodest-dbus-client.c:
4155 (libmodest_dbus_client_call_helloworld),
4156 (libmodfest_dbus_client_send_mail),
4157 (libmodfest_dbus_client_mailto),
4158 (libmodfest_dbus_client_open_message):
4159 * libmodest-dbus-client/libmodest-dbus-client.h:
4160 (Partly) Implement a send_mail D-Bus method.
4162 * tests/dbus_api/Makefile.am:
4163 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4164 the send_email D-Bus method.
4166 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4170 * libmodest-dbus-client/Makefile.am:
4171 * libmodest-dbus-client/libmodest-dbus-client.c:
4172 * libmodest-dbus-client/libmodest-dbus-client.h:
4173 * tests/dbus_api/Makefile.am:
4174 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4175 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4177 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4179 * src/maemo/easysetup/modest-easysetup-wizard.c:
4180 (create_page_account_details):
4181 * src/maemo/modest-account-settings-dialog.c:
4182 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4183 widgets, because this might not be the default in future versions of the Maemo GTK+.
4184 However, I can not not get capitalization to work even in a simple test case.
4186 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/easysetup/modest-easysetup-wizard.c:
4189 (create_page_custom_incoming), (create_page_custom_outgoing):
4190 * src/maemo/modest-account-settings-dialog.c:
4191 (create_page_account_details), (create_page_incoming),
4192 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4193 instead of using gtk_check_button_with_label(), so they are aligned like the other
4194 widgets, as per the UI spec.
4196 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4198 * src/maemo/easysetup/modest-easysetup-wizard.c:
4199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4200 * src/widgets/modest-validating-entry.c:
4201 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4202 Modest prefix instead of an EasySetup prefix.
4204 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4206 * src/widgets/modest-validating-entry.h:
4207 * src/widgets/modest-validating-entry.c: (on_insert_text),
4208 Added easysetup_validating_entry_set_max_func(), used to set a callback
4209 to call when the max number of characters is reached. GtkEntry has a max-length
4210 already but is silent about it.
4212 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4213 (create_page_account_details), (create_page_user_details),
4215 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4216 (create_page_account_details), (create_page_user_details),
4217 (create_page_outgoing):
4218 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4219 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4220 the UI spec, when the user tries to enter more than the max number of characters.
4222 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4224 * src/maemo/easysetup/modest-easysetup-wizard.c:
4225 (create_page_user_details), (create_page_custom_incoming),
4226 (create_page_custom_outgoing):
4227 * src/maemo/modest-account-settings-dialog.c:
4228 (create_page_user_details), (create_page_incoming),
4229 (create_page_outgoing):
4230 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4231 (modest_connection_specific_smtp_edit_window_init):
4232 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4233 not appropriate. Bad Maemo-specific defaults!.
4235 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4237 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4238 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4239 (modest_signature_editor_dialog_set_settings):
4240 Disable the label and textview when the checkbox is disabled, and use the
4241 specified (UI spec) default signature text.
4243 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4245 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4246 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4248 * src/modest-defs.h:
4249 * src/modest-account-mgr-helpers.h:
4250 * src/modest-account-mgr-helpers.c:
4251 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4253 * src/maemo/Makefile.am:
4254 * src/maemo/modest-signature-editor-dialog.c:
4255 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4258 * src/maemo/modest-account-settings-dialog.h:
4259 * src/maemo/modest-account-settings-dialog.c:
4260 (modest_account_settings_dialog_finalize), (on_button_signature),
4261 (save_configuration): Use the new dialog when the Edit button is pressed, and
4262 save the changes if necessary, as per the UI spec.
4264 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4266 * src/maemo/Makefile.am:
4267 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4268 based on maemo-develoers email from Dirk.
4270 * src/maemo/easysetup/modest-easysetup-wizard.c:
4271 (create_page_welcome), (create_page_account_details),
4272 (create_page_user_details), (create_page_complete_easysetup),
4273 (create_page_custom_incoming), (create_page_custom_outgoing),
4274 (create_page_complete_custom),
4275 (modest_easysetup_wizard_dialog_init):
4276 * src/maemo/modest-account-settings-dialog.c:
4277 (create_page_account_details), (create_page_user_details),
4278 (create_page_incoming), (create_page_outgoing),
4279 (modest_account_settings_dialog_init):
4280 * src/maemo/modest-connection-specific-smtp-window.c:
4281 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4283 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4285 * src/maemo/easysetup/modest-easysetup-wizard.c:
4286 (create_page_account_details), (create_page_custom_outgoing),
4287 (create_page_complete_custom):
4288 * src/maemo/modest-account-settings-dialog.c:
4289 (create_page_user_details), (create_page_incoming),
4290 (create_page_outgoing):
4291 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4292 (modest_connection_specific_smtp_edit_window_init):
4293 Use the correct (UI spec) port min/max, and use horizontal separators,
4296 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4298 * src/maemo/easysetup/modest-easysetup-wizard.c:
4299 (set_default_custom_servernames):
4300 * src/maemo/modest-account-settings-dialog.c:
4301 (create_page_incoming), (on_combo_outgoing_security_changed),
4302 (on_combo_incoming_security_changed), (create_page_outgoing),
4303 (modest_account_settings_dialog_set_account_name),
4304 (save_configuration):
4305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4306 (on_combo_security_changed),
4307 (modest_connection_specific_smtp_edit_window_init),
4308 (modest_connection_specific_smtp_edit_window_set_connection),
4309 (modest_connection_specific_smtp_edit_window_get_settings):
4310 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4313 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4316 * src/maemo/easysetup/modest-easysetup-wizard.c:
4317 (create_page_custom_outgoing), (create_page_complete_custom):
4318 * src/maemo/modest-account-settings-dialog.c:
4319 (create_page_user_details), (create_page_outgoing):
4320 * src/maemo/modest-account-view-window.c: (button_box_new):
4321 Use changed logical IDs as per the most recent UI spec:
4322 mcen_bd_emailsetup_edit -> mcen_bd_edit
4323 mcen_bd_emailsetup_delete -> mcen_bd_delete
4324 mcen_bd_emailsetup_close -> mcen_bd_close
4326 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4330 * src/dbus_api/Makefile.am:
4331 * src/dbus_api/modest-dbus-callbacks.c:
4332 * src/dbus_api/modest-dbus-callbacks.h:
4333 * src/maemo/modest-platform.c: (modest_platform_init):
4334 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4336 * tests/Makefile.am:
4337 * tests/dbus_api/Makefile.am:
4338 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4340 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4342 * src/maemo/modest-account-settings-dialog.c:
4343 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4344 Removed unnecessary includes.
4346 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4348 * src/maemo/easysetup/modest-easysetup-wizard.c:
4349 * src/maemo/modest-account-settings-dialog.c:
4350 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4351 * src/widgets/Makefile.am:
4352 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4353 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4354 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4355 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4356 * src/widgets/modest-secureauth-combo-box.c:
4357 * src/widgets/modest-secureauth-combo-box.h:
4358 * src/widgets/modest-serversecurity-combo-box.c:
4359 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4360 made the GObject names more consistent with the rest of the Modest code.
4362 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4364 * src/maemo/easysetup/Makefile.am:
4365 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4366 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4367 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4368 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4369 * src/maemo/easysetup/modest-easysetup-wizard.c:
4370 * src/maemo/easysetup/modest-validating-entry.c:
4371 * src/maemo/easysetup/modest-validating-entry.h:
4372 * src/maemo/modest-account-settings-dialog.c:
4373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4374 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4375 widgets/ because they are used outside of easysetup too. After checking in,
4376 svn will allow me to rename them too.
4378 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4380 * src/gnome/modest-msg-edit-window.c:
4381 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4382 linker error, to fix the build on the GNOME platform.
4383 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4384 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4385 ifdefed out to avoid a warning.
4387 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4389 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4390 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4391 some alternative for GTK+ 2.6.
4393 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4395 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4397 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4398 specified for EmailAccountsDialog in UI spec.
4400 * src/maemo/easysetup/modest-easysetup-wizard.c:
4401 * src/maemo/easysetup/modest-easysetup-wizard.h:
4402 * src/maemo/modest-account-settings-dialog.c:
4403 * src/maemo/modest-account-settings-dialog.h:
4404 Reuse a member window widget for the connection-specific SMTP server accounts,
4405 so we can tell it to create/save the accounts only if we actually save changes.
4407 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4408 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4409 (modest_connection_specific_smtp_edit_window_get_settings):
4410 Return a struct instance for temporarily remembering the entered data.
4412 * src/maemo/modest-connection-specific-smtp-window.h:
4413 * src/maemo/modest-connection-specific-smtp-window.c:
4414 (modest_connection_specific_smtp_window_finalize),
4415 (modest_connection_specific_smtp_window_fill_with_connections),
4417 (modest_connection_specific_smtp_window_save_server_accounts),
4418 (update_model_server_names): Do not actually save data until asked,
4419 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4421 (on_selection_changed),
4422 (modest_connection_specific_smtp_window_init): Disable the edit
4423 button when nothing is selected.
4425 * src/modest-account-mgr-helpers.c:
4426 * src/modest-account-mgr-helpers.h:
4427 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4430 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4432 * src/modest-account-mgr-helpers.h:
4433 * src/modest-account-mgr-helpers.c:
4434 (modest_account_mgr_get_unused_account_name),
4435 (modest_account_mgr_get_unused_account_display_name): Added these
4436 utility functions, to avoid code duplication.
4438 * src/maemo/easysetup/modest-easysetup-wizard.c:
4439 (create_page_account_details), (create_account):
4440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4441 (on_combo_security_changed),
4442 (modest_connection_specific_smtp_edit_window_init),
4443 (modest_connection_specific_smtp_edit_window_save_settings):
4444 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4445 * src/maemo/modest-connection-specific-smtp-window.c:
4446 (modest_connection_specific_smtp_window_finalize),
4447 (modest_connection_specific_smtp_window_fill_with_connections),
4448 (on_button_edit), (modest_connection_specific_smtp_window_init):
4449 * src/maemo/modest-connection-specific-smtp-window.h:
4450 Implementing saving of connection-specific server accounts.
4452 But I need to refactor this so we can save the data for each
4453 possible connection-specific account and only actually create the server accounts
4454 when the easysetup finished, or the OK button is pressed on the account settings
4457 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4459 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4460 (on_combo_security_changed):
4461 (modest_connection_specific_smtp_edit_window_init):
4462 Auto-fill the port number as in the account settings.
4464 (modest_connection_specific_smtp_edit_window_set_connection):
4465 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4466 * src/maemo/modest-connection-specific-smtp-window.c:
4467 (fill_with_connections), (on_button_edit),
4468 (modest_connection_specific_smtp_window_init):
4469 Turn the edit window into a dialog to simplify the code, and
4470 set a WM hint as in a GtkDialog, because only a popup can be on top of
4471 another window in Maemo, and popups usually have no WM decoration.
4473 * src/modest-defs.h:
4474 * src/modest-account-mgr-helpers.c:
4475 (modest_account_mgr_set_connection_specific_smtp),
4476 (modest_account_mgr_remove_connection_specific_smtp),
4477 (modest_account_mgr_get_connection_specific_smtp):
4478 * src/modest-account-mgr-helpers.h: Some functions to write the
4479 connection-specific SMTP server information. Not yet used.
4482 * src/widgets/modest-folder-view.c: (text_cell_data):
4483 Fix a warning about an uninitialized variable.
4484 (on_configuration_key_changed): Put an #ifdef around the use
4485 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4487 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4489 * src/maemo/modest-account-settings-dialog.h:
4490 * src/maemo/modest-account-settings-dialog.c:
4491 Added connect_for_modified() utility function to mark the new modified boolean.
4493 (create_page_account_details), (create_page_user_details),
4494 (create_page_incoming), (create_page_outgoing), (on_response),
4495 (modest_account_settings_dialog_init),
4496 (modest_account_settings_dialog_set_account_name):
4497 Only warn about unsaved changes when there are actually unsaved changes.
4499 * src/modest-account-mgr-helpers.c:
4500 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4501 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4502 to get the data from there in future.
4504 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4506 * src/modest-defs.h:
4508 * src/modest-account-mgr-helpers.h:
4509 * src/modest-account-mgr-helpers.c:
4510 Store the security account setting in a single conf key instead of using
4511 the options list, so that the list is left for just the to-be-removed camel hack,
4512 and because gconf_client_set_list() is failing for some reason.
4514 * src/modest-account-mgr.c:
4515 (modest_account_mgr_add_server_account):
4516 * src/maemo/modest-account-settings-dialog.c:
4517 (modest_account_settings_dialog_set_account_name),
4518 (save_configuration): Use the renamed functions.
4521 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4523 * src/widgets/Makefile.am:
4524 * src/widgets/modest-limit-retrieve-combo-box.c:
4525 * src/widgets/modest-limit-retrieve-combo-box.h:
4526 * src/widgets/modest-retrieve-combo-box.c:
4527 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4528 the account settings dialog.
4530 * src/modest-defs.h:
4531 * src/modest-account-mgr-helpers.h:
4532 * src/modest-account-mgr-helpers.c:
4533 (modest_server_account_get_option_secure_auth),
4534 (modest_server_account_set_option_secure_auth):
4535 * src/modest-account-mgr.c:
4536 (modest_account_mgr_add_server_account):
4537 Use the existing AUTH_MECH conf key for the secure-auth setting,
4538 instead of putting it in the list options, because this was actually used already.
4540 * src/maemo/modest-account-settings-dialog.c:
4541 (create_page_account_details),
4542 (modest_account_settings_dialog_set_account_name),
4543 (save_configuration):
4544 * src/maemo/modest-account-settings-dialog.h:
4545 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4546 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4548 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4550 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4551 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4552 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4554 * src/modest-defs.h:
4555 * src/maemo/modest-account-settings-dialog.c:
4556 (create_page_incoming), (on_combo_outgoing_security_changed),
4557 (on_combo_incoming_security_changed), (create_page_outgoing),
4558 (modest_account_settings_dialog_set_account_name),
4559 (save_configuration): Load/Save the port number, and change it when the
4560 security combo changes, to suitable defaults.
4562 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4564 * src/modest-account-mgr.c:
4565 (modest_account_mgr_add_server_account): Set the security and secure-auth
4566 options, and add a comment saying that the other camel-specific options should be
4569 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4571 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4573 * src/modest-tny-account-store.c: (account_list_free),
4574 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4575 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4578 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4580 * src/modest-protocol-info.c:
4581 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4582 is required by our UI spec. Maybe something in our implementation will use this eventually.
4583 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4584 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4585 instead of the previous 0 placeholder.
4587 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4588 secure-auth settings.
4589 * src/modest-account-mgr-helpers.h:
4590 * src/modest-account-mgr-helpers.c:
4591 (modest_server_account_data_get_option_secure_auth),
4592 (modest_server_account_set_option_secure_auth),
4593 (modest_server_account_data_get_option_security),
4594 (modest_server_account_set_option_security): Added this API for getting and setting the security
4595 and secure-auth settings.
4597 * src/maemo/modest-account-settings-dialog.h:
4598 * src/maemo/modest-account-settings-dialog.c:
4599 (modest_account_settings_dialog_finalize), (check_data),
4600 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4601 about changing titles.
4602 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4603 (save_configuration): Save the security and secure-auth settings.
4605 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4606 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4608 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4610 * src/modest-defs.h:
4611 * src/modest-account-mgr.c:
4612 (modest_account_mgr_add_server_account):
4613 Added and used defines for the options key and value pair strings,
4614 that are used so far, though they do not seem to correspond to anything in our
4615 UI specs or ModestProtocol enum.
4617 * src/modest-account-mgr-helpers.h:
4618 * src/modest-account-mgr-helpers.c:
4619 (compare_option_strings_for_name),
4620 (modest_server_account_data_get_option_value),
4621 (modest_server_account_data_get_option_bool),
4622 (modest_account_mgr_get_server_account_option):
4623 Added helper functions for parsing the options GSList.
4625 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4627 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4628 display name is based on the supplied account name.
4629 * src/modest-account-mgr.c:
4630 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4631 with an inefficient, but good-enough, implementation.
4633 * src/maemo/easysetup/modest-easysetup-wizard.c:
4634 (create_page_account_details), (on_before_next), (create_account):
4635 Check for existing display names rather than (non-user-visible) account names, and just
4636 create and set a unique account name at the end.
4638 * src/maemo/modest-account-settings-dialog.c:
4639 (modest_account_settings_dialog_init),
4640 (modest_account_settings_dialog_set_account_name),
4641 (create_page_incoming): Show the display name, instead of the account name.
4642 (on_response): Do some (not all) extra checks, as in the UI spec.
4643 (save_configuration): Save the display name if it was changed.
4645 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4647 * po/en_GB.po: Added needed logical ID and translation.
4648 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4649 (init_view): Made the is-default column clicking work.
4651 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4654 * src/maemo/easysetup/Makefile.am:
4655 * src/maemo/easysetup/modest-easysetup-wizard.c:
4656 (modest_easysetup_wizard_dialog_init):
4657 * src/maemo/easysetup/provider-data-test.keyfile:
4658 * src/maemo/easysetup/provider-data.keyfile:
4659 Moved the provider data file to the new modest-providers-data package and used it from there.
4661 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4663 * src/modest-local-folder-info.c:
4664 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4665 N_() was already used on the static strings, but this just marks it for translation without
4666 using the translation.
4668 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4670 * src/maemo/modest-account-settings-dialog.c:
4671 (create_page_incoming),
4672 (modest_account_settings_dialog_set_account_name):
4673 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4674 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4675 I will do this if nobody else gets there first.
4677 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4679 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4680 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4681 save the security stuff.
4683 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4685 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4686 Set the email address and user fullname, which I now see must be
4689 * src/maemo/modest-account-settings-dialog.h:
4690 * src/maemo/modest-account-settings-dialog.c:
4692 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4693 leave-on-server and authentication.
4694 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4697 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4700 * src/maemo/modest-account-settings-dialog.c:
4701 * src/maemo/modest-account-settings-dialog.h:
4702 Most (but not all) of the widgets are now present as specified by the UI spec.
4703 No changes are yet saved, and some details are not properly shown yet.
4705 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4707 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4709 * src/maemo/Makefile.am:
4710 * src/maemo/modest-account-settings-dialog.c:
4711 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4712 an existing account. Doesn't do much yet.
4714 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4715 Open the accounts settings dialog when Edit is clicked.
4717 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4719 * src/maemo/easysetup/Makefile.am:
4720 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4722 * src/maemo/easysetup/modest-easysetup-wizard.c:
4723 (modest_easysetup_wizard_dialog_init):
4724 Try to get the source directory from the build system,
4725 instead of hard-coding "./" into the source code, when opening our local
4726 copies of the configuration files.
4727 But this still fails when opening the wizard from the Accounts window,
4728 maybe because the working directory seems to change at runtime.
4729 So the wizard will fail the second time unless you copy the files into their
4730 proper locations - see the stdout warnings for the paths.
4732 (create_page_account_details),(on_before_next):
4733 Check for existing non-server accounts instead of server accounts,
4734 so the default account name is useful again, and to prevent trying to
4737 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4738 Show the wizard when New is clicked.
4740 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4741 (init_view): Show the column headers, and show the columns that are
4742 specified in the UI specs. However, something in Maemo's GTK+ prevents
4743 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4744 change the default account. This is despite unsetting the special properties.
4746 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4748 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4749 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4750 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4751 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4752 to make that clearer.
4753 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4755 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4757 * src/maemo/modest-account-view-window.c:
4758 (modest_account_view_window_init),
4759 (modest_account_view_window_new):
4760 Use the same buttons as specified in the
4761 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4762 the existing widgets, which never had a chance of working.
4763 Put the ModestAccountView treeview in a scrolled window.
4764 Do not repeat the initialization in both _init() and _new().
4766 * src/widgets/modest-account-view.c: (update_account_view):
4767 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4768 this widget and window shows no accounts.
4770 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4772 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4774 * src/maemo/easysetup/modest-easysetup-wizard.c:
4775 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4776 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4777 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4780 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4781 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4782 accounts exist yet, as in the UI spec.
4784 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4786 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4788 * src/maemo/Makefile.am:
4789 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4790 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4791 New window for editing connection-specific smtp details.
4792 Not fully implemented.
4794 * src/maemo/modest-connection-specific-smtp-window.c:
4795 (modest_connection_specific_smtp_window_finalize) :
4796 unref the tree model.
4797 (on_button_edit): Show the edit window.
4799 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4801 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4804 * src/maemo/Makefile.am:
4805 * src/maemo/modest-connection-specific-smtp-window.c:
4806 * src/maemo/modest-connection-specific-smtp-window.h:
4807 New window for showing the list of connections, for connection-specific
4808 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4809 * src/maemo/easysetup/modest-easysetup-wizard.c:
4810 (create_page_custom_outgoing): Show the new window when the button is clicked.
4812 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4814 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4815 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4816 * src/maemo/modest-msg-edit-window.c:
4817 (modest_msg_edit_window_insert_image):
4818 * src/modest-conf.c: (modest_conf_key_escape):
4819 * src/modest-mail-operation.c:
4820 (modest_mail_operation_send_new_mail):
4821 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4822 (modest_ui_actions_on_new_account):
4823 * src/widgets/modest-attachment-view.c: (update_filename_request):
4824 * src/widgets/modest-mail-header-view.c:
4825 Corrected warnings that were breaking the build, by commenting out unused variables,
4826 and a function, and by including a header.
4828 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4830 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4831 so we can #ifdef around platform-specific code when necessary.
4832 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4833 to allow this to build for the GNOME platform too.
4835 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4837 * src/maemo/easysetup/modest-easysetup-wizard.c:
4838 Added util_increment_name() and used it in create_page_account_details()
4839 to make sure that the default account name is always a new name.
4841 (modest_easysetup_wizard_dialog_init),
4842 (set_default_custom_servernames): Some minor memory management fixes.
4844 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4848 * src/modest-runtime.c: (init_i18n): Restored the translation
4849 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4850 are defined in config.h, and the translations are installed.
4852 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4853 is defined for translation.
4855 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4857 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4859 * src/maemo/easysetup/modest-easysetup-wizard.c:
4860 (modest_easysetup_wizard_dialog_init):
4861 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4862 Use realistic paths (though they should use $prefix generically) to the
4863 mcc_mapping and provider-data.keyfile files which might work when they
4864 are installed by the future version of the operator-wizard package,
4865 and then fallback to paths in our source code, with an explanatory
4868 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4872 * src/maemo/Makefile.am:
4873 * src/maemo/easysetup/: Added files from the previously-exernal
4874 osso-modest-easysetup.
4875 * src/maemo/modest-main-window-ui.h:
4876 * src/modest-ui-actions.c:
4877 * src/modest-ui-actions.h:
4878 Added modest_ui_actions_on_new_account() as a signal handler for the
4879 New Account menu item. It shows the easysetup wizard.
4880 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob