1 2007-07-07 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
4 ckdg_ib_maximum_characters_reached from correct package.
6 * src/modest-ui-actions.c: Show an error message when a folder could
7 not be created. Tinymail does not give us specific error codes about
8 what has gone wrong, so we assume that a folder with that name
9 already exists, though there might be other reasons.
11 2007-07-06 Murray Cumming <murrayc@murrayc.com>
13 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
14 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
15 give a more exact error message that can be partly translated.
17 2007-07-05 Murray Cumming <murrayc@murrayc.com>
19 * src/maemo/modest-address-book.c:
20 (select_email_addrs_for_contact): Specify a default window size for the
21 select-email-address dialog, so that it is probably big enough for the
22 title. This should fix projects.maemo.org bug NB#62277.
24 2007-07-05 Murray Cumming <murrayc@murrayc.com>
26 * src/maemo/easysetup/modest-easysetup-wizard.c:
27 (create_page_complete_easysetup): Use
28 gtk_widget_set_size() request to ensure that the text wraps
31 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
33 * src/maemo/easysetup/modest-easysetup-wizard.c:
34 (on_entry_invalid_character), (create_page_account_details),
35 (create_page_user_details):
36 Use new API of ModestValidatingEntry. But for some reason the banner is
37 not shown. I will have to investigate that further.
39 * src/widgets/modest-validating-entry.c: (on_insert_text),
40 (modest_validating_entry_set_func):
41 * src/widgets/modest-validating-entry.h:
42 Added a new callback function to be able to react to prevented
43 characters whitespaces to e.g show a banner.
45 2007-07-05 Armin Burgmeier <armin@openismus.com>
47 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
48 notification of HildonNumberEditor instead of remembering the port
49 number. Thanks to Johannes for pointing this out.
51 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
53 * src/maemo/easysetup/modest-easysetup-wizard.c:
54 Check if there are any user changes before showing a confirmation
55 dialog (projects.maemo.org NB#60946)
57 2007-07-05 Armin Burgmeier <armin@openismus.com>
59 * src/maemo/modest-account-settings-dialog.c: Remember custom port
60 number at the beginning of the dialog and set the modified flag at the
61 end if the port number has changed. This is necessary because
62 HildonNumberEditor does not support notification when the value has
65 2007-07-05 Murray Cumming <murrayc@murrayc.com>
67 * src/modest-ui-actions.c:
68 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
69 a connection before asking anything else. Correct the check for the destination
70 folder so that it succeeds when online.
71 This fixed projects.maemo.org bug NB#61645.
73 2007-07-05 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
76 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
77 to fix projects.maemo.org bug NB#62439.
79 2007-07-05 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-tny-account.c: (on_connection_status_changed):
82 Really do not use tny_device_force_offline() here. See the previous comment.
84 2007-07-04 Murray Cumming <murrayc@murrayc.com>
86 * src/modest-tny-account.c: (on_connection_status_changed):
87 Do not use tny_device_force_offline() when tinymail says that something
88 went wrong with the connection. It seems to report this unnecessarily.
90 2007-07-04 Murray Cumming <murrayc@murrayc.com>
92 * src/maemo/modest-connection-specific-smtp-window.c:
93 (modest_connection_specific_smtp_window_init):
94 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
95 does not seem to have any effect in osso 1.1 (though it works in
96 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
98 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
100 * src/maemo/modest-connection-specific-smtp-window.c:
101 Fix UI specification problems with projects.meamo.org NB#60479
103 2007-07-04 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
106 clue when this has failed, because the error dialog is not always shown
107 (at least in earlier version).
109 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
110 GError message, because the generic error dialog is not helpful.
112 'This message is not currently available (can't let a new connection go online)'
113 when trying to open an IMAP message.
115 (_modest_ui_actions_open): Offer a connection when some messages would
116 have to be downloaded and we are offline.
118 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
120 * src/widgets/modest-folder-view.c:
121 Don't check for MERGE type anymore as we use the correct type
123 NOTE: For the last two changes you need to update your tinymail copy
124 because of API changes!
126 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
128 * src/modest-tny-local-folders-account.c:
129 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
130 (see projects.maemo.org NB#61580)
132 2007-07-04 Murray Cumming <murrayc@murrayc.com>
134 * src/modest-tny-account.c: (on_connection_status_changed):
135 Commented out the call to modest_platform_connect_and_wait() because this
136 seems to always hang, and I would like to know if this is the only thing
137 that causes a hang when showing the connection dialog.
138 It is not very useful anyway.
140 2007-07-04 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-msg-view-window.c:
143 (modest_msg_view_window_select_next_message):
145 * src/modest-platform.h:
146 * src/maemo/modest-platform.c:
147 Added modest_platform_connect_and_wait(), which calls
148 tny_maemo_conic_device_connect() always in the main thread, by calling it
149 in an idle handler and waiting for the idle handler to run. It should be
150 in the main thread because it uses GTK+ UI code. It just returns TRUE
151 if the device is already online.
153 There is some nasty code to ensure that subsequent calls to
154 modest_platform_connect_and_wait() just wait for the first one to finish,
155 by checking repeatedly in another idle handler. This is necessary,
156 because other threads (or even the main thread, via another idle handler)
157 can call modest_platform_connect_and_wait() while
158 modest_platform_connect_and_wait() is running.
160 (modest_platform_connect_and_wait_if_network_account),
161 (modest_platform_connect_and_wait_if_network_folderstore):
162 Convenience functions that calls modest_platform_connect_and_wait() if
163 the account or folder might want network access.
165 * src/modest-mail-operation.c:
166 (modest_mail_operation_update_account):
167 * src/modest-ui-actions.c: (download_uncached_messages),
168 (modest_ui_actions_on_rename_folder), (delete_folder),
169 (modest_ui_actions_on_main_window_move_to),
170 (modest_ui_actions_on_msg_view_window_move_to):
171 * src/widgets/modest-folder-view.c:
172 (drag_and_drop_from_folder_view):
173 Offer a connection if we are offline.
175 * src/modest-tny-account.c: (on_connection_status_changed):
176 Document this as only handling errors during network operations in progress,
177 and replace the idle code with a simple call to
178 modest_platform_connect_and_wait(), which does this instead.
180 2007-07-03 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account.c:
183 (modest_tny_account_get_special_folder): (util_on_idle),
184 Handle the GError so we can see when tny_folder_store_get_folders()
185 fails, as it currently does while something else is connecting.
187 Added util_run_in_main_thread_and_wait()
188 which uses an idlen handler and mainloop to ensure that the function
189 is called in the main thread.
190 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
191 to make sure that we call attempt the connection in the mainloop only,
192 which might solve some hangs.
194 2007-07-03 Murray Cumming <murrayc@murrayc.com>
196 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
197 be found by their display name. This is never useful.
198 * src/modest-tny-account-store.c: (on_account_removed): Find the account
199 by its ID, instead of trying to use its ID as its display name.
201 * src/modest-tny-account-store.h:
202 * src/modest-tny-account.c:
203 (modest_tny_account_get_special_folder): Add a g_warning() when
204 tny_folder_store_get_folders() returns an empty list for the maildir.
206 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
207 Add a g_warning() when this returns NULL, because that it not allowed
210 2007-07-02 Armin Burgmeier <armin@openismus.com>
212 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
213 note when trying to cancel the wizard. This fixes projects.maemo.org
216 2007-07-02 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account.h:
219 * src/modest-tny-account.c:
220 (modest_tny_account_new_from_server_account),
221 (modest_tny_account_new_from_server_account_name),
222 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
223 because this must now be set before setting the proto. This is usd in
224 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
225 warning in camel_session_get_service() caused by
226 tny_camel_transport_account_prepare().
228 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
231 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
235 (modest_connection_specific_smtp_edit_window_init):
237 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
240 2007-06-29 Murray Cumming <murrayc@murrayc.com>
242 * src/modest-tny-account.c:
243 (modest_tny_account_new_from_server_account):
244 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
245 now uses to request a connection when it needs one, and which it uses
246 to tell us that something is wrong with the connection, so we can force
247 the accounts offline to prevent further problems.
250 * src/modest-init.c: (init_default_settings):
251 * src/modest-mail-operation.c:
252 (modest_mail_operation_update_account):
253 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
254 This should not be necessary anymore. Do not set the conf key that
255 determined this (it was always TRUE and not set anywhere else).
257 * src/modest-ui-actions.h: Remove unused and unimplemented
258 modest_ui_actions_on_online_toggle_toggled().
260 2007-06-29 Murray Cumming <murrayc@murrayc.com
262 * src/maemo/modest-main-window.c: (connect_signals):
263 Don't connect to delete_event twice. Maybe this was harmless.
265 2007-06-29 Murray Cumming <murrayc@murrayc.com
267 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
268 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
269 Debug output to give some more clue when a folder move is not allowed.
271 2007-06-28 Murray Cumming <murrayc@murrayc.com
273 * src/modest-tny-account.c: (on_modest_file_system_info),
274 (modest_tny_account_get_mmc_account_name):
275 Always call the callback, without checking whether the name has changed.
276 * src/widgets/modest-folder-view.c: (strings_are_equal),
277 (on_model_foreach_set_name), (on_get_mmc_account_name),
278 (text_cell_data): Compare the name here, and use the name from
279 the account rather than from the
280 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
281 if the name was changed after the account was added to the model.
282 That's a tinymail bug but not one that I want to fix now.
284 This finally fixes projects.maemo.org bug NB#59301.
286 2007-06-27 Armin Burgmeier <armin@openismus.com>
288 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
291 2007-06-27 Murray Cumming <murrayc@murrayc.com
293 * src/modest-tny-account.h:
294 * src/modest-tny-account.c:
295 Added modest_tny_account_get_mmc_account_name(), to set the memory
296 card name asynchronously for the given account and then notify.
297 (modest_tny_account_new_for_local_folders): Use this new function instead
298 of using hildon_file_system_info_async_new() directly.
300 * src/widgets/modest-folder-view.c: (text_cell_data):
301 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
302 gtk_tree_model_row_changed() when it is available.
304 This should fix projects.maemo.org bug NB#59301.
306 2007-06-27 Murray Cumming <murrayc@murrayc.com
308 * src/modest-mail-operation.c: (update_account_thread),
309 (get_msgs_full_thread): Fix typo failures in the revert
312 2007-06-27 Murray Cumming <murrayc@murrayc.com
314 * src/maemo/modest-maemo-global-settings-dialog.c:
315 (idle_select_default_focus):
316 * src/modest-mail-operation.c: (idle_notify_progress),
317 (idle_notify_progress_once), (set_last_updated_idle),
318 (update_account_thread), (get_msgs_full_thread):
319 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
320 * src/widgets/modest-header-view.c:
321 (idle_notify_headers_count_changed_destroy),
322 (idle_notify_headers_count_changed):
323 Reverted the additions of gdk_threads_enter/leave(), in case this
324 helps with a startup hang on the device.
326 2007-06-26 Armin Burgmeier <armin@openismus.com>
328 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
329 for supported secure authentication methods from server by
330 gtk_dialog_run(), saving CPU time and a potential race condition.
332 2007-06-26 Armin Burgmeier <armin@openismus.com>
334 * src/maemo/modest-maemo-utils.h:
335 * src/maemo/modest-maemo-utils.c: Added a
336 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
337 only error code to tell the calling code when the user canceled the
340 * src/maemo/modest-account-settings-dialog.h:
341 * src/maemo/modest-account-settings-dialog.c:
342 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
343 message if the retrieval of secure authentication methods was canceled
344 by the user. Perform the check before saving anything to configuration
345 to not end up with half-committed configuration changes, do not show
346 a "Saving to configuration failed" note when authentication methods
347 could not be retrieved.
349 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
352 2007-06-26 Murray Cumming <murrayc@murrayc.com>
354 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
355 Only return the first level of folders under accounts, because the
356 osso-global-search UI spec doesn't want the rest.
357 This fixed projects.maemo.org bug NB#61811.
359 2007-06-26 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-tny-account-store.c:
362 * src/modest-tny-account-store.h:
363 Added modest_tny_account_is_memory_card_account().
364 * src/maemo/modest-main-window.c: (create_details_widget):
365 Show the same information items for the memory card as we show for the
366 local-folders, to fix projects.maemo.org bug NB#59307.
368 2007-06-26 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-tny-account-store.c: (get_password):
371 Added some checks for NULL to maybe prevent crashes, though I think
372 it was Philip's last commit that actually prevented the crash here
373 when creating a first new account.
374 But the new account is still not usable (no messages are shown)
375 until a restart of the application.
377 2007-06-26 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/modest-maemo-global-settings-dialog.c:
380 (idle_select_default_focus):
381 * src/modest-mail-operation.c: (idle_notify_progress),
382 (idle_notify_progress_once), (idle_notify_update_account_queue),
383 (set_last_updated_idle), (update_account_thread),
384 (notify_get_msgs_full), (get_msgs_full_destroyer),
385 (get_msgs_full_thread):
386 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
387 * src/widgets/modest-header-view.c:
388 (idle_notify_headers_count_changed_destroy),
389 (idle_notify_headers_count_changed):
390 Use gdk_threads_enter() and gdk_threads_enter_leave() in
391 all idle handlers, because some other thread could be blocking
392 the GDK lock, so that it can do GUI stuff.
394 2007-06-26 Murray Cumming <murrayc@murrayc.com>
396 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
397 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
398 (on_idle_send_receive), (on_idle_open_default_inbox):
399 * src/maemo/modest-msg-edit-window.c:
400 (modest_msg_edit_window_attach_file_noninteractive):
401 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
402 to prevent a hang. I don't quite understand why these are necessary,
403 beause we should already be in the main loop. I guess something outside
404 of the main loop is taking the lock.
406 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
407 we are really using URIs, and use files that are more likely to exist.
409 2007-06-26 Murray Cumming <murrayc@murrayc.com>
411 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
412 necessary because configure.ac now defines different variables.
414 2007-06-26 Murray Cumming <murrayc@murrayc.com>
416 * libmodest-dbus-client/libmodest-dbus-client.c:
417 * libmodest-dbus-client/libmodest-dbus-client.h:
418 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
419 libmodest_dbus_client_compose_mail() is what things actually use.
421 * src/dbus_api/modest-dbus-api.h:
422 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
423 * tests/dbus_api/Makefile.am:
424 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
427 2007-06-26 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-init.c: (modest_init_local_folders):
430 For memory-card (or other non local-folders) maildir accounts,
431 always create an Archive folder, so that there is somewhere to put
432 messages. This should be less confusing, because the user does not need
433 to guess that the need to create a folder.
435 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
437 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
438 Fixed icon size by using (50, 50) which is the same as defined by
441 2007-06-25 Armin Burgmeier <armin@openismus.com>
443 * src/widgets/modest-window-mgr.c:
445 * configure.ac: Correctly recognize hildon-notify presence and fixed
446 the build without it being installed.
448 2007-06-25 Murray Cumming <murrayc@murrayc.com>
450 * libmodest-dbus-client/libmodest-dbus-client.c:
451 (libmodest_dbus_client_search): Fix the build. Sorry.
452 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
453 (reply_forward_cb): Initialize variables to fix the build.
455 * src/modest-tny-account-store.c:
456 (modest_tny_account_store_get_tny_account_by): Fix the account URI
457 comparison (a silly typo) so that email search results can be opened
458 when there are more than one account.
460 2007-06-25 Murray Cumming <murrayc@murrayc.com>
462 * libmodest-dbus-client/libmodest-dbus-client.c:
463 (libmodest_dbus_client_search),
464 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
465 instead of 1 second, because the search gets folders and messages from
466 the server, which can take a long time. When it times out,
467 osso-global-search will report no results.
469 We need to specify whether we should search only cached information
470 (maybe with a user preference), and the osso-email-search-plugin
471 API should really be improved to allow that option, and to allow results
472 to be delivered asynchronously in batches.
474 2007-06-25 Murray Cumming <murrayc@murrayc.com>
476 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
477 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
478 GTK_ICON_SIZE_DIALOG is probably the wrong size.
480 2007-06-25 Murray Cumming <murrayc@murrayc.com>
482 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
483 that is an empty string. D-Bus seems to give us these instead of NULL.
485 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
487 * src/dbus_api/modest-dbus-callbacks.c:
488 * src/maemo/easysetup/modest-easysetup-wizard.h:
489 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
490 * src/maemo/modest-connection-specific-smtp-edit-window.c:
491 (modest_connection_specific_smtp_edit_window_init):
492 * src/maemo/modest-maemo-global-settings-dialog.c:
494 * src/maemo/modest-maemo-utils.c:
495 (modest_maemo_utils_setup_images_filechooser):
496 * src/maemo/modest-main-window.c: (create_details_widget):
497 * src/maemo/modest-msg-edit-window.c:
498 (modest_msg_edit_window_attach_file_noninteractive),
499 (modest_msg_edit_window_color_button_change),
500 (modest_msg_edit_window_set_zoom):
501 * src/modest-mail-operation.c: (update_account_thread):
502 * src/modest-tny-account-store.c:
503 * src/modest-tny-account.c:
504 * src/widgets/modest-global-settings-dialog.c:
505 * src/widgets/modest-window.h:
509 2007-06-25 Murray Cumming <murrayc@murrayc.com>
511 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
512 * src/modest-search.c: (modest_search_folder),
513 (modest_search_all_accounts): Actually search only in the specified folder,
514 doing a simple match on the folder ID.
515 * src/modest-search.h: Added a folder field to the ModestSearch struct,
516 and added some documentation.
518 2007-06-22 Armin Burgmeier <armin@openismus.com>
520 * src/maemo/modest-maemo-utils.h:
521 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
522 modest_maemo_utils_get_supported_secure_authentication_methods.
524 * src/maemo/easysetup/modest-easysetup-wizard.c:
525 * src/maemo/modest-account-settings-dialog.c: Show correct error if
526 one occured, not just "Server does not support secure authentication".
528 2007-06-22 Murray Cumming <murrayc@murrayc.com>
530 * src/modest-tny-account-store.c: (get_password):
531 Restored the call to tny_account_set_user() because Philip seems to have
532 stopped this from crashing (by not using the freed string). It still does
533 not work, but now we can test it.
535 2007-06-22 Murray Cumming <murrayc@murrayc.com>
537 * src/maemo/modest-msg-edit-window.c: (init_window):
538 Comment out use of an uninitialzed GtkScrolledWindow variable,
539 to fix the build and stop a crash. Yet again.
541 2007-06-22 Murray Cumming <murrayc@murrayc.com>
543 * src/modest-tny-account-store.c: (get_password):
544 Remove the call to tny_account_set_user() because this actually crashes.
545 As mentioned in the last commit, it is known to not work anyway.
547 2007-06-22 Murray Cumming <murrayc@murrayc.com>
549 * src/modest-tny-account-store.c: (get_password):
550 Use tny_account_set_username() to tell tinymail that the username might
551 have changed too. But tinymail ignores this: see projects.maemo.org
553 * src/modest-ui-actions.c:
554 (modest_ui_actions_on_password_requested): Remove the useless attempt to
555 reset the connection when changing the username, and improve the comments.
556 Save the changed username to gconf at least, so it is used when Modest is
559 2007-06-21 Murray Cumming <murrayc@murrayc.com>
561 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
562 Do not use a query, so that we get all folders, including for POP and
563 local-folders. They work as search criteria too.
564 This fixes projects.maemo.org bug NB#57740.
566 2007-06-21 Murray Cumming <murrayc@murrayc.com>
568 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
569 Comment out the use of hildon_notification_set_sound() because it is
570 not declared, to fix the build. Warnings are serious, people.
572 2007-06-21 Armin Burgmeier <armin@openismus.com>
574 * src/maemo/modest-maemo-utils.h:
575 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
576 modest_maemo_utils_get_supported_secure_authentication_methods()
577 to query authentication methods for a specific user. This should fix
578 projects.maemo.org bug NB#61369.
580 * src/maemo/easysetup/modest-easysetup-wizard.c:
581 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
584 2007-06-21 Murray Cumming <murrayc@murrayc.com>
586 * libmodest-dbus-client/libmodest-dbus-client.h:
587 * libmodest-dbus-client/libmodest-dbus-client.c:
588 (modest_dbus_message_iter_get_search_hit),
589 (libmodest_dbus_client_search):
590 Reorganised and commented this.
591 Removed modest_search_hit_free() from the public API because it
594 Added libmodest_dbus_client_get_folders() and
595 modest_folder_result_list_free().
597 * src/dbus_api/modest-dbus-api.h:
598 * src/dbus_api/modest-dbus-callbacks.c:
599 (modest_dbus_req_filter): Commented. Moved most code to
600 on_dbus_method_search() and added on_dbus_method_get_folders().
602 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
603 of the extra D-Bus handler.
605 * tests/dbus_api/Makefile.am:
606 * tests/dbus_api/test_get_folders.c: New test for
607 libmodest_dbus_client_get_folders(). This seems to return an empty list
608 at the moment. That could be the same error that causes the message list
609 to be empty sometimes.
610 This should help with projects.maemo.org bug NB#57740.
612 2007-06-21 Armin Burgmeier <armin@openismus.com>
614 * src/modest-mail-operation.c: Do not call
615 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
616 notify the operation's end after having set the status to CANCELED for
617 the operation queue to listen on. This fixes a deadlock when there
618 were mail operations in the queue during its finalization.
620 * src/modest-singletons.c: Reordered uninitialization of the account
621 manager to happen after the mail operation queue was uninitialized
622 because the mail operation's in the queue might still try to access
623 the account manager (see modest_mail_operation_notify_end()). This
624 fixes a potential crash when terminating the application.
626 2007-06-21 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-search.c:
629 (search_mime_part_and_child_parts): Moved some code here so we
630 can search recursively in child folders.
631 (modest_search_folder): Search in the message as a mime part, instead
632 of just its child mime parts.
633 (read_chunk), (search_mime_part_ogs):
634 Check how many bytes were read, to prevent an endless loop.
635 Searching in message bodies now works. This finishes the fix for
636 projects.maemo.org bug NB#61007.
638 2007-06-20 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
641 Add a g_warning when the item is not a folder.
643 * src/modest-ui-dimming-rules.c:
644 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
645 when selected item is not a folder (for instance, an account), because
646 the UI spec only talks about folders.
647 I am not sure what the UI spec wants, so this might not totally fix
648 projects.maemo.org bug NB#60794.
650 2007-06-20 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
653 (load_from_file): Sort the list. The unsorted list would be more noticeable
654 in non-English locales.
656 * src/maemo/modest-msg-edit-window.c:
657 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
658 warning and fix the build.
660 * src/maemo/modest-progress-bar-widget.c:
661 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
662 avoid a g_warning, and probably to avoid a crash.
664 2007-06-20 Murray Cumming <murrayc@murrayc.com>
666 * src/modest-search.c: (modest_search_folder): Check for a GError
667 when calling tny_folder_get_headers(), to show that this is not the cause
670 2007-06-20 Murray Cumming <murrayc@murrayc.com>
672 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
673 Actually set the body query instead of the subject query.
675 * src/modest-search.c: (search_mime_part_ogs),
676 (search_mime_part_strcmp): Remove extra space from the text/* regex,
677 which would probably cause it to fail if we got this far.
679 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
680 to simplify the code.
681 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
682 be causing search-in-body to fail.
684 2007-06-20 Murray Cumming <murrayc@murrayc.com>
686 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
688 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
689 Better debug message when the folder cannot be found.
690 This should help with fixing projects.maemo.org bug #61287.
691 * src/modest-search.c: (add_hit): Do not leak the furl string.
693 2007-06-20 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-ui-actions.c:
696 (modest_ui_actions_on_folder_selection_changed):
697 Do not special-case TNY_MERGE_FOLDER here, because
698 modest_tny_folder_get_account() already does that. This fixes
699 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
700 shown when the Outbox was selected).
702 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
704 * libmodest-dbus-client/libmodest-dbus-client.c:
705 (_dbus_iter_get_string_or_null): Initialize the string variable in
706 case this helps with Dirk's crash.
708 2007-06-19 Murray Cumming <murrayc@murrayc.com>
710 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
711 though it is not implemented yet (this function is maybe not even used),
712 to avoid breaking ABI in future.
713 * libmodest-dbus-client/libmodest-dbus-client.c:
714 (get_attachments_string): Moved some code into this generic function.
715 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
716 sends email. It is maybe not used.
717 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
718 (on_send_mail): Use attachments.
720 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
721 * src/maemo/modest-msg-edit-window.c:
722 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
723 a filename before using it, to fix projects.maemo.org bug NB#58233.
725 2007-06-19 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
728 Initialize the continue_download variable to fix the build, and probably
729 to fix randome behaviour.
731 2007-06-18 Armin Burgmeier <armin@openismus.com>
733 * src/modest-tny-send-queue.h:
734 * src/modest-tny-send-queue.c: Keep track of the status of messages in
735 the queue so we can later show it in the UI. Replaced
736 modest_tny_send_queue_msg_is_being_sent() by
737 modest_tny_send_queue_get_msg_status().
739 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
741 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
742 gpointer. This probably was not harmful, but just to be sure.
744 2007-06-18 Murray Cumming <murrayc@murrayc.com>
746 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
747 Fix the build, but leave the function broken on Bora, because
748 hildon_uri_action_get_service() does not exist.
749 osso_uri_action_get_service() does not exist either, it seems.
751 2007-06-18 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account.c:
754 (modest_tny_account_new_from_server_account):
755 Uncommented the url debug output again, because it is useful for
756 debugging, as I said in the comment.
758 2007-06-18 Murray Cumming <murrayc@murrayc.com>
760 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
762 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
763 for Mameo Bora, to fix the build.
765 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
768 Fixed build with hildon < 0.99
770 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
771 Check if the selected account is busy instead of checking all accounts
773 * src/modest-account-mgr-priv.h:
774 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
775 (modest_account_mgr_init), (compare_account_name),
776 (modest_account_mgr_set_account_busy),
777 (modest_account_mgr_account_is_busy):
778 * src/modest-account-mgr.h:
779 Added busy information to the account manager. It possible to
780 set an account to busy or not busy now.
782 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
783 (modest_mail_operation_update_account),
784 (modest_mail_operation_notify_end):
785 Set the account to busy/not busy depending on the operation state.
787 * src/widgets/modest-account-view.c:
788 (modest_account_view_finalize), (get_last_updated_string),
789 (update_account_view), (on_account_busy_changed), (init_view):
790 Show string "Refreshing..." if the account is currently busy.
792 All this fixes projects.maemo.org bug NB#59711
794 2007-06-14 Armin Burgmeier <armin@openismus.com>
796 * src/widgets/modest-attachments-view.h:
797 * src/widgets/modest-attachments-view.c: Added
798 modest_attachments_view_has_attachments() and fixed coordinate
799 transformation in get_att_view_at_coords(). This fixes attachment
802 * src/widgets/modest-msg-view.c: Make use of
803 modest_attachments_view_has_attachments() to decide whether to show
804 attachments in the header.
806 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
809 (on_change), (on_combo_security_changed),
810 (modest_connection_specific_smtp_edit_window_init),
811 (modest_connection_specific_smtp_edit_window_set_connection),
812 (modest_connection_specific_smtp_edit_window_is_dirty):
813 * src/maemo/modest-connection-specific-smtp-edit-window.h:
814 * src/maemo/modest-connection-specific-smtp-window.c:
817 Show an comfirmation dialog for the smpt-edit-window if there are
818 unsaved changes and the user hits cancel.
819 (projects.maemo.org bug NB#60479)
821 2007-06-14 Armin Burgmeier <armin@openismus.com>
823 * src/maemo/easysetup/modest-easysetup-wizard.c:
824 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
825 address" info in banner instead of node, and select all the text as
826 per UI spec. This fixes projects.maemo.org bug NB#60550.
828 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
830 reviewed by: <delete if not using a buddy>
832 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
833 * src/modest-ui-actions.c: (folder_refreshed_cb):
835 2007-06-14 Murray Cumming <murrayc@murrayc.com>
837 * src/widgets/modest-folder-view.c: (filter_row):
838 Explictly filter out the per-account outbox accounts. I don't know why
839 these only sometimes show up, but now they should never show up in the UI.
840 This should fix projects.maemo.org bug NB#60160.
842 2007-06-14 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
845 when the toolbar does not exist yet.
846 * src/modest-widget-memory.c: (save_settings_header_view):
847 Added g_warnings() to help us to discover when we are trying to set
848 an empty columns list in gconf.
850 2007-06-14 Murray Cumming <murrayc@murrayc.com>
854 Added modest_init_get_default_header_view_column_ids().
856 * src/modest-widget-memory.c: (restore_settings_header_view):
857 Use the new function to get defaults, if the gconf key is empty,
858 instead of not creating any columns. This seems to fix the
859 empty right-hand pane problems.
861 * src/widgets/modest-header-view.h: Improved documentation.
863 2007-06-13 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
866 Revert the use of the display name as the account name, because this
867 is generally wrong and would break the code that follows.
869 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
871 * src/maemo/easysetup/modest-easysetup-wizard.c:
872 (check_for_supported_auth_methods), (on_before_next),
875 More correct fix for projects.maemo.org bug NB# 58991
876 Do not longer accept AUTH_PASSWORD as secure method and choose
877 correct method when creating the account.
879 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
881 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
882 Fixed projects.maemo.org bug NB# 58991
884 2007-06-13 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-init.c: (modest_init_init_core),
887 (modest_init_local_folders): Fixed compilation errors.
889 2007-06-13 Murray Cumming <murrayc@murrayc.com>
891 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
892 Remove unnecessary lib/include, though it is good in principle when needed.
894 * src/modest-init.c: (modest_init_one_local_folder),
895 (modest_init_local_folders):
896 * src/modest-init.h: Initialize the .modest library for memory cards,
897 instead of just doing nothing for them. This should allow us to create
898 folders there, fixing projects.maemo.org bug NB#59297.
900 2007-06-13 Murray Cumming <murrayc@murrayc.com>
902 * libmodest-dbus-client/libmodest-dbus-client.c:
903 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
904 (libmodest_dbus_client_compose_mail),
905 (libmodest_dbus_client_open_message),
906 (libmodest_dbus_client_send_and_receive),
907 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
909 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
910 (on_idle_open_message), (modest_dbus_req_handler),
911 (search_result_to_message), (modest_dbus_req_filter):
912 * src/modest-search.c: (add_hit), (modest_search_folder),
913 (modest_search_all_accounts): Improved debug messages.
915 * tests/dbus_api/test_open_message.c: (main): Improved comments.
917 * src/modest-tny-account-store.c:
918 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
921 2007-06-13 Murray Cumming <murrayc@murrayc.com>
924 2007-06-12 Murray Cumming <murrayc@murrayc.com>
926 * src/modest-tny-account-store.c: (get_server_accounts):
927 Call modest_tny_local_folders_account_add_merged_outbox_folders()
928 even when there are no accounts, so that the Outbox folder is always
929 visible. This fixes projects.maemo.org bug NB#60158.
931 2007-06-12 Murray Cumming <murrayc@murrayc.com>
933 * src/maemo/modest-main-window.c: (create_details_widget):
934 Use the mcen_va_never logical ID.
936 2007-06-12 Murray Cumming <murrayc@murrayc.com>
938 * src/dbus_api/modest-dbus-api.h:
939 * src/dbus_api/modest-dbus-callbacks.c:
940 (on_idle_open_default_inbox), (on_open_default_inbox),
941 (modest_dbus_req_handler):
942 Added a new OpenDefaultInbox method.
944 * libmodest-dbus-client/libmodest-dbus-client.h:
945 * libmodest-dbus-client/libmodest-dbus-client.c:
946 Added libmodest_dbus_client_open_default_inbox() to call the new
947 dbus method. This should be useful to projects.maemo.org bug NB#57214,
948 though it should maybe be used by a new osso-email-interface function.
950 * tests/dbus_api/Makefile.am:
951 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
954 2007-06-12 Murray Cumming <murrayc@murrayc.com>
956 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
957 NULL, so that the signals get all the keys. This should not actually
958 change any behaviour because we currently update everything when anything
961 2007-06-12 Murray Cumming <murrayc@murrayc.com>
963 * src/widgets/modest-folder-view.c: (text_cell_data),
964 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
965 (find_inbox_iter): If tinymail tells us that the folder is
966 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
967 This causes the inbox to be selected at startup, fixing part of
968 projects.maemo.org bug NB#56305.
970 * src/modest-ui-dimming-rules.c:
971 (modest_ui_dimming_rules_on_tools_smtp_servers):
972 * src/modest-ui-dimming-rules.h: Added a callback function to dim
973 the SMTP servers menu item.
974 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
975 that the SMTP Servers menu item is dimmed when there are no accounts,
976 as a future version of the UI spec will require. This fixes
977 projects.maemo.org bug NB#56305.
979 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
981 * src/maemo/modest-maemo-utils.c:
982 (modest_maemo_utils_get_supported_secure_authentication_methods):
983 Added label to dialog instead of unreadable title
985 * src/maemo/modest-main-window.c: (sync_accounts_cb),
986 (modest_main_window_new):
987 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
990 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
991 * src/modest-account-mgr.h:
992 Added method to avoid code duplication
994 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
995 (modest_ui_actions_on_send_receive):
996 Use modest_account_mgr_has_accounts
998 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1000 * src/maemo/easysetup/modest-presets.c:
1001 (modest_presets_get_info_server_security): Do not report secure auth
1003 * src/modest-protocol-info.c: Use the defines for the gconf key names
1004 for secure authentication. This was not working because we were writing
1005 Password and reading password, and the check was case sensitive.
1006 With this, gmail now works for receiving and sending when created via
1009 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/easysetup/modest-presets.c:
1012 (modest_presets_get_info_server_security): Correct the key name for
1013 SecureSmtp, because it seems to be case-sensitive.
1014 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1015 Do not try to get the 0th notebook page if there are 0 pages, to
1016 avoid a g_warning().
1018 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1020 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1021 Prevent use of the new notification feature for now, because it currently
1022 shows one dialog for each new email, which is annoying.
1024 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1026 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1027 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1028 when no country was selected, so that we show the global ones.
1029 * src/maemo/easysetup/modest-presets.c:
1030 (modest_presets_get_providers): Return only the global providers, not
1031 all providers when mmc=0 was requested.
1033 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1036 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1037 provider ID in the combo.
1039 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1040 Do not show the page numbers, because it would be confusing when we add
1041 the 2 extra pages for the custom setup, when the user chooses the "Other"
1042 provider. This fixes projects.maemo.org bug NB#59028
1044 * src/modest-init.c: (modest_init_init_core),
1045 (modest_init_local_folders):
1046 * src/modest-init.h:
1047 * src/modest-tny-account.c:
1048 (modest_tny_account_new_for_local_folders): Do not create default folders
1049 for the memory card. This should fix projects.maemo.org bug NB#59328.
1051 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1054 Free the changed_conf_keys string items. They are already freed in the
1055 idle handler if that runs first.
1057 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1059 * src/modest-ui-actions.c:
1060 (modest_ui_actions_on_password_requested): Check that the server name
1061 is not NULL, because I just saw a password dialog with (null) as the
1064 * src/modest-tny-folder.[h|c]: Added
1065 modest_tny_folder_is_memory_card_folder().
1066 * src/modest-ui-dimming-rules.c:
1067 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1068 menu item for memory cards, as per the UI spec (section 7.4). This should
1069 fix projects.maemo.org bug NB#59297.
1071 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1073 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1074 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1075 is another problem with the code, see Murray's comment at line 772)
1077 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1079 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1080 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1081 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1082 (load_from_file), (easysetup_country_combo_box_init),
1083 (easysetup_country_combo_box_get_active_country_ids),
1084 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1085 instead of just one ID, to avoid duplicate country names in the UI.
1087 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1088 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1089 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1090 a single ID, avoiding duplicate providers.
1091 * src/maemo/easysetup/modest-easysetup-wizard.c:
1092 (on_combo_account_country): Adapt to use a list.
1094 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1096 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1097 keys changed in the last X seconds.
1099 * src/modest-account-mgr.h:
1100 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1101 (on_key_change), (modest_account_mgr_class_init),
1102 (modest_account_mgr_init), (modest_account_mgr_finalize):
1103 As the keys are changed, save them in a GSList* and signal that GSList*
1104 further every X seconds, to batch changes, to allow us to do just one
1105 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1106 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1108 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1109 changed signal signature.
1111 * src/modest-conf.c: (modest_conf_set_list),
1112 (modest_conf_on_change): Reenable notification.
1114 (modest_conf_maemo_fake_on_change): Comment out the hack that
1115 notified immediately instead of asynchronously.
1117 * src/widgets/modest-account-view.h:
1118 * src/widgets/modest-account-view.c:
1119 (update_account_view): Select the previously-selected account ID,
1120 if possible. This fixes projects.maemo.org bug NB#56933.
1122 (on_account_changed), (on_account_removed),
1123 (modest_account_view_select_account):
1125 Remove the block/unblock functions
1126 because they were not useful.
1128 * src/maemo/modest-account-view-window.c:
1129 (on_delete_button_clicked), (on_edit_button_clicked),
1130 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1132 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1135 Improve the error dialog to show Incorrect Account Settings, which seems
1136 clearer, and say that the internal error message (to be removed from the
1137 dialog later) is often misleading.
1138 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1140 * src/modest-tny-account.c:
1141 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1142 URL because this is so useful for debugging on the device.
1144 * src/widgets/modest-serversecurity-combo-box.c:
1145 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1147 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-mail-operation.c:
1150 (modest_mail_operation_send_new_mail):
1151 Added a comment about a nasty but apparently harmless message. Details
1152 added to the wiki g_warnings() page.
1154 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1156 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1157 (modest_tny_send_queue_class_init):
1158 Do not use the priv struct because it is empty, to avoid g_warnings
1159 about a non-existant priv struct.
1161 * src/modest-tny-account-store.c:
1162 (modest_tny_account_store_get_server_account),
1163 (modest_tny_account_store_get_transport_account_for_open_connection
1164 ): Do not try to get transport server accounts for local folders,
1165 because they don't have any. This avoids a g_warning().
1167 * src/maemo/modest-main-window.c:
1168 (modest_main_window_notify_send_receive_initied),
1169 (on_configuration_key_changed):
1170 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1171 * src/modest-defs.h:
1172 * src/modest-mail-operation.c:
1173 (modest_mail_operation_update_account):
1174 * src/modest-tny-account-store.h:
1175 * src/modest-tny-account.c:
1176 (modest_tny_account_get_special_folder),
1177 (modest_tny_account_new_for_local_folders),
1178 (modest_tny_account_new_for_per_account_local_outbox_folder):
1179 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1180 * src/modest-tny-local-folders-account.c:
1181 (add_account_folders_to_merged_folder):
1182 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1183 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1184 (modest_ui_actions_on_send):
1185 * src/widgets/modest-folder-view.c: (update_model):
1186 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1187 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1188 modest_tny_account_store_get_tny_account_by_account() to
1189 modest_tny_account_store_get_server_account() to make the code clearer.
1191 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1193 * src/dbus_api/modest-dbus-api.h:
1194 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1195 * src/maemo/modest-msg-edit-window.c:
1196 (modest_msg_edit_window_attach_file_noninteractive):
1197 added g_warning in case the file to be attached does not exist
1198 * tests/dbus_api/test_compose_mail.c: (main):
1199 removed obsolete comment, added generic files as test case
1201 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1203 * src/modest-tny-account-store.c: (get_server_accounts):
1204 Create the local folders account only once, not once for each outbox, and
1205 not only when there are some outboxes.
1207 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1209 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1210 code that is causing a crash at startup. Sergio says that he is fixing this.
1212 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1214 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1215 * src/maemo/modest-account-settings-dialog.c:
1216 (create_page_outgoing),
1217 (modest_account_settings_dialog_set_account_name),
1218 (save_configuration):
1219 - Fixed handling of the "Use secure authentication" toggle to comply with
1220 the ui specification. See also projects.maemo.org bug NB#58400
1222 - Restore the Secure connection setting combo correctly when loading
1225 * src/maemo/modest-maemo-utils.c:
1226 (on_camel_account_get_supported_secure_authentication),
1227 (modest_maemo_utils_get_supported_secure_authentication_methods):
1228 Fixed a crasher if operation is canceled
1230 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1231 (modest_protocol_info_auth_is_secure):
1232 * src/modest-protocol-info.h:
1234 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1235 the sense of the "Use secure authentication" toggle.
1237 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-tny-account-store.h:
1240 * src/modest-tny-account-store.c:
1241 Added modest_tny_account_store_get_local_folders_account().
1243 * src/modest-tny-folder.h:
1244 * src/modest-tny-folder.c:
1245 (modest_tny_folder_get_account):
1246 Added this replacement for tny_folder_get_account() which returns
1247 the local-folders account for TnyMergeFolders, to avoid the
1248 warning about the unimplemented get_account_func() vfunc().
1250 (modest_tny_folder_get_rules),
1251 * src/modest-ui-actions.c:
1252 (modest_ui_actions_on_folder_selection_changed):
1253 * src/modest-mail-operation.c:
1254 (modest_mail_operation_remove_folder),
1255 (modest_mail_operation_xfer_folder),
1256 (modest_mail_operation_rename_folder),
1257 (modest_mail_operation_get_msg),
1258 (modest_mail_operation_get_msgs_full),
1259 (modest_mail_operation_remove_msg),
1260 (modest_mail_operation_xfer_msgs),
1261 (modest_mail_operation_refresh_folder):
1262 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1264 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1266 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1267 (modest_server_account_set_security):
1268 * src/modest-defs.h: Add comments explaining that our
1269 UI spec means TLS when it says Normal, so these do not look like errors.
1271 * src/modest-tny-account.c:
1272 (modest_tny_account_new_from_server_account): Use the new tinymail
1273 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1274 for TLS. This should fix projects.maemo.org bug NB#58460.
1276 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-easysetup-wizard.c:
1279 (create_account): Correct the position of the gconf sanity check warning.
1280 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1281 of using the g_idle_add() hack, because this does not seem to be necessary
1282 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1283 caused by something other than maemo's gconf.
1284 This fixes projects.maemo.org bug #59022.
1286 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1288 * src/modest-account-mgr-helpers.c:
1289 (modest_account_mgr_get_default_account): Do not check that the account
1290 exists if there is no default account (NULL), to fix a runtime warning.
1292 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1294 * src/widgets/modest-folder-view.c: (update_model):
1295 Do not unref the treemodel before we have finished with it.
1296 This prevents a valgrind warning and an occasional crash at startup.
1298 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1300 * libmodest-dbus-client/libmodest-dbus-client.h:
1301 added libmodest_dbus_client_compose_mail()
1302 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1304 added functions needed for SendAsMail() functionality
1305 * src/maemo/modest-msg-edit-window.c:
1306 (modest_msg_edit_window_attach_file_noninteractive):
1307 non interactively attaching files to message edit window
1308 * src/widgets/modest-msg-edit-window.h:
1309 * tests/dbus_api/Makefile.am:
1310 added test_compose_mail.c
1311 * tests/dbus_api/test_compose_mail.c: (main):
1313 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1315 * src/modest-account-view.c:
1316 Fixed bug projects.maemo.org bug NB#59307
1318 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1320 * src/maemo/easysetup/modest-easysetup-wizard.c:
1321 (get_serverport_incoming), (on_before_next), (create_account):
1322 * src/maemo/modest-account-settings-dialog.c:
1323 (modest_account_settings_dialog_set_account_name):
1324 * src/maemo/modest-maemo-utils.c:
1325 (on_camel_account_get_supported_secure_authentication_status),
1326 (on_camel_account_get_supported_secure_authentication),
1327 (on_secure_auth_cancel),
1328 (modest_maemo_utils_get_supported_secure_authentication_methods):
1330 Implemented security authentication for settings and easysetup.
1332 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/modest-main-window.c: (create_details_widget):
1335 Show the total size for memory card accounts too, instead of showing
1336 the name again. Fixes bug projects.maemo.org bug NB#59307.
1338 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-tny-simple-folder-store.c:
1342 * src/modest-tny-simple-folder-store.h: Removed.
1344 * src/modest-tny-local-folders-account.h
1345 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1346 for the local-folders maildir, with an extra TnyMergedFolder containing
1347 the folders of the per-account outbox store accounts.
1348 * src/modest-tny-account-store.c: (get_server_accounts):
1349 Add the outboxes to the special local folders account after creating it.
1351 * src/modest-tny-account.c:
1352 (modest_tny_account_new_for_local_folders): Create the derived
1353 account when creating the main local-folders account.
1355 * src/maemo/modest-main-window.c: (create_details_widget),
1356 (modest_main_window_set_contents_style):
1357 Adapted to the use of the derived account instead of the folder store.
1359 * src/modest-ui-actions.c:
1360 (modest_ui_actions_on_folder_selection_changed):
1361 * src/modest-ui-dimming-rules.c:
1362 (modest_ui_dimming_rules_on_new_folder):
1363 * src/widgets/modest-folder-view.c: (text_cell_data),
1364 (icon_cell_data), (filter_row), (update_model),
1365 (get_cmp_rows_type_pos):
1368 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1369 Do not get the priv struct, because no priv struct has been set,
1370 to avoid a runtime warning.
1372 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1373 #ifelse with #else, to fix a warning, to fix the build.
1376 2007-06-05 Christian Kellner <ckellner@openismus.com>
1378 * libmodest-dbus-client/libmodest-dbus-client.c:
1379 Fix small typo in doc (why do you always see them
1380 AFTER committing stuff?)
1383 2007-06-05 Christian Kellner <ckellner@openismus.com>
1385 * libmodest-dbus-client/libmodest-dbus-client.c:
1386 (libmodest_dbus_client_search):
1387 Initialize hit list with NULL. Also set folder list
1388 to "" if NULL was supplied.
1391 2007-06-03 Christian Kellner <ckellner@openismus.com>
1393 * libmodest-dbus-client/libmodest-dbus-client.c:
1394 (modest_search_hit_list_free):
1395 Make it save to call it with NULL.
1397 * src/dbus_api/modest-dbus-callbacks.c:
1398 * src/modest-search.c:
1399 Return full ModestSearchHits as the search result list not TnyHeader
1400 since can't be around withouth the correspoding TnyFolder.
1402 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1404 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1405 Added currently commented code to check for secure auth
1407 * src/maemo/modest-account-settings-dialog.c: (on_response),
1408 (save_configuration), (show_ok):
1409 Fixed projects.maemo.org bugs NB #59248 and #59251
1411 * src/maemo/modest-maemo-utils.c:
1412 (on_camel_account_get_supported_secure_authentication_status),
1413 (on_camel_account_get_supported_secure_authentication),
1414 (modest_maemo_utils_get_supported_secure_authentication_methods):
1415 * src/maemo/modest-maemo-utils.h:
1416 Moved get_supported_secure_authentication() method here to be able
1417 to use it from easysetup wizard.
1419 * src/modest-pair.c: (on_pair_compare_as_string):
1420 Should compare string with first part of pair and not
1421 strcmp pairs which will crash.
1423 * src/modest-protocol-info.c:
1424 (modest_protocol_info_protocol_is_store):
1425 * src/modest-protocol-info.h:
1426 Added modest_protocol_info_get_auth_protocol_name()
1428 2007-06-03 Armin Burgmeier <armin@openismus.com>
1430 * src/modest-mail-operation.c:
1431 (modest_mail_operation_get_msgs_full): Set priv->account also when
1432 only retrieving a single message. This avoids a crash when canceling
1435 (modest_mail_operation_notify_end): Do not explicitely remove the
1436 operation from the queue but only emit the progress_changed signal.
1437 The queue itself listens to that signal to remove the operation when
1438 it is finished. This reduces coupling and removes a potential deadlock
1439 when modest_mail_operation_notify_end() is called from the queue
1440 itself. If that is a problem performance-wise, I would suggest to
1441 implement a status-changed signal or something.
1443 * src/modest-mail-operation-queue.c: Make sure to never call a
1444 function from another file while the queue is locked. This (hopefully)
1445 fixes another deadlock when exiting the application while retrieving
1448 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1450 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1451 Fixed build if libogs is not available
1453 2007-06-03 Christian Kellner <ckellner@openismus.com>
1455 * libmodest-dbus-client/libmodest-dbus-client.h:
1456 * libmodest-dbus-client/libmodest-dbus-client.c:
1457 (libmodest_dbus_client_delete_message):
1458 Implement deletion of messages (Client side).
1460 (modest_search_hit_free),
1461 (modest_search_hit_list_free):
1462 Utility functions to free the result hits.
1464 * src/dbus_api/modest-dbus-api.h:
1465 * src/dbus_api/modest-dbus-callbacks.c:
1466 (on_delete_message),
1467 (modest_dbus_req_handler):
1468 Implement deletion of messages (Server side).
1470 * tests/dbus_api/test_search.c: (main):
1473 * tests/dbus_api/Makefile.am:
1474 * tests/dbus_api/test_delete_message:
1475 Add little test for the message deletion logic
1477 2007-06-03 Armin Burgmeier <armin@openismus.com>
1479 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1480 when the operation queue was not empty. projects.maemo.org bug
1483 2007-06-03 Armin Burgmeier <armin@openismus.com>
1485 * src/widgets/modest-account-view.c
1486 (on_account_default_toggled): Toggle default account column
1487 explicitely instead of waiting for gconf notification (which is
1488 currently ignored). This should fix projects.maemo.org bug NB#56910
1489 for now. It should probably be removed when gconf notifications are
1492 2007-06-03 Christian Kellner <ckellner@openismus.com>
1494 * libmodest-dbus-client/libmodest-dbus-client.c:
1495 Removed debugging spew.
1497 * src/dbus_api/modest-dbus-callbacks.c:
1498 Added debugging info.
1500 * src/modest-search.c:
1501 (modest_search_all_accounts):
1502 Use tny_account_store_get_accounts () on the account store
1503 to get all accounts which is the way to get all accounts.
1505 * tests/dbus_api/test_search.c: (main):
1506 Make it possible to supply the search term on the command line.
1508 2007-06-03 Christian Kellner <ckellner@openismus.com>
1510 * libmodest-dbus-client/libmodest-dbus-client.c:
1511 * libmodest-dbus-client/libmodest-dbus-client.h:
1512 Implement searching for mesages over raw dbus. (Client side)
1514 * src/dbus_api/Makefile.am:
1515 * src/dbus_api/modest-dbus-api.h:
1516 * src/dbus_api/modest-dbus-callbacks.c:
1517 * src/dbus_api/modest-dbus-callbacks.h:
1518 Search framework (Server side). Also implement on_idle_open_message().
1520 * src/maemo/modest-platform.c: (modest_platform_init):
1521 Prepare for raw dbus/osso rpc interaction.
1523 * src/modest-search.h:
1524 Changed minsize from unspecific guint to guint32.
1526 * src/modest-search.c:
1528 Added strange hack which magically made tnymail work.
1530 (modest_search_folder),
1531 (modest_search_account),
1532 (modest_search_all_accounts):
1533 Implement helper functions to search all accounts, specific account
1536 * tests/dbus_api/Makefile.am:
1537 * tests/dbus_api/test_open_message.c:
1538 Read url to open from commandline.
1540 * tests/dbus_api/test_search.c:
1541 Implement small test for dbus search stuff
1543 2007-06-02 Armin Burgmeier <armin@openismus.com>
1545 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1546 include account type and account title. This fixes projects.maemo.org
1549 * src/maemo/modest-account-view-window.c: Set a title for the window.
1551 2007-06-02 Armin Burgmeier <armin@openismus.com>
1553 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1554 incoming and outgoing server name based on email address and server
1555 types as long as the names have not been edited manually. This fixes
1556 projects.maemo.org bug NB#58671.
1558 2007-06-02 Armin Burgmeier <armin@openismus.com>
1560 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1561 server type cannot be changed in future to the incoming details page
1562 when creating an account. This fixes projects.maemo.org bug NB#59029.
1564 2007-06-02 Armin Burgmeier <armin@openismus.com>
1566 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1567 and assigned max width chars so that they wrap instead of being
1568 truncated. Fixes projects.maemo.org bug NB#56126.
1570 2007-06-02 Armin Burgmeier <armin@openismus.com>
1572 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1573 introductory note to the connection specific smtp servers dialog, as
1574 section 8.12 of the email UI specification requires. This fixes
1575 projects.maemo.org bug NB#59212.
1577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1579 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1580 Check for running mail operations, and offer to cancel them, as per the UI
1581 spec. This fixes projects.maemo.org bug NB#59041 .
1582 However, I suspect that tinymail may still use the network connection
1583 in ways that we cannot detect or cancel. But it should at least adapt to
1584 changes fairly well.
1586 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-tny-account-store.c: (recreate_all_accounts),
1589 (get_cached_accounts), (get_server_accounts): Do more sensible
1590 ref-counting of the temporarily-cached outbox accounts list. This seems
1591 to fix a crash when entering the password when the password was wrong.
1593 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1595 * src/gnome/modest-main-window.c: (connect_signals):
1596 * src/modest-tny-account-store.c: (get_password),
1597 (modest_tny_account_store_alert): Added comments and clues and
1598 commented-out code about how we currently fail to deal with connection
1599 errors and wrong passwords, and how we should.
1601 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1603 * src/widgets/modest-retrieve-combo-box.c:
1604 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1605 This fixes projects.maemo.org bug NB#58472 .
1607 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1609 * src/maemo/easysetup/modest-easysetup-wizard.c:
1610 (create_page_complete_easysetup):
1611 (create_page_complete_custom): Correct the last commit,
1612 putting the correct sentences in the correct pages.
1614 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/easysetup/modest-easysetup-wizard.c:
1617 (create_page_complete_custom): Show the second sentence of text
1618 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1621 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1623 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1624 Set the leave-on-server conf key by default. This fixes
1625 projects.maemo.org bug NB#59258 .
1627 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/modest-account-view-window.c:
1630 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1631 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1634 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/easysetup/modest-easysetup-wizard.c:
1637 (create_caption_new_with_asterisk):
1638 * src/maemo/modest-account-settings-dialog.c:
1639 (create_caption_new_with_asterisk):
1640 Uncomment the code to add the asterisk, because they are no longer in the
1641 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1642 (update_incoming_server_title): Add an asterisk here too.
1644 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1646 * src/maemo/modest-maemo-global-settings-dialog.c:
1647 (current_connection): Check that we are even connected before trying to
1648 get the current connection name, to prevent a warning.
1650 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1651 Change the comments because tny_maemo_conic_device_connect() is now meant to
1653 * src/modest-mail-operation.c:
1654 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1655 make sure we have a connection and fail if we can't connect.
1657 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1659 * src/maemo/modest-main-window.c:
1660 (on_account_store_connecting_finished): Do not try to get the
1661 connection ID if we are not really connected. I am surprised that
1662 this signal handler is called when we are not connected.
1664 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-error.h:
1667 * src/modest-ui-actions.c:
1668 (modest_ui_actions_get_msgs_full_error_handler):
1669 Renamed an enum, added comments, added an enum
1670 for retrieve-limit errors.
1672 * src/modest-mail-operation.c: (foreach_add_item),
1673 (internal_folder_observer_update), (update_account_thread),
1674 (modest_mail_operation_get_msgs_full):
1675 (modest_mail_operation_update_account),
1676 Added comments about how this works, and some code that should
1677 (but does not) check the retrieve-limit. See the TODO comment.
1679 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1682 Initialize help_id to fix the build. Warnings are good.
1684 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1686 * src/widgets/modest-hbox-cell-renderer.c:
1687 (modest_hbox_cell_renderer_append):
1688 * src/widgets/modest-vbox-cell-renderer.c:
1689 (modest_vbox_cell_renderer_append):
1690 Fix the last commit by doing an extra ref.
1692 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1694 * src/widgets/modest-hbox-cell-renderer.c:
1695 (modest_hbox_cell_renderer_append):
1696 * src/widgets/modest-vbox-cell-renderer.c:
1697 (modest_vbox_cell_renderer_append):
1698 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1699 to fix the build with Maemo Bora.
1700 However, there seems to be a remaining crash, probably due to reference
1703 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1705 * src/modest-tny-account.c:
1706 (modest_tny_account_new_for_local_folders):
1707 Use hildon_file_system_info_async_new() to get a better name for
1708 the memory card account, setting it as the account name.
1709 The timing seems to work, but this is probably
1710 not the best place to do this. See the TODO comment.
1711 * src/maemo/modest-main-window.c: (create_details_widget):
1712 * src/widgets/modest-folder-view.c: (text_cell_data):
1713 Use the tny account name instead of hardcoding a name.
1715 2007-05-30 Christian Kellner <ckellner@openismus.com>
1717 * src/modest-search.c: (modest_search):
1718 Correctly set part_search_func even if we have already parsed
1719 the query and thus a valid OgsTextSearcher object.
1721 2007-05-30 Christian Kellner <ckellner@openismus.com>
1724 Search and check for libogs.
1727 Incooparte the ogs build env.
1729 * src/modest-mime-part-search-stream.c:
1730 * src/modest-mime-part-search-stream.h:
1731 Removed since we do the real searching now in modest-search.c.
1733 * src/modest-search.c:
1734 * src/modest-search.h:
1735 Implement support for ogs. We use that if available and requested
1736 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1737 should now handle the corner case when the search term is spread
1738 across multiple reads.
1739 Also the logic in modest_search () was corrected to search all
1740 requested fields until one is found.
1742 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1744 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1746 * src/modest-init.h:
1747 * src/modest-init.c: Made modest_init_local_folders() take a
1748 path and be public so we can iniitialize maildir folders on
1751 * src/modest-local-folder-info.h:
1752 * src/modest-local-folder-info.c:
1753 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1755 * src/modest-tny-account.c:
1756 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1757 still means the standard local-folders path on the local volume.
1759 * src/modest-tny-account-store.c:
1760 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1761 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1762 all accounts when that happens.
1763 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1764 this too, so it shows up in the treeview.
1766 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/modest-maemo-global-settings-dialog.c:
1769 (current_connection):
1770 * src/widgets/modest-global-settings-dialog.c:
1771 (current_connection_default):
1772 Use the enum values instead of 0, 1 and -1,
1773 to make the code clearer.
1775 * src/modest-account-mgr-helpers.c:
1776 (modest_account_mgr_get_connection_specific_smtp): Make this code
1779 * src/modest-runtime.h:
1780 * src/modest-runtime.c:
1781 Added modest_runtime_remove_all_send_queues().
1782 * src/maemo/modest-main-window.c:
1783 (on_account_store_connecting_finished): Recreate the send queues,
1784 using the appropriate transport accounts for this new connection.
1785 Some futher adapting might be needed if the old send queues are not
1786 automatically stopped at this point.
1788 * src/modest-tny-account-store.c: (get_server_accounts):
1789 Create the connection-specific transport accounts, so that they can
1790 be found later by their ID.
1792 * src/modest-tny-account.h:
1793 * src/modest-tny-account.c:
1794 Added modest_tny_account_new_from_server_account_name().
1795 modest_tny_account_new_from_server_account(): Do not create the
1796 send queues here, because they will be
1797 recreated anyway when the connection changes for the first time.
1799 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-local-folder-info.h:
1802 * src/modest-local-folder-info.c:
1803 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1804 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1805 tbox_folder): Take a modest account name instead of a server TnyAccount,
1806 so we can have per-modest-account rather than per-transport-account
1808 We must make sure that we change or recreate the exisitng send queues
1809 when the connection changes for connection-specific transport accounts.
1811 * src/modest-tny-account-store.c:
1812 (create_per_account_local_outbox_folders): Create outboxed per modest
1813 account, not per transport account.
1815 * src/modest-tny-account.h:
1816 * src/modest-tny-account.c:
1817 (modest_tny_account_get_special_folder): For outboxes, get the
1818 parent modest account name. The account is ignored for other folders.
1819 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1820 modest account name rather than a server TnyAccount.
1822 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-tny-account.c:
1825 (modest_tny_account_new_from_server_account):
1826 Call modest_runtime_get_send_queue() immediately after creating transport
1827 accounts, so that they start trying to send email from the outbox as soon
1828 as possible at startup. This is probably what we want.
1830 * src/modest-mail-operation.c: (update_account_thread):
1831 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1832 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1833 * src/modest-tny-send-queue.h:
1834 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1835 (modest_ui_actions_on_send):
1836 Added comments about how sending works, though it needs some more work.
1838 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-tny-account.c:
1841 (modest_tny_account_get_special_folder): Add TODO because this fails when
1842 the network is busy.
1843 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1844 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1845 Do not try to show this window when there is no active account. The UI
1846 specs does not tell us what to do in this case.
1848 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/Makefile.am:
1853 * src/widgets/Makefile.am: Some dist fixes.
1855 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1857 * src/maemo/modest-connection-specific-smtp-window.c:
1858 (on_button_edit): Make the code clearer, to prevent a double free.
1860 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1862 * src/maemo/modest-account-settings-dialog.c:
1863 (modest_account_settings_dialog_set_account_name),
1864 Check the connection-specific smtp servers checkbox if there are any.
1866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1867 (modest_connection_specific_smtp_edit_window_init):
1868 Start with a suitable port number.
1870 * src/modest-account-mgr-helpers.h:
1871 * src/modest-account-mgr-helpers.c: Added
1872 modest_account_mgr_get_has_connection_specific_smtp().
1874 (modest_account_mgr_set_connection_specific_smtp),
1875 (modest_account_mgr_remove_connection_specific_smtp),
1876 (modest_account_mgr_get_has_connection_specific_smtp),
1877 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1878 connection-specific smtp server accounts in the account, rather than
1879 the server account conf dir.
1881 This fixes bug projects.maemo.org bug NB#58263 .
1883 * src/modest-tny-account-store.c:
1884 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1885 if there are no server accounts yet, to prevent an infinite loop when there
1886 are no accounts. Document that one must be called before the other.
1888 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-account-mgr-helpers.c:
1891 (modest_account_mgr_get_default_account): Make sure that at least
1892 one account is always the default, if there are any enabled accounts.
1893 This is just a sanity check that shouldn't be necessary.
1895 * src/modest-account-mgr-priv.c:
1896 (_modest_account_mgr_account_from_key): Unescape the conf key to
1897 get the real account name. For instance, this is an issue if a space
1898 was in the account name, which can happen because the account name
1899 is generated from the display name.
1900 (_modest_account_mgr_get_account_keyname): Always escape the
1902 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1903 Unescape the conf keys to get the real account names.
1905 For instance, previously the is-default radio button in the accounts
1906 list was not checked for any accounts at first. This fixes that,
1907 and might fix several similar bugs.
1909 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1911 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1912 Removed some debug printfs.
1914 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1916 Modest on-disk outbox directories are now here, for instance:
1917 $HOME/.modest/outboxes/<account-id-1>/outbox
1918 $HOME/.modest/outboxes/<account-id-2>/outbox
1920 $HOME/.modest/local-folders/outbox
1921 so we can have a separate outbox for each account.
1922 But they are shown as one outbox in the GtkTreeView, by using a
1923 TnyMergeFolder in a ModestTnySimpleFolderStore.
1926 * src/modest-tny-simple-folder-store.c:
1927 * src/modest-tny-simple-folder-store.h:
1928 Added ModestTnySimpleFolderStore, used to contain folders from
1929 other folder stores, such as other accounts.
1931 * src/modest-tny-outbox-account.h:
1932 * src/modest-tny-outbox-account.c:
1933 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1934 used for the per-account local outbox folders.
1936 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1937 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1938 only use this (internally) now for the non-outbox local folders.
1940 * src/modest-init.h:
1941 * src/modest-init.c: Added modest_init_one_local_folder(), for
1942 setting up the directory structure for each local folder.
1944 * src/modest-local-folder-info.c:
1945 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1946 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1948 * src/modest-local-folder-info.h:
1949 * src/modest-tny-account-store.c: (on_account_removed),
1950 (on_account_changed), (create_per_account_local_outbox_folders),
1951 (get_server_accounts), (modest_tny_account_store_get_accounts),
1952 (modest_tny_account_store_get_tny_account_by_account),
1953 (modest_tny_folder_store_is_virtual_local_folders):
1955 * src/modest-tny-account.h:
1956 * src/modest-tny-account.c:
1957 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1958 to create an on-disk per-account local outbox folder for each
1960 (create_per_account_local_outbox_folders): Create a local outbox folder
1961 for each transport account.
1962 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1963 for all local folders.
1965 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1966 instead of using g_object_get/set() directly. It is clearer.
1968 (modest_tny_folder_store_get_message_count),
1969 (modest_tny_folder_store_get_local_size
1970 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1971 because we now use these with non-acount folder stores.
1973 (modest_tny_account_get_special_folder),
1974 (modest_tny_account_new_from_server_account),
1975 (modest_tny_account_new_from_account):
1976 (recurse_folders): Adjust to the new outbox system.
1978 * src/modest-tny-folder.h:
1979 * src/modest-tny-folder.c:
1980 (modest_tny_folder_is_local_folder),
1981 (modest_tny_folder_get_local_folder_type),
1982 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1984 * src/widgets/modest-main-window.h:
1985 * src/maemo/modest-main-window.c: (create_details_widget),
1986 (modest_main_window_set_contents_style): Show details for any folder store,
1989 (modest_tny_folder_get_rules):
1990 Remove the const. C does not support constness enough for this.
1992 * src/modest-ui-actions.c:
1993 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1994 make all outboxes appear as one, in the usual local-folders tree node.
1996 (set_active_account_from_tny_account),
1997 (modest_ui_actions_on_folder_selection_changed):
1998 * src/widgets/modest-folder-view.c: (text_cell_data),
1999 (icon_cell_data), (filter_row),
2000 (add_account_folders_to_merged_folder),
2001 (add_account_folders_to_simple_folder_store), (),
2002 (get_cmp_rows_type_pos), (cmp_rows),
2003 (modest_folder_view_set_account_id_of_visible_server_account):
2004 Adjust to the new outbox system, using generic folder stores and folders
2005 in the GtkTreeModel.
2007 2007-05-23 Christian Kellner <ckellner@openismus.com>
2009 * src/modest-mail-operation.c:
2010 (modest_mail_operation_update_account):
2011 Use info->max_size instead of unintialized local var [small
2012 build fix]. (Added TODO to review that change since I don't
2015 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2017 * libmodest-dbus-client/libmodest-dbus-client.c:
2018 (libmodest_dbus_client_compose_mail): function added
2019 * src/dbus_api/modest-dbus-api.h:
2020 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2021 (on_compose_mail): Implementation of the SendAsMail functionality
2023 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2025 * src/modest-account-mgr.c:
2026 (modest_account_mgr_add_server_account): Set the secure-connection
2027 conf key for transport accounts as well as store accounts. I don't know
2028 why the if was there. For instance, this makes sure that we use SSL
2029 for the gmail preset from the easysetup wizard.
2031 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2033 * src/gnome/modest-main-window.c:
2034 (on_account_store_connecting_finished), (connect_signals):
2035 * src/maemo/modest-main-window.c:
2036 (on_account_store_connecting_finished), (connect_signals),
2037 (modest_main_window_new):
2038 Handle TnyAccountStore::connecting-finished instead of
2039 TnyDevice::connection-changed, because we cannot actually perform
2040 operations on accounts until TnyAccountStore has itself responded to
2041 the TnyDevice::connection-changed signal. This prevents a GError from
2043 Do not try to update at startup, because we (at least on scratchbox)
2044 already do an update at startup when the device goes online.
2045 This prevents a GError from tinymail.
2046 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2047 Added TODO about stopping simultaneous operations.
2049 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2051 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2052 * src/modest-mail-operation-queue.c:
2053 (modest_mail_operation_queue_remove):
2054 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2055 about where they happened.
2057 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-ui-actions.c:
2060 (modest_ui_actions_on_password_requested): Make sure that the remember
2061 output parameter is always TRUE.
2063 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2066 Show a OK/Cancel dialog if the error is a question, though we still do not
2067 know anything more about what we are asking the user.
2068 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2069 Fix an uninitialized variable (helper). This is a logic error, however.
2071 2007-05-21 Christian Kellner <ckellner@openismus.com>
2073 * src/modest-search.h:
2074 Correct bit shifting in the ModestSearchFlags enum.
2076 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-tny-account.c:
2079 (modest_tny_account_new_from_server_account): Do not use the lsub and
2080 check-all hard-coded IMAP options when using POP.
2082 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2084 * src/modest-tny-account.c:
2085 (modest_tny_account_new_from_server_account):
2086 Use NULL for the secure-auth method for POP when Password auth has been
2087 specified by the user, as we already do for IMAP. "auth=Login" causes
2088 an error from camel or the server.
2090 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/modest-account-settings-dialog.c:
2093 (create_page_account_details),
2094 (modest_account_settings_dialog_set_account_name):
2095 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2096 for the leave-on-server checkbox, rathr than just the checkbox, when
2097 the protocol is not POP.
2099 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2101 * src/widgets/modest-account-view.c:
2102 * src/widgets/modest-account-view.h:
2103 Added modest_account_view_select_account() which will be useful later
2104 to asynchronously re-select the edited account.
2106 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2108 * src/maemo/modest-account-settings-dialog.c:
2109 (modest_account_settings_dialog_set_account_name):
2110 Automatically choose the port numbers based on the secure authentication
2111 methods, if they have not been chosen before.
2112 This fixes projects.maemo.org bug NB#56273 .
2114 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-main-window-ui.h:
2117 * src/modest-ui-actions.c:
2118 * src/modest-ui-actions.h:
2119 Connect the Tools/SMTP Servers menu item to
2120 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2121 SMTP servers dialog, as in the UI specification and saves changes when it
2122 is closed. This fixed projects.maemo.org bug NB#56305 .
2124 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/modest-connection-specific-smtp-window.c:
2127 (modest_connection_specific_smtp_window_init):
2128 Use gtk_window_set_default_size() to make this window big enough, so
2129 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2131 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2133 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2134 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2135 (modest_connection_specific_smtp_edit_window_init),
2136 Do not try to connect to a combobox signal before the combobox exists.
2137 This fixes the cras in projects.maemo.org bug NB#56288 .
2138 (modest_connection_specific_smtp_edit_window_get_settings):
2139 Remove the server_account_name parameter which was being checked for NULL
2140 though it was not used.
2142 * src/maemo/modest-connection-specific-smtp-window.c:
2143 (modest_connection_specific_smtp_window_fill_with_connections),
2144 (on_button_edit), (modest_connection_specific_smtp_window_init):
2145 Correct the number of treemodel columns to prevent a warning.
2146 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2147 libconic does not work.
2149 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2151 * src/modest-tny-account.c:
2152 (modest_tny_account_new_from_server_account):
2153 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2154 SMTP when "None" was chosen by the user. However, with my SMTP server that
2155 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2158 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2160 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2161 to explain the memory management issue with the ID in the ModestPair.
2163 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2164 (add_sending_page), (modest_account_assistant_finalize):
2165 * src/gnome/modest-gnome-global-settings-dialog.c:
2166 (create_updating_page), (create_composing_page):
2167 * src/gnome/modest-msg-edit-window.c: (get_transports),
2168 (init_window), (modest_msg_edit_window_finalize),
2169 (modest_msg_edit_window_get_msg_data):
2170 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2171 * src/gnome/modest-transport-widget.c:
2172 (modest_transport_widget_finalize), (smtp_configuration):
2173 * src/maemo/modest-maemo-global-settings-dialog.c:
2174 (create_updating_page), (create_composing_page):
2175 * src/maemo/modest-msg-edit-window.c: (get_transports),
2176 (init_window), (modest_msg_edit_window_finalize),
2177 (modest_msg_edit_window_get_msg_data),
2178 (modest_msg_edit_window_free_msg_data):
2179 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2180 (modest_store_widget_finalize):
2181 * src/maemo/modest-transport-widget.c:
2182 (modest_transport_widget_finalize), (smtp_configuration):
2183 * src/modest-main.c: (send_mail):
2184 * src/widgets/modest-combo-box.h:
2185 * src/widgets/modest-global-settings-dialog-priv.h:
2186 * src/widgets/modest-global-settings-dialog.c:
2187 (modest_global_settings_dialog_finalize):
2188 * src/widgets/modest-msg-edit-window.h:
2189 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2190 as long as the combo box, to prevent use of freed memory for the ID.
2192 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2194 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2195 get_accounts(), to make this clearer. Do not check for the enabled gconf
2196 key, because we do not use this for server accounts (at least, not yet).
2197 This allows us to send email again.
2199 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/modest-platform.c:
2202 (on_modest_conf_update_interval_changed), (modest_platform_init):
2203 Only respond to this particular key change. All these strcmp()s cannot be
2206 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/modest-maemo-global-settings-dialog.c:
2209 (current_connection): Prevent a crash in scratchbox when
2210 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2211 * src/maemo/modest-platform.c:
2212 (on_modest_conf_update_interval_changed), (modest_platform_init):
2213 Get the update interval from gconf and reset it when the gconf key changes.
2215 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2217 * src/modest-protocol-info.c:
2218 * src/modest-protocol-info.h: Adde enum-specific get functions,
2219 instead of using a ModestProtocolType enum parameter.
2221 * src/gnome/modest-account-assistant.c:
2222 * src/gnome/modest-store-widget.c:
2223 * src/gnome/modest-store-widget.h:
2224 * src/gnome/modest-transport-widget.c:
2225 * src/gnome/modest-transport-widget.h:
2226 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2227 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2228 * src/maemo/easysetup/modest-easysetup-wizard.c:
2229 * src/maemo/modest-account-settings-dialog.c:
2230 * src/maemo/modest-account-settings-dialog.h:
2231 * src/maemo/modest-store-widget.c:
2232 * src/maemo/modest-store-widget.h:
2233 * src/maemo/modest-transport-widget.c:
2234 * src/maemo/modest-transport-widget.h:
2235 * src/modest-account-mgr-helpers.c:
2236 * src/modest-account-mgr-helpers.h:
2237 * src/modest-account-mgr.c:
2238 * src/modest-account-mgr.h:
2239 * src/modest-tny-account.c:
2240 * src/modest-tny-folder.c:
2241 * src/widgets/modest-account-view.c:
2242 * src/widgets/modest-retrieve-combo-box.c:
2243 * src/widgets/modest-retrieve-combo-box.h:
2244 * src/widgets/modest-secureauth-combo-box.c:
2245 * src/widgets/modest-serversecurity-combo-box.c:
2246 * src/widgets/modest-serversecurity-combo-box.h:
2247 * tests/check_account-mgr.c:
2248 Use the specific functions, and use the re-renamed enum values for GNOME too.
2250 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2252 * src/modest-pair.h:
2253 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2254 so we can get the second based on the first.
2256 * src/maemo/modest-account-settings-dialog.h:
2257 * src/maemo/modest-account-settings-dialog.c:
2258 Added get_supported_secure_authentication_methods(), though it is mostly
2259 commented-out for now until the necessary API is committed to tinymail.
2260 (modest_account_settings_dialog_set_account_name),
2261 (save_configuration): Request the supported authentication methods from the
2262 server, so we can choose a working method.
2264 * src/modest-tny-account-store.h:
2265 * src/modest-tny-account-store.c:
2266 (modest_tny_account_store_get_session): Rename from
2267 tny_account_store_get_session().
2269 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-protocol-info.h: Split the ModestProtocol enum
2272 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2273 There was no need to have these unrelated values in one enum.
2275 * src/: many files: Adapted to changed enum. This makes the code a bit
2276 clearer, and the compiler could catch some errors.
2278 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2281 Show the detailed internal camel error message when an error happens
2282 during the configuration, so that our testers can give us more clues.
2283 For instance, in projects.maemo.org bug NB#56910 .
2285 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-tny-account.c:
2288 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2289 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2291 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2293 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2294 * src/maemo/modest-account-settings-dialog.c:
2295 (modest_account_settings_dialog_set_account_name),
2296 (save_configuration): For the incoming secure authentication checkbox,
2297 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2298 the UI specification. PLAIN does not seem to be supported for most IMAP
2299 servers anyway, and I am not sure what it would mean.
2300 However, we probably need to discover which of the secure-authentication
2301 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2302 * src/modest-account-mgr-helpers.c:
2303 (modest_account_mgr_get_server_account_data):
2305 * src/modest-tny-account.c:
2306 (modest_tny_account_new_from_server_account):
2307 Use tny_account_set_mech() to set secure-authentication methods,
2308 with some special-casing for IMAP, based on my observations of how
2311 * src/modest-account-mgr-helpers.h:
2312 * src/modest-account-mgr.c:
2313 * src/modest-defs.h: Comment that the URI is only used for local folders.
2315 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2317 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2318 parameter const, just to be neat.
2319 * src/modest-text-utils.c: (modest_text_utils_inline):
2320 End g_strconcat() with NULL, as its documentation says. This is almost
2321 certainly the cause of my crash at startup on the device. Interestingly,
2322 valgrind doesn't tell us about these errors.
2324 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2326 * scripts/build-packages: Added more precise comments about how to use
2327 this script, though I still get this error:
2328 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2329 error building tinymail
2331 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2333 * src/maemo/modest-main-window.c: (on_account_update):
2334 Very slight cleanup, hoping to make it simpler to discover what causes
2335 a crash here sometimes.
2337 * src/modest-tny-account.c:
2338 (modest_tny_account_new_from_server_account): Set the port. Added
2339 comments about the options and a TODO comment because I need to find out
2340 how to specify the secure authentication method.
2342 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2344 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2345 changed CFlags paths form modest to libmodest
2347 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2349 * src/modest-account-mgr-helpers.c:
2350 (modest_account_mgr_get_server_account_data),
2351 (modest_account_mgr_free_server_account_data):
2352 * src/modest-account-mgr-helpers.h:
2353 * src/modest-account-mgr.c:
2354 (modest_account_mgr_add_server_account):
2355 * src/modest-defs.h:
2356 * src/modest-tny-account.c:
2357 (modest_tny_account_new_from_server_account):
2358 Determine the options for tny_camel_account_add_option() here,
2359 based on the settings, rather than storing them directly in gconf.
2361 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2363 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2364 Show a more friendly error dialog now that we expect (from the tinymail
2365 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2367 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-main-window.c: (on_account_update): Check that
2370 account_name is not NULL, to prevent a crash at startup that I am
2371 seeing on the N800. I do wonder why it is NULL.
2373 * src/maemo/easysetup/modest-easysetup-wizard.c:
2374 (create_page_user_details):
2375 * src/maemo/modest-account-settings-dialog.c:
2376 (create_page_user_details), (create_page_outgoing):
2377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2378 (modest_connection_specific_smtp_edit_window_init):
2379 * src/modest-ui-actions.c:
2380 (modest_ui_actions_on_password_requested):
2381 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2382 might do something useful with the on-screen keyboard.
2384 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/modest-main-window.c: (on_account_update):
2387 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2388 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2390 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-tny-account-store.c: (on_account_changed):
2393 Correct the signature of this signal handler.
2395 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2397 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2398 Show a HildonNote instead of a GtkDialog for Maemo.
2400 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2402 * src/widgets/modest-account-view.h:
2403 * src/widgets/modest-account-view.c: (on_account_changed),
2404 (on_account_removed). Added a boolean flag, set/unset by
2405 modest_account_view_block_conf_updates(),
2406 modest_account_view_unblock_conf_updates() to prevent unnecessary
2407 updates, but this is not very useful because the gconf notifications are
2408 so delays (maybe only on Maemo Bora).
2409 So auto-updating is turned off, and these functions do an explicit
2410 update when necessary.
2411 However, something else is still doing too much work when adding/removing
2412 accounts, probably in another part of the application.
2414 * src/maemo/modest-account-view-window.c:
2415 (on_delete_button_clicked), (on_edit_button_clicked),
2416 (on_new_button_clicked): Use the new functions.
2418 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2420 * src/modest-account-mgr-helpers.c:
2421 (modest_account_mgr_set_first_account_as_default):
2422 Sort the list of names alphabetically-by-title, so we choose the first one
2424 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2425 alphabetically by the title.
2427 This fixes projects.maemo.org bug NB#56418 .
2429 * src/modest-account-mgr-priv.c:
2430 (_modest_account_mgr_account_from_key):
2431 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2432 avoid a valgrind error, and possible random behaviour.
2434 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2436 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2437 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2438 tinymail documentation to say that this can be expected.
2439 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2440 pretty, and should not happen, but I would prefer to know when it does.
2442 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2444 * configure.ac: When using the older hildon version, probably on Bora,
2445 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2447 * src/widgets/modest-attachment-view.c:
2448 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2451 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2453 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2454 Implemented the prototype. Can be tested with
2455 tests/dbus_api/test_open_message:
2457 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2459 * src/modest-tny-account-store.c:
2460 (modest_tny_account_store_instance_init), (get_password):
2461 * src/modest-ui-actions.c:
2462 (modest_ui_actions_on_password_requested):
2463 Do not store the password in gconf, because this function is called
2464 for non-remembered passwords. Actually use the cached (in the hash map)
2465 password instead of releasing it.
2466 The password will now not be remembered if it is asked via the protected
2467 password dialog, as per the UI spec.
2469 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2471 * src/modest-defs.h:
2472 * src/modest-account-mgr-helpers.h:
2473 * src/modest-account-mgr-helpers.c:
2474 Added modest_server_account_get_username_has_succeeded(),
2475 modest_server_account_set_username_has_succeeded().
2476 (modest_server_account_set_username),
2477 Reset the has-succeeded flag if the username changes.
2479 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2480 * src/maemo/modest-connection-specific-smtp-window.c:
2481 (modest_connection_specific_smtp_window_save_server_accounts):
2482 Use modest_server_account_set_username() instead of using
2483 modest_conf_set_string() directly, so that the has-succeeded flag is always
2486 * src/modest-ui-actions.c:
2487 (modest_ui_actions_on_password_requested): Dim the username entry if
2488 the username has ever worked, as per the UI spec.
2490 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2492 * src/modest-tny-account-store.c: (get_password):
2493 * src/modest-ui-actions.c:
2494 (modest_ui_actions_on_password_requested):
2495 Allow the username to be changed too, though there is more work to
2496 be done on exactly how this behaves.
2498 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-account-mgr-helpers.h:
2501 * src/modest-account-mgr-helpers.c:
2502 Added modest_account_mgr_get_display_name(),
2503 modest_server_account_get_username(),
2504 modest_server_account_set_username(),
2505 modest_server_account_set_password(),
2506 modest_server_account_get_hostname() functions so we do not need to
2507 use the conf API directly.
2509 * src/maemo/modest-main-window.c: (connect_signals):
2510 Actually connect ot the ModestAccountStore::request-password signal,
2511 so that we show the dialog when the password is requested by Tinymail,
2512 for isntance if it is empty.
2514 * src/modest-marshal.list:
2515 * src/modest-tny-account-store.c:
2516 (modest_tny_account_store_class_init), (get_password),
2517 (modest_tny_account_store_alert):
2518 * src/modest-tny-account-store.h:
2519 * src/modest-ui-actions.h:
2520 * src/modest-ui-actions.c:
2521 (modest_ui_actions_on_password_requested):
2522 Change the signal parameters, so it is obvious that we are providing
2523 the non human-readable server name, and receiving both the username
2524 and password, though changing of the username is not yet implemented.
2525 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2526 for the GNOME version.
2528 This should fix the projects.maemo.org bug NB#56209, though it does not
2529 work on Bora, because the gconf_client_get() for the password fails
2530 immediately after we save it with gconf_client_set().
2532 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2535 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2536 caused an undefined symbol error:
2537 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2539 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2541 * src/modest-tny-account-store.c:
2542 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2543 using a GError instead of a string message, so we can translate it in
2546 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/modest-address-book.c:
2549 (modest_address_book_check_names):
2550 * src/maemo/modest-msg-view-window.c:
2551 (modest_msg_view_window_clipboard_owner_change):
2552 * src/modest-init.c: (modest_init_init_ui):
2553 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2554 (update_folders_cb), (modest_mail_operation_update_account):
2555 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2556 (modest_ui_actions_on_msg_attachment_clicked),
2557 (modest_ui_actions_on_msg_recpt_activated):
2558 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2559 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2560 (modest_msg_view_search_next):
2561 * src/widgets/modest-recpt-editor.c:
2562 (modest_recpt_editor_on_button_release_event),
2563 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2564 g_message(). At this point we should only be seeing interesting errors on
2565 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2567 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2569 (modest_wizard_dialog_force_title_update):
2570 * src/maemo/easysetup/modest-wizard-dialog.h:
2571 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2572 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2573 can update the title when appropriate. Otherwise the title is wrong if the
2574 pages are added after adding the notebook to the dialog.
2575 This must be a problem in HildonWizardDialog too.
2576 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2578 * src/maemo/easysetup/modest-easysetup-wizard.c:
2579 (create_subsequent_customsetup_pages),
2580 (create_subsequent_easysetup_pages):
2581 Call modest_wizard_dialog_force_title_update() so that the title is
2582 correct even with GTK+ < 2.10.
2583 This fixes projects.maemo.org bug NB#56145 .
2585 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/modest-platform.c:
2588 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2589 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2592 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2594 * src/widgets/modest-window.h:
2595 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2596 and modest_window_save_state(), which invokes it.
2598 * src/widgets/modest-window-mgr.h:
2599 * src/widgets/modest-window-mgr.c:
2600 Added modest_window_mgr_save_state_for_all_windows(), which calls
2601 the save_state vfunc on all registered windows, if implemented.
2603 * src/gnome/modest-msg-edit-window.c:
2604 * src/gnome/modest-msg-view-window.c:
2605 * src/maemo/modest-msg-edit-window.c:
2606 * src/maemo/modest-msg-view-window.c:
2607 * src/maemo/modest-main-window.c:
2608 Specify the existing save_settings functions as implementations of
2609 ModestWindow::save_state_func().
2611 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2612 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2613 enabling hibernation, for instance.
2615 We may need to do the same thing for restoring settings.
2618 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2620 * src/widgets/modest-window-mgr.c:
2621 * src/widgets/modest-window-mgr.h:
2622 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2623 modest_window_mgr_get_hibernation_is_prevented().
2625 * src/maemo/modest-main-window.c:
2626 (on_hildon_program_is_topmost_notify): Prevent hibernation
2627 (possible when the application goes to the background in the WM),
2628 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2630 * src/maemo/easysetup/modest-easysetup-wizard.c:
2631 (modest_easysetup_wizard_dialog_init):
2632 * src/maemo/modest-account-settings-dialog.c:
2633 (modest_account_settings_dialog_init):
2634 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2635 (modest_connection_specific_smtp_edit_window_init):
2636 * src/maemo/modest-connection-specific-smtp-window.c:
2637 (modest_connection_specific_smtp_window_init):
2638 * src/maemo/modest-signature-editor-dialog.c:
2639 (modest_signature_editor_dialog_init):
2640 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2641 prevent hibernation while any of these account settings dialogs are open.
2643 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2645 * src/maemo/Makefile.am:
2646 * src/maemo/modest-osso-state-saving.c:
2647 * src/maemo/modest-osso-state-saving.h: Added
2648 modest_osso_load_state() and modest_osso_save_state() though they do
2649 nothing now. They should iterate through all the open windows and load/save
2651 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2652 save state when closing.
2654 * src/maemo/modest-main-window.c:
2655 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2656 Add a notification handler for the HildonProgram::is-topmost property,
2657 so we can allow hibernation when the application goes into the background.
2658 But we still need to detect when the accounts setup windows are open so
2659 we can stop hibernation when they are open.
2660 To do this, I also added the main window the HildonProgram. This might have
2661 other side-effects/benefits, and should maybe be done for other windows.
2663 * src/maemo/modest-osso-autosave-callbacks.h:
2664 * src/maemo/modest-osso-autosave-callbacks.c:
2665 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2666 though it does not do anything yet, and we might never need this to do
2667 anything. For instance, we already save drafts.
2669 * src/maemo/modest-platform.c: (modest_platform_init):
2670 Specify the libosso auto-save callback.
2672 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2674 * src/maemo/modest-platform.c:
2675 (modest_platform_set_update_interval):
2676 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2677 aparently stays valid between application instances, so we can use this
2678 to remove and reset it later. According to a maemo-developers email from
2681 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2683 * configure.ac: Depend on libalarm for Maemo.
2685 * src/dbus_api/modest-dbus-api.h:
2686 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2687 (on_send_receive), (modest_dbus_req_handler):
2688 Handle a SEND_RECEIVE D-Bus method.
2690 * libmodest-dbus-client/libmodest-dbus-client.c:
2691 (libmodest_dbus_client_send_and_receive):
2692 * libmodest-dbus-client/libmodest-dbus-client.h:
2693 Add C convenience functions for calling the new D-Bus method.
2695 * src/modest-platform.h:
2696 * src/gnome/modest-platform.c:
2697 * src/maemo/modest-platform.c:
2698 Added modest_platform_set_update_interval(), which uses the
2699 alarmd API on Maemo.
2700 (modest_platform_init),
2701 Call modest_platform_set_update_interval(), using a hard-coded
2702 interval for now (until the global settings dialog is implemented),
2703 though I am not sure that this makes sense yet.
2705 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2707 * src/dbus_api/modest-dbus-callbacks.c:
2708 (modest_osso_cb_hw_state_handler):
2709 * src/dbus_api/modest-dbus-callbacks.h:
2710 * src/maemo/modest-platform.c: (modest_platform_init):
2711 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2712 in case this has some effect on the ability for Maemo to ping the
2715 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2717 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2718 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2719 warning. It is probably a logic error, but I need to fix the build.
2721 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2723 * src/modest-account-mgr.h:
2724 * src/modest-account-mgr.c:
2725 (modest_account_mgr_account_names): Add a gboolean enabled_only
2726 parameter, so we can get lists of onlt the enabled accounts.
2728 (modest_account_mgr_add_account),,
2729 (modest_account_mgr_account_with_display_name_exists):
2730 * src/maemo/modest-msg-edit-window.c: (get_transports):
2731 * src/modest-account-mgr-helpers.c:
2732 (modest_account_mgr_set_first_account_as_default):
2733 * src/modest-init.c: (init_default_account_maybe):
2734 * src/modest-tny-account-store.c: (get_accounts):
2735 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2736 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2737 * tests/check_account-mgr.c: (START_TEST):
2738 Provide the extra parameter, as appropriate.
2740 * src/widgets/modest-account-view.c: (update_account_view):
2741 Do not show disabled accounts (meaning that there is no way to
2742 enable/disable accounts in the UI (the feature is not in our UI
2743 specification), so we can use this internally only to mark unfinished
2744 or temporary account data.
2746 * src/maemo/easysetup/modest-easysetup-wizard.c:
2747 (create_account): Add boolean enable parameter, so we can specify FALSE
2748 to create the temporary account.
2749 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2750 (on_before_next): When finishing, when there is a temporary account, just
2752 Also, use a timeout to delay the showing of the dialog until gconf is likely
2753 to return correct information, due to a maemo gconf bug that is fixed in
2754 osso 1.1, but not yet in Bora.
2755 However, the dialog stays on screen after it is destroyed.
2757 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2758 for invalid data when cancelling. Use a hildon note instead of a dialog
2759 to complain about invalid data. Do not show the account-saved note if the
2760 account is disabled (a temporary account that will not really be saved for use
2763 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2765 * src/modest-account-mgr-helpers.h:
2766 * src/modest-account-mgr-helpers.c:
2767 Added modest_account_mgr_unset_default_account(),
2768 Added modest_account_mgr_set_first_account_as_default().
2770 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2771 If it was the default account, unset the default account name.
2773 * src/maemo/modest-account-view-window.c:
2774 (on_delete_button_clicked): If it was the default account,
2775 set the first remaining account as the default instead.
2777 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2778 a NULL account or a NULL default account, to prevent a crash. This should
2779 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2782 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2784 * src/widgets/modest-recpt-editor.c:
2785 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2786 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2787 TODO comment for this. This fixes the build.
2789 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2790 be the best place for it. This will in future update all auto-update accounts,
2791 rather than just the current/default account, when that gconf key exists.
2792 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2793 if there are no accounts, before calling do_send_receive().
2794 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2796 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2797 * src/maemo/modest-main-window-ui.h:
2798 * src/maemo/modest-main-window.c: (on_connection_changed),
2799 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2800 directly, becaue the signal handler does more.
2802 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2804 * src/modest-account-mgr-helpers.c:
2805 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2806 for the case that the account does not exist.
2808 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2809 (equivalent to the modest account name) rather than the tinymail account name
2810 (equivalent to the modest account title - human readable) to get the account data.
2811 Check for null account data to prevent the crash, and add a TODO comment saying that
2812 this needs fixing because it is using the server account name instead of the account name.
2814 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2817 * src/maemo/modest-account-settings-dialog.c: (show_error),
2819 Use hildon_note_new_information() for informative and error messages,
2820 which seems to be expected for Maemo applications (no documentation that I know of
2821 says this). I am surprised that there is no distinction between info and error
2824 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2826 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2827 it is easy to find where this is used.
2829 * src/maemo/easysetup/modest-easysetup-wizard.c:
2830 (create_page_welcome), (create_page_account_details),
2831 (create_page_user_details), (create_page_complete_easysetup),
2832 (create_page_custom_incoming), (create_page_custom_outgoing),
2833 (create_page_complete_custom):
2834 * src/maemo/modest-account-settings-dialog.c:
2835 (create_page_account_details), (create_page_user_details),
2836 (create_page_incoming), (create_page_outgoing):
2837 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2839 (modest_connection_specific_smtp_edit_window_init):
2840 * src/maemo/modest-connection-specific-smtp-window.c:
2841 (modest_connection_specific_smtp_window_init):
2842 * src/maemo/modest-signature-editor-dialog.c:
2843 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2844 and scrolling policy as per the Email Application Layout Guide, if I have
2847 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2849 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2850 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2851 which were empty, because these vfuncs have been removed from TnyAccountStore.
2852 This fixes the build.
2854 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2856 * src/maemo/modest-main-window.c:
2857 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2858 showing/hiding it. Added TODO because it probably should not be NULL.
2859 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2860 because unnecessary g_warnings() make degugging difficult.
2862 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/modest-msg-edit-window.c:
2865 (modest_msg_edit_window_select_color),
2866 (modest_msg_edit_window_select_background_color): 2 const corrections and
2867 moving 2 #endifs before closing brackets, to fix the build.
2869 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2871 * src/maemo/easysetup/modest-easysetup-wizard.h:
2872 * src/maemo/easysetup/modest-easysetup-wizard.c:
2873 (modest_easysetup_wizard_dialog_finalize),
2874 (on_button_edit_advanced_settings), (create_page_complete_custom),
2875 (on_response), (create_account):
2876 Implement the Advanced Settings edit button, by saving the account information,
2877 for the Advanded Settings dialog to use directly from gconf, and removing it
2878 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2879 Bug #5533 in the projects.maemo.org bugzilla.
2881 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2883 * src/maemo/modest-msg-view-window.c:
2884 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2885 when opening a message window.
2887 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/easysetup/modest-easysetup-wizard.c:
2890 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2893 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2894 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2895 gconf settings. I probably added more checks than necessary, but that is safer.
2897 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2898 variable to fix the build, but this seems to be used when it is still NULL.
2900 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2902 * src/modest-platform.h:
2903 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2904 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2905 * src/modest-main.c: Implement this function so we can avoid using
2906 maemo-specific API from cross-platform code.
2908 * src/modest-tny-account-store.c:
2909 (get_smtp_specific_transport_account_for_open_connection):
2910 * src/modest-ui-actions.c: (check_for_connection),
2911 (modest_ui_actions_on_item_not_found):
2912 Use modest_platform_connect_and_wait() and put #idefs around other
2913 maemo-specific code, because only maemo currently has a way to
2914 identify connection names.
2916 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2918 * src/modest-tny-account-store.h:
2919 * src/modest-tny-account-store.c:
2920 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2921 the connection-specific SMTP server settings in the configuration.
2923 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2925 * src/maemo/modest-main-window.c: (on_connection_changed),
2927 * src/modest-main.c: (main), (start_ui), (send_mail):
2928 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2929 that is what is intended.
2931 * src/modest-ui-actions.c: (action_send), (action_receive),
2932 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2933 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2934 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2935 SMTP server is used when it is specified.
2937 (modest_ui_actions_on_send_receive):
2938 Check that a connection is open before proceeding.
2939 Receive and then send, instead of vice-versa, as per the specification.
2941 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2943 * src/modest-mail-operation.c:
2944 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2945 though I guess it should be something other than NULL.
2947 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2949 * src/maemo/easysetup/modest-easysetup-wizard.c:
2950 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2951 combo twice, to avoid an g_warning and to make it visible again.
2952 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2953 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2954 (already intended) dereference when detaching, because we then recreate the menu.
2955 But I am not sure why the warning was happening, and it is possible that this is a memory
2958 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2960 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2961 and uri_parse_mailto() utility functions.
2962 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2964 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2966 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2968 * src/dbus_api/modest-dbus-api.h:
2969 * src/dbus_api/modest-dbus-callbacks.c:
2970 Use an idle callback to execute the modest code in the application's own thread.
2971 Remove the helloworld example method.
2972 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2973 parsed, and the open-message method is not implemented because this is not yet implemented in
2975 * libmodest-dbus-client/libmodest-dbus-client.c:
2976 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2977 (libmodest_dbus_client_open_message):
2978 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2980 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2981 body without crashing.
2983 * tests/dbus_api/Makefile.am:
2984 * tests/dbus_api/test_mail_to.c:
2985 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2987 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2989 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2990 Added file to fix the build. Sorry.
2992 * src/dbus_api/Makefile.am:
2993 * src/dbus_api/modest-dbus-api.h:
2994 * src/dbus_api/modest-dbus-callbacks.h:
2995 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2996 (modest_dbus_req_handler):
2997 Put constants in a separate header so it can be reused by the
2998 client library, without duplication
3000 * libmodest-dbus-client/Makefile.am:
3001 * libmodest-dbus-client/libmodest-dbus-client.c:
3002 (libmodest_dbus_client_call_helloworld),
3003 (libmodfest_dbus_client_send_mail),
3004 (libmodfest_dbus_client_mailto),
3005 (libmodfest_dbus_client_open_message):
3006 * libmodest-dbus-client/libmodest-dbus-client.h:
3007 (Partly) Implement a send_mail D-Bus method.
3009 * tests/dbus_api/Makefile.am:
3010 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3011 the send_email D-Bus method.
3013 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3017 * libmodest-dbus-client/Makefile.am:
3018 * libmodest-dbus-client/libmodest-dbus-client.c:
3019 * libmodest-dbus-client/libmodest-dbus-client.h:
3020 * tests/dbus_api/Makefile.am:
3021 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3022 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3024 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3026 * src/maemo/easysetup/modest-easysetup-wizard.c:
3027 (create_page_account_details):
3028 * src/maemo/modest-account-settings-dialog.c:
3029 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3030 widgets, because this might not be the default in future versions of the Maemo GTK+.
3031 However, I can not not get capitalization to work even in a simple test case.
3033 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 (create_page_custom_incoming), (create_page_custom_outgoing):
3037 * src/maemo/modest-account-settings-dialog.c:
3038 (create_page_account_details), (create_page_incoming),
3039 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3040 instead of using gtk_check_button_with_label(), so they are aligned like the other
3041 widgets, as per the UI spec.
3043 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3045 * src/maemo/easysetup/modest-easysetup-wizard.c:
3046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3047 * src/widgets/modest-validating-entry.c:
3048 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3049 Modest prefix instead of an EasySetup prefix.
3051 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3053 * src/widgets/modest-validating-entry.h:
3054 * src/widgets/modest-validating-entry.c: (on_insert_text),
3055 Added easysetup_validating_entry_set_max_func(), used to set a callback
3056 to call when the max number of characters is reached. GtkEntry has a max-length
3057 already but is silent about it.
3059 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3060 (create_page_account_details), (create_page_user_details),
3062 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3063 (create_page_account_details), (create_page_user_details),
3064 (create_page_outgoing):
3065 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3066 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3067 the UI spec, when the user tries to enter more than the max number of characters.
3069 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3071 * src/maemo/easysetup/modest-easysetup-wizard.c:
3072 (create_page_user_details), (create_page_custom_incoming),
3073 (create_page_custom_outgoing):
3074 * src/maemo/modest-account-settings-dialog.c:
3075 (create_page_user_details), (create_page_incoming),
3076 (create_page_outgoing):
3077 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3078 (modest_connection_specific_smtp_edit_window_init):
3079 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3080 not appropriate. Bad Maemo-specific defaults!.
3082 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3084 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3085 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3086 (modest_signature_editor_dialog_set_settings):
3087 Disable the label and textview when the checkbox is disabled, and use the
3088 specified (UI spec) default signature text.
3090 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3093 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3095 * src/modest-defs.h:
3096 * src/modest-account-mgr-helpers.h:
3097 * src/modest-account-mgr-helpers.c:
3098 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3100 * src/maemo/Makefile.am:
3101 * src/maemo/modest-signature-editor-dialog.c:
3102 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3105 * src/maemo/modest-account-settings-dialog.h:
3106 * src/maemo/modest-account-settings-dialog.c:
3107 (modest_account_settings_dialog_finalize), (on_button_signature),
3108 (save_configuration): Use the new dialog when the Edit button is pressed, and
3109 save the changes if necessary, as per the UI spec.
3111 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/Makefile.am:
3114 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3115 based on maemo-develoers email from Dirk.
3117 * src/maemo/easysetup/modest-easysetup-wizard.c:
3118 (create_page_welcome), (create_page_account_details),
3119 (create_page_user_details), (create_page_complete_easysetup),
3120 (create_page_custom_incoming), (create_page_custom_outgoing),
3121 (create_page_complete_custom),
3122 (modest_easysetup_wizard_dialog_init):
3123 * src/maemo/modest-account-settings-dialog.c:
3124 (create_page_account_details), (create_page_user_details),
3125 (create_page_incoming), (create_page_outgoing),
3126 (modest_account_settings_dialog_init):
3127 * src/maemo/modest-connection-specific-smtp-window.c:
3128 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3130 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3132 * src/maemo/easysetup/modest-easysetup-wizard.c:
3133 (create_page_account_details), (create_page_custom_outgoing),
3134 (create_page_complete_custom):
3135 * src/maemo/modest-account-settings-dialog.c:
3136 (create_page_user_details), (create_page_incoming),
3137 (create_page_outgoing):
3138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3139 (modest_connection_specific_smtp_edit_window_init):
3140 Use the correct (UI spec) port min/max, and use horizontal separators,
3143 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3145 * src/maemo/easysetup/modest-easysetup-wizard.c:
3146 (set_default_custom_servernames):
3147 * src/maemo/modest-account-settings-dialog.c:
3148 (create_page_incoming), (on_combo_outgoing_security_changed),
3149 (on_combo_incoming_security_changed), (create_page_outgoing),
3150 (modest_account_settings_dialog_set_account_name),
3151 (save_configuration):
3152 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3153 (on_combo_security_changed),
3154 (modest_connection_specific_smtp_edit_window_init),
3155 (modest_connection_specific_smtp_edit_window_set_connection),
3156 (modest_connection_specific_smtp_edit_window_get_settings):
3157 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3160 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3163 * src/maemo/easysetup/modest-easysetup-wizard.c:
3164 (create_page_custom_outgoing), (create_page_complete_custom):
3165 * src/maemo/modest-account-settings-dialog.c:
3166 (create_page_user_details), (create_page_outgoing):
3167 * src/maemo/modest-account-view-window.c: (button_box_new):
3168 Use changed logical IDs as per the most recent UI spec:
3169 mcen_bd_emailsetup_edit -> mcen_bd_edit
3170 mcen_bd_emailsetup_delete -> mcen_bd_delete
3171 mcen_bd_emailsetup_close -> mcen_bd_close
3173 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3177 * src/dbus_api/Makefile.am:
3178 * src/dbus_api/modest-dbus-callbacks.c:
3179 * src/dbus_api/modest-dbus-callbacks.h:
3180 * src/maemo/modest-platform.c: (modest_platform_init):
3181 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3183 * tests/Makefile.am:
3184 * tests/dbus_api/Makefile.am:
3185 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3187 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-account-settings-dialog.c:
3190 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3191 Removed unnecessary includes.
3193 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/easysetup/modest-easysetup-wizard.c:
3196 * src/maemo/modest-account-settings-dialog.c:
3197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3198 * src/widgets/Makefile.am:
3199 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3200 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3201 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3202 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3203 * src/widgets/modest-secureauth-combo-box.c:
3204 * src/widgets/modest-secureauth-combo-box.h:
3205 * src/widgets/modest-serversecurity-combo-box.c:
3206 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3207 made the GObject names more consistent with the rest of the Modest code.
3209 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3211 * src/maemo/easysetup/Makefile.am:
3212 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3213 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3214 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3215 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3216 * src/maemo/easysetup/modest-easysetup-wizard.c:
3217 * src/maemo/easysetup/modest-validating-entry.c:
3218 * src/maemo/easysetup/modest-validating-entry.h:
3219 * src/maemo/modest-account-settings-dialog.c:
3220 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3221 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3222 widgets/ because they are used outside of easysetup too. After checking in,
3223 svn will allow me to rename them too.
3225 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3227 * src/gnome/modest-msg-edit-window.c:
3228 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3229 linker error, to fix the build on the GNOME platform.
3230 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3231 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3232 ifdefed out to avoid a warning.
3234 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3236 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3237 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3238 some alternative for GTK+ 2.6.
3240 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3244 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3245 specified for EmailAccountsDialog in UI spec.
3247 * src/maemo/easysetup/modest-easysetup-wizard.c:
3248 * src/maemo/easysetup/modest-easysetup-wizard.h:
3249 * src/maemo/modest-account-settings-dialog.c:
3250 * src/maemo/modest-account-settings-dialog.h:
3251 Reuse a member window widget for the connection-specific SMTP server accounts,
3252 so we can tell it to create/save the accounts only if we actually save changes.
3254 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3256 (modest_connection_specific_smtp_edit_window_get_settings):
3257 Return a struct instance for temporarily remembering the entered data.
3259 * src/maemo/modest-connection-specific-smtp-window.h:
3260 * src/maemo/modest-connection-specific-smtp-window.c:
3261 (modest_connection_specific_smtp_window_finalize),
3262 (modest_connection_specific_smtp_window_fill_with_connections),
3264 (modest_connection_specific_smtp_window_save_server_accounts),
3265 (update_model_server_names): Do not actually save data until asked,
3266 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3268 (on_selection_changed),
3269 (modest_connection_specific_smtp_window_init): Disable the edit
3270 button when nothing is selected.
3272 * src/modest-account-mgr-helpers.c:
3273 * src/modest-account-mgr-helpers.h:
3274 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3277 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3279 * src/modest-account-mgr-helpers.h:
3280 * src/modest-account-mgr-helpers.c:
3281 (modest_account_mgr_get_unused_account_name),
3282 (modest_account_mgr_get_unused_account_display_name): Added these
3283 utility functions, to avoid code duplication.
3285 * src/maemo/easysetup/modest-easysetup-wizard.c:
3286 (create_page_account_details), (create_account):
3287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3288 (on_combo_security_changed),
3289 (modest_connection_specific_smtp_edit_window_init),
3290 (modest_connection_specific_smtp_edit_window_save_settings):
3291 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3292 * src/maemo/modest-connection-specific-smtp-window.c:
3293 (modest_connection_specific_smtp_window_finalize),
3294 (modest_connection_specific_smtp_window_fill_with_connections),
3295 (on_button_edit), (modest_connection_specific_smtp_window_init):
3296 * src/maemo/modest-connection-specific-smtp-window.h:
3297 Implementing saving of connection-specific server accounts.
3299 But I need to refactor this so we can save the data for each
3300 possible connection-specific account and only actually create the server accounts
3301 when the easysetup finished, or the OK button is pressed on the account settings
3304 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3306 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3307 (on_combo_security_changed):
3308 (modest_connection_specific_smtp_edit_window_init):
3309 Auto-fill the port number as in the account settings.
3311 (modest_connection_specific_smtp_edit_window_set_connection):
3312 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3313 * src/maemo/modest-connection-specific-smtp-window.c:
3314 (fill_with_connections), (on_button_edit),
3315 (modest_connection_specific_smtp_window_init):
3316 Turn the edit window into a dialog to simplify the code, and
3317 set a WM hint as in a GtkDialog, because only a popup can be on top of
3318 another window in Maemo, and popups usually have no WM decoration.
3320 * src/modest-defs.h:
3321 * src/modest-account-mgr-helpers.c:
3322 (modest_account_mgr_set_connection_specific_smtp),
3323 (modest_account_mgr_remove_connection_specific_smtp),
3324 (modest_account_mgr_get_connection_specific_smtp):
3325 * src/modest-account-mgr-helpers.h: Some functions to write the
3326 connection-specific SMTP server information. Not yet used.
3329 * src/widgets/modest-folder-view.c: (text_cell_data):
3330 Fix a warning about an uninitialized variable.
3331 (on_configuration_key_changed): Put an #ifdef around the use
3332 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3334 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/modest-account-settings-dialog.h:
3337 * src/maemo/modest-account-settings-dialog.c:
3338 Added connect_for_modified() utility function to mark the new modified boolean.
3340 (create_page_account_details), (create_page_user_details),
3341 (create_page_incoming), (create_page_outgoing), (on_response),
3342 (modest_account_settings_dialog_init),
3343 (modest_account_settings_dialog_set_account_name):
3344 Only warn about unsaved changes when there are actually unsaved changes.
3346 * src/modest-account-mgr-helpers.c:
3347 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3348 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3349 to get the data from there in future.
3351 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3353 * src/modest-defs.h:
3355 * src/modest-account-mgr-helpers.h:
3356 * src/modest-account-mgr-helpers.c:
3357 Store the security account setting in a single conf key instead of using
3358 the options list, so that the list is left for just the to-be-removed camel hack,
3359 and because gconf_client_set_list() is failing for some reason.
3361 * src/modest-account-mgr.c:
3362 (modest_account_mgr_add_server_account):
3363 * src/maemo/modest-account-settings-dialog.c:
3364 (modest_account_settings_dialog_set_account_name),
3365 (save_configuration): Use the renamed functions.
3368 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3370 * src/widgets/Makefile.am:
3371 * src/widgets/modest-limit-retrieve-combo-box.c:
3372 * src/widgets/modest-limit-retrieve-combo-box.h:
3373 * src/widgets/modest-retrieve-combo-box.c:
3374 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3375 the account settings dialog.
3377 * src/modest-defs.h:
3378 * src/modest-account-mgr-helpers.h:
3379 * src/modest-account-mgr-helpers.c:
3380 (modest_server_account_get_option_secure_auth),
3381 (modest_server_account_set_option_secure_auth):
3382 * src/modest-account-mgr.c:
3383 (modest_account_mgr_add_server_account):
3384 Use the existing AUTH_MECH conf key for the secure-auth setting,
3385 instead of putting it in the list options, because this was actually used already.
3387 * src/maemo/modest-account-settings-dialog.c:
3388 (create_page_account_details),
3389 (modest_account_settings_dialog_set_account_name),
3390 (save_configuration):
3391 * src/maemo/modest-account-settings-dialog.h:
3392 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3393 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3395 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3397 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3398 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3399 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3401 * src/modest-defs.h:
3402 * src/maemo/modest-account-settings-dialog.c:
3403 (create_page_incoming), (on_combo_outgoing_security_changed),
3404 (on_combo_incoming_security_changed), (create_page_outgoing),
3405 (modest_account_settings_dialog_set_account_name),
3406 (save_configuration): Load/Save the port number, and change it when the
3407 security combo changes, to suitable defaults.
3409 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3411 * src/modest-account-mgr.c:
3412 (modest_account_mgr_add_server_account): Set the security and secure-auth
3413 options, and add a comment saying that the other camel-specific options should be
3416 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3418 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3420 * src/modest-tny-account-store.c: (account_list_free),
3421 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3422 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3425 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3427 * src/modest-protocol-info.c:
3428 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3429 is required by our UI spec. Maybe something in our implementation will use this eventually.
3430 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3431 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3432 instead of the previous 0 placeholder.
3434 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3435 secure-auth settings.
3436 * src/modest-account-mgr-helpers.h:
3437 * src/modest-account-mgr-helpers.c:
3438 (modest_server_account_data_get_option_secure_auth),
3439 (modest_server_account_set_option_secure_auth),
3440 (modest_server_account_data_get_option_security),
3441 (modest_server_account_set_option_security): Added this API for getting and setting the security
3442 and secure-auth settings.
3444 * src/maemo/modest-account-settings-dialog.h:
3445 * src/maemo/modest-account-settings-dialog.c:
3446 (modest_account_settings_dialog_finalize), (check_data),
3447 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3448 about changing titles.
3449 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3450 (save_configuration): Save the security and secure-auth settings.
3452 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3453 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3455 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3457 * src/modest-defs.h:
3458 * src/modest-account-mgr.c:
3459 (modest_account_mgr_add_server_account):
3460 Added and used defines for the options key and value pair strings,
3461 that are used so far, though they do not seem to correspond to anything in our
3462 UI specs or ModestProtocol enum.
3464 * src/modest-account-mgr-helpers.h:
3465 * src/modest-account-mgr-helpers.c:
3466 (compare_option_strings_for_name),
3467 (modest_server_account_data_get_option_value),
3468 (modest_server_account_data_get_option_bool),
3469 (modest_account_mgr_get_server_account_option):
3470 Added helper functions for parsing the options GSList.
3472 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3474 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3475 display name is based on the supplied account name.
3476 * src/modest-account-mgr.c:
3477 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3478 with an inefficient, but good-enough, implementation.
3480 * src/maemo/easysetup/modest-easysetup-wizard.c:
3481 (create_page_account_details), (on_before_next), (create_account):
3482 Check for existing display names rather than (non-user-visible) account names, and just
3483 create and set a unique account name at the end.
3485 * src/maemo/modest-account-settings-dialog.c:
3486 (modest_account_settings_dialog_init),
3487 (modest_account_settings_dialog_set_account_name),
3488 (create_page_incoming): Show the display name, instead of the account name.
3489 (on_response): Do some (not all) extra checks, as in the UI spec.
3490 (save_configuration): Save the display name if it was changed.
3492 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3494 * po/en_GB.po: Added needed logical ID and translation.
3495 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3496 (init_view): Made the is-default column clicking work.
3498 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3501 * src/maemo/easysetup/Makefile.am:
3502 * src/maemo/easysetup/modest-easysetup-wizard.c:
3503 (modest_easysetup_wizard_dialog_init):
3504 * src/maemo/easysetup/provider-data-test.keyfile:
3505 * src/maemo/easysetup/provider-data.keyfile:
3506 Moved the provider data file to the new modest-providers-data package and used it from there.
3508 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3510 * src/modest-local-folder-info.c:
3511 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3512 N_() was already used on the static strings, but this just marks it for translation without
3513 using the translation.
3515 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/modest-account-settings-dialog.c:
3518 (create_page_incoming),
3519 (modest_account_settings_dialog_set_account_name):
3520 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3521 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3522 I will do this if nobody else gets there first.
3524 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3527 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3528 save the security stuff.
3530 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3532 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3533 Set the email address and user fullname, which I now see must be
3536 * src/maemo/modest-account-settings-dialog.h:
3537 * src/maemo/modest-account-settings-dialog.c:
3539 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3540 leave-on-server and authentication.
3541 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3544 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3547 * src/maemo/modest-account-settings-dialog.c:
3548 * src/maemo/modest-account-settings-dialog.h:
3549 Most (but not all) of the widgets are now present as specified by the UI spec.
3550 No changes are yet saved, and some details are not properly shown yet.
3552 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3554 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3556 * src/maemo/Makefile.am:
3557 * src/maemo/modest-account-settings-dialog.c:
3558 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3559 an existing account. Doesn't do much yet.
3561 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3562 Open the accounts settings dialog when Edit is clicked.
3564 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3566 * src/maemo/easysetup/Makefile.am:
3567 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3569 * src/maemo/easysetup/modest-easysetup-wizard.c:
3570 (modest_easysetup_wizard_dialog_init):
3571 Try to get the source directory from the build system,
3572 instead of hard-coding "./" into the source code, when opening our local
3573 copies of the configuration files.
3574 But this still fails when opening the wizard from the Accounts window,
3575 maybe because the working directory seems to change at runtime.
3576 So the wizard will fail the second time unless you copy the files into their
3577 proper locations - see the stdout warnings for the paths.
3579 (create_page_account_details),(on_before_next):
3580 Check for existing non-server accounts instead of server accounts,
3581 so the default account name is useful again, and to prevent trying to
3584 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3585 Show the wizard when New is clicked.
3587 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3588 (init_view): Show the column headers, and show the columns that are
3589 specified in the UI specs. However, something in Maemo's GTK+ prevents
3590 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3591 change the default account. This is despite unsetting the special properties.
3593 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3595 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3596 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3597 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3598 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3599 to make that clearer.
3600 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3602 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3604 * src/maemo/modest-account-view-window.c:
3605 (modest_account_view_window_init),
3606 (modest_account_view_window_new):
3607 Use the same buttons as specified in the
3608 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3609 the existing widgets, which never had a chance of working.
3610 Put the ModestAccountView treeview in a scrolled window.
3611 Do not repeat the initialization in both _init() and _new().
3613 * src/widgets/modest-account-view.c: (update_account_view):
3614 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3615 this widget and window shows no accounts.
3617 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3619 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3621 * src/maemo/easysetup/modest-easysetup-wizard.c:
3622 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3623 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3624 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3627 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3628 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3629 accounts exist yet, as in the UI spec.
3631 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3633 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/Makefile.am:
3636 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3637 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3638 New window for editing connection-specific smtp details.
3639 Not fully implemented.
3641 * src/maemo/modest-connection-specific-smtp-window.c:
3642 (modest_connection_specific_smtp_window_finalize) :
3643 unref the tree model.
3644 (on_button_edit): Show the edit window.
3646 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3648 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3651 * src/maemo/Makefile.am:
3652 * src/maemo/modest-connection-specific-smtp-window.c:
3653 * src/maemo/modest-connection-specific-smtp-window.h:
3654 New window for showing the list of connections, for connection-specific
3655 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3656 * src/maemo/easysetup/modest-easysetup-wizard.c:
3657 (create_page_custom_outgoing): Show the new window when the button is clicked.
3659 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3661 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3662 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3663 * src/maemo/modest-msg-edit-window.c:
3664 (modest_msg_edit_window_insert_image):
3665 * src/modest-conf.c: (modest_conf_key_escape):
3666 * src/modest-mail-operation.c:
3667 (modest_mail_operation_send_new_mail):
3668 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3669 (modest_ui_actions_on_new_account):
3670 * src/widgets/modest-attachment-view.c: (update_filename_request):
3671 * src/widgets/modest-mail-header-view.c:
3672 Corrected warnings that were breaking the build, by commenting out unused variables,
3673 and a function, and by including a header.
3675 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3677 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3678 so we can #ifdef around platform-specific code when necessary.
3679 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3680 to allow this to build for the GNOME platform too.
3682 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3684 * src/maemo/easysetup/modest-easysetup-wizard.c:
3685 Added util_increment_name() and used it in create_page_account_details()
3686 to make sure that the default account name is always a new name.
3688 (modest_easysetup_wizard_dialog_init),
3689 (set_default_custom_servernames): Some minor memory management fixes.
3691 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3695 * src/modest-runtime.c: (init_i18n): Restored the translation
3696 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3697 are defined in config.h, and the translations are installed.
3699 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3700 is defined for translation.
3702 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3704 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3706 * src/maemo/easysetup/modest-easysetup-wizard.c:
3707 (modest_easysetup_wizard_dialog_init):
3708 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3709 Use realistic paths (though they should use $prefix generically) to the
3710 mcc_mapping and provider-data.keyfile files which might work when they
3711 are installed by the future version of the operator-wizard package,
3712 and then fallback to paths in our source code, with an explanatory
3715 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3719 * src/maemo/Makefile.am:
3720 * src/maemo/easysetup/: Added files from the previously-exernal
3721 osso-modest-easysetup.
3722 * src/maemo/modest-main-window-ui.h:
3723 * src/modest-ui-actions.c:
3724 * src/modest-ui-actions.h:
3725 Added modest_ui_actions_on_new_account() as a signal handler for the
3726 New Account menu item. It shows the easysetup wizard.
3727 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob