1 2007-08-01 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
4 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
5 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
6 error dialog, instead of ignoring it.
8 2007-08-01 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-msg-view-window.c:
11 (modest_msg_view_window_get_header),
12 (modest_msg_view_window_last_message_selected):
13 Added comments to explain the use of priv->header_model.
14 * src/modest-ui-dimming-rules.c:
15 (modest_ui_dimming_rules_on_open_msg),
16 (modest_ui_dimming_rules_on_mark_as_read_msg),
17 (modest_ui_dimming_rules_on_mark_as_unread_msg),
18 (modest_ui_dimming_rules_on_remove_attachments),
19 (_invalid_attach_selected), (_selected_msg_marked_as):
20 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
21 and changed the parameter to a ModestMainWindow to make it clearer that
22 it never uses any other kind of window.
23 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
24 instead of the selected message.
25 I notice that much of the dimming code and the ModestMsgViewWindow code
26 hard-codes the assumption that the viewed message is always selected in
27 the header view. This does not seem wise or simple.
29 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
30 examine the actual message instead of whatever might be selected
31 in the header view. This stops the delete toolbar button and menu item
32 from being dimmed when opening a message view the search UI,
33 partially fixing projects.maemo.org bug NB#63811.
35 However, when actually deleting, I now get this warning:
36 "tny_header_set_flags: This is a header instance for a new message.
37 Only priority and attachment flags are supported"
39 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
41 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
43 Show account wizard if no accounts are defined while sending
44 (automatic sending after the account wizard finished does not
45 work because it takes some time until the account manager
46 synchronizes everything. (projects.maemo.org NB#62792)
48 2007-07-30 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-tny-account-store.c: (on_account_removed),
51 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
52 account is removed from the View menu. We have TnyAccountStore
53 and ModestTnyAccountStore signals that seem very similar, but this
54 seems to work for now.
56 * src/maemo/modest-main-window.c:
57 (on_show_account_action_activated): Prevent dereference
58 of a NULL if the accoutn does not really exist, though that
59 should not happen anymore.
61 This fixes projects.maemo.org bug NB#64606.
63 2007-07-30 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-ui-actions.c: (run_account_setup_wizard),
66 (modest_ui_actions_on_accounts): Revert a change that set these
67 to modal dialogs, freezing the UI when they show secondary dialogs.
68 This fixed projects.maemo.org bug NB#64519.
70 2007-07-27 Murray Cumming <murrayc@murrayc.com>
72 * src/widgets/modest-header-view-render.c:
73 (_modest_header_view_compact_header_cell_data):
74 Some checks and initialization to try to deal with a crash,
77 2007-07-27 Murray Cumming <murrayc@murrayc.com>
79 * src/maemo/modest-maemo-utils.c:
80 (modest_maemo_utils_get_supported_secure_authentication_methods):
81 Make sure that we have a connection, asking the user for one
83 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
84 Check for a connection before showing the wizard, because
85 the wizard needs a connection to check for server capabilities.
87 2007-07-27 Murray Cumming <murrayc@murrayc.com>
89 * src/maemo/modest-account-view-window.c:
90 (on_new_button_clicked): Remember the wizard dialog instance,
91 so we can just present it again if necessary. This prevents
92 multiple windows from appearing if you click again quickly on the
93 New button before the dialog appears, fixing projects.maemo.org
96 2007-07-27 Murray Cumming <murrayc@murrayc.com>
98 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
99 Offer a connection dialog if there is no connection when
100 starting modest. This should fix projects.maemo.org bug NB#61134.
102 2007-07-27 Murray Cumming <murrayc@murrayc.com>
104 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
105 Reverted my last commit. I was able to fix the build by doing
106 apt-get install wpeditor0 (replacing other wpeditor packages) and
107 an explicit apt-get install wpeditor-dev to upgrade the -dev
110 2007-07-27 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
113 Commented out the use of wp_text_buffer_replace_image()
114 because it does not exist, to break the build. Added a TODO for it.
116 2007-07-26 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-tny-account-store.c: (recreate_all_accounts):
119 Recreate them even if they were NULL before. I guess something
120 else was already creating them before, or this would never
122 (modest_tny_account_store_get_server_account): Make sure that
123 the tny accounts have been created before trying to find one.
124 This allows libmodest_dbus_client_compose_mail() to work
125 when the UI is not yet visible.
126 This is probably useful in other cases too.
128 (get_password): When the password is wrong after it is entered
129 in the protected password dialog, show an info banner (in an
130 idle handler) before showing the protected password dialog
133 2007-07-26 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-ui-actions.h:
136 * src/modest-ui-actions.c: Added
137 modest_do_refresh_current_folder() containing some code from
138 modest_ui_actions_on_send_receive().
139 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
140 Call modest_do_refresh_current_folder() before refreshing the
141 requested account, as in modest_ui_actions_on_send_receive().
142 This is strange, but seems to be necessary to show new mails.
143 Now new emails are finally visible in the UI when downloaded
144 via the automatic update interval, fixing bug NB#57458.
145 This also works because bug NB#57458 has been fixed somehow.
147 2007-07-26 Murray Cumming <murrayc@murrayc.com>
149 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
150 printf more details when we get unhandled D-Bus methods, because
153 * src/modest-mail-operation.c: (update_account_thread):
154 Comment out the tny_camel_pop_store_account_reconnect(), because this
155 is apparently no longer needed, and it did not work before anyway.
156 See the comment in the code.
158 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
159 by checking the header flags. This fixes projects.maemo.org bug
162 2007-07-25 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/modest-maemo-utils.h:
165 * src/maemo/modest-maemo-utils.c: Added
166 modest_maemo_show_information_note_in_main_context_and_forget().
167 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
168 Use the new function to show simple error dialogs in the main
169 context, though question dialogs are still in the current context,
170 which is unfortunately usually not the main context. This should
173 2007-07-25 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-tny-account-store.c: (get_password):
176 Never save the entered username and password in gconf,
177 because the UI spec says we should not. This helps
178 slightly with projects.maemo.org bug NB#63671.
180 2007-07-25 Murray Cumming <murrayc@murrayc.com>
182 * src/widgets/modest-msg-edit-window.h:
183 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
184 Moved some code here to make it simpler.
185 (modest_msg_edit_window_attach_file_one): Renamed from
186 modest_msg_edit_window_attach_file_interactive().
187 (modest_msg_edit_window_offer_attach_file): Renamed from
188 modest_msg_edit_window_attach_file() and used
189 modest_msg_edit_window_attach_file_one() instead of
190 copy/pasting the code. The old code for one was not using
191 GnomeVFS. This allows use of smb:// URLs when using send-as
192 from external applications, fixing bug NB#63741.
194 (modest_msg_edit_window_insert_image),
195 (modest_msg_edit_window_add_attachment_clicked):
196 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
197 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
198 Adapted to the new function names.
200 2007-07-25 Murray Cumming <murrayc@murrayc.com>
202 (modest_platform_set_update_interval): Set the alarm recurrence
203 fields so that auto-update does not just happen the first time.
204 This should have fixed projects.maemo.org bug NB#63938.
206 When this happens you can see a printf when the D-Bus method is
208 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
210 However, I do not actually seem to get new POP messages even when
211 clicking the refresh button manually. A restart gets them.
212 This might be a problem in today's tinymail only.
214 2007-07-24 Murray Cumming <murrayc@murrayc.com>
216 * src/maemo/modest-maemo-global-settings-dialog.c:
217 (current_connection):
218 Avoid a crash (probably only in scratchbox) when strcmp()ing a
219 NULL when closing the dialog.
221 2007-07-24 Murray Cumming <murrayc@murrayc.com>
223 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
224 Remove the hacky send/receive that didn't work, and instead
225 refilter the treemodel to make the deleted email really vanish from
226 the UI (though the delete-from-menu code does has commented out
227 the code that does that). This fixes projects.maemo.org bug
230 2007-07-24 Murray Cumming <murrayc@murrayc.com>
232 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
233 Try a couple of tricks to force the treeview to update (
234 poke the folder, and do a send/receive refresh), but the deleted
235 email still appears with a strike-through instead of really being
238 2007-07-23 Murray Cumming <murrayc@murrayc.com>
240 * src/dbus_api/modest-dbus-callbacks.c:
241 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
242 because their ID is not human-readable (see the comment about
243 improvements needed to the osso-email-interface API) and
244 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
246 2007-07-23 Murray Cumming <murrayc@murrayc.com>
248 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
249 (add_folders_to_list), (on_dbus_method_get_folders),
250 (modest_dbus_req_filter):
251 * src/maemo/modest-maemo-utils.c:
252 (on_camel_account_get_supported_secure_authentication):
253 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
254 (on_header_view_focus_in):
255 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
256 * src/modest-formatter.c: (modest_formatter_create_body_part):
257 * src/modest-mail-operation.c: (recurse_folders),
258 (update_account_thread), (get_msgs_full_thread),
259 (modest_mail_operation_get_msgs_full),
260 (modest_mail_operation_xfer_msgs):
261 * src/modest-search.c: (search_mime_part_and_child_parts),
262 (modest_search_account), (modest_search_all_accounts):
263 * src/modest-tny-account.c:
264 (modest_tny_account_get_special_folder), (recurse_folders):
265 * src/modest-tny-local-folders-account.c:
266 (modest_tny_local_folders_account_query_passes):
267 * src/modest-tny-msg.c: (copy_mime_part),
268 (modest_tny_msg_find_body_part_from_mime_part):
269 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
270 (modest_tny_send_queue_try_to_send):
271 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
272 (_modest_ui_actions_open), (download_uncached_messages),
273 (reply_forward), (modest_ui_actions_on_copy),
274 (modest_ui_actions_on_details), (has_retrieved_msgs),
275 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
277 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
278 (_selected_msg_marked_as), (_msg_download_completed),
279 (_selected_msg_sent_in_progress):
280 * src/widgets/modest-attachments-view.c:
281 (modest_attachments_view_set_message):
282 * src/widgets/modest-msg-view.c: (find_cid_image):
283 * tests/check_folder-transfer.c: (find_folders):
284 * tests/check_update-account.c: (func):
285 * tests/dbus_api/test_get_folders.c: (main):
286 Checked all uses of tny_iterator_get_current(), making sure
287 that the object is unreferenced (3 or 4 places did not),
288 and adding checks for NULL.
290 2007-07-23 Murray Cumming <murrayc@murrayc.com>
292 * src/dbus_api/modest-dbus-callbacks.c:
293 (on_idle_open_default_inbox): Make sure that the application UI is
295 * src/maemo/easysetup/modest-easysetup-wizard.c:
296 (on_entry_invalid_character): Show the word whitespace instead
297 of (null) in the banner when whitespace was entered.
298 (show_error): Add a comment that this does not work in
299 Maemo Bora, though we do not know why.
301 2007-07-23 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-tny-account.c:
304 (modest_tny_account_get_special_folder): Use an if instead of
305 an assert for when the parent account name is NULL, because this
306 might be causing a crash in projects.maemo.org bug 63192.
307 * src/modest-mail-operation.c:
308 (modest_mail_operation_send_new_mail_cb),
309 (modest_mail_operation_remove_folder): unref the folder that is
310 returned from modest_tny_account_get_special_folder().
312 2007-07-23 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-ui-actions.c:
315 (modest_ui_actions_on_password_requested):
316 Show mail_ib_login_cancelled info banner when the user cancels
317 the protected password dialog, to fix projects.maemo.org
320 2007-07-23 Murray Cumming <murrayc@murrayc.com>
322 * src/maemo/modest-account-settings-dialog.c:
323 (create_page_outgoing): Put this page in a GtkScrolledWindow,
324 matching the UI mock-up in the UI spec, and allowing access
325 to all widgets even when the on-screen keyboard is active.
327 2007-07-23 Murray Cumming <murrayc@murrayc.com>
329 Reverted this previous commit from Johannes,
330 because the scrollbars are always visible and because
331 I think we only need it on onepage of the account
332 settings, not the account wizard.
333 (I wrote the wrong instructions in the bug.)
335 * src/maemo/easysetup/modest-easysetup-wizard.c:
336 Added scrollbars to account wizard dialog.
337 Fixed projects.maemo.org NB #62744
339 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
341 * src/maemo/easysetup/modest-easysetup-wizard.c:
342 (create_page_user_details):
343 Use auto-cap for name (projects.maemo.org NB#63716)
344 * src/widgets/modest-account-view.c: (on_account_busy_changed):
346 2007-07-22 Armin Burgmeier <armin@openismus.com>
348 * src/maemo/modest-ui-actions.c: Use current account instead of
349 default account for creating viewer windows, so that the viewer
350 window knows to which account the viewed message belongs.
352 * src/maemo/modest-msg-view-window.c: Destroy the window when the
353 corresponding account is deleted. This fixes projects.maemo.org bug
356 2007-07-18 Armin Burgmeier <armin@openismus.com>
358 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
359 the dialog close after entering an invalid port number and clicking
360 OK. This fixes projects.maemo.org bug NB#63602.
362 2007-07-18 Armin Burgmeier <armin@openismus.com>
364 * src/modest-tny-account-store.c:
365 (get_server_accounts): Set parent modest account name for each
366 connection-specific transport account so that special folders of such
367 an account can be looked up. This fixes a crash when changing account
368 settings. This might also be related to projects.maemo.org bug
371 2007-07-16 Armin Burgmeier <armin@openismus.com>
373 * src/modest-ui-actions.c: Added a button to create a folder to the
374 move-to dialog. This fixes projects.maemo.org bug NB#.
376 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
378 * src/maemo/easysetup/modest-easysetup-wizard.c:
379 Added scrollbars to account wizard dialog.
380 Fixed projects.maemo.org NB #62744
382 2007-07-16 Murray Cumming <murrayc@murrayc.com>
384 * src/widgets/modest-msg-view.h:
385 * src/widgets/modest-msg-view.c:
386 Added modest_msg_view_get_message_is_empty() but this needs
388 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
389 Check if there is any text in the message yet.
390 But this needs to be implemented properly.
391 (modest_msg_edit_window_toggle_find_toolbar):
392 * src/maemo/modest-msg-view-window.c:
393 (modest_msg_view_window_toggle_find_toolbar):
394 Show a banner warning if there is no text to search, when
395 trying to start a search. This partially fixes
396 projects.maemo.org bug NB#62350.
398 2007-07-13 Murray Cumming <murrayc@murrayc.com>
400 * src/modest-mail-operation.c: (update_account_thread):
401 Initialized num_new_headers to fix the build.
403 2007-07-13 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
406 Ignore modest accounts whose server accounts don't exist in gconf.
407 This prevents us trying to create TnyAccount instances for those
408 server accounts when the server account has been removed from gconf,
409 but the parent modest account has not yet been removed from modest.
410 I don't know why this is only noticeable now. It was probably just
411 a harmeless g_warning() anyway.
413 2007-07-13 Murray Cumming <murrayc@murrayc.com>
415 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
416 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
418 2007-07-12 Armin Burgmeier <armin@openismus.com>
420 * src/maemo/modest-main-window.c: Make default account appear bold
421 in view, tools/send & receive and toolbar/send & receive SCM menus.
422 This fixes projects.maemo.org bug NB#59010.
424 2007-07-12 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
427 Add a short-cut, by checking if the folder store is an account.
428 This ensures that the Sort menu item and toolbar is dimmed for
429 the local-folders account root item, fixing
430 projects.maemo.org bug NB#62545.
432 2007-07-12 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-tny-account-store.c: (get_password):
435 Show the password dialog (via the signal) only in the mainloop, via
436 an idle handler that we wait for. This could theoretically prevent
437 hangs, though I worry that it could introduce some too.
439 2007-07-12 Murray Cumming <murrayc@murrayc.com>
441 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
442 * src/maemo/modest-platform.c:
443 (modest_platform_connect_and_wait):
444 Take a TnyAccount* parameter and try to set it to online
445 (a TnyCamel-only API), because tinymail sets accounts to offline
446 when the user cancels a password dialog, and doesn't ask again until
447 it has been set to online.
448 However, this is commented out because it causes a hang now.
450 (modest_platform_connect_and_wait_if_network_account):
451 * src/modest-mail-operation.c:
452 (modest_mail_operation_update_account):
453 * src/modest-platform.h:
454 * src/modest-ui-actions.c: (_modest_ui_actions_open),
455 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
457 2007-07-12 Armin Burgmeier <armin@openismus.com>
459 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
461 * src/modest-mail-operation.c:
462 * src/modest-ui-actions.c: Check for already existing folder before
463 querying the server, show error message from camel if the request
464 still fails. This fixes projects.maemo.org bug NB#58701.
466 2007-07-12 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-tny-account-store.h:
469 * src/modest-tny-account-store.c:
470 Added modest_tny_account_store_forget_password_in_memory(),
471 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
472 when creating a new account, so that new passwords will be used, instead of
473 us thinking that it's a second request as a result of a failed password again.
475 2007-07-12 Murray Cumming <murrayc@murrayc.com>
477 * src/dbus_api/modest-dbus-callbacks.c:
478 (on_idle_open_message): If the message is in drafts then open it
479 in an edit window instead of a view window. This fixes
480 projects.maemo.org bug NB#63005.
482 2007-07-12 Murray Cumming <murrayc@murrayc.com>
484 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
485 Avoided a harmless g_warning().
487 2007-07-12 Murray Cumming <murrayc@murrayc.com>
489 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
490 Pass the modest account name, not the TnyAccount display name to
491 modest_msg_view_window_new() so that the reply feature works,
492 fixing projects.maemo.org bug NB#62892.
494 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
495 (modest_msg_view_window_new_with_header_model):
496 * src/maemo/modest-msg-view-window.c:
497 (modest_msg_view_window_new_with_header_model),
498 (modest_msg_view_window_new):
499 * src/modest-ui-actions.c: (reply_forward):
500 * src/widgets/modest-msg-view-window.h:
501 * src/widgets/modest-window.c: (modest_window_set_active_account):
502 Rename an account parameter to modest_account_name to make this clearer.
504 2007-07-11 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-ui-actions.h:
507 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
508 modest_do_message_delete().
509 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
510 Call modest_do_message_delete(), hoping that this would cause messages
511 to be really deleted from search instead of just marked with strike through.
512 Does not seem to help.
514 2007-07-11 Armin Burgmeier <armin@openismus.com>
516 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
517 priv->reselect to FALSE prior to calling
518 modest_folder_view_select_first_inbox_or_local() to prevent endless
519 recursion and thus a crash on startup.
521 2007-07-11 Armin Burgmeier <armin@openismus.com>
523 * src/maemo/modest-account-settings-dialog.h: Include
524 <gtk/gtknotebook.h> to fix the build (at least for me).
526 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
527 Use "New FolderN" as default suggested name if "New folder" already
528 exists, with N being the first free number, though never exceed "New
529 folder99" in which case we just fall back to "New Folder" even though
530 it already exists. This fixes projects.maemo.org bug NB#58663.
532 2007-07-11 Murray Cumming <murrayc@murrayc.com>
534 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
535 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
536 projects.maemo.org bug NB#62778.
538 2007-07-11 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
541 Ignore the wrong (for now) secure-smtp setting in the presets -
542 just default to requiring secure authentication for SMTP, because
545 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
547 * src/widgets/modest-folder-view.c: (filter_row)
548 Do not show drafts folder (see UI specs)
550 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
552 * src/modest-ui-actions.c:
553 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
554 place and also not necessary.
556 * src/widgets/modest-folder-view.c: (filter_row)
557 Guess folder type and hide Sent & Outbox if necessary.
558 Fixed project.maemo.org NB#57328
560 2007-07-11 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-ui-actions.h:
563 * src/modest-ui-actions.c:
564 (modest_ui_actions_on_delete_message):
565 Move some code into a new
566 modest_ui_actions_refresh_message_window_after_delete()
567 function so we can use it from elsewhere.
569 * src/dbus_api/modest-dbus-callbacks.c:
570 (on_idle_delete_message), (on_delete_message): Used an idle
571 handler, as we do for the other D-Bus method handlers.
572 Call modest_ui_actions_refresh_message_window_after_delete()
573 if the deleted message was open in a window. This fixed
574 projects.maemo.org bug NB#62862.
576 2007-07-11 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-main.c: (main): Only show the UI at the start if
579 the showui command line option was given. For instance,
580 run-standalone src/modest showui
581 Otherwise, we wait for the top_application D-Bus method to
582 be sent by hildon-desktop when the application is selected
584 This allows us to run without a UI when osso-global-search
585 uses our D-Bus methods.
587 2007-07-11 Murray Cumming <murrayc@murrayc.com>
589 * src/dbus_api/modest-dbus-api.h: Added a define for a
590 top-application D-Bus method.
591 * src/dbus_api/modest-dbus-callbacks.c:
592 (on_top_application),
593 (modest_dbus_req_handler): Handle the top-application D-Bus
594 method, which might be an undocumented D-Bus signal sent by
595 hildon-desktop when it starts the application from the menu.
596 But I am not sure and I need to test it on the device, because
597 my scratchbox does not have the application in the menu now.
598 This method shows the main window, so that it can be invisible
599 when started, for instance, just for email searching from
602 * src/maemo/modest-main-window.c: (restore_settings),
603 (modest_main_window_new): Do not show the window immediately
604 upon creation. We show it later.
605 * src/modest-widget-memory.c: (save_settings_paned):
606 Try (unsuccessfully) to avoid saving the paned position when
607 it is not even visible.
608 (restore_settings_paned): Do not allow a silly paned position.
609 This seems necessary when not showing the window at first.
611 * tests/dbus_api/Makefile.am:
612 * tests/dbus_api/test_top_application.c: (main): Test for the
615 2007-07-10 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-ui-dimming-rules.c:
618 (modest_ui_dimming_rules_on_new_msg),
619 (modest_ui_dimming_rules_on_reply_msg),
620 (modest_ui_dimming_rules_on_delete_msg),
621 (modest_ui_dimming_rules_on_details),
622 (modest_ui_dimming_rules_on_view_window_move_to),
623 (modest_ui_dimming_rules_on_view_previous),
624 (modest_ui_dimming_rules_on_view_next),
625 (_invalid_folder_for_purge): Added checks before
626 casting the window. This looks like an actual
627 logic error in _invalid_folder_for_purge(), because it
628 tries to use a ModestMainWindow as a message window.
630 2007-07-10 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/modest-account-settings-dialog.c:
633 (show_error): Use the same implementation as in
634 modest-easysetup-wizard.c:
635 (on_entry_invalid_character): The logical ID contains a %s.
636 Guessed what it should be.
637 (on_entry_max), (check_data), (on_response): Adapt to
638 changed show_error().
639 (create_page_account_details): Really call
640 modest_validating_entry_set_func() on the correct widgets.
641 * src/maemo/easysetup/modest-easysetup-wizard.c:
642 (on_entry_invalid_character): Fix the logical ID here too.
643 (create_page_account_details),
644 (create_page_user_details):
646 modest_validating_entry_set_func() on the correct widgets.
648 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
649 Do not try to use the account if it is NULL.
651 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
653 * src/modest-ui-actions.c: (create_move_to_dialog),
654 (modest_ui_actions_on_main_window_move_to),
655 (modest_ui_actions_on_msg_view_window_move_to):
656 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
657 (filter_row), (modest_folder_view_show_non_move_folders):
658 * src/widgets/modest-folder-view.h:
660 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
661 the Sent folder yet as it does not report the correct folder type.
663 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
665 * src/maemo/modest-msg-edit-window.c: (init_window):
668 2007-07-10 Murray Cumming <murrayc@murrayc.com>
670 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
671 Take a parent widget instead of a parent window, and
672 implement this with hildon_banner_show_information() instead.
673 Non-Maemo builds can just ifdef that there.
674 This fixed projects.maemo.org bug NB#62766.
676 (on_entry_invalid_character): Use show_error() again instead
677 of using hildon directly, and use the _CS() macro to use the correct
679 (create_account), (check_for_supported_auth_methods), (on_entry_max):
680 Pass a widget instead od a window to show_error().
682 2007-07-10 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
685 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
686 This allows us to show the server name in the error message, fixing
687 projects.maemo.org bug NB#62904.
688 Also, use the appropriate logical ID message for the account protocol.
690 2007-07-10 Murray Cumming <murrayc@murrayc.com>
692 * src/modest-tny-account-store.c: (on_idle_wrong_password):
693 A compilation fix, though the build wasn't broken for me.
695 2007-07-09 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
698 Do not try to unref a NULL folder store, to avoid a runtime warning.
699 This seems to happen sometimes when changing accounts settings.
701 2007-07-09 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-tny-account-store.c:
704 (modest_tny_account_store_instance_init),
705 (modest_tny_account_store_finalize),
706 (on_account_settings_hide), (on_idle_wrong_password):
707 Use a GHashTable to ensure that we only show one account settings
708 dialog per modest account. This avoids us having a dialog open for
709 both the store and transport accounts, or due to repeated get_password()
710 calls that shouldn't happen anyway.
712 2007-07-09 Murray Cumming <murrayc@murrayc.com>
714 * src/maemo/modest-maemo-utils.c: (on_hide),
715 (modest_maemo_show_dialog_and_forget): Handle the response, because
716 the window is not even hidden by default.
718 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
719 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
720 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
721 which seems to prevent some modality problems.
723 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
724 Ignore user cancellation errors.
726 * src/modest-account-mgr-helpers.h:
727 * src/modest-account-mgr-helpers.c:
728 Added modest_server_account_get_password() and
729 modest_server_account_get_has_password() to avoid direct use of
732 * src/maemo/modest-account-settings-dialog.h:
733 * src/maemo/modest-account-settings-dialog.c:
734 (modest_account_settings_dialog_init): Store the notebook so we can
736 Added modest_account_settings_dialog_switch_to_user_info().
738 * src/modest-tny-account-store.c:
739 (get_password): When the password in the account settings is wrong (we think),
740 show the relevant page of the account settings dialog, in the mainloop.
741 However, we currently get many of these at once because cancel does not
743 (forget_password): Do not forget the password
744 from the account settings, because this causes side-effects when
745 tinymail seems to call it at strange time, maybe because of how we
746 are cancelling get_password().
747 (modest_tny_account_store_alert): Ignore user cancellations.
749 2007-07-09 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-maemo-utils.h:
752 * src/maemo/modest-maemo-utils.c:
753 Added modest_maemo_show_information_note_and_forget() for use instead of
754 gtk_dialog_run() when the response is not needed, to avoid an extra
755 mainloop which could cause a hang.
757 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
758 Use the logical IDs for the error message, though they are not
759 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
760 because gtk_dialog_run() caused a hang here (the window did not close).
761 This fixes projects.maemo.org bug NB#62646.
763 2007-07-09 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-account-mgr-helpers.h:
766 * src/modest-account-mgr-helpers.c:
767 Added modest_account_mgr_get_store_protocol().
769 * src/maemo/modest-account-view-window.c:
770 (on_delete_button_clicked): Show different warning text depending on
771 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
772 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
775 2007-07-09 Murray Cumming <murrayc@murrayc.com>
777 * src/maemo/modest-msg-edit-window.c:
778 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
779 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
781 2007-07-07 Armin Burgmeier <armin@openismus.com>
783 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
784 ckdg_ib_maximum_characters_reached from correct package.
786 * src/modest-ui-actions.c: Show an error message when a folder could
787 not be created. Tinymail does not give us specific error codes about
788 what has gone wrong, so we assume that a folder with that name
789 already exists, though there might be other reasons.
791 2007-07-06 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
794 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
795 give a more exact error message that can be partly translated.
797 2007-07-05 Murray Cumming <murrayc@murrayc.com>
799 * src/maemo/modest-address-book.c:
800 (select_email_addrs_for_contact): Specify a default window size for the
801 select-email-address dialog, so that it is probably big enough for the
802 title. This should fix projects.maemo.org bug NB#62277.
804 2007-07-05 Murray Cumming <murrayc@murrayc.com>
806 * src/maemo/easysetup/modest-easysetup-wizard.c:
807 (create_page_complete_easysetup): Use
808 gtk_widget_set_size() request to ensure that the text wraps
811 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
813 * src/maemo/easysetup/modest-easysetup-wizard.c:
814 (on_entry_invalid_character), (create_page_account_details),
815 (create_page_user_details):
816 Use new API of ModestValidatingEntry. But for some reason the banner is
817 not shown. I will have to investigate that further.
819 * src/widgets/modest-validating-entry.c: (on_insert_text),
820 (modest_validating_entry_set_func):
821 * src/widgets/modest-validating-entry.h:
822 Added a new callback function to be able to react to prevented
823 characters whitespaces to e.g show a banner.
825 2007-07-05 Armin Burgmeier <armin@openismus.com>
827 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
828 notification of HildonNumberEditor instead of remembering the port
829 number. Thanks to Johannes for pointing this out.
831 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
833 * src/maemo/easysetup/modest-easysetup-wizard.c:
834 Check if there are any user changes before showing a confirmation
835 dialog (projects.maemo.org NB#60946)
837 2007-07-05 Armin Burgmeier <armin@openismus.com>
839 * src/maemo/modest-account-settings-dialog.c: Remember custom port
840 number at the beginning of the dialog and set the modified flag at the
841 end if the port number has changed. This is necessary because
842 HildonNumberEditor does not support notification when the value has
845 2007-07-05 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-ui-actions.c:
848 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
849 a connection before asking anything else. Correct the check for the destination
850 folder so that it succeeds when online.
851 This fixed projects.maemo.org bug NB#61645.
853 2007-07-05 Murray Cumming <murrayc@murrayc.com>
855 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
856 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
857 to fix projects.maemo.org bug NB#62439.
859 2007-07-05 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-tny-account.c: (on_connection_status_changed):
862 Really do not use tny_device_force_offline() here. See the previous comment.
864 2007-07-04 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-tny-account.c: (on_connection_status_changed):
867 Do not use tny_device_force_offline() when tinymail says that something
868 went wrong with the connection. It seems to report this unnecessarily.
870 2007-07-04 Murray Cumming <murrayc@murrayc.com>
872 * src/maemo/modest-connection-specific-smtp-window.c:
873 (modest_connection_specific_smtp_window_init):
874 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
875 does not seem to have any effect in osso 1.1 (though it works in
876 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
878 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
880 * src/maemo/modest-connection-specific-smtp-window.c:
881 Fix UI specification problems with projects.meamo.org NB#60479
883 2007-07-04 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
886 clue when this has failed, because the error dialog is not always shown
887 (at least in earlier version).
889 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
890 GError message, because the generic error dialog is not helpful.
892 'This message is not currently available (can't let a new connection go online)'
893 when trying to open an IMAP message.
895 (_modest_ui_actions_open): Offer a connection when some messages would
896 have to be downloaded and we are offline.
898 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
900 * src/widgets/modest-folder-view.c:
901 Don't check for MERGE type anymore as we use the correct type
903 NOTE: For the last two changes you need to update your tinymail copy
904 because of API changes!
906 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
908 * src/modest-tny-local-folders-account.c:
909 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
910 (see projects.maemo.org NB#61580)
912 2007-07-04 Murray Cumming <murrayc@murrayc.com>
914 * src/modest-tny-account.c: (on_connection_status_changed):
915 Commented out the call to modest_platform_connect_and_wait() because this
916 seems to always hang, and I would like to know if this is the only thing
917 that causes a hang when showing the connection dialog.
918 It is not very useful anyway.
920 2007-07-04 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-msg-view-window.c:
923 (modest_msg_view_window_select_next_message):
925 * src/modest-platform.h:
926 * src/maemo/modest-platform.c:
927 Added modest_platform_connect_and_wait(), which calls
928 tny_maemo_conic_device_connect() always in the main thread, by calling it
929 in an idle handler and waiting for the idle handler to run. It should be
930 in the main thread because it uses GTK+ UI code. It just returns TRUE
931 if the device is already online.
933 There is some nasty code to ensure that subsequent calls to
934 modest_platform_connect_and_wait() just wait for the first one to finish,
935 by checking repeatedly in another idle handler. This is necessary,
936 because other threads (or even the main thread, via another idle handler)
937 can call modest_platform_connect_and_wait() while
938 modest_platform_connect_and_wait() is running.
940 (modest_platform_connect_and_wait_if_network_account),
941 (modest_platform_connect_and_wait_if_network_folderstore):
942 Convenience functions that calls modest_platform_connect_and_wait() if
943 the account or folder might want network access.
945 * src/modest-mail-operation.c:
946 (modest_mail_operation_update_account):
947 * src/modest-ui-actions.c: (download_uncached_messages),
948 (modest_ui_actions_on_rename_folder), (delete_folder),
949 (modest_ui_actions_on_main_window_move_to),
950 (modest_ui_actions_on_msg_view_window_move_to):
951 * src/widgets/modest-folder-view.c:
952 (drag_and_drop_from_folder_view):
953 Offer a connection if we are offline.
955 * src/modest-tny-account.c: (on_connection_status_changed):
956 Document this as only handling errors during network operations in progress,
957 and replace the idle code with a simple call to
958 modest_platform_connect_and_wait(), which does this instead.
960 2007-07-03 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account.c:
963 (modest_tny_account_get_special_folder): (util_on_idle),
964 Handle the GError so we can see when tny_folder_store_get_folders()
965 fails, as it currently does while something else is connecting.
967 Added util_run_in_main_thread_and_wait()
968 which uses an idlen handler and mainloop to ensure that the function
969 is called in the main thread.
970 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
971 to make sure that we call attempt the connection in the mainloop only,
972 which might solve some hangs.
974 2007-07-03 Murray Cumming <murrayc@murrayc.com>
976 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
977 be found by their display name. This is never useful.
978 * src/modest-tny-account-store.c: (on_account_removed): Find the account
979 by its ID, instead of trying to use its ID as its display name.
981 * src/modest-tny-account-store.h:
982 * src/modest-tny-account.c:
983 (modest_tny_account_get_special_folder): Add a g_warning() when
984 tny_folder_store_get_folders() returns an empty list for the maildir.
986 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
987 Add a g_warning() when this returns NULL, because that it not allowed
990 2007-07-02 Armin Burgmeier <armin@openismus.com>
992 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
993 note when trying to cancel the wizard. This fixes projects.maemo.org
996 2007-07-02 Murray Cumming <murrayc@murrayc.com>
998 * src/modest-tny-account.h:
999 * src/modest-tny-account.c:
1000 (modest_tny_account_new_from_server_account),
1001 (modest_tny_account_new_from_server_account_name),
1002 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1003 because this must now be set before setting the proto. This is usd in
1004 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1005 warning in camel_session_get_service() caused by
1006 tny_camel_transport_account_prepare().
1008 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1011 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1013 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1015 (modest_connection_specific_smtp_edit_window_init):
1017 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1018 of "changed" for now
1020 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-tny-account.c:
1023 (modest_tny_account_new_from_server_account):
1024 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1025 now uses to request a connection when it needs one, and which it uses
1026 to tell us that something is wrong with the connection, so we can force
1027 the accounts offline to prevent further problems.
1029 * src/modest-defs.h:
1030 * src/modest-init.c: (init_default_settings):
1031 * src/modest-mail-operation.c:
1032 (modest_mail_operation_update_account):
1033 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1034 This should not be necessary anymore. Do not set the conf key that
1035 determined this (it was always TRUE and not set anywhere else).
1037 * src/modest-ui-actions.h: Remove unused and unimplemented
1038 modest_ui_actions_on_online_toggle_toggled().
1040 2007-06-29 Murray Cumming <murrayc@murrayc.com
1042 * src/maemo/modest-main-window.c: (connect_signals):
1043 Don't connect to delete_event twice. Maybe this was harmless.
1045 2007-06-29 Murray Cumming <murrayc@murrayc.com
1047 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1048 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1049 Debug output to give some more clue when a folder move is not allowed.
1051 2007-06-28 Murray Cumming <murrayc@murrayc.com
1053 * src/modest-tny-account.c: (on_modest_file_system_info),
1054 (modest_tny_account_get_mmc_account_name):
1055 Always call the callback, without checking whether the name has changed.
1056 * src/widgets/modest-folder-view.c: (strings_are_equal),
1057 (on_model_foreach_set_name), (on_get_mmc_account_name),
1058 (text_cell_data): Compare the name here, and use the name from
1059 the account rather than from the
1060 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1061 if the name was changed after the account was added to the model.
1062 That's a tinymail bug but not one that I want to fix now.
1064 This finally fixes projects.maemo.org bug NB#59301.
1066 2007-06-27 Armin Burgmeier <armin@openismus.com>
1068 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1071 2007-06-27 Murray Cumming <murrayc@murrayc.com
1073 * src/modest-tny-account.h:
1074 * src/modest-tny-account.c:
1075 Added modest_tny_account_get_mmc_account_name(), to set the memory
1076 card name asynchronously for the given account and then notify.
1077 (modest_tny_account_new_for_local_folders): Use this new function instead
1078 of using hildon_file_system_info_async_new() directly.
1080 * src/widgets/modest-folder-view.c: (text_cell_data):
1081 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1082 gtk_tree_model_row_changed() when it is available.
1084 This should fix projects.maemo.org bug NB#59301.
1086 2007-06-27 Murray Cumming <murrayc@murrayc.com
1088 * src/modest-mail-operation.c: (update_account_thread),
1089 (get_msgs_full_thread): Fix typo failures in the revert
1092 2007-06-27 Murray Cumming <murrayc@murrayc.com
1094 * src/maemo/modest-maemo-global-settings-dialog.c:
1095 (idle_select_default_focus):
1096 * src/modest-mail-operation.c: (idle_notify_progress),
1097 (idle_notify_progress_once), (set_last_updated_idle),
1098 (update_account_thread), (get_msgs_full_thread):
1099 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1100 * src/widgets/modest-header-view.c:
1101 (idle_notify_headers_count_changed_destroy),
1102 (idle_notify_headers_count_changed):
1103 Reverted the additions of gdk_threads_enter/leave(), in case this
1104 helps with a startup hang on the device.
1106 2007-06-26 Armin Burgmeier <armin@openismus.com>
1108 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1109 for supported secure authentication methods from server by
1110 gtk_dialog_run(), saving CPU time and a potential race condition.
1112 2007-06-26 Armin Burgmeier <armin@openismus.com>
1114 * src/maemo/modest-maemo-utils.h:
1115 * src/maemo/modest-maemo-utils.c: Added a
1116 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1117 only error code to tell the calling code when the user canceled the
1120 * src/maemo/modest-account-settings-dialog.h:
1121 * src/maemo/modest-account-settings-dialog.c:
1122 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1123 message if the retrieval of secure authentication methods was canceled
1124 by the user. Perform the check before saving anything to configuration
1125 to not end up with half-committed configuration changes, do not show
1126 a "Saving to configuration failed" note when authentication methods
1127 could not be retrieved.
1129 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1132 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1134 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1135 Only return the first level of folders under accounts, because the
1136 osso-global-search UI spec doesn't want the rest.
1137 This fixed projects.maemo.org bug NB#61811.
1139 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-tny-account-store.c:
1142 * src/modest-tny-account-store.h:
1143 Added modest_tny_account_is_memory_card_account().
1144 * src/maemo/modest-main-window.c: (create_details_widget):
1145 Show the same information items for the memory card as we show for the
1146 local-folders, to fix projects.maemo.org bug NB#59307.
1148 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1150 * src/modest-tny-account-store.c: (get_password):
1151 Added some checks for NULL to maybe prevent crashes, though I think
1152 it was Philip's last commit that actually prevented the crash here
1153 when creating a first new account.
1154 But the new account is still not usable (no messages are shown)
1155 until a restart of the application.
1157 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1159 * src/maemo/modest-maemo-global-settings-dialog.c:
1160 (idle_select_default_focus):
1161 * src/modest-mail-operation.c: (idle_notify_progress),
1162 (idle_notify_progress_once), (idle_notify_update_account_queue),
1163 (set_last_updated_idle), (update_account_thread),
1164 (notify_get_msgs_full), (get_msgs_full_destroyer),
1165 (get_msgs_full_thread):
1166 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1167 * src/widgets/modest-header-view.c:
1168 (idle_notify_headers_count_changed_destroy),
1169 (idle_notify_headers_count_changed):
1170 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1171 all idle handlers, because some other thread could be blocking
1172 the GDK lock, so that it can do GUI stuff.
1174 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1176 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1177 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1178 (on_idle_send_receive), (on_idle_open_default_inbox):
1179 * src/maemo/modest-msg-edit-window.c:
1180 (modest_msg_edit_window_attach_file_noninteractive):
1181 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1182 to prevent a hang. I don't quite understand why these are necessary,
1183 beause we should already be in the main loop. I guess something outside
1184 of the main loop is taking the lock.
1186 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1187 we are really using URIs, and use files that are more likely to exist.
1189 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1191 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1192 necessary because configure.ac now defines different variables.
1194 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1196 * libmodest-dbus-client/libmodest-dbus-client.c:
1197 * libmodest-dbus-client/libmodest-dbus-client.h:
1198 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1199 libmodest_dbus_client_compose_mail() is what things actually use.
1201 * src/dbus_api/modest-dbus-api.h:
1202 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1203 * tests/dbus_api/Makefile.am:
1204 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1207 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-init.c: (modest_init_local_folders):
1210 For memory-card (or other non local-folders) maildir accounts,
1211 always create an Archive folder, so that there is somewhere to put
1212 messages. This should be less confusing, because the user does not need
1213 to guess that the need to create a folder.
1215 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1217 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1218 Fixed icon size by using (50, 50) which is the same as defined by
1221 2007-06-25 Armin Burgmeier <armin@openismus.com>
1223 * src/widgets/modest-window-mgr.c:
1224 * src/modest-init.c:
1225 * configure.ac: Correctly recognize hildon-notify presence and fixed
1226 the build without it being installed.
1228 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1230 * libmodest-dbus-client/libmodest-dbus-client.c:
1231 (libmodest_dbus_client_search): Fix the build. Sorry.
1232 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1233 (reply_forward_cb): Initialize variables to fix the build.
1235 * src/modest-tny-account-store.c:
1236 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1237 comparison (a silly typo) so that email search results can be opened
1238 when there are more than one account.
1240 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1242 * libmodest-dbus-client/libmodest-dbus-client.c:
1243 (libmodest_dbus_client_search),
1244 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1245 instead of 1 second, because the search gets folders and messages from
1246 the server, which can take a long time. When it times out,
1247 osso-global-search will report no results.
1249 We need to specify whether we should search only cached information
1250 (maybe with a user preference), and the osso-email-search-plugin
1251 API should really be improved to allow that option, and to allow results
1252 to be delivered asynchronously in batches.
1254 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1256 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1257 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1258 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1260 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1263 that is an empty string. D-Bus seems to give us these instead of NULL.
1265 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1267 * src/dbus_api/modest-dbus-callbacks.c:
1268 * src/maemo/easysetup/modest-easysetup-wizard.h:
1269 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1271 (modest_connection_specific_smtp_edit_window_init):
1272 * src/maemo/modest-maemo-global-settings-dialog.c:
1274 * src/maemo/modest-maemo-utils.c:
1275 (modest_maemo_utils_setup_images_filechooser):
1276 * src/maemo/modest-main-window.c: (create_details_widget):
1277 * src/maemo/modest-msg-edit-window.c:
1278 (modest_msg_edit_window_attach_file_noninteractive),
1279 (modest_msg_edit_window_color_button_change),
1280 (modest_msg_edit_window_set_zoom):
1281 * src/modest-mail-operation.c: (update_account_thread):
1282 * src/modest-tny-account-store.c:
1283 * src/modest-tny-account.c:
1284 * src/widgets/modest-global-settings-dialog.c:
1285 * src/widgets/modest-window.h:
1287 Fixed build on bora!
1289 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1291 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1292 * src/modest-search.c: (modest_search_folder),
1293 (modest_search_all_accounts): Actually search only in the specified folder,
1294 doing a simple match on the folder ID.
1295 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1296 and added some documentation.
1298 2007-06-22 Armin Burgmeier <armin@openismus.com>
1300 * src/maemo/modest-maemo-utils.h:
1301 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1302 modest_maemo_utils_get_supported_secure_authentication_methods.
1304 * src/maemo/easysetup/modest-easysetup-wizard.c:
1305 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1306 one occured, not just "Server does not support secure authentication".
1308 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1310 * src/modest-tny-account-store.c: (get_password):
1311 Restored the call to tny_account_set_user() because Philip seems to have
1312 stopped this from crashing (by not using the freed string). It still does
1313 not work, but now we can test it.
1315 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1317 * src/maemo/modest-msg-edit-window.c: (init_window):
1318 Comment out use of an uninitialzed GtkScrolledWindow variable,
1319 to fix the build and stop a crash. Yet again.
1321 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-tny-account-store.c: (get_password):
1324 Remove the call to tny_account_set_user() because this actually crashes.
1325 As mentioned in the last commit, it is known to not work anyway.
1327 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-tny-account-store.c: (get_password):
1330 Use tny_account_set_username() to tell tinymail that the username might
1331 have changed too. But tinymail ignores this: see projects.maemo.org
1333 * src/modest-ui-actions.c:
1334 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1335 reset the connection when changing the username, and improve the comments.
1336 Save the changed username to gconf at least, so it is used when Modest is
1339 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1341 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1342 Do not use a query, so that we get all folders, including for POP and
1343 local-folders. They work as search criteria too.
1344 This fixes projects.maemo.org bug NB#57740.
1346 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1349 Comment out the use of hildon_notification_set_sound() because it is
1350 not declared, to fix the build. Warnings are serious, people.
1352 2007-06-21 Armin Burgmeier <armin@openismus.com>
1354 * src/maemo/modest-maemo-utils.h:
1355 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1356 modest_maemo_utils_get_supported_secure_authentication_methods()
1357 to query authentication methods for a specific user. This should fix
1358 projects.maemo.org bug NB#61369.
1360 * src/maemo/easysetup/modest-easysetup-wizard.c:
1361 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1364 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1366 * libmodest-dbus-client/libmodest-dbus-client.h:
1367 * libmodest-dbus-client/libmodest-dbus-client.c:
1368 (modest_dbus_message_iter_get_search_hit),
1369 (libmodest_dbus_client_search):
1370 Reorganised and commented this.
1371 Removed modest_search_hit_free() from the public API because it
1374 Added libmodest_dbus_client_get_folders() and
1375 modest_folder_result_list_free().
1377 * src/dbus_api/modest-dbus-api.h:
1378 * src/dbus_api/modest-dbus-callbacks.c:
1379 (modest_dbus_req_filter): Commented. Moved most code to
1380 on_dbus_method_search() and added on_dbus_method_get_folders().
1382 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1383 of the extra D-Bus handler.
1385 * tests/dbus_api/Makefile.am:
1386 * tests/dbus_api/test_get_folders.c: New test for
1387 libmodest_dbus_client_get_folders(). This seems to return an empty list
1388 at the moment. That could be the same error that causes the message list
1389 to be empty sometimes.
1390 This should help with projects.maemo.org bug NB#57740.
1392 2007-06-21 Armin Burgmeier <armin@openismus.com>
1394 * src/modest-mail-operation.c: Do not call
1395 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1396 notify the operation's end after having set the status to CANCELED for
1397 the operation queue to listen on. This fixes a deadlock when there
1398 were mail operations in the queue during its finalization.
1400 * src/modest-singletons.c: Reordered uninitialization of the account
1401 manager to happen after the mail operation queue was uninitialized
1402 because the mail operation's in the queue might still try to access
1403 the account manager (see modest_mail_operation_notify_end()). This
1404 fixes a potential crash when terminating the application.
1406 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-search.c:
1409 (search_mime_part_and_child_parts): Moved some code here so we
1410 can search recursively in child folders.
1411 (modest_search_folder): Search in the message as a mime part, instead
1412 of just its child mime parts.
1413 (read_chunk), (search_mime_part_ogs):
1414 Check how many bytes were read, to prevent an endless loop.
1415 Searching in message bodies now works. This finishes the fix for
1416 projects.maemo.org bug NB#61007.
1418 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1420 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1421 Add a g_warning when the item is not a folder.
1423 * src/modest-ui-dimming-rules.c:
1424 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1425 when selected item is not a folder (for instance, an account), because
1426 the UI spec only talks about folders.
1427 I am not sure what the UI spec wants, so this might not totally fix
1428 projects.maemo.org bug NB#60794.
1430 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1432 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1433 (load_from_file): Sort the list. The unsorted list would be more noticeable
1434 in non-English locales.
1436 * src/maemo/modest-msg-edit-window.c:
1437 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1438 warning and fix the build.
1440 * src/maemo/modest-progress-bar-widget.c:
1441 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1442 avoid a g_warning, and probably to avoid a crash.
1444 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1446 * src/modest-search.c: (modest_search_folder): Check for a GError
1447 when calling tny_folder_get_headers(), to show that this is not the cause
1450 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1452 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1453 Actually set the body query instead of the subject query.
1455 * src/modest-search.c: (search_mime_part_ogs),
1456 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1457 which would probably cause it to fail if we got this far.
1459 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1460 to simplify the code.
1461 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1462 be causing search-in-body to fail.
1464 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1466 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1468 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1469 Better debug message when the folder cannot be found.
1470 This should help with fixing projects.maemo.org bug #61287.
1471 * src/modest-search.c: (add_hit): Do not leak the furl string.
1473 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-ui-actions.c:
1476 (modest_ui_actions_on_folder_selection_changed):
1477 Do not special-case TNY_MERGE_FOLDER here, because
1478 modest_tny_folder_get_account() already does that. This fixes
1479 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1480 shown when the Outbox was selected).
1482 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1484 * libmodest-dbus-client/libmodest-dbus-client.c:
1485 (_dbus_iter_get_string_or_null): Initialize the string variable in
1486 case this helps with Dirk's crash.
1488 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1490 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1491 though it is not implemented yet (this function is maybe not even used),
1492 to avoid breaking ABI in future.
1493 * libmodest-dbus-client/libmodest-dbus-client.c:
1494 (get_attachments_string): Moved some code into this generic function.
1495 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1496 sends email. It is maybe not used.
1497 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1498 (on_send_mail): Use attachments.
1500 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1501 * src/maemo/modest-msg-edit-window.c:
1502 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1503 a filename before using it, to fix projects.maemo.org bug NB#58233.
1505 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1508 Initialize the continue_download variable to fix the build, and probably
1509 to fix randome behaviour.
1511 2007-06-18 Armin Burgmeier <armin@openismus.com>
1513 * src/modest-tny-send-queue.h:
1514 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1515 the queue so we can later show it in the UI. Replaced
1516 modest_tny_send_queue_msg_is_being_sent() by
1517 modest_tny_send_queue_get_msg_status().
1519 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1521 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1522 gpointer. This probably was not harmful, but just to be sure.
1524 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1527 Fix the build, but leave the function broken on Bora, because
1528 hildon_uri_action_get_service() does not exist.
1529 osso_uri_action_get_service() does not exist either, it seems.
1531 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-tny-account.c:
1534 (modest_tny_account_new_from_server_account):
1535 Uncommented the url debug output again, because it is useful for
1536 debugging, as I said in the comment.
1538 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1540 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1542 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1543 for Mameo Bora, to fix the build.
1545 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1548 Fixed build with hildon < 0.99
1550 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1551 Check if the selected account is busy instead of checking all accounts
1553 * src/modest-account-mgr-priv.h:
1554 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1555 (modest_account_mgr_init), (compare_account_name),
1556 (modest_account_mgr_set_account_busy),
1557 (modest_account_mgr_account_is_busy):
1558 * src/modest-account-mgr.h:
1559 Added busy information to the account manager. It possible to
1560 set an account to busy or not busy now.
1562 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1563 (modest_mail_operation_update_account),
1564 (modest_mail_operation_notify_end):
1565 Set the account to busy/not busy depending on the operation state.
1567 * src/widgets/modest-account-view.c:
1568 (modest_account_view_finalize), (get_last_updated_string),
1569 (update_account_view), (on_account_busy_changed), (init_view):
1570 Show string "Refreshing..." if the account is currently busy.
1572 All this fixes projects.maemo.org bug NB#59711
1574 2007-06-14 Armin Burgmeier <armin@openismus.com>
1576 * src/widgets/modest-attachments-view.h:
1577 * src/widgets/modest-attachments-view.c: Added
1578 modest_attachments_view_has_attachments() and fixed coordinate
1579 transformation in get_att_view_at_coords(). This fixes attachment
1582 * src/widgets/modest-msg-view.c: Make use of
1583 modest_attachments_view_has_attachments() to decide whether to show
1584 attachments in the header.
1586 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1588 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1589 (on_change), (on_combo_security_changed),
1590 (modest_connection_specific_smtp_edit_window_init),
1591 (modest_connection_specific_smtp_edit_window_set_connection),
1592 (modest_connection_specific_smtp_edit_window_is_dirty):
1593 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1594 * src/maemo/modest-connection-specific-smtp-window.c:
1597 Show an comfirmation dialog for the smpt-edit-window if there are
1598 unsaved changes and the user hits cancel.
1599 (projects.maemo.org bug NB#60479)
1601 2007-06-14 Armin Burgmeier <armin@openismus.com>
1603 * src/maemo/easysetup/modest-easysetup-wizard.c:
1604 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1605 address" info in banner instead of node, and select all the text as
1606 per UI spec. This fixes projects.maemo.org bug NB#60550.
1608 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1610 reviewed by: <delete if not using a buddy>
1612 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1613 * src/modest-ui-actions.c: (folder_refreshed_cb):
1615 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1617 * src/widgets/modest-folder-view.c: (filter_row):
1618 Explictly filter out the per-account outbox accounts. I don't know why
1619 these only sometimes show up, but now they should never show up in the UI.
1620 This should fix projects.maemo.org bug NB#60160.
1622 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1625 when the toolbar does not exist yet.
1626 * src/modest-widget-memory.c: (save_settings_header_view):
1627 Added g_warnings() to help us to discover when we are trying to set
1628 an empty columns list in gconf.
1630 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1632 * src/modest-init.h:
1633 * src/modest-init.c:
1634 Added modest_init_get_default_header_view_column_ids().
1636 * src/modest-widget-memory.c: (restore_settings_header_view):
1637 Use the new function to get defaults, if the gconf key is empty,
1638 instead of not creating any columns. This seems to fix the
1639 empty right-hand pane problems.
1641 * src/widgets/modest-header-view.h: Improved documentation.
1643 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1646 Revert the use of the display name as the account name, because this
1647 is generally wrong and would break the code that follows.
1649 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1651 * src/maemo/easysetup/modest-easysetup-wizard.c:
1652 (check_for_supported_auth_methods), (on_before_next),
1655 More correct fix for projects.maemo.org bug NB# 58991
1656 Do not longer accept AUTH_PASSWORD as secure method and choose
1657 correct method when creating the account.
1659 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1661 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1662 Fixed projects.maemo.org bug NB# 58991
1664 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-init.c: (modest_init_init_core),
1667 (modest_init_local_folders): Fixed compilation errors.
1669 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1671 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1672 Remove unnecessary lib/include, though it is good in principle when needed.
1674 * src/modest-init.c: (modest_init_one_local_folder),
1675 (modest_init_local_folders):
1676 * src/modest-init.h: Initialize the .modest library for memory cards,
1677 instead of just doing nothing for them. This should allow us to create
1678 folders there, fixing projects.maemo.org bug NB#59297.
1680 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1682 * libmodest-dbus-client/libmodest-dbus-client.c:
1683 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1684 (libmodest_dbus_client_compose_mail),
1685 (libmodest_dbus_client_open_message),
1686 (libmodest_dbus_client_send_and_receive),
1687 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1689 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1690 (on_idle_open_message), (modest_dbus_req_handler),
1691 (search_result_to_message), (modest_dbus_req_filter):
1692 * src/modest-search.c: (add_hit), (modest_search_folder),
1693 (modest_search_all_accounts): Improved debug messages.
1695 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1697 * src/modest-tny-account-store.c:
1698 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1701 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1704 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1706 * src/modest-tny-account-store.c: (get_server_accounts):
1707 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1708 even when there are no accounts, so that the Outbox folder is always
1709 visible. This fixes projects.maemo.org bug NB#60158.
1711 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/modest-main-window.c: (create_details_widget):
1714 Use the mcen_va_never logical ID.
1716 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1718 * src/dbus_api/modest-dbus-api.h:
1719 * src/dbus_api/modest-dbus-callbacks.c:
1720 (on_idle_open_default_inbox), (on_open_default_inbox),
1721 (modest_dbus_req_handler):
1722 Added a new OpenDefaultInbox method.
1724 * libmodest-dbus-client/libmodest-dbus-client.h:
1725 * libmodest-dbus-client/libmodest-dbus-client.c:
1726 Added libmodest_dbus_client_open_default_inbox() to call the new
1727 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1728 though it should maybe be used by a new osso-email-interface function.
1730 * tests/dbus_api/Makefile.am:
1731 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1734 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1736 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1737 NULL, so that the signals get all the keys. This should not actually
1738 change any behaviour because we currently update everything when anything
1741 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1743 * src/widgets/modest-folder-view.c: (text_cell_data),
1744 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1745 (find_inbox_iter): If tinymail tells us that the folder is
1746 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1747 This causes the inbox to be selected at startup, fixing part of
1748 projects.maemo.org bug NB#56305.
1750 * src/modest-ui-dimming-rules.c:
1751 (modest_ui_dimming_rules_on_tools_smtp_servers):
1752 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1753 the SMTP servers menu item.
1754 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1755 that the SMTP Servers menu item is dimmed when there are no accounts,
1756 as a future version of the UI spec will require. This fixes
1757 projects.maemo.org bug NB#56305.
1759 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1761 * src/maemo/modest-maemo-utils.c:
1762 (modest_maemo_utils_get_supported_secure_authentication_methods):
1763 Added label to dialog instead of unreadable title
1765 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1766 (modest_main_window_new):
1767 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1770 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1771 * src/modest-account-mgr.h:
1772 Added method to avoid code duplication
1774 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1775 (modest_ui_actions_on_send_receive):
1776 Use modest_account_mgr_has_accounts
1778 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1780 * src/maemo/easysetup/modest-presets.c:
1781 (modest_presets_get_info_server_security): Do not report secure auth
1783 * src/modest-protocol-info.c: Use the defines for the gconf key names
1784 for secure authentication. This was not working because we were writing
1785 Password and reading password, and the check was case sensitive.
1786 With this, gmail now works for receiving and sending when created via
1789 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1791 * src/maemo/easysetup/modest-presets.c:
1792 (modest_presets_get_info_server_security): Correct the key name for
1793 SecureSmtp, because it seems to be case-sensitive.
1794 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1795 Do not try to get the 0th notebook page if there are 0 pages, to
1796 avoid a g_warning().
1798 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1800 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1801 Prevent use of the new notification feature for now, because it currently
1802 shows one dialog for each new email, which is annoying.
1804 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1806 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1807 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1808 when no country was selected, so that we show the global ones.
1809 * src/maemo/easysetup/modest-presets.c:
1810 (modest_presets_get_providers): Return only the global providers, not
1811 all providers when mmc=0 was requested.
1813 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1816 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1817 provider ID in the combo.
1819 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1820 Do not show the page numbers, because it would be confusing when we add
1821 the 2 extra pages for the custom setup, when the user chooses the "Other"
1822 provider. This fixes projects.maemo.org bug NB#59028
1824 * src/modest-init.c: (modest_init_init_core),
1825 (modest_init_local_folders):
1826 * src/modest-init.h:
1827 * src/modest-tny-account.c:
1828 (modest_tny_account_new_for_local_folders): Do not create default folders
1829 for the memory card. This should fix projects.maemo.org bug NB#59328.
1831 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1833 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1834 Free the changed_conf_keys string items. They are already freed in the
1835 idle handler if that runs first.
1837 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-ui-actions.c:
1840 (modest_ui_actions_on_password_requested): Check that the server name
1841 is not NULL, because I just saw a password dialog with (null) as the
1844 * src/modest-tny-folder.[h|c]: Added
1845 modest_tny_folder_is_memory_card_folder().
1846 * src/modest-ui-dimming-rules.c:
1847 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1848 menu item for memory cards, as per the UI spec (section 7.4). This should
1849 fix projects.maemo.org bug NB#59297.
1851 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1853 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1854 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1855 is another problem with the code, see Murray's comment at line 772)
1857 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1860 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1861 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1862 (load_from_file), (easysetup_country_combo_box_init),
1863 (easysetup_country_combo_box_get_active_country_ids),
1864 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1865 instead of just one ID, to avoid duplicate country names in the UI.
1867 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1868 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1869 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1870 a single ID, avoiding duplicate providers.
1871 * src/maemo/easysetup/modest-easysetup-wizard.c:
1872 (on_combo_account_country): Adapt to use a list.
1874 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1876 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1877 keys changed in the last X seconds.
1879 * src/modest-account-mgr.h:
1880 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1881 (on_key_change), (modest_account_mgr_class_init),
1882 (modest_account_mgr_init), (modest_account_mgr_finalize):
1883 As the keys are changed, save them in a GSList* and signal that GSList*
1884 further every X seconds, to batch changes, to allow us to do just one
1885 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1886 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1888 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1889 changed signal signature.
1891 * src/modest-conf.c: (modest_conf_set_list),
1892 (modest_conf_on_change): Reenable notification.
1894 (modest_conf_maemo_fake_on_change): Comment out the hack that
1895 notified immediately instead of asynchronously.
1897 * src/widgets/modest-account-view.h:
1898 * src/widgets/modest-account-view.c:
1899 (update_account_view): Select the previously-selected account ID,
1900 if possible. This fixes projects.maemo.org bug NB#56933.
1902 (on_account_changed), (on_account_removed),
1903 (modest_account_view_select_account):
1905 Remove the block/unblock functions
1906 because they were not useful.
1908 * src/maemo/modest-account-view-window.c:
1909 (on_delete_button_clicked), (on_edit_button_clicked),
1910 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1912 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1914 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1915 Improve the error dialog to show Incorrect Account Settings, which seems
1916 clearer, and say that the internal error message (to be removed from the
1917 dialog later) is often misleading.
1918 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1920 * src/modest-tny-account.c:
1921 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1922 URL because this is so useful for debugging on the device.
1924 * src/widgets/modest-serversecurity-combo-box.c:
1925 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1927 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-mail-operation.c:
1930 (modest_mail_operation_send_new_mail):
1931 Added a comment about a nasty but apparently harmless message. Details
1932 added to the wiki g_warnings() page.
1934 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1937 (modest_tny_send_queue_class_init):
1938 Do not use the priv struct because it is empty, to avoid g_warnings
1939 about a non-existant priv struct.
1941 * src/modest-tny-account-store.c:
1942 (modest_tny_account_store_get_server_account),
1943 (modest_tny_account_store_get_transport_account_for_open_connection
1944 ): Do not try to get transport server accounts for local folders,
1945 because they don't have any. This avoids a g_warning().
1947 * src/maemo/modest-main-window.c:
1948 (modest_main_window_notify_send_receive_initied),
1949 (on_configuration_key_changed):
1950 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1951 * src/modest-defs.h:
1952 * src/modest-mail-operation.c:
1953 (modest_mail_operation_update_account):
1954 * src/modest-tny-account-store.h:
1955 * src/modest-tny-account.c:
1956 (modest_tny_account_get_special_folder),
1957 (modest_tny_account_new_for_local_folders),
1958 (modest_tny_account_new_for_per_account_local_outbox_folder):
1959 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1960 * src/modest-tny-local-folders-account.c:
1961 (add_account_folders_to_merged_folder):
1962 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1963 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1964 (modest_ui_actions_on_send):
1965 * src/widgets/modest-folder-view.c: (update_model):
1966 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1967 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1968 modest_tny_account_store_get_tny_account_by_account() to
1969 modest_tny_account_store_get_server_account() to make the code clearer.
1971 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1973 * src/dbus_api/modest-dbus-api.h:
1974 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1975 * src/maemo/modest-msg-edit-window.c:
1976 (modest_msg_edit_window_attach_file_noninteractive):
1977 added g_warning in case the file to be attached does not exist
1978 * tests/dbus_api/test_compose_mail.c: (main):
1979 removed obsolete comment, added generic files as test case
1981 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-tny-account-store.c: (get_server_accounts):
1984 Create the local folders account only once, not once for each outbox, and
1985 not only when there are some outboxes.
1987 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1989 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1990 code that is causing a crash at startup. Sergio says that he is fixing this.
1992 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1994 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1995 * src/maemo/modest-account-settings-dialog.c:
1996 (create_page_outgoing),
1997 (modest_account_settings_dialog_set_account_name),
1998 (save_configuration):
1999 - Fixed handling of the "Use secure authentication" toggle to comply with
2000 the ui specification. See also projects.maemo.org bug NB#58400
2002 - Restore the Secure connection setting combo correctly when loading
2005 * src/maemo/modest-maemo-utils.c:
2006 (on_camel_account_get_supported_secure_authentication),
2007 (modest_maemo_utils_get_supported_secure_authentication_methods):
2008 Fixed a crasher if operation is canceled
2010 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2011 (modest_protocol_info_auth_is_secure):
2012 * src/modest-protocol-info.h:
2014 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2015 the sense of the "Use secure authentication" toggle.
2017 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2019 * src/modest-tny-account-store.h:
2020 * src/modest-tny-account-store.c:
2021 Added modest_tny_account_store_get_local_folders_account().
2023 * src/modest-tny-folder.h:
2024 * src/modest-tny-folder.c:
2025 (modest_tny_folder_get_account):
2026 Added this replacement for tny_folder_get_account() which returns
2027 the local-folders account for TnyMergeFolders, to avoid the
2028 warning about the unimplemented get_account_func() vfunc().
2030 (modest_tny_folder_get_rules),
2031 * src/modest-ui-actions.c:
2032 (modest_ui_actions_on_folder_selection_changed):
2033 * src/modest-mail-operation.c:
2034 (modest_mail_operation_remove_folder),
2035 (modest_mail_operation_xfer_folder),
2036 (modest_mail_operation_rename_folder),
2037 (modest_mail_operation_get_msg),
2038 (modest_mail_operation_get_msgs_full),
2039 (modest_mail_operation_remove_msg),
2040 (modest_mail_operation_xfer_msgs),
2041 (modest_mail_operation_refresh_folder):
2042 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2044 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2046 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2047 (modest_server_account_set_security):
2048 * src/modest-defs.h: Add comments explaining that our
2049 UI spec means TLS when it says Normal, so these do not look like errors.
2051 * src/modest-tny-account.c:
2052 (modest_tny_account_new_from_server_account): Use the new tinymail
2053 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2054 for TLS. This should fix projects.maemo.org bug NB#58460.
2056 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/easysetup/modest-easysetup-wizard.c:
2059 (create_account): Correct the position of the gconf sanity check warning.
2060 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2061 of using the g_idle_add() hack, because this does not seem to be necessary
2062 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2063 caused by something other than maemo's gconf.
2064 This fixes projects.maemo.org bug #59022.
2066 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-account-mgr-helpers.c:
2069 (modest_account_mgr_get_default_account): Do not check that the account
2070 exists if there is no default account (NULL), to fix a runtime warning.
2072 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2074 * src/widgets/modest-folder-view.c: (update_model):
2075 Do not unref the treemodel before we have finished with it.
2076 This prevents a valgrind warning and an occasional crash at startup.
2078 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2080 * libmodest-dbus-client/libmodest-dbus-client.h:
2081 added libmodest_dbus_client_compose_mail()
2082 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2084 added functions needed for SendAsMail() functionality
2085 * src/maemo/modest-msg-edit-window.c:
2086 (modest_msg_edit_window_attach_file_noninteractive):
2087 non interactively attaching files to message edit window
2088 * src/widgets/modest-msg-edit-window.h:
2089 * tests/dbus_api/Makefile.am:
2090 added test_compose_mail.c
2091 * tests/dbus_api/test_compose_mail.c: (main):
2093 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2095 * src/modest-account-view.c:
2096 Fixed bug projects.maemo.org bug NB#59307
2098 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2100 * src/maemo/easysetup/modest-easysetup-wizard.c:
2101 (get_serverport_incoming), (on_before_next), (create_account):
2102 * src/maemo/modest-account-settings-dialog.c:
2103 (modest_account_settings_dialog_set_account_name):
2104 * src/maemo/modest-maemo-utils.c:
2105 (on_camel_account_get_supported_secure_authentication_status),
2106 (on_camel_account_get_supported_secure_authentication),
2107 (on_secure_auth_cancel),
2108 (modest_maemo_utils_get_supported_secure_authentication_methods):
2110 Implemented security authentication for settings and easysetup.
2112 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-main-window.c: (create_details_widget):
2115 Show the total size for memory card accounts too, instead of showing
2116 the name again. Fixes bug projects.maemo.org bug NB#59307.
2118 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2121 * src/modest-tny-simple-folder-store.c:
2122 * src/modest-tny-simple-folder-store.h: Removed.
2124 * src/modest-tny-local-folders-account.h
2125 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2126 for the local-folders maildir, with an extra TnyMergedFolder containing
2127 the folders of the per-account outbox store accounts.
2128 * src/modest-tny-account-store.c: (get_server_accounts):
2129 Add the outboxes to the special local folders account after creating it.
2131 * src/modest-tny-account.c:
2132 (modest_tny_account_new_for_local_folders): Create the derived
2133 account when creating the main local-folders account.
2135 * src/maemo/modest-main-window.c: (create_details_widget),
2136 (modest_main_window_set_contents_style):
2137 Adapted to the use of the derived account instead of the folder store.
2139 * src/modest-ui-actions.c:
2140 (modest_ui_actions_on_folder_selection_changed):
2141 * src/modest-ui-dimming-rules.c:
2142 (modest_ui_dimming_rules_on_new_folder):
2143 * src/widgets/modest-folder-view.c: (text_cell_data),
2144 (icon_cell_data), (filter_row), (update_model),
2145 (get_cmp_rows_type_pos):
2148 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2149 Do not get the priv struct, because no priv struct has been set,
2150 to avoid a runtime warning.
2152 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2153 #ifelse with #else, to fix a warning, to fix the build.
2156 2007-06-05 Christian Kellner <ckellner@openismus.com>
2158 * libmodest-dbus-client/libmodest-dbus-client.c:
2159 Fix small typo in doc (why do you always see them
2160 AFTER committing stuff?)
2163 2007-06-05 Christian Kellner <ckellner@openismus.com>
2165 * libmodest-dbus-client/libmodest-dbus-client.c:
2166 (libmodest_dbus_client_search):
2167 Initialize hit list with NULL. Also set folder list
2168 to "" if NULL was supplied.
2171 2007-06-03 Christian Kellner <ckellner@openismus.com>
2173 * libmodest-dbus-client/libmodest-dbus-client.c:
2174 (modest_search_hit_list_free):
2175 Make it save to call it with NULL.
2177 * src/dbus_api/modest-dbus-callbacks.c:
2178 * src/modest-search.c:
2179 Return full ModestSearchHits as the search result list not TnyHeader
2180 since can't be around withouth the correspoding TnyFolder.
2182 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2184 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2185 Added currently commented code to check for secure auth
2187 * src/maemo/modest-account-settings-dialog.c: (on_response),
2188 (save_configuration), (show_ok):
2189 Fixed projects.maemo.org bugs NB #59248 and #59251
2191 * src/maemo/modest-maemo-utils.c:
2192 (on_camel_account_get_supported_secure_authentication_status),
2193 (on_camel_account_get_supported_secure_authentication),
2194 (modest_maemo_utils_get_supported_secure_authentication_methods):
2195 * src/maemo/modest-maemo-utils.h:
2196 Moved get_supported_secure_authentication() method here to be able
2197 to use it from easysetup wizard.
2199 * src/modest-pair.c: (on_pair_compare_as_string):
2200 Should compare string with first part of pair and not
2201 strcmp pairs which will crash.
2203 * src/modest-protocol-info.c:
2204 (modest_protocol_info_protocol_is_store):
2205 * src/modest-protocol-info.h:
2206 Added modest_protocol_info_get_auth_protocol_name()
2208 2007-06-03 Armin Burgmeier <armin@openismus.com>
2210 * src/modest-mail-operation.c:
2211 (modest_mail_operation_get_msgs_full): Set priv->account also when
2212 only retrieving a single message. This avoids a crash when canceling
2215 (modest_mail_operation_notify_end): Do not explicitely remove the
2216 operation from the queue but only emit the progress_changed signal.
2217 The queue itself listens to that signal to remove the operation when
2218 it is finished. This reduces coupling and removes a potential deadlock
2219 when modest_mail_operation_notify_end() is called from the queue
2220 itself. If that is a problem performance-wise, I would suggest to
2221 implement a status-changed signal or something.
2223 * src/modest-mail-operation-queue.c: Make sure to never call a
2224 function from another file while the queue is locked. This (hopefully)
2225 fixes another deadlock when exiting the application while retrieving
2228 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2230 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2231 Fixed build if libogs is not available
2233 2007-06-03 Christian Kellner <ckellner@openismus.com>
2235 * libmodest-dbus-client/libmodest-dbus-client.h:
2236 * libmodest-dbus-client/libmodest-dbus-client.c:
2237 (libmodest_dbus_client_delete_message):
2238 Implement deletion of messages (Client side).
2240 (modest_search_hit_free),
2241 (modest_search_hit_list_free):
2242 Utility functions to free the result hits.
2244 * src/dbus_api/modest-dbus-api.h:
2245 * src/dbus_api/modest-dbus-callbacks.c:
2246 (on_delete_message),
2247 (modest_dbus_req_handler):
2248 Implement deletion of messages (Server side).
2250 * tests/dbus_api/test_search.c: (main):
2253 * tests/dbus_api/Makefile.am:
2254 * tests/dbus_api/test_delete_message:
2255 Add little test for the message deletion logic
2257 2007-06-03 Armin Burgmeier <armin@openismus.com>
2259 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2260 when the operation queue was not empty. projects.maemo.org bug
2263 2007-06-03 Armin Burgmeier <armin@openismus.com>
2265 * src/widgets/modest-account-view.c
2266 (on_account_default_toggled): Toggle default account column
2267 explicitely instead of waiting for gconf notification (which is
2268 currently ignored). This should fix projects.maemo.org bug NB#56910
2269 for now. It should probably be removed when gconf notifications are
2272 2007-06-03 Christian Kellner <ckellner@openismus.com>
2274 * libmodest-dbus-client/libmodest-dbus-client.c:
2275 Removed debugging spew.
2277 * src/dbus_api/modest-dbus-callbacks.c:
2278 Added debugging info.
2280 * src/modest-search.c:
2281 (modest_search_all_accounts):
2282 Use tny_account_store_get_accounts () on the account store
2283 to get all accounts which is the way to get all accounts.
2285 * tests/dbus_api/test_search.c: (main):
2286 Make it possible to supply the search term on the command line.
2288 2007-06-03 Christian Kellner <ckellner@openismus.com>
2290 * libmodest-dbus-client/libmodest-dbus-client.c:
2291 * libmodest-dbus-client/libmodest-dbus-client.h:
2292 Implement searching for mesages over raw dbus. (Client side)
2294 * src/dbus_api/Makefile.am:
2295 * src/dbus_api/modest-dbus-api.h:
2296 * src/dbus_api/modest-dbus-callbacks.c:
2297 * src/dbus_api/modest-dbus-callbacks.h:
2298 Search framework (Server side). Also implement on_idle_open_message().
2300 * src/maemo/modest-platform.c: (modest_platform_init):
2301 Prepare for raw dbus/osso rpc interaction.
2303 * src/modest-search.h:
2304 Changed minsize from unspecific guint to guint32.
2306 * src/modest-search.c:
2308 Added strange hack which magically made tnymail work.
2310 (modest_search_folder),
2311 (modest_search_account),
2312 (modest_search_all_accounts):
2313 Implement helper functions to search all accounts, specific account
2316 * tests/dbus_api/Makefile.am:
2317 * tests/dbus_api/test_open_message.c:
2318 Read url to open from commandline.
2320 * tests/dbus_api/test_search.c:
2321 Implement small test for dbus search stuff
2323 2007-06-02 Armin Burgmeier <armin@openismus.com>
2325 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2326 include account type and account title. This fixes projects.maemo.org
2329 * src/maemo/modest-account-view-window.c: Set a title for the window.
2331 2007-06-02 Armin Burgmeier <armin@openismus.com>
2333 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2334 incoming and outgoing server name based on email address and server
2335 types as long as the names have not been edited manually. This fixes
2336 projects.maemo.org bug NB#58671.
2338 2007-06-02 Armin Burgmeier <armin@openismus.com>
2340 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2341 server type cannot be changed in future to the incoming details page
2342 when creating an account. This fixes projects.maemo.org bug NB#59029.
2344 2007-06-02 Armin Burgmeier <armin@openismus.com>
2346 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2347 and assigned max width chars so that they wrap instead of being
2348 truncated. Fixes projects.maemo.org bug NB#56126.
2350 2007-06-02 Armin Burgmeier <armin@openismus.com>
2352 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2353 introductory note to the connection specific smtp servers dialog, as
2354 section 8.12 of the email UI specification requires. This fixes
2355 projects.maemo.org bug NB#59212.
2357 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2359 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2360 Check for running mail operations, and offer to cancel them, as per the UI
2361 spec. This fixes projects.maemo.org bug NB#59041 .
2362 However, I suspect that tinymail may still use the network connection
2363 in ways that we cannot detect or cancel. But it should at least adapt to
2364 changes fairly well.
2366 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2368 * src/modest-tny-account-store.c: (recreate_all_accounts),
2369 (get_cached_accounts), (get_server_accounts): Do more sensible
2370 ref-counting of the temporarily-cached outbox accounts list. This seems
2371 to fix a crash when entering the password when the password was wrong.
2373 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2375 * src/gnome/modest-main-window.c: (connect_signals):
2376 * src/modest-tny-account-store.c: (get_password),
2377 (modest_tny_account_store_alert): Added comments and clues and
2378 commented-out code about how we currently fail to deal with connection
2379 errors and wrong passwords, and how we should.
2381 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2383 * src/widgets/modest-retrieve-combo-box.c:
2384 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2385 This fixes projects.maemo.org bug NB#58472 .
2387 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 (create_page_complete_easysetup):
2391 (create_page_complete_custom): Correct the last commit,
2392 putting the correct sentences in the correct pages.
2394 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2396 * src/maemo/easysetup/modest-easysetup-wizard.c:
2397 (create_page_complete_custom): Show the second sentence of text
2398 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2401 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2404 Set the leave-on-server conf key by default. This fixes
2405 projects.maemo.org bug NB#59258 .
2407 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/modest-account-view-window.c:
2410 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2411 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2414 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/easysetup/modest-easysetup-wizard.c:
2417 (create_caption_new_with_asterisk):
2418 * src/maemo/modest-account-settings-dialog.c:
2419 (create_caption_new_with_asterisk):
2420 Uncomment the code to add the asterisk, because they are no longer in the
2421 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2422 (update_incoming_server_title): Add an asterisk here too.
2424 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2426 * src/maemo/modest-maemo-global-settings-dialog.c:
2427 (current_connection): Check that we are even connected before trying to
2428 get the current connection name, to prevent a warning.
2430 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2431 Change the comments because tny_maemo_conic_device_connect() is now meant to
2433 * src/modest-mail-operation.c:
2434 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2435 make sure we have a connection and fail if we can't connect.
2437 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/modest-main-window.c:
2440 (on_account_store_connecting_finished): Do not try to get the
2441 connection ID if we are not really connected. I am surprised that
2442 this signal handler is called when we are not connected.
2444 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2446 * src/modest-error.h:
2447 * src/modest-ui-actions.c:
2448 (modest_ui_actions_get_msgs_full_error_handler):
2449 Renamed an enum, added comments, added an enum
2450 for retrieve-limit errors.
2452 * src/modest-mail-operation.c: (foreach_add_item),
2453 (internal_folder_observer_update), (update_account_thread),
2454 (modest_mail_operation_get_msgs_full):
2455 (modest_mail_operation_update_account),
2456 Added comments about how this works, and some code that should
2457 (but does not) check the retrieve-limit. See the TODO comment.
2459 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2462 Initialize help_id to fix the build. Warnings are good.
2464 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2466 * src/widgets/modest-hbox-cell-renderer.c:
2467 (modest_hbox_cell_renderer_append):
2468 * src/widgets/modest-vbox-cell-renderer.c:
2469 (modest_vbox_cell_renderer_append):
2470 Fix the last commit by doing an extra ref.
2472 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2474 * src/widgets/modest-hbox-cell-renderer.c:
2475 (modest_hbox_cell_renderer_append):
2476 * src/widgets/modest-vbox-cell-renderer.c:
2477 (modest_vbox_cell_renderer_append):
2478 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2479 to fix the build with Maemo Bora.
2480 However, there seems to be a remaining crash, probably due to reference
2483 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2485 * src/modest-tny-account.c:
2486 (modest_tny_account_new_for_local_folders):
2487 Use hildon_file_system_info_async_new() to get a better name for
2488 the memory card account, setting it as the account name.
2489 The timing seems to work, but this is probably
2490 not the best place to do this. See the TODO comment.
2491 * src/maemo/modest-main-window.c: (create_details_widget):
2492 * src/widgets/modest-folder-view.c: (text_cell_data):
2493 Use the tny account name instead of hardcoding a name.
2495 2007-05-30 Christian Kellner <ckellner@openismus.com>
2497 * src/modest-search.c: (modest_search):
2498 Correctly set part_search_func even if we have already parsed
2499 the query and thus a valid OgsTextSearcher object.
2501 2007-05-30 Christian Kellner <ckellner@openismus.com>
2504 Search and check for libogs.
2507 Incooparte the ogs build env.
2509 * src/modest-mime-part-search-stream.c:
2510 * src/modest-mime-part-search-stream.h:
2511 Removed since we do the real searching now in modest-search.c.
2513 * src/modest-search.c:
2514 * src/modest-search.h:
2515 Implement support for ogs. We use that if available and requested
2516 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2517 should now handle the corner case when the search term is spread
2518 across multiple reads.
2519 Also the logic in modest_search () was corrected to search all
2520 requested fields until one is found.
2522 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2524 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2526 * src/modest-init.h:
2527 * src/modest-init.c: Made modest_init_local_folders() take a
2528 path and be public so we can iniitialize maildir folders on
2531 * src/modest-local-folder-info.h:
2532 * src/modest-local-folder-info.c:
2533 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2535 * src/modest-tny-account.c:
2536 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2537 still means the standard local-folders path on the local volume.
2539 * src/modest-tny-account-store.c:
2540 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2541 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2542 all accounts when that happens.
2543 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2544 this too, so it shows up in the treeview.
2546 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/modest-maemo-global-settings-dialog.c:
2549 (current_connection):
2550 * src/widgets/modest-global-settings-dialog.c:
2551 (current_connection_default):
2552 Use the enum values instead of 0, 1 and -1,
2553 to make the code clearer.
2555 * src/modest-account-mgr-helpers.c:
2556 (modest_account_mgr_get_connection_specific_smtp): Make this code
2559 * src/modest-runtime.h:
2560 * src/modest-runtime.c:
2561 Added modest_runtime_remove_all_send_queues().
2562 * src/maemo/modest-main-window.c:
2563 (on_account_store_connecting_finished): Recreate the send queues,
2564 using the appropriate transport accounts for this new connection.
2565 Some futher adapting might be needed if the old send queues are not
2566 automatically stopped at this point.
2568 * src/modest-tny-account-store.c: (get_server_accounts):
2569 Create the connection-specific transport accounts, so that they can
2570 be found later by their ID.
2572 * src/modest-tny-account.h:
2573 * src/modest-tny-account.c:
2574 Added modest_tny_account_new_from_server_account_name().
2575 modest_tny_account_new_from_server_account(): Do not create the
2576 send queues here, because they will be
2577 recreated anyway when the connection changes for the first time.
2579 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2581 * src/modest-local-folder-info.h:
2582 * src/modest-local-folder-info.c:
2583 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2584 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2585 tbox_folder): Take a modest account name instead of a server TnyAccount,
2586 so we can have per-modest-account rather than per-transport-account
2588 We must make sure that we change or recreate the exisitng send queues
2589 when the connection changes for connection-specific transport accounts.
2591 * src/modest-tny-account-store.c:
2592 (create_per_account_local_outbox_folders): Create outboxed per modest
2593 account, not per transport account.
2595 * src/modest-tny-account.h:
2596 * src/modest-tny-account.c:
2597 (modest_tny_account_get_special_folder): For outboxes, get the
2598 parent modest account name. The account is ignored for other folders.
2599 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2600 modest account name rather than a server TnyAccount.
2602 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2604 * src/modest-tny-account.c:
2605 (modest_tny_account_new_from_server_account):
2606 Call modest_runtime_get_send_queue() immediately after creating transport
2607 accounts, so that they start trying to send email from the outbox as soon
2608 as possible at startup. This is probably what we want.
2610 * src/modest-mail-operation.c: (update_account_thread):
2611 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2612 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2613 * src/modest-tny-send-queue.h:
2614 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2615 (modest_ui_actions_on_send):
2616 Added comments about how sending works, though it needs some more work.
2618 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2620 * src/modest-tny-account.c:
2621 (modest_tny_account_get_special_folder): Add TODO because this fails when
2622 the network is busy.
2623 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2624 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2625 Do not try to show this window when there is no active account. The UI
2626 specs does not tell us what to do in this case.
2628 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2632 * src/maemo/Makefile.am:
2633 * src/widgets/Makefile.am: Some dist fixes.
2635 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/modest-connection-specific-smtp-window.c:
2638 (on_button_edit): Make the code clearer, to prevent a double free.
2640 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2642 * src/maemo/modest-account-settings-dialog.c:
2643 (modest_account_settings_dialog_set_account_name),
2644 Check the connection-specific smtp servers checkbox if there are any.
2646 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2647 (modest_connection_specific_smtp_edit_window_init):
2648 Start with a suitable port number.
2650 * src/modest-account-mgr-helpers.h:
2651 * src/modest-account-mgr-helpers.c: Added
2652 modest_account_mgr_get_has_connection_specific_smtp().
2654 (modest_account_mgr_set_connection_specific_smtp),
2655 (modest_account_mgr_remove_connection_specific_smtp),
2656 (modest_account_mgr_get_has_connection_specific_smtp),
2657 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2658 connection-specific smtp server accounts in the account, rather than
2659 the server account conf dir.
2661 This fixes bug projects.maemo.org bug NB#58263 .
2663 * src/modest-tny-account-store.c:
2664 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2665 if there are no server accounts yet, to prevent an infinite loop when there
2666 are no accounts. Document that one must be called before the other.
2668 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-account-mgr-helpers.c:
2671 (modest_account_mgr_get_default_account): Make sure that at least
2672 one account is always the default, if there are any enabled accounts.
2673 This is just a sanity check that shouldn't be necessary.
2675 * src/modest-account-mgr-priv.c:
2676 (_modest_account_mgr_account_from_key): Unescape the conf key to
2677 get the real account name. For instance, this is an issue if a space
2678 was in the account name, which can happen because the account name
2679 is generated from the display name.
2680 (_modest_account_mgr_get_account_keyname): Always escape the
2682 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2683 Unescape the conf keys to get the real account names.
2685 For instance, previously the is-default radio button in the accounts
2686 list was not checked for any accounts at first. This fixes that,
2687 and might fix several similar bugs.
2689 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2691 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2692 Removed some debug printfs.
2694 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2696 Modest on-disk outbox directories are now here, for instance:
2697 $HOME/.modest/outboxes/<account-id-1>/outbox
2698 $HOME/.modest/outboxes/<account-id-2>/outbox
2700 $HOME/.modest/local-folders/outbox
2701 so we can have a separate outbox for each account.
2702 But they are shown as one outbox in the GtkTreeView, by using a
2703 TnyMergeFolder in a ModestTnySimpleFolderStore.
2706 * src/modest-tny-simple-folder-store.c:
2707 * src/modest-tny-simple-folder-store.h:
2708 Added ModestTnySimpleFolderStore, used to contain folders from
2709 other folder stores, such as other accounts.
2711 * src/modest-tny-outbox-account.h:
2712 * src/modest-tny-outbox-account.c:
2713 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2714 used for the per-account local outbox folders.
2716 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2717 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2718 only use this (internally) now for the non-outbox local folders.
2720 * src/modest-init.h:
2721 * src/modest-init.c: Added modest_init_one_local_folder(), for
2722 setting up the directory structure for each local folder.
2724 * src/modest-local-folder-info.c:
2725 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2726 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2728 * src/modest-local-folder-info.h:
2729 * src/modest-tny-account-store.c: (on_account_removed),
2730 (on_account_changed), (create_per_account_local_outbox_folders),
2731 (get_server_accounts), (modest_tny_account_store_get_accounts),
2732 (modest_tny_account_store_get_tny_account_by_account),
2733 (modest_tny_folder_store_is_virtual_local_folders):
2735 * src/modest-tny-account.h:
2736 * src/modest-tny-account.c:
2737 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2738 to create an on-disk per-account local outbox folder for each
2740 (create_per_account_local_outbox_folders): Create a local outbox folder
2741 for each transport account.
2742 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2743 for all local folders.
2745 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2746 instead of using g_object_get/set() directly. It is clearer.
2748 (modest_tny_folder_store_get_message_count),
2749 (modest_tny_folder_store_get_local_size
2750 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2751 because we now use these with non-acount folder stores.
2753 (modest_tny_account_get_special_folder),
2754 (modest_tny_account_new_from_server_account),
2755 (modest_tny_account_new_from_account):
2756 (recurse_folders): Adjust to the new outbox system.
2758 * src/modest-tny-folder.h:
2759 * src/modest-tny-folder.c:
2760 (modest_tny_folder_is_local_folder),
2761 (modest_tny_folder_get_local_folder_type),
2762 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2764 * src/widgets/modest-main-window.h:
2765 * src/maemo/modest-main-window.c: (create_details_widget),
2766 (modest_main_window_set_contents_style): Show details for any folder store,
2769 (modest_tny_folder_get_rules):
2770 Remove the const. C does not support constness enough for this.
2772 * src/modest-ui-actions.c:
2773 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2774 make all outboxes appear as one, in the usual local-folders tree node.
2776 (set_active_account_from_tny_account),
2777 (modest_ui_actions_on_folder_selection_changed):
2778 * src/widgets/modest-folder-view.c: (text_cell_data),
2779 (icon_cell_data), (filter_row),
2780 (add_account_folders_to_merged_folder),
2781 (add_account_folders_to_simple_folder_store), (),
2782 (get_cmp_rows_type_pos), (cmp_rows),
2783 (modest_folder_view_set_account_id_of_visible_server_account):
2784 Adjust to the new outbox system, using generic folder stores and folders
2785 in the GtkTreeModel.
2787 2007-05-23 Christian Kellner <ckellner@openismus.com>
2789 * src/modest-mail-operation.c:
2790 (modest_mail_operation_update_account):
2791 Use info->max_size instead of unintialized local var [small
2792 build fix]. (Added TODO to review that change since I don't
2795 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2797 * libmodest-dbus-client/libmodest-dbus-client.c:
2798 (libmodest_dbus_client_compose_mail): function added
2799 * src/dbus_api/modest-dbus-api.h:
2800 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2801 (on_compose_mail): Implementation of the SendAsMail functionality
2803 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2805 * src/modest-account-mgr.c:
2806 (modest_account_mgr_add_server_account): Set the secure-connection
2807 conf key for transport accounts as well as store accounts. I don't know
2808 why the if was there. For instance, this makes sure that we use SSL
2809 for the gmail preset from the easysetup wizard.
2811 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2813 * src/gnome/modest-main-window.c:
2814 (on_account_store_connecting_finished), (connect_signals):
2815 * src/maemo/modest-main-window.c:
2816 (on_account_store_connecting_finished), (connect_signals),
2817 (modest_main_window_new):
2818 Handle TnyAccountStore::connecting-finished instead of
2819 TnyDevice::connection-changed, because we cannot actually perform
2820 operations on accounts until TnyAccountStore has itself responded to
2821 the TnyDevice::connection-changed signal. This prevents a GError from
2823 Do not try to update at startup, because we (at least on scratchbox)
2824 already do an update at startup when the device goes online.
2825 This prevents a GError from tinymail.
2826 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2827 Added TODO about stopping simultaneous operations.
2829 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2831 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2832 * src/modest-mail-operation-queue.c:
2833 (modest_mail_operation_queue_remove):
2834 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2835 about where they happened.
2837 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-ui-actions.c:
2840 (modest_ui_actions_on_password_requested): Make sure that the remember
2841 output parameter is always TRUE.
2843 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2846 Show a OK/Cancel dialog if the error is a question, though we still do not
2847 know anything more about what we are asking the user.
2848 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2849 Fix an uninitialized variable (helper). This is a logic error, however.
2851 2007-05-21 Christian Kellner <ckellner@openismus.com>
2853 * src/modest-search.h:
2854 Correct bit shifting in the ModestSearchFlags enum.
2856 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2858 * src/modest-tny-account.c:
2859 (modest_tny_account_new_from_server_account): Do not use the lsub and
2860 check-all hard-coded IMAP options when using POP.
2862 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2864 * src/modest-tny-account.c:
2865 (modest_tny_account_new_from_server_account):
2866 Use NULL for the secure-auth method for POP when Password auth has been
2867 specified by the user, as we already do for IMAP. "auth=Login" causes
2868 an error from camel or the server.
2870 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2872 * src/maemo/modest-account-settings-dialog.c:
2873 (create_page_account_details),
2874 (modest_account_settings_dialog_set_account_name):
2875 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2876 for the leave-on-server checkbox, rathr than just the checkbox, when
2877 the protocol is not POP.
2879 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2881 * src/widgets/modest-account-view.c:
2882 * src/widgets/modest-account-view.h:
2883 Added modest_account_view_select_account() which will be useful later
2884 to asynchronously re-select the edited account.
2886 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2888 * src/maemo/modest-account-settings-dialog.c:
2889 (modest_account_settings_dialog_set_account_name):
2890 Automatically choose the port numbers based on the secure authentication
2891 methods, if they have not been chosen before.
2892 This fixes projects.maemo.org bug NB#56273 .
2894 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2896 * src/maemo/modest-main-window-ui.h:
2897 * src/modest-ui-actions.c:
2898 * src/modest-ui-actions.h:
2899 Connect the Tools/SMTP Servers menu item to
2900 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2901 SMTP servers dialog, as in the UI specification and saves changes when it
2902 is closed. This fixed projects.maemo.org bug NB#56305 .
2904 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/modest-connection-specific-smtp-window.c:
2907 (modest_connection_specific_smtp_window_init):
2908 Use gtk_window_set_default_size() to make this window big enough, so
2909 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2911 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2913 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2914 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2915 (modest_connection_specific_smtp_edit_window_init),
2916 Do not try to connect to a combobox signal before the combobox exists.
2917 This fixes the cras in projects.maemo.org bug NB#56288 .
2918 (modest_connection_specific_smtp_edit_window_get_settings):
2919 Remove the server_account_name parameter which was being checked for NULL
2920 though it was not used.
2922 * src/maemo/modest-connection-specific-smtp-window.c:
2923 (modest_connection_specific_smtp_window_fill_with_connections),
2924 (on_button_edit), (modest_connection_specific_smtp_window_init):
2925 Correct the number of treemodel columns to prevent a warning.
2926 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2927 libconic does not work.
2929 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2931 * src/modest-tny-account.c:
2932 (modest_tny_account_new_from_server_account):
2933 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2934 SMTP when "None" was chosen by the user. However, with my SMTP server that
2935 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2938 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2941 to explain the memory management issue with the ID in the ModestPair.
2943 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2944 (add_sending_page), (modest_account_assistant_finalize):
2945 * src/gnome/modest-gnome-global-settings-dialog.c:
2946 (create_updating_page), (create_composing_page):
2947 * src/gnome/modest-msg-edit-window.c: (get_transports),
2948 (init_window), (modest_msg_edit_window_finalize),
2949 (modest_msg_edit_window_get_msg_data):
2950 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2951 * src/gnome/modest-transport-widget.c:
2952 (modest_transport_widget_finalize), (smtp_configuration):
2953 * src/maemo/modest-maemo-global-settings-dialog.c:
2954 (create_updating_page), (create_composing_page):
2955 * src/maemo/modest-msg-edit-window.c: (get_transports),
2956 (init_window), (modest_msg_edit_window_finalize),
2957 (modest_msg_edit_window_get_msg_data),
2958 (modest_msg_edit_window_free_msg_data):
2959 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2960 (modest_store_widget_finalize):
2961 * src/maemo/modest-transport-widget.c:
2962 (modest_transport_widget_finalize), (smtp_configuration):
2963 * src/modest-main.c: (send_mail):
2964 * src/widgets/modest-combo-box.h:
2965 * src/widgets/modest-global-settings-dialog-priv.h:
2966 * src/widgets/modest-global-settings-dialog.c:
2967 (modest_global_settings_dialog_finalize):
2968 * src/widgets/modest-msg-edit-window.h:
2969 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2970 as long as the combo box, to prevent use of freed memory for the ID.
2972 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2974 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2975 get_accounts(), to make this clearer. Do not check for the enabled gconf
2976 key, because we do not use this for server accounts (at least, not yet).
2977 This allows us to send email again.
2979 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/modest-platform.c:
2982 (on_modest_conf_update_interval_changed), (modest_platform_init):
2983 Only respond to this particular key change. All these strcmp()s cannot be
2986 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/modest-maemo-global-settings-dialog.c:
2989 (current_connection): Prevent a crash in scratchbox when
2990 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2991 * src/maemo/modest-platform.c:
2992 (on_modest_conf_update_interval_changed), (modest_platform_init):
2993 Get the update interval from gconf and reset it when the gconf key changes.
2995 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2997 * src/modest-protocol-info.c:
2998 * src/modest-protocol-info.h: Adde enum-specific get functions,
2999 instead of using a ModestProtocolType enum parameter.
3001 * src/gnome/modest-account-assistant.c:
3002 * src/gnome/modest-store-widget.c:
3003 * src/gnome/modest-store-widget.h:
3004 * src/gnome/modest-transport-widget.c:
3005 * src/gnome/modest-transport-widget.h:
3006 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3007 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3008 * src/maemo/easysetup/modest-easysetup-wizard.c:
3009 * src/maemo/modest-account-settings-dialog.c:
3010 * src/maemo/modest-account-settings-dialog.h:
3011 * src/maemo/modest-store-widget.c:
3012 * src/maemo/modest-store-widget.h:
3013 * src/maemo/modest-transport-widget.c:
3014 * src/maemo/modest-transport-widget.h:
3015 * src/modest-account-mgr-helpers.c:
3016 * src/modest-account-mgr-helpers.h:
3017 * src/modest-account-mgr.c:
3018 * src/modest-account-mgr.h:
3019 * src/modest-tny-account.c:
3020 * src/modest-tny-folder.c:
3021 * src/widgets/modest-account-view.c:
3022 * src/widgets/modest-retrieve-combo-box.c:
3023 * src/widgets/modest-retrieve-combo-box.h:
3024 * src/widgets/modest-secureauth-combo-box.c:
3025 * src/widgets/modest-serversecurity-combo-box.c:
3026 * src/widgets/modest-serversecurity-combo-box.h:
3027 * tests/check_account-mgr.c:
3028 Use the specific functions, and use the re-renamed enum values for GNOME too.
3030 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3032 * src/modest-pair.h:
3033 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3034 so we can get the second based on the first.
3036 * src/maemo/modest-account-settings-dialog.h:
3037 * src/maemo/modest-account-settings-dialog.c:
3038 Added get_supported_secure_authentication_methods(), though it is mostly
3039 commented-out for now until the necessary API is committed to tinymail.
3040 (modest_account_settings_dialog_set_account_name),
3041 (save_configuration): Request the supported authentication methods from the
3042 server, so we can choose a working method.
3044 * src/modest-tny-account-store.h:
3045 * src/modest-tny-account-store.c:
3046 (modest_tny_account_store_get_session): Rename from
3047 tny_account_store_get_session().
3049 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-protocol-info.h: Split the ModestProtocol enum
3052 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3053 There was no need to have these unrelated values in one enum.
3055 * src/: many files: Adapted to changed enum. This makes the code a bit
3056 clearer, and the compiler could catch some errors.
3058 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3061 Show the detailed internal camel error message when an error happens
3062 during the configuration, so that our testers can give us more clues.
3063 For instance, in projects.maemo.org bug NB#56910 .
3065 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3067 * src/modest-tny-account.c:
3068 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3069 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3071 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3074 * src/maemo/modest-account-settings-dialog.c:
3075 (modest_account_settings_dialog_set_account_name),
3076 (save_configuration): For the incoming secure authentication checkbox,
3077 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3078 the UI specification. PLAIN does not seem to be supported for most IMAP
3079 servers anyway, and I am not sure what it would mean.
3080 However, we probably need to discover which of the secure-authentication
3081 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3082 * src/modest-account-mgr-helpers.c:
3083 (modest_account_mgr_get_server_account_data):
3085 * src/modest-tny-account.c:
3086 (modest_tny_account_new_from_server_account):
3087 Use tny_account_set_mech() to set secure-authentication methods,
3088 with some special-casing for IMAP, based on my observations of how
3091 * src/modest-account-mgr-helpers.h:
3092 * src/modest-account-mgr.c:
3093 * src/modest-defs.h: Comment that the URI is only used for local folders.
3095 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3097 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3098 parameter const, just to be neat.
3099 * src/modest-text-utils.c: (modest_text_utils_inline):
3100 End g_strconcat() with NULL, as its documentation says. This is almost
3101 certainly the cause of my crash at startup on the device. Interestingly,
3102 valgrind doesn't tell us about these errors.
3104 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3106 * scripts/build-packages: Added more precise comments about how to use
3107 this script, though I still get this error:
3108 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3109 error building tinymail
3111 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/modest-main-window.c: (on_account_update):
3114 Very slight cleanup, hoping to make it simpler to discover what causes
3115 a crash here sometimes.
3117 * src/modest-tny-account.c:
3118 (modest_tny_account_new_from_server_account): Set the port. Added
3119 comments about the options and a TODO comment because I need to find out
3120 how to specify the secure authentication method.
3122 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3124 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3125 changed CFlags paths form modest to libmodest
3127 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3129 * src/modest-account-mgr-helpers.c:
3130 (modest_account_mgr_get_server_account_data),
3131 (modest_account_mgr_free_server_account_data):
3132 * src/modest-account-mgr-helpers.h:
3133 * src/modest-account-mgr.c:
3134 (modest_account_mgr_add_server_account):
3135 * src/modest-defs.h:
3136 * src/modest-tny-account.c:
3137 (modest_tny_account_new_from_server_account):
3138 Determine the options for tny_camel_account_add_option() here,
3139 based on the settings, rather than storing them directly in gconf.
3141 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3144 Show a more friendly error dialog now that we expect (from the tinymail
3145 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3147 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3149 * src/maemo/modest-main-window.c: (on_account_update): Check that
3150 account_name is not NULL, to prevent a crash at startup that I am
3151 seeing on the N800. I do wonder why it is NULL.
3153 * src/maemo/easysetup/modest-easysetup-wizard.c:
3154 (create_page_user_details):
3155 * src/maemo/modest-account-settings-dialog.c:
3156 (create_page_user_details), (create_page_outgoing):
3157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3158 (modest_connection_specific_smtp_edit_window_init):
3159 * src/modest-ui-actions.c:
3160 (modest_ui_actions_on_password_requested):
3161 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3162 might do something useful with the on-screen keyboard.
3164 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3166 * src/maemo/modest-main-window.c: (on_account_update):
3167 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3168 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3170 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3172 * src/modest-tny-account-store.c: (on_account_changed):
3173 Correct the signature of this signal handler.
3175 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3177 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3178 Show a HildonNote instead of a GtkDialog for Maemo.
3180 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3182 * src/widgets/modest-account-view.h:
3183 * src/widgets/modest-account-view.c: (on_account_changed),
3184 (on_account_removed). Added a boolean flag, set/unset by
3185 modest_account_view_block_conf_updates(),
3186 modest_account_view_unblock_conf_updates() to prevent unnecessary
3187 updates, but this is not very useful because the gconf notifications are
3188 so delays (maybe only on Maemo Bora).
3189 So auto-updating is turned off, and these functions do an explicit
3190 update when necessary.
3191 However, something else is still doing too much work when adding/removing
3192 accounts, probably in another part of the application.
3194 * src/maemo/modest-account-view-window.c:
3195 (on_delete_button_clicked), (on_edit_button_clicked),
3196 (on_new_button_clicked): Use the new functions.
3198 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3200 * src/modest-account-mgr-helpers.c:
3201 (modest_account_mgr_set_first_account_as_default):
3202 Sort the list of names alphabetically-by-title, so we choose the first one
3204 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3205 alphabetically by the title.
3207 This fixes projects.maemo.org bug NB#56418 .
3209 * src/modest-account-mgr-priv.c:
3210 (_modest_account_mgr_account_from_key):
3211 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3212 avoid a valgrind error, and possible random behaviour.
3214 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3216 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3217 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3218 tinymail documentation to say that this can be expected.
3219 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3220 pretty, and should not happen, but I would prefer to know when it does.
3222 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3224 * configure.ac: When using the older hildon version, probably on Bora,
3225 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3227 * src/widgets/modest-attachment-view.c:
3228 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3231 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3233 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3234 Implemented the prototype. Can be tested with
3235 tests/dbus_api/test_open_message:
3237 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3239 * src/modest-tny-account-store.c:
3240 (modest_tny_account_store_instance_init), (get_password):
3241 * src/modest-ui-actions.c:
3242 (modest_ui_actions_on_password_requested):
3243 Do not store the password in gconf, because this function is called
3244 for non-remembered passwords. Actually use the cached (in the hash map)
3245 password instead of releasing it.
3246 The password will now not be remembered if it is asked via the protected
3247 password dialog, as per the UI spec.
3249 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3251 * src/modest-defs.h:
3252 * src/modest-account-mgr-helpers.h:
3253 * src/modest-account-mgr-helpers.c:
3254 Added modest_server_account_get_username_has_succeeded(),
3255 modest_server_account_set_username_has_succeeded().
3256 (modest_server_account_set_username),
3257 Reset the has-succeeded flag if the username changes.
3259 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3260 * src/maemo/modest-connection-specific-smtp-window.c:
3261 (modest_connection_specific_smtp_window_save_server_accounts):
3262 Use modest_server_account_set_username() instead of using
3263 modest_conf_set_string() directly, so that the has-succeeded flag is always
3266 * src/modest-ui-actions.c:
3267 (modest_ui_actions_on_password_requested): Dim the username entry if
3268 the username has ever worked, as per the UI spec.
3270 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3272 * src/modest-tny-account-store.c: (get_password):
3273 * src/modest-ui-actions.c:
3274 (modest_ui_actions_on_password_requested):
3275 Allow the username to be changed too, though there is more work to
3276 be done on exactly how this behaves.
3278 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-account-mgr-helpers.h:
3281 * src/modest-account-mgr-helpers.c:
3282 Added modest_account_mgr_get_display_name(),
3283 modest_server_account_get_username(),
3284 modest_server_account_set_username(),
3285 modest_server_account_set_password(),
3286 modest_server_account_get_hostname() functions so we do not need to
3287 use the conf API directly.
3289 * src/maemo/modest-main-window.c: (connect_signals):
3290 Actually connect ot the ModestAccountStore::request-password signal,
3291 so that we show the dialog when the password is requested by Tinymail,
3292 for isntance if it is empty.
3294 * src/modest-marshal.list:
3295 * src/modest-tny-account-store.c:
3296 (modest_tny_account_store_class_init), (get_password),
3297 (modest_tny_account_store_alert):
3298 * src/modest-tny-account-store.h:
3299 * src/modest-ui-actions.h:
3300 * src/modest-ui-actions.c:
3301 (modest_ui_actions_on_password_requested):
3302 Change the signal parameters, so it is obvious that we are providing
3303 the non human-readable server name, and receiving both the username
3304 and password, though changing of the username is not yet implemented.
3305 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3306 for the GNOME version.
3308 This should fix the projects.maemo.org bug NB#56209, though it does not
3309 work on Bora, because the gconf_client_get() for the password fails
3310 immediately after we save it with gconf_client_set().
3312 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3315 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3316 caused an undefined symbol error:
3317 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3319 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3321 * src/modest-tny-account-store.c:
3322 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3323 using a GError instead of a string message, so we can translate it in
3326 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3328 * src/maemo/modest-address-book.c:
3329 (modest_address_book_check_names):
3330 * src/maemo/modest-msg-view-window.c:
3331 (modest_msg_view_window_clipboard_owner_change):
3332 * src/modest-init.c: (modest_init_init_ui):
3333 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3334 (update_folders_cb), (modest_mail_operation_update_account):
3335 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3336 (modest_ui_actions_on_msg_attachment_clicked),
3337 (modest_ui_actions_on_msg_recpt_activated):
3338 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3339 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3340 (modest_msg_view_search_next):
3341 * src/widgets/modest-recpt-editor.c:
3342 (modest_recpt_editor_on_button_release_event),
3343 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3344 g_message(). At this point we should only be seeing interesting errors on
3345 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3347 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3349 (modest_wizard_dialog_force_title_update):
3350 * src/maemo/easysetup/modest-wizard-dialog.h:
3351 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3352 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3353 can update the title when appropriate. Otherwise the title is wrong if the
3354 pages are added after adding the notebook to the dialog.
3355 This must be a problem in HildonWizardDialog too.
3356 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3358 * src/maemo/easysetup/modest-easysetup-wizard.c:
3359 (create_subsequent_customsetup_pages),
3360 (create_subsequent_easysetup_pages):
3361 Call modest_wizard_dialog_force_title_update() so that the title is
3362 correct even with GTK+ < 2.10.
3363 This fixes projects.maemo.org bug NB#56145 .
3365 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3367 * src/maemo/modest-platform.c:
3368 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3369 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3372 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3374 * src/widgets/modest-window.h:
3375 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3376 and modest_window_save_state(), which invokes it.
3378 * src/widgets/modest-window-mgr.h:
3379 * src/widgets/modest-window-mgr.c:
3380 Added modest_window_mgr_save_state_for_all_windows(), which calls
3381 the save_state vfunc on all registered windows, if implemented.
3383 * src/gnome/modest-msg-edit-window.c:
3384 * src/gnome/modest-msg-view-window.c:
3385 * src/maemo/modest-msg-edit-window.c:
3386 * src/maemo/modest-msg-view-window.c:
3387 * src/maemo/modest-main-window.c:
3388 Specify the existing save_settings functions as implementations of
3389 ModestWindow::save_state_func().
3391 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3392 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3393 enabling hibernation, for instance.
3395 We may need to do the same thing for restoring settings.
3398 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3400 * src/widgets/modest-window-mgr.c:
3401 * src/widgets/modest-window-mgr.h:
3402 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3403 modest_window_mgr_get_hibernation_is_prevented().
3405 * src/maemo/modest-main-window.c:
3406 (on_hildon_program_is_topmost_notify): Prevent hibernation
3407 (possible when the application goes to the background in the WM),
3408 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3410 * src/maemo/easysetup/modest-easysetup-wizard.c:
3411 (modest_easysetup_wizard_dialog_init):
3412 * src/maemo/modest-account-settings-dialog.c:
3413 (modest_account_settings_dialog_init):
3414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3415 (modest_connection_specific_smtp_edit_window_init):
3416 * src/maemo/modest-connection-specific-smtp-window.c:
3417 (modest_connection_specific_smtp_window_init):
3418 * src/maemo/modest-signature-editor-dialog.c:
3419 (modest_signature_editor_dialog_init):
3420 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3421 prevent hibernation while any of these account settings dialogs are open.
3423 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/Makefile.am:
3426 * src/maemo/modest-osso-state-saving.c:
3427 * src/maemo/modest-osso-state-saving.h: Added
3428 modest_osso_load_state() and modest_osso_save_state() though they do
3429 nothing now. They should iterate through all the open windows and load/save
3431 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3432 save state when closing.
3434 * src/maemo/modest-main-window.c:
3435 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3436 Add a notification handler for the HildonProgram::is-topmost property,
3437 so we can allow hibernation when the application goes into the background.
3438 But we still need to detect when the accounts setup windows are open so
3439 we can stop hibernation when they are open.
3440 To do this, I also added the main window the HildonProgram. This might have
3441 other side-effects/benefits, and should maybe be done for other windows.
3443 * src/maemo/modest-osso-autosave-callbacks.h:
3444 * src/maemo/modest-osso-autosave-callbacks.c:
3445 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3446 though it does not do anything yet, and we might never need this to do
3447 anything. For instance, we already save drafts.
3449 * src/maemo/modest-platform.c: (modest_platform_init):
3450 Specify the libosso auto-save callback.
3452 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3454 * src/maemo/modest-platform.c:
3455 (modest_platform_set_update_interval):
3456 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3457 aparently stays valid between application instances, so we can use this
3458 to remove and reset it later. According to a maemo-developers email from
3461 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3463 * configure.ac: Depend on libalarm for Maemo.
3465 * src/dbus_api/modest-dbus-api.h:
3466 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3467 (on_send_receive), (modest_dbus_req_handler):
3468 Handle a SEND_RECEIVE D-Bus method.
3470 * libmodest-dbus-client/libmodest-dbus-client.c:
3471 (libmodest_dbus_client_send_and_receive):
3472 * libmodest-dbus-client/libmodest-dbus-client.h:
3473 Add C convenience functions for calling the new D-Bus method.
3475 * src/modest-platform.h:
3476 * src/gnome/modest-platform.c:
3477 * src/maemo/modest-platform.c:
3478 Added modest_platform_set_update_interval(), which uses the
3479 alarmd API on Maemo.
3480 (modest_platform_init),
3481 Call modest_platform_set_update_interval(), using a hard-coded
3482 interval for now (until the global settings dialog is implemented),
3483 though I am not sure that this makes sense yet.
3485 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3487 * src/dbus_api/modest-dbus-callbacks.c:
3488 (modest_osso_cb_hw_state_handler):
3489 * src/dbus_api/modest-dbus-callbacks.h:
3490 * src/maemo/modest-platform.c: (modest_platform_init):
3491 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3492 in case this has some effect on the ability for Maemo to ping the
3495 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3497 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3498 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3499 warning. It is probably a logic error, but I need to fix the build.
3501 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3503 * src/modest-account-mgr.h:
3504 * src/modest-account-mgr.c:
3505 (modest_account_mgr_account_names): Add a gboolean enabled_only
3506 parameter, so we can get lists of onlt the enabled accounts.
3508 (modest_account_mgr_add_account),,
3509 (modest_account_mgr_account_with_display_name_exists):
3510 * src/maemo/modest-msg-edit-window.c: (get_transports):
3511 * src/modest-account-mgr-helpers.c:
3512 (modest_account_mgr_set_first_account_as_default):
3513 * src/modest-init.c: (init_default_account_maybe):
3514 * src/modest-tny-account-store.c: (get_accounts):
3515 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3516 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3517 * tests/check_account-mgr.c: (START_TEST):
3518 Provide the extra parameter, as appropriate.
3520 * src/widgets/modest-account-view.c: (update_account_view):
3521 Do not show disabled accounts (meaning that there is no way to
3522 enable/disable accounts in the UI (the feature is not in our UI
3523 specification), so we can use this internally only to mark unfinished
3524 or temporary account data.
3526 * src/maemo/easysetup/modest-easysetup-wizard.c:
3527 (create_account): Add boolean enable parameter, so we can specify FALSE
3528 to create the temporary account.
3529 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3530 (on_before_next): When finishing, when there is a temporary account, just
3532 Also, use a timeout to delay the showing of the dialog until gconf is likely
3533 to return correct information, due to a maemo gconf bug that is fixed in
3534 osso 1.1, but not yet in Bora.
3535 However, the dialog stays on screen after it is destroyed.
3537 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3538 for invalid data when cancelling. Use a hildon note instead of a dialog
3539 to complain about invalid data. Do not show the account-saved note if the
3540 account is disabled (a temporary account that will not really be saved for use
3543 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3545 * src/modest-account-mgr-helpers.h:
3546 * src/modest-account-mgr-helpers.c:
3547 Added modest_account_mgr_unset_default_account(),
3548 Added modest_account_mgr_set_first_account_as_default().
3550 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3551 If it was the default account, unset the default account name.
3553 * src/maemo/modest-account-view-window.c:
3554 (on_delete_button_clicked): If it was the default account,
3555 set the first remaining account as the default instead.
3557 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3558 a NULL account or a NULL default account, to prevent a crash. This should
3559 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3562 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3564 * src/widgets/modest-recpt-editor.c:
3565 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3566 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3567 TODO comment for this. This fixes the build.
3569 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3570 be the best place for it. This will in future update all auto-update accounts,
3571 rather than just the current/default account, when that gconf key exists.
3572 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3573 if there are no accounts, before calling do_send_receive().
3574 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3576 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3577 * src/maemo/modest-main-window-ui.h:
3578 * src/maemo/modest-main-window.c: (on_connection_changed),
3579 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3580 directly, becaue the signal handler does more.
3582 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3584 * src/modest-account-mgr-helpers.c:
3585 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3586 for the case that the account does not exist.
3588 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3589 (equivalent to the modest account name) rather than the tinymail account name
3590 (equivalent to the modest account title - human readable) to get the account data.
3591 Check for null account data to prevent the crash, and add a TODO comment saying that
3592 this needs fixing because it is using the server account name instead of the account name.
3594 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3596 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3597 * src/maemo/modest-account-settings-dialog.c: (show_error),
3599 Use hildon_note_new_information() for informative and error messages,
3600 which seems to be expected for Maemo applications (no documentation that I know of
3601 says this). I am surprised that there is no distinction between info and error
3604 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3606 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3607 it is easy to find where this is used.
3609 * src/maemo/easysetup/modest-easysetup-wizard.c:
3610 (create_page_welcome), (create_page_account_details),
3611 (create_page_user_details), (create_page_complete_easysetup),
3612 (create_page_custom_incoming), (create_page_custom_outgoing),
3613 (create_page_complete_custom):
3614 * src/maemo/modest-account-settings-dialog.c:
3615 (create_page_account_details), (create_page_user_details),
3616 (create_page_incoming), (create_page_outgoing):
3617 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3618 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3619 (modest_connection_specific_smtp_edit_window_init):
3620 * src/maemo/modest-connection-specific-smtp-window.c:
3621 (modest_connection_specific_smtp_window_init):
3622 * src/maemo/modest-signature-editor-dialog.c:
3623 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3624 and scrolling policy as per the Email Application Layout Guide, if I have
3627 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3629 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3630 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3631 which were empty, because these vfuncs have been removed from TnyAccountStore.
3632 This fixes the build.
3634 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/modest-main-window.c:
3637 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3638 showing/hiding it. Added TODO because it probably should not be NULL.
3639 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3640 because unnecessary g_warnings() make degugging difficult.
3642 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3644 * src/maemo/modest-msg-edit-window.c:
3645 (modest_msg_edit_window_select_color),
3646 (modest_msg_edit_window_select_background_color): 2 const corrections and
3647 moving 2 #endifs before closing brackets, to fix the build.
3649 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3651 * src/maemo/easysetup/modest-easysetup-wizard.h:
3652 * src/maemo/easysetup/modest-easysetup-wizard.c:
3653 (modest_easysetup_wizard_dialog_finalize),
3654 (on_button_edit_advanced_settings), (create_page_complete_custom),
3655 (on_response), (create_account):
3656 Implement the Advanced Settings edit button, by saving the account information,
3657 for the Advanded Settings dialog to use directly from gconf, and removing it
3658 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3659 Bug #5533 in the projects.maemo.org bugzilla.
3661 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3663 * src/maemo/modest-msg-view-window.c:
3664 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3665 when opening a message window.
3667 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3669 * src/maemo/easysetup/modest-easysetup-wizard.c:
3670 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3673 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3674 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3675 gconf settings. I probably added more checks than necessary, but that is safer.
3677 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3678 variable to fix the build, but this seems to be used when it is still NULL.
3680 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3682 * src/modest-platform.h:
3683 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3684 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3685 * src/modest-main.c: Implement this function so we can avoid using
3686 maemo-specific API from cross-platform code.
3688 * src/modest-tny-account-store.c:
3689 (get_smtp_specific_transport_account_for_open_connection):
3690 * src/modest-ui-actions.c: (check_for_connection),
3691 (modest_ui_actions_on_item_not_found):
3692 Use modest_platform_connect_and_wait() and put #idefs around other
3693 maemo-specific code, because only maemo currently has a way to
3694 identify connection names.
3696 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3698 * src/modest-tny-account-store.h:
3699 * src/modest-tny-account-store.c:
3700 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3701 the connection-specific SMTP server settings in the configuration.
3703 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3705 * src/maemo/modest-main-window.c: (on_connection_changed),
3707 * src/modest-main.c: (main), (start_ui), (send_mail):
3708 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3709 that is what is intended.
3711 * src/modest-ui-actions.c: (action_send), (action_receive),
3712 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3713 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3714 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3715 SMTP server is used when it is specified.
3717 (modest_ui_actions_on_send_receive):
3718 Check that a connection is open before proceeding.
3719 Receive and then send, instead of vice-versa, as per the specification.
3721 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3723 * src/modest-mail-operation.c:
3724 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3725 though I guess it should be something other than NULL.
3727 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3729 * src/maemo/easysetup/modest-easysetup-wizard.c:
3730 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3731 combo twice, to avoid an g_warning and to make it visible again.
3732 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3733 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3734 (already intended) dereference when detaching, because we then recreate the menu.
3735 But I am not sure why the warning was happening, and it is possible that this is a memory
3738 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3740 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3741 and uri_parse_mailto() utility functions.
3742 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3744 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3746 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3748 * src/dbus_api/modest-dbus-api.h:
3749 * src/dbus_api/modest-dbus-callbacks.c:
3750 Use an idle callback to execute the modest code in the application's own thread.
3751 Remove the helloworld example method.
3752 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3753 parsed, and the open-message method is not implemented because this is not yet implemented in
3755 * libmodest-dbus-client/libmodest-dbus-client.c:
3756 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3757 (libmodest_dbus_client_open_message):
3758 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3760 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3761 body without crashing.
3763 * tests/dbus_api/Makefile.am:
3764 * tests/dbus_api/test_mail_to.c:
3765 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3767 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3769 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3770 Added file to fix the build. Sorry.
3772 * src/dbus_api/Makefile.am:
3773 * src/dbus_api/modest-dbus-api.h:
3774 * src/dbus_api/modest-dbus-callbacks.h:
3775 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3776 (modest_dbus_req_handler):
3777 Put constants in a separate header so it can be reused by the
3778 client library, without duplication
3780 * libmodest-dbus-client/Makefile.am:
3781 * libmodest-dbus-client/libmodest-dbus-client.c:
3782 (libmodest_dbus_client_call_helloworld),
3783 (libmodfest_dbus_client_send_mail),
3784 (libmodfest_dbus_client_mailto),
3785 (libmodfest_dbus_client_open_message):
3786 * libmodest-dbus-client/libmodest-dbus-client.h:
3787 (Partly) Implement a send_mail D-Bus method.
3789 * tests/dbus_api/Makefile.am:
3790 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3791 the send_email D-Bus method.
3793 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3797 * libmodest-dbus-client/Makefile.am:
3798 * libmodest-dbus-client/libmodest-dbus-client.c:
3799 * libmodest-dbus-client/libmodest-dbus-client.h:
3800 * tests/dbus_api/Makefile.am:
3801 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3802 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3804 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3806 * src/maemo/easysetup/modest-easysetup-wizard.c:
3807 (create_page_account_details):
3808 * src/maemo/modest-account-settings-dialog.c:
3809 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3810 widgets, because this might not be the default in future versions of the Maemo GTK+.
3811 However, I can not not get capitalization to work even in a simple test case.
3813 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3815 * src/maemo/easysetup/modest-easysetup-wizard.c:
3816 (create_page_custom_incoming), (create_page_custom_outgoing):
3817 * src/maemo/modest-account-settings-dialog.c:
3818 (create_page_account_details), (create_page_incoming),
3819 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3820 instead of using gtk_check_button_with_label(), so they are aligned like the other
3821 widgets, as per the UI spec.
3823 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3825 * src/maemo/easysetup/modest-easysetup-wizard.c:
3826 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3827 * src/widgets/modest-validating-entry.c:
3828 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3829 Modest prefix instead of an EasySetup prefix.
3831 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3833 * src/widgets/modest-validating-entry.h:
3834 * src/widgets/modest-validating-entry.c: (on_insert_text),
3835 Added easysetup_validating_entry_set_max_func(), used to set a callback
3836 to call when the max number of characters is reached. GtkEntry has a max-length
3837 already but is silent about it.
3839 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3840 (create_page_account_details), (create_page_user_details),
3842 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3843 (create_page_account_details), (create_page_user_details),
3844 (create_page_outgoing):
3845 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3846 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3847 the UI spec, when the user tries to enter more than the max number of characters.
3849 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3851 * src/maemo/easysetup/modest-easysetup-wizard.c:
3852 (create_page_user_details), (create_page_custom_incoming),
3853 (create_page_custom_outgoing):
3854 * src/maemo/modest-account-settings-dialog.c:
3855 (create_page_user_details), (create_page_incoming),
3856 (create_page_outgoing):
3857 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3858 (modest_connection_specific_smtp_edit_window_init):
3859 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3860 not appropriate. Bad Maemo-specific defaults!.
3862 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3864 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3865 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3866 (modest_signature_editor_dialog_set_settings):
3867 Disable the label and textview when the checkbox is disabled, and use the
3868 specified (UI spec) default signature text.
3870 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3873 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3875 * src/modest-defs.h:
3876 * src/modest-account-mgr-helpers.h:
3877 * src/modest-account-mgr-helpers.c:
3878 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3880 * src/maemo/Makefile.am:
3881 * src/maemo/modest-signature-editor-dialog.c:
3882 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3885 * src/maemo/modest-account-settings-dialog.h:
3886 * src/maemo/modest-account-settings-dialog.c:
3887 (modest_account_settings_dialog_finalize), (on_button_signature),
3888 (save_configuration): Use the new dialog when the Edit button is pressed, and
3889 save the changes if necessary, as per the UI spec.
3891 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3893 * src/maemo/Makefile.am:
3894 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3895 based on maemo-develoers email from Dirk.
3897 * src/maemo/easysetup/modest-easysetup-wizard.c:
3898 (create_page_welcome), (create_page_account_details),
3899 (create_page_user_details), (create_page_complete_easysetup),
3900 (create_page_custom_incoming), (create_page_custom_outgoing),
3901 (create_page_complete_custom),
3902 (modest_easysetup_wizard_dialog_init):
3903 * src/maemo/modest-account-settings-dialog.c:
3904 (create_page_account_details), (create_page_user_details),
3905 (create_page_incoming), (create_page_outgoing),
3906 (modest_account_settings_dialog_init):
3907 * src/maemo/modest-connection-specific-smtp-window.c:
3908 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3910 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3912 * src/maemo/easysetup/modest-easysetup-wizard.c:
3913 (create_page_account_details), (create_page_custom_outgoing),
3914 (create_page_complete_custom):
3915 * src/maemo/modest-account-settings-dialog.c:
3916 (create_page_user_details), (create_page_incoming),
3917 (create_page_outgoing):
3918 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3919 (modest_connection_specific_smtp_edit_window_init):
3920 Use the correct (UI spec) port min/max, and use horizontal separators,
3923 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3925 * src/maemo/easysetup/modest-easysetup-wizard.c:
3926 (set_default_custom_servernames):
3927 * src/maemo/modest-account-settings-dialog.c:
3928 (create_page_incoming), (on_combo_outgoing_security_changed),
3929 (on_combo_incoming_security_changed), (create_page_outgoing),
3930 (modest_account_settings_dialog_set_account_name),
3931 (save_configuration):
3932 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3933 (on_combo_security_changed),
3934 (modest_connection_specific_smtp_edit_window_init),
3935 (modest_connection_specific_smtp_edit_window_set_connection),
3936 (modest_connection_specific_smtp_edit_window_get_settings):
3937 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3940 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3943 * src/maemo/easysetup/modest-easysetup-wizard.c:
3944 (create_page_custom_outgoing), (create_page_complete_custom):
3945 * src/maemo/modest-account-settings-dialog.c:
3946 (create_page_user_details), (create_page_outgoing):
3947 * src/maemo/modest-account-view-window.c: (button_box_new):
3948 Use changed logical IDs as per the most recent UI spec:
3949 mcen_bd_emailsetup_edit -> mcen_bd_edit
3950 mcen_bd_emailsetup_delete -> mcen_bd_delete
3951 mcen_bd_emailsetup_close -> mcen_bd_close
3953 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3957 * src/dbus_api/Makefile.am:
3958 * src/dbus_api/modest-dbus-callbacks.c:
3959 * src/dbus_api/modest-dbus-callbacks.h:
3960 * src/maemo/modest-platform.c: (modest_platform_init):
3961 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3963 * tests/Makefile.am:
3964 * tests/dbus_api/Makefile.am:
3965 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3967 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3969 * src/maemo/modest-account-settings-dialog.c:
3970 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3971 Removed unnecessary includes.
3973 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3975 * src/maemo/easysetup/modest-easysetup-wizard.c:
3976 * src/maemo/modest-account-settings-dialog.c:
3977 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3978 * src/widgets/Makefile.am:
3979 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3980 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3981 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3982 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3983 * src/widgets/modest-secureauth-combo-box.c:
3984 * src/widgets/modest-secureauth-combo-box.h:
3985 * src/widgets/modest-serversecurity-combo-box.c:
3986 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3987 made the GObject names more consistent with the rest of the Modest code.
3989 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3991 * src/maemo/easysetup/Makefile.am:
3992 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3993 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3994 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3995 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3996 * src/maemo/easysetup/modest-easysetup-wizard.c:
3997 * src/maemo/easysetup/modest-validating-entry.c:
3998 * src/maemo/easysetup/modest-validating-entry.h:
3999 * src/maemo/modest-account-settings-dialog.c:
4000 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4001 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4002 widgets/ because they are used outside of easysetup too. After checking in,
4003 svn will allow me to rename them too.
4005 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4007 * src/gnome/modest-msg-edit-window.c:
4008 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4009 linker error, to fix the build on the GNOME platform.
4010 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4011 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4012 ifdefed out to avoid a warning.
4014 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4016 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4017 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4018 some alternative for GTK+ 2.6.
4020 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4022 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4024 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4025 specified for EmailAccountsDialog in UI spec.
4027 * src/maemo/easysetup/modest-easysetup-wizard.c:
4028 * src/maemo/easysetup/modest-easysetup-wizard.h:
4029 * src/maemo/modest-account-settings-dialog.c:
4030 * src/maemo/modest-account-settings-dialog.h:
4031 Reuse a member window widget for the connection-specific SMTP server accounts,
4032 so we can tell it to create/save the accounts only if we actually save changes.
4034 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4035 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4036 (modest_connection_specific_smtp_edit_window_get_settings):
4037 Return a struct instance for temporarily remembering the entered data.
4039 * src/maemo/modest-connection-specific-smtp-window.h:
4040 * src/maemo/modest-connection-specific-smtp-window.c:
4041 (modest_connection_specific_smtp_window_finalize),
4042 (modest_connection_specific_smtp_window_fill_with_connections),
4044 (modest_connection_specific_smtp_window_save_server_accounts),
4045 (update_model_server_names): Do not actually save data until asked,
4046 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4048 (on_selection_changed),
4049 (modest_connection_specific_smtp_window_init): Disable the edit
4050 button when nothing is selected.
4052 * src/modest-account-mgr-helpers.c:
4053 * src/modest-account-mgr-helpers.h:
4054 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4057 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4059 * src/modest-account-mgr-helpers.h:
4060 * src/modest-account-mgr-helpers.c:
4061 (modest_account_mgr_get_unused_account_name),
4062 (modest_account_mgr_get_unused_account_display_name): Added these
4063 utility functions, to avoid code duplication.
4065 * src/maemo/easysetup/modest-easysetup-wizard.c:
4066 (create_page_account_details), (create_account):
4067 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4068 (on_combo_security_changed),
4069 (modest_connection_specific_smtp_edit_window_init),
4070 (modest_connection_specific_smtp_edit_window_save_settings):
4071 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4072 * src/maemo/modest-connection-specific-smtp-window.c:
4073 (modest_connection_specific_smtp_window_finalize),
4074 (modest_connection_specific_smtp_window_fill_with_connections),
4075 (on_button_edit), (modest_connection_specific_smtp_window_init):
4076 * src/maemo/modest-connection-specific-smtp-window.h:
4077 Implementing saving of connection-specific server accounts.
4079 But I need to refactor this so we can save the data for each
4080 possible connection-specific account and only actually create the server accounts
4081 when the easysetup finished, or the OK button is pressed on the account settings
4084 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4086 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4087 (on_combo_security_changed):
4088 (modest_connection_specific_smtp_edit_window_init):
4089 Auto-fill the port number as in the account settings.
4091 (modest_connection_specific_smtp_edit_window_set_connection):
4092 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4093 * src/maemo/modest-connection-specific-smtp-window.c:
4094 (fill_with_connections), (on_button_edit),
4095 (modest_connection_specific_smtp_window_init):
4096 Turn the edit window into a dialog to simplify the code, and
4097 set a WM hint as in a GtkDialog, because only a popup can be on top of
4098 another window in Maemo, and popups usually have no WM decoration.
4100 * src/modest-defs.h:
4101 * src/modest-account-mgr-helpers.c:
4102 (modest_account_mgr_set_connection_specific_smtp),
4103 (modest_account_mgr_remove_connection_specific_smtp),
4104 (modest_account_mgr_get_connection_specific_smtp):
4105 * src/modest-account-mgr-helpers.h: Some functions to write the
4106 connection-specific SMTP server information. Not yet used.
4109 * src/widgets/modest-folder-view.c: (text_cell_data):
4110 Fix a warning about an uninitialized variable.
4111 (on_configuration_key_changed): Put an #ifdef around the use
4112 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4114 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4116 * src/maemo/modest-account-settings-dialog.h:
4117 * src/maemo/modest-account-settings-dialog.c:
4118 Added connect_for_modified() utility function to mark the new modified boolean.
4120 (create_page_account_details), (create_page_user_details),
4121 (create_page_incoming), (create_page_outgoing), (on_response),
4122 (modest_account_settings_dialog_init),
4123 (modest_account_settings_dialog_set_account_name):
4124 Only warn about unsaved changes when there are actually unsaved changes.
4126 * src/modest-account-mgr-helpers.c:
4127 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4128 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4129 to get the data from there in future.
4131 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4133 * src/modest-defs.h:
4135 * src/modest-account-mgr-helpers.h:
4136 * src/modest-account-mgr-helpers.c:
4137 Store the security account setting in a single conf key instead of using
4138 the options list, so that the list is left for just the to-be-removed camel hack,
4139 and because gconf_client_set_list() is failing for some reason.
4141 * src/modest-account-mgr.c:
4142 (modest_account_mgr_add_server_account):
4143 * src/maemo/modest-account-settings-dialog.c:
4144 (modest_account_settings_dialog_set_account_name),
4145 (save_configuration): Use the renamed functions.
4148 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4150 * src/widgets/Makefile.am:
4151 * src/widgets/modest-limit-retrieve-combo-box.c:
4152 * src/widgets/modest-limit-retrieve-combo-box.h:
4153 * src/widgets/modest-retrieve-combo-box.c:
4154 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4155 the account settings dialog.
4157 * src/modest-defs.h:
4158 * src/modest-account-mgr-helpers.h:
4159 * src/modest-account-mgr-helpers.c:
4160 (modest_server_account_get_option_secure_auth),
4161 (modest_server_account_set_option_secure_auth):
4162 * src/modest-account-mgr.c:
4163 (modest_account_mgr_add_server_account):
4164 Use the existing AUTH_MECH conf key for the secure-auth setting,
4165 instead of putting it in the list options, because this was actually used already.
4167 * src/maemo/modest-account-settings-dialog.c:
4168 (create_page_account_details),
4169 (modest_account_settings_dialog_set_account_name),
4170 (save_configuration):
4171 * src/maemo/modest-account-settings-dialog.h:
4172 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4173 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4175 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4177 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4178 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4179 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4181 * src/modest-defs.h:
4182 * src/maemo/modest-account-settings-dialog.c:
4183 (create_page_incoming), (on_combo_outgoing_security_changed),
4184 (on_combo_incoming_security_changed), (create_page_outgoing),
4185 (modest_account_settings_dialog_set_account_name),
4186 (save_configuration): Load/Save the port number, and change it when the
4187 security combo changes, to suitable defaults.
4189 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4191 * src/modest-account-mgr.c:
4192 (modest_account_mgr_add_server_account): Set the security and secure-auth
4193 options, and add a comment saying that the other camel-specific options should be
4196 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4198 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4200 * src/modest-tny-account-store.c: (account_list_free),
4201 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4202 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4205 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4207 * src/modest-protocol-info.c:
4208 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4209 is required by our UI spec. Maybe something in our implementation will use this eventually.
4210 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4211 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4212 instead of the previous 0 placeholder.
4214 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4215 secure-auth settings.
4216 * src/modest-account-mgr-helpers.h:
4217 * src/modest-account-mgr-helpers.c:
4218 (modest_server_account_data_get_option_secure_auth),
4219 (modest_server_account_set_option_secure_auth),
4220 (modest_server_account_data_get_option_security),
4221 (modest_server_account_set_option_security): Added this API for getting and setting the security
4222 and secure-auth settings.
4224 * src/maemo/modest-account-settings-dialog.h:
4225 * src/maemo/modest-account-settings-dialog.c:
4226 (modest_account_settings_dialog_finalize), (check_data),
4227 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4228 about changing titles.
4229 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4230 (save_configuration): Save the security and secure-auth settings.
4232 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4233 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4235 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4237 * src/modest-defs.h:
4238 * src/modest-account-mgr.c:
4239 (modest_account_mgr_add_server_account):
4240 Added and used defines for the options key and value pair strings,
4241 that are used so far, though they do not seem to correspond to anything in our
4242 UI specs or ModestProtocol enum.
4244 * src/modest-account-mgr-helpers.h:
4245 * src/modest-account-mgr-helpers.c:
4246 (compare_option_strings_for_name),
4247 (modest_server_account_data_get_option_value),
4248 (modest_server_account_data_get_option_bool),
4249 (modest_account_mgr_get_server_account_option):
4250 Added helper functions for parsing the options GSList.
4252 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4254 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4255 display name is based on the supplied account name.
4256 * src/modest-account-mgr.c:
4257 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4258 with an inefficient, but good-enough, implementation.
4260 * src/maemo/easysetup/modest-easysetup-wizard.c:
4261 (create_page_account_details), (on_before_next), (create_account):
4262 Check for existing display names rather than (non-user-visible) account names, and just
4263 create and set a unique account name at the end.
4265 * src/maemo/modest-account-settings-dialog.c:
4266 (modest_account_settings_dialog_init),
4267 (modest_account_settings_dialog_set_account_name),
4268 (create_page_incoming): Show the display name, instead of the account name.
4269 (on_response): Do some (not all) extra checks, as in the UI spec.
4270 (save_configuration): Save the display name if it was changed.
4272 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4274 * po/en_GB.po: Added needed logical ID and translation.
4275 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4276 (init_view): Made the is-default column clicking work.
4278 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4281 * src/maemo/easysetup/Makefile.am:
4282 * src/maemo/easysetup/modest-easysetup-wizard.c:
4283 (modest_easysetup_wizard_dialog_init):
4284 * src/maemo/easysetup/provider-data-test.keyfile:
4285 * src/maemo/easysetup/provider-data.keyfile:
4286 Moved the provider data file to the new modest-providers-data package and used it from there.
4288 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4290 * src/modest-local-folder-info.c:
4291 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4292 N_() was already used on the static strings, but this just marks it for translation without
4293 using the translation.
4295 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4297 * src/maemo/modest-account-settings-dialog.c:
4298 (create_page_incoming),
4299 (modest_account_settings_dialog_set_account_name):
4300 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4301 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4302 I will do this if nobody else gets there first.
4304 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4306 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4307 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4308 save the security stuff.
4310 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4312 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4313 Set the email address and user fullname, which I now see must be
4316 * src/maemo/modest-account-settings-dialog.h:
4317 * src/maemo/modest-account-settings-dialog.c:
4319 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4320 leave-on-server and authentication.
4321 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4324 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4327 * src/maemo/modest-account-settings-dialog.c:
4328 * src/maemo/modest-account-settings-dialog.h:
4329 Most (but not all) of the widgets are now present as specified by the UI spec.
4330 No changes are yet saved, and some details are not properly shown yet.
4332 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4334 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4336 * src/maemo/Makefile.am:
4337 * src/maemo/modest-account-settings-dialog.c:
4338 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4339 an existing account. Doesn't do much yet.
4341 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4342 Open the accounts settings dialog when Edit is clicked.
4344 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4346 * src/maemo/easysetup/Makefile.am:
4347 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4349 * src/maemo/easysetup/modest-easysetup-wizard.c:
4350 (modest_easysetup_wizard_dialog_init):
4351 Try to get the source directory from the build system,
4352 instead of hard-coding "./" into the source code, when opening our local
4353 copies of the configuration files.
4354 But this still fails when opening the wizard from the Accounts window,
4355 maybe because the working directory seems to change at runtime.
4356 So the wizard will fail the second time unless you copy the files into their
4357 proper locations - see the stdout warnings for the paths.
4359 (create_page_account_details),(on_before_next):
4360 Check for existing non-server accounts instead of server accounts,
4361 so the default account name is useful again, and to prevent trying to
4364 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4365 Show the wizard when New is clicked.
4367 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4368 (init_view): Show the column headers, and show the columns that are
4369 specified in the UI specs. However, something in Maemo's GTK+ prevents
4370 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4371 change the default account. This is despite unsetting the special properties.
4373 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4375 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4376 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4377 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4378 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4379 to make that clearer.
4380 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4382 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4384 * src/maemo/modest-account-view-window.c:
4385 (modest_account_view_window_init),
4386 (modest_account_view_window_new):
4387 Use the same buttons as specified in the
4388 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4389 the existing widgets, which never had a chance of working.
4390 Put the ModestAccountView treeview in a scrolled window.
4391 Do not repeat the initialization in both _init() and _new().
4393 * src/widgets/modest-account-view.c: (update_account_view):
4394 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4395 this widget and window shows no accounts.
4397 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4399 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4401 * src/maemo/easysetup/modest-easysetup-wizard.c:
4402 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4403 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4404 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4407 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4408 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4409 accounts exist yet, as in the UI spec.
4411 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4413 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4415 * src/maemo/Makefile.am:
4416 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4417 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4418 New window for editing connection-specific smtp details.
4419 Not fully implemented.
4421 * src/maemo/modest-connection-specific-smtp-window.c:
4422 (modest_connection_specific_smtp_window_finalize) :
4423 unref the tree model.
4424 (on_button_edit): Show the edit window.
4426 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4428 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4431 * src/maemo/Makefile.am:
4432 * src/maemo/modest-connection-specific-smtp-window.c:
4433 * src/maemo/modest-connection-specific-smtp-window.h:
4434 New window for showing the list of connections, for connection-specific
4435 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4436 * src/maemo/easysetup/modest-easysetup-wizard.c:
4437 (create_page_custom_outgoing): Show the new window when the button is clicked.
4439 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4441 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4442 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4443 * src/maemo/modest-msg-edit-window.c:
4444 (modest_msg_edit_window_insert_image):
4445 * src/modest-conf.c: (modest_conf_key_escape):
4446 * src/modest-mail-operation.c:
4447 (modest_mail_operation_send_new_mail):
4448 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4449 (modest_ui_actions_on_new_account):
4450 * src/widgets/modest-attachment-view.c: (update_filename_request):
4451 * src/widgets/modest-mail-header-view.c:
4452 Corrected warnings that were breaking the build, by commenting out unused variables,
4453 and a function, and by including a header.
4455 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4457 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4458 so we can #ifdef around platform-specific code when necessary.
4459 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4460 to allow this to build for the GNOME platform too.
4462 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4464 * src/maemo/easysetup/modest-easysetup-wizard.c:
4465 Added util_increment_name() and used it in create_page_account_details()
4466 to make sure that the default account name is always a new name.
4468 (modest_easysetup_wizard_dialog_init),
4469 (set_default_custom_servernames): Some minor memory management fixes.
4471 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4475 * src/modest-runtime.c: (init_i18n): Restored the translation
4476 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4477 are defined in config.h, and the translations are installed.
4479 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4480 is defined for translation.
4482 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4484 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4486 * src/maemo/easysetup/modest-easysetup-wizard.c:
4487 (modest_easysetup_wizard_dialog_init):
4488 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4489 Use realistic paths (though they should use $prefix generically) to the
4490 mcc_mapping and provider-data.keyfile files which might work when they
4491 are installed by the future version of the operator-wizard package,
4492 and then fallback to paths in our source code, with an explanatory
4495 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4499 * src/maemo/Makefile.am:
4500 * src/maemo/easysetup/: Added files from the previously-exernal
4501 osso-modest-easysetup.
4502 * src/maemo/modest-main-window-ui.h:
4503 * src/modest-ui-actions.c:
4504 * src/modest-ui-actions.h:
4505 Added modest_ui_actions_on_new_account() as a signal handler for the
4506 New Account menu item. It shows the easysetup wizard.
4507 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob