git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * Makefile.am:
   4         * configure.ac:
   5         * libmodest-dbus-client/Makefile.am:
   6         * libmodest-dbus-client/libmodest-dbus-client.c:
   7         * libmodest-dbus-client/libmodest-dbus-client.h:
   8         * tests/dbus_api/Makefile.am:
   9         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
  10         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
  11
  12 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  13
  14         * src/maemo/easysetup/modest-easysetup-wizard.c:
  15         (create_page_account_details):
  16         * src/maemo/modest-account-settings-dialog.c:
  17         (create_page_account_details): Explicitly set auto-capitalization mode for the title
  18         widgets, because this might not be the default in future versions of the Maemo GTK+.
  19         However, I can not not get capitalization to work even in a simple test case.
  20
  21 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  22
  23         * src/maemo/easysetup/modest-easysetup-wizard.c:
  24         (create_page_custom_incoming), (create_page_custom_outgoing):
  25         * src/maemo/modest-account-settings-dialog.c:
  26         (create_page_account_details), (create_page_incoming),
  27         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
  28         instead of using gtk_check_button_with_label(), so they are aligned like the other
  29         widgets, as per the UI spec.
  30
  31 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  32
  33         * src/maemo/easysetup/modest-easysetup-wizard.c:
  34         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  35         * src/widgets/modest-validating-entry.c:
  36         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
  37         Modest prefix instead of an EasySetup prefix.
  38
  39 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  40
  41         * src/widgets/modest-validating-entry.h:
  42         * src/widgets/modest-validating-entry.c: (on_insert_text),
  43         Added easysetup_validating_entry_set_max_func(), used to set a callback
  44         to call when the max number of characters is reached. GtkEntry has a max-length
  45         already but is silent about it.
  46
  47         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
  48         (create_page_account_details), (create_page_user_details),
  49         (create_account):
  50         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
  51         (create_page_account_details), (create_page_user_details),
  52         (create_page_outgoing):
  53         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
  54         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
  55         the UI spec, when the user tries to enter more than the max number of characters.
  56
  57 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  58
  59         * src/maemo/easysetup/modest-easysetup-wizard.c:
  60         (create_page_user_details), (create_page_custom_incoming),
  61         (create_page_custom_outgoing):
  62         * src/maemo/modest-account-settings-dialog.c:
  63         (create_page_user_details), (create_page_incoming),
  64         (create_page_outgoing):
  65         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  66         (modest_connection_specific_smtp_edit_window_init):
  67         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
  68         not appropriate. Bad Maemo-specific defaults!.
  69
  70 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  71
  72         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
  73         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
  74         (modest_signature_editor_dialog_set_settings):
  75         Disable the label and textview when the checkbox is disabled, and use the
  76         specified (UI spec) default signature text.
  77
  78 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  79
  80         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  81         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
  82
  83         * src/modest-defs.h:
  84         * src/modest-account-mgr-helpers.h:
  85         * src/modest-account-mgr-helpers.c:
  86         Added modest_account_mgr_get/set_signature(), using new gconf keys.
  87
  88         * src/maemo/Makefile.am:
  89         * src/maemo/modest-signature-editor-dialog.c:
  90         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
  91         as per the UI spec.
  92
  93         * src/maemo/modest-account-settings-dialog.h:
  94         * src/maemo/modest-account-settings-dialog.c:
  95         (modest_account_settings_dialog_finalize), (on_button_signature),
  96         (save_configuration): Use the new dialog when the Edit button is pressed, and
  97         save the changes if necessary, as per the UI spec.
  98
  99 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 100
 101         * src/maemo/Makefile.am:
 102         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 103         based on maemo-develoers email from Dirk.
 104
 105         * src/maemo/easysetup/modest-easysetup-wizard.c:
 106         (create_page_welcome), (create_page_account_details),
 107         (create_page_user_details), (create_page_complete_easysetup),
 108         (create_page_custom_incoming), (create_page_custom_outgoing),
 109         (create_page_complete_custom),
 110         (modest_easysetup_wizard_dialog_init):
 111         * src/maemo/modest-account-settings-dialog.c:
 112         (create_page_account_details), (create_page_user_details),
 113         (create_page_incoming), (create_page_outgoing),
 114         (modest_account_settings_dialog_init):
 115         * src/maemo/modest-connection-specific-smtp-window.c:
 116         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 117
 118 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 119
 120         * src/maemo/easysetup/modest-easysetup-wizard.c:
 121         (create_page_account_details), (create_page_custom_outgoing),
 122         (create_page_complete_custom):
 123         * src/maemo/modest-account-settings-dialog.c:
 124         (create_page_user_details), (create_page_incoming),
 125         (create_page_outgoing):
 126         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 127         (modest_connection_specific_smtp_edit_window_init):
 128         Use the correct (UI spec) port min/max, and use horizontal separators,
 129         as per the UI spec.
 130
 131 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 132
 133         * src/maemo/easysetup/modest-easysetup-wizard.c:
 134         (set_default_custom_servernames):
 135         * src/maemo/modest-account-settings-dialog.c:
 136         (create_page_incoming), (on_combo_outgoing_security_changed),
 137         (on_combo_incoming_security_changed), (create_page_outgoing),
 138         (modest_account_settings_dialog_set_account_name),
 139         (save_configuration):
 140         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 141         (on_combo_security_changed),
 142         (modest_connection_specific_smtp_edit_window_init),
 143         (modest_connection_specific_smtp_edit_window_set_connection),
 144         (modest_connection_specific_smtp_edit_window_get_settings):
 145         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 146         as per the UI spec.
 147
 148 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 149
 150         * po/en_GB.po:
 151         * src/maemo/easysetup/modest-easysetup-wizard.c:
 152         (create_page_custom_outgoing), (create_page_complete_custom):
 153         * src/maemo/modest-account-settings-dialog.c:
 154         (create_page_user_details), (create_page_outgoing):
 155         * src/maemo/modest-account-view-window.c: (button_box_new):
 156         Use changed logical IDs as per the most recent UI spec:
 157         mcen_bd_emailsetup_edit -> mcen_bd_edit
 158         mcen_bd_emailsetup_delete -> mcen_bd_delete
 159         mcen_bd_emailsetup_close -> mcen_bd_close
 160
 161 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 162
 163         * configure.ac:
 164         * src/Makefile.am:
 165         * src/dbus_api/Makefile.am:
 166         * src/dbus_api/modest-dbus-callbacks.c:
 167         * src/dbus_api/modest-dbus-callbacks.h:
 168         * src/maemo/modest-platform.c: (modest_platform_init):
 169         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 170         method.
 171         * tests/Makefile.am:
 172         * tests/dbus_api/Makefile.am:
 173         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 174
 175 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 176
 177         * src/maemo/modest-account-settings-dialog.c:
 178         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 179         Removed unnecessary includes.
 180
 181 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 182
 183         * src/maemo/easysetup/modest-easysetup-wizard.c:
 184         * src/maemo/modest-account-settings-dialog.c:
 185         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 186         * src/widgets/Makefile.am:
 187         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 188         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 189         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 190         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 191         * src/widgets/modest-secureauth-combo-box.c:
 192         * src/widgets/modest-secureauth-combo-box.h:
 193         * src/widgets/modest-serversecurity-combo-box.c:
 194         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 195         made the GObject names more consistent with the rest of the Modest code.
 196
 197 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 198
 199         * src/maemo/easysetup/Makefile.am:
 200         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 201         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 202         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 203         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 204         * src/maemo/easysetup/modest-easysetup-wizard.c:
 205         * src/maemo/easysetup/modest-validating-entry.c:
 206         * src/maemo/easysetup/modest-validating-entry.h:
 207         * src/maemo/modest-account-settings-dialog.c:
 208         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 209         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 210         widgets/ because they are used outside of easysetup too. After checking in,
 211         svn will allow me to rename them too.
 212
 213 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 214
 215         * src/gnome/modest-msg-edit-window.c:
 216         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 217         linker error, to fix the build on the GNOME platform.
 218         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 219         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 220         ifdefed out to avoid a warning.
 221
 222 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 223
 224         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 225         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 226         some alternative for GTK+ 2.6.
 227
 228 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 229
 230         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 231
 232         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 233         specified for EmailAccountsDialog in UI spec.
 234
 235         * src/maemo/easysetup/modest-easysetup-wizard.c:
 236         * src/maemo/easysetup/modest-easysetup-wizard.h:
 237         * src/maemo/modest-account-settings-dialog.c:
 238         * src/maemo/modest-account-settings-dialog.h:
 239         Reuse a member window widget for the connection-specific SMTP server accounts,
 240         so we can tell it to create/save the accounts only if we actually save changes.
 241
 242         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 243         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 244         (modest_connection_specific_smtp_edit_window_get_settings):
 245         Return a struct instance for temporarily remembering the entered data.
 246
 247         * src/maemo/modest-connection-specific-smtp-window.h:
 248         * src/maemo/modest-connection-specific-smtp-window.c:
 249         (modest_connection_specific_smtp_window_finalize),
 250         (modest_connection_specific_smtp_window_fill_with_connections),
 251         (on_button_edit),
 252         (modest_connection_specific_smtp_window_save_server_accounts),
 253         (update_model_server_names): Do not actually save data until asked,
 254         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 255
 256         (on_selection_changed),
 257         (modest_connection_specific_smtp_window_init): Disable the edit
 258         button when nothing is selected.
 259
 260         * src/modest-account-mgr-helpers.c:
 261         * src/modest-account-mgr-helpers.h:
 262         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 263         elsewhere.
 264
 265 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 266
 267         * src/modest-account-mgr-helpers.h:
 268         * src/modest-account-mgr-helpers.c:
 269         (modest_account_mgr_get_unused_account_name),
 270         (modest_account_mgr_get_unused_account_display_name): Added these
 271         utility functions, to avoid code duplication.
 272
 273         * src/maemo/easysetup/modest-easysetup-wizard.c:
 274         (create_page_account_details), (create_account):
 275         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 276         (on_combo_security_changed),
 277         (modest_connection_specific_smtp_edit_window_init),
 278         (modest_connection_specific_smtp_edit_window_save_settings):
 279         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 280         * src/maemo/modest-connection-specific-smtp-window.c:
 281         (modest_connection_specific_smtp_window_finalize),
 282         (modest_connection_specific_smtp_window_fill_with_connections),
 283         (on_button_edit), (modest_connection_specific_smtp_window_init):
 284         * src/maemo/modest-connection-specific-smtp-window.h:
 285         Implementing saving of connection-specific server accounts.
 286
 287         But I need to refactor this so we can save the data for each
 288         possible connection-specific account and only actually create the server accounts
 289         when the easysetup finished, or the OK button is pressed on the account settings
 290         dialog.
 291
 292 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 293
 294         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 295         (on_combo_security_changed):
 296         (modest_connection_specific_smtp_edit_window_init):
 297         Auto-fill the port number as in the account settings.
 298
 299         (modest_connection_specific_smtp_edit_window_set_connection):
 300         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 301         * src/maemo/modest-connection-specific-smtp-window.c:
 302         (fill_with_connections), (on_button_edit),
 303         (modest_connection_specific_smtp_window_init):
 304         Turn the edit window into a dialog to simplify the code, and
 305         set a WM hint as in a GtkDialog, because only a popup can be on top of
 306         another window in Maemo, and popups usually have no WM decoration.
 307
 308         * src/modest-defs.h:
 309         * src/modest-account-mgr-helpers.c:
 310         (modest_account_mgr_set_connection_specific_smtp),
 311         (modest_account_mgr_remove_connection_specific_smtp),
 312         (modest_account_mgr_get_connection_specific_smtp):
 313         * src/modest-account-mgr-helpers.h: Some functions to write the
 314         connection-specific SMTP server information. Not yet used.
 315
 316
 317         * src/widgets/modest-folder-view.c: (text_cell_data):
 318         Fix a warning about an uninitialized variable.
 319         (on_configuration_key_changed): Put an #ifdef around the use
 320         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 321
 322 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 323
 324         * src/maemo/modest-account-settings-dialog.h:
 325         * src/maemo/modest-account-settings-dialog.c:
 326         Added connect_for_modified() utility function to mark the new modified boolean.
 327
 328         (create_page_account_details), (create_page_user_details),
 329         (create_page_incoming), (create_page_outgoing), (on_response),
 330         (modest_account_settings_dialog_init),
 331         (modest_account_settings_dialog_set_account_name):
 332         Only warn about unsaved changes when there are actually unsaved changes.
 333
 334         * src/modest-account-mgr-helpers.c:
 335         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 336         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 337         to get the data from there in future.
 338
 339 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 340
 341         * src/modest-defs.h:
 342
 343         * src/modest-account-mgr-helpers.h:
 344         * src/modest-account-mgr-helpers.c:
 345         Store the security account setting in a single conf key instead of using
 346         the options list, so that the list is left for just the to-be-removed camel hack,
 347         and because gconf_client_set_list() is failing for some reason.
 348
 349         * src/modest-account-mgr.c:
 350         (modest_account_mgr_add_server_account):
 351         * src/maemo/modest-account-settings-dialog.c:
 352         (modest_account_settings_dialog_set_account_name),
 353         (save_configuration): Use the renamed functions.
 354
 355
 356 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 357
 358         * src/widgets/Makefile.am:
 359         * src/widgets/modest-limit-retrieve-combo-box.c:
 360         * src/widgets/modest-limit-retrieve-combo-box.h:
 361         * src/widgets/modest-retrieve-combo-box.c:
 362         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 363         the account settings dialog.
 364
 365         * src/modest-defs.h:
 366         * src/modest-account-mgr-helpers.h:
 367         * src/modest-account-mgr-helpers.c:
 368         (modest_server_account_get_option_secure_auth),
 369         (modest_server_account_set_option_secure_auth):
 370         * src/modest-account-mgr.c:
 371         (modest_account_mgr_add_server_account):
 372         Use the existing AUTH_MECH conf key for the secure-auth setting,
 373         instead of putting it in the list options, because this was actually used already.
 374
 375         * src/maemo/modest-account-settings-dialog.c:
 376         (create_page_account_details),
 377         (modest_account_settings_dialog_set_account_name),
 378         (save_configuration):
 379         * src/maemo/modest-account-settings-dialog.h:
 380         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 381         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 382
 383 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 384
 385         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 386         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 387         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 388
 389         * src/modest-defs.h:
 390         * src/maemo/modest-account-settings-dialog.c:
 391         (create_page_incoming), (on_combo_outgoing_security_changed),
 392         (on_combo_incoming_security_changed), (create_page_outgoing),
 393         (modest_account_settings_dialog_set_account_name),
 394         (save_configuration): Load/Save the port number, and change it when the
 395         security combo changes, to suitable defaults.
 396
 397 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 398
 399         * src/modest-account-mgr.c:
 400         (modest_account_mgr_add_server_account): Set the security and secure-auth
 401         options, and add a comment saying that the other camel-specific options should be
 402         removed in future.
 403
 404 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 405
 406         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 407         found by valgrind.
 408         * src/modest-tny-account-store.c: (account_list_free),
 409         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 410         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 411         easy to fix.
 412
 413 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 414
 415         * src/modest-protocol-info.c:
 416         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 417         is required by our UI spec. Maybe something in our implementation will use this eventually.
 418         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 419         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 420         instead of the previous 0 placeholder.
 421
 422         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 423         secure-auth settings.
 424         * src/modest-account-mgr-helpers.h:
 425         * src/modest-account-mgr-helpers.c:
 426         (modest_server_account_data_get_option_secure_auth),
 427         (modest_server_account_set_option_secure_auth),
 428         (modest_server_account_data_get_option_security),
 429         (modest_server_account_set_option_security): Added this API for getting and setting the security
 430         and secure-auth settings.
 431
 432         * src/maemo/modest-account-settings-dialog.h:
 433         * src/maemo/modest-account-settings-dialog.c:
 434         (modest_account_settings_dialog_finalize), (check_data),
 435         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 436         about changing titles.
 437         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 438         (save_configuration): Save the security and secure-auth settings.
 439
 440         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 441         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 442
 443 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 444
 445         * src/modest-defs.h:
 446         * src/modest-account-mgr.c:
 447         (modest_account_mgr_add_server_account):
 448         Added and used defines for the options key and value pair strings,
 449         that are used so far, though they do not seem to correspond to anything in our
 450         UI specs or ModestProtocol enum.
 451
 452         * src/modest-account-mgr-helpers.h:
 453         * src/modest-account-mgr-helpers.c:
 454         (compare_option_strings_for_name),
 455         (modest_server_account_data_get_option_value),
 456         (modest_server_account_data_get_option_bool),
 457         (modest_account_mgr_get_server_account_option):
 458         Added helper functions for parsing the options GSList.
 459
 460 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 461
 462         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 463         display name is based on the supplied account name.
 464         * src/modest-account-mgr.c:
 465         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 466         with an inefficient, but good-enough, implementation.
 467
 468         * src/maemo/easysetup/modest-easysetup-wizard.c:
 469         (create_page_account_details), (on_before_next), (create_account):
 470         Check for existing display names rather than (non-user-visible) account names, and just
 471         create and set a unique account name at the end.
 472
 473         * src/maemo/modest-account-settings-dialog.c:
 474         (modest_account_settings_dialog_init),
 475         (modest_account_settings_dialog_set_account_name),
 476         (create_page_incoming): Show the display name, instead of the account name.
 477         (on_response): Do some (not all) extra checks, as in the UI spec.
 478         (save_configuration): Save the display name if it was changed.
 479
 480 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 481
 482         * po/en_GB.po: Added needed logical ID and translation.
 483         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 484         (init_view): Made the is-default column clicking work.
 485
 486 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 487
 488         * configure.ac:
 489         * src/maemo/easysetup/Makefile.am:
 490         * src/maemo/easysetup/modest-easysetup-wizard.c:
 491         (modest_easysetup_wizard_dialog_init):
 492         * src/maemo/easysetup/provider-data-test.keyfile:
 493         * src/maemo/easysetup/provider-data.keyfile:
 494         Moved the provider data file to the new modest-providers-data package and used it from there.
 495
 496 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 497
 498         * src/modest-local-folder-info.c:
 499         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 500         N_() was already used on the static strings, but this just marks it for translation without
 501         using the translation.
 502
 503 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 504
 505         * src/maemo/modest-account-settings-dialog.c:
 506         (create_page_incoming),
 507         (modest_account_settings_dialog_set_account_name):
 508         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 509         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 510         I will do this if nobody else gets there first.
 511
 512 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 513
 514         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 515         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 516         save the security stuff.
 517
 518 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 519
 520         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 521         Set the email address and user fullname, which I now see must be
 522         done separately.
 523
 524         * src/maemo/modest-account-settings-dialog.h:
 525         * src/maemo/modest-account-settings-dialog.c:
 526          (on_response),
 527         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 528         leave-on-server and authentication.
 529         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 530         how to do the rest.
 531
 532 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 533
 534
 535         * src/maemo/modest-account-settings-dialog.c:
 536         * src/maemo/modest-account-settings-dialog.h:
 537         Most (but not all) of the widgets are now present as specified by the UI spec.
 538         No changes are yet saved, and some details are not properly shown yet.
 539
 540         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 541
 542 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 543
 544         * src/maemo/Makefile.am:
 545         * src/maemo/modest-account-settings-dialog.c:
 546         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 547         an existing account. Doesn't do much yet.
 548
 549         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 550         Open the accounts settings dialog when Edit is clicked.
 551
 552 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 553
 554         * src/maemo/easysetup/Makefile.am:
 555         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 556         (load_from_file):
 557         * src/maemo/easysetup/modest-easysetup-wizard.c:
 558         (modest_easysetup_wizard_dialog_init):
 559         Try to get the source directory from the build system,
 560         instead of hard-coding "./" into the source code, when opening our local
 561         copies of the configuration files.
 562         But this still fails when opening the wizard from the Accounts window,
 563         maybe because the working directory seems to change at runtime.
 564         So the wizard will fail the second time unless you copy the files into their
 565         proper locations - see the stdout warnings for the paths.
 566
 567         (create_page_account_details),(on_before_next):
 568         Check for existing non-server accounts instead of server accounts,
 569         so the default account name is useful again, and to prevent trying to
 570         recreate accounts.
 571
 572         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 573         Show the wizard when New is clicked.
 574
 575         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 576         (init_view): Show the column headers, and show the columns that are
 577         specified in the UI specs. However, something in Maemo's GTK+ prevents
 578         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 579         change the default account. This is despite unsetting the special properties.
 580
 581 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 582
 583         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 584         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 585         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 586         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 587         to make that clearer.
 588         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 589
 590 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 591
 592         * src/maemo/modest-account-view-window.c:
 593         (modest_account_view_window_init),
 594         (modest_account_view_window_new):
 595         Use the same buttons as specified in the
 596         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 597         the existing widgets, which never had a chance of working.
 598         Put the ModestAccountView treeview in a scrolled window.
 599         Do not repeat the initialization in both _init() and _new().
 600
 601         * src/widgets/modest-account-view.c: (update_account_view):
 602         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 603         this widget and window shows no accounts.
 604
 605         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 606
 607 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 608
 609         * src/maemo/easysetup/modest-easysetup-wizard.c:
 610         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 611         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 612         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 613         which seems wrong.
 614
 615         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 616         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 617         accounts exist yet, as in the UI spec.
 618
 619         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 620
 621 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 622
 623         * src/maemo/Makefile.am:
 624         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 625         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 626         New window for editing connection-specific smtp details.
 627         Not fully implemented.
 628
 629         * src/maemo/modest-connection-specific-smtp-window.c:
 630         (modest_connection_specific_smtp_window_finalize) :
 631         unref the tree model.
 632         (on_button_edit): Show the edit window.
 633
 634 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 637         error for me.
 638
 639         * src/maemo/Makefile.am:
 640         * src/maemo/modest-connection-specific-smtp-window.c:
 641         * src/maemo/modest-connection-specific-smtp-window.h:
 642         New window for showing the list of connections, for connection-specific
 643         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 644         * src/maemo/easysetup/modest-easysetup-wizard.c:
 645         (create_page_custom_outgoing): Show the new window when the button is clicked.
 646
 647 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 650         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 651         * src/maemo/modest-msg-edit-window.c:
 652         (modest_msg_edit_window_insert_image):
 653         * src/modest-conf.c: (modest_conf_key_escape):
 654         * src/modest-mail-operation.c:
 655         (modest_mail_operation_send_new_mail):
 656         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 657         (modest_ui_actions_on_new_account):
 658         * src/widgets/modest-attachment-view.c: (update_filename_request):
 659         * src/widgets/modest-mail-header-view.c:
 660         Corrected warnings that were breaking the build, by commenting out unused variables,
 661         and a function, and by including a header.
 662
 663 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 664
 665         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 666         so we can #ifdef around platform-specific code when necessary.
 667         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 668         to allow this to build for the GNOME platform too.
 669
 670 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 671
 672         * src/maemo/easysetup/modest-easysetup-wizard.c:
 673         Added util_increment_name() and used it in create_page_account_details()
 674         to make sure that the default account name is always a new name.
 675
 676         (modest_easysetup_wizard_dialog_init),
 677         (set_default_custom_servernames): Some minor memory management fixes.
 678
 679 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 680
 681         * Makefile.am:
 682         * configure.ac:
 683         * src/modest-runtime.c: (init_i18n): Restored the translation
 684         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 685         are defined in config.h, and the translations are installed.
 686
 687         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 688         is defined for translation.
 689
 690 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 691
 692         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 693         (load_from_file):
 694         * src/maemo/easysetup/modest-easysetup-wizard.c:
 695         (modest_easysetup_wizard_dialog_init):
 696         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 697         Use realistic paths (though they should use $prefix generically) to the
 698         mcc_mapping and provider-data.keyfile files which might work when they
 699         are installed by the future version of the operator-wizard package,
 700         and then fallback to paths in our source code, with an explanatory
 701         warning.
 702
 703 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 704
 705         * configure.ac:
 706         * src/Makefile.am:
 707         * src/maemo/Makefile.am:
 708         * src/maemo/easysetup/: Added files from the previously-exernal
 709         osso-modest-easysetup.
 710         * src/maemo/modest-main-window-ui.h:
 711         * src/modest-ui-actions.c:
 712         * src/modest-ui-actions.h:
 713         Added modest_ui_actions_on_new_account() as a signal handler for the
 714         New Account menu item. It shows the easysetup wizard.
 715         * po/en_GB.po: Added additional needed logical IDs and translations.
 716
 717 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 718 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 719