1 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/modest-ui-actions.c:
4 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
5 place and also not necessary.
7 * src/widgets/modest-folder-view.c: (filter_row)
8 Guess folder type and hide Sent & Outbox if necessary.
9 Fixed project.maemo.org NB#57328
11 2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
13 * src/modest-main.c: (main): Only show the UI at the start if
14 the showui command line option was given. For instance,
15 run-standalone src/modest showui
16 Otherwise, we wait for the top_application D-Bus method to
17 be sent by hildon-desktop when the application is selected
19 This allows us to run without a UI when osso-global-search
20 uses our D-Bus methods.
22 2007-07-11 Murray Cumming <murrayc@murrayc.com>
24 * src/dbus_api/modest-dbus-api.h: Added a define for a
25 top-application D-Bus method.
26 * src/dbus_api/modest-dbus-callbacks.c:
28 (modest_dbus_req_handler): Handle the top-application D-Bus
29 method, which might be an undocumented D-Bus signal sent by
30 hildon-desktop when it starts the application from the menu.
31 But I am not sure and I need to test it on the device, because
32 my scratchbox does not have the application in the menu now.
33 This method shows the main window, so that it can be invisible
34 when started, for instance, just for email searching from
37 * src/maemo/modest-main-window.c: (restore_settings),
38 (modest_main_window_new): Do not show the window immediately
39 upon creation. We show it later.
40 * src/modest-widget-memory.c: (save_settings_paned):
41 Try (unsuccessfully) to avoid saving the paned position when
42 it is not even visible.
43 (restore_settings_paned): Do not allow a silly paned position.
44 This seems necessary when not showing the window at first.
46 * tests/dbus_api/Makefile.am:
47 * tests/dbus_api/test_top_application.c: (main): Test for the
50 2007-07-10 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-ui-dimming-rules.c:
53 (modest_ui_dimming_rules_on_new_msg),
54 (modest_ui_dimming_rules_on_reply_msg),
55 (modest_ui_dimming_rules_on_delete_msg),
56 (modest_ui_dimming_rules_on_details),
57 (modest_ui_dimming_rules_on_view_window_move_to),
58 (modest_ui_dimming_rules_on_view_previous),
59 (modest_ui_dimming_rules_on_view_next),
60 (_invalid_folder_for_purge): Added checks before
61 casting the window. This looks like an actual
62 logic error in _invalid_folder_for_purge(), because it
63 tries to use a ModestMainWindow as a message window.
65 2007-07-10 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/modest-account-settings-dialog.c:
68 (show_error): Use the same implementation as in
69 modest-easysetup-wizard.c:
70 (on_entry_invalid_character): The logical ID contains a %s.
71 Guessed what it should be.
72 (on_entry_max), (check_data), (on_response): Adapt to
74 (create_page_account_details): Really call
75 modest_validating_entry_set_func() on the correct widgets.
76 * src/maemo/easysetup/modest-easysetup-wizard.c:
77 (on_entry_invalid_character): Fix the logical ID here too.
78 (create_page_account_details),
79 (create_page_user_details):
81 modest_validating_entry_set_func() on the correct widgets.
83 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
84 Do not try to use the account if it is NULL.
86 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
88 * src/modest-ui-actions.c: (create_move_to_dialog),
89 (modest_ui_actions_on_main_window_move_to),
90 (modest_ui_actions_on_msg_view_window_move_to):
91 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
92 (filter_row), (modest_folder_view_show_non_move_folders):
93 * src/widgets/modest-folder-view.h:
95 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
96 the Sent folder yet as it does not report the correct folder type.
98 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
100 * src/maemo/modest-msg-edit-window.c: (init_window):
103 2007-07-10 Murray Cumming <murrayc@murrayc.com>
105 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
106 Take a parent widget instead of a parent window, and
107 implement this with hildon_banner_show_information() instead.
108 Non-Maemo builds can just ifdef that there.
109 This fixed projects.maemo.org bug NB#62766.
111 (on_entry_invalid_character): Use show_error() again instead
112 of using hildon directly, and use the _CS() macro to use the correct
114 (create_account), (check_for_supported_auth_methods), (on_entry_max):
115 Pass a widget instead od a window to show_error().
117 2007-07-10 Murray Cumming <murrayc@murrayc.com>
119 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
120 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
121 This allows us to show the server name in the error message, fixing
122 projects.maemo.org bug NB#62904.
123 Also, use the appropriate logical ID message for the account protocol.
125 2007-07-10 Murray Cumming <murrayc@murrayc.com>
127 * src/modest-tny-account-store.c: (on_idle_wrong_password):
128 A compilation fix, though the build wasn't broken for me.
130 2007-07-09 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
133 Do not try to unref a NULL folder store, to avoid a runtime warning.
134 This seems to happen sometimes when changing accounts settings.
136 2007-07-09 Murray Cumming <murrayc@murrayc.com>
138 * src/modest-tny-account-store.c:
139 (modest_tny_account_store_instance_init),
140 (modest_tny_account_store_finalize),
141 (on_account_settings_hide), (on_idle_wrong_password):
142 Use a GHashTable to ensure that we only show one account settings
143 dialog per modest account. This avoids us having a dialog open for
144 both the store and transport accounts, or due to repeated get_password()
145 calls that shouldn't happen anyway.
147 2007-07-09 Murray Cumming <murrayc@murrayc.com>
149 * src/maemo/modest-maemo-utils.c: (on_hide),
150 (modest_maemo_show_dialog_and_forget): Handle the response, because
151 the window is not even hidden by default.
153 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
154 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
155 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
156 which seems to prevent some modality problems.
158 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
159 Ignore user cancellation errors.
161 * src/modest-account-mgr-helpers.h:
162 * src/modest-account-mgr-helpers.c:
163 Added modest_server_account_get_password() and
164 modest_server_account_get_has_password() to avoid direct use of
167 * src/maemo/modest-account-settings-dialog.h:
168 * src/maemo/modest-account-settings-dialog.c:
169 (modest_account_settings_dialog_init): Store the notebook so we can
171 Added modest_account_settings_dialog_switch_to_user_info().
173 * src/modest-tny-account-store.c:
174 (get_password): When the password in the account settings is wrong (we think),
175 show the relevant page of the account settings dialog, in the mainloop.
176 However, we currently get many of these at once because cancel does not
178 (forget_password): Do not forget the password
179 from the account settings, because this causes side-effects when
180 tinymail seems to call it at strange time, maybe because of how we
181 are cancelling get_password().
182 (modest_tny_account_store_alert): Ignore user cancellations.
184 2007-07-09 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/modest-maemo-utils.h:
187 * src/maemo/modest-maemo-utils.c:
188 Added modest_maemo_show_information_note_and_forget() for use instead of
189 gtk_dialog_run() when the response is not needed, to avoid an extra
190 mainloop which could cause a hang.
192 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
193 Use the logical IDs for the error message, though they are not
194 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
195 because gtk_dialog_run() caused a hang here (the window did not close).
196 This fixes projects.maemo.org bug NB#62646.
198 2007-07-09 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-account-mgr-helpers.h:
201 * src/modest-account-mgr-helpers.c:
202 Added modest_account_mgr_get_store_protocol().
204 * src/maemo/modest-account-view-window.c:
205 (on_delete_button_clicked): Show different warning text depending on
206 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
207 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
210 2007-07-09 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/modest-msg-edit-window.c:
213 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
214 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
216 2007-07-07 Armin Burgmeier <armin@openismus.com>
218 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
219 ckdg_ib_maximum_characters_reached from correct package.
221 * src/modest-ui-actions.c: Show an error message when a folder could
222 not be created. Tinymail does not give us specific error codes about
223 what has gone wrong, so we assume that a folder with that name
224 already exists, though there might be other reasons.
226 2007-07-06 Murray Cumming <murrayc@murrayc.com>
228 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
229 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
230 give a more exact error message that can be partly translated.
232 2007-07-05 Murray Cumming <murrayc@murrayc.com>
234 * src/maemo/modest-address-book.c:
235 (select_email_addrs_for_contact): Specify a default window size for the
236 select-email-address dialog, so that it is probably big enough for the
237 title. This should fix projects.maemo.org bug NB#62277.
239 2007-07-05 Murray Cumming <murrayc@murrayc.com>
241 * src/maemo/easysetup/modest-easysetup-wizard.c:
242 (create_page_complete_easysetup): Use
243 gtk_widget_set_size() request to ensure that the text wraps
246 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
248 * src/maemo/easysetup/modest-easysetup-wizard.c:
249 (on_entry_invalid_character), (create_page_account_details),
250 (create_page_user_details):
251 Use new API of ModestValidatingEntry. But for some reason the banner is
252 not shown. I will have to investigate that further.
254 * src/widgets/modest-validating-entry.c: (on_insert_text),
255 (modest_validating_entry_set_func):
256 * src/widgets/modest-validating-entry.h:
257 Added a new callback function to be able to react to prevented
258 characters whitespaces to e.g show a banner.
260 2007-07-05 Armin Burgmeier <armin@openismus.com>
262 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
263 notification of HildonNumberEditor instead of remembering the port
264 number. Thanks to Johannes for pointing this out.
266 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
268 * src/maemo/easysetup/modest-easysetup-wizard.c:
269 Check if there are any user changes before showing a confirmation
270 dialog (projects.maemo.org NB#60946)
272 2007-07-05 Armin Burgmeier <armin@openismus.com>
274 * src/maemo/modest-account-settings-dialog.c: Remember custom port
275 number at the beginning of the dialog and set the modified flag at the
276 end if the port number has changed. This is necessary because
277 HildonNumberEditor does not support notification when the value has
280 2007-07-05 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-ui-actions.c:
283 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
284 a connection before asking anything else. Correct the check for the destination
285 folder so that it succeeds when online.
286 This fixed projects.maemo.org bug NB#61645.
288 2007-07-05 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
291 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
292 to fix projects.maemo.org bug NB#62439.
294 2007-07-05 Murray Cumming <murrayc@murrayc.com>
296 * src/modest-tny-account.c: (on_connection_status_changed):
297 Really do not use tny_device_force_offline() here. See the previous comment.
299 2007-07-04 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-tny-account.c: (on_connection_status_changed):
302 Do not use tny_device_force_offline() when tinymail says that something
303 went wrong with the connection. It seems to report this unnecessarily.
305 2007-07-04 Murray Cumming <murrayc@murrayc.com>
307 * src/maemo/modest-connection-specific-smtp-window.c:
308 (modest_connection_specific_smtp_window_init):
309 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
310 does not seem to have any effect in osso 1.1 (though it works in
311 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
313 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
315 * src/maemo/modest-connection-specific-smtp-window.c:
316 Fix UI specification problems with projects.meamo.org NB#60479
318 2007-07-04 Murray Cumming <murrayc@murrayc.com>
320 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
321 clue when this has failed, because the error dialog is not always shown
322 (at least in earlier version).
324 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
325 GError message, because the generic error dialog is not helpful.
327 'This message is not currently available (can't let a new connection go online)'
328 when trying to open an IMAP message.
330 (_modest_ui_actions_open): Offer a connection when some messages would
331 have to be downloaded and we are offline.
333 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
335 * src/widgets/modest-folder-view.c:
336 Don't check for MERGE type anymore as we use the correct type
338 NOTE: For the last two changes you need to update your tinymail copy
339 because of API changes!
341 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
343 * src/modest-tny-local-folders-account.c:
344 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
345 (see projects.maemo.org NB#61580)
347 2007-07-04 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-tny-account.c: (on_connection_status_changed):
350 Commented out the call to modest_platform_connect_and_wait() because this
351 seems to always hang, and I would like to know if this is the only thing
352 that causes a hang when showing the connection dialog.
353 It is not very useful anyway.
355 2007-07-04 Murray Cumming <murrayc@murrayc.com>
357 * src/maemo/modest-msg-view-window.c:
358 (modest_msg_view_window_select_next_message):
360 * src/modest-platform.h:
361 * src/maemo/modest-platform.c:
362 Added modest_platform_connect_and_wait(), which calls
363 tny_maemo_conic_device_connect() always in the main thread, by calling it
364 in an idle handler and waiting for the idle handler to run. It should be
365 in the main thread because it uses GTK+ UI code. It just returns TRUE
366 if the device is already online.
368 There is some nasty code to ensure that subsequent calls to
369 modest_platform_connect_and_wait() just wait for the first one to finish,
370 by checking repeatedly in another idle handler. This is necessary,
371 because other threads (or even the main thread, via another idle handler)
372 can call modest_platform_connect_and_wait() while
373 modest_platform_connect_and_wait() is running.
375 (modest_platform_connect_and_wait_if_network_account),
376 (modest_platform_connect_and_wait_if_network_folderstore):
377 Convenience functions that calls modest_platform_connect_and_wait() if
378 the account or folder might want network access.
380 * src/modest-mail-operation.c:
381 (modest_mail_operation_update_account):
382 * src/modest-ui-actions.c: (download_uncached_messages),
383 (modest_ui_actions_on_rename_folder), (delete_folder),
384 (modest_ui_actions_on_main_window_move_to),
385 (modest_ui_actions_on_msg_view_window_move_to):
386 * src/widgets/modest-folder-view.c:
387 (drag_and_drop_from_folder_view):
388 Offer a connection if we are offline.
390 * src/modest-tny-account.c: (on_connection_status_changed):
391 Document this as only handling errors during network operations in progress,
392 and replace the idle code with a simple call to
393 modest_platform_connect_and_wait(), which does this instead.
395 2007-07-03 Murray Cumming <murrayc@murrayc.com>
397 * src/modest-tny-account.c:
398 (modest_tny_account_get_special_folder): (util_on_idle),
399 Handle the GError so we can see when tny_folder_store_get_folders()
400 fails, as it currently does while something else is connecting.
402 Added util_run_in_main_thread_and_wait()
403 which uses an idlen handler and mainloop to ensure that the function
404 is called in the main thread.
405 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
406 to make sure that we call attempt the connection in the mainloop only,
407 which might solve some hangs.
409 2007-07-03 Murray Cumming <murrayc@murrayc.com>
411 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
412 be found by their display name. This is never useful.
413 * src/modest-tny-account-store.c: (on_account_removed): Find the account
414 by its ID, instead of trying to use its ID as its display name.
416 * src/modest-tny-account-store.h:
417 * src/modest-tny-account.c:
418 (modest_tny_account_get_special_folder): Add a g_warning() when
419 tny_folder_store_get_folders() returns an empty list for the maildir.
421 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
422 Add a g_warning() when this returns NULL, because that it not allowed
425 2007-07-02 Armin Burgmeier <armin@openismus.com>
427 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
428 note when trying to cancel the wizard. This fixes projects.maemo.org
431 2007-07-02 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-tny-account.h:
434 * src/modest-tny-account.c:
435 (modest_tny_account_new_from_server_account),
436 (modest_tny_account_new_from_server_account_name),
437 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
438 because this must now be set before setting the proto. This is usd in
439 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
440 warning in camel_session_get_service() caused by
441 tny_camel_transport_account_prepare().
443 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
446 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
448 * src/maemo/modest-connection-specific-smtp-edit-window.c:
450 (modest_connection_specific_smtp_edit_window_init):
452 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
455 2007-06-29 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-tny-account.c:
458 (modest_tny_account_new_from_server_account):
459 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
460 now uses to request a connection when it needs one, and which it uses
461 to tell us that something is wrong with the connection, so we can force
462 the accounts offline to prevent further problems.
465 * src/modest-init.c: (init_default_settings):
466 * src/modest-mail-operation.c:
467 (modest_mail_operation_update_account):
468 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
469 This should not be necessary anymore. Do not set the conf key that
470 determined this (it was always TRUE and not set anywhere else).
472 * src/modest-ui-actions.h: Remove unused and unimplemented
473 modest_ui_actions_on_online_toggle_toggled().
475 2007-06-29 Murray Cumming <murrayc@murrayc.com
477 * src/maemo/modest-main-window.c: (connect_signals):
478 Don't connect to delete_event twice. Maybe this was harmless.
480 2007-06-29 Murray Cumming <murrayc@murrayc.com
482 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
483 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
484 Debug output to give some more clue when a folder move is not allowed.
486 2007-06-28 Murray Cumming <murrayc@murrayc.com
488 * src/modest-tny-account.c: (on_modest_file_system_info),
489 (modest_tny_account_get_mmc_account_name):
490 Always call the callback, without checking whether the name has changed.
491 * src/widgets/modest-folder-view.c: (strings_are_equal),
492 (on_model_foreach_set_name), (on_get_mmc_account_name),
493 (text_cell_data): Compare the name here, and use the name from
494 the account rather than from the
495 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
496 if the name was changed after the account was added to the model.
497 That's a tinymail bug but not one that I want to fix now.
499 This finally fixes projects.maemo.org bug NB#59301.
501 2007-06-27 Armin Burgmeier <armin@openismus.com>
503 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
506 2007-06-27 Murray Cumming <murrayc@murrayc.com
508 * src/modest-tny-account.h:
509 * src/modest-tny-account.c:
510 Added modest_tny_account_get_mmc_account_name(), to set the memory
511 card name asynchronously for the given account and then notify.
512 (modest_tny_account_new_for_local_folders): Use this new function instead
513 of using hildon_file_system_info_async_new() directly.
515 * src/widgets/modest-folder-view.c: (text_cell_data):
516 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
517 gtk_tree_model_row_changed() when it is available.
519 This should fix projects.maemo.org bug NB#59301.
521 2007-06-27 Murray Cumming <murrayc@murrayc.com
523 * src/modest-mail-operation.c: (update_account_thread),
524 (get_msgs_full_thread): Fix typo failures in the revert
527 2007-06-27 Murray Cumming <murrayc@murrayc.com
529 * src/maemo/modest-maemo-global-settings-dialog.c:
530 (idle_select_default_focus):
531 * src/modest-mail-operation.c: (idle_notify_progress),
532 (idle_notify_progress_once), (set_last_updated_idle),
533 (update_account_thread), (get_msgs_full_thread):
534 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
535 * src/widgets/modest-header-view.c:
536 (idle_notify_headers_count_changed_destroy),
537 (idle_notify_headers_count_changed):
538 Reverted the additions of gdk_threads_enter/leave(), in case this
539 helps with a startup hang on the device.
541 2007-06-26 Armin Burgmeier <armin@openismus.com>
543 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
544 for supported secure authentication methods from server by
545 gtk_dialog_run(), saving CPU time and a potential race condition.
547 2007-06-26 Armin Burgmeier <armin@openismus.com>
549 * src/maemo/modest-maemo-utils.h:
550 * src/maemo/modest-maemo-utils.c: Added a
551 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
552 only error code to tell the calling code when the user canceled the
555 * src/maemo/modest-account-settings-dialog.h:
556 * src/maemo/modest-account-settings-dialog.c:
557 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
558 message if the retrieval of secure authentication methods was canceled
559 by the user. Perform the check before saving anything to configuration
560 to not end up with half-committed configuration changes, do not show
561 a "Saving to configuration failed" note when authentication methods
562 could not be retrieved.
564 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
567 2007-06-26 Murray Cumming <murrayc@murrayc.com>
569 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
570 Only return the first level of folders under accounts, because the
571 osso-global-search UI spec doesn't want the rest.
572 This fixed projects.maemo.org bug NB#61811.
574 2007-06-26 Murray Cumming <murrayc@murrayc.com>
576 * src/modest-tny-account-store.c:
577 * src/modest-tny-account-store.h:
578 Added modest_tny_account_is_memory_card_account().
579 * src/maemo/modest-main-window.c: (create_details_widget):
580 Show the same information items for the memory card as we show for the
581 local-folders, to fix projects.maemo.org bug NB#59307.
583 2007-06-26 Murray Cumming <murrayc@murrayc.com>
585 * src/modest-tny-account-store.c: (get_password):
586 Added some checks for NULL to maybe prevent crashes, though I think
587 it was Philip's last commit that actually prevented the crash here
588 when creating a first new account.
589 But the new account is still not usable (no messages are shown)
590 until a restart of the application.
592 2007-06-26 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/modest-maemo-global-settings-dialog.c:
595 (idle_select_default_focus):
596 * src/modest-mail-operation.c: (idle_notify_progress),
597 (idle_notify_progress_once), (idle_notify_update_account_queue),
598 (set_last_updated_idle), (update_account_thread),
599 (notify_get_msgs_full), (get_msgs_full_destroyer),
600 (get_msgs_full_thread):
601 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
602 * src/widgets/modest-header-view.c:
603 (idle_notify_headers_count_changed_destroy),
604 (idle_notify_headers_count_changed):
605 Use gdk_threads_enter() and gdk_threads_enter_leave() in
606 all idle handlers, because some other thread could be blocking
607 the GDK lock, so that it can do GUI stuff.
609 2007-06-26 Murray Cumming <murrayc@murrayc.com>
611 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
612 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
613 (on_idle_send_receive), (on_idle_open_default_inbox):
614 * src/maemo/modest-msg-edit-window.c:
615 (modest_msg_edit_window_attach_file_noninteractive):
616 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
617 to prevent a hang. I don't quite understand why these are necessary,
618 beause we should already be in the main loop. I guess something outside
619 of the main loop is taking the lock.
621 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
622 we are really using URIs, and use files that are more likely to exist.
624 2007-06-26 Murray Cumming <murrayc@murrayc.com>
626 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
627 necessary because configure.ac now defines different variables.
629 2007-06-26 Murray Cumming <murrayc@murrayc.com>
631 * libmodest-dbus-client/libmodest-dbus-client.c:
632 * libmodest-dbus-client/libmodest-dbus-client.h:
633 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
634 libmodest_dbus_client_compose_mail() is what things actually use.
636 * src/dbus_api/modest-dbus-api.h:
637 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
638 * tests/dbus_api/Makefile.am:
639 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
642 2007-06-26 Murray Cumming <murrayc@murrayc.com>
644 * src/modest-init.c: (modest_init_local_folders):
645 For memory-card (or other non local-folders) maildir accounts,
646 always create an Archive folder, so that there is somewhere to put
647 messages. This should be less confusing, because the user does not need
648 to guess that the need to create a folder.
650 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
652 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
653 Fixed icon size by using (50, 50) which is the same as defined by
656 2007-06-25 Armin Burgmeier <armin@openismus.com>
658 * src/widgets/modest-window-mgr.c:
660 * configure.ac: Correctly recognize hildon-notify presence and fixed
661 the build without it being installed.
663 2007-06-25 Murray Cumming <murrayc@murrayc.com>
665 * libmodest-dbus-client/libmodest-dbus-client.c:
666 (libmodest_dbus_client_search): Fix the build. Sorry.
667 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
668 (reply_forward_cb): Initialize variables to fix the build.
670 * src/modest-tny-account-store.c:
671 (modest_tny_account_store_get_tny_account_by): Fix the account URI
672 comparison (a silly typo) so that email search results can be opened
673 when there are more than one account.
675 2007-06-25 Murray Cumming <murrayc@murrayc.com>
677 * libmodest-dbus-client/libmodest-dbus-client.c:
678 (libmodest_dbus_client_search),
679 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
680 instead of 1 second, because the search gets folders and messages from
681 the server, which can take a long time. When it times out,
682 osso-global-search will report no results.
684 We need to specify whether we should search only cached information
685 (maybe with a user preference), and the osso-email-search-plugin
686 API should really be improved to allow that option, and to allow results
687 to be delivered asynchronously in batches.
689 2007-06-25 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
692 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
693 GTK_ICON_SIZE_DIALOG is probably the wrong size.
695 2007-06-25 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
698 that is an empty string. D-Bus seems to give us these instead of NULL.
700 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
702 * src/dbus_api/modest-dbus-callbacks.c:
703 * src/maemo/easysetup/modest-easysetup-wizard.h:
704 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
706 (modest_connection_specific_smtp_edit_window_init):
707 * src/maemo/modest-maemo-global-settings-dialog.c:
709 * src/maemo/modest-maemo-utils.c:
710 (modest_maemo_utils_setup_images_filechooser):
711 * src/maemo/modest-main-window.c: (create_details_widget):
712 * src/maemo/modest-msg-edit-window.c:
713 (modest_msg_edit_window_attach_file_noninteractive),
714 (modest_msg_edit_window_color_button_change),
715 (modest_msg_edit_window_set_zoom):
716 * src/modest-mail-operation.c: (update_account_thread):
717 * src/modest-tny-account-store.c:
718 * src/modest-tny-account.c:
719 * src/widgets/modest-global-settings-dialog.c:
720 * src/widgets/modest-window.h:
724 2007-06-25 Murray Cumming <murrayc@murrayc.com>
726 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
727 * src/modest-search.c: (modest_search_folder),
728 (modest_search_all_accounts): Actually search only in the specified folder,
729 doing a simple match on the folder ID.
730 * src/modest-search.h: Added a folder field to the ModestSearch struct,
731 and added some documentation.
733 2007-06-22 Armin Burgmeier <armin@openismus.com>
735 * src/maemo/modest-maemo-utils.h:
736 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
737 modest_maemo_utils_get_supported_secure_authentication_methods.
739 * src/maemo/easysetup/modest-easysetup-wizard.c:
740 * src/maemo/modest-account-settings-dialog.c: Show correct error if
741 one occured, not just "Server does not support secure authentication".
743 2007-06-22 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-tny-account-store.c: (get_password):
746 Restored the call to tny_account_set_user() because Philip seems to have
747 stopped this from crashing (by not using the freed string). It still does
748 not work, but now we can test it.
750 2007-06-22 Murray Cumming <murrayc@murrayc.com>
752 * src/maemo/modest-msg-edit-window.c: (init_window):
753 Comment out use of an uninitialzed GtkScrolledWindow variable,
754 to fix the build and stop a crash. Yet again.
756 2007-06-22 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-tny-account-store.c: (get_password):
759 Remove the call to tny_account_set_user() because this actually crashes.
760 As mentioned in the last commit, it is known to not work anyway.
762 2007-06-22 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-tny-account-store.c: (get_password):
765 Use tny_account_set_username() to tell tinymail that the username might
766 have changed too. But tinymail ignores this: see projects.maemo.org
768 * src/modest-ui-actions.c:
769 (modest_ui_actions_on_password_requested): Remove the useless attempt to
770 reset the connection when changing the username, and improve the comments.
771 Save the changed username to gconf at least, so it is used when Modest is
774 2007-06-21 Murray Cumming <murrayc@murrayc.com>
776 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
777 Do not use a query, so that we get all folders, including for POP and
778 local-folders. They work as search criteria too.
779 This fixes projects.maemo.org bug NB#57740.
781 2007-06-21 Murray Cumming <murrayc@murrayc.com>
783 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
784 Comment out the use of hildon_notification_set_sound() because it is
785 not declared, to fix the build. Warnings are serious, people.
787 2007-06-21 Armin Burgmeier <armin@openismus.com>
789 * src/maemo/modest-maemo-utils.h:
790 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
791 modest_maemo_utils_get_supported_secure_authentication_methods()
792 to query authentication methods for a specific user. This should fix
793 projects.maemo.org bug NB#61369.
795 * src/maemo/easysetup/modest-easysetup-wizard.c:
796 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
799 2007-06-21 Murray Cumming <murrayc@murrayc.com>
801 * libmodest-dbus-client/libmodest-dbus-client.h:
802 * libmodest-dbus-client/libmodest-dbus-client.c:
803 (modest_dbus_message_iter_get_search_hit),
804 (libmodest_dbus_client_search):
805 Reorganised and commented this.
806 Removed modest_search_hit_free() from the public API because it
809 Added libmodest_dbus_client_get_folders() and
810 modest_folder_result_list_free().
812 * src/dbus_api/modest-dbus-api.h:
813 * src/dbus_api/modest-dbus-callbacks.c:
814 (modest_dbus_req_filter): Commented. Moved most code to
815 on_dbus_method_search() and added on_dbus_method_get_folders().
817 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
818 of the extra D-Bus handler.
820 * tests/dbus_api/Makefile.am:
821 * tests/dbus_api/test_get_folders.c: New test for
822 libmodest_dbus_client_get_folders(). This seems to return an empty list
823 at the moment. That could be the same error that causes the message list
824 to be empty sometimes.
825 This should help with projects.maemo.org bug NB#57740.
827 2007-06-21 Armin Burgmeier <armin@openismus.com>
829 * src/modest-mail-operation.c: Do not call
830 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
831 notify the operation's end after having set the status to CANCELED for
832 the operation queue to listen on. This fixes a deadlock when there
833 were mail operations in the queue during its finalization.
835 * src/modest-singletons.c: Reordered uninitialization of the account
836 manager to happen after the mail operation queue was uninitialized
837 because the mail operation's in the queue might still try to access
838 the account manager (see modest_mail_operation_notify_end()). This
839 fixes a potential crash when terminating the application.
841 2007-06-21 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-search.c:
844 (search_mime_part_and_child_parts): Moved some code here so we
845 can search recursively in child folders.
846 (modest_search_folder): Search in the message as a mime part, instead
847 of just its child mime parts.
848 (read_chunk), (search_mime_part_ogs):
849 Check how many bytes were read, to prevent an endless loop.
850 Searching in message bodies now works. This finishes the fix for
851 projects.maemo.org bug NB#61007.
853 2007-06-20 Murray Cumming <murrayc@murrayc.com>
855 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
856 Add a g_warning when the item is not a folder.
858 * src/modest-ui-dimming-rules.c:
859 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
860 when selected item is not a folder (for instance, an account), because
861 the UI spec only talks about folders.
862 I am not sure what the UI spec wants, so this might not totally fix
863 projects.maemo.org bug NB#60794.
865 2007-06-20 Murray Cumming <murrayc@murrayc.com>
867 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
868 (load_from_file): Sort the list. The unsorted list would be more noticeable
869 in non-English locales.
871 * src/maemo/modest-msg-edit-window.c:
872 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
873 warning and fix the build.
875 * src/maemo/modest-progress-bar-widget.c:
876 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
877 avoid a g_warning, and probably to avoid a crash.
879 2007-06-20 Murray Cumming <murrayc@murrayc.com>
881 * src/modest-search.c: (modest_search_folder): Check for a GError
882 when calling tny_folder_get_headers(), to show that this is not the cause
885 2007-06-20 Murray Cumming <murrayc@murrayc.com>
887 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
888 Actually set the body query instead of the subject query.
890 * src/modest-search.c: (search_mime_part_ogs),
891 (search_mime_part_strcmp): Remove extra space from the text/* regex,
892 which would probably cause it to fail if we got this far.
894 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
895 to simplify the code.
896 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
897 be causing search-in-body to fail.
899 2007-06-20 Murray Cumming <murrayc@murrayc.com>
901 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
903 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
904 Better debug message when the folder cannot be found.
905 This should help with fixing projects.maemo.org bug #61287.
906 * src/modest-search.c: (add_hit): Do not leak the furl string.
908 2007-06-20 Murray Cumming <murrayc@murrayc.com>
910 * src/modest-ui-actions.c:
911 (modest_ui_actions_on_folder_selection_changed):
912 Do not special-case TNY_MERGE_FOLDER here, because
913 modest_tny_folder_get_account() already does that. This fixes
914 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
915 shown when the Outbox was selected).
917 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
919 * libmodest-dbus-client/libmodest-dbus-client.c:
920 (_dbus_iter_get_string_or_null): Initialize the string variable in
921 case this helps with Dirk's crash.
923 2007-06-19 Murray Cumming <murrayc@murrayc.com>
925 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
926 though it is not implemented yet (this function is maybe not even used),
927 to avoid breaking ABI in future.
928 * libmodest-dbus-client/libmodest-dbus-client.c:
929 (get_attachments_string): Moved some code into this generic function.
930 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
931 sends email. It is maybe not used.
932 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
933 (on_send_mail): Use attachments.
935 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
936 * src/maemo/modest-msg-edit-window.c:
937 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
938 a filename before using it, to fix projects.maemo.org bug NB#58233.
940 2007-06-19 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
943 Initialize the continue_download variable to fix the build, and probably
944 to fix randome behaviour.
946 2007-06-18 Armin Burgmeier <armin@openismus.com>
948 * src/modest-tny-send-queue.h:
949 * src/modest-tny-send-queue.c: Keep track of the status of messages in
950 the queue so we can later show it in the UI. Replaced
951 modest_tny_send_queue_msg_is_being_sent() by
952 modest_tny_send_queue_get_msg_status().
954 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
956 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
957 gpointer. This probably was not harmful, but just to be sure.
959 2007-06-18 Murray Cumming <murrayc@murrayc.com>
961 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
962 Fix the build, but leave the function broken on Bora, because
963 hildon_uri_action_get_service() does not exist.
964 osso_uri_action_get_service() does not exist either, it seems.
966 2007-06-18 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account.c:
969 (modest_tny_account_new_from_server_account):
970 Uncommented the url debug output again, because it is useful for
971 debugging, as I said in the comment.
973 2007-06-18 Murray Cumming <murrayc@murrayc.com>
975 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
977 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
978 for Mameo Bora, to fix the build.
980 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
983 Fixed build with hildon < 0.99
985 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
986 Check if the selected account is busy instead of checking all accounts
988 * src/modest-account-mgr-priv.h:
989 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
990 (modest_account_mgr_init), (compare_account_name),
991 (modest_account_mgr_set_account_busy),
992 (modest_account_mgr_account_is_busy):
993 * src/modest-account-mgr.h:
994 Added busy information to the account manager. It possible to
995 set an account to busy or not busy now.
997 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
998 (modest_mail_operation_update_account),
999 (modest_mail_operation_notify_end):
1000 Set the account to busy/not busy depending on the operation state.
1002 * src/widgets/modest-account-view.c:
1003 (modest_account_view_finalize), (get_last_updated_string),
1004 (update_account_view), (on_account_busy_changed), (init_view):
1005 Show string "Refreshing..." if the account is currently busy.
1007 All this fixes projects.maemo.org bug NB#59711
1009 2007-06-14 Armin Burgmeier <armin@openismus.com>
1011 * src/widgets/modest-attachments-view.h:
1012 * src/widgets/modest-attachments-view.c: Added
1013 modest_attachments_view_has_attachments() and fixed coordinate
1014 transformation in get_att_view_at_coords(). This fixes attachment
1017 * src/widgets/modest-msg-view.c: Make use of
1018 modest_attachments_view_has_attachments() to decide whether to show
1019 attachments in the header.
1021 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1024 (on_change), (on_combo_security_changed),
1025 (modest_connection_specific_smtp_edit_window_init),
1026 (modest_connection_specific_smtp_edit_window_set_connection),
1027 (modest_connection_specific_smtp_edit_window_is_dirty):
1028 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1029 * src/maemo/modest-connection-specific-smtp-window.c:
1032 Show an comfirmation dialog for the smpt-edit-window if there are
1033 unsaved changes and the user hits cancel.
1034 (projects.maemo.org bug NB#60479)
1036 2007-06-14 Armin Burgmeier <armin@openismus.com>
1038 * src/maemo/easysetup/modest-easysetup-wizard.c:
1039 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1040 address" info in banner instead of node, and select all the text as
1041 per UI spec. This fixes projects.maemo.org bug NB#60550.
1043 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1045 reviewed by: <delete if not using a buddy>
1047 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1048 * src/modest-ui-actions.c: (folder_refreshed_cb):
1050 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1052 * src/widgets/modest-folder-view.c: (filter_row):
1053 Explictly filter out the per-account outbox accounts. I don't know why
1054 these only sometimes show up, but now they should never show up in the UI.
1055 This should fix projects.maemo.org bug NB#60160.
1057 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1059 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1060 when the toolbar does not exist yet.
1061 * src/modest-widget-memory.c: (save_settings_header_view):
1062 Added g_warnings() to help us to discover when we are trying to set
1063 an empty columns list in gconf.
1065 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-init.h:
1068 * src/modest-init.c:
1069 Added modest_init_get_default_header_view_column_ids().
1071 * src/modest-widget-memory.c: (restore_settings_header_view):
1072 Use the new function to get defaults, if the gconf key is empty,
1073 instead of not creating any columns. This seems to fix the
1074 empty right-hand pane problems.
1076 * src/widgets/modest-header-view.h: Improved documentation.
1078 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1080 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1081 Revert the use of the display name as the account name, because this
1082 is generally wrong and would break the code that follows.
1084 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1086 * src/maemo/easysetup/modest-easysetup-wizard.c:
1087 (check_for_supported_auth_methods), (on_before_next),
1090 More correct fix for projects.maemo.org bug NB# 58991
1091 Do not longer accept AUTH_PASSWORD as secure method and choose
1092 correct method when creating the account.
1094 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1096 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1097 Fixed projects.maemo.org bug NB# 58991
1099 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-init.c: (modest_init_init_core),
1102 (modest_init_local_folders): Fixed compilation errors.
1104 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1106 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1107 Remove unnecessary lib/include, though it is good in principle when needed.
1109 * src/modest-init.c: (modest_init_one_local_folder),
1110 (modest_init_local_folders):
1111 * src/modest-init.h: Initialize the .modest library for memory cards,
1112 instead of just doing nothing for them. This should allow us to create
1113 folders there, fixing projects.maemo.org bug NB#59297.
1115 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1117 * libmodest-dbus-client/libmodest-dbus-client.c:
1118 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1119 (libmodest_dbus_client_compose_mail),
1120 (libmodest_dbus_client_open_message),
1121 (libmodest_dbus_client_send_and_receive),
1122 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1124 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1125 (on_idle_open_message), (modest_dbus_req_handler),
1126 (search_result_to_message), (modest_dbus_req_filter):
1127 * src/modest-search.c: (add_hit), (modest_search_folder),
1128 (modest_search_all_accounts): Improved debug messages.
1130 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1132 * src/modest-tny-account-store.c:
1133 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1136 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1139 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-tny-account-store.c: (get_server_accounts):
1142 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1143 even when there are no accounts, so that the Outbox folder is always
1144 visible. This fixes projects.maemo.org bug NB#60158.
1146 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1148 * src/maemo/modest-main-window.c: (create_details_widget):
1149 Use the mcen_va_never logical ID.
1151 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1153 * src/dbus_api/modest-dbus-api.h:
1154 * src/dbus_api/modest-dbus-callbacks.c:
1155 (on_idle_open_default_inbox), (on_open_default_inbox),
1156 (modest_dbus_req_handler):
1157 Added a new OpenDefaultInbox method.
1159 * libmodest-dbus-client/libmodest-dbus-client.h:
1160 * libmodest-dbus-client/libmodest-dbus-client.c:
1161 Added libmodest_dbus_client_open_default_inbox() to call the new
1162 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1163 though it should maybe be used by a new osso-email-interface function.
1165 * tests/dbus_api/Makefile.am:
1166 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1169 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1172 NULL, so that the signals get all the keys. This should not actually
1173 change any behaviour because we currently update everything when anything
1176 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1178 * src/widgets/modest-folder-view.c: (text_cell_data),
1179 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1180 (find_inbox_iter): If tinymail tells us that the folder is
1181 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1182 This causes the inbox to be selected at startup, fixing part of
1183 projects.maemo.org bug NB#56305.
1185 * src/modest-ui-dimming-rules.c:
1186 (modest_ui_dimming_rules_on_tools_smtp_servers):
1187 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1188 the SMTP servers menu item.
1189 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1190 that the SMTP Servers menu item is dimmed when there are no accounts,
1191 as a future version of the UI spec will require. This fixes
1192 projects.maemo.org bug NB#56305.
1194 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1196 * src/maemo/modest-maemo-utils.c:
1197 (modest_maemo_utils_get_supported_secure_authentication_methods):
1198 Added label to dialog instead of unreadable title
1200 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1201 (modest_main_window_new):
1202 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1205 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1206 * src/modest-account-mgr.h:
1207 Added method to avoid code duplication
1209 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1210 (modest_ui_actions_on_send_receive):
1211 Use modest_account_mgr_has_accounts
1213 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1215 * src/maemo/easysetup/modest-presets.c:
1216 (modest_presets_get_info_server_security): Do not report secure auth
1218 * src/modest-protocol-info.c: Use the defines for the gconf key names
1219 for secure authentication. This was not working because we were writing
1220 Password and reading password, and the check was case sensitive.
1221 With this, gmail now works for receiving and sending when created via
1224 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1226 * src/maemo/easysetup/modest-presets.c:
1227 (modest_presets_get_info_server_security): Correct the key name for
1228 SecureSmtp, because it seems to be case-sensitive.
1229 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1230 Do not try to get the 0th notebook page if there are 0 pages, to
1231 avoid a g_warning().
1233 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1235 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1236 Prevent use of the new notification feature for now, because it currently
1237 shows one dialog for each new email, which is annoying.
1239 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1241 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1242 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1243 when no country was selected, so that we show the global ones.
1244 * src/maemo/easysetup/modest-presets.c:
1245 (modest_presets_get_providers): Return only the global providers, not
1246 all providers when mmc=0 was requested.
1248 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1250 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1251 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1252 provider ID in the combo.
1254 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1255 Do not show the page numbers, because it would be confusing when we add
1256 the 2 extra pages for the custom setup, when the user chooses the "Other"
1257 provider. This fixes projects.maemo.org bug NB#59028
1259 * src/modest-init.c: (modest_init_init_core),
1260 (modest_init_local_folders):
1261 * src/modest-init.h:
1262 * src/modest-tny-account.c:
1263 (modest_tny_account_new_for_local_folders): Do not create default folders
1264 for the memory card. This should fix projects.maemo.org bug NB#59328.
1266 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1268 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1269 Free the changed_conf_keys string items. They are already freed in the
1270 idle handler if that runs first.
1272 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-ui-actions.c:
1275 (modest_ui_actions_on_password_requested): Check that the server name
1276 is not NULL, because I just saw a password dialog with (null) as the
1279 * src/modest-tny-folder.[h|c]: Added
1280 modest_tny_folder_is_memory_card_folder().
1281 * src/modest-ui-dimming-rules.c:
1282 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1283 menu item for memory cards, as per the UI spec (section 7.4). This should
1284 fix projects.maemo.org bug NB#59297.
1286 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1288 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1289 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1290 is another problem with the code, see Murray's comment at line 772)
1292 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1294 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1295 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1296 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1297 (load_from_file), (easysetup_country_combo_box_init),
1298 (easysetup_country_combo_box_get_active_country_ids),
1299 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1300 instead of just one ID, to avoid duplicate country names in the UI.
1302 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1303 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1304 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1305 a single ID, avoiding duplicate providers.
1306 * src/maemo/easysetup/modest-easysetup-wizard.c:
1307 (on_combo_account_country): Adapt to use a list.
1309 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1311 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1312 keys changed in the last X seconds.
1314 * src/modest-account-mgr.h:
1315 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1316 (on_key_change), (modest_account_mgr_class_init),
1317 (modest_account_mgr_init), (modest_account_mgr_finalize):
1318 As the keys are changed, save them in a GSList* and signal that GSList*
1319 further every X seconds, to batch changes, to allow us to do just one
1320 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1321 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1323 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1324 changed signal signature.
1326 * src/modest-conf.c: (modest_conf_set_list),
1327 (modest_conf_on_change): Reenable notification.
1329 (modest_conf_maemo_fake_on_change): Comment out the hack that
1330 notified immediately instead of asynchronously.
1332 * src/widgets/modest-account-view.h:
1333 * src/widgets/modest-account-view.c:
1334 (update_account_view): Select the previously-selected account ID,
1335 if possible. This fixes projects.maemo.org bug NB#56933.
1337 (on_account_changed), (on_account_removed),
1338 (modest_account_view_select_account):
1340 Remove the block/unblock functions
1341 because they were not useful.
1343 * src/maemo/modest-account-view-window.c:
1344 (on_delete_button_clicked), (on_edit_button_clicked),
1345 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1347 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1349 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1350 Improve the error dialog to show Incorrect Account Settings, which seems
1351 clearer, and say that the internal error message (to be removed from the
1352 dialog later) is often misleading.
1353 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1355 * src/modest-tny-account.c:
1356 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1357 URL because this is so useful for debugging on the device.
1359 * src/widgets/modest-serversecurity-combo-box.c:
1360 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1362 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-mail-operation.c:
1365 (modest_mail_operation_send_new_mail):
1366 Added a comment about a nasty but apparently harmless message. Details
1367 added to the wiki g_warnings() page.
1369 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1371 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1372 (modest_tny_send_queue_class_init):
1373 Do not use the priv struct because it is empty, to avoid g_warnings
1374 about a non-existant priv struct.
1376 * src/modest-tny-account-store.c:
1377 (modest_tny_account_store_get_server_account),
1378 (modest_tny_account_store_get_transport_account_for_open_connection
1379 ): Do not try to get transport server accounts for local folders,
1380 because they don't have any. This avoids a g_warning().
1382 * src/maemo/modest-main-window.c:
1383 (modest_main_window_notify_send_receive_initied),
1384 (on_configuration_key_changed):
1385 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1386 * src/modest-defs.h:
1387 * src/modest-mail-operation.c:
1388 (modest_mail_operation_update_account):
1389 * src/modest-tny-account-store.h:
1390 * src/modest-tny-account.c:
1391 (modest_tny_account_get_special_folder),
1392 (modest_tny_account_new_for_local_folders),
1393 (modest_tny_account_new_for_per_account_local_outbox_folder):
1394 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1395 * src/modest-tny-local-folders-account.c:
1396 (add_account_folders_to_merged_folder):
1397 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1398 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1399 (modest_ui_actions_on_send):
1400 * src/widgets/modest-folder-view.c: (update_model):
1401 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1402 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1403 modest_tny_account_store_get_tny_account_by_account() to
1404 modest_tny_account_store_get_server_account() to make the code clearer.
1406 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1408 * src/dbus_api/modest-dbus-api.h:
1409 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1410 * src/maemo/modest-msg-edit-window.c:
1411 (modest_msg_edit_window_attach_file_noninteractive):
1412 added g_warning in case the file to be attached does not exist
1413 * tests/dbus_api/test_compose_mail.c: (main):
1414 removed obsolete comment, added generic files as test case
1416 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1418 * src/modest-tny-account-store.c: (get_server_accounts):
1419 Create the local folders account only once, not once for each outbox, and
1420 not only when there are some outboxes.
1422 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1424 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1425 code that is causing a crash at startup. Sergio says that he is fixing this.
1427 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1429 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1430 * src/maemo/modest-account-settings-dialog.c:
1431 (create_page_outgoing),
1432 (modest_account_settings_dialog_set_account_name),
1433 (save_configuration):
1434 - Fixed handling of the "Use secure authentication" toggle to comply with
1435 the ui specification. See also projects.maemo.org bug NB#58400
1437 - Restore the Secure connection setting combo correctly when loading
1440 * src/maemo/modest-maemo-utils.c:
1441 (on_camel_account_get_supported_secure_authentication),
1442 (modest_maemo_utils_get_supported_secure_authentication_methods):
1443 Fixed a crasher if operation is canceled
1445 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1446 (modest_protocol_info_auth_is_secure):
1447 * src/modest-protocol-info.h:
1449 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1450 the sense of the "Use secure authentication" toggle.
1452 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-tny-account-store.h:
1455 * src/modest-tny-account-store.c:
1456 Added modest_tny_account_store_get_local_folders_account().
1458 * src/modest-tny-folder.h:
1459 * src/modest-tny-folder.c:
1460 (modest_tny_folder_get_account):
1461 Added this replacement for tny_folder_get_account() which returns
1462 the local-folders account for TnyMergeFolders, to avoid the
1463 warning about the unimplemented get_account_func() vfunc().
1465 (modest_tny_folder_get_rules),
1466 * src/modest-ui-actions.c:
1467 (modest_ui_actions_on_folder_selection_changed):
1468 * src/modest-mail-operation.c:
1469 (modest_mail_operation_remove_folder),
1470 (modest_mail_operation_xfer_folder),
1471 (modest_mail_operation_rename_folder),
1472 (modest_mail_operation_get_msg),
1473 (modest_mail_operation_get_msgs_full),
1474 (modest_mail_operation_remove_msg),
1475 (modest_mail_operation_xfer_msgs),
1476 (modest_mail_operation_refresh_folder):
1477 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1479 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1481 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1482 (modest_server_account_set_security):
1483 * src/modest-defs.h: Add comments explaining that our
1484 UI spec means TLS when it says Normal, so these do not look like errors.
1486 * src/modest-tny-account.c:
1487 (modest_tny_account_new_from_server_account): Use the new tinymail
1488 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1489 for TLS. This should fix projects.maemo.org bug NB#58460.
1491 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/easysetup/modest-easysetup-wizard.c:
1494 (create_account): Correct the position of the gconf sanity check warning.
1495 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1496 of using the g_idle_add() hack, because this does not seem to be necessary
1497 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1498 caused by something other than maemo's gconf.
1499 This fixes projects.maemo.org bug #59022.
1501 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1503 * src/modest-account-mgr-helpers.c:
1504 (modest_account_mgr_get_default_account): Do not check that the account
1505 exists if there is no default account (NULL), to fix a runtime warning.
1507 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1509 * src/widgets/modest-folder-view.c: (update_model):
1510 Do not unref the treemodel before we have finished with it.
1511 This prevents a valgrind warning and an occasional crash at startup.
1513 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1515 * libmodest-dbus-client/libmodest-dbus-client.h:
1516 added libmodest_dbus_client_compose_mail()
1517 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1519 added functions needed for SendAsMail() functionality
1520 * src/maemo/modest-msg-edit-window.c:
1521 (modest_msg_edit_window_attach_file_noninteractive):
1522 non interactively attaching files to message edit window
1523 * src/widgets/modest-msg-edit-window.h:
1524 * tests/dbus_api/Makefile.am:
1525 added test_compose_mail.c
1526 * tests/dbus_api/test_compose_mail.c: (main):
1528 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1530 * src/modest-account-view.c:
1531 Fixed bug projects.maemo.org bug NB#59307
1533 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1535 * src/maemo/easysetup/modest-easysetup-wizard.c:
1536 (get_serverport_incoming), (on_before_next), (create_account):
1537 * src/maemo/modest-account-settings-dialog.c:
1538 (modest_account_settings_dialog_set_account_name):
1539 * src/maemo/modest-maemo-utils.c:
1540 (on_camel_account_get_supported_secure_authentication_status),
1541 (on_camel_account_get_supported_secure_authentication),
1542 (on_secure_auth_cancel),
1543 (modest_maemo_utils_get_supported_secure_authentication_methods):
1545 Implemented security authentication for settings and easysetup.
1547 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1549 * src/maemo/modest-main-window.c: (create_details_widget):
1550 Show the total size for memory card accounts too, instead of showing
1551 the name again. Fixes bug projects.maemo.org bug NB#59307.
1553 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1556 * src/modest-tny-simple-folder-store.c:
1557 * src/modest-tny-simple-folder-store.h: Removed.
1559 * src/modest-tny-local-folders-account.h
1560 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1561 for the local-folders maildir, with an extra TnyMergedFolder containing
1562 the folders of the per-account outbox store accounts.
1563 * src/modest-tny-account-store.c: (get_server_accounts):
1564 Add the outboxes to the special local folders account after creating it.
1566 * src/modest-tny-account.c:
1567 (modest_tny_account_new_for_local_folders): Create the derived
1568 account when creating the main local-folders account.
1570 * src/maemo/modest-main-window.c: (create_details_widget),
1571 (modest_main_window_set_contents_style):
1572 Adapted to the use of the derived account instead of the folder store.
1574 * src/modest-ui-actions.c:
1575 (modest_ui_actions_on_folder_selection_changed):
1576 * src/modest-ui-dimming-rules.c:
1577 (modest_ui_dimming_rules_on_new_folder):
1578 * src/widgets/modest-folder-view.c: (text_cell_data),
1579 (icon_cell_data), (filter_row), (update_model),
1580 (get_cmp_rows_type_pos):
1583 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1584 Do not get the priv struct, because no priv struct has been set,
1585 to avoid a runtime warning.
1587 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1588 #ifelse with #else, to fix a warning, to fix the build.
1591 2007-06-05 Christian Kellner <ckellner@openismus.com>
1593 * libmodest-dbus-client/libmodest-dbus-client.c:
1594 Fix small typo in doc (why do you always see them
1595 AFTER committing stuff?)
1598 2007-06-05 Christian Kellner <ckellner@openismus.com>
1600 * libmodest-dbus-client/libmodest-dbus-client.c:
1601 (libmodest_dbus_client_search):
1602 Initialize hit list with NULL. Also set folder list
1603 to "" if NULL was supplied.
1606 2007-06-03 Christian Kellner <ckellner@openismus.com>
1608 * libmodest-dbus-client/libmodest-dbus-client.c:
1609 (modest_search_hit_list_free):
1610 Make it save to call it with NULL.
1612 * src/dbus_api/modest-dbus-callbacks.c:
1613 * src/modest-search.c:
1614 Return full ModestSearchHits as the search result list not TnyHeader
1615 since can't be around withouth the correspoding TnyFolder.
1617 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1619 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1620 Added currently commented code to check for secure auth
1622 * src/maemo/modest-account-settings-dialog.c: (on_response),
1623 (save_configuration), (show_ok):
1624 Fixed projects.maemo.org bugs NB #59248 and #59251
1626 * src/maemo/modest-maemo-utils.c:
1627 (on_camel_account_get_supported_secure_authentication_status),
1628 (on_camel_account_get_supported_secure_authentication),
1629 (modest_maemo_utils_get_supported_secure_authentication_methods):
1630 * src/maemo/modest-maemo-utils.h:
1631 Moved get_supported_secure_authentication() method here to be able
1632 to use it from easysetup wizard.
1634 * src/modest-pair.c: (on_pair_compare_as_string):
1635 Should compare string with first part of pair and not
1636 strcmp pairs which will crash.
1638 * src/modest-protocol-info.c:
1639 (modest_protocol_info_protocol_is_store):
1640 * src/modest-protocol-info.h:
1641 Added modest_protocol_info_get_auth_protocol_name()
1643 2007-06-03 Armin Burgmeier <armin@openismus.com>
1645 * src/modest-mail-operation.c:
1646 (modest_mail_operation_get_msgs_full): Set priv->account also when
1647 only retrieving a single message. This avoids a crash when canceling
1650 (modest_mail_operation_notify_end): Do not explicitely remove the
1651 operation from the queue but only emit the progress_changed signal.
1652 The queue itself listens to that signal to remove the operation when
1653 it is finished. This reduces coupling and removes a potential deadlock
1654 when modest_mail_operation_notify_end() is called from the queue
1655 itself. If that is a problem performance-wise, I would suggest to
1656 implement a status-changed signal or something.
1658 * src/modest-mail-operation-queue.c: Make sure to never call a
1659 function from another file while the queue is locked. This (hopefully)
1660 fixes another deadlock when exiting the application while retrieving
1663 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1665 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1666 Fixed build if libogs is not available
1668 2007-06-03 Christian Kellner <ckellner@openismus.com>
1670 * libmodest-dbus-client/libmodest-dbus-client.h:
1671 * libmodest-dbus-client/libmodest-dbus-client.c:
1672 (libmodest_dbus_client_delete_message):
1673 Implement deletion of messages (Client side).
1675 (modest_search_hit_free),
1676 (modest_search_hit_list_free):
1677 Utility functions to free the result hits.
1679 * src/dbus_api/modest-dbus-api.h:
1680 * src/dbus_api/modest-dbus-callbacks.c:
1681 (on_delete_message),
1682 (modest_dbus_req_handler):
1683 Implement deletion of messages (Server side).
1685 * tests/dbus_api/test_search.c: (main):
1688 * tests/dbus_api/Makefile.am:
1689 * tests/dbus_api/test_delete_message:
1690 Add little test for the message deletion logic
1692 2007-06-03 Armin Burgmeier <armin@openismus.com>
1694 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1695 when the operation queue was not empty. projects.maemo.org bug
1698 2007-06-03 Armin Burgmeier <armin@openismus.com>
1700 * src/widgets/modest-account-view.c
1701 (on_account_default_toggled): Toggle default account column
1702 explicitely instead of waiting for gconf notification (which is
1703 currently ignored). This should fix projects.maemo.org bug NB#56910
1704 for now. It should probably be removed when gconf notifications are
1707 2007-06-03 Christian Kellner <ckellner@openismus.com>
1709 * libmodest-dbus-client/libmodest-dbus-client.c:
1710 Removed debugging spew.
1712 * src/dbus_api/modest-dbus-callbacks.c:
1713 Added debugging info.
1715 * src/modest-search.c:
1716 (modest_search_all_accounts):
1717 Use tny_account_store_get_accounts () on the account store
1718 to get all accounts which is the way to get all accounts.
1720 * tests/dbus_api/test_search.c: (main):
1721 Make it possible to supply the search term on the command line.
1723 2007-06-03 Christian Kellner <ckellner@openismus.com>
1725 * libmodest-dbus-client/libmodest-dbus-client.c:
1726 * libmodest-dbus-client/libmodest-dbus-client.h:
1727 Implement searching for mesages over raw dbus. (Client side)
1729 * src/dbus_api/Makefile.am:
1730 * src/dbus_api/modest-dbus-api.h:
1731 * src/dbus_api/modest-dbus-callbacks.c:
1732 * src/dbus_api/modest-dbus-callbacks.h:
1733 Search framework (Server side). Also implement on_idle_open_message().
1735 * src/maemo/modest-platform.c: (modest_platform_init):
1736 Prepare for raw dbus/osso rpc interaction.
1738 * src/modest-search.h:
1739 Changed minsize from unspecific guint to guint32.
1741 * src/modest-search.c:
1743 Added strange hack which magically made tnymail work.
1745 (modest_search_folder),
1746 (modest_search_account),
1747 (modest_search_all_accounts):
1748 Implement helper functions to search all accounts, specific account
1751 * tests/dbus_api/Makefile.am:
1752 * tests/dbus_api/test_open_message.c:
1753 Read url to open from commandline.
1755 * tests/dbus_api/test_search.c:
1756 Implement small test for dbus search stuff
1758 2007-06-02 Armin Burgmeier <armin@openismus.com>
1760 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1761 include account type and account title. This fixes projects.maemo.org
1764 * src/maemo/modest-account-view-window.c: Set a title for the window.
1766 2007-06-02 Armin Burgmeier <armin@openismus.com>
1768 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1769 incoming and outgoing server name based on email address and server
1770 types as long as the names have not been edited manually. This fixes
1771 projects.maemo.org bug NB#58671.
1773 2007-06-02 Armin Burgmeier <armin@openismus.com>
1775 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1776 server type cannot be changed in future to the incoming details page
1777 when creating an account. This fixes projects.maemo.org bug NB#59029.
1779 2007-06-02 Armin Burgmeier <armin@openismus.com>
1781 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1782 and assigned max width chars so that they wrap instead of being
1783 truncated. Fixes projects.maemo.org bug NB#56126.
1785 2007-06-02 Armin Burgmeier <armin@openismus.com>
1787 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1788 introductory note to the connection specific smtp servers dialog, as
1789 section 8.12 of the email UI specification requires. This fixes
1790 projects.maemo.org bug NB#59212.
1792 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1794 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1795 Check for running mail operations, and offer to cancel them, as per the UI
1796 spec. This fixes projects.maemo.org bug NB#59041 .
1797 However, I suspect that tinymail may still use the network connection
1798 in ways that we cannot detect or cancel. But it should at least adapt to
1799 changes fairly well.
1801 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1803 * src/modest-tny-account-store.c: (recreate_all_accounts),
1804 (get_cached_accounts), (get_server_accounts): Do more sensible
1805 ref-counting of the temporarily-cached outbox accounts list. This seems
1806 to fix a crash when entering the password when the password was wrong.
1808 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1810 * src/gnome/modest-main-window.c: (connect_signals):
1811 * src/modest-tny-account-store.c: (get_password),
1812 (modest_tny_account_store_alert): Added comments and clues and
1813 commented-out code about how we currently fail to deal with connection
1814 errors and wrong passwords, and how we should.
1816 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1818 * src/widgets/modest-retrieve-combo-box.c:
1819 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1820 This fixes projects.maemo.org bug NB#58472 .
1822 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1824 * src/maemo/easysetup/modest-easysetup-wizard.c:
1825 (create_page_complete_easysetup):
1826 (create_page_complete_custom): Correct the last commit,
1827 putting the correct sentences in the correct pages.
1829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1831 * src/maemo/easysetup/modest-easysetup-wizard.c:
1832 (create_page_complete_custom): Show the second sentence of text
1833 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1836 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1838 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1839 Set the leave-on-server conf key by default. This fixes
1840 projects.maemo.org bug NB#59258 .
1842 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1844 * src/maemo/modest-account-view-window.c:
1845 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1846 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1849 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1851 * src/maemo/easysetup/modest-easysetup-wizard.c:
1852 (create_caption_new_with_asterisk):
1853 * src/maemo/modest-account-settings-dialog.c:
1854 (create_caption_new_with_asterisk):
1855 Uncomment the code to add the asterisk, because they are no longer in the
1856 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1857 (update_incoming_server_title): Add an asterisk here too.
1859 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1861 * src/maemo/modest-maemo-global-settings-dialog.c:
1862 (current_connection): Check that we are even connected before trying to
1863 get the current connection name, to prevent a warning.
1865 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1866 Change the comments because tny_maemo_conic_device_connect() is now meant to
1868 * src/modest-mail-operation.c:
1869 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1870 make sure we have a connection and fail if we can't connect.
1872 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/modest-main-window.c:
1875 (on_account_store_connecting_finished): Do not try to get the
1876 connection ID if we are not really connected. I am surprised that
1877 this signal handler is called when we are not connected.
1879 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1881 * src/modest-error.h:
1882 * src/modest-ui-actions.c:
1883 (modest_ui_actions_get_msgs_full_error_handler):
1884 Renamed an enum, added comments, added an enum
1885 for retrieve-limit errors.
1887 * src/modest-mail-operation.c: (foreach_add_item),
1888 (internal_folder_observer_update), (update_account_thread),
1889 (modest_mail_operation_get_msgs_full):
1890 (modest_mail_operation_update_account),
1891 Added comments about how this works, and some code that should
1892 (but does not) check the retrieve-limit. See the TODO comment.
1894 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1897 Initialize help_id to fix the build. Warnings are good.
1899 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1901 * src/widgets/modest-hbox-cell-renderer.c:
1902 (modest_hbox_cell_renderer_append):
1903 * src/widgets/modest-vbox-cell-renderer.c:
1904 (modest_vbox_cell_renderer_append):
1905 Fix the last commit by doing an extra ref.
1907 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1909 * src/widgets/modest-hbox-cell-renderer.c:
1910 (modest_hbox_cell_renderer_append):
1911 * src/widgets/modest-vbox-cell-renderer.c:
1912 (modest_vbox_cell_renderer_append):
1913 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1914 to fix the build with Maemo Bora.
1915 However, there seems to be a remaining crash, probably due to reference
1918 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-tny-account.c:
1921 (modest_tny_account_new_for_local_folders):
1922 Use hildon_file_system_info_async_new() to get a better name for
1923 the memory card account, setting it as the account name.
1924 The timing seems to work, but this is probably
1925 not the best place to do this. See the TODO comment.
1926 * src/maemo/modest-main-window.c: (create_details_widget):
1927 * src/widgets/modest-folder-view.c: (text_cell_data):
1928 Use the tny account name instead of hardcoding a name.
1930 2007-05-30 Christian Kellner <ckellner@openismus.com>
1932 * src/modest-search.c: (modest_search):
1933 Correctly set part_search_func even if we have already parsed
1934 the query and thus a valid OgsTextSearcher object.
1936 2007-05-30 Christian Kellner <ckellner@openismus.com>
1939 Search and check for libogs.
1942 Incooparte the ogs build env.
1944 * src/modest-mime-part-search-stream.c:
1945 * src/modest-mime-part-search-stream.h:
1946 Removed since we do the real searching now in modest-search.c.
1948 * src/modest-search.c:
1949 * src/modest-search.h:
1950 Implement support for ogs. We use that if available and requested
1951 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1952 should now handle the corner case when the search term is spread
1953 across multiple reads.
1954 Also the logic in modest_search () was corrected to search all
1955 requested fields until one is found.
1957 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1961 * src/modest-init.h:
1962 * src/modest-init.c: Made modest_init_local_folders() take a
1963 path and be public so we can iniitialize maildir folders on
1966 * src/modest-local-folder-info.h:
1967 * src/modest-local-folder-info.c:
1968 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1970 * src/modest-tny-account.c:
1971 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1972 still means the standard local-folders path on the local volume.
1974 * src/modest-tny-account-store.c:
1975 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1976 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1977 all accounts when that happens.
1978 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1979 this too, so it shows up in the treeview.
1981 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/modest-maemo-global-settings-dialog.c:
1984 (current_connection):
1985 * src/widgets/modest-global-settings-dialog.c:
1986 (current_connection_default):
1987 Use the enum values instead of 0, 1 and -1,
1988 to make the code clearer.
1990 * src/modest-account-mgr-helpers.c:
1991 (modest_account_mgr_get_connection_specific_smtp): Make this code
1994 * src/modest-runtime.h:
1995 * src/modest-runtime.c:
1996 Added modest_runtime_remove_all_send_queues().
1997 * src/maemo/modest-main-window.c:
1998 (on_account_store_connecting_finished): Recreate the send queues,
1999 using the appropriate transport accounts for this new connection.
2000 Some futher adapting might be needed if the old send queues are not
2001 automatically stopped at this point.
2003 * src/modest-tny-account-store.c: (get_server_accounts):
2004 Create the connection-specific transport accounts, so that they can
2005 be found later by their ID.
2007 * src/modest-tny-account.h:
2008 * src/modest-tny-account.c:
2009 Added modest_tny_account_new_from_server_account_name().
2010 modest_tny_account_new_from_server_account(): Do not create the
2011 send queues here, because they will be
2012 recreated anyway when the connection changes for the first time.
2014 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-local-folder-info.h:
2017 * src/modest-local-folder-info.c:
2018 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2019 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2020 tbox_folder): Take a modest account name instead of a server TnyAccount,
2021 so we can have per-modest-account rather than per-transport-account
2023 We must make sure that we change or recreate the exisitng send queues
2024 when the connection changes for connection-specific transport accounts.
2026 * src/modest-tny-account-store.c:
2027 (create_per_account_local_outbox_folders): Create outboxed per modest
2028 account, not per transport account.
2030 * src/modest-tny-account.h:
2031 * src/modest-tny-account.c:
2032 (modest_tny_account_get_special_folder): For outboxes, get the
2033 parent modest account name. The account is ignored for other folders.
2034 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2035 modest account name rather than a server TnyAccount.
2037 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2039 * src/modest-tny-account.c:
2040 (modest_tny_account_new_from_server_account):
2041 Call modest_runtime_get_send_queue() immediately after creating transport
2042 accounts, so that they start trying to send email from the outbox as soon
2043 as possible at startup. This is probably what we want.
2045 * src/modest-mail-operation.c: (update_account_thread):
2046 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2047 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2048 * src/modest-tny-send-queue.h:
2049 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2050 (modest_ui_actions_on_send):
2051 Added comments about how sending works, though it needs some more work.
2053 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-tny-account.c:
2056 (modest_tny_account_get_special_folder): Add TODO because this fails when
2057 the network is busy.
2058 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2059 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2060 Do not try to show this window when there is no active account. The UI
2061 specs does not tell us what to do in this case.
2063 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/Makefile.am:
2068 * src/widgets/Makefile.am: Some dist fixes.
2070 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2072 * src/maemo/modest-connection-specific-smtp-window.c:
2073 (on_button_edit): Make the code clearer, to prevent a double free.
2075 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2077 * src/maemo/modest-account-settings-dialog.c:
2078 (modest_account_settings_dialog_set_account_name),
2079 Check the connection-specific smtp servers checkbox if there are any.
2081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2082 (modest_connection_specific_smtp_edit_window_init):
2083 Start with a suitable port number.
2085 * src/modest-account-mgr-helpers.h:
2086 * src/modest-account-mgr-helpers.c: Added
2087 modest_account_mgr_get_has_connection_specific_smtp().
2089 (modest_account_mgr_set_connection_specific_smtp),
2090 (modest_account_mgr_remove_connection_specific_smtp),
2091 (modest_account_mgr_get_has_connection_specific_smtp),
2092 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2093 connection-specific smtp server accounts in the account, rather than
2094 the server account conf dir.
2096 This fixes bug projects.maemo.org bug NB#58263 .
2098 * src/modest-tny-account-store.c:
2099 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2100 if there are no server accounts yet, to prevent an infinite loop when there
2101 are no accounts. Document that one must be called before the other.
2103 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2105 * src/modest-account-mgr-helpers.c:
2106 (modest_account_mgr_get_default_account): Make sure that at least
2107 one account is always the default, if there are any enabled accounts.
2108 This is just a sanity check that shouldn't be necessary.
2110 * src/modest-account-mgr-priv.c:
2111 (_modest_account_mgr_account_from_key): Unescape the conf key to
2112 get the real account name. For instance, this is an issue if a space
2113 was in the account name, which can happen because the account name
2114 is generated from the display name.
2115 (_modest_account_mgr_get_account_keyname): Always escape the
2117 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2118 Unescape the conf keys to get the real account names.
2120 For instance, previously the is-default radio button in the accounts
2121 list was not checked for any accounts at first. This fixes that,
2122 and might fix several similar bugs.
2124 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2126 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2127 Removed some debug printfs.
2129 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2131 Modest on-disk outbox directories are now here, for instance:
2132 $HOME/.modest/outboxes/<account-id-1>/outbox
2133 $HOME/.modest/outboxes/<account-id-2>/outbox
2135 $HOME/.modest/local-folders/outbox
2136 so we can have a separate outbox for each account.
2137 But they are shown as one outbox in the GtkTreeView, by using a
2138 TnyMergeFolder in a ModestTnySimpleFolderStore.
2141 * src/modest-tny-simple-folder-store.c:
2142 * src/modest-tny-simple-folder-store.h:
2143 Added ModestTnySimpleFolderStore, used to contain folders from
2144 other folder stores, such as other accounts.
2146 * src/modest-tny-outbox-account.h:
2147 * src/modest-tny-outbox-account.c:
2148 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2149 used for the per-account local outbox folders.
2151 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2152 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2153 only use this (internally) now for the non-outbox local folders.
2155 * src/modest-init.h:
2156 * src/modest-init.c: Added modest_init_one_local_folder(), for
2157 setting up the directory structure for each local folder.
2159 * src/modest-local-folder-info.c:
2160 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2161 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2163 * src/modest-local-folder-info.h:
2164 * src/modest-tny-account-store.c: (on_account_removed),
2165 (on_account_changed), (create_per_account_local_outbox_folders),
2166 (get_server_accounts), (modest_tny_account_store_get_accounts),
2167 (modest_tny_account_store_get_tny_account_by_account),
2168 (modest_tny_folder_store_is_virtual_local_folders):
2170 * src/modest-tny-account.h:
2171 * src/modest-tny-account.c:
2172 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2173 to create an on-disk per-account local outbox folder for each
2175 (create_per_account_local_outbox_folders): Create a local outbox folder
2176 for each transport account.
2177 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2178 for all local folders.
2180 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2181 instead of using g_object_get/set() directly. It is clearer.
2183 (modest_tny_folder_store_get_message_count),
2184 (modest_tny_folder_store_get_local_size
2185 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2186 because we now use these with non-acount folder stores.
2188 (modest_tny_account_get_special_folder),
2189 (modest_tny_account_new_from_server_account),
2190 (modest_tny_account_new_from_account):
2191 (recurse_folders): Adjust to the new outbox system.
2193 * src/modest-tny-folder.h:
2194 * src/modest-tny-folder.c:
2195 (modest_tny_folder_is_local_folder),
2196 (modest_tny_folder_get_local_folder_type),
2197 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2199 * src/widgets/modest-main-window.h:
2200 * src/maemo/modest-main-window.c: (create_details_widget),
2201 (modest_main_window_set_contents_style): Show details for any folder store,
2204 (modest_tny_folder_get_rules):
2205 Remove the const. C does not support constness enough for this.
2207 * src/modest-ui-actions.c:
2208 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2209 make all outboxes appear as one, in the usual local-folders tree node.
2211 (set_active_account_from_tny_account),
2212 (modest_ui_actions_on_folder_selection_changed):
2213 * src/widgets/modest-folder-view.c: (text_cell_data),
2214 (icon_cell_data), (filter_row),
2215 (add_account_folders_to_merged_folder),
2216 (add_account_folders_to_simple_folder_store), (),
2217 (get_cmp_rows_type_pos), (cmp_rows),
2218 (modest_folder_view_set_account_id_of_visible_server_account):
2219 Adjust to the new outbox system, using generic folder stores and folders
2220 in the GtkTreeModel.
2222 2007-05-23 Christian Kellner <ckellner@openismus.com>
2224 * src/modest-mail-operation.c:
2225 (modest_mail_operation_update_account):
2226 Use info->max_size instead of unintialized local var [small
2227 build fix]. (Added TODO to review that change since I don't
2230 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2232 * libmodest-dbus-client/libmodest-dbus-client.c:
2233 (libmodest_dbus_client_compose_mail): function added
2234 * src/dbus_api/modest-dbus-api.h:
2235 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2236 (on_compose_mail): Implementation of the SendAsMail functionality
2238 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2240 * src/modest-account-mgr.c:
2241 (modest_account_mgr_add_server_account): Set the secure-connection
2242 conf key for transport accounts as well as store accounts. I don't know
2243 why the if was there. For instance, this makes sure that we use SSL
2244 for the gmail preset from the easysetup wizard.
2246 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2248 * src/gnome/modest-main-window.c:
2249 (on_account_store_connecting_finished), (connect_signals):
2250 * src/maemo/modest-main-window.c:
2251 (on_account_store_connecting_finished), (connect_signals),
2252 (modest_main_window_new):
2253 Handle TnyAccountStore::connecting-finished instead of
2254 TnyDevice::connection-changed, because we cannot actually perform
2255 operations on accounts until TnyAccountStore has itself responded to
2256 the TnyDevice::connection-changed signal. This prevents a GError from
2258 Do not try to update at startup, because we (at least on scratchbox)
2259 already do an update at startup when the device goes online.
2260 This prevents a GError from tinymail.
2261 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2262 Added TODO about stopping simultaneous operations.
2264 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2267 * src/modest-mail-operation-queue.c:
2268 (modest_mail_operation_queue_remove):
2269 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2270 about where they happened.
2272 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-ui-actions.c:
2275 (modest_ui_actions_on_password_requested): Make sure that the remember
2276 output parameter is always TRUE.
2278 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2281 Show a OK/Cancel dialog if the error is a question, though we still do not
2282 know anything more about what we are asking the user.
2283 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2284 Fix an uninitialized variable (helper). This is a logic error, however.
2286 2007-05-21 Christian Kellner <ckellner@openismus.com>
2288 * src/modest-search.h:
2289 Correct bit shifting in the ModestSearchFlags enum.
2291 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2293 * src/modest-tny-account.c:
2294 (modest_tny_account_new_from_server_account): Do not use the lsub and
2295 check-all hard-coded IMAP options when using POP.
2297 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2299 * src/modest-tny-account.c:
2300 (modest_tny_account_new_from_server_account):
2301 Use NULL for the secure-auth method for POP when Password auth has been
2302 specified by the user, as we already do for IMAP. "auth=Login" causes
2303 an error from camel or the server.
2305 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/modest-account-settings-dialog.c:
2308 (create_page_account_details),
2309 (modest_account_settings_dialog_set_account_name):
2310 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2311 for the leave-on-server checkbox, rathr than just the checkbox, when
2312 the protocol is not POP.
2314 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2316 * src/widgets/modest-account-view.c:
2317 * src/widgets/modest-account-view.h:
2318 Added modest_account_view_select_account() which will be useful later
2319 to asynchronously re-select the edited account.
2321 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/modest-account-settings-dialog.c:
2324 (modest_account_settings_dialog_set_account_name):
2325 Automatically choose the port numbers based on the secure authentication
2326 methods, if they have not been chosen before.
2327 This fixes projects.maemo.org bug NB#56273 .
2329 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/modest-main-window-ui.h:
2332 * src/modest-ui-actions.c:
2333 * src/modest-ui-actions.h:
2334 Connect the Tools/SMTP Servers menu item to
2335 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2336 SMTP servers dialog, as in the UI specification and saves changes when it
2337 is closed. This fixed projects.maemo.org bug NB#56305 .
2339 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2341 * src/maemo/modest-connection-specific-smtp-window.c:
2342 (modest_connection_specific_smtp_window_init):
2343 Use gtk_window_set_default_size() to make this window big enough, so
2344 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2346 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2350 (modest_connection_specific_smtp_edit_window_init),
2351 Do not try to connect to a combobox signal before the combobox exists.
2352 This fixes the cras in projects.maemo.org bug NB#56288 .
2353 (modest_connection_specific_smtp_edit_window_get_settings):
2354 Remove the server_account_name parameter which was being checked for NULL
2355 though it was not used.
2357 * src/maemo/modest-connection-specific-smtp-window.c:
2358 (modest_connection_specific_smtp_window_fill_with_connections),
2359 (on_button_edit), (modest_connection_specific_smtp_window_init):
2360 Correct the number of treemodel columns to prevent a warning.
2361 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2362 libconic does not work.
2364 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2366 * src/modest-tny-account.c:
2367 (modest_tny_account_new_from_server_account):
2368 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2369 SMTP when "None" was chosen by the user. However, with my SMTP server that
2370 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2373 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2376 to explain the memory management issue with the ID in the ModestPair.
2378 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2379 (add_sending_page), (modest_account_assistant_finalize):
2380 * src/gnome/modest-gnome-global-settings-dialog.c:
2381 (create_updating_page), (create_composing_page):
2382 * src/gnome/modest-msg-edit-window.c: (get_transports),
2383 (init_window), (modest_msg_edit_window_finalize),
2384 (modest_msg_edit_window_get_msg_data):
2385 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2386 * src/gnome/modest-transport-widget.c:
2387 (modest_transport_widget_finalize), (smtp_configuration):
2388 * src/maemo/modest-maemo-global-settings-dialog.c:
2389 (create_updating_page), (create_composing_page):
2390 * src/maemo/modest-msg-edit-window.c: (get_transports),
2391 (init_window), (modest_msg_edit_window_finalize),
2392 (modest_msg_edit_window_get_msg_data),
2393 (modest_msg_edit_window_free_msg_data):
2394 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2395 (modest_store_widget_finalize):
2396 * src/maemo/modest-transport-widget.c:
2397 (modest_transport_widget_finalize), (smtp_configuration):
2398 * src/modest-main.c: (send_mail):
2399 * src/widgets/modest-combo-box.h:
2400 * src/widgets/modest-global-settings-dialog-priv.h:
2401 * src/widgets/modest-global-settings-dialog.c:
2402 (modest_global_settings_dialog_finalize):
2403 * src/widgets/modest-msg-edit-window.h:
2404 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2405 as long as the combo box, to prevent use of freed memory for the ID.
2407 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2410 get_accounts(), to make this clearer. Do not check for the enabled gconf
2411 key, because we do not use this for server accounts (at least, not yet).
2412 This allows us to send email again.
2414 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/modest-platform.c:
2417 (on_modest_conf_update_interval_changed), (modest_platform_init):
2418 Only respond to this particular key change. All these strcmp()s cannot be
2421 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/modest-maemo-global-settings-dialog.c:
2424 (current_connection): Prevent a crash in scratchbox when
2425 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2426 * src/maemo/modest-platform.c:
2427 (on_modest_conf_update_interval_changed), (modest_platform_init):
2428 Get the update interval from gconf and reset it when the gconf key changes.
2430 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2432 * src/modest-protocol-info.c:
2433 * src/modest-protocol-info.h: Adde enum-specific get functions,
2434 instead of using a ModestProtocolType enum parameter.
2436 * src/gnome/modest-account-assistant.c:
2437 * src/gnome/modest-store-widget.c:
2438 * src/gnome/modest-store-widget.h:
2439 * src/gnome/modest-transport-widget.c:
2440 * src/gnome/modest-transport-widget.h:
2441 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2442 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2443 * src/maemo/easysetup/modest-easysetup-wizard.c:
2444 * src/maemo/modest-account-settings-dialog.c:
2445 * src/maemo/modest-account-settings-dialog.h:
2446 * src/maemo/modest-store-widget.c:
2447 * src/maemo/modest-store-widget.h:
2448 * src/maemo/modest-transport-widget.c:
2449 * src/maemo/modest-transport-widget.h:
2450 * src/modest-account-mgr-helpers.c:
2451 * src/modest-account-mgr-helpers.h:
2452 * src/modest-account-mgr.c:
2453 * src/modest-account-mgr.h:
2454 * src/modest-tny-account.c:
2455 * src/modest-tny-folder.c:
2456 * src/widgets/modest-account-view.c:
2457 * src/widgets/modest-retrieve-combo-box.c:
2458 * src/widgets/modest-retrieve-combo-box.h:
2459 * src/widgets/modest-secureauth-combo-box.c:
2460 * src/widgets/modest-serversecurity-combo-box.c:
2461 * src/widgets/modest-serversecurity-combo-box.h:
2462 * tests/check_account-mgr.c:
2463 Use the specific functions, and use the re-renamed enum values for GNOME too.
2465 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-pair.h:
2468 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2469 so we can get the second based on the first.
2471 * src/maemo/modest-account-settings-dialog.h:
2472 * src/maemo/modest-account-settings-dialog.c:
2473 Added get_supported_secure_authentication_methods(), though it is mostly
2474 commented-out for now until the necessary API is committed to tinymail.
2475 (modest_account_settings_dialog_set_account_name),
2476 (save_configuration): Request the supported authentication methods from the
2477 server, so we can choose a working method.
2479 * src/modest-tny-account-store.h:
2480 * src/modest-tny-account-store.c:
2481 (modest_tny_account_store_get_session): Rename from
2482 tny_account_store_get_session().
2484 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2486 * src/modest-protocol-info.h: Split the ModestProtocol enum
2487 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2488 There was no need to have these unrelated values in one enum.
2490 * src/: many files: Adapted to changed enum. This makes the code a bit
2491 clearer, and the compiler could catch some errors.
2493 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2495 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2496 Show the detailed internal camel error message when an error happens
2497 during the configuration, so that our testers can give us more clues.
2498 For instance, in projects.maemo.org bug NB#56910 .
2500 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-tny-account.c:
2503 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2504 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2506 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2508 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2509 * src/maemo/modest-account-settings-dialog.c:
2510 (modest_account_settings_dialog_set_account_name),
2511 (save_configuration): For the incoming secure authentication checkbox,
2512 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2513 the UI specification. PLAIN does not seem to be supported for most IMAP
2514 servers anyway, and I am not sure what it would mean.
2515 However, we probably need to discover which of the secure-authentication
2516 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2517 * src/modest-account-mgr-helpers.c:
2518 (modest_account_mgr_get_server_account_data):
2520 * src/modest-tny-account.c:
2521 (modest_tny_account_new_from_server_account):
2522 Use tny_account_set_mech() to set secure-authentication methods,
2523 with some special-casing for IMAP, based on my observations of how
2526 * src/modest-account-mgr-helpers.h:
2527 * src/modest-account-mgr.c:
2528 * src/modest-defs.h: Comment that the URI is only used for local folders.
2530 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2532 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2533 parameter const, just to be neat.
2534 * src/modest-text-utils.c: (modest_text_utils_inline):
2535 End g_strconcat() with NULL, as its documentation says. This is almost
2536 certainly the cause of my crash at startup on the device. Interestingly,
2537 valgrind doesn't tell us about these errors.
2539 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2541 * scripts/build-packages: Added more precise comments about how to use
2542 this script, though I still get this error:
2543 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2544 error building tinymail
2546 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/modest-main-window.c: (on_account_update):
2549 Very slight cleanup, hoping to make it simpler to discover what causes
2550 a crash here sometimes.
2552 * src/modest-tny-account.c:
2553 (modest_tny_account_new_from_server_account): Set the port. Added
2554 comments about the options and a TODO comment because I need to find out
2555 how to specify the secure authentication method.
2557 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2559 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2560 changed CFlags paths form modest to libmodest
2562 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2564 * src/modest-account-mgr-helpers.c:
2565 (modest_account_mgr_get_server_account_data),
2566 (modest_account_mgr_free_server_account_data):
2567 * src/modest-account-mgr-helpers.h:
2568 * src/modest-account-mgr.c:
2569 (modest_account_mgr_add_server_account):
2570 * src/modest-defs.h:
2571 * src/modest-tny-account.c:
2572 (modest_tny_account_new_from_server_account):
2573 Determine the options for tny_camel_account_add_option() here,
2574 based on the settings, rather than storing them directly in gconf.
2576 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2578 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2579 Show a more friendly error dialog now that we expect (from the tinymail
2580 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2582 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/modest-main-window.c: (on_account_update): Check that
2585 account_name is not NULL, to prevent a crash at startup that I am
2586 seeing on the N800. I do wonder why it is NULL.
2588 * src/maemo/easysetup/modest-easysetup-wizard.c:
2589 (create_page_user_details):
2590 * src/maemo/modest-account-settings-dialog.c:
2591 (create_page_user_details), (create_page_outgoing):
2592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2593 (modest_connection_specific_smtp_edit_window_init):
2594 * src/modest-ui-actions.c:
2595 (modest_ui_actions_on_password_requested):
2596 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2597 might do something useful with the on-screen keyboard.
2599 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2601 * src/maemo/modest-main-window.c: (on_account_update):
2602 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2603 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2605 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2607 * src/modest-tny-account-store.c: (on_account_changed):
2608 Correct the signature of this signal handler.
2610 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2613 Show a HildonNote instead of a GtkDialog for Maemo.
2615 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2617 * src/widgets/modest-account-view.h:
2618 * src/widgets/modest-account-view.c: (on_account_changed),
2619 (on_account_removed). Added a boolean flag, set/unset by
2620 modest_account_view_block_conf_updates(),
2621 modest_account_view_unblock_conf_updates() to prevent unnecessary
2622 updates, but this is not very useful because the gconf notifications are
2623 so delays (maybe only on Maemo Bora).
2624 So auto-updating is turned off, and these functions do an explicit
2625 update when necessary.
2626 However, something else is still doing too much work when adding/removing
2627 accounts, probably in another part of the application.
2629 * src/maemo/modest-account-view-window.c:
2630 (on_delete_button_clicked), (on_edit_button_clicked),
2631 (on_new_button_clicked): Use the new functions.
2633 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2635 * src/modest-account-mgr-helpers.c:
2636 (modest_account_mgr_set_first_account_as_default):
2637 Sort the list of names alphabetically-by-title, so we choose the first one
2639 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2640 alphabetically by the title.
2642 This fixes projects.maemo.org bug NB#56418 .
2644 * src/modest-account-mgr-priv.c:
2645 (_modest_account_mgr_account_from_key):
2646 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2647 avoid a valgrind error, and possible random behaviour.
2649 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2652 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2653 tinymail documentation to say that this can be expected.
2654 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2655 pretty, and should not happen, but I would prefer to know when it does.
2657 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2659 * configure.ac: When using the older hildon version, probably on Bora,
2660 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2662 * src/widgets/modest-attachment-view.c:
2663 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2666 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2668 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2669 Implemented the prototype. Can be tested with
2670 tests/dbus_api/test_open_message:
2672 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2674 * src/modest-tny-account-store.c:
2675 (modest_tny_account_store_instance_init), (get_password):
2676 * src/modest-ui-actions.c:
2677 (modest_ui_actions_on_password_requested):
2678 Do not store the password in gconf, because this function is called
2679 for non-remembered passwords. Actually use the cached (in the hash map)
2680 password instead of releasing it.
2681 The password will now not be remembered if it is asked via the protected
2682 password dialog, as per the UI spec.
2684 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2686 * src/modest-defs.h:
2687 * src/modest-account-mgr-helpers.h:
2688 * src/modest-account-mgr-helpers.c:
2689 Added modest_server_account_get_username_has_succeeded(),
2690 modest_server_account_set_username_has_succeeded().
2691 (modest_server_account_set_username),
2692 Reset the has-succeeded flag if the username changes.
2694 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2695 * src/maemo/modest-connection-specific-smtp-window.c:
2696 (modest_connection_specific_smtp_window_save_server_accounts):
2697 Use modest_server_account_set_username() instead of using
2698 modest_conf_set_string() directly, so that the has-succeeded flag is always
2701 * src/modest-ui-actions.c:
2702 (modest_ui_actions_on_password_requested): Dim the username entry if
2703 the username has ever worked, as per the UI spec.
2705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-tny-account-store.c: (get_password):
2708 * src/modest-ui-actions.c:
2709 (modest_ui_actions_on_password_requested):
2710 Allow the username to be changed too, though there is more work to
2711 be done on exactly how this behaves.
2713 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2715 * src/modest-account-mgr-helpers.h:
2716 * src/modest-account-mgr-helpers.c:
2717 Added modest_account_mgr_get_display_name(),
2718 modest_server_account_get_username(),
2719 modest_server_account_set_username(),
2720 modest_server_account_set_password(),
2721 modest_server_account_get_hostname() functions so we do not need to
2722 use the conf API directly.
2724 * src/maemo/modest-main-window.c: (connect_signals):
2725 Actually connect ot the ModestAccountStore::request-password signal,
2726 so that we show the dialog when the password is requested by Tinymail,
2727 for isntance if it is empty.
2729 * src/modest-marshal.list:
2730 * src/modest-tny-account-store.c:
2731 (modest_tny_account_store_class_init), (get_password),
2732 (modest_tny_account_store_alert):
2733 * src/modest-tny-account-store.h:
2734 * src/modest-ui-actions.h:
2735 * src/modest-ui-actions.c:
2736 (modest_ui_actions_on_password_requested):
2737 Change the signal parameters, so it is obvious that we are providing
2738 the non human-readable server name, and receiving both the username
2739 and password, though changing of the username is not yet implemented.
2740 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2741 for the GNOME version.
2743 This should fix the projects.maemo.org bug NB#56209, though it does not
2744 work on Bora, because the gconf_client_get() for the password fails
2745 immediately after we save it with gconf_client_set().
2747 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2750 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2751 caused an undefined symbol error:
2752 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2754 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2756 * src/modest-tny-account-store.c:
2757 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2758 using a GError instead of a string message, so we can translate it in
2761 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2763 * src/maemo/modest-address-book.c:
2764 (modest_address_book_check_names):
2765 * src/maemo/modest-msg-view-window.c:
2766 (modest_msg_view_window_clipboard_owner_change):
2767 * src/modest-init.c: (modest_init_init_ui):
2768 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2769 (update_folders_cb), (modest_mail_operation_update_account):
2770 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2771 (modest_ui_actions_on_msg_attachment_clicked),
2772 (modest_ui_actions_on_msg_recpt_activated):
2773 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2774 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2775 (modest_msg_view_search_next):
2776 * src/widgets/modest-recpt-editor.c:
2777 (modest_recpt_editor_on_button_release_event),
2778 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2779 g_message(). At this point we should only be seeing interesting errors on
2780 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2782 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2784 (modest_wizard_dialog_force_title_update):
2785 * src/maemo/easysetup/modest-wizard-dialog.h:
2786 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2787 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2788 can update the title when appropriate. Otherwise the title is wrong if the
2789 pages are added after adding the notebook to the dialog.
2790 This must be a problem in HildonWizardDialog too.
2791 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2793 * src/maemo/easysetup/modest-easysetup-wizard.c:
2794 (create_subsequent_customsetup_pages),
2795 (create_subsequent_easysetup_pages):
2796 Call modest_wizard_dialog_force_title_update() so that the title is
2797 correct even with GTK+ < 2.10.
2798 This fixes projects.maemo.org bug NB#56145 .
2800 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-platform.c:
2803 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2804 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2807 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2809 * src/widgets/modest-window.h:
2810 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2811 and modest_window_save_state(), which invokes it.
2813 * src/widgets/modest-window-mgr.h:
2814 * src/widgets/modest-window-mgr.c:
2815 Added modest_window_mgr_save_state_for_all_windows(), which calls
2816 the save_state vfunc on all registered windows, if implemented.
2818 * src/gnome/modest-msg-edit-window.c:
2819 * src/gnome/modest-msg-view-window.c:
2820 * src/maemo/modest-msg-edit-window.c:
2821 * src/maemo/modest-msg-view-window.c:
2822 * src/maemo/modest-main-window.c:
2823 Specify the existing save_settings functions as implementations of
2824 ModestWindow::save_state_func().
2826 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2827 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2828 enabling hibernation, for instance.
2830 We may need to do the same thing for restoring settings.
2833 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2835 * src/widgets/modest-window-mgr.c:
2836 * src/widgets/modest-window-mgr.h:
2837 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2838 modest_window_mgr_get_hibernation_is_prevented().
2840 * src/maemo/modest-main-window.c:
2841 (on_hildon_program_is_topmost_notify): Prevent hibernation
2842 (possible when the application goes to the background in the WM),
2843 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2845 * src/maemo/easysetup/modest-easysetup-wizard.c:
2846 (modest_easysetup_wizard_dialog_init):
2847 * src/maemo/modest-account-settings-dialog.c:
2848 (modest_account_settings_dialog_init):
2849 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2850 (modest_connection_specific_smtp_edit_window_init):
2851 * src/maemo/modest-connection-specific-smtp-window.c:
2852 (modest_connection_specific_smtp_window_init):
2853 * src/maemo/modest-signature-editor-dialog.c:
2854 (modest_signature_editor_dialog_init):
2855 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2856 prevent hibernation while any of these account settings dialogs are open.
2858 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/Makefile.am:
2861 * src/maemo/modest-osso-state-saving.c:
2862 * src/maemo/modest-osso-state-saving.h: Added
2863 modest_osso_load_state() and modest_osso_save_state() though they do
2864 nothing now. They should iterate through all the open windows and load/save
2866 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2867 save state when closing.
2869 * src/maemo/modest-main-window.c:
2870 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2871 Add a notification handler for the HildonProgram::is-topmost property,
2872 so we can allow hibernation when the application goes into the background.
2873 But we still need to detect when the accounts setup windows are open so
2874 we can stop hibernation when they are open.
2875 To do this, I also added the main window the HildonProgram. This might have
2876 other side-effects/benefits, and should maybe be done for other windows.
2878 * src/maemo/modest-osso-autosave-callbacks.h:
2879 * src/maemo/modest-osso-autosave-callbacks.c:
2880 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2881 though it does not do anything yet, and we might never need this to do
2882 anything. For instance, we already save drafts.
2884 * src/maemo/modest-platform.c: (modest_platform_init):
2885 Specify the libosso auto-save callback.
2887 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/modest-platform.c:
2890 (modest_platform_set_update_interval):
2891 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2892 aparently stays valid between application instances, so we can use this
2893 to remove and reset it later. According to a maemo-developers email from
2896 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2898 * configure.ac: Depend on libalarm for Maemo.
2900 * src/dbus_api/modest-dbus-api.h:
2901 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2902 (on_send_receive), (modest_dbus_req_handler):
2903 Handle a SEND_RECEIVE D-Bus method.
2905 * libmodest-dbus-client/libmodest-dbus-client.c:
2906 (libmodest_dbus_client_send_and_receive):
2907 * libmodest-dbus-client/libmodest-dbus-client.h:
2908 Add C convenience functions for calling the new D-Bus method.
2910 * src/modest-platform.h:
2911 * src/gnome/modest-platform.c:
2912 * src/maemo/modest-platform.c:
2913 Added modest_platform_set_update_interval(), which uses the
2914 alarmd API on Maemo.
2915 (modest_platform_init),
2916 Call modest_platform_set_update_interval(), using a hard-coded
2917 interval for now (until the global settings dialog is implemented),
2918 though I am not sure that this makes sense yet.
2920 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2922 * src/dbus_api/modest-dbus-callbacks.c:
2923 (modest_osso_cb_hw_state_handler):
2924 * src/dbus_api/modest-dbus-callbacks.h:
2925 * src/maemo/modest-platform.c: (modest_platform_init):
2926 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2927 in case this has some effect on the ability for Maemo to ping the
2930 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2932 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2933 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2934 warning. It is probably a logic error, but I need to fix the build.
2936 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2938 * src/modest-account-mgr.h:
2939 * src/modest-account-mgr.c:
2940 (modest_account_mgr_account_names): Add a gboolean enabled_only
2941 parameter, so we can get lists of onlt the enabled accounts.
2943 (modest_account_mgr_add_account),,
2944 (modest_account_mgr_account_with_display_name_exists):
2945 * src/maemo/modest-msg-edit-window.c: (get_transports):
2946 * src/modest-account-mgr-helpers.c:
2947 (modest_account_mgr_set_first_account_as_default):
2948 * src/modest-init.c: (init_default_account_maybe):
2949 * src/modest-tny-account-store.c: (get_accounts):
2950 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2951 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2952 * tests/check_account-mgr.c: (START_TEST):
2953 Provide the extra parameter, as appropriate.
2955 * src/widgets/modest-account-view.c: (update_account_view):
2956 Do not show disabled accounts (meaning that there is no way to
2957 enable/disable accounts in the UI (the feature is not in our UI
2958 specification), so we can use this internally only to mark unfinished
2959 or temporary account data.
2961 * src/maemo/easysetup/modest-easysetup-wizard.c:
2962 (create_account): Add boolean enable parameter, so we can specify FALSE
2963 to create the temporary account.
2964 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2965 (on_before_next): When finishing, when there is a temporary account, just
2967 Also, use a timeout to delay the showing of the dialog until gconf is likely
2968 to return correct information, due to a maemo gconf bug that is fixed in
2969 osso 1.1, but not yet in Bora.
2970 However, the dialog stays on screen after it is destroyed.
2972 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2973 for invalid data when cancelling. Use a hildon note instead of a dialog
2974 to complain about invalid data. Do not show the account-saved note if the
2975 account is disabled (a temporary account that will not really be saved for use
2978 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2980 * src/modest-account-mgr-helpers.h:
2981 * src/modest-account-mgr-helpers.c:
2982 Added modest_account_mgr_unset_default_account(),
2983 Added modest_account_mgr_set_first_account_as_default().
2985 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2986 If it was the default account, unset the default account name.
2988 * src/maemo/modest-account-view-window.c:
2989 (on_delete_button_clicked): If it was the default account,
2990 set the first remaining account as the default instead.
2992 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2993 a NULL account or a NULL default account, to prevent a crash. This should
2994 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2997 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2999 * src/widgets/modest-recpt-editor.c:
3000 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3001 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3002 TODO comment for this. This fixes the build.
3004 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3005 be the best place for it. This will in future update all auto-update accounts,
3006 rather than just the current/default account, when that gconf key exists.
3007 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3008 if there are no accounts, before calling do_send_receive().
3009 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3011 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3012 * src/maemo/modest-main-window-ui.h:
3013 * src/maemo/modest-main-window.c: (on_connection_changed),
3014 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3015 directly, becaue the signal handler does more.
3017 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3019 * src/modest-account-mgr-helpers.c:
3020 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3021 for the case that the account does not exist.
3023 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3024 (equivalent to the modest account name) rather than the tinymail account name
3025 (equivalent to the modest account title - human readable) to get the account data.
3026 Check for null account data to prevent the crash, and add a TODO comment saying that
3027 this needs fixing because it is using the server account name instead of the account name.
3029 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3031 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3032 * src/maemo/modest-account-settings-dialog.c: (show_error),
3034 Use hildon_note_new_information() for informative and error messages,
3035 which seems to be expected for Maemo applications (no documentation that I know of
3036 says this). I am surprised that there is no distinction between info and error
3039 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3042 it is easy to find where this is used.
3044 * src/maemo/easysetup/modest-easysetup-wizard.c:
3045 (create_page_welcome), (create_page_account_details),
3046 (create_page_user_details), (create_page_complete_easysetup),
3047 (create_page_custom_incoming), (create_page_custom_outgoing),
3048 (create_page_complete_custom):
3049 * src/maemo/modest-account-settings-dialog.c:
3050 (create_page_account_details), (create_page_user_details),
3051 (create_page_incoming), (create_page_outgoing):
3052 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3053 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3054 (modest_connection_specific_smtp_edit_window_init):
3055 * src/maemo/modest-connection-specific-smtp-window.c:
3056 (modest_connection_specific_smtp_window_init):
3057 * src/maemo/modest-signature-editor-dialog.c:
3058 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3059 and scrolling policy as per the Email Application Layout Guide, if I have
3062 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3064 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3065 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3066 which were empty, because these vfuncs have been removed from TnyAccountStore.
3067 This fixes the build.
3069 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3071 * src/maemo/modest-main-window.c:
3072 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3073 showing/hiding it. Added TODO because it probably should not be NULL.
3074 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3075 because unnecessary g_warnings() make degugging difficult.
3077 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3079 * src/maemo/modest-msg-edit-window.c:
3080 (modest_msg_edit_window_select_color),
3081 (modest_msg_edit_window_select_background_color): 2 const corrections and
3082 moving 2 #endifs before closing brackets, to fix the build.
3084 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3086 * src/maemo/easysetup/modest-easysetup-wizard.h:
3087 * src/maemo/easysetup/modest-easysetup-wizard.c:
3088 (modest_easysetup_wizard_dialog_finalize),
3089 (on_button_edit_advanced_settings), (create_page_complete_custom),
3090 (on_response), (create_account):
3091 Implement the Advanced Settings edit button, by saving the account information,
3092 for the Advanded Settings dialog to use directly from gconf, and removing it
3093 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3094 Bug #5533 in the projects.maemo.org bugzilla.
3096 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3098 * src/maemo/modest-msg-view-window.c:
3099 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3100 when opening a message window.
3102 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/easysetup/modest-easysetup-wizard.c:
3105 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3108 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3109 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3110 gconf settings. I probably added more checks than necessary, but that is safer.
3112 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3113 variable to fix the build, but this seems to be used when it is still NULL.
3115 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3117 * src/modest-platform.h:
3118 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3119 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3120 * src/modest-main.c: Implement this function so we can avoid using
3121 maemo-specific API from cross-platform code.
3123 * src/modest-tny-account-store.c:
3124 (get_smtp_specific_transport_account_for_open_connection):
3125 * src/modest-ui-actions.c: (check_for_connection),
3126 (modest_ui_actions_on_item_not_found):
3127 Use modest_platform_connect_and_wait() and put #idefs around other
3128 maemo-specific code, because only maemo currently has a way to
3129 identify connection names.
3131 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3133 * src/modest-tny-account-store.h:
3134 * src/modest-tny-account-store.c:
3135 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3136 the connection-specific SMTP server settings in the configuration.
3138 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3140 * src/maemo/modest-main-window.c: (on_connection_changed),
3142 * src/modest-main.c: (main), (start_ui), (send_mail):
3143 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3144 that is what is intended.
3146 * src/modest-ui-actions.c: (action_send), (action_receive),
3147 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3148 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3149 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3150 SMTP server is used when it is specified.
3152 (modest_ui_actions_on_send_receive):
3153 Check that a connection is open before proceeding.
3154 Receive and then send, instead of vice-versa, as per the specification.
3156 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3158 * src/modest-mail-operation.c:
3159 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3160 though I guess it should be something other than NULL.
3162 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/easysetup/modest-easysetup-wizard.c:
3165 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3166 combo twice, to avoid an g_warning and to make it visible again.
3167 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3168 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3169 (already intended) dereference when detaching, because we then recreate the menu.
3170 But I am not sure why the warning was happening, and it is possible that this is a memory
3173 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3175 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3176 and uri_parse_mailto() utility functions.
3177 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3179 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3181 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3183 * src/dbus_api/modest-dbus-api.h:
3184 * src/dbus_api/modest-dbus-callbacks.c:
3185 Use an idle callback to execute the modest code in the application's own thread.
3186 Remove the helloworld example method.
3187 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3188 parsed, and the open-message method is not implemented because this is not yet implemented in
3190 * libmodest-dbus-client/libmodest-dbus-client.c:
3191 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3192 (libmodest_dbus_client_open_message):
3193 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3195 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3196 body without crashing.
3198 * tests/dbus_api/Makefile.am:
3199 * tests/dbus_api/test_mail_to.c:
3200 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3202 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3204 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3205 Added file to fix the build. Sorry.
3207 * src/dbus_api/Makefile.am:
3208 * src/dbus_api/modest-dbus-api.h:
3209 * src/dbus_api/modest-dbus-callbacks.h:
3210 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3211 (modest_dbus_req_handler):
3212 Put constants in a separate header so it can be reused by the
3213 client library, without duplication
3215 * libmodest-dbus-client/Makefile.am:
3216 * libmodest-dbus-client/libmodest-dbus-client.c:
3217 (libmodest_dbus_client_call_helloworld),
3218 (libmodfest_dbus_client_send_mail),
3219 (libmodfest_dbus_client_mailto),
3220 (libmodfest_dbus_client_open_message):
3221 * libmodest-dbus-client/libmodest-dbus-client.h:
3222 (Partly) Implement a send_mail D-Bus method.
3224 * tests/dbus_api/Makefile.am:
3225 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3226 the send_email D-Bus method.
3228 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3232 * libmodest-dbus-client/Makefile.am:
3233 * libmodest-dbus-client/libmodest-dbus-client.c:
3234 * libmodest-dbus-client/libmodest-dbus-client.h:
3235 * tests/dbus_api/Makefile.am:
3236 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3237 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3239 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3241 * src/maemo/easysetup/modest-easysetup-wizard.c:
3242 (create_page_account_details):
3243 * src/maemo/modest-account-settings-dialog.c:
3244 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3245 widgets, because this might not be the default in future versions of the Maemo GTK+.
3246 However, I can not not get capitalization to work even in a simple test case.
3248 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/easysetup/modest-easysetup-wizard.c:
3251 (create_page_custom_incoming), (create_page_custom_outgoing):
3252 * src/maemo/modest-account-settings-dialog.c:
3253 (create_page_account_details), (create_page_incoming),
3254 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3255 instead of using gtk_check_button_with_label(), so they are aligned like the other
3256 widgets, as per the UI spec.
3258 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3260 * src/maemo/easysetup/modest-easysetup-wizard.c:
3261 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3262 * src/widgets/modest-validating-entry.c:
3263 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3264 Modest prefix instead of an EasySetup prefix.
3266 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3268 * src/widgets/modest-validating-entry.h:
3269 * src/widgets/modest-validating-entry.c: (on_insert_text),
3270 Added easysetup_validating_entry_set_max_func(), used to set a callback
3271 to call when the max number of characters is reached. GtkEntry has a max-length
3272 already but is silent about it.
3274 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3275 (create_page_account_details), (create_page_user_details),
3277 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3278 (create_page_account_details), (create_page_user_details),
3279 (create_page_outgoing):
3280 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3281 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3282 the UI spec, when the user tries to enter more than the max number of characters.
3284 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3286 * src/maemo/easysetup/modest-easysetup-wizard.c:
3287 (create_page_user_details), (create_page_custom_incoming),
3288 (create_page_custom_outgoing):
3289 * src/maemo/modest-account-settings-dialog.c:
3290 (create_page_user_details), (create_page_incoming),
3291 (create_page_outgoing):
3292 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3293 (modest_connection_specific_smtp_edit_window_init):
3294 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3295 not appropriate. Bad Maemo-specific defaults!.
3297 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3299 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3300 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3301 (modest_signature_editor_dialog_set_settings):
3302 Disable the label and textview when the checkbox is disabled, and use the
3303 specified (UI spec) default signature text.
3305 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3308 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3310 * src/modest-defs.h:
3311 * src/modest-account-mgr-helpers.h:
3312 * src/modest-account-mgr-helpers.c:
3313 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3315 * src/maemo/Makefile.am:
3316 * src/maemo/modest-signature-editor-dialog.c:
3317 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3320 * src/maemo/modest-account-settings-dialog.h:
3321 * src/maemo/modest-account-settings-dialog.c:
3322 (modest_account_settings_dialog_finalize), (on_button_signature),
3323 (save_configuration): Use the new dialog when the Edit button is pressed, and
3324 save the changes if necessary, as per the UI spec.
3326 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3328 * src/maemo/Makefile.am:
3329 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3330 based on maemo-develoers email from Dirk.
3332 * src/maemo/easysetup/modest-easysetup-wizard.c:
3333 (create_page_welcome), (create_page_account_details),
3334 (create_page_user_details), (create_page_complete_easysetup),
3335 (create_page_custom_incoming), (create_page_custom_outgoing),
3336 (create_page_complete_custom),
3337 (modest_easysetup_wizard_dialog_init):
3338 * src/maemo/modest-account-settings-dialog.c:
3339 (create_page_account_details), (create_page_user_details),
3340 (create_page_incoming), (create_page_outgoing),
3341 (modest_account_settings_dialog_init):
3342 * src/maemo/modest-connection-specific-smtp-window.c:
3343 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3345 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3347 * src/maemo/easysetup/modest-easysetup-wizard.c:
3348 (create_page_account_details), (create_page_custom_outgoing),
3349 (create_page_complete_custom):
3350 * src/maemo/modest-account-settings-dialog.c:
3351 (create_page_user_details), (create_page_incoming),
3352 (create_page_outgoing):
3353 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3354 (modest_connection_specific_smtp_edit_window_init):
3355 Use the correct (UI spec) port min/max, and use horizontal separators,
3358 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/easysetup/modest-easysetup-wizard.c:
3361 (set_default_custom_servernames):
3362 * src/maemo/modest-account-settings-dialog.c:
3363 (create_page_incoming), (on_combo_outgoing_security_changed),
3364 (on_combo_incoming_security_changed), (create_page_outgoing),
3365 (modest_account_settings_dialog_set_account_name),
3366 (save_configuration):
3367 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3368 (on_combo_security_changed),
3369 (modest_connection_specific_smtp_edit_window_init),
3370 (modest_connection_specific_smtp_edit_window_set_connection),
3371 (modest_connection_specific_smtp_edit_window_get_settings):
3372 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3375 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3378 * src/maemo/easysetup/modest-easysetup-wizard.c:
3379 (create_page_custom_outgoing), (create_page_complete_custom):
3380 * src/maemo/modest-account-settings-dialog.c:
3381 (create_page_user_details), (create_page_outgoing):
3382 * src/maemo/modest-account-view-window.c: (button_box_new):
3383 Use changed logical IDs as per the most recent UI spec:
3384 mcen_bd_emailsetup_edit -> mcen_bd_edit
3385 mcen_bd_emailsetup_delete -> mcen_bd_delete
3386 mcen_bd_emailsetup_close -> mcen_bd_close
3388 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3392 * src/dbus_api/Makefile.am:
3393 * src/dbus_api/modest-dbus-callbacks.c:
3394 * src/dbus_api/modest-dbus-callbacks.h:
3395 * src/maemo/modest-platform.c: (modest_platform_init):
3396 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3398 * tests/Makefile.am:
3399 * tests/dbus_api/Makefile.am:
3400 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3402 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3404 * src/maemo/modest-account-settings-dialog.c:
3405 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3406 Removed unnecessary includes.
3408 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3410 * src/maemo/easysetup/modest-easysetup-wizard.c:
3411 * src/maemo/modest-account-settings-dialog.c:
3412 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3413 * src/widgets/Makefile.am:
3414 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3415 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3416 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3417 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3418 * src/widgets/modest-secureauth-combo-box.c:
3419 * src/widgets/modest-secureauth-combo-box.h:
3420 * src/widgets/modest-serversecurity-combo-box.c:
3421 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3422 made the GObject names more consistent with the rest of the Modest code.
3424 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3426 * src/maemo/easysetup/Makefile.am:
3427 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3428 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3429 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3430 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3431 * src/maemo/easysetup/modest-easysetup-wizard.c:
3432 * src/maemo/easysetup/modest-validating-entry.c:
3433 * src/maemo/easysetup/modest-validating-entry.h:
3434 * src/maemo/modest-account-settings-dialog.c:
3435 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3436 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3437 widgets/ because they are used outside of easysetup too. After checking in,
3438 svn will allow me to rename them too.
3440 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3442 * src/gnome/modest-msg-edit-window.c:
3443 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3444 linker error, to fix the build on the GNOME platform.
3445 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3446 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3447 ifdefed out to avoid a warning.
3449 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3451 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3452 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3453 some alternative for GTK+ 2.6.
3455 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3457 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3459 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3460 specified for EmailAccountsDialog in UI spec.
3462 * src/maemo/easysetup/modest-easysetup-wizard.c:
3463 * src/maemo/easysetup/modest-easysetup-wizard.h:
3464 * src/maemo/modest-account-settings-dialog.c:
3465 * src/maemo/modest-account-settings-dialog.h:
3466 Reuse a member window widget for the connection-specific SMTP server accounts,
3467 so we can tell it to create/save the accounts only if we actually save changes.
3469 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3471 (modest_connection_specific_smtp_edit_window_get_settings):
3472 Return a struct instance for temporarily remembering the entered data.
3474 * src/maemo/modest-connection-specific-smtp-window.h:
3475 * src/maemo/modest-connection-specific-smtp-window.c:
3476 (modest_connection_specific_smtp_window_finalize),
3477 (modest_connection_specific_smtp_window_fill_with_connections),
3479 (modest_connection_specific_smtp_window_save_server_accounts),
3480 (update_model_server_names): Do not actually save data until asked,
3481 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3483 (on_selection_changed),
3484 (modest_connection_specific_smtp_window_init): Disable the edit
3485 button when nothing is selected.
3487 * src/modest-account-mgr-helpers.c:
3488 * src/modest-account-mgr-helpers.h:
3489 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3492 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3494 * src/modest-account-mgr-helpers.h:
3495 * src/modest-account-mgr-helpers.c:
3496 (modest_account_mgr_get_unused_account_name),
3497 (modest_account_mgr_get_unused_account_display_name): Added these
3498 utility functions, to avoid code duplication.
3500 * src/maemo/easysetup/modest-easysetup-wizard.c:
3501 (create_page_account_details), (create_account):
3502 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3503 (on_combo_security_changed),
3504 (modest_connection_specific_smtp_edit_window_init),
3505 (modest_connection_specific_smtp_edit_window_save_settings):
3506 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3507 * src/maemo/modest-connection-specific-smtp-window.c:
3508 (modest_connection_specific_smtp_window_finalize),
3509 (modest_connection_specific_smtp_window_fill_with_connections),
3510 (on_button_edit), (modest_connection_specific_smtp_window_init):
3511 * src/maemo/modest-connection-specific-smtp-window.h:
3512 Implementing saving of connection-specific server accounts.
3514 But I need to refactor this so we can save the data for each
3515 possible connection-specific account and only actually create the server accounts
3516 when the easysetup finished, or the OK button is pressed on the account settings
3519 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3522 (on_combo_security_changed):
3523 (modest_connection_specific_smtp_edit_window_init):
3524 Auto-fill the port number as in the account settings.
3526 (modest_connection_specific_smtp_edit_window_set_connection):
3527 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3528 * src/maemo/modest-connection-specific-smtp-window.c:
3529 (fill_with_connections), (on_button_edit),
3530 (modest_connection_specific_smtp_window_init):
3531 Turn the edit window into a dialog to simplify the code, and
3532 set a WM hint as in a GtkDialog, because only a popup can be on top of
3533 another window in Maemo, and popups usually have no WM decoration.
3535 * src/modest-defs.h:
3536 * src/modest-account-mgr-helpers.c:
3537 (modest_account_mgr_set_connection_specific_smtp),
3538 (modest_account_mgr_remove_connection_specific_smtp),
3539 (modest_account_mgr_get_connection_specific_smtp):
3540 * src/modest-account-mgr-helpers.h: Some functions to write the
3541 connection-specific SMTP server information. Not yet used.
3544 * src/widgets/modest-folder-view.c: (text_cell_data):
3545 Fix a warning about an uninitialized variable.
3546 (on_configuration_key_changed): Put an #ifdef around the use
3547 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3549 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3551 * src/maemo/modest-account-settings-dialog.h:
3552 * src/maemo/modest-account-settings-dialog.c:
3553 Added connect_for_modified() utility function to mark the new modified boolean.
3555 (create_page_account_details), (create_page_user_details),
3556 (create_page_incoming), (create_page_outgoing), (on_response),
3557 (modest_account_settings_dialog_init),
3558 (modest_account_settings_dialog_set_account_name):
3559 Only warn about unsaved changes when there are actually unsaved changes.
3561 * src/modest-account-mgr-helpers.c:
3562 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3563 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3564 to get the data from there in future.
3566 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3568 * src/modest-defs.h:
3570 * src/modest-account-mgr-helpers.h:
3571 * src/modest-account-mgr-helpers.c:
3572 Store the security account setting in a single conf key instead of using
3573 the options list, so that the list is left for just the to-be-removed camel hack,
3574 and because gconf_client_set_list() is failing for some reason.
3576 * src/modest-account-mgr.c:
3577 (modest_account_mgr_add_server_account):
3578 * src/maemo/modest-account-settings-dialog.c:
3579 (modest_account_settings_dialog_set_account_name),
3580 (save_configuration): Use the renamed functions.
3583 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3585 * src/widgets/Makefile.am:
3586 * src/widgets/modest-limit-retrieve-combo-box.c:
3587 * src/widgets/modest-limit-retrieve-combo-box.h:
3588 * src/widgets/modest-retrieve-combo-box.c:
3589 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3590 the account settings dialog.
3592 * src/modest-defs.h:
3593 * src/modest-account-mgr-helpers.h:
3594 * src/modest-account-mgr-helpers.c:
3595 (modest_server_account_get_option_secure_auth),
3596 (modest_server_account_set_option_secure_auth):
3597 * src/modest-account-mgr.c:
3598 (modest_account_mgr_add_server_account):
3599 Use the existing AUTH_MECH conf key for the secure-auth setting,
3600 instead of putting it in the list options, because this was actually used already.
3602 * src/maemo/modest-account-settings-dialog.c:
3603 (create_page_account_details),
3604 (modest_account_settings_dialog_set_account_name),
3605 (save_configuration):
3606 * src/maemo/modest-account-settings-dialog.h:
3607 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3608 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3610 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3613 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3614 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3616 * src/modest-defs.h:
3617 * src/maemo/modest-account-settings-dialog.c:
3618 (create_page_incoming), (on_combo_outgoing_security_changed),
3619 (on_combo_incoming_security_changed), (create_page_outgoing),
3620 (modest_account_settings_dialog_set_account_name),
3621 (save_configuration): Load/Save the port number, and change it when the
3622 security combo changes, to suitable defaults.
3624 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3626 * src/modest-account-mgr.c:
3627 (modest_account_mgr_add_server_account): Set the security and secure-auth
3628 options, and add a comment saying that the other camel-specific options should be
3631 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3633 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3635 * src/modest-tny-account-store.c: (account_list_free),
3636 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3637 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3640 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3642 * src/modest-protocol-info.c:
3643 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3644 is required by our UI spec. Maybe something in our implementation will use this eventually.
3645 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3646 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3647 instead of the previous 0 placeholder.
3649 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3650 secure-auth settings.
3651 * src/modest-account-mgr-helpers.h:
3652 * src/modest-account-mgr-helpers.c:
3653 (modest_server_account_data_get_option_secure_auth),
3654 (modest_server_account_set_option_secure_auth),
3655 (modest_server_account_data_get_option_security),
3656 (modest_server_account_set_option_security): Added this API for getting and setting the security
3657 and secure-auth settings.
3659 * src/maemo/modest-account-settings-dialog.h:
3660 * src/maemo/modest-account-settings-dialog.c:
3661 (modest_account_settings_dialog_finalize), (check_data),
3662 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3663 about changing titles.
3664 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3665 (save_configuration): Save the security and secure-auth settings.
3667 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3668 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3670 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3672 * src/modest-defs.h:
3673 * src/modest-account-mgr.c:
3674 (modest_account_mgr_add_server_account):
3675 Added and used defines for the options key and value pair strings,
3676 that are used so far, though they do not seem to correspond to anything in our
3677 UI specs or ModestProtocol enum.
3679 * src/modest-account-mgr-helpers.h:
3680 * src/modest-account-mgr-helpers.c:
3681 (compare_option_strings_for_name),
3682 (modest_server_account_data_get_option_value),
3683 (modest_server_account_data_get_option_bool),
3684 (modest_account_mgr_get_server_account_option):
3685 Added helper functions for parsing the options GSList.
3687 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3689 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3690 display name is based on the supplied account name.
3691 * src/modest-account-mgr.c:
3692 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3693 with an inefficient, but good-enough, implementation.
3695 * src/maemo/easysetup/modest-easysetup-wizard.c:
3696 (create_page_account_details), (on_before_next), (create_account):
3697 Check for existing display names rather than (non-user-visible) account names, and just
3698 create and set a unique account name at the end.
3700 * src/maemo/modest-account-settings-dialog.c:
3701 (modest_account_settings_dialog_init),
3702 (modest_account_settings_dialog_set_account_name),
3703 (create_page_incoming): Show the display name, instead of the account name.
3704 (on_response): Do some (not all) extra checks, as in the UI spec.
3705 (save_configuration): Save the display name if it was changed.
3707 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3709 * po/en_GB.po: Added needed logical ID and translation.
3710 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3711 (init_view): Made the is-default column clicking work.
3713 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/easysetup/Makefile.am:
3717 * src/maemo/easysetup/modest-easysetup-wizard.c:
3718 (modest_easysetup_wizard_dialog_init):
3719 * src/maemo/easysetup/provider-data-test.keyfile:
3720 * src/maemo/easysetup/provider-data.keyfile:
3721 Moved the provider data file to the new modest-providers-data package and used it from there.
3723 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3725 * src/modest-local-folder-info.c:
3726 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3727 N_() was already used on the static strings, but this just marks it for translation without
3728 using the translation.
3730 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3732 * src/maemo/modest-account-settings-dialog.c:
3733 (create_page_incoming),
3734 (modest_account_settings_dialog_set_account_name):
3735 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3736 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3737 I will do this if nobody else gets there first.
3739 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3741 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3742 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3743 save the security stuff.
3745 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3748 Set the email address and user fullname, which I now see must be
3751 * src/maemo/modest-account-settings-dialog.h:
3752 * src/maemo/modest-account-settings-dialog.c:
3754 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3755 leave-on-server and authentication.
3756 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3759 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3762 * src/maemo/modest-account-settings-dialog.c:
3763 * src/maemo/modest-account-settings-dialog.h:
3764 Most (but not all) of the widgets are now present as specified by the UI spec.
3765 No changes are yet saved, and some details are not properly shown yet.
3767 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3769 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/Makefile.am:
3772 * src/maemo/modest-account-settings-dialog.c:
3773 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3774 an existing account. Doesn't do much yet.
3776 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3777 Open the accounts settings dialog when Edit is clicked.
3779 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3781 * src/maemo/easysetup/Makefile.am:
3782 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3784 * src/maemo/easysetup/modest-easysetup-wizard.c:
3785 (modest_easysetup_wizard_dialog_init):
3786 Try to get the source directory from the build system,
3787 instead of hard-coding "./" into the source code, when opening our local
3788 copies of the configuration files.
3789 But this still fails when opening the wizard from the Accounts window,
3790 maybe because the working directory seems to change at runtime.
3791 So the wizard will fail the second time unless you copy the files into their
3792 proper locations - see the stdout warnings for the paths.
3794 (create_page_account_details),(on_before_next):
3795 Check for existing non-server accounts instead of server accounts,
3796 so the default account name is useful again, and to prevent trying to
3799 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3800 Show the wizard when New is clicked.
3802 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3803 (init_view): Show the column headers, and show the columns that are
3804 specified in the UI specs. However, something in Maemo's GTK+ prevents
3805 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3806 change the default account. This is despite unsetting the special properties.
3808 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3810 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3811 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3812 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3813 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3814 to make that clearer.
3815 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3817 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3819 * src/maemo/modest-account-view-window.c:
3820 (modest_account_view_window_init),
3821 (modest_account_view_window_new):
3822 Use the same buttons as specified in the
3823 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3824 the existing widgets, which never had a chance of working.
3825 Put the ModestAccountView treeview in a scrolled window.
3826 Do not repeat the initialization in both _init() and _new().
3828 * src/widgets/modest-account-view.c: (update_account_view):
3829 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3830 this widget and window shows no accounts.
3832 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3834 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3836 * src/maemo/easysetup/modest-easysetup-wizard.c:
3837 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3838 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3839 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3842 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3843 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3844 accounts exist yet, as in the UI spec.
3846 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3848 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/Makefile.am:
3851 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3852 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3853 New window for editing connection-specific smtp details.
3854 Not fully implemented.
3856 * src/maemo/modest-connection-specific-smtp-window.c:
3857 (modest_connection_specific_smtp_window_finalize) :
3858 unref the tree model.
3859 (on_button_edit): Show the edit window.
3861 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3863 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3866 * src/maemo/Makefile.am:
3867 * src/maemo/modest-connection-specific-smtp-window.c:
3868 * src/maemo/modest-connection-specific-smtp-window.h:
3869 New window for showing the list of connections, for connection-specific
3870 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3871 * src/maemo/easysetup/modest-easysetup-wizard.c:
3872 (create_page_custom_outgoing): Show the new window when the button is clicked.
3874 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3876 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3877 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3878 * src/maemo/modest-msg-edit-window.c:
3879 (modest_msg_edit_window_insert_image):
3880 * src/modest-conf.c: (modest_conf_key_escape):
3881 * src/modest-mail-operation.c:
3882 (modest_mail_operation_send_new_mail):
3883 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3884 (modest_ui_actions_on_new_account):
3885 * src/widgets/modest-attachment-view.c: (update_filename_request):
3886 * src/widgets/modest-mail-header-view.c:
3887 Corrected warnings that were breaking the build, by commenting out unused variables,
3888 and a function, and by including a header.
3890 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3892 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3893 so we can #ifdef around platform-specific code when necessary.
3894 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3895 to allow this to build for the GNOME platform too.
3897 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3899 * src/maemo/easysetup/modest-easysetup-wizard.c:
3900 Added util_increment_name() and used it in create_page_account_details()
3901 to make sure that the default account name is always a new name.
3903 (modest_easysetup_wizard_dialog_init),
3904 (set_default_custom_servernames): Some minor memory management fixes.
3906 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3910 * src/modest-runtime.c: (init_i18n): Restored the translation
3911 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3912 are defined in config.h, and the translations are installed.
3914 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3915 is defined for translation.
3917 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3919 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3921 * src/maemo/easysetup/modest-easysetup-wizard.c:
3922 (modest_easysetup_wizard_dialog_init):
3923 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3924 Use realistic paths (though they should use $prefix generically) to the
3925 mcc_mapping and provider-data.keyfile files which might work when they
3926 are installed by the future version of the operator-wizard package,
3927 and then fallback to paths in our source code, with an explanatory
3930 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3934 * src/maemo/Makefile.am:
3935 * src/maemo/easysetup/: Added files from the previously-exernal
3936 osso-modest-easysetup.
3937 * src/maemo/modest-main-window-ui.h:
3938 * src/modest-ui-actions.c:
3939 * src/modest-ui-actions.h:
3940 Added modest_ui_actions_on_new_account() as a signal handler for the
3941 New Account menu item. It shows the easysetup wizard.
3942 * po/en_GB.po: Added additional needed logical IDs and translations.