1 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/modest-main-window.c: (sync_accounts_cb):
4 Fixed projects.maemo.org bug NB#56472 (not yet activated as there
5 is another problem with the code, see Murray's comment at line 772)
7 2007-06-08 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
10 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
11 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
12 (load_from_file), (easysetup_country_combo_box_init),
13 (easysetup_country_combo_box_get_active_country_ids),
14 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
15 instead of just one ID, to avoid duplicate country names in the UI.
17 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
18 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
19 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
20 a single ID, avoiding duplicate providers.
21 * src/maemo/easysetup/modest-easysetup-wizard.c:
22 (on_combo_account_country): Adapt to use a list.
24 2007-06-08 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
27 keys changed in the last X seconds.
29 * src/modest-account-mgr.h:
30 * src/modest-account-mgr.c: (on_timeout_notify_changes),
31 (on_key_change), (modest_account_mgr_class_init),
32 (modest_account_mgr_init), (modest_account_mgr_finalize):
33 As the keys are changed, save them in a GSList* and signal that GSList*
34 further every X seconds, to batch changes, to allow us to do just one
35 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
36 bug NB#56941 and other (UI-blocking) delays when changing account settings.
38 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
39 changed signal signature.
41 * src/modest-conf.c: (modest_conf_set_list),
42 (modest_conf_on_change): Reenable notification.
44 (modest_conf_maemo_fake_on_change): Comment out the hack that
45 notified immediately instead of asynchronously.
47 * src/widgets/modest-account-view.h:
48 * src/widgets/modest-account-view.c:
49 (update_account_view): Select the previously-selected account ID,
50 if possible. This fixes projects.maemo.org bug NB#56933.
52 (on_account_changed), (on_account_removed),
53 (modest_account_view_select_account):
55 Remove the block/unblock functions
56 because they were not useful.
58 * src/maemo/modest-account-view-window.c:
59 (on_delete_button_clicked), (on_edit_button_clicked),
60 (on_new_button_clicked): Remove the use of the non-working block/unblock.
62 2007-06-08 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
65 Improve the error dialog to show Incorrect Account Settings, which seems
66 clearer, and say that the internal error message (to be removed from the
67 dialog later) is often misleading.
68 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
70 * src/modest-tny-account.c:
71 (modest_tny_account_new_from_server_account): Uncomment the printf of the
72 URL because this is so useful for debugging on the device.
74 * src/widgets/modest-serversecurity-combo-box.c:
75 (modest_serversecurity_combo_box_fill): Correct a logical ID.
77 2007-06-08 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-mail-operation.c:
80 (modest_mail_operation_send_new_mail):
81 Added a comment about a nasty but apparently harmless message. Details
82 added to the wiki g_warnings() page.
84 2007-06-08 Murray Cumming <murrayc@murrayc.com>
86 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
87 (modest_tny_send_queue_class_init):
88 Do not use the priv struct because it is empty, to avoid g_warnings
89 about a non-existant priv struct.
91 * src/modest-tny-account-store.c:
92 (modest_tny_account_store_get_server_account),
93 (modest_tny_account_store_get_transport_account_for_open_connection
94 ): Do not try to get transport server accounts for local folders,
95 because they don't have any. This avoids a g_warning().
97 * src/maemo/modest-main-window.c:
98 (modest_main_window_notify_send_receive_initied),
99 (on_configuration_key_changed):
100 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
102 * src/modest-mail-operation.c:
103 (modest_mail_operation_update_account):
104 * src/modest-tny-account-store.h:
105 * src/modest-tny-account.c:
106 (modest_tny_account_get_special_folder),
107 (modest_tny_account_new_for_local_folders),
108 (modest_tny_account_new_for_per_account_local_outbox_folder):
109 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
110 * src/modest-tny-local-folders-account.c:
111 (add_account_folders_to_merged_folder):
112 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
113 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
114 (modest_ui_actions_on_send):
115 * src/widgets/modest-folder-view.c: (update_model):
116 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
117 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
118 modest_tny_account_store_get_tny_account_by_account() to
119 modest_tny_account_store_get_server_account() to make the code clearer.
121 2007-06-07 Marcus Bauer <marcusb@openismus.com>
123 * src/dbus_api/modest-dbus-api.h:
124 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
125 * src/maemo/modest-msg-edit-window.c:
126 (modest_msg_edit_window_attach_file_noninteractive):
127 added g_warning in case the file to be attached does not exist
128 * tests/dbus_api/test_compose_mail.c: (main):
129 removed obsolete comment, added generic files as test case
131 2007-06-07 Murray Cumming <murrayc@murrayc.com>
133 * src/modest-tny-account-store.c: (get_server_accounts):
134 Create the local folders account only once, not once for each outbox, and
135 not only when there are some outboxes.
137 2007-06-07 Murray Cumming <murrayc@murrayc.com>
139 * src/widgets/modest-folder-view.c: (update_model): Comment out some
140 code that is causing a crash at startup. Sergio says that he is fixing this.
142 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
144 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
145 * src/maemo/modest-account-settings-dialog.c:
146 (create_page_outgoing),
147 (modest_account_settings_dialog_set_account_name),
148 (save_configuration):
149 - Fixed handling of the "Use secure authentication" toggle to comply with
150 the ui specification. See also projects.maemo.org bug NB#58400
152 - Restore the Secure connection setting combo correctly when loading
155 * src/maemo/modest-maemo-utils.c:
156 (on_camel_account_get_supported_secure_authentication),
157 (modest_maemo_utils_get_supported_secure_authentication_methods):
158 Fixed a crasher if operation is canceled
160 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
161 (modest_protocol_info_auth_is_secure):
162 * src/modest-protocol-info.h:
164 Added two new methods to determine if a protocol/auth method is secure/encrypted in
165 the sense of the "Use secure authentication" toggle.
167 2007-06-07 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-tny-account-store.h:
170 * src/modest-tny-account-store.c:
171 Added modest_tny_account_store_get_local_folders_account().
173 * src/modest-tny-folder.h:
174 * src/modest-tny-folder.c:
175 (modest_tny_folder_get_account):
176 Added this replacement for tny_folder_get_account() which returns
177 the local-folders account for TnyMergeFolders, to avoid the
178 warning about the unimplemented get_account_func() vfunc().
180 (modest_tny_folder_get_rules),
181 * src/modest-ui-actions.c:
182 (modest_ui_actions_on_folder_selection_changed):
183 * src/modest-mail-operation.c:
184 (modest_mail_operation_remove_folder),
185 (modest_mail_operation_xfer_folder),
186 (modest_mail_operation_rename_folder),
187 (modest_mail_operation_get_msg),
188 (modest_mail_operation_get_msgs_full),
189 (modest_mail_operation_remove_msg),
190 (modest_mail_operation_xfer_msgs),
191 (modest_mail_operation_refresh_folder):
192 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
194 2007-06-07 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
197 (modest_server_account_set_security):
198 * src/modest-defs.h: Add comments explaining that our
199 UI spec means TLS when it says Normal, so these do not look like errors.
201 * src/modest-tny-account.c:
202 (modest_tny_account_new_from_server_account): Use the new tinymail
203 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
204 for TLS. This should fix projects.maemo.org bug NB#58460.
206 2007-06-06 Murray Cumming <murrayc@murrayc.com>
208 * src/maemo/easysetup/modest-easysetup-wizard.c:
209 (create_account): Correct the position of the gconf sanity check warning.
210 (on_button_edit_advanced_settings): Show the dialog immediately, instead
211 of using the g_idle_add() hack, because this does not seem to be necessary
212 on osso 1.1. It might even work on Maemo Bora if the problems were actually
213 caused by something other than maemo's gconf.
214 This fixes projects.maemo.org bug #59022.
216 2007-06-06 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-account-mgr-helpers.c:
219 (modest_account_mgr_get_default_account): Do not check that the account
220 exists if there is no default account (NULL), to fix a runtime warning.
222 2007-06-06 Murray Cumming <murrayc@murrayc.com>
224 * src/widgets/modest-folder-view.c: (update_model):
225 Do not unref the treemodel before we have finished with it.
226 This prevents a valgrind warning and an occasional crash at startup.
228 2007-06-06 Marcus Bauer <marcusb@openismus.com>
230 * libmodest-dbus-client/libmodest-dbus-client.h:
231 added libmodest_dbus_client_compose_mail()
232 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
234 added functions needed for SendAsMail() functionality
235 * src/maemo/modest-msg-edit-window.c:
236 (modest_msg_edit_window_attach_file_noninteractive):
237 non interactively attaching files to message edit window
238 * src/widgets/modest-msg-edit-window.h:
239 * tests/dbus_api/Makefile.am:
240 added test_compose_mail.c
241 * tests/dbus_api/test_compose_mail.c: (main):
243 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
245 * src/modest-account-view.c:
246 Fixed bug projects.maemo.org bug NB#59307
248 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
250 * src/maemo/easysetup/modest-easysetup-wizard.c:
251 (get_serverport_incoming), (on_before_next), (create_account):
252 * src/maemo/modest-account-settings-dialog.c:
253 (modest_account_settings_dialog_set_account_name):
254 * src/maemo/modest-maemo-utils.c:
255 (on_camel_account_get_supported_secure_authentication_status),
256 (on_camel_account_get_supported_secure_authentication),
257 (on_secure_auth_cancel),
258 (modest_maemo_utils_get_supported_secure_authentication_methods):
260 Implemented security authentication for settings and easysetup.
262 2007-06-05 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-main-window.c: (create_details_widget):
265 Show the total size for memory card accounts too, instead of showing
266 the name again. Fixes bug projects.maemo.org bug NB#59307.
268 2007-06-05 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-tny-simple-folder-store.c:
272 * src/modest-tny-simple-folder-store.h: Removed.
274 * src/modest-tny-local-folders-account.h
275 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
276 for the local-folders maildir, with an extra TnyMergedFolder containing
277 the folders of the per-account outbox store accounts.
278 * src/modest-tny-account-store.c: (get_server_accounts):
279 Add the outboxes to the special local folders account after creating it.
281 * src/modest-tny-account.c:
282 (modest_tny_account_new_for_local_folders): Create the derived
283 account when creating the main local-folders account.
285 * src/maemo/modest-main-window.c: (create_details_widget),
286 (modest_main_window_set_contents_style):
287 Adapted to the use of the derived account instead of the folder store.
289 * src/modest-ui-actions.c:
290 (modest_ui_actions_on_folder_selection_changed):
291 * src/modest-ui-dimming-rules.c:
292 (modest_ui_dimming_rules_on_new_folder):
293 * src/widgets/modest-folder-view.c: (text_cell_data),
294 (icon_cell_data), (filter_row), (update_model),
295 (get_cmp_rows_type_pos):
298 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
299 Do not get the priv struct, because no priv struct has been set,
300 to avoid a runtime warning.
302 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
303 #ifelse with #else, to fix a warning, to fix the build.
306 2007-06-05 Christian Kellner <ckellner@openismus.com>
308 * libmodest-dbus-client/libmodest-dbus-client.c:
309 Fix small typo in doc (why do you always see them
310 AFTER committing stuff?)
313 2007-06-05 Christian Kellner <ckellner@openismus.com>
315 * libmodest-dbus-client/libmodest-dbus-client.c:
316 (libmodest_dbus_client_search):
317 Initialize hit list with NULL. Also set folder list
318 to "" if NULL was supplied.
321 2007-06-03 Christian Kellner <ckellner@openismus.com>
323 * libmodest-dbus-client/libmodest-dbus-client.c:
324 (modest_search_hit_list_free):
325 Make it save to call it with NULL.
327 * src/dbus_api/modest-dbus-callbacks.c:
328 * src/modest-search.c:
329 Return full ModestSearchHits as the search result list not TnyHeader
330 since can't be around withouth the correspoding TnyFolder.
332 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
334 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
335 Added currently commented code to check for secure auth
337 * src/maemo/modest-account-settings-dialog.c: (on_response),
338 (save_configuration), (show_ok):
339 Fixed projects.maemo.org bugs NB #59248 and #59251
341 * src/maemo/modest-maemo-utils.c:
342 (on_camel_account_get_supported_secure_authentication_status),
343 (on_camel_account_get_supported_secure_authentication),
344 (modest_maemo_utils_get_supported_secure_authentication_methods):
345 * src/maemo/modest-maemo-utils.h:
346 Moved get_supported_secure_authentication() method here to be able
347 to use it from easysetup wizard.
349 * src/modest-pair.c: (on_pair_compare_as_string):
350 Should compare string with first part of pair and not
351 strcmp pairs which will crash.
353 * src/modest-protocol-info.c:
354 (modest_protocol_info_protocol_is_store):
355 * src/modest-protocol-info.h:
356 Added modest_protocol_info_get_auth_protocol_name()
358 2007-06-03 Armin Burgmeier <armin@openismus.com>
360 * src/modest-mail-operation.c:
361 (modest_mail_operation_get_msgs_full): Set priv->account also when
362 only retrieving a single message. This avoids a crash when canceling
365 (modest_mail_operation_notify_end): Do not explicitely remove the
366 operation from the queue but only emit the progress_changed signal.
367 The queue itself listens to that signal to remove the operation when
368 it is finished. This reduces coupling and removes a potential deadlock
369 when modest_mail_operation_notify_end() is called from the queue
370 itself. If that is a problem performance-wise, I would suggest to
371 implement a status-changed signal or something.
373 * src/modest-mail-operation-queue.c: Make sure to never call a
374 function from another file while the queue is locked. This (hopefully)
375 fixes another deadlock when exiting the application while retrieving
378 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
380 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
381 Fixed build if libogs is not available
383 2007-06-03 Christian Kellner <ckellner@openismus.com>
385 * libmodest-dbus-client/libmodest-dbus-client.h:
386 * libmodest-dbus-client/libmodest-dbus-client.c:
387 (libmodest_dbus_client_delete_message):
388 Implement deletion of messages (Client side).
390 (modest_search_hit_free),
391 (modest_search_hit_list_free):
392 Utility functions to free the result hits.
394 * src/dbus_api/modest-dbus-api.h:
395 * src/dbus_api/modest-dbus-callbacks.c:
397 (modest_dbus_req_handler):
398 Implement deletion of messages (Server side).
400 * tests/dbus_api/test_search.c: (main):
403 * tests/dbus_api/Makefile.am:
404 * tests/dbus_api/test_delete_message:
405 Add little test for the message deletion logic
407 2007-06-03 Armin Burgmeier <armin@openismus.com>
409 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
410 when the operation queue was not empty. projects.maemo.org bug
413 2007-06-03 Armin Burgmeier <armin@openismus.com>
415 * src/widgets/modest-account-view.c
416 (on_account_default_toggled): Toggle default account column
417 explicitely instead of waiting for gconf notification (which is
418 currently ignored). This should fix projects.maemo.org bug NB#56910
419 for now. It should probably be removed when gconf notifications are
422 2007-06-03 Christian Kellner <ckellner@openismus.com>
424 * libmodest-dbus-client/libmodest-dbus-client.c:
425 Removed debugging spew.
427 * src/dbus_api/modest-dbus-callbacks.c:
428 Added debugging info.
430 * src/modest-search.c:
431 (modest_search_all_accounts):
432 Use tny_account_store_get_accounts () on the account store
433 to get all accounts which is the way to get all accounts.
435 * tests/dbus_api/test_search.c: (main):
436 Make it possible to supply the search term on the command line.
438 2007-06-03 Christian Kellner <ckellner@openismus.com>
440 * libmodest-dbus-client/libmodest-dbus-client.c:
441 * libmodest-dbus-client/libmodest-dbus-client.h:
442 Implement searching for mesages over raw dbus. (Client side)
444 * src/dbus_api/Makefile.am:
445 * src/dbus_api/modest-dbus-api.h:
446 * src/dbus_api/modest-dbus-callbacks.c:
447 * src/dbus_api/modest-dbus-callbacks.h:
448 Search framework (Server side). Also implement on_idle_open_message().
450 * src/maemo/modest-platform.c: (modest_platform_init):
451 Prepare for raw dbus/osso rpc interaction.
453 * src/modest-search.h:
454 Changed minsize from unspecific guint to guint32.
456 * src/modest-search.c:
458 Added strange hack which magically made tnymail work.
460 (modest_search_folder),
461 (modest_search_account),
462 (modest_search_all_accounts):
463 Implement helper functions to search all accounts, specific account
466 * tests/dbus_api/Makefile.am:
467 * tests/dbus_api/test_open_message.c:
468 Read url to open from commandline.
470 * tests/dbus_api/test_search.c:
471 Implement small test for dbus search stuff
473 2007-06-02 Armin Burgmeier <armin@openismus.com>
475 * src/maemo/modest-account-settings-dialog.c: Changed window title to
476 include account type and account title. This fixes projects.maemo.org
479 * src/maemo/modest-account-view-window.c: Set a title for the window.
481 2007-06-02 Armin Burgmeier <armin@openismus.com>
483 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
484 incoming and outgoing server name based on email address and server
485 types as long as the names have not been edited manually. This fixes
486 projects.maemo.org bug NB#58671.
488 2007-06-02 Armin Burgmeier <armin@openismus.com>
490 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
491 server type cannot be changed in future to the incoming details page
492 when creating an account. This fixes projects.maemo.org bug NB#59029.
494 2007-06-02 Armin Burgmeier <armin@openismus.com>
496 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
497 and assigned max width chars so that they wrap instead of being
498 truncated. Fixes projects.maemo.org bug NB#56126.
500 2007-06-02 Armin Burgmeier <armin@openismus.com>
502 * src/maemo/modest-connection-specific-smtp-window.c: Add an
503 introductory note to the connection specific smtp servers dialog, as
504 section 8.12 of the email UI specification requires. This fixes
505 projects.maemo.org bug NB#59212.
507 2007-06-01 Murray Cumming <murrayc@murrayc.com>
509 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
510 Check for running mail operations, and offer to cancel them, as per the UI
511 spec. This fixes projects.maemo.org bug NB#59041 .
512 However, I suspect that tinymail may still use the network connection
513 in ways that we cannot detect or cancel. But it should at least adapt to
516 2007-06-01 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-tny-account-store.c: (recreate_all_accounts),
519 (get_cached_accounts), (get_server_accounts): Do more sensible
520 ref-counting of the temporarily-cached outbox accounts list. This seems
521 to fix a crash when entering the password when the password was wrong.
523 2007-06-01 Murray Cumming <murrayc@murrayc.com>
525 * src/gnome/modest-main-window.c: (connect_signals):
526 * src/modest-tny-account-store.c: (get_password),
527 (modest_tny_account_store_alert): Added comments and clues and
528 commented-out code about how we currently fail to deal with connection
529 errors and wrong passwords, and how we should.
531 2007-06-01 Murray Cumming <murrayc@murrayc.com>
533 * src/widgets/modest-retrieve-combo-box.c:
534 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
535 This fixes projects.maemo.org bug NB#58472 .
537 2007-06-01 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/easysetup/modest-easysetup-wizard.c:
540 (create_page_complete_easysetup):
541 (create_page_complete_custom): Correct the last commit,
542 putting the correct sentences in the correct pages.
544 2007-06-01 Murray Cumming <murrayc@murrayc.com>
546 * src/maemo/easysetup/modest-easysetup-wizard.c:
547 (create_page_complete_custom): Show the second sentence of text
548 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
553 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
554 Set the leave-on-server conf key by default. This fixes
555 projects.maemo.org bug NB#59258 .
557 2007-06-01 Murray Cumming <murrayc@murrayc.com>
559 * src/maemo/modest-account-view-window.c:
560 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
561 logical ID for the confirmation messages. Fixed projects.maemo.org bug
564 2007-06-01 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/easysetup/modest-easysetup-wizard.c:
567 (create_caption_new_with_asterisk):
568 * src/maemo/modest-account-settings-dialog.c:
569 (create_caption_new_with_asterisk):
570 Uncomment the code to add the asterisk, because they are no longer in the
571 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
572 (update_incoming_server_title): Add an asterisk here too.
574 2007-06-01 Murray Cumming <murrayc@murrayc.com>
576 * src/maemo/modest-maemo-global-settings-dialog.c:
577 (current_connection): Check that we are even connected before trying to
578 get the current connection name, to prevent a warning.
580 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
581 Change the comments because tny_maemo_conic_device_connect() is now meant to
583 * src/modest-mail-operation.c:
584 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
585 make sure we have a connection and fail if we can't connect.
587 2007-05-31 Murray Cumming <murrayc@murrayc.com>
589 * src/maemo/modest-main-window.c:
590 (on_account_store_connecting_finished): Do not try to get the
591 connection ID if we are not really connected. I am surprised that
592 this signal handler is called when we are not connected.
594 2007-05-31 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-error.h:
597 * src/modest-ui-actions.c:
598 (modest_ui_actions_get_msgs_full_error_handler):
599 Renamed an enum, added comments, added an enum
600 for retrieve-limit errors.
602 * src/modest-mail-operation.c: (foreach_add_item),
603 (internal_folder_observer_update), (update_account_thread),
604 (modest_mail_operation_get_msgs_full):
605 (modest_mail_operation_update_account),
606 Added comments about how this works, and some code that should
607 (but does not) check the retrieve-limit. See the TODO comment.
609 2007-05-31 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
612 Initialize help_id to fix the build. Warnings are good.
614 2007-05-31 Murray Cumming <murrayc@murrayc.com>
616 * src/widgets/modest-hbox-cell-renderer.c:
617 (modest_hbox_cell_renderer_append):
618 * src/widgets/modest-vbox-cell-renderer.c:
619 (modest_vbox_cell_renderer_append):
620 Fix the last commit by doing an extra ref.
622 2007-05-31 Murray Cumming <murrayc@murrayc.com>
624 * src/widgets/modest-hbox-cell-renderer.c:
625 (modest_hbox_cell_renderer_append):
626 * src/widgets/modest-vbox-cell-renderer.c:
627 (modest_vbox_cell_renderer_append):
628 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
629 to fix the build with Maemo Bora.
630 However, there seems to be a remaining crash, probably due to reference
633 2007-05-30 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-tny-account.c:
636 (modest_tny_account_new_for_local_folders):
637 Use hildon_file_system_info_async_new() to get a better name for
638 the memory card account, setting it as the account name.
639 The timing seems to work, but this is probably
640 not the best place to do this. See the TODO comment.
641 * src/maemo/modest-main-window.c: (create_details_widget):
642 * src/widgets/modest-folder-view.c: (text_cell_data):
643 Use the tny account name instead of hardcoding a name.
645 2007-05-30 Christian Kellner <ckellner@openismus.com>
647 * src/modest-search.c: (modest_search):
648 Correctly set part_search_func even if we have already parsed
649 the query and thus a valid OgsTextSearcher object.
651 2007-05-30 Christian Kellner <ckellner@openismus.com>
654 Search and check for libogs.
657 Incooparte the ogs build env.
659 * src/modest-mime-part-search-stream.c:
660 * src/modest-mime-part-search-stream.h:
661 Removed since we do the real searching now in modest-search.c.
663 * src/modest-search.c:
664 * src/modest-search.h:
665 Implement support for ogs. We use that if available and requested
666 and fall back to modest_text_utils_utf8_strcmp (). The search logic
667 should now handle the corner case when the search term is spread
668 across multiple reads.
669 Also the logic in modest_search () was corrected to search all
670 requested fields until one is found.
672 2007-05-30 Murray Cumming <murrayc@murrayc.com>
674 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
677 * src/modest-init.c: Made modest_init_local_folders() take a
678 path and be public so we can iniitialize maildir folders on
681 * src/modest-local-folder-info.h:
682 * src/modest-local-folder-info.c:
683 (modest_local_folder_info_get_maildir_path): Add a path parameter.
685 * src/modest-tny-account.c:
686 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
687 still means the standard local-folders path on the local volume.
689 * src/modest-tny-account-store.c:
690 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
691 signal so we can detect mount/unmount of the MMC1 card, and do an update of
692 all accounts when that happens.
693 (get_server_accounts): If the MMC1 card is mounted, create a store account for
694 this too, so it shows up in the treeview.
696 2007-05-28 Murray Cumming <murrayc@murrayc.com>
698 * src/maemo/modest-maemo-global-settings-dialog.c:
699 (current_connection):
700 * src/widgets/modest-global-settings-dialog.c:
701 (current_connection_default):
702 Use the enum values instead of 0, 1 and -1,
703 to make the code clearer.
705 * src/modest-account-mgr-helpers.c:
706 (modest_account_mgr_get_connection_specific_smtp): Make this code
709 * src/modest-runtime.h:
710 * src/modest-runtime.c:
711 Added modest_runtime_remove_all_send_queues().
712 * src/maemo/modest-main-window.c:
713 (on_account_store_connecting_finished): Recreate the send queues,
714 using the appropriate transport accounts for this new connection.
715 Some futher adapting might be needed if the old send queues are not
716 automatically stopped at this point.
718 * src/modest-tny-account-store.c: (get_server_accounts):
719 Create the connection-specific transport accounts, so that they can
720 be found later by their ID.
722 * src/modest-tny-account.h:
723 * src/modest-tny-account.c:
724 Added modest_tny_account_new_from_server_account_name().
725 modest_tny_account_new_from_server_account(): Do not create the
726 send queues here, because they will be
727 recreated anyway when the connection changes for the first time.
729 2007-05-28 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-local-folder-info.h:
732 * src/modest-local-folder-info.c:
733 (modest_per_account_local_outbox_folder_info_get_maildir_path),
734 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
735 tbox_folder): Take a modest account name instead of a server TnyAccount,
736 so we can have per-modest-account rather than per-transport-account
738 We must make sure that we change or recreate the exisitng send queues
739 when the connection changes for connection-specific transport accounts.
741 * src/modest-tny-account-store.c:
742 (create_per_account_local_outbox_folders): Create outboxed per modest
743 account, not per transport account.
745 * src/modest-tny-account.h:
746 * src/modest-tny-account.c:
747 (modest_tny_account_get_special_folder): For outboxes, get the
748 parent modest account name. The account is ignored for other folders.
749 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
750 modest account name rather than a server TnyAccount.
752 2007-05-25 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-tny-account.c:
755 (modest_tny_account_new_from_server_account):
756 Call modest_runtime_get_send_queue() immediately after creating transport
757 accounts, so that they start trying to send email from the outbox as soon
758 as possible at startup. This is probably what we want.
760 * src/modest-mail-operation.c: (update_account_thread):
761 * src/modest-runtime.c: (modest_runtime_get_send_queue):
762 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
763 * src/modest-tny-send-queue.h:
764 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
765 (modest_ui_actions_on_send):
766 Added comments about how sending works, though it needs some more work.
768 2007-05-25 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-tny-account.c:
771 (modest_tny_account_get_special_folder): Add TODO because this fails when
773 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
774 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
775 Do not try to show this window when there is no active account. The UI
776 specs does not tell us what to do in this case.
778 2007-05-24 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/Makefile.am:
783 * src/widgets/Makefile.am: Some dist fixes.
785 2007-05-24 Murray Cumming <murrayc@murrayc.com>
787 * src/maemo/modest-connection-specific-smtp-window.c:
788 (on_button_edit): Make the code clearer, to prevent a double free.
790 2007-05-24 Murray Cumming <murrayc@murrayc.com>
792 * src/maemo/modest-account-settings-dialog.c:
793 (modest_account_settings_dialog_set_account_name),
794 Check the connection-specific smtp servers checkbox if there are any.
796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
797 (modest_connection_specific_smtp_edit_window_init):
798 Start with a suitable port number.
800 * src/modest-account-mgr-helpers.h:
801 * src/modest-account-mgr-helpers.c: Added
802 modest_account_mgr_get_has_connection_specific_smtp().
804 (modest_account_mgr_set_connection_specific_smtp),
805 (modest_account_mgr_remove_connection_specific_smtp),
806 (modest_account_mgr_get_has_connection_specific_smtp),
807 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
808 connection-specific smtp server accounts in the account, rather than
809 the server account conf dir.
811 This fixes bug projects.maemo.org bug NB#58263 .
813 * src/modest-tny-account-store.c:
814 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
815 if there are no server accounts yet, to prevent an infinite loop when there
816 are no accounts. Document that one must be called before the other.
818 2007-05-24 Murray Cumming <murrayc@murrayc.com>
820 * src/modest-account-mgr-helpers.c:
821 (modest_account_mgr_get_default_account): Make sure that at least
822 one account is always the default, if there are any enabled accounts.
823 This is just a sanity check that shouldn't be necessary.
825 * src/modest-account-mgr-priv.c:
826 (_modest_account_mgr_account_from_key): Unescape the conf key to
827 get the real account name. For instance, this is an issue if a space
828 was in the account name, which can happen because the account name
829 is generated from the display name.
830 (_modest_account_mgr_get_account_keyname): Always escape the
832 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
833 Unescape the conf keys to get the real account names.
835 For instance, previously the is-default radio button in the accounts
836 list was not checked for any accounts at first. This fixes that,
837 and might fix several similar bugs.
839 2007-05-23 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
842 Removed some debug printfs.
844 2007-05-23 Murray Cumming <murrayc@murrayc.com>
846 Modest on-disk outbox directories are now here, for instance:
847 $HOME/.modest/outboxes/<account-id-1>/outbox
848 $HOME/.modest/outboxes/<account-id-2>/outbox
850 $HOME/.modest/local-folders/outbox
851 so we can have a separate outbox for each account.
852 But they are shown as one outbox in the GtkTreeView, by using a
853 TnyMergeFolder in a ModestTnySimpleFolderStore.
856 * src/modest-tny-simple-folder-store.c:
857 * src/modest-tny-simple-folder-store.h:
858 Added ModestTnySimpleFolderStore, used to contain folders from
859 other folder stores, such as other accounts.
861 * src/modest-tny-outbox-account.h:
862 * src/modest-tny-outbox-account.c:
863 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
864 used for the per-account local outbox folders.
866 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
867 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
868 only use this (internally) now for the non-outbox local folders.
871 * src/modest-init.c: Added modest_init_one_local_folder(), for
872 setting up the directory structure for each local folder.
874 * src/modest-local-folder-info.c:
875 (modest_per_account_local_outbox_folder_info_get_maildir_path),
876 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
878 * src/modest-local-folder-info.h:
879 * src/modest-tny-account-store.c: (on_account_removed),
880 (on_account_changed), (create_per_account_local_outbox_folders),
881 (get_server_accounts), (modest_tny_account_store_get_accounts),
882 (modest_tny_account_store_get_tny_account_by_account),
883 (modest_tny_folder_store_is_virtual_local_folders):
885 * src/modest-tny-account.h:
886 * src/modest-tny-account.c:
887 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
888 to create an on-disk per-account local outbox folder for each
890 (create_per_account_local_outbox_folders): Create a local outbox folder
891 for each transport account.
892 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
893 for all local folders.
895 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
896 instead of using g_object_get/set() directly. It is clearer.
898 (modest_tny_folder_store_get_message_count),
899 (modest_tny_folder_store_get_local_size
900 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
901 because we now use these with non-acount folder stores.
903 (modest_tny_account_get_special_folder),
904 (modest_tny_account_new_from_server_account),
905 (modest_tny_account_new_from_account):
906 (recurse_folders): Adjust to the new outbox system.
908 * src/modest-tny-folder.h:
909 * src/modest-tny-folder.c:
910 (modest_tny_folder_is_local_folder),
911 (modest_tny_folder_get_local_folder_type),
912 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
914 * src/widgets/modest-main-window.h:
915 * src/maemo/modest-main-window.c: (create_details_widget),
916 (modest_main_window_set_contents_style): Show details for any folder store,
919 (modest_tny_folder_get_rules):
920 Remove the const. C does not support constness enough for this.
922 * src/modest-ui-actions.c:
923 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
924 make all outboxes appear as one, in the usual local-folders tree node.
926 (set_active_account_from_tny_account),
927 (modest_ui_actions_on_folder_selection_changed):
928 * src/widgets/modest-folder-view.c: (text_cell_data),
929 (icon_cell_data), (filter_row),
930 (add_account_folders_to_merged_folder),
931 (add_account_folders_to_simple_folder_store), (),
932 (get_cmp_rows_type_pos), (cmp_rows),
933 (modest_folder_view_set_account_id_of_visible_server_account):
934 Adjust to the new outbox system, using generic folder stores and folders
937 2007-05-23 Christian Kellner <ckellner@openismus.com>
939 * src/modest-mail-operation.c:
940 (modest_mail_operation_update_account):
941 Use info->max_size instead of unintialized local var [small
942 build fix]. (Added TODO to review that change since I don't
945 2007-05-23 Marcus Bauer <marcusb@openismus.com>
947 * libmodest-dbus-client/libmodest-dbus-client.c:
948 (libmodest_dbus_client_compose_mail): function added
949 * src/dbus_api/modest-dbus-api.h:
950 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
951 (on_compose_mail): Implementation of the SendAsMail functionality
953 2007-05-22 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-account-mgr.c:
956 (modest_account_mgr_add_server_account): Set the secure-connection
957 conf key for transport accounts as well as store accounts. I don't know
958 why the if was there. For instance, this makes sure that we use SSL
959 for the gmail preset from the easysetup wizard.
961 2007-05-22 Murray Cumming <murrayc@murrayc.com>
963 * src/gnome/modest-main-window.c:
964 (on_account_store_connecting_finished), (connect_signals):
965 * src/maemo/modest-main-window.c:
966 (on_account_store_connecting_finished), (connect_signals),
967 (modest_main_window_new):
968 Handle TnyAccountStore::connecting-finished instead of
969 TnyDevice::connection-changed, because we cannot actually perform
970 operations on accounts until TnyAccountStore has itself responded to
971 the TnyDevice::connection-changed signal. This prevents a GError from
973 Do not try to update at startup, because we (at least on scratchbox)
974 already do an update at startup when the device goes online.
975 This prevents a GError from tinymail.
976 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
977 Added TODO about stopping simultaneous operations.
979 2007-05-21 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
982 * src/modest-mail-operation-queue.c:
983 (modest_mail_operation_queue_remove):
984 * src/modest-tny-account-store.c: When GErrors happen, give more clues
985 about where they happened.
987 2007-05-21 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-ui-actions.c:
990 (modest_ui_actions_on_password_requested): Make sure that the remember
991 output parameter is always TRUE.
993 2007-05-21 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
996 Show a OK/Cancel dialog if the error is a question, though we still do not
997 know anything more about what we are asking the user.
998 * src/widgets/modest-folder-view.c: (on_drag_data_received):
999 Fix an uninitialized variable (helper). This is a logic error, however.
1001 2007-05-21 Christian Kellner <ckellner@openismus.com>
1003 * src/modest-search.h:
1004 Correct bit shifting in the ModestSearchFlags enum.
1006 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-tny-account.c:
1009 (modest_tny_account_new_from_server_account): Do not use the lsub and
1010 check-all hard-coded IMAP options when using POP.
1012 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-tny-account.c:
1015 (modest_tny_account_new_from_server_account):
1016 Use NULL for the secure-auth method for POP when Password auth has been
1017 specified by the user, as we already do for IMAP. "auth=Login" causes
1018 an error from camel or the server.
1020 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1022 * src/maemo/modest-account-settings-dialog.c:
1023 (create_page_account_details),
1024 (modest_account_settings_dialog_set_account_name):
1025 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1026 for the leave-on-server checkbox, rathr than just the checkbox, when
1027 the protocol is not POP.
1029 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1031 * src/widgets/modest-account-view.c:
1032 * src/widgets/modest-account-view.h:
1033 Added modest_account_view_select_account() which will be useful later
1034 to asynchronously re-select the edited account.
1036 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1038 * src/maemo/modest-account-settings-dialog.c:
1039 (modest_account_settings_dialog_set_account_name):
1040 Automatically choose the port numbers based on the secure authentication
1041 methods, if they have not been chosen before.
1042 This fixes projects.maemo.org bug NB#56273 .
1044 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1046 * src/maemo/modest-main-window-ui.h:
1047 * src/modest-ui-actions.c:
1048 * src/modest-ui-actions.h:
1049 Connect the Tools/SMTP Servers menu item to
1050 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1051 SMTP servers dialog, as in the UI specification and saves changes when it
1052 is closed. This fixed projects.maemo.org bug NB#56305 .
1054 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1056 * src/maemo/modest-connection-specific-smtp-window.c:
1057 (modest_connection_specific_smtp_window_init):
1058 Use gtk_window_set_default_size() to make this window big enough, so
1059 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1061 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1064 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1065 (modest_connection_specific_smtp_edit_window_init),
1066 Do not try to connect to a combobox signal before the combobox exists.
1067 This fixes the cras in projects.maemo.org bug NB#56288 .
1068 (modest_connection_specific_smtp_edit_window_get_settings):
1069 Remove the server_account_name parameter which was being checked for NULL
1070 though it was not used.
1072 * src/maemo/modest-connection-specific-smtp-window.c:
1073 (modest_connection_specific_smtp_window_fill_with_connections),
1074 (on_button_edit), (modest_connection_specific_smtp_window_init):
1075 Correct the number of treemodel columns to prevent a warning.
1076 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1077 libconic does not work.
1079 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account.c:
1082 (modest_tny_account_new_from_server_account):
1083 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1084 SMTP when "None" was chosen by the user. However, with my SMTP server that
1085 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1088 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1091 to explain the memory management issue with the ID in the ModestPair.
1093 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1094 (add_sending_page), (modest_account_assistant_finalize):
1095 * src/gnome/modest-gnome-global-settings-dialog.c:
1096 (create_updating_page), (create_composing_page):
1097 * src/gnome/modest-msg-edit-window.c: (get_transports),
1098 (init_window), (modest_msg_edit_window_finalize),
1099 (modest_msg_edit_window_get_msg_data):
1100 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1101 * src/gnome/modest-transport-widget.c:
1102 (modest_transport_widget_finalize), (smtp_configuration):
1103 * src/maemo/modest-maemo-global-settings-dialog.c:
1104 (create_updating_page), (create_composing_page):
1105 * src/maemo/modest-msg-edit-window.c: (get_transports),
1106 (init_window), (modest_msg_edit_window_finalize),
1107 (modest_msg_edit_window_get_msg_data),
1108 (modest_msg_edit_window_free_msg_data):
1109 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1110 (modest_store_widget_finalize):
1111 * src/maemo/modest-transport-widget.c:
1112 (modest_transport_widget_finalize), (smtp_configuration):
1113 * src/modest-main.c: (send_mail):
1114 * src/widgets/modest-combo-box.h:
1115 * src/widgets/modest-global-settings-dialog-priv.h:
1116 * src/widgets/modest-global-settings-dialog.c:
1117 (modest_global_settings_dialog_finalize):
1118 * src/widgets/modest-msg-edit-window.h:
1119 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1120 as long as the combo box, to prevent use of freed memory for the ID.
1122 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1125 get_accounts(), to make this clearer. Do not check for the enabled gconf
1126 key, because we do not use this for server accounts (at least, not yet).
1127 This allows us to send email again.
1129 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1131 * src/maemo/modest-platform.c:
1132 (on_modest_conf_update_interval_changed), (modest_platform_init):
1133 Only respond to this particular key change. All these strcmp()s cannot be
1136 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-maemo-global-settings-dialog.c:
1139 (current_connection): Prevent a crash in scratchbox when
1140 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1141 * src/maemo/modest-platform.c:
1142 (on_modest_conf_update_interval_changed), (modest_platform_init):
1143 Get the update interval from gconf and reset it when the gconf key changes.
1145 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-protocol-info.c:
1148 * src/modest-protocol-info.h: Adde enum-specific get functions,
1149 instead of using a ModestProtocolType enum parameter.
1151 * src/gnome/modest-account-assistant.c:
1152 * src/gnome/modest-store-widget.c:
1153 * src/gnome/modest-store-widget.h:
1154 * src/gnome/modest-transport-widget.c:
1155 * src/gnome/modest-transport-widget.h:
1156 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1157 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1158 * src/maemo/easysetup/modest-easysetup-wizard.c:
1159 * src/maemo/modest-account-settings-dialog.c:
1160 * src/maemo/modest-account-settings-dialog.h:
1161 * src/maemo/modest-store-widget.c:
1162 * src/maemo/modest-store-widget.h:
1163 * src/maemo/modest-transport-widget.c:
1164 * src/maemo/modest-transport-widget.h:
1165 * src/modest-account-mgr-helpers.c:
1166 * src/modest-account-mgr-helpers.h:
1167 * src/modest-account-mgr.c:
1168 * src/modest-account-mgr.h:
1169 * src/modest-tny-account.c:
1170 * src/modest-tny-folder.c:
1171 * src/widgets/modest-account-view.c:
1172 * src/widgets/modest-retrieve-combo-box.c:
1173 * src/widgets/modest-retrieve-combo-box.h:
1174 * src/widgets/modest-secureauth-combo-box.c:
1175 * src/widgets/modest-serversecurity-combo-box.c:
1176 * src/widgets/modest-serversecurity-combo-box.h:
1177 * tests/check_account-mgr.c:
1178 Use the specific functions, and use the re-renamed enum values for GNOME too.
1180 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-pair.h:
1183 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1184 so we can get the second based on the first.
1186 * src/maemo/modest-account-settings-dialog.h:
1187 * src/maemo/modest-account-settings-dialog.c:
1188 Added get_supported_secure_authentication_methods(), though it is mostly
1189 commented-out for now until the necessary API is committed to tinymail.
1190 (modest_account_settings_dialog_set_account_name),
1191 (save_configuration): Request the supported authentication methods from the
1192 server, so we can choose a working method.
1194 * src/modest-tny-account-store.h:
1195 * src/modest-tny-account-store.c:
1196 (modest_tny_account_store_get_session): Rename from
1197 tny_account_store_get_session().
1199 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-protocol-info.h: Split the ModestProtocol enum
1202 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1203 There was no need to have these unrelated values in one enum.
1205 * src/: many files: Adapted to changed enum. This makes the code a bit
1206 clearer, and the compiler could catch some errors.
1208 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1211 Show the detailed internal camel error message when an error happens
1212 during the configuration, so that our testers can give us more clues.
1213 For instance, in projects.maemo.org bug NB#56910 .
1215 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1217 * src/modest-tny-account.c:
1218 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1219 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1221 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1224 * src/maemo/modest-account-settings-dialog.c:
1225 (modest_account_settings_dialog_set_account_name),
1226 (save_configuration): For the incoming secure authentication checkbox,
1227 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1228 the UI specification. PLAIN does not seem to be supported for most IMAP
1229 servers anyway, and I am not sure what it would mean.
1230 However, we probably need to discover which of the secure-authentication
1231 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1232 * src/modest-account-mgr-helpers.c:
1233 (modest_account_mgr_get_server_account_data):
1235 * src/modest-tny-account.c:
1236 (modest_tny_account_new_from_server_account):
1237 Use tny_account_set_mech() to set secure-authentication methods,
1238 with some special-casing for IMAP, based on my observations of how
1241 * src/modest-account-mgr-helpers.h:
1242 * src/modest-account-mgr.c:
1243 * src/modest-defs.h: Comment that the URI is only used for local folders.
1245 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1248 parameter const, just to be neat.
1249 * src/modest-text-utils.c: (modest_text_utils_inline):
1250 End g_strconcat() with NULL, as its documentation says. This is almost
1251 certainly the cause of my crash at startup on the device. Interestingly,
1252 valgrind doesn't tell us about these errors.
1254 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1256 * scripts/build-packages: Added more precise comments about how to use
1257 this script, though I still get this error:
1258 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1259 error building tinymail
1261 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/modest-main-window.c: (on_account_update):
1264 Very slight cleanup, hoping to make it simpler to discover what causes
1265 a crash here sometimes.
1267 * src/modest-tny-account.c:
1268 (modest_tny_account_new_from_server_account): Set the port. Added
1269 comments about the options and a TODO comment because I need to find out
1270 how to specify the secure authentication method.
1272 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1274 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1275 changed CFlags paths form modest to libmodest
1277 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-account-mgr-helpers.c:
1280 (modest_account_mgr_get_server_account_data),
1281 (modest_account_mgr_free_server_account_data):
1282 * src/modest-account-mgr-helpers.h:
1283 * src/modest-account-mgr.c:
1284 (modest_account_mgr_add_server_account):
1285 * src/modest-defs.h:
1286 * src/modest-tny-account.c:
1287 (modest_tny_account_new_from_server_account):
1288 Determine the options for tny_camel_account_add_option() here,
1289 based on the settings, rather than storing them directly in gconf.
1291 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1293 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1294 Show a more friendly error dialog now that we expect (from the tinymail
1295 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1297 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-main-window.c: (on_account_update): Check that
1300 account_name is not NULL, to prevent a crash at startup that I am
1301 seeing on the N800. I do wonder why it is NULL.
1303 * src/maemo/easysetup/modest-easysetup-wizard.c:
1304 (create_page_user_details):
1305 * src/maemo/modest-account-settings-dialog.c:
1306 (create_page_user_details), (create_page_outgoing):
1307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1308 (modest_connection_specific_smtp_edit_window_init):
1309 * src/modest-ui-actions.c:
1310 (modest_ui_actions_on_password_requested):
1311 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1312 might do something useful with the on-screen keyboard.
1314 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1316 * src/maemo/modest-main-window.c: (on_account_update):
1317 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1318 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1320 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-tny-account-store.c: (on_account_changed):
1323 Correct the signature of this signal handler.
1325 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1328 Show a HildonNote instead of a GtkDialog for Maemo.
1330 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1332 * src/widgets/modest-account-view.h:
1333 * src/widgets/modest-account-view.c: (on_account_changed),
1334 (on_account_removed). Added a boolean flag, set/unset by
1335 modest_account_view_block_conf_updates(),
1336 modest_account_view_unblock_conf_updates() to prevent unnecessary
1337 updates, but this is not very useful because the gconf notifications are
1338 so delays (maybe only on Maemo Bora).
1339 So auto-updating is turned off, and these functions do an explicit
1340 update when necessary.
1341 However, something else is still doing too much work when adding/removing
1342 accounts, probably in another part of the application.
1344 * src/maemo/modest-account-view-window.c:
1345 (on_delete_button_clicked), (on_edit_button_clicked),
1346 (on_new_button_clicked): Use the new functions.
1348 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-account-mgr-helpers.c:
1351 (modest_account_mgr_set_first_account_as_default):
1352 Sort the list of names alphabetically-by-title, so we choose the first one
1354 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1355 alphabetically by the title.
1357 This fixes projects.maemo.org bug NB#56418 .
1359 * src/modest-account-mgr-priv.c:
1360 (_modest_account_mgr_account_from_key):
1361 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1362 avoid a valgrind error, and possible random behaviour.
1364 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1367 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1368 tinymail documentation to say that this can be expected.
1369 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1370 pretty, and should not happen, but I would prefer to know when it does.
1372 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1374 * configure.ac: When using the older hildon version, probably on Bora,
1375 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1377 * src/widgets/modest-attachment-view.c:
1378 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1381 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1383 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1384 Implemented the prototype. Can be tested with
1385 tests/dbus_api/test_open_message:
1387 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1389 * src/modest-tny-account-store.c:
1390 (modest_tny_account_store_instance_init), (get_password):
1391 * src/modest-ui-actions.c:
1392 (modest_ui_actions_on_password_requested):
1393 Do not store the password in gconf, because this function is called
1394 for non-remembered passwords. Actually use the cached (in the hash map)
1395 password instead of releasing it.
1396 The password will now not be remembered if it is asked via the protected
1397 password dialog, as per the UI spec.
1399 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-defs.h:
1402 * src/modest-account-mgr-helpers.h:
1403 * src/modest-account-mgr-helpers.c:
1404 Added modest_server_account_get_username_has_succeeded(),
1405 modest_server_account_set_username_has_succeeded().
1406 (modest_server_account_set_username),
1407 Reset the has-succeeded flag if the username changes.
1409 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1410 * src/maemo/modest-connection-specific-smtp-window.c:
1411 (modest_connection_specific_smtp_window_save_server_accounts):
1412 Use modest_server_account_set_username() instead of using
1413 modest_conf_set_string() directly, so that the has-succeeded flag is always
1416 * src/modest-ui-actions.c:
1417 (modest_ui_actions_on_password_requested): Dim the username entry if
1418 the username has ever worked, as per the UI spec.
1420 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-tny-account-store.c: (get_password):
1423 * src/modest-ui-actions.c:
1424 (modest_ui_actions_on_password_requested):
1425 Allow the username to be changed too, though there is more work to
1426 be done on exactly how this behaves.
1428 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1430 * src/modest-account-mgr-helpers.h:
1431 * src/modest-account-mgr-helpers.c:
1432 Added modest_account_mgr_get_display_name(),
1433 modest_server_account_get_username(),
1434 modest_server_account_set_username(),
1435 modest_server_account_set_password(),
1436 modest_server_account_get_hostname() functions so we do not need to
1437 use the conf API directly.
1439 * src/maemo/modest-main-window.c: (connect_signals):
1440 Actually connect ot the ModestAccountStore::request-password signal,
1441 so that we show the dialog when the password is requested by Tinymail,
1442 for isntance if it is empty.
1444 * src/modest-marshal.list:
1445 * src/modest-tny-account-store.c:
1446 (modest_tny_account_store_class_init), (get_password),
1447 (modest_tny_account_store_alert):
1448 * src/modest-tny-account-store.h:
1449 * src/modest-ui-actions.h:
1450 * src/modest-ui-actions.c:
1451 (modest_ui_actions_on_password_requested):
1452 Change the signal parameters, so it is obvious that we are providing
1453 the non human-readable server name, and receiving both the username
1454 and password, though changing of the username is not yet implemented.
1455 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1456 for the GNOME version.
1458 This should fix the projects.maemo.org bug NB#56209, though it does not
1459 work on Bora, because the gconf_client_get() for the password fails
1460 immediately after we save it with gconf_client_set().
1462 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1465 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1466 caused an undefined symbol error:
1467 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1469 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-tny-account-store.c:
1472 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1473 using a GError instead of a string message, so we can translate it in
1476 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/modest-address-book.c:
1479 (modest_address_book_check_names):
1480 * src/maemo/modest-msg-view-window.c:
1481 (modest_msg_view_window_clipboard_owner_change):
1482 * src/modest-init.c: (modest_init_init_ui):
1483 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1484 (update_folders_cb), (modest_mail_operation_update_account):
1485 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1486 (modest_ui_actions_on_msg_attachment_clicked),
1487 (modest_ui_actions_on_msg_recpt_activated):
1488 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1489 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1490 (modest_msg_view_search_next):
1491 * src/widgets/modest-recpt-editor.c:
1492 (modest_recpt_editor_on_button_release_event),
1493 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1494 g_message(). At this point we should only be seeing interesting errors on
1495 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1497 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1499 (modest_wizard_dialog_force_title_update):
1500 * src/maemo/easysetup/modest-wizard-dialog.h:
1501 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1502 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1503 can update the title when appropriate. Otherwise the title is wrong if the
1504 pages are added after adding the notebook to the dialog.
1505 This must be a problem in HildonWizardDialog too.
1506 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1508 * src/maemo/easysetup/modest-easysetup-wizard.c:
1509 (create_subsequent_customsetup_pages),
1510 (create_subsequent_easysetup_pages):
1511 Call modest_wizard_dialog_force_title_update() so that the title is
1512 correct even with GTK+ < 2.10.
1513 This fixes projects.maemo.org bug NB#56145 .
1515 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1517 * src/maemo/modest-platform.c:
1518 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1519 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1522 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1524 * src/widgets/modest-window.h:
1525 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1526 and modest_window_save_state(), which invokes it.
1528 * src/widgets/modest-window-mgr.h:
1529 * src/widgets/modest-window-mgr.c:
1530 Added modest_window_mgr_save_state_for_all_windows(), which calls
1531 the save_state vfunc on all registered windows, if implemented.
1533 * src/gnome/modest-msg-edit-window.c:
1534 * src/gnome/modest-msg-view-window.c:
1535 * src/maemo/modest-msg-edit-window.c:
1536 * src/maemo/modest-msg-view-window.c:
1537 * src/maemo/modest-main-window.c:
1538 Specify the existing save_settings functions as implementations of
1539 ModestWindow::save_state_func().
1541 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1542 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1543 enabling hibernation, for instance.
1545 We may need to do the same thing for restoring settings.
1548 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1550 * src/widgets/modest-window-mgr.c:
1551 * src/widgets/modest-window-mgr.h:
1552 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1553 modest_window_mgr_get_hibernation_is_prevented().
1555 * src/maemo/modest-main-window.c:
1556 (on_hildon_program_is_topmost_notify): Prevent hibernation
1557 (possible when the application goes to the background in the WM),
1558 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 (modest_easysetup_wizard_dialog_init):
1562 * src/maemo/modest-account-settings-dialog.c:
1563 (modest_account_settings_dialog_init):
1564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1565 (modest_connection_specific_smtp_edit_window_init):
1566 * src/maemo/modest-connection-specific-smtp-window.c:
1567 (modest_connection_specific_smtp_window_init):
1568 * src/maemo/modest-signature-editor-dialog.c:
1569 (modest_signature_editor_dialog_init):
1570 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1571 prevent hibernation while any of these account settings dialogs are open.
1573 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/Makefile.am:
1576 * src/maemo/modest-osso-state-saving.c:
1577 * src/maemo/modest-osso-state-saving.h: Added
1578 modest_osso_load_state() and modest_osso_save_state() though they do
1579 nothing now. They should iterate through all the open windows and load/save
1581 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1582 save state when closing.
1584 * src/maemo/modest-main-window.c:
1585 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1586 Add a notification handler for the HildonProgram::is-topmost property,
1587 so we can allow hibernation when the application goes into the background.
1588 But we still need to detect when the accounts setup windows are open so
1589 we can stop hibernation when they are open.
1590 To do this, I also added the main window the HildonProgram. This might have
1591 other side-effects/benefits, and should maybe be done for other windows.
1593 * src/maemo/modest-osso-autosave-callbacks.h:
1594 * src/maemo/modest-osso-autosave-callbacks.c:
1595 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1596 though it does not do anything yet, and we might never need this to do
1597 anything. For instance, we already save drafts.
1599 * src/maemo/modest-platform.c: (modest_platform_init):
1600 Specify the libosso auto-save callback.
1602 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1604 * src/maemo/modest-platform.c:
1605 (modest_platform_set_update_interval):
1606 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1607 aparently stays valid between application instances, so we can use this
1608 to remove and reset it later. According to a maemo-developers email from
1611 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1613 * configure.ac: Depend on libalarm for Maemo.
1615 * src/dbus_api/modest-dbus-api.h:
1616 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1617 (on_send_receive), (modest_dbus_req_handler):
1618 Handle a SEND_RECEIVE D-Bus method.
1620 * libmodest-dbus-client/libmodest-dbus-client.c:
1621 (libmodest_dbus_client_send_and_receive):
1622 * libmodest-dbus-client/libmodest-dbus-client.h:
1623 Add C convenience functions for calling the new D-Bus method.
1625 * src/modest-platform.h:
1626 * src/gnome/modest-platform.c:
1627 * src/maemo/modest-platform.c:
1628 Added modest_platform_set_update_interval(), which uses the
1629 alarmd API on Maemo.
1630 (modest_platform_init),
1631 Call modest_platform_set_update_interval(), using a hard-coded
1632 interval for now (until the global settings dialog is implemented),
1633 though I am not sure that this makes sense yet.
1635 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1637 * src/dbus_api/modest-dbus-callbacks.c:
1638 (modest_osso_cb_hw_state_handler):
1639 * src/dbus_api/modest-dbus-callbacks.h:
1640 * src/maemo/modest-platform.c: (modest_platform_init):
1641 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1642 in case this has some effect on the ability for Maemo to ping the
1645 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1648 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1649 warning. It is probably a logic error, but I need to fix the build.
1651 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1653 * src/modest-account-mgr.h:
1654 * src/modest-account-mgr.c:
1655 (modest_account_mgr_account_names): Add a gboolean enabled_only
1656 parameter, so we can get lists of onlt the enabled accounts.
1658 (modest_account_mgr_add_account),,
1659 (modest_account_mgr_account_with_display_name_exists):
1660 * src/maemo/modest-msg-edit-window.c: (get_transports):
1661 * src/modest-account-mgr-helpers.c:
1662 (modest_account_mgr_set_first_account_as_default):
1663 * src/modest-init.c: (init_default_account_maybe):
1664 * src/modest-tny-account-store.c: (get_accounts):
1665 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1666 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1667 * tests/check_account-mgr.c: (START_TEST):
1668 Provide the extra parameter, as appropriate.
1670 * src/widgets/modest-account-view.c: (update_account_view):
1671 Do not show disabled accounts (meaning that there is no way to
1672 enable/disable accounts in the UI (the feature is not in our UI
1673 specification), so we can use this internally only to mark unfinished
1674 or temporary account data.
1676 * src/maemo/easysetup/modest-easysetup-wizard.c:
1677 (create_account): Add boolean enable parameter, so we can specify FALSE
1678 to create the temporary account.
1679 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1680 (on_before_next): When finishing, when there is a temporary account, just
1682 Also, use a timeout to delay the showing of the dialog until gconf is likely
1683 to return correct information, due to a maemo gconf bug that is fixed in
1684 osso 1.1, but not yet in Bora.
1685 However, the dialog stays on screen after it is destroyed.
1687 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1688 for invalid data when cancelling. Use a hildon note instead of a dialog
1689 to complain about invalid data. Do not show the account-saved note if the
1690 account is disabled (a temporary account that will not really be saved for use
1693 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1695 * src/modest-account-mgr-helpers.h:
1696 * src/modest-account-mgr-helpers.c:
1697 Added modest_account_mgr_unset_default_account(),
1698 Added modest_account_mgr_set_first_account_as_default().
1700 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1701 If it was the default account, unset the default account name.
1703 * src/maemo/modest-account-view-window.c:
1704 (on_delete_button_clicked): If it was the default account,
1705 set the first remaining account as the default instead.
1707 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1708 a NULL account or a NULL default account, to prevent a crash. This should
1709 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1712 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1714 * src/widgets/modest-recpt-editor.c:
1715 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1716 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1717 TODO comment for this. This fixes the build.
1719 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1720 be the best place for it. This will in future update all auto-update accounts,
1721 rather than just the current/default account, when that gconf key exists.
1722 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1723 if there are no accounts, before calling do_send_receive().
1724 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1726 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1727 * src/maemo/modest-main-window-ui.h:
1728 * src/maemo/modest-main-window.c: (on_connection_changed),
1729 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1730 directly, becaue the signal handler does more.
1732 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-account-mgr-helpers.c:
1735 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1736 for the case that the account does not exist.
1738 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1739 (equivalent to the modest account name) rather than the tinymail account name
1740 (equivalent to the modest account title - human readable) to get the account data.
1741 Check for null account data to prevent the crash, and add a TODO comment saying that
1742 this needs fixing because it is using the server account name instead of the account name.
1744 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1746 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1747 * src/maemo/modest-account-settings-dialog.c: (show_error),
1749 Use hildon_note_new_information() for informative and error messages,
1750 which seems to be expected for Maemo applications (no documentation that I know of
1751 says this). I am surprised that there is no distinction between info and error
1754 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1756 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1757 it is easy to find where this is used.
1759 * src/maemo/easysetup/modest-easysetup-wizard.c:
1760 (create_page_welcome), (create_page_account_details),
1761 (create_page_user_details), (create_page_complete_easysetup),
1762 (create_page_custom_incoming), (create_page_custom_outgoing),
1763 (create_page_complete_custom):
1764 * src/maemo/modest-account-settings-dialog.c:
1765 (create_page_account_details), (create_page_user_details),
1766 (create_page_incoming), (create_page_outgoing):
1767 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1768 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1769 (modest_connection_specific_smtp_edit_window_init):
1770 * src/maemo/modest-connection-specific-smtp-window.c:
1771 (modest_connection_specific_smtp_window_init):
1772 * src/maemo/modest-signature-editor-dialog.c:
1773 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1774 and scrolling policy as per the Email Application Layout Guide, if I have
1777 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1779 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1780 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1781 which were empty, because these vfuncs have been removed from TnyAccountStore.
1782 This fixes the build.
1784 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1786 * src/maemo/modest-main-window.c:
1787 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1788 showing/hiding it. Added TODO because it probably should not be NULL.
1789 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1790 because unnecessary g_warnings() make degugging difficult.
1792 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1794 * src/maemo/modest-msg-edit-window.c:
1795 (modest_msg_edit_window_select_color),
1796 (modest_msg_edit_window_select_background_color): 2 const corrections and
1797 moving 2 #endifs before closing brackets, to fix the build.
1799 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1801 * src/maemo/easysetup/modest-easysetup-wizard.h:
1802 * src/maemo/easysetup/modest-easysetup-wizard.c:
1803 (modest_easysetup_wizard_dialog_finalize),
1804 (on_button_edit_advanced_settings), (create_page_complete_custom),
1805 (on_response), (create_account):
1806 Implement the Advanced Settings edit button, by saving the account information,
1807 for the Advanded Settings dialog to use directly from gconf, and removing it
1808 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1809 Bug #5533 in the projects.maemo.org bugzilla.
1811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1813 * src/maemo/modest-msg-view-window.c:
1814 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1815 when opening a message window.
1817 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1819 * src/maemo/easysetup/modest-easysetup-wizard.c:
1820 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1823 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1824 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1825 gconf settings. I probably added more checks than necessary, but that is safer.
1827 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1828 variable to fix the build, but this seems to be used when it is still NULL.
1830 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-platform.h:
1833 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1834 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1835 * src/modest-main.c: Implement this function so we can avoid using
1836 maemo-specific API from cross-platform code.
1838 * src/modest-tny-account-store.c:
1839 (get_smtp_specific_transport_account_for_open_connection):
1840 * src/modest-ui-actions.c: (check_for_connection),
1841 (modest_ui_actions_on_item_not_found):
1842 Use modest_platform_connect_and_wait() and put #idefs around other
1843 maemo-specific code, because only maemo currently has a way to
1844 identify connection names.
1846 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-tny-account-store.h:
1849 * src/modest-tny-account-store.c:
1850 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1851 the connection-specific SMTP server settings in the configuration.
1853 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1855 * src/maemo/modest-main-window.c: (on_connection_changed),
1857 * src/modest-main.c: (main), (start_ui), (send_mail):
1858 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1859 that is what is intended.
1861 * src/modest-ui-actions.c: (action_send), (action_receive),
1862 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1863 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1864 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1865 SMTP server is used when it is specified.
1867 (modest_ui_actions_on_send_receive):
1868 Check that a connection is open before proceeding.
1869 Receive and then send, instead of vice-versa, as per the specification.
1871 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1873 * src/modest-mail-operation.c:
1874 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1875 though I guess it should be something other than NULL.
1877 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/easysetup/modest-easysetup-wizard.c:
1880 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1881 combo twice, to avoid an g_warning and to make it visible again.
1882 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1883 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1884 (already intended) dereference when detaching, because we then recreate the menu.
1885 But I am not sure why the warning was happening, and it is possible that this is a memory
1888 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1890 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1891 and uri_parse_mailto() utility functions.
1892 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1894 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1896 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1898 * src/dbus_api/modest-dbus-api.h:
1899 * src/dbus_api/modest-dbus-callbacks.c:
1900 Use an idle callback to execute the modest code in the application's own thread.
1901 Remove the helloworld example method.
1902 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1903 parsed, and the open-message method is not implemented because this is not yet implemented in
1905 * libmodest-dbus-client/libmodest-dbus-client.c:
1906 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1907 (libmodest_dbus_client_open_message):
1908 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1910 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1911 body without crashing.
1913 * tests/dbus_api/Makefile.am:
1914 * tests/dbus_api/test_mail_to.c:
1915 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1917 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1919 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1920 Added file to fix the build. Sorry.
1922 * src/dbus_api/Makefile.am:
1923 * src/dbus_api/modest-dbus-api.h:
1924 * src/dbus_api/modest-dbus-callbacks.h:
1925 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1926 (modest_dbus_req_handler):
1927 Put constants in a separate header so it can be reused by the
1928 client library, without duplication
1930 * libmodest-dbus-client/Makefile.am:
1931 * libmodest-dbus-client/libmodest-dbus-client.c:
1932 (libmodest_dbus_client_call_helloworld),
1933 (libmodfest_dbus_client_send_mail),
1934 (libmodfest_dbus_client_mailto),
1935 (libmodfest_dbus_client_open_message):
1936 * libmodest-dbus-client/libmodest-dbus-client.h:
1937 (Partly) Implement a send_mail D-Bus method.
1939 * tests/dbus_api/Makefile.am:
1940 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1941 the send_email D-Bus method.
1943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1947 * libmodest-dbus-client/Makefile.am:
1948 * libmodest-dbus-client/libmodest-dbus-client.c:
1949 * libmodest-dbus-client/libmodest-dbus-client.h:
1950 * tests/dbus_api/Makefile.am:
1951 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1952 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1954 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1956 * src/maemo/easysetup/modest-easysetup-wizard.c:
1957 (create_page_account_details):
1958 * src/maemo/modest-account-settings-dialog.c:
1959 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1960 widgets, because this might not be the default in future versions of the Maemo GTK+.
1961 However, I can not not get capitalization to work even in a simple test case.
1963 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/easysetup/modest-easysetup-wizard.c:
1966 (create_page_custom_incoming), (create_page_custom_outgoing):
1967 * src/maemo/modest-account-settings-dialog.c:
1968 (create_page_account_details), (create_page_incoming),
1969 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1970 instead of using gtk_check_button_with_label(), so they are aligned like the other
1971 widgets, as per the UI spec.
1973 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/easysetup/modest-easysetup-wizard.c:
1976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1977 * src/widgets/modest-validating-entry.c:
1978 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1979 Modest prefix instead of an EasySetup prefix.
1981 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1983 * src/widgets/modest-validating-entry.h:
1984 * src/widgets/modest-validating-entry.c: (on_insert_text),
1985 Added easysetup_validating_entry_set_max_func(), used to set a callback
1986 to call when the max number of characters is reached. GtkEntry has a max-length
1987 already but is silent about it.
1989 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1990 (create_page_account_details), (create_page_user_details),
1992 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1993 (create_page_account_details), (create_page_user_details),
1994 (create_page_outgoing):
1995 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1996 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1997 the UI spec, when the user tries to enter more than the max number of characters.
1999 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c:
2002 (create_page_user_details), (create_page_custom_incoming),
2003 (create_page_custom_outgoing):
2004 * src/maemo/modest-account-settings-dialog.c:
2005 (create_page_user_details), (create_page_incoming),
2006 (create_page_outgoing):
2007 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2008 (modest_connection_specific_smtp_edit_window_init):
2009 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2010 not appropriate. Bad Maemo-specific defaults!.
2012 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2015 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2016 (modest_signature_editor_dialog_set_settings):
2017 Disable the label and textview when the checkbox is disabled, and use the
2018 specified (UI spec) default signature text.
2020 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2023 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2025 * src/modest-defs.h:
2026 * src/modest-account-mgr-helpers.h:
2027 * src/modest-account-mgr-helpers.c:
2028 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2030 * src/maemo/Makefile.am:
2031 * src/maemo/modest-signature-editor-dialog.c:
2032 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2035 * src/maemo/modest-account-settings-dialog.h:
2036 * src/maemo/modest-account-settings-dialog.c:
2037 (modest_account_settings_dialog_finalize), (on_button_signature),
2038 (save_configuration): Use the new dialog when the Edit button is pressed, and
2039 save the changes if necessary, as per the UI spec.
2041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/Makefile.am:
2044 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2045 based on maemo-develoers email from Dirk.
2047 * src/maemo/easysetup/modest-easysetup-wizard.c:
2048 (create_page_welcome), (create_page_account_details),
2049 (create_page_user_details), (create_page_complete_easysetup),
2050 (create_page_custom_incoming), (create_page_custom_outgoing),
2051 (create_page_complete_custom),
2052 (modest_easysetup_wizard_dialog_init):
2053 * src/maemo/modest-account-settings-dialog.c:
2054 (create_page_account_details), (create_page_user_details),
2055 (create_page_incoming), (create_page_outgoing),
2056 (modest_account_settings_dialog_init):
2057 * src/maemo/modest-connection-specific-smtp-window.c:
2058 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/easysetup/modest-easysetup-wizard.c:
2063 (create_page_account_details), (create_page_custom_outgoing),
2064 (create_page_complete_custom):
2065 * src/maemo/modest-account-settings-dialog.c:
2066 (create_page_user_details), (create_page_incoming),
2067 (create_page_outgoing):
2068 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2069 (modest_connection_specific_smtp_edit_window_init):
2070 Use the correct (UI spec) port min/max, and use horizontal separators,
2073 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2075 * src/maemo/easysetup/modest-easysetup-wizard.c:
2076 (set_default_custom_servernames):
2077 * src/maemo/modest-account-settings-dialog.c:
2078 (create_page_incoming), (on_combo_outgoing_security_changed),
2079 (on_combo_incoming_security_changed), (create_page_outgoing),
2080 (modest_account_settings_dialog_set_account_name),
2081 (save_configuration):
2082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2083 (on_combo_security_changed),
2084 (modest_connection_specific_smtp_edit_window_init),
2085 (modest_connection_specific_smtp_edit_window_set_connection),
2086 (modest_connection_specific_smtp_edit_window_get_settings):
2087 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2090 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/easysetup/modest-easysetup-wizard.c:
2094 (create_page_custom_outgoing), (create_page_complete_custom):
2095 * src/maemo/modest-account-settings-dialog.c:
2096 (create_page_user_details), (create_page_outgoing):
2097 * src/maemo/modest-account-view-window.c: (button_box_new):
2098 Use changed logical IDs as per the most recent UI spec:
2099 mcen_bd_emailsetup_edit -> mcen_bd_edit
2100 mcen_bd_emailsetup_delete -> mcen_bd_delete
2101 mcen_bd_emailsetup_close -> mcen_bd_close
2103 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2107 * src/dbus_api/Makefile.am:
2108 * src/dbus_api/modest-dbus-callbacks.c:
2109 * src/dbus_api/modest-dbus-callbacks.h:
2110 * src/maemo/modest-platform.c: (modest_platform_init):
2111 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2113 * tests/Makefile.am:
2114 * tests/dbus_api/Makefile.am:
2115 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2117 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/modest-account-settings-dialog.c:
2120 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2121 Removed unnecessary includes.
2123 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/easysetup/modest-easysetup-wizard.c:
2126 * src/maemo/modest-account-settings-dialog.c:
2127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2128 * src/widgets/Makefile.am:
2129 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2130 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2131 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2132 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2133 * src/widgets/modest-secureauth-combo-box.c:
2134 * src/widgets/modest-secureauth-combo-box.h:
2135 * src/widgets/modest-serversecurity-combo-box.c:
2136 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2137 made the GObject names more consistent with the rest of the Modest code.
2139 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2141 * src/maemo/easysetup/Makefile.am:
2142 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2143 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2144 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2145 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2146 * src/maemo/easysetup/modest-easysetup-wizard.c:
2147 * src/maemo/easysetup/modest-validating-entry.c:
2148 * src/maemo/easysetup/modest-validating-entry.h:
2149 * src/maemo/modest-account-settings-dialog.c:
2150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2151 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2152 widgets/ because they are used outside of easysetup too. After checking in,
2153 svn will allow me to rename them too.
2155 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2157 * src/gnome/modest-msg-edit-window.c:
2158 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2159 linker error, to fix the build on the GNOME platform.
2160 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2161 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2162 ifdefed out to avoid a warning.
2164 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2166 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2167 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2168 some alternative for GTK+ 2.6.
2170 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2174 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2175 specified for EmailAccountsDialog in UI spec.
2177 * src/maemo/easysetup/modest-easysetup-wizard.c:
2178 * src/maemo/easysetup/modest-easysetup-wizard.h:
2179 * src/maemo/modest-account-settings-dialog.c:
2180 * src/maemo/modest-account-settings-dialog.h:
2181 Reuse a member window widget for the connection-specific SMTP server accounts,
2182 so we can tell it to create/save the accounts only if we actually save changes.
2184 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2186 (modest_connection_specific_smtp_edit_window_get_settings):
2187 Return a struct instance for temporarily remembering the entered data.
2189 * src/maemo/modest-connection-specific-smtp-window.h:
2190 * src/maemo/modest-connection-specific-smtp-window.c:
2191 (modest_connection_specific_smtp_window_finalize),
2192 (modest_connection_specific_smtp_window_fill_with_connections),
2194 (modest_connection_specific_smtp_window_save_server_accounts),
2195 (update_model_server_names): Do not actually save data until asked,
2196 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2198 (on_selection_changed),
2199 (modest_connection_specific_smtp_window_init): Disable the edit
2200 button when nothing is selected.
2202 * src/modest-account-mgr-helpers.c:
2203 * src/modest-account-mgr-helpers.h:
2204 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2207 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2209 * src/modest-account-mgr-helpers.h:
2210 * src/modest-account-mgr-helpers.c:
2211 (modest_account_mgr_get_unused_account_name),
2212 (modest_account_mgr_get_unused_account_display_name): Added these
2213 utility functions, to avoid code duplication.
2215 * src/maemo/easysetup/modest-easysetup-wizard.c:
2216 (create_page_account_details), (create_account):
2217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2218 (on_combo_security_changed),
2219 (modest_connection_specific_smtp_edit_window_init),
2220 (modest_connection_specific_smtp_edit_window_save_settings):
2221 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2222 * src/maemo/modest-connection-specific-smtp-window.c:
2223 (modest_connection_specific_smtp_window_finalize),
2224 (modest_connection_specific_smtp_window_fill_with_connections),
2225 (on_button_edit), (modest_connection_specific_smtp_window_init):
2226 * src/maemo/modest-connection-specific-smtp-window.h:
2227 Implementing saving of connection-specific server accounts.
2229 But I need to refactor this so we can save the data for each
2230 possible connection-specific account and only actually create the server accounts
2231 when the easysetup finished, or the OK button is pressed on the account settings
2234 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2236 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2237 (on_combo_security_changed):
2238 (modest_connection_specific_smtp_edit_window_init):
2239 Auto-fill the port number as in the account settings.
2241 (modest_connection_specific_smtp_edit_window_set_connection):
2242 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2243 * src/maemo/modest-connection-specific-smtp-window.c:
2244 (fill_with_connections), (on_button_edit),
2245 (modest_connection_specific_smtp_window_init):
2246 Turn the edit window into a dialog to simplify the code, and
2247 set a WM hint as in a GtkDialog, because only a popup can be on top of
2248 another window in Maemo, and popups usually have no WM decoration.
2250 * src/modest-defs.h:
2251 * src/modest-account-mgr-helpers.c:
2252 (modest_account_mgr_set_connection_specific_smtp),
2253 (modest_account_mgr_remove_connection_specific_smtp),
2254 (modest_account_mgr_get_connection_specific_smtp):
2255 * src/modest-account-mgr-helpers.h: Some functions to write the
2256 connection-specific SMTP server information. Not yet used.
2259 * src/widgets/modest-folder-view.c: (text_cell_data):
2260 Fix a warning about an uninitialized variable.
2261 (on_configuration_key_changed): Put an #ifdef around the use
2262 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2264 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2266 * src/maemo/modest-account-settings-dialog.h:
2267 * src/maemo/modest-account-settings-dialog.c:
2268 Added connect_for_modified() utility function to mark the new modified boolean.
2270 (create_page_account_details), (create_page_user_details),
2271 (create_page_incoming), (create_page_outgoing), (on_response),
2272 (modest_account_settings_dialog_init),
2273 (modest_account_settings_dialog_set_account_name):
2274 Only warn about unsaved changes when there are actually unsaved changes.
2276 * src/modest-account-mgr-helpers.c:
2277 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2278 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2279 to get the data from there in future.
2281 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2283 * src/modest-defs.h:
2285 * src/modest-account-mgr-helpers.h:
2286 * src/modest-account-mgr-helpers.c:
2287 Store the security account setting in a single conf key instead of using
2288 the options list, so that the list is left for just the to-be-removed camel hack,
2289 and because gconf_client_set_list() is failing for some reason.
2291 * src/modest-account-mgr.c:
2292 (modest_account_mgr_add_server_account):
2293 * src/maemo/modest-account-settings-dialog.c:
2294 (modest_account_settings_dialog_set_account_name),
2295 (save_configuration): Use the renamed functions.
2298 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2300 * src/widgets/Makefile.am:
2301 * src/widgets/modest-limit-retrieve-combo-box.c:
2302 * src/widgets/modest-limit-retrieve-combo-box.h:
2303 * src/widgets/modest-retrieve-combo-box.c:
2304 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2305 the account settings dialog.
2307 * src/modest-defs.h:
2308 * src/modest-account-mgr-helpers.h:
2309 * src/modest-account-mgr-helpers.c:
2310 (modest_server_account_get_option_secure_auth),
2311 (modest_server_account_set_option_secure_auth):
2312 * src/modest-account-mgr.c:
2313 (modest_account_mgr_add_server_account):
2314 Use the existing AUTH_MECH conf key for the secure-auth setting,
2315 instead of putting it in the list options, because this was actually used already.
2317 * src/maemo/modest-account-settings-dialog.c:
2318 (create_page_account_details),
2319 (modest_account_settings_dialog_set_account_name),
2320 (save_configuration):
2321 * src/maemo/modest-account-settings-dialog.h:
2322 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2323 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2325 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2328 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2329 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2331 * src/modest-defs.h:
2332 * src/maemo/modest-account-settings-dialog.c:
2333 (create_page_incoming), (on_combo_outgoing_security_changed),
2334 (on_combo_incoming_security_changed), (create_page_outgoing),
2335 (modest_account_settings_dialog_set_account_name),
2336 (save_configuration): Load/Save the port number, and change it when the
2337 security combo changes, to suitable defaults.
2339 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2341 * src/modest-account-mgr.c:
2342 (modest_account_mgr_add_server_account): Set the security and secure-auth
2343 options, and add a comment saying that the other camel-specific options should be
2346 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2350 * src/modest-tny-account-store.c: (account_list_free),
2351 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2352 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2355 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2357 * src/modest-protocol-info.c:
2358 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2359 is required by our UI spec. Maybe something in our implementation will use this eventually.
2360 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2361 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2362 instead of the previous 0 placeholder.
2364 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2365 secure-auth settings.
2366 * src/modest-account-mgr-helpers.h:
2367 * src/modest-account-mgr-helpers.c:
2368 (modest_server_account_data_get_option_secure_auth),
2369 (modest_server_account_set_option_secure_auth),
2370 (modest_server_account_data_get_option_security),
2371 (modest_server_account_set_option_security): Added this API for getting and setting the security
2372 and secure-auth settings.
2374 * src/maemo/modest-account-settings-dialog.h:
2375 * src/maemo/modest-account-settings-dialog.c:
2376 (modest_account_settings_dialog_finalize), (check_data),
2377 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2378 about changing titles.
2379 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2380 (save_configuration): Save the security and secure-auth settings.
2382 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2383 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2385 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2387 * src/modest-defs.h:
2388 * src/modest-account-mgr.c:
2389 (modest_account_mgr_add_server_account):
2390 Added and used defines for the options key and value pair strings,
2391 that are used so far, though they do not seem to correspond to anything in our
2392 UI specs or ModestProtocol enum.
2394 * src/modest-account-mgr-helpers.h:
2395 * src/modest-account-mgr-helpers.c:
2396 (compare_option_strings_for_name),
2397 (modest_server_account_data_get_option_value),
2398 (modest_server_account_data_get_option_bool),
2399 (modest_account_mgr_get_server_account_option):
2400 Added helper functions for parsing the options GSList.
2402 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2404 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2405 display name is based on the supplied account name.
2406 * src/modest-account-mgr.c:
2407 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2408 with an inefficient, but good-enough, implementation.
2410 * src/maemo/easysetup/modest-easysetup-wizard.c:
2411 (create_page_account_details), (on_before_next), (create_account):
2412 Check for existing display names rather than (non-user-visible) account names, and just
2413 create and set a unique account name at the end.
2415 * src/maemo/modest-account-settings-dialog.c:
2416 (modest_account_settings_dialog_init),
2417 (modest_account_settings_dialog_set_account_name),
2418 (create_page_incoming): Show the display name, instead of the account name.
2419 (on_response): Do some (not all) extra checks, as in the UI spec.
2420 (save_configuration): Save the display name if it was changed.
2422 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2424 * po/en_GB.po: Added needed logical ID and translation.
2425 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2426 (init_view): Made the is-default column clicking work.
2428 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/easysetup/Makefile.am:
2432 * src/maemo/easysetup/modest-easysetup-wizard.c:
2433 (modest_easysetup_wizard_dialog_init):
2434 * src/maemo/easysetup/provider-data-test.keyfile:
2435 * src/maemo/easysetup/provider-data.keyfile:
2436 Moved the provider data file to the new modest-providers-data package and used it from there.
2438 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2440 * src/modest-local-folder-info.c:
2441 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2442 N_() was already used on the static strings, but this just marks it for translation without
2443 using the translation.
2445 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/modest-account-settings-dialog.c:
2448 (create_page_incoming),
2449 (modest_account_settings_dialog_set_account_name):
2450 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2451 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2452 I will do this if nobody else gets there first.
2454 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2456 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2457 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2458 save the security stuff.
2460 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2463 Set the email address and user fullname, which I now see must be
2466 * src/maemo/modest-account-settings-dialog.h:
2467 * src/maemo/modest-account-settings-dialog.c:
2469 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2470 leave-on-server and authentication.
2471 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2474 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2477 * src/maemo/modest-account-settings-dialog.c:
2478 * src/maemo/modest-account-settings-dialog.h:
2479 Most (but not all) of the widgets are now present as specified by the UI spec.
2480 No changes are yet saved, and some details are not properly shown yet.
2482 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2484 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2486 * src/maemo/Makefile.am:
2487 * src/maemo/modest-account-settings-dialog.c:
2488 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2489 an existing account. Doesn't do much yet.
2491 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2492 Open the accounts settings dialog when Edit is clicked.
2494 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2496 * src/maemo/easysetup/Makefile.am:
2497 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2499 * src/maemo/easysetup/modest-easysetup-wizard.c:
2500 (modest_easysetup_wizard_dialog_init):
2501 Try to get the source directory from the build system,
2502 instead of hard-coding "./" into the source code, when opening our local
2503 copies of the configuration files.
2504 But this still fails when opening the wizard from the Accounts window,
2505 maybe because the working directory seems to change at runtime.
2506 So the wizard will fail the second time unless you copy the files into their
2507 proper locations - see the stdout warnings for the paths.
2509 (create_page_account_details),(on_before_next):
2510 Check for existing non-server accounts instead of server accounts,
2511 so the default account name is useful again, and to prevent trying to
2514 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2515 Show the wizard when New is clicked.
2517 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2518 (init_view): Show the column headers, and show the columns that are
2519 specified in the UI specs. However, something in Maemo's GTK+ prevents
2520 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2521 change the default account. This is despite unsetting the special properties.
2523 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2525 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2526 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2527 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2528 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2529 to make that clearer.
2530 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2532 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2534 * src/maemo/modest-account-view-window.c:
2535 (modest_account_view_window_init),
2536 (modest_account_view_window_new):
2537 Use the same buttons as specified in the
2538 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2539 the existing widgets, which never had a chance of working.
2540 Put the ModestAccountView treeview in a scrolled window.
2541 Do not repeat the initialization in both _init() and _new().
2543 * src/widgets/modest-account-view.c: (update_account_view):
2544 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2545 this widget and window shows no accounts.
2547 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2549 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/easysetup/modest-easysetup-wizard.c:
2552 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2553 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2554 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2557 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2558 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2559 accounts exist yet, as in the UI spec.
2561 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2563 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2565 * src/maemo/Makefile.am:
2566 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2567 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2568 New window for editing connection-specific smtp details.
2569 Not fully implemented.
2571 * src/maemo/modest-connection-specific-smtp-window.c:
2572 (modest_connection_specific_smtp_window_finalize) :
2573 unref the tree model.
2574 (on_button_edit): Show the edit window.
2576 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2578 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2581 * src/maemo/Makefile.am:
2582 * src/maemo/modest-connection-specific-smtp-window.c:
2583 * src/maemo/modest-connection-specific-smtp-window.h:
2584 New window for showing the list of connections, for connection-specific
2585 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2586 * src/maemo/easysetup/modest-easysetup-wizard.c:
2587 (create_page_custom_outgoing): Show the new window when the button is clicked.
2589 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2592 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2593 * src/maemo/modest-msg-edit-window.c:
2594 (modest_msg_edit_window_insert_image):
2595 * src/modest-conf.c: (modest_conf_key_escape):
2596 * src/modest-mail-operation.c:
2597 (modest_mail_operation_send_new_mail):
2598 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2599 (modest_ui_actions_on_new_account):
2600 * src/widgets/modest-attachment-view.c: (update_filename_request):
2601 * src/widgets/modest-mail-header-view.c:
2602 Corrected warnings that were breaking the build, by commenting out unused variables,
2603 and a function, and by including a header.
2605 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2607 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2608 so we can #ifdef around platform-specific code when necessary.
2609 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2610 to allow this to build for the GNOME platform too.
2612 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2614 * src/maemo/easysetup/modest-easysetup-wizard.c:
2615 Added util_increment_name() and used it in create_page_account_details()
2616 to make sure that the default account name is always a new name.
2618 (modest_easysetup_wizard_dialog_init),
2619 (set_default_custom_servernames): Some minor memory management fixes.
2621 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2625 * src/modest-runtime.c: (init_i18n): Restored the translation
2626 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2627 are defined in config.h, and the translations are installed.
2629 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2630 is defined for translation.
2632 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2634 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 (modest_easysetup_wizard_dialog_init):
2638 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2639 Use realistic paths (though they should use $prefix generically) to the
2640 mcc_mapping and provider-data.keyfile files which might work when they
2641 are installed by the future version of the operator-wizard package,
2642 and then fallback to paths in our source code, with an explanatory
2645 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/Makefile.am:
2650 * src/maemo/easysetup/: Added files from the previously-exernal
2651 osso-modest-easysetup.
2652 * src/maemo/modest-main-window-ui.h:
2653 * src/modest-ui-actions.c:
2654 * src/modest-ui-actions.h:
2655 Added modest_ui_actions_on_new_account() as a signal handler for the
2656 New Account menu item. It shows the easysetup wizard.
2657 * po/en_GB.po: Added additional needed logical IDs and translations.
2659 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2660 Apparently ChangeLog is not used for some vague Nokia legal reasons.