1 2007-07-13 MMurray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
4 Ignore modest accounts whose server accounts don't exist in gconf.
5 This prevents us trying to create TnyAccount instances for those
6 server accounts when the server account has been removed from gconf,
7 but the parent modest account has not yet been removed from modest.
8 I don't know why this is only noticeable now. It was probably just
9 a harmeless g_warning() anyway.
11 2007-07-13 Murray Cumming <murrayc@murrayc.com>
13 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
14 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
16 2007-07-12 Armin Burgmeier <armin@openismus.com>
18 * src/maemo/modest-main-window.c: Make default account appear bold
19 in view, tools/send & receive and toolbar/send & receive SCM menus.
20 This fixes projects.maemo.org bug NB#59010.
22 2007-07-12 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
25 Add a short-cut, by checking if the folder store is an account.
26 This ensures that the Sort menu item and toolbar is dimmed for
27 the local-folders account root item, fixing
28 projects.maemo.org bug NB#62545.
30 2007-07-12 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-tny-account-store.c: (get_password):
33 Show the password dialog (via the signal) only in the mainloop, via
34 an idle handler that we wait for. This could theoretically prevent
35 hangs, though I worry that it could introduce some too.
37 2007-07-12 Murray Cumming <murrayc@murrayc.com>
39 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
40 * src/maemo/modest-platform.c:
41 (modest_platform_connect_and_wait):
42 Take a TnyAccount* parameter and try to set it to online
43 (a TnyCamel-only API), because tinymail sets accounts to offline
44 when the user cancels a password dialog, and doesn't ask again until
45 it has been set to online.
46 However, this is commented out because it causes a hang now.
48 (modest_platform_connect_and_wait_if_network_account):
49 * src/modest-mail-operation.c:
50 (modest_mail_operation_update_account):
51 * src/modest-platform.h:
52 * src/modest-ui-actions.c: (_modest_ui_actions_open),
53 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
55 2007-07-12 Armin Burgmeier <armin@openismus.com>
57 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
59 * src/modest-mail-operation.c:
60 * src/modest-ui-actions.c: Check for already existing folder before
61 querying the server, show error message from camel if the request
62 still fails. This fixes projects.maemo.org bug NB#58701.
64 2007-07-12 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-tny-account-store.h:
67 * src/modest-tny-account-store.c:
68 Added modest_tny_account_store_forget_password_in_memory(),
69 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
70 when creating a new account, so that new passwords will be used, instead of
71 us thinking that it's a second request as a result of a failed password again.
73 2007-07-12 Murray Cumming <murrayc@murrayc.com>
75 * src/dbus_api/modest-dbus-callbacks.c:
76 (on_idle_open_message): If the message is in drafts then open it
77 in an edit window instead of a view window. This fixes
78 projects.maemo.org bug NB#63005.
80 2007-07-12 Murray Cumming <murrayc@murrayc.com>
82 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
83 Avoided a harmless g_warning().
85 2007-07-12 Murray Cumming <murrayc@murrayc.com>
87 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
88 Pass the modest account name, not the TnyAccount display name to
89 modest_msg_view_window_new() so that the reply feature works,
90 fixing projects.maemo.org bug NB#62892.
92 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
93 (modest_msg_view_window_new_with_header_model):
94 * src/maemo/modest-msg-view-window.c:
95 (modest_msg_view_window_new_with_header_model),
96 (modest_msg_view_window_new):
97 * src/modest-ui-actions.c: (reply_forward):
98 * src/widgets/modest-msg-view-window.h:
99 * src/widgets/modest-window.c: (modest_window_set_active_account):
100 Rename an account parameter to modest_account_name to make this clearer.
102 2007-07-11 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-ui-actions.h:
105 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
106 modest_do_message_delete().
107 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
108 Call modest_do_message_delete(), hoping that this would cause messages
109 to be really deleted from search instead of just marked with strike through.
110 Does not seem to help.
112 2007-07-11 Armin Burgmeier <armin@openismus.com>
114 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
115 priv->reselect to FALSE prior to calling
116 modest_folder_view_select_first_inbox_or_local() to prevent endless
117 recursion and thus a crash on startup.
119 2007-07-11 Armin Burgmeier <armin@openismus.com>
121 * src/maemo/modest-account-settings-dialog.h: Include
122 <gtk/gtknotebook.h> to fix the build (at least for me).
124 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
125 Use "New FolderN" as default suggested name if "New folder" already
126 exists, with N being the first free number, though never exceed "New
127 folder99" in which case we just fall back to "New Folder" even though
128 it already exists. This fixes projects.maemo.org bug NB#58663.
130 2007-07-11 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
133 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
134 projects.maemo.org bug NB#62778.
136 2007-07-11 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
139 Ignore the wrong (for now) secure-smtp setting in the presets -
140 just default to requiring secure authentication for SMTP, because
143 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
145 * src/widgets/modest-folder-view.c: (filter_row)
146 Do not show drafts folder (see UI specs)
148 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
150 * src/modest-ui-actions.c:
151 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
152 place and also not necessary.
154 * src/widgets/modest-folder-view.c: (filter_row)
155 Guess folder type and hide Sent & Outbox if necessary.
156 Fixed project.maemo.org NB#57328
158 2007-07-11 Murray Cumming <murrayc@murrayc.com>
160 * src/modest-ui-actions.h:
161 * src/modest-ui-actions.c:
162 (modest_ui_actions_on_delete_message):
163 Move some code into a new
164 modest_ui_actions_refresh_message_window_after_delete()
165 function so we can use it from elsewhere.
167 * src/dbus_api/modest-dbus-callbacks.c:
168 (on_idle_delete_message), (on_delete_message): Used an idle
169 handler, as we do for the other D-Bus method handlers.
170 Call modest_ui_actions_refresh_message_window_after_delete()
171 if the deleted message was open in a window. This fixed
172 projects.maemo.org bug NB#62862.
174 2007-07-11 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-main.c: (main): Only show the UI at the start if
177 the showui command line option was given. For instance,
178 run-standalone src/modest showui
179 Otherwise, we wait for the top_application D-Bus method to
180 be sent by hildon-desktop when the application is selected
182 This allows us to run without a UI when osso-global-search
183 uses our D-Bus methods.
185 2007-07-11 Murray Cumming <murrayc@murrayc.com>
187 * src/dbus_api/modest-dbus-api.h: Added a define for a
188 top-application D-Bus method.
189 * src/dbus_api/modest-dbus-callbacks.c:
190 (on_top_application),
191 (modest_dbus_req_handler): Handle the top-application D-Bus
192 method, which might be an undocumented D-Bus signal sent by
193 hildon-desktop when it starts the application from the menu.
194 But I am not sure and I need to test it on the device, because
195 my scratchbox does not have the application in the menu now.
196 This method shows the main window, so that it can be invisible
197 when started, for instance, just for email searching from
200 * src/maemo/modest-main-window.c: (restore_settings),
201 (modest_main_window_new): Do not show the window immediately
202 upon creation. We show it later.
203 * src/modest-widget-memory.c: (save_settings_paned):
204 Try (unsuccessfully) to avoid saving the paned position when
205 it is not even visible.
206 (restore_settings_paned): Do not allow a silly paned position.
207 This seems necessary when not showing the window at first.
209 * tests/dbus_api/Makefile.am:
210 * tests/dbus_api/test_top_application.c: (main): Test for the
213 2007-07-10 Murray Cumming <murrayc@murrayc.com>
215 * src/modest-ui-dimming-rules.c:
216 (modest_ui_dimming_rules_on_new_msg),
217 (modest_ui_dimming_rules_on_reply_msg),
218 (modest_ui_dimming_rules_on_delete_msg),
219 (modest_ui_dimming_rules_on_details),
220 (modest_ui_dimming_rules_on_view_window_move_to),
221 (modest_ui_dimming_rules_on_view_previous),
222 (modest_ui_dimming_rules_on_view_next),
223 (_invalid_folder_for_purge): Added checks before
224 casting the window. This looks like an actual
225 logic error in _invalid_folder_for_purge(), because it
226 tries to use a ModestMainWindow as a message window.
228 2007-07-10 Murray Cumming <murrayc@murrayc.com>
230 * src/maemo/modest-account-settings-dialog.c:
231 (show_error): Use the same implementation as in
232 modest-easysetup-wizard.c:
233 (on_entry_invalid_character): The logical ID contains a %s.
234 Guessed what it should be.
235 (on_entry_max), (check_data), (on_response): Adapt to
236 changed show_error().
237 (create_page_account_details): Really call
238 modest_validating_entry_set_func() on the correct widgets.
239 * src/maemo/easysetup/modest-easysetup-wizard.c:
240 (on_entry_invalid_character): Fix the logical ID here too.
241 (create_page_account_details),
242 (create_page_user_details):
244 modest_validating_entry_set_func() on the correct widgets.
246 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
247 Do not try to use the account if it is NULL.
249 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
251 * src/modest-ui-actions.c: (create_move_to_dialog),
252 (modest_ui_actions_on_main_window_move_to),
253 (modest_ui_actions_on_msg_view_window_move_to):
254 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
255 (filter_row), (modest_folder_view_show_non_move_folders):
256 * src/widgets/modest-folder-view.h:
258 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
259 the Sent folder yet as it does not report the correct folder type.
261 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
263 * src/maemo/modest-msg-edit-window.c: (init_window):
266 2007-07-10 Murray Cumming <murrayc@murrayc.com>
268 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
269 Take a parent widget instead of a parent window, and
270 implement this with hildon_banner_show_information() instead.
271 Non-Maemo builds can just ifdef that there.
272 This fixed projects.maemo.org bug NB#62766.
274 (on_entry_invalid_character): Use show_error() again instead
275 of using hildon directly, and use the _CS() macro to use the correct
277 (create_account), (check_for_supported_auth_methods), (on_entry_max):
278 Pass a widget instead od a window to show_error().
280 2007-07-10 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
283 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
284 This allows us to show the server name in the error message, fixing
285 projects.maemo.org bug NB#62904.
286 Also, use the appropriate logical ID message for the account protocol.
288 2007-07-10 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-tny-account-store.c: (on_idle_wrong_password):
291 A compilation fix, though the build wasn't broken for me.
293 2007-07-09 Murray Cumming <murrayc@murrayc.com>
295 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
296 Do not try to unref a NULL folder store, to avoid a runtime warning.
297 This seems to happen sometimes when changing accounts settings.
299 2007-07-09 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-tny-account-store.c:
302 (modest_tny_account_store_instance_init),
303 (modest_tny_account_store_finalize),
304 (on_account_settings_hide), (on_idle_wrong_password):
305 Use a GHashTable to ensure that we only show one account settings
306 dialog per modest account. This avoids us having a dialog open for
307 both the store and transport accounts, or due to repeated get_password()
308 calls that shouldn't happen anyway.
310 2007-07-09 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-maemo-utils.c: (on_hide),
313 (modest_maemo_show_dialog_and_forget): Handle the response, because
314 the window is not even hidden by default.
316 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
317 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
318 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
319 which seems to prevent some modality problems.
321 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
322 Ignore user cancellation errors.
324 * src/modest-account-mgr-helpers.h:
325 * src/modest-account-mgr-helpers.c:
326 Added modest_server_account_get_password() and
327 modest_server_account_get_has_password() to avoid direct use of
330 * src/maemo/modest-account-settings-dialog.h:
331 * src/maemo/modest-account-settings-dialog.c:
332 (modest_account_settings_dialog_init): Store the notebook so we can
334 Added modest_account_settings_dialog_switch_to_user_info().
336 * src/modest-tny-account-store.c:
337 (get_password): When the password in the account settings is wrong (we think),
338 show the relevant page of the account settings dialog, in the mainloop.
339 However, we currently get many of these at once because cancel does not
341 (forget_password): Do not forget the password
342 from the account settings, because this causes side-effects when
343 tinymail seems to call it at strange time, maybe because of how we
344 are cancelling get_password().
345 (modest_tny_account_store_alert): Ignore user cancellations.
347 2007-07-09 Murray Cumming <murrayc@murrayc.com>
349 * src/maemo/modest-maemo-utils.h:
350 * src/maemo/modest-maemo-utils.c:
351 Added modest_maemo_show_information_note_and_forget() for use instead of
352 gtk_dialog_run() when the response is not needed, to avoid an extra
353 mainloop which could cause a hang.
355 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
356 Use the logical IDs for the error message, though they are not
357 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
358 because gtk_dialog_run() caused a hang here (the window did not close).
359 This fixes projects.maemo.org bug NB#62646.
361 2007-07-09 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-account-mgr-helpers.h:
364 * src/modest-account-mgr-helpers.c:
365 Added modest_account_mgr_get_store_protocol().
367 * src/maemo/modest-account-view-window.c:
368 (on_delete_button_clicked): Show different warning text depending on
369 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
370 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
373 2007-07-09 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-msg-edit-window.c:
376 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
377 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
379 2007-07-07 Armin Burgmeier <armin@openismus.com>
381 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
382 ckdg_ib_maximum_characters_reached from correct package.
384 * src/modest-ui-actions.c: Show an error message when a folder could
385 not be created. Tinymail does not give us specific error codes about
386 what has gone wrong, so we assume that a folder with that name
387 already exists, though there might be other reasons.
389 2007-07-06 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
392 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
393 give a more exact error message that can be partly translated.
395 2007-07-05 Murray Cumming <murrayc@murrayc.com>
397 * src/maemo/modest-address-book.c:
398 (select_email_addrs_for_contact): Specify a default window size for the
399 select-email-address dialog, so that it is probably big enough for the
400 title. This should fix projects.maemo.org bug NB#62277.
402 2007-07-05 Murray Cumming <murrayc@murrayc.com>
404 * src/maemo/easysetup/modest-easysetup-wizard.c:
405 (create_page_complete_easysetup): Use
406 gtk_widget_set_size() request to ensure that the text wraps
409 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
411 * src/maemo/easysetup/modest-easysetup-wizard.c:
412 (on_entry_invalid_character), (create_page_account_details),
413 (create_page_user_details):
414 Use new API of ModestValidatingEntry. But for some reason the banner is
415 not shown. I will have to investigate that further.
417 * src/widgets/modest-validating-entry.c: (on_insert_text),
418 (modest_validating_entry_set_func):
419 * src/widgets/modest-validating-entry.h:
420 Added a new callback function to be able to react to prevented
421 characters whitespaces to e.g show a banner.
423 2007-07-05 Armin Burgmeier <armin@openismus.com>
425 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
426 notification of HildonNumberEditor instead of remembering the port
427 number. Thanks to Johannes for pointing this out.
429 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
431 * src/maemo/easysetup/modest-easysetup-wizard.c:
432 Check if there are any user changes before showing a confirmation
433 dialog (projects.maemo.org NB#60946)
435 2007-07-05 Armin Burgmeier <armin@openismus.com>
437 * src/maemo/modest-account-settings-dialog.c: Remember custom port
438 number at the beginning of the dialog and set the modified flag at the
439 end if the port number has changed. This is necessary because
440 HildonNumberEditor does not support notification when the value has
443 2007-07-05 Murray Cumming <murrayc@murrayc.com>
445 * src/modest-ui-actions.c:
446 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
447 a connection before asking anything else. Correct the check for the destination
448 folder so that it succeeds when online.
449 This fixed projects.maemo.org bug NB#61645.
451 2007-07-05 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
454 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
455 to fix projects.maemo.org bug NB#62439.
457 2007-07-05 Murray Cumming <murrayc@murrayc.com>
459 * src/modest-tny-account.c: (on_connection_status_changed):
460 Really do not use tny_device_force_offline() here. See the previous comment.
462 2007-07-04 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-tny-account.c: (on_connection_status_changed):
465 Do not use tny_device_force_offline() when tinymail says that something
466 went wrong with the connection. It seems to report this unnecessarily.
468 2007-07-04 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/modest-connection-specific-smtp-window.c:
471 (modest_connection_specific_smtp_window_init):
472 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
473 does not seem to have any effect in osso 1.1 (though it works in
474 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
476 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
478 * src/maemo/modest-connection-specific-smtp-window.c:
479 Fix UI specification problems with projects.meamo.org NB#60479
481 2007-07-04 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
484 clue when this has failed, because the error dialog is not always shown
485 (at least in earlier version).
487 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
488 GError message, because the generic error dialog is not helpful.
490 'This message is not currently available (can't let a new connection go online)'
491 when trying to open an IMAP message.
493 (_modest_ui_actions_open): Offer a connection when some messages would
494 have to be downloaded and we are offline.
496 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
498 * src/widgets/modest-folder-view.c:
499 Don't check for MERGE type anymore as we use the correct type
501 NOTE: For the last two changes you need to update your tinymail copy
502 because of API changes!
504 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
506 * src/modest-tny-local-folders-account.c:
507 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
508 (see projects.maemo.org NB#61580)
510 2007-07-04 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account.c: (on_connection_status_changed):
513 Commented out the call to modest_platform_connect_and_wait() because this
514 seems to always hang, and I would like to know if this is the only thing
515 that causes a hang when showing the connection dialog.
516 It is not very useful anyway.
518 2007-07-04 Murray Cumming <murrayc@murrayc.com>
520 * src/maemo/modest-msg-view-window.c:
521 (modest_msg_view_window_select_next_message):
523 * src/modest-platform.h:
524 * src/maemo/modest-platform.c:
525 Added modest_platform_connect_and_wait(), which calls
526 tny_maemo_conic_device_connect() always in the main thread, by calling it
527 in an idle handler and waiting for the idle handler to run. It should be
528 in the main thread because it uses GTK+ UI code. It just returns TRUE
529 if the device is already online.
531 There is some nasty code to ensure that subsequent calls to
532 modest_platform_connect_and_wait() just wait for the first one to finish,
533 by checking repeatedly in another idle handler. This is necessary,
534 because other threads (or even the main thread, via another idle handler)
535 can call modest_platform_connect_and_wait() while
536 modest_platform_connect_and_wait() is running.
538 (modest_platform_connect_and_wait_if_network_account),
539 (modest_platform_connect_and_wait_if_network_folderstore):
540 Convenience functions that calls modest_platform_connect_and_wait() if
541 the account or folder might want network access.
543 * src/modest-mail-operation.c:
544 (modest_mail_operation_update_account):
545 * src/modest-ui-actions.c: (download_uncached_messages),
546 (modest_ui_actions_on_rename_folder), (delete_folder),
547 (modest_ui_actions_on_main_window_move_to),
548 (modest_ui_actions_on_msg_view_window_move_to):
549 * src/widgets/modest-folder-view.c:
550 (drag_and_drop_from_folder_view):
551 Offer a connection if we are offline.
553 * src/modest-tny-account.c: (on_connection_status_changed):
554 Document this as only handling errors during network operations in progress,
555 and replace the idle code with a simple call to
556 modest_platform_connect_and_wait(), which does this instead.
558 2007-07-03 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-tny-account.c:
561 (modest_tny_account_get_special_folder): (util_on_idle),
562 Handle the GError so we can see when tny_folder_store_get_folders()
563 fails, as it currently does while something else is connecting.
565 Added util_run_in_main_thread_and_wait()
566 which uses an idlen handler and mainloop to ensure that the function
567 is called in the main thread.
568 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
569 to make sure that we call attempt the connection in the mainloop only,
570 which might solve some hangs.
572 2007-07-03 Murray Cumming <murrayc@murrayc.com>
574 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
575 be found by their display name. This is never useful.
576 * src/modest-tny-account-store.c: (on_account_removed): Find the account
577 by its ID, instead of trying to use its ID as its display name.
579 * src/modest-tny-account-store.h:
580 * src/modest-tny-account.c:
581 (modest_tny_account_get_special_folder): Add a g_warning() when
582 tny_folder_store_get_folders() returns an empty list for the maildir.
584 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
585 Add a g_warning() when this returns NULL, because that it not allowed
588 2007-07-02 Armin Burgmeier <armin@openismus.com>
590 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
591 note when trying to cancel the wizard. This fixes projects.maemo.org
594 2007-07-02 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-tny-account.h:
597 * src/modest-tny-account.c:
598 (modest_tny_account_new_from_server_account),
599 (modest_tny_account_new_from_server_account_name),
600 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
601 because this must now be set before setting the proto. This is usd in
602 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
603 warning in camel_session_get_service() caused by
604 tny_camel_transport_account_prepare().
606 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
609 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
613 (modest_connection_specific_smtp_edit_window_init):
615 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
618 2007-06-29 Murray Cumming <murrayc@murrayc.com>
620 * src/modest-tny-account.c:
621 (modest_tny_account_new_from_server_account):
622 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
623 now uses to request a connection when it needs one, and which it uses
624 to tell us that something is wrong with the connection, so we can force
625 the accounts offline to prevent further problems.
628 * src/modest-init.c: (init_default_settings):
629 * src/modest-mail-operation.c:
630 (modest_mail_operation_update_account):
631 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
632 This should not be necessary anymore. Do not set the conf key that
633 determined this (it was always TRUE and not set anywhere else).
635 * src/modest-ui-actions.h: Remove unused and unimplemented
636 modest_ui_actions_on_online_toggle_toggled().
638 2007-06-29 Murray Cumming <murrayc@murrayc.com
640 * src/maemo/modest-main-window.c: (connect_signals):
641 Don't connect to delete_event twice. Maybe this was harmless.
643 2007-06-29 Murray Cumming <murrayc@murrayc.com
645 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
646 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
647 Debug output to give some more clue when a folder move is not allowed.
649 2007-06-28 Murray Cumming <murrayc@murrayc.com
651 * src/modest-tny-account.c: (on_modest_file_system_info),
652 (modest_tny_account_get_mmc_account_name):
653 Always call the callback, without checking whether the name has changed.
654 * src/widgets/modest-folder-view.c: (strings_are_equal),
655 (on_model_foreach_set_name), (on_get_mmc_account_name),
656 (text_cell_data): Compare the name here, and use the name from
657 the account rather than from the
658 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
659 if the name was changed after the account was added to the model.
660 That's a tinymail bug but not one that I want to fix now.
662 This finally fixes projects.maemo.org bug NB#59301.
664 2007-06-27 Armin Burgmeier <armin@openismus.com>
666 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
669 2007-06-27 Murray Cumming <murrayc@murrayc.com
671 * src/modest-tny-account.h:
672 * src/modest-tny-account.c:
673 Added modest_tny_account_get_mmc_account_name(), to set the memory
674 card name asynchronously for the given account and then notify.
675 (modest_tny_account_new_for_local_folders): Use this new function instead
676 of using hildon_file_system_info_async_new() directly.
678 * src/widgets/modest-folder-view.c: (text_cell_data):
679 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
680 gtk_tree_model_row_changed() when it is available.
682 This should fix projects.maemo.org bug NB#59301.
684 2007-06-27 Murray Cumming <murrayc@murrayc.com
686 * src/modest-mail-operation.c: (update_account_thread),
687 (get_msgs_full_thread): Fix typo failures in the revert
690 2007-06-27 Murray Cumming <murrayc@murrayc.com
692 * src/maemo/modest-maemo-global-settings-dialog.c:
693 (idle_select_default_focus):
694 * src/modest-mail-operation.c: (idle_notify_progress),
695 (idle_notify_progress_once), (set_last_updated_idle),
696 (update_account_thread), (get_msgs_full_thread):
697 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
698 * src/widgets/modest-header-view.c:
699 (idle_notify_headers_count_changed_destroy),
700 (idle_notify_headers_count_changed):
701 Reverted the additions of gdk_threads_enter/leave(), in case this
702 helps with a startup hang on the device.
704 2007-06-26 Armin Burgmeier <armin@openismus.com>
706 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
707 for supported secure authentication methods from server by
708 gtk_dialog_run(), saving CPU time and a potential race condition.
710 2007-06-26 Armin Burgmeier <armin@openismus.com>
712 * src/maemo/modest-maemo-utils.h:
713 * src/maemo/modest-maemo-utils.c: Added a
714 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
715 only error code to tell the calling code when the user canceled the
718 * src/maemo/modest-account-settings-dialog.h:
719 * src/maemo/modest-account-settings-dialog.c:
720 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
721 message if the retrieval of secure authentication methods was canceled
722 by the user. Perform the check before saving anything to configuration
723 to not end up with half-committed configuration changes, do not show
724 a "Saving to configuration failed" note when authentication methods
725 could not be retrieved.
727 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
730 2007-06-26 Murray Cumming <murrayc@murrayc.com>
732 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
733 Only return the first level of folders under accounts, because the
734 osso-global-search UI spec doesn't want the rest.
735 This fixed projects.maemo.org bug NB#61811.
737 2007-06-26 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-tny-account-store.c:
740 * src/modest-tny-account-store.h:
741 Added modest_tny_account_is_memory_card_account().
742 * src/maemo/modest-main-window.c: (create_details_widget):
743 Show the same information items for the memory card as we show for the
744 local-folders, to fix projects.maemo.org bug NB#59307.
746 2007-06-26 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account-store.c: (get_password):
749 Added some checks for NULL to maybe prevent crashes, though I think
750 it was Philip's last commit that actually prevented the crash here
751 when creating a first new account.
752 But the new account is still not usable (no messages are shown)
753 until a restart of the application.
755 2007-06-26 Murray Cumming <murrayc@murrayc.com>
757 * src/maemo/modest-maemo-global-settings-dialog.c:
758 (idle_select_default_focus):
759 * src/modest-mail-operation.c: (idle_notify_progress),
760 (idle_notify_progress_once), (idle_notify_update_account_queue),
761 (set_last_updated_idle), (update_account_thread),
762 (notify_get_msgs_full), (get_msgs_full_destroyer),
763 (get_msgs_full_thread):
764 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
765 * src/widgets/modest-header-view.c:
766 (idle_notify_headers_count_changed_destroy),
767 (idle_notify_headers_count_changed):
768 Use gdk_threads_enter() and gdk_threads_enter_leave() in
769 all idle handlers, because some other thread could be blocking
770 the GDK lock, so that it can do GUI stuff.
772 2007-06-26 Murray Cumming <murrayc@murrayc.com>
774 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
775 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
776 (on_idle_send_receive), (on_idle_open_default_inbox):
777 * src/maemo/modest-msg-edit-window.c:
778 (modest_msg_edit_window_attach_file_noninteractive):
779 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
780 to prevent a hang. I don't quite understand why these are necessary,
781 beause we should already be in the main loop. I guess something outside
782 of the main loop is taking the lock.
784 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
785 we are really using URIs, and use files that are more likely to exist.
787 2007-06-26 Murray Cumming <murrayc@murrayc.com>
789 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
790 necessary because configure.ac now defines different variables.
792 2007-06-26 Murray Cumming <murrayc@murrayc.com>
794 * libmodest-dbus-client/libmodest-dbus-client.c:
795 * libmodest-dbus-client/libmodest-dbus-client.h:
796 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
797 libmodest_dbus_client_compose_mail() is what things actually use.
799 * src/dbus_api/modest-dbus-api.h:
800 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
801 * tests/dbus_api/Makefile.am:
802 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
805 2007-06-26 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-init.c: (modest_init_local_folders):
808 For memory-card (or other non local-folders) maildir accounts,
809 always create an Archive folder, so that there is somewhere to put
810 messages. This should be less confusing, because the user does not need
811 to guess that the need to create a folder.
813 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
815 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
816 Fixed icon size by using (50, 50) which is the same as defined by
819 2007-06-25 Armin Burgmeier <armin@openismus.com>
821 * src/widgets/modest-window-mgr.c:
823 * configure.ac: Correctly recognize hildon-notify presence and fixed
824 the build without it being installed.
826 2007-06-25 Murray Cumming <murrayc@murrayc.com>
828 * libmodest-dbus-client/libmodest-dbus-client.c:
829 (libmodest_dbus_client_search): Fix the build. Sorry.
830 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
831 (reply_forward_cb): Initialize variables to fix the build.
833 * src/modest-tny-account-store.c:
834 (modest_tny_account_store_get_tny_account_by): Fix the account URI
835 comparison (a silly typo) so that email search results can be opened
836 when there are more than one account.
838 2007-06-25 Murray Cumming <murrayc@murrayc.com>
840 * libmodest-dbus-client/libmodest-dbus-client.c:
841 (libmodest_dbus_client_search),
842 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
843 instead of 1 second, because the search gets folders and messages from
844 the server, which can take a long time. When it times out,
845 osso-global-search will report no results.
847 We need to specify whether we should search only cached information
848 (maybe with a user preference), and the osso-email-search-plugin
849 API should really be improved to allow that option, and to allow results
850 to be delivered asynchronously in batches.
852 2007-06-25 Murray Cumming <murrayc@murrayc.com>
854 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
855 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
856 GTK_ICON_SIZE_DIALOG is probably the wrong size.
858 2007-06-25 Murray Cumming <murrayc@murrayc.com>
860 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
861 that is an empty string. D-Bus seems to give us these instead of NULL.
863 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
865 * src/dbus_api/modest-dbus-callbacks.c:
866 * src/maemo/easysetup/modest-easysetup-wizard.h:
867 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
869 (modest_connection_specific_smtp_edit_window_init):
870 * src/maemo/modest-maemo-global-settings-dialog.c:
872 * src/maemo/modest-maemo-utils.c:
873 (modest_maemo_utils_setup_images_filechooser):
874 * src/maemo/modest-main-window.c: (create_details_widget):
875 * src/maemo/modest-msg-edit-window.c:
876 (modest_msg_edit_window_attach_file_noninteractive),
877 (modest_msg_edit_window_color_button_change),
878 (modest_msg_edit_window_set_zoom):
879 * src/modest-mail-operation.c: (update_account_thread):
880 * src/modest-tny-account-store.c:
881 * src/modest-tny-account.c:
882 * src/widgets/modest-global-settings-dialog.c:
883 * src/widgets/modest-window.h:
887 2007-06-25 Murray Cumming <murrayc@murrayc.com>
889 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
890 * src/modest-search.c: (modest_search_folder),
891 (modest_search_all_accounts): Actually search only in the specified folder,
892 doing a simple match on the folder ID.
893 * src/modest-search.h: Added a folder field to the ModestSearch struct,
894 and added some documentation.
896 2007-06-22 Armin Burgmeier <armin@openismus.com>
898 * src/maemo/modest-maemo-utils.h:
899 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
900 modest_maemo_utils_get_supported_secure_authentication_methods.
902 * src/maemo/easysetup/modest-easysetup-wizard.c:
903 * src/maemo/modest-account-settings-dialog.c: Show correct error if
904 one occured, not just "Server does not support secure authentication".
906 2007-06-22 Murray Cumming <murrayc@murrayc.com>
908 * src/modest-tny-account-store.c: (get_password):
909 Restored the call to tny_account_set_user() because Philip seems to have
910 stopped this from crashing (by not using the freed string). It still does
911 not work, but now we can test it.
913 2007-06-22 Murray Cumming <murrayc@murrayc.com>
915 * src/maemo/modest-msg-edit-window.c: (init_window):
916 Comment out use of an uninitialzed GtkScrolledWindow variable,
917 to fix the build and stop a crash. Yet again.
919 2007-06-22 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-tny-account-store.c: (get_password):
922 Remove the call to tny_account_set_user() because this actually crashes.
923 As mentioned in the last commit, it is known to not work anyway.
925 2007-06-22 Murray Cumming <murrayc@murrayc.com>
927 * src/modest-tny-account-store.c: (get_password):
928 Use tny_account_set_username() to tell tinymail that the username might
929 have changed too. But tinymail ignores this: see projects.maemo.org
931 * src/modest-ui-actions.c:
932 (modest_ui_actions_on_password_requested): Remove the useless attempt to
933 reset the connection when changing the username, and improve the comments.
934 Save the changed username to gconf at least, so it is used when Modest is
937 2007-06-21 Murray Cumming <murrayc@murrayc.com>
939 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
940 Do not use a query, so that we get all folders, including for POP and
941 local-folders. They work as search criteria too.
942 This fixes projects.maemo.org bug NB#57740.
944 2007-06-21 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
947 Comment out the use of hildon_notification_set_sound() because it is
948 not declared, to fix the build. Warnings are serious, people.
950 2007-06-21 Armin Burgmeier <armin@openismus.com>
952 * src/maemo/modest-maemo-utils.h:
953 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
954 modest_maemo_utils_get_supported_secure_authentication_methods()
955 to query authentication methods for a specific user. This should fix
956 projects.maemo.org bug NB#61369.
958 * src/maemo/easysetup/modest-easysetup-wizard.c:
959 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
962 2007-06-21 Murray Cumming <murrayc@murrayc.com>
964 * libmodest-dbus-client/libmodest-dbus-client.h:
965 * libmodest-dbus-client/libmodest-dbus-client.c:
966 (modest_dbus_message_iter_get_search_hit),
967 (libmodest_dbus_client_search):
968 Reorganised and commented this.
969 Removed modest_search_hit_free() from the public API because it
972 Added libmodest_dbus_client_get_folders() and
973 modest_folder_result_list_free().
975 * src/dbus_api/modest-dbus-api.h:
976 * src/dbus_api/modest-dbus-callbacks.c:
977 (modest_dbus_req_filter): Commented. Moved most code to
978 on_dbus_method_search() and added on_dbus_method_get_folders().
980 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
981 of the extra D-Bus handler.
983 * tests/dbus_api/Makefile.am:
984 * tests/dbus_api/test_get_folders.c: New test for
985 libmodest_dbus_client_get_folders(). This seems to return an empty list
986 at the moment. That could be the same error that causes the message list
987 to be empty sometimes.
988 This should help with projects.maemo.org bug NB#57740.
990 2007-06-21 Armin Burgmeier <armin@openismus.com>
992 * src/modest-mail-operation.c: Do not call
993 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
994 notify the operation's end after having set the status to CANCELED for
995 the operation queue to listen on. This fixes a deadlock when there
996 were mail operations in the queue during its finalization.
998 * src/modest-singletons.c: Reordered uninitialization of the account
999 manager to happen after the mail operation queue was uninitialized
1000 because the mail operation's in the queue might still try to access
1001 the account manager (see modest_mail_operation_notify_end()). This
1002 fixes a potential crash when terminating the application.
1004 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-search.c:
1007 (search_mime_part_and_child_parts): Moved some code here so we
1008 can search recursively in child folders.
1009 (modest_search_folder): Search in the message as a mime part, instead
1010 of just its child mime parts.
1011 (read_chunk), (search_mime_part_ogs):
1012 Check how many bytes were read, to prevent an endless loop.
1013 Searching in message bodies now works. This finishes the fix for
1014 projects.maemo.org bug NB#61007.
1016 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1019 Add a g_warning when the item is not a folder.
1021 * src/modest-ui-dimming-rules.c:
1022 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1023 when selected item is not a folder (for instance, an account), because
1024 the UI spec only talks about folders.
1025 I am not sure what the UI spec wants, so this might not totally fix
1026 projects.maemo.org bug NB#60794.
1028 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1030 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1031 (load_from_file): Sort the list. The unsorted list would be more noticeable
1032 in non-English locales.
1034 * src/maemo/modest-msg-edit-window.c:
1035 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1036 warning and fix the build.
1038 * src/maemo/modest-progress-bar-widget.c:
1039 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1040 avoid a g_warning, and probably to avoid a crash.
1042 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-search.c: (modest_search_folder): Check for a GError
1045 when calling tny_folder_get_headers(), to show that this is not the cause
1048 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1050 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1051 Actually set the body query instead of the subject query.
1053 * src/modest-search.c: (search_mime_part_ogs),
1054 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1055 which would probably cause it to fail if we got this far.
1057 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1058 to simplify the code.
1059 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1060 be causing search-in-body to fail.
1062 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1064 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1066 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1067 Better debug message when the folder cannot be found.
1068 This should help with fixing projects.maemo.org bug #61287.
1069 * src/modest-search.c: (add_hit): Do not leak the furl string.
1071 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-ui-actions.c:
1074 (modest_ui_actions_on_folder_selection_changed):
1075 Do not special-case TNY_MERGE_FOLDER here, because
1076 modest_tny_folder_get_account() already does that. This fixes
1077 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1078 shown when the Outbox was selected).
1080 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1082 * libmodest-dbus-client/libmodest-dbus-client.c:
1083 (_dbus_iter_get_string_or_null): Initialize the string variable in
1084 case this helps with Dirk's crash.
1086 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1088 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1089 though it is not implemented yet (this function is maybe not even used),
1090 to avoid breaking ABI in future.
1091 * libmodest-dbus-client/libmodest-dbus-client.c:
1092 (get_attachments_string): Moved some code into this generic function.
1093 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1094 sends email. It is maybe not used.
1095 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1096 (on_send_mail): Use attachments.
1098 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1099 * src/maemo/modest-msg-edit-window.c:
1100 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1101 a filename before using it, to fix projects.maemo.org bug NB#58233.
1103 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1106 Initialize the continue_download variable to fix the build, and probably
1107 to fix randome behaviour.
1109 2007-06-18 Armin Burgmeier <armin@openismus.com>
1111 * src/modest-tny-send-queue.h:
1112 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1113 the queue so we can later show it in the UI. Replaced
1114 modest_tny_send_queue_msg_is_being_sent() by
1115 modest_tny_send_queue_get_msg_status().
1117 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1119 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1120 gpointer. This probably was not harmful, but just to be sure.
1122 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1124 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1125 Fix the build, but leave the function broken on Bora, because
1126 hildon_uri_action_get_service() does not exist.
1127 osso_uri_action_get_service() does not exist either, it seems.
1129 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account.c:
1132 (modest_tny_account_new_from_server_account):
1133 Uncommented the url debug output again, because it is useful for
1134 debugging, as I said in the comment.
1136 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1138 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1140 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1141 for Mameo Bora, to fix the build.
1143 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1146 Fixed build with hildon < 0.99
1148 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1149 Check if the selected account is busy instead of checking all accounts
1151 * src/modest-account-mgr-priv.h:
1152 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1153 (modest_account_mgr_init), (compare_account_name),
1154 (modest_account_mgr_set_account_busy),
1155 (modest_account_mgr_account_is_busy):
1156 * src/modest-account-mgr.h:
1157 Added busy information to the account manager. It possible to
1158 set an account to busy or not busy now.
1160 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1161 (modest_mail_operation_update_account),
1162 (modest_mail_operation_notify_end):
1163 Set the account to busy/not busy depending on the operation state.
1165 * src/widgets/modest-account-view.c:
1166 (modest_account_view_finalize), (get_last_updated_string),
1167 (update_account_view), (on_account_busy_changed), (init_view):
1168 Show string "Refreshing..." if the account is currently busy.
1170 All this fixes projects.maemo.org bug NB#59711
1172 2007-06-14 Armin Burgmeier <armin@openismus.com>
1174 * src/widgets/modest-attachments-view.h:
1175 * src/widgets/modest-attachments-view.c: Added
1176 modest_attachments_view_has_attachments() and fixed coordinate
1177 transformation in get_att_view_at_coords(). This fixes attachment
1180 * src/widgets/modest-msg-view.c: Make use of
1181 modest_attachments_view_has_attachments() to decide whether to show
1182 attachments in the header.
1184 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1186 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1187 (on_change), (on_combo_security_changed),
1188 (modest_connection_specific_smtp_edit_window_init),
1189 (modest_connection_specific_smtp_edit_window_set_connection),
1190 (modest_connection_specific_smtp_edit_window_is_dirty):
1191 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1192 * src/maemo/modest-connection-specific-smtp-window.c:
1195 Show an comfirmation dialog for the smpt-edit-window if there are
1196 unsaved changes and the user hits cancel.
1197 (projects.maemo.org bug NB#60479)
1199 2007-06-14 Armin Burgmeier <armin@openismus.com>
1201 * src/maemo/easysetup/modest-easysetup-wizard.c:
1202 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1203 address" info in banner instead of node, and select all the text as
1204 per UI spec. This fixes projects.maemo.org bug NB#60550.
1206 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1208 reviewed by: <delete if not using a buddy>
1210 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1211 * src/modest-ui-actions.c: (folder_refreshed_cb):
1213 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1215 * src/widgets/modest-folder-view.c: (filter_row):
1216 Explictly filter out the per-account outbox accounts. I don't know why
1217 these only sometimes show up, but now they should never show up in the UI.
1218 This should fix projects.maemo.org bug NB#60160.
1220 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1222 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1223 when the toolbar does not exist yet.
1224 * src/modest-widget-memory.c: (save_settings_header_view):
1225 Added g_warnings() to help us to discover when we are trying to set
1226 an empty columns list in gconf.
1228 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-init.h:
1231 * src/modest-init.c:
1232 Added modest_init_get_default_header_view_column_ids().
1234 * src/modest-widget-memory.c: (restore_settings_header_view):
1235 Use the new function to get defaults, if the gconf key is empty,
1236 instead of not creating any columns. This seems to fix the
1237 empty right-hand pane problems.
1239 * src/widgets/modest-header-view.h: Improved documentation.
1241 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1244 Revert the use of the display name as the account name, because this
1245 is generally wrong and would break the code that follows.
1247 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1249 * src/maemo/easysetup/modest-easysetup-wizard.c:
1250 (check_for_supported_auth_methods), (on_before_next),
1253 More correct fix for projects.maemo.org bug NB# 58991
1254 Do not longer accept AUTH_PASSWORD as secure method and choose
1255 correct method when creating the account.
1257 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1259 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1260 Fixed projects.maemo.org bug NB# 58991
1262 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-init.c: (modest_init_init_core),
1265 (modest_init_local_folders): Fixed compilation errors.
1267 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1269 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1270 Remove unnecessary lib/include, though it is good in principle when needed.
1272 * src/modest-init.c: (modest_init_one_local_folder),
1273 (modest_init_local_folders):
1274 * src/modest-init.h: Initialize the .modest library for memory cards,
1275 instead of just doing nothing for them. This should allow us to create
1276 folders there, fixing projects.maemo.org bug NB#59297.
1278 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1280 * libmodest-dbus-client/libmodest-dbus-client.c:
1281 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1282 (libmodest_dbus_client_compose_mail),
1283 (libmodest_dbus_client_open_message),
1284 (libmodest_dbus_client_send_and_receive),
1285 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1287 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1288 (on_idle_open_message), (modest_dbus_req_handler),
1289 (search_result_to_message), (modest_dbus_req_filter):
1290 * src/modest-search.c: (add_hit), (modest_search_folder),
1291 (modest_search_all_accounts): Improved debug messages.
1293 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1295 * src/modest-tny-account-store.c:
1296 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1299 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1302 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1304 * src/modest-tny-account-store.c: (get_server_accounts):
1305 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1306 even when there are no accounts, so that the Outbox folder is always
1307 visible. This fixes projects.maemo.org bug NB#60158.
1309 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/modest-main-window.c: (create_details_widget):
1312 Use the mcen_va_never logical ID.
1314 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1316 * src/dbus_api/modest-dbus-api.h:
1317 * src/dbus_api/modest-dbus-callbacks.c:
1318 (on_idle_open_default_inbox), (on_open_default_inbox),
1319 (modest_dbus_req_handler):
1320 Added a new OpenDefaultInbox method.
1322 * libmodest-dbus-client/libmodest-dbus-client.h:
1323 * libmodest-dbus-client/libmodest-dbus-client.c:
1324 Added libmodest_dbus_client_open_default_inbox() to call the new
1325 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1326 though it should maybe be used by a new osso-email-interface function.
1328 * tests/dbus_api/Makefile.am:
1329 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1332 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1335 NULL, so that the signals get all the keys. This should not actually
1336 change any behaviour because we currently update everything when anything
1339 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1341 * src/widgets/modest-folder-view.c: (text_cell_data),
1342 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1343 (find_inbox_iter): If tinymail tells us that the folder is
1344 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1345 This causes the inbox to be selected at startup, fixing part of
1346 projects.maemo.org bug NB#56305.
1348 * src/modest-ui-dimming-rules.c:
1349 (modest_ui_dimming_rules_on_tools_smtp_servers):
1350 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1351 the SMTP servers menu item.
1352 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1353 that the SMTP Servers menu item is dimmed when there are no accounts,
1354 as a future version of the UI spec will require. This fixes
1355 projects.maemo.org bug NB#56305.
1357 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1359 * src/maemo/modest-maemo-utils.c:
1360 (modest_maemo_utils_get_supported_secure_authentication_methods):
1361 Added label to dialog instead of unreadable title
1363 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1364 (modest_main_window_new):
1365 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1368 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1369 * src/modest-account-mgr.h:
1370 Added method to avoid code duplication
1372 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1373 (modest_ui_actions_on_send_receive):
1374 Use modest_account_mgr_has_accounts
1376 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/easysetup/modest-presets.c:
1379 (modest_presets_get_info_server_security): Do not report secure auth
1381 * src/modest-protocol-info.c: Use the defines for the gconf key names
1382 for secure authentication. This was not working because we were writing
1383 Password and reading password, and the check was case sensitive.
1384 With this, gmail now works for receiving and sending when created via
1387 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/easysetup/modest-presets.c:
1390 (modest_presets_get_info_server_security): Correct the key name for
1391 SecureSmtp, because it seems to be case-sensitive.
1392 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1393 Do not try to get the 0th notebook page if there are 0 pages, to
1394 avoid a g_warning().
1396 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1399 Prevent use of the new notification feature for now, because it currently
1400 shows one dialog for each new email, which is annoying.
1402 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1404 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1405 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1406 when no country was selected, so that we show the global ones.
1407 * src/maemo/easysetup/modest-presets.c:
1408 (modest_presets_get_providers): Return only the global providers, not
1409 all providers when mmc=0 was requested.
1411 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1413 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1414 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1415 provider ID in the combo.
1417 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1418 Do not show the page numbers, because it would be confusing when we add
1419 the 2 extra pages for the custom setup, when the user chooses the "Other"
1420 provider. This fixes projects.maemo.org bug NB#59028
1422 * src/modest-init.c: (modest_init_init_core),
1423 (modest_init_local_folders):
1424 * src/modest-init.h:
1425 * src/modest-tny-account.c:
1426 (modest_tny_account_new_for_local_folders): Do not create default folders
1427 for the memory card. This should fix projects.maemo.org bug NB#59328.
1429 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1432 Free the changed_conf_keys string items. They are already freed in the
1433 idle handler if that runs first.
1435 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1437 * src/modest-ui-actions.c:
1438 (modest_ui_actions_on_password_requested): Check that the server name
1439 is not NULL, because I just saw a password dialog with (null) as the
1442 * src/modest-tny-folder.[h|c]: Added
1443 modest_tny_folder_is_memory_card_folder().
1444 * src/modest-ui-dimming-rules.c:
1445 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1446 menu item for memory cards, as per the UI spec (section 7.4). This should
1447 fix projects.maemo.org bug NB#59297.
1449 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1451 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1452 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1453 is another problem with the code, see Murray's comment at line 772)
1455 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1457 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1458 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1459 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1460 (load_from_file), (easysetup_country_combo_box_init),
1461 (easysetup_country_combo_box_get_active_country_ids),
1462 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1463 instead of just one ID, to avoid duplicate country names in the UI.
1465 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1466 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1467 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1468 a single ID, avoiding duplicate providers.
1469 * src/maemo/easysetup/modest-easysetup-wizard.c:
1470 (on_combo_account_country): Adapt to use a list.
1472 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1474 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1475 keys changed in the last X seconds.
1477 * src/modest-account-mgr.h:
1478 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1479 (on_key_change), (modest_account_mgr_class_init),
1480 (modest_account_mgr_init), (modest_account_mgr_finalize):
1481 As the keys are changed, save them in a GSList* and signal that GSList*
1482 further every X seconds, to batch changes, to allow us to do just one
1483 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1484 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1486 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1487 changed signal signature.
1489 * src/modest-conf.c: (modest_conf_set_list),
1490 (modest_conf_on_change): Reenable notification.
1492 (modest_conf_maemo_fake_on_change): Comment out the hack that
1493 notified immediately instead of asynchronously.
1495 * src/widgets/modest-account-view.h:
1496 * src/widgets/modest-account-view.c:
1497 (update_account_view): Select the previously-selected account ID,
1498 if possible. This fixes projects.maemo.org bug NB#56933.
1500 (on_account_changed), (on_account_removed),
1501 (modest_account_view_select_account):
1503 Remove the block/unblock functions
1504 because they were not useful.
1506 * src/maemo/modest-account-view-window.c:
1507 (on_delete_button_clicked), (on_edit_button_clicked),
1508 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1510 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1512 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1513 Improve the error dialog to show Incorrect Account Settings, which seems
1514 clearer, and say that the internal error message (to be removed from the
1515 dialog later) is often misleading.
1516 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1518 * src/modest-tny-account.c:
1519 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1520 URL because this is so useful for debugging on the device.
1522 * src/widgets/modest-serversecurity-combo-box.c:
1523 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1525 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1527 * src/modest-mail-operation.c:
1528 (modest_mail_operation_send_new_mail):
1529 Added a comment about a nasty but apparently harmless message. Details
1530 added to the wiki g_warnings() page.
1532 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1535 (modest_tny_send_queue_class_init):
1536 Do not use the priv struct because it is empty, to avoid g_warnings
1537 about a non-existant priv struct.
1539 * src/modest-tny-account-store.c:
1540 (modest_tny_account_store_get_server_account),
1541 (modest_tny_account_store_get_transport_account_for_open_connection
1542 ): Do not try to get transport server accounts for local folders,
1543 because they don't have any. This avoids a g_warning().
1545 * src/maemo/modest-main-window.c:
1546 (modest_main_window_notify_send_receive_initied),
1547 (on_configuration_key_changed):
1548 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1549 * src/modest-defs.h:
1550 * src/modest-mail-operation.c:
1551 (modest_mail_operation_update_account):
1552 * src/modest-tny-account-store.h:
1553 * src/modest-tny-account.c:
1554 (modest_tny_account_get_special_folder),
1555 (modest_tny_account_new_for_local_folders),
1556 (modest_tny_account_new_for_per_account_local_outbox_folder):
1557 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1558 * src/modest-tny-local-folders-account.c:
1559 (add_account_folders_to_merged_folder):
1560 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1561 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1562 (modest_ui_actions_on_send):
1563 * src/widgets/modest-folder-view.c: (update_model):
1564 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1565 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1566 modest_tny_account_store_get_tny_account_by_account() to
1567 modest_tny_account_store_get_server_account() to make the code clearer.
1569 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1571 * src/dbus_api/modest-dbus-api.h:
1572 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1573 * src/maemo/modest-msg-edit-window.c:
1574 (modest_msg_edit_window_attach_file_noninteractive):
1575 added g_warning in case the file to be attached does not exist
1576 * tests/dbus_api/test_compose_mail.c: (main):
1577 removed obsolete comment, added generic files as test case
1579 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-account-store.c: (get_server_accounts):
1582 Create the local folders account only once, not once for each outbox, and
1583 not only when there are some outboxes.
1585 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1587 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1588 code that is causing a crash at startup. Sergio says that he is fixing this.
1590 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1592 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1593 * src/maemo/modest-account-settings-dialog.c:
1594 (create_page_outgoing),
1595 (modest_account_settings_dialog_set_account_name),
1596 (save_configuration):
1597 - Fixed handling of the "Use secure authentication" toggle to comply with
1598 the ui specification. See also projects.maemo.org bug NB#58400
1600 - Restore the Secure connection setting combo correctly when loading
1603 * src/maemo/modest-maemo-utils.c:
1604 (on_camel_account_get_supported_secure_authentication),
1605 (modest_maemo_utils_get_supported_secure_authentication_methods):
1606 Fixed a crasher if operation is canceled
1608 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1609 (modest_protocol_info_auth_is_secure):
1610 * src/modest-protocol-info.h:
1612 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1613 the sense of the "Use secure authentication" toggle.
1615 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-tny-account-store.h:
1618 * src/modest-tny-account-store.c:
1619 Added modest_tny_account_store_get_local_folders_account().
1621 * src/modest-tny-folder.h:
1622 * src/modest-tny-folder.c:
1623 (modest_tny_folder_get_account):
1624 Added this replacement for tny_folder_get_account() which returns
1625 the local-folders account for TnyMergeFolders, to avoid the
1626 warning about the unimplemented get_account_func() vfunc().
1628 (modest_tny_folder_get_rules),
1629 * src/modest-ui-actions.c:
1630 (modest_ui_actions_on_folder_selection_changed):
1631 * src/modest-mail-operation.c:
1632 (modest_mail_operation_remove_folder),
1633 (modest_mail_operation_xfer_folder),
1634 (modest_mail_operation_rename_folder),
1635 (modest_mail_operation_get_msg),
1636 (modest_mail_operation_get_msgs_full),
1637 (modest_mail_operation_remove_msg),
1638 (modest_mail_operation_xfer_msgs),
1639 (modest_mail_operation_refresh_folder):
1640 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1642 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1645 (modest_server_account_set_security):
1646 * src/modest-defs.h: Add comments explaining that our
1647 UI spec means TLS when it says Normal, so these do not look like errors.
1649 * src/modest-tny-account.c:
1650 (modest_tny_account_new_from_server_account): Use the new tinymail
1651 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1652 for TLS. This should fix projects.maemo.org bug NB#58460.
1654 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/easysetup/modest-easysetup-wizard.c:
1657 (create_account): Correct the position of the gconf sanity check warning.
1658 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1659 of using the g_idle_add() hack, because this does not seem to be necessary
1660 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1661 caused by something other than maemo's gconf.
1662 This fixes projects.maemo.org bug #59022.
1664 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-account-mgr-helpers.c:
1667 (modest_account_mgr_get_default_account): Do not check that the account
1668 exists if there is no default account (NULL), to fix a runtime warning.
1670 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1672 * src/widgets/modest-folder-view.c: (update_model):
1673 Do not unref the treemodel before we have finished with it.
1674 This prevents a valgrind warning and an occasional crash at startup.
1676 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1678 * libmodest-dbus-client/libmodest-dbus-client.h:
1679 added libmodest_dbus_client_compose_mail()
1680 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1682 added functions needed for SendAsMail() functionality
1683 * src/maemo/modest-msg-edit-window.c:
1684 (modest_msg_edit_window_attach_file_noninteractive):
1685 non interactively attaching files to message edit window
1686 * src/widgets/modest-msg-edit-window.h:
1687 * tests/dbus_api/Makefile.am:
1688 added test_compose_mail.c
1689 * tests/dbus_api/test_compose_mail.c: (main):
1691 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1693 * src/modest-account-view.c:
1694 Fixed bug projects.maemo.org bug NB#59307
1696 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1698 * src/maemo/easysetup/modest-easysetup-wizard.c:
1699 (get_serverport_incoming), (on_before_next), (create_account):
1700 * src/maemo/modest-account-settings-dialog.c:
1701 (modest_account_settings_dialog_set_account_name):
1702 * src/maemo/modest-maemo-utils.c:
1703 (on_camel_account_get_supported_secure_authentication_status),
1704 (on_camel_account_get_supported_secure_authentication),
1705 (on_secure_auth_cancel),
1706 (modest_maemo_utils_get_supported_secure_authentication_methods):
1708 Implemented security authentication for settings and easysetup.
1710 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1712 * src/maemo/modest-main-window.c: (create_details_widget):
1713 Show the total size for memory card accounts too, instead of showing
1714 the name again. Fixes bug projects.maemo.org bug NB#59307.
1716 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1719 * src/modest-tny-simple-folder-store.c:
1720 * src/modest-tny-simple-folder-store.h: Removed.
1722 * src/modest-tny-local-folders-account.h
1723 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1724 for the local-folders maildir, with an extra TnyMergedFolder containing
1725 the folders of the per-account outbox store accounts.
1726 * src/modest-tny-account-store.c: (get_server_accounts):
1727 Add the outboxes to the special local folders account after creating it.
1729 * src/modest-tny-account.c:
1730 (modest_tny_account_new_for_local_folders): Create the derived
1731 account when creating the main local-folders account.
1733 * src/maemo/modest-main-window.c: (create_details_widget),
1734 (modest_main_window_set_contents_style):
1735 Adapted to the use of the derived account instead of the folder store.
1737 * src/modest-ui-actions.c:
1738 (modest_ui_actions_on_folder_selection_changed):
1739 * src/modest-ui-dimming-rules.c:
1740 (modest_ui_dimming_rules_on_new_folder):
1741 * src/widgets/modest-folder-view.c: (text_cell_data),
1742 (icon_cell_data), (filter_row), (update_model),
1743 (get_cmp_rows_type_pos):
1746 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1747 Do not get the priv struct, because no priv struct has been set,
1748 to avoid a runtime warning.
1750 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1751 #ifelse with #else, to fix a warning, to fix the build.
1754 2007-06-05 Christian Kellner <ckellner@openismus.com>
1756 * libmodest-dbus-client/libmodest-dbus-client.c:
1757 Fix small typo in doc (why do you always see them
1758 AFTER committing stuff?)
1761 2007-06-05 Christian Kellner <ckellner@openismus.com>
1763 * libmodest-dbus-client/libmodest-dbus-client.c:
1764 (libmodest_dbus_client_search):
1765 Initialize hit list with NULL. Also set folder list
1766 to "" if NULL was supplied.
1769 2007-06-03 Christian Kellner <ckellner@openismus.com>
1771 * libmodest-dbus-client/libmodest-dbus-client.c:
1772 (modest_search_hit_list_free):
1773 Make it save to call it with NULL.
1775 * src/dbus_api/modest-dbus-callbacks.c:
1776 * src/modest-search.c:
1777 Return full ModestSearchHits as the search result list not TnyHeader
1778 since can't be around withouth the correspoding TnyFolder.
1780 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1782 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1783 Added currently commented code to check for secure auth
1785 * src/maemo/modest-account-settings-dialog.c: (on_response),
1786 (save_configuration), (show_ok):
1787 Fixed projects.maemo.org bugs NB #59248 and #59251
1789 * src/maemo/modest-maemo-utils.c:
1790 (on_camel_account_get_supported_secure_authentication_status),
1791 (on_camel_account_get_supported_secure_authentication),
1792 (modest_maemo_utils_get_supported_secure_authentication_methods):
1793 * src/maemo/modest-maemo-utils.h:
1794 Moved get_supported_secure_authentication() method here to be able
1795 to use it from easysetup wizard.
1797 * src/modest-pair.c: (on_pair_compare_as_string):
1798 Should compare string with first part of pair and not
1799 strcmp pairs which will crash.
1801 * src/modest-protocol-info.c:
1802 (modest_protocol_info_protocol_is_store):
1803 * src/modest-protocol-info.h:
1804 Added modest_protocol_info_get_auth_protocol_name()
1806 2007-06-03 Armin Burgmeier <armin@openismus.com>
1808 * src/modest-mail-operation.c:
1809 (modest_mail_operation_get_msgs_full): Set priv->account also when
1810 only retrieving a single message. This avoids a crash when canceling
1813 (modest_mail_operation_notify_end): Do not explicitely remove the
1814 operation from the queue but only emit the progress_changed signal.
1815 The queue itself listens to that signal to remove the operation when
1816 it is finished. This reduces coupling and removes a potential deadlock
1817 when modest_mail_operation_notify_end() is called from the queue
1818 itself. If that is a problem performance-wise, I would suggest to
1819 implement a status-changed signal or something.
1821 * src/modest-mail-operation-queue.c: Make sure to never call a
1822 function from another file while the queue is locked. This (hopefully)
1823 fixes another deadlock when exiting the application while retrieving
1826 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1828 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1829 Fixed build if libogs is not available
1831 2007-06-03 Christian Kellner <ckellner@openismus.com>
1833 * libmodest-dbus-client/libmodest-dbus-client.h:
1834 * libmodest-dbus-client/libmodest-dbus-client.c:
1835 (libmodest_dbus_client_delete_message):
1836 Implement deletion of messages (Client side).
1838 (modest_search_hit_free),
1839 (modest_search_hit_list_free):
1840 Utility functions to free the result hits.
1842 * src/dbus_api/modest-dbus-api.h:
1843 * src/dbus_api/modest-dbus-callbacks.c:
1844 (on_delete_message),
1845 (modest_dbus_req_handler):
1846 Implement deletion of messages (Server side).
1848 * tests/dbus_api/test_search.c: (main):
1851 * tests/dbus_api/Makefile.am:
1852 * tests/dbus_api/test_delete_message:
1853 Add little test for the message deletion logic
1855 2007-06-03 Armin Burgmeier <armin@openismus.com>
1857 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1858 when the operation queue was not empty. projects.maemo.org bug
1861 2007-06-03 Armin Burgmeier <armin@openismus.com>
1863 * src/widgets/modest-account-view.c
1864 (on_account_default_toggled): Toggle default account column
1865 explicitely instead of waiting for gconf notification (which is
1866 currently ignored). This should fix projects.maemo.org bug NB#56910
1867 for now. It should probably be removed when gconf notifications are
1870 2007-06-03 Christian Kellner <ckellner@openismus.com>
1872 * libmodest-dbus-client/libmodest-dbus-client.c:
1873 Removed debugging spew.
1875 * src/dbus_api/modest-dbus-callbacks.c:
1876 Added debugging info.
1878 * src/modest-search.c:
1879 (modest_search_all_accounts):
1880 Use tny_account_store_get_accounts () on the account store
1881 to get all accounts which is the way to get all accounts.
1883 * tests/dbus_api/test_search.c: (main):
1884 Make it possible to supply the search term on the command line.
1886 2007-06-03 Christian Kellner <ckellner@openismus.com>
1888 * libmodest-dbus-client/libmodest-dbus-client.c:
1889 * libmodest-dbus-client/libmodest-dbus-client.h:
1890 Implement searching for mesages over raw dbus. (Client side)
1892 * src/dbus_api/Makefile.am:
1893 * src/dbus_api/modest-dbus-api.h:
1894 * src/dbus_api/modest-dbus-callbacks.c:
1895 * src/dbus_api/modest-dbus-callbacks.h:
1896 Search framework (Server side). Also implement on_idle_open_message().
1898 * src/maemo/modest-platform.c: (modest_platform_init):
1899 Prepare for raw dbus/osso rpc interaction.
1901 * src/modest-search.h:
1902 Changed minsize from unspecific guint to guint32.
1904 * src/modest-search.c:
1906 Added strange hack which magically made tnymail work.
1908 (modest_search_folder),
1909 (modest_search_account),
1910 (modest_search_all_accounts):
1911 Implement helper functions to search all accounts, specific account
1914 * tests/dbus_api/Makefile.am:
1915 * tests/dbus_api/test_open_message.c:
1916 Read url to open from commandline.
1918 * tests/dbus_api/test_search.c:
1919 Implement small test for dbus search stuff
1921 2007-06-02 Armin Burgmeier <armin@openismus.com>
1923 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1924 include account type and account title. This fixes projects.maemo.org
1927 * src/maemo/modest-account-view-window.c: Set a title for the window.
1929 2007-06-02 Armin Burgmeier <armin@openismus.com>
1931 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1932 incoming and outgoing server name based on email address and server
1933 types as long as the names have not been edited manually. This fixes
1934 projects.maemo.org bug NB#58671.
1936 2007-06-02 Armin Burgmeier <armin@openismus.com>
1938 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1939 server type cannot be changed in future to the incoming details page
1940 when creating an account. This fixes projects.maemo.org bug NB#59029.
1942 2007-06-02 Armin Burgmeier <armin@openismus.com>
1944 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1945 and assigned max width chars so that they wrap instead of being
1946 truncated. Fixes projects.maemo.org bug NB#56126.
1948 2007-06-02 Armin Burgmeier <armin@openismus.com>
1950 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1951 introductory note to the connection specific smtp servers dialog, as
1952 section 8.12 of the email UI specification requires. This fixes
1953 projects.maemo.org bug NB#59212.
1955 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1957 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1958 Check for running mail operations, and offer to cancel them, as per the UI
1959 spec. This fixes projects.maemo.org bug NB#59041 .
1960 However, I suspect that tinymail may still use the network connection
1961 in ways that we cannot detect or cancel. But it should at least adapt to
1962 changes fairly well.
1964 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-tny-account-store.c: (recreate_all_accounts),
1967 (get_cached_accounts), (get_server_accounts): Do more sensible
1968 ref-counting of the temporarily-cached outbox accounts list. This seems
1969 to fix a crash when entering the password when the password was wrong.
1971 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1973 * src/gnome/modest-main-window.c: (connect_signals):
1974 * src/modest-tny-account-store.c: (get_password),
1975 (modest_tny_account_store_alert): Added comments and clues and
1976 commented-out code about how we currently fail to deal with connection
1977 errors and wrong passwords, and how we should.
1979 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1981 * src/widgets/modest-retrieve-combo-box.c:
1982 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1983 This fixes projects.maemo.org bug NB#58472 .
1985 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1987 * src/maemo/easysetup/modest-easysetup-wizard.c:
1988 (create_page_complete_easysetup):
1989 (create_page_complete_custom): Correct the last commit,
1990 putting the correct sentences in the correct pages.
1992 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1994 * src/maemo/easysetup/modest-easysetup-wizard.c:
1995 (create_page_complete_custom): Show the second sentence of text
1996 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1999 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2002 Set the leave-on-server conf key by default. This fixes
2003 projects.maemo.org bug NB#59258 .
2005 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2007 * src/maemo/modest-account-view-window.c:
2008 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2009 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2012 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/easysetup/modest-easysetup-wizard.c:
2015 (create_caption_new_with_asterisk):
2016 * src/maemo/modest-account-settings-dialog.c:
2017 (create_caption_new_with_asterisk):
2018 Uncomment the code to add the asterisk, because they are no longer in the
2019 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2020 (update_incoming_server_title): Add an asterisk here too.
2022 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2024 * src/maemo/modest-maemo-global-settings-dialog.c:
2025 (current_connection): Check that we are even connected before trying to
2026 get the current connection name, to prevent a warning.
2028 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2029 Change the comments because tny_maemo_conic_device_connect() is now meant to
2031 * src/modest-mail-operation.c:
2032 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2033 make sure we have a connection and fail if we can't connect.
2035 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/modest-main-window.c:
2038 (on_account_store_connecting_finished): Do not try to get the
2039 connection ID if we are not really connected. I am surprised that
2040 this signal handler is called when we are not connected.
2042 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-error.h:
2045 * src/modest-ui-actions.c:
2046 (modest_ui_actions_get_msgs_full_error_handler):
2047 Renamed an enum, added comments, added an enum
2048 for retrieve-limit errors.
2050 * src/modest-mail-operation.c: (foreach_add_item),
2051 (internal_folder_observer_update), (update_account_thread),
2052 (modest_mail_operation_get_msgs_full):
2053 (modest_mail_operation_update_account),
2054 Added comments about how this works, and some code that should
2055 (but does not) check the retrieve-limit. See the TODO comment.
2057 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2060 Initialize help_id to fix the build. Warnings are good.
2062 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2064 * src/widgets/modest-hbox-cell-renderer.c:
2065 (modest_hbox_cell_renderer_append):
2066 * src/widgets/modest-vbox-cell-renderer.c:
2067 (modest_vbox_cell_renderer_append):
2068 Fix the last commit by doing an extra ref.
2070 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2072 * src/widgets/modest-hbox-cell-renderer.c:
2073 (modest_hbox_cell_renderer_append):
2074 * src/widgets/modest-vbox-cell-renderer.c:
2075 (modest_vbox_cell_renderer_append):
2076 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2077 to fix the build with Maemo Bora.
2078 However, there seems to be a remaining crash, probably due to reference
2081 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-account.c:
2084 (modest_tny_account_new_for_local_folders):
2085 Use hildon_file_system_info_async_new() to get a better name for
2086 the memory card account, setting it as the account name.
2087 The timing seems to work, but this is probably
2088 not the best place to do this. See the TODO comment.
2089 * src/maemo/modest-main-window.c: (create_details_widget):
2090 * src/widgets/modest-folder-view.c: (text_cell_data):
2091 Use the tny account name instead of hardcoding a name.
2093 2007-05-30 Christian Kellner <ckellner@openismus.com>
2095 * src/modest-search.c: (modest_search):
2096 Correctly set part_search_func even if we have already parsed
2097 the query and thus a valid OgsTextSearcher object.
2099 2007-05-30 Christian Kellner <ckellner@openismus.com>
2102 Search and check for libogs.
2105 Incooparte the ogs build env.
2107 * src/modest-mime-part-search-stream.c:
2108 * src/modest-mime-part-search-stream.h:
2109 Removed since we do the real searching now in modest-search.c.
2111 * src/modest-search.c:
2112 * src/modest-search.h:
2113 Implement support for ogs. We use that if available and requested
2114 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2115 should now handle the corner case when the search term is spread
2116 across multiple reads.
2117 Also the logic in modest_search () was corrected to search all
2118 requested fields until one is found.
2120 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2122 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2124 * src/modest-init.h:
2125 * src/modest-init.c: Made modest_init_local_folders() take a
2126 path and be public so we can iniitialize maildir folders on
2129 * src/modest-local-folder-info.h:
2130 * src/modest-local-folder-info.c:
2131 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2133 * src/modest-tny-account.c:
2134 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2135 still means the standard local-folders path on the local volume.
2137 * src/modest-tny-account-store.c:
2138 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2139 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2140 all accounts when that happens.
2141 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2142 this too, so it shows up in the treeview.
2144 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/modest-maemo-global-settings-dialog.c:
2147 (current_connection):
2148 * src/widgets/modest-global-settings-dialog.c:
2149 (current_connection_default):
2150 Use the enum values instead of 0, 1 and -1,
2151 to make the code clearer.
2153 * src/modest-account-mgr-helpers.c:
2154 (modest_account_mgr_get_connection_specific_smtp): Make this code
2157 * src/modest-runtime.h:
2158 * src/modest-runtime.c:
2159 Added modest_runtime_remove_all_send_queues().
2160 * src/maemo/modest-main-window.c:
2161 (on_account_store_connecting_finished): Recreate the send queues,
2162 using the appropriate transport accounts for this new connection.
2163 Some futher adapting might be needed if the old send queues are not
2164 automatically stopped at this point.
2166 * src/modest-tny-account-store.c: (get_server_accounts):
2167 Create the connection-specific transport accounts, so that they can
2168 be found later by their ID.
2170 * src/modest-tny-account.h:
2171 * src/modest-tny-account.c:
2172 Added modest_tny_account_new_from_server_account_name().
2173 modest_tny_account_new_from_server_account(): Do not create the
2174 send queues here, because they will be
2175 recreated anyway when the connection changes for the first time.
2177 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2179 * src/modest-local-folder-info.h:
2180 * src/modest-local-folder-info.c:
2181 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2182 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2183 tbox_folder): Take a modest account name instead of a server TnyAccount,
2184 so we can have per-modest-account rather than per-transport-account
2186 We must make sure that we change or recreate the exisitng send queues
2187 when the connection changes for connection-specific transport accounts.
2189 * src/modest-tny-account-store.c:
2190 (create_per_account_local_outbox_folders): Create outboxed per modest
2191 account, not per transport account.
2193 * src/modest-tny-account.h:
2194 * src/modest-tny-account.c:
2195 (modest_tny_account_get_special_folder): For outboxes, get the
2196 parent modest account name. The account is ignored for other folders.
2197 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2198 modest account name rather than a server TnyAccount.
2200 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2202 * src/modest-tny-account.c:
2203 (modest_tny_account_new_from_server_account):
2204 Call modest_runtime_get_send_queue() immediately after creating transport
2205 accounts, so that they start trying to send email from the outbox as soon
2206 as possible at startup. This is probably what we want.
2208 * src/modest-mail-operation.c: (update_account_thread):
2209 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2210 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2211 * src/modest-tny-send-queue.h:
2212 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2213 (modest_ui_actions_on_send):
2214 Added comments about how sending works, though it needs some more work.
2216 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2218 * src/modest-tny-account.c:
2219 (modest_tny_account_get_special_folder): Add TODO because this fails when
2220 the network is busy.
2221 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2222 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2223 Do not try to show this window when there is no active account. The UI
2224 specs does not tell us what to do in this case.
2226 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/Makefile.am:
2231 * src/widgets/Makefile.am: Some dist fixes.
2233 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/modest-connection-specific-smtp-window.c:
2236 (on_button_edit): Make the code clearer, to prevent a double free.
2238 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/modest-account-settings-dialog.c:
2241 (modest_account_settings_dialog_set_account_name),
2242 Check the connection-specific smtp servers checkbox if there are any.
2244 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2245 (modest_connection_specific_smtp_edit_window_init):
2246 Start with a suitable port number.
2248 * src/modest-account-mgr-helpers.h:
2249 * src/modest-account-mgr-helpers.c: Added
2250 modest_account_mgr_get_has_connection_specific_smtp().
2252 (modest_account_mgr_set_connection_specific_smtp),
2253 (modest_account_mgr_remove_connection_specific_smtp),
2254 (modest_account_mgr_get_has_connection_specific_smtp),
2255 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2256 connection-specific smtp server accounts in the account, rather than
2257 the server account conf dir.
2259 This fixes bug projects.maemo.org bug NB#58263 .
2261 * src/modest-tny-account-store.c:
2262 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2263 if there are no server accounts yet, to prevent an infinite loop when there
2264 are no accounts. Document that one must be called before the other.
2266 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2268 * src/modest-account-mgr-helpers.c:
2269 (modest_account_mgr_get_default_account): Make sure that at least
2270 one account is always the default, if there are any enabled accounts.
2271 This is just a sanity check that shouldn't be necessary.
2273 * src/modest-account-mgr-priv.c:
2274 (_modest_account_mgr_account_from_key): Unescape the conf key to
2275 get the real account name. For instance, this is an issue if a space
2276 was in the account name, which can happen because the account name
2277 is generated from the display name.
2278 (_modest_account_mgr_get_account_keyname): Always escape the
2280 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2281 Unescape the conf keys to get the real account names.
2283 For instance, previously the is-default radio button in the accounts
2284 list was not checked for any accounts at first. This fixes that,
2285 and might fix several similar bugs.
2287 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2290 Removed some debug printfs.
2292 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2294 Modest on-disk outbox directories are now here, for instance:
2295 $HOME/.modest/outboxes/<account-id-1>/outbox
2296 $HOME/.modest/outboxes/<account-id-2>/outbox
2298 $HOME/.modest/local-folders/outbox
2299 so we can have a separate outbox for each account.
2300 But they are shown as one outbox in the GtkTreeView, by using a
2301 TnyMergeFolder in a ModestTnySimpleFolderStore.
2304 * src/modest-tny-simple-folder-store.c:
2305 * src/modest-tny-simple-folder-store.h:
2306 Added ModestTnySimpleFolderStore, used to contain folders from
2307 other folder stores, such as other accounts.
2309 * src/modest-tny-outbox-account.h:
2310 * src/modest-tny-outbox-account.c:
2311 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2312 used for the per-account local outbox folders.
2314 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2315 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2316 only use this (internally) now for the non-outbox local folders.
2318 * src/modest-init.h:
2319 * src/modest-init.c: Added modest_init_one_local_folder(), for
2320 setting up the directory structure for each local folder.
2322 * src/modest-local-folder-info.c:
2323 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2324 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2326 * src/modest-local-folder-info.h:
2327 * src/modest-tny-account-store.c: (on_account_removed),
2328 (on_account_changed), (create_per_account_local_outbox_folders),
2329 (get_server_accounts), (modest_tny_account_store_get_accounts),
2330 (modest_tny_account_store_get_tny_account_by_account),
2331 (modest_tny_folder_store_is_virtual_local_folders):
2333 * src/modest-tny-account.h:
2334 * src/modest-tny-account.c:
2335 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2336 to create an on-disk per-account local outbox folder for each
2338 (create_per_account_local_outbox_folders): Create a local outbox folder
2339 for each transport account.
2340 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2341 for all local folders.
2343 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2344 instead of using g_object_get/set() directly. It is clearer.
2346 (modest_tny_folder_store_get_message_count),
2347 (modest_tny_folder_store_get_local_size
2348 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2349 because we now use these with non-acount folder stores.
2351 (modest_tny_account_get_special_folder),
2352 (modest_tny_account_new_from_server_account),
2353 (modest_tny_account_new_from_account):
2354 (recurse_folders): Adjust to the new outbox system.
2356 * src/modest-tny-folder.h:
2357 * src/modest-tny-folder.c:
2358 (modest_tny_folder_is_local_folder),
2359 (modest_tny_folder_get_local_folder_type),
2360 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2362 * src/widgets/modest-main-window.h:
2363 * src/maemo/modest-main-window.c: (create_details_widget),
2364 (modest_main_window_set_contents_style): Show details for any folder store,
2367 (modest_tny_folder_get_rules):
2368 Remove the const. C does not support constness enough for this.
2370 * src/modest-ui-actions.c:
2371 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2372 make all outboxes appear as one, in the usual local-folders tree node.
2374 (set_active_account_from_tny_account),
2375 (modest_ui_actions_on_folder_selection_changed):
2376 * src/widgets/modest-folder-view.c: (text_cell_data),
2377 (icon_cell_data), (filter_row),
2378 (add_account_folders_to_merged_folder),
2379 (add_account_folders_to_simple_folder_store), (),
2380 (get_cmp_rows_type_pos), (cmp_rows),
2381 (modest_folder_view_set_account_id_of_visible_server_account):
2382 Adjust to the new outbox system, using generic folder stores and folders
2383 in the GtkTreeModel.
2385 2007-05-23 Christian Kellner <ckellner@openismus.com>
2387 * src/modest-mail-operation.c:
2388 (modest_mail_operation_update_account):
2389 Use info->max_size instead of unintialized local var [small
2390 build fix]. (Added TODO to review that change since I don't
2393 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2395 * libmodest-dbus-client/libmodest-dbus-client.c:
2396 (libmodest_dbus_client_compose_mail): function added
2397 * src/dbus_api/modest-dbus-api.h:
2398 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2399 (on_compose_mail): Implementation of the SendAsMail functionality
2401 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-account-mgr.c:
2404 (modest_account_mgr_add_server_account): Set the secure-connection
2405 conf key for transport accounts as well as store accounts. I don't know
2406 why the if was there. For instance, this makes sure that we use SSL
2407 for the gmail preset from the easysetup wizard.
2409 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2411 * src/gnome/modest-main-window.c:
2412 (on_account_store_connecting_finished), (connect_signals):
2413 * src/maemo/modest-main-window.c:
2414 (on_account_store_connecting_finished), (connect_signals),
2415 (modest_main_window_new):
2416 Handle TnyAccountStore::connecting-finished instead of
2417 TnyDevice::connection-changed, because we cannot actually perform
2418 operations on accounts until TnyAccountStore has itself responded to
2419 the TnyDevice::connection-changed signal. This prevents a GError from
2421 Do not try to update at startup, because we (at least on scratchbox)
2422 already do an update at startup when the device goes online.
2423 This prevents a GError from tinymail.
2424 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2425 Added TODO about stopping simultaneous operations.
2427 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2429 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2430 * src/modest-mail-operation-queue.c:
2431 (modest_mail_operation_queue_remove):
2432 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2433 about where they happened.
2435 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2437 * src/modest-ui-actions.c:
2438 (modest_ui_actions_on_password_requested): Make sure that the remember
2439 output parameter is always TRUE.
2441 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2443 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2444 Show a OK/Cancel dialog if the error is a question, though we still do not
2445 know anything more about what we are asking the user.
2446 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2447 Fix an uninitialized variable (helper). This is a logic error, however.
2449 2007-05-21 Christian Kellner <ckellner@openismus.com>
2451 * src/modest-search.h:
2452 Correct bit shifting in the ModestSearchFlags enum.
2454 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2456 * src/modest-tny-account.c:
2457 (modest_tny_account_new_from_server_account): Do not use the lsub and
2458 check-all hard-coded IMAP options when using POP.
2460 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2462 * src/modest-tny-account.c:
2463 (modest_tny_account_new_from_server_account):
2464 Use NULL for the secure-auth method for POP when Password auth has been
2465 specified by the user, as we already do for IMAP. "auth=Login" causes
2466 an error from camel or the server.
2468 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-account-settings-dialog.c:
2471 (create_page_account_details),
2472 (modest_account_settings_dialog_set_account_name):
2473 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2474 for the leave-on-server checkbox, rathr than just the checkbox, when
2475 the protocol is not POP.
2477 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2479 * src/widgets/modest-account-view.c:
2480 * src/widgets/modest-account-view.h:
2481 Added modest_account_view_select_account() which will be useful later
2482 to asynchronously re-select the edited account.
2484 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2486 * src/maemo/modest-account-settings-dialog.c:
2487 (modest_account_settings_dialog_set_account_name):
2488 Automatically choose the port numbers based on the secure authentication
2489 methods, if they have not been chosen before.
2490 This fixes projects.maemo.org bug NB#56273 .
2492 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/modest-main-window-ui.h:
2495 * src/modest-ui-actions.c:
2496 * src/modest-ui-actions.h:
2497 Connect the Tools/SMTP Servers menu item to
2498 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2499 SMTP servers dialog, as in the UI specification and saves changes when it
2500 is closed. This fixed projects.maemo.org bug NB#56305 .
2502 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/modest-connection-specific-smtp-window.c:
2505 (modest_connection_specific_smtp_window_init):
2506 Use gtk_window_set_default_size() to make this window big enough, so
2507 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2509 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2513 (modest_connection_specific_smtp_edit_window_init),
2514 Do not try to connect to a combobox signal before the combobox exists.
2515 This fixes the cras in projects.maemo.org bug NB#56288 .
2516 (modest_connection_specific_smtp_edit_window_get_settings):
2517 Remove the server_account_name parameter which was being checked for NULL
2518 though it was not used.
2520 * src/maemo/modest-connection-specific-smtp-window.c:
2521 (modest_connection_specific_smtp_window_fill_with_connections),
2522 (on_button_edit), (modest_connection_specific_smtp_window_init):
2523 Correct the number of treemodel columns to prevent a warning.
2524 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2525 libconic does not work.
2527 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2529 * src/modest-tny-account.c:
2530 (modest_tny_account_new_from_server_account):
2531 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2532 SMTP when "None" was chosen by the user. However, with my SMTP server that
2533 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2536 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2539 to explain the memory management issue with the ID in the ModestPair.
2541 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2542 (add_sending_page), (modest_account_assistant_finalize):
2543 * src/gnome/modest-gnome-global-settings-dialog.c:
2544 (create_updating_page), (create_composing_page):
2545 * src/gnome/modest-msg-edit-window.c: (get_transports),
2546 (init_window), (modest_msg_edit_window_finalize),
2547 (modest_msg_edit_window_get_msg_data):
2548 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2549 * src/gnome/modest-transport-widget.c:
2550 (modest_transport_widget_finalize), (smtp_configuration):
2551 * src/maemo/modest-maemo-global-settings-dialog.c:
2552 (create_updating_page), (create_composing_page):
2553 * src/maemo/modest-msg-edit-window.c: (get_transports),
2554 (init_window), (modest_msg_edit_window_finalize),
2555 (modest_msg_edit_window_get_msg_data),
2556 (modest_msg_edit_window_free_msg_data):
2557 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2558 (modest_store_widget_finalize):
2559 * src/maemo/modest-transport-widget.c:
2560 (modest_transport_widget_finalize), (smtp_configuration):
2561 * src/modest-main.c: (send_mail):
2562 * src/widgets/modest-combo-box.h:
2563 * src/widgets/modest-global-settings-dialog-priv.h:
2564 * src/widgets/modest-global-settings-dialog.c:
2565 (modest_global_settings_dialog_finalize):
2566 * src/widgets/modest-msg-edit-window.h:
2567 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2568 as long as the combo box, to prevent use of freed memory for the ID.
2570 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2572 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2573 get_accounts(), to make this clearer. Do not check for the enabled gconf
2574 key, because we do not use this for server accounts (at least, not yet).
2575 This allows us to send email again.
2577 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-platform.c:
2580 (on_modest_conf_update_interval_changed), (modest_platform_init):
2581 Only respond to this particular key change. All these strcmp()s cannot be
2584 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/modest-maemo-global-settings-dialog.c:
2587 (current_connection): Prevent a crash in scratchbox when
2588 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2589 * src/maemo/modest-platform.c:
2590 (on_modest_conf_update_interval_changed), (modest_platform_init):
2591 Get the update interval from gconf and reset it when the gconf key changes.
2593 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-protocol-info.c:
2596 * src/modest-protocol-info.h: Adde enum-specific get functions,
2597 instead of using a ModestProtocolType enum parameter.
2599 * src/gnome/modest-account-assistant.c:
2600 * src/gnome/modest-store-widget.c:
2601 * src/gnome/modest-store-widget.h:
2602 * src/gnome/modest-transport-widget.c:
2603 * src/gnome/modest-transport-widget.h:
2604 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2605 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2606 * src/maemo/easysetup/modest-easysetup-wizard.c:
2607 * src/maemo/modest-account-settings-dialog.c:
2608 * src/maemo/modest-account-settings-dialog.h:
2609 * src/maemo/modest-store-widget.c:
2610 * src/maemo/modest-store-widget.h:
2611 * src/maemo/modest-transport-widget.c:
2612 * src/maemo/modest-transport-widget.h:
2613 * src/modest-account-mgr-helpers.c:
2614 * src/modest-account-mgr-helpers.h:
2615 * src/modest-account-mgr.c:
2616 * src/modest-account-mgr.h:
2617 * src/modest-tny-account.c:
2618 * src/modest-tny-folder.c:
2619 * src/widgets/modest-account-view.c:
2620 * src/widgets/modest-retrieve-combo-box.c:
2621 * src/widgets/modest-retrieve-combo-box.h:
2622 * src/widgets/modest-secureauth-combo-box.c:
2623 * src/widgets/modest-serversecurity-combo-box.c:
2624 * src/widgets/modest-serversecurity-combo-box.h:
2625 * tests/check_account-mgr.c:
2626 Use the specific functions, and use the re-renamed enum values for GNOME too.
2628 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2630 * src/modest-pair.h:
2631 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2632 so we can get the second based on the first.
2634 * src/maemo/modest-account-settings-dialog.h:
2635 * src/maemo/modest-account-settings-dialog.c:
2636 Added get_supported_secure_authentication_methods(), though it is mostly
2637 commented-out for now until the necessary API is committed to tinymail.
2638 (modest_account_settings_dialog_set_account_name),
2639 (save_configuration): Request the supported authentication methods from the
2640 server, so we can choose a working method.
2642 * src/modest-tny-account-store.h:
2643 * src/modest-tny-account-store.c:
2644 (modest_tny_account_store_get_session): Rename from
2645 tny_account_store_get_session().
2647 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2649 * src/modest-protocol-info.h: Split the ModestProtocol enum
2650 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2651 There was no need to have these unrelated values in one enum.
2653 * src/: many files: Adapted to changed enum. This makes the code a bit
2654 clearer, and the compiler could catch some errors.
2656 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2658 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2659 Show the detailed internal camel error message when an error happens
2660 during the configuration, so that our testers can give us more clues.
2661 For instance, in projects.maemo.org bug NB#56910 .
2663 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2665 * src/modest-tny-account.c:
2666 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2667 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2669 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2671 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2672 * src/maemo/modest-account-settings-dialog.c:
2673 (modest_account_settings_dialog_set_account_name),
2674 (save_configuration): For the incoming secure authentication checkbox,
2675 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2676 the UI specification. PLAIN does not seem to be supported for most IMAP
2677 servers anyway, and I am not sure what it would mean.
2678 However, we probably need to discover which of the secure-authentication
2679 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2680 * src/modest-account-mgr-helpers.c:
2681 (modest_account_mgr_get_server_account_data):
2683 * src/modest-tny-account.c:
2684 (modest_tny_account_new_from_server_account):
2685 Use tny_account_set_mech() to set secure-authentication methods,
2686 with some special-casing for IMAP, based on my observations of how
2689 * src/modest-account-mgr-helpers.h:
2690 * src/modest-account-mgr.c:
2691 * src/modest-defs.h: Comment that the URI is only used for local folders.
2693 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2695 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2696 parameter const, just to be neat.
2697 * src/modest-text-utils.c: (modest_text_utils_inline):
2698 End g_strconcat() with NULL, as its documentation says. This is almost
2699 certainly the cause of my crash at startup on the device. Interestingly,
2700 valgrind doesn't tell us about these errors.
2702 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2704 * scripts/build-packages: Added more precise comments about how to use
2705 this script, though I still get this error:
2706 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2707 error building tinymail
2709 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/modest-main-window.c: (on_account_update):
2712 Very slight cleanup, hoping to make it simpler to discover what causes
2713 a crash here sometimes.
2715 * src/modest-tny-account.c:
2716 (modest_tny_account_new_from_server_account): Set the port. Added
2717 comments about the options and a TODO comment because I need to find out
2718 how to specify the secure authentication method.
2720 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2722 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2723 changed CFlags paths form modest to libmodest
2725 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2727 * src/modest-account-mgr-helpers.c:
2728 (modest_account_mgr_get_server_account_data),
2729 (modest_account_mgr_free_server_account_data):
2730 * src/modest-account-mgr-helpers.h:
2731 * src/modest-account-mgr.c:
2732 (modest_account_mgr_add_server_account):
2733 * src/modest-defs.h:
2734 * src/modest-tny-account.c:
2735 (modest_tny_account_new_from_server_account):
2736 Determine the options for tny_camel_account_add_option() here,
2737 based on the settings, rather than storing them directly in gconf.
2739 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2742 Show a more friendly error dialog now that we expect (from the tinymail
2743 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2745 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2747 * src/maemo/modest-main-window.c: (on_account_update): Check that
2748 account_name is not NULL, to prevent a crash at startup that I am
2749 seeing on the N800. I do wonder why it is NULL.
2751 * src/maemo/easysetup/modest-easysetup-wizard.c:
2752 (create_page_user_details):
2753 * src/maemo/modest-account-settings-dialog.c:
2754 (create_page_user_details), (create_page_outgoing):
2755 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2756 (modest_connection_specific_smtp_edit_window_init):
2757 * src/modest-ui-actions.c:
2758 (modest_ui_actions_on_password_requested):
2759 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2760 might do something useful with the on-screen keyboard.
2762 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2764 * src/maemo/modest-main-window.c: (on_account_update):
2765 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2766 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2768 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2770 * src/modest-tny-account-store.c: (on_account_changed):
2771 Correct the signature of this signal handler.
2773 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2775 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2776 Show a HildonNote instead of a GtkDialog for Maemo.
2778 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2780 * src/widgets/modest-account-view.h:
2781 * src/widgets/modest-account-view.c: (on_account_changed),
2782 (on_account_removed). Added a boolean flag, set/unset by
2783 modest_account_view_block_conf_updates(),
2784 modest_account_view_unblock_conf_updates() to prevent unnecessary
2785 updates, but this is not very useful because the gconf notifications are
2786 so delays (maybe only on Maemo Bora).
2787 So auto-updating is turned off, and these functions do an explicit
2788 update when necessary.
2789 However, something else is still doing too much work when adding/removing
2790 accounts, probably in another part of the application.
2792 * src/maemo/modest-account-view-window.c:
2793 (on_delete_button_clicked), (on_edit_button_clicked),
2794 (on_new_button_clicked): Use the new functions.
2796 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2798 * src/modest-account-mgr-helpers.c:
2799 (modest_account_mgr_set_first_account_as_default):
2800 Sort the list of names alphabetically-by-title, so we choose the first one
2802 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2803 alphabetically by the title.
2805 This fixes projects.maemo.org bug NB#56418 .
2807 * src/modest-account-mgr-priv.c:
2808 (_modest_account_mgr_account_from_key):
2809 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2810 avoid a valgrind error, and possible random behaviour.
2812 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2814 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2815 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2816 tinymail documentation to say that this can be expected.
2817 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2818 pretty, and should not happen, but I would prefer to know when it does.
2820 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2822 * configure.ac: When using the older hildon version, probably on Bora,
2823 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2825 * src/widgets/modest-attachment-view.c:
2826 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2829 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2831 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2832 Implemented the prototype. Can be tested with
2833 tests/dbus_api/test_open_message:
2835 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2837 * src/modest-tny-account-store.c:
2838 (modest_tny_account_store_instance_init), (get_password):
2839 * src/modest-ui-actions.c:
2840 (modest_ui_actions_on_password_requested):
2841 Do not store the password in gconf, because this function is called
2842 for non-remembered passwords. Actually use the cached (in the hash map)
2843 password instead of releasing it.
2844 The password will now not be remembered if it is asked via the protected
2845 password dialog, as per the UI spec.
2847 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2849 * src/modest-defs.h:
2850 * src/modest-account-mgr-helpers.h:
2851 * src/modest-account-mgr-helpers.c:
2852 Added modest_server_account_get_username_has_succeeded(),
2853 modest_server_account_set_username_has_succeeded().
2854 (modest_server_account_set_username),
2855 Reset the has-succeeded flag if the username changes.
2857 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2858 * src/maemo/modest-connection-specific-smtp-window.c:
2859 (modest_connection_specific_smtp_window_save_server_accounts):
2860 Use modest_server_account_set_username() instead of using
2861 modest_conf_set_string() directly, so that the has-succeeded flag is always
2864 * src/modest-ui-actions.c:
2865 (modest_ui_actions_on_password_requested): Dim the username entry if
2866 the username has ever worked, as per the UI spec.
2868 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2870 * src/modest-tny-account-store.c: (get_password):
2871 * src/modest-ui-actions.c:
2872 (modest_ui_actions_on_password_requested):
2873 Allow the username to be changed too, though there is more work to
2874 be done on exactly how this behaves.
2876 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2878 * src/modest-account-mgr-helpers.h:
2879 * src/modest-account-mgr-helpers.c:
2880 Added modest_account_mgr_get_display_name(),
2881 modest_server_account_get_username(),
2882 modest_server_account_set_username(),
2883 modest_server_account_set_password(),
2884 modest_server_account_get_hostname() functions so we do not need to
2885 use the conf API directly.
2887 * src/maemo/modest-main-window.c: (connect_signals):
2888 Actually connect ot the ModestAccountStore::request-password signal,
2889 so that we show the dialog when the password is requested by Tinymail,
2890 for isntance if it is empty.
2892 * src/modest-marshal.list:
2893 * src/modest-tny-account-store.c:
2894 (modest_tny_account_store_class_init), (get_password),
2895 (modest_tny_account_store_alert):
2896 * src/modest-tny-account-store.h:
2897 * src/modest-ui-actions.h:
2898 * src/modest-ui-actions.c:
2899 (modest_ui_actions_on_password_requested):
2900 Change the signal parameters, so it is obvious that we are providing
2901 the non human-readable server name, and receiving both the username
2902 and password, though changing of the username is not yet implemented.
2903 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2904 for the GNOME version.
2906 This should fix the projects.maemo.org bug NB#56209, though it does not
2907 work on Bora, because the gconf_client_get() for the password fails
2908 immediately after we save it with gconf_client_set().
2910 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2913 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2914 caused an undefined symbol error:
2915 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2917 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2919 * src/modest-tny-account-store.c:
2920 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2921 using a GError instead of a string message, so we can translate it in
2924 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/modest-address-book.c:
2927 (modest_address_book_check_names):
2928 * src/maemo/modest-msg-view-window.c:
2929 (modest_msg_view_window_clipboard_owner_change):
2930 * src/modest-init.c: (modest_init_init_ui):
2931 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2932 (update_folders_cb), (modest_mail_operation_update_account):
2933 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2934 (modest_ui_actions_on_msg_attachment_clicked),
2935 (modest_ui_actions_on_msg_recpt_activated):
2936 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2937 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2938 (modest_msg_view_search_next):
2939 * src/widgets/modest-recpt-editor.c:
2940 (modest_recpt_editor_on_button_release_event),
2941 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2942 g_message(). At this point we should only be seeing interesting errors on
2943 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2945 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2947 (modest_wizard_dialog_force_title_update):
2948 * src/maemo/easysetup/modest-wizard-dialog.h:
2949 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2950 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2951 can update the title when appropriate. Otherwise the title is wrong if the
2952 pages are added after adding the notebook to the dialog.
2953 This must be a problem in HildonWizardDialog too.
2954 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2956 * src/maemo/easysetup/modest-easysetup-wizard.c:
2957 (create_subsequent_customsetup_pages),
2958 (create_subsequent_easysetup_pages):
2959 Call modest_wizard_dialog_force_title_update() so that the title is
2960 correct even with GTK+ < 2.10.
2961 This fixes projects.maemo.org bug NB#56145 .
2963 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2965 * src/maemo/modest-platform.c:
2966 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2967 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2970 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2972 * src/widgets/modest-window.h:
2973 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2974 and modest_window_save_state(), which invokes it.
2976 * src/widgets/modest-window-mgr.h:
2977 * src/widgets/modest-window-mgr.c:
2978 Added modest_window_mgr_save_state_for_all_windows(), which calls
2979 the save_state vfunc on all registered windows, if implemented.
2981 * src/gnome/modest-msg-edit-window.c:
2982 * src/gnome/modest-msg-view-window.c:
2983 * src/maemo/modest-msg-edit-window.c:
2984 * src/maemo/modest-msg-view-window.c:
2985 * src/maemo/modest-main-window.c:
2986 Specify the existing save_settings functions as implementations of
2987 ModestWindow::save_state_func().
2989 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2990 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2991 enabling hibernation, for instance.
2993 We may need to do the same thing for restoring settings.
2996 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2998 * src/widgets/modest-window-mgr.c:
2999 * src/widgets/modest-window-mgr.h:
3000 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3001 modest_window_mgr_get_hibernation_is_prevented().
3003 * src/maemo/modest-main-window.c:
3004 (on_hildon_program_is_topmost_notify): Prevent hibernation
3005 (possible when the application goes to the background in the WM),
3006 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3008 * src/maemo/easysetup/modest-easysetup-wizard.c:
3009 (modest_easysetup_wizard_dialog_init):
3010 * src/maemo/modest-account-settings-dialog.c:
3011 (modest_account_settings_dialog_init):
3012 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3013 (modest_connection_specific_smtp_edit_window_init):
3014 * src/maemo/modest-connection-specific-smtp-window.c:
3015 (modest_connection_specific_smtp_window_init):
3016 * src/maemo/modest-signature-editor-dialog.c:
3017 (modest_signature_editor_dialog_init):
3018 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3019 prevent hibernation while any of these account settings dialogs are open.
3021 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3023 * src/maemo/Makefile.am:
3024 * src/maemo/modest-osso-state-saving.c:
3025 * src/maemo/modest-osso-state-saving.h: Added
3026 modest_osso_load_state() and modest_osso_save_state() though they do
3027 nothing now. They should iterate through all the open windows and load/save
3029 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3030 save state when closing.
3032 * src/maemo/modest-main-window.c:
3033 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3034 Add a notification handler for the HildonProgram::is-topmost property,
3035 so we can allow hibernation when the application goes into the background.
3036 But we still need to detect when the accounts setup windows are open so
3037 we can stop hibernation when they are open.
3038 To do this, I also added the main window the HildonProgram. This might have
3039 other side-effects/benefits, and should maybe be done for other windows.
3041 * src/maemo/modest-osso-autosave-callbacks.h:
3042 * src/maemo/modest-osso-autosave-callbacks.c:
3043 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3044 though it does not do anything yet, and we might never need this to do
3045 anything. For instance, we already save drafts.
3047 * src/maemo/modest-platform.c: (modest_platform_init):
3048 Specify the libosso auto-save callback.
3050 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3052 * src/maemo/modest-platform.c:
3053 (modest_platform_set_update_interval):
3054 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3055 aparently stays valid between application instances, so we can use this
3056 to remove and reset it later. According to a maemo-developers email from
3059 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3061 * configure.ac: Depend on libalarm for Maemo.
3063 * src/dbus_api/modest-dbus-api.h:
3064 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3065 (on_send_receive), (modest_dbus_req_handler):
3066 Handle a SEND_RECEIVE D-Bus method.
3068 * libmodest-dbus-client/libmodest-dbus-client.c:
3069 (libmodest_dbus_client_send_and_receive):
3070 * libmodest-dbus-client/libmodest-dbus-client.h:
3071 Add C convenience functions for calling the new D-Bus method.
3073 * src/modest-platform.h:
3074 * src/gnome/modest-platform.c:
3075 * src/maemo/modest-platform.c:
3076 Added modest_platform_set_update_interval(), which uses the
3077 alarmd API on Maemo.
3078 (modest_platform_init),
3079 Call modest_platform_set_update_interval(), using a hard-coded
3080 interval for now (until the global settings dialog is implemented),
3081 though I am not sure that this makes sense yet.
3083 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3085 * src/dbus_api/modest-dbus-callbacks.c:
3086 (modest_osso_cb_hw_state_handler):
3087 * src/dbus_api/modest-dbus-callbacks.h:
3088 * src/maemo/modest-platform.c: (modest_platform_init):
3089 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3090 in case this has some effect on the ability for Maemo to ping the
3093 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3095 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3096 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3097 warning. It is probably a logic error, but I need to fix the build.
3099 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3101 * src/modest-account-mgr.h:
3102 * src/modest-account-mgr.c:
3103 (modest_account_mgr_account_names): Add a gboolean enabled_only
3104 parameter, so we can get lists of onlt the enabled accounts.
3106 (modest_account_mgr_add_account),,
3107 (modest_account_mgr_account_with_display_name_exists):
3108 * src/maemo/modest-msg-edit-window.c: (get_transports):
3109 * src/modest-account-mgr-helpers.c:
3110 (modest_account_mgr_set_first_account_as_default):
3111 * src/modest-init.c: (init_default_account_maybe):
3112 * src/modest-tny-account-store.c: (get_accounts):
3113 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3114 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3115 * tests/check_account-mgr.c: (START_TEST):
3116 Provide the extra parameter, as appropriate.
3118 * src/widgets/modest-account-view.c: (update_account_view):
3119 Do not show disabled accounts (meaning that there is no way to
3120 enable/disable accounts in the UI (the feature is not in our UI
3121 specification), so we can use this internally only to mark unfinished
3122 or temporary account data.
3124 * src/maemo/easysetup/modest-easysetup-wizard.c:
3125 (create_account): Add boolean enable parameter, so we can specify FALSE
3126 to create the temporary account.
3127 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3128 (on_before_next): When finishing, when there is a temporary account, just
3130 Also, use a timeout to delay the showing of the dialog until gconf is likely
3131 to return correct information, due to a maemo gconf bug that is fixed in
3132 osso 1.1, but not yet in Bora.
3133 However, the dialog stays on screen after it is destroyed.
3135 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3136 for invalid data when cancelling. Use a hildon note instead of a dialog
3137 to complain about invalid data. Do not show the account-saved note if the
3138 account is disabled (a temporary account that will not really be saved for use
3141 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-account-mgr-helpers.h:
3144 * src/modest-account-mgr-helpers.c:
3145 Added modest_account_mgr_unset_default_account(),
3146 Added modest_account_mgr_set_first_account_as_default().
3148 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3149 If it was the default account, unset the default account name.
3151 * src/maemo/modest-account-view-window.c:
3152 (on_delete_button_clicked): If it was the default account,
3153 set the first remaining account as the default instead.
3155 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3156 a NULL account or a NULL default account, to prevent a crash. This should
3157 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3160 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3162 * src/widgets/modest-recpt-editor.c:
3163 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3164 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3165 TODO comment for this. This fixes the build.
3167 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3168 be the best place for it. This will in future update all auto-update accounts,
3169 rather than just the current/default account, when that gconf key exists.
3170 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3171 if there are no accounts, before calling do_send_receive().
3172 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3174 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3175 * src/maemo/modest-main-window-ui.h:
3176 * src/maemo/modest-main-window.c: (on_connection_changed),
3177 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3178 directly, becaue the signal handler does more.
3180 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3182 * src/modest-account-mgr-helpers.c:
3183 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3184 for the case that the account does not exist.
3186 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3187 (equivalent to the modest account name) rather than the tinymail account name
3188 (equivalent to the modest account title - human readable) to get the account data.
3189 Check for null account data to prevent the crash, and add a TODO comment saying that
3190 this needs fixing because it is using the server account name instead of the account name.
3192 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3194 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3195 * src/maemo/modest-account-settings-dialog.c: (show_error),
3197 Use hildon_note_new_information() for informative and error messages,
3198 which seems to be expected for Maemo applications (no documentation that I know of
3199 says this). I am surprised that there is no distinction between info and error
3202 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3204 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3205 it is easy to find where this is used.
3207 * src/maemo/easysetup/modest-easysetup-wizard.c:
3208 (create_page_welcome), (create_page_account_details),
3209 (create_page_user_details), (create_page_complete_easysetup),
3210 (create_page_custom_incoming), (create_page_custom_outgoing),
3211 (create_page_complete_custom):
3212 * src/maemo/modest-account-settings-dialog.c:
3213 (create_page_account_details), (create_page_user_details),
3214 (create_page_incoming), (create_page_outgoing):
3215 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3216 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3217 (modest_connection_specific_smtp_edit_window_init):
3218 * src/maemo/modest-connection-specific-smtp-window.c:
3219 (modest_connection_specific_smtp_window_init):
3220 * src/maemo/modest-signature-editor-dialog.c:
3221 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3222 and scrolling policy as per the Email Application Layout Guide, if I have
3225 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3227 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3228 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3229 which were empty, because these vfuncs have been removed from TnyAccountStore.
3230 This fixes the build.
3232 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3234 * src/maemo/modest-main-window.c:
3235 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3236 showing/hiding it. Added TODO because it probably should not be NULL.
3237 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3238 because unnecessary g_warnings() make degugging difficult.
3240 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/modest-msg-edit-window.c:
3243 (modest_msg_edit_window_select_color),
3244 (modest_msg_edit_window_select_background_color): 2 const corrections and
3245 moving 2 #endifs before closing brackets, to fix the build.
3247 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3249 * src/maemo/easysetup/modest-easysetup-wizard.h:
3250 * src/maemo/easysetup/modest-easysetup-wizard.c:
3251 (modest_easysetup_wizard_dialog_finalize),
3252 (on_button_edit_advanced_settings), (create_page_complete_custom),
3253 (on_response), (create_account):
3254 Implement the Advanced Settings edit button, by saving the account information,
3255 for the Advanded Settings dialog to use directly from gconf, and removing it
3256 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3257 Bug #5533 in the projects.maemo.org bugzilla.
3259 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3261 * src/maemo/modest-msg-view-window.c:
3262 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3263 when opening a message window.
3265 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3267 * src/maemo/easysetup/modest-easysetup-wizard.c:
3268 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3271 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3272 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3273 gconf settings. I probably added more checks than necessary, but that is safer.
3275 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3276 variable to fix the build, but this seems to be used when it is still NULL.
3278 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-platform.h:
3281 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3282 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3283 * src/modest-main.c: Implement this function so we can avoid using
3284 maemo-specific API from cross-platform code.
3286 * src/modest-tny-account-store.c:
3287 (get_smtp_specific_transport_account_for_open_connection):
3288 * src/modest-ui-actions.c: (check_for_connection),
3289 (modest_ui_actions_on_item_not_found):
3290 Use modest_platform_connect_and_wait() and put #idefs around other
3291 maemo-specific code, because only maemo currently has a way to
3292 identify connection names.
3294 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3296 * src/modest-tny-account-store.h:
3297 * src/modest-tny-account-store.c:
3298 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3299 the connection-specific SMTP server settings in the configuration.
3301 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3303 * src/maemo/modest-main-window.c: (on_connection_changed),
3305 * src/modest-main.c: (main), (start_ui), (send_mail):
3306 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3307 that is what is intended.
3309 * src/modest-ui-actions.c: (action_send), (action_receive),
3310 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3311 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3312 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3313 SMTP server is used when it is specified.
3315 (modest_ui_actions_on_send_receive):
3316 Check that a connection is open before proceeding.
3317 Receive and then send, instead of vice-versa, as per the specification.
3319 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3321 * src/modest-mail-operation.c:
3322 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3323 though I guess it should be something other than NULL.
3325 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3327 * src/maemo/easysetup/modest-easysetup-wizard.c:
3328 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3329 combo twice, to avoid an g_warning and to make it visible again.
3330 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3331 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3332 (already intended) dereference when detaching, because we then recreate the menu.
3333 But I am not sure why the warning was happening, and it is possible that this is a memory
3336 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3338 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3339 and uri_parse_mailto() utility functions.
3340 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3342 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3344 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3346 * src/dbus_api/modest-dbus-api.h:
3347 * src/dbus_api/modest-dbus-callbacks.c:
3348 Use an idle callback to execute the modest code in the application's own thread.
3349 Remove the helloworld example method.
3350 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3351 parsed, and the open-message method is not implemented because this is not yet implemented in
3353 * libmodest-dbus-client/libmodest-dbus-client.c:
3354 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3355 (libmodest_dbus_client_open_message):
3356 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3358 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3359 body without crashing.
3361 * tests/dbus_api/Makefile.am:
3362 * tests/dbus_api/test_mail_to.c:
3363 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3365 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3367 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3368 Added file to fix the build. Sorry.
3370 * src/dbus_api/Makefile.am:
3371 * src/dbus_api/modest-dbus-api.h:
3372 * src/dbus_api/modest-dbus-callbacks.h:
3373 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3374 (modest_dbus_req_handler):
3375 Put constants in a separate header so it can be reused by the
3376 client library, without duplication
3378 * libmodest-dbus-client/Makefile.am:
3379 * libmodest-dbus-client/libmodest-dbus-client.c:
3380 (libmodest_dbus_client_call_helloworld),
3381 (libmodfest_dbus_client_send_mail),
3382 (libmodfest_dbus_client_mailto),
3383 (libmodfest_dbus_client_open_message):
3384 * libmodest-dbus-client/libmodest-dbus-client.h:
3385 (Partly) Implement a send_mail D-Bus method.
3387 * tests/dbus_api/Makefile.am:
3388 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3389 the send_email D-Bus method.
3391 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3395 * libmodest-dbus-client/Makefile.am:
3396 * libmodest-dbus-client/libmodest-dbus-client.c:
3397 * libmodest-dbus-client/libmodest-dbus-client.h:
3398 * tests/dbus_api/Makefile.am:
3399 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3400 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3402 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3404 * src/maemo/easysetup/modest-easysetup-wizard.c:
3405 (create_page_account_details):
3406 * src/maemo/modest-account-settings-dialog.c:
3407 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3408 widgets, because this might not be the default in future versions of the Maemo GTK+.
3409 However, I can not not get capitalization to work even in a simple test case.
3411 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3413 * src/maemo/easysetup/modest-easysetup-wizard.c:
3414 (create_page_custom_incoming), (create_page_custom_outgoing):
3415 * src/maemo/modest-account-settings-dialog.c:
3416 (create_page_account_details), (create_page_incoming),
3417 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3418 instead of using gtk_check_button_with_label(), so they are aligned like the other
3419 widgets, as per the UI spec.
3421 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3423 * src/maemo/easysetup/modest-easysetup-wizard.c:
3424 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3425 * src/widgets/modest-validating-entry.c:
3426 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3427 Modest prefix instead of an EasySetup prefix.
3429 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3431 * src/widgets/modest-validating-entry.h:
3432 * src/widgets/modest-validating-entry.c: (on_insert_text),
3433 Added easysetup_validating_entry_set_max_func(), used to set a callback
3434 to call when the max number of characters is reached. GtkEntry has a max-length
3435 already but is silent about it.
3437 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3438 (create_page_account_details), (create_page_user_details),
3440 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3441 (create_page_account_details), (create_page_user_details),
3442 (create_page_outgoing):
3443 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3444 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3445 the UI spec, when the user tries to enter more than the max number of characters.
3447 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/easysetup/modest-easysetup-wizard.c:
3450 (create_page_user_details), (create_page_custom_incoming),
3451 (create_page_custom_outgoing):
3452 * src/maemo/modest-account-settings-dialog.c:
3453 (create_page_user_details), (create_page_incoming),
3454 (create_page_outgoing):
3455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3456 (modest_connection_specific_smtp_edit_window_init):
3457 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3458 not appropriate. Bad Maemo-specific defaults!.
3460 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3463 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3464 (modest_signature_editor_dialog_set_settings):
3465 Disable the label and textview when the checkbox is disabled, and use the
3466 specified (UI spec) default signature text.
3468 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3471 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3473 * src/modest-defs.h:
3474 * src/modest-account-mgr-helpers.h:
3475 * src/modest-account-mgr-helpers.c:
3476 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3478 * src/maemo/Makefile.am:
3479 * src/maemo/modest-signature-editor-dialog.c:
3480 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3483 * src/maemo/modest-account-settings-dialog.h:
3484 * src/maemo/modest-account-settings-dialog.c:
3485 (modest_account_settings_dialog_finalize), (on_button_signature),
3486 (save_configuration): Use the new dialog when the Edit button is pressed, and
3487 save the changes if necessary, as per the UI spec.
3489 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/Makefile.am:
3492 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3493 based on maemo-develoers email from Dirk.
3495 * src/maemo/easysetup/modest-easysetup-wizard.c:
3496 (create_page_welcome), (create_page_account_details),
3497 (create_page_user_details), (create_page_complete_easysetup),
3498 (create_page_custom_incoming), (create_page_custom_outgoing),
3499 (create_page_complete_custom),
3500 (modest_easysetup_wizard_dialog_init):
3501 * src/maemo/modest-account-settings-dialog.c:
3502 (create_page_account_details), (create_page_user_details),
3503 (create_page_incoming), (create_page_outgoing),
3504 (modest_account_settings_dialog_init):
3505 * src/maemo/modest-connection-specific-smtp-window.c:
3506 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3508 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/easysetup/modest-easysetup-wizard.c:
3511 (create_page_account_details), (create_page_custom_outgoing),
3512 (create_page_complete_custom):
3513 * src/maemo/modest-account-settings-dialog.c:
3514 (create_page_user_details), (create_page_incoming),
3515 (create_page_outgoing):
3516 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3517 (modest_connection_specific_smtp_edit_window_init):
3518 Use the correct (UI spec) port min/max, and use horizontal separators,
3521 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3523 * src/maemo/easysetup/modest-easysetup-wizard.c:
3524 (set_default_custom_servernames):
3525 * src/maemo/modest-account-settings-dialog.c:
3526 (create_page_incoming), (on_combo_outgoing_security_changed),
3527 (on_combo_incoming_security_changed), (create_page_outgoing),
3528 (modest_account_settings_dialog_set_account_name),
3529 (save_configuration):
3530 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3531 (on_combo_security_changed),
3532 (modest_connection_specific_smtp_edit_window_init),
3533 (modest_connection_specific_smtp_edit_window_set_connection),
3534 (modest_connection_specific_smtp_edit_window_get_settings):
3535 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3538 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3541 * src/maemo/easysetup/modest-easysetup-wizard.c:
3542 (create_page_custom_outgoing), (create_page_complete_custom):
3543 * src/maemo/modest-account-settings-dialog.c:
3544 (create_page_user_details), (create_page_outgoing):
3545 * src/maemo/modest-account-view-window.c: (button_box_new):
3546 Use changed logical IDs as per the most recent UI spec:
3547 mcen_bd_emailsetup_edit -> mcen_bd_edit
3548 mcen_bd_emailsetup_delete -> mcen_bd_delete
3549 mcen_bd_emailsetup_close -> mcen_bd_close
3551 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3555 * src/dbus_api/Makefile.am:
3556 * src/dbus_api/modest-dbus-callbacks.c:
3557 * src/dbus_api/modest-dbus-callbacks.h:
3558 * src/maemo/modest-platform.c: (modest_platform_init):
3559 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3561 * tests/Makefile.am:
3562 * tests/dbus_api/Makefile.am:
3563 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3565 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3567 * src/maemo/modest-account-settings-dialog.c:
3568 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3569 Removed unnecessary includes.
3571 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3573 * src/maemo/easysetup/modest-easysetup-wizard.c:
3574 * src/maemo/modest-account-settings-dialog.c:
3575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3576 * src/widgets/Makefile.am:
3577 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3578 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3579 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3580 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3581 * src/widgets/modest-secureauth-combo-box.c:
3582 * src/widgets/modest-secureauth-combo-box.h:
3583 * src/widgets/modest-serversecurity-combo-box.c:
3584 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3585 made the GObject names more consistent with the rest of the Modest code.
3587 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3589 * src/maemo/easysetup/Makefile.am:
3590 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3591 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3592 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3593 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3594 * src/maemo/easysetup/modest-easysetup-wizard.c:
3595 * src/maemo/easysetup/modest-validating-entry.c:
3596 * src/maemo/easysetup/modest-validating-entry.h:
3597 * src/maemo/modest-account-settings-dialog.c:
3598 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3599 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3600 widgets/ because they are used outside of easysetup too. After checking in,
3601 svn will allow me to rename them too.
3603 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3605 * src/gnome/modest-msg-edit-window.c:
3606 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3607 linker error, to fix the build on the GNOME platform.
3608 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3609 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3610 ifdefed out to avoid a warning.
3612 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3614 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3615 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3616 some alternative for GTK+ 2.6.
3618 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3620 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3622 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3623 specified for EmailAccountsDialog in UI spec.
3625 * src/maemo/easysetup/modest-easysetup-wizard.c:
3626 * src/maemo/easysetup/modest-easysetup-wizard.h:
3627 * src/maemo/modest-account-settings-dialog.c:
3628 * src/maemo/modest-account-settings-dialog.h:
3629 Reuse a member window widget for the connection-specific SMTP server accounts,
3630 so we can tell it to create/save the accounts only if we actually save changes.
3632 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3633 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3634 (modest_connection_specific_smtp_edit_window_get_settings):
3635 Return a struct instance for temporarily remembering the entered data.
3637 * src/maemo/modest-connection-specific-smtp-window.h:
3638 * src/maemo/modest-connection-specific-smtp-window.c:
3639 (modest_connection_specific_smtp_window_finalize),
3640 (modest_connection_specific_smtp_window_fill_with_connections),
3642 (modest_connection_specific_smtp_window_save_server_accounts),
3643 (update_model_server_names): Do not actually save data until asked,
3644 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3646 (on_selection_changed),
3647 (modest_connection_specific_smtp_window_init): Disable the edit
3648 button when nothing is selected.
3650 * src/modest-account-mgr-helpers.c:
3651 * src/modest-account-mgr-helpers.h:
3652 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3655 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3657 * src/modest-account-mgr-helpers.h:
3658 * src/modest-account-mgr-helpers.c:
3659 (modest_account_mgr_get_unused_account_name),
3660 (modest_account_mgr_get_unused_account_display_name): Added these
3661 utility functions, to avoid code duplication.
3663 * src/maemo/easysetup/modest-easysetup-wizard.c:
3664 (create_page_account_details), (create_account):
3665 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3666 (on_combo_security_changed),
3667 (modest_connection_specific_smtp_edit_window_init),
3668 (modest_connection_specific_smtp_edit_window_save_settings):
3669 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3670 * src/maemo/modest-connection-specific-smtp-window.c:
3671 (modest_connection_specific_smtp_window_finalize),
3672 (modest_connection_specific_smtp_window_fill_with_connections),
3673 (on_button_edit), (modest_connection_specific_smtp_window_init):
3674 * src/maemo/modest-connection-specific-smtp-window.h:
3675 Implementing saving of connection-specific server accounts.
3677 But I need to refactor this so we can save the data for each
3678 possible connection-specific account and only actually create the server accounts
3679 when the easysetup finished, or the OK button is pressed on the account settings
3682 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3684 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3685 (on_combo_security_changed):
3686 (modest_connection_specific_smtp_edit_window_init):
3687 Auto-fill the port number as in the account settings.
3689 (modest_connection_specific_smtp_edit_window_set_connection):
3690 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3691 * src/maemo/modest-connection-specific-smtp-window.c:
3692 (fill_with_connections), (on_button_edit),
3693 (modest_connection_specific_smtp_window_init):
3694 Turn the edit window into a dialog to simplify the code, and
3695 set a WM hint as in a GtkDialog, because only a popup can be on top of
3696 another window in Maemo, and popups usually have no WM decoration.
3698 * src/modest-defs.h:
3699 * src/modest-account-mgr-helpers.c:
3700 (modest_account_mgr_set_connection_specific_smtp),
3701 (modest_account_mgr_remove_connection_specific_smtp),
3702 (modest_account_mgr_get_connection_specific_smtp):
3703 * src/modest-account-mgr-helpers.h: Some functions to write the
3704 connection-specific SMTP server information. Not yet used.
3707 * src/widgets/modest-folder-view.c: (text_cell_data):
3708 Fix a warning about an uninitialized variable.
3709 (on_configuration_key_changed): Put an #ifdef around the use
3710 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3712 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3714 * src/maemo/modest-account-settings-dialog.h:
3715 * src/maemo/modest-account-settings-dialog.c:
3716 Added connect_for_modified() utility function to mark the new modified boolean.
3718 (create_page_account_details), (create_page_user_details),
3719 (create_page_incoming), (create_page_outgoing), (on_response),
3720 (modest_account_settings_dialog_init),
3721 (modest_account_settings_dialog_set_account_name):
3722 Only warn about unsaved changes when there are actually unsaved changes.
3724 * src/modest-account-mgr-helpers.c:
3725 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3726 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3727 to get the data from there in future.
3729 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3731 * src/modest-defs.h:
3733 * src/modest-account-mgr-helpers.h:
3734 * src/modest-account-mgr-helpers.c:
3735 Store the security account setting in a single conf key instead of using
3736 the options list, so that the list is left for just the to-be-removed camel hack,
3737 and because gconf_client_set_list() is failing for some reason.
3739 * src/modest-account-mgr.c:
3740 (modest_account_mgr_add_server_account):
3741 * src/maemo/modest-account-settings-dialog.c:
3742 (modest_account_settings_dialog_set_account_name),
3743 (save_configuration): Use the renamed functions.
3746 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3748 * src/widgets/Makefile.am:
3749 * src/widgets/modest-limit-retrieve-combo-box.c:
3750 * src/widgets/modest-limit-retrieve-combo-box.h:
3751 * src/widgets/modest-retrieve-combo-box.c:
3752 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3753 the account settings dialog.
3755 * src/modest-defs.h:
3756 * src/modest-account-mgr-helpers.h:
3757 * src/modest-account-mgr-helpers.c:
3758 (modest_server_account_get_option_secure_auth),
3759 (modest_server_account_set_option_secure_auth):
3760 * src/modest-account-mgr.c:
3761 (modest_account_mgr_add_server_account):
3762 Use the existing AUTH_MECH conf key for the secure-auth setting,
3763 instead of putting it in the list options, because this was actually used already.
3765 * src/maemo/modest-account-settings-dialog.c:
3766 (create_page_account_details),
3767 (modest_account_settings_dialog_set_account_name),
3768 (save_configuration):
3769 * src/maemo/modest-account-settings-dialog.h:
3770 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3771 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3773 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3776 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3777 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3779 * src/modest-defs.h:
3780 * src/maemo/modest-account-settings-dialog.c:
3781 (create_page_incoming), (on_combo_outgoing_security_changed),
3782 (on_combo_incoming_security_changed), (create_page_outgoing),
3783 (modest_account_settings_dialog_set_account_name),
3784 (save_configuration): Load/Save the port number, and change it when the
3785 security combo changes, to suitable defaults.
3787 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3789 * src/modest-account-mgr.c:
3790 (modest_account_mgr_add_server_account): Set the security and secure-auth
3791 options, and add a comment saying that the other camel-specific options should be
3794 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3796 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3798 * src/modest-tny-account-store.c: (account_list_free),
3799 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3800 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3803 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3805 * src/modest-protocol-info.c:
3806 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3807 is required by our UI spec. Maybe something in our implementation will use this eventually.
3808 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3809 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3810 instead of the previous 0 placeholder.
3812 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3813 secure-auth settings.
3814 * src/modest-account-mgr-helpers.h:
3815 * src/modest-account-mgr-helpers.c:
3816 (modest_server_account_data_get_option_secure_auth),
3817 (modest_server_account_set_option_secure_auth),
3818 (modest_server_account_data_get_option_security),
3819 (modest_server_account_set_option_security): Added this API for getting and setting the security
3820 and secure-auth settings.
3822 * src/maemo/modest-account-settings-dialog.h:
3823 * src/maemo/modest-account-settings-dialog.c:
3824 (modest_account_settings_dialog_finalize), (check_data),
3825 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3826 about changing titles.
3827 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3828 (save_configuration): Save the security and secure-auth settings.
3830 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3831 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3833 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3835 * src/modest-defs.h:
3836 * src/modest-account-mgr.c:
3837 (modest_account_mgr_add_server_account):
3838 Added and used defines for the options key and value pair strings,
3839 that are used so far, though they do not seem to correspond to anything in our
3840 UI specs or ModestProtocol enum.
3842 * src/modest-account-mgr-helpers.h:
3843 * src/modest-account-mgr-helpers.c:
3844 (compare_option_strings_for_name),
3845 (modest_server_account_data_get_option_value),
3846 (modest_server_account_data_get_option_bool),
3847 (modest_account_mgr_get_server_account_option):
3848 Added helper functions for parsing the options GSList.
3850 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3852 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3853 display name is based on the supplied account name.
3854 * src/modest-account-mgr.c:
3855 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3856 with an inefficient, but good-enough, implementation.
3858 * src/maemo/easysetup/modest-easysetup-wizard.c:
3859 (create_page_account_details), (on_before_next), (create_account):
3860 Check for existing display names rather than (non-user-visible) account names, and just
3861 create and set a unique account name at the end.
3863 * src/maemo/modest-account-settings-dialog.c:
3864 (modest_account_settings_dialog_init),
3865 (modest_account_settings_dialog_set_account_name),
3866 (create_page_incoming): Show the display name, instead of the account name.
3867 (on_response): Do some (not all) extra checks, as in the UI spec.
3868 (save_configuration): Save the display name if it was changed.
3870 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3872 * po/en_GB.po: Added needed logical ID and translation.
3873 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3874 (init_view): Made the is-default column clicking work.
3876 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3879 * src/maemo/easysetup/Makefile.am:
3880 * src/maemo/easysetup/modest-easysetup-wizard.c:
3881 (modest_easysetup_wizard_dialog_init):
3882 * src/maemo/easysetup/provider-data-test.keyfile:
3883 * src/maemo/easysetup/provider-data.keyfile:
3884 Moved the provider data file to the new modest-providers-data package and used it from there.
3886 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3888 * src/modest-local-folder-info.c:
3889 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3890 N_() was already used on the static strings, but this just marks it for translation without
3891 using the translation.
3893 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3895 * src/maemo/modest-account-settings-dialog.c:
3896 (create_page_incoming),
3897 (modest_account_settings_dialog_set_account_name):
3898 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3899 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3900 I will do this if nobody else gets there first.
3902 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3904 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3905 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3906 save the security stuff.
3908 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3910 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3911 Set the email address and user fullname, which I now see must be
3914 * src/maemo/modest-account-settings-dialog.h:
3915 * src/maemo/modest-account-settings-dialog.c:
3917 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3918 leave-on-server and authentication.
3919 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3922 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3925 * src/maemo/modest-account-settings-dialog.c:
3926 * src/maemo/modest-account-settings-dialog.h:
3927 Most (but not all) of the widgets are now present as specified by the UI spec.
3928 No changes are yet saved, and some details are not properly shown yet.
3930 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3932 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3934 * src/maemo/Makefile.am:
3935 * src/maemo/modest-account-settings-dialog.c:
3936 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3937 an existing account. Doesn't do much yet.
3939 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3940 Open the accounts settings dialog when Edit is clicked.
3942 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3944 * src/maemo/easysetup/Makefile.am:
3945 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3947 * src/maemo/easysetup/modest-easysetup-wizard.c:
3948 (modest_easysetup_wizard_dialog_init):
3949 Try to get the source directory from the build system,
3950 instead of hard-coding "./" into the source code, when opening our local
3951 copies of the configuration files.
3952 But this still fails when opening the wizard from the Accounts window,
3953 maybe because the working directory seems to change at runtime.
3954 So the wizard will fail the second time unless you copy the files into their
3955 proper locations - see the stdout warnings for the paths.
3957 (create_page_account_details),(on_before_next):
3958 Check for existing non-server accounts instead of server accounts,
3959 so the default account name is useful again, and to prevent trying to
3962 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3963 Show the wizard when New is clicked.
3965 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3966 (init_view): Show the column headers, and show the columns that are
3967 specified in the UI specs. However, something in Maemo's GTK+ prevents
3968 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3969 change the default account. This is despite unsetting the special properties.
3971 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3973 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3974 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3975 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3976 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3977 to make that clearer.
3978 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3980 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3982 * src/maemo/modest-account-view-window.c:
3983 (modest_account_view_window_init),
3984 (modest_account_view_window_new):
3985 Use the same buttons as specified in the
3986 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3987 the existing widgets, which never had a chance of working.
3988 Put the ModestAccountView treeview in a scrolled window.
3989 Do not repeat the initialization in both _init() and _new().
3991 * src/widgets/modest-account-view.c: (update_account_view):
3992 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3993 this widget and window shows no accounts.
3995 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3997 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3999 * src/maemo/easysetup/modest-easysetup-wizard.c:
4000 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4001 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4002 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4005 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4006 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4007 accounts exist yet, as in the UI spec.
4009 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4011 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4013 * src/maemo/Makefile.am:
4014 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4015 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4016 New window for editing connection-specific smtp details.
4017 Not fully implemented.
4019 * src/maemo/modest-connection-specific-smtp-window.c:
4020 (modest_connection_specific_smtp_window_finalize) :
4021 unref the tree model.
4022 (on_button_edit): Show the edit window.
4024 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4026 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4029 * src/maemo/Makefile.am:
4030 * src/maemo/modest-connection-specific-smtp-window.c:
4031 * src/maemo/modest-connection-specific-smtp-window.h:
4032 New window for showing the list of connections, for connection-specific
4033 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4034 * src/maemo/easysetup/modest-easysetup-wizard.c:
4035 (create_page_custom_outgoing): Show the new window when the button is clicked.
4037 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4039 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4040 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4041 * src/maemo/modest-msg-edit-window.c:
4042 (modest_msg_edit_window_insert_image):
4043 * src/modest-conf.c: (modest_conf_key_escape):
4044 * src/modest-mail-operation.c:
4045 (modest_mail_operation_send_new_mail):
4046 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4047 (modest_ui_actions_on_new_account):
4048 * src/widgets/modest-attachment-view.c: (update_filename_request):
4049 * src/widgets/modest-mail-header-view.c:
4050 Corrected warnings that were breaking the build, by commenting out unused variables,
4051 and a function, and by including a header.
4053 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4055 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4056 so we can #ifdef around platform-specific code when necessary.
4057 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4058 to allow this to build for the GNOME platform too.
4060 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4062 * src/maemo/easysetup/modest-easysetup-wizard.c:
4063 Added util_increment_name() and used it in create_page_account_details()
4064 to make sure that the default account name is always a new name.
4066 (modest_easysetup_wizard_dialog_init),
4067 (set_default_custom_servernames): Some minor memory management fixes.
4069 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4073 * src/modest-runtime.c: (init_i18n): Restored the translation
4074 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4075 are defined in config.h, and the translations are installed.
4077 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4078 is defined for translation.
4080 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4082 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4084 * src/maemo/easysetup/modest-easysetup-wizard.c:
4085 (modest_easysetup_wizard_dialog_init):
4086 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4087 Use realistic paths (though they should use $prefix generically) to the
4088 mcc_mapping and provider-data.keyfile files which might work when they
4089 are installed by the future version of the operator-wizard package,
4090 and then fallback to paths in our source code, with an explanatory
4093 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4097 * src/maemo/Makefile.am:
4098 * src/maemo/easysetup/: Added files from the previously-exernal
4099 osso-modest-easysetup.
4100 * src/maemo/modest-main-window-ui.h:
4101 * src/modest-ui-actions.c:
4102 * src/modest-ui-actions.h:
4103 Added modest_ui_actions_on_new_account() as a signal handler for the
4104 New Account menu item. It shows the easysetup wizard.
4105 * po/en_GB.po: Added additional needed logical IDs and translations.