1 2007-07-02 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.h:
4 * src/modest-tny-account.c:
5 (modest_tny_account_new_from_server_account),
6 (modest_tny_account_new_from_server_account_name),
7 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
8 because this must now be set before setting the proto. This is usd in
9 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
10 warning in camel_session_get_service() caused by
11 tny_camel_transport_account_prepare().
13 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
16 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
18 * src/maemo/modest-connection-specific-smtp-edit-window.c:
20 (modest_connection_specific_smtp_edit_window_init):
22 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
25 2007-06-29 Murray Cumming <murrayc@murrayc.com>
27 * src/modest-tny-account.c:
28 (modest_tny_account_new_from_server_account):
29 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
30 now uses to request a connection when it needs one, and which it uses
31 to tell us that something is wrong with the connection, so we can force
32 the accounts offline to prevent further problems.
35 * src/modest-init.c: (init_default_settings):
36 * src/modest-mail-operation.c:
37 (modest_mail_operation_update_account):
38 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
39 This should not be necessary anymore. Do not set the conf key that
40 determined this (it was always TRUE and not set anywhere else).
42 * src/modest-ui-actions.h: Remove unused and unimplemented
43 modest_ui_actions_on_online_toggle_toggled().
45 2007-06-29 Murray Cumming <murrayc@murrayc.com
47 * src/maemo/modest-main-window.c: (connect_signals):
48 Don't connect to delete_event twice. Maybe this was harmless.
50 2007-06-29 Murray Cumming <murrayc@murrayc.com
52 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
53 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
54 Debug output to give some more clue when a folder move is not allowed.
56 2007-06-28 Murray Cumming <murrayc@murrayc.com
58 * src/modest-tny-account.c: (on_modest_file_system_info),
59 (modest_tny_account_get_mmc_account_name):
60 Always call the callback, without checking whether the name has changed.
61 * src/widgets/modest-folder-view.c: (strings_are_equal),
62 (on_model_foreach_set_name), (on_get_mmc_account_name),
63 (text_cell_data): Compare the name here, and use the name from
64 the account rather than from the
65 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
66 if the name was changed after the account was added to the model.
67 That's a tinymail bug but not one that I want to fix now.
69 This finally fixes projects.maemo.org bug NB#59301.
71 2007-06-27 Armin Burgmeier <armin@openismus.com>
73 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
76 2007-06-27 Murray Cumming <murrayc@murrayc.com
78 * src/modest-tny-account.h:
79 * src/modest-tny-account.c:
80 Added modest_tny_account_get_mmc_account_name(), to set the memory
81 card name asynchronously for the given account and then notify.
82 (modest_tny_account_new_for_local_folders): Use this new function instead
83 of using hildon_file_system_info_async_new() directly.
85 * src/widgets/modest-folder-view.c: (text_cell_data):
86 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
87 gtk_tree_model_row_changed() when it is available.
89 This should fix projects.maemo.org bug NB#59301.
91 2007-06-27 Murray Cumming <murrayc@murrayc.com
93 * src/modest-mail-operation.c: (update_account_thread),
94 (get_msgs_full_thread): Fix typo failures in the revert
97 2007-06-27 Murray Cumming <murrayc@murrayc.com
99 * src/maemo/modest-maemo-global-settings-dialog.c:
100 (idle_select_default_focus):
101 * src/modest-mail-operation.c: (idle_notify_progress),
102 (idle_notify_progress_once), (set_last_updated_idle),
103 (update_account_thread), (get_msgs_full_thread):
104 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
105 * src/widgets/modest-header-view.c:
106 (idle_notify_headers_count_changed_destroy),
107 (idle_notify_headers_count_changed):
108 Reverted the additions of gdk_threads_enter/leave(), in case this
109 helps with a startup hang on the device.
111 2007-06-26 Armin Burgmeier <armin@openismus.com>
113 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
114 for supported secure authentication methods from server by
115 gtk_dialog_run(), saving CPU time and a potential race condition.
117 2007-06-26 Armin Burgmeier <armin@openismus.com>
119 * src/maemo/modest-maemo-utils.h:
120 * src/maemo/modest-maemo-utils.c: Added a
121 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
122 only error code to tell the calling code when the user canceled the
125 * src/maemo/modest-account-settings-dialog.h:
126 * src/maemo/modest-account-settings-dialog.c:
127 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
128 message if the retrieval of secure authentication methods was canceled
129 by the user. Perform the check before saving anything to configuration
130 to not end up with half-committed configuration changes, do not show
131 a "Saving to configuration failed" note when authentication methods
132 could not be retrieved.
134 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
137 2007-06-26 Murray Cumming <murrayc@murrayc.com>
139 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
140 Only return the first level of folders under accounts, because the
141 osso-global-search UI spec doesn't want the rest.
142 This fixed projects.maemo.org bug NB#61811.
144 2007-06-26 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-tny-account-store.c:
147 * src/modest-tny-account-store.h:
148 Added modest_tny_account_is_memory_card_account().
149 * src/maemo/modest-main-window.c: (create_details_widget):
150 Show the same information items for the memory card as we show for the
151 local-folders, to fix projects.maemo.org bug NB#59307.
153 2007-06-26 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-tny-account-store.c: (get_password):
156 Added some checks for NULL to maybe prevent crashes, though I think
157 it was Philip's last commit that actually prevented the crash here
158 when creating a first new account.
159 But the new account is still not usable (no messages are shown)
160 until a restart of the application.
162 2007-06-26 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/modest-maemo-global-settings-dialog.c:
165 (idle_select_default_focus):
166 * src/modest-mail-operation.c: (idle_notify_progress),
167 (idle_notify_progress_once), (idle_notify_update_account_queue),
168 (set_last_updated_idle), (update_account_thread),
169 (notify_get_msgs_full), (get_msgs_full_destroyer),
170 (get_msgs_full_thread):
171 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
172 * src/widgets/modest-header-view.c:
173 (idle_notify_headers_count_changed_destroy),
174 (idle_notify_headers_count_changed):
175 Use gdk_threads_enter() and gdk_threads_enter_leave() in
176 all idle handlers, because some other thread could be blocking
177 the GDK lock, so that it can do GUI stuff.
179 2007-06-26 Murray Cumming <murrayc@murrayc.com>
181 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
182 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
183 (on_idle_send_receive), (on_idle_open_default_inbox):
184 * src/maemo/modest-msg-edit-window.c:
185 (modest_msg_edit_window_attach_file_noninteractive):
186 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
187 to prevent a hang. I don't quite understand why these are necessary,
188 beause we should already be in the main loop. I guess something outside
189 of the main loop is taking the lock.
191 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
192 we are really using URIs, and use files that are more likely to exist.
194 2007-06-26 Murray Cumming <murrayc@murrayc.com>
196 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
197 necessary because configure.ac now defines different variables.
199 2007-06-26 Murray Cumming <murrayc@murrayc.com>
201 * libmodest-dbus-client/libmodest-dbus-client.c:
202 * libmodest-dbus-client/libmodest-dbus-client.h:
203 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
204 libmodest_dbus_client_compose_mail() is what things actually use.
206 * src/dbus_api/modest-dbus-api.h:
207 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
208 * tests/dbus_api/Makefile.am:
209 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
212 2007-06-26 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-init.c: (modest_init_local_folders):
215 For memory-card (or other non local-folders) maildir accounts,
216 always create an Archive folder, so that there is somewhere to put
217 messages. This should be less confusing, because the user does not need
218 to guess that the need to create a folder.
220 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
222 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
223 Fixed icon size by using (50, 50) which is the same as defined by
226 2007-06-25 Armin Burgmeier <armin@openismus.com>
228 * src/widgets/modest-window-mgr.c:
230 * configure.ac: Correctly recognize hildon-notify presence and fixed
231 the build without it being installed.
233 2007-06-25 Murray Cumming <murrayc@murrayc.com>
235 * libmodest-dbus-client/libmodest-dbus-client.c:
236 (libmodest_dbus_client_search): Fix the build. Sorry.
237 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
238 (reply_forward_cb): Initialize variables to fix the build.
240 * src/modest-tny-account-store.c:
241 (modest_tny_account_store_get_tny_account_by): Fix the account URI
242 comparison (a silly typo) so that email search results can be opened
243 when there are more than one account.
245 2007-06-25 Murray Cumming <murrayc@murrayc.com>
247 * libmodest-dbus-client/libmodest-dbus-client.c:
248 (libmodest_dbus_client_search),
249 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
250 instead of 1 second, because the search gets folders and messages from
251 the server, which can take a long time. When it times out,
252 osso-global-search will report no results.
254 We need to specify whether we should search only cached information
255 (maybe with a user preference), and the osso-email-search-plugin
256 API should really be improved to allow that option, and to allow results
257 to be delivered asynchronously in batches.
259 2007-06-25 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
262 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
263 GTK_ICON_SIZE_DIALOG is probably the wrong size.
265 2007-06-25 Murray Cumming <murrayc@murrayc.com>
267 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
268 that is an empty string. D-Bus seems to give us these instead of NULL.
270 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
272 * src/dbus_api/modest-dbus-callbacks.c:
273 * src/maemo/easysetup/modest-easysetup-wizard.h:
274 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
275 * src/maemo/modest-connection-specific-smtp-edit-window.c:
276 (modest_connection_specific_smtp_edit_window_init):
277 * src/maemo/modest-maemo-global-settings-dialog.c:
279 * src/maemo/modest-maemo-utils.c:
280 (modest_maemo_utils_setup_images_filechooser):
281 * src/maemo/modest-main-window.c: (create_details_widget):
282 * src/maemo/modest-msg-edit-window.c:
283 (modest_msg_edit_window_attach_file_noninteractive),
284 (modest_msg_edit_window_color_button_change),
285 (modest_msg_edit_window_set_zoom):
286 * src/modest-mail-operation.c: (update_account_thread):
287 * src/modest-tny-account-store.c:
288 * src/modest-tny-account.c:
289 * src/widgets/modest-global-settings-dialog.c:
290 * src/widgets/modest-window.h:
294 2007-06-25 Murray Cumming <murrayc@murrayc.com>
296 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
297 * src/modest-search.c: (modest_search_folder),
298 (modest_search_all_accounts): Actually search only in the specified folder,
299 doing a simple match on the folder ID.
300 * src/modest-search.h: Added a folder field to the ModestSearch struct,
301 and added some documentation.
303 2007-06-22 Armin Burgmeier <armin@openismus.com>
305 * src/maemo/modest-maemo-utils.h:
306 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
307 modest_maemo_utils_get_supported_secure_authentication_methods.
309 * src/maemo/easysetup/modest-easysetup-wizard.c:
310 * src/maemo/modest-account-settings-dialog.c: Show correct error if
311 one occured, not just "Server does not support secure authentication".
313 2007-06-22 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-tny-account-store.c: (get_password):
316 Restored the call to tny_account_set_user() because Philip seems to have
317 stopped this from crashing (by not using the freed string). It still does
318 not work, but now we can test it.
320 2007-06-22 Murray Cumming <murrayc@murrayc.com>
322 * src/maemo/modest-msg-edit-window.c: (init_window):
323 Comment out use of an uninitialzed GtkScrolledWindow variable,
324 to fix the build and stop a crash. Yet again.
326 2007-06-22 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account-store.c: (get_password):
329 Remove the call to tny_account_set_user() because this actually crashes.
330 As mentioned in the last commit, it is known to not work anyway.
332 2007-06-22 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-tny-account-store.c: (get_password):
335 Use tny_account_set_username() to tell tinymail that the username might
336 have changed too. But tinymail ignores this: see projects.maemo.org
338 * src/modest-ui-actions.c:
339 (modest_ui_actions_on_password_requested): Remove the useless attempt to
340 reset the connection when changing the username, and improve the comments.
341 Save the changed username to gconf at least, so it is used when Modest is
344 2007-06-21 Murray Cumming <murrayc@murrayc.com>
346 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
347 Do not use a query, so that we get all folders, including for POP and
348 local-folders. They work as search criteria too.
349 This fixes projects.maemo.org bug NB#57740.
351 2007-06-21 Murray Cumming <murrayc@murrayc.com>
353 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
354 Comment out the use of hildon_notification_set_sound() because it is
355 not declared, to fix the build. Warnings are serious, people.
357 2007-06-21 Armin Burgmeier <armin@openismus.com>
359 * src/maemo/modest-maemo-utils.h:
360 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
361 modest_maemo_utils_get_supported_secure_authentication_methods()
362 to query authentication methods for a specific user. This should fix
363 projects.maemo.org bug NB#61369.
365 * src/maemo/easysetup/modest-easysetup-wizard.c:
366 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
369 2007-06-21 Murray Cumming <murrayc@murrayc.com>
371 * libmodest-dbus-client/libmodest-dbus-client.h:
372 * libmodest-dbus-client/libmodest-dbus-client.c:
373 (modest_dbus_message_iter_get_search_hit),
374 (libmodest_dbus_client_search):
375 Reorganised and commented this.
376 Removed modest_search_hit_free() from the public API because it
379 Added libmodest_dbus_client_get_folders() and
380 modest_folder_result_list_free().
382 * src/dbus_api/modest-dbus-api.h:
383 * src/dbus_api/modest-dbus-callbacks.c:
384 (modest_dbus_req_filter): Commented. Moved most code to
385 on_dbus_method_search() and added on_dbus_method_get_folders().
387 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
388 of the extra D-Bus handler.
390 * tests/dbus_api/Makefile.am:
391 * tests/dbus_api/test_get_folders.c: New test for
392 libmodest_dbus_client_get_folders(). This seems to return an empty list
393 at the moment. That could be the same error that causes the message list
394 to be empty sometimes.
395 This should help with projects.maemo.org bug NB#57740.
397 2007-06-21 Armin Burgmeier <armin@openismus.com>
399 * src/modest-mail-operation.c: Do not call
400 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
401 notify the operation's end after having set the status to CANCELED for
402 the operation queue to listen on. This fixes a deadlock when there
403 were mail operations in the queue during its finalization.
405 * src/modest-singletons.c: Reordered uninitialization of the account
406 manager to happen after the mail operation queue was uninitialized
407 because the mail operation's in the queue might still try to access
408 the account manager (see modest_mail_operation_notify_end()). This
409 fixes a potential crash when terminating the application.
411 2007-06-21 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-search.c:
414 (search_mime_part_and_child_parts): Moved some code here so we
415 can search recursively in child folders.
416 (modest_search_folder): Search in the message as a mime part, instead
417 of just its child mime parts.
418 (read_chunk), (search_mime_part_ogs):
419 Check how many bytes were read, to prevent an endless loop.
420 Searching in message bodies now works. This finishes the fix for
421 projects.maemo.org bug NB#61007.
423 2007-06-20 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
426 Add a g_warning when the item is not a folder.
428 * src/modest-ui-dimming-rules.c:
429 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
430 when selected item is not a folder (for instance, an account), because
431 the UI spec only talks about folders.
432 I am not sure what the UI spec wants, so this might not totally fix
433 projects.maemo.org bug NB#60794.
435 2007-06-20 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
438 (load_from_file): Sort the list. The unsorted list would be more noticeable
439 in non-English locales.
441 * src/maemo/modest-msg-edit-window.c:
442 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
443 warning and fix the build.
445 * src/maemo/modest-progress-bar-widget.c:
446 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
447 avoid a g_warning, and probably to avoid a crash.
449 2007-06-20 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-search.c: (modest_search_folder): Check for a GError
452 when calling tny_folder_get_headers(), to show that this is not the cause
455 2007-06-20 Murray Cumming <murrayc@murrayc.com>
457 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
458 Actually set the body query instead of the subject query.
460 * src/modest-search.c: (search_mime_part_ogs),
461 (search_mime_part_strcmp): Remove extra space from the text/* regex,
462 which would probably cause it to fail if we got this far.
464 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
465 to simplify the code.
466 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
467 be causing search-in-body to fail.
469 2007-06-20 Murray Cumming <murrayc@murrayc.com>
471 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
473 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
474 Better debug message when the folder cannot be found.
475 This should help with fixing projects.maemo.org bug #61287.
476 * src/modest-search.c: (add_hit): Do not leak the furl string.
478 2007-06-20 Murray Cumming <murrayc@murrayc.com>
480 * src/modest-ui-actions.c:
481 (modest_ui_actions_on_folder_selection_changed):
482 Do not special-case TNY_MERGE_FOLDER here, because
483 modest_tny_folder_get_account() already does that. This fixes
484 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
485 shown when the Outbox was selected).
487 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
489 * libmodest-dbus-client/libmodest-dbus-client.c:
490 (_dbus_iter_get_string_or_null): Initialize the string variable in
491 case this helps with Dirk's crash.
493 2007-06-19 Murray Cumming <murrayc@murrayc.com>
495 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
496 though it is not implemented yet (this function is maybe not even used),
497 to avoid breaking ABI in future.
498 * libmodest-dbus-client/libmodest-dbus-client.c:
499 (get_attachments_string): Moved some code into this generic function.
500 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
501 sends email. It is maybe not used.
502 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
503 (on_send_mail): Use attachments.
505 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
506 * src/maemo/modest-msg-edit-window.c:
507 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
508 a filename before using it, to fix projects.maemo.org bug NB#58233.
510 2007-06-19 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
513 Initialize the continue_download variable to fix the build, and probably
514 to fix randome behaviour.
516 2007-06-18 Armin Burgmeier <armin@openismus.com>
518 * src/modest-tny-send-queue.h:
519 * src/modest-tny-send-queue.c: Keep track of the status of messages in
520 the queue so we can later show it in the UI. Replaced
521 modest_tny_send_queue_msg_is_being_sent() by
522 modest_tny_send_queue_get_msg_status().
524 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
526 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
527 gpointer. This probably was not harmful, but just to be sure.
529 2007-06-18 Murray Cumming <murrayc@murrayc.com>
531 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
532 Fix the build, but leave the function broken on Bora, because
533 hildon_uri_action_get_service() does not exist.
534 osso_uri_action_get_service() does not exist either, it seems.
536 2007-06-18 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-tny-account.c:
539 (modest_tny_account_new_from_server_account):
540 Uncommented the url debug output again, because it is useful for
541 debugging, as I said in the comment.
543 2007-06-18 Murray Cumming <murrayc@murrayc.com>
545 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
547 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
548 for Mameo Bora, to fix the build.
550 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
553 Fixed build with hildon < 0.99
555 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
556 Check if the selected account is busy instead of checking all accounts
558 * src/modest-account-mgr-priv.h:
559 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
560 (modest_account_mgr_init), (compare_account_name),
561 (modest_account_mgr_set_account_busy),
562 (modest_account_mgr_account_is_busy):
563 * src/modest-account-mgr.h:
564 Added busy information to the account manager. It possible to
565 set an account to busy or not busy now.
567 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
568 (modest_mail_operation_update_account),
569 (modest_mail_operation_notify_end):
570 Set the account to busy/not busy depending on the operation state.
572 * src/widgets/modest-account-view.c:
573 (modest_account_view_finalize), (get_last_updated_string),
574 (update_account_view), (on_account_busy_changed), (init_view):
575 Show string "Refreshing..." if the account is currently busy.
577 All this fixes projects.maemo.org bug NB#59711
579 2007-06-14 Armin Burgmeier <armin@openismus.com>
581 * src/widgets/modest-attachments-view.h:
582 * src/widgets/modest-attachments-view.c: Added
583 modest_attachments_view_has_attachments() and fixed coordinate
584 transformation in get_att_view_at_coords(). This fixes attachment
587 * src/widgets/modest-msg-view.c: Make use of
588 modest_attachments_view_has_attachments() to decide whether to show
589 attachments in the header.
591 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
593 * src/maemo/modest-connection-specific-smtp-edit-window.c:
594 (on_change), (on_combo_security_changed),
595 (modest_connection_specific_smtp_edit_window_init),
596 (modest_connection_specific_smtp_edit_window_set_connection),
597 (modest_connection_specific_smtp_edit_window_is_dirty):
598 * src/maemo/modest-connection-specific-smtp-edit-window.h:
599 * src/maemo/modest-connection-specific-smtp-window.c:
602 Show an comfirmation dialog for the smpt-edit-window if there are
603 unsaved changes and the user hits cancel.
604 (projects.maemo.org bug NB#60479)
606 2007-06-14 Armin Burgmeier <armin@openismus.com>
608 * src/maemo/easysetup/modest-easysetup-wizard.c:
609 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
610 address" info in banner instead of node, and select all the text as
611 per UI spec. This fixes projects.maemo.org bug NB#60550.
613 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
615 reviewed by: <delete if not using a buddy>
617 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
618 * src/modest-ui-actions.c: (folder_refreshed_cb):
620 2007-06-14 Murray Cumming <murrayc@murrayc.com>
622 * src/widgets/modest-folder-view.c: (filter_row):
623 Explictly filter out the per-account outbox accounts. I don't know why
624 these only sometimes show up, but now they should never show up in the UI.
625 This should fix projects.maemo.org bug NB#60160.
627 2007-06-14 Murray Cumming <murrayc@murrayc.com>
629 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
630 when the toolbar does not exist yet.
631 * src/modest-widget-memory.c: (save_settings_header_view):
632 Added g_warnings() to help us to discover when we are trying to set
633 an empty columns list in gconf.
635 2007-06-14 Murray Cumming <murrayc@murrayc.com>
639 Added modest_init_get_default_header_view_column_ids().
641 * src/modest-widget-memory.c: (restore_settings_header_view):
642 Use the new function to get defaults, if the gconf key is empty,
643 instead of not creating any columns. This seems to fix the
644 empty right-hand pane problems.
646 * src/widgets/modest-header-view.h: Improved documentation.
648 2007-06-13 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
651 Revert the use of the display name as the account name, because this
652 is generally wrong and would break the code that follows.
654 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
656 * src/maemo/easysetup/modest-easysetup-wizard.c:
657 (check_for_supported_auth_methods), (on_before_next),
660 More correct fix for projects.maemo.org bug NB# 58991
661 Do not longer accept AUTH_PASSWORD as secure method and choose
662 correct method when creating the account.
664 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
666 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
667 Fixed projects.maemo.org bug NB# 58991
669 2007-06-13 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-init.c: (modest_init_init_core),
672 (modest_init_local_folders): Fixed compilation errors.
674 2007-06-13 Murray Cumming <murrayc@murrayc.com>
676 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
677 Remove unnecessary lib/include, though it is good in principle when needed.
679 * src/modest-init.c: (modest_init_one_local_folder),
680 (modest_init_local_folders):
681 * src/modest-init.h: Initialize the .modest library for memory cards,
682 instead of just doing nothing for them. This should allow us to create
683 folders there, fixing projects.maemo.org bug NB#59297.
685 2007-06-13 Murray Cumming <murrayc@murrayc.com>
687 * libmodest-dbus-client/libmodest-dbus-client.c:
688 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
689 (libmodest_dbus_client_compose_mail),
690 (libmodest_dbus_client_open_message),
691 (libmodest_dbus_client_send_and_receive),
692 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
694 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
695 (on_idle_open_message), (modest_dbus_req_handler),
696 (search_result_to_message), (modest_dbus_req_filter):
697 * src/modest-search.c: (add_hit), (modest_search_folder),
698 (modest_search_all_accounts): Improved debug messages.
700 * tests/dbus_api/test_open_message.c: (main): Improved comments.
702 * src/modest-tny-account-store.c:
703 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
706 2007-06-13 Murray Cumming <murrayc@murrayc.com>
709 2007-06-12 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-tny-account-store.c: (get_server_accounts):
712 Call modest_tny_local_folders_account_add_merged_outbox_folders()
713 even when there are no accounts, so that the Outbox folder is always
714 visible. This fixes projects.maemo.org bug NB#60158.
716 2007-06-12 Murray Cumming <murrayc@murrayc.com>
718 * src/maemo/modest-main-window.c: (create_details_widget):
719 Use the mcen_va_never logical ID.
721 2007-06-12 Murray Cumming <murrayc@murrayc.com>
723 * src/dbus_api/modest-dbus-api.h:
724 * src/dbus_api/modest-dbus-callbacks.c:
725 (on_idle_open_default_inbox), (on_open_default_inbox),
726 (modest_dbus_req_handler):
727 Added a new OpenDefaultInbox method.
729 * libmodest-dbus-client/libmodest-dbus-client.h:
730 * libmodest-dbus-client/libmodest-dbus-client.c:
731 Added libmodest_dbus_client_open_default_inbox() to call the new
732 dbus method. This should be useful to projects.maemo.org bug NB#57214,
733 though it should maybe be used by a new osso-email-interface function.
735 * tests/dbus_api/Makefile.am:
736 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
739 2007-06-12 Murray Cumming <murrayc@murrayc.com>
741 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
742 NULL, so that the signals get all the keys. This should not actually
743 change any behaviour because we currently update everything when anything
746 2007-06-12 Murray Cumming <murrayc@murrayc.com>
748 * src/widgets/modest-folder-view.c: (text_cell_data),
749 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
750 (find_inbox_iter): If tinymail tells us that the folder is
751 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
752 This causes the inbox to be selected at startup, fixing part of
753 projects.maemo.org bug NB#56305.
755 * src/modest-ui-dimming-rules.c:
756 (modest_ui_dimming_rules_on_tools_smtp_servers):
757 * src/modest-ui-dimming-rules.h: Added a callback function to dim
758 the SMTP servers menu item.
759 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
760 that the SMTP Servers menu item is dimmed when there are no accounts,
761 as a future version of the UI spec will require. This fixes
762 projects.maemo.org bug NB#56305.
764 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
766 * src/maemo/modest-maemo-utils.c:
767 (modest_maemo_utils_get_supported_secure_authentication_methods):
768 Added label to dialog instead of unreadable title
770 * src/maemo/modest-main-window.c: (sync_accounts_cb),
771 (modest_main_window_new):
772 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
775 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
776 * src/modest-account-mgr.h:
777 Added method to avoid code duplication
779 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
780 (modest_ui_actions_on_send_receive):
781 Use modest_account_mgr_has_accounts
783 2007-06-11 Murray Cumming <murrayc@murrayc.com>
785 * src/maemo/easysetup/modest-presets.c:
786 (modest_presets_get_info_server_security): Do not report secure auth
788 * src/modest-protocol-info.c: Use the defines for the gconf key names
789 for secure authentication. This was not working because we were writing
790 Password and reading password, and the check was case sensitive.
791 With this, gmail now works for receiving and sending when created via
794 2007-06-11 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/easysetup/modest-presets.c:
797 (modest_presets_get_info_server_security): Correct the key name for
798 SecureSmtp, because it seems to be case-sensitive.
799 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
800 Do not try to get the 0th notebook page if there are 0 pages, to
803 2007-06-11 Murray Cumming <murrayc@murrayc.com>
805 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
806 Prevent use of the new notification feature for now, because it currently
807 shows one dialog for each new email, which is annoying.
809 2007-06-11 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
812 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
813 when no country was selected, so that we show the global ones.
814 * src/maemo/easysetup/modest-presets.c:
815 (modest_presets_get_providers): Return only the global providers, not
816 all providers when mmc=0 was requested.
818 2007-06-11 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
821 (easysetup_provider_combo_box_fill): Remove debug code that showed the
822 provider ID in the combo.
824 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
825 Do not show the page numbers, because it would be confusing when we add
826 the 2 extra pages for the custom setup, when the user chooses the "Other"
827 provider. This fixes projects.maemo.org bug NB#59028
829 * src/modest-init.c: (modest_init_init_core),
830 (modest_init_local_folders):
832 * src/modest-tny-account.c:
833 (modest_tny_account_new_for_local_folders): Do not create default folders
834 for the memory card. This should fix projects.maemo.org bug NB#59328.
836 2007-06-11 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
839 Free the changed_conf_keys string items. They are already freed in the
840 idle handler if that runs first.
842 2007-06-11 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-ui-actions.c:
845 (modest_ui_actions_on_password_requested): Check that the server name
846 is not NULL, because I just saw a password dialog with (null) as the
849 * src/modest-tny-folder.[h|c]: Added
850 modest_tny_folder_is_memory_card_folder().
851 * src/modest-ui-dimming-rules.c:
852 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
853 menu item for memory cards, as per the UI spec (section 7.4). This should
854 fix projects.maemo.org bug NB#59297.
856 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
858 * src/maemo/modest-main-window.c: (sync_accounts_cb):
859 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
860 is another problem with the code, see Murray's comment at line 772)
862 2007-06-08 Murray Cumming <murrayc@murrayc.com>
864 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
865 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
866 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
867 (load_from_file), (easysetup_country_combo_box_init),
868 (easysetup_country_combo_box_get_active_country_ids),
869 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
870 instead of just one ID, to avoid duplicate country names in the UI.
872 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
873 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
874 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
875 a single ID, avoiding duplicate providers.
876 * src/maemo/easysetup/modest-easysetup-wizard.c:
877 (on_combo_account_country): Adapt to use a list.
879 2007-06-08 Murray Cumming <murrayc@murrayc.com>
881 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
882 keys changed in the last X seconds.
884 * src/modest-account-mgr.h:
885 * src/modest-account-mgr.c: (on_timeout_notify_changes),
886 (on_key_change), (modest_account_mgr_class_init),
887 (modest_account_mgr_init), (modest_account_mgr_finalize):
888 As the keys are changed, save them in a GSList* and signal that GSList*
889 further every X seconds, to batch changes, to allow us to do just one
890 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
891 bug NB#56941 and other (UI-blocking) delays when changing account settings.
893 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
894 changed signal signature.
896 * src/modest-conf.c: (modest_conf_set_list),
897 (modest_conf_on_change): Reenable notification.
899 (modest_conf_maemo_fake_on_change): Comment out the hack that
900 notified immediately instead of asynchronously.
902 * src/widgets/modest-account-view.h:
903 * src/widgets/modest-account-view.c:
904 (update_account_view): Select the previously-selected account ID,
905 if possible. This fixes projects.maemo.org bug NB#56933.
907 (on_account_changed), (on_account_removed),
908 (modest_account_view_select_account):
910 Remove the block/unblock functions
911 because they were not useful.
913 * src/maemo/modest-account-view-window.c:
914 (on_delete_button_clicked), (on_edit_button_clicked),
915 (on_new_button_clicked): Remove the use of the non-working block/unblock.
917 2007-06-08 Murray Cumming <murrayc@murrayc.com>
919 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
920 Improve the error dialog to show Incorrect Account Settings, which seems
921 clearer, and say that the internal error message (to be removed from the
922 dialog later) is often misleading.
923 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
925 * src/modest-tny-account.c:
926 (modest_tny_account_new_from_server_account): Uncomment the printf of the
927 URL because this is so useful for debugging on the device.
929 * src/widgets/modest-serversecurity-combo-box.c:
930 (modest_serversecurity_combo_box_fill): Correct a logical ID.
932 2007-06-08 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-mail-operation.c:
935 (modest_mail_operation_send_new_mail):
936 Added a comment about a nasty but apparently harmless message. Details
937 added to the wiki g_warnings() page.
939 2007-06-08 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
942 (modest_tny_send_queue_class_init):
943 Do not use the priv struct because it is empty, to avoid g_warnings
944 about a non-existant priv struct.
946 * src/modest-tny-account-store.c:
947 (modest_tny_account_store_get_server_account),
948 (modest_tny_account_store_get_transport_account_for_open_connection
949 ): Do not try to get transport server accounts for local folders,
950 because they don't have any. This avoids a g_warning().
952 * src/maemo/modest-main-window.c:
953 (modest_main_window_notify_send_receive_initied),
954 (on_configuration_key_changed):
955 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
957 * src/modest-mail-operation.c:
958 (modest_mail_operation_update_account):
959 * src/modest-tny-account-store.h:
960 * src/modest-tny-account.c:
961 (modest_tny_account_get_special_folder),
962 (modest_tny_account_new_for_local_folders),
963 (modest_tny_account_new_for_per_account_local_outbox_folder):
964 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
965 * src/modest-tny-local-folders-account.c:
966 (add_account_folders_to_merged_folder):
967 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
968 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
969 (modest_ui_actions_on_send):
970 * src/widgets/modest-folder-view.c: (update_model):
971 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
972 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
973 modest_tny_account_store_get_tny_account_by_account() to
974 modest_tny_account_store_get_server_account() to make the code clearer.
976 2007-06-07 Marcus Bauer <marcusb@openismus.com>
978 * src/dbus_api/modest-dbus-api.h:
979 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
980 * src/maemo/modest-msg-edit-window.c:
981 (modest_msg_edit_window_attach_file_noninteractive):
982 added g_warning in case the file to be attached does not exist
983 * tests/dbus_api/test_compose_mail.c: (main):
984 removed obsolete comment, added generic files as test case
986 2007-06-07 Murray Cumming <murrayc@murrayc.com>
988 * src/modest-tny-account-store.c: (get_server_accounts):
989 Create the local folders account only once, not once for each outbox, and
990 not only when there are some outboxes.
992 2007-06-07 Murray Cumming <murrayc@murrayc.com>
994 * src/widgets/modest-folder-view.c: (update_model): Comment out some
995 code that is causing a crash at startup. Sergio says that he is fixing this.
997 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
999 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1000 * src/maemo/modest-account-settings-dialog.c:
1001 (create_page_outgoing),
1002 (modest_account_settings_dialog_set_account_name),
1003 (save_configuration):
1004 - Fixed handling of the "Use secure authentication" toggle to comply with
1005 the ui specification. See also projects.maemo.org bug NB#58400
1007 - Restore the Secure connection setting combo correctly when loading
1010 * src/maemo/modest-maemo-utils.c:
1011 (on_camel_account_get_supported_secure_authentication),
1012 (modest_maemo_utils_get_supported_secure_authentication_methods):
1013 Fixed a crasher if operation is canceled
1015 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1016 (modest_protocol_info_auth_is_secure):
1017 * src/modest-protocol-info.h:
1019 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1020 the sense of the "Use secure authentication" toggle.
1022 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-tny-account-store.h:
1025 * src/modest-tny-account-store.c:
1026 Added modest_tny_account_store_get_local_folders_account().
1028 * src/modest-tny-folder.h:
1029 * src/modest-tny-folder.c:
1030 (modest_tny_folder_get_account):
1031 Added this replacement for tny_folder_get_account() which returns
1032 the local-folders account for TnyMergeFolders, to avoid the
1033 warning about the unimplemented get_account_func() vfunc().
1035 (modest_tny_folder_get_rules),
1036 * src/modest-ui-actions.c:
1037 (modest_ui_actions_on_folder_selection_changed):
1038 * src/modest-mail-operation.c:
1039 (modest_mail_operation_remove_folder),
1040 (modest_mail_operation_xfer_folder),
1041 (modest_mail_operation_rename_folder),
1042 (modest_mail_operation_get_msg),
1043 (modest_mail_operation_get_msgs_full),
1044 (modest_mail_operation_remove_msg),
1045 (modest_mail_operation_xfer_msgs),
1046 (modest_mail_operation_refresh_folder):
1047 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1049 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1052 (modest_server_account_set_security):
1053 * src/modest-defs.h: Add comments explaining that our
1054 UI spec means TLS when it says Normal, so these do not look like errors.
1056 * src/modest-tny-account.c:
1057 (modest_tny_account_new_from_server_account): Use the new tinymail
1058 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1059 for TLS. This should fix projects.maemo.org bug NB#58460.
1061 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/easysetup/modest-easysetup-wizard.c:
1064 (create_account): Correct the position of the gconf sanity check warning.
1065 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1066 of using the g_idle_add() hack, because this does not seem to be necessary
1067 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1068 caused by something other than maemo's gconf.
1069 This fixes projects.maemo.org bug #59022.
1071 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-account-mgr-helpers.c:
1074 (modest_account_mgr_get_default_account): Do not check that the account
1075 exists if there is no default account (NULL), to fix a runtime warning.
1077 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1079 * src/widgets/modest-folder-view.c: (update_model):
1080 Do not unref the treemodel before we have finished with it.
1081 This prevents a valgrind warning and an occasional crash at startup.
1083 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1085 * libmodest-dbus-client/libmodest-dbus-client.h:
1086 added libmodest_dbus_client_compose_mail()
1087 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1089 added functions needed for SendAsMail() functionality
1090 * src/maemo/modest-msg-edit-window.c:
1091 (modest_msg_edit_window_attach_file_noninteractive):
1092 non interactively attaching files to message edit window
1093 * src/widgets/modest-msg-edit-window.h:
1094 * tests/dbus_api/Makefile.am:
1095 added test_compose_mail.c
1096 * tests/dbus_api/test_compose_mail.c: (main):
1098 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1100 * src/modest-account-view.c:
1101 Fixed bug projects.maemo.org bug NB#59307
1103 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1105 * src/maemo/easysetup/modest-easysetup-wizard.c:
1106 (get_serverport_incoming), (on_before_next), (create_account):
1107 * src/maemo/modest-account-settings-dialog.c:
1108 (modest_account_settings_dialog_set_account_name):
1109 * src/maemo/modest-maemo-utils.c:
1110 (on_camel_account_get_supported_secure_authentication_status),
1111 (on_camel_account_get_supported_secure_authentication),
1112 (on_secure_auth_cancel),
1113 (modest_maemo_utils_get_supported_secure_authentication_methods):
1115 Implemented security authentication for settings and easysetup.
1117 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-main-window.c: (create_details_widget):
1120 Show the total size for memory card accounts too, instead of showing
1121 the name again. Fixes bug projects.maemo.org bug NB#59307.
1123 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-tny-simple-folder-store.c:
1127 * src/modest-tny-simple-folder-store.h: Removed.
1129 * src/modest-tny-local-folders-account.h
1130 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1131 for the local-folders maildir, with an extra TnyMergedFolder containing
1132 the folders of the per-account outbox store accounts.
1133 * src/modest-tny-account-store.c: (get_server_accounts):
1134 Add the outboxes to the special local folders account after creating it.
1136 * src/modest-tny-account.c:
1137 (modest_tny_account_new_for_local_folders): Create the derived
1138 account when creating the main local-folders account.
1140 * src/maemo/modest-main-window.c: (create_details_widget),
1141 (modest_main_window_set_contents_style):
1142 Adapted to the use of the derived account instead of the folder store.
1144 * src/modest-ui-actions.c:
1145 (modest_ui_actions_on_folder_selection_changed):
1146 * src/modest-ui-dimming-rules.c:
1147 (modest_ui_dimming_rules_on_new_folder):
1148 * src/widgets/modest-folder-view.c: (text_cell_data),
1149 (icon_cell_data), (filter_row), (update_model),
1150 (get_cmp_rows_type_pos):
1153 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1154 Do not get the priv struct, because no priv struct has been set,
1155 to avoid a runtime warning.
1157 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1158 #ifelse with #else, to fix a warning, to fix the build.
1161 2007-06-05 Christian Kellner <ckellner@openismus.com>
1163 * libmodest-dbus-client/libmodest-dbus-client.c:
1164 Fix small typo in doc (why do you always see them
1165 AFTER committing stuff?)
1168 2007-06-05 Christian Kellner <ckellner@openismus.com>
1170 * libmodest-dbus-client/libmodest-dbus-client.c:
1171 (libmodest_dbus_client_search):
1172 Initialize hit list with NULL. Also set folder list
1173 to "" if NULL was supplied.
1176 2007-06-03 Christian Kellner <ckellner@openismus.com>
1178 * libmodest-dbus-client/libmodest-dbus-client.c:
1179 (modest_search_hit_list_free):
1180 Make it save to call it with NULL.
1182 * src/dbus_api/modest-dbus-callbacks.c:
1183 * src/modest-search.c:
1184 Return full ModestSearchHits as the search result list not TnyHeader
1185 since can't be around withouth the correspoding TnyFolder.
1187 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1189 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1190 Added currently commented code to check for secure auth
1192 * src/maemo/modest-account-settings-dialog.c: (on_response),
1193 (save_configuration), (show_ok):
1194 Fixed projects.maemo.org bugs NB #59248 and #59251
1196 * src/maemo/modest-maemo-utils.c:
1197 (on_camel_account_get_supported_secure_authentication_status),
1198 (on_camel_account_get_supported_secure_authentication),
1199 (modest_maemo_utils_get_supported_secure_authentication_methods):
1200 * src/maemo/modest-maemo-utils.h:
1201 Moved get_supported_secure_authentication() method here to be able
1202 to use it from easysetup wizard.
1204 * src/modest-pair.c: (on_pair_compare_as_string):
1205 Should compare string with first part of pair and not
1206 strcmp pairs which will crash.
1208 * src/modest-protocol-info.c:
1209 (modest_protocol_info_protocol_is_store):
1210 * src/modest-protocol-info.h:
1211 Added modest_protocol_info_get_auth_protocol_name()
1213 2007-06-03 Armin Burgmeier <armin@openismus.com>
1215 * src/modest-mail-operation.c:
1216 (modest_mail_operation_get_msgs_full): Set priv->account also when
1217 only retrieving a single message. This avoids a crash when canceling
1220 (modest_mail_operation_notify_end): Do not explicitely remove the
1221 operation from the queue but only emit the progress_changed signal.
1222 The queue itself listens to that signal to remove the operation when
1223 it is finished. This reduces coupling and removes a potential deadlock
1224 when modest_mail_operation_notify_end() is called from the queue
1225 itself. If that is a problem performance-wise, I would suggest to
1226 implement a status-changed signal or something.
1228 * src/modest-mail-operation-queue.c: Make sure to never call a
1229 function from another file while the queue is locked. This (hopefully)
1230 fixes another deadlock when exiting the application while retrieving
1233 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1235 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1236 Fixed build if libogs is not available
1238 2007-06-03 Christian Kellner <ckellner@openismus.com>
1240 * libmodest-dbus-client/libmodest-dbus-client.h:
1241 * libmodest-dbus-client/libmodest-dbus-client.c:
1242 (libmodest_dbus_client_delete_message):
1243 Implement deletion of messages (Client side).
1245 (modest_search_hit_free),
1246 (modest_search_hit_list_free):
1247 Utility functions to free the result hits.
1249 * src/dbus_api/modest-dbus-api.h:
1250 * src/dbus_api/modest-dbus-callbacks.c:
1251 (on_delete_message),
1252 (modest_dbus_req_handler):
1253 Implement deletion of messages (Server side).
1255 * tests/dbus_api/test_search.c: (main):
1258 * tests/dbus_api/Makefile.am:
1259 * tests/dbus_api/test_delete_message:
1260 Add little test for the message deletion logic
1262 2007-06-03 Armin Burgmeier <armin@openismus.com>
1264 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1265 when the operation queue was not empty. projects.maemo.org bug
1268 2007-06-03 Armin Burgmeier <armin@openismus.com>
1270 * src/widgets/modest-account-view.c
1271 (on_account_default_toggled): Toggle default account column
1272 explicitely instead of waiting for gconf notification (which is
1273 currently ignored). This should fix projects.maemo.org bug NB#56910
1274 for now. It should probably be removed when gconf notifications are
1277 2007-06-03 Christian Kellner <ckellner@openismus.com>
1279 * libmodest-dbus-client/libmodest-dbus-client.c:
1280 Removed debugging spew.
1282 * src/dbus_api/modest-dbus-callbacks.c:
1283 Added debugging info.
1285 * src/modest-search.c:
1286 (modest_search_all_accounts):
1287 Use tny_account_store_get_accounts () on the account store
1288 to get all accounts which is the way to get all accounts.
1290 * tests/dbus_api/test_search.c: (main):
1291 Make it possible to supply the search term on the command line.
1293 2007-06-03 Christian Kellner <ckellner@openismus.com>
1295 * libmodest-dbus-client/libmodest-dbus-client.c:
1296 * libmodest-dbus-client/libmodest-dbus-client.h:
1297 Implement searching for mesages over raw dbus. (Client side)
1299 * src/dbus_api/Makefile.am:
1300 * src/dbus_api/modest-dbus-api.h:
1301 * src/dbus_api/modest-dbus-callbacks.c:
1302 * src/dbus_api/modest-dbus-callbacks.h:
1303 Search framework (Server side). Also implement on_idle_open_message().
1305 * src/maemo/modest-platform.c: (modest_platform_init):
1306 Prepare for raw dbus/osso rpc interaction.
1308 * src/modest-search.h:
1309 Changed minsize from unspecific guint to guint32.
1311 * src/modest-search.c:
1313 Added strange hack which magically made tnymail work.
1315 (modest_search_folder),
1316 (modest_search_account),
1317 (modest_search_all_accounts):
1318 Implement helper functions to search all accounts, specific account
1321 * tests/dbus_api/Makefile.am:
1322 * tests/dbus_api/test_open_message.c:
1323 Read url to open from commandline.
1325 * tests/dbus_api/test_search.c:
1326 Implement small test for dbus search stuff
1328 2007-06-02 Armin Burgmeier <armin@openismus.com>
1330 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1331 include account type and account title. This fixes projects.maemo.org
1334 * src/maemo/modest-account-view-window.c: Set a title for the window.
1336 2007-06-02 Armin Burgmeier <armin@openismus.com>
1338 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1339 incoming and outgoing server name based on email address and server
1340 types as long as the names have not been edited manually. This fixes
1341 projects.maemo.org bug NB#58671.
1343 2007-06-02 Armin Burgmeier <armin@openismus.com>
1345 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1346 server type cannot be changed in future to the incoming details page
1347 when creating an account. This fixes projects.maemo.org bug NB#59029.
1349 2007-06-02 Armin Burgmeier <armin@openismus.com>
1351 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1352 and assigned max width chars so that they wrap instead of being
1353 truncated. Fixes projects.maemo.org bug NB#56126.
1355 2007-06-02 Armin Burgmeier <armin@openismus.com>
1357 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1358 introductory note to the connection specific smtp servers dialog, as
1359 section 8.12 of the email UI specification requires. This fixes
1360 projects.maemo.org bug NB#59212.
1362 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1365 Check for running mail operations, and offer to cancel them, as per the UI
1366 spec. This fixes projects.maemo.org bug NB#59041 .
1367 However, I suspect that tinymail may still use the network connection
1368 in ways that we cannot detect or cancel. But it should at least adapt to
1369 changes fairly well.
1371 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1373 * src/modest-tny-account-store.c: (recreate_all_accounts),
1374 (get_cached_accounts), (get_server_accounts): Do more sensible
1375 ref-counting of the temporarily-cached outbox accounts list. This seems
1376 to fix a crash when entering the password when the password was wrong.
1378 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1380 * src/gnome/modest-main-window.c: (connect_signals):
1381 * src/modest-tny-account-store.c: (get_password),
1382 (modest_tny_account_store_alert): Added comments and clues and
1383 commented-out code about how we currently fail to deal with connection
1384 errors and wrong passwords, and how we should.
1386 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1388 * src/widgets/modest-retrieve-combo-box.c:
1389 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1390 This fixes projects.maemo.org bug NB#58472 .
1392 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/easysetup/modest-easysetup-wizard.c:
1395 (create_page_complete_easysetup):
1396 (create_page_complete_custom): Correct the last commit,
1397 putting the correct sentences in the correct pages.
1399 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1401 * src/maemo/easysetup/modest-easysetup-wizard.c:
1402 (create_page_complete_custom): Show the second sentence of text
1403 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1406 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1409 Set the leave-on-server conf key by default. This fixes
1410 projects.maemo.org bug NB#59258 .
1412 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1414 * src/maemo/modest-account-view-window.c:
1415 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1416 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1419 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/easysetup/modest-easysetup-wizard.c:
1422 (create_caption_new_with_asterisk):
1423 * src/maemo/modest-account-settings-dialog.c:
1424 (create_caption_new_with_asterisk):
1425 Uncomment the code to add the asterisk, because they are no longer in the
1426 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1427 (update_incoming_server_title): Add an asterisk here too.
1429 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/modest-maemo-global-settings-dialog.c:
1432 (current_connection): Check that we are even connected before trying to
1433 get the current connection name, to prevent a warning.
1435 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1436 Change the comments because tny_maemo_conic_device_connect() is now meant to
1438 * src/modest-mail-operation.c:
1439 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1440 make sure we have a connection and fail if we can't connect.
1442 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/modest-main-window.c:
1445 (on_account_store_connecting_finished): Do not try to get the
1446 connection ID if we are not really connected. I am surprised that
1447 this signal handler is called when we are not connected.
1449 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-error.h:
1452 * src/modest-ui-actions.c:
1453 (modest_ui_actions_get_msgs_full_error_handler):
1454 Renamed an enum, added comments, added an enum
1455 for retrieve-limit errors.
1457 * src/modest-mail-operation.c: (foreach_add_item),
1458 (internal_folder_observer_update), (update_account_thread),
1459 (modest_mail_operation_get_msgs_full):
1460 (modest_mail_operation_update_account),
1461 Added comments about how this works, and some code that should
1462 (but does not) check the retrieve-limit. See the TODO comment.
1464 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1467 Initialize help_id to fix the build. Warnings are good.
1469 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1471 * src/widgets/modest-hbox-cell-renderer.c:
1472 (modest_hbox_cell_renderer_append):
1473 * src/widgets/modest-vbox-cell-renderer.c:
1474 (modest_vbox_cell_renderer_append):
1475 Fix the last commit by doing an extra ref.
1477 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1479 * src/widgets/modest-hbox-cell-renderer.c:
1480 (modest_hbox_cell_renderer_append):
1481 * src/widgets/modest-vbox-cell-renderer.c:
1482 (modest_vbox_cell_renderer_append):
1483 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1484 to fix the build with Maemo Bora.
1485 However, there seems to be a remaining crash, probably due to reference
1488 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1490 * src/modest-tny-account.c:
1491 (modest_tny_account_new_for_local_folders):
1492 Use hildon_file_system_info_async_new() to get a better name for
1493 the memory card account, setting it as the account name.
1494 The timing seems to work, but this is probably
1495 not the best place to do this. See the TODO comment.
1496 * src/maemo/modest-main-window.c: (create_details_widget):
1497 * src/widgets/modest-folder-view.c: (text_cell_data):
1498 Use the tny account name instead of hardcoding a name.
1500 2007-05-30 Christian Kellner <ckellner@openismus.com>
1502 * src/modest-search.c: (modest_search):
1503 Correctly set part_search_func even if we have already parsed
1504 the query and thus a valid OgsTextSearcher object.
1506 2007-05-30 Christian Kellner <ckellner@openismus.com>
1509 Search and check for libogs.
1512 Incooparte the ogs build env.
1514 * src/modest-mime-part-search-stream.c:
1515 * src/modest-mime-part-search-stream.h:
1516 Removed since we do the real searching now in modest-search.c.
1518 * src/modest-search.c:
1519 * src/modest-search.h:
1520 Implement support for ogs. We use that if available and requested
1521 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1522 should now handle the corner case when the search term is spread
1523 across multiple reads.
1524 Also the logic in modest_search () was corrected to search all
1525 requested fields until one is found.
1527 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1531 * src/modest-init.h:
1532 * src/modest-init.c: Made modest_init_local_folders() take a
1533 path and be public so we can iniitialize maildir folders on
1536 * src/modest-local-folder-info.h:
1537 * src/modest-local-folder-info.c:
1538 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1540 * src/modest-tny-account.c:
1541 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1542 still means the standard local-folders path on the local volume.
1544 * src/modest-tny-account-store.c:
1545 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1546 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1547 all accounts when that happens.
1548 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1549 this too, so it shows up in the treeview.
1551 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1553 * src/maemo/modest-maemo-global-settings-dialog.c:
1554 (current_connection):
1555 * src/widgets/modest-global-settings-dialog.c:
1556 (current_connection_default):
1557 Use the enum values instead of 0, 1 and -1,
1558 to make the code clearer.
1560 * src/modest-account-mgr-helpers.c:
1561 (modest_account_mgr_get_connection_specific_smtp): Make this code
1564 * src/modest-runtime.h:
1565 * src/modest-runtime.c:
1566 Added modest_runtime_remove_all_send_queues().
1567 * src/maemo/modest-main-window.c:
1568 (on_account_store_connecting_finished): Recreate the send queues,
1569 using the appropriate transport accounts for this new connection.
1570 Some futher adapting might be needed if the old send queues are not
1571 automatically stopped at this point.
1573 * src/modest-tny-account-store.c: (get_server_accounts):
1574 Create the connection-specific transport accounts, so that they can
1575 be found later by their ID.
1577 * src/modest-tny-account.h:
1578 * src/modest-tny-account.c:
1579 Added modest_tny_account_new_from_server_account_name().
1580 modest_tny_account_new_from_server_account(): Do not create the
1581 send queues here, because they will be
1582 recreated anyway when the connection changes for the first time.
1584 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-local-folder-info.h:
1587 * src/modest-local-folder-info.c:
1588 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1589 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1590 tbox_folder): Take a modest account name instead of a server TnyAccount,
1591 so we can have per-modest-account rather than per-transport-account
1593 We must make sure that we change or recreate the exisitng send queues
1594 when the connection changes for connection-specific transport accounts.
1596 * src/modest-tny-account-store.c:
1597 (create_per_account_local_outbox_folders): Create outboxed per modest
1598 account, not per transport account.
1600 * src/modest-tny-account.h:
1601 * src/modest-tny-account.c:
1602 (modest_tny_account_get_special_folder): For outboxes, get the
1603 parent modest account name. The account is ignored for other folders.
1604 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1605 modest account name rather than a server TnyAccount.
1607 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1609 * src/modest-tny-account.c:
1610 (modest_tny_account_new_from_server_account):
1611 Call modest_runtime_get_send_queue() immediately after creating transport
1612 accounts, so that they start trying to send email from the outbox as soon
1613 as possible at startup. This is probably what we want.
1615 * src/modest-mail-operation.c: (update_account_thread):
1616 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1617 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1618 * src/modest-tny-send-queue.h:
1619 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1620 (modest_ui_actions_on_send):
1621 Added comments about how sending works, though it needs some more work.
1623 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-tny-account.c:
1626 (modest_tny_account_get_special_folder): Add TODO because this fails when
1627 the network is busy.
1628 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1629 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1630 Do not try to show this window when there is no active account. The UI
1631 specs does not tell us what to do in this case.
1633 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/Makefile.am:
1638 * src/widgets/Makefile.am: Some dist fixes.
1640 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/modest-connection-specific-smtp-window.c:
1643 (on_button_edit): Make the code clearer, to prevent a double free.
1645 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/modest-account-settings-dialog.c:
1648 (modest_account_settings_dialog_set_account_name),
1649 Check the connection-specific smtp servers checkbox if there are any.
1651 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1652 (modest_connection_specific_smtp_edit_window_init):
1653 Start with a suitable port number.
1655 * src/modest-account-mgr-helpers.h:
1656 * src/modest-account-mgr-helpers.c: Added
1657 modest_account_mgr_get_has_connection_specific_smtp().
1659 (modest_account_mgr_set_connection_specific_smtp),
1660 (modest_account_mgr_remove_connection_specific_smtp),
1661 (modest_account_mgr_get_has_connection_specific_smtp),
1662 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1663 connection-specific smtp server accounts in the account, rather than
1664 the server account conf dir.
1666 This fixes bug projects.maemo.org bug NB#58263 .
1668 * src/modest-tny-account-store.c:
1669 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1670 if there are no server accounts yet, to prevent an infinite loop when there
1671 are no accounts. Document that one must be called before the other.
1673 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1675 * src/modest-account-mgr-helpers.c:
1676 (modest_account_mgr_get_default_account): Make sure that at least
1677 one account is always the default, if there are any enabled accounts.
1678 This is just a sanity check that shouldn't be necessary.
1680 * src/modest-account-mgr-priv.c:
1681 (_modest_account_mgr_account_from_key): Unescape the conf key to
1682 get the real account name. For instance, this is an issue if a space
1683 was in the account name, which can happen because the account name
1684 is generated from the display name.
1685 (_modest_account_mgr_get_account_keyname): Always escape the
1687 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1688 Unescape the conf keys to get the real account names.
1690 For instance, previously the is-default radio button in the accounts
1691 list was not checked for any accounts at first. This fixes that,
1692 and might fix several similar bugs.
1694 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1697 Removed some debug printfs.
1699 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1701 Modest on-disk outbox directories are now here, for instance:
1702 $HOME/.modest/outboxes/<account-id-1>/outbox
1703 $HOME/.modest/outboxes/<account-id-2>/outbox
1705 $HOME/.modest/local-folders/outbox
1706 so we can have a separate outbox for each account.
1707 But they are shown as one outbox in the GtkTreeView, by using a
1708 TnyMergeFolder in a ModestTnySimpleFolderStore.
1711 * src/modest-tny-simple-folder-store.c:
1712 * src/modest-tny-simple-folder-store.h:
1713 Added ModestTnySimpleFolderStore, used to contain folders from
1714 other folder stores, such as other accounts.
1716 * src/modest-tny-outbox-account.h:
1717 * src/modest-tny-outbox-account.c:
1718 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1719 used for the per-account local outbox folders.
1721 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1722 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1723 only use this (internally) now for the non-outbox local folders.
1725 * src/modest-init.h:
1726 * src/modest-init.c: Added modest_init_one_local_folder(), for
1727 setting up the directory structure for each local folder.
1729 * src/modest-local-folder-info.c:
1730 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1731 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1733 * src/modest-local-folder-info.h:
1734 * src/modest-tny-account-store.c: (on_account_removed),
1735 (on_account_changed), (create_per_account_local_outbox_folders),
1736 (get_server_accounts), (modest_tny_account_store_get_accounts),
1737 (modest_tny_account_store_get_tny_account_by_account),
1738 (modest_tny_folder_store_is_virtual_local_folders):
1740 * src/modest-tny-account.h:
1741 * src/modest-tny-account.c:
1742 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1743 to create an on-disk per-account local outbox folder for each
1745 (create_per_account_local_outbox_folders): Create a local outbox folder
1746 for each transport account.
1747 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1748 for all local folders.
1750 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1751 instead of using g_object_get/set() directly. It is clearer.
1753 (modest_tny_folder_store_get_message_count),
1754 (modest_tny_folder_store_get_local_size
1755 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1756 because we now use these with non-acount folder stores.
1758 (modest_tny_account_get_special_folder),
1759 (modest_tny_account_new_from_server_account),
1760 (modest_tny_account_new_from_account):
1761 (recurse_folders): Adjust to the new outbox system.
1763 * src/modest-tny-folder.h:
1764 * src/modest-tny-folder.c:
1765 (modest_tny_folder_is_local_folder),
1766 (modest_tny_folder_get_local_folder_type),
1767 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1769 * src/widgets/modest-main-window.h:
1770 * src/maemo/modest-main-window.c: (create_details_widget),
1771 (modest_main_window_set_contents_style): Show details for any folder store,
1774 (modest_tny_folder_get_rules):
1775 Remove the const. C does not support constness enough for this.
1777 * src/modest-ui-actions.c:
1778 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1779 make all outboxes appear as one, in the usual local-folders tree node.
1781 (set_active_account_from_tny_account),
1782 (modest_ui_actions_on_folder_selection_changed):
1783 * src/widgets/modest-folder-view.c: (text_cell_data),
1784 (icon_cell_data), (filter_row),
1785 (add_account_folders_to_merged_folder),
1786 (add_account_folders_to_simple_folder_store), (),
1787 (get_cmp_rows_type_pos), (cmp_rows),
1788 (modest_folder_view_set_account_id_of_visible_server_account):
1789 Adjust to the new outbox system, using generic folder stores and folders
1790 in the GtkTreeModel.
1792 2007-05-23 Christian Kellner <ckellner@openismus.com>
1794 * src/modest-mail-operation.c:
1795 (modest_mail_operation_update_account):
1796 Use info->max_size instead of unintialized local var [small
1797 build fix]. (Added TODO to review that change since I don't
1800 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1802 * libmodest-dbus-client/libmodest-dbus-client.c:
1803 (libmodest_dbus_client_compose_mail): function added
1804 * src/dbus_api/modest-dbus-api.h:
1805 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1806 (on_compose_mail): Implementation of the SendAsMail functionality
1808 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1810 * src/modest-account-mgr.c:
1811 (modest_account_mgr_add_server_account): Set the secure-connection
1812 conf key for transport accounts as well as store accounts. I don't know
1813 why the if was there. For instance, this makes sure that we use SSL
1814 for the gmail preset from the easysetup wizard.
1816 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1818 * src/gnome/modest-main-window.c:
1819 (on_account_store_connecting_finished), (connect_signals):
1820 * src/maemo/modest-main-window.c:
1821 (on_account_store_connecting_finished), (connect_signals),
1822 (modest_main_window_new):
1823 Handle TnyAccountStore::connecting-finished instead of
1824 TnyDevice::connection-changed, because we cannot actually perform
1825 operations on accounts until TnyAccountStore has itself responded to
1826 the TnyDevice::connection-changed signal. This prevents a GError from
1828 Do not try to update at startup, because we (at least on scratchbox)
1829 already do an update at startup when the device goes online.
1830 This prevents a GError from tinymail.
1831 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1832 Added TODO about stopping simultaneous operations.
1834 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1836 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1837 * src/modest-mail-operation-queue.c:
1838 (modest_mail_operation_queue_remove):
1839 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1840 about where they happened.
1842 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1844 * src/modest-ui-actions.c:
1845 (modest_ui_actions_on_password_requested): Make sure that the remember
1846 output parameter is always TRUE.
1848 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1850 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1851 Show a OK/Cancel dialog if the error is a question, though we still do not
1852 know anything more about what we are asking the user.
1853 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1854 Fix an uninitialized variable (helper). This is a logic error, however.
1856 2007-05-21 Christian Kellner <ckellner@openismus.com>
1858 * src/modest-search.h:
1859 Correct bit shifting in the ModestSearchFlags enum.
1861 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1863 * src/modest-tny-account.c:
1864 (modest_tny_account_new_from_server_account): Do not use the lsub and
1865 check-all hard-coded IMAP options when using POP.
1867 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-tny-account.c:
1870 (modest_tny_account_new_from_server_account):
1871 Use NULL for the secure-auth method for POP when Password auth has been
1872 specified by the user, as we already do for IMAP. "auth=Login" causes
1873 an error from camel or the server.
1875 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-account-settings-dialog.c:
1878 (create_page_account_details),
1879 (modest_account_settings_dialog_set_account_name):
1880 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1881 for the leave-on-server checkbox, rathr than just the checkbox, when
1882 the protocol is not POP.
1884 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1886 * src/widgets/modest-account-view.c:
1887 * src/widgets/modest-account-view.h:
1888 Added modest_account_view_select_account() which will be useful later
1889 to asynchronously re-select the edited account.
1891 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/modest-account-settings-dialog.c:
1894 (modest_account_settings_dialog_set_account_name):
1895 Automatically choose the port numbers based on the secure authentication
1896 methods, if they have not been chosen before.
1897 This fixes projects.maemo.org bug NB#56273 .
1899 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1901 * src/maemo/modest-main-window-ui.h:
1902 * src/modest-ui-actions.c:
1903 * src/modest-ui-actions.h:
1904 Connect the Tools/SMTP Servers menu item to
1905 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1906 SMTP servers dialog, as in the UI specification and saves changes when it
1907 is closed. This fixed projects.maemo.org bug NB#56305 .
1909 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/modest-connection-specific-smtp-window.c:
1912 (modest_connection_specific_smtp_window_init):
1913 Use gtk_window_set_default_size() to make this window big enough, so
1914 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1916 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1918 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1919 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1920 (modest_connection_specific_smtp_edit_window_init),
1921 Do not try to connect to a combobox signal before the combobox exists.
1922 This fixes the cras in projects.maemo.org bug NB#56288 .
1923 (modest_connection_specific_smtp_edit_window_get_settings):
1924 Remove the server_account_name parameter which was being checked for NULL
1925 though it was not used.
1927 * src/maemo/modest-connection-specific-smtp-window.c:
1928 (modest_connection_specific_smtp_window_fill_with_connections),
1929 (on_button_edit), (modest_connection_specific_smtp_window_init):
1930 Correct the number of treemodel columns to prevent a warning.
1931 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1932 libconic does not work.
1934 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-tny-account.c:
1937 (modest_tny_account_new_from_server_account):
1938 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1939 SMTP when "None" was chosen by the user. However, with my SMTP server that
1940 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1943 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1946 to explain the memory management issue with the ID in the ModestPair.
1948 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1949 (add_sending_page), (modest_account_assistant_finalize):
1950 * src/gnome/modest-gnome-global-settings-dialog.c:
1951 (create_updating_page), (create_composing_page):
1952 * src/gnome/modest-msg-edit-window.c: (get_transports),
1953 (init_window), (modest_msg_edit_window_finalize),
1954 (modest_msg_edit_window_get_msg_data):
1955 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1956 * src/gnome/modest-transport-widget.c:
1957 (modest_transport_widget_finalize), (smtp_configuration):
1958 * src/maemo/modest-maemo-global-settings-dialog.c:
1959 (create_updating_page), (create_composing_page):
1960 * src/maemo/modest-msg-edit-window.c: (get_transports),
1961 (init_window), (modest_msg_edit_window_finalize),
1962 (modest_msg_edit_window_get_msg_data),
1963 (modest_msg_edit_window_free_msg_data):
1964 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1965 (modest_store_widget_finalize):
1966 * src/maemo/modest-transport-widget.c:
1967 (modest_transport_widget_finalize), (smtp_configuration):
1968 * src/modest-main.c: (send_mail):
1969 * src/widgets/modest-combo-box.h:
1970 * src/widgets/modest-global-settings-dialog-priv.h:
1971 * src/widgets/modest-global-settings-dialog.c:
1972 (modest_global_settings_dialog_finalize):
1973 * src/widgets/modest-msg-edit-window.h:
1974 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1975 as long as the combo box, to prevent use of freed memory for the ID.
1977 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1979 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1980 get_accounts(), to make this clearer. Do not check for the enabled gconf
1981 key, because we do not use this for server accounts (at least, not yet).
1982 This allows us to send email again.
1984 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1986 * src/maemo/modest-platform.c:
1987 (on_modest_conf_update_interval_changed), (modest_platform_init):
1988 Only respond to this particular key change. All these strcmp()s cannot be
1991 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1993 * src/maemo/modest-maemo-global-settings-dialog.c:
1994 (current_connection): Prevent a crash in scratchbox when
1995 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1996 * src/maemo/modest-platform.c:
1997 (on_modest_conf_update_interval_changed), (modest_platform_init):
1998 Get the update interval from gconf and reset it when the gconf key changes.
2000 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2002 * src/modest-protocol-info.c:
2003 * src/modest-protocol-info.h: Adde enum-specific get functions,
2004 instead of using a ModestProtocolType enum parameter.
2006 * src/gnome/modest-account-assistant.c:
2007 * src/gnome/modest-store-widget.c:
2008 * src/gnome/modest-store-widget.h:
2009 * src/gnome/modest-transport-widget.c:
2010 * src/gnome/modest-transport-widget.h:
2011 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2012 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2013 * src/maemo/easysetup/modest-easysetup-wizard.c:
2014 * src/maemo/modest-account-settings-dialog.c:
2015 * src/maemo/modest-account-settings-dialog.h:
2016 * src/maemo/modest-store-widget.c:
2017 * src/maemo/modest-store-widget.h:
2018 * src/maemo/modest-transport-widget.c:
2019 * src/maemo/modest-transport-widget.h:
2020 * src/modest-account-mgr-helpers.c:
2021 * src/modest-account-mgr-helpers.h:
2022 * src/modest-account-mgr.c:
2023 * src/modest-account-mgr.h:
2024 * src/modest-tny-account.c:
2025 * src/modest-tny-folder.c:
2026 * src/widgets/modest-account-view.c:
2027 * src/widgets/modest-retrieve-combo-box.c:
2028 * src/widgets/modest-retrieve-combo-box.h:
2029 * src/widgets/modest-secureauth-combo-box.c:
2030 * src/widgets/modest-serversecurity-combo-box.c:
2031 * src/widgets/modest-serversecurity-combo-box.h:
2032 * tests/check_account-mgr.c:
2033 Use the specific functions, and use the re-renamed enum values for GNOME too.
2035 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2037 * src/modest-pair.h:
2038 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2039 so we can get the second based on the first.
2041 * src/maemo/modest-account-settings-dialog.h:
2042 * src/maemo/modest-account-settings-dialog.c:
2043 Added get_supported_secure_authentication_methods(), though it is mostly
2044 commented-out for now until the necessary API is committed to tinymail.
2045 (modest_account_settings_dialog_set_account_name),
2046 (save_configuration): Request the supported authentication methods from the
2047 server, so we can choose a working method.
2049 * src/modest-tny-account-store.h:
2050 * src/modest-tny-account-store.c:
2051 (modest_tny_account_store_get_session): Rename from
2052 tny_account_store_get_session().
2054 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-protocol-info.h: Split the ModestProtocol enum
2057 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2058 There was no need to have these unrelated values in one enum.
2060 * src/: many files: Adapted to changed enum. This makes the code a bit
2061 clearer, and the compiler could catch some errors.
2063 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2066 Show the detailed internal camel error message when an error happens
2067 during the configuration, so that our testers can give us more clues.
2068 For instance, in projects.maemo.org bug NB#56910 .
2070 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2072 * src/modest-tny-account.c:
2073 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2074 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2076 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2079 * src/maemo/modest-account-settings-dialog.c:
2080 (modest_account_settings_dialog_set_account_name),
2081 (save_configuration): For the incoming secure authentication checkbox,
2082 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2083 the UI specification. PLAIN does not seem to be supported for most IMAP
2084 servers anyway, and I am not sure what it would mean.
2085 However, we probably need to discover which of the secure-authentication
2086 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2087 * src/modest-account-mgr-helpers.c:
2088 (modest_account_mgr_get_server_account_data):
2090 * src/modest-tny-account.c:
2091 (modest_tny_account_new_from_server_account):
2092 Use tny_account_set_mech() to set secure-authentication methods,
2093 with some special-casing for IMAP, based on my observations of how
2096 * src/modest-account-mgr-helpers.h:
2097 * src/modest-account-mgr.c:
2098 * src/modest-defs.h: Comment that the URI is only used for local folders.
2100 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2102 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2103 parameter const, just to be neat.
2104 * src/modest-text-utils.c: (modest_text_utils_inline):
2105 End g_strconcat() with NULL, as its documentation says. This is almost
2106 certainly the cause of my crash at startup on the device. Interestingly,
2107 valgrind doesn't tell us about these errors.
2109 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2111 * scripts/build-packages: Added more precise comments about how to use
2112 this script, though I still get this error:
2113 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2114 error building tinymail
2116 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2118 * src/maemo/modest-main-window.c: (on_account_update):
2119 Very slight cleanup, hoping to make it simpler to discover what causes
2120 a crash here sometimes.
2122 * src/modest-tny-account.c:
2123 (modest_tny_account_new_from_server_account): Set the port. Added
2124 comments about the options and a TODO comment because I need to find out
2125 how to specify the secure authentication method.
2127 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2129 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2130 changed CFlags paths form modest to libmodest
2132 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-account-mgr-helpers.c:
2135 (modest_account_mgr_get_server_account_data),
2136 (modest_account_mgr_free_server_account_data):
2137 * src/modest-account-mgr-helpers.h:
2138 * src/modest-account-mgr.c:
2139 (modest_account_mgr_add_server_account):
2140 * src/modest-defs.h:
2141 * src/modest-tny-account.c:
2142 (modest_tny_account_new_from_server_account):
2143 Determine the options for tny_camel_account_add_option() here,
2144 based on the settings, rather than storing them directly in gconf.
2146 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2149 Show a more friendly error dialog now that we expect (from the tinymail
2150 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2152 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/modest-main-window.c: (on_account_update): Check that
2155 account_name is not NULL, to prevent a crash at startup that I am
2156 seeing on the N800. I do wonder why it is NULL.
2158 * src/maemo/easysetup/modest-easysetup-wizard.c:
2159 (create_page_user_details):
2160 * src/maemo/modest-account-settings-dialog.c:
2161 (create_page_user_details), (create_page_outgoing):
2162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2163 (modest_connection_specific_smtp_edit_window_init):
2164 * src/modest-ui-actions.c:
2165 (modest_ui_actions_on_password_requested):
2166 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2167 might do something useful with the on-screen keyboard.
2169 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2171 * src/maemo/modest-main-window.c: (on_account_update):
2172 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2173 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2175 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-tny-account-store.c: (on_account_changed):
2178 Correct the signature of this signal handler.
2180 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2182 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2183 Show a HildonNote instead of a GtkDialog for Maemo.
2185 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2187 * src/widgets/modest-account-view.h:
2188 * src/widgets/modest-account-view.c: (on_account_changed),
2189 (on_account_removed). Added a boolean flag, set/unset by
2190 modest_account_view_block_conf_updates(),
2191 modest_account_view_unblock_conf_updates() to prevent unnecessary
2192 updates, but this is not very useful because the gconf notifications are
2193 so delays (maybe only on Maemo Bora).
2194 So auto-updating is turned off, and these functions do an explicit
2195 update when necessary.
2196 However, something else is still doing too much work when adding/removing
2197 accounts, probably in another part of the application.
2199 * src/maemo/modest-account-view-window.c:
2200 (on_delete_button_clicked), (on_edit_button_clicked),
2201 (on_new_button_clicked): Use the new functions.
2203 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2205 * src/modest-account-mgr-helpers.c:
2206 (modest_account_mgr_set_first_account_as_default):
2207 Sort the list of names alphabetically-by-title, so we choose the first one
2209 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2210 alphabetically by the title.
2212 This fixes projects.maemo.org bug NB#56418 .
2214 * src/modest-account-mgr-priv.c:
2215 (_modest_account_mgr_account_from_key):
2216 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2217 avoid a valgrind error, and possible random behaviour.
2219 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2222 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2223 tinymail documentation to say that this can be expected.
2224 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2225 pretty, and should not happen, but I would prefer to know when it does.
2227 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2229 * configure.ac: When using the older hildon version, probably on Bora,
2230 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2232 * src/widgets/modest-attachment-view.c:
2233 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2236 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2238 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2239 Implemented the prototype. Can be tested with
2240 tests/dbus_api/test_open_message:
2242 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2244 * src/modest-tny-account-store.c:
2245 (modest_tny_account_store_instance_init), (get_password):
2246 * src/modest-ui-actions.c:
2247 (modest_ui_actions_on_password_requested):
2248 Do not store the password in gconf, because this function is called
2249 for non-remembered passwords. Actually use the cached (in the hash map)
2250 password instead of releasing it.
2251 The password will now not be remembered if it is asked via the protected
2252 password dialog, as per the UI spec.
2254 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2256 * src/modest-defs.h:
2257 * src/modest-account-mgr-helpers.h:
2258 * src/modest-account-mgr-helpers.c:
2259 Added modest_server_account_get_username_has_succeeded(),
2260 modest_server_account_set_username_has_succeeded().
2261 (modest_server_account_set_username),
2262 Reset the has-succeeded flag if the username changes.
2264 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2265 * src/maemo/modest-connection-specific-smtp-window.c:
2266 (modest_connection_specific_smtp_window_save_server_accounts):
2267 Use modest_server_account_set_username() instead of using
2268 modest_conf_set_string() directly, so that the has-succeeded flag is always
2271 * src/modest-ui-actions.c:
2272 (modest_ui_actions_on_password_requested): Dim the username entry if
2273 the username has ever worked, as per the UI spec.
2275 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-tny-account-store.c: (get_password):
2278 * src/modest-ui-actions.c:
2279 (modest_ui_actions_on_password_requested):
2280 Allow the username to be changed too, though there is more work to
2281 be done on exactly how this behaves.
2283 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2285 * src/modest-account-mgr-helpers.h:
2286 * src/modest-account-mgr-helpers.c:
2287 Added modest_account_mgr_get_display_name(),
2288 modest_server_account_get_username(),
2289 modest_server_account_set_username(),
2290 modest_server_account_set_password(),
2291 modest_server_account_get_hostname() functions so we do not need to
2292 use the conf API directly.
2294 * src/maemo/modest-main-window.c: (connect_signals):
2295 Actually connect ot the ModestAccountStore::request-password signal,
2296 so that we show the dialog when the password is requested by Tinymail,
2297 for isntance if it is empty.
2299 * src/modest-marshal.list:
2300 * src/modest-tny-account-store.c:
2301 (modest_tny_account_store_class_init), (get_password),
2302 (modest_tny_account_store_alert):
2303 * src/modest-tny-account-store.h:
2304 * src/modest-ui-actions.h:
2305 * src/modest-ui-actions.c:
2306 (modest_ui_actions_on_password_requested):
2307 Change the signal parameters, so it is obvious that we are providing
2308 the non human-readable server name, and receiving both the username
2309 and password, though changing of the username is not yet implemented.
2310 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2311 for the GNOME version.
2313 This should fix the projects.maemo.org bug NB#56209, though it does not
2314 work on Bora, because the gconf_client_get() for the password fails
2315 immediately after we save it with gconf_client_set().
2317 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2320 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2321 caused an undefined symbol error:
2322 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2324 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2326 * src/modest-tny-account-store.c:
2327 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2328 using a GError instead of a string message, so we can translate it in
2331 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2333 * src/maemo/modest-address-book.c:
2334 (modest_address_book_check_names):
2335 * src/maemo/modest-msg-view-window.c:
2336 (modest_msg_view_window_clipboard_owner_change):
2337 * src/modest-init.c: (modest_init_init_ui):
2338 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2339 (update_folders_cb), (modest_mail_operation_update_account):
2340 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2341 (modest_ui_actions_on_msg_attachment_clicked),
2342 (modest_ui_actions_on_msg_recpt_activated):
2343 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2344 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2345 (modest_msg_view_search_next):
2346 * src/widgets/modest-recpt-editor.c:
2347 (modest_recpt_editor_on_button_release_event),
2348 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2349 g_message(). At this point we should only be seeing interesting errors on
2350 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2352 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2354 (modest_wizard_dialog_force_title_update):
2355 * src/maemo/easysetup/modest-wizard-dialog.h:
2356 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2357 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2358 can update the title when appropriate. Otherwise the title is wrong if the
2359 pages are added after adding the notebook to the dialog.
2360 This must be a problem in HildonWizardDialog too.
2361 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2363 * src/maemo/easysetup/modest-easysetup-wizard.c:
2364 (create_subsequent_customsetup_pages),
2365 (create_subsequent_easysetup_pages):
2366 Call modest_wizard_dialog_force_title_update() so that the title is
2367 correct even with GTK+ < 2.10.
2368 This fixes projects.maemo.org bug NB#56145 .
2370 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2372 * src/maemo/modest-platform.c:
2373 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2374 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2377 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2379 * src/widgets/modest-window.h:
2380 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2381 and modest_window_save_state(), which invokes it.
2383 * src/widgets/modest-window-mgr.h:
2384 * src/widgets/modest-window-mgr.c:
2385 Added modest_window_mgr_save_state_for_all_windows(), which calls
2386 the save_state vfunc on all registered windows, if implemented.
2388 * src/gnome/modest-msg-edit-window.c:
2389 * src/gnome/modest-msg-view-window.c:
2390 * src/maemo/modest-msg-edit-window.c:
2391 * src/maemo/modest-msg-view-window.c:
2392 * src/maemo/modest-main-window.c:
2393 Specify the existing save_settings functions as implementations of
2394 ModestWindow::save_state_func().
2396 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2397 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2398 enabling hibernation, for instance.
2400 We may need to do the same thing for restoring settings.
2403 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2405 * src/widgets/modest-window-mgr.c:
2406 * src/widgets/modest-window-mgr.h:
2407 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2408 modest_window_mgr_get_hibernation_is_prevented().
2410 * src/maemo/modest-main-window.c:
2411 (on_hildon_program_is_topmost_notify): Prevent hibernation
2412 (possible when the application goes to the background in the WM),
2413 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2415 * src/maemo/easysetup/modest-easysetup-wizard.c:
2416 (modest_easysetup_wizard_dialog_init):
2417 * src/maemo/modest-account-settings-dialog.c:
2418 (modest_account_settings_dialog_init):
2419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2420 (modest_connection_specific_smtp_edit_window_init):
2421 * src/maemo/modest-connection-specific-smtp-window.c:
2422 (modest_connection_specific_smtp_window_init):
2423 * src/maemo/modest-signature-editor-dialog.c:
2424 (modest_signature_editor_dialog_init):
2425 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2426 prevent hibernation while any of these account settings dialogs are open.
2428 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2430 * src/maemo/Makefile.am:
2431 * src/maemo/modest-osso-state-saving.c:
2432 * src/maemo/modest-osso-state-saving.h: Added
2433 modest_osso_load_state() and modest_osso_save_state() though they do
2434 nothing now. They should iterate through all the open windows and load/save
2436 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2437 save state when closing.
2439 * src/maemo/modest-main-window.c:
2440 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2441 Add a notification handler for the HildonProgram::is-topmost property,
2442 so we can allow hibernation when the application goes into the background.
2443 But we still need to detect when the accounts setup windows are open so
2444 we can stop hibernation when they are open.
2445 To do this, I also added the main window the HildonProgram. This might have
2446 other side-effects/benefits, and should maybe be done for other windows.
2448 * src/maemo/modest-osso-autosave-callbacks.h:
2449 * src/maemo/modest-osso-autosave-callbacks.c:
2450 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2451 though it does not do anything yet, and we might never need this to do
2452 anything. For instance, we already save drafts.
2454 * src/maemo/modest-platform.c: (modest_platform_init):
2455 Specify the libosso auto-save callback.
2457 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2459 * src/maemo/modest-platform.c:
2460 (modest_platform_set_update_interval):
2461 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2462 aparently stays valid between application instances, so we can use this
2463 to remove and reset it later. According to a maemo-developers email from
2466 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2468 * configure.ac: Depend on libalarm for Maemo.
2470 * src/dbus_api/modest-dbus-api.h:
2471 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2472 (on_send_receive), (modest_dbus_req_handler):
2473 Handle a SEND_RECEIVE D-Bus method.
2475 * libmodest-dbus-client/libmodest-dbus-client.c:
2476 (libmodest_dbus_client_send_and_receive):
2477 * libmodest-dbus-client/libmodest-dbus-client.h:
2478 Add C convenience functions for calling the new D-Bus method.
2480 * src/modest-platform.h:
2481 * src/gnome/modest-platform.c:
2482 * src/maemo/modest-platform.c:
2483 Added modest_platform_set_update_interval(), which uses the
2484 alarmd API on Maemo.
2485 (modest_platform_init),
2486 Call modest_platform_set_update_interval(), using a hard-coded
2487 interval for now (until the global settings dialog is implemented),
2488 though I am not sure that this makes sense yet.
2490 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2492 * src/dbus_api/modest-dbus-callbacks.c:
2493 (modest_osso_cb_hw_state_handler):
2494 * src/dbus_api/modest-dbus-callbacks.h:
2495 * src/maemo/modest-platform.c: (modest_platform_init):
2496 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2497 in case this has some effect on the ability for Maemo to ping the
2500 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2503 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2504 warning. It is probably a logic error, but I need to fix the build.
2506 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2508 * src/modest-account-mgr.h:
2509 * src/modest-account-mgr.c:
2510 (modest_account_mgr_account_names): Add a gboolean enabled_only
2511 parameter, so we can get lists of onlt the enabled accounts.
2513 (modest_account_mgr_add_account),,
2514 (modest_account_mgr_account_with_display_name_exists):
2515 * src/maemo/modest-msg-edit-window.c: (get_transports):
2516 * src/modest-account-mgr-helpers.c:
2517 (modest_account_mgr_set_first_account_as_default):
2518 * src/modest-init.c: (init_default_account_maybe):
2519 * src/modest-tny-account-store.c: (get_accounts):
2520 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2521 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2522 * tests/check_account-mgr.c: (START_TEST):
2523 Provide the extra parameter, as appropriate.
2525 * src/widgets/modest-account-view.c: (update_account_view):
2526 Do not show disabled accounts (meaning that there is no way to
2527 enable/disable accounts in the UI (the feature is not in our UI
2528 specification), so we can use this internally only to mark unfinished
2529 or temporary account data.
2531 * src/maemo/easysetup/modest-easysetup-wizard.c:
2532 (create_account): Add boolean enable parameter, so we can specify FALSE
2533 to create the temporary account.
2534 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2535 (on_before_next): When finishing, when there is a temporary account, just
2537 Also, use a timeout to delay the showing of the dialog until gconf is likely
2538 to return correct information, due to a maemo gconf bug that is fixed in
2539 osso 1.1, but not yet in Bora.
2540 However, the dialog stays on screen after it is destroyed.
2542 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2543 for invalid data when cancelling. Use a hildon note instead of a dialog
2544 to complain about invalid data. Do not show the account-saved note if the
2545 account is disabled (a temporary account that will not really be saved for use
2548 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2550 * src/modest-account-mgr-helpers.h:
2551 * src/modest-account-mgr-helpers.c:
2552 Added modest_account_mgr_unset_default_account(),
2553 Added modest_account_mgr_set_first_account_as_default().
2555 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2556 If it was the default account, unset the default account name.
2558 * src/maemo/modest-account-view-window.c:
2559 (on_delete_button_clicked): If it was the default account,
2560 set the first remaining account as the default instead.
2562 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2563 a NULL account or a NULL default account, to prevent a crash. This should
2564 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2567 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2569 * src/widgets/modest-recpt-editor.c:
2570 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2571 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2572 TODO comment for this. This fixes the build.
2574 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2575 be the best place for it. This will in future update all auto-update accounts,
2576 rather than just the current/default account, when that gconf key exists.
2577 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2578 if there are no accounts, before calling do_send_receive().
2579 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2581 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2582 * src/maemo/modest-main-window-ui.h:
2583 * src/maemo/modest-main-window.c: (on_connection_changed),
2584 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2585 directly, becaue the signal handler does more.
2587 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2589 * src/modest-account-mgr-helpers.c:
2590 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2591 for the case that the account does not exist.
2593 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2594 (equivalent to the modest account name) rather than the tinymail account name
2595 (equivalent to the modest account title - human readable) to get the account data.
2596 Check for null account data to prevent the crash, and add a TODO comment saying that
2597 this needs fixing because it is using the server account name instead of the account name.
2599 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2601 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2602 * src/maemo/modest-account-settings-dialog.c: (show_error),
2604 Use hildon_note_new_information() for informative and error messages,
2605 which seems to be expected for Maemo applications (no documentation that I know of
2606 says this). I am surprised that there is no distinction between info and error
2609 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2612 it is easy to find where this is used.
2614 * src/maemo/easysetup/modest-easysetup-wizard.c:
2615 (create_page_welcome), (create_page_account_details),
2616 (create_page_user_details), (create_page_complete_easysetup),
2617 (create_page_custom_incoming), (create_page_custom_outgoing),
2618 (create_page_complete_custom):
2619 * src/maemo/modest-account-settings-dialog.c:
2620 (create_page_account_details), (create_page_user_details),
2621 (create_page_incoming), (create_page_outgoing):
2622 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2623 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2624 (modest_connection_specific_smtp_edit_window_init):
2625 * src/maemo/modest-connection-specific-smtp-window.c:
2626 (modest_connection_specific_smtp_window_init):
2627 * src/maemo/modest-signature-editor-dialog.c:
2628 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2629 and scrolling policy as per the Email Application Layout Guide, if I have
2632 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2634 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2635 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2636 which were empty, because these vfuncs have been removed from TnyAccountStore.
2637 This fixes the build.
2639 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2641 * src/maemo/modest-main-window.c:
2642 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2643 showing/hiding it. Added TODO because it probably should not be NULL.
2644 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2645 because unnecessary g_warnings() make degugging difficult.
2647 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/modest-msg-edit-window.c:
2650 (modest_msg_edit_window_select_color),
2651 (modest_msg_edit_window_select_background_color): 2 const corrections and
2652 moving 2 #endifs before closing brackets, to fix the build.
2654 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2656 * src/maemo/easysetup/modest-easysetup-wizard.h:
2657 * src/maemo/easysetup/modest-easysetup-wizard.c:
2658 (modest_easysetup_wizard_dialog_finalize),
2659 (on_button_edit_advanced_settings), (create_page_complete_custom),
2660 (on_response), (create_account):
2661 Implement the Advanced Settings edit button, by saving the account information,
2662 for the Advanded Settings dialog to use directly from gconf, and removing it
2663 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2664 Bug #5533 in the projects.maemo.org bugzilla.
2666 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-msg-view-window.c:
2669 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2670 when opening a message window.
2672 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2674 * src/maemo/easysetup/modest-easysetup-wizard.c:
2675 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2678 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2679 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2680 gconf settings. I probably added more checks than necessary, but that is safer.
2682 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2683 variable to fix the build, but this seems to be used when it is still NULL.
2685 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-platform.h:
2688 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2689 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2690 * src/modest-main.c: Implement this function so we can avoid using
2691 maemo-specific API from cross-platform code.
2693 * src/modest-tny-account-store.c:
2694 (get_smtp_specific_transport_account_for_open_connection):
2695 * src/modest-ui-actions.c: (check_for_connection),
2696 (modest_ui_actions_on_item_not_found):
2697 Use modest_platform_connect_and_wait() and put #idefs around other
2698 maemo-specific code, because only maemo currently has a way to
2699 identify connection names.
2701 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-tny-account-store.h:
2704 * src/modest-tny-account-store.c:
2705 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2706 the connection-specific SMTP server settings in the configuration.
2708 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2710 * src/maemo/modest-main-window.c: (on_connection_changed),
2712 * src/modest-main.c: (main), (start_ui), (send_mail):
2713 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2714 that is what is intended.
2716 * src/modest-ui-actions.c: (action_send), (action_receive),
2717 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2718 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2719 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2720 SMTP server is used when it is specified.
2722 (modest_ui_actions_on_send_receive):
2723 Check that a connection is open before proceeding.
2724 Receive and then send, instead of vice-versa, as per the specification.
2726 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2728 * src/modest-mail-operation.c:
2729 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2730 though I guess it should be something other than NULL.
2732 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/easysetup/modest-easysetup-wizard.c:
2735 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2736 combo twice, to avoid an g_warning and to make it visible again.
2737 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2738 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2739 (already intended) dereference when detaching, because we then recreate the menu.
2740 But I am not sure why the warning was happening, and it is possible that this is a memory
2743 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2745 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2746 and uri_parse_mailto() utility functions.
2747 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2749 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2751 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2753 * src/dbus_api/modest-dbus-api.h:
2754 * src/dbus_api/modest-dbus-callbacks.c:
2755 Use an idle callback to execute the modest code in the application's own thread.
2756 Remove the helloworld example method.
2757 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2758 parsed, and the open-message method is not implemented because this is not yet implemented in
2760 * libmodest-dbus-client/libmodest-dbus-client.c:
2761 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2762 (libmodest_dbus_client_open_message):
2763 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2765 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2766 body without crashing.
2768 * tests/dbus_api/Makefile.am:
2769 * tests/dbus_api/test_mail_to.c:
2770 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2772 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2774 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2775 Added file to fix the build. Sorry.
2777 * src/dbus_api/Makefile.am:
2778 * src/dbus_api/modest-dbus-api.h:
2779 * src/dbus_api/modest-dbus-callbacks.h:
2780 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2781 (modest_dbus_req_handler):
2782 Put constants in a separate header so it can be reused by the
2783 client library, without duplication
2785 * libmodest-dbus-client/Makefile.am:
2786 * libmodest-dbus-client/libmodest-dbus-client.c:
2787 (libmodest_dbus_client_call_helloworld),
2788 (libmodfest_dbus_client_send_mail),
2789 (libmodfest_dbus_client_mailto),
2790 (libmodfest_dbus_client_open_message):
2791 * libmodest-dbus-client/libmodest-dbus-client.h:
2792 (Partly) Implement a send_mail D-Bus method.
2794 * tests/dbus_api/Makefile.am:
2795 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2796 the send_email D-Bus method.
2798 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2802 * libmodest-dbus-client/Makefile.am:
2803 * libmodest-dbus-client/libmodest-dbus-client.c:
2804 * libmodest-dbus-client/libmodest-dbus-client.h:
2805 * tests/dbus_api/Makefile.am:
2806 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2807 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2809 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/easysetup/modest-easysetup-wizard.c:
2812 (create_page_account_details):
2813 * src/maemo/modest-account-settings-dialog.c:
2814 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2815 widgets, because this might not be the default in future versions of the Maemo GTK+.
2816 However, I can not not get capitalization to work even in a simple test case.
2818 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/easysetup/modest-easysetup-wizard.c:
2821 (create_page_custom_incoming), (create_page_custom_outgoing):
2822 * src/maemo/modest-account-settings-dialog.c:
2823 (create_page_account_details), (create_page_incoming),
2824 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2825 instead of using gtk_check_button_with_label(), so they are aligned like the other
2826 widgets, as per the UI spec.
2828 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2830 * src/maemo/easysetup/modest-easysetup-wizard.c:
2831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2832 * src/widgets/modest-validating-entry.c:
2833 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2834 Modest prefix instead of an EasySetup prefix.
2836 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2838 * src/widgets/modest-validating-entry.h:
2839 * src/widgets/modest-validating-entry.c: (on_insert_text),
2840 Added easysetup_validating_entry_set_max_func(), used to set a callback
2841 to call when the max number of characters is reached. GtkEntry has a max-length
2842 already but is silent about it.
2844 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2845 (create_page_account_details), (create_page_user_details),
2847 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2848 (create_page_account_details), (create_page_user_details),
2849 (create_page_outgoing):
2850 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2851 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2852 the UI spec, when the user tries to enter more than the max number of characters.
2854 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2856 * src/maemo/easysetup/modest-easysetup-wizard.c:
2857 (create_page_user_details), (create_page_custom_incoming),
2858 (create_page_custom_outgoing):
2859 * src/maemo/modest-account-settings-dialog.c:
2860 (create_page_user_details), (create_page_incoming),
2861 (create_page_outgoing):
2862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2863 (modest_connection_specific_smtp_edit_window_init):
2864 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2865 not appropriate. Bad Maemo-specific defaults!.
2867 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2869 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2870 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2871 (modest_signature_editor_dialog_set_settings):
2872 Disable the label and textview when the checkbox is disabled, and use the
2873 specified (UI spec) default signature text.
2875 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2878 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2880 * src/modest-defs.h:
2881 * src/modest-account-mgr-helpers.h:
2882 * src/modest-account-mgr-helpers.c:
2883 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2885 * src/maemo/Makefile.am:
2886 * src/maemo/modest-signature-editor-dialog.c:
2887 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2890 * src/maemo/modest-account-settings-dialog.h:
2891 * src/maemo/modest-account-settings-dialog.c:
2892 (modest_account_settings_dialog_finalize), (on_button_signature),
2893 (save_configuration): Use the new dialog when the Edit button is pressed, and
2894 save the changes if necessary, as per the UI spec.
2896 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2898 * src/maemo/Makefile.am:
2899 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2900 based on maemo-develoers email from Dirk.
2902 * src/maemo/easysetup/modest-easysetup-wizard.c:
2903 (create_page_welcome), (create_page_account_details),
2904 (create_page_user_details), (create_page_complete_easysetup),
2905 (create_page_custom_incoming), (create_page_custom_outgoing),
2906 (create_page_complete_custom),
2907 (modest_easysetup_wizard_dialog_init):
2908 * src/maemo/modest-account-settings-dialog.c:
2909 (create_page_account_details), (create_page_user_details),
2910 (create_page_incoming), (create_page_outgoing),
2911 (modest_account_settings_dialog_init):
2912 * src/maemo/modest-connection-specific-smtp-window.c:
2913 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2915 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/easysetup/modest-easysetup-wizard.c:
2918 (create_page_account_details), (create_page_custom_outgoing),
2919 (create_page_complete_custom):
2920 * src/maemo/modest-account-settings-dialog.c:
2921 (create_page_user_details), (create_page_incoming),
2922 (create_page_outgoing):
2923 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2924 (modest_connection_specific_smtp_edit_window_init):
2925 Use the correct (UI spec) port min/max, and use horizontal separators,
2928 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2930 * src/maemo/easysetup/modest-easysetup-wizard.c:
2931 (set_default_custom_servernames):
2932 * src/maemo/modest-account-settings-dialog.c:
2933 (create_page_incoming), (on_combo_outgoing_security_changed),
2934 (on_combo_incoming_security_changed), (create_page_outgoing),
2935 (modest_account_settings_dialog_set_account_name),
2936 (save_configuration):
2937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2938 (on_combo_security_changed),
2939 (modest_connection_specific_smtp_edit_window_init),
2940 (modest_connection_specific_smtp_edit_window_set_connection),
2941 (modest_connection_specific_smtp_edit_window_get_settings):
2942 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2945 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2948 * src/maemo/easysetup/modest-easysetup-wizard.c:
2949 (create_page_custom_outgoing), (create_page_complete_custom):
2950 * src/maemo/modest-account-settings-dialog.c:
2951 (create_page_user_details), (create_page_outgoing):
2952 * src/maemo/modest-account-view-window.c: (button_box_new):
2953 Use changed logical IDs as per the most recent UI spec:
2954 mcen_bd_emailsetup_edit -> mcen_bd_edit
2955 mcen_bd_emailsetup_delete -> mcen_bd_delete
2956 mcen_bd_emailsetup_close -> mcen_bd_close
2958 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2962 * src/dbus_api/Makefile.am:
2963 * src/dbus_api/modest-dbus-callbacks.c:
2964 * src/dbus_api/modest-dbus-callbacks.h:
2965 * src/maemo/modest-platform.c: (modest_platform_init):
2966 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2968 * tests/Makefile.am:
2969 * tests/dbus_api/Makefile.am:
2970 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2972 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/modest-account-settings-dialog.c:
2975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2976 Removed unnecessary includes.
2978 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/easysetup/modest-easysetup-wizard.c:
2981 * src/maemo/modest-account-settings-dialog.c:
2982 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2983 * src/widgets/Makefile.am:
2984 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2985 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2986 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2987 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2988 * src/widgets/modest-secureauth-combo-box.c:
2989 * src/widgets/modest-secureauth-combo-box.h:
2990 * src/widgets/modest-serversecurity-combo-box.c:
2991 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2992 made the GObject names more consistent with the rest of the Modest code.
2994 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2996 * src/maemo/easysetup/Makefile.am:
2997 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2998 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2999 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3000 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3001 * src/maemo/easysetup/modest-easysetup-wizard.c:
3002 * src/maemo/easysetup/modest-validating-entry.c:
3003 * src/maemo/easysetup/modest-validating-entry.h:
3004 * src/maemo/modest-account-settings-dialog.c:
3005 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3006 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3007 widgets/ because they are used outside of easysetup too. After checking in,
3008 svn will allow me to rename them too.
3010 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3012 * src/gnome/modest-msg-edit-window.c:
3013 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3014 linker error, to fix the build on the GNOME platform.
3015 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3016 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3017 ifdefed out to avoid a warning.
3019 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3021 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3022 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3023 some alternative for GTK+ 2.6.
3025 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3027 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3029 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3030 specified for EmailAccountsDialog in UI spec.
3032 * src/maemo/easysetup/modest-easysetup-wizard.c:
3033 * src/maemo/easysetup/modest-easysetup-wizard.h:
3034 * src/maemo/modest-account-settings-dialog.c:
3035 * src/maemo/modest-account-settings-dialog.h:
3036 Reuse a member window widget for the connection-specific SMTP server accounts,
3037 so we can tell it to create/save the accounts only if we actually save changes.
3039 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3040 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3041 (modest_connection_specific_smtp_edit_window_get_settings):
3042 Return a struct instance for temporarily remembering the entered data.
3044 * src/maemo/modest-connection-specific-smtp-window.h:
3045 * src/maemo/modest-connection-specific-smtp-window.c:
3046 (modest_connection_specific_smtp_window_finalize),
3047 (modest_connection_specific_smtp_window_fill_with_connections),
3049 (modest_connection_specific_smtp_window_save_server_accounts),
3050 (update_model_server_names): Do not actually save data until asked,
3051 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3053 (on_selection_changed),
3054 (modest_connection_specific_smtp_window_init): Disable the edit
3055 button when nothing is selected.
3057 * src/modest-account-mgr-helpers.c:
3058 * src/modest-account-mgr-helpers.h:
3059 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3062 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3064 * src/modest-account-mgr-helpers.h:
3065 * src/modest-account-mgr-helpers.c:
3066 (modest_account_mgr_get_unused_account_name),
3067 (modest_account_mgr_get_unused_account_display_name): Added these
3068 utility functions, to avoid code duplication.
3070 * src/maemo/easysetup/modest-easysetup-wizard.c:
3071 (create_page_account_details), (create_account):
3072 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3073 (on_combo_security_changed),
3074 (modest_connection_specific_smtp_edit_window_init),
3075 (modest_connection_specific_smtp_edit_window_save_settings):
3076 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3077 * src/maemo/modest-connection-specific-smtp-window.c:
3078 (modest_connection_specific_smtp_window_finalize),
3079 (modest_connection_specific_smtp_window_fill_with_connections),
3080 (on_button_edit), (modest_connection_specific_smtp_window_init):
3081 * src/maemo/modest-connection-specific-smtp-window.h:
3082 Implementing saving of connection-specific server accounts.
3084 But I need to refactor this so we can save the data for each
3085 possible connection-specific account and only actually create the server accounts
3086 when the easysetup finished, or the OK button is pressed on the account settings
3089 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3091 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3092 (on_combo_security_changed):
3093 (modest_connection_specific_smtp_edit_window_init):
3094 Auto-fill the port number as in the account settings.
3096 (modest_connection_specific_smtp_edit_window_set_connection):
3097 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3098 * src/maemo/modest-connection-specific-smtp-window.c:
3099 (fill_with_connections), (on_button_edit),
3100 (modest_connection_specific_smtp_window_init):
3101 Turn the edit window into a dialog to simplify the code, and
3102 set a WM hint as in a GtkDialog, because only a popup can be on top of
3103 another window in Maemo, and popups usually have no WM decoration.
3105 * src/modest-defs.h:
3106 * src/modest-account-mgr-helpers.c:
3107 (modest_account_mgr_set_connection_specific_smtp),
3108 (modest_account_mgr_remove_connection_specific_smtp),
3109 (modest_account_mgr_get_connection_specific_smtp):
3110 * src/modest-account-mgr-helpers.h: Some functions to write the
3111 connection-specific SMTP server information. Not yet used.
3114 * src/widgets/modest-folder-view.c: (text_cell_data):
3115 Fix a warning about an uninitialized variable.
3116 (on_configuration_key_changed): Put an #ifdef around the use
3117 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3119 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3121 * src/maemo/modest-account-settings-dialog.h:
3122 * src/maemo/modest-account-settings-dialog.c:
3123 Added connect_for_modified() utility function to mark the new modified boolean.
3125 (create_page_account_details), (create_page_user_details),
3126 (create_page_incoming), (create_page_outgoing), (on_response),
3127 (modest_account_settings_dialog_init),
3128 (modest_account_settings_dialog_set_account_name):
3129 Only warn about unsaved changes when there are actually unsaved changes.
3131 * src/modest-account-mgr-helpers.c:
3132 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3133 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3134 to get the data from there in future.
3136 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3138 * src/modest-defs.h:
3140 * src/modest-account-mgr-helpers.h:
3141 * src/modest-account-mgr-helpers.c:
3142 Store the security account setting in a single conf key instead of using
3143 the options list, so that the list is left for just the to-be-removed camel hack,
3144 and because gconf_client_set_list() is failing for some reason.
3146 * src/modest-account-mgr.c:
3147 (modest_account_mgr_add_server_account):
3148 * src/maemo/modest-account-settings-dialog.c:
3149 (modest_account_settings_dialog_set_account_name),
3150 (save_configuration): Use the renamed functions.
3153 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3155 * src/widgets/Makefile.am:
3156 * src/widgets/modest-limit-retrieve-combo-box.c:
3157 * src/widgets/modest-limit-retrieve-combo-box.h:
3158 * src/widgets/modest-retrieve-combo-box.c:
3159 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3160 the account settings dialog.
3162 * src/modest-defs.h:
3163 * src/modest-account-mgr-helpers.h:
3164 * src/modest-account-mgr-helpers.c:
3165 (modest_server_account_get_option_secure_auth),
3166 (modest_server_account_set_option_secure_auth):
3167 * src/modest-account-mgr.c:
3168 (modest_account_mgr_add_server_account):
3169 Use the existing AUTH_MECH conf key for the secure-auth setting,
3170 instead of putting it in the list options, because this was actually used already.
3172 * src/maemo/modest-account-settings-dialog.c:
3173 (create_page_account_details),
3174 (modest_account_settings_dialog_set_account_name),
3175 (save_configuration):
3176 * src/maemo/modest-account-settings-dialog.h:
3177 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3178 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3180 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3182 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3183 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3184 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3186 * src/modest-defs.h:
3187 * src/maemo/modest-account-settings-dialog.c:
3188 (create_page_incoming), (on_combo_outgoing_security_changed),
3189 (on_combo_incoming_security_changed), (create_page_outgoing),
3190 (modest_account_settings_dialog_set_account_name),
3191 (save_configuration): Load/Save the port number, and change it when the
3192 security combo changes, to suitable defaults.
3194 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3196 * src/modest-account-mgr.c:
3197 (modest_account_mgr_add_server_account): Set the security and secure-auth
3198 options, and add a comment saying that the other camel-specific options should be
3201 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3203 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3205 * src/modest-tny-account-store.c: (account_list_free),
3206 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3207 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3210 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3212 * src/modest-protocol-info.c:
3213 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3214 is required by our UI spec. Maybe something in our implementation will use this eventually.
3215 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3216 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3217 instead of the previous 0 placeholder.
3219 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3220 secure-auth settings.
3221 * src/modest-account-mgr-helpers.h:
3222 * src/modest-account-mgr-helpers.c:
3223 (modest_server_account_data_get_option_secure_auth),
3224 (modest_server_account_set_option_secure_auth),
3225 (modest_server_account_data_get_option_security),
3226 (modest_server_account_set_option_security): Added this API for getting and setting the security
3227 and secure-auth settings.
3229 * src/maemo/modest-account-settings-dialog.h:
3230 * src/maemo/modest-account-settings-dialog.c:
3231 (modest_account_settings_dialog_finalize), (check_data),
3232 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3233 about changing titles.
3234 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3235 (save_configuration): Save the security and secure-auth settings.
3237 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3238 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3240 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3242 * src/modest-defs.h:
3243 * src/modest-account-mgr.c:
3244 (modest_account_mgr_add_server_account):
3245 Added and used defines for the options key and value pair strings,
3246 that are used so far, though they do not seem to correspond to anything in our
3247 UI specs or ModestProtocol enum.
3249 * src/modest-account-mgr-helpers.h:
3250 * src/modest-account-mgr-helpers.c:
3251 (compare_option_strings_for_name),
3252 (modest_server_account_data_get_option_value),
3253 (modest_server_account_data_get_option_bool),
3254 (modest_account_mgr_get_server_account_option):
3255 Added helper functions for parsing the options GSList.
3257 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3259 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3260 display name is based on the supplied account name.
3261 * src/modest-account-mgr.c:
3262 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3263 with an inefficient, but good-enough, implementation.
3265 * src/maemo/easysetup/modest-easysetup-wizard.c:
3266 (create_page_account_details), (on_before_next), (create_account):
3267 Check for existing display names rather than (non-user-visible) account names, and just
3268 create and set a unique account name at the end.
3270 * src/maemo/modest-account-settings-dialog.c:
3271 (modest_account_settings_dialog_init),
3272 (modest_account_settings_dialog_set_account_name),
3273 (create_page_incoming): Show the display name, instead of the account name.
3274 (on_response): Do some (not all) extra checks, as in the UI spec.
3275 (save_configuration): Save the display name if it was changed.
3277 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3279 * po/en_GB.po: Added needed logical ID and translation.
3280 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3281 (init_view): Made the is-default column clicking work.
3283 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3286 * src/maemo/easysetup/Makefile.am:
3287 * src/maemo/easysetup/modest-easysetup-wizard.c:
3288 (modest_easysetup_wizard_dialog_init):
3289 * src/maemo/easysetup/provider-data-test.keyfile:
3290 * src/maemo/easysetup/provider-data.keyfile:
3291 Moved the provider data file to the new modest-providers-data package and used it from there.
3293 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3295 * src/modest-local-folder-info.c:
3296 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3297 N_() was already used on the static strings, but this just marks it for translation without
3298 using the translation.
3300 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/modest-account-settings-dialog.c:
3303 (create_page_incoming),
3304 (modest_account_settings_dialog_set_account_name):
3305 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3306 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3307 I will do this if nobody else gets there first.
3309 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3311 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3312 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3313 save the security stuff.
3315 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3318 Set the email address and user fullname, which I now see must be
3321 * src/maemo/modest-account-settings-dialog.h:
3322 * src/maemo/modest-account-settings-dialog.c:
3324 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3325 leave-on-server and authentication.
3326 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3329 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3332 * src/maemo/modest-account-settings-dialog.c:
3333 * src/maemo/modest-account-settings-dialog.h:
3334 Most (but not all) of the widgets are now present as specified by the UI spec.
3335 No changes are yet saved, and some details are not properly shown yet.
3337 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3339 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/Makefile.am:
3342 * src/maemo/modest-account-settings-dialog.c:
3343 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3344 an existing account. Doesn't do much yet.
3346 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3347 Open the accounts settings dialog when Edit is clicked.
3349 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/easysetup/Makefile.am:
3352 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3354 * src/maemo/easysetup/modest-easysetup-wizard.c:
3355 (modest_easysetup_wizard_dialog_init):
3356 Try to get the source directory from the build system,
3357 instead of hard-coding "./" into the source code, when opening our local
3358 copies of the configuration files.
3359 But this still fails when opening the wizard from the Accounts window,
3360 maybe because the working directory seems to change at runtime.
3361 So the wizard will fail the second time unless you copy the files into their
3362 proper locations - see the stdout warnings for the paths.
3364 (create_page_account_details),(on_before_next):
3365 Check for existing non-server accounts instead of server accounts,
3366 so the default account name is useful again, and to prevent trying to
3369 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3370 Show the wizard when New is clicked.
3372 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3373 (init_view): Show the column headers, and show the columns that are
3374 specified in the UI specs. However, something in Maemo's GTK+ prevents
3375 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3376 change the default account. This is despite unsetting the special properties.
3378 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3380 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3381 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3382 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3383 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3384 to make that clearer.
3385 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3387 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3389 * src/maemo/modest-account-view-window.c:
3390 (modest_account_view_window_init),
3391 (modest_account_view_window_new):
3392 Use the same buttons as specified in the
3393 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3394 the existing widgets, which never had a chance of working.
3395 Put the ModestAccountView treeview in a scrolled window.
3396 Do not repeat the initialization in both _init() and _new().
3398 * src/widgets/modest-account-view.c: (update_account_view):
3399 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3400 this widget and window shows no accounts.
3402 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3404 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3406 * src/maemo/easysetup/modest-easysetup-wizard.c:
3407 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3408 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3409 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3412 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3413 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3414 accounts exist yet, as in the UI spec.
3416 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3418 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3420 * src/maemo/Makefile.am:
3421 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3422 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3423 New window for editing connection-specific smtp details.
3424 Not fully implemented.
3426 * src/maemo/modest-connection-specific-smtp-window.c:
3427 (modest_connection_specific_smtp_window_finalize) :
3428 unref the tree model.
3429 (on_button_edit): Show the edit window.
3431 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3433 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3436 * src/maemo/Makefile.am:
3437 * src/maemo/modest-connection-specific-smtp-window.c:
3438 * src/maemo/modest-connection-specific-smtp-window.h:
3439 New window for showing the list of connections, for connection-specific
3440 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3441 * src/maemo/easysetup/modest-easysetup-wizard.c:
3442 (create_page_custom_outgoing): Show the new window when the button is clicked.
3444 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3446 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3447 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3448 * src/maemo/modest-msg-edit-window.c:
3449 (modest_msg_edit_window_insert_image):
3450 * src/modest-conf.c: (modest_conf_key_escape):
3451 * src/modest-mail-operation.c:
3452 (modest_mail_operation_send_new_mail):
3453 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3454 (modest_ui_actions_on_new_account):
3455 * src/widgets/modest-attachment-view.c: (update_filename_request):
3456 * src/widgets/modest-mail-header-view.c:
3457 Corrected warnings that were breaking the build, by commenting out unused variables,
3458 and a function, and by including a header.
3460 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3462 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3463 so we can #ifdef around platform-specific code when necessary.
3464 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3465 to allow this to build for the GNOME platform too.
3467 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/easysetup/modest-easysetup-wizard.c:
3470 Added util_increment_name() and used it in create_page_account_details()
3471 to make sure that the default account name is always a new name.
3473 (modest_easysetup_wizard_dialog_init),
3474 (set_default_custom_servernames): Some minor memory management fixes.
3476 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3480 * src/modest-runtime.c: (init_i18n): Restored the translation
3481 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3482 are defined in config.h, and the translations are installed.
3484 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3485 is defined for translation.
3487 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3491 * src/maemo/easysetup/modest-easysetup-wizard.c:
3492 (modest_easysetup_wizard_dialog_init):
3493 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3494 Use realistic paths (though they should use $prefix generically) to the
3495 mcc_mapping and provider-data.keyfile files which might work when they
3496 are installed by the future version of the operator-wizard package,
3497 and then fallback to paths in our source code, with an explanatory
3500 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/Makefile.am:
3505 * src/maemo/easysetup/: Added files from the previously-exernal
3506 osso-modest-easysetup.
3507 * src/maemo/modest-main-window-ui.h:
3508 * src/modest-ui-actions.c:
3509 * src/modest-ui-actions.h:
3510 Added modest_ui_actions_on_new_account() as a signal handler for the
3511 New Account menu item. It shows the easysetup wizard.
3512 * po/en_GB.po: Added additional needed logical IDs and translations.