1 2007-07-04 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c: (on_connection_status_changed):
4 Commented out the call to modest_platform_connect_and_wait() because this
5 seems to always hang, and I would like to know if this is the only thing
6 that causes a hang when showing the connection dialog.
7 It is not very useful anyway.
9 2007-07-04 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-msg-view-window.c:
12 (modest_msg_view_window_select_next_message):
14 * src/modest-platform.h:
15 * src/maemo/modest-platform.c:
16 Added modest_platform_connect_and_wait(), which calls
17 tny_maemo_conic_device_connect() always in the main thread, by calling it
18 in an idle handler and waiting for the idle handler to run. It should be
19 in the main thread because it uses GTK+ UI code. It just returns TRUE
20 if the device is already online.
22 There is some nasty code to ensure that subsequent calls to
23 modest_platform_connect_and_wait() just wait for the first one to finish,
24 by checking repeatedly in another idle handler. This is necessary,
25 because other threads (or even the main thread, via another idle handler)
26 can call modest_platform_connect_and_wait() while
27 modest_platform_connect_and_wait() is running.
29 (modest_platform_connect_and_wait_if_network_account),
30 (modest_platform_connect_and_wait_if_network_folderstore):
31 Convenience functions that calls modest_platform_connect_and_wait() if
32 the account or folder might want network access.
34 * src/modest-mail-operation.c:
35 (modest_mail_operation_update_account):
36 * src/modest-ui-actions.c: (download_uncached_messages),
37 (modest_ui_actions_on_rename_folder), (delete_folder),
38 (modest_ui_actions_on_main_window_move_to),
39 (modest_ui_actions_on_msg_view_window_move_to):
40 * src/widgets/modest-folder-view.c:
41 (drag_and_drop_from_folder_view):
42 Offer a connection if we are offline.
44 * src/modest-tny-account.c: (on_connection_status_changed):
45 Document this as only handling errors during network operations in progress,
46 and replace the idle code with a simple call to
47 modest_platform_connect_and_wait(), which does this instead.
49 2007-07-03 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-tny-account.c:
52 (modest_tny_account_get_special_folder): (util_on_idle),
53 Handle the GError so we can see when tny_folder_store_get_folders()
54 fails, as it currently does while something else is connecting.
56 Added util_run_in_main_thread_and_wait()
57 which uses an idlen handler and mainloop to ensure that the function
58 is called in the main thread.
59 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
60 to make sure that we call attempt the connection in the mainloop only,
61 which might solve some hangs.
63 2007-07-03 Murray Cumming <murrayc@murrayc.com>
65 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
66 be found by their display name. This is never useful.
67 * src/modest-tny-account-store.c: (on_account_removed): Find the account
68 by its ID, instead of trying to use its ID as its display name.
70 * src/modest-tny-account-store.h:
71 * src/modest-tny-account.c:
72 (modest_tny_account_get_special_folder): Add a g_warning() when
73 tny_folder_store_get_folders() returns an empty list for the maildir.
75 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
76 Add a g_warning() when this returns NULL, because that it not allowed
79 2007-07-02 Armin Burgmeier <armin@openismus.com>
81 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
82 note when trying to cancel the wizard. This fixes projects.maemo.org
85 2007-07-02 Murray Cumming <murrayc@murrayc.com>
87 * src/modest-tny-account.h:
88 * src/modest-tny-account.c:
89 (modest_tny_account_new_from_server_account),
90 (modest_tny_account_new_from_server_account_name),
91 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
92 because this must now be set before setting the proto. This is usd in
93 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
94 warning in camel_session_get_service() caused by
95 tny_camel_transport_account_prepare().
97 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
100 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
104 (modest_connection_specific_smtp_edit_window_init):
106 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
109 2007-06-29 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-tny-account.c:
112 (modest_tny_account_new_from_server_account):
113 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
114 now uses to request a connection when it needs one, and which it uses
115 to tell us that something is wrong with the connection, so we can force
116 the accounts offline to prevent further problems.
119 * src/modest-init.c: (init_default_settings):
120 * src/modest-mail-operation.c:
121 (modest_mail_operation_update_account):
122 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
123 This should not be necessary anymore. Do not set the conf key that
124 determined this (it was always TRUE and not set anywhere else).
126 * src/modest-ui-actions.h: Remove unused and unimplemented
127 modest_ui_actions_on_online_toggle_toggled().
129 2007-06-29 Murray Cumming <murrayc@murrayc.com
131 * src/maemo/modest-main-window.c: (connect_signals):
132 Don't connect to delete_event twice. Maybe this was harmless.
134 2007-06-29 Murray Cumming <murrayc@murrayc.com
136 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
137 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
138 Debug output to give some more clue when a folder move is not allowed.
140 2007-06-28 Murray Cumming <murrayc@murrayc.com
142 * src/modest-tny-account.c: (on_modest_file_system_info),
143 (modest_tny_account_get_mmc_account_name):
144 Always call the callback, without checking whether the name has changed.
145 * src/widgets/modest-folder-view.c: (strings_are_equal),
146 (on_model_foreach_set_name), (on_get_mmc_account_name),
147 (text_cell_data): Compare the name here, and use the name from
148 the account rather than from the
149 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
150 if the name was changed after the account was added to the model.
151 That's a tinymail bug but not one that I want to fix now.
153 This finally fixes projects.maemo.org bug NB#59301.
155 2007-06-27 Armin Burgmeier <armin@openismus.com>
157 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
160 2007-06-27 Murray Cumming <murrayc@murrayc.com
162 * src/modest-tny-account.h:
163 * src/modest-tny-account.c:
164 Added modest_tny_account_get_mmc_account_name(), to set the memory
165 card name asynchronously for the given account and then notify.
166 (modest_tny_account_new_for_local_folders): Use this new function instead
167 of using hildon_file_system_info_async_new() directly.
169 * src/widgets/modest-folder-view.c: (text_cell_data):
170 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
171 gtk_tree_model_row_changed() when it is available.
173 This should fix projects.maemo.org bug NB#59301.
175 2007-06-27 Murray Cumming <murrayc@murrayc.com
177 * src/modest-mail-operation.c: (update_account_thread),
178 (get_msgs_full_thread): Fix typo failures in the revert
181 2007-06-27 Murray Cumming <murrayc@murrayc.com
183 * src/maemo/modest-maemo-global-settings-dialog.c:
184 (idle_select_default_focus):
185 * src/modest-mail-operation.c: (idle_notify_progress),
186 (idle_notify_progress_once), (set_last_updated_idle),
187 (update_account_thread), (get_msgs_full_thread):
188 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
189 * src/widgets/modest-header-view.c:
190 (idle_notify_headers_count_changed_destroy),
191 (idle_notify_headers_count_changed):
192 Reverted the additions of gdk_threads_enter/leave(), in case this
193 helps with a startup hang on the device.
195 2007-06-26 Armin Burgmeier <armin@openismus.com>
197 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
198 for supported secure authentication methods from server by
199 gtk_dialog_run(), saving CPU time and a potential race condition.
201 2007-06-26 Armin Burgmeier <armin@openismus.com>
203 * src/maemo/modest-maemo-utils.h:
204 * src/maemo/modest-maemo-utils.c: Added a
205 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
206 only error code to tell the calling code when the user canceled the
209 * src/maemo/modest-account-settings-dialog.h:
210 * src/maemo/modest-account-settings-dialog.c:
211 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
212 message if the retrieval of secure authentication methods was canceled
213 by the user. Perform the check before saving anything to configuration
214 to not end up with half-committed configuration changes, do not show
215 a "Saving to configuration failed" note when authentication methods
216 could not be retrieved.
218 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
221 2007-06-26 Murray Cumming <murrayc@murrayc.com>
223 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
224 Only return the first level of folders under accounts, because the
225 osso-global-search UI spec doesn't want the rest.
226 This fixed projects.maemo.org bug NB#61811.
228 2007-06-26 Murray Cumming <murrayc@murrayc.com>
230 * src/modest-tny-account-store.c:
231 * src/modest-tny-account-store.h:
232 Added modest_tny_account_is_memory_card_account().
233 * src/maemo/modest-main-window.c: (create_details_widget):
234 Show the same information items for the memory card as we show for the
235 local-folders, to fix projects.maemo.org bug NB#59307.
237 2007-06-26 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-tny-account-store.c: (get_password):
240 Added some checks for NULL to maybe prevent crashes, though I think
241 it was Philip's last commit that actually prevented the crash here
242 when creating a first new account.
243 But the new account is still not usable (no messages are shown)
244 until a restart of the application.
246 2007-06-26 Murray Cumming <murrayc@murrayc.com>
248 * src/maemo/modest-maemo-global-settings-dialog.c:
249 (idle_select_default_focus):
250 * src/modest-mail-operation.c: (idle_notify_progress),
251 (idle_notify_progress_once), (idle_notify_update_account_queue),
252 (set_last_updated_idle), (update_account_thread),
253 (notify_get_msgs_full), (get_msgs_full_destroyer),
254 (get_msgs_full_thread):
255 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
256 * src/widgets/modest-header-view.c:
257 (idle_notify_headers_count_changed_destroy),
258 (idle_notify_headers_count_changed):
259 Use gdk_threads_enter() and gdk_threads_enter_leave() in
260 all idle handlers, because some other thread could be blocking
261 the GDK lock, so that it can do GUI stuff.
263 2007-06-26 Murray Cumming <murrayc@murrayc.com>
265 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
266 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
267 (on_idle_send_receive), (on_idle_open_default_inbox):
268 * src/maemo/modest-msg-edit-window.c:
269 (modest_msg_edit_window_attach_file_noninteractive):
270 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
271 to prevent a hang. I don't quite understand why these are necessary,
272 beause we should already be in the main loop. I guess something outside
273 of the main loop is taking the lock.
275 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
276 we are really using URIs, and use files that are more likely to exist.
278 2007-06-26 Murray Cumming <murrayc@murrayc.com>
280 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
281 necessary because configure.ac now defines different variables.
283 2007-06-26 Murray Cumming <murrayc@murrayc.com>
285 * libmodest-dbus-client/libmodest-dbus-client.c:
286 * libmodest-dbus-client/libmodest-dbus-client.h:
287 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
288 libmodest_dbus_client_compose_mail() is what things actually use.
290 * src/dbus_api/modest-dbus-api.h:
291 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
292 * tests/dbus_api/Makefile.am:
293 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
296 2007-06-26 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-init.c: (modest_init_local_folders):
299 For memory-card (or other non local-folders) maildir accounts,
300 always create an Archive folder, so that there is somewhere to put
301 messages. This should be less confusing, because the user does not need
302 to guess that the need to create a folder.
304 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
306 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
307 Fixed icon size by using (50, 50) which is the same as defined by
310 2007-06-25 Armin Burgmeier <armin@openismus.com>
312 * src/widgets/modest-window-mgr.c:
314 * configure.ac: Correctly recognize hildon-notify presence and fixed
315 the build without it being installed.
317 2007-06-25 Murray Cumming <murrayc@murrayc.com>
319 * libmodest-dbus-client/libmodest-dbus-client.c:
320 (libmodest_dbus_client_search): Fix the build. Sorry.
321 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
322 (reply_forward_cb): Initialize variables to fix the build.
324 * src/modest-tny-account-store.c:
325 (modest_tny_account_store_get_tny_account_by): Fix the account URI
326 comparison (a silly typo) so that email search results can be opened
327 when there are more than one account.
329 2007-06-25 Murray Cumming <murrayc@murrayc.com>
331 * libmodest-dbus-client/libmodest-dbus-client.c:
332 (libmodest_dbus_client_search),
333 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
334 instead of 1 second, because the search gets folders and messages from
335 the server, which can take a long time. When it times out,
336 osso-global-search will report no results.
338 We need to specify whether we should search only cached information
339 (maybe with a user preference), and the osso-email-search-plugin
340 API should really be improved to allow that option, and to allow results
341 to be delivered asynchronously in batches.
343 2007-06-25 Murray Cumming <murrayc@murrayc.com>
345 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
346 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
347 GTK_ICON_SIZE_DIALOG is probably the wrong size.
349 2007-06-25 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
352 that is an empty string. D-Bus seems to give us these instead of NULL.
354 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
356 * src/dbus_api/modest-dbus-callbacks.c:
357 * src/maemo/easysetup/modest-easysetup-wizard.h:
358 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
360 (modest_connection_specific_smtp_edit_window_init):
361 * src/maemo/modest-maemo-global-settings-dialog.c:
363 * src/maemo/modest-maemo-utils.c:
364 (modest_maemo_utils_setup_images_filechooser):
365 * src/maemo/modest-main-window.c: (create_details_widget):
366 * src/maemo/modest-msg-edit-window.c:
367 (modest_msg_edit_window_attach_file_noninteractive),
368 (modest_msg_edit_window_color_button_change),
369 (modest_msg_edit_window_set_zoom):
370 * src/modest-mail-operation.c: (update_account_thread):
371 * src/modest-tny-account-store.c:
372 * src/modest-tny-account.c:
373 * src/widgets/modest-global-settings-dialog.c:
374 * src/widgets/modest-window.h:
378 2007-06-25 Murray Cumming <murrayc@murrayc.com>
380 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
381 * src/modest-search.c: (modest_search_folder),
382 (modest_search_all_accounts): Actually search only in the specified folder,
383 doing a simple match on the folder ID.
384 * src/modest-search.h: Added a folder field to the ModestSearch struct,
385 and added some documentation.
387 2007-06-22 Armin Burgmeier <armin@openismus.com>
389 * src/maemo/modest-maemo-utils.h:
390 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
391 modest_maemo_utils_get_supported_secure_authentication_methods.
393 * src/maemo/easysetup/modest-easysetup-wizard.c:
394 * src/maemo/modest-account-settings-dialog.c: Show correct error if
395 one occured, not just "Server does not support secure authentication".
397 2007-06-22 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-tny-account-store.c: (get_password):
400 Restored the call to tny_account_set_user() because Philip seems to have
401 stopped this from crashing (by not using the freed string). It still does
402 not work, but now we can test it.
404 2007-06-22 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/modest-msg-edit-window.c: (init_window):
407 Comment out use of an uninitialzed GtkScrolledWindow variable,
408 to fix the build and stop a crash. Yet again.
410 2007-06-22 Murray Cumming <murrayc@murrayc.com>
412 * src/modest-tny-account-store.c: (get_password):
413 Remove the call to tny_account_set_user() because this actually crashes.
414 As mentioned in the last commit, it is known to not work anyway.
416 2007-06-22 Murray Cumming <murrayc@murrayc.com>
418 * src/modest-tny-account-store.c: (get_password):
419 Use tny_account_set_username() to tell tinymail that the username might
420 have changed too. But tinymail ignores this: see projects.maemo.org
422 * src/modest-ui-actions.c:
423 (modest_ui_actions_on_password_requested): Remove the useless attempt to
424 reset the connection when changing the username, and improve the comments.
425 Save the changed username to gconf at least, so it is used when Modest is
428 2007-06-21 Murray Cumming <murrayc@murrayc.com>
430 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
431 Do not use a query, so that we get all folders, including for POP and
432 local-folders. They work as search criteria too.
433 This fixes projects.maemo.org bug NB#57740.
435 2007-06-21 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
438 Comment out the use of hildon_notification_set_sound() because it is
439 not declared, to fix the build. Warnings are serious, people.
441 2007-06-21 Armin Burgmeier <armin@openismus.com>
443 * src/maemo/modest-maemo-utils.h:
444 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
445 modest_maemo_utils_get_supported_secure_authentication_methods()
446 to query authentication methods for a specific user. This should fix
447 projects.maemo.org bug NB#61369.
449 * src/maemo/easysetup/modest-easysetup-wizard.c:
450 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
453 2007-06-21 Murray Cumming <murrayc@murrayc.com>
455 * libmodest-dbus-client/libmodest-dbus-client.h:
456 * libmodest-dbus-client/libmodest-dbus-client.c:
457 (modest_dbus_message_iter_get_search_hit),
458 (libmodest_dbus_client_search):
459 Reorganised and commented this.
460 Removed modest_search_hit_free() from the public API because it
463 Added libmodest_dbus_client_get_folders() and
464 modest_folder_result_list_free().
466 * src/dbus_api/modest-dbus-api.h:
467 * src/dbus_api/modest-dbus-callbacks.c:
468 (modest_dbus_req_filter): Commented. Moved most code to
469 on_dbus_method_search() and added on_dbus_method_get_folders().
471 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
472 of the extra D-Bus handler.
474 * tests/dbus_api/Makefile.am:
475 * tests/dbus_api/test_get_folders.c: New test for
476 libmodest_dbus_client_get_folders(). This seems to return an empty list
477 at the moment. That could be the same error that causes the message list
478 to be empty sometimes.
479 This should help with projects.maemo.org bug NB#57740.
481 2007-06-21 Armin Burgmeier <armin@openismus.com>
483 * src/modest-mail-operation.c: Do not call
484 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
485 notify the operation's end after having set the status to CANCELED for
486 the operation queue to listen on. This fixes a deadlock when there
487 were mail operations in the queue during its finalization.
489 * src/modest-singletons.c: Reordered uninitialization of the account
490 manager to happen after the mail operation queue was uninitialized
491 because the mail operation's in the queue might still try to access
492 the account manager (see modest_mail_operation_notify_end()). This
493 fixes a potential crash when terminating the application.
495 2007-06-21 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-search.c:
498 (search_mime_part_and_child_parts): Moved some code here so we
499 can search recursively in child folders.
500 (modest_search_folder): Search in the message as a mime part, instead
501 of just its child mime parts.
502 (read_chunk), (search_mime_part_ogs):
503 Check how many bytes were read, to prevent an endless loop.
504 Searching in message bodies now works. This finishes the fix for
505 projects.maemo.org bug NB#61007.
507 2007-06-20 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
510 Add a g_warning when the item is not a folder.
512 * src/modest-ui-dimming-rules.c:
513 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
514 when selected item is not a folder (for instance, an account), because
515 the UI spec only talks about folders.
516 I am not sure what the UI spec wants, so this might not totally fix
517 projects.maemo.org bug NB#60794.
519 2007-06-20 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
522 (load_from_file): Sort the list. The unsorted list would be more noticeable
523 in non-English locales.
525 * src/maemo/modest-msg-edit-window.c:
526 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
527 warning and fix the build.
529 * src/maemo/modest-progress-bar-widget.c:
530 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
531 avoid a g_warning, and probably to avoid a crash.
533 2007-06-20 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-search.c: (modest_search_folder): Check for a GError
536 when calling tny_folder_get_headers(), to show that this is not the cause
539 2007-06-20 Murray Cumming <murrayc@murrayc.com>
541 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
542 Actually set the body query instead of the subject query.
544 * src/modest-search.c: (search_mime_part_ogs),
545 (search_mime_part_strcmp): Remove extra space from the text/* regex,
546 which would probably cause it to fail if we got this far.
548 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
549 to simplify the code.
550 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
551 be causing search-in-body to fail.
553 2007-06-20 Murray Cumming <murrayc@murrayc.com>
555 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
557 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
558 Better debug message when the folder cannot be found.
559 This should help with fixing projects.maemo.org bug #61287.
560 * src/modest-search.c: (add_hit): Do not leak the furl string.
562 2007-06-20 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-ui-actions.c:
565 (modest_ui_actions_on_folder_selection_changed):
566 Do not special-case TNY_MERGE_FOLDER here, because
567 modest_tny_folder_get_account() already does that. This fixes
568 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
569 shown when the Outbox was selected).
571 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
573 * libmodest-dbus-client/libmodest-dbus-client.c:
574 (_dbus_iter_get_string_or_null): Initialize the string variable in
575 case this helps with Dirk's crash.
577 2007-06-19 Murray Cumming <murrayc@murrayc.com>
579 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
580 though it is not implemented yet (this function is maybe not even used),
581 to avoid breaking ABI in future.
582 * libmodest-dbus-client/libmodest-dbus-client.c:
583 (get_attachments_string): Moved some code into this generic function.
584 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
585 sends email. It is maybe not used.
586 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
587 (on_send_mail): Use attachments.
589 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
590 * src/maemo/modest-msg-edit-window.c:
591 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
592 a filename before using it, to fix projects.maemo.org bug NB#58233.
594 2007-06-19 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
597 Initialize the continue_download variable to fix the build, and probably
598 to fix randome behaviour.
600 2007-06-18 Armin Burgmeier <armin@openismus.com>
602 * src/modest-tny-send-queue.h:
603 * src/modest-tny-send-queue.c: Keep track of the status of messages in
604 the queue so we can later show it in the UI. Replaced
605 modest_tny_send_queue_msg_is_being_sent() by
606 modest_tny_send_queue_get_msg_status().
608 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
610 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
611 gpointer. This probably was not harmful, but just to be sure.
613 2007-06-18 Murray Cumming <murrayc@murrayc.com>
615 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
616 Fix the build, but leave the function broken on Bora, because
617 hildon_uri_action_get_service() does not exist.
618 osso_uri_action_get_service() does not exist either, it seems.
620 2007-06-18 Murray Cumming <murrayc@murrayc.com>
622 * src/modest-tny-account.c:
623 (modest_tny_account_new_from_server_account):
624 Uncommented the url debug output again, because it is useful for
625 debugging, as I said in the comment.
627 2007-06-18 Murray Cumming <murrayc@murrayc.com>
629 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
631 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
632 for Mameo Bora, to fix the build.
634 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
637 Fixed build with hildon < 0.99
639 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
640 Check if the selected account is busy instead of checking all accounts
642 * src/modest-account-mgr-priv.h:
643 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
644 (modest_account_mgr_init), (compare_account_name),
645 (modest_account_mgr_set_account_busy),
646 (modest_account_mgr_account_is_busy):
647 * src/modest-account-mgr.h:
648 Added busy information to the account manager. It possible to
649 set an account to busy or not busy now.
651 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
652 (modest_mail_operation_update_account),
653 (modest_mail_operation_notify_end):
654 Set the account to busy/not busy depending on the operation state.
656 * src/widgets/modest-account-view.c:
657 (modest_account_view_finalize), (get_last_updated_string),
658 (update_account_view), (on_account_busy_changed), (init_view):
659 Show string "Refreshing..." if the account is currently busy.
661 All this fixes projects.maemo.org bug NB#59711
663 2007-06-14 Armin Burgmeier <armin@openismus.com>
665 * src/widgets/modest-attachments-view.h:
666 * src/widgets/modest-attachments-view.c: Added
667 modest_attachments_view_has_attachments() and fixed coordinate
668 transformation in get_att_view_at_coords(). This fixes attachment
671 * src/widgets/modest-msg-view.c: Make use of
672 modest_attachments_view_has_attachments() to decide whether to show
673 attachments in the header.
675 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
677 * src/maemo/modest-connection-specific-smtp-edit-window.c:
678 (on_change), (on_combo_security_changed),
679 (modest_connection_specific_smtp_edit_window_init),
680 (modest_connection_specific_smtp_edit_window_set_connection),
681 (modest_connection_specific_smtp_edit_window_is_dirty):
682 * src/maemo/modest-connection-specific-smtp-edit-window.h:
683 * src/maemo/modest-connection-specific-smtp-window.c:
686 Show an comfirmation dialog for the smpt-edit-window if there are
687 unsaved changes and the user hits cancel.
688 (projects.maemo.org bug NB#60479)
690 2007-06-14 Armin Burgmeier <armin@openismus.com>
692 * src/maemo/easysetup/modest-easysetup-wizard.c:
693 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
694 address" info in banner instead of node, and select all the text as
695 per UI spec. This fixes projects.maemo.org bug NB#60550.
697 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
699 reviewed by: <delete if not using a buddy>
701 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
702 * src/modest-ui-actions.c: (folder_refreshed_cb):
704 2007-06-14 Murray Cumming <murrayc@murrayc.com>
706 * src/widgets/modest-folder-view.c: (filter_row):
707 Explictly filter out the per-account outbox accounts. I don't know why
708 these only sometimes show up, but now they should never show up in the UI.
709 This should fix projects.maemo.org bug NB#60160.
711 2007-06-14 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
714 when the toolbar does not exist yet.
715 * src/modest-widget-memory.c: (save_settings_header_view):
716 Added g_warnings() to help us to discover when we are trying to set
717 an empty columns list in gconf.
719 2007-06-14 Murray Cumming <murrayc@murrayc.com>
723 Added modest_init_get_default_header_view_column_ids().
725 * src/modest-widget-memory.c: (restore_settings_header_view):
726 Use the new function to get defaults, if the gconf key is empty,
727 instead of not creating any columns. This seems to fix the
728 empty right-hand pane problems.
730 * src/widgets/modest-header-view.h: Improved documentation.
732 2007-06-13 Murray Cumming <murrayc@murrayc.com>
734 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
735 Revert the use of the display name as the account name, because this
736 is generally wrong and would break the code that follows.
738 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
740 * src/maemo/easysetup/modest-easysetup-wizard.c:
741 (check_for_supported_auth_methods), (on_before_next),
744 More correct fix for projects.maemo.org bug NB# 58991
745 Do not longer accept AUTH_PASSWORD as secure method and choose
746 correct method when creating the account.
748 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
750 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
751 Fixed projects.maemo.org bug NB# 58991
753 2007-06-13 Murray Cumming <murrayc@murrayc.com>
755 * src/modest-init.c: (modest_init_init_core),
756 (modest_init_local_folders): Fixed compilation errors.
758 2007-06-13 Murray Cumming <murrayc@murrayc.com>
760 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
761 Remove unnecessary lib/include, though it is good in principle when needed.
763 * src/modest-init.c: (modest_init_one_local_folder),
764 (modest_init_local_folders):
765 * src/modest-init.h: Initialize the .modest library for memory cards,
766 instead of just doing nothing for them. This should allow us to create
767 folders there, fixing projects.maemo.org bug NB#59297.
769 2007-06-13 Murray Cumming <murrayc@murrayc.com>
771 * libmodest-dbus-client/libmodest-dbus-client.c:
772 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
773 (libmodest_dbus_client_compose_mail),
774 (libmodest_dbus_client_open_message),
775 (libmodest_dbus_client_send_and_receive),
776 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
778 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
779 (on_idle_open_message), (modest_dbus_req_handler),
780 (search_result_to_message), (modest_dbus_req_filter):
781 * src/modest-search.c: (add_hit), (modest_search_folder),
782 (modest_search_all_accounts): Improved debug messages.
784 * tests/dbus_api/test_open_message.c: (main): Improved comments.
786 * src/modest-tny-account-store.c:
787 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
790 2007-06-13 Murray Cumming <murrayc@murrayc.com>
793 2007-06-12 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-tny-account-store.c: (get_server_accounts):
796 Call modest_tny_local_folders_account_add_merged_outbox_folders()
797 even when there are no accounts, so that the Outbox folder is always
798 visible. This fixes projects.maemo.org bug NB#60158.
800 2007-06-12 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/modest-main-window.c: (create_details_widget):
803 Use the mcen_va_never logical ID.
805 2007-06-12 Murray Cumming <murrayc@murrayc.com>
807 * src/dbus_api/modest-dbus-api.h:
808 * src/dbus_api/modest-dbus-callbacks.c:
809 (on_idle_open_default_inbox), (on_open_default_inbox),
810 (modest_dbus_req_handler):
811 Added a new OpenDefaultInbox method.
813 * libmodest-dbus-client/libmodest-dbus-client.h:
814 * libmodest-dbus-client/libmodest-dbus-client.c:
815 Added libmodest_dbus_client_open_default_inbox() to call the new
816 dbus method. This should be useful to projects.maemo.org bug NB#57214,
817 though it should maybe be used by a new osso-email-interface function.
819 * tests/dbus_api/Makefile.am:
820 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
823 2007-06-12 Murray Cumming <murrayc@murrayc.com>
825 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
826 NULL, so that the signals get all the keys. This should not actually
827 change any behaviour because we currently update everything when anything
830 2007-06-12 Murray Cumming <murrayc@murrayc.com>
832 * src/widgets/modest-folder-view.c: (text_cell_data),
833 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
834 (find_inbox_iter): If tinymail tells us that the folder is
835 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
836 This causes the inbox to be selected at startup, fixing part of
837 projects.maemo.org bug NB#56305.
839 * src/modest-ui-dimming-rules.c:
840 (modest_ui_dimming_rules_on_tools_smtp_servers):
841 * src/modest-ui-dimming-rules.h: Added a callback function to dim
842 the SMTP servers menu item.
843 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
844 that the SMTP Servers menu item is dimmed when there are no accounts,
845 as a future version of the UI spec will require. This fixes
846 projects.maemo.org bug NB#56305.
848 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
850 * src/maemo/modest-maemo-utils.c:
851 (modest_maemo_utils_get_supported_secure_authentication_methods):
852 Added label to dialog instead of unreadable title
854 * src/maemo/modest-main-window.c: (sync_accounts_cb),
855 (modest_main_window_new):
856 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
859 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
860 * src/modest-account-mgr.h:
861 Added method to avoid code duplication
863 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
864 (modest_ui_actions_on_send_receive):
865 Use modest_account_mgr_has_accounts
867 2007-06-11 Murray Cumming <murrayc@murrayc.com>
869 * src/maemo/easysetup/modest-presets.c:
870 (modest_presets_get_info_server_security): Do not report secure auth
872 * src/modest-protocol-info.c: Use the defines for the gconf key names
873 for secure authentication. This was not working because we were writing
874 Password and reading password, and the check was case sensitive.
875 With this, gmail now works for receiving and sending when created via
878 2007-06-11 Murray Cumming <murrayc@murrayc.com>
880 * src/maemo/easysetup/modest-presets.c:
881 (modest_presets_get_info_server_security): Correct the key name for
882 SecureSmtp, because it seems to be case-sensitive.
883 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
884 Do not try to get the 0th notebook page if there are 0 pages, to
887 2007-06-11 Murray Cumming <murrayc@murrayc.com>
889 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
890 Prevent use of the new notification feature for now, because it currently
891 shows one dialog for each new email, which is annoying.
893 2007-06-11 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
896 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
897 when no country was selected, so that we show the global ones.
898 * src/maemo/easysetup/modest-presets.c:
899 (modest_presets_get_providers): Return only the global providers, not
900 all providers when mmc=0 was requested.
902 2007-06-11 Murray Cumming <murrayc@murrayc.com>
904 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
905 (easysetup_provider_combo_box_fill): Remove debug code that showed the
906 provider ID in the combo.
908 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
909 Do not show the page numbers, because it would be confusing when we add
910 the 2 extra pages for the custom setup, when the user chooses the "Other"
911 provider. This fixes projects.maemo.org bug NB#59028
913 * src/modest-init.c: (modest_init_init_core),
914 (modest_init_local_folders):
916 * src/modest-tny-account.c:
917 (modest_tny_account_new_for_local_folders): Do not create default folders
918 for the memory card. This should fix projects.maemo.org bug NB#59328.
920 2007-06-11 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
923 Free the changed_conf_keys string items. They are already freed in the
924 idle handler if that runs first.
926 2007-06-11 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-ui-actions.c:
929 (modest_ui_actions_on_password_requested): Check that the server name
930 is not NULL, because I just saw a password dialog with (null) as the
933 * src/modest-tny-folder.[h|c]: Added
934 modest_tny_folder_is_memory_card_folder().
935 * src/modest-ui-dimming-rules.c:
936 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
937 menu item for memory cards, as per the UI spec (section 7.4). This should
938 fix projects.maemo.org bug NB#59297.
940 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
942 * src/maemo/modest-main-window.c: (sync_accounts_cb):
943 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
944 is another problem with the code, see Murray's comment at line 772)
946 2007-06-08 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
949 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
950 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
951 (load_from_file), (easysetup_country_combo_box_init),
952 (easysetup_country_combo_box_get_active_country_ids),
953 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
954 instead of just one ID, to avoid duplicate country names in the UI.
956 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
957 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
958 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
959 a single ID, avoiding duplicate providers.
960 * src/maemo/easysetup/modest-easysetup-wizard.c:
961 (on_combo_account_country): Adapt to use a list.
963 2007-06-08 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
966 keys changed in the last X seconds.
968 * src/modest-account-mgr.h:
969 * src/modest-account-mgr.c: (on_timeout_notify_changes),
970 (on_key_change), (modest_account_mgr_class_init),
971 (modest_account_mgr_init), (modest_account_mgr_finalize):
972 As the keys are changed, save them in a GSList* and signal that GSList*
973 further every X seconds, to batch changes, to allow us to do just one
974 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
975 bug NB#56941 and other (UI-blocking) delays when changing account settings.
977 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
978 changed signal signature.
980 * src/modest-conf.c: (modest_conf_set_list),
981 (modest_conf_on_change): Reenable notification.
983 (modest_conf_maemo_fake_on_change): Comment out the hack that
984 notified immediately instead of asynchronously.
986 * src/widgets/modest-account-view.h:
987 * src/widgets/modest-account-view.c:
988 (update_account_view): Select the previously-selected account ID,
989 if possible. This fixes projects.maemo.org bug NB#56933.
991 (on_account_changed), (on_account_removed),
992 (modest_account_view_select_account):
994 Remove the block/unblock functions
995 because they were not useful.
997 * src/maemo/modest-account-view-window.c:
998 (on_delete_button_clicked), (on_edit_button_clicked),
999 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1001 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1004 Improve the error dialog to show Incorrect Account Settings, which seems
1005 clearer, and say that the internal error message (to be removed from the
1006 dialog later) is often misleading.
1007 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1009 * src/modest-tny-account.c:
1010 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1011 URL because this is so useful for debugging on the device.
1013 * src/widgets/modest-serversecurity-combo-box.c:
1014 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1016 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-mail-operation.c:
1019 (modest_mail_operation_send_new_mail):
1020 Added a comment about a nasty but apparently harmless message. Details
1021 added to the wiki g_warnings() page.
1023 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1025 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1026 (modest_tny_send_queue_class_init):
1027 Do not use the priv struct because it is empty, to avoid g_warnings
1028 about a non-existant priv struct.
1030 * src/modest-tny-account-store.c:
1031 (modest_tny_account_store_get_server_account),
1032 (modest_tny_account_store_get_transport_account_for_open_connection
1033 ): Do not try to get transport server accounts for local folders,
1034 because they don't have any. This avoids a g_warning().
1036 * src/maemo/modest-main-window.c:
1037 (modest_main_window_notify_send_receive_initied),
1038 (on_configuration_key_changed):
1039 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1040 * src/modest-defs.h:
1041 * src/modest-mail-operation.c:
1042 (modest_mail_operation_update_account):
1043 * src/modest-tny-account-store.h:
1044 * src/modest-tny-account.c:
1045 (modest_tny_account_get_special_folder),
1046 (modest_tny_account_new_for_local_folders),
1047 (modest_tny_account_new_for_per_account_local_outbox_folder):
1048 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1049 * src/modest-tny-local-folders-account.c:
1050 (add_account_folders_to_merged_folder):
1051 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1052 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1053 (modest_ui_actions_on_send):
1054 * src/widgets/modest-folder-view.c: (update_model):
1055 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1056 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1057 modest_tny_account_store_get_tny_account_by_account() to
1058 modest_tny_account_store_get_server_account() to make the code clearer.
1060 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1062 * src/dbus_api/modest-dbus-api.h:
1063 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1064 * src/maemo/modest-msg-edit-window.c:
1065 (modest_msg_edit_window_attach_file_noninteractive):
1066 added g_warning in case the file to be attached does not exist
1067 * tests/dbus_api/test_compose_mail.c: (main):
1068 removed obsolete comment, added generic files as test case
1070 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1072 * src/modest-tny-account-store.c: (get_server_accounts):
1073 Create the local folders account only once, not once for each outbox, and
1074 not only when there are some outboxes.
1076 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1078 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1079 code that is causing a crash at startup. Sergio says that he is fixing this.
1081 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1083 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1084 * src/maemo/modest-account-settings-dialog.c:
1085 (create_page_outgoing),
1086 (modest_account_settings_dialog_set_account_name),
1087 (save_configuration):
1088 - Fixed handling of the "Use secure authentication" toggle to comply with
1089 the ui specification. See also projects.maemo.org bug NB#58400
1091 - Restore the Secure connection setting combo correctly when loading
1094 * src/maemo/modest-maemo-utils.c:
1095 (on_camel_account_get_supported_secure_authentication),
1096 (modest_maemo_utils_get_supported_secure_authentication_methods):
1097 Fixed a crasher if operation is canceled
1099 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1100 (modest_protocol_info_auth_is_secure):
1101 * src/modest-protocol-info.h:
1103 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1104 the sense of the "Use secure authentication" toggle.
1106 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1108 * src/modest-tny-account-store.h:
1109 * src/modest-tny-account-store.c:
1110 Added modest_tny_account_store_get_local_folders_account().
1112 * src/modest-tny-folder.h:
1113 * src/modest-tny-folder.c:
1114 (modest_tny_folder_get_account):
1115 Added this replacement for tny_folder_get_account() which returns
1116 the local-folders account for TnyMergeFolders, to avoid the
1117 warning about the unimplemented get_account_func() vfunc().
1119 (modest_tny_folder_get_rules),
1120 * src/modest-ui-actions.c:
1121 (modest_ui_actions_on_folder_selection_changed):
1122 * src/modest-mail-operation.c:
1123 (modest_mail_operation_remove_folder),
1124 (modest_mail_operation_xfer_folder),
1125 (modest_mail_operation_rename_folder),
1126 (modest_mail_operation_get_msg),
1127 (modest_mail_operation_get_msgs_full),
1128 (modest_mail_operation_remove_msg),
1129 (modest_mail_operation_xfer_msgs),
1130 (modest_mail_operation_refresh_folder):
1131 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1133 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1136 (modest_server_account_set_security):
1137 * src/modest-defs.h: Add comments explaining that our
1138 UI spec means TLS when it says Normal, so these do not look like errors.
1140 * src/modest-tny-account.c:
1141 (modest_tny_account_new_from_server_account): Use the new tinymail
1142 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1143 for TLS. This should fix projects.maemo.org bug NB#58460.
1145 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1147 * src/maemo/easysetup/modest-easysetup-wizard.c:
1148 (create_account): Correct the position of the gconf sanity check warning.
1149 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1150 of using the g_idle_add() hack, because this does not seem to be necessary
1151 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1152 caused by something other than maemo's gconf.
1153 This fixes projects.maemo.org bug #59022.
1155 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-account-mgr-helpers.c:
1158 (modest_account_mgr_get_default_account): Do not check that the account
1159 exists if there is no default account (NULL), to fix a runtime warning.
1161 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1163 * src/widgets/modest-folder-view.c: (update_model):
1164 Do not unref the treemodel before we have finished with it.
1165 This prevents a valgrind warning and an occasional crash at startup.
1167 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1169 * libmodest-dbus-client/libmodest-dbus-client.h:
1170 added libmodest_dbus_client_compose_mail()
1171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1173 added functions needed for SendAsMail() functionality
1174 * src/maemo/modest-msg-edit-window.c:
1175 (modest_msg_edit_window_attach_file_noninteractive):
1176 non interactively attaching files to message edit window
1177 * src/widgets/modest-msg-edit-window.h:
1178 * tests/dbus_api/Makefile.am:
1179 added test_compose_mail.c
1180 * tests/dbus_api/test_compose_mail.c: (main):
1182 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1184 * src/modest-account-view.c:
1185 Fixed bug projects.maemo.org bug NB#59307
1187 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 (get_serverport_incoming), (on_before_next), (create_account):
1191 * src/maemo/modest-account-settings-dialog.c:
1192 (modest_account_settings_dialog_set_account_name):
1193 * src/maemo/modest-maemo-utils.c:
1194 (on_camel_account_get_supported_secure_authentication_status),
1195 (on_camel_account_get_supported_secure_authentication),
1196 (on_secure_auth_cancel),
1197 (modest_maemo_utils_get_supported_secure_authentication_methods):
1199 Implemented security authentication for settings and easysetup.
1201 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-main-window.c: (create_details_widget):
1204 Show the total size for memory card accounts too, instead of showing
1205 the name again. Fixes bug projects.maemo.org bug NB#59307.
1207 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-tny-simple-folder-store.c:
1211 * src/modest-tny-simple-folder-store.h: Removed.
1213 * src/modest-tny-local-folders-account.h
1214 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1215 for the local-folders maildir, with an extra TnyMergedFolder containing
1216 the folders of the per-account outbox store accounts.
1217 * src/modest-tny-account-store.c: (get_server_accounts):
1218 Add the outboxes to the special local folders account after creating it.
1220 * src/modest-tny-account.c:
1221 (modest_tny_account_new_for_local_folders): Create the derived
1222 account when creating the main local-folders account.
1224 * src/maemo/modest-main-window.c: (create_details_widget),
1225 (modest_main_window_set_contents_style):
1226 Adapted to the use of the derived account instead of the folder store.
1228 * src/modest-ui-actions.c:
1229 (modest_ui_actions_on_folder_selection_changed):
1230 * src/modest-ui-dimming-rules.c:
1231 (modest_ui_dimming_rules_on_new_folder):
1232 * src/widgets/modest-folder-view.c: (text_cell_data),
1233 (icon_cell_data), (filter_row), (update_model),
1234 (get_cmp_rows_type_pos):
1237 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1238 Do not get the priv struct, because no priv struct has been set,
1239 to avoid a runtime warning.
1241 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1242 #ifelse with #else, to fix a warning, to fix the build.
1245 2007-06-05 Christian Kellner <ckellner@openismus.com>
1247 * libmodest-dbus-client/libmodest-dbus-client.c:
1248 Fix small typo in doc (why do you always see them
1249 AFTER committing stuff?)
1252 2007-06-05 Christian Kellner <ckellner@openismus.com>
1254 * libmodest-dbus-client/libmodest-dbus-client.c:
1255 (libmodest_dbus_client_search):
1256 Initialize hit list with NULL. Also set folder list
1257 to "" if NULL was supplied.
1260 2007-06-03 Christian Kellner <ckellner@openismus.com>
1262 * libmodest-dbus-client/libmodest-dbus-client.c:
1263 (modest_search_hit_list_free):
1264 Make it save to call it with NULL.
1266 * src/dbus_api/modest-dbus-callbacks.c:
1267 * src/modest-search.c:
1268 Return full ModestSearchHits as the search result list not TnyHeader
1269 since can't be around withouth the correspoding TnyFolder.
1271 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1273 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1274 Added currently commented code to check for secure auth
1276 * src/maemo/modest-account-settings-dialog.c: (on_response),
1277 (save_configuration), (show_ok):
1278 Fixed projects.maemo.org bugs NB #59248 and #59251
1280 * src/maemo/modest-maemo-utils.c:
1281 (on_camel_account_get_supported_secure_authentication_status),
1282 (on_camel_account_get_supported_secure_authentication),
1283 (modest_maemo_utils_get_supported_secure_authentication_methods):
1284 * src/maemo/modest-maemo-utils.h:
1285 Moved get_supported_secure_authentication() method here to be able
1286 to use it from easysetup wizard.
1288 * src/modest-pair.c: (on_pair_compare_as_string):
1289 Should compare string with first part of pair and not
1290 strcmp pairs which will crash.
1292 * src/modest-protocol-info.c:
1293 (modest_protocol_info_protocol_is_store):
1294 * src/modest-protocol-info.h:
1295 Added modest_protocol_info_get_auth_protocol_name()
1297 2007-06-03 Armin Burgmeier <armin@openismus.com>
1299 * src/modest-mail-operation.c:
1300 (modest_mail_operation_get_msgs_full): Set priv->account also when
1301 only retrieving a single message. This avoids a crash when canceling
1304 (modest_mail_operation_notify_end): Do not explicitely remove the
1305 operation from the queue but only emit the progress_changed signal.
1306 The queue itself listens to that signal to remove the operation when
1307 it is finished. This reduces coupling and removes a potential deadlock
1308 when modest_mail_operation_notify_end() is called from the queue
1309 itself. If that is a problem performance-wise, I would suggest to
1310 implement a status-changed signal or something.
1312 * src/modest-mail-operation-queue.c: Make sure to never call a
1313 function from another file while the queue is locked. This (hopefully)
1314 fixes another deadlock when exiting the application while retrieving
1317 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1319 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1320 Fixed build if libogs is not available
1322 2007-06-03 Christian Kellner <ckellner@openismus.com>
1324 * libmodest-dbus-client/libmodest-dbus-client.h:
1325 * libmodest-dbus-client/libmodest-dbus-client.c:
1326 (libmodest_dbus_client_delete_message):
1327 Implement deletion of messages (Client side).
1329 (modest_search_hit_free),
1330 (modest_search_hit_list_free):
1331 Utility functions to free the result hits.
1333 * src/dbus_api/modest-dbus-api.h:
1334 * src/dbus_api/modest-dbus-callbacks.c:
1335 (on_delete_message),
1336 (modest_dbus_req_handler):
1337 Implement deletion of messages (Server side).
1339 * tests/dbus_api/test_search.c: (main):
1342 * tests/dbus_api/Makefile.am:
1343 * tests/dbus_api/test_delete_message:
1344 Add little test for the message deletion logic
1346 2007-06-03 Armin Burgmeier <armin@openismus.com>
1348 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1349 when the operation queue was not empty. projects.maemo.org bug
1352 2007-06-03 Armin Burgmeier <armin@openismus.com>
1354 * src/widgets/modest-account-view.c
1355 (on_account_default_toggled): Toggle default account column
1356 explicitely instead of waiting for gconf notification (which is
1357 currently ignored). This should fix projects.maemo.org bug NB#56910
1358 for now. It should probably be removed when gconf notifications are
1361 2007-06-03 Christian Kellner <ckellner@openismus.com>
1363 * libmodest-dbus-client/libmodest-dbus-client.c:
1364 Removed debugging spew.
1366 * src/dbus_api/modest-dbus-callbacks.c:
1367 Added debugging info.
1369 * src/modest-search.c:
1370 (modest_search_all_accounts):
1371 Use tny_account_store_get_accounts () on the account store
1372 to get all accounts which is the way to get all accounts.
1374 * tests/dbus_api/test_search.c: (main):
1375 Make it possible to supply the search term on the command line.
1377 2007-06-03 Christian Kellner <ckellner@openismus.com>
1379 * libmodest-dbus-client/libmodest-dbus-client.c:
1380 * libmodest-dbus-client/libmodest-dbus-client.h:
1381 Implement searching for mesages over raw dbus. (Client side)
1383 * src/dbus_api/Makefile.am:
1384 * src/dbus_api/modest-dbus-api.h:
1385 * src/dbus_api/modest-dbus-callbacks.c:
1386 * src/dbus_api/modest-dbus-callbacks.h:
1387 Search framework (Server side). Also implement on_idle_open_message().
1389 * src/maemo/modest-platform.c: (modest_platform_init):
1390 Prepare for raw dbus/osso rpc interaction.
1392 * src/modest-search.h:
1393 Changed minsize from unspecific guint to guint32.
1395 * src/modest-search.c:
1397 Added strange hack which magically made tnymail work.
1399 (modest_search_folder),
1400 (modest_search_account),
1401 (modest_search_all_accounts):
1402 Implement helper functions to search all accounts, specific account
1405 * tests/dbus_api/Makefile.am:
1406 * tests/dbus_api/test_open_message.c:
1407 Read url to open from commandline.
1409 * tests/dbus_api/test_search.c:
1410 Implement small test for dbus search stuff
1412 2007-06-02 Armin Burgmeier <armin@openismus.com>
1414 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1415 include account type and account title. This fixes projects.maemo.org
1418 * src/maemo/modest-account-view-window.c: Set a title for the window.
1420 2007-06-02 Armin Burgmeier <armin@openismus.com>
1422 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1423 incoming and outgoing server name based on email address and server
1424 types as long as the names have not been edited manually. This fixes
1425 projects.maemo.org bug NB#58671.
1427 2007-06-02 Armin Burgmeier <armin@openismus.com>
1429 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1430 server type cannot be changed in future to the incoming details page
1431 when creating an account. This fixes projects.maemo.org bug NB#59029.
1433 2007-06-02 Armin Burgmeier <armin@openismus.com>
1435 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1436 and assigned max width chars so that they wrap instead of being
1437 truncated. Fixes projects.maemo.org bug NB#56126.
1439 2007-06-02 Armin Burgmeier <armin@openismus.com>
1441 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1442 introductory note to the connection specific smtp servers dialog, as
1443 section 8.12 of the email UI specification requires. This fixes
1444 projects.maemo.org bug NB#59212.
1446 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1448 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1449 Check for running mail operations, and offer to cancel them, as per the UI
1450 spec. This fixes projects.maemo.org bug NB#59041 .
1451 However, I suspect that tinymail may still use the network connection
1452 in ways that we cannot detect or cancel. But it should at least adapt to
1453 changes fairly well.
1455 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1457 * src/modest-tny-account-store.c: (recreate_all_accounts),
1458 (get_cached_accounts), (get_server_accounts): Do more sensible
1459 ref-counting of the temporarily-cached outbox accounts list. This seems
1460 to fix a crash when entering the password when the password was wrong.
1462 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1464 * src/gnome/modest-main-window.c: (connect_signals):
1465 * src/modest-tny-account-store.c: (get_password),
1466 (modest_tny_account_store_alert): Added comments and clues and
1467 commented-out code about how we currently fail to deal with connection
1468 errors and wrong passwords, and how we should.
1470 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1472 * src/widgets/modest-retrieve-combo-box.c:
1473 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1474 This fixes projects.maemo.org bug NB#58472 .
1476 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/easysetup/modest-easysetup-wizard.c:
1479 (create_page_complete_easysetup):
1480 (create_page_complete_custom): Correct the last commit,
1481 putting the correct sentences in the correct pages.
1483 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/easysetup/modest-easysetup-wizard.c:
1486 (create_page_complete_custom): Show the second sentence of text
1487 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1490 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1493 Set the leave-on-server conf key by default. This fixes
1494 projects.maemo.org bug NB#59258 .
1496 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/modest-account-view-window.c:
1499 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1500 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1503 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1505 * src/maemo/easysetup/modest-easysetup-wizard.c:
1506 (create_caption_new_with_asterisk):
1507 * src/maemo/modest-account-settings-dialog.c:
1508 (create_caption_new_with_asterisk):
1509 Uncomment the code to add the asterisk, because they are no longer in the
1510 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1511 (update_incoming_server_title): Add an asterisk here too.
1513 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/modest-maemo-global-settings-dialog.c:
1516 (current_connection): Check that we are even connected before trying to
1517 get the current connection name, to prevent a warning.
1519 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1520 Change the comments because tny_maemo_conic_device_connect() is now meant to
1522 * src/modest-mail-operation.c:
1523 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1524 make sure we have a connection and fail if we can't connect.
1526 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/modest-main-window.c:
1529 (on_account_store_connecting_finished): Do not try to get the
1530 connection ID if we are not really connected. I am surprised that
1531 this signal handler is called when we are not connected.
1533 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1535 * src/modest-error.h:
1536 * src/modest-ui-actions.c:
1537 (modest_ui_actions_get_msgs_full_error_handler):
1538 Renamed an enum, added comments, added an enum
1539 for retrieve-limit errors.
1541 * src/modest-mail-operation.c: (foreach_add_item),
1542 (internal_folder_observer_update), (update_account_thread),
1543 (modest_mail_operation_get_msgs_full):
1544 (modest_mail_operation_update_account),
1545 Added comments about how this works, and some code that should
1546 (but does not) check the retrieve-limit. See the TODO comment.
1548 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1550 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1551 Initialize help_id to fix the build. Warnings are good.
1553 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1555 * src/widgets/modest-hbox-cell-renderer.c:
1556 (modest_hbox_cell_renderer_append):
1557 * src/widgets/modest-vbox-cell-renderer.c:
1558 (modest_vbox_cell_renderer_append):
1559 Fix the last commit by doing an extra ref.
1561 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1563 * src/widgets/modest-hbox-cell-renderer.c:
1564 (modest_hbox_cell_renderer_append):
1565 * src/widgets/modest-vbox-cell-renderer.c:
1566 (modest_vbox_cell_renderer_append):
1567 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1568 to fix the build with Maemo Bora.
1569 However, there seems to be a remaining crash, probably due to reference
1572 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1574 * src/modest-tny-account.c:
1575 (modest_tny_account_new_for_local_folders):
1576 Use hildon_file_system_info_async_new() to get a better name for
1577 the memory card account, setting it as the account name.
1578 The timing seems to work, but this is probably
1579 not the best place to do this. See the TODO comment.
1580 * src/maemo/modest-main-window.c: (create_details_widget):
1581 * src/widgets/modest-folder-view.c: (text_cell_data):
1582 Use the tny account name instead of hardcoding a name.
1584 2007-05-30 Christian Kellner <ckellner@openismus.com>
1586 * src/modest-search.c: (modest_search):
1587 Correctly set part_search_func even if we have already parsed
1588 the query and thus a valid OgsTextSearcher object.
1590 2007-05-30 Christian Kellner <ckellner@openismus.com>
1593 Search and check for libogs.
1596 Incooparte the ogs build env.
1598 * src/modest-mime-part-search-stream.c:
1599 * src/modest-mime-part-search-stream.h:
1600 Removed since we do the real searching now in modest-search.c.
1602 * src/modest-search.c:
1603 * src/modest-search.h:
1604 Implement support for ogs. We use that if available and requested
1605 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1606 should now handle the corner case when the search term is spread
1607 across multiple reads.
1608 Also the logic in modest_search () was corrected to search all
1609 requested fields until one is found.
1611 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1615 * src/modest-init.h:
1616 * src/modest-init.c: Made modest_init_local_folders() take a
1617 path and be public so we can iniitialize maildir folders on
1620 * src/modest-local-folder-info.h:
1621 * src/modest-local-folder-info.c:
1622 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1624 * src/modest-tny-account.c:
1625 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1626 still means the standard local-folders path on the local volume.
1628 * src/modest-tny-account-store.c:
1629 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1630 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1631 all accounts when that happens.
1632 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1633 this too, so it shows up in the treeview.
1635 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/modest-maemo-global-settings-dialog.c:
1638 (current_connection):
1639 * src/widgets/modest-global-settings-dialog.c:
1640 (current_connection_default):
1641 Use the enum values instead of 0, 1 and -1,
1642 to make the code clearer.
1644 * src/modest-account-mgr-helpers.c:
1645 (modest_account_mgr_get_connection_specific_smtp): Make this code
1648 * src/modest-runtime.h:
1649 * src/modest-runtime.c:
1650 Added modest_runtime_remove_all_send_queues().
1651 * src/maemo/modest-main-window.c:
1652 (on_account_store_connecting_finished): Recreate the send queues,
1653 using the appropriate transport accounts for this new connection.
1654 Some futher adapting might be needed if the old send queues are not
1655 automatically stopped at this point.
1657 * src/modest-tny-account-store.c: (get_server_accounts):
1658 Create the connection-specific transport accounts, so that they can
1659 be found later by their ID.
1661 * src/modest-tny-account.h:
1662 * src/modest-tny-account.c:
1663 Added modest_tny_account_new_from_server_account_name().
1664 modest_tny_account_new_from_server_account(): Do not create the
1665 send queues here, because they will be
1666 recreated anyway when the connection changes for the first time.
1668 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1670 * src/modest-local-folder-info.h:
1671 * src/modest-local-folder-info.c:
1672 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1673 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1674 tbox_folder): Take a modest account name instead of a server TnyAccount,
1675 so we can have per-modest-account rather than per-transport-account
1677 We must make sure that we change or recreate the exisitng send queues
1678 when the connection changes for connection-specific transport accounts.
1680 * src/modest-tny-account-store.c:
1681 (create_per_account_local_outbox_folders): Create outboxed per modest
1682 account, not per transport account.
1684 * src/modest-tny-account.h:
1685 * src/modest-tny-account.c:
1686 (modest_tny_account_get_special_folder): For outboxes, get the
1687 parent modest account name. The account is ignored for other folders.
1688 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1689 modest account name rather than a server TnyAccount.
1691 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-tny-account.c:
1694 (modest_tny_account_new_from_server_account):
1695 Call modest_runtime_get_send_queue() immediately after creating transport
1696 accounts, so that they start trying to send email from the outbox as soon
1697 as possible at startup. This is probably what we want.
1699 * src/modest-mail-operation.c: (update_account_thread):
1700 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1701 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1702 * src/modest-tny-send-queue.h:
1703 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1704 (modest_ui_actions_on_send):
1705 Added comments about how sending works, though it needs some more work.
1707 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-tny-account.c:
1710 (modest_tny_account_get_special_folder): Add TODO because this fails when
1711 the network is busy.
1712 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1713 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1714 Do not try to show this window when there is no active account. The UI
1715 specs does not tell us what to do in this case.
1717 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1721 * src/maemo/Makefile.am:
1722 * src/widgets/Makefile.am: Some dist fixes.
1724 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1726 * src/maemo/modest-connection-specific-smtp-window.c:
1727 (on_button_edit): Make the code clearer, to prevent a double free.
1729 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1731 * src/maemo/modest-account-settings-dialog.c:
1732 (modest_account_settings_dialog_set_account_name),
1733 Check the connection-specific smtp servers checkbox if there are any.
1735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1736 (modest_connection_specific_smtp_edit_window_init):
1737 Start with a suitable port number.
1739 * src/modest-account-mgr-helpers.h:
1740 * src/modest-account-mgr-helpers.c: Added
1741 modest_account_mgr_get_has_connection_specific_smtp().
1743 (modest_account_mgr_set_connection_specific_smtp),
1744 (modest_account_mgr_remove_connection_specific_smtp),
1745 (modest_account_mgr_get_has_connection_specific_smtp),
1746 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1747 connection-specific smtp server accounts in the account, rather than
1748 the server account conf dir.
1750 This fixes bug projects.maemo.org bug NB#58263 .
1752 * src/modest-tny-account-store.c:
1753 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1754 if there are no server accounts yet, to prevent an infinite loop when there
1755 are no accounts. Document that one must be called before the other.
1757 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1759 * src/modest-account-mgr-helpers.c:
1760 (modest_account_mgr_get_default_account): Make sure that at least
1761 one account is always the default, if there are any enabled accounts.
1762 This is just a sanity check that shouldn't be necessary.
1764 * src/modest-account-mgr-priv.c:
1765 (_modest_account_mgr_account_from_key): Unescape the conf key to
1766 get the real account name. For instance, this is an issue if a space
1767 was in the account name, which can happen because the account name
1768 is generated from the display name.
1769 (_modest_account_mgr_get_account_keyname): Always escape the
1771 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1772 Unescape the conf keys to get the real account names.
1774 For instance, previously the is-default radio button in the accounts
1775 list was not checked for any accounts at first. This fixes that,
1776 and might fix several similar bugs.
1778 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1780 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1781 Removed some debug printfs.
1783 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1785 Modest on-disk outbox directories are now here, for instance:
1786 $HOME/.modest/outboxes/<account-id-1>/outbox
1787 $HOME/.modest/outboxes/<account-id-2>/outbox
1789 $HOME/.modest/local-folders/outbox
1790 so we can have a separate outbox for each account.
1791 But they are shown as one outbox in the GtkTreeView, by using a
1792 TnyMergeFolder in a ModestTnySimpleFolderStore.
1795 * src/modest-tny-simple-folder-store.c:
1796 * src/modest-tny-simple-folder-store.h:
1797 Added ModestTnySimpleFolderStore, used to contain folders from
1798 other folder stores, such as other accounts.
1800 * src/modest-tny-outbox-account.h:
1801 * src/modest-tny-outbox-account.c:
1802 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1803 used for the per-account local outbox folders.
1805 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1806 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1807 only use this (internally) now for the non-outbox local folders.
1809 * src/modest-init.h:
1810 * src/modest-init.c: Added modest_init_one_local_folder(), for
1811 setting up the directory structure for each local folder.
1813 * src/modest-local-folder-info.c:
1814 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1815 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1817 * src/modest-local-folder-info.h:
1818 * src/modest-tny-account-store.c: (on_account_removed),
1819 (on_account_changed), (create_per_account_local_outbox_folders),
1820 (get_server_accounts), (modest_tny_account_store_get_accounts),
1821 (modest_tny_account_store_get_tny_account_by_account),
1822 (modest_tny_folder_store_is_virtual_local_folders):
1824 * src/modest-tny-account.h:
1825 * src/modest-tny-account.c:
1826 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1827 to create an on-disk per-account local outbox folder for each
1829 (create_per_account_local_outbox_folders): Create a local outbox folder
1830 for each transport account.
1831 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1832 for all local folders.
1834 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1835 instead of using g_object_get/set() directly. It is clearer.
1837 (modest_tny_folder_store_get_message_count),
1838 (modest_tny_folder_store_get_local_size
1839 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1840 because we now use these with non-acount folder stores.
1842 (modest_tny_account_get_special_folder),
1843 (modest_tny_account_new_from_server_account),
1844 (modest_tny_account_new_from_account):
1845 (recurse_folders): Adjust to the new outbox system.
1847 * src/modest-tny-folder.h:
1848 * src/modest-tny-folder.c:
1849 (modest_tny_folder_is_local_folder),
1850 (modest_tny_folder_get_local_folder_type),
1851 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1853 * src/widgets/modest-main-window.h:
1854 * src/maemo/modest-main-window.c: (create_details_widget),
1855 (modest_main_window_set_contents_style): Show details for any folder store,
1858 (modest_tny_folder_get_rules):
1859 Remove the const. C does not support constness enough for this.
1861 * src/modest-ui-actions.c:
1862 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1863 make all outboxes appear as one, in the usual local-folders tree node.
1865 (set_active_account_from_tny_account),
1866 (modest_ui_actions_on_folder_selection_changed):
1867 * src/widgets/modest-folder-view.c: (text_cell_data),
1868 (icon_cell_data), (filter_row),
1869 (add_account_folders_to_merged_folder),
1870 (add_account_folders_to_simple_folder_store), (),
1871 (get_cmp_rows_type_pos), (cmp_rows),
1872 (modest_folder_view_set_account_id_of_visible_server_account):
1873 Adjust to the new outbox system, using generic folder stores and folders
1874 in the GtkTreeModel.
1876 2007-05-23 Christian Kellner <ckellner@openismus.com>
1878 * src/modest-mail-operation.c:
1879 (modest_mail_operation_update_account):
1880 Use info->max_size instead of unintialized local var [small
1881 build fix]. (Added TODO to review that change since I don't
1884 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1886 * libmodest-dbus-client/libmodest-dbus-client.c:
1887 (libmodest_dbus_client_compose_mail): function added
1888 * src/dbus_api/modest-dbus-api.h:
1889 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1890 (on_compose_mail): Implementation of the SendAsMail functionality
1892 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-account-mgr.c:
1895 (modest_account_mgr_add_server_account): Set the secure-connection
1896 conf key for transport accounts as well as store accounts. I don't know
1897 why the if was there. For instance, this makes sure that we use SSL
1898 for the gmail preset from the easysetup wizard.
1900 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1902 * src/gnome/modest-main-window.c:
1903 (on_account_store_connecting_finished), (connect_signals):
1904 * src/maemo/modest-main-window.c:
1905 (on_account_store_connecting_finished), (connect_signals),
1906 (modest_main_window_new):
1907 Handle TnyAccountStore::connecting-finished instead of
1908 TnyDevice::connection-changed, because we cannot actually perform
1909 operations on accounts until TnyAccountStore has itself responded to
1910 the TnyDevice::connection-changed signal. This prevents a GError from
1912 Do not try to update at startup, because we (at least on scratchbox)
1913 already do an update at startup when the device goes online.
1914 This prevents a GError from tinymail.
1915 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1916 Added TODO about stopping simultaneous operations.
1918 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1921 * src/modest-mail-operation-queue.c:
1922 (modest_mail_operation_queue_remove):
1923 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1924 about where they happened.
1926 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1928 * src/modest-ui-actions.c:
1929 (modest_ui_actions_on_password_requested): Make sure that the remember
1930 output parameter is always TRUE.
1932 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1934 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1935 Show a OK/Cancel dialog if the error is a question, though we still do not
1936 know anything more about what we are asking the user.
1937 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1938 Fix an uninitialized variable (helper). This is a logic error, however.
1940 2007-05-21 Christian Kellner <ckellner@openismus.com>
1942 * src/modest-search.h:
1943 Correct bit shifting in the ModestSearchFlags enum.
1945 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-tny-account.c:
1948 (modest_tny_account_new_from_server_account): Do not use the lsub and
1949 check-all hard-coded IMAP options when using POP.
1951 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-tny-account.c:
1954 (modest_tny_account_new_from_server_account):
1955 Use NULL for the secure-auth method for POP when Password auth has been
1956 specified by the user, as we already do for IMAP. "auth=Login" causes
1957 an error from camel or the server.
1959 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-account-settings-dialog.c:
1962 (create_page_account_details),
1963 (modest_account_settings_dialog_set_account_name):
1964 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1965 for the leave-on-server checkbox, rathr than just the checkbox, when
1966 the protocol is not POP.
1968 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1970 * src/widgets/modest-account-view.c:
1971 * src/widgets/modest-account-view.h:
1972 Added modest_account_view_select_account() which will be useful later
1973 to asynchronously re-select the edited account.
1975 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1977 * src/maemo/modest-account-settings-dialog.c:
1978 (modest_account_settings_dialog_set_account_name):
1979 Automatically choose the port numbers based on the secure authentication
1980 methods, if they have not been chosen before.
1981 This fixes projects.maemo.org bug NB#56273 .
1983 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1985 * src/maemo/modest-main-window-ui.h:
1986 * src/modest-ui-actions.c:
1987 * src/modest-ui-actions.h:
1988 Connect the Tools/SMTP Servers menu item to
1989 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1990 SMTP servers dialog, as in the UI specification and saves changes when it
1991 is closed. This fixed projects.maemo.org bug NB#56305 .
1993 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/modest-connection-specific-smtp-window.c:
1996 (modest_connection_specific_smtp_window_init):
1997 Use gtk_window_set_default_size() to make this window big enough, so
1998 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2000 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2002 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2003 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2004 (modest_connection_specific_smtp_edit_window_init),
2005 Do not try to connect to a combobox signal before the combobox exists.
2006 This fixes the cras in projects.maemo.org bug NB#56288 .
2007 (modest_connection_specific_smtp_edit_window_get_settings):
2008 Remove the server_account_name parameter which was being checked for NULL
2009 though it was not used.
2011 * src/maemo/modest-connection-specific-smtp-window.c:
2012 (modest_connection_specific_smtp_window_fill_with_connections),
2013 (on_button_edit), (modest_connection_specific_smtp_window_init):
2014 Correct the number of treemodel columns to prevent a warning.
2015 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2016 libconic does not work.
2018 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2020 * src/modest-tny-account.c:
2021 (modest_tny_account_new_from_server_account):
2022 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2023 SMTP when "None" was chosen by the user. However, with my SMTP server that
2024 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2027 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2029 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2030 to explain the memory management issue with the ID in the ModestPair.
2032 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2033 (add_sending_page), (modest_account_assistant_finalize):
2034 * src/gnome/modest-gnome-global-settings-dialog.c:
2035 (create_updating_page), (create_composing_page):
2036 * src/gnome/modest-msg-edit-window.c: (get_transports),
2037 (init_window), (modest_msg_edit_window_finalize),
2038 (modest_msg_edit_window_get_msg_data):
2039 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2040 * src/gnome/modest-transport-widget.c:
2041 (modest_transport_widget_finalize), (smtp_configuration):
2042 * src/maemo/modest-maemo-global-settings-dialog.c:
2043 (create_updating_page), (create_composing_page):
2044 * src/maemo/modest-msg-edit-window.c: (get_transports),
2045 (init_window), (modest_msg_edit_window_finalize),
2046 (modest_msg_edit_window_get_msg_data),
2047 (modest_msg_edit_window_free_msg_data):
2048 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2049 (modest_store_widget_finalize):
2050 * src/maemo/modest-transport-widget.c:
2051 (modest_transport_widget_finalize), (smtp_configuration):
2052 * src/modest-main.c: (send_mail):
2053 * src/widgets/modest-combo-box.h:
2054 * src/widgets/modest-global-settings-dialog-priv.h:
2055 * src/widgets/modest-global-settings-dialog.c:
2056 (modest_global_settings_dialog_finalize):
2057 * src/widgets/modest-msg-edit-window.h:
2058 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2059 as long as the combo box, to prevent use of freed memory for the ID.
2061 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2063 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2064 get_accounts(), to make this clearer. Do not check for the enabled gconf
2065 key, because we do not use this for server accounts (at least, not yet).
2066 This allows us to send email again.
2068 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-platform.c:
2071 (on_modest_conf_update_interval_changed), (modest_platform_init):
2072 Only respond to this particular key change. All these strcmp()s cannot be
2075 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2077 * src/maemo/modest-maemo-global-settings-dialog.c:
2078 (current_connection): Prevent a crash in scratchbox when
2079 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2080 * src/maemo/modest-platform.c:
2081 (on_modest_conf_update_interval_changed), (modest_platform_init):
2082 Get the update interval from gconf and reset it when the gconf key changes.
2084 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2086 * src/modest-protocol-info.c:
2087 * src/modest-protocol-info.h: Adde enum-specific get functions,
2088 instead of using a ModestProtocolType enum parameter.
2090 * src/gnome/modest-account-assistant.c:
2091 * src/gnome/modest-store-widget.c:
2092 * src/gnome/modest-store-widget.h:
2093 * src/gnome/modest-transport-widget.c:
2094 * src/gnome/modest-transport-widget.h:
2095 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2096 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2097 * src/maemo/easysetup/modest-easysetup-wizard.c:
2098 * src/maemo/modest-account-settings-dialog.c:
2099 * src/maemo/modest-account-settings-dialog.h:
2100 * src/maemo/modest-store-widget.c:
2101 * src/maemo/modest-store-widget.h:
2102 * src/maemo/modest-transport-widget.c:
2103 * src/maemo/modest-transport-widget.h:
2104 * src/modest-account-mgr-helpers.c:
2105 * src/modest-account-mgr-helpers.h:
2106 * src/modest-account-mgr.c:
2107 * src/modest-account-mgr.h:
2108 * src/modest-tny-account.c:
2109 * src/modest-tny-folder.c:
2110 * src/widgets/modest-account-view.c:
2111 * src/widgets/modest-retrieve-combo-box.c:
2112 * src/widgets/modest-retrieve-combo-box.h:
2113 * src/widgets/modest-secureauth-combo-box.c:
2114 * src/widgets/modest-serversecurity-combo-box.c:
2115 * src/widgets/modest-serversecurity-combo-box.h:
2116 * tests/check_account-mgr.c:
2117 Use the specific functions, and use the re-renamed enum values for GNOME too.
2119 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2121 * src/modest-pair.h:
2122 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2123 so we can get the second based on the first.
2125 * src/maemo/modest-account-settings-dialog.h:
2126 * src/maemo/modest-account-settings-dialog.c:
2127 Added get_supported_secure_authentication_methods(), though it is mostly
2128 commented-out for now until the necessary API is committed to tinymail.
2129 (modest_account_settings_dialog_set_account_name),
2130 (save_configuration): Request the supported authentication methods from the
2131 server, so we can choose a working method.
2133 * src/modest-tny-account-store.h:
2134 * src/modest-tny-account-store.c:
2135 (modest_tny_account_store_get_session): Rename from
2136 tny_account_store_get_session().
2138 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-protocol-info.h: Split the ModestProtocol enum
2141 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2142 There was no need to have these unrelated values in one enum.
2144 * src/: many files: Adapted to changed enum. This makes the code a bit
2145 clearer, and the compiler could catch some errors.
2147 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2149 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2150 Show the detailed internal camel error message when an error happens
2151 during the configuration, so that our testers can give us more clues.
2152 For instance, in projects.maemo.org bug NB#56910 .
2154 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2156 * src/modest-tny-account.c:
2157 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2158 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2160 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2162 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2163 * src/maemo/modest-account-settings-dialog.c:
2164 (modest_account_settings_dialog_set_account_name),
2165 (save_configuration): For the incoming secure authentication checkbox,
2166 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2167 the UI specification. PLAIN does not seem to be supported for most IMAP
2168 servers anyway, and I am not sure what it would mean.
2169 However, we probably need to discover which of the secure-authentication
2170 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2171 * src/modest-account-mgr-helpers.c:
2172 (modest_account_mgr_get_server_account_data):
2174 * src/modest-tny-account.c:
2175 (modest_tny_account_new_from_server_account):
2176 Use tny_account_set_mech() to set secure-authentication methods,
2177 with some special-casing for IMAP, based on my observations of how
2180 * src/modest-account-mgr-helpers.h:
2181 * src/modest-account-mgr.c:
2182 * src/modest-defs.h: Comment that the URI is only used for local folders.
2184 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2187 parameter const, just to be neat.
2188 * src/modest-text-utils.c: (modest_text_utils_inline):
2189 End g_strconcat() with NULL, as its documentation says. This is almost
2190 certainly the cause of my crash at startup on the device. Interestingly,
2191 valgrind doesn't tell us about these errors.
2193 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2195 * scripts/build-packages: Added more precise comments about how to use
2196 this script, though I still get this error:
2197 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2198 error building tinymail
2200 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2202 * src/maemo/modest-main-window.c: (on_account_update):
2203 Very slight cleanup, hoping to make it simpler to discover what causes
2204 a crash here sometimes.
2206 * src/modest-tny-account.c:
2207 (modest_tny_account_new_from_server_account): Set the port. Added
2208 comments about the options and a TODO comment because I need to find out
2209 how to specify the secure authentication method.
2211 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2213 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2214 changed CFlags paths form modest to libmodest
2216 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2218 * src/modest-account-mgr-helpers.c:
2219 (modest_account_mgr_get_server_account_data),
2220 (modest_account_mgr_free_server_account_data):
2221 * src/modest-account-mgr-helpers.h:
2222 * src/modest-account-mgr.c:
2223 (modest_account_mgr_add_server_account):
2224 * src/modest-defs.h:
2225 * src/modest-tny-account.c:
2226 (modest_tny_account_new_from_server_account):
2227 Determine the options for tny_camel_account_add_option() here,
2228 based on the settings, rather than storing them directly in gconf.
2230 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2232 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2233 Show a more friendly error dialog now that we expect (from the tinymail
2234 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2236 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2238 * src/maemo/modest-main-window.c: (on_account_update): Check that
2239 account_name is not NULL, to prevent a crash at startup that I am
2240 seeing on the N800. I do wonder why it is NULL.
2242 * src/maemo/easysetup/modest-easysetup-wizard.c:
2243 (create_page_user_details):
2244 * src/maemo/modest-account-settings-dialog.c:
2245 (create_page_user_details), (create_page_outgoing):
2246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2247 (modest_connection_specific_smtp_edit_window_init):
2248 * src/modest-ui-actions.c:
2249 (modest_ui_actions_on_password_requested):
2250 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2251 might do something useful with the on-screen keyboard.
2253 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2255 * src/maemo/modest-main-window.c: (on_account_update):
2256 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2257 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2259 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2261 * src/modest-tny-account-store.c: (on_account_changed):
2262 Correct the signature of this signal handler.
2264 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2267 Show a HildonNote instead of a GtkDialog for Maemo.
2269 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2271 * src/widgets/modest-account-view.h:
2272 * src/widgets/modest-account-view.c: (on_account_changed),
2273 (on_account_removed). Added a boolean flag, set/unset by
2274 modest_account_view_block_conf_updates(),
2275 modest_account_view_unblock_conf_updates() to prevent unnecessary
2276 updates, but this is not very useful because the gconf notifications are
2277 so delays (maybe only on Maemo Bora).
2278 So auto-updating is turned off, and these functions do an explicit
2279 update when necessary.
2280 However, something else is still doing too much work when adding/removing
2281 accounts, probably in another part of the application.
2283 * src/maemo/modest-account-view-window.c:
2284 (on_delete_button_clicked), (on_edit_button_clicked),
2285 (on_new_button_clicked): Use the new functions.
2287 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-account-mgr-helpers.c:
2290 (modest_account_mgr_set_first_account_as_default):
2291 Sort the list of names alphabetically-by-title, so we choose the first one
2293 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2294 alphabetically by the title.
2296 This fixes projects.maemo.org bug NB#56418 .
2298 * src/modest-account-mgr-priv.c:
2299 (_modest_account_mgr_account_from_key):
2300 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2301 avoid a valgrind error, and possible random behaviour.
2303 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2305 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2306 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2307 tinymail documentation to say that this can be expected.
2308 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2309 pretty, and should not happen, but I would prefer to know when it does.
2311 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2313 * configure.ac: When using the older hildon version, probably on Bora,
2314 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2316 * src/widgets/modest-attachment-view.c:
2317 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2320 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2322 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2323 Implemented the prototype. Can be tested with
2324 tests/dbus_api/test_open_message:
2326 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2328 * src/modest-tny-account-store.c:
2329 (modest_tny_account_store_instance_init), (get_password):
2330 * src/modest-ui-actions.c:
2331 (modest_ui_actions_on_password_requested):
2332 Do not store the password in gconf, because this function is called
2333 for non-remembered passwords. Actually use the cached (in the hash map)
2334 password instead of releasing it.
2335 The password will now not be remembered if it is asked via the protected
2336 password dialog, as per the UI spec.
2338 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2340 * src/modest-defs.h:
2341 * src/modest-account-mgr-helpers.h:
2342 * src/modest-account-mgr-helpers.c:
2343 Added modest_server_account_get_username_has_succeeded(),
2344 modest_server_account_set_username_has_succeeded().
2345 (modest_server_account_set_username),
2346 Reset the has-succeeded flag if the username changes.
2348 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2349 * src/maemo/modest-connection-specific-smtp-window.c:
2350 (modest_connection_specific_smtp_window_save_server_accounts):
2351 Use modest_server_account_set_username() instead of using
2352 modest_conf_set_string() directly, so that the has-succeeded flag is always
2355 * src/modest-ui-actions.c:
2356 (modest_ui_actions_on_password_requested): Dim the username entry if
2357 the username has ever worked, as per the UI spec.
2359 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2361 * src/modest-tny-account-store.c: (get_password):
2362 * src/modest-ui-actions.c:
2363 (modest_ui_actions_on_password_requested):
2364 Allow the username to be changed too, though there is more work to
2365 be done on exactly how this behaves.
2367 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2369 * src/modest-account-mgr-helpers.h:
2370 * src/modest-account-mgr-helpers.c:
2371 Added modest_account_mgr_get_display_name(),
2372 modest_server_account_get_username(),
2373 modest_server_account_set_username(),
2374 modest_server_account_set_password(),
2375 modest_server_account_get_hostname() functions so we do not need to
2376 use the conf API directly.
2378 * src/maemo/modest-main-window.c: (connect_signals):
2379 Actually connect ot the ModestAccountStore::request-password signal,
2380 so that we show the dialog when the password is requested by Tinymail,
2381 for isntance if it is empty.
2383 * src/modest-marshal.list:
2384 * src/modest-tny-account-store.c:
2385 (modest_tny_account_store_class_init), (get_password),
2386 (modest_tny_account_store_alert):
2387 * src/modest-tny-account-store.h:
2388 * src/modest-ui-actions.h:
2389 * src/modest-ui-actions.c:
2390 (modest_ui_actions_on_password_requested):
2391 Change the signal parameters, so it is obvious that we are providing
2392 the non human-readable server name, and receiving both the username
2393 and password, though changing of the username is not yet implemented.
2394 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2395 for the GNOME version.
2397 This should fix the projects.maemo.org bug NB#56209, though it does not
2398 work on Bora, because the gconf_client_get() for the password fails
2399 immediately after we save it with gconf_client_set().
2401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2404 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2405 caused an undefined symbol error:
2406 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2408 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2410 * src/modest-tny-account-store.c:
2411 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2412 using a GError instead of a string message, so we can translate it in
2415 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2417 * src/maemo/modest-address-book.c:
2418 (modest_address_book_check_names):
2419 * src/maemo/modest-msg-view-window.c:
2420 (modest_msg_view_window_clipboard_owner_change):
2421 * src/modest-init.c: (modest_init_init_ui):
2422 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2423 (update_folders_cb), (modest_mail_operation_update_account):
2424 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2425 (modest_ui_actions_on_msg_attachment_clicked),
2426 (modest_ui_actions_on_msg_recpt_activated):
2427 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2428 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2429 (modest_msg_view_search_next):
2430 * src/widgets/modest-recpt-editor.c:
2431 (modest_recpt_editor_on_button_release_event),
2432 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2433 g_message(). At this point we should only be seeing interesting errors on
2434 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2436 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2438 (modest_wizard_dialog_force_title_update):
2439 * src/maemo/easysetup/modest-wizard-dialog.h:
2440 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2441 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2442 can update the title when appropriate. Otherwise the title is wrong if the
2443 pages are added after adding the notebook to the dialog.
2444 This must be a problem in HildonWizardDialog too.
2445 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2447 * src/maemo/easysetup/modest-easysetup-wizard.c:
2448 (create_subsequent_customsetup_pages),
2449 (create_subsequent_easysetup_pages):
2450 Call modest_wizard_dialog_force_title_update() so that the title is
2451 correct even with GTK+ < 2.10.
2452 This fixes projects.maemo.org bug NB#56145 .
2454 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2456 * src/maemo/modest-platform.c:
2457 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2458 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2461 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2463 * src/widgets/modest-window.h:
2464 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2465 and modest_window_save_state(), which invokes it.
2467 * src/widgets/modest-window-mgr.h:
2468 * src/widgets/modest-window-mgr.c:
2469 Added modest_window_mgr_save_state_for_all_windows(), which calls
2470 the save_state vfunc on all registered windows, if implemented.
2472 * src/gnome/modest-msg-edit-window.c:
2473 * src/gnome/modest-msg-view-window.c:
2474 * src/maemo/modest-msg-edit-window.c:
2475 * src/maemo/modest-msg-view-window.c:
2476 * src/maemo/modest-main-window.c:
2477 Specify the existing save_settings functions as implementations of
2478 ModestWindow::save_state_func().
2480 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2481 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2482 enabling hibernation, for instance.
2484 We may need to do the same thing for restoring settings.
2487 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2489 * src/widgets/modest-window-mgr.c:
2490 * src/widgets/modest-window-mgr.h:
2491 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2492 modest_window_mgr_get_hibernation_is_prevented().
2494 * src/maemo/modest-main-window.c:
2495 (on_hildon_program_is_topmost_notify): Prevent hibernation
2496 (possible when the application goes to the background in the WM),
2497 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2499 * src/maemo/easysetup/modest-easysetup-wizard.c:
2500 (modest_easysetup_wizard_dialog_init):
2501 * src/maemo/modest-account-settings-dialog.c:
2502 (modest_account_settings_dialog_init):
2503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2504 (modest_connection_specific_smtp_edit_window_init):
2505 * src/maemo/modest-connection-specific-smtp-window.c:
2506 (modest_connection_specific_smtp_window_init):
2507 * src/maemo/modest-signature-editor-dialog.c:
2508 (modest_signature_editor_dialog_init):
2509 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2510 prevent hibernation while any of these account settings dialogs are open.
2512 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2514 * src/maemo/Makefile.am:
2515 * src/maemo/modest-osso-state-saving.c:
2516 * src/maemo/modest-osso-state-saving.h: Added
2517 modest_osso_load_state() and modest_osso_save_state() though they do
2518 nothing now. They should iterate through all the open windows and load/save
2520 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2521 save state when closing.
2523 * src/maemo/modest-main-window.c:
2524 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2525 Add a notification handler for the HildonProgram::is-topmost property,
2526 so we can allow hibernation when the application goes into the background.
2527 But we still need to detect when the accounts setup windows are open so
2528 we can stop hibernation when they are open.
2529 To do this, I also added the main window the HildonProgram. This might have
2530 other side-effects/benefits, and should maybe be done for other windows.
2532 * src/maemo/modest-osso-autosave-callbacks.h:
2533 * src/maemo/modest-osso-autosave-callbacks.c:
2534 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2535 though it does not do anything yet, and we might never need this to do
2536 anything. For instance, we already save drafts.
2538 * src/maemo/modest-platform.c: (modest_platform_init):
2539 Specify the libosso auto-save callback.
2541 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/modest-platform.c:
2544 (modest_platform_set_update_interval):
2545 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2546 aparently stays valid between application instances, so we can use this
2547 to remove and reset it later. According to a maemo-developers email from
2550 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2552 * configure.ac: Depend on libalarm for Maemo.
2554 * src/dbus_api/modest-dbus-api.h:
2555 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2556 (on_send_receive), (modest_dbus_req_handler):
2557 Handle a SEND_RECEIVE D-Bus method.
2559 * libmodest-dbus-client/libmodest-dbus-client.c:
2560 (libmodest_dbus_client_send_and_receive):
2561 * libmodest-dbus-client/libmodest-dbus-client.h:
2562 Add C convenience functions for calling the new D-Bus method.
2564 * src/modest-platform.h:
2565 * src/gnome/modest-platform.c:
2566 * src/maemo/modest-platform.c:
2567 Added modest_platform_set_update_interval(), which uses the
2568 alarmd API on Maemo.
2569 (modest_platform_init),
2570 Call modest_platform_set_update_interval(), using a hard-coded
2571 interval for now (until the global settings dialog is implemented),
2572 though I am not sure that this makes sense yet.
2574 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2576 * src/dbus_api/modest-dbus-callbacks.c:
2577 (modest_osso_cb_hw_state_handler):
2578 * src/dbus_api/modest-dbus-callbacks.h:
2579 * src/maemo/modest-platform.c: (modest_platform_init):
2580 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2581 in case this has some effect on the ability for Maemo to ping the
2584 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2587 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2588 warning. It is probably a logic error, but I need to fix the build.
2590 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2592 * src/modest-account-mgr.h:
2593 * src/modest-account-mgr.c:
2594 (modest_account_mgr_account_names): Add a gboolean enabled_only
2595 parameter, so we can get lists of onlt the enabled accounts.
2597 (modest_account_mgr_add_account),,
2598 (modest_account_mgr_account_with_display_name_exists):
2599 * src/maemo/modest-msg-edit-window.c: (get_transports):
2600 * src/modest-account-mgr-helpers.c:
2601 (modest_account_mgr_set_first_account_as_default):
2602 * src/modest-init.c: (init_default_account_maybe):
2603 * src/modest-tny-account-store.c: (get_accounts):
2604 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2605 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2606 * tests/check_account-mgr.c: (START_TEST):
2607 Provide the extra parameter, as appropriate.
2609 * src/widgets/modest-account-view.c: (update_account_view):
2610 Do not show disabled accounts (meaning that there is no way to
2611 enable/disable accounts in the UI (the feature is not in our UI
2612 specification), so we can use this internally only to mark unfinished
2613 or temporary account data.
2615 * src/maemo/easysetup/modest-easysetup-wizard.c:
2616 (create_account): Add boolean enable parameter, so we can specify FALSE
2617 to create the temporary account.
2618 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2619 (on_before_next): When finishing, when there is a temporary account, just
2621 Also, use a timeout to delay the showing of the dialog until gconf is likely
2622 to return correct information, due to a maemo gconf bug that is fixed in
2623 osso 1.1, but not yet in Bora.
2624 However, the dialog stays on screen after it is destroyed.
2626 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2627 for invalid data when cancelling. Use a hildon note instead of a dialog
2628 to complain about invalid data. Do not show the account-saved note if the
2629 account is disabled (a temporary account that will not really be saved for use
2632 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2634 * src/modest-account-mgr-helpers.h:
2635 * src/modest-account-mgr-helpers.c:
2636 Added modest_account_mgr_unset_default_account(),
2637 Added modest_account_mgr_set_first_account_as_default().
2639 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2640 If it was the default account, unset the default account name.
2642 * src/maemo/modest-account-view-window.c:
2643 (on_delete_button_clicked): If it was the default account,
2644 set the first remaining account as the default instead.
2646 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2647 a NULL account or a NULL default account, to prevent a crash. This should
2648 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2651 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2653 * src/widgets/modest-recpt-editor.c:
2654 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2655 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2656 TODO comment for this. This fixes the build.
2658 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2659 be the best place for it. This will in future update all auto-update accounts,
2660 rather than just the current/default account, when that gconf key exists.
2661 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2662 if there are no accounts, before calling do_send_receive().
2663 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2665 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2666 * src/maemo/modest-main-window-ui.h:
2667 * src/maemo/modest-main-window.c: (on_connection_changed),
2668 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2669 directly, becaue the signal handler does more.
2671 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2673 * src/modest-account-mgr-helpers.c:
2674 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2675 for the case that the account does not exist.
2677 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2678 (equivalent to the modest account name) rather than the tinymail account name
2679 (equivalent to the modest account title - human readable) to get the account data.
2680 Check for null account data to prevent the crash, and add a TODO comment saying that
2681 this needs fixing because it is using the server account name instead of the account name.
2683 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2686 * src/maemo/modest-account-settings-dialog.c: (show_error),
2688 Use hildon_note_new_information() for informative and error messages,
2689 which seems to be expected for Maemo applications (no documentation that I know of
2690 says this). I am surprised that there is no distinction between info and error
2693 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2695 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2696 it is easy to find where this is used.
2698 * src/maemo/easysetup/modest-easysetup-wizard.c:
2699 (create_page_welcome), (create_page_account_details),
2700 (create_page_user_details), (create_page_complete_easysetup),
2701 (create_page_custom_incoming), (create_page_custom_outgoing),
2702 (create_page_complete_custom):
2703 * src/maemo/modest-account-settings-dialog.c:
2704 (create_page_account_details), (create_page_user_details),
2705 (create_page_incoming), (create_page_outgoing):
2706 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2707 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2708 (modest_connection_specific_smtp_edit_window_init):
2709 * src/maemo/modest-connection-specific-smtp-window.c:
2710 (modest_connection_specific_smtp_window_init):
2711 * src/maemo/modest-signature-editor-dialog.c:
2712 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2713 and scrolling policy as per the Email Application Layout Guide, if I have
2716 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2718 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2719 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2720 which were empty, because these vfuncs have been removed from TnyAccountStore.
2721 This fixes the build.
2723 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/modest-main-window.c:
2726 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2727 showing/hiding it. Added TODO because it probably should not be NULL.
2728 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2729 because unnecessary g_warnings() make degugging difficult.
2731 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2733 * src/maemo/modest-msg-edit-window.c:
2734 (modest_msg_edit_window_select_color),
2735 (modest_msg_edit_window_select_background_color): 2 const corrections and
2736 moving 2 #endifs before closing brackets, to fix the build.
2738 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/easysetup/modest-easysetup-wizard.h:
2741 * src/maemo/easysetup/modest-easysetup-wizard.c:
2742 (modest_easysetup_wizard_dialog_finalize),
2743 (on_button_edit_advanced_settings), (create_page_complete_custom),
2744 (on_response), (create_account):
2745 Implement the Advanced Settings edit button, by saving the account information,
2746 for the Advanded Settings dialog to use directly from gconf, and removing it
2747 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2748 Bug #5533 in the projects.maemo.org bugzilla.
2750 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/modest-msg-view-window.c:
2753 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2754 when opening a message window.
2756 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2758 * src/maemo/easysetup/modest-easysetup-wizard.c:
2759 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2762 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2763 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2764 gconf settings. I probably added more checks than necessary, but that is safer.
2766 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2767 variable to fix the build, but this seems to be used when it is still NULL.
2769 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-platform.h:
2772 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2773 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2774 * src/modest-main.c: Implement this function so we can avoid using
2775 maemo-specific API from cross-platform code.
2777 * src/modest-tny-account-store.c:
2778 (get_smtp_specific_transport_account_for_open_connection):
2779 * src/modest-ui-actions.c: (check_for_connection),
2780 (modest_ui_actions_on_item_not_found):
2781 Use modest_platform_connect_and_wait() and put #idefs around other
2782 maemo-specific code, because only maemo currently has a way to
2783 identify connection names.
2785 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2787 * src/modest-tny-account-store.h:
2788 * src/modest-tny-account-store.c:
2789 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2790 the connection-specific SMTP server settings in the configuration.
2792 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2794 * src/maemo/modest-main-window.c: (on_connection_changed),
2796 * src/modest-main.c: (main), (start_ui), (send_mail):
2797 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2798 that is what is intended.
2800 * src/modest-ui-actions.c: (action_send), (action_receive),
2801 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2802 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2803 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2804 SMTP server is used when it is specified.
2806 (modest_ui_actions_on_send_receive):
2807 Check that a connection is open before proceeding.
2808 Receive and then send, instead of vice-versa, as per the specification.
2810 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2812 * src/modest-mail-operation.c:
2813 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2814 though I guess it should be something other than NULL.
2816 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2818 * src/maemo/easysetup/modest-easysetup-wizard.c:
2819 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2820 combo twice, to avoid an g_warning and to make it visible again.
2821 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2822 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2823 (already intended) dereference when detaching, because we then recreate the menu.
2824 But I am not sure why the warning was happening, and it is possible that this is a memory
2827 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2829 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2830 and uri_parse_mailto() utility functions.
2831 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2833 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2835 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2837 * src/dbus_api/modest-dbus-api.h:
2838 * src/dbus_api/modest-dbus-callbacks.c:
2839 Use an idle callback to execute the modest code in the application's own thread.
2840 Remove the helloworld example method.
2841 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2842 parsed, and the open-message method is not implemented because this is not yet implemented in
2844 * libmodest-dbus-client/libmodest-dbus-client.c:
2845 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2846 (libmodest_dbus_client_open_message):
2847 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2849 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2850 body without crashing.
2852 * tests/dbus_api/Makefile.am:
2853 * tests/dbus_api/test_mail_to.c:
2854 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2856 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2858 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2859 Added file to fix the build. Sorry.
2861 * src/dbus_api/Makefile.am:
2862 * src/dbus_api/modest-dbus-api.h:
2863 * src/dbus_api/modest-dbus-callbacks.h:
2864 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2865 (modest_dbus_req_handler):
2866 Put constants in a separate header so it can be reused by the
2867 client library, without duplication
2869 * libmodest-dbus-client/Makefile.am:
2870 * libmodest-dbus-client/libmodest-dbus-client.c:
2871 (libmodest_dbus_client_call_helloworld),
2872 (libmodfest_dbus_client_send_mail),
2873 (libmodfest_dbus_client_mailto),
2874 (libmodfest_dbus_client_open_message):
2875 * libmodest-dbus-client/libmodest-dbus-client.h:
2876 (Partly) Implement a send_mail D-Bus method.
2878 * tests/dbus_api/Makefile.am:
2879 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2880 the send_email D-Bus method.
2882 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2886 * libmodest-dbus-client/Makefile.am:
2887 * libmodest-dbus-client/libmodest-dbus-client.c:
2888 * libmodest-dbus-client/libmodest-dbus-client.h:
2889 * tests/dbus_api/Makefile.am:
2890 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2891 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2893 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/easysetup/modest-easysetup-wizard.c:
2896 (create_page_account_details):
2897 * src/maemo/modest-account-settings-dialog.c:
2898 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2899 widgets, because this might not be the default in future versions of the Maemo GTK+.
2900 However, I can not not get capitalization to work even in a simple test case.
2902 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2904 * src/maemo/easysetup/modest-easysetup-wizard.c:
2905 (create_page_custom_incoming), (create_page_custom_outgoing):
2906 * src/maemo/modest-account-settings-dialog.c:
2907 (create_page_account_details), (create_page_incoming),
2908 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2909 instead of using gtk_check_button_with_label(), so they are aligned like the other
2910 widgets, as per the UI spec.
2912 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2914 * src/maemo/easysetup/modest-easysetup-wizard.c:
2915 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2916 * src/widgets/modest-validating-entry.c:
2917 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2918 Modest prefix instead of an EasySetup prefix.
2920 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2922 * src/widgets/modest-validating-entry.h:
2923 * src/widgets/modest-validating-entry.c: (on_insert_text),
2924 Added easysetup_validating_entry_set_max_func(), used to set a callback
2925 to call when the max number of characters is reached. GtkEntry has a max-length
2926 already but is silent about it.
2928 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2929 (create_page_account_details), (create_page_user_details),
2931 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2932 (create_page_account_details), (create_page_user_details),
2933 (create_page_outgoing):
2934 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2935 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2936 the UI spec, when the user tries to enter more than the max number of characters.
2938 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2940 * src/maemo/easysetup/modest-easysetup-wizard.c:
2941 (create_page_user_details), (create_page_custom_incoming),
2942 (create_page_custom_outgoing):
2943 * src/maemo/modest-account-settings-dialog.c:
2944 (create_page_user_details), (create_page_incoming),
2945 (create_page_outgoing):
2946 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2947 (modest_connection_specific_smtp_edit_window_init):
2948 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2949 not appropriate. Bad Maemo-specific defaults!.
2951 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2953 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2954 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2955 (modest_signature_editor_dialog_set_settings):
2956 Disable the label and textview when the checkbox is disabled, and use the
2957 specified (UI spec) default signature text.
2959 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2961 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2962 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2964 * src/modest-defs.h:
2965 * src/modest-account-mgr-helpers.h:
2966 * src/modest-account-mgr-helpers.c:
2967 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2969 * src/maemo/Makefile.am:
2970 * src/maemo/modest-signature-editor-dialog.c:
2971 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2974 * src/maemo/modest-account-settings-dialog.h:
2975 * src/maemo/modest-account-settings-dialog.c:
2976 (modest_account_settings_dialog_finalize), (on_button_signature),
2977 (save_configuration): Use the new dialog when the Edit button is pressed, and
2978 save the changes if necessary, as per the UI spec.
2980 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/Makefile.am:
2983 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2984 based on maemo-develoers email from Dirk.
2986 * src/maemo/easysetup/modest-easysetup-wizard.c:
2987 (create_page_welcome), (create_page_account_details),
2988 (create_page_user_details), (create_page_complete_easysetup),
2989 (create_page_custom_incoming), (create_page_custom_outgoing),
2990 (create_page_complete_custom),
2991 (modest_easysetup_wizard_dialog_init):
2992 * src/maemo/modest-account-settings-dialog.c:
2993 (create_page_account_details), (create_page_user_details),
2994 (create_page_incoming), (create_page_outgoing),
2995 (modest_account_settings_dialog_init):
2996 * src/maemo/modest-connection-specific-smtp-window.c:
2997 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2999 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/easysetup/modest-easysetup-wizard.c:
3002 (create_page_account_details), (create_page_custom_outgoing),
3003 (create_page_complete_custom):
3004 * src/maemo/modest-account-settings-dialog.c:
3005 (create_page_user_details), (create_page_incoming),
3006 (create_page_outgoing):
3007 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3008 (modest_connection_specific_smtp_edit_window_init):
3009 Use the correct (UI spec) port min/max, and use horizontal separators,
3012 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3014 * src/maemo/easysetup/modest-easysetup-wizard.c:
3015 (set_default_custom_servernames):
3016 * src/maemo/modest-account-settings-dialog.c:
3017 (create_page_incoming), (on_combo_outgoing_security_changed),
3018 (on_combo_incoming_security_changed), (create_page_outgoing),
3019 (modest_account_settings_dialog_set_account_name),
3020 (save_configuration):
3021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3022 (on_combo_security_changed),
3023 (modest_connection_specific_smtp_edit_window_init),
3024 (modest_connection_specific_smtp_edit_window_set_connection),
3025 (modest_connection_specific_smtp_edit_window_get_settings):
3026 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3029 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3032 * src/maemo/easysetup/modest-easysetup-wizard.c:
3033 (create_page_custom_outgoing), (create_page_complete_custom):
3034 * src/maemo/modest-account-settings-dialog.c:
3035 (create_page_user_details), (create_page_outgoing):
3036 * src/maemo/modest-account-view-window.c: (button_box_new):
3037 Use changed logical IDs as per the most recent UI spec:
3038 mcen_bd_emailsetup_edit -> mcen_bd_edit
3039 mcen_bd_emailsetup_delete -> mcen_bd_delete
3040 mcen_bd_emailsetup_close -> mcen_bd_close
3042 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3046 * src/dbus_api/Makefile.am:
3047 * src/dbus_api/modest-dbus-callbacks.c:
3048 * src/dbus_api/modest-dbus-callbacks.h:
3049 * src/maemo/modest-platform.c: (modest_platform_init):
3050 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3052 * tests/Makefile.am:
3053 * tests/dbus_api/Makefile.am:
3054 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3056 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3058 * src/maemo/modest-account-settings-dialog.c:
3059 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3060 Removed unnecessary includes.
3062 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3064 * src/maemo/easysetup/modest-easysetup-wizard.c:
3065 * src/maemo/modest-account-settings-dialog.c:
3066 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3067 * src/widgets/Makefile.am:
3068 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3069 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3070 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3071 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3072 * src/widgets/modest-secureauth-combo-box.c:
3073 * src/widgets/modest-secureauth-combo-box.h:
3074 * src/widgets/modest-serversecurity-combo-box.c:
3075 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3076 made the GObject names more consistent with the rest of the Modest code.
3078 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/easysetup/Makefile.am:
3081 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3082 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3083 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3084 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3085 * src/maemo/easysetup/modest-easysetup-wizard.c:
3086 * src/maemo/easysetup/modest-validating-entry.c:
3087 * src/maemo/easysetup/modest-validating-entry.h:
3088 * src/maemo/modest-account-settings-dialog.c:
3089 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3090 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3091 widgets/ because they are used outside of easysetup too. After checking in,
3092 svn will allow me to rename them too.
3094 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3096 * src/gnome/modest-msg-edit-window.c:
3097 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3098 linker error, to fix the build on the GNOME platform.
3099 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3100 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3101 ifdefed out to avoid a warning.
3103 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3105 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3106 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3107 some alternative for GTK+ 2.6.
3109 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3111 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3113 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3114 specified for EmailAccountsDialog in UI spec.
3116 * src/maemo/easysetup/modest-easysetup-wizard.c:
3117 * src/maemo/easysetup/modest-easysetup-wizard.h:
3118 * src/maemo/modest-account-settings-dialog.c:
3119 * src/maemo/modest-account-settings-dialog.h:
3120 Reuse a member window widget for the connection-specific SMTP server accounts,
3121 so we can tell it to create/save the accounts only if we actually save changes.
3123 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3125 (modest_connection_specific_smtp_edit_window_get_settings):
3126 Return a struct instance for temporarily remembering the entered data.
3128 * src/maemo/modest-connection-specific-smtp-window.h:
3129 * src/maemo/modest-connection-specific-smtp-window.c:
3130 (modest_connection_specific_smtp_window_finalize),
3131 (modest_connection_specific_smtp_window_fill_with_connections),
3133 (modest_connection_specific_smtp_window_save_server_accounts),
3134 (update_model_server_names): Do not actually save data until asked,
3135 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3137 (on_selection_changed),
3138 (modest_connection_specific_smtp_window_init): Disable the edit
3139 button when nothing is selected.
3141 * src/modest-account-mgr-helpers.c:
3142 * src/modest-account-mgr-helpers.h:
3143 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3146 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-account-mgr-helpers.h:
3149 * src/modest-account-mgr-helpers.c:
3150 (modest_account_mgr_get_unused_account_name),
3151 (modest_account_mgr_get_unused_account_display_name): Added these
3152 utility functions, to avoid code duplication.
3154 * src/maemo/easysetup/modest-easysetup-wizard.c:
3155 (create_page_account_details), (create_account):
3156 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3157 (on_combo_security_changed),
3158 (modest_connection_specific_smtp_edit_window_init),
3159 (modest_connection_specific_smtp_edit_window_save_settings):
3160 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3161 * src/maemo/modest-connection-specific-smtp-window.c:
3162 (modest_connection_specific_smtp_window_finalize),
3163 (modest_connection_specific_smtp_window_fill_with_connections),
3164 (on_button_edit), (modest_connection_specific_smtp_window_init):
3165 * src/maemo/modest-connection-specific-smtp-window.h:
3166 Implementing saving of connection-specific server accounts.
3168 But I need to refactor this so we can save the data for each
3169 possible connection-specific account and only actually create the server accounts
3170 when the easysetup finished, or the OK button is pressed on the account settings
3173 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3176 (on_combo_security_changed):
3177 (modest_connection_specific_smtp_edit_window_init):
3178 Auto-fill the port number as in the account settings.
3180 (modest_connection_specific_smtp_edit_window_set_connection):
3181 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3182 * src/maemo/modest-connection-specific-smtp-window.c:
3183 (fill_with_connections), (on_button_edit),
3184 (modest_connection_specific_smtp_window_init):
3185 Turn the edit window into a dialog to simplify the code, and
3186 set a WM hint as in a GtkDialog, because only a popup can be on top of
3187 another window in Maemo, and popups usually have no WM decoration.
3189 * src/modest-defs.h:
3190 * src/modest-account-mgr-helpers.c:
3191 (modest_account_mgr_set_connection_specific_smtp),
3192 (modest_account_mgr_remove_connection_specific_smtp),
3193 (modest_account_mgr_get_connection_specific_smtp):
3194 * src/modest-account-mgr-helpers.h: Some functions to write the
3195 connection-specific SMTP server information. Not yet used.
3198 * src/widgets/modest-folder-view.c: (text_cell_data):
3199 Fix a warning about an uninitialized variable.
3200 (on_configuration_key_changed): Put an #ifdef around the use
3201 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3203 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/modest-account-settings-dialog.h:
3206 * src/maemo/modest-account-settings-dialog.c:
3207 Added connect_for_modified() utility function to mark the new modified boolean.
3209 (create_page_account_details), (create_page_user_details),
3210 (create_page_incoming), (create_page_outgoing), (on_response),
3211 (modest_account_settings_dialog_init),
3212 (modest_account_settings_dialog_set_account_name):
3213 Only warn about unsaved changes when there are actually unsaved changes.
3215 * src/modest-account-mgr-helpers.c:
3216 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3217 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3218 to get the data from there in future.
3220 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3222 * src/modest-defs.h:
3224 * src/modest-account-mgr-helpers.h:
3225 * src/modest-account-mgr-helpers.c:
3226 Store the security account setting in a single conf key instead of using
3227 the options list, so that the list is left for just the to-be-removed camel hack,
3228 and because gconf_client_set_list() is failing for some reason.
3230 * src/modest-account-mgr.c:
3231 (modest_account_mgr_add_server_account):
3232 * src/maemo/modest-account-settings-dialog.c:
3233 (modest_account_settings_dialog_set_account_name),
3234 (save_configuration): Use the renamed functions.
3237 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3239 * src/widgets/Makefile.am:
3240 * src/widgets/modest-limit-retrieve-combo-box.c:
3241 * src/widgets/modest-limit-retrieve-combo-box.h:
3242 * src/widgets/modest-retrieve-combo-box.c:
3243 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3244 the account settings dialog.
3246 * src/modest-defs.h:
3247 * src/modest-account-mgr-helpers.h:
3248 * src/modest-account-mgr-helpers.c:
3249 (modest_server_account_get_option_secure_auth),
3250 (modest_server_account_set_option_secure_auth):
3251 * src/modest-account-mgr.c:
3252 (modest_account_mgr_add_server_account):
3253 Use the existing AUTH_MECH conf key for the secure-auth setting,
3254 instead of putting it in the list options, because this was actually used already.
3256 * src/maemo/modest-account-settings-dialog.c:
3257 (create_page_account_details),
3258 (modest_account_settings_dialog_set_account_name),
3259 (save_configuration):
3260 * src/maemo/modest-account-settings-dialog.h:
3261 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3262 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3264 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3267 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3268 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3270 * src/modest-defs.h:
3271 * src/maemo/modest-account-settings-dialog.c:
3272 (create_page_incoming), (on_combo_outgoing_security_changed),
3273 (on_combo_incoming_security_changed), (create_page_outgoing),
3274 (modest_account_settings_dialog_set_account_name),
3275 (save_configuration): Load/Save the port number, and change it when the
3276 security combo changes, to suitable defaults.
3278 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-account-mgr.c:
3281 (modest_account_mgr_add_server_account): Set the security and secure-auth
3282 options, and add a comment saying that the other camel-specific options should be
3285 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3287 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3289 * src/modest-tny-account-store.c: (account_list_free),
3290 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3291 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3294 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3296 * src/modest-protocol-info.c:
3297 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3298 is required by our UI spec. Maybe something in our implementation will use this eventually.
3299 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3300 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3301 instead of the previous 0 placeholder.
3303 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3304 secure-auth settings.
3305 * src/modest-account-mgr-helpers.h:
3306 * src/modest-account-mgr-helpers.c:
3307 (modest_server_account_data_get_option_secure_auth),
3308 (modest_server_account_set_option_secure_auth),
3309 (modest_server_account_data_get_option_security),
3310 (modest_server_account_set_option_security): Added this API for getting and setting the security
3311 and secure-auth settings.
3313 * src/maemo/modest-account-settings-dialog.h:
3314 * src/maemo/modest-account-settings-dialog.c:
3315 (modest_account_settings_dialog_finalize), (check_data),
3316 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3317 about changing titles.
3318 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3319 (save_configuration): Save the security and secure-auth settings.
3321 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3322 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3324 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3326 * src/modest-defs.h:
3327 * src/modest-account-mgr.c:
3328 (modest_account_mgr_add_server_account):
3329 Added and used defines for the options key and value pair strings,
3330 that are used so far, though they do not seem to correspond to anything in our
3331 UI specs or ModestProtocol enum.
3333 * src/modest-account-mgr-helpers.h:
3334 * src/modest-account-mgr-helpers.c:
3335 (compare_option_strings_for_name),
3336 (modest_server_account_data_get_option_value),
3337 (modest_server_account_data_get_option_bool),
3338 (modest_account_mgr_get_server_account_option):
3339 Added helper functions for parsing the options GSList.
3341 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3343 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3344 display name is based on the supplied account name.
3345 * src/modest-account-mgr.c:
3346 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3347 with an inefficient, but good-enough, implementation.
3349 * src/maemo/easysetup/modest-easysetup-wizard.c:
3350 (create_page_account_details), (on_before_next), (create_account):
3351 Check for existing display names rather than (non-user-visible) account names, and just
3352 create and set a unique account name at the end.
3354 * src/maemo/modest-account-settings-dialog.c:
3355 (modest_account_settings_dialog_init),
3356 (modest_account_settings_dialog_set_account_name),
3357 (create_page_incoming): Show the display name, instead of the account name.
3358 (on_response): Do some (not all) extra checks, as in the UI spec.
3359 (save_configuration): Save the display name if it was changed.
3361 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3363 * po/en_GB.po: Added needed logical ID and translation.
3364 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3365 (init_view): Made the is-default column clicking work.
3367 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3370 * src/maemo/easysetup/Makefile.am:
3371 * src/maemo/easysetup/modest-easysetup-wizard.c:
3372 (modest_easysetup_wizard_dialog_init):
3373 * src/maemo/easysetup/provider-data-test.keyfile:
3374 * src/maemo/easysetup/provider-data.keyfile:
3375 Moved the provider data file to the new modest-providers-data package and used it from there.
3377 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3379 * src/modest-local-folder-info.c:
3380 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3381 N_() was already used on the static strings, but this just marks it for translation without
3382 using the translation.
3384 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3386 * src/maemo/modest-account-settings-dialog.c:
3387 (create_page_incoming),
3388 (modest_account_settings_dialog_set_account_name):
3389 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3390 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3391 I will do this if nobody else gets there first.
3393 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3395 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3396 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3397 save the security stuff.
3399 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3401 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3402 Set the email address and user fullname, which I now see must be
3405 * src/maemo/modest-account-settings-dialog.h:
3406 * src/maemo/modest-account-settings-dialog.c:
3408 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3409 leave-on-server and authentication.
3410 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3413 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3416 * src/maemo/modest-account-settings-dialog.c:
3417 * src/maemo/modest-account-settings-dialog.h:
3418 Most (but not all) of the widgets are now present as specified by the UI spec.
3419 No changes are yet saved, and some details are not properly shown yet.
3421 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3423 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/Makefile.am:
3426 * src/maemo/modest-account-settings-dialog.c:
3427 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3428 an existing account. Doesn't do much yet.
3430 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3431 Open the accounts settings dialog when Edit is clicked.
3433 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3435 * src/maemo/easysetup/Makefile.am:
3436 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3438 * src/maemo/easysetup/modest-easysetup-wizard.c:
3439 (modest_easysetup_wizard_dialog_init):
3440 Try to get the source directory from the build system,
3441 instead of hard-coding "./" into the source code, when opening our local
3442 copies of the configuration files.
3443 But this still fails when opening the wizard from the Accounts window,
3444 maybe because the working directory seems to change at runtime.
3445 So the wizard will fail the second time unless you copy the files into their
3446 proper locations - see the stdout warnings for the paths.
3448 (create_page_account_details),(on_before_next):
3449 Check for existing non-server accounts instead of server accounts,
3450 so the default account name is useful again, and to prevent trying to
3453 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3454 Show the wizard when New is clicked.
3456 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3457 (init_view): Show the column headers, and show the columns that are
3458 specified in the UI specs. However, something in Maemo's GTK+ prevents
3459 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3460 change the default account. This is despite unsetting the special properties.
3462 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3464 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3465 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3466 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3467 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3468 to make that clearer.
3469 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3471 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3473 * src/maemo/modest-account-view-window.c:
3474 (modest_account_view_window_init),
3475 (modest_account_view_window_new):
3476 Use the same buttons as specified in the
3477 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3478 the existing widgets, which never had a chance of working.
3479 Put the ModestAccountView treeview in a scrolled window.
3480 Do not repeat the initialization in both _init() and _new().
3482 * src/widgets/modest-account-view.c: (update_account_view):
3483 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3484 this widget and window shows no accounts.
3486 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3488 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3490 * src/maemo/easysetup/modest-easysetup-wizard.c:
3491 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3492 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3493 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3496 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3497 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3498 accounts exist yet, as in the UI spec.
3500 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3502 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/Makefile.am:
3505 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3506 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3507 New window for editing connection-specific smtp details.
3508 Not fully implemented.
3510 * src/maemo/modest-connection-specific-smtp-window.c:
3511 (modest_connection_specific_smtp_window_finalize) :
3512 unref the tree model.
3513 (on_button_edit): Show the edit window.
3515 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3517 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3520 * src/maemo/Makefile.am:
3521 * src/maemo/modest-connection-specific-smtp-window.c:
3522 * src/maemo/modest-connection-specific-smtp-window.h:
3523 New window for showing the list of connections, for connection-specific
3524 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3525 * src/maemo/easysetup/modest-easysetup-wizard.c:
3526 (create_page_custom_outgoing): Show the new window when the button is clicked.
3528 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3530 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3531 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3532 * src/maemo/modest-msg-edit-window.c:
3533 (modest_msg_edit_window_insert_image):
3534 * src/modest-conf.c: (modest_conf_key_escape):
3535 * src/modest-mail-operation.c:
3536 (modest_mail_operation_send_new_mail):
3537 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3538 (modest_ui_actions_on_new_account):
3539 * src/widgets/modest-attachment-view.c: (update_filename_request):
3540 * src/widgets/modest-mail-header-view.c:
3541 Corrected warnings that were breaking the build, by commenting out unused variables,
3542 and a function, and by including a header.
3544 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3546 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3547 so we can #ifdef around platform-specific code when necessary.
3548 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3549 to allow this to build for the GNOME platform too.
3551 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3553 * src/maemo/easysetup/modest-easysetup-wizard.c:
3554 Added util_increment_name() and used it in create_page_account_details()
3555 to make sure that the default account name is always a new name.
3557 (modest_easysetup_wizard_dialog_init),
3558 (set_default_custom_servernames): Some minor memory management fixes.
3560 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3564 * src/modest-runtime.c: (init_i18n): Restored the translation
3565 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3566 are defined in config.h, and the translations are installed.
3568 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3569 is defined for translation.
3571 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3573 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3575 * src/maemo/easysetup/modest-easysetup-wizard.c:
3576 (modest_easysetup_wizard_dialog_init):
3577 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3578 Use realistic paths (though they should use $prefix generically) to the
3579 mcc_mapping and provider-data.keyfile files which might work when they
3580 are installed by the future version of the operator-wizard package,
3581 and then fallback to paths in our source code, with an explanatory
3584 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3588 * src/maemo/Makefile.am:
3589 * src/maemo/easysetup/: Added files from the previously-exernal
3590 osso-modest-easysetup.
3591 * src/maemo/modest-main-window-ui.h:
3592 * src/modest-ui-actions.c:
3593 * src/modest-ui-actions.h:
3594 Added modest_ui_actions_on_new_account() as a signal handler for the
3595 New Account menu item. It shows the easysetup wizard.
3596 * po/en_GB.po: Added additional needed logical IDs and translations.